Page MenuHomePhabricator

dschuff (Derek Schuff)
Yet Another Compiler Compiler

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2013, 9:35 AM (419 w, 12 h)

US-Pacific timezone.

Recent Activity

Fri, Jan 15

dschuff added a reverting change for rG38dfce706f79: [WebAssembly] Add support for table linking to wasm-ld: rG187d771d27ed: Revert "[WebAssembly] Add support for table linking to wasm-ld".
Fri, Jan 15, 3:52 PM
dschuff committed rG187d771d27ed: Revert "[WebAssembly] Add support for table linking to wasm-ld" (authored by dschuff).
Revert "[WebAssembly] Add support for table linking to wasm-ld"
Fri, Jan 15, 3:52 PM
dschuff added a reverting change for rGe9f1ed2306b1: [WebAssembly] MC layer writes table symbols to object files: rGe65b9b04cdef: Revert "[WebAssembly] MC layer writes table symbols to object files".
Fri, Jan 15, 3:52 PM
dschuff added a reverting change for D91870: [WebAssembly] Add support for table linking to wasm-ld: rG187d771d27ed: Revert "[WebAssembly] Add support for table linking to wasm-ld".
Fri, Jan 15, 3:52 PM · Restricted Project
dschuff committed rGe65b9b04cdef: Revert "[WebAssembly] MC layer writes table symbols to object files" (authored by dschuff).
Revert "[WebAssembly] MC layer writes table symbols to object files"
Fri, Jan 15, 3:52 PM
dschuff added a reverting change for D92215: [WebAssembly] MC layer writes table symbols to object files: rGe65b9b04cdef: Revert "[WebAssembly] MC layer writes table symbols to object files".
Fri, Jan 15, 3:52 PM · Restricted Project
dschuff added a comment to D91870: [WebAssembly] Add support for table linking to wasm-ld.

it's funny, since this CL doesn't really modify the export behavior.
I'm going to go ahead and revert it though ("revert first and ask questions later" being the usual LLVM practice), until we can figure out what's happening.

Fri, Jan 15, 3:46 PM · Restricted Project
dschuff added a comment to D91870: [WebAssembly] Add support for table linking to wasm-ld.

This seems to have a bug that we discovered on the emscripten builders where it's exporting the table twice.
The output (from wasm-objdump):

Export[14]:
 - memory[0] -> "memory"
 - table[0] -> "__indirect_function_table"
 - func[3] <__wasm_call_ctors> -> "__wasm_call_ctors"
 - func[5] <main> -> "main"
 - table[0] -> "__indirect_function_table"
 - func[6] <stackSave> -> "stackSave"
 - func[7] <stackRestore> -> "stackRestore"
 - func[8] <stackAlloc> -> "stackAlloc"
 - func[9] <emscripten_stack_init> -> "emscripten_stack_init"
 - func[10] <emscripten_stack_get_free> -> "emscripten_stack_get_free"
 - func[11] <emscripten_stack_get_end> -> "emscripten_stack_get_end"
 - func[12] <saveSetjmp> -> "saveSetjmp"
 - func[13] <testSetjmp> -> "testSetjmp"
 - func[14] <setThrew> -> "setThrew"

I'll see if I can find a more useful reproducer

Fri, Jan 15, 3:42 PM · Restricted Project
dschuff added a comment to D94347: [WebAssembly] locals can now be indirect in DWARF.

Hm, that's a good point, I missed the size bit when reading the spec.
DW_OP_stack_value seems to be just sort of the generic terminator; i'm not sure what exactly it would mean if we omitted it? Really I guess it would mean whatever the debugger thinks it does.
I'm not sure whether it would be better to try to shoehorn something in here that almost fits but not quite, or to try to change what we do in the frontend (which could maybe be either changing the type of the parameter to some_struct*, or marking all struct descriptors with DW_AT_calling_convention, or perhaps even just not using byval at all and making the pointer parameter explicit in the frontend.
I'm not sure yet how hard it would be to do those. Do you have a sense of how lldb would react to having OP_deref, or leaving off OP_stack_value? (i.e. would it actually solve the problem, or would it just require a bunch of difficult work on the debugger side?)

Fri, Jan 15, 11:22 AM · Restricted Project

Thu, Jan 14

dschuff updated subscribers of D94347: [WebAssembly] locals can now be indirect in DWARF.

@pfaffe does this make sense? (i.e. when a structure is passed by value, it is passed indirectly, and its DW_AT_location ends with a DW_OP_deref to indicate this)

Thu, Jan 14, 1:40 PM · Restricted Project
dschuff closed D93472: [WebAssembly][lld] Don't mark a file live from an undefine symbol.

This landed as https://github.com/llvm/llvm-project/commit/cb77e877f8132b885fcac8b7532c58072537b9ed

Thu, Jan 14, 9:41 AM · Restricted Project

Tue, Jan 12

dschuff added a comment to D94347: [WebAssembly] locals can now be indirect in DWARF.

Ok, and it would change TI_LOCAL_INDIRECT back to TI_LOCAL as it emits DW_OP_deref ?

Tue, Jan 12, 5:18 PM · Restricted Project
dschuff added a comment to D94347: [WebAssembly] locals can now be indirect in DWARF.

I looked a little at DW_AT_calling_convention and it looks like clang does use it (e.g. DW_CC_pass_by_reference), even for dwarf 4, for e.g. nontrivially-copyable classes (see e.g. https://github.com/llvm/llvm-project/blob/master/clang/test/CodeGenCXX/debug-info-composite-cc.cpp). In this case though, a function that takes this value is also generated in the IR as a pointer rather than a byval.
In order to make this work we'd probably need to make the contract between a frontend that uses byval and the backend even more obscure (i.e. it would need to mark all the type infos for structs with this attribute in addition to making them passed byval). In other words since it's the backend that decides exactly how a byval IR parameter is passed it makes sense that the backend also sets the debug info accordingly. Assuming that's possible or reasonable, of course; that's why I was asking about what it would take to pass the information through to DwarfExpression::addWasmLocation.

Tue, Jan 12, 4:32 PM · Restricted Project

Mon, Jan 11

dschuff added a comment to D94347: [WebAssembly] locals can now be indirect in DWARF.

This approach definitely makes for simple implementation. It does seem a little unfortunate (at the dwarf level) that we are inventing something target-specific for a case that could be covered by something generic.
Is it possible just to modify DwarfExpression::addWasmLocation() to slip an extra DW_OP_deref into the expression when the TI kind is indirect? or does that have to be done elsewhere, e.g. in the caller?

Mon, Jan 11, 3:24 PM · Restricted Project

Thu, Jan 7

dschuff accepted D94047: [WebAssembly] Remove more unnecessary brs in CFGStackify.
Thu, Jan 7, 1:15 PM · Restricted Project

Wed, Jan 6

dschuff accepted D94045: [WebAssembly] Ensure terminate pads are a single BB.
Wed, Jan 6, 5:43 PM · Restricted Project
dschuff accepted D94044: [WebAssembly] Remove unreachable EH pads.
Wed, Jan 6, 5:22 PM · Restricted Project
dschuff accepted D94043: [WebAssembly] Update InstPrinter support for EH.
Wed, Jan 6, 5:09 PM · Restricted Project
dschuff accepted D94041: [WebAssembly] Remove exnref and br_on_exn.
Wed, Jan 6, 5:05 PM · Restricted Project
dschuff accepted D94040: [WebAssembly] Update basic EH instructions for the new spec.
Wed, Jan 6, 4:34 PM · Restricted Project
dschuff added inline comments to D94039: [WebAssembly] Update WasmEHPrepare for the new spec.
Wed, Jan 6, 3:57 PM · Restricted Project, Restricted Project
dschuff accepted D94140: [WebAssembly] Fixed byval args missing DWARF DW_AT_LOCATION.

@dblaikie Added you for review since this modifies common DWARF code, would love to hear if that is problematic or not. It would seem not, since we're the only users of these TI's it seems, and the new code is generic enough that it could work for future targets using TIs?

Yeah, since you folks are the ones that are using this feature for now (I guess/can you confirm that the TI things were added specifically for WebAssembly?) it's pretty much up to you. For more nuanced review of debug info locations, @aprantl is probably a more useful reference point - the actual optimized debug info variable location tracking, etc, isn't something I've stayed particularly close to.

Wed, Jan 6, 3:51 PM · Restricted Project
dschuff accepted D94038: [WebAssembly] Rename wasm_rethrow_in_catch intrinsic/builtin.
Wed, Jan 6, 2:16 PM · Restricted Project, Restricted Project
dschuff accepted D94037: [WebAssembly] Change label numbers to variables in test.
Wed, Jan 6, 2:15 PM · Restricted Project

Tue, Jan 5

dschuff accepted D93650: [MC][WebAssembly] Avoid recalculating indexes in -gsplit-dwarf mode.
Tue, Jan 5, 5:04 PM · Restricted Project

Dec 17 2020

dschuff updated the summary of D93472: [WebAssembly][lld] Don't mark a file live from an undefine symbol.
Dec 17 2020, 10:27 AM · Restricted Project
dschuff requested review of D93472: [WebAssembly][lld] Don't mark a file live from an undefine symbol.
Dec 17 2020, 10:27 AM · Restricted Project

Dec 16 2020

dschuff added a reverting change for rG950ae4309112: [WebAssembly] GC constructor functions in otherwise unused archive objects: D93415: Attempted revert of b3b4cda and 950ae43.
Dec 16 2020, 12:08 PM
dschuff added a reverting change for rGb3b4cda10406: [lld][WebAssembly] Don't GC library objects under `--whole-archive`: D93415: Attempted revert of b3b4cda and 950ae43.
Dec 16 2020, 12:08 PM
dschuff added a reverting change for D89290: [lld][WebAssembly] Don't GC library objects under `--whole-archive`: D93415: Attempted revert of b3b4cda and 950ae43.
Dec 16 2020, 12:08 PM · Restricted Project
dschuff added a reverting change for D85062: [WebAssembly] GC constructor functions in otherwise unused archive objects: D93415: Attempted revert of b3b4cda and 950ae43.
Dec 16 2020, 12:08 PM · Restricted Project

Dec 10 2020

dschuff committed rGdd6412c05c10: [WebAssembly][lld] Exclude COMDAT sections (authored by dschuff).
[WebAssembly][lld] Exclude COMDAT sections
Dec 10 2020, 5:50 PM
dschuff closed D92950: [WebAssembly] [lld] Exclude COMDAT sections.
Dec 10 2020, 5:49 PM · Restricted Project
dschuff committed rG8d396acac3bc: [WebAssembly] Support COMDAT sections in assembly syntax (authored by dschuff).
[WebAssembly] Support COMDAT sections in assembly syntax
Dec 10 2020, 4:46 PM
dschuff added a reverting change for D92952: [WebAssembly] Support COMDAT sections in assembly syntax: rGdd1aa4fdd82b: Revert "[WebAssembly] Support COMDAT sections in assembly syntax".
Dec 10 2020, 3:56 PM · Restricted Project
dschuff added a reverting change for rG4564553b8d8a: [WebAssembly] Support COMDAT sections in assembly syntax: rGdd1aa4fdd82b: Revert "[WebAssembly] Support COMDAT sections in assembly syntax".
Dec 10 2020, 3:56 PM
dschuff committed rGdd1aa4fdd82b: Revert "[WebAssembly] Support COMDAT sections in assembly syntax" (authored by dschuff).
Revert "[WebAssembly] Support COMDAT sections in assembly syntax"
Dec 10 2020, 3:56 PM
dschuff added a reviewer for D92950: [WebAssembly] [lld] Exclude COMDAT sections: sbc100.

I found that comdat functions seem to be getting double-included (i.e. not properly excluded) when using --no-gc-sections (independently of whether the object originates from llc or from assembly). I removed the checks that test functions and made them only test the section behavior. We can fix functions in a follow-up.

Dec 10 2020, 2:55 PM · Restricted Project
dschuff published D92950: [WebAssembly] [lld] Exclude COMDAT sections for review.
Dec 10 2020, 2:53 PM · Restricted Project
dschuff committed rG4564553b8d8a: [WebAssembly] Support COMDAT sections in assembly syntax (authored by dschuff).
[WebAssembly] Support COMDAT sections in assembly syntax
Dec 10 2020, 2:47 PM
dschuff closed D92952: [WebAssembly] Support COMDAT sections in assembly syntax.
Dec 10 2020, 2:46 PM · Restricted Project
dschuff added a comment to D92952: [WebAssembly] Support COMDAT sections in assembly syntax.

oops, forgot to publish my comments.

Dec 10 2020, 2:07 PM · Restricted Project
dschuff updated the diff for D92952: [WebAssembly] Support COMDAT sections in assembly syntax.
  • Simplify; add test for forgetting to specify sectoin
  • review
  • remove comdat-asm.ll, rebase
Dec 10 2020, 9:53 AM · Restricted Project
dschuff updated the diff for D92952: [WebAssembly] Support COMDAT sections in assembly syntax.
  • review
Dec 10 2020, 9:51 AM · Restricted Project

Dec 9 2020

dschuff added a comment to D92952: [WebAssembly] Support COMDAT sections in assembly syntax.

OK, added a check for the behavior when the .section directive is missing for a function, and a TODO for the existing problem of honoring the user's specified section name.

Dec 9 2020, 6:05 PM · Restricted Project
dschuff updated the diff for D92952: [WebAssembly] Support COMDAT sections in assembly syntax.

fix rebase

Dec 9 2020, 6:02 PM · Restricted Project
dschuff updated the diff for D92952: [WebAssembly] Support COMDAT sections in assembly syntax.

Simplify WebAssemblyAsmParser, add test for its behavior, add TODO

Dec 9 2020, 6:02 PM · Restricted Project
dschuff updated the summary of D92952: [WebAssembly] Support COMDAT sections in assembly syntax.
Dec 9 2020, 4:14 PM · Restricted Project
dschuff published D92952: [WebAssembly] Support COMDAT sections in assembly syntax for review.

This is ready to review now.

Dec 9 2020, 4:13 PM · Restricted Project

Dec 7 2020

dschuff committed rG0a391060f16d: [WebAssembly] Add Object and ObjectWriter support for wasm COMDAT sections (authored by dschuff).
[WebAssembly] Add Object and ObjectWriter support for wasm COMDAT sections
Dec 7 2020, 12:14 PM
dschuff closed D92691: [WebAssembly] Add Object and ObjectWriter support for wasm COMDAT sections.
Dec 7 2020, 12:14 PM · Restricted Project
dschuff updated the diff for D92691: [WebAssembly] Add Object and ObjectWriter support for wasm COMDAT sections.

rebase, fix typo

Dec 7 2020, 11:57 AM · Restricted Project
dschuff added a comment to D92691: [WebAssembly] Add Object and ObjectWriter support for wasm COMDAT sections.

I'm going to add assembly support in a separate change. So this change is ready for review; it has the end-to-end test, and when I add assembler support I'll add tests that go from ll -> asm and asm -> YAML

Dec 7 2020, 9:14 AM · Restricted Project
dschuff retitled D92691: [WebAssembly] Add Object and ObjectWriter support for wasm COMDAT sections from [WIP] Add Object and ObjectWriter support for wasm COMDAT sections to [WebAssembly] Add Object and ObjectWriter support for wasm COMDAT sections.
Dec 7 2020, 9:13 AM · Restricted Project

Dec 4 2020

dschuff updated the diff for D92691: [WebAssembly] Add Object and ObjectWriter support for wasm COMDAT sections.
  • clang-format
Dec 4 2020, 4:09 PM · Restricted Project
dschuff added a reviewer for D92691: [WebAssembly] Add Object and ObjectWriter support for wasm COMDAT sections: sbc100.
Dec 4 2020, 4:06 PM · Restricted Project
dschuff published D92691: [WebAssembly] Add Object and ObjectWriter support for wasm COMDAT sections for review.

This version basically just tests -fdebug-types-section end-to-end to YAML via comdats. (It probably needs more tests, suggestions are welcome)
I'm thinking it would be good to add assembly syntax so we can test just the MC and Object stuff separately from the debuginfo stuff. Not sure if that should be a separate change?

Dec 4 2020, 4:05 PM · Restricted Project

Dec 3 2020

dschuff added inline comments to D92620: [lld][WebAssembly] Add suppport for PIC + passive data initialization.
Dec 3 2020, 4:58 PM · Restricted Project

Dec 1 2020

dschuff committed rG8b8088ac6ca9: [lld] Use -1 as tombstone value for discarded code ranges (authored by Eric).
[lld] Use -1 as tombstone value for discarded code ranges
Dec 1 2020, 5:07 PM
dschuff closed D91803: [lld] Use -1 as tombstone value for discarded code ranges.
Dec 1 2020, 5:07 PM · Restricted Project
dschuff accepted D92429: [lld][WebAssembly] Feedback from D92038. NFC.

thanks!

Dec 1 2020, 2:46 PM · Restricted Project

Nov 30 2020

dschuff added inline comments to D92038: [lld][WebAssembly] Ensure stub symbols always get address 0.
Nov 30 2020, 11:15 AM · Restricted Project

Nov 19 2020

dschuff accepted D91681: [lld][WebAssembly] Convert more tests to asm format. NFC..
Nov 19 2020, 4:37 PM · Restricted Project

Nov 18 2020

dschuff accepted D91681: [lld][WebAssembly] Convert more tests to asm format. NFC..

This conversion LGTM.
It occurred to me that I don't know if we have tests that actually cover the conversion that we're removing here, namely LLVM IR -> assembly. e.g. after a really quick search I didn't see an ll test testing extern_weak globals in llvm/test/CodeGen/WebAssembly/ or llvm/test/MC/WebAssembly/. Did I just miss it?

Nov 18 2020, 2:00 PM · Restricted Project
dschuff accepted D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.
Nov 18 2020, 1:53 PM · Restricted Project

Nov 17 2020

dschuff added a comment to D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.

I was curious about emscripten. You mean that this is the mode that links the final wasm? Does emscripten allow users to inject JS functions that are directly imported by the wasm? (I assume we could use that mode for JS functions that are directly packaged by emscripten if we wanted).

Nov 17 2020, 5:00 PM · Restricted Project
dschuff added a comment to D91577: [lld][WebAssembly] Add --unresolved-symbols=import-dynamic.

What's the use case for 'import-functions' mode after we roll this out?

Nov 17 2020, 4:13 PM · Restricted Project
dschuff accepted D79248: [lld][WebAssembly] Implement --unresolved-symbols.
Nov 17 2020, 4:08 PM · Restricted Project
dschuff added a comment to D73820: [llvm-strip][WebAssembly] Support strip flags.

There are still outstanding comments after the last round, I just haven't had time to get back to it yet and it wasn't on the top of the list. I can bump the priority if you have need for it though?

Nov 17 2020, 2:15 PM · Restricted Project

Nov 13 2020

dschuff added a comment to D87258: [WebAssembly, LowerTypeTests] Fix control-flow integrity support.

Just a cross-reference, table-number relocs are being added in D90948

Nov 13 2020, 3:50 PM · Restricted Project

Nov 3 2020

dschuff accepted D90577: [WebAssembly] Don't fold frame offset for global addresses.

oh, I guess you're referring to the TODO on line 97? Yeah I guess including the case where the operand is a GA instead of an immediate counts as "more cases"...

Nov 3 2020, 2:26 PM · Restricted Project

Nov 2 2020

dschuff added a comment to D52050: [Driver] Fix architecture triplets and search paths for Linux x32.

One other question then: do you know if Debian and/or Ubuntu still have the same support for running x32 programs on the regular x86-64 distribution? (presumably yes, since you aren't changing the existing behavior).
AFAIK clang's current support was developed against Ubuntu, but I haven't tried it in a long time and to my knowledge nobody has submitted any patches for x32 in a while either.

Nov 2 2020, 3:14 PM · Restricted Project
dschuff added a comment to D52050: [Driver] Fix architecture triplets and search paths for Linux x32.

Can you upload the diff with full context (e.g. use diff -U 9999 or use arcanist to upload)?

Nov 2 2020, 1:57 PM · Restricted Project
dschuff added a comment to D90577: [WebAssembly] Don't fold frame offset for global addresses.

I think in theory, we could actually keep this optimization if we had a (ULEB?) relocation type with an addend (I think R_WASM_MEMORY_ADDR_LEB would work, actually).
Then we'd emit a load with a reloc against its constant offset field, where the addend would be the frame offset and the symbol would be the operand (similarly to what LadPatImmOff does for ISel)?
Of course if nobody discovered this bug before now it might not be that worthwhile...

Nov 2 2020, 1:34 PM · Restricted Project

Oct 30 2020

dschuff closed D88603: [WebAssembly] Add support for DWARF type units.
Oct 30 2020, 4:38 PM · Restricted Project, Restricted Project
dschuff added inline comments to D90503: [WebAssembly] Fixed DWARF DW_AT_low_pc encoded as 64-bit in wasm64.
Oct 30 2020, 3:54 PM · Restricted Project
dschuff accepted D90503: [WebAssembly] Fixed DWARF DW_AT_low_pc encoded as 64-bit in wasm64.

LGTM for now.
As I said, I have a feeling we may need to do something more to get the data address space right. But this is fine to avoid crashing.

Oct 30 2020, 3:53 PM · Restricted Project

Oct 28 2020

dschuff added a comment to D88603: [WebAssembly] Add support for DWARF type units.

@sbc100 I found that the cause of the assertion is that
in dwarf 5, the type units apparently go in the .debug_info section (instead of the .debug_type section), and this section already exists (but it was created as a non-comdat).
So when getWasmSection tries to look up an existing section it fails because the group is part of the key. Then it tries to create a new section but that fails because the name is duplicate.

Oct 28 2020, 5:47 PM · Restricted Project, Restricted Project
dschuff committed rG77973f8dee6d: [WebAssembly] Add support for DWARF type units (authored by dschuff).
[WebAssembly] Add support for DWARF type units
Oct 28 2020, 5:42 PM
dschuff updated the diff for D88603: [WebAssembly] Add support for DWARF type units.

fix diff; it should be against master

Oct 28 2020, 5:35 PM · Restricted Project, Restricted Project
dschuff updated the diff for D88603: [WebAssembly] Add support for DWARF type units.

can't just getOrCreate symbol without dealing with the section
just disable the test for now as we don't need dw5

Oct 28 2020, 5:34 PM · Restricted Project, Restricted Project
dschuff updated the diff for D88603: [WebAssembly] Add support for DWARF type units.

use getOrCreate

Oct 28 2020, 5:17 PM · Restricted Project, Restricted Project
dschuff reopened D88603: [WebAssembly] Add support for DWARF type units.
Oct 28 2020, 5:17 PM · Restricted Project, Restricted Project
dschuff added a comment to D88603: [WebAssembly] Add support for DWARF type units.

This broke the bots for some strange reason that didn't reproduce locally. But because it was ~all of them, I probably just did something stupid.

Good to have links to buildbots and/or quotes from buildbots (incase the logs get retired) about the specifics so other folks can chip in/know what went wrong, etc.

Oct 28 2020, 3:15 PM · Restricted Project, Restricted Project

Oct 27 2020

dschuff added a comment to D88603: [WebAssembly] Add support for DWARF type units.

This broke the bots for some strange reason that didn't reproduce locally. But because it was ~all of them, I probably just did something stupid.

Oct 27 2020, 6:02 PM · Restricted Project, Restricted Project
dschuff added a reverting change for rGbcb8a119df21: [WebAssembly] Add support for DWARF type units: rG44eea0b1a730: Revert "[WebAssembly] Add support for DWARF type units".
Oct 27 2020, 5:58 PM
dschuff committed rG44eea0b1a730: Revert "[WebAssembly] Add support for DWARF type units" (authored by dschuff).
Revert "[WebAssembly] Add support for DWARF type units"
Oct 27 2020, 5:58 PM
dschuff added a reverting change for D88603: [WebAssembly] Add support for DWARF type units: rG44eea0b1a730: Revert "[WebAssembly] Add support for DWARF type units".
Oct 27 2020, 5:58 PM · Restricted Project, Restricted Project
dschuff committed rGbcb8a119df21: [WebAssembly] Add support for DWARF type units (authored by dschuff).
[WebAssembly] Add support for DWARF type units
Oct 27 2020, 5:14 PM
dschuff closed D88603: [WebAssembly] Add support for DWARF type units.
Oct 27 2020, 5:14 PM · Restricted Project, Restricted Project
dschuff updated the diff for D88603: [WebAssembly] Add support for DWARF type units.

use GenericSectionID instead of ~0

Oct 27 2020, 5:07 PM · Restricted Project, Restricted Project

Oct 14 2020

dschuff added inline comments to D88603: [WebAssembly] Add support for DWARF type units.
Oct 14 2020, 2:45 PM · Restricted Project, Restricted Project

Oct 7 2020

dschuff added inline comments to D88603: [WebAssembly] Add support for DWARF type units.
Oct 7 2020, 1:34 PM · Restricted Project, Restricted Project

Oct 2 2020

dschuff accepted D88697: [WebAssembly] Rename Emscripten EH functions.

LGTM modulo Thomas's idea if you think that will work and is an improvement.

Oct 2 2020, 11:10 AM · Restricted Project

Oct 1 2020

dschuff updated subscribers of D88697: [WebAssembly] Rename Emscripten EH functions.

So, just to be sure I understand the architecture here:
Previously we use separate longjup_jmpbuf/longjmp and __invoke_{$LLVMSIG} because the lowering pass runs on IR and the IR type system's rules apply (and we don't have wasm signatures there). Now we can get wasm function signatures at AsmPrinter::emitEndOfAsmFile and the only thing that needs to be done is rename them?

Oct 1 2020, 4:51 PM · Restricted Project

Sep 30 2020

dschuff added inline comments to D88603: [WebAssembly] Add support for DWARF type units.
Sep 30 2020, 2:43 PM · Restricted Project, Restricted Project
dschuff added inline comments to D88603: [WebAssembly] Add support for DWARF type units.
Sep 30 2020, 12:01 PM · Restricted Project, Restricted Project
dschuff requested review of D88603: [WebAssembly] Add support for DWARF type units.
Sep 30 2020, 12:00 PM · Restricted Project, Restricted Project

Sep 28 2020

dschuff accepted D88428: [WebAssembly] Use wasm::Signature for in ObjectWriter (NFC).

LGTM too; I think I created wasm::WasmSignature in service of some other purpose (https://reviews.llvm.org/D52580) and never got around to finishing the job of removing this code...

Sep 28 2020, 10:31 AM · Restricted Project

Sep 25 2020

dschuff accepted D88323: [WebAssembly] Check features before making SjLj vars thread-local.
Sep 25 2020, 11:32 AM · Restricted Project