US-Pacific timezone.
User Details
- User Since
- Jan 7 2013, 9:35 AM (493 w, 6 d)
Thu, Jun 23
rebase
Tue, Jun 21
Fri, Jun 17
Mon, Jun 13
Thu, Jun 9
Tue, Jun 7
Mon, Jun 6
- expand comment
- review comments
Fri, Jun 3
- use start.s as a test instead
Thu, Jun 2
@jhenderson or others, would you like to review this too, or is sbc's review sufficient?
Wed, Jun 1
Tue, May 31
- remove stray blank line
OK, the prerequisite refactoring has landed, and this patch is now based on main, please take a look.
- Merge branch 'main' into objcopy-known
Fri, May 27
May 27 2022
include all the diffs
also update reloc and symbol type functions
- Merge branch 'sectionTypeToString' into objcopy-known
May 26 2022
Deduplicate
LGTM but will this require a change to clang and/or EMCC first?
Yeah, letting the user override with the manual mechanisms seems like a good thing, probably?
what happens when you use attribute(export-name) in clang, along with -fvisibility=hidden? (or is there some other way force an export?)
May 17 2022
May 13 2022
This looks good. Keep the interleaving if you find it more readable.
But thanks for the pointer @asb, I knew about the LLVM IR version of that tool but didn't know there was a MIR one.
This looks great! I guess the test for this will be when the fix for the MIR verifier lands, and it will start throwing errors if this somehow breaks, right?
May 2 2022
Mar 17 2022
Mar 15 2022
Mar 14 2022
Ah, right I forgot we already combined the default segments. That's probably fine as a default behavior.
Would there still be an advantage to combining the segments? e.g. would the library load faster if there were only one?
This code is fine as a reflection of the current state of the proposal though.
Mar 10 2022
I assume these llvm_unreachables your're adding in this CL are the places that will be filled in in subsequent CLs?
Mar 1 2022
Feb 28 2022
Feb 24 2022
Feb 22 2022
Feb 18 2022
Feb 16 2022
Feb 15 2022
can-haz test?
Feb 10 2022
Looks OK to me. All of these options handle explicit overrides to the ABI which I guess just didn't work before but doesn't change any defaults. We should probably put something in the emscripten release notes with a list of the flags that now actually do something, just in case someone was accidentally using them before :)
Jan 28 2022
I haven't reviewed this yet, but since we got one of these before and never merged it (https://reviews.llvm.org/D101464) we should probably land one of these.
Jan 27 2022
I guess the existing tls.s test case still covers the case where neither the symbol nor the segment is marked as TLS but the name is .tdata?
Jan 26 2022
The code, test and the behavior LGTM though.
Mostly I was confused by the fact that it says Wasm EH "used with" either Emscripten EH (which doesn't make sense) or Wasm EH (redundant). But I guess you mean the wasm EH primitive, used to implement C++ EH and setjmp/longjmp?
Wasm EH, used with either of Emscripten EH or Wasm EH, does not allow
Do you mean "Wasm SjLj?"
Jan 24 2022
fix diff
just one blank line