- User Since
- Jan 27 2014, 9:36 AM (225 w, 5 d)
- Fix variable capitalization.
Fri, May 25
GCC in libcxx-libcxxabi-x86_64-linux-ubuntu-cxx03 seems to mis-handle ATOMIC_VAR_INIT:
Fixed by r333290.
Thu, May 24
Ping! clang side landed in https://reviews.llvm.org/rL333246
- Address nit.
- Change suggested by Richard
- Merge format-size-spec-nsinteger
- Address nit.
Can you also add a test for _Bool _Accum.
Wed, May 23
Actually, scratch that. We will be enabling it since GCC does. Will update this and other relevant C++ related code appropriately.
Based on the cfe-dev discussion we'll want to handle the case of NSInteger with %z format on Darwin separately from other attempts at portability warnings in printf formats. I'll therefore re-post this patch as-is and CC all of you.
Tue, May 22
This is on by default for any version of C? AFAICK _Accum isn't on the C17 draft that I have, I'd expect to have to specify a command-line flag pertaining to TR 18037 to get this. At a minimum I'd be OK having it with the GNU variant of C, but not the __ANSI_C__ one.
Fri, May 18
- move test
- Follow John's suggestion.
I quite like the approach in D47073. I'll defer to it.
Thanks for starting the discussion, the general approach seems good. I think we can discuss MSVC versions as well as STL requirements separately, along with the libstdc++ ABI problems. and whether we should statically / dynamically link libc++ in some cases.
Thu, May 17
One comment, lgtm otherwise.
lgtm, though of course someone like @kcc should sign off.
Wed, May 16
Seems like a no-brainer, I'll commit.
Update landed in r332496.
- Address comments
- Fix double-wide CAS
Tue, May 15
Had to revert because some bots don't have double-pointer-wide atomics.
- Misc updates, cleanup
Mon, May 14
Actually I had a bit of time and addressed all outstanding comments from @dexonsmith.
- Rebase, address comments.
I committed the two requests NFC changes. Will address other changes tomorrow.