Page MenuHomePhabricator

NoQ (Artem Dergachev)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 3 2015, 9:16 AM (189 w, 1 d)

Recent Activity

Yesterday

NoQ added inline comments to D60796: [analyzer] PR41269: SmartPtrChecker..
Fri, Apr 19, 5:29 PM
NoQ updated the diff for D60796: [analyzer] PR41269: SmartPtrChecker..

Fix unused include.

Fri, Apr 19, 5:28 PM
NoQ accepted D58573: [analyzer] Move UninitializedObjectChecker out of alpha.

Ouch, forgot to accept it. Here you go!

Fri, Apr 19, 8:30 AM · Restricted Project

Thu, Apr 18

NoQ removed a child revision for D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.: D60796: [analyzer] PR41269: SmartPtrChecker..
Thu, Apr 18, 6:26 PM · Restricted Project, Restricted Project
NoQ removed a parent revision for D60796: [analyzer] PR41269: SmartPtrChecker.: D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..
Thu, Apr 18, 6:26 PM
NoQ updated the diff for D60796: [analyzer] PR41269: SmartPtrChecker..

On second thought, maybe let's restrict the scope to just bool conversions (don't model .get() and .release() yet) but enable the check by default immediately?

Thu, Apr 18, 6:25 PM
NoQ added a parent revision for D60899: [analyzer] Unbreak body farms in presence of multiple declarations.: D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function..
Thu, Apr 18, 6:11 PM · Restricted Project
NoQ added a child revision for D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.: D60899: [analyzer] Unbreak body farms in presence of multiple declarations..
Thu, Apr 18, 6:11 PM · Restricted Project
NoQ created D60899: [analyzer] Unbreak body farms in presence of multiple declarations..
Thu, Apr 18, 6:11 PM · Restricted Project
NoQ updated the diff for D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function..

Add space before \.

Thu, Apr 18, 6:01 PM · Restricted Project
NoQ updated the diff for D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function..

Separate the canonicalization change that unbreaks body farms into a separate patch.

Thu, Apr 18, 5:59 PM · Restricted Project
NoQ updated the diff for D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..

Fall back to the previous std::vector<std::unique_ptr<NoteTag>> approach.

Thu, Apr 18, 4:09 PM · Restricted Project, Restricted Project
NoQ added a comment to D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..

Hmmm, interesting. Could there be an issue with NoteTag not being trivially destructible?

Thu, Apr 18, 3:03 PM · Restricted Project, Restricted Project
NoQ added a comment to D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function..

(also fix typo in the function name)

Thu, Apr 18, 1:52 PM · Restricted Project
NoQ updated the diff for D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function..

Don't canonicalize the decl in the body farm. The decl supplied by the AnalysisDeclContext is already the correct one (and not necessarily the canonical one).

Thu, Apr 18, 1:52 PM · Restricted Project

Wed, Apr 17

NoQ planned changes to D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function..
In D60808#1469734, @NoQ wrote:

Hmm, i think i'd love to know why doesn't the uninitialized variable checker fire on the if-statement as farmed by the body farm:

Passing arguments to this whole body farm thing doesn't work. It builds the body for the declaration on line 4 but then calls the declaration on line 5, and parameter variables in the synthesized body don't match parameter variables of the call, so it cannot read argument values :/

Wed, Apr 17, 5:39 PM · Restricted Project
NoQ accepted D60845: [VerifyDiagnosticConsumer] Document -verify=<prefixes> in doxygen.
Wed, Apr 17, 5:11 PM · Restricted Project
NoQ added a comment to D60845: [VerifyDiagnosticConsumer] Document -verify=<prefixes> in doxygen.

Yup, i confirm that this improves discoverability of this feature :) Maybe it deserves its own .rst doc, like FileCheck, but for now doxygen seems to be the best source of truth on how to use -verify and i consult it regularly.

Wed, Apr 17, 5:11 PM · Restricted Project
NoQ added inline comments to D60796: [analyzer] PR41269: SmartPtrChecker..
Wed, Apr 17, 4:29 PM
NoQ updated the diff for D60796: [analyzer] PR41269: SmartPtrChecker..

The actual "Behold!".

Wed, Apr 17, 4:29 PM
NoQ added inline comments to D60796: [analyzer] PR41269: SmartPtrChecker..
Wed, Apr 17, 11:58 AM
NoQ updated the diff for D60796: [analyzer] PR41269: SmartPtrChecker..

Fxd.

Wed, Apr 17, 11:58 AM

Tue, Apr 16

NoQ added a comment to D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function..

Hmm, i think i'd love to know why doesn't the uninitialized variable checker fire on the if-statement as farmed by the body farm:

592   // Signature:
593   // _Bool OSAtomicCompareAndSwapPtr(void *__oldValue,
594   //                                 void *__newValue,
595   //                                 void * volatile *__theValue)
596   // Generate body:
597   //   if (oldValue == *theValue) {
598   //    *theValue = newValue;
599   //    return YES;
600   //   }
601   //   else return NO;

(closing brace accidentally omitted in the original comment as well)

Tue, Apr 16, 10:17 PM · Restricted Project
NoQ updated the diff for D60742: [analyzer] RegionStore: Enable loading default bindings from variables..

Fxd constructors and destructors.

Tue, Apr 16, 6:11 PM · Restricted Project
NoQ added inline comments to D60742: [analyzer] RegionStore: Enable loading default bindings from variables..
Tue, Apr 16, 6:06 PM · Restricted Project
NoQ added a comment to D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests..

The original patch added documentation to -cc1 -help. Doxygen for VerifyDiagnosticConsumer is another possibility except it currently doesn't mention command-line usage at all. Maybe it should?

Tue, Apr 16, 6:01 PM · Restricted Project, Restricted Project
NoQ updated the diff for D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function..

Fix comments.

Tue, Apr 16, 5:54 PM · Restricted Project
NoQ created D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function..
Tue, Apr 16, 5:54 PM · Restricted Project
NoQ accepted D53076: [analyzer] ConditionBRVisitor: Enhance to write out more information.

Yay!! I'm happy with this change and redirected all my wrath on its dependencies.

Tue, Apr 16, 4:30 PM · Restricted Project
NoQ added a reviewer for D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece: alexfh.

Let's decide whether we want to display the new notes in the text output. @alexfh: Given that clang-tidy is the primary consumer of the analyzer's text output mode, would you rather have or rather not have these new note:s in the text output? (scroll to the bottom of D53076 to see how they look). In my opinion, i'd rather have them in text output (because text output is hard to navigate, and having the necessary information exactly where you need it would probably be helpful), but rather not have them in tools that parse clang-tidy notes and stuff them into a source code view in some GUI (such tools do exist, right?), so im confused. I'd also prefer to have them be off in text output in tests, because such tests usually test checker-specific notes and having more checker-inspecific notes in the tests is more annoying than useful. But that's pretty minor; i'll be happy to write them down every time i write a test if they are believed to be a good thing in text output in general.

Tue, Apr 16, 3:53 PM · Restricted Project
NoQ added a comment to D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece.

In HTML reports background-color: LemonChiffon was too light, changed to PaleGoldenRod.

Tue, Apr 16, 3:37 PM · Restricted Project
NoQ added a child revision for D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.: D60796: [analyzer] PR41269: SmartPtrChecker..
Tue, Apr 16, 2:33 PM · Restricted Project, Restricted Project
NoQ added a parent revision for D60796: [analyzer] PR41269: SmartPtrChecker.: D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests..
Tue, Apr 16, 2:33 PM
NoQ added a parent revision for D60796: [analyzer] PR41269: SmartPtrChecker.: D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..
Tue, Apr 16, 2:33 PM
NoQ added a comment to D60796: [analyzer] PR41269: SmartPtrChecker..

Why alpha? Because it needs a bug visitor to explain what's going on when it suddenly returns a note. Because it's going to be a bugtype-inspecific note that is emitted by a checker, i want to implement it via note tags (D58367), otherwise it's quite a layering nightmare to set up communication between core and checker visitors (especially given that we'd want to attach a new move visitor immediately after emitting the note).

Tue, Apr 16, 2:33 PM
NoQ added a child revision for D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.: D60796: [analyzer] PR41269: SmartPtrChecker..
Tue, Apr 16, 2:33 PM · Restricted Project, Restricted Project
NoQ created D60796: [analyzer] PR41269: SmartPtrChecker..
Tue, Apr 16, 2:25 PM

Mon, Apr 15

NoQ added a child revision for D60739: [analyzer] NFC: Re-use reusable unittest mocks.: D60742: [analyzer] RegionStore: Enable loading default bindings from variables..
Mon, Apr 15, 5:37 PM · Restricted Project, Restricted Project
NoQ updated the diff for D60742: [analyzer] RegionStore: Enable loading default bindings from variables..

Whoops, copy-paste error.

Mon, Apr 15, 5:37 PM · Restricted Project
NoQ added a parent revision for D60742: [analyzer] RegionStore: Enable loading default bindings from variables.: D60739: [analyzer] NFC: Re-use reusable unittest mocks..
Mon, Apr 15, 5:37 PM · Restricted Project
NoQ updated the diff for D60742: [analyzer] RegionStore: Enable loading default bindings from variables..

Fix test file name in the top comment.

Mon, Apr 15, 5:33 PM · Restricted Project
NoQ created D60742: [analyzer] RegionStore: Enable loading default bindings from variables..
Mon, Apr 15, 5:30 PM · Restricted Project
NoQ created D60739: [analyzer] NFC: Re-use reusable unittest mocks..
Mon, Apr 15, 5:04 PM · Restricted Project, Restricted Project
NoQ created D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests..
Mon, Apr 15, 2:51 PM · Restricted Project, Restricted Project

Fri, Apr 12

NoQ added inline comments to D60281: [analyzer] Add docs for cplusplus.InnerPointer.
Fri, Apr 12, 6:21 PM · Restricted Project
NoQ added a comment to D59555: [analyzer] Add yaml parser to GenericTaintChecker.

This new approach is clearly useful to other checkers as well, not only the Taint checker. I believe we should strongly consider generalizing it somehow, it's just too awesome to restrict to a single checker.

Fri, Apr 12, 5:55 PM · Restricted Project

Sun, Apr 7

NoQ added inline comments to D54978: Move the SMT API to LLVM.
Sun, Apr 7, 1:22 AM · Restricted Project, Restricted Project

Fri, Apr 5

NoQ added a comment to D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC..
Running ['clang-tidy', '/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/tools/extra/test/clang-tidy/Output/google-readability-nested-namespace-comments.cpp.tmp.cpp', '-fix', '--checks=-*,google-readability-namespace-comments', '--', '--std=c++11', '-nostdinc++']...
------------------------ clang-tidy output -----------------------
3 warnings generated.
/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/tools/extra/test/clang-tidy/Output/google-readability-nested-namespace-comments.cpp.tmp.cpp:14:2: warning: namespace 'n3' not terminated with a closing comment [google-readability-namespace-comments]
}}
 ^
/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/tools/extra/test/clang-tidy/Output/google-readability-nested-namespace-comments.cpp.tmp.cpp:14:2: note: FIX-IT applied suggested code changes
/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/tools/extra/test/clang-tidy/Output/google-readability-nested-namespace-comments.cpp.tmp.cpp:4:11: note: namespace 'n3' starts here
namespace n3 {
          ^
/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/tools/extra/test/clang-tidy/Output/google-readability-nested-namespace-comments.cpp.tmp.cpp:14:3: warning: namespace 'n1::n2 {' not terminated with a closing comment [google-readability-namespace-comments]
}}
  ^
    // namespace n1::n2 {
/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/tools/extra/test/clang-tidy/Output/google-readability-nested-namespace-comments.cpp.tmp.cpp:14:3: note: FIX-IT applied suggested code changes
/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm.obj/tools/clang/tools/extra/test/clang-tidy/Output/google-readability-nested-namespace-comments.cpp.tmp.cpp:3:11: note: namespace 'n1::n2 {' starts here
namespace n1::n2 {
          ^
clang-tidy applied 2 of 2 suggested fixes.
Suppressed 1 warnings (1 with check filters).
Fri, Apr 5, 3:55 PM · Restricted Project, Restricted Project
NoQ reopened D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC..

Reverted in rC357827 because clang-tidy was using this function in some of its checks. I'll have a look at if it is also affected by the bug or was already using a workaround.

Fri, Apr 5, 3:47 PM · Restricted Project, Restricted Project

Thu, Apr 4

NoQ added inline comments to D60107: [analyzer] NoStoreFuncVisitor: Suppress bug reports with no-store in system headers..
Thu, Apr 4, 7:40 PM · Restricted Project, Restricted Project
NoQ updated the diff for D60107: [analyzer] NoStoreFuncVisitor: Suppress bug reports with no-store in system headers..

Address comments. Thanks!

Thu, Apr 4, 7:40 PM · Restricted Project, Restricted Project
NoQ added a comment to D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC..

I guess i'll commit, given that i don't know anybody else who uses these functions anyway.

Thu, Apr 4, 12:51 PM · Restricted Project, Restricted Project

Wed, Apr 3

NoQ added a comment to D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis.

Reverted D57230 in rC357620.

Wed, Apr 3, 11:27 AM · Restricted Project

Tue, Apr 2

NoQ added a comment to D58121: [analyzer][WIP] Attempt to fix traversing bindings of non-base regions in ClusterAnalysis.

Mmm. I'm also pretty pinned down (it's seasonal), so i'm thinking of temporarily reverting :( until one of us gets to fixing the accidental effect on escaping, 'cause it just keeps biting us. Like, i wholeheartedly appreciate the work and i have already noticed a few times how it makes things better and loved it, it just seems to accidentally have something missing that nobody could predict, and i'll be super eager to get it back in.

Tue, Apr 2, 7:07 PM · Restricted Project
NoQ added inline comments to D59467: [clang] Adding the Likelihood Attribute from C++2a.
Tue, Apr 2, 5:34 PM · Restricted Project
NoQ added a comment to D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape..

Woah, the code looks amazing, cheers on the refactoring! I'll be honest, I'm struggling a bit with the sentence "we're now in the top frame". In order, I don't understand what does

  • we
  • now
  • in the top frame mean. "Top-level argument" is another one -- Do we have precise definitions for there terms?
Tue, Apr 2, 2:30 PM · Restricted Project

Mon, Apr 1

NoQ created D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape..
Mon, Apr 1, 8:55 PM · Restricted Project
NoQ added a comment to D60107: [analyzer] NoStoreFuncVisitor: Suppress bug reports with no-store in system headers..

(whoops, forgot Alexey)

Mon, Apr 1, 7:47 PM · Restricted Project, Restricted Project
NoQ added a reviewer for D60107: [analyzer] NoStoreFuncVisitor: Suppress bug reports with no-store in system headers.: a_sidorin.
Mon, Apr 1, 7:47 PM · Restricted Project, Restricted Project
NoQ created D60110: [analyzer] When failing to evaluate a __builtin_constant_p, presume it's false..
Mon, Apr 1, 7:45 PM · Restricted Project, Restricted Project
NoQ added inline comments to D59467: [clang] Adding the Likelihood Attribute from C++2a.
Mon, Apr 1, 6:22 PM · Restricted Project
NoQ updated the summary of D60107: [analyzer] NoStoreFuncVisitor: Suppress bug reports with no-store in system headers..
Mon, Apr 1, 5:37 PM · Restricted Project, Restricted Project
NoQ created D60107: [analyzer] NoStoreFuncVisitor: Suppress bug reports with no-store in system headers..
Mon, Apr 1, 5:35 PM · Restricted Project, Restricted Project
NoQ accepted D53701: [Analyzer] Instead of recording comparisons in interator checkers do an eager state split.

Looks great, thanks!

Mon, Apr 1, 2:38 PM · Restricted Project

Sun, Mar 31

NoQ added inline comments to D59467: [clang] Adding the Likelihood Attribute from C++2a.
Sun, Mar 31, 2:31 PM · Restricted Project

Fri, Mar 29

NoQ reopened D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..

Re-reopen after the Diffusion auto-close.

Fri, Mar 29, 4:56 PM · Restricted Project, Restricted Project
NoQ reopened D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..

Reverted in rC357332!

Fri, Mar 29, 4:10 PM · Restricted Project, Restricted Project
NoQ added a comment to D59901: [analyzer] PR41239: Fix a crash on invalid source location in NoStoreFuncVisitor..

This other example seems to work and looks relatively similar, just with a different checker causing the visitor to be attached.

Fri, Mar 29, 3:54 PM · Restricted Project, Restricted Project
NoQ updated the diff for D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?.

Cleaned up formatting a bit.

Fri, Mar 29, 2:49 PM · Restricted Project
NoQ updated the diff for D59121: [analyzer] Fix macro names in diagnostics within bigger macros..

Also, this is kinda weird. According to my logic, we should have written Assuming 'i' is equal to 4294967295 because that's what the user will see in the macro popup. However, that's incorrect for the same reason: i is an int, while 4294967295 doesn't fit into an int, so they can never be equal. Writing Assuming 'i' is equal to UINT32_MAX is incorrect for the same reason, and the current message is the only one that's technically the truth.

Fri, Mar 29, 2:49 PM · Restricted Project
NoQ added a comment to D59121: [analyzer] Fix macro names in diagnostics within bigger macros..

Mmm, that *is* an Assuming... piece, i.e., this is the same code, just the structure of macros is more complicated than usual.

Fri, Mar 29, 2:24 PM · Restricted Project
NoQ added a comment to D58573: [analyzer] Move UninitializedObjectChecker out of alpha.

Ping, @NoQ, if we settled on optin.cplusplus, would you be fine with this patch?

Fri, Mar 29, 2:21 PM · Restricted Project
NoQ updated the diff for D59121: [analyzer] Fix macro names in diagnostics within bigger macros..

On second thought, dunno. In the scan-build macro preview it wouldn't show you UINT32_MAX anyway. Maybe let's keep this behavior.

Fri, Mar 29, 2:11 PM · Restricted Project
NoQ added a comment to D59121: [analyzer] Fix macro names in diagnostics within bigger macros..

I think the right thing to do here is "look at the immediate macro; while it expands exactly to our original expression, look at what it is an expansion of; write down the last macro we've reached". My code now gives up whenever we stop expanding to the original expression, but it should write down the highest macro it has reached instead.

Fri, Mar 29, 10:13 AM · Restricted Project

Thu, Mar 28

NoQ added a child revision for D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC.: D59121: [analyzer] Fix macro names in diagnostics within bigger macros..
Thu, Mar 28, 7:18 PM · Restricted Project, Restricted Project
NoQ added a parent revision for D59121: [analyzer] Fix macro names in diagnostics within bigger macros.: D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC..
Thu, Mar 28, 7:18 PM · Restricted Project
NoQ updated the diff for D59121: [analyzer] Fix macro names in diagnostics within bigger macros..

An elegant solution for a more civilized age. Unfortunately, doesn't preserve the UINT32_MAX macro in the newly added test - i'll try a bit harder to preserve it. Relies on D59977 to work.

Thu, Mar 28, 7:14 PM · Restricted Project
NoQ created D59977: [Lexer] Fix an off-by-one bug in Lexer::getAsCharRange() - NFC..
Thu, Mar 28, 7:11 PM · Restricted Project, Restricted Project
NoQ added a comment to D53076: [analyzer] ConditionBRVisitor: Enhance to write out more information.

Instead of having those as events similar to "Assuming", we could turn the new "Knowing" pieces into floating pop-ups - imagine you hover the mouse over a condition foo() and it says "foo() is false". That is, instead of PathDiagnosticsEventPiece, a new kind of piece can be introduced that is shown in scan-build as a pop-up similar to macro pop-ups. Like this:

Thu, Mar 28, 5:32 PM · Restricted Project

Wed, Mar 27

NoQ created D59914: [analyzer] MIGChecker: Add support for more deallocator APIs..
Wed, Mar 27, 6:43 PM · Restricted Project, Restricted Project
NoQ accepted D55007: [Analyzer] Constraint Manager - Calculate Effective Range for Differences.

What i was trying to say with my last comment is that i guess i'd rather go for option (1) because with that getRange() remains the single source of truth, which is comfy.

Wed, Mar 27, 3:37 PM · Restricted Project, Restricted Project
NoQ created D59901: [analyzer] PR41239: Fix a crash on invalid source location in NoStoreFuncVisitor..
Wed, Mar 27, 1:42 PM · Restricted Project, Restricted Project
NoQ updated the diff for D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?.

Add a test for taint dumps.

Wed, Mar 27, 1:14 PM · Restricted Project
NoQ added inline comments to D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..
Wed, Mar 27, 1:10 PM · Restricted Project, Restricted Project
NoQ updated the diff for D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..
Wed, Mar 27, 1:10 PM · Restricted Project, Restricted Project
NoQ added a comment to D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..

*un-forgets to actually post comments*

Wed, Mar 27, 1:08 PM · Restricted Project, Restricted Project
NoQ added inline comments to D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..
Wed, Mar 27, 12:53 PM · Restricted Project, Restricted Project
NoQ updated the diff for D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..
Wed, Mar 27, 12:53 PM · Restricted Project, Restricted Project
NoQ accepted D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry.

I agree that we shouldn't try real hard to fix our code until we have a clear "party line" on how exactly do we name our variables (and ideally also how do we invalidate our caches), but having variables and fields consistent with each other makes it look much better imo, so why not.

Wed, Mar 27, 12:12 PM · Restricted Project, Restricted Project
NoQ added inline comments to D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?.
Wed, Mar 27, 12:05 PM · Restricted Project
NoQ updated the diff for D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?.

Address comments. Fix printing taint in state dumps.

Wed, Mar 27, 12:05 PM · Restricted Project

Tue, Mar 26

NoQ added a comment to D59516: [analyzer] Add custom filter functions for GenericTaintChecker.

Hi, i wanted to squeeze in D59861 somewhere in the middle of your work, would you mind?
I'll definitely have a look at your patches soon :)

Tue, Mar 26, 6:48 PM · Restricted Project
NoQ added a comment to D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?.

(whoops sry nvm typo in reviewer list)

Tue, Mar 26, 6:46 PM · Restricted Project
NoQ edited reviewers for D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?, added: boga95; removed: alexfh.
Tue, Mar 26, 6:45 PM · Restricted Project
NoQ created D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?.
Tue, Mar 26, 6:45 PM · Restricted Project
NoQ created D59857: [analyzer] PR37501: Disable the assertion for reverse-engineering logical op short circuits..
Tue, Mar 26, 5:57 PM · Restricted Project
NoQ updated the diff for D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..

Remove memoization for now. Address a few inline comments. I'm mostly done with this first patch, did i accidentally miss anything?

Tue, Mar 26, 3:21 PM · Restricted Project, Restricted Project

Mon, Mar 25

NoQ added a comment to D59622: [analyzer] C++17: PR41142: Ignore transparent InitListExprs in ExprEngine as well..

(the commit message shouldn't have said "CFG", sry)

Mon, Mar 25, 7:55 PM · Restricted Project
NoQ added inline comments to D53701: [Analyzer] Instead of recording comparisons in interator checkers do an eager state split.
Mon, Mar 25, 5:22 PM · Restricted Project
NoQ added inline comments to D53701: [Analyzer] Instead of recording comparisons in interator checkers do an eager state split.
Mon, Mar 25, 3:02 PM · Restricted Project