Page MenuHomePhabricator

brooks (Brooks Davis)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2015, 9:29 AM (297 w, 23 h)

Recent Activity

Mon, Sep 28

brooks requested review of D88453: [lldb] Fix FreeBSD Arm Process Plugin build..
Mon, Sep 28, 3:24 PM · Restricted Project

Aug 24 2020

brooks added a comment to D86397: Move special va_list handling to kmp_os.h.

This seems to replace D77333

Aug 24 2020, 11:55 AM · Restricted Project

Jun 12 2020

brooks updated the diff for D77333: OpenMP: Support FreeBSD on AArch64..
  • clang-format patched lines.
Jun 12 2020, 8:38 AM · Restricted Project

Apr 2 2020

brooks created D77333: OpenMP: Support FreeBSD on AArch64..
Apr 2 2020, 1:00 PM · Restricted Project

Mar 27 2020

brooks added a comment to D76827: [lldb/CMake] Fix `install` for multi-configuration generators..

Doing a bit of naive digging suggests to me that putting this section inside an

if (NOT CMAKE_CFG_INTDIR STREQUAL  ".")

might do the trick.

Mar 27 2020, 4:32 PM · Restricted Project
brooks updated subscribers of D76827: [lldb/CMake] Fix `install` for multi-configuration generators..

The generator is Ninja. @emaste may know of a buildbot. Note that this is an install failure so I'm not sure if buildbots will catch it.

Mar 27 2020, 3:59 PM · Restricted Project
brooks added a comment to D76827: [lldb/CMake] Fix `install` for multi-configuration generators..

This is broken in a FreeBSD install.

Mar 27 2020, 3:27 PM · Restricted Project

Jul 22 2019

brooks added a comment to D7104: On FreeBSD MIPS claim and pass down the -G# argument if present when linking..

@brooks, @arichardson do we still want to pursue this?

Jul 22 2019, 2:25 PM

Sep 25 2018

brooks created D52507: Fix FreeBSD build after r342633..
Sep 25 2018, 10:17 AM
brooks added a comment to D52507: Fix FreeBSD build after r342633..

See also: D51859

Sep 25 2018, 10:17 AM
brooks added a comment to D51859: [NFC] Turn "load dependent files" boolean into an enum .

Also broke the FreeBSD build:

Sep 25 2018, 10:05 AM

May 7 2018

brooks accepted D24867: Request init/fini array on FreeBSD 12 and later.

I do think we should make this change, but don't have a strong opinion on the timing. If we do it for 12 and not 13 then we should probably try to get it into a 6.0.2.

May 7 2018, 1:16 PM

May 6 2018

brooks updated the diff for D46503: [cmake] work around a race in Sphinx..
  • Correct whitespace.
May 6 2018, 9:42 AM
brooks added a comment to D46503: [cmake] work around a race in Sphinx..

I've received multiple reports of this issue from FreeBSD ports users, but have never encountered it myself. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227460

May 6 2018, 9:40 AM
brooks created D46503: [cmake] work around a race in Sphinx..
May 6 2018, 9:37 AM
brooks added a reviewer for D24867: Request init/fini array on FreeBSD 12 and later: arichardson.

Adding Alex as he made some related changes to CHERI Clang recently https://github.com/CTSRD-CHERI/clang/commit/3a648766deabb4ff7f95862213c3c99e7223363c.

May 6 2018, 9:11 AM

May 29 2015

brooks added a comment to D10137: On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option to the assembler..

I may just not understand how render() works, but I tried it and it didn't seem to work to replace

May 29 2015, 4:23 PM
brooks updated the diff for D10137: On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option to the assembler..

Remove a spurious -mcpu from the test case.

May 29 2015, 4:21 PM
brooks added a comment to D9114: For FreeBSD on mips, pass -G options to the linker.
In D9114#181178, @dim wrote:

Even if this patch is incomplete with regards to the assembler, it is both necessary and sufficient to build and link programs with the current FreeBSD build system. It follows gcc's long established behavior as a linker and is harmless to other consumers so why not commit it?

Sure, but maybe -G for the linker is not completely useful, if the assembler also doesn't use it?

May 29 2015, 2:10 PM
brooks retitled D10137: On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option to the assembler. from to On {mips,mipsel,mips64,mips64el}-freebsd, we need to pass any -G option to the assembler..
May 29 2015, 2:10 PM
brooks added a comment to D9114: For FreeBSD on mips, pass -G options to the linker.

Even if this patch is incomplete with regards to the assembler, it is both necessary and sufficient to build and link programs with the current FreeBSD build system. It follows gcc's long established behavior as a linker and is harmless to other consumers so why not commit it?

May 29 2015, 12:27 PM

Jan 21 2015

brooks added a comment to D7104: On FreeBSD MIPS claim and pass down the -G# argument if present when linking..

Add cfe-commits per message

Jan 21 2015, 11:59 AM
brooks updated the diff for D7104: On FreeBSD MIPS claim and pass down the -G# argument if present when linking..

Add a test for not passing -G0 when it isn't an argument.

Jan 21 2015, 11:58 AM
brooks retitled D7104: On FreeBSD MIPS claim and pass down the -G# argument if present when linking. from to On FreeBSD MIPS claim and pass down the -G# argument if present when linking..
Jan 21 2015, 11:37 AM