Page MenuHomePhabricator

zahiraam (Zahira Ammarguellat)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2017, 11:28 AM (208 w, 3 d)

Recent Activity

Mon, Mar 15

zahiraam added a comment to D98632: [NFC] Fix "unused parameter" error revealed in the Linux self-build..

LGTM! The CI build failures look to be entirely unrelated to any changes in this patch, but please keep an eye on the build bots once you land this just in case there's a real issue.

Mon, Mar 15, 9:18 AM · Restricted Project
zahiraam committed rG80ca4fd15449: [NFC] Fix "unused parameter" error revealed in the Linux self-build. (authored by zahiraam).
[NFC] Fix "unused parameter" error revealed in the Linux self-build.
Mon, Mar 15, 9:17 AM
zahiraam requested review of D98632: [NFC] Fix "unused parameter" error revealed in the Linux self-build..
Mon, Mar 15, 6:25 AM · Restricted Project

Mar 12 2021

zahiraam committed rGc2006f857d80: [NFC] Fix "unused parameter" error revealed in the Linux self-build. (authored by zahiraam).
[NFC] Fix "unused parameter" error revealed in the Linux self-build.
Mar 12 2021, 10:27 AM
zahiraam added a comment to D98204: [NFC] Fix "unused parameter" error revealed in the Linux self-build..

@aaron.ballman Thanks for that. Let's see if this one will work.

Mar 12 2021, 8:05 AM · Restricted Project
zahiraam updated the diff for D98204: [NFC] Fix "unused parameter" error revealed in the Linux self-build..
Mar 12 2021, 8:04 AM · Restricted Project

Mar 10 2021

zahiraam added a comment to D98204: [NFC] Fix "unused parameter" error revealed in the Linux self-build..

Let's see if this time it worked. Thanks.

Mar 10 2021, 2:03 PM · Restricted Project
zahiraam updated the diff for D98204: [NFC] Fix "unused parameter" error revealed in the Linux self-build..
Mar 10 2021, 2:02 PM · Restricted Project
zahiraam added a comment to D98204: [NFC] Fix "unused parameter" error revealed in the Linux self-build..

The changes look good as far as the diff is concerned, but the patch does not apply cleanly for me on ToT and the CI pipeline agrees (https://buildkite.com/llvm-project/diff-checks/builds/32992#831d7148-ce1c-4e47-9f96-e2d7edf67580).

Mar 10 2021, 12:25 PM · Restricted Project
zahiraam added inline comments to D98204: [NFC] Fix "unused parameter" error revealed in the Linux self-build..
Mar 10 2021, 11:41 AM · Restricted Project
zahiraam updated the diff for D98204: [NFC] Fix "unused parameter" error revealed in the Linux self-build..
Mar 10 2021, 11:41 AM · Restricted Project

Mar 8 2021

zahiraam requested review of D98204: [NFC] Fix "unused parameter" error revealed in the Linux self-build..
Mar 8 2021, 11:36 AM · Restricted Project

Jan 26 2021

zahiraam added a comment to D95462: Fix an error about implicit fallthrough during self build - new tag for ittapi..

LGTM. Let me know if you need help with submitting this patch.

Jan 26 2021, 11:56 AM · Restricted Project
zahiraam requested review of D95462: Fix an error about implicit fallthrough during self build - new tag for ittapi..
Jan 26 2021, 11:06 AM · Restricted Project

Jan 20 2021

zahiraam abandoned D94609: Implicit fallthrough error in self build..
Jan 20 2021, 5:43 AM · Restricted Project

Jan 13 2021

zahiraam added a reviewer for D94609: Implicit fallthrough error in self build.: aaron.ballman.
Jan 13 2021, 8:52 AM · Restricted Project
zahiraam requested review of D94609: Implicit fallthrough error in self build..
Jan 13 2021, 8:51 AM · Restricted Project

Dec 1 2020

zahiraam committed rGf9eaa4650f5d: Fix erroneous edit in https://github.com/llvm/llvm… (authored by zahiraam).
Fix erroneous edit in https://github.com/llvm/llvm…
Dec 1 2020, 12:46 PM
zahiraam added a comment to D90943: Fix for Bug25668. Clang is asserting when lookup argument is a class that hasn't been instantiated..

rG37340798ccb0

Dec 1 2020, 10:47 AM
zahiraam committed rG37340798ccb0: Argument dependent lookup with class argument is recursing into base (authored by zahiraam).
Argument dependent lookup with class argument is recursing into base
Dec 1 2020, 10:45 AM

Nov 30 2020

zahiraam updated the diff for D90943: Fix for Bug25668. Clang is asserting when lookup argument is a class that hasn't been instantiated..
Nov 30 2020, 7:01 AM

Nov 25 2020

zahiraam updated the diff for D90943: Fix for Bug25668. Clang is asserting when lookup argument is a class that hasn't been instantiated..
Nov 25 2020, 12:40 PM

Nov 11 2020

zahiraam added a comment to D90943: Fix for Bug25668. Clang is asserting when lookup argument is a class that hasn't been instantiated..

I am not really convinced that this is an openmp issue. If I take the same test case but remove one level of instantiation, the test cases compiles without hitting the assertion.
template <typename T>
struct z {

static void aj() {
  T f;

#pragma omp target map(f)

  ;
}

};
template <int> struct as {};
template class z<as<4>>;
I think the issue is that Sema::FindAssociatedClassesAndNamespaces is entered with a null location and noone inside addAssociatedClassesAndNamespaces updates the field Instantiation of Result.
I am proposing this fix to remedy to it. Not sure what you think of this?
Thanks.

Nov 11 2020, 1:31 PM
zahiraam updated the diff for D90943: Fix for Bug25668. Clang is asserting when lookup argument is a class that hasn't been instantiated..
Nov 11 2020, 1:27 PM

Nov 10 2020

zahiraam accepted D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811).
Nov 10 2020, 8:54 AM · Restricted Project
zahiraam added a comment to D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811).

clang.exe -c test.cpp
Assertion failed: !hasUninstantiatedDefaultArg() && "Default argument is not yet instantiated!", file D:\IUSERS\zahiraam\llorg_ws\ws1\llvm\clang\lib\AST\Decl.cpp, line 2719
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.

Thanks for catching that!

What's happening is that Clang tries to emit the ctor closure even though the ctor is just declared, but not defined.

I don't think it makes sense to try to emit the closure until we have the ctor definition. I'll update the patch to handle this.

Nov 10 2020, 8:54 AM · Restricted Project
zahiraam added a comment to D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811).

Please take a look.

Nov 10 2020, 5:15 AM · Restricted Project

Nov 6 2020

zahiraam added a comment to D90943: Fix for Bug25668. Clang is asserting when lookup argument is a class that hasn't been instantiated..
In D90943#2379563, @rnk wrote:

It seems like OpenMP can trigger template instantiation without providing a location for the instantiation, and that is a bug. See this commented out assert in RequireCompleteTypeImpl:
https://github.com/llvm/llvm-project/blob/master/clang/lib/Sema/SemaType.cpp#L8553

// FIXME: Add this assertion to make sure we always get instantiation points.
//  assert(!Loc.isInvalid() && "Invalid location in RequireCompleteType");

I think the workaround is probably OK, but if it's possible to loop at the OpenMP sema side of things, it's worth looking into.

Nov 6 2020, 11:53 AM
zahiraam updated the diff for D90943: Fix for Bug25668. Clang is asserting when lookup argument is a class that hasn't been instantiated..
Nov 6 2020, 11:53 AM
zahiraam updated the diff for D90943: Fix for Bug25668. Clang is asserting when lookup argument is a class that hasn't been instantiated..
Nov 6 2020, 10:29 AM
zahiraam requested review of D90943: Fix for Bug25668. Clang is asserting when lookup argument is a class that hasn't been instantiated..
Nov 6 2020, 7:00 AM
zahiraam added a comment to D88112: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544.

Merged in https://reviews.llvm.org/rGe562a40871da.

Nov 6 2020, 6:13 AM

Oct 27 2020

zahiraam committed rGe562a40871da: Fix for PR47544. Clang is crashing after generating the right (authored by zahiraam).
Fix for PR47544. Clang is crashing after generating the right
Oct 27 2020, 6:08 AM

Oct 26 2020

zahiraam requested review of D90165: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544..
Oct 26 2020, 8:47 AM · Restricted Project

Oct 22 2020

zahiraam requested review of D89960: Testing the use of arc..
Oct 22 2020, 7:02 AM · Restricted Project

Oct 21 2020

zahiraam updated the diff for D88112: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544.
Oct 21 2020, 2:01 PM
zahiraam updated the diff for D88112: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544.
Oct 21 2020, 11:02 AM

Oct 20 2020

zahiraam added a reviewer for D88112: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544: aaron.ballman.
Oct 20 2020, 6:07 AM

Oct 9 2020

zahiraam added a comment to D88112: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544.

Any feedback please?

Oct 9 2020, 8:33 AM

Oct 6 2020

zahiraam updated the diff for D88112: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544.
Oct 6 2020, 8:05 AM

Sep 30 2020

zahiraam added a comment to D88112: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544.
In D88112#2298597, @rnk wrote:

I don't feel like there is enough information in the bug or here to understand if this is the correct fix. Why is clang crashing? Why should we return null here instead of returning a decl that has already been marked invalid? Maybe the caller should treat the invalid declaration more carefully. I usually try to answer these questions by reading the existing code to try to understand why it does what it does.

I see there are two call sites to this function, one for definitions ({}) and one for declarations {;}:
https://github.com/llvm/llvm-project/blob/master/clang/lib/Parse/ParseCXXInlineMethods.cpp#L39
https://github.com/llvm/llvm-project/blob/master/clang/lib/Parse/ParseDeclCXX.cpp#L2825

In this case, it seems like the second is the one that is crashing. Reading forward from that function call, I found these ifs here, which treat null and invalid member declarations differently:
https://github.com/llvm/llvm-project/blob/master/clang/lib/Parse/ParseDeclCXX.cpp#L2890
That means there is some set of things we do for invalid decls, and some that we do for null decls. I guess the question is now, should those things be done for these types of friend declarations? I guess the important thing is that the invalid declaration is added to the declgroup, which is ultimately what gets returned out of here, so maybe the crash happens later, but I can't say for sure.

Sep 30 2020, 6:44 AM

Sep 28 2020

zahiraam added a comment to D88150: BuildVectorType with a dependent (array) type is crashing the compiler - Fix for PR-47542.
In D88150#2298923, @rnk wrote:

Thanks!

Sep 28 2020, 12:37 PM · Restricted Project
zahiraam updated the diff for D88150: BuildVectorType with a dependent (array) type is crashing the compiler - Fix for PR-47542.
Sep 28 2020, 12:33 PM · Restricted Project

Sep 23 2020

zahiraam added reviewers for D88150: BuildVectorType with a dependent (array) type is crashing the compiler - Fix for PR-47542: rnk, mikerice.
Sep 23 2020, 6:38 AM · Restricted Project
zahiraam requested review of D88150: BuildVectorType with a dependent (array) type is crashing the compiler - Fix for PR-47542.
Sep 23 2020, 6:35 AM · Restricted Project
zahiraam updated the diff for D88112: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544.
Sep 23 2020, 6:11 AM

Sep 22 2020

zahiraam added inline comments to D88112: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544.
Sep 22 2020, 2:33 PM
zahiraam added reviewers for D88112: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544: mikerice, rnk.
Sep 22 2020, 12:56 PM
zahiraam requested review of D88112: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544.
Sep 22 2020, 12:54 PM

Aug 10 2020

zahiraam added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

Review anyone please? Thanks.

Aug 10 2020, 1:09 PM

Jul 30 2020

zahiraam updated the diff for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

This patch is only to fix the compiler crash.
Would you mind commenting/reviewing this patch as it is a crash with (internal) impact?
There would still be another bug that needs fixing (would prefer to open another bug for it), for this case:
class __declspec(dllexport) foo {

foo(int x = 0);

};

Jul 30 2020, 10:44 AM
zahiraam retitled D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion. from Fix for Bug45811 - Failed assertion to Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
Jul 30 2020, 10:42 AM

Jul 28 2020

zahiraam added a comment to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..

I actually made an attempt to commit the patch using arc but not sure it made it. This was my last command: git commit --amend -a
Do I need to push now?
Thanks.

You can use arc land --revision D84038 or you can check what you're about to push: git fetch origin && git log ^origin/master HEAD ; if this is the commit you intend to push and the commit message is satisfying, then just push it.

If you don't have push permissions, you need to ask here for someone to land it for you.

Jul 28 2020, 12:45 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam added a comment to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..

I actually made an attempt to commit the patch using arc but not sure it made it. This was my last command: git commit --amend -a
Do I need to push now?
Thanks.

Jul 28 2020, 11:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam requested review of D84780: Setting the /bigobj option globally for Windows debug build. https://bugs.llvm.org/show_bug.cgi?id=46733.
Jul 28 2020, 11:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam added a comment to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..

Can someone submit it please? Thanks.

Jul 28 2020, 10:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam added inline comments to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..
Jul 28 2020, 5:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam updated the diff for D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..
Jul 28 2020, 5:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam retitled D84038: On Windows build, making the /bigobj flag global , instead of passing it per file. from Passing the flag bigobj globally when building debug compiler on Windows to On Windows build, making the /bigobj flag global , instead of passing it per file..
Jul 28 2020, 5:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 27 2020

zahiraam added a comment to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..

Review please? Thanks.

Jul 27 2020, 2:39 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 22 2020

zahiraam updated the diff for D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..
Jul 22 2020, 6:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 21 2020

zahiraam added a comment to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..

Sadly I think @rnk isn't around. This is something I'd really like him to weigh in on. I assume there was a reason for doing this per-object file rather than for everything, and I don't have the context.

Jul 21 2020, 1:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam updated the diff for D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..
Jul 21 2020, 12:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 19 2020

zahiraam updated the diff for D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..
Jul 19 2020, 11:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 17 2020

Herald added projects to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file.: Restricted Project, Restricted Project.
Jul 17 2020, 8:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 16 2020

zahiraam added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

@hans Thanks for the feedback.
@riccibruno Thanks for the feedback.

Jun 16 2020, 1:44 PM
zahiraam updated the summary of D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
Jun 16 2020, 1:44 PM
zahiraam added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

I'm sorry, but I still don't understand, and neither will anyone who reads the new code, I think. It needs an explanation.

Jun 16 2020, 6:04 AM

Jun 10 2020

zahiraam added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
Jun 10 2020, 1:21 PM
zahiraam added inline comments to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
Jun 10 2020, 1:21 PM
zahiraam updated the diff for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
Jun 10 2020, 1:21 PM
zahiraam updated the diff for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
Jun 10 2020, 11:41 AM
zahiraam added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

@hans Thanks for looking at it. I think the updated patch is a better way to handle the crash.

Jun 10 2020, 11:41 AM

Jun 9 2020

zahiraam added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

@majnemer Any feedback? Thanks.

Jun 9 2020, 7:05 AM

May 23 2020

zahiraam updated the diff for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
May 23 2020, 7:24 AM

May 20 2020

zahiraam updated the diff for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
May 20 2020, 3:27 PM
zahiraam added a reviewer for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion.: hans.
May 20 2020, 3:27 PM

May 18 2020

zahiraam added inline comments to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
May 18 2020, 1:00 PM
zahiraam updated the diff for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
May 18 2020, 1:00 PM
zahiraam added a reviewer for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion.: erichkeane.
May 18 2020, 8:34 AM

May 7 2020

zahiraam created D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
May 7 2020, 10:47 AM

Dec 9 2019

zahiraam committed rG32c802e0f539: Fix build bot fails due to the patch here: https://reviews.llvm.org/D70691… (authored by zahiraam).
Fix build bot fails due to the patch here: https://reviews.llvm.org/D70691…
Dec 9 2019, 6:32 AM
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

I looked at the test failure, the REQUIRES line is necessary because the test calls emit-obj. I've asked Zahira to commit it to fix the bots.

Dec 9 2019, 6:31 AM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

Got other build fails.
Doesn't the LIT test require a:
// REQUIRES: x86-registered-target
command?

Dec 9 2019, 12:33 AM · Restricted Project

Dec 8 2019

zahiraam committed rG27f5d35137cb: Fix for build bot failure. For more details see: https://reviews.llvm. (authored by zahiraam).
Fix for build bot failure. For more details see: https://reviews.llvm.
Dec 8 2019, 9:58 PM
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

LGTM. Could you commit this soon to get the bots green again?

Dec 8 2019, 9:58 PM · Restricted Project

Dec 6 2019

zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

This might be easier to read the edit that I have made:
ksh-3.2$ git diff
diff --git a/clang/test/CodeGen/opt-record-1.c b/clang/test/CodeGen/opt-record-1.c
index 3f37e32..00a753d 100644

  • a/clang/test/CodeGen/opt-record-1.c

+++ b/clang/test/CodeGen/opt-record-1.c
@@ -1,12 +1,12 @@
- RUN: %clang_cc1 %s -opt-record-file=t1.opt -fopenmp -emit-llvm-bc -o %t.bc
-
RUN: %clang_cc1 -x ir %t.bc -opt-record-file %t.opt -fopenmp -emit-obj
+ RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-cpu x86-64 %s -O3 -opt-record-file=t1.opt -fopenmp -emit-llvm-bc -o %t.bc
+
RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-cpu x86-64 -O3 -x ir %t.bc -opt-record-file %t.opt -fopenmp -emit-obj
// RUN: cat %t.opt | FileCheck -check-prefix=CHECK %s

Dec 6 2019, 2:34 PM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

If you agree with the edit I will commit the change. Thanks.

Dec 6 2019, 2:25 PM · Restricted Project
zahiraam updated the diff for D70691: Optimization record for bytecode input missing- PR44000.
Dec 6 2019, 2:25 PM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

Please see the edit in the list test. Fixed the build issue that occurred in the buildbot:
http://lab.llvm.org:8011/builders/clang-x86_64-debian-new-pass-manager-fast/builds/232/steps/test-check-all/logs/stdio

Dec 6 2019, 2:25 PM · Restricted Project
zahiraam committed rGa3b2552575d3: Fix for PR44000. Optimization record for bytecode input missing. Review is here… (authored by zahiraam).
Fix for PR44000. Optimization record for bytecode input missing. Review is here…
Dec 6 2019, 4:57 AM

Dec 4 2019

zahiraam updated the diff for D70691: Optimization record for bytecode input missing- PR44000.
Dec 4 2019, 9:51 AM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

Fixed the indentation. Thanks.

Dec 4 2019, 9:51 AM · Restricted Project
zahiraam updated the diff for D70691: Optimization record for bytecode input missing- PR44000.
Dec 4 2019, 8:45 AM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

Changed it. Thanks.

Dec 4 2019, 8:45 AM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

Thanks for the review. Please let me know if I have addressed everything.

Dec 4 2019, 8:08 AM · Restricted Project
zahiraam updated the diff for D70691: Optimization record for bytecode input missing- PR44000.
Dec 4 2019, 8:08 AM · Restricted Project

Nov 29 2019

zahiraam added a reviewer for D70691: Optimization record for bytecode input missing- PR44000: erichkeane.
Nov 29 2019, 6:03 AM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

After an (offline) review from @erichkeane (added now as a reviewer) , stripped the unnecessary code. Thanks.

Nov 29 2019, 6:03 AM · Restricted Project
zahiraam updated the diff for D70691: Optimization record for bytecode input missing- PR44000.
Nov 29 2019, 6:03 AM · Restricted Project