User Details
- User Since
- Apr 14 2017, 11:28 AM (208 w, 3 d)
Mon, Mar 15
Mar 12 2021
@aaron.ballman Thanks for that. Let's see if this one will work.
Mar 10 2021
Let's see if this time it worked. Thanks.
Mar 8 2021
Jan 26 2021
Jan 20 2021
Jan 13 2021
Dec 1 2020
Nov 30 2020
Nov 25 2020
Nov 11 2020
I am not really convinced that this is an openmp issue. If I take the same test case but remove one level of instantiation, the test cases compiles without hitting the assertion.
template <typename T>
struct z {
static void aj() { T f;
#pragma omp target map(f)
; }
};
template <int> struct as {};
template class z<as<4>>;
I think the issue is that Sema::FindAssociatedClassesAndNamespaces is entered with a null location and noone inside addAssociatedClassesAndNamespaces updates the field Instantiation of Result.
I am proposing this fix to remedy to it. Not sure what you think of this?
Thanks.
Nov 10 2020
Nov 6 2020
Merged in https://reviews.llvm.org/rGe562a40871da.
Oct 27 2020
Oct 26 2020
Oct 22 2020
Oct 21 2020
Oct 20 2020
Oct 9 2020
Any feedback please?
Oct 6 2020
Sep 30 2020
Sep 28 2020
Sep 23 2020
Sep 22 2020
Aug 10 2020
Review anyone please? Thanks.
Jul 30 2020
This patch is only to fix the compiler crash.
Would you mind commenting/reviewing this patch as it is a crash with (internal) impact?
There would still be another bug that needs fixing (would prefer to open another bug for it), for this case:
class __declspec(dllexport) foo {
foo(int x = 0);
};
Jul 28 2020
I actually made an attempt to commit the patch using arc but not sure it made it. This was my last command: git commit --amend -a
Do I need to push now?
Thanks.
Can someone submit it please? Thanks.
Jul 27 2020
Review please? Thanks.
Jul 22 2020
Jul 21 2020
Jul 19 2020
Jul 17 2020
Jun 16 2020
@hans Thanks for the feedback.
@riccibruno Thanks for the feedback.
Jun 10 2020
@hans Thanks for looking at it. I think the updated patch is a better way to handle the crash.
Jun 9 2020
@majnemer Any feedback? Thanks.
May 23 2020
May 20 2020
May 18 2020
May 7 2020
Dec 9 2019
Got other build fails.
Doesn't the LIT test require a:
// REQUIRES: x86-registered-target
command?
Dec 8 2019
Dec 6 2019
This might be easier to read the edit that I have made:
ksh-3.2$ git diff
diff --git a/clang/test/CodeGen/opt-record-1.c b/clang/test/CodeGen/opt-record-1.c
index 3f37e32..00a753d 100644
- a/clang/test/CodeGen/opt-record-1.c
+++ b/clang/test/CodeGen/opt-record-1.c
@@ -1,12 +1,12 @@
- RUN: %clang_cc1 %s -opt-record-file=t1.opt -fopenmp -emit-llvm-bc -o %t.bc
- RUN: %clang_cc1 -x ir %t.bc -opt-record-file %t.opt -fopenmp -emit-obj
+ RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-cpu x86-64 %s -O3 -opt-record-file=t1.opt -fopenmp -emit-llvm-bc -o %t.bc
+ RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-cpu x86-64 -O3 -x ir %t.bc -opt-record-file %t.opt -fopenmp -emit-obj
// RUN: cat %t.opt | FileCheck -check-prefix=CHECK %s
If you agree with the edit I will commit the change. Thanks.
Please see the edit in the list test. Fixed the build issue that occurred in the buildbot:
http://lab.llvm.org:8011/builders/clang-x86_64-debian-new-pass-manager-fast/builds/232/steps/test-check-all/logs/stdio
Dec 4 2019
Fixed the indentation. Thanks.
Changed it. Thanks.
Thanks for the review. Please let me know if I have addressed everything.
Nov 29 2019
After an (offline) review from @erichkeane (added now as a reviewer) , stripped the unnecessary code. Thanks.