Page MenuHomePhabricator

zahiraam (Zahira Ammarguellat)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2017, 11:28 AM (310 w, 1 d)

Recent Activity

Fri, Mar 24

zahiraam added a comment to D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method.

Okay, so modifying math.h to use this attribute is acceptable? That's great, that's definitely the best outcome for the compiler.

Just a minor request about the diagnostic name, but otherwise LGTM.

Yes. Added the attribute inside the included math.h header file.

How does this work for, say, glibc, musl, or MSVC CRT? Won't those math.h headers lack the attribute and thus run into problems when used with Clang?

Fri, Mar 24, 1:20 PM · Restricted Project, Restricted Project
zahiraam added a comment to D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method.

Okay, so modifying math.h to use this attribute is acceptable? That's great, that's definitely the best outcome for the compiler.

Just a minor request about the diagnostic name, but otherwise LGTM.

Fri, Mar 24, 12:08 PM · Restricted Project, Restricted Project
zahiraam updated the diff for D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method.
Fri, Mar 24, 11:35 AM · Restricted Project, Restricted Project
zahiraam updated the diff for D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method.
Fri, Mar 24, 8:53 AM · Restricted Project, Restricted Project

Thu, Mar 23

zahiraam added a comment to D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method.

The user isn't modifying the float_t type definition, they're using it. I think the diagnostic should say something like cannot use type 'float_t' within '#pragma clang fp eval_method'; type is set according to the default eval method for the translation unit.

Is there any way we can infer an attribute for these typedefs when they're declared, then diagnose it in DiagnoseUseOfDecl? Some sort of "available_only_in_default_eval_method" attribute?

Thu, Mar 23, 11:22 AM · Restricted Project, Restricted Project
zahiraam updated the diff for D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method.
Thu, Mar 23, 11:19 AM · Restricted Project, Restricted Project

Wed, Mar 22

zahiraam updated the diff for D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method.
Wed, Mar 22, 7:33 AM · Restricted Project, Restricted Project

Tue, Mar 21

zahiraam added inline comments to D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method.
Tue, Mar 21, 1:01 PM · Restricted Project, Restricted Project
zahiraam updated the diff for D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method.
Tue, Mar 21, 1:01 PM · Restricted Project, Restricted Project

Wed, Mar 15

zahiraam requested review of D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method.
Wed, Mar 15, 9:07 AM · Restricted Project, Restricted Project

Fri, Mar 10

zahiraam added a reverting change for rGbbf0d1932a3c: Currently the control of the eval-method is mixed with fast-math.: rG2f1264260b37: Revert "Currently the control of the eval-method is mixed with fast-math.".
Fri, Mar 10, 11:45 AM · Restricted Project
zahiraam committed rG2f1264260b37: Revert "Currently the control of the eval-method is mixed with fast-math." (authored by zahiraam).
Revert "Currently the control of the eval-method is mixed with fast-math."
Fri, Mar 10, 11:44 AM · Restricted Project, Restricted Project
zahiraam added a reverting change for D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.: rG2f1264260b37: Revert "Currently the control of the eval-method is mixed with fast-math.".
Fri, Mar 10, 11:44 AM · Restricted Project, Restricted Project
zahiraam added a comment to D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled.".

LGTM! If you don't hear otherwise from @kito-cheng, @bjope, @Wilco1 in the next ~4 hours, feel free to land.

Fri, Mar 10, 5:38 AM · Restricted Project, Restricted Project

Thu, Mar 9

zahiraam updated the diff for D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled.".
Thu, Mar 9, 11:38 AM · Restricted Project, Restricted Project
zahiraam updated the diff for D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled.".
Thu, Mar 9, 11:34 AM · Restricted Project, Restricted Project
zahiraam added a comment to D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled.".

Thank you for working on this! Because this is fixing an ABI break, if we can land this in time for the release candidate I think we should try to add this to 16.0 to limit damage. CC @tstellar for his opinion.

This doesn't seem to fully revert bbf0d1932a3c1be970ed8a580e51edf571b80fd5; that commit changed clang/lib/Sema/Sema.cpp but this commit does not back those changes out. Is that intentional?

Thu, Mar 9, 11:33 AM · Restricted Project, Restricted Project
zahiraam updated subscribers of D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled.".

Tagging @davemgreen, @kito-cheng, @bjope and @Wilco1 for awareness.

Thu, Mar 9, 10:29 AM · Restricted Project, Restricted Project
zahiraam added a reverting change for rGbbf0d1932a3c: Currently the control of the eval-method is mixed with fast-math.: D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled.".
Thu, Mar 9, 10:24 AM · Restricted Project
zahiraam requested review of D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled.".
Thu, Mar 9, 10:24 AM · Restricted Project, Restricted Project
zahiraam added a reverting change for D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.: D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled.".
Thu, Mar 9, 10:24 AM · Restricted Project, Restricted Project

Wed, Mar 8

zahiraam accepted D145071: [clang][RISCV] Set HasLegalHalfType to true if zfh is enabled.
Wed, Mar 8, 10:35 AM · Restricted Project

Mon, Mar 6

zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Mon, Mar 6, 1:29 PM · Restricted Project, Restricted Project

Fri, Mar 3

zahiraam added a comment to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..

Would be nice to have feedback on this! So much work was put into it! @rnk, @efriedma

Fri, Mar 3, 1:28 PM · Restricted Project, Restricted Project

Thu, Mar 2

zahiraam added a comment to D145071: [clang][RISCV] Set HasLegalHalfType to true if zfh is enabled.

HasFloat16 is unconditionally true for Arm and only gated on SSE2 support for X86

My understanding of that is because all aarch64 implementations support ARMv8 FP which makes half type for this target legal. Setting both HasLegalHalfType and HasFloat16 makes sense.
That's not the case for x86. HasLegalHalfType needs the avx512fp16 feature to be set.

Thu, Mar 2, 8:59 AM · Restricted Project

Feb 22 2023

zahiraam closed D144299: [NFC] Added a lit test for the arithmetic fence builtin..
Feb 22 2023, 8:59 AM · Restricted Project, Restricted Project

Feb 21 2023

zahiraam committed rGa790d777465c: [NFC] Added a lit test for the arithmetic fence builtin. (authored by zahiraam).
[NFC] Added a lit test for the arithmetic fence builtin.
Feb 21 2023, 5:33 AM · Restricted Project, Restricted Project

Feb 17 2023

zahiraam requested review of D144299: [NFC] Added a lit test for the arithmetic fence builtin..
Feb 17 2023, 1:56 PM · Restricted Project, Restricted Project
zahiraam added a comment to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..

ping?

Feb 17 2023, 1:55 PM · Restricted Project, Restricted Project

Feb 1 2023

zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Feb 1 2023, 1:12 PM · Restricted Project, Restricted Project

Jan 31 2023

zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Jan 31 2023, 1:55 PM · Restricted Project, Restricted Project

Jan 30 2023

zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Jan 30 2023, 1:56 PM · Restricted Project, Restricted Project

Jan 26 2023

zahiraam committed rGb4b06d8ff826: __arithmetic_fence enforces ordering on expression evaluation when fast-math (authored by zahiraam).
__arithmetic_fence enforces ordering on expression evaluation when fast-math
Jan 26 2023, 11:19 AM · Restricted Project, Restricted Project
zahiraam closed D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target..
Jan 26 2023, 11:18 AM · Restricted Project, Restricted Project
zahiraam added a comment to D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target..

LGTM. Thanks!

Jan 26 2023, 9:38 AM · Restricted Project, Restricted Project
zahiraam added inline comments to D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target..
Jan 26 2023, 9:21 AM · Restricted Project, Restricted Project
zahiraam updated the diff for D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target..
Jan 26 2023, 9:20 AM · Restricted Project, Restricted Project
zahiraam updated the diff for D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target..
Jan 26 2023, 5:41 AM · Restricted Project, Restricted Project
zahiraam retitled D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target. from [SPIR] Add support for __arithmetic_fence builtin for SPIR targets. to [SPIR] Add support for __arithmetic_fence builtin for SPIR target..
Jan 26 2023, 4:49 AM · Restricted Project, Restricted Project
zahiraam retitled D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target. from [SPIR-V] Add support for __arithmetic_fence builtin for SYCL targets. to [SPIR] Add support for __arithmetic_fence builtin for SPIR targets..
Jan 26 2023, 4:48 AM · Restricted Project, Restricted Project

Jan 25 2023

zahiraam requested review of D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target..
Jan 25 2023, 2:21 PM · Restricted Project, Restricted Project

Jan 24 2023

zahiraam added a comment to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..

Thanks. Please see my comments/questions.

Jan 24 2023, 8:30 AM · Restricted Project, Restricted Project
zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Jan 24 2023, 8:30 AM · Restricted Project, Restricted Project

Jan 23 2023

zahiraam updated subscribers of D142367: Add support for clang-cl's option -fexcess-precision..

@thakis I think this should fix the clang-cl use with the Mac OS compiler.

Jan 23 2023, 9:09 AM · Restricted Project, Restricted Project
zahiraam committed rG3759ef9e56dc: Add support for clang-cl's option `-fexcess-precision`. (authored by zahiraam).
Add support for clang-cl's option `-fexcess-precision`.
Jan 23 2023, 9:08 AM · Restricted Project, Restricted Project
zahiraam closed D142367: Add support for clang-cl's option -fexcess-precision..
Jan 23 2023, 9:08 AM · Restricted Project, Restricted Project
zahiraam requested review of D142367: Add support for clang-cl's option -fexcess-precision..
Jan 23 2023, 7:45 AM · Restricted Project, Restricted Project

Jan 20 2023

zahiraam added a comment to D141929: Add support for clang-cl's option -fexcess-precision..

This breaks tests on macOS: http://45.33.8.238/macm1/53215/step_7.txt

Please take a look and revert for now if it takes a while to fix.

Jan 20 2023, 1:46 PM · Restricted Project, Restricted Project
zahiraam added a reverting change for rG47074683c906: Add support for clang-cl's option `-fexcess-precision`.: rGf97cdc013fe7: Revert "Add support for clang-cl's option `-fexcess-precision`.".
Jan 20 2023, 1:45 PM · Restricted Project, Restricted Project
zahiraam committed rGf97cdc013fe7: Revert "Add support for clang-cl's option `-fexcess-precision`." (authored by zahiraam).
Revert "Add support for clang-cl's option `-fexcess-precision`."
Jan 20 2023, 1:45 PM · Restricted Project, Restricted Project
zahiraam added a reverting change for D141929: Add support for clang-cl's option -fexcess-precision.: rGf97cdc013fe7: Revert "Add support for clang-cl's option `-fexcess-precision`.".
Jan 20 2023, 1:45 PM · Restricted Project, Restricted Project
zahiraam committed rG47074683c906: Add support for clang-cl's option `-fexcess-precision`. (authored by zahiraam).
Add support for clang-cl's option `-fexcess-precision`.
Jan 20 2023, 8:26 AM · Restricted Project, Restricted Project
zahiraam closed D141929: Add support for clang-cl's option -fexcess-precision..
Jan 20 2023, 8:25 AM · Restricted Project, Restricted Project
zahiraam retitled D141929: Add support for clang-cl's option -fexcess-precision. from Add support for clang-cl's option /fexcess-precision. to Add support for clang-cl's option -fexcess-precision..
Jan 20 2023, 5:26 AM · Restricted Project, Restricted Project

Jan 18 2023

zahiraam updated the diff for D141929: Add support for clang-cl's option -fexcess-precision..
Jan 18 2023, 8:34 AM · Restricted Project, Restricted Project

Jan 17 2023

zahiraam updated the diff for D141929: Add support for clang-cl's option -fexcess-precision..
Jan 17 2023, 8:21 AM · Restricted Project, Restricted Project
zahiraam retitled D141929: Add support for clang-cl's option -fexcess-precision. from Add support for clang-cl's option /Qfexcess-precision. to Add support for clang-cl's option /fexcess-precision..
Jan 17 2023, 8:21 AM · Restricted Project, Restricted Project
zahiraam requested review of D141929: Add support for clang-cl's option -fexcess-precision..
Jan 17 2023, 6:15 AM · Restricted Project, Restricted Project

Jan 9 2023

zahiraam added a comment to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..

ping.

Jan 9 2023, 12:03 PM · Restricted Project, Restricted Project

Jan 5 2023

zahiraam committed rG85d049a089d4: Implement support for option 'fexcess-precision'. (authored by zahiraam).
Implement support for option 'fexcess-precision'.
Jan 5 2023, 6:36 AM · Restricted Project, Restricted Project

Jan 4 2023

zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Jan 4 2023, 7:09 AM · Restricted Project, Restricted Project
zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Jan 4 2023, 7:05 AM · Restricted Project, Restricted Project

Dec 22 2022

zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 22 2022, 7:50 AM · Restricted Project, Restricted Project
zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 22 2022, 6:24 AM · Restricted Project, Restricted Project

Dec 21 2022

zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 21 2022, 1:46 PM · Restricted Project, Restricted Project
zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 21 2022, 1:46 PM · Restricted Project, Restricted Project
zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 21 2022, 7:04 AM · Restricted Project, Restricted Project

Dec 20 2022

zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 20 2022, 8:06 AM · Restricted Project, Restricted Project
zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 20 2022, 8:05 AM · Restricted Project, Restricted Project
zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 20 2022, 6:57 AM · Restricted Project, Restricted Project
zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 20 2022, 6:56 AM · Restricted Project, Restricted Project
zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 20 2022, 6:51 AM · Restricted Project, Restricted Project

Dec 19 2022

zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 19 2022, 2:56 PM · Restricted Project, Restricted Project
zahiraam added a comment to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 19 2022, 1:50 PM · Restricted Project, Restricted Project
zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 19 2022, 1:50 PM · Restricted Project, Restricted Project
zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 19 2022, 10:38 AM · Restricted Project, Restricted Project

Dec 16 2022

zahiraam added a comment to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..

Not sure exactly what code that generates in its current form, but that's roughly the right idea, yes.

Dec 16 2022, 7:02 AM · Restricted Project, Restricted Project

Dec 15 2022

zahiraam added a comment to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..

This uploaded patch is a draft (LIT tests fails but are not updated since I am not sure about these changes) that I am part way confident about. There are still a lot of things that I need to look at, but would you mind looking at it to see if this is moving in the right direction?

Dec 15 2022, 1:32 PM · Restricted Project, Restricted Project
zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 15 2022, 1:31 PM · Restricted Project, Restricted Project

Dec 9 2022

zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 9 2022, 11:11 AM · Restricted Project, Restricted Project

Dec 8 2022

zahiraam added inline comments to D139629: clang: Stop emitting "strictfp".
Dec 8 2022, 1:54 PM · Restricted Project
zahiraam added a comment to D139629: clang: Stop emitting "strictfp".

Can you please be more verbose in your summary? This change is related to the use of -ffp-exception-behavior=strict right?
This attribute is set here https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenFunction.cpp#L987 but under a condition. Is that condition always satisfied when the attribute needs to be set?

Dec 8 2022, 10:03 AM · Restricted Project
zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 8 2022, 7:27 AM · Restricted Project, Restricted Project

Dec 7 2022

zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 7 2022, 1:10 PM · Restricted Project, Restricted Project
zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 7 2022, 1:08 PM · Restricted Project, Restricted Project
zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 7 2022, 10:05 AM · Restricted Project, Restricted Project

Dec 6 2022

zahiraam updated subscribers of D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..

@eli.friedman Thanks.

Dec 6 2022, 12:15 PM · Restricted Project, Restricted Project
zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 6 2022, 12:15 PM · Restricted Project, Restricted Project

Dec 5 2022

zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 5 2022, 2:39 PM · Restricted Project, Restricted Project

Dec 2 2022

zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 2 2022, 8:47 AM · Restricted Project, Restricted Project

Dec 1 2022

zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Dec 1 2022, 8:36 AM · Restricted Project, Restricted Project
zahiraam accepted D138117: [clang][docs] Correct floating point option explanations.

Addressed to @zahiraam's comment

Dec 1 2022, 6:59 AM · Restricted Project, Restricted Project

Nov 30 2022

zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Nov 30 2022, 2:52 PM · Restricted Project, Restricted Project
zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Nov 30 2022, 2:31 PM · Restricted Project, Restricted Project
zahiraam added inline comments to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Nov 30 2022, 7:03 AM · Restricted Project, Restricted Project

Nov 29 2022

zahiraam added a comment to D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..

There are multiple notions of "constant" here:

  • Whether a value is invariant at runtime.
  • Whether a value is legal in a "constexpr" expression.
  • Whether we can emit a constant without emitting code that runs at startup to initialize it.

The third is generally a superset of the second; most targets have relocations that allow us emit the address of a global variable into another global variable. dllimport variables are an exception: even though the address is constant, we can't emit a relocation.

To make this work, what we need to do is:

  • Extend the notion of a "constant" in the AST/Sema to allow dllimport variables. (There should be code specifically checking for dllimport variables; we just need to drop that check.)
  • Teach IR generation (clang/lib/CodeGen) how to emit constants that don't have a relocation. This probably means a check that if we're generating the initializer for a global variable, and the initializer refers to the address of a dllimport variable, we instead emit a global constructor. (Maybe with a higher priority that normal global constructor, so the user can't accidentally observe an uninitialized variable? I forget if MSVC actually has constructor priorities...). Or I guess as an initial patch, we could just emit an error if we detect this case.
Nov 29 2022, 3:20 PM · Restricted Project, Restricted Project
zahiraam updated the diff for D137107: Allow MS extension: support of constexpr with __declspec(dllimport)..
Nov 29 2022, 3:19 PM · Restricted Project, Restricted Project
zahiraam added inline comments to D138117: [clang][docs] Correct floating point option explanations.
Nov 29 2022, 5:58 AM · Restricted Project, Restricted Project

Nov 17 2022

zahiraam accepted D137618: [Clang] Fix behavior of -ffp-model option when overriden.
Nov 17 2022, 6:42 AM · Restricted Project, Restricted Project
zahiraam added a comment to D137618: [Clang] Fix behavior of -ffp-model option when overriden.

Looks good to me after the additional RUN line mentioned in my comment for Driver/fp-model.c is added. Thanks.

Nov 17 2022, 6:42 AM · Restricted Project, Restricted Project