User Details
User Details
- User Since
- Apr 14 2017, 11:28 AM (267 w, 23 h)
Apr 21 2022
Apr 21 2022
zahiraam updated the diff for D124095: [WIP] Experimental changes.
Apr 21 2022, 4:29 AM · Restricted Project
Apr 20 2022
Apr 20 2022
zahiraam added inline comments to D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__.
zahiraam updated the diff for D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__.
zahiraam updated the summary of D123630: [WIP] Remove connection between 'ffast-math' and 'ffp-contract'..
zahiraam requested review of D124095: [WIP] Experimental changes.
Apr 20 2022, 8:42 AM · Restricted Project
Apr 19 2022
Apr 19 2022
zahiraam requested review of D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__.
zahiraam added inline comments to D124004: Define __FLT_EVAL_METHOD__ when input source is stdin..
zahiraam added inline comments to D124004: Define __FLT_EVAL_METHOD__ when input source is stdin..
zahiraam updated subscribers of D124004: Define __FLT_EVAL_METHOD__ when input source is stdin..
zahiraam requested review of D124004: Define __FLT_EVAL_METHOD__ when input source is stdin..
Apr 13 2022
Apr 13 2022
zahiraam retitled D123630: [WIP] Remove connection between 'ffast-math' and 'ffp-contract'. from Remove connection between 'ffast-math' and 'ffp-contract'. to [WIP] Remove connection between 'ffast-math' and 'ffp-contract'..
Apr 12 2022
Apr 12 2022
zahiraam requested review of D123630: [WIP] Remove connection between 'ffast-math' and 'ffp-contract'..
Herald added a project to D119290: [Clang] Add support for -fcx-limited-range, -fcx-fortran-rules options.: Restricted Project.
Apr 5 2022
Apr 5 2022
zahiraam committed rG4d165ad7d9b3: In fast-math mode, when unsafe math optimizations are enabled, the (authored by zahiraam).
In fast-math mode, when unsafe math optimizations are enabled, the
Apr 4 2022
Apr 4 2022
Apr 3 2022
Apr 3 2022
Apr 1 2022
Apr 1 2022
Mar 29 2022
Mar 29 2022
Mar 28 2022
Mar 28 2022
Mar 25 2022
Mar 25 2022
Mar 23 2022
Mar 23 2022
zahiraam added a comment to D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
zahiraam committed rGb0bc93da926a: Revert "[clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially… (authored by zahiraam).
Revert "[clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially…
Mar 23 2022, 4:54 AM · Restricted Project
Mar 22 2022
Mar 22 2022
Mar 21 2022
Mar 21 2022
zahiraam added a comment to D118837: Methods visited for a special class must have an identifier..
Mar 17 2022
Mar 17 2022
zahiraam committed rGbbf0d1932a3c: Currently the control of the eval-method is mixed with fast-math. (authored by zahiraam).
Currently the control of the eval-method is mixed with fast-math.
Mar 17 2022, 11:48 AM · Restricted Project
zahiraam updated the diff for D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
zahiraam updated the diff for D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
Mar 11 2022
Mar 11 2022
zahiraam updated the diff for D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
zahiraam added inline comments to D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
zahiraam updated the diff for D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
Mar 10 2022
Mar 10 2022
zahiraam committed rG15ef06f453c6: Diagnose when `#pragma clang fp eval_method` doesn't have a supported value. (authored by zahiraam).
Diagnose when `#pragma clang fp eval_method` doesn't have a supported value.
Mar 10 2022, 1:20 PM · Restricted Project
zahiraam added inline comments to D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
zahiraam updated the diff for D121380: Pragma `clang fp eval_method` needs to take as input a supported value..
zahiraam updated the diff for D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
zahiraam updated the diff for D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
zahiraam added inline comments to D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
zahiraam updated the diff for D121380: Pragma `clang fp eval_method` needs to take as input a supported value..
zahiraam updated the diff for D121380: Pragma `clang fp eval_method` needs to take as input a supported value..
zahiraam requested review of D121380: Pragma `clang fp eval_method` needs to take as input a supported value..
Mar 9 2022
Mar 9 2022
zahiraam updated the diff for D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
Mar 8 2022
Mar 8 2022
zahiraam added inline comments to D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
zahiraam updated the diff for D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
zahiraam updated the summary of D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
Mar 7 2022
Mar 7 2022
zahiraam requested review of D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled..
Feb 23 2022
Feb 23 2022
zahiraam committed rG1592d88aa7bc: Add support for floating-point option `ffp-eval-method` and for (authored by zahiraam).
Add support for floating-point option `ffp-eval-method` and for
Feb 22 2022
Feb 22 2022
zahiraam added a comment to D120155: FLT_EVAL_METHOD should always be set.
@MaskRay Thanks. Will do that.
zahiraam added a comment to D120155: FLT_EVAL_METHOD should always be set.
Thanks @aaron.ballman
Feb 20 2022
Feb 20 2022
zahiraam updated the diff for D120155: FLT_EVAL_METHOD should always be set.
Feb 18 2022
Feb 18 2022
zahiraam requested review of D120155: FLT_EVAL_METHOD should always be set.
Feb 17 2022
Feb 17 2022
zahiraam committed rG4dfa68e48313: [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue. (authored by zahiraam).
[NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue.
zahiraam committed rG32b73bc6ab82: Add support for floating-point option `ffp-eval-method` and for (authored by zahiraam).
Add support for floating-point option `ffp-eval-method` and for
zahiraam updated the summary of D120066: [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue..
Feb 17 2022, 8:54 AM · Restricted Project
zahiraam retitled D120066: [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue. from FileCheck’s regexp stumped on Windows. to [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue..
Feb 17 2022, 8:53 AM · Restricted Project
zahiraam updated the diff for D120066: [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue..
Feb 17 2022, 8:52 AM · Restricted Project
zahiraam requested review of D120066: [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue..
Feb 17 2022, 8:28 AM · Restricted Project
Feb 15 2022
Feb 15 2022
zahiraam committed rG4bafe65c2b2f: Add support for floating-point option `ffp-eval-method` and for (authored by zahiraam).
Add support for floating-point option `ffp-eval-method` and for
Feb 9 2022
Feb 9 2022
zahiraam added a comment to D117569: Constexpr not supported with __declspec(dllimport)..
@majnemer Review please :)
Feb 9 2022, 12:53 PM · Restricted Project
Feb 8 2022
Feb 8 2022
zahiraam committed rT6da025eb78f7: Getting previous behavior of FMA for SPEC2006 (authored by zahiraam).
Getting previous behavior of FMA for SPEC2006
Feb 7 2022
Feb 7 2022
zahiraam updated the diff for D117569: Constexpr not supported with __declspec(dllimport)..
Feb 7 2022, 6:50 AM · Restricted Project
Feb 3 2022
Feb 3 2022
zahiraam updated the diff for D117569: Constexpr not supported with __declspec(dllimport)..
Feb 3 2022, 1:47 PM · Restricted Project
Feb 2 2022
Feb 2 2022
zahiraam committed rGe692654a4dc0: The methods visited for a special class must have an identifier. (authored by zahiraam).
The methods visited for a special class must have an identifier.
zahiraam requested review of D118837: Methods visited for a special class must have an identifier..
Jan 31 2022
Jan 31 2022
zahiraam added a comment to D117569: Constexpr not supported with __declspec(dllimport)..
@majnemer Any feedback please? thanks.
Jan 31 2022, 10:03 AM · Restricted Project
zahiraam updated the diff for D117569: Constexpr not supported with __declspec(dllimport)..
Jan 31 2022, 10:02 AM · Restricted Project
Jan 29 2022
Jan 29 2022
zahiraam added a comment to D114483: [SYCL] Add support for sycl_special_class attribute.
Jan 29 2022, 6:47 AM · Restricted Project
zahiraam added a comment to D114483: [SYCL] Add support for sycl_special_class attribute.
@MaskRay OK thanks. I see other clang-format issues. Should those be fixed too?
Jan 29 2022, 6:15 AM · Restricted Project
Jan 26 2022
Jan 26 2022
zahiraam updated the diff for D117569: Constexpr not supported with __declspec(dllimport)..
Jan 26 2022, 12:18 PM · Restricted Project
zahiraam updated the diff for D117569: Constexpr not supported with __declspec(dllimport)..
Jan 26 2022, 11:38 AM · Restricted Project
Jan 25 2022
Jan 25 2022
zahiraam committed rG8ba9c794feb3: Add support for sycl_special_class attribute. (authored by zahiraam).
Add support for sycl_special_class attribute.
zahiraam added a comment to D114483: [SYCL] Add support for sycl_special_class attribute.
Thanks for the reviews.
Jan 25 2022, 7:05 AM · Restricted Project
zahiraam updated the diff for D114483: [SYCL] Add support for sycl_special_class attribute.
Jan 25 2022, 7:05 AM · Restricted Project
zahiraam updated the diff for D114483: [SYCL] Add support for sycl_special_class attribute.
Jan 25 2022, 4:39 AM · Restricted Project
Jan 24 2022
Jan 24 2022
zahiraam updated the diff for D114483: [SYCL] Add support for sycl_special_class attribute.
Jan 24 2022, 2:08 PM · Restricted Project
zahiraam added inline comments to D114483: [SYCL] Add support for sycl_special_class attribute.
Jan 24 2022, 12:00 PM · Restricted Project
zahiraam added a comment to D117569: Constexpr not supported with __declspec(dllimport)..
Jan 24 2022, 7:59 AM · Restricted Project
Jan 21 2022
Jan 21 2022
zahiraam added a comment to D117569: Constexpr not supported with __declspec(dllimport)..
I did take an example completely different with no use of the constexpr in order to understand (at least for me) when the _imp prefix is generated with CL.
This is sample.cpp:
#include<iostream>
Jan 21 2022, 2:25 PM · Restricted Project
Jan 20 2022
Jan 20 2022
zahiraam added a comment to D117569: Constexpr not supported with __declspec(dllimport)..
Jan 20 2022, 6:19 PM · Restricted Project
zahiraam added a comment to D117569: Constexpr not supported with __declspec(dllimport)..
Jan 20 2022, 3:13 PM · Restricted Project
zahiraam updated the diff for D117569: Constexpr not supported with __declspec(dllimport)..
Jan 20 2022, 8:00 AM · Restricted Project
zahiraam added a comment to D117569: Constexpr not supported with __declspec(dllimport)..
Jan 20 2022, 7:45 AM · Restricted Project
Jan 19 2022
Jan 19 2022
zahiraam updated the diff for D117569: Constexpr not supported with __declspec(dllimport)..
Jan 19 2022, 2:59 PM · Restricted Project
Jan 18 2022
Jan 18 2022
zahiraam requested review of D117569: Constexpr not supported with __declspec(dllimport)..
Jan 18 2022, 8:52 AM · Restricted Project
Jan 14 2022
Jan 14 2022
zahiraam added a comment to D114483: [SYCL] Add support for sycl_special_class attribute.
@Fznamznon @bader @Naghasan reviews please? Thanks.
Jan 14 2022, 9:54 AM · Restricted Project
Jan 4 2022
Jan 4 2022
zahiraam added a comment to D76038: PR45000: Let Sema::SubstParmVarDecl handle default args of lambdas in initializers.
This change is generating this crash discussed here: https://bugs.llvm.org/show_bug.cgi?id=49834
@aaronpuchert do you have any fix for it?