Page MenuHomePhabricator

zahiraam (Zahira Ammarguellat)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 14 2017, 11:28 AM (179 w, 2 d)

Recent Activity

Aug 10 2020

zahiraam added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

Review anyone please? Thanks.

Aug 10 2020, 1:09 PM

Jul 30 2020

zahiraam updated the diff for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

This patch is only to fix the compiler crash.
Would you mind commenting/reviewing this patch as it is a crash with (internal) impact?
There would still be another bug that needs fixing (would prefer to open another bug for it), for this case:
class __declspec(dllexport) foo {

foo(int x = 0);

};

Jul 30 2020, 10:44 AM
zahiraam retitled D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion. from Fix for Bug45811 - Failed assertion to Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
Jul 30 2020, 10:42 AM

Jul 28 2020

zahiraam added a comment to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..

I actually made an attempt to commit the patch using arc but not sure it made it. This was my last command: git commit --amend -a
Do I need to push now?
Thanks.

You can use arc land --revision D84038 or you can check what you're about to push: git fetch origin && git log ^origin/master HEAD ; if this is the commit you intend to push and the commit message is satisfying, then just push it.

If you don't have push permissions, you need to ask here for someone to land it for you.

Jul 28 2020, 12:45 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam added a comment to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..

I actually made an attempt to commit the patch using arc but not sure it made it. This was my last command: git commit --amend -a
Do I need to push now?
Thanks.

Jul 28 2020, 11:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam requested review of D84780: Setting the /bigobj option globally for Windows debug build. https://bugs.llvm.org/show_bug.cgi?id=46733.
Jul 28 2020, 11:34 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam added a comment to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..

Can someone submit it please? Thanks.

Jul 28 2020, 10:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam added inline comments to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..
Jul 28 2020, 5:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam updated the diff for D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..
Jul 28 2020, 5:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam retitled D84038: On Windows build, making the /bigobj flag global , instead of passing it per file. from Passing the flag bigobj globally when building debug compiler on Windows to On Windows build, making the /bigobj flag global , instead of passing it per file..
Jul 28 2020, 5:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 27 2020

zahiraam added a comment to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..

Review please? Thanks.

Jul 27 2020, 2:39 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 22 2020

zahiraam updated the diff for D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..
Jul 22 2020, 6:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 21 2020

zahiraam added a comment to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..

Sadly I think @rnk isn't around. This is something I'd really like him to weigh in on. I assume there was a reason for doing this per-object file rather than for everything, and I don't have the context.

Jul 21 2020, 1:35 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
zahiraam updated the diff for D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..
Jul 21 2020, 12:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 19 2020

zahiraam updated the diff for D84038: On Windows build, making the /bigobj flag global , instead of passing it per file..
Jul 19 2020, 11:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 17 2020

Herald added projects to D84038: On Windows build, making the /bigobj flag global , instead of passing it per file.: Restricted Project, Restricted Project.
Jul 17 2020, 8:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jun 16 2020

zahiraam added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

@hans Thanks for the feedback.
@riccibruno Thanks for the feedback.

Jun 16 2020, 1:44 PM
zahiraam updated the summary of D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
Jun 16 2020, 1:44 PM
zahiraam added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

I'm sorry, but I still don't understand, and neither will anyone who reads the new code, I think. It needs an explanation.

Jun 16 2020, 6:04 AM

Jun 10 2020

zahiraam added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
Jun 10 2020, 1:21 PM
zahiraam added inline comments to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
Jun 10 2020, 1:21 PM
zahiraam updated the diff for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
Jun 10 2020, 1:21 PM
zahiraam updated the diff for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
Jun 10 2020, 11:41 AM
zahiraam added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

@hans Thanks for looking at it. I think the updated patch is a better way to handle the crash.

Jun 10 2020, 11:41 AM

Jun 9 2020

zahiraam added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

@majnemer Any feedback? Thanks.

Jun 9 2020, 7:05 AM

May 23 2020

zahiraam updated the diff for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
May 23 2020, 7:24 AM

May 20 2020

zahiraam updated the diff for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
May 20 2020, 3:27 PM
zahiraam added a reviewer for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion.: hans.
May 20 2020, 3:27 PM

May 18 2020

zahiraam added inline comments to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
May 18 2020, 1:00 PM
zahiraam updated the diff for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
May 18 2020, 1:00 PM
zahiraam added a reviewer for D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion.: erichkeane.
May 18 2020, 8:34 AM

May 7 2020

zahiraam created D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..
May 7 2020, 10:47 AM

Dec 9 2019

zahiraam committed rG32c802e0f539: Fix build bot fails due to the patch here: https://reviews.llvm.org/D70691… (authored by zahiraam).
Fix build bot fails due to the patch here: https://reviews.llvm.org/D70691…
Dec 9 2019, 6:32 AM
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

I looked at the test failure, the REQUIRES line is necessary because the test calls emit-obj. I've asked Zahira to commit it to fix the bots.

Dec 9 2019, 6:31 AM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

Got other build fails.
Doesn't the LIT test require a:
// REQUIRES: x86-registered-target
command?

Dec 9 2019, 12:33 AM · Restricted Project

Dec 8 2019

zahiraam committed rG27f5d35137cb: Fix for build bot failure. For more details see: https://reviews.llvm. (authored by zahiraam).
Fix for build bot failure. For more details see: https://reviews.llvm.
Dec 8 2019, 9:58 PM
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

LGTM. Could you commit this soon to get the bots green again?

Dec 8 2019, 9:58 PM · Restricted Project

Dec 6 2019

zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

This might be easier to read the edit that I have made:
ksh-3.2$ git diff
diff --git a/clang/test/CodeGen/opt-record-1.c b/clang/test/CodeGen/opt-record-1.c
index 3f37e32..00a753d 100644

  • a/clang/test/CodeGen/opt-record-1.c

+++ b/clang/test/CodeGen/opt-record-1.c
@@ -1,12 +1,12 @@
- RUN: %clang_cc1 %s -opt-record-file=t1.opt -fopenmp -emit-llvm-bc -o %t.bc
-
RUN: %clang_cc1 -x ir %t.bc -opt-record-file %t.opt -fopenmp -emit-obj
+ RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-cpu x86-64 %s -O3 -opt-record-file=t1.opt -fopenmp -emit-llvm-bc -o %t.bc
+
RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-cpu x86-64 -O3 -x ir %t.bc -opt-record-file %t.opt -fopenmp -emit-obj
// RUN: cat %t.opt | FileCheck -check-prefix=CHECK %s

Dec 6 2019, 2:34 PM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

If you agree with the edit I will commit the change. Thanks.

Dec 6 2019, 2:25 PM · Restricted Project
zahiraam updated the diff for D70691: Optimization record for bytecode input missing- PR44000.
Dec 6 2019, 2:25 PM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

Please see the edit in the list test. Fixed the build issue that occurred in the buildbot:
http://lab.llvm.org:8011/builders/clang-x86_64-debian-new-pass-manager-fast/builds/232/steps/test-check-all/logs/stdio

Dec 6 2019, 2:25 PM · Restricted Project
zahiraam committed rGa3b2552575d3: Fix for PR44000. Optimization record for bytecode input missing. Review is here… (authored by zahiraam).
Fix for PR44000. Optimization record for bytecode input missing. Review is here…
Dec 6 2019, 4:57 AM

Dec 4 2019

zahiraam updated the diff for D70691: Optimization record for bytecode input missing- PR44000.
Dec 4 2019, 9:51 AM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

Fixed the indentation. Thanks.

Dec 4 2019, 9:51 AM · Restricted Project
zahiraam updated the diff for D70691: Optimization record for bytecode input missing- PR44000.
Dec 4 2019, 8:45 AM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

Changed it. Thanks.

Dec 4 2019, 8:45 AM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

Thanks for the review. Please let me know if I have addressed everything.

Dec 4 2019, 8:08 AM · Restricted Project
zahiraam updated the diff for D70691: Optimization record for bytecode input missing- PR44000.
Dec 4 2019, 8:08 AM · Restricted Project

Nov 29 2019

zahiraam added a reviewer for D70691: Optimization record for bytecode input missing- PR44000: erichkeane.
Nov 29 2019, 6:03 AM · Restricted Project
zahiraam added a comment to D70691: Optimization record for bytecode input missing- PR44000.

After an (offline) review from @erichkeane (added now as a reviewer) , stripped the unnecessary code. Thanks.

Nov 29 2019, 6:03 AM · Restricted Project
zahiraam updated the diff for D70691: Optimization record for bytecode input missing- PR44000.
Nov 29 2019, 6:03 AM · Restricted Project

Nov 26 2019

zahiraam added inline comments to D70691: Optimization record for bytecode input missing- PR44000.
Nov 26 2019, 7:30 AM · Restricted Project
zahiraam updated the diff for D70691: Optimization record for bytecode input missing- PR44000.
Nov 26 2019, 7:30 AM · Restricted Project

Nov 25 2019

zahiraam added a reviewer for D70691: Optimization record for bytecode input missing- PR44000: hfinkel.
Nov 25 2019, 11:50 AM · Restricted Project
zahiraam created D70691: Optimization record for bytecode input missing- PR44000.
Nov 25 2019, 11:50 AM · Restricted Project

Oct 14 2019

zahiraam added inline comments to D68521: [PATCH 25/27] [noalias] Clang CodeGen for restrict-qualified pointers.
Oct 14 2019, 2:13 PM · Restricted Project

Aug 8 2019

zahiraam added a comment to D65774: Removing redundant-move warnings generated by gcc9x..

Agree with all these comments -- I'm no expert on when and when not to std::move, but this is undoing changes I've made to fix buildbots on different compilers.

Aug 8 2019, 5:04 AM · Restricted Project

Aug 5 2019

zahiraam created D65774: Removing redundant-move warnings generated by gcc9x..
Aug 5 2019, 1:39 PM · Restricted Project

Jul 3 2019

zahiraam added inline comments to D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).
Jul 3 2019, 1:39 PM
zahiraam updated the diff for D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).

Thanks for the review.
I think and hope that I have responded to every issue you raised. Let me know if there are still pending issues.
Happy 4th!

Jul 3 2019, 1:39 PM

May 30 2019

zahiraam added a comment to D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).

A review please :-) Thanks.

May 30 2019, 7:07 AM

May 21 2019

zahiraam updated the diff for D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).
May 21 2019, 6:24 AM
zahiraam added a comment to D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).

And this patch actually fixes the bug. Thanks.

May 21 2019, 6:24 AM

May 20 2019

zahiraam updated the diff for D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).
May 20 2019, 5:56 AM
zahiraam added a comment to D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).

@rsmith I think I have made all the changes you have pointed out to. But please note that this new patch only impements an explicit AST representation of uuid in template arguments. It does not fix the bug for which this review was opened for.
I will take care of the bug in time. But before doing that I want to make sure that the changes required to give an explicit AST for uuid is correct.

May 20 2019, 5:55 AM

Apr 2 2019

zahiraam added a comment to D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).

There are still a few things I haven't addressed yet. Mostly because not sure there is another solution like getting rid of the map from StringRef to expr. The other issue is not adding new kind to ParsedAttr. There may be another way of doing it, but didn't look at it yet.
Meanwhile can you please let me know if you are happy with the current status of the implementation.

Apr 2 2019, 5:22 AM
zahiraam updated the diff for D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).
Apr 2 2019, 5:19 AM

Mar 19 2019

zahiraam updated the diff for D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).
Mar 19 2019, 12:56 PM
zahiraam added a comment to D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).

It would be nice to have a review for this year old (updated) patch. Thanks.

Mar 19 2019, 12:56 PM

Mar 18 2019

zahiraam added a comment to D45978: dllexport const variables must have external linkage..

LGTM!

Mar 18 2019, 6:49 AM

Mar 11 2019

zahiraam updated the diff for D45978: dllexport const variables must have external linkage..
Mar 11 2019, 10:55 AM
zahiraam added inline comments to D45978: dllexport const variables must have external linkage..
Mar 11 2019, 10:53 AM

Mar 8 2019

zahiraam added inline comments to D45978: dllexport const variables must have external linkage..
Mar 8 2019, 4:36 AM
zahiraam updated the diff for D45978: dllexport const variables must have external linkage..
Mar 8 2019, 4:36 AM

Mar 7 2019

zahiraam updated the diff for D45978: dllexport const variables must have external linkage..
Mar 7 2019, 12:33 AM

Feb 25 2019

zahiraam added a comment to D41950: Fix for Bug 8446. Template instantiation without a 'typename' keyword..
In D41950#1404899, @rnk wrote:

lgtm

Feb 25 2019, 9:41 AM · Restricted Project

Feb 23 2019

zahiraam added a comment to D45978: dllexport const variables must have external linkage..

Let's see if I have included every thing mentioned. Thanks.

Feb 23 2019, 6:40 AM
zahiraam updated the diff for D45978: dllexport const variables must have external linkage..
Feb 23 2019, 6:40 AM

Feb 20 2019

zahiraam updated the diff for D41950: Fix for Bug 8446. Template instantiation without a 'typename' keyword..
Feb 20 2019, 7:14 AM · Restricted Project
zahiraam added inline comments to D41950: Fix for Bug 8446. Template instantiation without a 'typename' keyword..
Feb 20 2019, 7:14 AM · Restricted Project

Feb 14 2019

zahiraam added inline comments to D41950: Fix for Bug 8446. Template instantiation without a 'typename' keyword..
Feb 14 2019, 6:54 AM · Restricted Project
zahiraam updated the diff for D41950: Fix for Bug 8446. Template instantiation without a 'typename' keyword..
Feb 14 2019, 6:54 AM · Restricted Project
zahiraam added inline comments to D45978: dllexport const variables must have external linkage..
Feb 14 2019, 2:24 AM

Feb 13 2019

zahiraam updated the diff for D45978: dllexport const variables must have external linkage..
Feb 13 2019, 6:36 AM
zahiraam added a comment to D45978: dllexport const variables must have external linkage..
Feb 13 2019, 6:36 AM

Feb 12 2019

zahiraam updated subscribers of D45978: dllexport const variables must have external linkage..
Feb 12 2019, 7:10 AM
zahiraam updated the diff for D45978: dllexport const variables must have external linkage..
Feb 12 2019, 7:10 AM

Feb 11 2019

zahiraam updated the diff for D45978: dllexport const variables must have external linkage..
Feb 11 2019, 9:14 AM
zahiraam added a comment to D45978: dllexport const variables must have external linkage..

It looks like the patch got mucked up somehow, I only see three testing files in the patch now?

Feb 11 2019, 9:14 AM

Feb 8 2019

zahiraam updated the diff for D45978: dllexport const variables must have external linkage..
Feb 8 2019, 12:37 AM
zahiraam added a comment to D45978: dllexport const variables must have external linkage..

Can you add tests for C mode as well, as it seems the behavior differs there.

Feb 8 2019, 12:37 AM

Feb 6 2019

zahiraam added a comment to D45978: dllexport const variables must have external linkage..

That seems like a reasonable place to try, to me.

Feb 6 2019, 6:33 AM
zahiraam updated the diff for D45978: dllexport const variables must have external linkage..
Feb 6 2019, 6:33 AM

Feb 3 2019

zahiraam added a comment to D45978: dllexport const variables must have external linkage..
In D45978#1379901, @rnk wrote:

I'm still not sure this is the best place to make this change, but the functionality is important. There are still unaddressed comments (no need to check MSVCCompatibility, formatting), and I think once those are fixed we can land this.

Feb 3 2019, 3:17 AM

Jan 30 2019

zahiraam added a comment to D41950: Fix for Bug 8446. Template instantiation without a 'typename' keyword..

Feedback please. Thanks.

Jan 30 2019, 5:50 AM · Restricted Project

Jan 26 2019

zahiraam added a comment to D45978: dllexport const variables must have external linkage..

Please advise.
Thanks.

Jan 26 2019, 2:07 AM

Nov 24 2018

zahiraam added a comment to D41950: Fix for Bug 8446. Template instantiation without a 'typename' keyword..

Feedback on this please. Thanks.

Nov 24 2018, 3:39 AM · Restricted Project

May 14 2018

zahiraam updated the diff for D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid).
May 14 2018, 10:50 AM

May 1 2018

zahiraam added a comment to D46226: Oenmp task with by reference array.

Is this better? Thanks.

May 1 2018, 8:09 AM
zahiraam updated the diff for D46226: Oenmp task with by reference array.
May 1 2018, 8:09 AM