Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

nemanjai (Nemanja Ivanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 23 2015, 9:38 AM (453 w, 2 d)

Recent Activity

Thu, Sep 21

nemanjai accepted D116016: [Clang] [PowerPC] Emit module flag for current float abi.

LGTM. Thanks for reviving this patch.

Thu, Sep 21, 1:10 PM · Restricted Project, Restricted Project
nemanjai added inline comments to D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.
Thu, Sep 21, 10:11 AM · Restricted Project, Restricted Project

Thu, Sep 14

nemanjai added a comment to D152914: [Draft] Make __builtin_cpu builtins target-independent.

Friendly ping, are there any questions remained to proceed with target-independent __builtin_cpu_supports ?

Thu, Sep 14, 9:46 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 6

nemanjai accepted D155600: [AIX][TLS] Produce a faster local-exec access sequence with -maix-small-local-exec-tls (And optimize when load/store offsets are 0).

LGTM. The patch is easy to follow now. Thank you for your patience.

Wed, Sep 6, 10:55 PM · Restricted Project, Restricted Project, Restricted Project

Aug 29 2023

nemanjai accepted D159050: [PowerPC] set min jump table entries to 64.

The reason 64 seems to be a good value on PPC chips is hopefully a transient situation that seems to have something to do with how bad the chips can be with branch prediction for indirect branches (CTR branches). I think at least some indication should be added in code comments suggesting this be re-evaluated on future HW that will hopefully do better with this kind of branch.
The other knob we have access to wrt. jump tables (density) could probably use some tuning as well.

Aug 29 2023, 12:31 PM · Restricted Project, Restricted Project

Aug 23 2023

nemanjai accepted D158487: [PowerPC][altivec] Optimize codegen of vec_promote.

LGTM. This is a good idea and we should go ahead with this for anyone that uses vec_promote, but it might be a good idea to improve codegen for the insert which might be more common.

Aug 23 2023, 2:04 PM · Restricted Project, Restricted Project, Restricted Project
nemanjai added inline comments to D158197: [PowerPC][lld] Account for additional X-Forms -> D-Form/DS-Forms load/stores when relaxing initial-exec to local-exec.
Aug 23 2023, 1:39 PM · lld, Restricted Project, Restricted Project, Restricted Project
nemanjai added a comment to D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.

Kill flags should be removed. You should switch to reverse liveness which does not rely on accurate kill flags

I'm not sure I follow. Are you suggesting that we remove all kill flags in this pass? We're really only fixing them up to appease the verifier rather than because anything in the PPC back end relies on the flags.

Aug 23 2023, 1:26 PM · Restricted Project, Restricted Project

Aug 22 2023

nemanjai added inline comments to D158197: [PowerPC][lld] Account for additional X-Forms -> D-Form/DS-Forms load/stores when relaxing initial-exec to local-exec.
Aug 22 2023, 8:53 AM · lld, Restricted Project, Restricted Project, Restricted Project

Aug 20 2023

nemanjai accepted D158065: [PowerPC] Implement builtin for mffsl.

Thanks for implementing this.

Aug 20 2023, 4:43 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai added a comment to D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h.

CC @amyk @quinnp Any comments about the naming?

I see some __builtin_ppc_xxx are aliased into __builtin_xxx by defineXLCompatMacros. But these are not XL-compatible builtins, and the macros do not always work.

Aug 20 2023, 4:39 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D158328: [PowerPC] Merge rotate and clear into single instruction..
Aug 20 2023, 4:31 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D158197: [PowerPC][lld] Account for additional X-Forms -> D-Form/DS-Forms load/stores when relaxing initial-exec to local-exec.
Aug 20 2023, 4:17 AM · lld, Restricted Project, Restricted Project, Restricted Project

Aug 18 2023

nemanjai added a comment to D158197: [PowerPC][lld] Account for additional X-Forms -> D-Form/DS-Forms load/stores when relaxing initial-exec to local-exec.

This patch fixes a regression caused by a patch that is in v17. We will need to decide if we should backport this fix or if we should pull the original patch (which also has additional patches dependent on it that are in v17 as well). I think this patch is obvious enough to be backported, but I'll defer the final decision on that to @MaskRay once this is approved.
@amyk Perhaps it would help to perform a thorough test with the approved version of this patch applied to v17 to ensure it is safe to backport.

Aug 18 2023, 11:55 PM · lld, Restricted Project, Restricted Project, Restricted Project
nemanjai added inline comments to D157811: [DAGCombiner] Don't merge stores to an illegal integer type.
Aug 18 2023, 4:34 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D158197: [PowerPC][lld] Account for additional X-Forms -> D-Form/DS-Forms load/stores when relaxing initial-exec to local-exec.
Aug 18 2023, 4:28 AM · lld, Restricted Project, Restricted Project, Restricted Project

Aug 13 2023

nemanjai updated the summary of D157811: [DAGCombiner] Don't merge stores to an illegal integer type.
Aug 13 2023, 6:19 AM · Restricted Project, Restricted Project
nemanjai requested review of D157811: [DAGCombiner] Don't merge stores to an illegal integer type.
Aug 13 2023, 6:18 AM · Restricted Project, Restricted Project
nemanjai added a comment to D155957: [PPC][AIX] Fix toc-data peephole bug and some related cleanup..

It seems to me that this section of this function has built up a significant amount of technical debt and we should really try to get it refactored so it is clearer what is happening and why. Please note that this is a statement about the existing implementation, not just about the updates in this patch.

Aug 13 2023, 2:53 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D146942: [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments.
Aug 13 2023, 12:54 AM · Restricted Project, Restricted Project, Restricted Project

Aug 8 2023

nemanjai added inline comments to D146942: [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments.
Aug 8 2023, 8:06 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai accepted D152754: [PowerPC] Correct missue of getOperandConstraint in PPCInstrInfo::commuteInstructionImpl.

Sorry I missed this. LGTM.

Aug 8 2023, 7:31 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D157365: [lld][PPC64] Fix location of the least significant byte when fixing up R_PPC64_ADDR14 for little-endian target.
Aug 8 2023, 6:16 AM · Restricted Project, Restricted Project

Aug 6 2023

nemanjai accepted D153206: [PPC32] Parse bl __tls_get_addr(x@tlsgd)@plt+32768.

I think the code could be clarified a bit with some additional comments, but otherwise LGTM.

Aug 6 2023, 11:40 PM · Restricted Project, Restricted Project
nemanjai accepted D156953: PowerPC 32bit: Emit relocation type R_PPC_DTPREL32 for tls variablels..

LGTM. Thanks.

Aug 6 2023, 10:53 PM · Restricted Project, Restricted Project, Restricted Project
nemanjai added a comment to D156292: [PowerPC] Support initial-exec TLS relocation on AIX.

It is not clear how someone in the future should react if the test case changes behaviour. You should think about maintainability of the test cases. It would appear that a part of the checks were produced using a script and a part was added manually. As such, it is not clear what the essential parts of the tests are so anyone maintaining this in the future must really dive deep into the TLS implementation to understand if changes are safe or not. I'm not sure what the best approach would be. Perhaps add a comment describing what is being tested. Or maybe only test the key parts using manual checks.

Aug 6 2023, 10:48 PM · Restricted Project, Restricted Project
nemanjai accepted D156520: [TII] NFCI: Simplify the interface for isTriviallyReMaterializable.

Seems fine to me - certainly from a PPC perspective.

Aug 6 2023, 3:55 AM · Restricted Project, Restricted Project
nemanjai requested changes to D155600: [AIX][TLS] Produce a faster local-exec access sequence with -maix-small-local-exec-tls (And optimize when load/store offsets are 0).

I don't think the last set of comments were addressed yet. Requesting changes to remove it from my queue.

Aug 6 2023, 2:15 AM · Restricted Project, Restricted Project, Restricted Project

Aug 3 2023

nemanjai added a comment to D156953: PowerPC 32bit: Emit relocation type R_PPC_DTPREL32 for tls variablels..

The patch certainly seems reasonable to me. The test case seems like it could be trimmed down a bit (I don't think all the DWARF directives are needed).

Aug 3 2023, 1:27 AM · Restricted Project, Restricted Project, Restricted Project

Aug 2 2023

nemanjai added inline comments to D155852: [flang] Add -fppc-native-vector-element-order option to control the element order in PowerPC vector types.
Aug 2 2023, 3:03 AM · Restricted Project, Restricted Project, Restricted Project

Jul 31 2023

nemanjai added inline comments to D155852: [flang] Add -fppc-native-vector-element-order option to control the element order in PowerPC vector types.
Jul 31 2023, 11:51 AM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2023

nemanjai added a reviewer for D156488: [PPC] Fix layering issues between MCTargetDesc and CodeGen: Restricted Project.
Jul 27 2023, 3:39 PM · Restricted Project, Restricted Project
nemanjai added a comment to D156488: [PPC] Fix layering issues between MCTargetDesc and CodeGen.

Thank you for the patch. This is actually interesting and is a bit of a change to how we thought the code was do be structured. For us the affinity between CodeGen and MCTargetDesc was an indication that the libraries, although separate, are dependent on each other. Of course, this is not necessary so I am in favour of this refactoring.

Jul 27 2023, 3:38 PM · Restricted Project, Restricted Project
nemanjai accepted D156351: clang driver throws error for -mabi=elfv2 or elfv2.

Ah, ok. This makes sense. When we don't know anything about the ABI, it makes sense to rely on -mabi.

Jul 27 2023, 11:08 AM · Restricted Project, Restricted Project

Jul 25 2023

nemanjai added a comment to D156204: [PowerPC][MC] Recognize tlbilx and its mnemonics.

The motivation is https://github.com/llvm/llvm-project/issues/64080

I see both GCC and XLC 16 recognize the instruction in inlineasm.

The instruction (tlbilx) can be found in ISA 2.07 but eliminated in 3.0 and 3.1 since it belongs to 'Book III-E'. Not sure if it should be implemented in current PPC backend. So I put this in draft mode.

In support of the OpenPOWER Foundation’s standardization of server architecture, Power ISA Version 3.0 streamlined this integration by choosing a single Book III and a set of widely used categories to become part of the base architecture for all forward-looking Power implementations. All other optional architecture categories were eliminated to ensure increased application portability between Power processors. Legacy embedded applications that require the eliminated material will continue to use V. 2.07B.

-Preface of ISA 3.0

Jul 25 2023, 1:07 AM · Restricted Project, Restricted Project

Jul 24 2023

nemanjai added inline comments to D156203: [AIX][TLS] Add target attribute for -maix-small-local-exec-tls option..
Jul 24 2023, 11:20 PM · Restricted Project, Restricted Project
nemanjai added a comment to D156204: [PowerPC][MC] Recognize tlbilx and its mnemonics.

What version of the PowerISA is this from? What is the motivation for implementing this?

Jul 24 2023, 11:02 PM · Restricted Project, Restricted Project
nemanjai added a comment to D155600: [AIX][TLS] Produce a faster local-exec access sequence with -maix-small-local-exec-tls (And optimize when load/store offsets are 0).

Sorry, I forgot to submit these comments when I reviewed this.

Jul 24 2023, 10:43 PM · Restricted Project, Restricted Project, Restricted Project
nemanjai added a comment to D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX.

So we don't have code generation for this, but we are enabling it in the front end? What happens if we try to produce code for the IR this produces? It would make more sense to me to implement what is needed in the back end prior to allowing the front end to produce the code.

Jul 24 2023, 12:46 AM · Restricted Project, Restricted Project

Jul 23 2023

nemanjai accepted D151312: [PowerPC][AIX] Enable quadword atomics by default for AIX.

LGTM.

Jul 23 2023, 11:53 PM · Restricted Project, Restricted Project
nemanjai requested changes to D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX.

Please provide a description justifying this change. There is no context here for the viewer to determine whether this change makes sense.

Jul 23 2023, 11:38 PM · Restricted Project, Restricted Project

Jul 20 2023

nemanjai added inline comments to D152914: [Draft] Make __builtin_cpu builtins target-independent.
Jul 20 2023, 11:45 AM · Restricted Project, Restricted Project, Restricted Project

Jul 13 2023

nemanjai accepted D154447: [PowerPC] Improve code gen for vector add.

LGTM.

Jul 13 2023, 8:09 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D152914: [Draft] Make __builtin_cpu builtins target-independent.
Jul 13 2023, 7:47 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai added a comment to D152914: [Draft] Make __builtin_cpu builtins target-independent.

@arsenm Has my description adequately addressed your question? Do you think we should move forward with [some version of] this patch or do you have any fundamental objections?

Jul 13 2023, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai added a comment to D152914: [Draft] Make __builtin_cpu builtins target-independent.

Thank you for the patch, it comes in the right time - we are also working on AArch64 __builtin_cpu_supports, and I was thinking how to make it more general.
I uploaded our RFC version for review https://reviews.llvm.org/D153153


It would be great to have in __builtin_cpu_supports argument string of plus-separated features. Just SemaBuiltinCpuSupports need to handle this.

Jul 13 2023, 7:11 AM · Restricted Project, Restricted Project, Restricted Project

Jul 12 2023

nemanjai accepted D155111: [clangd] Fix build failures observed on build bots for missing libs.

Lets get this committed to unblock the bots and if it is not the correct/desired fix, the author can subsequently provide the more appropriate fix.

Jul 12 2023, 2:06 PM · Restricted Project, Restricted Project
nemanjai accepted D155114: [llvm-objdump] Default to --mcpu=future for PPC32.

Thanks for adding this. Nice to common-up the behaviour. LGTM.

Jul 12 2023, 1:36 PM · Restricted Project, Restricted Project
nemanjai accepted D155089: [PowerPC][MC] Set 'future' as default CPU type of AIX.

LGTM. Whatever the choice is wrt. 32-bit mode, please just add a comment to the function explaining it.

Jul 12 2023, 8:48 AM · Restricted Project, Restricted Project

Jul 11 2023

nemanjai accepted D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain.

No concerns from the perspective of PowerPC here. Of course, my focus is primarily on the server side of things but I am not aware of any other group that could be adversely affected.

Jul 11 2023, 5:51 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai added inline comments to D154933: [PowerPC] Implement llvm.set.rounding intrinsic.
Jul 11 2023, 4:42 AM · Restricted Project, Restricted Project
nemanjai added a comment to D154933: [PowerPC] Implement llvm.set.rounding intrinsic.

What is the plan for handling nearest, away rounding mode for which the PPC FPSCR does not have a setting?

Jul 11 2023, 4:36 AM · Restricted Project, Restricted Project

Jul 7 2023

nemanjai added a comment to D138883: [SelectionDAG][PowerPC] Memset reuse vector element for tail store.

Rebase and added some comments.

Hi @nemanjai, I accepted and addressed your previous comments. Do you have any more concerns on the approach that is implemented here? Thank you!

Jul 7 2023, 1:24 PM · Restricted Project, Restricted Project
nemanjai committed rGb0e249d5e289: Reland "[PowerPC] Remove extend between shift and and" (authored by nemanjai).
Reland "[PowerPC] Remove extend between shift and and"
Jul 7 2023, 11:45 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D154686: [AIX][XCOFF] make integrated-as as default on AIX..
Jul 7 2023, 11:24 AM · Restricted Project, Restricted Project
nemanjai accepted D143198: DAG: Lower is.fpclass fcInf to fcmp of fabs.

LGTM.

Jul 7 2023, 11:11 AM · Restricted Project, Restricted Project

Jul 5 2023

nemanjai added a reverting change for rGa57236de4eb8: [PowerPC] Remove extend between shift and and: rG7cd9084c694c: Revert "[PowerPC] Remove extend between shift and and".
Jul 5 2023, 5:07 PM · Restricted Project, Restricted Project
nemanjai committed rG7cd9084c694c: Revert "[PowerPC] Remove extend between shift and and" (authored by nemanjai).
Revert "[PowerPC] Remove extend between shift and and"
Jul 5 2023, 5:06 PM · Restricted Project, Restricted Project
nemanjai added a reverting change for D152911: [PowerPC] Remove extend between shift and and: rG7cd9084c694c: Revert "[PowerPC] Remove extend between shift and and".
Jul 5 2023, 5:06 PM · Restricted Project, Restricted Project
nemanjai committed rGa57236de4eb8: [PowerPC] Remove extend between shift and and (authored by nemanjai).
[PowerPC] Remove extend between shift and and
Jul 5 2023, 1:33 PM · Restricted Project, Restricted Project
nemanjai closed D152911: [PowerPC] Remove extend between shift and and.
Jul 5 2023, 1:33 PM · Restricted Project, Restricted Project
nemanjai updated the diff for D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.

Address comments

  • Run clang-format
  • Resolve issue with shift-extend peephole
Jul 5 2023, 8:05 AM · Restricted Project, Restricted Project
nemanjai added a comment to rG8a3fdf7b9089: [UTC] Add fallback support for specific metadata, and check their defs.

It appears that this causes failures on buildbots: https://lab.llvm.org/buildbot/#/builders/230/builds/15327
Please fix or pull this.

Jul 5 2023, 7:09 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai added inline comments to D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.
Jul 5 2023, 6:51 AM · Restricted Project, Restricted Project

Jul 4 2023

nemanjai added a comment to D154447: [PowerPC] Improve code gen for vector add.

Unfortunately, this isn't just a case of adding:

def : Pat<(v2i64 (shl v2i64:$vA, (v2i64 (immEQOneV)))),
          (v2i64 (VADDUDM $vA, $vA))>;

like the others but I think it may be worth doing.

Yeah, this is because we don't have a way of materializing the <1, 1> vector so we end up with a constant pool load. We can provide custom legalization:
setOperationAction(ISD::SHL, MVT::v2i64, Custom); for Power8 and up where we would just leave the node alone if it's a shift by 1.

At this point maybe just add the test case and we can deal with the issue at a later date.

I agree this can be done in a follow-up patch.

Jul 4 2023, 1:48 PM · Restricted Project, Restricted Project

Jun 20 2023

nemanjai added inline comments to D152911: [PowerPC] Remove extend between shift and and.
Jun 20 2023, 3:39 AM · Restricted Project, Restricted Project

Jun 19 2023

nemanjai accepted D152669: [AIX][TLS] Generate 32-bit local-exec access code sequence.

LGTM aside from some minor nits.

Jun 19 2023, 8:41 AM · Restricted Project, Restricted Project, Restricted Project

Jun 16 2023

nemanjai accepted D149722: [AIX][TLS] Generate 64-bit local-exec access code sequence.

LGTM.

Jun 16 2023, 8:50 AM · Restricted Project, Restricted Project
nemanjai accepted D106409: [PowerPC] Truncate exponent parameter for vec_cts,vec_ctf.

LGTM.

Jun 16 2023, 8:24 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D152914: [Draft] Make __builtin_cpu builtins target-independent.
Jun 16 2023, 6:43 AM · Restricted Project, Restricted Project, Restricted Project

Jun 14 2023

nemanjai added a comment to D148697: [clang-tidy] Add more checks for functions which should be noexcept.

It was also causing PPC bots to break. I fixed it in https://reviews.llvm.org/rGffd7a200fdfbd01ef296101647d2f2da91ddfd41

O, thank you. Thats explain a lot. Because when I look into cmake, clangTidyPerformanceModule were already there because you already added it.

Jun 14 2023, 2:02 PM · Restricted Project, Restricted Project
nemanjai added a comment to D148697: [clang-tidy] Add more checks for functions which should be noexcept.

@Dinistro It compiles & links with clang 16 also (shared libs). So I'm unable to reproduce.

I used the following command to build:

cmake -S/home/christianu/repos/llvm-project/llvm -B/home/christianu/repos/llvm-project/build-clang-tidy -GNinja -DLLVM_ENABLE_LLD=ON -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_ENABLE_ASSERTIONS=ON -DBUILD_SHARED_LIBS=ON -DLLVM_INCLUDE_UTILS=ON -DLLVM_INSTALL_UTILS=ON -DLLVM_BUILD_EXAMPLES=OFF -DLLVM_CCACHE_BUILD=ON -DLLVM_OPTIMIZED_TABLEGEN=ON -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DLLVM_ENABLE_RUNTIMES=openmp
Jun 14 2023, 1:56 PM · Restricted Project, Restricted Project
nemanjai added inline comments to D152914: [Draft] Make __builtin_cpu builtins target-independent.
Jun 14 2023, 6:47 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai requested review of D152914: [Draft] Make __builtin_cpu builtins target-independent.
Jun 14 2023, 6:45 AM · Restricted Project, Restricted Project, Restricted Project
nemanjai requested review of D152911: [PowerPC] Remove extend between shift and and.
Jun 14 2023, 5:54 AM · Restricted Project, Restricted Project
nemanjai committed rGffd7a200fdfb: [clang-tidy] Fix build bot break after 474a2b9367ad (authored by nemanjai).
[clang-tidy] Fix build bot break after 474a2b9367ad
Jun 14 2023, 4:48 AM · Restricted Project, Restricted Project

May 24 2023

nemanjai committed rGde681d53ba82: [PowerPC] Do not attempt to combine fptoui without FPCVT (authored by nemanjai).
[PowerPC] Do not attempt to combine fptoui without FPCVT
May 24 2023, 9:15 AM · Restricted Project, Restricted Project

May 23 2023

nemanjai accepted D149711: [PowerPC] Remove asserts from the disassembler..

LGTM. Thanks for fixing these.

May 23 2023, 2:07 PM · Restricted Project, Restricted Project

May 19 2023

nemanjai added inline comments to D149711: [PowerPC] Remove asserts from the disassembler..
May 19 2023, 5:39 PM · Restricted Project, Restricted Project

May 18 2023

nemanjai added inline comments to D149711: [PowerPC] Remove asserts from the disassembler..
May 18 2023, 8:00 AM · Restricted Project, Restricted Project
nemanjai added a comment to D149711: [PowerPC] Remove asserts from the disassembler..

Please note that this assert can trip even when disassembling with --disassemble and not just -disassemble-all. Namely, the offending word can appear in the text section (for example, the AIX traceback table, etc.).
This is very similar to https://reviews.llvm.org/rGc86f8d4276ae

May 18 2023, 7:54 AM · Restricted Project, Restricted Project

Apr 28 2023

nemanjai updated the diff for D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.

Rebase on top of some new additions to the pass and address numerous review comments.

Apr 28 2023, 7:27 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D133103: [PowerPC] Improve kill flag computation and add verification after MI peephole.
Apr 28 2023, 7:01 AM · Restricted Project, Restricted Project

Apr 24 2023

nemanjai accepted D149030: [PPCMIPeephole] Fix incorrect compare elimination.

LGTM. Thanks for the fix.

Apr 24 2023, 4:34 AM · Restricted Project, Restricted Project

Apr 17 2023

nemanjai added a comment to D148192: [JITLink][ELF][PPC64] Add skeleton ppc64 support and ELF/ppc64 JITLink backend..

Thank you so much for implementing this for PowerPC. Implementing JITLink has been on our radar for a while and this gives us a very welcome head start.

Apr 17 2023, 3:59 PM · Restricted Project, Restricted Project, Restricted Project
nemanjai accepted D148192: [JITLink][ELF][PPC64] Add skeleton ppc64 support and ELF/ppc64 JITLink backend..

This all LGTM and I think the naming is consistent with other targets, so ppc64 makes sense. I have some minor comments that are more likely due to my lack of familiarity with jit-link than anything that should require action on the patch.

Apr 17 2023, 9:00 AM · Restricted Project, Restricted Project, Restricted Project

Apr 3 2023

nemanjai committed rGc93709af9a23: [SmallVector] Fix unit test to eliminate failure with -Werror (authored by nemanjai).
[SmallVector] Fix unit test to eliminate failure with -Werror
Apr 3 2023, 6:03 PM · Restricted Project, Restricted Project
nemanjai accepted D147454: [NFC] Update CodeGen/*/nomerge.ll tests with utils/update_llc_test_checks.py..

LGTM.

Apr 3 2023, 4:03 PM · Restricted Project, Restricted Project
nemanjai accepted D147016: [PowerPC] Add function pointer alignment to DataLayout.

LGTM. Maybe give others a bit of time to chime in.

Apr 3 2023, 3:03 PM · Restricted Project, Restricted Project, Restricted Project
nemanjai added inline comments to D146325: [PowerPC] Add statistics to show the number of entries in the TOC..
Apr 3 2023, 2:19 PM · Restricted Project, Restricted Project
nemanjai added inline comments to D146632: [PowerPC] Fix the xxperm swap requirements.
Apr 3 2023, 2:10 PM · Restricted Project, Restricted Project
nemanjai added a comment to D146602: [PowerPC] Enable canCombineStoreAndExtract target hook.

For the most part, the code produced for vector-promotion.ll is worse as we're forcing the operations into the vector space rather than doing it in scalar registers. Perhaps we should return false from this query if the input vector is the result of a load and the only user is the extract instruction. This would of course require that we change the interface of the query to take the extract instruction rather than the type.
The idea is that if we are loading the vector, extracting an element, performing an operation and then storing, we won't really load the vector but will load only the single element. Promoting the operation will force us to load the vector which is counter productive.

Apr 3 2023, 1:11 PM · Restricted Project, Restricted Project

Mar 31 2023

nemanjai accepted D143467: [PowerPC] Add target feature requirement to builtins.

This looks fine to me. I'd like some of the devs that have added builtins with Sema checking in the past to have a look here as well. @amyk @maryammo @kamaub @stefanp Can you have a look at this as well please?

Mar 31 2023, 6:35 AM · Restricted Project, Restricted Project
nemanjai accepted D135171: FreeBSD: enable __float128 on x86 and powerpc64le.

My comments are minor nits that don't require another review, so LGTM.

Mar 31 2023, 2:22 AM · Restricted Project, Restricted Project

Mar 24 2023

nemanjai committed rGe7c35d71007f: [SelectionDAG] Correctly reduce BV to shuffle with zero on big endian (authored by nemanjai).
[SelectionDAG] Correctly reduce BV to shuffle with zero on big endian
Mar 24 2023, 7:57 AM · Restricted Project, Restricted Project
nemanjai closed D146460: [SelectionDAG] Correctly reduce BV to shuffle with zero on big endian.
Mar 24 2023, 7:57 AM · Restricted Project, Restricted Project
nemanjai added inline comments to D146460: [SelectionDAG] Correctly reduce BV to shuffle with zero on big endian.
Mar 24 2023, 7:19 AM · Restricted Project, Restricted Project

Mar 21 2023

nemanjai accepted D146459: [clang][PowerPC] Remove remaining Darwin support.

This LGTM. Thanks for cleaning it up. Give it at least a week for any others that may have an opinion on this to chime in.

Mar 21 2023, 9:15 AM · Restricted Project, Restricted Project

Mar 20 2023

nemanjai requested review of D146460: [SelectionDAG] Correctly reduce BV to shuffle with zero on big endian.
Mar 20 2023, 3:04 PM · Restricted Project, Restricted Project
nemanjai committed rG6ee4ea8e2fe6: [PowerPC][NFC] Test needs to include constant pool values (authored by nemanjai).
[PowerPC][NFC] Test needs to include constant pool values
Mar 20 2023, 2:44 PM · Restricted Project, Restricted Project