Page MenuHomePhabricator

nemanjai (Nemanja Ivanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 23 2015, 9:38 AM (225 w, 3 d)

Recent Activity

Fri, May 17

nemanjai added a comment to D61228: [PowerPC] Set the innermost hot loop(from PGO) to align 32 bytes.

Okay, but we just call MBB->getParent()->getFunction().hasProfileData(), where do we actually check that the loop is hot?

Also, even if we align the majority of loops, how much does that really cost us? The code-size impact could be minor compared to the perf improvement, and if so, we should just always do it. It is still true that most users don't use PGO.

Fri, May 17, 5:57 AM · Restricted Project

Thu, May 16

nemanjai accepted D61966: [PowerPC][NFC] Add a tests for Reordering CSR reloads in epilogue to follow the same order as CSR saves in the prologue.

Please name the test case csr-save-restore-order.ll rather than using the word reverse since the reversal is something you do once and the test case shows the order of saves/restores.

Thu, May 16, 3:00 PM · Restricted Project
nemanjai added inline comments to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.
Thu, May 16, 2:45 PM · Restricted Project
nemanjai accepted D59881: Initial support for vectorization using MASSV (IBM MASS vector library).

LGTM. Thanks for getting this done.

Thu, May 16, 2:32 PM · Restricted Project
nemanjai added a comment to D61228: [PowerPC] Set the innermost hot loop(from PGO) to align 32 bytes.

Can you explain why we don't always do this? You're checking for profiling data but then not using it?

Thu, May 16, 2:29 PM · Restricted Project

Tue, May 14

nemanjai added a comment to D61726: [Pass Pipeline] Run another round of reassociation after loop pipeline.

It would be interesting to see how that result translates on a more typical x86 build machine. Either way, I suspect we'll get different opinions about whether a 0.3% time increase is minimal and whether that cost is worth paying for the runtime perf gains. This might be a case for differentiating between -O2 and -O3?

Tue, May 14, 2:10 PM · Restricted Project

Mon, May 13

nemanjai updated the diff for D61726: [Pass Pipeline] Run another round of reassociation after loop pipeline.

Remove an unrelated change that snuck in by accident.

Mon, May 13, 6:40 PM · Restricted Project
nemanjai updated the diff for D61726: [Pass Pipeline] Run another round of reassociation after loop pipeline.

Update the new test case. Thanks @efriedma for the tip.

Mon, May 13, 6:35 PM · Restricted Project
nemanjai committed rG1d662316cbff: [Pass Pipeline][NFC] Add a test prior to committing D61726 (authored by nemanjai).
[Pass Pipeline][NFC] Add a test prior to committing D61726
Mon, May 13, 2:15 PM
nemanjai committed rL360620: [Pass Pipeline][NFC] Add a test prior to committing D61726.
[Pass Pipeline][NFC] Add a test prior to committing D61726
Mon, May 13, 2:15 PM

Fri, May 10

nemanjai added a comment to D61726: [Pass Pipeline] Run another round of reassociation after loop pipeline.
Fri, May 10, 10:18 AM · Restricted Project
nemanjai committed rG34dc3aca407c: Pull r360426 as it is breaking the build bots. (authored by nemanjai).
Pull r360426 as it is breaking the build bots.
Fri, May 10, 9:01 AM
nemanjai committed rL360437: Pull r360426 as it is breaking the build bots..
Pull r360426 as it is breaking the build bots.
Fri, May 10, 9:01 AM
nemanjai committed rG7a41cd5b8884: Another attempt to fix the build bot breaks after r360426 (authored by nemanjai).
Another attempt to fix the build bot breaks after r360426
Fri, May 10, 8:46 AM
nemanjai committed rL360434: Another attempt to fix the build bot breaks after r360426.
Another attempt to fix the build bot breaks after r360426
Fri, May 10, 8:45 AM
nemanjai committed rG0f991c65f2c1: Fix build break after r360426 (authored by nemanjai).
Fix build break after r360426
Fri, May 10, 8:10 AM
nemanjai committed rL360433: Fix build break after r360426.
Fix build break after r360426
Fri, May 10, 8:09 AM
nemanjai updated the diff for D61726: [Pass Pipeline] Run another round of reassociation after loop pipeline.

Move the newly added test case and update it to only show the different behaviour (after committing it to show the current behaviour in r360426)
Move the additional run of reassociation before the late LICM pass. I assumed that this is a good place for it in the pipeline since LICM might move things out of the loop and potentially take away some opportunities. This is just based on a weak hunch and I am very much open to suggestions for a better place for this in the pipeline.

Fri, May 10, 6:52 AM · Restricted Project
nemanjai committed rGcfc89896e018: [Pass Pipeline][NFC] Add a test prior to committing D61726 (authored by nemanjai).
[Pass Pipeline][NFC] Add a test prior to committing D61726
Fri, May 10, 6:45 AM
nemanjai committed rL360426: [Pass Pipeline][NFC] Add a test prior to committing D61726.
[Pass Pipeline][NFC] Add a test prior to committing D61726
Fri, May 10, 6:45 AM

Thu, May 9

nemanjai added a comment to D61726: [Pass Pipeline] Run another round of reassociation after loop pipeline.

Running reassociate after unroll probably makes sense. But I'd like to see compile-time numbers.

How carefully have you considered the exact placement? It looks like you're using different placement for the legacy vs. new pass manager. Do we want to run before the late LICM pass?

Thu, May 9, 12:27 PM · Restricted Project
nemanjai added a reviewer for D61726: [Pass Pipeline] Run another round of reassociation after loop pipeline: tstellar.
Thu, May 9, 5:40 AM · Restricted Project
nemanjai created D61726: [Pass Pipeline] Run another round of reassociation after loop pipeline.
Thu, May 9, 5:40 AM · Restricted Project
nemanjai committed rG80808ed0f6a5: [PowerPC][NFC] Add test for D60506 to show differences in code-gen (authored by nemanjai).
[PowerPC][NFC] Add test for D60506 to show differences in code-gen
Thu, May 9, 5:25 AM
nemanjai committed rL360338: [PowerPC][NFC] Add test for D60506 to show differences in code-gen.
[PowerPC][NFC] Add test for D60506 to show differences in code-gen
Thu, May 9, 5:25 AM
nemanjai closed D61723: [PowerPC] Add tests to show opportunity to make ICMP_EQ use CR result of ICMP_S(L|G)T dominators. NFC.
Thu, May 9, 5:25 AM · Restricted Project
nemanjai accepted D61723: [PowerPC] Add tests to show opportunity to make ICMP_EQ use CR result of ICMP_S(L|G)T dominators. NFC.

LGTM. I'll commit it for you.

Thu, May 9, 4:09 AM · Restricted Project

Tue, May 7

nemanjai committed rG83eb9c5b588c: Fix buildbot break after r360195 (authored by nemanjai).
Fix buildbot break after r360195
Tue, May 7, 7:03 PM
nemanjai committed rC360220: Fix buildbot break after r360195.
Fix buildbot break after r360195
Tue, May 7, 7:03 PM
nemanjai committed rL360220: Fix buildbot break after r360195.
Fix buildbot break after r360195
Tue, May 7, 7:03 PM
nemanjai added a comment to D58497: Clear the KnownModules cache if the preprocessor is going away.

Ping. Does anyone think this is a good idea? Bad idea? Have any further comments?

Tue, May 7, 3:41 PM · Restricted Project
nemanjai added reviewers for D61658: [PowerPC] Emit XXSEL for vec_sel and code that has the same pattern: kbarton, lei.
Tue, May 7, 3:01 PM · Restricted Project
nemanjai updated the diff for D61658: [PowerPC] Emit XXSEL for vec_sel and code that has the same pattern.

Add tests for some other types as well.

Tue, May 7, 3:00 PM · Restricted Project
nemanjai created D61658: [PowerPC] Emit XXSEL for vec_sel and code that has the same pattern.
Tue, May 7, 2:58 PM · Restricted Project
nemanjai committed rGb4f028f0f3f6: [PowerPC] Use the two-constant NR algorithm for refining estimates (authored by nemanjai).
[PowerPC] Use the two-constant NR algorithm for refining estimates
Tue, May 7, 6:46 AM
nemanjai committed rL360144: [PowerPC] Use the two-constant NR algorithm for refining estimates.
[PowerPC] Use the two-constant NR algorithm for refining estimates
Tue, May 7, 6:46 AM
nemanjai closed D60037: [PowerPC] Use the two-constant NR algorithm for refining estimates.
Tue, May 7, 6:46 AM · Restricted Project
nemanjai added inline comments to D60037: [PowerPC] Use the two-constant NR algorithm for refining estimates.
Tue, May 7, 5:06 AM · Restricted Project

Mon, May 6

nemanjai committed rG70afe4f7e1f7: [PowerPC] Fix erroneous condition for converting uint-to-fp vector conversion (authored by nemanjai).
[PowerPC] Fix erroneous condition for converting uint-to-fp vector conversion
Mon, May 6, 6:34 AM
nemanjai committed rL360043: [PowerPC] Fix erroneous condition for converting uint-to-fp vector conversion.
[PowerPC] Fix erroneous condition for converting uint-to-fp vector conversion
Mon, May 6, 6:33 AM

Fri, May 3

nemanjai accepted D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.

Other than a few minor nits that can be addressed on the commit, LGTM.

Fri, May 3, 5:53 AM · Restricted Project

Thu, May 2

nemanjai added a reviewer for D57857: [PowerPC] custom lower `v2f64 fpext v2f32`: nemanjai.
Thu, May 2, 8:56 AM · Restricted Project
nemanjai updated the diff for D60037: [PowerPC] Use the two-constant NR algorithm for refining estimates.

Fixed the typos, added a check for no register move.

Thu, May 2, 6:16 AM · Restricted Project
nemanjai added inline comments to D59633: [PowerPC] Look through copies for compare elimination.
Thu, May 2, 4:45 AM · Restricted Project
nemanjai updated the diff for D60402: [PowerPC] Collapse RLDICL/RLDICR into RLDIC when possible.

Added a check for wrapping in the computation of the new shift amount and mask start bit.

Thu, May 2, 4:41 AM · Restricted Project
nemanjai added inline comments to D60402: [PowerPC] Collapse RLDICL/RLDICR into RLDIC when possible.
Thu, May 2, 4:41 AM · Restricted Project

Wed, May 1

nemanjai abandoned D61384: [DAGCombine] Fix for regression introduced in rL359398.

Fixed as part of the original patch. Abandoning this.

Wed, May 1, 7:48 PM · Restricted Project
nemanjai accepted D61149: [DAGCombiner] try repeated fdiv divisor transform before building estimate.

Interestingly enough, I tried this (or some variant of this) and it didn't work for me. Clearly I had done something wrong when trying it. In any case, I've run this against the code we were originally spinning on and it's all good. LGTM and thanks for fixing so quickly.

Wed, May 1, 7:46 PM · Restricted Project
nemanjai added a comment to rL359398: [DAGCombiner] try repeated fdiv divisor transform before building estimate.

Since I messed up the patch I posted, I've decided to just post it for review as a separate patch: https://reviews.llvm.org/D61384
Can you please review it there and we can probably get this fixed up quickly. I'll address any comments you have right away.

Oops, too late. :)
I reverted at rL359695, so let me reopen the original review and merge your patch into that.

Wed, May 1, 9:17 AM
nemanjai added a comment to rL359398: [DAGCombiner] try repeated fdiv divisor transform before building estimate.

Since I messed up the patch I posted, I've decided to just post it for review as a separate patch: https://reviews.llvm.org/D61384
Can you please review it there and we can probably get this fixed up quickly. I'll address any comments you have right away.

Wed, May 1, 9:03 AM
nemanjai created D61384: [DAGCombine] Fix for regression introduced in rL359398.
Wed, May 1, 9:02 AM · Restricted Project
nemanjai added a comment to rL359398: [DAGCombiner] try repeated fdiv divisor transform before building estimate.

Could you either pull this patch or advise on the correct way forward (i.e. should I just commit the patch? post it for review?)?

Sorry about that! I'm seeing different crashing on existing regression tests after applying your patch, but didn't step through yet. Any ideas about that?
I will revert this so we don't have the bug while we sort it out.

Wed, May 1, 8:55 AM
nemanjai added a comment to rL359398: [DAGCombiner] try repeated fdiv divisor transform before building estimate.

This causes the old combine/uncombine infinite loop with the following test case compiled for PPC:

$ cat infiniteloop.ll 
define dso_local void @test(float %a, <4 x float>* nocapture %b) {
entry:
  %call = tail call fast float @test2(float %a) #2
  %vecinit = insertelement <4 x float> undef, float %call, i32 0
  %vecinit3 = shufflevector <4 x float> %vecinit, <4 x float> undef, <4 x i32> zeroinitializer
  %0 = load <4 x float>, <4 x float>* %b, align 16
  %1 = fmul fast <4 x float> %0, <float 1.000000e+00, float 1.000000e+00, float 1.000000e+00, float 0x3FF028F5C0000000>
  %mul = fdiv fast <4 x float> %1, %vecinit3
  store <4 x float> %mul, <4 x float>* %b, align 16
  ret void
}
Wed, May 1, 8:04 AM

Mon, Apr 29

nemanjai added inline comments to D61236: [NFC] Add a static function to do the endian check.
Mon, Apr 29, 10:45 AM · Restricted Project

Wed, Apr 24

nemanjai added a comment to D59694: [PPC64][libunwind] Fix r2 not properly restored.

Sorry, could you please rebase to latest? It does not apply cleanly for me (assembly.h does not apply).

Wed, Apr 24, 5:56 AM · Restricted Project, Restricted Project

Tue, Apr 23

nemanjai added a comment to D59694: [PPC64][libunwind] Fix r2 not properly restored.

I like the patch now and the test case seems to cover what it needs to (I like the indirect call to ensure a call through a global entry point trick).

Tue, Apr 23, 2:11 PM · Restricted Project, Restricted Project
nemanjai accepted D60102: [PowerPC] Try harder to avoid load/move-to VSR for partial vector loads.

LGTM.

Tue, Apr 23, 5:50 AM · Restricted Project
nemanjai requested changes to D60506: [CGP] Make ICMP_EQ use CR result of ICMP_S(L|G)T dominators.

Please reduce the test case only to cases that are changing behaviour. Also, it is probably useful to commit the test case initially as an NFC patch so we can see the actual difference in codegen.

Tue, Apr 23, 5:46 AM · Restricted Project

Mon, Apr 22

nemanjai added a comment to D59881: Initial support for vectorization using MASSV (IBM MASS vector library).

@pjeeva01 Can you address Jinsong's comments? It would be good to add the negative tests for sure:

  • No vectorization with -mattr=-altivec
  • No vectorization with the nobuiltin attribute
  • A couple of calls to functions that MASSV doesn't have a vector equivalent for

Also, it would be good to add a run line for big endian.

Mon, Apr 22, 7:18 AM · Restricted Project
nemanjai accepted D60160: [PowerPC] Update P9 vector costs for insert/extract element.

The logic LGTM. Please address the test case updates requested by Jinsong. I don't think this requires another revision though.

Mon, Apr 22, 7:00 AM · Restricted Project

Apr 16 2019

nemanjai added a comment to D60539: Add -std=c++14 language standard option to tests that require C++14 default.

Do you need to build clangd? We explicitly don't aim to support building everywhere clang can be built, maybe we should just disable in this case?

Our environment includes various OS levels running on PowerPC. We certainly wouldn't want to disable building/testing clangd on all our PowerPC machines. Is there a way to disable it only on certain OS levels?

Apr 16 2019, 11:30 AM · Restricted Project, Restricted Project

Apr 9 2019

nemanjai committed rG820b90318fb0: NFC: Refactor library-specific mappings of scalar maths functions to their… (authored by nemanjai).
NFC: Refactor library-specific mappings of scalar maths functions to their…
Apr 9 2019, 6:20 AM
nemanjai committed rL358001: NFC: Refactor library-specific mappings of scalar maths functions to their….
NFC: Refactor library-specific mappings of scalar maths functions to their…
Apr 9 2019, 6:20 AM
nemanjai closed D60211: NFC: Refactor library-specific mappings of scalar maths functions to their vector counterparts.
Apr 9 2019, 6:20 AM · Restricted Project

Apr 8 2019

nemanjai updated the diff for D60402: [PowerPC] Collapse RLDICL/RLDICR into RLDIC when possible.

Cleaned up the comments and the MB parameter for RLDIC does not need to include the shift that was originally on the RLDICL.

Apr 8 2019, 7:28 AM · Restricted Project
nemanjai created D60402: [PowerPC] Collapse RLDICL/RLDICR into RLDIC when possible.
Apr 8 2019, 5:27 AM · Restricted Project

Apr 5 2019

nemanjai accepted D60211: NFC: Refactor library-specific mappings of scalar maths functions to their vector counterparts.

LGTM. Thanks for pulling out this change into a separate patch. I'll commit it for you on Monday. This way others have an extra opportunity to add any comments or concerns.

Apr 5 2019, 4:43 AM · Restricted Project

Mar 31 2019

nemanjai added a comment to D58497: Clear the KnownModules cache if the preprocessor is going away.

Ping.

Unfortunately Richard Smith is out for a few weeks at the moment, so might take a little bit before he can get to this.

It's odd to me that this lacks a test case - but you mention it's shown up on buildbots? Does it reproduce consistently there? Under what conditions (which buildbots/configurations show this - are they permanently failing because of this?)?

A test case, if at all possible, would be super helpful.

The failure this causes always shows up in the Modules/builtins.m test (at least in my experience). It is far from predictable and it does not consistently reproduce on any build bot. It occasionally shows up and slight perturbations in the source make it go away.
Honestly, I don't find this to be all that surprising. Using memory after freeing it has inherently unpredictable behaviour. There are certain toolchains that will diagnose freeing the same memory twice, but that's not the case here - we just happen to use it after freeing it.

Mar 31 2019, 6:47 PM · Restricted Project
Herald added a project to D45308: [IPRA] Do not collect register usage information on functions that can be derefined: Restricted Project.

Is this patch dead? Does @kbarton or perhaps @jonpa have any interest in seeing this through so IPRA can be enabled on PPC/SystemZ?

Mar 31 2019, 6:03 AM · Restricted Project
Herald added a project to D50988: Remove Darwin support from POWER backend.: Restricted Project.

@kbarton Do you plan to rebase and commit this patch?

Mar 31 2019, 5:58 AM · Restricted Project
Herald added a project to D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux: Restricted Project.

Do you plan to follow-up on these questions and comments?
At least the full context is needed and for the test case, I imagine it can be similar to other driver test cases. I imagine tools/clang/test/Driver/linux-ld.c can be augmented with this?

Mar 31 2019, 5:57 AM · Restricted Project
nemanjai accepted D57118: [CMake][PowerPC] Recognize LLVM_NATIVE_TARGET="ppc64le" as PowerPC.

This looks right. Thanks.

Mar 31 2019, 5:47 AM · Restricted Project
nemanjai added reviewers for D58497: Clear the KnownModules cache if the preprocessor is going away: dexonsmith, dblaikie.
Mar 31 2019, 5:42 AM · Restricted Project
nemanjai added a comment to D58497: Clear the KnownModules cache if the preprocessor is going away.

If there are no objections in the next week or so, I'll commit this and it can be reviewed post-commit.

Mar 31 2019, 5:41 AM · Restricted Project
nemanjai added a comment to D59384: Fix reversed bit issue in DCMX mask for "xvtstdcdp" and "xvtstdcsp" P9 implementation.

@stefanp Victor doesn't have commit access yet. Can you commit this for him?

Mar 31 2019, 5:38 AM · Restricted Project
nemanjai accepted D59694: [PPC64][libunwind] Fix r2 not properly restored.

I don't really know much about how libunwind is tested so I can't really comment on how to write one (or the need for one). But the code looks good to me.

Mar 31 2019, 5:31 AM · Restricted Project, Restricted Project
nemanjai requested changes to D56703: PowerPC: Fix register spilling for SPE registers.

Can you add a test case? At least for the spills that you're adding.

Mar 31 2019, 5:22 AM · Restricted Project
nemanjai requested changes to D54409: PowerPC/SPE: Fix load/store handling for SPE.

I am only requesting changes for the refactoring of the function. As I mentioned in the inline comment, I am not necessarily requesting that you rework the addressing mode computation functions as I mentioned, just that you clean up the code in SelectAddressRegReg().

Mar 31 2019, 5:15 AM · Restricted Project
nemanjai added a comment to D54583: PowerPC: Optimize SPE double parameter calling setup.

LGTM. The remaining comments are stylistic nits that can be addressed on the commit and do not require another round of review. Thank you for your patience with this review.

Mar 31 2019, 3:09 AM
nemanjai accepted D54583: PowerPC: Optimize SPE double parameter calling setup.

Forgot to select Accept Revision from the pulldown.

Mar 31 2019, 3:09 AM

Mar 30 2019

nemanjai created D60037: [PowerPC] Use the two-constant NR algorithm for refining estimates.
Mar 30 2019, 4:40 PM · Restricted Project

Mar 28 2019

nemanjai added a comment to D59633: [PowerPC] Look through copies for compare elimination.

Might miss some opportunity related to parameters instead. Please have a look. Thanks.

Mar 28 2019, 8:10 PM · Restricted Project
nemanjai updated the diff for D59633: [PowerPC] Look through copies for compare elimination.

Updated to not look through copies if that leads to a physical register since that will never produce a defining MI.

Mar 28 2019, 8:06 PM · Restricted Project

Mar 22 2019

nemanjai added a comment to D59694: [PPC64][libunwind] Fix r2 not properly restored.

Also, is it possible to have a test case for this? I don't actually know what libunwind test cases look like, but seems pertinent.

Mar 22 2019, 2:31 PM · Restricted Project, Restricted Project

Mar 21 2019

nemanjai created D59633: [PowerPC] Look through copies for compare elimination.
Mar 21 2019, 3:09 AM · Restricted Project

Mar 20 2019

nemanjai added a comment to D49837: [SelectionDAG] Handle unary SelectPatternFlavor for ABS case in SelectionDAGBuilder::visitSelect..

It would appear that the fix for PR 41149 should be fairly straightforward. The vector type legalizer just needs to learn about ISD::ABS. Likely just another case to be added in ScalarizeVectorResult().
PR 41160 is a common pitfall with DAG combines. I've gone ahead and reduced the test case provided in the PR.

Mar 20 2019, 4:53 PM · Restricted Project

Mar 18 2019

nemanjai added a comment to D57857: [PowerPC] custom lower `v2f64 fpext v2f32`.

I think approaching the problem this way is unnecessarily limited - and I say that knowing that I may have suggested a similar approach.
However, what we are actually looking to do is to convert a DAG such as:

Mar 18 2019, 8:55 AM · Restricted Project

Mar 13 2019

nemanjai committed rG784cdb439e98: Fix invocation of Gold plugin with LTO after r355331 (authored by nemanjai).
Fix invocation of Gold plugin with LTO after r355331
Mar 13 2019, 4:54 PM
nemanjai committed rC356111: Fix invocation of Gold plugin with LTO after r355331.
Fix invocation of Gold plugin with LTO after r355331
Mar 13 2019, 4:54 PM
nemanjai committed rL356111: Fix invocation of Gold plugin with LTO after r355331.
Fix invocation of Gold plugin with LTO after r355331
Mar 13 2019, 4:54 PM
nemanjai closed D59304: Fix invocation of Gold plugin with LTO after r355331.
Mar 13 2019, 4:54 PM · Restricted Project, Restricted Project
nemanjai added a comment to D59304: Fix invocation of Gold plugin with LTO after r355331.

Thanks Teresa, I'll commit this soon.

Mar 13 2019, 9:43 AM · Restricted Project, Restricted Project
nemanjai created D59304: Fix invocation of Gold plugin with LTO after r355331.
Mar 13 2019, 9:26 AM · Restricted Project, Restricted Project

Mar 12 2019

nemanjai added a comment to D49837: [SelectionDAG] Handle unary SelectPatternFlavor for ABS case in SelectionDAGBuilder::visitSelect..

OK, it appears that the PPC issue is really just a phase ordering problem that is quite easy to resolve. We now get the ISD::ABS node earlier so we may very well end up in a situation where we need to legalize the result type of such node. So our Custom legalization of all vector types can't really work any longer. Applying this in PPCISelLowering.cpp should fix the UNREACHABLE failure:

Mar 12 2019, 5:19 AM · Restricted Project
nemanjai added a comment to D49837: [SelectionDAG] Handle unary SelectPatternFlavor for ABS case in SelectionDAGBuilder::visitSelect..

I will apply this patch and take a look at what breaks on PPC. I'll advise soon on what is needed for us.

Mar 12 2019, 4:35 AM · Restricted Project
nemanjai accepted D58354: PowerPC: Add ImmArg to intrinsics.

Sorry about the delay. LGTM.

Mar 12 2019, 4:04 AM
nemanjai accepted D58645: [PowerPC] Set useful flags for vector imm setting instructions.

LGTM. Sorry about the delay.

Mar 12 2019, 3:57 AM · Restricted Project

Mar 11 2019

nemanjai added a comment to D47332: [PowerPC] Exploit the vector min/max instructions.

Is anything happening with this? We've hit PPC issues with ISD::ABS on https://reviews.llvm.org/D49837 and I noticed that PPCTargetLowering::LowerABS has a reference to this patch.

Mar 11 2019, 4:43 AM · Restricted Project

Mar 5 2019

nemanjai added a comment to D58595: [TableGen][SelectionDAG][X86] Add specific isel matchers for immAllZerosV/immAllOnesV. Remove bitcasts from X86 patterns that are no longer necessary..

I think we should re-think this patch as it seems to massively increase the number of failed attempts the instruction selector makes when selecting code. Below is a trivial example:

Mar 5 2019, 10:37 AM · Restricted Project

Mar 4 2019

nemanjai added a comment to D55501: [PPC64][PPC] add tests for R_PPC64_REL14 R_PPC_REL14.

@sfertile Do you have any comments regarding this as you're most familiar with this part of the PPC backend?

Mar 4 2019, 4:17 PM · Restricted Project