- User Since
- Apr 20 2015, 1:34 PM (322 w, 3 d)
Feb 28 2021
Hi, Abhina. Sorry for the delay getting back to you. I added some more comments.
Dec 23 2020
Dec 16 2020
Dec 11 2020
Aug 7 2020
I'm not a regular Clang reviewer. But for what it is worth, the changes look correct, clear, and appropriate from my lens (though I disagree slightly with some of the lint recommendations in the cases where the recommendation deviates from the surrounding code style). It looks like the concerns Hubert raised have been addressed.
Jun 18 2020
@Kai, I'm afraid I won't be able to assist much in reviews of most z/OS related patches (due to lack of time and lack of expertise with various parts of z/OS), but please do copy me on anything related to source and execution character set encoding or conversions, handling of universal-character-names, and encoding of output files (preprocessor output, dependency output, etc...)
Jan 6 2020
Jul 2 2019
See PR25683 (https://bugs.llvm.org/show_bug.cgi?id=25683) for more details. The patch posted here differs slightly from what is posted in the PR; getLocation() is called instead of getBeginLoc() since the latter may return a customized begin location.
Sep 30 2016
For what it's worth, Coverity has been running with this patch in place for at least a year and a half now. I believe the only reason it wasn't committed was due to concerns with the test case in D9126. I haven't had time to address those concerns (and don't expect to anytime soon).
Jul 6 2015
What's the state of this?
Apr 22 2015
For future reference, it's our convention to include the code change and tests in the same review.
Apr 21 2015
Please add a testcase (I'd imagine it's not too hard to craft one in this case?).
Apr 20 2015
The formatting I intended in the summary did not take affect. Here is the referenced code as I intended it to display:
A fix for this issue has been proposed in D9127.