Page MenuHomePhabricator

tahonermann (Tom Honermann)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 20 2015, 1:34 PM (374 w, 5 d)

Recent Activity

Fri, Jun 24

tahonermann accepted D123064: [Clang][C++23] P2071 Named universal character escapes.

@tahonermann gentle ping (Aaron told me you might have further comments)

Fri, Jun 24, 3:55 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 22

tahonermann added inline comments to D128059: [Clang] Add a warning on invalid UTF-8 in comments..
Wed, Jun 22, 11:54 AM · Restricted Project, Restricted Project, Restricted Project
tahonermann added inline comments to D128059: [Clang] Add a warning on invalid UTF-8 in comments..
Wed, Jun 22, 9:08 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

tahonermann added inline comments to D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures.
Tue, Jun 21, 9:48 AM · Restricted Project, Restricted Project

Wed, Jun 15

tahonermann accepted D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'.

Looks good to me! Thanks Jolanta!

Wed, Jun 15, 11:25 AM · Restricted Project, Restricted Project

Tue, Jun 14

tahonermann added a reviewer for D127812: [AArch64] Function multiversioning support added.: erichkeane.
Tue, Jun 14, 6:31 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
tahonermann added inline comments to D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'.
Tue, Jun 14, 8:14 AM · Restricted Project, Restricted Project

Mon, Jun 13

tahonermann added inline comments to D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'.
Mon, Jun 13, 1:41 PM · Restricted Project, Restricted Project
tahonermann added a comment to D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'.

The code changes and test updates all look good to me. Please add a release note to clang/docs/ReleaseNotes.rst; I'll be happy to approve after that is done. It would be great to get an additional approval on this; I'm not an expert here.

Mon, Jun 13, 7:33 AM · Restricted Project, Restricted Project

Fri, Jun 10

tahonermann requested changes to D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'.
Fri, Jun 10, 8:56 AM · Restricted Project, Restricted Project

Thu, Jun 9

tahonermann requested changes to D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures.

When submitting patches, please create the diff with context so that the code can be navigated in Phabricator. See https://llvm.org/docs/Phabricator.html#phabricator-request-review-web for details on how to do so.

Thu, Jun 9, 2:39 PM · Restricted Project, Restricted Project

Tue, Jun 7

tahonermann added inline comments to D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'.
Tue, Jun 7, 8:40 AM · Restricted Project, Restricted Project

Mon, Jun 6

tahonermann added a comment to D126818: Itanium ABI: Implement mangling for constrained friends.

Note we might be confused, the parens there aren't completely clear as to what your intent is.

Mon, Jun 6, 8:59 PM · Restricted Project

Fri, Jun 3

tahonermann added a comment to D126959: [C++20][Modules] Introduce an implementation module..

Implementation modules are never serialized (-emit-module-interface for an implementation unit is diagnosed and rejected).

Fri, Jun 3, 8:45 AM · Restricted Project, Restricted Project

Thu, Jun 2

tahonermann added a comment to D126818: Itanium ABI: Implement mangling for constrained friends.

I wonder if I'm reading (temp.friend)p9` sentence 2 correctly. Which of these should it be parsed as?

Thu, Jun 2, 2:03 PM · Restricted Project

Tue, May 31

tahonermann added inline comments to D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'.
Tue, May 31, 11:01 AM · Restricted Project, Restricted Project
tahonermann added inline comments to D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'.
Tue, May 31, 10:58 AM · Restricted Project, Restricted Project

May 19 2022

tahonermann added a comment to D125773: [Driver] Do not auto-enable header modules with -std=c++20.

So the proposal is that -fheader-modules=parse would parse #include of header unit in the same TU, and import .pcm on import, right?

May 19 2022, 8:33 AM · Restricted Project, Restricted Project

May 18 2022

tahonermann accepted D125882: Correct the diagnostic behavior for unreachable _Generic associations in C++.

LGTM!

May 18 2022, 9:05 AM · Restricted Project, Restricted Project

May 17 2022

tahonermann added a comment to D125259: [C11] Diagnose unreachable generic selection associations.

I'm questioning the benefit to supporting _Generic in C++ and starting to wonder if perhaps we should pull this extension back.

May 17 2022, 1:11 PM · Restricted Project, Restricted Project

May 13 2022

tahonermann added inline comments to rG4be105c98a9c: Silence some false positive -Wstrict-prototype warnings.
May 13 2022, 7:04 AM · Restricted Project, Restricted Project

May 12 2022

tahonermann accepted D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.

Looks good, @tbaeder! Thank you for sticking with me through all these iterations!

May 12 2022, 7:18 AM · Restricted Project, Restricted Project

May 11 2022

tahonermann added inline comments to D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
May 11 2022, 7:25 AM · Restricted Project, Restricted Project

May 10 2022

tahonermann added inline comments to D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
May 10 2022, 9:11 AM · Restricted Project, Restricted Project
tahonermann added inline comments to D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
May 10 2022, 9:04 AM · Restricted Project, Restricted Project

May 9 2022

tahonermann accepted D125259: [C11] Diagnose unreachable generic selection associations.

Looks good to me!

May 9 2022, 12:46 PM · Restricted Project, Restricted Project
tahonermann added inline comments to D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
May 9 2022, 9:52 AM · Restricted Project, Restricted Project
tahonermann added inline comments to D125167: [WIP] Fix member access of anonymous struct/union fields in C.
May 9 2022, 9:19 AM · Restricted Project, Restricted Project
tahonermann added inline comments to D125167: [WIP] Fix member access of anonymous struct/union fields in C.
May 9 2022, 8:56 AM · Restricted Project, Restricted Project

May 6 2022

tahonermann closed D124719: [docs] PCH usage documentation update.

Re-closing since this review has already landed.

May 6 2022, 1:48 PM · Restricted Project, Restricted Project
tahonermann added a comment to D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.

Thanks for your continued work on this, Tim! I think this is close. I did spot one issue and added a few other comments.

May 6 2022, 9:27 AM · Restricted Project, Restricted Project

May 5 2022

tahonermann added inline comments to D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.
May 5 2022, 8:04 AM · Restricted Project, Restricted Project
tahonermann added a comment to D104975: Implement P1949.

Since it is a C++23 feature, can we at least have it only if the user requests C++23 standard compliance?

May 5 2022, 7:50 AM · Restricted Project, Restricted Project, Restricted Project
tahonermann requested changes to D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals.

I think changes are needed to make this behavior dependent on whether char8_t support is active or not.

May 5 2022, 7:33 AM · Restricted Project, Restricted Project

May 4 2022

tahonermann reopened D124719: [docs] PCH usage documentation update.

Reopening for further discussion or clarification.

May 4 2022, 1:48 PM · Restricted Project, Restricted Project
tahonermann added a comment to D104975: Implement P1949.

I hope at least GCC will not implement this arbitrary restriction on math symbols. I would argue a partial derivative symbol in C++ has more sense than a skull emoji.

May 4 2022, 1:08 PM · Restricted Project, Restricted Project, Restricted Project

Apr 29 2022

tahonermann accepted rGef87865b98fa: Silence -Wstrict-prototype diagnostics in C2x mode.

Looks good to me.

Apr 29 2022, 12:24 PM · Restricted Project, Restricted Project
tahonermann added a comment to D122895: [C89/C2x] Improve diagnostics around strict prototypes in C.

I think it's debatable whether this is a bug or not

Apr 29 2022, 7:34 AM · Restricted Project, Restricted Project

Apr 28 2022

tahonermann accepted D124258: [C89/C2x] Change the behavior of implicit int diagnostics.
Apr 28 2022, 11:02 AM · Restricted Project, Restricted Project, Restricted Project
tahonermann accepted D124258: [C89/C2x] Change the behavior of implicit int diagnostics.
Apr 28 2022, 7:06 AM · Restricted Project, Restricted Project, Restricted Project
tahonermann added a reviewer for D124258: [C89/C2x] Change the behavior of implicit int diagnostics: tahonermann.
Apr 28 2022, 7:06 AM · Restricted Project, Restricted Project, Restricted Project
tahonermann added a comment to D124258: [C89/C2x] Change the behavior of implicit int diagnostics.

Ping for the other reviewers in case they have thoughts.

Apr 28 2022, 7:06 AM · Restricted Project, Restricted Project, Restricted Project

Apr 25 2022

tahonermann added inline comments to D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=.
Apr 25 2022, 12:15 PM · Restricted Project, Restricted Project
tahonermann added inline comments to D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=.
Apr 25 2022, 11:45 AM · Restricted Project, Restricted Project

Apr 19 2022

tahonermann added a comment to D119544: Deferred Concept Instantiation Implementation.

I wouldn't think so either? In this case the problem is that 'u' is not in the re-manufactured scope, I think there is a bit of work to make sure that lambdas ALSO get the scope of their containing function, if they are in a functiondecl.

Apr 19 2022, 8:46 AM · Restricted Project, Restricted Project
tahonermann added a comment to D119544: Deferred Concept Instantiation Implementation.

This is a case where the function is a template instantiation but does NOT have a primary template, so I have to figure out what THAT means/what I should be using instead.

Apr 19 2022, 7:59 AM · Restricted Project, Restricted Project

Apr 18 2022

tahonermann added inline comments to D123955: [C2x] Disallow functions without prototypes/functions with identifier lists.
Apr 18 2022, 1:31 PM · Restricted Project, Restricted Project

Apr 15 2022

tahonermann added a comment to D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C..

This might've caused a regression? (https://github.com/llvm/llvm-project/issues/54892)

Apr 15 2022, 1:02 PM · Restricted Project, Restricted Project

Apr 13 2022

tahonermann accepted D119221: [clang][lexer] Allow u8 character literal prefixes in C2x.

Looks good to me! Thank you for filing the separate issue.

Apr 13 2022, 8:54 AM · Restricted Project, Restricted Project

Apr 12 2022

tahonermann added inline comments to D122952: [clang] NFC: Extend comdat validation in target multiversion function tests..
Apr 12 2022, 2:19 PM · Restricted Project, Restricted Project

Apr 5 2022

tahonermann committed rG5531abaf7158: [clang] Corrections for target_clones multiversion functions. (authored by tahonermann).
[clang] Corrections for target_clones multiversion functions.
Apr 5 2022, 4:51 PM · Restricted Project, Restricted Project
tahonermann committed rG40af8df6fe64: [clang] NFC: Preparation for merging code to emit target and target_clones… (authored by tahonermann).
[clang] NFC: Preparation for merging code to emit target and target_clones…
Apr 5 2022, 4:51 PM · Restricted Project, Restricted Project
tahonermann committed rG0ace0100aec3: [clang] NFC: Simplify the interface to CodeGenModule… (authored by tahonermann).
[clang] NFC: Simplify the interface to CodeGenModule…
Apr 5 2022, 4:51 PM · Restricted Project, Restricted Project
tahonermann committed rGbed5ee3f4ba2: [clang] NFC: Enhance comments in CodeGen for multiversion function support. (authored by tahonermann).
[clang] NFC: Enhance comments in CodeGen for multiversion function support.
Apr 5 2022, 4:51 PM · Restricted Project, Restricted Project
tahonermann closed D122958: [clang] Corrections for target_clones multiversion functions..
Apr 5 2022, 4:51 PM · Restricted Project, Restricted Project
tahonermann closed D122957: [clang] NFC: Preparation for merging code to emit target and target_clones resolvers..
Apr 5 2022, 4:50 PM · Restricted Project, Restricted Project
tahonermann closed D122956: [clang] NFC: Simplify the interface to CodeGenModule::GetOrCreateMultiVersionResolver()..
Apr 5 2022, 4:50 PM · Restricted Project, Restricted Project
tahonermann closed D122955: [clang] NFC: Enhance comments in CodeGen for multiversion function support..
Apr 5 2022, 4:50 PM · Restricted Project, Restricted Project
tahonermann closed D122953: [clang] Emit target_clones resolver functions as COMDAT..

Closing per commit 7c53fc4fe1308f5b2a7527d14ea41fabb18109b8 (I failed to add "Differential Revision" to the commit message).

Apr 5 2022, 3:54 PM · Restricted Project, Restricted Project
tahonermann closed D122952: [clang] NFC: Extend comdat validation in target multiversion function tests..

Closing per commit 3531a4fa3b7038d43ac20f56871da88aa25bf53d (I failed to add "Differential Revision" to the commit message).

Apr 5 2022, 3:53 PM · Restricted Project, Restricted Project
tahonermann closed D122618: [Lint][Verifier] NFC: Rename 'Assert*' macros to 'Check*'..

Closing per commit c54ad1360248e28a436a6a6c560ba5952d8e98cb (I failed to get "Differential Revision" added to the commit message).

Apr 5 2022, 3:50 PM · Restricted Project, Restricted Project
tahonermann added a comment to D123064: [Clang][C++23] P2071 Named universal character escapes.

This looks pretty good to me. I added a few comments. I mostly just reviewed the lexer related code; I didn't dive into the name matching code.

Apr 5 2022, 1:38 PM · Restricted Project, Restricted Project, Restricted Project
tahonermann committed rG7c53fc4fe130: [clang] Emit target_clones resolver functions as COMDAT. (authored by tahonermann).
[clang] Emit target_clones resolver functions as COMDAT.
Apr 5 2022, 12:35 PM · Restricted Project, Restricted Project
tahonermann committed rGc54ad1360248: [Lint][Verifier] NFC: Rename 'Assert*' macros to 'Check*'. (authored by tahonermann).
[Lint][Verifier] NFC: Rename 'Assert*' macros to 'Check*'.
Apr 5 2022, 12:35 PM · Restricted Project, Restricted Project
tahonermann committed rG3531a4fa3b70: [clang] NFC: Extend comdat validation in target multiversion function tests. (authored by tahonermann).
[clang] NFC: Extend comdat validation in target multiversion function tests.
Apr 5 2022, 12:35 PM · Restricted Project, Restricted Project
tahonermann abandoned D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions..

Abandoning this review; the changes made here have been squashed into D122958.

Apr 5 2022, 11:57 AM · Restricted Project, Restricted Project
tahonermann updated the diff for D122958: [clang] Corrections for target_clones multiversion functions..

Squashed the addition of tests originally made in D122954 to this review.

Apr 5 2022, 11:44 AM · Restricted Project, Restricted Project
tahonermann updated the diff for D122955: [clang] NFC: Enhance comments in CodeGen for multiversion function support..

Reworded a comment to address code review commentary.

Apr 5 2022, 11:41 AM · Restricted Project, Restricted Project

Apr 4 2022

tahonermann added a comment to D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions..

but I DO have the opposite problem: Figuring out what the associated tests are for a patch

Apr 4 2022, 2:11 PM · Restricted Project, Restricted Project
tahonermann added a comment to D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions..

FWIW, I dislike this idea of doing tests in separate commits from the patch itself, it makes the review of the patch more difficult, and makes looking through history more difficult.

Apr 4 2022, 12:57 PM · Restricted Project, Restricted Project

Apr 2 2022

tahonermann published D122958: [clang] Corrections for target_clones multiversion functions. for review.
Apr 2 2022, 2:12 PM · Restricted Project, Restricted Project
tahonermann published D122957: [clang] NFC: Preparation for merging code to emit target and target_clones resolvers. for review.
Apr 2 2022, 2:11 PM · Restricted Project, Restricted Project
tahonermann published D122956: [clang] NFC: Simplify the interface to CodeGenModule::GetOrCreateMultiVersionResolver(). for review.
Apr 2 2022, 2:11 PM · Restricted Project, Restricted Project
tahonermann published D122955: [clang] NFC: Enhance comments in CodeGen for multiversion function support. for review.
Apr 2 2022, 2:11 PM · Restricted Project, Restricted Project
tahonermann published D122954: [clang] Extend target_clones tests to exercise declarations that are not definitions. for review.
Apr 2 2022, 2:11 PM · Restricted Project, Restricted Project
tahonermann published D122953: [clang] Emit target_clones resolver functions as COMDAT. for review.
Apr 2 2022, 2:11 PM · Restricted Project, Restricted Project
tahonermann published D122952: [clang] NFC: Extend comdat validation in target multiversion function tests. for review.
Apr 2 2022, 2:11 PM · Restricted Project, Restricted Project

Apr 1 2022

tahonermann accepted D122608: Fix behavior of ifuncs with 'used' extern "C" static functions.

Looks good to me! I left one final comment about a double period that was my fault.

Apr 1 2022, 12:59 PM · Restricted Project, Restricted Project
tahonermann added inline comments to D122608: Fix behavior of ifuncs with 'used' extern "C" static functions.
Apr 1 2022, 12:47 PM · Restricted Project, Restricted Project
tahonermann added a comment to D122618: [Lint][Verifier] NFC: Rename 'Assert*' macros to 'Check*'..

Thanks for the approval @aeubanks! If no objections are raised, I'll land this Tuesday morning.

Apr 1 2022, 12:38 PM · Restricted Project, Restricted Project

Mar 31 2022

tahonermann added inline comments to D122608: Fix behavior of ifuncs with 'used' extern "C" static functions.
Mar 31 2022, 8:42 PM · Restricted Project, Restricted Project

Mar 29 2022

tahonermann added inline comments to D122608: Fix behavior of ifuncs with 'used' extern "C" static functions.
Mar 29 2022, 12:05 PM · Restricted Project, Restricted Project
tahonermann added a comment to D122618: [Lint][Verifier] NFC: Rename 'Assert*' macros to 'Check*'..

perhaps Verify() makes a bit more sense than Check() at least for the verifier?

Mar 29 2022, 7:43 AM · Restricted Project, Restricted Project

Mar 28 2022

tahonermann published D122618: [Lint][Verifier] NFC: Rename 'Assert*' macros to 'Check*'. for review.

I've added some reviewers based on prior git history for the changed files. Please feel free to resign or nominate another reviewer!

Mar 28 2022, 2:36 PM · Restricted Project, Restricted Project

Mar 21 2022

tahonermann committed rG059a953d8819: [clang] [OpenMP] Diagnose use of 'target_clones' in OpenMP variant declarations. (authored by tahonermann).
[clang] [OpenMP] Diagnose use of 'target_clones' in OpenMP variant declarations.
Mar 21 2022, 10:40 AM · Restricted Project
tahonermann committed rG0cceee755992: [clang] Produce a "multiversion" annotation in textual AST output. (authored by tahonermann).
[clang] Produce a "multiversion" annotation in textual AST output.
Mar 21 2022, 10:40 AM · Restricted Project
tahonermann committed rG8ff8c3ac0dd6: [clang] [OpenMP] Extend OpenMP variant declaration tests. (authored by tahonermann).
[clang] [OpenMP] Extend OpenMP variant declaration tests.
Mar 21 2022, 10:40 AM · Restricted Project
tahonermann committed rG58c202a3d83d: [clang] NFC: Rename 'MVType' variables to 'MVKind' for consistency with their… (authored by tahonermann).
[clang] NFC: Rename 'MVType' variables to 'MVKind' for consistency with their…
Mar 21 2022, 10:40 AM · Restricted Project
tahonermann closed D121963: [clang] [OpenMP] Diagnose use of 'target_clones' in OpenMP variant declarations..
Mar 21 2022, 10:40 AM · Restricted Project, Restricted Project
tahonermann committed rG8b6f1cbb21c5: [clang] Add missing diagnostics for invalid overloads of multiversion functions… (authored by tahonermann).
[clang] Add missing diagnostics for invalid overloads of multiversion functions…
Mar 21 2022, 10:40 AM · Restricted Project
tahonermann committed rG42e4c5b2610d: [clang] NFC: Remove forced type merging in multiversion function checks. (authored by tahonermann).
[clang] NFC: Remove forced type merging in multiversion function checks.
Mar 21 2022, 10:40 AM · Restricted Project
tahonermann closed D121962: [clang] [OpenMP] Extend OpenMP variant declaration tests..
Mar 21 2022, 10:40 AM · Restricted Project, Restricted Project
tahonermann committed rG01b2e0567c54: [clang] NFC: Redundant code removal in SemaDecl.cpp… (authored by tahonermann).
[clang] NFC: Redundant code removal in SemaDecl.cpp…
Mar 21 2022, 10:40 AM · Restricted Project
tahonermann closed D121961: [clang] Produce a "multiversion" annotation in textual AST output..
Mar 21 2022, 10:40 AM · Restricted Project, Restricted Project
tahonermann committed rG77472a659e25: [clang] NFC: Dead code removal in SemaDecl.cpp, CheckMultiVersionFunction(). (authored by tahonermann).
[clang] NFC: Dead code removal in SemaDecl.cpp, CheckMultiVersionFunction().
Mar 21 2022, 10:40 AM · Restricted Project
tahonermann closed D121960: [clang] NFC: Rename 'MVType' variables to 'MVKind' for consistency with their type..
Mar 21 2022, 10:40 AM · Restricted Project, Restricted Project
tahonermann closed D121959: [clang] Add missing diagnostics for invalid overloads of multiversion functions in C..
Mar 21 2022, 10:40 AM · Restricted Project, Restricted Project
tahonermann committed rG325c4c29d68c: [clang] Add test cases for multiversion function overload scenarios in C. (authored by tahonermann).
[clang] Add test cases for multiversion function overload scenarios in C.
Mar 21 2022, 10:40 AM · Restricted Project
tahonermann closed D121958: [clang] NFC: Remove forced type merging in multiversion function checks..
Mar 21 2022, 10:40 AM · Restricted Project, Restricted Project
tahonermann closed D121957: [clang] NFC: Redundant code removal in SemaDecl.cpp, CheckTargetCausesMultiVersioning()..
Mar 21 2022, 10:40 AM · Restricted Project, Restricted Project