- User Since
- Jun 25 2014, 4:17 PM (273 w, 4 d)
Fri, Sep 20
Thu, Sep 19
Tue, Sep 17
It's best not to have two places that define the macro. Can we always pass in -D from the driver instead?
Fri, Sep 13
Sure, I can do that today.
Thu, Sep 12
I think @delcypher wanted to test it first
Wed, Sep 11
LGTM with one suggestion
Mon, Sep 9
LGTM, but please: add a CHECK somewhere that a CompilationComandIdx is actually emitted as a prefix (I don't see one now).
Good catch, thanks!
Fri, Sep 6
When fully implemented, will define inline tweak work with C++ methods in classes as well?
Thanks! I think that's a better layering. LGTM. I don't think there's a particular need to report error to clients of just the DependencyFileGenerator.
The approach seems reasonable to me
Wed, Sep 4
restructure the code to perform skipping directly in the preprocessor
Why "We need at least one -MT equivalent for the generator to work."?
Instead of basing the new -MT name off the output, can you base it on the name of the input filename instead to simplify this logic?
Add support for chained PP callbacks in setAdditionalPPCallbacks.
Thanks, this is useful for clang-scan-deps too!
Tue, Sep 3
Thanks for fixing this! Could you add a test case which verifies that the assertion no longer happens? Let me know if you need help coming up with a test.
Fri, Aug 30
Thu, Aug 29
Wed, Aug 28
Tue, Aug 27
Will the git monorepo handle svn:eol-style correctly?
Mon, Aug 26
Is there any way to test this, or is it pretty much hopeless?
Missing full context
Sat, Aug 24
Aug 23 2019
Address review comments.
Aug 22 2019
Reimplement the new option on top of -MJ. -MJ is still the preferred option if both are specified.
@jkorous I addressed your comments as well ("" directory is now allowed, error is reported, existing escape used).