- User Since
- Jun 25 2014, 4:17 PM (191 w, 3 d)
Mon, Feb 12
LGTM, I didn't find any issues
Thu, Feb 8
Wed, Feb 7
Thanks for your input. You're right, this warning is quite correct (even though it seems like too much).
Mon, Feb 5
Address review comments and fix the inverted check case.
Wed, Jan 31
Tue, Jan 30
Oops, that logic turned out to be incorrect. We simply have to start a new storage unit when the new bitfield's size is wider than the available bits.
Fix packing logic.
Mon, Jan 29
Jan 25 2018
Jan 19 2018
I think that's a sensible fix, thanks!
Jan 4 2018
Jan 3 2018
Dec 29 2017
Dec 21 2017
It turns out there's already something that works much better: #pragma clang __debug handle_crash. Sorry about the redundant patch!
LGTM, thank you
Address review comments
Dec 20 2017
Dec 19 2017
Note that even though there is a discrepancy between GCC and Clang, this patch does not change Clang's behavior in this instance as it emitted -1 previously as well
Dec 15 2017
- Remove redundant checks.
- Remove the ARC-specific check.
Dec 14 2017
Fixed in r320766. Sorry about that!
Sure, I'll do it today.
Dec 13 2017
- Use separate functions for checks.
- "ARM" should match "thumb" arch too.
Dec 12 2017
- Change error message.
- Take sub arch into account.
Dec 11 2017
Accidental 'return', will reopen
Don't warn about the redundant environment variable
Dec 8 2017
I rewrote the patch on top of https://reviews.llvm.org/D41035 as suggested by Duncan.
Preparation refactoring patch: https://reviews.llvm.org/D41035
Dec 7 2017
Sorry, accidental Return. Will close and reopen.