- User Since
- Jun 25 2014, 4:17 PM (465 w, 3 d)
Mon, May 22
Mar 28 2023
How is this attribute going to handle a trampoline that performs a virtual dispatch from C++ call into Swift? In that case, the target is not known.
Mar 12 2023
Feb 23 2023
Feb 15 2023
Feb 6 2023
updated test file with correct version check.
- Updated version to be the date.
- Updated release notes.
- Fixed a bug in my changed tablegen code in previous patch.
Jan 31 2023
Jan 24 2023
Jan 20 2023
Jan 19 2023
Updated __has_attribute(external_source_symbol) to return a version.
Jan 18 2023
@erichkeane I've added more test coverage with different USR values, C++ decls and some dependent C++ decls too. How does it look now?
add more test coverage
I posted the Swift patch here:
Jan 10 2023
Updated to address review comments.
Jan 9 2023
Dec 19 2022
Dec 13 2022
Great, thank you!
Dec 9 2022
Unfortunately I'm unable to revert this commit now so we won't be able to get the bot back to green until it's fixed.
Nov 29 2022
This change has caused a failure in Clang's stage 2 CI on the green dragon Darwin CI: https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6390/console.
Nov 17 2022
Thanks, this LGTM. You might want to get another reviewers approval as well.
Nov 16 2022
Nov 14 2022
Nov 10 2022
Nov 2 2022
Oct 12 2022
Thanks, this looks good!
Oct 4 2022
Jun 16 2022
@rnk this is option is needed to vendor the Apple clang toolchain in Xcode. Unfortunately we don't have any references to it in the upstream llvm-project repo, but this is breaking our downstream integration. Can this be reverted?
May 25 2022
May 24 2022
Marked them as unsupported on AIX in 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9.
I'm going to disable these tests for aix for now to unblock the bot as they're still failing.
Do you happen to have suggestions for how to try to reproduce this? Looking at the failure it looks like this CI job somehow was unable to be affected by this change, for instance the CI output of index-concept-kind.cpp does not have any concepts output:
May 23 2022
Fix the windows test failure (add -fno-delayed-template-parsing)
Yes, I'm going to check what's wrong with it.
May 19 2022
May 12 2022
LGTM, with one request.
Apr 18 2022
Great, thanks for adding the test case!
Apr 13 2022
The change itself LGTM.
Mar 21 2022
clang -x objective-c++ -Weverything -std=c++14 -c test.mm
I don't think this patch is sound. I found this problem with this change when the following file is compiled in Objective-C++ mode:
Mar 18 2022
Mar 17 2022
I see, thanks! Let me think a bit more about this change and test it on our codebase to see if this is a viable Sema change.
Mar 15 2022
Is there a Swift-based test case you have that demonstrates the original problem from Swift's clang importer side? I'm curious to see where it manifests in Swift.
Mar 14 2022
Feb 22 2022
No, I will land it today.
Feb 21 2022
Feb 15 2022
Feb 14 2022
Add checking for -darwin-target-variant support
Can you add a test case that verifies that using driverkit without a version will default it to driverkit19?
Feb 11 2022
bdf573652138..3f05192c4c40 main -> main
Yep, I just noticed. Reverting for now and will fix LLDB before recommitting.
Feb 8 2022
Feb 7 2022
Feb 2 2022
Feb 1 2022
Fix test failure with asserts enabled.
Update to address review feedback, remove appendToken which is not needed as we're can just setTokens instead (it's a new macro info)
Thanks, that feedback makes sense. I'll update the patch today.