- User Since
- Jun 25 2014, 4:17 PM (237 w, 6 d)
Mon, Jan 14
Fri, Jan 11
Wed, Jan 9
Address review comments.
Tue, Jan 8
That makes sense, LGTM. Thanks!
Thu, Jan 3
Do not annotate one token [ .... ] expressions as Objective-C message sends as suggested by Duncan.
Wed, Jan 2
Fri, Dec 21
Thu, Dec 20
I think Args.getArgString might return nullptr so that's why you could crash.
Fixed comment, will commit.
Wed, Dec 19
I think we might need to run it past the internal builds to see if anything breaks.
Mon, Dec 17
Dec 14 2018
Ensure test will pass on non-darwin.
Updated to infer deployment target version from SDK versions specified in the JSON file and to allow inferring the SDK version from the SDK path.
Dec 13 2018
Dec 12 2018
Dec 11 2018
Thanks for working on this! Could you please post a patch with full context (git diff -U9999)?
Dec 7 2018
Dec 6 2018
Swift uses -Xclang to pass in build settings to its own build and to pass in custom options through its Clang importer that we intentionally don't want to expose to Clang's users. We don't want to warn for those uses for sure.
Dec 5 2018
Dec 3 2018
Please mention this change in the release notes though.
Nov 30 2018
So far everything looks fine, but I have to rerun a couple of things due to infrastructural issues. I should have the final results next Monday.
Nov 26 2018
LGTM, we can optimize later. It looks like you also moved SymbolID to a new file, this should be an NFC precommit.
Nov 16 2018
Thanks for working on this, some minor comments:
I don't think we want to move the logic to add a libc++ path to the driver. -cc1 with -resource-dir and -stdlib=libc++ should still work as before. In this case the previous patch is better, except it should not set InstalledDir except when needed (e.g. for tooling when working with a CDB that has an absolute path to the compiler), so when InstalledDir is empty it should fallback to the current logic in InitHeaderSearch.cpp. That should solve the issues we had.
Would it be better to deprecate the use of PTH right now for the current release, so that the users will be aware that we will remove PTH support in LLVM 9 once they upgrade to LLVM 8? Then we can remove it right after LLVM 8 branch is created.
Nov 14 2018
I don't think we should be using textDocument/definition here, and I agree with Sam that a new method would be better. We don't actually need the semantic guarantees/constrains imposed by LSP's description of textDocument/definition, as we want to find any declaration that corresponds to the reference at the location, so we don't need to guarantee that we return some definition. This would also avoid any confusion about USRs returned in textDocument/definition/textDocument/references.
Nov 13 2018
Nov 12 2018
Apologies for not seeing this earlier.
I agree with George, this behavior doesn't seem right to me.
Oct 26 2018
LGTM too when Aaron's comments are addressed
Oct 25 2018
Thanks! It looks pretty good, just minor nit. could you also update the language extension doc and release notes?
Oct 18 2018
Oct 16 2018
Oops, this is a wrong patch. Sorry for the noise.
Sep 10 2018
Remove dead code for filesystem update fileID matching.