arphaman (Alex Lorenz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2014, 4:17 PM (160 w, 4 d)

Recent Activity

Today

arphaman updated the diff for D35726: unguarded availability: add a fixit for the "annotate '...' with an availability attribute to silence" note.

Addressed Erik's comments

Mon, Jul 24, 7:43 AM
arphaman added inline comments to D35726: unguarded availability: add a fixit for the "annotate '...' with an availability attribute to silence" note.
Mon, Jul 24, 7:43 AM
arphaman accepted D35736: [ubsan] -fsanitize=vptr now requires -fsanitize=null, update tests.

LGTM

Mon, Jul 24, 6:18 AM
arphaman added a comment to D35735: [ubsan] Null-check pointers in -fsanitize=vptr (PR33881).

You might also want to mention the fact that -fsanitizer=vptr requires null in the release notes.

Mon, Jul 24, 6:18 AM
arphaman accepted D35735: [ubsan] Null-check pointers in -fsanitize=vptr (PR33881).

LGTM!

Mon, Jul 24, 6:14 AM
arphaman added a comment to D34748: [clang-diff] improve mapping accuracy, HTML side-by-side diff..

Some comments:

Mon, Jul 24, 4:28 AM

Fri, Jul 21

arphaman created D35726: unguarded availability: add a fixit for the "annotate '...' with an availability attribute to silence" note.
Fri, Jul 21, 8:01 AM
arphaman committed rL308737: [clang-diff] Get rid of unused variable warnings in ASTDiff.cpp.
[clang-diff] Get rid of unused variable warnings in ASTDiff.cpp
Fri, Jul 21, 6:19 AM
arphaman committed rL308735: Clang's tests should depend on clang-diff.
Clang's tests should depend on clang-diff
Fri, Jul 21, 6:12 AM
arphaman committed rL308734: Fix another compiler error from r308731.
Fix another compiler error from r308731
Fri, Jul 21, 6:05 AM
arphaman committed rL308733: Fix tuple construction compiler error from r308731.
Fix tuple construction compiler error from r308731
Fri, Jul 21, 6:01 AM
arphaman committed rL308731: [clang-diff] Add initial implementation.
[clang-diff] Add initial implementation
Fri, Jul 21, 5:50 AM
arphaman closed D34329: [clang-diff] Initial implementation. by committing rL308731: [clang-diff] Add initial implementation.
Fri, Jul 21, 5:50 AM
arphaman added a comment to D34329: [clang-diff] Initial implementation..

I'll commit this on behalf of Johannes today as he didn't get his access yet

Fri, Jul 21, 3:09 AM

Wed, Jul 19

arphaman added a comment to D35484: Add a warning for missing '#pragma pack (pop)' and suspicious '#pragma pack' uses when including files.

This triggered a warning in LLVM itself, in CoverageMapping.h :

Wed, Jul 19, 6:01 AM
arphaman committed rL308441: Recommit r308327: Add a warning for missing '#pragma pack (pop)'.
Recommit r308327: Add a warning for missing '#pragma pack (pop)'
Wed, Jul 19, 4:31 AM
arphaman accepted D35520: [Sema] Improve diagnostic message for unavailable c++17 aligned allocation functions .

LGTM, Thanks.

Wed, Jul 19, 2:39 AM

Tue, Jul 18

arphaman updated the diff for D35012: [refactor] Add the AST source selection component.

rm early exit bug

Tue, Jul 18, 10:44 AM
arphaman committed rL308328: Revert r308327.
Revert r308327
Tue, Jul 18, 10:37 AM
arphaman committed rL308327: Add a warning for missing '#pragma pack (pop)' and suspicious uses.
Add a warning for missing '#pragma pack (pop)' and suspicious uses
Tue, Jul 18, 10:24 AM
arphaman closed D35484: Add a warning for missing '#pragma pack (pop)' and suspicious '#pragma pack' uses when including files by committing rL308327: Add a warning for missing '#pragma pack (pop)' and suspicious uses.
Tue, Jul 18, 10:24 AM
arphaman added a comment to D35012: [refactor] Add the AST source selection component.

Oops, I just realised that now there's a small bug with early exits. Since we don't actually have true lexical order for declarations in the @implementation we might exit early after visiting a method in the @implementation before a function that's actually written before that method. I will probably constraint early exits to avoid this case.

Tue, Jul 18, 9:49 AM
arphaman updated the diff for D35012: [refactor] Add the AST source selection component.

Factor out the lexical ordering code into a new visitor and simplify the implementation of the ast selection visitor

Tue, Jul 18, 9:46 AM
arphaman added inline comments to D35012: [refactor] Add the AST source selection component.
Tue, Jul 18, 7:03 AM
arphaman updated the diff for D35484: Add a warning for missing '#pragma pack (pop)' and suspicious '#pragma pack' uses when including files.

Address review comments.

Tue, Jul 18, 6:43 AM
arphaman added inline comments to D35520: [Sema] Improve diagnostic message for unavailable c++17 aligned allocation functions .
Tue, Jul 18, 6:02 AM
arphaman added inline comments to D35012: [refactor] Add the AST source selection component.
Tue, Jul 18, 5:45 AM
arphaman updated the diff for D35012: [refactor] Add the AST source selection component.
  • Address review comments.
  • Remove the Location parameter and ContainsSelectionPoint enum value.
  • Stop traversing early when a declaration that ends after the selection range was reached.
Tue, Jul 18, 5:44 AM

Mon, Jul 17

arphaman added inline comments to D35012: [refactor] Add the AST source selection component.
Mon, Jul 17, 9:19 AM
arphaman created D35484: Add a warning for missing '#pragma pack (pop)' and suspicious '#pragma pack' uses when including files.
Mon, Jul 17, 7:38 AM
arphaman added a comment to D35012: [refactor] Add the AST source selection component.

Ping.

Mon, Jul 17, 4:03 AM
arphaman added inline comments to D35379: Add documentation for @available.
Mon, Jul 17, 2:57 AM

Fri, Jul 14

arphaman accepted D35398: Add filename support to yaml::Input..

Yep, LGTM. Thanks.

Fri, Jul 14, 7:48 AM
arphaman accepted D35405: [index] Added a method indexTopLevelDecls to run indexing on a list of Decls..

LGTM, thanks.

Fri, Jul 14, 3:25 AM
arphaman requested changes to D35405: [index] Added a method indexTopLevelDecls to run indexing on a list of Decls..

Nice, I will need something like this for the refactoring stress test tool in the future that verifies that the indexer and renaming engine have a similar view of the code.

Fri, Jul 14, 3:20 AM
arphaman added a comment to D35379: Add documentation for @available.

Thanks for doing this! I have some comments:

Fri, Jul 14, 12:53 AM

Thu, Jul 13

arphaman committed rL307924: Extend -Wdeprecated-implementations to warn about unavailable methods.
Extend -Wdeprecated-implementations to warn about unavailable methods
Thu, Jul 13, 9:37 AM
arphaman committed rL307923: NFC, Cleanup the code for -Wdeprecated-implementations.
NFC, Cleanup the code for -Wdeprecated-implementations
Thu, Jul 13, 9:36 AM
arphaman committed rL307908: Remove another 'using namespace llvm' from the.
Remove another 'using namespace llvm' from the
Thu, Jul 13, 5:49 AM
arphaman committed rL307905: Remove 'using namespace llvm' from the USRFinder.h header.
Remove 'using namespace llvm' from the USRFinder.h header
Thu, Jul 13, 4:27 AM
arphaman committed rL307903: [ObjC] Pick a 'readwrite' property when synthesizing ambiguous.
[ObjC] Pick a 'readwrite' property when synthesizing ambiguous
Thu, Jul 13, 4:07 AM
arphaman closed D35268: [ObjC] Ambiguous property synthesis should pick the 'readwrite' property and check for incompatible attributes by committing rL307903: [ObjC] Pick a 'readwrite' property when synthesizing ambiguous.
Thu, Jul 13, 4:06 AM
arphaman committed rL307901: [index] Objective-C method declarations and message sends with.
[index] Objective-C method declarations and message sends with
Thu, Jul 13, 3:50 AM
arphaman committed rL307898: [refactor][rename] Use a single base class for class that finds.
[refactor][rename] Use a single base class for class that finds
Thu, Jul 13, 3:37 AM
arphaman closed D34949: [refactor][rename] Use a single base class for class that finds a declaration at location and for class that searches for all occurrences of a specific declaration by committing rL307898: [refactor][rename] Use a single base class for class that finds.
Thu, Jul 13, 3:37 AM

Wed, Jul 12

arphaman committed rL307813: [diagtool] Add a 'find-diagnostic-id' subcommand that converts a name of.
[diagtool] Add a 'find-diagnostic-id' subcommand that converts a name of
Wed, Jul 12, 9:42 AM
arphaman closed D35306: [diagtool] Add the 'find-diagnostic-id' subcommand that converts a name of the diagnostic to its enum value by committing rL307813: [diagtool] Add a 'find-diagnostic-id' subcommand that converts a name of.
Wed, Jul 12, 9:42 AM
arphaman created D35306: [diagtool] Add the 'find-diagnostic-id' subcommand that converts a name of the diagnostic to its enum value.
Wed, Jul 12, 7:51 AM
arphaman added a comment to D35175: New option that adds the DiagID enum name and index to Diagnostic output..

I was impatient, so I already started on a patch for diagtool. I'll post it soon.

Wed, Jul 12, 7:26 AM
arphaman added a comment to D34949: [refactor][rename] Use a single base class for class that finds a declaration at location and for class that searches for all occurrences of a specific declaration.

Ping.

Wed, Jul 12, 7:05 AM
arphaman added a comment to D35175: New option that adds the DiagID enum name and index to Diagnostic output..

Right. I was aware of the diagtool before, but didn't really look into what it did. TIL! It would make sense to add this kind of mapping functionality to that tool then.

Wed, Jul 12, 6:59 AM
arphaman added a comment to D35175: New option that adds the DiagID enum name and index to Diagnostic output..

My script relies on a hack to map the name of the diagnostic to the enum value. We need to come up with a better to map the diagnostic name to the enum value. I propose a new utility tool that would take the name of the diagnostic and map it back to the enum value.

Wed, Jul 12, 6:32 AM
arphaman added a comment to D35187: [libclang] Support for querying whether an enum is scoped.

Committed r307771 with correct attribution.

Wed, Jul 12, 4:36 AM · Restricted Project
arphaman committed rL307771: [libclang] Support for querying whether an enum is scoped.
[libclang] Support for querying whether an enum is scoped
Wed, Jul 12, 4:35 AM
arphaman committed rL307770: Revert r307769 (Forgot to mention the name of the contributor)..
Revert r307769 (Forgot to mention the name of the contributor).
Wed, Jul 12, 4:34 AM
arphaman committed rL307769: [libclang] Support for querying whether an enum is scoped.
[libclang] Support for querying whether an enum is scoped
Wed, Jul 12, 4:32 AM
arphaman closed D35187: [libclang] Support for querying whether an enum is scoped by committing rL307769: [libclang] Support for querying whether an enum is scoped.
Wed, Jul 12, 4:32 AM · Restricted Project
arphaman added a comment to D35187: [libclang] Support for querying whether an enum is scoped.

Sure, I'll commit it today.

Wed, Jul 12, 4:14 AM · Restricted Project

Tue, Jul 11

arphaman accepted D35187: [libclang] Support for querying whether an enum is scoped.

LGTM. Do you have commit access or would you like me to commit it on your behalf?

Tue, Jul 11, 10:47 AM · Restricted Project
arphaman updated the summary of D35268: [ObjC] Ambiguous property synthesis should pick the 'readwrite' property and check for incompatible attributes.
Tue, Jul 11, 10:33 AM
arphaman created D35268: [ObjC] Ambiguous property synthesis should pick the 'readwrite' property and check for incompatible attributes.
Tue, Jul 11, 10:32 AM
arphaman added a comment to D35175: New option that adds the DiagID enum name and index to Diagnostic output..

Currently looks like around 200k (4534 @ 33 byte avg length + ptr). If this is too much, we could make it conditional based on NDEBUG or some other macro at compile time.

Tue, Jul 11, 4:17 AM
arphaman committed rL307642: [ObjC] Check that a subscript methods is declared for a qualified id type.
[ObjC] Check that a subscript methods is declared for a qualified id type
Tue, Jul 11, 3:19 AM
arphaman committed rL307638: RecursiveASTVisitor should visit the nested name qualifiers in.
RecursiveASTVisitor should visit the nested name qualifiers in
Tue, Jul 11, 2:39 AM
arphaman closed D34981: RecursiveASTVisitor should visit the nested name qualifiers in a template specialisation by committing rL307638: RecursiveASTVisitor should visit the nested name qualifiers in.
Tue, Jul 11, 2:39 AM

Mon, Jul 10

arphaman committed rL307388: Recommit [driver][macOS] Pick the system version for the.
Recommit [driver][macOS] Pick the system version for the
Mon, Jul 10, 9:42 AM
arphaman added a comment to D35187: [libclang] Support for querying whether an enum is scoped.

Thanks for the patch.
I have just one minor comment:

Mon, Jul 10, 3:14 AM · Restricted Project
arphaman added a comment to D35175: New option that adds the DiagID enum name and index to Diagnostic output..

Thanks, that's pretty cool!

Mon, Jul 10, 2:50 AM

Fri, Jul 7

arphaman updated subscribers of D34748: [clang-diff] improve mapping accuracy, HTML side-by-side diff..
Fri, Jul 7, 4:49 AM
arphaman added a comment to D34748: [clang-diff] improve mapping accuracy, HTML side-by-side diff..

Can you provide a test that demonstrates what this change fixed/improved?

Fri, Jul 7, 4:46 AM
arphaman committed rL307384: [Frontend] Verify that the bitstream is not empty before reading.
[Frontend] Verify that the bitstream is not empty before reading
Fri, Jul 7, 3:25 AM
arphaman closed D35069: [Frontend] Verify that the bitstream is not empty before reading the serialised diagnostics by committing rL307384: [Frontend] Verify that the bitstream is not empty before reading.
Fri, Jul 7, 3:25 AM
arphaman committed rL307377: Update the Windows version of updateTripleOSVersion to account for.
Update the Windows version of updateTripleOSVersion to account for
Fri, Jul 7, 3:09 AM
arphaman committed rL307372: [Support] sys::getProcessTriple should return a macOS triple using.
[Support] sys::getProcessTriple should return a macOS triple using
Fri, Jul 7, 2:54 AM
arphaman closed D34446: [Support] sys::getProcessTriple should return a macOS triple using the system's version of macOS by committing rL307372: [Support] sys::getProcessTriple should return a macOS triple using.
Fri, Jul 7, 2:54 AM
arphaman committed rL307368: [ObjC] Avoid the -Wunguarded-availability warnings for protocol.
[ObjC] Avoid the -Wunguarded-availability warnings for protocol
Fri, Jul 7, 2:16 AM
arphaman closed D35061: [ObjC] Avoid the -Wunguarded-availability warnings for protocol requirements in protocol/class/category declarations by committing rL307368: [ObjC] Avoid the -Wunguarded-availability warnings for protocol.
Fri, Jul 7, 2:16 AM

Thu, Jul 6

arphaman added inline comments to D35061: [ObjC] Avoid the -Wunguarded-availability warnings for protocol requirements in protocol/class/category declarations.
Thu, Jul 6, 10:20 AM
arphaman created D35069: [Frontend] Verify that the bitstream is not empty before reading the serialised diagnostics.
Thu, Jul 6, 10:14 AM
arphaman added a comment to D34446: [Support] sys::getProcessTriple should return a macOS triple using the system's version of macOS.

Ping.

Thu, Jul 6, 9:59 AM
arphaman added inline comments to D35061: [ObjC] Avoid the -Wunguarded-availability warnings for protocol requirements in protocol/class/category declarations.
Thu, Jul 6, 9:49 AM
arphaman created D35061: [ObjC] Avoid the -Wunguarded-availability warnings for protocol requirements in protocol/class/category declarations.
Thu, Jul 6, 8:51 AM
arphaman added inline comments to D34512: Add preliminary Cross Translation Unit support library.
Thu, Jul 6, 5:57 AM

Wed, Jul 5

arphaman added a comment to D34992: Emit static constexpr member as available_externally definition.

Does this apply to all constexpr global variables? It could potentially fix https://bugs.llvm.org/show_bug.cgi?id=31860 .

Wed, Jul 5, 8:28 AM
arphaman updated the diff for D35012: [refactor] Add the AST source selection component.

A a test-case for implicit declarations.

Wed, Jul 5, 7:25 AM
arphaman created D35012: [refactor] Add the AST source selection component.
Wed, Jul 5, 6:56 AM

Tue, Jul 4

arphaman created D34981: RecursiveASTVisitor should visit the nested name qualifiers in a template specialisation.
Tue, Jul 4, 6:55 AM
arphaman committed rL307074: [index] Index nested name qualifiers in a forward declaration of a.
[index] Index nested name qualifiers in a forward declaration of a
Tue, Jul 4, 5:51 AM
arphaman accepted D34329: [clang-diff] Initial implementation..

LGTM. You can request commit access at http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access.

Tue, Jul 4, 5:47 AM
arphaman added inline comments to D34329: [clang-diff] Initial implementation..
Tue, Jul 4, 3:30 AM
arphaman added inline comments to D34329: [clang-diff] Initial implementation..
Tue, Jul 4, 3:29 AM
arphaman added inline comments to D34329: [clang-diff] Initial implementation..
Tue, Jul 4, 3:19 AM

Mon, Jul 3

arphaman added a comment to D34329: [clang-diff] Initial implementation..

@johannes
Are you planning to work on integration with the StmtDataCollector in this patch or would you prefer to follow-up with additional patches?

Mon, Jul 3, 9:27 AM
arphaman updated the diff for D34949: [refactor][rename] Use a single base class for class that finds a declaration at location and for class that searches for all occurrences of a specific declaration.

Small fixup.

Mon, Jul 3, 8:31 AM
arphaman added a comment to D34949: [refactor][rename] Use a single base class for class that finds a declaration at location and for class that searches for all occurrences of a specific declaration.

This is meant to be NFC btw.

Mon, Jul 3, 8:28 AM
arphaman created D34949: [refactor][rename] Use a single base class for class that finds a declaration at location and for class that searches for all occurrences of a specific declaration.
Mon, Jul 3, 8:18 AM
arphaman committed rL307014: Add a fixit for -Wobjc-protocol-property-synthesis.
Add a fixit for -Wobjc-protocol-property-synthesis
Mon, Jul 3, 7:37 AM
arphaman committed rL307016: [index] Remove 'implicit' role for message sends in implicit ObjC.
[index] Remove 'implicit' role for message sends in implicit ObjC
Mon, Jul 3, 7:37 AM
arphaman closed D34886: Add a fixit for -Wobjc-protocol-property-synthesis by committing rL307014: Add a fixit for -Wobjc-protocol-property-synthesis.
Mon, Jul 3, 7:37 AM
arphaman added inline comments to D34886: Add a fixit for -Wobjc-protocol-property-synthesis.
Mon, Jul 3, 7:33 AM