arphaman (Alex Lorenz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2014, 4:17 PM (152 w, 3 d)

Recent Activity

Wed, May 24

arphaman committed rL303761: Warn about uses of `@available` that can't suppress the.
Warn about uses of `@available` that can't suppress the
Wed, May 24, 8:16 AM
arphaman closed D33450: Warn about uses of `@available` that can't suppress the -Wunguarded-availability warnings by committing rL303761: Warn about uses of `@available` that can't suppress the.
Wed, May 24, 8:16 AM
arphaman committed rL303751: [index] The references to explicit class properties should be recorded.
[index] The references to explicit class properties should be recorded
Wed, May 24, 7:24 AM
arphaman added a comment to D33493: Speed up preamble loading, reduce global completion cache calls.

Please post the patch with full context git diff -U9999.

Wed, May 24, 6:18 AM

Tue, May 23

arphaman created D33450: Warn about uses of `@available` that can't suppress the -Wunguarded-availability warnings.
Tue, May 23, 10:34 AM
arphaman committed rL303651: [index] The references to enum constants from member enums that are.
[index] The references to enum constants from member enums that are
Tue, May 23, 9:47 AM
arphaman committed rL303650: [index] The references to member enums from template instantiations should.
[index] The references to member enums from template instantiations should
Tue, May 23, 9:36 AM
arphaman committed rL303648: [index] The references to type aliases and typedefs from template.
[index] The references to type aliases and typedefs from template
Tue, May 23, 9:27 AM
arphaman committed rL303647: [index] The references to fields from nested records in template instantiations.
[index] The references to fields from nested records in template instantiations
Tue, May 23, 9:25 AM
arphaman committed rL303646: [index] The references to records from template instantiations should refer.
[index] The references to records from template instantiations should refer
Tue, May 23, 9:23 AM
arphaman updated the diff for D33357: Avoid calling report_fatal_error in the destructor of raw_fd_ostream when saving a module timestamp file.

Remove the first redundant error check.

Tue, May 23, 6:50 AM
arphaman added a comment to D33357: Avoid calling report_fatal_error in the destructor of raw_fd_ostream when saving a module timestamp file.

Any idea why we're hitting this issue in the first place? The error that gets cleaned up is reported at some point before? Seems to me that we're going to fail to update the timestamp but continue as nothing happened, I wonder how many other issues this might trigger...

Tue, May 23, 6:50 AM

Mon, May 22

arphaman committed rL303568: [index] Index the default template parameter values.
[index] Index the default template parameter values
Mon, May 22, 9:51 AM
arphaman committed rL303563: [index] Index the deleted functions.
[index] Index the deleted functions
Mon, May 22, 8:42 AM
arphaman committed rL303559: [index] Visit the default argument values in function definitions.
[index] Visit the default argument values in function definitions
Mon, May 22, 8:17 AM
arphaman committed rL303555: [index] 'using namespace' declarations in functions should record.
[index] 'using namespace' declarations in functions should record
Mon, May 22, 7:39 AM
arphaman accepted D33250: [Sema][ObjC] Fix a bug where -Wunguarded-availability was emitted at the wrong location.

LGTM with one change below:

Mon, May 22, 6:57 AM
arphaman added a comment to D32178: Delete unstable integration tests.

Ok, I will commit them sometime this week then.

Mon, May 22, 2:34 AM

Fri, May 19

arphaman created D33357: Avoid calling report_fatal_error in the destructor of raw_fd_ostream when saving a module timestamp file.
Fri, May 19, 7:54 AM
arphaman added a comment to D32178: Delete unstable integration tests.

While I do agree that these tests would be better off in another place, we currently don't have the bandwidth to facilitate that move.

Fri, May 19, 4:17 AM
arphaman added a comment to D32178: Delete unstable integration tests.

I've managed to put together a solution that adds REQUIRES to the tests that ensure they only work with the latest SDK (10.12).

Fri, May 19, 4:15 AM

Thu, May 18

arphaman committed rL303366: [index] Avoid one more crash caused by infinite recursion that happens when.
[index] Avoid one more crash caused by infinite recursion that happens when
Thu, May 18, 11:19 AM
arphaman closed D33324: [index] Avoid infinite recursion when looking up a dependent name by committing rL303366: [index] Avoid one more crash caused by infinite recursion that happens when.
Thu, May 18, 11:19 AM
arphaman created D33324: [index] Avoid infinite recursion when looking up a dependent name.
Thu, May 18, 10:13 AM
arphaman committed rL303343: [index] Record references to class receivers used in property references.
[index] Record references to class receivers used in property references
Thu, May 18, 3:56 AM

Wed, May 17

arphaman added inline comments to D33250: [Sema][ObjC] Fix a bug where -Wunguarded-availability was emitted at the wrong location.
Wed, May 17, 9:17 AM
arphaman added a comment to D33250: [Sema][ObjC] Fix a bug where -Wunguarded-availability was emitted at the wrong location.

Hmm, I don't like how we end with a location that points to x instead of InterWithProp. Can we ignore the TypeLocs with invalid location and instead look at ObjCPropertyRefExprs with a class receiver?

Wed, May 17, 9:11 AM
arphaman committed rL303246: [Lexer] Ensure that the token is not an annotation token when.
[Lexer] Ensure that the token is not an annotation token when
Wed, May 17, 4:22 AM

Tue, May 16

arphaman committed rL303192: [index] Avoid another crash that happens when looking up a dependent name.
[index] Avoid another crash that happens when looking up a dependent name
Tue, May 16, 10:46 AM
arphaman committed rL303170: [Sema] Avoid duplicate -Wunguarded-availability warnings in nested functions.
[Sema] Avoid duplicate -Wunguarded-availability warnings in nested functions
Tue, May 16, 7:12 AM
arphaman committed rL303156: Fix PR 10758: Infinite recursion when dealing with copy-initialization.
Fix PR 10758: Infinite recursion when dealing with copy-initialization
Tue, May 16, 3:37 AM
arphaman closed D25051: Fix PR 10758: Infinite recursion when dealing with copy-initialization by committing rL303156: Fix PR 10758: Infinite recursion when dealing with copy-initialization.
Tue, May 16, 3:37 AM
arphaman added a comment to D25051: Fix PR 10758: Infinite recursion when dealing with copy-initialization.

I will commit it today.

Tue, May 16, 3:17 AM

Mon, May 15

arphaman committed rL303068: [index] References to fields from template instantiations should refer to.
[index] References to fields from template instantiations should refer to
Mon, May 15, 7:39 AM
arphaman committed rL303048: [index] Visit and store information about namespace alias declarations.
[index] Visit and store information about namespace alias declarations
Mon, May 15, 4:09 AM
arphaman committed rL303046: [index] Store correct location for namespace nested name qualifiers.
[index] Store correct location for namespace nested name qualifiers
Mon, May 15, 3:54 AM
arphaman committed rL303045: [index] Avoid a crash that happens when looking up a dependent name.
[index] Avoid a crash that happens when looking up a dependent name
Mon, May 15, 3:34 AM

Fri, May 12

arphaman committed rL302918: [index] Index template specialization arguments for function templats.
[index] Index template specialization arguments for function templats
Fri, May 12, 9:45 AM
arphaman added a comment to D32178: Delete unstable integration tests.

@jroelofs
We'd be ok with tying the test to a specific SDK and maintaining that tie (e.g. bumping it upstream).
I was planning to investigate how to make the SDK version checks work, but I don't have the time ATM. Can I get back to you in a week?

Fri, May 12, 4:11 AM

Thu, May 11

arphaman committed rL302797: [CodeCompletion] Provide member completions for dependent expressions whose.
[CodeCompletion] Provide member completions for dependent expressions whose
Thu, May 11, 7:02 AM
arphaman committed rL302796: [CodeCompletion] NFC, extract a function that generates member.
[CodeCompletion] NFC, extract a function that generates member
Thu, May 11, 6:54 AM

Wed, May 10

arphaman committed rL302689: [AST] RecursiveASTVisitor should not crash on lambdas with type attributes.
[AST] RecursiveASTVisitor should not crash on lambdas with type attributes
Wed, May 10, 9:34 AM
arphaman accepted D32891: [Sema][ObjC++] Objective-C++ support for __is_base_of(B, D).

LGTM! A couple of comments below:

Wed, May 10, 7:43 AM
arphaman committed rL302632: [index] Index simple dependent declaration references.
[index] Index simple dependent declaration references
Wed, May 10, 3:01 AM
arphaman closed D32972: [index] Index simple dependent declaration references by committing rL302632: [index] Index simple dependent declaration references.
Wed, May 10, 3:00 AM

Tue, May 9

arphaman committed rL302545: [CodeCompletion] Complete platform names in @available expressions.
[CodeCompletion] Complete platform names in @available expressions
Tue, May 9, 9:18 AM
arphaman committed rL302540: Add support for pretty platform names to `@available`/.
Add support for pretty platform names to `@available`/
Tue, May 9, 8:48 AM
arphaman closed D33000: Add support for pretty platform names to `@available`/`__builtin_available` by committing rL302540: Add support for pretty platform names to `@available`/.
Tue, May 9, 8:48 AM
arphaman created D33000: Add support for pretty platform names to `@available`/`__builtin_available`.
Tue, May 9, 6:46 AM

Mon, May 8

arphaman created D32972: [index] Index simple dependent declaration references.
Mon, May 8, 10:20 AM

Fri, May 5

arphaman committed rL302253: Add a fix-it for -Wunguarded-availability.
Add a fix-it for -Wunguarded-availability
Fri, May 5, 9:56 AM
arphaman closed D32424: Add a fix-it for -Wunguarded-availability by committing rL302253: Add a fix-it for -Wunguarded-availability.
Fri, May 5, 9:55 AM
arphaman committed rL302250: [ObjC] Don't disallow vector parameters/return values in methods.
[ObjC] Don't disallow vector parameters/return values in methods
Fri, May 5, 9:28 AM
arphaman committed rL302240: [Driver] Add a "-mmacos_version_min" option that's an alias for.
[Driver] Add a "-mmacos_version_min" option that's an alias for
Fri, May 5, 8:15 AM
arphaman closed D32796: [Driver] Add a "-mmacos_version_min" option that's an alias for "-mmacosx_version_min" by committing rL302240: [Driver] Add a "-mmacos_version_min" option that's an alias for.
Fri, May 5, 8:10 AM
arphaman updated the diff for D32424: Add a fix-it for -Wunguarded-availability.
  • Simplify the RecursiveASTVisitor as suggested by Erik
  • Improve the note to include __builtin_available
Fri, May 5, 3:17 AM
arphaman added inline comments to D32424: Add a fix-it for -Wunguarded-availability.
Fri, May 5, 2:16 AM

Thu, May 4

arphaman committed rL302151: DiagnosticsEngine should clear DelayedDiagID before reporting the.
DiagnosticsEngine should clear DelayedDiagID before reporting the
Thu, May 4, 7:10 AM
arphaman committed rL302136: [Index] The relation between the declarations in template.
[Index] The relation between the declarations in template
Thu, May 4, 3:55 AM

Wed, May 3

arphaman committed rL302046: Revert r302037.
Revert r302037
Wed, May 3, 9:35 AM
arphaman committed rL302037: DiagnosticsEngine should clear DelayedDiagID before reporting the.
DiagnosticsEngine should clear DelayedDiagID before reporting the
Wed, May 3, 8:54 AM
arphaman created D32796: [Driver] Add a "-mmacos_version_min" option that's an alias for "-mmacosx_version_min".
Wed, May 3, 4:33 AM
arphaman committed rL302011: [Triple] Add a "macos" OS type that acts as a synonym for "macosx".
[Triple] Add a "macos" OS type that acts as a synonym for "macosx"
Wed, May 3, 3:55 AM
arphaman closed D32748: [Triple] Add a "macos" OS type that acts as a synonym for "macosx" by committing rL302011: [Triple] Add a "macos" OS type that acts as a synonym for "macosx".
Wed, May 3, 3:55 AM

Tue, May 2

arphaman created D32748: [Triple] Add a "macos" OS type that acts as a synonym for "macosx".
Tue, May 2, 7:14 AM

Fri, Apr 28

arphaman committed rL301647: Use the -Wunknown-warning-option group for the "unknown warning group".
Use the -Wunknown-warning-option group for the "unknown warning group"
Fri, Apr 28, 7:58 AM
arphaman accepted D32389: [libclang] Expose some target information via the C API..

Thanks, LGTM

Fri, Apr 28, 7:49 AM · Restricted Project
arphaman added a comment to D29768: [TargetInfo] Set 'UseSignedCharForObjCBool' to false by default.

Ping.

Fri, Apr 28, 7:18 AM
arphaman committed rL301643: [Sema] Avoid an invalid redefinition error that was presented for.
[Sema] Avoid an invalid redefinition error that was presented for
Fri, Apr 28, 5:43 AM
arphaman closed D25113: [Sema] Don't display an invalid redefinition error when dealing with a redefinition of a function whose previous definition was typo-corrected by committing rL301643: [Sema] Avoid an invalid redefinition error that was presented for.
Fri, Apr 28, 5:43 AM
arphaman committed rL301635: [index] Handle vector types in USR generator.
[index] Handle vector types in USR generator
Fri, Apr 28, 2:59 AM

Apr 27 2017

arphaman committed rL301542: [libclang] Pass in the -fallow-editor-placeholders option.
[libclang] Pass in the -fallow-editor-placeholders option
Apr 27 2017, 7:00 AM
arphaman committed rL301532: [ObjC] Disallow vector parameters and return values in Objective-C methods.
[ObjC] Disallow vector parameters and return values in Objective-C methods
Apr 27 2017, 3:57 AM
arphaman closed D28670: [ObjC] Disallow vector parameters and return values in Objective-C methods on older X86 targets by committing rL301532: [ObjC] Disallow vector parameters and return values in Objective-C methods.
Apr 27 2017, 3:56 AM

Apr 26 2017

arphaman committed rL301409: -Wunguarded-availability should support if (@available) checks in top-level.
-Wunguarded-availability should support if (@available) checks in top-level
Apr 26 2017, 7:33 AM
arphaman committed rL301402: -Wdocumentation should not check the @returns command for Objective-C.
-Wdocumentation should not check the @returns command for Objective-C
Apr 26 2017, 6:22 AM
arphaman committed rL301400: [AST] Look through attribute type locs when searching for function type.
[AST] Look through attribute type locs when searching for function type
Apr 26 2017, 5:59 AM
arphaman added a comment to D32389: [libclang] Expose some target information via the C API..

It looks good, I have a couple of comments:

Apr 26 2017, 4:11 AM · Restricted Project

Apr 25 2017

arphaman added a comment to D28670: [ObjC] Disallow vector parameters and return values in Objective-C methods on older X86 targets.

Ping.

Apr 25 2017, 10:25 AM
arphaman added a comment to D32348: [libclang] Check for a record declaration before a template specialization..

@emilio, you can request to merge this into 4.0.1 by using a script called merge-request.sh (http://lists.llvm.org/pipermail/llvm-dev/2017-March/111530.html).

Apr 25 2017, 10:23 AM · Restricted Project
arphaman committed rL301328: [libclang] Check for a record declaration before a template specialization.
[libclang] Check for a record declaration before a template specialization
Apr 25 2017, 10:12 AM
arphaman closed D32348: [libclang] Check for a record declaration before a template specialization. by committing rL301328: [libclang] Check for a record declaration before a template specialization.
Apr 25 2017, 10:12 AM · Restricted Project
arphaman added a comment to D32348: [libclang] Check for a record declaration before a template specialization..

Sure. You can ask Chris Lattner for commit access for future patches :)

Apr 25 2017, 10:09 AM · Restricted Project
arphaman committed rL301315: [index] Index type source info for class specializations.
[index] Index type source info for class specializations
Apr 25 2017, 8:26 AM
arphaman committed rL301310: [index] Record the 'SpecializationOf' relation for function specializations.
[index] Record the 'SpecializationOf' relation for function specializations
Apr 25 2017, 7:35 AM
arphaman updated the diff for D32424: Add a fix-it for -Wunguarded-availability.

Now the patch takes the following situations into account:

  • Enclose only the statement in a case.
  • If the fixit has to enclose a declaration statement, then the fixit will try to enclose the appropriate uses as well.
Apr 25 2017, 5:58 AM

Apr 24 2017

arphaman committed rL301180: [index] The relation between the declarations in template specializations.
[index] The relation between the declarations in template specializations
Apr 24 2017, 7:18 AM
arphaman closed D32020: [indexer] The relationship between the declarations in template specializations that 'override' declarations in the base template should be recorded by committing rL301180: [index] The relation between the declarations in template specializations.
Apr 24 2017, 7:18 AM
arphaman added a comment to D32389: [libclang] Expose some target information via the C API..

Maybe it would be better to introduce a CXTargetInfo type, and change the API to be:

clang_getTranslationUnitTargetInfo
clang_TargetInfo_getTriple
clang_TargetInfo_getPointerWidth

?
This way the TargetInfo functions will be cleanly separated, so we can extend the API easier in the future.

Apr 24 2017, 6:23 AM · Restricted Project
arphaman accepted D32348: [libclang] Check for a record declaration before a template specialization..

I see, thanks for explaining. LGTM. Do you need someone to commit it?

Apr 24 2017, 6:15 AM · Restricted Project
arphaman created D32424: Add a fix-it for -Wunguarded-availability.
Apr 24 2017, 3:13 AM

Apr 21 2017

arphaman added inline comments to D32348: [libclang] Check for a record declaration before a template specialization..
Apr 21 2017, 9:14 AM · Restricted Project
arphaman committed rL300981: [PR32667] -Wdocumentation should allow @param/@returns for fields/variables.
[PR32667] -Wdocumentation should allow @param/@returns for fields/variables
Apr 21 2017, 7:30 AM
arphaman added a comment to D32348: [libclang] Check for a record declaration before a template specialization..

Please post the diff with full context (git diff -U9999).

Apr 21 2017, 6:22 AM · Restricted Project
arphaman updated the diff for D25113: [Sema] Don't display an invalid redefinition error when dealing with a redefinition of a function whose previous definition was typo-corrected .

Rebased the patch.

Apr 21 2017, 4:24 AM
arphaman updated the diff for D25051: Fix PR 10758: Infinite recursion when dealing with copy-initialization.

Rebased the patch.

Apr 21 2017, 4:07 AM

Apr 20 2017

arphaman updated the diff for D32020: [indexer] The relationship between the declarations in template specializations that 'override' declarations in the base template should be recorded.

Updated the relationship to be 'overrideOf | specializationOf' to differentiate it from regular 'overrideOf'.

Apr 20 2017, 5:41 AM
arphaman committed rL300832: [index] Record class template specializations using a new 'SpecializationOf'.
[index] Record class template specializations using a new 'SpecializationOf'
Apr 20 2017, 3:56 AM
arphaman closed D32010: [indexer] Record class template specializations using a new 'SpecializationOf' relationship by committing rL300832: [index] Record class template specializations using a new 'SpecializationOf'.
Apr 20 2017, 3:56 AM
arphaman committed rL300826: Add #pragma clang attribute support to the availability attribute.
Add #pragma clang attribute support to the availability attribute
Apr 20 2017, 2:47 AM