Page MenuHomePhabricator

arphaman (Alex Lorenz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2014, 4:17 PM (255 w, 5 d)

Recent Activity

Yesterday

arphaman updated the diff for D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation.

Remove some outdated commented out code.

Mon, May 20, 4:54 PM · Restricted Project
arphaman added inline comments to D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation.
Mon, May 20, 4:00 PM · Restricted Project
arphaman updated the diff for D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation.
  • Added diagnostic support.
  • Fixed the issue with C++14 number separators.
  • Other fixes requested by @Bigcheese .
Mon, May 20, 4:00 PM · Restricted Project

Thu, May 9

arphaman created D61758: [driver][xray] fix the macOS support checker by supporting -macos triple in addition to -darwin.
Thu, May 9, 1:50 PM · Restricted Project
arphaman committed rGdee161fb3848: NFC, make XFAIL work on macOS correctly for test/Driver/XRay/xray-instrument-os. (authored by arphaman).
NFC, make XFAIL work on macOS correctly for test/Driver/XRay/xray-instrument-os.
Thu, May 9, 1:35 PM
arphaman committed rC360374: NFC, make XFAIL work on macOS correctly for test/Driver/XRay/xray-instrument-os..
NFC, make XFAIL work on macOS correctly for test/Driver/XRay/xray-instrument-os.
Thu, May 9, 1:35 PM
arphaman committed rL360374: NFC, make XFAIL work on macOS correctly for test/Driver/XRay/xray-instrument-os..
NFC, make XFAIL work on macOS correctly for test/Driver/XRay/xray-instrument-os.
Thu, May 9, 1:35 PM

Wed, May 8

arphaman committed rGa438a898b02a: lit config: disable LSan for Apple clang compiler in addition to Apple LLVM (authored by arphaman).
lit config: disable LSan for Apple clang compiler in addition to Apple LLVM
Wed, May 8, 7:45 PM
arphaman committed rL360307: lit config: disable LSan for Apple clang compiler in addition to Apple LLVM.
lit config: disable LSan for Apple clang compiler in addition to Apple LLVM
Wed, May 8, 7:45 PM

Fri, Apr 26

arphaman committed rG353f593976d8: [clang][driver] Weaken the test from 359353 to appease Windows bots (authored by arphaman).
[clang][driver] Weaken the test from 359353 to appease Windows bots
Fri, Apr 26, 3:57 PM
arphaman committed rC359356: [clang][driver] Weaken the test from 359353 to appease Windows bots.
[clang][driver] Weaken the test from 359353 to appease Windows bots
Fri, Apr 26, 3:56 PM
arphaman committed rL359356: [clang][driver] Weaken the test from 359353 to appease Windows bots.
[clang][driver] Weaken the test from 359353 to appease Windows bots
Fri, Apr 26, 3:56 PM
arphaman committed rG3bf116c1a4f8: [driver][macOS] Link libarclite from the default toolchain when clang is… (authored by arphaman).
[driver][macOS] Link libarclite from the default toolchain when clang is…
Fri, Apr 26, 3:41 PM
arphaman committed rL359353: [driver][macOS] Link libarclite from the default toolchain when clang.
[driver][macOS] Link libarclite from the default toolchain when clang
Fri, Apr 26, 3:41 PM
arphaman committed rC359353: [driver][macOS] Link libarclite from the default toolchain when clang.
[driver][macOS] Link libarclite from the default toolchain when clang
Fri, Apr 26, 3:40 PM

Apr 16 2019

arphaman accepted D60786: [FileSystemStatCache] Update test for new FileSystemStatCache API.

LG

Apr 16 2019, 10:57 AM · Restricted Project
arphaman accepted D60735: [FileSystemStatCache] Return std::error_code from stat cache methods.

LGTM, please mark it as NFC

Apr 16 2019, 10:12 AM · Restricted Project

Apr 15 2019

arphaman added a comment to D60376: [llvm-objdump] Align instructions to a tab stop in disassembly output.

Reverted in r358459

Apr 15 2019, 3:35 PM · Restricted Project
arphaman committed rGd9d0c3e13823: Revert r358405: "[llvm-objdump] Align instructions to a tab stop in disassembly… (authored by arphaman).
Revert r358405: "[llvm-objdump] Align instructions to a tab stop in disassembly…
Apr 15 2019, 3:35 PM
arphaman committed rL358459: Revert r358405: "[llvm-objdump] Align instructions to a tab stop in disassembly….
Revert r358405: "[llvm-objdump] Align instructions to a tab stop in disassembly…
Apr 15 2019, 3:34 PM
arphaman committed rG16256123d006: Revert r358418: "[llvm-objdump] Simplify PrintHelpMessage() logic" (authored by arphaman).
Revert r358418: "[llvm-objdump] Simplify PrintHelpMessage() logic"
Apr 15 2019, 1:15 PM
arphaman committed rL358443: Revert r358418: "[llvm-objdump] Simplify PrintHelpMessage() logic".
Revert r358418: "[llvm-objdump] Simplify PrintHelpMessage() logic"
Apr 15 2019, 1:14 PM

Apr 9 2019

arphaman added inline comments to D60432: [clang][ASTContext] Simplify caching for declaration-related comments.
Apr 9 2019, 8:17 AM · Restricted Project
arphaman updated the diff for D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation.

Updated to the new LLVM license comments.

Apr 9 2019, 8:03 AM · Restricted Project

Apr 4 2019

arphaman committed rG5d289ed3fee3: [test] Specify an explicit darwin version in a triple in `test/Driver/debug… (authored by arphaman).
[test] Specify an explicit darwin version in a triple in `test/Driver/debug…
Apr 4 2019, 6:47 PM
arphaman committed rC357740: [test] Specify an explicit darwin version in a triple in.
[test] Specify an explicit darwin version in a triple in
Apr 4 2019, 6:46 PM
arphaman committed rL357740: [test] Specify an explicit darwin version in a triple in.
[test] Specify an explicit darwin version in a triple in
Apr 4 2019, 6:46 PM

Apr 3 2019

arphaman added a comment to D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation.

@Bigcheese Initial tool posted to https://reviews.llvm.org/D60233 .

Apr 3 2019, 2:51 PM · Restricted Project
arphaman created D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database.
Apr 3 2019, 2:51 PM · Restricted Project

Apr 2 2019

arphaman accepted D56924: Special case ObjCPropertyDecl for printing.
Apr 2 2019, 6:15 PM · Restricted Project
arphaman added a comment to D56924: Special case ObjCPropertyDecl for printing.

Sorry, I missed the pings. It LGTM.

Apr 2 2019, 6:15 PM · Restricted Project

Apr 1 2019

arphaman added a comment to D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation.

@Bigcheese Please take a look. I'll post the basic tool that runs the preprocessor on regular vs minimized sources by Wed.

Apr 1 2019, 6:07 PM · Restricted Project
arphaman updated the diff for D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation.

Rebased patch, added a #warning/error fix from @dexonsmith.

Apr 1 2019, 6:06 PM · Restricted Project

Mar 25 2019

arphaman accepted D59808: [clangd][xpc][cmake] Respect explicit value of CLANGD_BUILD_XPC.

LG, Thanks

Mar 25 2019, 8:33 PM · Restricted Project

Mar 20 2019

arphaman committed rG0b4364847dcd: Fix implicit ios -> watchOS availability version mapping for versions that have… (authored by arphaman).
Fix implicit ios -> watchOS availability version mapping for versions that have…
Mar 20 2019, 1:03 PM
arphaman committed rC356605: Fix implicit ios -> watchOS availability version mapping for.
Fix implicit ios -> watchOS availability version mapping for
Mar 20 2019, 1:03 PM
arphaman committed rL356605: Fix implicit ios -> watchOS availability version mapping for.
Fix implicit ios -> watchOS availability version mapping for
Mar 20 2019, 1:03 PM

Feb 22 2019

arphaman added a comment to D58559: emit '(assertions enabled)' in the version string for a build of clang with assertions enabled.

I like this. Can you start a discussion on cfe-dev (if you haven't already)? This is user-visible so I want to be sure other vendors are happy with this; if not, we can hide it behind a CMake flag.

Feb 22 2019, 6:47 PM · Restricted Project
arphaman updated the diff for D58559: emit '(assertions enabled)' in the version string for a build of clang with assertions enabled.

Use "(+asserts)" as suggested.

Feb 22 2019, 6:42 PM · Restricted Project
arphaman added a comment to D56924: Special case ObjCPropertyDecl for printing.

Please add a test that covers the '(class extension)' output as well.

Feb 22 2019, 6:42 PM · Restricted Project
arphaman created D58559: emit '(assertions enabled)' in the version string for a build of clang with assertions enabled.
Feb 22 2019, 4:05 PM · Restricted Project

Feb 14 2019

arphaman accepted D58213: [FileManager] fillRealPathName even if we aren't opening the file.

LGTM

Feb 14 2019, 1:24 PM · Restricted Project
arphaman added inline comments to D58213: [FileManager] fillRealPathName even if we aren't opening the file.
Feb 14 2019, 12:58 PM · Restricted Project
arphaman added inline comments to D58213: [FileManager] fillRealPathName even if we aren't opening the file.
Feb 14 2019, 12:56 PM · Restricted Project
arphaman added inline comments to D58213: [FileManager] fillRealPathName even if we aren't opening the file.
Feb 14 2019, 12:41 PM · Restricted Project

Feb 8 2019

arphaman accepted D57532: [Index] Make sure c-index-test finds libc++ on Mac.

LGTM.

Feb 8 2019, 7:03 PM · Restricted Project

Feb 4 2019

arphaman accepted D57712: [SemaObjC] Don't infer the availabilty of messages to +new from -init if the receiver has Class type.

LGTM, Thanks!

Feb 4 2019, 1:59 PM · Restricted Project

Feb 1 2019

arphaman added a comment to D57532: [Index] Make sure c-index-test finds libc++ on Mac.

@arphaman, thanks for pointing this out. It's definitely nice to change stuff only in one place.
There are two issues still pending:

  • index-file.cu still fails, I haven't looked into it closely yet, any idea why that might be happening?; repro is simple, just patch this in locally and run the test.
Feb 1 2019, 11:05 AM · Restricted Project

Jan 31 2019

arphaman requested changes to D57532: [Index] Make sure c-index-test finds libc++ on Mac.

The real problem is that clang_parseTranslationUnit2 is broken, so this just fixes one client, c-index-test. All other macOS clients that call that function will still be unable to find the libc++ headers.

Jan 31 2019, 1:42 PM · Restricted Project
arphaman accepted D57345: Make clang/test/Index/pch-from-libclang.c pass in more places.

LGTM

Jan 31 2019, 1:30 PM · Restricted Project
arphaman requested changes to D56924: Special case ObjCPropertyDecl for printing.

Do you know if this have an effect on the output of completion results or other tooling-based output?

Jan 31 2019, 1:06 PM · Restricted Project
arphaman added a comment to D57345: Make clang/test/Index/pch-from-libclang.c pass in more places.

Yes, that should work.

Jan 31 2019, 12:39 PM · Restricted Project
arphaman requested changes to D57345: Make clang/test/Index/pch-from-libclang.c pass in more places.
Jan 31 2019, 10:30 AM · Restricted Project
arphaman accepted D57345: Make clang/test/Index/pch-from-libclang.c pass in more places.

Makes sense. The comments aren't really enforceable though, can we just factor this out into one function in lib/Basic that can be shared between all sites? It seems like there's nothing that would prevent that.

Jan 31 2019, 10:29 AM · Restricted Project

Jan 30 2019

arphaman added a comment to D52339: Support enums with a fixed underlying type in all language modes.

We could introduce a new extension flag like c_fixed_enum that can be set for all language modes. objc_fixed_enum should apply to ObjC only.

Jan 30 2019, 11:24 AM
arphaman added a comment to D52339: Support enums with a fixed underlying type in all language modes.

@erik.pilkington the change to make objc_fixed_enum true in non-ObjC mode turned out to be problematic for our adoption. Could you please fix it before LLVM8 is wrapped up so that we don't ship this extension as on by default for all language modes?

Jan 30 2019, 11:18 AM
arphaman added a comment to D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend.
In D55673#1377404, @tra wrote:

Would that be OK to use target_sdk_version to pass *CUDA* SDK version to the CC1 compilations?
I have upcoming changes that need to know the version to generate correct glue IR for CUDA. The driver currently figures out detected CUDA version in lib/Driver/ToolChains/Cuda.cpp and I could use -target-sdk-version to pass it on to CC1 instances.

On one hand CUDA is a target SDK and the option appears to be accessible exactly where I need it. On the other hand, my use case is not *exactly* the case -target-sdk-version was intended for (i.e. it's not darwin and it has nothing to do with module metadata, though it *may* be eventually useful there even for CUDA).

If using the option for CUDA sounds like too much of a hack, I guess I can add a separate -cuda-sdk-version=, though it would effectively replicate some of this patch.

Opinions?

Jan 30 2019, 10:49 AM

Jan 24 2019

arphaman committed rL352125: [clang-format] square parens with one token are not Objective-C message sends.
[clang-format] square parens with one token are not Objective-C message sends
Jan 24 2019, 3:10 PM
arphaman committed rC352125: [clang-format] square parens with one token are not Objective-C message sends.
[clang-format] square parens with one token are not Objective-C message sends
Jan 24 2019, 3:09 PM
arphaman closed D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends.
Jan 24 2019, 3:09 PM
arphaman updated the diff for D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends.

Update for Ben's comments.

Jan 24 2019, 12:47 PM
arphaman committed rC352084: Add a priority field to availability attributes to prioritize explicit.
Add a priority field to availability attributes to prioritize explicit
Jan 24 2019, 11:15 AM
arphaman committed rL352084: Add a priority field to availability attributes to prioritize explicit.
Add a priority field to availability attributes to prioritize explicit
Jan 24 2019, 11:15 AM
arphaman closed D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'.
Jan 24 2019, 11:15 AM

Jan 18 2019

arphaman added a comment to D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'.

I think the documentation for the attribute should be updated to explain this new behavior, otherwise this will be a very inexplicable feature to users.

Jan 18 2019, 2:27 PM
arphaman updated the diff for D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'.
  • Add documentation and expand a comment as suggested by Aaron.
  • Address Erik's comments.
Jan 18 2019, 2:24 PM

Jan 17 2019

arphaman updated the diff for D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'.

Reverse the priority numbering direction as suggested by @dexonsmith .

Jan 17 2019, 6:48 PM
arphaman created D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'.
Jan 17 2019, 6:40 PM
arphaman committed rL351459: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are.
[ObjC] Follow-up r350768 and allow the use of unavailable methods that are
Jan 17 2019, 10:16 AM
arphaman committed rC351459: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are.
[ObjC] Follow-up r350768 and allow the use of unavailable methods that are
Jan 17 2019, 10:16 AM
arphaman closed D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context.
Jan 17 2019, 10:16 AM

Jan 16 2019

arphaman updated the diff for D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context.

Follow Erik's suggestion and don't check for definition/declaration in parent class.

Jan 16 2019, 4:58 PM
arphaman created D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context.
Jan 16 2019, 3:16 PM
arphaman accepted D56766: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction..

That LGTM.

Jan 16 2019, 2:35 PM

Jan 15 2019

arphaman accepted D54428: [clangd] XPC transport layer, framework, test-client.

LGTM

Jan 15 2019, 11:20 AM

Jan 14 2019

arphaman accepted D56523: Improve a -Wunguarded-availability note.

LGTM

Jan 14 2019, 11:00 AM

Jan 11 2019

arphaman accepted D56608: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO.

LGTM

Jan 11 2019, 11:29 AM
arphaman added inline comments to D56608: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO.
Jan 11 2019, 10:57 AM

Jan 9 2019

arphaman committed rL350768: [ObjC] Allow the use of implemented unavailable methods from within.
[ObjC] Allow the use of implemented unavailable methods from within
Jan 9 2019, 2:35 PM
arphaman committed rC350768: [ObjC] Allow the use of implemented unavailable methods from within.
[ObjC] Allow the use of implemented unavailable methods from within
Jan 9 2019, 2:35 PM
arphaman closed D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context .
Jan 9 2019, 2:35 PM
arphaman updated the diff for D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context .

Address review comments.

Jan 9 2019, 12:24 PM
arphaman added inline comments to D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context .
Jan 9 2019, 11:00 AM

Jan 8 2019

arphaman created D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context .
Jan 8 2019, 6:08 PM
arphaman committed rC350680: [libclang] Fix the mismatched delete operator for ExprEvalResult.
[libclang] Fix the mismatched delete operator for ExprEvalResult
Jan 8 2019, 3:32 PM
arphaman committed rL350680: [libclang] Fix the mismatched delete operator for ExprEvalResult.
[libclang] Fix the mismatched delete operator for ExprEvalResult
Jan 8 2019, 3:32 PM
arphaman committed rC350666: [libclang] Recommit r336590 with a fix for the memory leak in the test.
[libclang] Recommit r336590 with a fix for the memory leak in the test
Jan 8 2019, 2:36 PM
arphaman committed rL350666: [libclang] Recommit r336590 with a fix for the memory leak in the test.
[libclang] Recommit r336590 with a fix for the memory leak in the test
Jan 8 2019, 2:36 PM
arphaman accepted D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang.

That makes sense, LGTM. Thanks!

Jan 8 2019, 10:33 AM

Jan 3 2019

arphaman updated the diff for D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends.

Do not annotate one token [ .... ] expressions as Objective-C message sends as suggested by Duncan.

Jan 3 2019, 11:24 AM

Jan 2 2019

arphaman committed rL350283: Fix incorrect column numbers in test from r350282..
Fix incorrect column numbers in test from r350282.
Jan 2 2019, 5:34 PM
arphaman committed rC350283: Fix incorrect column numbers in test from r350282..
Fix incorrect column numbers in test from r350282.
Jan 2 2019, 5:34 PM
arphaman committed rL350282: [libclang] CoroutineBody/Coreturn statements are UnexposedStmts and not Exprs.
[libclang] CoroutineBody/Coreturn statements are UnexposedStmts and not Exprs
Jan 2 2019, 5:17 PM
arphaman committed rC350282: [libclang] CoroutineBody/Coreturn statements are UnexposedStmts and not Exprs.
[libclang] CoroutineBody/Coreturn statements are UnexposedStmts and not Exprs
Jan 2 2019, 5:17 PM
arphaman created D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends.
Jan 2 2019, 3:24 PM
arphaman accepted D56067: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit.

LGTM

Jan 2 2019, 1:23 PM

Dec 21 2018

arphaman committed rC349942: Remove stat cache chaining as it's no longer needed after PTH support has been.
Remove stat cache chaining as it's no longer needed after PTH support has been
Dec 21 2018, 11:36 AM
arphaman committed rL349942: Remove stat cache chaining as it's no longer needed after PTH support has been.
Remove stat cache chaining as it's no longer needed after PTH support has been
Dec 21 2018, 11:36 AM
arphaman closed D55455: Remove stat cache chaining as it's no longer needed after PTH support has been removed.
Dec 21 2018, 11:36 AM

Dec 20 2018

arphaman added a comment to D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'.

I think Args.getArgString might return nullptr so that's why you could crash.

Dec 20 2018, 3:36 PM