- User Since
- Jun 25 2014, 4:17 PM (418 w, 5 d)
Thu, Jun 16
@rnk this is option is needed to vendor the Apple clang toolchain in Xcode. Unfortunately we don't have any references to it in the upstream llvm-project repo, but this is breaking our downstream integration. Can this be reverted?
May 25 2022
May 24 2022
Marked them as unsupported on AIX in 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9.
I'm going to disable these tests for aix for now to unblock the bot as they're still failing.
Do you happen to have suggestions for how to try to reproduce this? Looking at the failure it looks like this CI job somehow was unable to be affected by this change, for instance the CI output of index-concept-kind.cpp does not have any concepts output:
May 23 2022
Fix the windows test failure (add -fno-delayed-template-parsing)
Yes, I'm going to check what's wrong with it.
May 19 2022
May 12 2022
LGTM, with one request.
Apr 18 2022
Great, thanks for adding the test case!
Apr 13 2022
The change itself LGTM.
Mar 21 2022
clang -x objective-c++ -Weverything -std=c++14 -c test.mm
I don't think this patch is sound. I found this problem with this change when the following file is compiled in Objective-C++ mode:
Mar 18 2022
Mar 17 2022
I see, thanks! Let me think a bit more about this change and test it on our codebase to see if this is a viable Sema change.
Mar 15 2022
Is there a Swift-based test case you have that demonstrates the original problem from Swift's clang importer side? I'm curious to see where it manifests in Swift.
Mar 14 2022
Feb 22 2022
No, I will land it today.
Feb 21 2022
Feb 15 2022
Feb 14 2022
Add checking for -darwin-target-variant support
Can you add a test case that verifies that using driverkit without a version will default it to driverkit19?
Feb 11 2022
bdf573652138..3f05192c4c40 main -> main
Yep, I just noticed. Reverting for now and will fix LLDB before recommitting.
Feb 8 2022
Feb 7 2022
Feb 2 2022
Feb 1 2022
Fix test failure with asserts enabled.
Update to address review feedback, remove appendToken which is not needed as we're can just setTokens instead (it's a new macro info)
Thanks, that feedback makes sense. I'll update the patch today.
Jan 25 2022
Jan 14 2022
Jan 11 2022
LGTM with one comment. This is great, thanks!
Jan 10 2022
Jan 5 2022
Jan 4 2022
Thanks! I think your tests don't actually test the added code, can you check if you can parse a mapping like ios_tvos in the constructed SDK settings?
I think we would still want to diagnose any mismatches between class properties that override a class property in the superclass. do you think that would be useful? You can adjust the lookup to take that into account.
Dec 20 2021
This change caused the following regression on the EXPENSIVE_CHECKS=on green dragon CI, where clang is unable to compile compiler-rt for armv7:
@vitalybuka Hi, this change caused some test failures on green dragon apple CI. This is the bot: https://green.lab.llvm.org/green/job/clang-stage1-RA/. The following tests are failing:
@vitalybuka This change caused a regression on Darwin CI for tsan -,
This is the CI job: https://green.lab.llvm.org/green/job/clang-stage1-RA, and the build: https://green.lab.llvm.org/green/job/clang-stage1-RA/26354/
ThreadSanitizer-x86_64.Darwin.dlopen.cpp is now failing because the initializer that you added runs before flags is initialized when it's being dlopened . Could you take a look at this issue?
Dec 8 2021
Dec 7 2021
Dec 6 2021
This looks good to me! I agree, an enum class would be cleaner though.
Dec 2 2021
Nov 29 2021
Sorry for delay, this LGTM. Thanks for doing this cleanup!
Nov 19 2021
I will commit this on behalf of @beccadax as she doesn't have commit access yet.
Nov 5 2021
Oct 29 2021
Oct 28 2021
Looks good to me. Can you post the patch with the full context next time so that it's easier to review?