Page MenuHomePhabricator

arphaman (Alex Lorenz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2014, 4:17 PM (273 w, 4 d)

Recent Activity

Fri, Sep 20

arphaman committed rG172e8a7a5de1: [clang-scan-deps] strip the --serialize-diagnostics argument (authored by arphaman).
[clang-scan-deps] strip the --serialize-diagnostics argument
Fri, Sep 20, 5:20 PM
arphaman committed rL372444: [clang-scan-deps] strip the --serialize-diagnostics argument.
[clang-scan-deps] strip the --serialize-diagnostics argument
Fri, Sep 20, 5:16 PM

Thu, Sep 19

arphaman committed rGccf8d5b8292a: Fix for stringized function-macro args continued across lines (authored by arphaman).
Fix for stringized function-macro args continued across lines
Thu, Sep 19, 3:44 PM
arphaman committed rL372360: Fix for stringized function-macro args continued across lines.
Fix for stringized function-macro args continued across lines
Thu, Sep 19, 3:37 PM
arphaman closed D67635: Fix for stringized function-macro args continued across lines.
Thu, Sep 19, 3:37 PM · Restricted Project, Restricted Project
arphaman added a comment to D67635: Fix for stringized function-macro args continued across lines.

Thanks! I will need you to merge this one too!

Thu, Sep 19, 2:28 PM · Restricted Project, Restricted Project
arphaman accepted D67635: Fix for stringized function-macro args continued across lines.

LGTM, thanks!

Thu, Sep 19, 11:02 AM · Restricted Project, Restricted Project

Tue, Sep 17

arphaman added a comment to D67682: [WIP] Add support for preprocessing sources for analyzer.

It's best not to have two places that define the macro. Can we always pass in -D from the driver instead?

Tue, Sep 17, 5:01 PM

Fri, Sep 13

arphaman committed rGee30b0ecc245: [clang-scan-deps] Fix for headers having the same name as a directory (authored by arphaman).
[clang-scan-deps] Fix for headers having the same name as a directory
Fri, Sep 13, 3:11 PM
arphaman committed rL371903: [clang-scan-deps] Fix for headers having the same name as a directory.
[clang-scan-deps] Fix for headers having the same name as a directory
Fri, Sep 13, 3:10 PM
arphaman closed D67091: Fix for headers having the same name as a directory.
Fri, Sep 13, 3:10 PM · Restricted Project, Restricted Project
arphaman accepted D66982: [Modules][Objective-C] Use complete decl from module when diagnosing missing import.

LGTM

Fri, Sep 13, 1:13 PM · Restricted Project, Restricted Project
arphaman added a comment to D67091: Fix for headers having the same name as a directory.

Sure, I can do that today.

Fri, Sep 13, 1:05 PM · Restricted Project, Restricted Project
arphaman accepted D67091: Fix for headers having the same name as a directory.

LGTM, Thanks!

Fri, Sep 13, 12:23 PM · Restricted Project, Restricted Project

Thu, Sep 12

arphaman added a comment to D66984: compiler-rt/builtins: Make check-builtins run tests on macOS..

I think @delcypher wanted to test it first

Thu, Sep 12, 6:11 PM · Restricted Project
arphaman added inline comments to D67522: [clang-scan-deps] Verbose mode.
Thu, Sep 12, 2:12 PM · Restricted Project
arphaman accepted D67522: [clang-scan-deps] Verbose mode.

LGTM

Thu, Sep 12, 2:12 PM · Restricted Project
arphaman committed rG456bfdf5154b: NFC, add missing cl::cat option category to clang-scan-deps options to ensure… (authored by arphaman).
NFC, add missing cl::cat option category to clang-scan-deps options to ensure…
Thu, Sep 12, 12:05 PM
arphaman committed rL371759: NFC, add missing cl::cat option category to clang-scan-deps options to ensure….
NFC, add missing cl::cat option category to clang-scan-deps options to ensure…
Thu, Sep 12, 12:04 PM
arphaman updated subscribers of D67091: Fix for headers having the same name as a directory.

Sorry about the delay on this - I was OOO (back now).

  1. I added tests.
  2. I couldn't add isDirectory() check to createFile() since that resulted in failures to normal scenarios where it was previously passing.

    PTAL!
Thu, Sep 12, 11:47 AM · Restricted Project, Restricted Project
arphaman committed rG57a014d31fb2: [clang-scan-deps] remove dots and dots dots from the reported file dependency… (authored by arphaman).
[clang-scan-deps] remove dots and dots dots from the reported file dependency…
Thu, Sep 12, 11:07 AM
arphaman committed rL371751: [clang-scan-deps] remove dots and dots dots from the reported file dependency….
[clang-scan-deps] remove dots and dots dots from the reported file dependency…
Thu, Sep 12, 11:07 AM

Wed, Sep 11

arphaman accepted D67475: [clang-scan-deps] Add even proper-er dependency targets.

LGTM with one suggestion

Wed, Sep 11, 5:33 PM · Restricted Project
arphaman committed rG428d92832c5d: [clang-scan-deps] cast Result to ErrorOr<unique_ptr<vfs::File>> explicitly to… (authored by arphaman).
[clang-scan-deps] cast Result to ErrorOr<unique_ptr<vfs::File>> explicitly to…
Wed, Sep 11, 2:02 PM
arphaman committed rL371664: [clang-scan-deps] cast Result to ErrorOr<unique_ptr<vfs::File>> explicitly to….
[clang-scan-deps] cast Result to ErrorOr<unique_ptr<vfs::File>> explicitly to…
Wed, Sep 11, 2:02 PM
arphaman committed rGca6e60971e95: [clang-scan-deps] add skip excluded conditional preprocessor block… (authored by arphaman).
[clang-scan-deps] add skip excluded conditional preprocessor block…
Wed, Sep 11, 1:41 PM
arphaman committed rL371656: [clang-scan-deps] add skip excluded conditional preprocessor block….
[clang-scan-deps] add skip excluded conditional preprocessor block…
Wed, Sep 11, 1:41 PM
arphaman closed D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization .
Wed, Sep 11, 1:41 PM · Restricted Project, Restricted Project

Mon, Sep 9

arphaman accepted D67197: [clang-scan-deps] Add proper dependency targets.

LGTM, but please: add a CHECK somewhere that a CompilationComandIdx is actually emitted as a prefix (I don't see one now).

Mon, Sep 9, 6:01 PM
arphaman accepted D67379: [clang-scan-deps] Fix tests - prevent FileCheck matching temp dir path.

Good catch, thanks!

Mon, Sep 9, 5:51 PM · Restricted Project
arphaman added inline comments to D65433: [clangd] DefineInline action availability checks.
Mon, Sep 9, 1:12 PM · Restricted Project

Fri, Sep 6

arphaman added a comment to D67197: [clang-scan-deps] Add proper dependency targets.

Instead of basing the new -MT name off the output, can you base it on the name of the input filename instead to simplify this logic?

I can but I'd like to eventually use something more robust as this will be incorrect if there's -o specified in the compilation command.

Fri, Sep 6, 6:06 PM
arphaman added a comment to D65433: [clangd] DefineInline action availability checks.

When fully implemented, will define inline tweak work with C++ methods in classes as well?
E.g.

Fri, Sep 6, 6:01 PM · Restricted Project
arphaman accepted D67308: [clang][DependencyFileGenerator] Fix missing -MT option handling.

Thanks! I think that's a better layering. LGTM. I don't think there's a particular need to report error to clients of just the DependencyFileGenerator.

Fri, Sep 6, 5:50 PM · Restricted Project
arphaman added a comment to D66984: compiler-rt/builtins: Make check-builtins run tests on macOS..

The approach seems reasonable to me

Fri, Sep 6, 10:04 AM · Restricted Project

Wed, Sep 4

arphaman updated the diff for D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization .

restructure the code to perform skipping directly in the preprocessor

Wed, Sep 4, 5:55 PM · Restricted Project, Restricted Project
arphaman accepted D66775: [libclang] Expose abort()-ing fatal error handler.
Wed, Sep 4, 4:18 PM · Restricted Project
arphaman added a comment to D67197: [clang-scan-deps] Add proper dependency targets.

Why "We need at least one -MT equivalent for the generator to work."?

Wed, Sep 4, 4:01 PM
arphaman added a comment to D67197: [clang-scan-deps] Add proper dependency targets.

Instead of basing the new -MT name off the output, can you base it on the name of the input filename instead to simplify this logic?

Wed, Sep 4, 4:01 PM
arphaman added inline comments to D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization .
Wed, Sep 4, 1:11 PM · Restricted Project, Restricted Project
arphaman updated the diff for D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization .

Add support for chained PP callbacks in setAdditionalPPCallbacks.

Wed, Sep 4, 1:11 PM · Restricted Project, Restricted Project
arphaman committed rL370959: Request commit access for arphaman.
Request commit access for arphaman
Wed, Sep 4, 12:21 PM
arphaman added inline comments to D66775: [libclang] Expose abort()-ing fatal error handler.
Wed, Sep 4, 12:21 PM · Restricted Project
arphaman added a comment to D67163: [Driver] Use shared singleton instance of DriverOptTable.

Thanks, this is useful for clang-scan-deps too!

Wed, Sep 4, 7:46 AM · Restricted Project, Restricted Project

Tue, Sep 3

arphaman created D67127: [clang-scan-deps] add skip excluded conditional preprocessor block preprocessing optimization .
Tue, Sep 3, 2:27 PM · Restricted Project, Restricted Project
arphaman added a comment to D67091: Fix for headers having the same name as a directory.

Thanks for fixing this! Could you add a test case which verifies that the assertion no longer happens? Let me know if you need help coming up with a test.

Tue, Sep 3, 2:12 PM · Restricted Project, Restricted Project

Fri, Aug 30

arphaman committed rG0377ca641c9a: Introduce a DirectoryEntryRef that stores both a reference and an accessed name… (authored by arphaman).
Introduce a DirectoryEntryRef that stores both a reference and an accessed name…
Fri, Aug 30, 6:27 PM
arphaman committed rL370562: Introduce a DirectoryEntryRef that stores both a reference and an.
Introduce a DirectoryEntryRef that stores both a reference and an
Fri, Aug 30, 6:27 PM
arphaman closed D67026: Introduce a DirectoryEntryRef that stores both a reference and an accessed name to the directory entry.
Fri, Aug 30, 6:27 PM · Restricted Project, Restricted Project
arphaman added inline comments to D67026: Introduce a DirectoryEntryRef that stores both a reference and an accessed name to the directory entry.
Fri, Aug 30, 6:26 PM · Restricted Project, Restricted Project
Gaelan awarded D58559: emit '(assertions enabled)' in the version string for a build of clang with assertions enabled a Love token.
Fri, Aug 30, 5:02 PM · Restricted Project
arphaman created D67026: Introduce a DirectoryEntryRef that stores both a reference and an accessed name to the directory entry.
Fri, Aug 30, 4:04 PM · Restricted Project, Restricted Project
arphaman committed rGc4130cf13281: [clang-scan-deps] NFC, remove outdated implementation comment (authored by arphaman).
[clang-scan-deps] NFC, remove outdated implementation comment
Fri, Aug 30, 10:34 AM
arphaman committed rL370493: [clang-scan-deps] NFC, remove outdated implementation comment.
[clang-scan-deps] NFC, remove outdated implementation comment
Fri, Aug 30, 10:33 AM

Thu, Aug 29

arphaman accepted D66710: ASTReader: Bypass overridden files when reading PCHs.

LGTM

Thu, Aug 29, 6:58 PM
arphaman committed rGca4216abde78: [clang-scan-deps] NFC, refactor the DependencyScanningWorker to use a consumer… (authored by arphaman).
[clang-scan-deps] NFC, refactor the DependencyScanningWorker to use a consumer…
Thu, Aug 29, 6:30 PM
arphaman committed rL370425: [clang-scan-deps] NFC, refactor the DependencyScanningWorker to use a consumer.
[clang-scan-deps] NFC, refactor the DependencyScanningWorker to use a consumer
Thu, Aug 29, 6:24 PM
arphaman committed rG3944c9638e56: [clang-scan-deps] reuse the file manager across invocations of the dependency… (authored by arphaman).
[clang-scan-deps] reuse the file manager across invocations of the dependency…
Thu, Aug 29, 3:58 PM
arphaman committed rL370420: [clang-scan-deps] reuse the file manager across invocations of.
[clang-scan-deps] reuse the file manager across invocations of
Thu, Aug 29, 3:55 PM

Wed, Aug 28

arphaman added a comment to D66775: [libclang] Expose abort()-ing fatal error handler.

Is there any way to test this, or is it pretty much hopeless?

Wed, Aug 28, 4:05 PM · Restricted Project

Tue, Aug 27

arphaman accepted D66831: [ObjC] Fix type checking for qualified id block parameters..

LGTM

Tue, Aug 27, 3:55 PM · Restricted Project
arphaman added a comment to D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.

Will the git monorepo handle svn:eol-style correctly?

Tue, Aug 27, 12:48 PM · Restricted Project, Restricted Project
arphaman committed rL370096: Remove clang-tidy-vs from clang-tools-extra (PR41791).
Remove clang-tidy-vs from clang-tools-extra (PR41791)
Tue, Aug 27, 11:52 AM
arphaman committed rG559ae14c9b6c: Remove clang-tidy-vs from clang-tools-extra (PR41791) (authored by arphaman).
Remove clang-tidy-vs from clang-tools-extra (PR41791)
Tue, Aug 27, 11:47 AM
arphaman closed D66813: Remove clang-tidy-vs plugin from clang-tools-extra.
Tue, Aug 27, 11:44 AM · Restricted Project, Restricted Project
arphaman committed rL370093: [driver][xray] fix the macOS support checker by supporting -macos.
[driver][xray] fix the macOS support checker by supporting -macos
Tue, Aug 27, 11:41 AM
arphaman committed rG3737c0239a58: [driver][xray] fix the macOS support checker by supporting -macos triple in… (authored by arphaman).
[driver][xray] fix the macOS support checker by supporting -macos triple in…
Tue, Aug 27, 11:34 AM
arphaman closed D61758: [driver][xray] fix the macOS support checker by supporting -macos triple in addition to -darwin.
Tue, Aug 27, 11:34 AM · Restricted Project, Restricted Project
arphaman created D66813: Remove clang-tidy-vs plugin from clang-tools-extra.
Tue, Aug 27, 11:01 AM · Restricted Project, Restricted Project
arphaman committed rL370081: Use FileEntryRef for PPCallbacks::HasInclude.
Use FileEntryRef for PPCallbacks::HasInclude
Tue, Aug 27, 10:46 AM
arphaman committed rG1c8a4b7204d3: Use FileEntryRef for PPCallbacks::HasInclude (authored by arphaman).
Use FileEntryRef for PPCallbacks::HasInclude
Tue, Aug 27, 10:41 AM

Mon, Aug 26

arphaman committed rG6a808d5a8399: Fix clangd's IndexAction for FileSkipped API update (authored by arphaman).
Fix clangd's IndexAction for FileSkipped API update
Mon, Aug 26, 6:37 PM
arphaman committed rL370004: Fix clangd's IndexAction for FileSkipped API update.
Fix clangd's IndexAction for FileSkipped API update
Mon, Aug 26, 6:37 PM
arphaman committed rG67d25fede9aa: Use FileEntryRef for PPCallbacks::FileSkipped (authored by arphaman).
Use FileEntryRef for PPCallbacks::FileSkipped
Mon, Aug 26, 6:06 PM
arphaman committed rL369998: Use FileEntryRef for PPCallbacks::FileSkipped.
Use FileEntryRef for PPCallbacks::FileSkipped
Mon, Aug 26, 6:05 PM
arphaman added a comment to D66775: [libclang] Expose abort()-ing fatal error handler.

Is there any way to test this, or is it pretty much hopeless?

Mon, Aug 26, 5:37 PM · Restricted Project
arphaman committed rL369956: Fix gen-cdb-fragment test for Windows.
Fix gen-cdb-fragment test for Windows
Mon, Aug 26, 1:11 PM
arphaman committed rG29f10822a796: Fix gen-cdb-fragment test for Windows (authored by arphaman).
Fix gen-cdb-fragment test for Windows
Mon, Aug 26, 1:06 PM
arphaman committed rL369938: [driver] add a new option `-gen-cdb-fragment-path` to emit.
[driver] add a new option `-gen-cdb-fragment-path` to emit
Mon, Aug 26, 11:17 AM
arphaman committed rG8679ef4e46a4: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a… (authored by arphaman).
[driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a…
Mon, Aug 26, 11:10 AM
arphaman closed D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation.
Mon, Aug 26, 11:10 AM · Restricted Project
arphaman added a comment to D66710: ASTReader: Bypass overridden files when reading PCHs.

Missing full context

Mon, Aug 26, 10:23 AM
arphaman accepted D66713: ContentCache: Drop getBuffer's dependency on SourceManager.

LGTM

Mon, Aug 26, 10:23 AM
arphaman accepted D66705: FileManager: Use llvm::Expected in new getFileRef API.

LGTM

Mon, Aug 26, 10:21 AM · Restricted Project
arphaman added a comment to D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations.

No the windows test failure was different, there were no Deps at all. I'm currently investigating it on a windows VM.

@JamesNagurne I think there's some issue with the working directory, which is not added in your case. Which platform are you running your build/test on? Which cmake options are you using?

I apologize for not giving such information in the first reply. Unfortunately this isn't an easy remote reproduction, as our ToolChain and some integral changes aren't upstreamed. This is an embedded ARM cross-compiled on Linux. Might be able to reproduce with arm-none-none-eabi.
LLVM is built as an external project. Looking at the build system, it looks like we have the CMAKE_ARGS:

-DLLVM_DEFAULT_TARGET_TRIPLE=arm-ti-none-eabi
-DLLVM_EXTERNAL_CLANG_SOURCE_DIR=${CMAKE_SOURCE_DIR}/llvm-project/clang
-DLLVM_TARGETS_TO_BUILD=ARM
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_CXX_COMPILER=clang++
-DCMAKE_C_COMPILER=clang
-DLLVM_USE_LINKER=gold
-GNinja

Nothing suspicious, except maybe the default triple and ARM target.
Looking at our (not upstream) toolchain file, we do have some RTLibs, LibInternal, libcxx, and System include changes, along with a -nostdsysteminc to avoid pulling host includes into our cross compiler. However, none of this should affect general "#include" behavior, correct?
Another glance at your changes don't seem to affect any target-specific handling either, at least directly.

Mon, Aug 26, 10:20 AM · Restricted Project, Restricted Project
arphaman accepted D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.

LGTM

Mon, Aug 26, 10:14 AM · Restricted Project, Restricted Project

Sat, Aug 24

arphaman added inline comments to D66705: FileManager: Use llvm::Expected in new getFileRef API.
Sat, Aug 24, 8:32 AM · Restricted Project

Aug 23 2019

arphaman committed rGa39e6490af0f: Re-enable DependencyScannerTest on windows with the right fixes (authored by arphaman).
Re-enable DependencyScannerTest on windows with the right fixes
Aug 23 2019, 6:55 PM
arphaman committed rL369832: Re-enable DependencyScannerTest on windows with the right fixes.
Re-enable DependencyScannerTest on windows with the right fixes
Aug 23 2019, 6:54 PM
arphaman added a comment to D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations.

@arphaman you disabled this test on Windows, but did not specify exactly how it fails.
My team works on an embedded ARM compiler (most similar to arm-none-eabi), and we're now seeing failures from DependencyScannerTest. I can't find a buildbot failure for this test so I can't cross-reference to see if we have the same issue.

Does this failure look similar to what you saw on Windows, or could it be an option we're adding as part of the Compilation setup?

[ RUN      ] DependencyScanner.ScanDepsReuseFilemanager
.../clang/unittests/Tooling/DependencyScannerTest.cpp:100: Failure
      Expected: Deps[1]
      Which is: "symlink.h"
To be equal to: "/root/symlink.h"
.../clang/unittests/Tooling/DependencyScannerTest.cpp:101: Failure
      Expected: Deps[2]
      Which is: "header.h"
To be equal to: "/root/header.h"
.../clang/unittests/Tooling/DependencyScannerTest.cpp:113: Failure
      Expected: Deps[1]
      Which is: "symlink.h"
To be equal to: "/root/symlink.h"
.../clang/unittests/Tooling/DependencyScannerTest.cpp:114: Failure
      Expected: Deps[2]
      Which is: "header.h"
To be equal to: "/root/header.h"
[  FAILED  ] DependencyScanner.ScanDepsReuseFilemanager (5 ms)
Aug 23 2019, 2:03 PM · Restricted Project, Restricted Project
arphaman added inline comments to D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation.
Aug 23 2019, 10:44 AM · Restricted Project
arphaman updated the diff for D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation.

Address review comments.

Aug 23 2019, 10:41 AM · Restricted Project
arphaman accepted D66511: [clang-scan-deps] Skip UTF-8 BOM in source minimizer.

LGTM

Aug 23 2019, 10:01 AM · Restricted Project, Restricted Project

Aug 22 2019

arphaman added inline comments to D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings.
Aug 22 2019, 3:49 PM · Restricted Project, Restricted Project
arphaman updated the diff for D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation.

Reimplement the new option on top of -MJ. -MJ is still the preferred option if both are specified.

Aug 22 2019, 2:18 PM · Restricted Project
arphaman added a comment to D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation.

@jkorous I addressed your comments as well ("" directory is now allowed, error is reported, existing escape used).

Aug 22 2019, 2:18 PM · Restricted Project
arphaman committed rG7a490c5b0683: Disable the ScanDepsReuseFilemanager test on Windows (authored by arphaman).
Disable the ScanDepsReuseFilemanager test on Windows
Aug 22 2019, 12:08 PM
arphaman committed rL369688: Disable the ScanDepsReuseFilemanager test on Windows.
Disable the ScanDepsReuseFilemanager test on Windows
Aug 22 2019, 11:59 AM
arphaman committed rG4dc5573acc0d: Introduce FileEntryRef and use it when handling includes to report correct… (authored by arphaman).
Introduce FileEntryRef and use it when handling includes to report correct…
Aug 22 2019, 11:16 AM
arphaman committed rL369680: Introduce FileEntryRef and use it when handling includes to report correct….
Introduce FileEntryRef and use it when handling includes to report correct…
Aug 22 2019, 11:15 AM