- User Since
- Jun 25 2014, 4:17 PM (152 w, 3 d)
Wed, May 24
Please post the patch with full context git diff -U9999.
Tue, May 23
Remove the first redundant error check.
Mon, May 22
LGTM with one change below:
Ok, I will commit them sometime this week then.
Fri, May 19
While I do agree that these tests would be better off in another place, we currently don't have the bandwidth to facilitate that move.
I've managed to put together a solution that adds REQUIRES to the tests that ensure they only work with the latest SDK (10.12).
Thu, May 18
Wed, May 17
Hmm, I don't like how we end with a location that points to x instead of InterWithProp. Can we ignore the TypeLocs with invalid location and instead look at ObjCPropertyRefExprs with a class receiver?
Tue, May 16
I will commit it today.
Mon, May 15
Fri, May 12
We'd be ok with tying the test to a specific SDK and maintaining that tie (e.g. bumping it upstream).
I was planning to investigate how to make the SDK version checks work, but I don't have the time ATM. Can I get back to you in a week?
Thu, May 11
Wed, May 10
LGTM! A couple of comments below:
Tue, May 9
Mon, May 8
Fri, May 5
- Simplify the RecursiveASTVisitor as suggested by Erik
- Improve the note to include __builtin_available
Thu, May 4
Wed, May 3
Tue, May 2
Fri, Apr 28
Apr 27 2017
Apr 26 2017
It looks good, I have a couple of comments:
Apr 25 2017
@emilio, you can request to merge this into 4.0.1 by using a script called merge-request.sh (http://lists.llvm.org/pipermail/llvm-dev/2017-March/111530.html).
Sure. You can ask Chris Lattner for commit access for future patches :)
Now the patch takes the following situations into account:
- Enclose only the statement in a case.
- If the fixit has to enclose a declaration statement, then the fixit will try to enclose the appropriate uses as well.
Apr 24 2017
Maybe it would be better to introduce a CXTargetInfo type, and change the API to be:
clang_getTranslationUnitTargetInfo clang_TargetInfo_getTriple clang_TargetInfo_getPointerWidth
This way the TargetInfo functions will be cleanly separated, so we can extend the API easier in the future.
I see, thanks for explaining. LGTM. Do you need someone to commit it?
Apr 21 2017
Please post the diff with full context (git diff -U9999).
Rebased the patch.
Rebased the patch.
Apr 20 2017
Updated the relationship to be 'overrideOf | specializationOf' to differentiate it from regular 'overrideOf'.