- User Since
- Jun 25 2014, 4:17 PM (300 w, 5 d)
Fri, Mar 27
Great, that looks better, thanks! LGTM
LGTM with one comment that needs to be fixed
It looks like you're now adding a dependency on a real filesystem to the VFS writer due to calls to fs::is_directory. I think it should be possible to use a VFS write to construct a VFS file without an underlying filesystem, or with an underlying filesystem that doesn't represent the state of your constructed VFS. Is there another way to achieve this goal without depending on the underlying filesystem?
Wed, Mar 25
This change causes compiler-rt to fail to build lib/CMakeFiles/SanitizerLintCheck on Darwin with the following error:
Feb 13 2020
Feb 10 2020
Feb 6 2020
Jan 28 2020
Add suggested changes. The -ibuiltininc flag now interacts with -nobuiltininc as well, i.e. it's cancelled out if -nobuiltininc comes after it, and vice-versa.
Jan 27 2020
Jan 22 2020
This also breaks the macOS SDK. @rsmith could you please disable this change for Darwin when you're recommitting this patch?
Jan 21 2020
Please add a test that exercises path without ARC enabled.
Jan 10 2020
LGTM, with a nit mentioned.
Jan 9 2020
It might be hard to test in a regular build: you probably would need to construct a test-case where the buffer is precisely a multiple of the page size and not nil-terminated, and then hopefully the OS will trigger a fault once you access the out of bounds character. Have you tried ASANified build? I think it could trigger a crash even if you don't get the pages right and just have a not-nil terminated buffer.
Jan 8 2020
Did you check if you can reproduce it with a unittest by passing in a Buffer that's not nil-terminated?
Dec 17 2019
Looks like HOST_LINK_VERSION is influencing the decision. I should specify the version manually in the tests then.
@phosek Thanks, I think it reproduces on our macOS bots. I'll start fixing it right now.
I couldn't come up with a reasonable Sema-based test, so I'm going to commit this as it is.
LGTM, But we should also have a test in Sema that verifies it works, and also covers class properties in addition to the instance ones. I can add one when committing (@MadCoder still doesn't have commit access).