- User Since
- Jun 25 2014, 4:17 PM (247 w, 22 h)
Fri, Feb 22
Use "(+asserts)" as suggested.
Please add a test that covers the '(class extension)' output as well.
Feb 14 2019
Feb 8 2019
Feb 4 2019
Feb 1 2019
Jan 31 2019
The real problem is that clang_parseTranslationUnit2 is broken, so this just fixes one client, c-index-test. All other macOS clients that call that function will still be unable to find the libc++ headers.
Do you know if this have an effect on the output of completion results or other tooling-based output?
Yes, that should work.
Makes sense. The comments aren't really enforceable though, can we just factor this out into one function in lib/Basic that can be shared between all sites? It seems like there's nothing that would prevent that.
Jan 30 2019
We could introduce a new extension flag like c_fixed_enum that can be set for all language modes. objc_fixed_enum should apply to ObjC only.
@erik.pilkington the change to make objc_fixed_enum true in non-ObjC mode turned out to be problematic for our adoption. Could you please fix it before LLVM8 is wrapped up so that we don't ship this extension as on by default for all language modes?
Jan 24 2019
Update for Ben's comments.
Jan 18 2019
- Add documentation and expand a comment as suggested by Aaron.
- Address Erik's comments.
Jan 17 2019
Reverse the priority numbering direction as suggested by @dexonsmith .
Jan 16 2019
Follow Erik's suggestion and don't check for definition/declaration in parent class.
Jan 15 2019
Jan 14 2019
Jan 11 2019
Jan 9 2019
Address review comments.
Jan 8 2019
That makes sense, LGTM. Thanks!
Jan 3 2019
Do not annotate one token [ .... ] expressions as Objective-C message sends as suggested by Duncan.
Jan 2 2019
Dec 21 2018
Dec 20 2018
I think Args.getArgString might return nullptr so that's why you could crash.
Fixed comment, will commit.
Dec 19 2018
I think we might need to run it past the internal builds to see if anything breaks.
Dec 17 2018
Dec 14 2018
Ensure test will pass on non-darwin.
Updated to infer deployment target version from SDK versions specified in the JSON file and to allow inferring the SDK version from the SDK path.
Dec 13 2018
Dec 12 2018
Dec 11 2018
Thanks for working on this! Could you please post a patch with full context (git diff -U9999)?