Page MenuHomePhabricator

arphaman (Alex Lorenz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2014, 4:17 PM (418 w, 5 d)

Recent Activity

Thu, Jun 16

arphaman added a comment to D126977: [config] Remove vestigial LLVM_VERSION_INFO.

@rnk this is option is needed to vendor the Apple clang toolchain in Xcode. Unfortunately we don't have any references to it in the upstream llvm-project repo, but this is breaking our downstream integration. Can this be reverted?

Thu, Jun 16, 3:34 PM · Restricted Project, Restricted Project

May 25 2022

arphaman committed rG79e09af1d6e1: [clang] Fix the begin location of concepts specialization expression (authored by arphaman).
[clang] Fix the begin location of concepts specialization expression
May 25 2022, 12:40 PM · Restricted Project, Restricted Project
arphaman closed D126332: [clang] Fix the begin location of concepts specialization expression.
May 25 2022, 12:40 PM · Restricted Project, Restricted Project

May 24 2022

arphaman retitled D126332: [clang] Fix the begin location of concepts specialization expression from [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token to [clang] Fix the begin location of concepts specialization expression.
May 24 2022, 2:49 PM · Restricted Project, Restricted Project
arphaman requested review of D126332: [clang] Fix the begin location of concepts specialization expression.
May 24 2022, 2:47 PM · Restricted Project, Restricted Project
arphaman added a comment to D126031: [libclang] add supporting for indexing/visiting C++ concepts.

Marked them as unsupported on AIX in 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9.

May 24 2022, 1:40 PM · Restricted Project, Restricted Project
arphaman committed rG1b34f1e99656: [clang][test] mark tests added in ee8524087c78 as unsupported on AIX (authored by arphaman).
[clang][test] mark tests added in ee8524087c78 as unsupported on AIX
May 24 2022, 1:40 PM · Restricted Project, Restricted Project
arphaman added a comment to D126031: [libclang] add supporting for indexing/visiting C++ concepts.

@Jake-Egan
I'm going to disable these tests for aix for now to unblock the bot as they're still failing.

May 24 2022, 1:36 PM · Restricted Project, Restricted Project
arphaman added a comment to D126031: [libclang] add supporting for indexing/visiting C++ concepts.

@Jake-Egan
Do you happen to have suggestions for how to try to reproduce this? Looking at the failure it looks like this CI job somehow was unable to be affected by this change, for instance the CI output of index-concept-kind.cpp does not have any concepts output:

May 24 2022, 12:42 PM · Restricted Project, Restricted Project
arphaman added a comment to D126031: [libclang] add supporting for indexing/visiting C++ concepts.

Sure, investigating.

May 24 2022, 12:28 PM · Restricted Project, Restricted Project
arphaman committed rGee8524087c78: [libclang] add supporting for indexing/visiting C++ concepts (authored by arphaman).
[libclang] add supporting for indexing/visiting C++ concepts
May 24 2022, 10:03 AM · Restricted Project, Restricted Project
arphaman closed D126031: [libclang] add supporting for indexing/visiting C++ concepts.
May 24 2022, 10:03 AM · Restricted Project, Restricted Project

May 23 2022

arphaman updated the diff for D126031: [libclang] add supporting for indexing/visiting C++ concepts.

Fix the windows test failure (add -fno-delayed-template-parsing)

May 23 2022, 3:49 PM · Restricted Project, Restricted Project
arphaman added a comment to D126031: [libclang] add supporting for indexing/visiting C++ concepts.

Yes, I'm going to check what's wrong with it.

May 23 2022, 3:28 PM · Restricted Project, Restricted Project

May 19 2022

arphaman requested review of D126031: [libclang] add supporting for indexing/visiting C++ concepts.
May 19 2022, 4:14 PM · Restricted Project, Restricted Project

May 12 2022

arphaman accepted D121911: [Clang] Add DriverKit support.

LGTM, with one request.

May 12 2022, 8:15 AM · Restricted Project, Restricted Project

Apr 18 2022

arphaman accepted D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath.

Great, thanks for adding the test case!

Apr 18 2022, 4:12 PM · Restricted Project, Restricted Project

Apr 13 2022

arphaman added a comment to D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath.

The change itself LGTM.

Apr 13 2022, 10:55 AM · Restricted Project, Restricted Project

Mar 21 2022

arphaman added a comment to D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName.

clang -x objective-c++ -Weverything -std=c++14 -c test.mm

Mar 21 2022, 2:34 PM · Restricted Project, Restricted Project
arphaman added a comment to D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName.

I don't think this patch is sound. I found this problem with this change when the following file is compiled in Objective-C++ mode:

Mar 21 2022, 1:56 PM · Restricted Project, Restricted Project

Mar 18 2022

arphaman accepted D122030: Driver: Make macOS the default target OS for -arch arm64.
Mar 18 2022, 1:26 PM · Restricted Project, Restricted Project

Mar 17 2022

arphaman added a comment to D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName.

I see, thanks! Let me think a bit more about this change and test it on our codebase to see if this is a viable Sema change.

Mar 17 2022, 5:36 PM · Restricted Project, Restricted Project

Mar 15 2022

arphaman added a comment to D121748: [clang][Sema] Better support for ObjC++ in Sema::LookupName.

Is there a Swift-based test case you have that demonstrates the original problem from Swift's clang importer side? I'm curious to see where it manifests in Swift.

Mar 15 2022, 4:53 PM · Restricted Project, Restricted Project

Mar 14 2022

arphaman accepted D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO.
Mar 14 2022, 3:02 PM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2022

arphaman committed rGf5153d9e7262: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst… (authored by arphaman).
[compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst…
Feb 22 2022, 7:33 PM
arphaman closed D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support.
Feb 22 2022, 7:32 PM · Restricted Project
arphaman added a comment to D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support.

No, I will land it today.

Feb 22 2022, 9:13 AM · Restricted Project

Feb 21 2022

arphaman accepted D118046: Add DriverKit support.

LGTM

Feb 21 2022, 10:12 AM · Restricted Project

Feb 15 2022

arphaman accepted D119850: Darwin: introduce a global override for debug prefix map entries.
Feb 15 2022, 12:15 PM · Restricted Project
arphaman added inline comments to D119850: Darwin: introduce a global override for debug prefix map entries.
Feb 15 2022, 9:11 AM · Restricted Project

Feb 14 2022

arphaman added a comment to D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands.

The following two tests started failing in our bots:

Clang :: Driver/darwin-ld-platform-version-target-version.c
Clang :: Driver/darwin-zippered-target-version.c

https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8822219707275734081/overview

The error message is as the following:

Script:
--
: 'RUN: at line 1';   touch /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld-platform-version-target-version.c.tmp.o
: 'RUN: at line 3';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target x86_64-apple-ios13.1-macabi -darwin-target-variant x86_64-apple-macos10.15 -isysroot /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/MacOSX10.15.versioned.sdk -mlinker-version=520 -### /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld-platform-version-target-version.c.tmp.o 2>&1    | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/darwin-ld-platform-version-target-version.c
: 'RUN: at line 5';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target x86_64-apple-macos10.14.3 -darwin-target-variant x86_64-apple-ios13.1-macabi -isysroot /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/MacOSX10.15.versioned.sdk -mlinker-version=520 -### /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld-platform-version-target-version.c.tmp.o 2>&1    | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck --check-prefix=CHECK-INV /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/darwin-ld-platform-version-target-version.c
: 'RUN: at line 8';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target arm64-apple-ios13.1-macabi -darwin-target-variant arm64-apple-macos10.15 -isysroot /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/MacOSX10.15.versioned.sdk -mlinker-version=520 -### /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld-platform-version-target-version.c.tmp.o 2>&1    | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck --check-prefix=ARM64_NEW /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/darwin-ld-platform-version-target-version.c
: 'RUN: at line 10';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target arm64-apple-macos10.15 -darwin-target-variant arm64-apple-ios13.1-macabi  -isysroot /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/MacOSX10.15.versioned.sdk -mlinker-version=520 -### /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld-platform-version-target-version.c.tmp.o 2>&1    | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck --check-prefix=ARM64_NEW-INV /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/darwin-ld-platform-version-target-version.c
: 'RUN: at line 12';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target arm64-apple-ios13.1-macabi -darwin-target-variant arm64-apple-macos10.15 -isysroot /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/MacOSX10.15.versioned.sdk -mlinker-version=400 -### /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld-platform-version-target-version.c.tmp.o 2>&1    | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck --check-prefix=ARM64_OLD /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/darwin-ld-platform-version-target-version.c
: 'RUN: at line 14';   /b/s/w/ir/x/w/staging/llvm_build/bin/clang -target arm64-apple-macos10.15 -darwin-target-variant arm64-apple-ios13.1-macabi -isysroot /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/MacOSX10.15.versioned.sdk -mlinker-version=400 -### /b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld-platform-version-target-version.c.tmp.o 2>&1    | /b/s/w/ir/x/w/staging/llvm_build/bin/FileCheck --check-prefix=ARM64_OLD-INV /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/darwin-ld-platform-version-target-version.c
--
Exit Code: 1

Command Output (stderr):
--
/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/darwin-ld-platform-version-target-version.c:29:15: error: ARM64_OLD: expected string not found in input
// ARM64_OLD: "-maccatalyst_version_min" "14.0.0" "-macosx_version_min" "11.0.0"
              ^
<stdin>:1:1: note: scanning from here
Fuchsia clang version 15.0.0 (https://llvm.googlesource.com/a/llvm-project cccef321096c20825fe8738045c1d91d3b9fd57d)
^
<stdin>:5:109: note: possible intended match here
 "/b/s/w/ir/x/w/staging/llvm_build/bin/ld64.lld" "-demangle" "-dynamic" "-arch" "arm64" "-platform_version" "mac catalyst" "14.0.0" "13.1" "-platform_version" "macos" "11.0.0" "10.15" "-syslibroot" "/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/MacOSX10.15.versioned.sdk" "-o" "a.out" "/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld-platform-version-target-version.c.tmp.o" "-lSystem"
                                                                                                            ^

Input file: <stdin>
Check file: /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/darwin-ld-platform-version-target-version.c

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            1: Fuchsia clang version 15.0.0 (https://llvm.googlesource.com/a/llvm-project cccef321096c20825fe8738045c1d91d3b9fd57d) 
check:29'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
            2: Target: arm64-apple-ios13.1-macabi 
check:29'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            3: Thread model: posix 
check:29'0     ~~~~~~~~~~~~~~~~~~~~
            4: InstalledDir: /b/s/w/ir/x/w/staging/llvm_build/bin 
check:29'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            5:  "/b/s/w/ir/x/w/staging/llvm_build/bin/ld64.lld" "-demangle" "-dynamic" "-arch" "arm64" "-platform_version" "mac catalyst" "14.0.0" "13.1" "-platform_version" "macos" "11.0.0" "10.15" "-syslibroot" "/b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/Inputs/MacOSX10.15.versioned.sdk" "-o" "a.out" "/b/s/w/ir/x/w/staging/llvm_build/tools/clang/test/Driver/Output/darwin-ld-platform-version-target-version.c.tmp.o" "-lSystem" 
check:29'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:29'1                                                                                                                 ?                                                                                                                                                                                                                                                                                                                           possible intended match
>>>>>>

--
Feb 14 2022, 4:17 PM · Restricted Project
arphaman added a reviewer for D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support: aralisza.
Feb 14 2022, 2:23 PM · Restricted Project
arphaman updated the diff for D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support.

Add checking for -darwin-target-variant support

Feb 14 2022, 2:21 PM · Restricted Project
arphaman added a comment to D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support.

Hi, I built and tested clang using this patch and https://reviews.llvm.org/D118862. It works great.
The current patch adds the -darwin-target-variant flag to all object files for MacOS targets in the compiler_rt's builtin library. However, users building compiler_rt may have compilers that don't support such flag, so it would be nice to have a CMake option to enable compiler flags like COMPILER_RT_ENABLE_CATALYST.

Feb 14 2022, 1:30 PM · Restricted Project
arphaman committed rG688622ff607c: [clang][test] Add -fuse-ld= to test cases added in… (authored by arphaman).
[clang][test] Add -fuse-ld= to test cases added in…
Feb 14 2022, 1:23 PM
arphaman committed rGd238acd1131e: [clang][driver] add clang driver support for emitting macho files with two… (authored by arphaman).
[clang][driver] add clang driver support for emitting macho files with two…
Feb 14 2022, 12:28 PM
arphaman closed D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands.
Feb 14 2022, 12:27 PM · Restricted Project
arphaman added a comment to D118046: Add DriverKit support.

Can you add a test case that verifies that using driverkit without a version will default it to driverkit19?

Feb 14 2022, 11:13 AM · Restricted Project
arphaman committed rG00cd6c04202a: [Preprocessor] Reduce the memory overhead of `#define` directives (Recommit) (authored by arphaman).
[Preprocessor] Reduce the memory overhead of `#define` directives (Recommit)
Feb 14 2022, 9:28 AM

Feb 11 2022

arphaman added a reverting change for rG0d9b91524ea4: [Preprocessor] Reduce the memory overhead of `#define` directives: rG3f05192c4c40: Revert "[Preprocessor] Reduce the memory overhead of `#define` directives".
Feb 11 2022, 3:55 PM
arphaman added a reverting change for D117348: [Preprocessor] Reduce the memory overhead of `#define` directives: rG3f05192c4c40: Revert "[Preprocessor] Reduce the memory overhead of `#define` directives".
Feb 11 2022, 3:55 PM · Restricted Project
arphaman committed rG3f05192c4c40: Revert "[Preprocessor] Reduce the memory overhead of `#define` directives" (authored by arphaman).
Revert "[Preprocessor] Reduce the memory overhead of `#define` directives"
Feb 11 2022, 3:54 PM
arphaman added a comment to D117348: [Preprocessor] Reduce the memory overhead of `#define` directives.

To github.com:llvm/llvm-project.git

bdf573652138..3f05192c4c40  main -> main
Feb 11 2022, 3:54 PM · Restricted Project
arphaman added a comment to D117348: [Preprocessor] Reduce the memory overhead of `#define` directives.

Yep, I just noticed. Reverting for now and will fix LLDB before recommitting.

Feb 11 2022, 3:54 PM · Restricted Project
arphaman committed rG0d9b91524ea4: [Preprocessor] Reduce the memory overhead of `#define` directives (authored by arphaman).
[Preprocessor] Reduce the memory overhead of `#define` directives
Feb 11 2022, 3:01 PM
arphaman closed D117348: [Preprocessor] Reduce the memory overhead of `#define` directives.
Feb 11 2022, 3:01 PM · Restricted Project
arphaman accepted D119226: [clang][lex][minimizer] Avoid treating path separators as comments.

Cheers, LGTM

Feb 11 2022, 12:02 PM · Restricted Project

Feb 8 2022

arphaman accepted D119231: [clang][lex][minimizer] Ensure whitespace between squashed lines.

LG, thanks!

Feb 8 2022, 12:10 PM · Restricted Project

Feb 7 2022

arphaman committed rGb58bf76f97f4: [clang][driver] update the darwin driver to point to correct macho_embedded path (authored by arphaman).
[clang][driver] update the darwin driver to point to correct macho_embedded path
Feb 7 2022, 4:51 PM
arphaman closed D115403: [clang][driver] update the darwin driver to point to correct macho_embedded path.
Feb 7 2022, 4:51 PM · Restricted Project

Feb 2 2022

arphaman requested review of D118875: [compiler-rt][builtins] build the macOS compiler-rt built-ins with Mac Catalyst support.
Feb 2 2022, 11:36 PM · Restricted Project
arphaman updated the summary of D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands.
Feb 2 2022, 4:40 PM · Restricted Project
arphaman requested review of D118862: [clang][driver] add clang driver support for emitting macho files with two build version load commands.
Feb 2 2022, 4:38 PM · Restricted Project
arphaman committed rG979d0ee8ab30: [clang] fix out of bounds access in an empty string when lexing a _Pragma with… (authored by arphaman).
[clang] fix out of bounds access in an empty string when lexing a _Pragma with…
Feb 2 2022, 11:16 AM
arphaman closed D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.
Feb 2 2022, 11:16 AM · Restricted Project
arphaman committed rG116c1bea65ac: [clang][macho] add clang frontend support for emitting macho files with two… (authored by arphaman).
[clang][macho] add clang frontend support for emitting macho files with two…
Feb 2 2022, 8:31 AM
arphaman closed D115415: [clang][macho] add clang frontend support for emitting macho files with two build version load commands.
Feb 2 2022, 8:31 AM · Restricted Project, Restricted Project

Feb 1 2022

arphaman updated the diff for D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.

Fix test failure with asserts enabled.

Feb 1 2022, 11:28 PM · Restricted Project
arphaman added inline comments to D117348: [Preprocessor] Reduce the memory overhead of `#define` directives.
Feb 1 2022, 2:35 PM · Restricted Project
arphaman updated the diff for D117348: [Preprocessor] Reduce the memory overhead of `#define` directives.

Update to address review feedback, remove appendToken which is not needed as we're can just setTokens instead (it's a new macro info)

Feb 1 2022, 2:35 PM · Restricted Project
arphaman added a comment to D117348: [Preprocessor] Reduce the memory overhead of `#define` directives.

Thanks, that feedback makes sense. I'll update the patch today.

Feb 1 2022, 1:46 PM · Restricted Project

Jan 25 2022

arphaman accepted D117809: [clang] Add an extract-api driver option.
Jan 25 2022, 9:39 PM · Restricted Project

Jan 14 2022

arphaman requested review of D117348: [Preprocessor] Reduce the memory overhead of `#define` directives.
Jan 14 2022, 11:14 AM · Restricted Project

Jan 11 2022

arphaman accepted D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability.

LGTM with one comment. This is great, thanks!

Jan 11 2022, 11:56 AM · Restricted Project

Jan 10 2022

arphaman accepted D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties.

LGTM, Cheers!

Jan 10 2022, 2:46 PM · Restricted Project

Jan 5 2022

arphaman committed rG809c6a5a1d2f: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS (authored by egorzhdan).
[Clang] Extract availability mapping from VersionMap for watchOS/tvOS
Jan 5 2022, 5:00 PM
arphaman closed D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS.
Jan 5 2022, 5:00 PM · Restricted Project
arphaman accepted D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS.

LGTM

Jan 5 2022, 9:20 AM · Restricted Project

Jan 4 2022

arphaman added a comment to D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS.

Thanks! I think your tests don't actually test the added code, can you check if you can parse a mapping like ios_tvos in the constructed SDK settings?

Jan 4 2022, 3:45 PM · Restricted Project
arphaman added a comment to D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties.

I think we would still want to diagnose any mismatches between class properties that override a class property in the superclass. do you think that would be useful? You can adjust the lookup to take that into account.

Jan 4 2022, 3:42 PM · Restricted Project

Dec 20 2021

arphaman added a comment to D115497: [Inline] Disable deferred inlining.

This change caused the following regression on the EXPENSIVE_CHECKS=on green dragon CI, where clang is unable to compile compiler-rt for armv7:

Dec 20 2021, 6:29 PM · Restricted Project
arphaman updated subscribers of D114498: [sanitizer] Run Stack compression in background thread.

@vitalybuka Hi, this change caused some test failures on green dragon apple CI. This is the bot: https://green.lab.llvm.org/green/job/clang-stage1-RA/. The following tests are failing:

Dec 20 2021, 2:34 PM · Restricted Project
arphaman added a comment to D115759: Add a flag to force tsan's background thread.

@vitalybuka This change caused a regression on Darwin CI for tsan -,
This is the CI job: https://green.lab.llvm.org/green/job/clang-stage1-RA, and the build: https://green.lab.llvm.org/green/job/clang-stage1-RA/26354/
ThreadSanitizer-x86_64.Darwin.dlopen.cpp is now failing because the initializer that you added runs before flags is initialized when it's being dlopened . Could you take a look at this issue?

Dec 20 2021, 1:43 PM · Restricted Project
arphaman updated the summary of D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.
Dec 20 2021, 12:35 PM · Restricted Project
arphaman updated the summary of D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.
Dec 20 2021, 12:35 PM · Restricted Project
arphaman updated the summary of D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.
Dec 20 2021, 12:34 PM · Restricted Project
arphaman requested review of D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.
Dec 20 2021, 12:31 PM · Restricted Project

Dec 8 2021

arphaman updated subscribers of D115415: [clang][macho] add clang frontend support for emitting macho files with two build version load commands.
Dec 8 2021, 5:54 PM · Restricted Project, Restricted Project
arphaman requested review of D115415: [clang][macho] add clang frontend support for emitting macho files with two build version load commands.
Dec 8 2021, 5:54 PM · Restricted Project, Restricted Project
arphaman requested review of D115403: [clang][driver] update the darwin driver to point to correct macho_embedded path.
Dec 8 2021, 3:25 PM · Restricted Project
arphaman added inline comments to D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all.
Dec 8 2021, 2:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
arphaman added inline comments to D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all.
Dec 8 2021, 2:21 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 7 2021

arphaman committed rG0756aa397856: [macho] add support for emitting macho files with two build version load… (authored by arphaman).
[macho] add support for emitting macho files with two build version load…
Dec 7 2021, 6:18 PM
arphaman closed D112189: [macho] add support for emitting macho files with two build version load commands.
Dec 7 2021, 6:18 PM · Restricted Project

Dec 6 2021

arphaman accepted D114971: [clang][deps] Handle symlinks in minimizing FS.

This looks good to me! I agree, an enum class would be cleaner though.

Dec 6 2021, 9:03 AM · Restricted Project

Dec 2 2021

arphaman added a comment to D114968: [clang][deps] Avoid reading file for stat calls.

Assuming the filesystem doesn't change during dependency scanning, this change keeps the consistency between stat/read calls for minimized files.

Thinking about it some more though, the original reason for reading files eagerly (even for stat calls) was most likely to avoid inconsistencies when the file changes on the filesystem between stat and read. Is that correct, @arphaman? If so, I think I should abandon this patch.

Agreed; that consistency is important. I don't think stat should be decoupled from reading the file.

Dec 2 2021, 11:58 PM · Restricted Project

Nov 29 2021

arphaman accepted D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible..

Sorry for delay, this LGTM. Thanks for doing this cleanup!

Nov 29 2021, 7:37 PM · Restricted Project, Restricted Project

Nov 19 2021

arphaman committed rG290cddcd139d: Allow __attribute__((swift_attr)) in attribute push pragmas (authored by beccadax).
Allow __attribute__((swift_attr)) in attribute push pragmas
Nov 19 2021, 1:00 PM
arphaman closed D112773: Allow __attribute__((swift_attr)) in attribute push pragmas.
Nov 19 2021, 1:00 PM · Restricted Project
arphaman added a comment to D112773: Allow __attribute__((swift_attr)) in attribute push pragmas.

I will commit this on behalf of @beccadax as she doesn't have commit access yet.

Nov 19 2021, 12:08 PM · Restricted Project

Nov 5 2021

arphaman committed rGa00944ebeab1: [clang] 'unused-but-set-variable' warning should not apply to __block objective… (authored by arphaman).
[clang] 'unused-but-set-variable' warning should not apply to __block objective…
Nov 5 2021, 7:48 AM
arphaman closed D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers.
Nov 5 2021, 7:48 AM · Restricted Project

Oct 29 2021

arphaman requested review of D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers.
Oct 29 2021, 3:15 PM · Restricted Project
arphaman committed rGa43d1aa85256: [clang] Make 'align-mismatch' warning work without an associated function… (authored by arphaman).
[clang] Make 'align-mismatch' warning work without an associated function…
Oct 29 2021, 1:39 PM
arphaman closed D109402: Make 'align-mismatch' warning work without an associated function declaration.
Oct 29 2021, 1:39 PM · Restricted Project

Oct 28 2021

arphaman accepted D112773: Allow __attribute__((swift_attr)) in attribute push pragmas.

Looks good to me. Can you post the patch with the full context next time so that it's easier to review?

Oct 28 2021, 6:48 PM · Restricted Project
arphaman committed rG3d0d7d8c5b66: [clang][driver][darwin] support -target with Mac Catalyst triple without OS… (authored by arphaman).
[clang][driver][darwin] support -target with Mac Catalyst triple without OS…
Oct 28 2021, 6:46 PM

Oct 20 2021

arphaman updated subscribers of D112189: [macho] add support for emitting macho files with two build version load commands.
Oct 20 2021, 3:37 PM · Restricted Project
arphaman requested review of D112189: [macho] add support for emitting macho files with two build version load commands.
Oct 20 2021, 3:33 PM · Restricted Project

Sep 20 2021

arphaman added inline comments to D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all.
Sep 20 2021, 12:13 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project