Page MenuHomePhabricator

arphaman (Alex Lorenz)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2014, 4:17 PM (247 w, 22 h)

Recent Activity

Yesterday

arphaman committed rG0b4364847dcd: Fix implicit ios -> watchOS availability version mapping for versions that have… (authored by arphaman).
Fix implicit ios -> watchOS availability version mapping for versions that have…
Wed, Mar 20, 1:03 PM
arphaman committed rC356605: Fix implicit ios -> watchOS availability version mapping for.
Fix implicit ios -> watchOS availability version mapping for
Wed, Mar 20, 1:03 PM
arphaman committed rL356605: Fix implicit ios -> watchOS availability version mapping for.
Fix implicit ios -> watchOS availability version mapping for
Wed, Mar 20, 1:03 PM

Fri, Feb 22

arphaman added a comment to D58559: emit '(assertions enabled)' in the version string for a build of clang with assertions enabled.

I like this. Can you start a discussion on cfe-dev (if you haven't already)? This is user-visible so I want to be sure other vendors are happy with this; if not, we can hide it behind a CMake flag.

Fri, Feb 22, 6:47 PM · Restricted Project
arphaman updated the diff for D58559: emit '(assertions enabled)' in the version string for a build of clang with assertions enabled.

Use "(+asserts)" as suggested.

Fri, Feb 22, 6:42 PM · Restricted Project
arphaman added a comment to D56924: Special case ObjCPropertyDecl for printing.

Please add a test that covers the '(class extension)' output as well.

Fri, Feb 22, 6:42 PM · Restricted Project
arphaman created D58559: emit '(assertions enabled)' in the version string for a build of clang with assertions enabled.
Fri, Feb 22, 4:05 PM · Restricted Project

Feb 14 2019

arphaman accepted D58213: [FileManager] fillRealPathName even if we aren't opening the file.

LGTM

Feb 14 2019, 1:24 PM · Restricted Project
arphaman added inline comments to D58213: [FileManager] fillRealPathName even if we aren't opening the file.
Feb 14 2019, 12:58 PM · Restricted Project
arphaman added inline comments to D58213: [FileManager] fillRealPathName even if we aren't opening the file.
Feb 14 2019, 12:56 PM · Restricted Project
arphaman added inline comments to D58213: [FileManager] fillRealPathName even if we aren't opening the file.
Feb 14 2019, 12:41 PM · Restricted Project

Feb 8 2019

arphaman accepted D57532: [Index] Make sure c-index-test finds libc++ on Mac.

LGTM.

Feb 8 2019, 7:03 PM · Restricted Project

Feb 4 2019

arphaman accepted D57712: [SemaObjC] Don't infer the availabilty of messages to +new from -init if the receiver has Class type.

LGTM, Thanks!

Feb 4 2019, 1:59 PM · Restricted Project

Feb 1 2019

arphaman added a comment to D57532: [Index] Make sure c-index-test finds libc++ on Mac.

@arphaman, thanks for pointing this out. It's definitely nice to change stuff only in one place.
There are two issues still pending:

  • index-file.cu still fails, I haven't looked into it closely yet, any idea why that might be happening?; repro is simple, just patch this in locally and run the test.
Feb 1 2019, 11:05 AM · Restricted Project

Jan 31 2019

arphaman requested changes to D57532: [Index] Make sure c-index-test finds libc++ on Mac.

The real problem is that clang_parseTranslationUnit2 is broken, so this just fixes one client, c-index-test. All other macOS clients that call that function will still be unable to find the libc++ headers.

Jan 31 2019, 1:42 PM · Restricted Project
arphaman accepted D57345: Make clang/test/Index/pch-from-libclang.c pass in more places.

LGTM

Jan 31 2019, 1:30 PM · Restricted Project
arphaman requested changes to D56924: Special case ObjCPropertyDecl for printing.

Do you know if this have an effect on the output of completion results or other tooling-based output?

Jan 31 2019, 1:06 PM · Restricted Project
arphaman added a comment to D57345: Make clang/test/Index/pch-from-libclang.c pass in more places.

Yes, that should work.

Jan 31 2019, 12:39 PM · Restricted Project
arphaman requested changes to D57345: Make clang/test/Index/pch-from-libclang.c pass in more places.
Jan 31 2019, 10:30 AM · Restricted Project
arphaman accepted D57345: Make clang/test/Index/pch-from-libclang.c pass in more places.

Makes sense. The comments aren't really enforceable though, can we just factor this out into one function in lib/Basic that can be shared between all sites? It seems like there's nothing that would prevent that.

Jan 31 2019, 10:29 AM · Restricted Project

Jan 30 2019

arphaman added a comment to D52339: Support enums with a fixed underlying type in all language modes.

We could introduce a new extension flag like c_fixed_enum that can be set for all language modes. objc_fixed_enum should apply to ObjC only.

Jan 30 2019, 11:24 AM
arphaman added a comment to D52339: Support enums with a fixed underlying type in all language modes.

@erik.pilkington the change to make objc_fixed_enum true in non-ObjC mode turned out to be problematic for our adoption. Could you please fix it before LLVM8 is wrapped up so that we don't ship this extension as on by default for all language modes?

Jan 30 2019, 11:18 AM
arphaman added a comment to D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend.
In D55673#1377404, @tra wrote:

Would that be OK to use target_sdk_version to pass *CUDA* SDK version to the CC1 compilations?
I have upcoming changes that need to know the version to generate correct glue IR for CUDA. The driver currently figures out detected CUDA version in lib/Driver/ToolChains/Cuda.cpp and I could use -target-sdk-version to pass it on to CC1 instances.

On one hand CUDA is a target SDK and the option appears to be accessible exactly where I need it. On the other hand, my use case is not *exactly* the case -target-sdk-version was intended for (i.e. it's not darwin and it has nothing to do with module metadata, though it *may* be eventually useful there even for CUDA).

If using the option for CUDA sounds like too much of a hack, I guess I can add a separate -cuda-sdk-version=, though it would effectively replicate some of this patch.

Opinions?

Jan 30 2019, 10:49 AM

Jan 24 2019

arphaman committed rL352125: [clang-format] square parens with one token are not Objective-C message sends.
[clang-format] square parens with one token are not Objective-C message sends
Jan 24 2019, 3:10 PM
arphaman committed rC352125: [clang-format] square parens with one token are not Objective-C message sends.
[clang-format] square parens with one token are not Objective-C message sends
Jan 24 2019, 3:09 PM
arphaman closed D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends.
Jan 24 2019, 3:09 PM
arphaman updated the diff for D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends.

Update for Ben's comments.

Jan 24 2019, 12:47 PM
arphaman committed rC352084: Add a priority field to availability attributes to prioritize explicit.
Add a priority field to availability attributes to prioritize explicit
Jan 24 2019, 11:15 AM
arphaman committed rL352084: Add a priority field to availability attributes to prioritize explicit.
Add a priority field to availability attributes to prioritize explicit
Jan 24 2019, 11:15 AM
arphaman closed D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'.
Jan 24 2019, 11:15 AM

Jan 18 2019

arphaman added a comment to D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'.

I think the documentation for the attribute should be updated to explain this new behavior, otherwise this will be a very inexplicable feature to users.

Jan 18 2019, 2:27 PM
arphaman updated the diff for D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'.
  • Add documentation and expand a comment as suggested by Aaron.
  • Address Erik's comments.
Jan 18 2019, 2:24 PM

Jan 17 2019

arphaman updated the diff for D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'.

Reverse the priority numbering direction as suggested by @dexonsmith .

Jan 17 2019, 6:48 PM
arphaman created D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'.
Jan 17 2019, 6:40 PM
arphaman committed rL351459: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are.
[ObjC] Follow-up r350768 and allow the use of unavailable methods that are
Jan 17 2019, 10:16 AM
arphaman committed rC351459: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are.
[ObjC] Follow-up r350768 and allow the use of unavailable methods that are
Jan 17 2019, 10:16 AM
arphaman closed D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context.
Jan 17 2019, 10:16 AM

Jan 16 2019

arphaman updated the diff for D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context.

Follow Erik's suggestion and don't check for definition/declaration in parent class.

Jan 16 2019, 4:58 PM
arphaman created D56816: [ObjC] Follow-up r350768 and allow the use of unavailable methods that are declared in a parent class from within the @implementation context.
Jan 16 2019, 3:16 PM
arphaman accepted D56766: [Frontend] Make WrapperFrontendAction call WrappedAction.PrepareToExecuteAction..

That LGTM.

Jan 16 2019, 2:35 PM

Jan 15 2019

arphaman accepted D54428: [clangd] XPC transport layer, framework, test-client.

LGTM

Jan 15 2019, 11:20 AM

Jan 14 2019

arphaman accepted D56523: Improve a -Wunguarded-availability note.

LGTM

Jan 14 2019, 11:00 AM

Jan 11 2019

arphaman accepted D56608: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO.

LGTM

Jan 11 2019, 11:29 AM
arphaman added inline comments to D56608: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO.
Jan 11 2019, 10:57 AM

Jan 9 2019

arphaman committed rL350768: [ObjC] Allow the use of implemented unavailable methods from within.
[ObjC] Allow the use of implemented unavailable methods from within
Jan 9 2019, 2:35 PM
arphaman committed rC350768: [ObjC] Allow the use of implemented unavailable methods from within.
[ObjC] Allow the use of implemented unavailable methods from within
Jan 9 2019, 2:35 PM
arphaman closed D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context .
Jan 9 2019, 2:35 PM
arphaman updated the diff for D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context .

Address review comments.

Jan 9 2019, 12:24 PM
arphaman added inline comments to D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context .
Jan 9 2019, 11:00 AM

Jan 8 2019

arphaman created D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context .
Jan 8 2019, 6:08 PM
arphaman committed rC350680: [libclang] Fix the mismatched delete operator for ExprEvalResult.
[libclang] Fix the mismatched delete operator for ExprEvalResult
Jan 8 2019, 3:32 PM
arphaman committed rL350680: [libclang] Fix the mismatched delete operator for ExprEvalResult.
[libclang] Fix the mismatched delete operator for ExprEvalResult
Jan 8 2019, 3:32 PM
arphaman committed rC350666: [libclang] Recommit r336590 with a fix for the memory leak in the test.
[libclang] Recommit r336590 with a fix for the memory leak in the test
Jan 8 2019, 2:36 PM
arphaman committed rL350666: [libclang] Recommit r336590 with a fix for the memory leak in the test.
[libclang] Recommit r336590 with a fix for the memory leak in the test
Jan 8 2019, 2:36 PM
arphaman accepted D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang.

That makes sense, LGTM. Thanks!

Jan 8 2019, 10:33 AM

Jan 3 2019

arphaman updated the diff for D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends.

Do not annotate one token [ .... ] expressions as Objective-C message sends as suggested by Duncan.

Jan 3 2019, 11:24 AM

Jan 2 2019

arphaman committed rL350283: Fix incorrect column numbers in test from r350282..
Fix incorrect column numbers in test from r350282.
Jan 2 2019, 5:34 PM
arphaman committed rC350283: Fix incorrect column numbers in test from r350282..
Fix incorrect column numbers in test from r350282.
Jan 2 2019, 5:34 PM
arphaman committed rL350282: [libclang] CoroutineBody/Coreturn statements are UnexposedStmts and not Exprs.
[libclang] CoroutineBody/Coreturn statements are UnexposedStmts and not Exprs
Jan 2 2019, 5:17 PM
arphaman committed rC350282: [libclang] CoroutineBody/Coreturn statements are UnexposedStmts and not Exprs.
[libclang] CoroutineBody/Coreturn statements are UnexposedStmts and not Exprs
Jan 2 2019, 5:17 PM
arphaman created D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends.
Jan 2 2019, 3:24 PM
arphaman accepted D56067: Make test/Driver/darwin-sdk-version.c pass if the host triple is 32-bit.

LGTM

Jan 2 2019, 1:23 PM

Dec 21 2018

arphaman committed rC349942: Remove stat cache chaining as it's no longer needed after PTH support has been.
Remove stat cache chaining as it's no longer needed after PTH support has been
Dec 21 2018, 11:36 AM
arphaman committed rL349942: Remove stat cache chaining as it's no longer needed after PTH support has been.
Remove stat cache chaining as it's no longer needed after PTH support has been
Dec 21 2018, 11:36 AM
arphaman closed D55455: Remove stat cache chaining as it's no longer needed after PTH support has been removed.
Dec 21 2018, 11:36 AM

Dec 20 2018

arphaman added a comment to D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'.

I think Args.getArgString might return nullptr so that's why you could crash.

Dec 20 2018, 3:36 PM
arphaman committed rL349841: [ObjC] Messages to 'self' in class methods that return 'instancetype' should.
[ObjC] Messages to 'self' in class methods that return 'instancetype' should
Dec 20 2018, 2:14 PM
arphaman committed rC349841: [ObjC] Messages to 'self' in class methods that return 'instancetype' should.
[ObjC] Messages to 'self' in class methods that return 'instancetype' should
Dec 20 2018, 2:14 PM
arphaman closed D36790: [ObjC] Messages to 'self' in class methods that return 'instancetype' should use the pointer to the class as the result type of the message.
Dec 20 2018, 2:14 PM
arphaman added a comment to D36790: [ObjC] Messages to 'self' in class methods that return 'instancetype' should use the pointer to the class as the result type of the message.

Fixed comment, will commit.

Dec 20 2018, 2:14 PM

Dec 19 2018

arphaman added a comment to D55895: NFC: simplify Darwin environment handling.

I think we might need to run it past the internal builds to see if anything breaks.

Dec 19 2018, 1:21 PM · Restricted Project

Dec 17 2018

arphaman committed rL349393: Make test/Driver/darwin-sdk-version.c pass on hosts < macOS10.14.
Make test/Driver/darwin-sdk-version.c pass on hosts < macOS10.14
Dec 17 2018, 1:04 PM
arphaman committed rC349393: Make test/Driver/darwin-sdk-version.c pass on hosts < macOS10.14.
Make test/Driver/darwin-sdk-version.c pass on hosts < macOS10.14
Dec 17 2018, 1:04 PM
arphaman committed rC349388: Fix build after r349380.
Fix build after r349380
Dec 17 2018, 12:29 PM
arphaman committed rL349388: Fix build after r349380.
Fix build after r349380
Dec 17 2018, 12:28 PM
arphaman committed rL349382: [darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch`.
[darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch`
Dec 17 2018, 11:34 AM
arphaman committed rC349382: [darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch`.
[darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch`
Dec 17 2018, 11:34 AM
arphaman closed D55731: [darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch` is not specified.
Dec 17 2018, 11:33 AM
arphaman accepted D55775: [Driver] Don't override '-march' when using '-arch x86_64h'.

LGTM

Dec 17 2018, 11:25 AM
arphaman committed rC349380: [darwin] parse the SDK settings from SDKSettings.json if it exists and.
[darwin] parse the SDK settings from SDKSettings.json if it exists and
Dec 17 2018, 11:22 AM
arphaman committed rL349380: [darwin] parse the SDK settings from SDKSettings.json if it exists and.
[darwin] parse the SDK settings from SDKSettings.json if it exists and
Dec 17 2018, 11:22 AM
arphaman closed D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend.
Dec 17 2018, 11:22 AM
arphaman added inline comments to D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend.
Dec 17 2018, 10:33 AM

Dec 14 2018

arphaman created D55731: [darwin][arm64] use the "cyclone" CPU for Darwin even when `-arch` is not specified.
Dec 14 2018, 6:45 PM
arphaman updated the diff for D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend.

Ensure test will pass on non-darwin.

Dec 14 2018, 3:48 PM
arphaman added inline comments to D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend.
Dec 14 2018, 3:42 PM
arphaman updated the diff for D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend.

Updated to infer deployment target version from SDK versions specified in the JSON file and to allow inferring the SDK version from the SDK path.

Dec 14 2018, 3:42 PM

Dec 13 2018

arphaman committed rL349119: [macho] save the SDK version stored in module metadata into the version min and.
[macho] save the SDK version stored in module metadata into the version min and
Dec 13 2018, 5:17 PM
arphaman closed D55612: [macho] save the SDK version stored in module metadata into the version min and build version load commands in the object file.
Dec 13 2018, 5:17 PM
arphaman added inline comments to D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend.
Dec 13 2018, 2:50 PM
arphaman added inline comments to D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend.
Dec 13 2018, 2:49 PM
arphaman created D55673: [darwin] parse the SDK settings from SDKSettings.json if it exists and pass in the -target-sdk-version to the compiler and backend.
Dec 13 2018, 2:15 PM

Dec 12 2018

arphaman added a comment to D55612: [macho] save the SDK version stored in module metadata into the version min and build version load commands in the object file.

Don't we need IR support for this as well? sdk version is not in the triple so it is going to get lost when building from IR. Maybe use a metadata node?

Dec 12 2018, 3:11 PM
arphaman added a reviewer for D55612: [macho] save the SDK version stored in module metadata into the version min and build version load commands in the object file: ab.
Dec 12 2018, 1:27 PM
arphaman created D55612: [macho] save the SDK version stored in module metadata into the version min and build version load commands in the object file.
Dec 12 2018, 1:11 PM

Dec 11 2018

arphaman added a comment to D55544: Warning: objc-encodings-larger-than=.

Thanks for working on this! Could you please post a patch with full context (git diff -U9999)?

Dec 11 2018, 11:03 AM · Restricted Project
arphaman added reviewers for D55544: Warning: objc-encodings-larger-than=: ahatanak, rjmccall, erik.pilkington.
Dec 11 2018, 11:01 AM · Restricted Project

Dec 7 2018

arphaman added a comment to D55455: Remove stat cache chaining as it's no longer needed after PTH support has been removed.

This patch LGTM, but before committing I suggest sending an RFC to cfe-dev and waiting a few days.

Dec 7 2018, 4:54 PM
arphaman created D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation.
Dec 7 2018, 4:38 PM
arphaman created D55455: Remove stat cache chaining as it's no longer needed after PTH support has been removed.
Dec 7 2018, 1:11 PM