Page MenuHomePhabricator

dim (Dimitry Andric)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 15 2014, 12:19 PM (429 w, 1 d)

Recent Activity

Sun, Jul 3

dim added a comment to D123177: [libomptarget] Add device RTL to regression test dependencies..

This fails to configure in cmake when enabled as a project.

$ cmake ../llvm -DLLVM_ENABLE_PROJECTS='llvm;clang;lld;openmp'
...
-- Configuring done
CMake Error at /home/bed22/git/llvm-project/openmp/libomptarget/plugins/amdgpu/CMakeLists.txt:74 (add_dependencies):
  The dependency target "omptarget.devicertl.amdgpu" of target
  "omptarget.rtl.amdgpu" does not exist.


-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.

Reverting this commit allows cmake to succeed. The linkage fix in rG2e0cb61570ec does not fix this issue.

Sun, Jul 3, 7:27 AM · Restricted Project, Restricted Project

Sat, Jun 18

dim added a comment to D124118: [Peephole-Opt][X86] Enhance peephole opt to see through SUBREG_TO_REG (following AND) and eliminates redundant TEST instruction..

FYI https://github.com/llvm/llvm-project/issues/56103

Sat, Jun 18, 4:23 AM · Restricted Project, Restricted Project

Jun 4 2022

dim added a comment to D126882: [libc++] Do not yield from __sp_mut::lock().

To answer my own question partially, the original commit is Howard's: rG088e37c77aafaec5ead8fbe7ebf918265e6b86f2:

Despite my pathological distrust of spin locks, the number just don't lie. I've put a small spin in __sp_mut::lock() on std::mutex::try_lock(), which is testing quite well. In my experience, putting in a yield for every failed iteration is also a major performance booster. This change makes one of the performance tests I was using (a highly contended one) run about 20 times faster.

Jun 4 2022, 7:45 AM · Restricted Project, Restricted Project
dim added a comment to D126882: [libc++] Do not yield from __sp_mut::lock().

This patch was put together in collaboration with a performance engineer on our side. It was tested with a use case that was previously problematic and this patch did solve the issue. We believe this should be an improvement for all OSes if their pthread_mutex_lock is reasonable (which is the case on Linux and Apple at least)

Jun 4 2022, 7:41 AM · Restricted Project, Restricted Project

May 31 2022

dim added a comment to D126462: [libc++] Re-enable std::pair trivial copy constructor for FreeBSD >= 14.

In any case it would be nice if it was possible to decide whether ABIv2 will be pinned down (and ABIv3 is made into the 'new' unstable) before 15.0 is branched. :-)

May 31 2022, 11:04 AM · Restricted Project, Restricted Project

May 26 2022

dim added a comment to D126462: [libc++] Re-enable std::pair trivial copy constructor for FreeBSD >= 14.

...

But for 14.0, which is our trunk/main/head, there is no such ABI promise, therefore we can simply bump libc++.so to .2 now and fix the issue that way. If the upstream libc++ ABI version gets bumped to 2 though, we'll have to bump our .so to .3 I'm afraid, since the ELF soversion doesn't really allow "half-sized" version numbers.

Do you have to bump the version now or would it be possible for you to wait maybe one or two months so we can get things sorted out upstream?

May 26 2022, 11:45 AM · Restricted Project, Restricted Project
dim added a comment to D126462: [libc++] Re-enable std::pair trivial copy constructor for FreeBSD >= 14.

Sounds good to me. We can bump the .so version in the base system, but how do we treat it upstream (i.e., here in llvm) and in the ports tree?

Would it make sense from your side to to declare ABIv2 stable?

May 26 2022, 9:23 AM · Restricted Project, Restricted Project
dim requested review of D126462: [libc++] Re-enable std::pair trivial copy constructor for FreeBSD >= 14.
May 26 2022, 6:47 AM · Restricted Project, Restricted Project
dim added a comment to D125611: DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs.

Thanks a lot. I'll make sure to put up a libc++ review now to get rid of the FreeBSD std::pair problem in the future! :)

May 26 2022, 5:37 AM · Restricted Project, Restricted Project

May 23 2022

dim added a comment to D125899: [ADT] Add copy constructor to IntervalMap.

Will this fix FreeBSD 12 (and maybe 11?). FreeBSD 12 is still very much supported.

May 23 2022, 7:16 AM · Restricted Project, Restricted Project

May 21 2022

dim added a comment to D125899: [ADT] Add copy constructor to IntervalMap.

...

There's a subtle difference between the two std::vector constructors, mentioned at https://en.cppreference.com/w/cpp/container/vector/vector, where variant 3 is "Constructs the container with count copies of elements with value value" (so it needs a copy constructor), and variant 4 is "Constructs the container with count default-inserted instances of T. No copies are made". E.g. the latter should not require a copy constructor, but just a default constructor.

May 21 2022, 3:36 AM · Restricted Project, Restricted Project
dim added a comment to D125899: [ADT] Add copy constructor to IntervalMap.

Changed the copy to a deep one.

Ah, if the type wasn't deep copying before - ie: its default copy operation wasn't actually valid/probably would've resulted in duplicate free/delete/etc and generally been broken. Then my use case was just getting lucky because it was copying empty maps.

If that's the case, then maybe that does argue in favor of the unique_ptr solution/marking the broken copy ctor as deleted. (or figuring out some way to do the construction in-place in my case without using copying)

I'll take a closer look.

May 21 2022, 2:27 AM · Restricted Project, Restricted Project

May 17 2022

dim added a comment to D125611: DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs.

...

Ultimately, this is caused by _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR in /usr/include/c++/v1/__config (this was last modified by @EricWF, but a long time ago). If this setting is enabled (to preserve the old ABI), std::pair will always have a non-trivial copy constructor, and since IntervalMap contains a std::pair (via RootLeaf -> IntervalMapImpl::LeafNode -> NodeBase<std::pair<KeyT, KeyT>, ValT, N>), IntervalMap itself is also non-trivially copyable. std::vector in turn requires its value type to be copy-constructible (at least certainly when you use the constructor with a size).

I was hoping something I could reproduce without having FreeBSD myself - either on godbolt (though godbolt might not have different OS platforms as a primary feature) or something like that. Or a brief example that emulates the quirk of FreeBSD to better understand what we're working around here.

May 17 2022, 2:26 PM · Restricted Project, Restricted Project
dim accepted D125746: [PowerPC] Treat llvm.fmuladd intrinsic as using CTR.

I can confirm that this fixes both my original full test case, and the minimized variant. Since this change resembles D78668, I think it is relatively safe to apply now, and merge to the release/14.x branch?

May 17 2022, 11:16 AM · Restricted Project, Restricted Project
dim updated subscribers of D125611: DWARFVerifier: Change vector of IntervalMap to vector of unique_ptrs.

Some more details on the specifics in the patch description would be good - I'm still not 100% clear on the reproduction case to understand what we're working around, exactly. Do you have a godbolt reproduction/small example, by chance?

May 17 2022, 8:58 AM · Restricted Project, Restricted Project

May 15 2022

dim abandoned D123427: Reset _unwindInfoMissing when info is found eventually.
May 15 2022, 12:47 AM · Restricted Project, Restricted Project, Restricted Project

May 12 2022

dim added a comment to rG0d8cb8b399ad: DWARFVerifier: Verify CU/TU index overlap issues.

Cross-reference: https://github.com/llvm/llvm-project/issues/55414

May 12 2022, 3:31 PM · Restricted Project, Restricted Project
dim updated subscribers of rG0d8cb8b399ad: DWARFVerifier: Verify CU/TU index overlap issues.

This fails to compile:

$ /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/w/bld/org/lib/DebugInfo/DWARF -I/w/src/llvm.org/llvm/lib/DebugInfo/DWARF -I/w/bld/org/include -I/w/src/llvm.org/llvm/include -I/usr/local/include -stdlib=libc++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -c /w/src/llvm.org/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
In file included from /w/src/llvm.org/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:8:
In file included from /w/src/llvm.org/llvm/include/llvm/DebugInfo/DWARF/DWARFVerifier.h:12:
In file included from /w/src/llvm.org/llvm/include/llvm/ADT/Optional.h:19:
In file included from /w/src/llvm.org/llvm/include/llvm/ADT/Hashing.h:51:
In file included from /usr/include/c++/v1/algorithm:653:
In file included from /usr/include/c++/v1/functional:500:
In file included from /usr/include/c++/v1/__functional/function.h:20:
In file included from /usr/include/c++/v1/__memory/shared_ptr.h:22:
/usr/include/c++/v1/__memory/allocator.h:154:28: error: call to implicitly-deleted copy constructor of 'llvm::IntervalMap<unsigned int, unsigned long, 12>'
        ::new ((void*)__p) _Up(_VSTD::forward<_Args>(__args)...);
                           ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/v1/__memory/allocator_traits.h:290:13: note: in instantiation of function template specialization 'std::allocator<llvm::IntervalMap<unsigned int, unsigned long, 12>>::construct<llvm::IntervalMap<unsigned int, unsigned long, 12>, const llvm::IntervalMap<unsigned int, unsigned long, 12> &>' requested here
        __a.construct(__p, _VSTD::forward<_Args>(__args)...);
            ^
/usr/include/c++/v1/vector:1085:25: note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<llvm::IntervalMap<unsigned int, unsigned long, 12>>>::construct<llvm::IntervalMap<unsigned int, unsigned long, 12>, const llvm::IntervalMap<unsigned int, unsigned long, 12> &, void>' requested here
        __alloc_traits::construct(this->__alloc(), _VSTD::__to_address(__pos), __x);
                        ^
/usr/include/c++/v1/vector:1178:9: note: in instantiation of member function 'std::vector<llvm::IntervalMap<unsigned int, unsigned long, 12>>::__construct_at_end' requested here
        __construct_at_end(__n, __x);
        ^
/w/src/llvm.org/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp:410:48: note: in instantiation of member function 'std::vector<llvm::IntervalMap<unsigned int, unsigned long, 12>>::vector' requested here
  std::vector<IntervalMap<uint32_t, uint64_t>> Sections(
                                               ^
/w/src/llvm.org/llvm/include/llvm/ADT/IntervalMap.h:970:14: note: copy constructor of 'IntervalMap<unsigned int, unsigned long, 12>' is implicitly deleted because variant field 'leaf' has a non-trivial copy constructor
    RootLeaf leaf;
             ^
1 error generated.

What standard library is in use here? I believe it's non-conformant (& since lots of other buildbots haven't failed on this, that seems likely), possibly outdated.

LLVM requires C++14 and C++14 provides a std::vector constructor that takes a count (& not a default value) and default constructs the elements in-place without copying a singular default value.

May 12 2022, 1:25 AM · Restricted Project, Restricted Project

Apr 29 2022

dim committed rG7abfaa0a815a: [lldb] Define LLDB_VERSION_PATCH correctly (authored by dim).
[lldb] Define LLDB_VERSION_PATCH correctly
Apr 29 2022, 10:31 AM · Restricted Project, Restricted Project
dim closed D124672: [lldb] Define LLDB_VERSION_PATCH correctly.
Apr 29 2022, 10:31 AM · Restricted Project, Restricted Project, Restricted Project
dim updated the diff for D124672: [lldb] Define LLDB_VERSION_PATCH correctly.

Add llvm/utils/gn/secondary/lldb/include/lldb/Version/BUILD.gn while we're here.

Apr 29 2022, 10:29 AM · Restricted Project, Restricted Project, Restricted Project
dim requested review of D124672: [lldb] Define LLDB_VERSION_PATCH correctly.
Apr 29 2022, 6:25 AM · Restricted Project, Restricted Project, Restricted Project

Apr 8 2022

dim updated subscribers of D123427: Reset _unwindInfoMissing when info is found eventually.
Apr 8 2022, 4:01 PM · Restricted Project, Restricted Project, Restricted Project
dim accepted D122628: [libcxx] random_device, use arc4random() on FreeBSD, NetBSD and DragonFlyBSD.

Sure, LGTM.

Apr 8 2022, 4:01 PM · Restricted Project, Restricted Project
dim requested review of D123427: Reset _unwindInfoMissing when info is found eventually.
Apr 8 2022, 3:51 PM · Restricted Project, Restricted Project, Restricted Project

Apr 7 2022

Herald added a project to D118809: [libc++] Define `namespace views` in its own detail header.: Restricted Project.

It's a pity this one didn't make it into 14.0.0, as you now can't even include <ranges> without immediately getting an error:

Apr 7 2022, 12:33 PM · Restricted Project, Restricted Project

Mar 27 2022

dim committed rG1a6d571174f8: [Support] Skip attempts to access /proc/self/fd on FreeBSD (authored by mjguzik).
[Support] Skip attempts to access /proc/self/fd on FreeBSD
Mar 27 2022, 11:20 AM · Restricted Project, Restricted Project
dim closed D122545: Skip attempts to access /proc/self/fd on FreeBSD.
Mar 27 2022, 11:20 AM · Restricted Project, Restricted Project
dim accepted D122545: Skip attempts to access /proc/self/fd on FreeBSD.
Mar 27 2022, 10:04 AM · Restricted Project, Restricted Project
dim added a reviewer for D122545: Skip attempts to access /proc/self/fd on FreeBSD: emaste.
Mar 27 2022, 9:50 AM · Restricted Project, Restricted Project

Mar 15 2022

dim committed rG7ab1ab0db401: [libc++] Make __dir_stream visibility declaration consistent (authored by dim).
[libc++] Make __dir_stream visibility declaration consistent
Mar 15 2022, 11:31 AM · Restricted Project
dim closed D121639: [libc++] Make __dir_stream visibility declaration consistent.
Mar 15 2022, 11:31 AM · Restricted Project, Restricted Project

Mar 14 2022

dim updated the summary of D121639: [libc++] Make __dir_stream visibility declaration consistent.
Mar 14 2022, 2:10 PM · Restricted Project, Restricted Project
dim requested review of D121639: [libc++] Make __dir_stream visibility declaration consistent.
Mar 14 2022, 2:08 PM · Restricted Project, Restricted Project

Mar 1 2022

dim updated subscribers of D119969: [libc++] Unconditionally provide the ability for users to enable assertions.

Running readelf shows following in our shipping shared libs.

 231: 00000000000c7db0     8 OBJECT  GLOBAL DEFAULT   23 _ZNSt3__123__libcpp_debug_functionE
 668: 0000000000075160    13 FUNC    GLOBAL DEFAULT   14 _ZNSt3__127__libcpp_set_debug_functionEPFvRKNS_19__libcpp_debug_infoEE
1438: 0000000000075110    79 FUNC    GLOBAL DEFAULT   14 _ZNSt3__129__libcpp_abort_debug_functionERKNS_19__libcpp_debug_infoE
1979: 0000000000074ef0   544 FUNC    GLOBAL DEFAULT   14 _ZNKSt3__119__libcpp_debug_info4whatEv

Okay, right -- so as expected, you've been shipping support for the debug mode as part of the dylib, and if any user has been enabling assertions with _LIBCPP_DEBUG=0, they are relying on those symbols. So I think my proposed direction stands (it's this patch as-is). It's not the most elegant design since we're reusing old __libcpp_debug_foo for assertions, but I think it's the best decision engineering-wise for the time being.

Mar 1 2022, 7:35 AM · Restricted Project, Restricted Project

Feb 21 2022

dim accepted D116867: [PowerPC] Fix sanitizers build on FreeBSD.

I can't vouch for any of the PowerPC specific stuff, but I would like to get it into FreeBSD if at all possible. :)

Feb 21 2022, 5:57 AM · Restricted Project, Restricted Project

Feb 12 2022

dim added a reverting change for rG5ebdb07e7eb3: [RISCV] Enable shrink wrap by default: rG7af3d4ab3d5d: Revert "[RISCV] Enable shrink wrap by default".
Feb 12 2022, 10:07 AM
dim committed rG7af3d4ab3d5d: Revert "[RISCV] Enable shrink wrap by default" (authored by dim).
Revert "[RISCV] Enable shrink wrap by default"
Feb 12 2022, 10:06 AM
dim added a reverting change for D109037: [RISCV] Enable shrink wrap by default: rG7af3d4ab3d5d: Revert "[RISCV] Enable shrink wrap by default".
Feb 12 2022, 10:06 AM · Restricted Project
dim requested review of D119624: [PowerPC] Avoid generating 128-bit __multi3() and __muloti4() on 32-bit.
Feb 12 2022, 2:25 AM · Restricted Project

Feb 11 2022

dim committed rGa9f1a9c00af3: [compiler-rt] Force ABI to libcxxabi when building cxustom libc++ (authored by dim).
[compiler-rt] Force ABI to libcxxabi when building cxustom libc++
Feb 11 2022, 1:14 PM
dim closed D119554: [compiler-rt] Force ABI to libcxxabi when building cxustom libc++.
Feb 11 2022, 1:14 PM · Restricted Project
dim added inline comments to D119554: [compiler-rt] Force ABI to libcxxabi when building cxustom libc++.
Feb 11 2022, 1:10 PM · Restricted Project
dim requested review of D119554: [compiler-rt] Force ABI to libcxxabi when building cxustom libc++.
Feb 11 2022, 9:09 AM · Restricted Project

Feb 9 2022

dim added a comment to D118733: [libc++] Remove the std::string base class.

FWIW, this breaks compilation of Firefox:

Feb 9 2022, 6:33 AM · Restricted Project

Feb 8 2022

dim accepted D119255: [runtimes] Remove support for standalone builds.

LGTM (@emaste I've never used the standalone build, always as part of the 'full monty' all llvm components)

Feb 8 2022, 12:40 PM · Restricted Project, Restricted Project, Restricted Project
dim updated subscribers of D119246: [libcxx][AIX][PowerPC] Disable workaround for PR31864 on powerpc.

Hm @pkubaj do you remember if this is needed for 32-bit PowerPC on FreeBSD? I can't remember...

Feb 8 2022, 7:59 AM · Restricted Project, Restricted Project

Feb 7 2022

dim accepted D119137: Replace Steve Klabnik with Josh Stone as one of the Rust Security Response WG representatives.

In any case, LGTM for this review itself of course.

Feb 7 2022, 10:23 AM · Restricted Project, Restricted Project
dim added a comment to D119137: Replace Steve Klabnik with Josh Stone as one of the Rust Security Response WG representatives.

Having said that, if this document is supposed to be published on GitHub, and read by people primarily via GitHub, I suppose it would make sense to change all the mentioned usernames to GitHub usernames instead of Phabricator usernames?

Feb 7 2022, 10:22 AM · Restricted Project, Restricted Project
dim added a comment to D119137: Replace Steve Klabnik with Josh Stone as one of the Rust Security Response WG representatives.

Note: andykaylor is Andy's GitHub username: https://github.com/andykaylor
and similarly, smaslov-intel is Sergey's: https://github.com/smaslov-intel

Feb 7 2022, 10:20 AM · Restricted Project, Restricted Project
dim updated subscribers of D119137: Replace Steve Klabnik with Josh Stone as one of the Rust Security Response WG representatives.

As far as I know:
Andy Kaylor = @andrew.w.kaylor
Sergey Maslov = @smaslov

Feb 7 2022, 7:16 AM · Restricted Project, Restricted Project
dim committed rG28fb22c90fe7: [TSan] Handle FreeBSD specific indirection of libpthread functions (authored by dim).
[TSan] Handle FreeBSD specific indirection of libpthread functions
Feb 7 2022, 2:02 AM
dim closed D119034: [TSan] Handle FreeBSD specific indirection of libpthread functions.
Feb 7 2022, 2:02 AM · Restricted Project

Feb 5 2022

dim updated the diff for D119034: [TSan] Handle FreeBSD specific indirection of libpthread functions.

Address review comments.

Feb 5 2022, 7:36 AM · Restricted Project

Feb 4 2022

dim requested review of D119034: [TSan] Handle FreeBSD specific indirection of libpthread functions.
Feb 4 2022, 12:56 PM · Restricted Project

Jan 27 2022

dim added a comment to D102707: Fix non-global-value-max-name-size not considered by LLParser.

Your profile shows a great amount of maps lookup though. It can be that the map size exploded for some reason or that we query it much more?

Jan 27 2022, 12:23 PM · Restricted Project

Jan 25 2022

dim added a comment to D102707: Fix non-global-value-max-name-size not considered by LLParser.

The creduce run is almost finished, I'll go create a ticket now.

Jan 25 2022, 9:59 AM · Restricted Project
dim added a comment to D102707: Fix non-global-value-max-name-size not considered by LLParser.

The top 10 list from perf report output shows that it's doing quite a lot of StringMapImpl work:

Jan 25 2022, 8:56 AM · Restricted Project

Jan 24 2022

dim added a comment to D102707: Fix non-global-value-max-name-size not considered by LLParser.

For some reason, this commit causes a huge memory usage, and extreme slowdown, when compiling the FreeBSD port math/openturns (https://github.com/openturns/openturns) port; see https://bugs.freebsd.org/261341.

With llvmorg-13-init-11364-g0ce58c52d50 (i.e. just before this commit):?
...
I had to terminate the clang process after ~9 minutes, as it was using >115GiB virtual memory, and this was a bit of a risk to crash the (shared) machine I was working on.

Any ideas, before I attempt reducing the ~196,000 line test case? :)

This is pretty bad... Can you clarify if your clang is built with assertions or in release mode?

Jan 24 2022, 3:09 PM · Restricted Project
dim added a comment to D102707: Fix non-global-value-max-name-size not considered by LLParser.

For some reason, this commit causes a huge memory usage, and extreme slowdown, when compiling the FreeBSD port math/openturns (https://github.com/openturns/openturns) port; see https://bugs.freebsd.org/261341.

Jan 24 2022, 12:41 PM · Restricted Project

Jan 21 2022

dim added a comment to D117811: [libc++] Make _VSTD and alias for std.

The build failure looks to me like a gcc bug. Can anybody confirm this? Or is it implementation divergence?

Jan 21 2022, 3:43 PM · Restricted Project

Jan 20 2022

dim added a comment to D117811: [libc++] Make _VSTD and alias for std.

How do you mean "no practical difference"? _VSTD is defined as std::_LIBCPP_ABI_NAMESPACE, and in turn, _LIBCPP_ABI_NAMESPACE is configurable by the user, or defaults to mangling the ABI version in it. So this would be a huge change, for unknown benefit?

Jan 20 2022, 11:18 AM · Restricted Project

Jan 16 2022

dim accepted D117388: [Driver][FreeBSD] -r: imply -nostdlib like GCC.

LGTM, thanks!

Jan 16 2022, 10:21 AM · Restricted Project

Jan 11 2022

dim committed rG593b4d7a1c26: [Nomination] Adding Intel representatives to security group (authored by dim).
[Nomination] Adding Intel representatives to security group
Jan 11 2022, 8:31 AM
dim closed D115657: [Nomination] Adding Intel representatives to security group.
Jan 11 2022, 8:31 AM · Restricted Project
dim accepted D115657: [Nomination] Adding Intel representatives to security group.

LGTM too. I will commit this now.

Jan 11 2022, 8:28 AM · Restricted Project

Jan 3 2022

dim updated subscribers of D68480: Implementation of C++20's P1135R6 for libcxx.

Also, on a different note: I'm pretty serious about FreeBSD needing to implement pre-commit CI if it wants to be supported officially. It's a small investment, but it needs to happen for libc++ to keep FreeBSD as part of its list of supported platforms. @dim can you help with this?

Jan 3 2022, 2:47 PM · Restricted Project

Dec 23 2021

dim added a comment to D107476: [ARM] Define ComplexPatternFuncMutatesDAG.

Okay, in my case the test case is quite a bit shorter:

Dec 23 2021, 12:14 PM · Restricted Project
dim updated subscribers of D107476: [ARM] Define ComplexPatternFuncMutatesDAG.

David, in this particular change, does "valid and handled successfully" mean "not crash or assert"? I just ran into the following assertion when building part of llvm (13.0.0) itself under FreeBSD 12:

Dec 23 2021, 7:54 AM · Restricted Project

Dec 14 2021

dim added a comment to D109789: [SCEV] Stop blindly propagating flags from inbound geps to SCEV nodes.

Can you file a bug now that the transition is complete?

Dec 14 2021, 10:24 AM · Restricted Project

Dec 13 2021

Herald added a reviewer for D75183: [libcxx] Guard C++20 atomic type aliases: Restricted Project.

It's a pity this never landed. Now libc++ can't work on older arm without non-standard patches... :)

Dec 13 2021, 10:07 AM · Restricted Project

Dec 10 2021

dim updated subscribers of D94355: [Passes] Add relative lookup table converter pass.

FWIW, this commit turned out to break the FreeBSD dns/bind916 port, see https://bugs.freebsd.org/259921.

Dec 10 2021, 1:15 PM · Restricted Project, Restricted Project

Dec 9 2021

dim added a comment to D112753: [llvm] [Support] Add CURL HTTP Client..

@dim, I just committed D115189 which should solve your problem. Thanks for your help and please let me know if your build still fails.

Dec 9 2021, 1:22 AM · Restricted Project

Dec 8 2021

dim added a comment to D112753: [llvm] [Support] Add CURL HTTP Client..

Thanks @dim, I have a patch that should fix this D115189
Would that solve the breakage on freebsd?

Dec 8 2021, 1:39 PM · Restricted Project
dim updated subscribers of D112753: [llvm] [Support] Add CURL HTTP Client..

This breaks building on FreeBSD, where I see:

Dec 8 2021, 1:17 PM · Restricted Project

Dec 6 2021

dim added a comment to D109789: [SCEV] Stop blindly propagating flags from inbound geps to SCEV nodes.

From a fellow FreeBSD user I received a test case which *appears* to be fixed by this particular review/commit, and which otherwise leads to an assertion:

Dec 6 2021, 2:27 PM · Restricted Project

Dec 4 2021

dim added a comment to D115074: [lldb/lua] Suppress warnings about C-linkage in generated wrapper.

We should move this from the wrapper to the header block, similar to what Pavel did for Python: https://reviews.llvm.org/rG9a14adeae00015798843ff5cad987e5fdbdddb34

Dec 4 2021, 1:16 PM · Restricted Project
dim committed rGbbba9d8c1b63: [XRay] fix more -Wformat warnings (authored by dim).
[XRay] fix more -Wformat warnings
Dec 4 2021, 11:01 AM
dim closed D114469: [XRay] fix more -Wformat warnings.
Dec 4 2021, 11:01 AM · Restricted Project

Dec 3 2021

dim requested review of D115074: [lldb/lua] Suppress warnings about C-linkage in generated wrapper.
Dec 3 2021, 12:46 PM · Restricted Project
dim added inline comments to D114469: [XRay] fix more -Wformat warnings.
Dec 3 2021, 11:47 AM · Restricted Project

Dec 2 2021

dim added a comment to D114186: [lld][CMake] Add LLD_DEFAULT_NOSTART_STOP_GC.

I've tried to stay out of this for my own sanity, but my objection has not been about the end state which, in a world where SHF_GNU_RETAIN can be relied upon to work, is a more sensible state than historically (I would've preferred that uses that wanted the new GC behaviour use a new way of doing things rather than repurposing something that didn't do the right thing and then forcing their needs on it, breaking existing uses, but I can see and appreciate the technical reasons for doing it this way, and ignoring compatibility issues it does make more sense). My objection has been that SHF_GNU_RETAIN is not ubiquitous enough, both in terms of support and use, for the default start-stop-gc behaviour to have been changed.

Dec 2 2021, 1:19 PM · Restricted Project

Nov 28 2021

dim committed rGdf08b2fe8b35: [AArch64] Avoid crashing on invalid -Wa,-march= values (authored by dim).
[AArch64] Avoid crashing on invalid -Wa,-march= values
Nov 28 2021, 1:24 PM
dim closed D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values.
Nov 28 2021, 1:24 PM · Restricted Project
dim updated the diff for D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values.

Address review comments.

Nov 28 2021, 10:39 AM · Restricted Project
dim requested review of D114677: [AArch64] Avoid crashing on invalid -Wa,-march= values.
Nov 28 2021, 10:13 AM · Restricted Project

Nov 25 2021

dim added a comment to D114555: [ScalarEvolution] Add bailout to avoid zext of pointer..

FWIW, this fixes both the minimized test case from PR52594, and the full original test case from https://bugs.freebsd.org/260000.

Nov 25 2021, 1:06 AM · Restricted Project

Nov 24 2021

dim committed rG187d9979f22e: cfi: fix more -Wformat warnings (authored by dim).
cfi: fix more -Wformat warnings
Nov 24 2021, 12:49 PM
dim closed D114466: cfi: fix more -Wformat warnings.
Nov 24 2021, 12:48 PM · Restricted Project

Nov 23 2021

dim updated the diff for D114469: [XRay] fix more -Wformat warnings.

Squash commits because arc tricked me.

Nov 23 2021, 1:03 PM · Restricted Project
dim updated the diff for D114469: [XRay] fix more -Wformat warnings.

Drop trailing dots from report messages.

Nov 23 2021, 1:02 PM · Restricted Project
dim committed rGb5a927b972b2: [lldb] Move create_relative_symlink function up in CMake hierarchy (authored by dim).
[lldb] Move create_relative_symlink function up in CMake hierarchy
Nov 23 2021, 1:00 PM
dim closed D114465: [lldb] Move create_relative_symlink function up in CMake hierarchy.
Nov 23 2021, 1:00 PM · Restricted Project
dim requested review of D114469: [XRay] fix more -Wformat warnings.
Nov 23 2021, 12:36 PM · Restricted Project
dim abandoned D114468: Lint..
Nov 23 2021, 12:35 PM · Restricted Project
dim requested review of D114468: Lint..
Nov 23 2021, 12:35 PM · Restricted Project
dim requested review of D114466: cfi: fix more -Wformat warnings.
Nov 23 2021, 12:13 PM · Restricted Project
dim requested review of D114465: [lldb] Move create_relative_symlink function up in CMake hierarchy.
Nov 23 2021, 11:58 AM · Restricted Project

Nov 22 2021

dim accepted D114396: [Driver] Default to current FreeBSD profiling behaviour.

LGTM

Nov 22 2021, 11:57 PM · Restricted Project
dim added a comment to D113443: [FreeBSD] avoid marking __stack_chk_guard symbol as dso_local on PPC64.

Note that this is the version as we have it in the FreeBSD base system version of llvm 13.0.0. Without the isPPC64() check, we would get unexpected R_X86_64_REX_GOTP relocations in our kernel modules, which the kernel module loader cannot handle; see e.g. https://reviews.llvm.org/D109090#3113552 and further comments.

Nov 22 2021, 11:46 AM · Restricted Project