- User Since
- Apr 15 2014, 12:19 PM (373 w, 4 d)
Sat, May 29
Yes, this looks good to me. Thanks for this fix!
Fri, May 28
Hm so this is definitely something that we'd want in 12.0.1? @tstellar it doesn't change any ABI, so should be perfectly safe. I'll create a PR.
May 4 2021
May 3 2021
Reverted due to the influence this had on some other test cases. I'll do a full check-all and go over them one by one, but it will take some time...
Update comment and commit message, and add mips64 test.
Add test case, and update comment to explicitly mention ld.lld.
Apr 21 2021
Apr 7 2021
Apr 6 2021
Apr 4 2021
Apr 3 2021
Apr 2 2021
Squash commits to convince Phabricator.
Address review comments.
Apr 1 2021
Mar 25 2021
My previous update accidentally dropped the changes to SCCP.cpp.
Squashed both local revisions to get both the functionality change and
the test case.
Mar 24 2021
LGTM, but this would probably need some sort of test, at least that it correctly accepts the flag(s) now?
Looks like a good idea to me.
Mar 20 2021
Added a bugpoint-reduced test case. (I could only get clang and opt to
trigger errors on a Linux machine by building with
Ok, I have not been able to make either llc or opt show any addressanitizer errors with the .ll output from the .cpp test case. Is it OK to check in a .cpp test case instead? That would require clang at regression test time though, and I'm unsure if that is available?
Mar 15 2021
Hm, I've reduced the test case to the following C++ source:
Mar 14 2021
Mar 8 2021
Oh please s/FreeVBD/FreeBSD in the description before committing :)
Yes please, this warning has annoyed me for ages. I think we can't get rid of this include entirely, since we need to get at the declarations even if they are deprecated.
Feb 15 2021
Note, this is mainly aimed at getting the 12.0.0 release built, as I had to apply a custom hack to turn the operators on. But I would like to get rid of the hack and have this applied in a way acceptable to the libc++ maintainers.
Jan 28 2021
Jan 22 2021
Jan 19 2021
Jan 8 2021
LGTM (this mirrors what is in libcxx/include/__config btw)
Nov 28 2020
Address comments from review:
- Move FreeBSD specific include under common block
- Use #if #elif #endif for OS specific implementations
Oct 30 2020
Yes, this looks pretty fine to me, but indeed needs a test.
Oct 16 2020
Oct 9 2020
Sep 10 2020
Sep 3 2020
Sep 2 2020
Aug 29 2020
Aug 26 2020
Aug 24 2020
Please note, I did a follow-up commit in rG47b0262d3f82, to address compile errors I received from the x86_64-linux-debian build bot:
Aug 22 2020
After this change, it turns out that some of the errors that this results in can be very confusing. For example, when building ocaml, it uses a .S file (https://github.com/ocaml/ocaml/blob/trunk/runtime/amd64.S#L729) containing:
Aug 21 2020
As @JDevlieghere suggests, only instantiate Error objects when necessary.
Aug 15 2020
Hm, the static FrameHeaderCache ProcessFrameHeaderCache; is biting us here, at least in a multithreaded process like lld, which is the process that is crashing for me all the time now. I added some instrumentation, which shows the problem by adding a thread ID to each log message, and by adding an assert in FrameHeaderCache::add() that MostRecentlyUsed != nullptr:
I turned on _LIBUNWIND_DEBUG_FRAMEHEADER_CACHE, and indeed such segfaults appear immediately after the message libunwind: FrameHeaderCache reset. That means FrameHeaderCache::MostRecentlyUsed has just been set to nullptr ...
It seems that after this change, I'm getting sporadic lld segfaults in libunwind, which look like:
Aug 10 2020
For me, this fixes the assertion for both the original test case (a fully preprocessed ASTReader.cpp) and the minimized test case from https://bugs.llvm.org/show_bug.cgi?id=47041#c1
Aug 9 2020
Aug 3 2020
Aug 2 2020
Hm, this review's still open after two years, and even as of 2020-08-02 clang still crashes on the sample. :)
Aug 1 2020
Note that as of rG1db4318766256f25a03ef80af8dbb3f99743ebe9, applying this change results in the Passed testcases increasing from 49259 to 49666, so more than 400 Failed test cases are fixed by it.
Jul 31 2020
Jul 19 2020
Jul 16 2020