- User Since
- Apr 15 2014, 12:19 PM (311 w, 4 h)
Thu, Mar 26
FYI FreeBSD is one of the few OSes that enables -Wsystem-headers by default, *and* uses libc++ as its default C++ library. So we've already submitted a bunch of warning fixes for libc++.
Fri, Mar 20
Wed, Mar 18
As far as I'm concerned, most suggestions make sense, and it is good to have this information clearly stated.
Tue, Mar 17
Mon, Mar 16
Sun, Mar 15
Fri, Mar 13
Note: one thing that I am unsure about is the _NOEXCEPT after some of the copy constructors. I only applied those to classes that have other _NOEXCEPT constructors, but copying may involve other things that could throw.
Feb 15 2020
Feb 10 2020
Yeah sorry, I used a whitelist instead, here: rG52f2df1ecdd79cc550b694ab280f3b0396d7cf9a
Feb 9 2020
Ping, can we get this committed then? :)
Feb 7 2020
Remove stray newline.
Add better NetBSD implementation of internal_dlinfo().
Feb 6 2020
- Rebase onto reformatted files.
- Add internal_dlinfo() for FreeBSD and NetBSD, with stubs for other platforms.
- Add GET_LINK_MAP_BY_DLOPEN_HANDLE() macro for NetBSD.
Btw, note that according to the Linux dlinfo() manpage, it also has RTLD_DI_LINKMAP as a documented way to get at the link map. Maybe we should generalize this in a follow-up review?
Feb 4 2020
Cast return value to link_map to avoid call site errors.
Jan 29 2020
Jan 24 2020
Jan 17 2020
Aha, which version of clang-cl are you using? With the released version of clang-cl 9.0.1, I get a warning instead of an error:
Eh, no it does not crash clang, at least not here? Instead it gives you a compile error, as it should:
Jan 9 2020
Jan 8 2020
Dec 15 2019
We should abandon this, for e.g. 9.0.1 the whole Base_url variable has become unused. :)
Nov 18 2019
Adding a few people who might know a bit more about CUDA specific things. Please take a look if this review makes any sense, thanks. :)
- Add cuda options test, copied from cuda-options.cu.
Nov 17 2019
I'll work on a test.
Nov 13 2019
Now opt supports -disable-builtin, move the test to llvm/test/Transforms/InstCombine.
I submitted D70193 for adding a -disable-builtin option to opt. Once that is committed, this review can continue.
Nov 12 2019
Nov 8 2019
Another attempt to grab your attention :)
Oct 29 2019
Hm, I would really say that __isnan and the other __ prefixed functions are Linuxisms, or more accurately, glibc-isms. They also don't exist on e.g. macOS:
Oct 21 2019
N.B., EOWNERDEAD and ENOTRECOVERABLE are already defined on lines 158 and line 170, respectively.
Get rid of the ELAST trickery, which is hard to maintain, and does not
appear to serve any purpose. There is no mention of ELAST in the C or
C++ standards, as far as I know.
Now that I'm reading this header again, why do we even bother to define ELAST at all? On Linux, there is no such thing, while on BSDs and macOS, it is already provided by the regular errno.h.
Oct 19 2019
Oct 18 2019
Rewrite the __FreeBSD_version condition to be more straightforward.
Oct 10 2019
Convert m_(monitor|operation)_thread to llvm::Optional<>.
Oct 9 2019
@devnexen this appears to cause https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241137, where simply launching a process in lldb triggers a failure:
Oct 8 2019
For some reason this didn't get closed by Phabricator. Committed in rCRT374070.
@spatel, you mentioned this should be in 9.0.1, with "A noticeable perf regression for x86 vector code made it into the 9.0 release". Does it have a lot of influence on compile-time performance, or run-time performance? (I'd like to pull this one into FreeBSD's clang 9.0.)
Oct 2 2019
Sep 26 2019
LGTM from a FreeBSD point of view. :)
Sep 25 2019
This works for me, and also for the original test case from https://bugs.freebsd.org/240764.
Sep 18 2019
Sep 10 2019
Third time's the charm.