Page MenuHomePhabricator

dim (Dimitry Andric)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 15 2014, 12:19 PM (300 w, 3 d)

Recent Activity

Today

dim added a comment to D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash.

Aha, which version of clang-cl are you using? With the released version of clang-cl 9.0.1, I get a warning instead of an error:

Fri, Jan 17, 5:22 AM · Restricted Project
dim added a comment to D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash.

Eh, no it does not crash clang, at least not here? Instead it gives you a compile error, as it should:

Fri, Jan 17, 3:02 AM · Restricted Project

Thu, Jan 9

dim added inline comments to D71827: [clang] avoid strict aliasing violation in assert.
Thu, Jan 9, 11:01 AM · Restricted Project

Wed, Jan 8

dim accepted D72014: [PowerPC]: Add powerpcspe target triple subarch component.

LGTM.

Wed, Jan 8, 9:43 AM · Restricted Project, Restricted Project

Dec 15 2019

dim added a comment to D68741: test-release.sh s/http/https/.

We should abandon this, for e.g. 9.0.1 the whole Base_url variable has become unused. :)

Dec 15 2019, 3:38 AM · Restricted Project
dim created D71522: Define _LIBCPP_HAS_TIMESPEC_GET for FreeBSD when appropriate.
Dec 15 2019, 3:29 AM · Restricted Project
dim updated the summary of D71522: Define _LIBCPP_HAS_TIMESPEC_GET for FreeBSD when appropriate.
Dec 15 2019, 3:29 AM · Restricted Project

Nov 18 2019

dim committed rGee31adb7fa42: Populate CUDA flags on FreeBSD too, as many other toolchains do. (authored by dim).
Populate CUDA flags on FreeBSD too, as many other toolchains do.
Nov 18 2019, 12:58 PM
dim closed D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do..
Nov 18 2019, 12:58 PM · Restricted Project
dim added a comment to D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do..
In D69990#1750348, @tra wrote:

LGTM, though I'm curious if it's particularly useful. Last time I checked NVIDIA didn't ship libcudart for FreeBSD and without it it's rather cumbersome to use CUDA in practice.

Nov 18 2019, 12:57 PM · Restricted Project
dim added reviewers for D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.: tra, yaxunl, ABataev.

Adding a few people who might know a bit more about CUDA specific things. Please take a look if this review makes any sense, thanks. :)

Nov 18 2019, 11:08 AM · Restricted Project
dim updated the diff for D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do..
  • Add cuda options test, copied from cuda-options.cu.
Nov 18 2019, 11:08 AM · Restricted Project

Nov 17 2019

dim edited reviewers for D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do., added: dim, emaste; removed: Restricted Project.

I'll work on a test.

Nov 17 2019, 11:09 PM · Restricted Project

Nov 13 2019

dim committed rG3db6783d8a7d: Check result of emitStrLen before passing it to CreateGEP (authored by dim).
Check result of emitStrLen before passing it to CreateGEP
Nov 13 2019, 11:11 PM
dim closed D70143: Check result of emitStrLen before passing it to CreateGEP.
Nov 13 2019, 11:11 PM · Restricted Project, Restricted Project
dim updated the diff for D70143: Check result of emitStrLen before passing it to CreateGEP.

Now opt supports -disable-builtin, move the test to llvm/test/Transforms/InstCombine.

Nov 13 2019, 1:19 PM · Restricted Project, Restricted Project
dim committed rG597b77fb7ff9: Add -disable-builtin option to opt (authored by dim).
Add -disable-builtin option to opt
Nov 13 2019, 12:33 PM
dim closed D70193: Add -disable-builtin option to opt.
Nov 13 2019, 12:33 PM · Restricted Project
dim updated the summary of D70193: Add -disable-builtin option to opt.
Nov 13 2019, 12:09 PM · Restricted Project
dim updated subscribers of D56398: Add new EINTEGRITY errno.

Sorry if this is a basic question, but why are we trying to provide EINTEGRITY in libc++'s errno.h header at all? I don't see this being part of the C or C++ Standard.

Nov 13 2019, 11:27 AM
dim added a comment to D70143: Check result of emitStrLen before passing it to CreateGEP.

I submitted D70193 for adding a -disable-builtin option to opt. Once that is committed, this review can continue.

Nov 13 2019, 11:18 AM · Restricted Project, Restricted Project
dim created D70193: Add -disable-builtin option to opt.
Nov 13 2019, 11:18 AM · Restricted Project
dim added inline comments to D70143: Check result of emitStrLen before passing it to CreateGEP.
Nov 13 2019, 6:53 AM · Restricted Project, Restricted Project

Nov 12 2019

dim added a comment to D56398: Add new EINTEGRITY errno.

cem == dim?

Nov 12 2019, 2:03 PM
dim added a comment to D70143: Check result of emitStrLen before passing it to CreateGEP.

This should have a llvm ir test in llvm/test/transforms/instcombine i think, not a clang test.

Nov 12 2019, 2:03 PM · Restricted Project, Restricted Project
dim created D70143: Check result of emitStrLen before passing it to CreateGEP.
Nov 12 2019, 1:34 PM · Restricted Project, Restricted Project
dim accepted D70110: [Driver][FreeBSD] Enable unwind tables on !amd64.

LGTM

Nov 12 2019, 10:09 AM · Restricted Project

Nov 8 2019

dim added a comment to D56398: Add new EINTEGRITY errno.

Another attempt to grab your attention :)

Nov 8 2019, 10:35 AM

Oct 29 2019

dim added a comment to D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3).

Hm, I would really say that __isnan and the other __ prefixed functions are Linuxisms, or more accurately, glibc-isms. They also don't exist on e.g. macOS:

Oct 29 2019, 10:17 AM · Restricted Project
dim added a comment to D56398: Add new EINTEGRITY errno.

Ping :)

Oct 29 2019, 6:06 AM

Oct 21 2019

dim added a comment to D56398: Add new EINTEGRITY errno.

N.B., EOWNERDEAD and ENOTRECOVERABLE are already defined on lines 158 and line 170, respectively.

Oct 21 2019, 12:39 PM
dim updated the diff for D56398: Add new EINTEGRITY errno.

Get rid of the ELAST trickery, which is hard to maintain, and does not
appear to serve any purpose. There is no mention of ELAST in the C or
C++ standards, as far as I know.

Oct 21 2019, 11:43 AM
dim added a comment to D56398: Add new EINTEGRITY errno.

Now that I'm reading this header again, why do we even bother to define ELAST at all? On Linux, there is no such thing, while on BSDs and macOS, it is already provided by the regular errno.h.

Oct 21 2019, 11:33 AM

Oct 19 2019

dim committed rGd5367db95c42: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD (authored by dim).
Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD
Oct 19 2019, 3:59 AM
dim committed rL375340: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD
Oct 19 2019, 3:59 AM
dim closed D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Oct 19 2019, 3:58 AM · Restricted Project

Oct 18 2019

dim updated the diff for D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.

Rewrite the __FreeBSD_version condition to be more straightforward.

Oct 18 2019, 12:49 PM · Restricted Project
dim added inline comments to D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Oct 18 2019, 12:40 PM · Restricted Project
dim created D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Oct 18 2019, 8:47 AM · Restricted Project
dim abandoned D47987: Provide only one declaration of __throw_runtime_error.

Obsoleted by D58425 (and rCXX354515).

Oct 18 2019, 2:52 AM

Oct 10 2019

dim committed rGa42942e0ecd6: Fix process launch failure on FreeBSD after r365761 (authored by dim).
Fix process launch failure on FreeBSD after r365761
Oct 10 2019, 1:27 PM
dim closed D68723: Fix process launch failure on FreeBSD after r365761.
Oct 10 2019, 1:27 PM · Restricted Project
dim committed rL374444: Fix process launch failure on FreeBSD after r365761.
Fix process launch failure on FreeBSD after r365761
Oct 10 2019, 1:26 PM
dim updated the diff for D68723: Fix process launch failure on FreeBSD after r365761.

Convert m_(monitor|operation)_thread to llvm::Optional<>.

Oct 10 2019, 12:30 PM · Restricted Project

Oct 9 2019

dim created D68723: Fix process launch failure on FreeBSD after r365761.
Oct 9 2019, 1:10 PM · Restricted Project
dim added a comment to D68723: Fix process launch failure on FreeBSD after r365761.
Oct 9 2019, 1:10 PM · Restricted Project
dim added a comment to rL365761: [LLDB] Fix FreeBSD build..

@devnexen this appears to cause https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241137, where simply launching a process in lldb triggers a failure:

Expected<T> must be checked before access or destruction.
Expected<T> value was in success state. (Note: Expected<T> values in success mode must still be checked prior to being destroyed).
Oct 9 2019, 11:54 AM
dim updated subscribers of rL365761: [LLDB] Fix FreeBSD build..

@devnexen this appears to cause https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241137, where simply launching a process in lldb triggers a failure:

Oct 9 2019, 11:54 AM

Oct 8 2019

dim closed D68045: [builtins] Unbreak build on FreeBSD armv7 after D60351.

For some reason this didn't get closed by Phabricator. Committed in rCRT374070.

Oct 8 2019, 9:58 AM · Restricted Project, Restricted Project
dim added a comment to rL372886: [DAGCombiner] add one-use restriction to vector transform with cheap extract.

@spatel, you mentioned this should be in 9.0.1, with "A noticeable perf regression for x86 vector code made it into the 9.0 release". Does it have a lot of influence on compile-time performance, or run-time performance? (I'd like to pull this one into FreeBSD's clang 9.0.)

Oct 8 2019, 12:29 AM

Oct 2 2019

dim updated subscribers of D68269: [libc++abi] Do not define new/delete by default.

Pinging vendors for awareness of the change: @phosek @danalbert @dim

This is going in soon and will require a change in how you build libc++abi if you need new/delete definitions to be provided in libc++abi.so, namely to use -DLIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS=ON when you configure CMake for libc++abi.

The upshot of this change is that by default, we won't get both definitions in libc++ and libc++abi, thus unbreaking the default configuration.

Oct 2 2019, 2:34 PM · Restricted Project

Sep 26 2019

dim added a comment to D68051: [OpenMP] Don't link libm with -Wl,--as-needed on FreeBSD.

LGTM from a FreeBSD point of view. :)

Sep 26 2019, 10:28 AM · Restricted Project

Sep 25 2019

dim added a comment to D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper.

This works for me, and also for the original test case from https://bugs.freebsd.org/240764.

Sep 25 2019, 2:20 AM · Restricted Project

Sep 18 2019

dim committed rGab8b456ce5d8: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher (authored by dim).
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Sep 18 2019, 2:05 PM
dim committed rGf88e75525d25: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher (authored by dim).
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Sep 18 2019, 1:58 PM
dim committed rL372261: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Sep 18 2019, 1:57 PM
dim closed D67119: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
Sep 18 2019, 1:57 PM · Restricted Project, Restricted Project
dim committed rL372260: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Sep 18 2019, 1:57 PM
dim closed D67118: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
Sep 18 2019, 1:57 PM · Restricted Project

Sep 10 2019

dim added a comment to rL363529: Re-commit r357452 (take 3): "SimplifyCFG SinkCommonCodeFromPredecessors: Also….

Third time's the charm.

Sep 10 2019, 12:37 PM

Sep 7 2019

dim committed rG5bd4a4806aaf: Remove ::gets for FreeBSD 13 and later (authored by dim).
Remove ::gets for FreeBSD 13 and later
Sep 7 2019, 3:18 PM
dim committed rL371324: Remove ::gets for FreeBSD 13 and later.
Remove ::gets for FreeBSD 13 and later
Sep 7 2019, 3:17 PM
dim closed D67316: Remove ::gets for FreeBSD 13 and later.
Sep 7 2019, 3:17 PM · Restricted Project
dim updated the diff for D67316: Remove ::gets for FreeBSD 13 and later.

Add _LIBCPP_C_HAS_NO_GETS macro to <__config>, and use that in <cstdio>.

Sep 7 2019, 8:20 AM · Restricted Project
dim created D67316: Remove ::gets for FreeBSD 13 and later.
Sep 7 2019, 5:13 AM · Restricted Project

Sep 4 2019

dim accepted D35034: compiler-rt: use fp_t instead of long double, for consistency.

Still OK with me :)

Sep 4 2019, 10:59 PM · Restricted Project

Sep 3 2019

dim created D67119: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
Sep 3 2019, 11:17 AM · Restricted Project, Restricted Project
dim created D67118: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
Sep 3 2019, 11:15 AM · Restricted Project
dim accepted D66760: clang: default to DWARF 4 for FreeBSD 12.0 and later.

LGTM

Sep 3 2019, 9:06 AM · Restricted Project

Aug 30 2019

dim committed rL370542: Request commit access for dim.
Request commit access for dim
Aug 30 2019, 3:37 PM
dim committed rL370541: Remove mixed newlines, set svn:eol-style and svn:mime-type to prevent further….
Remove mixed newlines, set svn:eol-style and svn:mime-type to prevent further…
Aug 30 2019, 3:32 PM

Aug 28 2019

dim accepted D66758: compiler-rt: all FreeBSD CPU archs except i386 use 64-bit time_t.
Aug 28 2019, 12:10 PM · Restricted Project

Aug 22 2019

dim accepted D66582: [Sanitizer] checks ASLR on FreeBSD.

LGTM. Maybe nice to merge it to 9.0 after a day or two.

Aug 22 2019, 10:50 AM · Restricted Project, Restricted Project

Aug 10 2019

dim committed rGc09d88863284: Add support for FreeBSD's LD_32_LIBRARY_PATH (authored by dim).
Add support for FreeBSD's LD_32_LIBRARY_PATH
Aug 10 2019, 12:08 PM
dim committed rL368516: Add support for FreeBSD's LD_32_LIBRARY_PATH.
Add support for FreeBSD's LD_32_LIBRARY_PATH
Aug 10 2019, 12:07 PM
dim closed D65772: Add support for FreeBSD's LD_32_LIBRARY_PATH.
Aug 10 2019, 12:07 PM · Restricted Project, Restricted Project

Aug 5 2019

dim created D65772: Add support for FreeBSD's LD_32_LIBRARY_PATH.
Aug 5 2019, 1:21 PM · Restricted Project, Restricted Project

Jul 28 2019

dim added inline comments to D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.
Jul 28 2019, 3:00 AM · Restricted Project, Restricted Project

Jul 24 2019

dim added a comment to D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.

Is any test was broken?

Jul 24 2019, 11:11 PM · Restricted Project, Restricted Project
dim added a comment to D55596: Reimplement Thread Static Data ASan routines with TLS.
In D55596#1599456, @dim wrote:

This broke ASAN on FreeBSD (same for the MSAN change). When loading static thread_local struct tsd_key key this is done using __tls_get_addr. The interceptor for __tls_get_addr then calls GetCurrentThread which calls AsanTSDGet which again calls __tls_get_addr.
If I remove the || SANITIZER_FREEBSD it works fine (at least on FreeBSD 11.2).

Yes indeed, this is https://bugs.llvm.org/show_bug.cgi?id=40761. I'm unsure what a good solution direction is.

I just spent some time debugging and it seems like https://reviews.llvm.org/D55596 works.

Jul 24 2019, 10:51 AM · Restricted Project, Restricted Project
dim added a comment to D55596: Reimplement Thread Static Data ASan routines with TLS.

This broke ASAN on FreeBSD (same for the MSAN change). When loading static thread_local struct tsd_key key this is done using __tls_get_addr. The interceptor for __tls_get_addr then calls GetCurrentThread which calls AsanTSDGet which again calls __tls_get_addr.
If I remove the || SANITIZER_FREEBSD it works fine (at least on FreeBSD 11.2).

Jul 24 2019, 9:51 AM · Restricted Project, Restricted Project

Jul 9 2019

dim committed rG19a71f6bdf2d: Merging r360861, with an additional change to also add the PPC64_OPD1 and… (authored by dim).
Merging r360861, with an additional change to also add the PPC64_OPD1 and…
Jul 9 2019, 12:26 PM
dim committed rL365542: Merging r360861, with an additional change to also add the PPC64_OPD1.
Merging r360861, with an additional change to also add the PPC64_OPD1
Jul 9 2019, 12:25 PM
dim committed rG635f8ffdbd7b: Revert merge of r360861: (authored by dim).
Revert merge of r360861:
Jul 9 2019, 12:18 PM
dim committed rL365539: Revert merge of r360861:.
Revert merge of r360861:
Jul 9 2019, 12:18 PM

Jun 23 2019

dim added a comment to D63686: [LFTR] Fix post-inc pointer IV with truncated exit count (PR41998).

FWIW, the original test case with pre-increment is fixed by this, e.g.:

Jun 23 2019, 2:23 PM · Restricted Project

Jun 15 2019

dim abandoned D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF.

No longer needed after rC362328 and follow-ups.

Jun 15 2019, 2:07 PM · Restricted Project

Jun 4 2019

dim created D62873: Avoid building analyzer plugins if CLANG_ENABLE_STATIC_ANALYZER is OFF.
Jun 4 2019, 12:48 PM · Restricted Project

May 13 2019

dim added a comment to D60748: Fix i386 struct and union parameter alignment.

In fact, it is probably better to turn the OS check around, e.g. *only* increase the alignment for Linux, and nowhere else.

May 13 2019, 4:01 AM · Restricted Project
dim updated subscribers of D60748: Fix i386 struct and union parameter alignment.

Please also exclude FreeBSD from these changes, since we care a lot about backwards compatibility, and specifically about alignment requirements. (We have run into many issues in our ports collection where upstream assumes everything is 16-byte aligned on i386, which is *NOT* ABI compliant.)

May 13 2019, 3:57 AM · Restricted Project

May 6 2019

dim added a comment to D60427: [ARM] Glue register copies to tail calls..

@efriedma any more work to be done on this? :)

May 6 2019, 11:07 AM · Restricted Project
dim committed rG181aff63fb14: Add non-SSE wrapper for __kmp_{load,store}_mxcsr (authored by dim).
Add non-SSE wrapper for __kmp_{load,store}_mxcsr
May 6 2019, 10:58 AM
dim committed rL360062: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.
Add non-SSE wrapper for __kmp_{load,store}_mxcsr
May 6 2019, 10:58 AM
dim committed rOMP360062: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.
Add non-SSE wrapper for __kmp_{load,store}_mxcsr
May 6 2019, 10:58 AM
dim closed D60916: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.
May 6 2019, 10:57 AM · Restricted Project

May 4 2019

dim added a comment to D60916: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.

So does this look better now?

May 4 2019, 5:58 AM · Restricted Project

May 1 2019

dim updated the diff for D60916: Add non-SSE wrapper for __kmp_{load,store}_mxcsr.

Address review comments:

  • Assign zero to pointed-to value in __kmp_store_mxcsr()
  • Use SSE specific stuff in KMP_OS_UNIX part only
May 1 2019, 12:53 PM · Restricted Project
dim committed rG147ce2334c96: Enable OpenMP build for 32-bit FreeBSD (authored by dim).
Enable OpenMP build for 32-bit FreeBSD
May 1 2019, 12:33 PM
dim committed rL359716: Enable OpenMP build for 32-bit FreeBSD.
Enable OpenMP build for 32-bit FreeBSD
May 1 2019, 12:32 PM
dim committed rOMP359716: Enable OpenMP build for 32-bit FreeBSD.
Enable OpenMP build for 32-bit FreeBSD
May 1 2019, 12:32 PM