Page MenuHomePhabricator

dim (Dimitry Andric)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 15 2014, 12:19 PM (373 w, 4 d)

Recent Activity

Sat, May 29

dim accepted D103346: [Support] Fix getMainExecutable on FreeBSD when called via an absolute path.

Yes, this looks good to me. Thanks for this fix!

Sat, May 29, 12:39 AM · Restricted Project

Fri, May 28

dim added a comment to D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

https://bugs.llvm.org/show_bug.cgi?id=50522

Fri, May 28, 1:14 PM · Restricted Project
dim updated subscribers of D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

Hm so this is definitely something that we'd want in 12.0.1? @tstellar it doesn't change any ABI, so should be perfectly safe. I'll create a PR.

Fri, May 28, 12:29 PM · Restricted Project

May 4 2021

dim committed rGdffddde73ab7: Revert "[llvm-objdump] Remove Generic Options group from help text output" (authored by dim).
Revert "[llvm-objdump] Remove Generic Options group from help text output"
May 4 2021, 9:29 AM
dim added a reverting change for rG73686247ac3e: [llvm-objdump] Remove Generic Options group from help text output: rGdffddde73ab7: Revert "[llvm-objdump] Remove Generic Options group from help text output".
May 4 2021, 9:29 AM
dim added a reverting change for D101652: [llvm-objdump] Remove Generic Options group from help text output: rGdffddde73ab7: Revert "[llvm-objdump] Remove Generic Options group from help text output".
May 4 2021, 9:29 AM · Restricted Project
dim added inline comments to rG73686247ac3e: [llvm-objdump] Remove Generic Options group from help text output.
May 4 2021, 9:27 AM
dim committed rG7e83a7f1fdfc: Reland "[MC][ELF] Work around R_MIPS_LO16 relocation handling problem" (authored by dim).
Reland "[MC][ELF] Work around R_MIPS_LO16 relocation handling problem"
May 4 2021, 9:16 AM

May 3 2021

dim added a comment to D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

Reverted due to the influence this had on some other test cases. I'll do a full check-all and go over them one by one, but it will take some time...

May 3 2021, 2:11 PM · Restricted Project
dim added a reverting change for rGab40c027f0ce: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem: rGe1babfc2233b: Revert "[MC][ELF] Work around R_MIPS_LO16 relocation handling problem".
May 3 2021, 2:09 PM
dim committed rGe1babfc2233b: Revert "[MC][ELF] Work around R_MIPS_LO16 relocation handling problem" (authored by dim).
Revert "[MC][ELF] Work around R_MIPS_LO16 relocation handling problem"
May 3 2021, 2:09 PM
dim added a reverting change for D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem: rGe1babfc2233b: Revert "[MC][ELF] Work around R_MIPS_LO16 relocation handling problem".
May 3 2021, 2:09 PM · Restricted Project
dim committed rGab40c027f0ce: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem (authored by dim).
[MC][ELF] Work around R_MIPS_LO16 relocation handling problem
May 3 2021, 1:59 PM
dim closed D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.
May 3 2021, 1:59 PM · Restricted Project
dim updated the summary of D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.
May 3 2021, 1:57 PM · Restricted Project
dim updated the diff for D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

Update comment and commit message, and add mips64 test.

May 3 2021, 1:22 PM · Restricted Project
dim updated the diff for D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.

Add test case, and update comment to explicitly mention ld.lld.

May 3 2021, 12:11 PM · Restricted Project
dim requested review of D101773: [MC][ELF] Work around R_MIPS_LO16 relocation handling problem.
May 3 2021, 11:10 AM · Restricted Project

Apr 21 2021

dim accepted D100864: Replace Apple representative to security group..

Welcome, Kate.

Apr 21 2021, 1:05 AM · Restricted Project

Apr 7 2021

dim committed rGb3e9b07a7d1c: Avoid testing for libc++ internal macros after D99834 (authored by dim).
Avoid testing for libc++ internal macros after D99834
Apr 7 2021, 9:53 AM

Apr 6 2021

dim added inline comments to D99834: Don't check that std::pair is trivially copyable on FreeBSD.
Apr 6 2021, 12:28 PM · Restricted Project
dim added inline comments to D99834: Don't check that std::pair is trivially copyable on FreeBSD.
Apr 6 2021, 12:09 PM · Restricted Project

Apr 4 2021

dim committed rG6fbbb093aea5: Don't check that std::pair is trivially copyable on FreeBSD (authored by dim).
Don't check that std::pair is trivially copyable on FreeBSD
Apr 4 2021, 4:14 AM
dim closed D99834: Don't check that std::pair is trivially copyable on FreeBSD.
Apr 4 2021, 4:14 AM · Restricted Project

Apr 3 2021

dim requested review of D99834: Don't check that std::pair is trivially copyable on FreeBSD.
Apr 3 2021, 3:24 AM · Restricted Project

Apr 2 2021

dim added inline comments to D98602: [SCCP] Avoid modifying AdditionalUsers while iterating over it.
Apr 2 2021, 10:07 AM · Restricted Project
dim committed rG6abb92f2103a: [SCCP] Avoid modifying AdditionalUsers while iterating over it (authored by dim).
[SCCP] Avoid modifying AdditionalUsers while iterating over it
Apr 2 2021, 10:06 AM
dim closed D98602: [SCCP] Avoid modifying AdditionalUsers while iterating over it.
Apr 2 2021, 10:06 AM · Restricted Project
dim updated the diff for D98602: [SCCP] Avoid modifying AdditionalUsers while iterating over it.

Squash commits to convince Phabricator.

Apr 2 2021, 9:48 AM · Restricted Project
dim updated the diff for D98602: [SCCP] Avoid modifying AdditionalUsers while iterating over it.

Address review comments.

Apr 2 2021, 8:59 AM · Restricted Project

Apr 1 2021

dim added a comment to D98602: [SCCP] Avoid modifying AdditionalUsers while iterating over it.
In D98602#2651521, @dim wrote:

My previous update accidentally dropped the changes to SCCP.cpp.
Squashed both local revisions to get both the functionality change and
the test case.

Thanks for adding the test! As long as it fails with ASan, that's fine, there are multiple bots building with that enabled. If it would be possible to reduce it even further, that would obviously be great, but it probably needs a large enough input to trigger.

Apr 1 2021, 11:20 AM · Restricted Project

Mar 25 2021

dim updated the diff for D98602: [SCCP] Avoid modifying AdditionalUsers while iterating over it.

My previous update accidentally dropped the changes to SCCP.cpp.
Squashed both local revisions to get both the functionality change and
the test case.

Mar 25 2021, 12:56 PM · Restricted Project

Mar 24 2021

dim accepted D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD.

LGTM, but this would probably need some sort of test, at least that it correctly accepts the flag(s) now?

Mar 24 2021, 11:26 AM · Restricted Project
dim accepted D98285: [asan] Add an offset for the kernel address sanitizer on FreeBSD.

LGTM

Mar 24 2021, 11:25 AM · Restricted Project
dim accepted D99232: [Nomination] Adding new Google representative to security group.

Looks like a good idea to me.

Mar 24 2021, 11:24 AM · Restricted Project

Mar 20 2021

dim updated the diff for D98602: [SCCP] Avoid modifying AdditionalUsers while iterating over it.

Added a bugpoint-reduced test case. (I could only get clang and opt to
trigger errors on a Linux machine by building with
LLVM_USE_SANITIZER=Address.)

Mar 20 2021, 2:09 PM · Restricted Project
dim added a comment to D98602: [SCCP] Avoid modifying AdditionalUsers while iterating over it.

Ok, I have not been able to make either llc or opt show any addressanitizer errors with the .ll output from the .cpp test case. Is it OK to check in a .cpp test case instead? That would require clang at regression test time though, and I'm unsure if that is available?

Mar 20 2021, 12:42 PM · Restricted Project

Mar 15 2021

dim added a comment to D98602: [SCCP] Avoid modifying AdditionalUsers while iterating over it.

Hm, I've reduced the test case to the following C++ source:

Mar 15 2021, 12:11 PM · Restricted Project

Mar 14 2021

dim added a comment to D98602: [SCCP] Avoid modifying AdditionalUsers while iterating over it.

Test missing.

Mar 14 2021, 11:02 AM · Restricted Project
dim requested review of D98602: [SCCP] Avoid modifying AdditionalUsers while iterating over it.
Mar 14 2021, 9:46 AM · Restricted Project

Mar 8 2021

dim added a comment to D94963: [compiler-rt] Silence a deprecation warning on FreeBSD.

Oh please s/FreeVBD/FreeBSD in the description before committing :)

Mar 8 2021, 4:27 AM · Restricted Project
dim accepted D94963: [compiler-rt] Silence a deprecation warning on FreeBSD.

Yes please, this warning has annoyed me for ages. I think we can't get rid of this include entirely, since we need to get at the declarations even if they are deprecated.

Mar 8 2021, 4:27 AM · Restricted Project

Feb 15 2021

dim committed rG328261019f50: Define new/delete in libc++ when using libcxxrt (authored by dim).
Define new/delete in libc++ when using libcxxrt
Feb 15 2021, 12:22 PM
dim closed D96720: Define new/delete in libc++ when using libcxxrt.
Feb 15 2021, 12:22 PM · Restricted Project
dim updated the summary of D96720: Define new/delete in libc++ when using libcxxrt.
Feb 15 2021, 12:21 PM · Restricted Project
dim updated subscribers of D96720: Define new/delete in libc++ when using libcxxrt.

Is the 12.x release fixed, or does this patch need to be cherry-picked to the branch?

Feb 15 2021, 12:04 PM · Restricted Project
dim added a comment to D96720: Define new/delete in libc++ when using libcxxrt.

Note, this is mainly aimed at getting the 12.0.0 release built, as I had to apply a custom hack to turn the operators on. But I would like to get rid of the hack and have this applied in a way acceptable to the libc++ maintainers.

Feb 15 2021, 9:29 AM · Restricted Project
dim retitled D96720: Define new/delete in libc++ when using libcxxrt from Summary: Always turn on LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS, if libcxxrt is used as the C++ ABI library, since libcxxrt does not provide the full set of new and delete operators. In particular, the aligned versions of these operators are... to Define new/delete in libc++ when using libcxxrt.
Feb 15 2021, 9:27 AM · Restricted Project
dim requested review of D96720: Define new/delete in libc++ when using libcxxrt.
Feb 15 2021, 9:25 AM · Restricted Project

Jan 28 2021

dim committed rGe056fc6cb676: [sanitizer] Fix msan test build on FreeBSD after 7afdc89c2054 (authored by dim).
[sanitizer] Fix msan test build on FreeBSD after 7afdc89c2054
Jan 28 2021, 2:54 PM

Jan 22 2021

dim accepted D95264: [compiler-rt] Support FreeBSD standalone (boot) environment.

LGTM.

Jan 22 2021, 1:22 PM · Restricted Project

Jan 19 2021

dim added a comment to D94941: Add minor version to libclang.so and libclang-cpp.so SONAME.

@sylvestre.ledru removed the minor version from the binary (on purpose, I think?) in rGa8b717fda42294d1c8e1f05d71280503e5839f14:

Jan 19 2021, 12:16 PM · Restricted Project

Jan 8 2021

dim accepted D94292: [libc++] Sync TEST_HAS_TIMESPEC_GET and _LIBCPP_HAS_TIMESPEC_GET on FreeBSD.

LGTM (this mirrors what is in libcxx/include/__config btw)

Jan 8 2021, 4:38 AM · Restricted Project

Nov 28 2020

dim committed rGd989ffd109b2: Implement computeHostNumHardwareThreads() for FreeBSD (authored by dim).
Implement computeHostNumHardwareThreads() for FreeBSD
Nov 28 2020, 3:50 PM
dim closed D92271: Implement computeHostNumHardwareThreads() for FreeBSD.
Nov 28 2020, 3:50 PM · Restricted Project
dim updated the diff for D92271: Implement computeHostNumHardwareThreads() for FreeBSD.

Address comments from review:

  • Move FreeBSD specific include under common block
  • Use #if #elif #endif for OS specific implementations
Nov 28 2020, 12:44 PM · Restricted Project
dim requested review of D92271: Implement computeHostNumHardwareThreads() for FreeBSD.
Nov 28 2020, 12:05 PM · Restricted Project

Oct 30 2020

dim added a comment to D44964: Change order of libclang_rt.profile link for freebsd.

Yes, this looks pretty fine to me, but indeed needs a test.

Oct 30 2020, 8:13 AM

Oct 16 2020

dim accepted D89557: Fix build of MiBench on FreeBSD RISC-V.

LGTM.

Oct 16 2020, 10:15 AM

Oct 9 2020

dim accepted D68269: [libc++] Define new/delete in libc++abi only by default.
In D68269#2322291, @dim wrote:

Ping. Please take a look. I'll ship this in a week if nobody cares.

On FreeBSD we replaced (quite a while ago now) libsupc++ with libcxxrt. Currently this also provides new and delete operators, but not all that are provided by libc++ (as of ~11.0.0 rc5):

[...]

That said, both libcxxrt and libc++ mark their implementations as weak, so it's good guess which one wins... I'm actually not completely sure, except for the variants that libcxxrt doesn't implement. :)

In any case, we'd at least have to add the variants with align_val_t and with the const nothrow_t to libcxxrt, to make it backwards compatible. Another option would be to switch to libc++abi, but that is quite a lot more work.

The other option, which I would argue is the least amount of work, is for you to configure CMake with -DLIBCXX_ENABLE_NEW_DELETE_DEFINITIONS=ON. The libc++ produced with that option should match what you have today.

Oct 9 2020, 11:05 AM · Restricted Project, Restricted Project
dim updated subscribers of D68269: [libc++] Define new/delete in libc++abi only by default.

Ping. Please take a look. I'll ship this in a week if nobody cares.

Oct 9 2020, 10:40 AM · Restricted Project, Restricted Project

Sep 10 2020

dim added a comment to D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE.

Any chance of a backport to 11?

Sep 10 2020, 1:11 PM · Restricted Project, Restricted Project

Sep 3 2020

dim committed rGf26fc568402f: Eliminate the sizing template parameter N from CoalescingBitVector (authored by dim).
Eliminate the sizing template parameter N from CoalescingBitVector
Sep 3 2020, 9:16 AM
dim closed D87044: Eliminate the sizing template parameter N from CoalescingBitVector.
Sep 3 2020, 9:15 AM · Restricted Project

Sep 2 2020

dim requested review of D87044: Eliminate the sizing template parameter N from CoalescingBitVector.
Sep 2 2020, 10:01 AM · Restricted Project

Aug 29 2020

dim committed rGfc2dac4116df: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE (authored by dim).
[PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE
Aug 29 2020, 3:04 AM
dim closed D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE.
Aug 29 2020, 3:03 AM · Restricted Project, Restricted Project

Aug 26 2020

dim added a comment to D86510: [compiler-rt] Fix atomic support functions on 32-bit architectures.

We are triggering -Watomic-alignment because __c11_atomic_is_lock_free(8) expands to a __atomic_is_lock_free call for mips32 since the property is not known statically, so the branch inside the switch emitted and contains a call to __atomic_load_8 which triggers the warning.

Which -Watomic-alignment warning are we talking about? The "max lock-free size" one, or the "actual alignment" one?

Aug 26 2020, 2:54 PM · Restricted Project

Aug 24 2020

dim added a comment to D86397: Move special va_list handling to kmp_os.h.

Please note, I did a follow-up commit in rG47b0262d3f82, to address compile errors I received from the x86_64-linux-debian build bot:

Aug 24 2020, 1:49 PM · Restricted Project
dim closed D77333: OpenMP: Support FreeBSD on AArch64..

This has been obsoleted by D86397 (committed as rGcde8f4c164a2 with follow-up rG47b0262d3f82).

Aug 24 2020, 1:47 PM · Restricted Project
dim committed rG47b0262d3f82: Add <stdarg.h> include to kmp_os.h, to get the va_list type, required (authored by dim).
Add <stdarg.h> include to kmp_os.h, to get the va_list type, required
Aug 24 2020, 1:45 PM
dim committed rGcde8f4c164a2: Move special va_list handling to kmp_os.h (authored by dim).
Move special va_list handling to kmp_os.h
Aug 24 2020, 1:32 PM
dim closed D86397: Move special va_list handling to kmp_os.h.
Aug 24 2020, 1:32 PM · Restricted Project

Aug 22 2020

dim added a comment to D73999: [MC][ELF] Error for sh_type, sh_flags or sh_entsize change.

After this change, it turns out that some of the errors that this results in can be very confusing. For example, when building ocaml, it uses a .S file (https://github.com/ocaml/ocaml/blob/trunk/runtime/amd64.S#L729) containing:

Aug 22 2020, 11:26 AM · Restricted Project
dim requested review of D86397: Move special va_list handling to kmp_os.h.
Aug 22 2020, 6:32 AM · Restricted Project
dim committed rG1ce07cd614be: Instantiate Error in Target::GetEntryPointAddress() only when necessary (authored by dim).
Instantiate Error in Target::GetEntryPointAddress() only when necessary
Aug 22 2020, 3:48 AM
dim closed D86355: Instantiate Error in Target::GetEntryPointAddress() only when necessary.
Aug 22 2020, 3:47 AM · Restricted Project

Aug 21 2020

dim retitled D86355: Instantiate Error in Target::GetEntryPointAddress() only when necessary from Consume error for valid return from Target::GetEntryPointAddress() to Instantiate Error in Target::GetEntryPointAddress() only when necessary.
Aug 21 2020, 12:06 PM · Restricted Project
dim updated the diff for D86355: Instantiate Error in Target::GetEntryPointAddress() only when necessary.

As @JDevlieghere suggests, only instantiate Error objects when necessary.

Aug 21 2020, 12:04 PM · Restricted Project
dim added inline comments to D86355: Instantiate Error in Target::GetEntryPointAddress() only when necessary.
Aug 21 2020, 11:49 AM · Restricted Project
dim requested review of D86355: Instantiate Error in Target::GetEntryPointAddress() only when necessary.
Aug 21 2020, 8:50 AM · Restricted Project

Aug 15 2020

dim updated subscribers of D75954: Cache uwnind frame headers as they are found..

Hm, the static FrameHeaderCache ProcessFrameHeaderCache; is biting us here, at least in a multithreaded process like lld, which is the process that is crashing for me all the time now. I added some instrumentation, which shows the problem by adding a thread ID to each log message, and by adding an assert in FrameHeaderCache::add() that MostRecentlyUsed != nullptr:

Aug 15 2020, 12:17 PM · Restricted Project, Restricted Project, Restricted Project
dim added a comment to D75954: Cache uwnind frame headers as they are found..

I turned on _LIBUNWIND_DEBUG_FRAMEHEADER_CACHE, and indeed such segfaults appear immediately after the message libunwind: FrameHeaderCache reset. That means FrameHeaderCache::MostRecentlyUsed has just been set to nullptr ...

Aug 15 2020, 11:36 AM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D75954: Cache uwnind frame headers as they are found.: Restricted Project.

It seems that after this change, I'm getting sporadic lld segfaults in libunwind, which look like:

Aug 15 2020, 10:47 AM · Restricted Project, Restricted Project, Restricted Project
dim committed rG3aecf4bdf3f8: On FreeBSD, add -pthread to ASan dynamic compile flags for tests (authored by dim).
On FreeBSD, add -pthread to ASan dynamic compile flags for tests
Aug 15 2020, 4:06 AM
dim closed D85082: On FreeBSD, add -pthread to ASan dynamic compile flags for tests.
Aug 15 2020, 4:05 AM · Restricted Project

Aug 10 2020

dim added a comment to D85659: [PowerPC] in fixupIsDeadOrKill before RA, get def instructions by calling getVRegDef .

For me, this fixes the assertion for both the original test case (a fully preprocessed ASTReader.cpp) and the minimized test case from https://bugs.llvm.org/show_bug.cgi?id=47041#c1

Aug 10 2020, 1:25 PM · Restricted Project

Aug 9 2020

dim added inline comments to rG7ab05d9a60b0: [PowerPC] fold addi's imm operand to its imm form consumer's displacement.
Aug 9 2020, 12:10 PM

Aug 3 2020

dim added a comment to D85082: On FreeBSD, add -pthread to ASan dynamic compile flags for tests.

Can we instead add a dependency on libpthread.so/libthr.so to libasan.so?

Never mind, it seems like it's already there:

File: ./lib/clang/12.0.0/lib/freebsd/libclang_rt.asan-x86_64.so
Format: elf64-x86-64
Arch: x86_64
AddressSize: 64bit
LoadName: libclang_rt.asan-x86_64.so
NeededLibraries [
  libc++.so.1
  libc.so.7
  libcxxrt.so.1
  libdl.so.1
  libgcc_s.so.1
  libm.so.5
  librt.so.1
  libthr.so.3
]
Aug 3 2020, 6:25 AM · Restricted Project

Aug 2 2020

dim added a comment to D44536: Avoid segfault when destructor is not yet known.

Hm, this review's still open after two years, and even as of 2020-08-02 clang still crashes on the sample. :)

Aug 2 2020, 3:19 AM

Aug 1 2020

dim added a comment to D85082: On FreeBSD, add -pthread to ASan dynamic compile flags for tests.

Note that as of rG1db4318766256f25a03ef80af8dbb3f99743ebe9, applying this change results in the Passed testcases increasing from 49259 to 49666, so more than 400 Failed test cases are fixed by it.

Aug 1 2020, 3:44 PM · Restricted Project
dim requested review of D85082: On FreeBSD, add -pthread to ASan dynamic compile flags for tests.
Aug 1 2020, 3:40 PM · Restricted Project
dim closed D83411: Use md5 -q for HashProgramOutput.sh, to show only the checksum..
Aug 1 2020, 6:36 AM

Jul 31 2020

dim added a comment to D77776: [Driver] Default to libc++ on FreeBSD.
In D77776#2187273, @dim wrote:
+#ifdef __FreeBSD__
+	  return __FreeBSD_version / 100000;
+#else
+	  return 10;
+#endif

No, that would hardcode something at build time. We need to respect whatever triple the user is passing in.

Nobody has proposed not respecting that, this is all in the context of the if (Major == 0) fallback

Jul 31 2020, 6:12 AM · Restricted Project
dim added inline comments to D83411: Use md5 -q for HashProgramOutput.sh, to show only the checksum..
Jul 31 2020, 6:11 AM
dim added a comment to D77776: [Driver] Default to libc++ on FreeBSD.

I don't like the fact that this only changes one of the users of getTriple().getOSMajorVersion().

Jul 31 2020, 5:43 AM · Restricted Project
dim reclaimed D83411: Use md5 -q for HashProgramOutput.sh, to show only the checksum..
Jul 31 2020, 3:09 AM
dim abandoned D83411: Use md5 -q for HashProgramOutput.sh, to show only the checksum..
Jul 31 2020, 2:54 AM

Jul 19 2020

dim added a comment to D83645: Bump the default target CPU for i386-freebsd to i686.

@dim

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (--date=now is my personal preference (author dates are usually not useful. Using committer dates can make log almost monotonic in time))

llvm/utils/git/pre-push.py can validate the message does not include unneeded tags.

Jul 19 2020, 2:46 AM · Restricted Project

Jul 16 2020

dim accepted D83990: [test-release] fallback to py3's venv module.

LGTM.

Jul 16 2020, 3:29 PM · Restricted Project