Page MenuHomePhabricator

dim (Dimitry Andric)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 15 2014, 12:19 PM (253 w, 1 d)

Recent Activity

Today

dim committed rCXX354515: Fix the build with gcc when `-Wredundant-decls` is passed.
Fix the build with gcc when `-Wredundant-decls` is passed
Wed, Feb 20, 1:19 PM
dim committed rGd95da99b9159: Fix the build with gcc when `-Wredundant-decls` is passed (authored by dim).
Fix the build with gcc when `-Wredundant-decls` is passed
Wed, Feb 20, 1:02 PM
dim committed rL354515: Fix the build with gcc when `-Wredundant-decls` is passed.
Fix the build with gcc when `-Wredundant-decls` is passed
Wed, Feb 20, 1:01 PM
dim closed D58425: Fix the build with gcc 8.x when `-Wredundant-decls` is passed.
Wed, Feb 20, 1:01 PM · Restricted Project, Restricted Project
dim commandeered D58425: Fix the build with gcc 8.x when `-Wredundant-decls` is passed.

I will update and commit.

Wed, Feb 20, 12:56 PM · Restricted Project, Restricted Project
dim created D58473: Fix a few swapped _LIBCPP_TEMPLATE_VIS attributes.
Wed, Feb 20, 12:48 PM
dim added a comment to D58425: Fix the build with gcc 8.x when `-Wredundant-decls` is passed.

In the case of <__locale>, __throw_runtime_error is already used in the file before its declaration, but via transitive includes, <stdexcept> is also included earlier, so it gets the duplicate declaration of __throw_runtime_error from there. I think we can just delete the __throw_runtime_error declaration from <__locale> altogether.

Wed, Feb 20, 4:03 AM · Restricted Project, Restricted Project

Wed, Feb 6

dim added inline comments to D57735: [X86] Add FPCW as a register and start using it as an implicit use on floating point instructions..
Wed, Feb 6, 12:58 PM · Restricted Project

Tue, Feb 5

dim added a comment to D57735: [X86] Add FPCW as a register and start using it as an implicit use on floating point instructions..

For what it's worth, this builds and tests correctly for me, and also appears to solve the test cases from bug 40206.

Tue, Feb 5, 2:49 AM · Restricted Project

Tue, Jan 29

dim committed rLLD352606: Recognize FreeBSD specific BFD names in OUTPUT_FORMAT.
Recognize FreeBSD specific BFD names in OUTPUT_FORMAT
Tue, Jan 29, 10:32 PM
dim committed rL352606: Recognize FreeBSD specific BFD names in OUTPUT_FORMAT.
Recognize FreeBSD specific BFD names in OUTPUT_FORMAT
Tue, Jan 29, 10:31 PM
dim closed D57283: Recognize FreeBSD specific BFD names in OUTPUT_FORMAT.
Tue, Jan 29, 10:31 PM
dim updated the diff for D57283: Recognize FreeBSD specific BFD names in OUTPUT_FORMAT.

Updated as @ruiu suggested.

Tue, Jan 29, 2:03 PM
dim updated the diff for D57283: Recognize FreeBSD specific BFD names in OUTPUT_FORMAT.

Rebased.

Tue, Jan 29, 9:41 AM
dim updated the diff for D57283: Recognize FreeBSD specific BFD names in OUTPUT_FORMAT.

Updated to address comments:

  • Replaced tuple with BfdDesc struct
  • Parse -freebsd suffix to determine OSABI
  • Add new case for elf-aarch64 (which used to be elf-aarch64-freebsd)
Tue, Jan 29, 3:08 AM

Mon, Jan 28

dim added inline comments to D57283: Recognize FreeBSD specific BFD names in OUTPUT_FORMAT.
Mon, Jan 28, 4:03 AM

Sat, Jan 26

dim created D57283: Recognize FreeBSD specific BFD names in OUTPUT_FORMAT.
Sat, Jan 26, 9:07 AM

Fri, Jan 25

dim committed rCRT352234: Fix XRayTest link on FreeBSD (and likely NetBSD too).
Fix XRayTest link on FreeBSD (and likely NetBSD too)
Fri, Jan 25, 11:36 AM
dim committed rL352234: Fix XRayTest link on FreeBSD (and likely NetBSD too).
Fix XRayTest link on FreeBSD (and likely NetBSD too)
Fri, Jan 25, 11:36 AM
dim closed D57181: Fix XRayTest link on FreeBSD (and likely NetBSD too).
Fri, Jan 25, 11:36 AM

Thu, Jan 24

dim created D57181: Fix XRayTest link on FreeBSD (and likely NetBSD too).
Thu, Jan 24, 12:38 PM

Jan 20 2019

dim accepted D56975: [Support] Reimplement getMainExecutable() using sysctl on NetBSD.

I can't vouch for the NetBSD part, but this definitely seems like a good idea to me. I'm unsure if the sysctl is already fixed on the FreeBSD side. @emaste any idea?

Jan 20 2019, 6:07 AM

Jan 7 2019

dim created D56398: Add new EINTEGRITY errno.
Jan 7 2019, 10:45 AM

Dec 25 2018

dim updated subscribers of rL329339: [X86] Remove some InstRWs for plain store instructions on Sandy Bridge..

I'm not sure yet why, but this revision breaks unrolling of some loops in FreeBSD's lib/msun/ld80/e_powl.c, specifically the one in __polevll here, which gets expanded in two places, one instance with a count of 3:

Dec 25 2018, 5:56 AM

Dec 23 2018

dim committed rCRT350020: Set the default SANITIZER_CXX_ABI library to libc++ for FreeBSD, and.
Set the default SANITIZER_CXX_ABI library to libc++ for FreeBSD, and
Dec 23 2018, 3:54 AM
dim committed rL350020: Set the default SANITIZER_CXX_ABI library to libc++ for FreeBSD, and.
Set the default SANITIZER_CXX_ABI library to libc++ for FreeBSD, and
Dec 23 2018, 3:53 AM

Dec 20 2018

dim accepted D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI].
Dec 20 2018, 4:38 AM

Dec 16 2018

dim added a comment to D55576: [libcxx] [test] [support] Use socket()+bind() to create unix sockets portably.

@dim, thanks for the review. Should I also try removing the following restriction?

#if !defined(__APPLE__) && !defined(__FreeBSD__) // No support for domain sockets
        {env.create_socket("socket"), file_type::socket},
#endif
Dec 16 2018, 7:42 AM
dim accepted D55576: [libcxx] [test] [support] Use socket()+bind() to create unix sockets portably.

LGTM.

Dec 16 2018, 7:10 AM

Nov 20 2018

dim added a comment to D54724: [Driver] Automatically include C++ library dependencies.
In D54724#1303809, @dim wrote:

I think this is the wrong direction, placing "common" code in addCXXStdlibLinkDeps, which then has all kinds of ugly ifs and switches for different OSes? Let different OSes handle this in their own way, maybe.

You mean handling this in individual ToolChain subclasses? I've considered doing that. The reason I went with a single method is because we already use this approach for other types of runtimes like sanitizers, XRay, etc. There'd be still some duplication for handling different C++ libraries, but I'd be fine changing the implementation to use that approach if there's a strong preference for doing so.

Nov 20 2018, 11:00 PM

Nov 19 2018

dim added a comment to D54724: [Driver] Automatically include C++ library dependencies.

I think this is the wrong direction, placing "common" code in addCXXStdlibLinkDeps, which then has all kinds of ugly ifs and switches for different OSes? Let different OSes handle this in their own way, maybe.

Nov 19 2018, 10:54 PM

Nov 18 2018

dim accepted D54650: Swap order of discovering of -ltinfo and -lterminfo.

On FreeBSD, there is no libterminfo either, so LGTM.

Nov 18 2018, 3:25 AM

Oct 22 2018

dim committed rL345002: Don't mess up RelIplt symbols during relocatable processing.
Don't mess up RelIplt symbols during relocatable processing
Oct 22 2018, 10:56 PM
dim committed rLLD345002: Don't mess up RelIplt symbols during relocatable processing.
Don't mess up RelIplt symbols during relocatable processing
Oct 22 2018, 10:56 PM
dim closed D53515: Don't mess up RelIplt symbols during relocatable processing.
Oct 22 2018, 10:56 PM
dim created D53515: Don't mess up RelIplt symbols during relocatable processing.
Oct 22 2018, 11:05 AM

Oct 11 2018

dim added a comment to rL325887: [ELF] - Do not remove empty output sections that are explicitly assigned to….

I think that the inconsistency of linkers behavior shown above shows that LLD behavior is
not incorrect. It is different. But we never tried to be fully bug compatible with bfd/gold.
First of all the problem is caused by a weak assumption in the linker script, which assumes
that orphans are placed at the particular place before the assignment command,
and my feeling it should be fixed.

Oct 11 2018, 1:16 PM

Oct 8 2018

dim added a comment to rL325887: [ELF] - Do not remove empty output sections that are explicitly assigned to….

Here is the shortest test case I could come up with. (This uses ld.lld-r325886, but it could also use ld.lld 6.0.1.)

Oct 8 2018, 1:16 PM
dim added a comment to rL325887: [ELF] - Do not remove empty output sections that are explicitly assigned to….

I am still debugging it, but one observation to mention:

If you remove the .data1 : { *(.data1) } line from the script,
(https://github.com/freebsd/freebsd/blob/master/sys/conf/ldscript.i386#L141)
you'll get the same result as after this patch

.data1 is the empty section and it is anyways removed. But with this patch, it is done a bit earlier, what does not
allows our orphan placement algorithm to see/use it for finding the insertion point.

So it is just a luck that the script worked before this revision.

Oct 8 2018, 12:22 PM

Oct 6 2018

dim added a comment to rL325887: [ELF] - Do not remove empty output sections that are explicitly assigned to….

My guess it happens because of set_sysinit_set, set_sysuninit_set, set_pcpu, set_vnet are orphans (not listed in the linker script),
and our algorithm of placing the orphans started to place them in between of
(https://github.com/freebsd/freebsd/blob/master/sys/conf/ldscript.i386#L142)

_edata = .; PROVIDE (edata = .);
__bss_start = .;

for some reason. And honestly, I would not call this incorrect behavior, though I do not understand now how this patch could affect this.

Oct 6 2018, 11:58 AM
dim added a comment to rL325887: [ELF] - Do not remove empty output sections that are explicitly assigned to….

Furthermore, we have read-only and read/write set_ sections. BFD ld and older lld seem to figure these out, then place the read-only ones just after .rodata, and the read/write ones after .data. I am not sure if there is a way to distinguish between these in a linker script? The names always match set_*, but there is no different naming scheme for r/o and r/w sets.

What I meant is to specify them explicitly. You do not need to match the 'set_*' for that.
I modified the script from the reproduce file in the following way (added all set_* r/w sections before _edata symbol assignment):

...
  .data1          : { *(.data1) }
  
  set_sysinit_set    : { *(set_sysinit_set) }
  set_sysuninit_set  : { *(set_sysuninit_set ) }
  set_pcpu           : { *(set_pcpu) }
  set_vnet           : { *(set_sysinit_set) }
  
  _edata = .; PROVIDE (edata = .);
...

And that resolves the issue (at least _edata == 01e2ef78 now, I did not check the booting).
I think the same should be done for the rest (r/o) set_* sections for the safety and overall correctness of the script.

Speaking about some kind of auto distinguishing between r/o and r/w, I do not think it is possible.
The script may have ONLY_IF_RO and ONLY_IF_RW commands, but that is
about different thing and will not help here I believe.

Will the suggested solution work for you?

Oct 6 2018, 11:47 AM

Oct 2 2018

dim added a comment to rL325887: [ELF] - Do not remove empty output sections that are explicitly assigned to….

Two questions:

  1. Why don't you just list them in the script at the expected place? This will solve the issue and make the behavior explicit and cleaner I think.
Oct 2 2018, 9:41 AM

Oct 1 2018

dim updated subscribers of rL325887: [ELF] - Do not remove empty output sections that are explicitly assigned to….

This change breaks booting an lld-linked i386-freebsd kernel, apparently because it moves symbols around, while not updating the sections? For instance, with lld r325886, I have the following readelf output:

Oct 1 2018, 1:04 PM

Sep 22 2018

dim added a comment to D52394: [libcxx] Fix the definition of the check-cxx-abilist target on Darwin.

Ah, sorry about that! I should have realized this, but my CMake-fu is weak. :)

Sep 22 2018, 12:39 PM
dim committed rL342805: Similar to the handling of darwin target triples, strip the version.
Similar to the handling of darwin target triples, strip the version
Sep 22 2018, 7:39 AM
dim committed rCXX342805: Similar to the handling of darwin target triples, strip the version.
Similar to the handling of darwin target triples, strip the version
Sep 22 2018, 7:39 AM
dim committed rCXX342803: Remove a bunch of empty subdirectories. NFCI..
Remove a bunch of empty subdirectories. NFCI.
Sep 22 2018, 6:39 AM
dim committed rL342803: Remove a bunch of empty subdirectories. NFCI..
Remove a bunch of empty subdirectories. NFCI.
Sep 22 2018, 6:36 AM

Sep 21 2018

dim updated subscribers of D52240: Partial Fix for PR#38964.
In D52240#1242341, @dim wrote:

Hmm, I tried on macOS 10.13.6 with Xcode 9.4.1 and Apple LLVM version 9.1.0 (clang-902.0.39.2), using stock libc++ r342744, but that already failed:

ninja: Entering directory `/Users/dim/obj/llvm-342744-trunk-darwin17-x86_64-ninja-rel-1'
[1/1] Testing ABI compatibility...
FAILED: projects/libcxx/lib/abi/CMakeFiles/check-cxx-abilist
cd /Users/dim/obj/llvm-342744-trunk-darwin17-x86_64-ninja-rel-1/projects/libcxx/lib/abi && /Users/dim/tmp/llvm/projects/libcxx/utils/sym_diff.py --only-stdlib-symbols --strict /Users/dim/tmp/llvm/projects/libcxx/lib/abi/x86_64-apple-darwin.v1.abilist /Users/dim/obj/llvm-342744-trunk-darwin17-x86_64-ninja-rel-1/lib/libc++.1.dylib
Symbol added: __ZNSt3__16__itoa8__u32toaEjPc
    {'type': 'FUNC', 'is_defined': True, 'name': '__ZNSt3__16__itoa8__u32toaEjPc'}

Symbol added: __ZNSt3__16__itoa8__u64toaEyPc
    {'type': 'FUNC', 'is_defined': True, 'name': '__ZNSt3__16__itoa8__u64toaEyPc'}

Summary
    Added:   2
    Removed: 0
    Changed: 0
Symbols added.

So I assume the ABI is already broken in some way...

Sep 21 2018, 1:53 PM
dim updated subscribers of D52240: Partial Fix for PR#38964.

Marshall, can you confirm that the change does not break check-cxx-abilist on OS X. I'm fine with the change if that's not broken.

Sep 21 2018, 11:55 AM
dim committed rLLD342746: Align AArch64 and i386 image base to superpage.
Align AArch64 and i386 image base to superpage
Sep 21 2018, 10:00 AM
dim committed rL342746: Align AArch64 and i386 image base to superpage.
Align AArch64 and i386 image base to superpage
Sep 21 2018, 10:00 AM
dim closed D50297: Align AArch64 and i386 image base to superpage.
Sep 21 2018, 9:59 AM

Sep 18 2018

dim added a comment to D52240: Partial Fix for PR#38964.

Built with mkdir build && cd build && cmake -G Ninja .. && ninja, the resulting libc++.so.1 has the following additional symbols:

Sep 18 2018, 12:16 PM
dim retitled D52240: Partial Fix for PR#38964 from Partial Fix for PR#39864 to Partial Fix for PR#38964.
Sep 18 2018, 12:16 PM

Sep 16 2018

dim added a comment to D50297: Align AArch64 and i386 image base to superpage.

So, any more actions to take, or can I commit this?

Sep 16 2018, 1:42 AM

Sep 1 2018

dim committed rL341279: For the 2018 Developers' Meeting page, use https:// links for the W3C.
For the 2018 Developers' Meeting page, use https:// links for the W3C
Sep 1 2018, 7:32 AM

Aug 29 2018

dim added a comment to D50297: Align AArch64 and i386 image base to superpage.

Oh, I didn't notice that you are trying to make a change for i386, not for x86-64. What is your motivation to use superpages for 32-bit applications? I believe that the applications you want to use superpages are large programs and naturally be 64-bit, so I wonder if this change is actually useful.

Aug 29 2018, 3:48 AM

Aug 28 2018

dim retitled D50297: Align AArch64 and i386 image base to superpage from On FreeBSD, align AArch64 and i386 image base to superpage to Align AArch64 and i386 image base to superpage.
Aug 28 2018, 1:03 PM
dim updated the diff for D50297: Align AArch64 and i386 image base to superpage.

Update all tests to match current output.

Aug 28 2018, 9:06 AM

Aug 15 2018

dim accepted D50799: Fix for PR 38495: <ctime> no longer compiles on FreeBSD, due to lack of timespec_get().

LGTM.

Aug 15 2018, 2:14 PM
dim committed rCXX339794: For FreeBSD, don't define _M in nasty_macros.hpp.
For FreeBSD, don't define _M in nasty_macros.hpp
Aug 15 2018, 10:32 AM
dim committed rL339794: For FreeBSD, don't define _M in nasty_macros.hpp.
For FreeBSD, don't define _M in nasty_macros.hpp
Aug 15 2018, 10:31 AM

Aug 7 2018

dim added a comment to D50297: Align AArch64 and i386 image base to superpage.

Looking at this a bit more, I see that it is unconditionally setting the DefaultImage base for all platforms, which cannot be right. I didn't notice this when it was committed into FreeBSD, but it doesn't matter there, of course. I'm not sure if there is a good way to override this setting on a per-platform basis. Maybe just if (os == FreeBSD) DefaultImageBase=x?

Is there any reason that this value doesn't work for other operating systems? I guess the new image base values work everywhere. If that's the case, I'd change the default so that we have less moving parts in the linker.

Aug 7 2018, 10:42 PM

Aug 4 2018

dim updated subscribers of rL330566: [Atomics] warn about atomic accesses using libcalls.

@t.p.northover, I'm seeing this warning now on some code in FreeBSD, but the variable in question is perfectly aligned, so there should be no penalty at all. Does this warning check the actual variable being accessed in any way?

Aug 4 2018, 12:06 PM
dim added a comment to D50297: Align AArch64 and i386 image base to superpage.

Looking at this a bit more, I see that it is unconditionally setting the DefaultImage base for all platforms, which cannot be right. I didn't notice this when it was committed into FreeBSD, but it doesn't matter there, of course. I'm not sure if there is a good way to override this setting on a per-platform basis. Maybe just if (os == FreeBSD) DefaultImageBase=x?

Aug 4 2018, 11:38 AM
dim added a comment to D48433: [ELF] - Report unimplemented -z options..

Ah, only now I've noticed that in the FreeBSD kernel link, we've been using the unsupported -z common-page-size= option:

Aug 4 2018, 9:47 AM
dim added a comment to D50297: Align AArch64 and i386 image base to superpage.

Note that we have already committed this in FreeBSD, see https://reviews.freebsd.org/D16385 and https://reviews.freebsd.org/rS337282.

Aug 4 2018, 6:04 AM
dim created D50297: Align AArch64 and i386 image base to superpage.
Aug 4 2018, 6:04 AM

Jul 2 2018

dim added a comment to D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.
In D48806#1149655, @dim wrote:
In D48806#1149021, @dim wrote:

Sorry for not getting to this one earlier, indeed it fixes the deadlock for me too!

Now the only "big" thing left is the hundreds of:

==41641==AddressSanitizer CHECK failed: /share/dim/src/llvm/trunk/projects/compiler-rt/lib/asan/asan_posix.cc:48 "((0)) == ((pthread_key_create(&tsd_key, destructor)))" (0x0, 0x4e)
`

failures. :-)

I guess it s FreeBSD 11.2 ? Seems his fix working on 10.4, will check on 11.x when I can ... otherwise there is always the thread local solution I threw a while ago. WE might need to come up with another solution anyway @krytarowski reports it is still an issue on NetBSD.

This is on FreeBSD 12-CURRENT, but it could also show the same issue on 11.x.

Jul 2 2018, 2:37 PM
dim added a comment to D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.
In D48806#1149021, @dim wrote:

Sorry for not getting to this one earlier, indeed it fixes the deadlock for me too!

Now the only "big" thing left is the hundreds of:

==41641==AddressSanitizer CHECK failed: /share/dim/src/llvm/trunk/projects/compiler-rt/lib/asan/asan_posix.cc:48 "((0)) == ((pthread_key_create(&tsd_key, destructor)))" (0x0, 0x4e)
`

failures. :-)

I guess it s FreeBSD 11.2 ? Seems his fix working on 10.4, will check on 11.x when I can ... otherwise there is always the thread local solution I threw a while ago. WE might need to come up with another solution anyway @krytarowski reports it is still an issue on NetBSD.

Jul 2 2018, 9:35 AM

Jul 1 2018

dim added a comment to D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.

Sorry for not getting to this one earlier, indeed it fixes the deadlock for me too!

Jul 1 2018, 2:24 PM

Jun 29 2018

dim committed rC336008: Request init/fini array on FreeBSD 12 and later.
Request init/fini array on FreeBSD 12 and later
Jun 29 2018, 12:23 PM
dim committed rL336008: Request init/fini array on FreeBSD 12 and later.
Request init/fini array on FreeBSD 12 and later
Jun 29 2018, 12:23 PM
dim closed D24867: Request init/fini array on FreeBSD 12 and later.
Jun 29 2018, 12:22 PM

Jun 15 2018

dim added a comment to rL325240: Add Xray instrumentation support to FreeBSD.

FWIW, after this commit, on FreeBSD 12.0-CURRENT, most (if not all) ASan tests hang in 'urdlck' state. I'm still investigating.

Jun 15 2018, 12:22 PM

Jun 13 2018

dim committed rCRT334659: Disable MSan tests of prlimit on FreeBSD.
Disable MSan tests of prlimit on FreeBSD
Jun 13 2018, 2:42 PM
dim committed rL334659: Disable MSan tests of prlimit on FreeBSD.
Disable MSan tests of prlimit on FreeBSD
Jun 13 2018, 2:42 PM

Jun 9 2018

dim created D47987: Provide only one declaration of __throw_runtime_error.
Jun 9 2018, 2:49 PM

May 14 2018

dim updated subscribers of D46857: [CMake] Detect the compiler runtime and standard library.

Do we still leave the defaults for particular OSes here? I'm asking because for example in FreeBSD, we use libcxxrt, but you *won't* find it in linker output, since our libc++.so is a linker script:

$ clang++ /usr/local/share/cmake/Modules/DummyCXXFile.cxx -###
FreeBSD clang version 6.0.0 (tags/RELEASE_600/final 326565) (based on LLVM 6.0.0)
Target: x86_64-unknown-freebsd11.2
Thread model: posix
InstalledDir: /usr/bin
 "/usr/bin/clang++" "-cc1" "-triple" "x86_64-unknown-freebsd11.2" "-emit-obj" "-mrelax-all" "-disable-free" "-disable-llvm-verifier" "-discard-value-names" "-main-file-name" "DummyCXXFile.cxx" "-mrelocation-model" "static" "-mthread-model" "posix" "-mdisable-fp-elim" "-masm-verbose" "-mconstructor-aliases" "-munwind-tables" "-target-cpu" "x86-64" "-dwarf-column-info" "-debugger-tuning=gdb" "-resource-dir" "/usr/lib/clang/6.0.0" "-internal-isystem" "/usr/include/c++/v1" "-fdeprecated-macro" "-fdebug-compilation-dir" "/home/dim/src/llvm/trunk" "-ferror-limit" "19" "-fmessage-length" "160" "-fobjc-runtime=gnustep" "-fcxx-exceptions" "-fexceptions" "-fdiagnostics-show-option" "-fcolor-diagnostics" "-o" "/tmp/DummyCXXFile-5ffab3.o" "-x" "c++" "/usr/local/share/cmake/Modules/DummyCXXFile.cxx"
 "/usr/bin/ld" "--eh-frame-hdr" "-dynamic-linker" "/libexec/ld-elf.so.1" "--hash-style=both" "--enable-new-dtags" "-o" "a.out" "/usr/lib/crt1.o" "/usr/lib/crti.o" "/usr/lib/crtbegin.o" "-L/usr/lib" "/tmp/DummyCXXFile-5ffab3.o" "-lc++" "-lm" "-lgcc" "--as-needed" "-lgcc_s" "--no-as-needed" "-lc" "-lgcc" "--as-needed" "-lgcc_s" "--no-as-needed" "/usr/lib/crtend.o" "/usr/lib/crtn.o"

E.g., you see -lc++, and our /usr/lib/libc++.so contains:

$ cat /usr/lib/libc++.so
/* $FreeBSD: stable/11/lib/libc++/libc++.ldscript 253917 2013-08-03 16:23:43Z dim $ */
GROUP ( /usr/lib/libc++.so.1 /usr/lib/libcxxrt.so )

So what would check_link_libraries find in this case?

May 14 2018, 4:56 PM

May 13 2018

dim committed rL332197: Follow-up to rL332176 by adding a test case for PR37264..
Follow-up to rL332176 by adding a test case for PR37264.
May 13 2018, 7:36 AM

May 12 2018

dim committed rL332176: Clear converters map after X86 Domain Reassignment to avoid crashes.
Clear converters map after X86 Domain Reassignment to avoid crashes
May 12 2018, 1:03 PM
dim closed D46425: Clear converters map after X86 Domain Reassignment to avoid crashes.
May 12 2018, 1:03 PM
dim added inline comments to rL330269: [x86] Switch EFLAGS copy lowering to use reg-reg form of testing for.
May 12 2018, 12:20 PM
dim added inline comments to D46425: Clear converters map after X86 Domain Reassignment to avoid crashes.
May 12 2018, 12:15 PM
dim updated the diff for D46425: Clear converters map after X86 Domain Reassignment to avoid crashes.

Use DeleteContainerSeconds instead of rolling our own.

May 12 2018, 12:13 PM

May 11 2018

dim added a comment to D46425: Clear converters map after X86 Domain Reassignment to avoid crashes.

Ping.

May 11 2018, 2:19 PM

May 10 2018

dim added a comment to rL326644: Adding Msan support to FreeBSD.

Sorry for reacting rather late to this, but I'm getting:

May 10 2018, 8:53 AM

May 9 2018

dim accepted D46623: Omit PT_NOTE for SHT_NOTE without SHF_ALLOC.

I'm fine with this, and also with committing it into FreeBSD's copy of lld, but I'd like to see the opinion of @ruiu and/or @grimar too. (I take it @espindola is no longer being monitored...)

May 9 2018, 3:44 AM

May 7 2018

dim added a comment to D24867: Request init/fini array on FreeBSD 12 and later.

Brooks, I can commit this if you prefer. Maybe it can go into 6.0.2 still...

May 7 2018, 11:59 AM

May 4 2018

dim created D46425: Clear converters map after X86 Domain Reassignment to avoid crashes.
May 4 2018, 5:26 AM

Apr 25 2018

dim added a comment to D45652: Asan, fix FreeBSD support.

Do we know why pthread_{get,set}specific fails now? And would it make sense to use tls more broadly (not just on FreeBSD)?

Apr 25 2018, 10:31 AM

Apr 12 2018

dim added inline comments to rL329673: [x86] Model the direction flag (DF) separately from the rest of EFLAGS..
Apr 12 2018, 11:32 AM
dim added inline comments to rL329673: [x86] Model the direction flag (DF) separately from the rest of EFLAGS..
Apr 12 2018, 11:29 AM

Apr 11 2018

dim committed rL329827: Document -std= values for different languages.
Document -std= values for different languages
Apr 11 2018, 10:25 AM
dim committed rC329827: Document -std= values for different languages.
Document -std= values for different languages
Apr 11 2018, 10:25 AM
dim closed D45406: Document -std= values for different languages.
Apr 11 2018, 10:25 AM
dim added a comment to D45406: Document -std= values for different languages.

Ping

Apr 11 2018, 2:05 AM

Apr 9 2018

dim added a comment to D45406: Document -std= values for different languages.

So, does this look good enough to commit?

Apr 9 2018, 10:54 AM

Apr 8 2018

dim updated the diff for D45406: Document -std= values for different languages.

Attempt to put the standard values in to definition lists. In the HTML
output, this looks fairly nice, but as a man page, it seems a bit
strange, for example:

Apr 8 2018, 4:08 AM