Page MenuHomePhabricator

dim (Dimitry Andric)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 15 2014, 12:19 PM (311 w, 4 h)

Recent Activity

Thu, Mar 26

dim added a comment to D65034: [libc++] use constexpr for sizeof comparisons.

FYI FreeBSD is one of the few OSes that enables -Wsystem-headers by default, *and* uses libc++ as its default C++ library. So we've already submitted a bunch of warning fixes for libc++.

Thu, Mar 26, 8:06 AM

Fri, Mar 20

dim added a comment to D6379: Only warn about DWARF2 supporting one section per compilation unit for code sections.

Hello, we're hitting this issue when assembling the Linux kernel with Clang (https://github.com/ClangBuiltLinux/linux/issues/716). I'd be happy to dust this off/rebase and add tests. @dim would you prefer to do it or shall I?

Fri, Mar 20, 4:50 PM

Wed, Mar 18

dim accepted D75425: [docs] Added solutions to slow build under common problems.

As far as I'm concerned, most suggestions make sense, and it is good to have this information clearly stated.

Wed, Mar 18, 2:07 PM · Restricted Project

Tue, Mar 17

dim committed rG585a3cc31bb4: Fix -Wdeprecated-copy-dtor and -Wdeprecated-dynamic-exception-spec warnings. (authored by dim).
Fix -Wdeprecated-copy-dtor and -Wdeprecated-dynamic-exception-spec warnings.
Tue, Mar 17, 11:18 AM
dim closed D76150: Fix -Wdeprecated-copy-dtor and -Wdeprecated-dynamic-exception-spec warnings..
Tue, Mar 17, 11:17 AM · Restricted Project

Mon, Mar 16

dim added a comment to D76192: Use maximum compression when packaging release tarballs..

This seems reasonable, but can we wait until after the release? I would prefer to not change these things right now.

Mon, Mar 16, 3:09 AM · Restricted Project

Sun, Mar 15

dim created D76192: Use maximum compression when packaging release tarballs..
Sun, Mar 15, 4:48 AM · Restricted Project
dim created D76191: Turn off core dumps before starting the main body of test-release.sh..
Sun, Mar 15, 3:43 AM · Restricted Project

Fri, Mar 13

dim added a comment to D76150: Fix -Wdeprecated-copy-dtor and -Wdeprecated-dynamic-exception-spec warnings..

Note: one thing that I am unsure about is the _NOEXCEPT after some of the copy constructors. I only applied those to classes that have other _NOEXCEPT constructors, but copying may involve other things that could throw.

Fri, Mar 13, 11:49 AM · Restricted Project
dim created D76150: Fix -Wdeprecated-copy-dtor and -Wdeprecated-dynamic-exception-spec warnings..
Fri, Mar 13, 11:49 AM · Restricted Project

Feb 15 2020

dim committed rG62654cab7e65: Restore functionality of --sysroot on FreeBSD after b18cb9c47 (authored by dim).
Restore functionality of --sysroot on FreeBSD after b18cb9c47
Feb 15 2020, 4:55 PM
dim updated subscribers of rL211743: Land support for ARM EHABI unwinding for libunwind..
Feb 15 2020, 6:10 AM

Feb 10 2020

dim added a comment to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
In D73990#1868085, @dim wrote:

This breaks in our downstream runtimes builds for armv7-none-linux-androideabi16. FYI

Can you point me to some build logs? (I didn't receive any failure mails from bots yet.)

Posted a fix at D74358

Feb 10 2020, 2:51 PM · Restricted Project, Restricted Project
dim added a comment to D74358: Marking internal_dlinfo as unsupported for Android sanitizers to fix runtimes builds..

Yeah sorry, I used a whitelist instead, here: rG52f2df1ecdd79cc550b694ab280f3b0396d7cf9a

Feb 10 2020, 2:51 PM · Restricted Project, Restricted Project
dim committed rG52f2df1ecdd7: [Sanitizers] Get link map on FreeBSD and NetBSD via documented API (authored by dim).
[Sanitizers] Get link map on FreeBSD and NetBSD via documented API
Feb 10 2020, 2:44 PM
dim committed rG480eea4e45bc: Revert "[Sanitizers] Get link map on FreeBSD via documented API" (authored by dim).
Revert "[Sanitizers] Get link map on FreeBSD via documented API"
Feb 10 2020, 2:33 PM
dim added a reverting change for rG92e267a94dc4: [Sanitizers] Get link map on FreeBSD via documented API: rG480eea4e45bc: Revert "[Sanitizers] Get link map on FreeBSD via documented API".
Feb 10 2020, 2:33 PM
dim added a comment to D73990: [Sanitizers] Get link map on FreeBSD via documented API.

This breaks in our downstream runtimes builds for armv7-none-linux-androideabi16. FYI

Feb 10 2020, 2:15 PM · Restricted Project, Restricted Project
dim committed rG92e267a94dc4: [Sanitizers] Get link map on FreeBSD via documented API (authored by dim).
[Sanitizers] Get link map on FreeBSD via documented API
Feb 10 2020, 10:23 AM
dim closed D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 10 2020, 10:23 AM · Restricted Project, Restricted Project

Feb 9 2020

dim added a comment to D73990: [Sanitizers] Get link map on FreeBSD via documented API.

Ping, can we get this committed then? :)

Feb 9 2020, 11:20 PM · Restricted Project, Restricted Project

Feb 7 2020

dim updated the diff for D73990: [Sanitizers] Get link map on FreeBSD via documented API.

Remove stray newline.

Feb 7 2020, 10:35 AM · Restricted Project, Restricted Project
dim updated the diff for D73990: [Sanitizers] Get link map on FreeBSD via documented API.

Add better NetBSD implementation of internal_dlinfo().

Feb 7 2020, 10:35 AM · Restricted Project, Restricted Project

Feb 6 2020

dim updated the diff for D73990: [Sanitizers] Get link map on FreeBSD via documented API.
  • Rebase onto reformatted files.
  • Add internal_dlinfo() for FreeBSD and NetBSD, with stubs for other platforms.
  • Add GET_LINK_MAP_BY_DLOPEN_HANDLE() macro for NetBSD.
Feb 6 2020, 2:25 PM · Restricted Project, Restricted Project
dim added a reviewer for D73990: [Sanitizers] Get link map on FreeBSD via documented API: krytarowski.
Feb 6 2020, 2:25 PM · Restricted Project, Restricted Project
dim committed rG924c9030a89d: [compiler-rt] clang-format FreeBSD-specific sanitizer sources (authored by dim).
[compiler-rt] clang-format FreeBSD-specific sanitizer sources
Feb 6 2020, 1:49 PM
dim added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 6 2020, 6:35 AM · Restricted Project, Restricted Project
dim added a comment to D73990: [Sanitizers] Get link map on FreeBSD via documented API.

Btw, note that according to the Linux dlinfo() manpage, it also has RTLD_DI_LINKMAP as a documented way to get at the link map. Maybe we should generalize this in a follow-up review?

Feb 6 2020, 6:17 AM · Restricted Project, Restricted Project
dim added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 6 2020, 6:08 AM · Restricted Project, Restricted Project

Feb 4 2020

dim added inline comments to D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 4 2020, 10:17 PM · Restricted Project, Restricted Project
dim committed rG8a1f4feb1b74: [compiler-rt] Fix sanitizer_common build for FreeBSD (authored by dim).
[compiler-rt] Fix sanitizer_common build for FreeBSD
Feb 4 2020, 1:56 PM
dim updated the diff for D73990: [Sanitizers] Get link map on FreeBSD via documented API.

Formatting.

Feb 4 2020, 1:55 PM · Restricted Project, Restricted Project
dim updated the diff for D73990: [Sanitizers] Get link map on FreeBSD via documented API.

Cast return value to link_map to avoid call site errors.

Feb 4 2020, 1:55 PM · Restricted Project, Restricted Project
dim created D73990: [Sanitizers] Get link map on FreeBSD via documented API.
Feb 4 2020, 1:09 PM · Restricted Project, Restricted Project

Jan 29 2020

dim committed rG5e416ba943b7: Define _LIBCPP_HAS_TIMESPEC_GET for FreeBSD when appropriate (authored by dim).
Define _LIBCPP_HAS_TIMESPEC_GET for FreeBSD when appropriate
Jan 29 2020, 11:03 PM
dim closed D71522: Define _LIBCPP_HAS_TIMESPEC_GET for FreeBSD when appropriate.
Jan 29 2020, 11:03 PM · Restricted Project

Jan 24 2020

dim added inline comments to D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time.
Jan 24 2020, 12:55 PM · Restricted Project, Restricted Project, Restricted Project
dim committed rG58592f6c4924: Include <cstdlib> for std::abort() in clangd (authored by dim).
Include <cstdlib> for std::abort() in clangd
Jan 24 2020, 11:58 AM

Jan 17 2020

dim added a comment to D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash.

Aha, which version of clang-cl are you using? With the released version of clang-cl 9.0.1, I get a warning instead of an error:

Jan 17 2020, 5:22 AM · Restricted Project
dim added a comment to D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash.

Eh, no it does not crash clang, at least not here? Instead it gives you a compile error, as it should:

Jan 17 2020, 3:02 AM · Restricted Project

Jan 9 2020

dim added inline comments to D71827: [clang] avoid strict aliasing violation in assert.
Jan 9 2020, 11:01 AM · Restricted Project

Jan 8 2020

dim accepted D72014: [PowerPC]: Add powerpcspe target triple subarch component.

LGTM.

Jan 8 2020, 9:43 AM · Restricted Project, Restricted Project

Dec 15 2019

dim added a comment to D68741: test-release.sh s/http/https/.

We should abandon this, for e.g. 9.0.1 the whole Base_url variable has become unused. :)

Dec 15 2019, 3:38 AM · Restricted Project
dim created D71522: Define _LIBCPP_HAS_TIMESPEC_GET for FreeBSD when appropriate.
Dec 15 2019, 3:29 AM · Restricted Project
dim updated the summary of D71522: Define _LIBCPP_HAS_TIMESPEC_GET for FreeBSD when appropriate.
Dec 15 2019, 3:29 AM · Restricted Project

Nov 18 2019

dim committed rGee31adb7fa42: Populate CUDA flags on FreeBSD too, as many other toolchains do. (authored by dim).
Populate CUDA flags on FreeBSD too, as many other toolchains do.
Nov 18 2019, 12:58 PM
dim closed D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do..
Nov 18 2019, 12:58 PM · Restricted Project
dim added a comment to D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do..
In D69990#1750348, @tra wrote:

LGTM, though I'm curious if it's particularly useful. Last time I checked NVIDIA didn't ship libcudart for FreeBSD and without it it's rather cumbersome to use CUDA in practice.

Nov 18 2019, 12:57 PM · Restricted Project
dim added reviewers for D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.: tra, yaxunl, ABataev.

Adding a few people who might know a bit more about CUDA specific things. Please take a look if this review makes any sense, thanks. :)

Nov 18 2019, 11:08 AM · Restricted Project
dim updated the diff for D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do..
  • Add cuda options test, copied from cuda-options.cu.
Nov 18 2019, 11:08 AM · Restricted Project

Nov 17 2019

dim edited reviewers for D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do., added: dim, emaste; removed: Restricted Project.

I'll work on a test.

Nov 17 2019, 11:09 PM · Restricted Project

Nov 13 2019

dim committed rG3db6783d8a7d: Check result of emitStrLen before passing it to CreateGEP (authored by dim).
Check result of emitStrLen before passing it to CreateGEP
Nov 13 2019, 11:11 PM
dim closed D70143: Check result of emitStrLen before passing it to CreateGEP.
Nov 13 2019, 11:11 PM · Restricted Project, Restricted Project
dim updated the diff for D70143: Check result of emitStrLen before passing it to CreateGEP.

Now opt supports -disable-builtin, move the test to llvm/test/Transforms/InstCombine.

Nov 13 2019, 1:19 PM · Restricted Project, Restricted Project
dim committed rG597b77fb7ff9: Add -disable-builtin option to opt (authored by dim).
Add -disable-builtin option to opt
Nov 13 2019, 12:33 PM
dim closed D70193: Add -disable-builtin option to opt.
Nov 13 2019, 12:33 PM · Restricted Project
dim updated the summary of D70193: Add -disable-builtin option to opt.
Nov 13 2019, 12:09 PM · Restricted Project
dim updated subscribers of D56398: Add new EINTEGRITY errno.

Sorry if this is a basic question, but why are we trying to provide EINTEGRITY in libc++'s errno.h header at all? I don't see this being part of the C or C++ Standard.

Nov 13 2019, 11:27 AM
dim added a comment to D70143: Check result of emitStrLen before passing it to CreateGEP.

I submitted D70193 for adding a -disable-builtin option to opt. Once that is committed, this review can continue.

Nov 13 2019, 11:18 AM · Restricted Project, Restricted Project
dim created D70193: Add -disable-builtin option to opt.
Nov 13 2019, 11:18 AM · Restricted Project
dim added inline comments to D70143: Check result of emitStrLen before passing it to CreateGEP.
Nov 13 2019, 6:53 AM · Restricted Project, Restricted Project

Nov 12 2019

dim added a comment to D56398: Add new EINTEGRITY errno.

cem == dim?

Nov 12 2019, 2:03 PM
dim added a comment to D70143: Check result of emitStrLen before passing it to CreateGEP.

This should have a llvm ir test in llvm/test/transforms/instcombine i think, not a clang test.

Nov 12 2019, 2:03 PM · Restricted Project, Restricted Project
dim created D70143: Check result of emitStrLen before passing it to CreateGEP.
Nov 12 2019, 1:34 PM · Restricted Project, Restricted Project
dim accepted D70110: [Driver][FreeBSD] Enable unwind tables on !amd64.

LGTM

Nov 12 2019, 10:09 AM · Restricted Project

Nov 8 2019

dim added a comment to D56398: Add new EINTEGRITY errno.

Another attempt to grab your attention :)

Nov 8 2019, 10:35 AM

Oct 29 2019

dim added a comment to D60220: [CUDA][Windows] Final fix for bug 38811 (Step 3 of 3).

Hm, I would really say that __isnan and the other __ prefixed functions are Linuxisms, or more accurately, glibc-isms. They also don't exist on e.g. macOS:

Oct 29 2019, 10:17 AM · Restricted Project
dim added a comment to D56398: Add new EINTEGRITY errno.

Ping :)

Oct 29 2019, 6:06 AM

Oct 21 2019

dim added a comment to D56398: Add new EINTEGRITY errno.

N.B., EOWNERDEAD and ENOTRECOVERABLE are already defined on lines 158 and line 170, respectively.

Oct 21 2019, 12:39 PM
dim updated the diff for D56398: Add new EINTEGRITY errno.

Get rid of the ELAST trickery, which is hard to maintain, and does not
appear to serve any purpose. There is no mention of ELAST in the C or
C++ standards, as far as I know.

Oct 21 2019, 11:43 AM
dim added a comment to D56398: Add new EINTEGRITY errno.

Now that I'm reading this header again, why do we even bother to define ELAST at all? On Linux, there is no such thing, while on BSDs and macOS, it is already provided by the regular errno.h.

Oct 21 2019, 11:33 AM

Oct 19 2019

dim committed rGd5367db95c42: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD (authored by dim).
Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD
Oct 19 2019, 3:59 AM
dim committed rL375340: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD
Oct 19 2019, 3:59 AM
dim closed D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Oct 19 2019, 3:58 AM · Restricted Project

Oct 18 2019

dim updated the diff for D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.

Rewrite the __FreeBSD_version condition to be more straightforward.

Oct 18 2019, 12:49 PM · Restricted Project
dim added inline comments to D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Oct 18 2019, 12:40 PM · Restricted Project
dim created D69174: Refine check for `_LIBCPP_C_HAS_NO_GETS` on FreeBSD.
Oct 18 2019, 8:47 AM · Restricted Project
dim abandoned D47987: Provide only one declaration of __throw_runtime_error.

Obsoleted by D58425 (and rCXX354515).

Oct 18 2019, 2:52 AM

Oct 10 2019

dim committed rGa42942e0ecd6: Fix process launch failure on FreeBSD after r365761 (authored by dim).
Fix process launch failure on FreeBSD after r365761
Oct 10 2019, 1:27 PM
dim closed D68723: Fix process launch failure on FreeBSD after r365761.
Oct 10 2019, 1:27 PM · Restricted Project
dim committed rL374444: Fix process launch failure on FreeBSD after r365761.
Fix process launch failure on FreeBSD after r365761
Oct 10 2019, 1:26 PM
dim updated the diff for D68723: Fix process launch failure on FreeBSD after r365761.

Convert m_(monitor|operation)_thread to llvm::Optional<>.

Oct 10 2019, 12:30 PM · Restricted Project

Oct 9 2019

dim created D68723: Fix process launch failure on FreeBSD after r365761.
Oct 9 2019, 1:10 PM · Restricted Project
dim added a comment to D68723: Fix process launch failure on FreeBSD after r365761.
Oct 9 2019, 1:10 PM · Restricted Project
dim added a comment to rL365761: [LLDB] Fix FreeBSD build..

@devnexen this appears to cause https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241137, where simply launching a process in lldb triggers a failure:

Expected<T> must be checked before access or destruction.
Expected<T> value was in success state. (Note: Expected<T> values in success mode must still be checked prior to being destroyed).
Oct 9 2019, 11:54 AM
dim updated subscribers of rL365761: [LLDB] Fix FreeBSD build..

@devnexen this appears to cause https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241137, where simply launching a process in lldb triggers a failure:

Oct 9 2019, 11:54 AM

Oct 8 2019

dim closed D68045: [builtins] Unbreak build on FreeBSD armv7 after D60351.

For some reason this didn't get closed by Phabricator. Committed in rCRT374070.

Oct 8 2019, 9:58 AM · Restricted Project, Restricted Project
dim added a comment to rL372886: [DAGCombiner] add one-use restriction to vector transform with cheap extract.

@spatel, you mentioned this should be in 9.0.1, with "A noticeable perf regression for x86 vector code made it into the 9.0 release". Does it have a lot of influence on compile-time performance, or run-time performance? (I'd like to pull this one into FreeBSD's clang 9.0.)

Oct 8 2019, 12:29 AM

Oct 2 2019

dim updated subscribers of D68269: [libc++abi] Do not define new/delete by default.

Pinging vendors for awareness of the change: @phosek @danalbert @dim

This is going in soon and will require a change in how you build libc++abi if you need new/delete definitions to be provided in libc++abi.so, namely to use -DLIBCXXABI_ENABLE_NEW_DELETE_DEFINITIONS=ON when you configure CMake for libc++abi.

The upshot of this change is that by default, we won't get both definitions in libc++ and libc++abi, thus unbreaking the default configuration.

Oct 2 2019, 2:34 PM · Restricted Project

Sep 26 2019

dim added a comment to D68051: [OpenMP] Don't link libm with -Wl,--as-needed on FreeBSD.

LGTM from a FreeBSD point of view. :)

Sep 26 2019, 10:28 AM · Restricted Project

Sep 25 2019

dim added a comment to D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper.

This works for me, and also for the original test case from https://bugs.freebsd.org/240764.

Sep 25 2019, 2:20 AM · Restricted Project

Sep 18 2019

dim committed rGab8b456ce5d8: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher (authored by dim).
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Sep 18 2019, 2:05 PM
dim committed rGf88e75525d25: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher (authored by dim).
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Sep 18 2019, 1:58 PM
dim committed rL372261: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Sep 18 2019, 1:57 PM
dim closed D67119: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
Sep 18 2019, 1:57 PM · Restricted Project, Restricted Project
dim committed rL372260: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
On PowerPC, Secure-PLT by default for FreeBSD 13 and higher
Sep 18 2019, 1:57 PM
dim closed D67118: On PowerPC, Secure-PLT by default for FreeBSD 13 and higher.
Sep 18 2019, 1:57 PM · Restricted Project

Sep 10 2019

dim added a comment to rL363529: Re-commit r357452 (take 3): "SimplifyCFG SinkCommonCodeFromPredecessors: Also….

Third time's the charm.

Sep 10 2019, 12:37 PM

Sep 7 2019

dim committed rG5bd4a4806aaf: Remove ::gets for FreeBSD 13 and later (authored by dim).
Remove ::gets for FreeBSD 13 and later
Sep 7 2019, 3:18 PM
dim committed rL371324: Remove ::gets for FreeBSD 13 and later.
Remove ::gets for FreeBSD 13 and later
Sep 7 2019, 3:17 PM