Page MenuHomePhabricator

nickdesaulniers (Nick Desaulniers)
Google

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2018, 4:23 PM (92 w, 2 d)

Recent Activity

Fri, Jan 17

nickdesaulniers added a comment to D72344: [LLD][ELF][ARM][AArch64] Only round up ThunkSection Size when large OS..

Thanks everyone!

Fri, Jan 17, 8:45 AM · Restricted Project
nickdesaulniers added inline comments to D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes.
Fri, Jan 17, 8:38 AM · Restricted Project

Thu, Jan 16

nickdesaulniers added a comment to D70072: [ARM] Improve codegen of volatile load/store of i64.

@vhscampos sorry, we're getting new/different warnings now seemingly with this patch: https://github.com/ClangBuiltLinux/linux/issues/838

Warning: index register overlaps transfer register

Thu, Jan 16, 11:11 AM · Restricted Project

Tue, Jan 14

nickdesaulniers added a comment to D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes.

Having thought about it I am happy with this being the full fix

Tue, Jan 14, 1:28 PM · Restricted Project
nickdesaulniers added a reviewer for D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes: lhames.
Tue, Jan 14, 1:28 PM · Restricted Project

Mon, Jan 13

nickdesaulniers added a comment to D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes.

This is a partial fix for

Mon, Jan 13, 11:12 PM · Restricted Project
nickdesaulniers added a comment to D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes.

Thanks for the extensive tests. I might triple check the entity sizes to make sure they're correct, but the tests look pretty exhaustive to me and make sense.

Mon, Jan 13, 11:12 PM · Restricted Project
nickdesaulniers added a comment to D72656: Specify branch probabilities for callbr dests.

Cool, IIRC when upstream kernel devs took a look (via some objtool bug reports) they mentioned that our block placement was backwards. The callbr-asm-branch-folding.ll change makes the most sense to me; the indirect branch is moved out of the way. (Though I would have thought branch predictors assume forward branches are taken). Did this result in any measurable performance difference?

Mon, Jan 13, 10:25 PM · Restricted Project

Fri, Jan 10

nickdesaulniers added inline comments to D72220: [X86] Support function attribute "patchable-function-entry".
Fri, Jan 10, 10:03 AM · Restricted Project

Wed, Jan 8

nickdesaulniers accepted D72221: Support function attribute patchable_function_entry.

Thanks for all of the work that went into this. Looks like review comments have all been addressed.

Wed, Jan 8, 9:15 AM · Restricted Project

Mon, Jan 6

nickdesaulniers accepted D71849: Don't rely on '%l' modifiers to indicate a label reference.
Mon, Jan 6, 2:07 PM · Restricted Project
nickdesaulniers added inline comments to D71849: Don't rely on '%l' modifiers to indicate a label reference.
Mon, Jan 6, 1:29 PM · Restricted Project
nickdesaulniers added inline comments to D71849: Don't rely on '%l' modifiers to indicate a label reference.
Mon, Jan 6, 12:33 PM · Restricted Project
nickdesaulniers accepted D70072: [ARM] Improve codegen of volatile load/store of i64.

Thanks @vhscampos , I tested the new patch and could no longer reproduce the observed crashes. I'm not sure if I'm looking at the interdiff correctly, but consider adding additional test cases that properly describe and cover the breakage we observed.

Mon, Jan 6, 11:45 AM · Restricted Project
nickdesaulniers added inline comments to D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes.
Mon, Jan 6, 11:13 AM · Restricted Project
nickdesaulniers added a comment to D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable.

I laid out a series of three options before:

  • Emit different object-file sections for different mergeability settings.
  • Only mark an object-file section as mergeable if all the symbols in it would have the same mergeability settings.
  • Stop implicitly using mergeability for "ordinary" sections (i.e. sections other than the string section).

Of the above, I really think #2 is the only complete solution.

Can you explain why you think #1 is not "complete"? All three seem to establish correctness; I can see how giving up on the optimization (#3) is not a great solution, but #1 doesn't have that problem and actually preserves it in more places. To be clear, this is just taking advantage of the ability to have multiple sections with the same name in an ELF object file; they will still be assembled into a single section in the linked image.

My understanding is that changing the flags on an MCSection retroactively is pretty counter to the architecture, so I'm not sure how we'd actually achieve #2.

Mon, Jan 6, 11:12 AM · Restricted Project
nickdesaulniers added inline comments to D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes.
Mon, Jan 6, 11:03 AM · Restricted Project
nickdesaulniers added inline comments to D72221: Support function attribute patchable_function_entry.
Mon, Jan 6, 10:53 AM · Restricted Project
nickdesaulniers updated subscribers of D72220: [X86] Support function attribute "patchable-function-entry".
Mon, Jan 6, 10:44 AM · Restricted Project
nickdesaulniers added reviewers for D72215: [AArch64] Add function attribute "patchable-function-entry" to add NOPs at function entry: chill, peter.smith.
Mon, Jan 6, 10:16 AM · Restricted Project
nickdesaulniers added a comment to D72215: [AArch64] Add function attribute "patchable-function-entry" to add NOPs at function entry.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92424 for context.

Mon, Jan 6, 10:16 AM · Restricted Project
nickdesaulniers added inline comments to D72221: Support function attribute patchable_function_entry.
Mon, Jan 6, 10:06 AM · Restricted Project
nickdesaulniers added inline comments to D72221: Support function attribute patchable_function_entry.
Mon, Jan 6, 10:06 AM · Restricted Project
nickdesaulniers retitled D71849: Don't rely on '%l' modifiers to indicate a label reference from Don't rely on 'l'(ell) modifiers to indicate a label reference to Don't rely on '%l' modifiers to indicate a label reference.
Mon, Jan 6, 9:48 AM · Restricted Project
nickdesaulniers added a comment to D71849: Don't rely on '%l' modifiers to indicate a label reference.

Thanks for the fix. Two minor fixes requested, then should be good to land.

Mon, Jan 6, 9:47 AM · Restricted Project
nickdesaulniers added inline comments to D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination..
Mon, Jan 6, 9:37 AM · Restricted Project
nickdesaulniers accepted D69876: Allow output constraints on "asm goto".

No, thanks for the work on this @void !

Mon, Jan 6, 9:27 AM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes.

From https://reviews.llvm.org/D68101#1806135, I think a better approach would be to delay the emission of the "M" merge-able section flag unless all entries had the same size.

Mon, Jan 6, 9:27 AM · Restricted Project
nickdesaulniers added a comment to D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable.

Below is the code comment from the new patch explaining the new approach, please take a look and see if you have any questions/comments:

// If two globals with differing sizes end up in the same mergeable
// section that section can be assigned an incorrect entry size. Normally,
// the assembler avoids this by putting incompatible globals into
// differently named sections. However, globals can be explicitly assigned
// to a section by specifying the section name. In this case, if unique
// section names are available (-unique-section-names in LLVM) then we
// bin compatible globals into different mergeable sections with the same name.
Mon, Jan 6, 9:19 AM · Restricted Project

Dec 20 2019

nickdesaulniers added inline comments to D69876: Allow output constraints on "asm goto".
Dec 20 2019, 10:51 AM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D70072: [ARM] Improve codegen of volatile load/store of i64.

Hi Victor, we're observing a crash in Clang when compiling the Linux kernel bisected to this commit. Can you please revert?
See the trace in https://ci.linaro.org/job/tcwg_kernel-bisect-llvm-master-arm-next-allmodconfig/62/artifact/artifacts/build-bbcf1c3496ce2bd1ed87e8fb15ad896e279633ce/console.log grep for stack dump.

Dec 20 2019, 9:49 AM · Restricted Project
nickdesaulniers added a comment to D71627: [Clang FE, SystemZ] Recognize -mrecord-mcount CL option..

This is regressing linux kernel builds for multiple architectures. The linux kernel uses feature detection for compiler flags, basically invoking:

Dec 20 2019, 9:40 AM

Dec 19 2019

nickdesaulniers added a comment to D69876: Allow output constraints on "asm goto".

I'm not getting the Undefined temporary symbol in your example (even with optimizations):

[morbo@fawn:llvm-project] clang -o - -S ../bug.c
Dec 19 2019, 3:50 PM · Restricted Project, Restricted Project
nickdesaulniers requested changes to D69876: Allow output constraints on "asm goto".

Thinking hard about this, I think there's four cases we really need to think hard about:

  1. asm redirects control flow BEFORE assigning to output. ie.
Dec 19 2019, 10:32 AM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination..
Dec 19 2019, 10:13 AM · Restricted Project
nickdesaulniers added a comment to D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination..

Use -Wuninitialized.

Dec 19 2019, 9:33 AM · Restricted Project

Dec 17 2019

nickdesaulniers added a comment to D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination..

strange, the below test isn't warning for me with this patch applied:

$ clang -O2 foo.c -c
$ cat foo.c
int quux(void) {
  int y;
  asm volatile goto("ja %l1" : "=r"(y) ::: err);
  return y;
err:
  return y;
}
Dec 17 2019, 3:43 PM · Restricted Project
nickdesaulniers added inline comments to D69868: Allow "callbr" to return non-void values.
Dec 17 2019, 2:56 PM · Restricted Project, Restricted Project

Dec 13 2019

nickdesaulniers added a comment to D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable.

More info: https://docs.oracle.com/cd/E23824_01/html/819-0690/ggdlu.html

Dec 13 2019, 11:10 AM · Restricted Project

Dec 12 2019

nickdesaulniers added inline comments to D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination..
Dec 12 2019, 10:32 AM · Restricted Project

Dec 4 2019

nickdesaulniers added a comment to D70638: [Diagnostic] add a warning which warns about misleading indentation.

As an FYI, this appears to cause several false positive warnings with the Linux kernel:

../drivers/video/fbdev/core/fbmem.c:665:3: warning: misleading indentation; statement is not part of the previous 'else' [-Wmisleading-indentation]
        if (fb_logo.depth > 4 && depth > 4) {
        ^
../drivers/video/fbdev/core/fbmem.c:661:2: note: previous statement is here
        else
        ^
../drivers/video/fbdev/core/fbmem.c:1075:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
        return ret;
        ^
../drivers/video/fbdev/core/fbmem.c:1072:2: note: previous statement is here
        if (!ret)
        ^
2 warnings generated.

Corresponding to:

https://elixir.bootlin.com/linux/v5.4.1/source/drivers/video/fbdev/core/fbmem.c#L665

and

https://elixir.bootlin.com/linux/v5.4.1/source/drivers/video/fbdev/core/fbmem.c#L1072

Dec 4 2019, 10:28 AM · Restricted Project

Dec 3 2019

nickdesaulniers added a comment to D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable.

But ELF allows object files to contain an arbitrary number of what I've been calling "section units" that will be assembled into a single section in the image.

Dec 3 2019, 1:11 PM · Restricted Project
nickdesaulniers added a comment to D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable.

Just some more thoughts after being able to sleep on it.

Dec 3 2019, 10:42 AM · Restricted Project

Dec 2 2019

nickdesaulniers added a comment to D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable.

Given all that, this patch seems far too aggressive. While mergeable sections can be useful for optimizing arbitrary code that might not use a section, they are also extremely useful for optimizing the sorts of global tables that programmers frequently use explicit sections for. It seems to me that the right fix is to find the place that ensures that we don't put mergeable and non-mergeable objects in the same section unit (or at least conservatively makes the section unit non-mergeable) and fix it to consider entry size as well. That should be straightforward unless that place doesn't exist, in which case we have very serious problems.

Dec 2 2019, 3:39 PM · Restricted Project

Nov 25 2019

nickdesaulniers added a comment to D69868: Allow "callbr" to return non-void values.

Ping? :-)

Nov 25 2019, 10:45 AM · Restricted Project, Restricted Project

Nov 18 2019

nickdesaulniers added a comment to D65550: [AArch64] Do not emit '#' before immediates in inline asm.

So you could maybe do:

Nov 18 2019, 7:22 PM · Restricted Project
nickdesaulniers added inline comments to D69876: Allow output constraints on "asm goto".
Nov 18 2019, 2:04 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D69876: Allow output constraints on "asm goto".
Nov 18 2019, 11:18 AM · Restricted Project, Restricted Project
nickdesaulniers requested changes to D69868: Allow "callbr" to return non-void values.

The value returned by "callbr" is only valid on the "normal" path. Return

values used on "abnormal" paths are poisoned.

Nov 18 2019, 10:59 AM · Restricted Project, Restricted Project
nickdesaulniers accepted D69870: [builtins] Implement rounding mode support for i386/x86_64.

No more nits from me. Please wait for LGTM from ctopper for functional review.

Nov 18 2019, 10:05 AM · Restricted Project, Restricted Project

Nov 13 2019

nickdesaulniers added inline comments to D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 13 2019, 12:47 PM · Restricted Project, Restricted Project

Nov 12 2019

nickdesaulniers added a comment to D69411: [MC] Parse .if conditions with symbols in consecutive MCDataFragements.

Thanks for the summary.

Nov 12 2019, 9:41 AM · Restricted Project
nickdesaulniers accepted D70062: MCObjectStreamer: assign MCSymbols in the dummy fragment to offset 0..

Thanks, I tested the first two cases in https://bugs.llvm.org/show_bug.cgi?id=41825. I also did not see any more patterns of EmitLabel() followed by setOffset() in the tree. @peter.smith provides an excellent summary in https://reviews.llvm.org/D69411#1742030.

Nov 12 2019, 9:32 AM · Restricted Project

Nov 11 2019

nickdesaulniers added a comment to D69876: Allow output constraints on "asm goto".

I think -Wuninitialized (UninitializedValues.cpp) should be taught how to detect the use of output variables in error blocks, at least for trivial cases.

Actually, for some reason -- it looks like the warning is failing the wrong way right now, and emits an uninitialized use warning even where there shouldn't be one.

Nice catch! I updated the patch with a fix. PTAL.

Nov 11 2019, 2:29 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D70062: MCObjectStreamer: assign MCSymbols in the dummy fragment to offset 0..
Nov 11 2019, 10:59 AM · Restricted Project
nickdesaulniers committed rG49fb4a96e0b7: change LLVM_VERSION_SUFFIX default from svn to git (authored by nickdesaulniers).
change LLVM_VERSION_SUFFIX default from svn to git
Nov 11 2019, 9:17 AM
nickdesaulniers closed D70019: change LLVM_VERSION_SUFFIX default from svn to git.
Nov 11 2019, 9:17 AM · Restricted Project, Restricted Project

Nov 8 2019

nickdesaulniers created D70019: change LLVM_VERSION_SUFFIX default from svn to git.
Nov 8 2019, 10:35 AM · Restricted Project, Restricted Project
nickdesaulniers added a reviewer for D70019: change LLVM_VERSION_SUFFIX default from svn to git: hans.
Nov 8 2019, 10:35 AM · Restricted Project, Restricted Project
nickdesaulniers committed rG51adeae1c90c: remove redundant LLVM version from version string when setting CLANG_VENDOR (authored by nickdesaulniers).
remove redundant LLVM version from version string when setting CLANG_VENDOR
Nov 8 2019, 9:31 AM
nickdesaulniers closed D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR.
Nov 8 2019, 9:31 AM · Restricted Project

Nov 7 2019

nickdesaulniers added inline comments to D69868: Allow "callbr" to return non-void values.
Nov 7 2019, 2:45 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR.

Thanks for the review, leaving open for final comments, will merge tomorrow.

Nov 7 2019, 2:45 PM · Restricted Project
nickdesaulniers added a comment to D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR.

Just grabbed a version string off a MBP:

Nov 7 2019, 12:50 PM · Restricted Project
nickdesaulniers added a comment to D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR.

+1, Apple's clang has an #ifdef 0 around this code.

Nov 7 2019, 12:32 PM · Restricted Project

Nov 6 2019

nickdesaulniers added inline comments to D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR.
Nov 6 2019, 3:42 PM · Restricted Project
nickdesaulniers created D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR.
Nov 6 2019, 3:42 PM · Restricted Project
nickdesaulniers added inline comments to D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR.
Nov 6 2019, 3:42 PM · Restricted Project
nickdesaulniers added inline comments to D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 6 2019, 10:29 AM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D69411: [MC] Parse .if conditions with symbols in consecutive MCDataFragements.
Nov 6 2019, 10:09 AM · Restricted Project
nickdesaulniers added inline comments to D69411: [MC] Parse .if conditions with symbols in consecutive MCDataFragements.
Nov 6 2019, 10:09 AM · Restricted Project
nickdesaulniers added a reviewer for D69870: [builtins] Implement rounding mode support for i386/x86_64: nickdesaulniers.
Nov 6 2019, 9:59 AM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D69870: [builtins] Implement rounding mode support for i386/x86_64.
Nov 6 2019, 9:59 AM · Restricted Project, Restricted Project
nickdesaulniers edited reviewers for D69411: [MC] Parse .if conditions with symbols in consecutive MCDataFragements, added: peter.smith, MaskRay; removed: dschuff, sunfish.
Nov 6 2019, 9:31 AM · Restricted Project

Nov 5 2019

nickdesaulniers updated subscribers of D69411: [MC] Parse .if conditions with symbols in consecutive MCDataFragements.
Nov 5 2019, 12:01 PM · Restricted Project

Oct 30 2019

nickdesaulniers added a comment to D69296: [ARM] Uses "Sun Style" syntax for section switching.

Linux has been patched by to use normal section switching syntax https://lkml.org/lkml/2019/10/30/807. Abandon this LLVM patch as we should be fine without it.

Oct 30 2019, 11:31 AM · Restricted Project

Oct 29 2019

nickdesaulniers added a comment to D69296: [ARM] Uses "Sun Style" syntax for section switching.

The original patch looks fine because the SunStyleELFSectionSwitchSyntax functionality is already there. Now we start to add IsCompatibleWithSunStyleELFSectionSwitchSyntax... Have we communicated the Solaris assembler's .section syntax problem to the Linux community?

Oct 29 2019, 2:17 PM · Restricted Project
nickdesaulniers added a comment to D69411: [MC] Parse .if conditions with symbols in consecutive MCDataFragements.

There are also some test cases for other ISA's in https://bugs.llvm.org/show_bug.cgi?id=41825.

Oct 29 2019, 9:09 AM · Restricted Project

Oct 28 2019

nickdesaulniers added a reviewer for D69411: [MC] Parse .if conditions with symbols in consecutive MCDataFragements: nickdesaulniers.
Oct 28 2019, 12:35 PM · Restricted Project
nickdesaulniers added a comment to D69411: [MC] Parse .if conditions with symbols in consecutive MCDataFragements.

Thanks for the patch! Looks like this was much simpler to support than I expected.

Oct 28 2019, 12:21 PM · Restricted Project

Oct 25 2019

nickdesaulniers added inline comments to D69296: [ARM] Uses "Sun Style" syntax for section switching.
Oct 25 2019, 10:06 AM · Restricted Project

Oct 16 2019

nickdesaulniers added a comment to D69018: [AArch64] Fix offset calculation.

Likely also fixes regressions for aarch64 linux kernel builds: https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/246197698

Oct 16 2019, 4:23 PM · Restricted Project
nickdesaulniers added inline comments to rL369601: [TSan] #include header instead of forward declaring interceptees.
Oct 16 2019, 1:52 PM

Oct 14 2019

nickdesaulniers accepted D68764: [ARM][AsmParser] handles offset expression in parentheses.

Thanks for the patch and for following up on code review!

Oct 14 2019, 2:21 PM · Restricted Project

Oct 11 2019

nickdesaulniers added inline comments to D68764: [ARM][AsmParser] handles offset expression in parentheses.
Oct 11 2019, 2:04 PM · Restricted Project
nickdesaulniers updated the summary of D68884: Add support to -Wa,-W in clang.
Oct 11 2019, 1:24 PM · Restricted Project
nickdesaulniers added inline comments to D68764: [ARM][AsmParser] handles offset expression in parentheses.
Oct 11 2019, 9:10 AM · Restricted Project

Oct 10 2019

nickdesaulniers added inline comments to D68764: [ARM][AsmParser] handles offset expression in parentheses.
Oct 10 2019, 1:16 PM · Restricted Project
nickdesaulniers added a comment to D68764: [ARM][AsmParser] handles offset expression in parentheses.

Great test cases. Thanks for the patch!

Oct 10 2019, 1:07 PM · Restricted Project
nickdesaulniers added a comment to D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0.

This transformation seems to increase code size significantly. Is the snprintf "%s" pattern common enough? I suspect most projects have already used memccpy, stpncpy, strscpy, or strlcpy. For the few that don't, the performance probably does not matter.

Oct 10 2019, 12:59 PM · Restricted Project

Oct 7 2019

nickdesaulniers added a comment to D68410: [AttrDocs] document always_inline.

Also, I'm fairly certain __forceinline and always_inline, confusingly enough differ in semantics, with __forceinline only being a stronger hint on MSVC.

Oct 7 2019, 11:26 AM · Restricted Project

Oct 4 2019

nickdesaulniers added a reviewer for D68483: [IA] Recognize hexadecimal escape sequences: jcai19.
Oct 4 2019, 2:30 PM · Restricted Project

Oct 3 2019

nickdesaulniers added a reviewer for D67945: LowerTypeTests: Rename local functions to avoid collisions with identically named functions in ThinLTO modules.: dexonsmith.
Oct 3 2019, 3:38 PM · Restricted Project
nickdesaulniers added inline comments to D68410: [AttrDocs] document always_inline.
Oct 3 2019, 3:29 PM · Restricted Project
nickdesaulniers added reviewers for D68410: [AttrDocs] document always_inline: jyknight, lebedev.ri, ojeda, jdoerfert, erichkeane, dblaikie, kristina.
Oct 3 2019, 2:08 PM · Restricted Project
nickdesaulniers updated the diff for D68410: [AttrDocs] document always_inline.
  • add links
  • remove extra whitespace
  • rewording, split onto separate lines to ease code review
  • add spellings to heading
Oct 3 2019, 2:05 PM · Restricted Project
nickdesaulniers committed rGede784ff5a60: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a (authored by nickdesaulniers).
[AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a
Oct 3 2019, 1:11 PM
nickdesaulniers committed rL373655: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a.
[AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a
Oct 3 2019, 1:11 PM
nickdesaulniers closed D68356: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a.
Oct 3 2019, 1:11 PM · Restricted Project
nickdesaulniers updated the summary of D68410: [AttrDocs] document always_inline.
Oct 3 2019, 12:56 PM · Restricted Project