Page MenuHomePhabricator

nickdesaulniers (Nick Desaulniers)
Google

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2018, 4:23 PM (79 w, 3 d)

Recent Activity

Wed, Oct 16

nickdesaulniers added a comment to D69018: [AArch64] Fix offset calculation.

Likely also fixes regressions for aarch64 linux kernel builds: https://travis-ci.com/ClangBuiltLinux/continuous-integration/jobs/246197698

Wed, Oct 16, 4:23 PM · Restricted Project
nickdesaulniers added inline comments to rL369601: [TSan] #include header instead of forward declaring interceptees.
Wed, Oct 16, 1:52 PM

Mon, Oct 14

nickdesaulniers accepted D68764: [ARM][AsmParser] handles offset expression in parentheses.

Thanks for the patch and for following up on code review!

Mon, Oct 14, 2:21 PM · Restricted Project

Fri, Oct 11

nickdesaulniers added inline comments to D68764: [ARM][AsmParser] handles offset expression in parentheses.
Fri, Oct 11, 2:04 PM · Restricted Project
nickdesaulniers updated the summary of D68884: Add support to -Wa,-W in clang.
Fri, Oct 11, 1:24 PM · Restricted Project
nickdesaulniers added inline comments to D68764: [ARM][AsmParser] handles offset expression in parentheses.
Fri, Oct 11, 9:10 AM · Restricted Project

Thu, Oct 10

nickdesaulniers added inline comments to D68764: [ARM][AsmParser] handles offset expression in parentheses.
Thu, Oct 10, 1:16 PM · Restricted Project
nickdesaulniers added a comment to D68764: [ARM][AsmParser] handles offset expression in parentheses.

Great test cases. Thanks for the patch!

Thu, Oct 10, 1:07 PM · Restricted Project
nickdesaulniers added a comment to D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0.

This transformation seems to increase code size significantly. Is the snprintf "%s" pattern common enough? I suspect most projects have already used memccpy, stpncpy, strscpy, or strlcpy. For the few that don't, the performance probably does not matter.

Thu, Oct 10, 12:59 PM · Restricted Project

Mon, Oct 7

nickdesaulniers added a comment to D68410: [AttrDocs] document always_inline.

Also, I'm fairly certain __forceinline and always_inline, confusingly enough differ in semantics, with __forceinline only being a stronger hint on MSVC.

Mon, Oct 7, 11:26 AM · Restricted Project

Fri, Oct 4

nickdesaulniers added a reviewer for D68483: [IA] Recognize hexadecimal escape sequences: jcai19.
Fri, Oct 4, 2:30 PM · Restricted Project

Thu, Oct 3

nickdesaulniers added a reviewer for D67945: LowerTypeTests: Rename local functions to avoid collisions with identically named functions in ThinLTO modules.: dexonsmith.
Thu, Oct 3, 3:38 PM · Restricted Project
nickdesaulniers added inline comments to D68410: [AttrDocs] document always_inline.
Thu, Oct 3, 3:29 PM · Restricted Project
nickdesaulniers added reviewers for D68410: [AttrDocs] document always_inline: jyknight, lebedev.ri, ojeda, jdoerfert, erichkeane, dblaikie, kristina.
Thu, Oct 3, 2:08 PM · Restricted Project
nickdesaulniers updated the diff for D68410: [AttrDocs] document always_inline.
  • add links
  • remove extra whitespace
  • rewording, split onto separate lines to ease code review
  • add spellings to heading
Thu, Oct 3, 2:05 PM · Restricted Project
nickdesaulniers committed rGede784ff5a60: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a (authored by nickdesaulniers).
[AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a
Thu, Oct 3, 1:11 PM
nickdesaulniers committed rL373655: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a.
[AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a
Thu, Oct 3, 1:11 PM
nickdesaulniers closed D68356: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a.
Thu, Oct 3, 1:11 PM · Restricted Project
nickdesaulniers updated the summary of D68410: [AttrDocs] document always_inline.
Thu, Oct 3, 12:56 PM · Restricted Project
nickdesaulniers created D68410: [AttrDocs] document always_inline.
Thu, Oct 3, 11:37 AM · Restricted Project
nickdesaulniers updated the diff for D68356: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a.
  • fix two unit tests that needed updating
Thu, Oct 3, 10:01 AM · Restricted Project
nickdesaulniers added a comment to D68356: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a.

Sorry, this breaks:

Thu, Oct 3, 9:46 AM · Restricted Project
nickdesaulniers updated the summary of D68356: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a.
Thu, Oct 3, 9:00 AM · Restricted Project

Wed, Oct 2

nickdesaulniers updated the diff for D68356: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a.
  • git-clang-format HEAD~
Wed, Oct 2, 1:39 PM · Restricted Project
nickdesaulniers created D68356: [AArch64InstPrinter] prefer bfi to bfc for < armv8.2-a.
Wed, Oct 2, 1:39 PM · Restricted Project
nickdesaulniers added a comment to D67986: [InstCombine] snprintf (d, size, "%s", s) -> memccpy (d, s, '\0', size - 1), d[size - 1] = 0.

It sounds like memccpy is part of C20. Can we not do this transform unless LangOpt says we're C20 or greater? Otherwise the Linux kernel doesn't implement this routine.

Wed, Oct 2, 10:27 AM · Restricted Project

Tue, Oct 1

nickdesaulniers updated subscribers of D67469: [WIP][Debuginfo][LLD] Remove obsolete debug info while garbage collecting..
Tue, Oct 1, 11:02 PM · debug-info, lld, Restricted Project
nickdesaulniers accepted D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros.
Tue, Oct 1, 11:00 PM · Restricted Project
nickdesaulniers added inline comments to D68131: Switch lowering: omit range check for bit tests when default is unreachable (PR43129).
Tue, Oct 1, 1:25 PM · Restricted Project
nickdesaulniers added inline comments to D68131: Switch lowering: omit range check for bit tests when default is unreachable (PR43129).
Tue, Oct 1, 9:54 AM · Restricted Project

Mon, Sep 30

nickdesaulniers added inline comments to D68131: Switch lowering: omit range check for bit tests when default is unreachable (PR43129).
Mon, Sep 30, 2:33 PM · Restricted Project

Fri, Sep 27

nickdesaulniers added a comment to D68131: Switch lowering: omit range check for bit tests when default is unreachable (PR43129).

Thanks for the patch! Just some small thoughts on style.

Fri, Sep 27, 1:22 PM · Restricted Project

Wed, Sep 25

nickdesaulniers committed rG93d87260f1f7: [Verifier] add invariant check for callbr (authored by nickdesaulniers).
[Verifier] add invariant check for callbr
Wed, Sep 25, 3:28 PM
nickdesaulniers committed rL372923: [Verifier] add invariant check for callbr.
[Verifier] add invariant check for callbr
Wed, Sep 25, 3:28 PM
nickdesaulniers closed D67196: [Verifier] add invariant check for callbr.
Wed, Sep 25, 3:28 PM · Restricted Project
nickdesaulniers added a comment to D68050: WIP Make attribute target work better with AArch64.

Thanks for the patch. No comment if this is "the right thing to do," just basic code review comments.

Wed, Sep 25, 3:01 PM · Restricted Project

Mon, Sep 23

nickdesaulniers added a comment to D67196: [Verifier] add invariant check for callbr.

Bumping for code review

Mon, Sep 23, 1:09 PM · Restricted Project
nickdesaulniers added a comment to D67873: Allow llvm-objdump to run on executable files.

Please post patches with context.

Mon, Sep 23, 9:07 AM · Restricted Project

Sep 17 2019

nickdesaulniers added a reviewer for D67196: [Verifier] add invariant check for callbr: chandlerc.
Sep 17 2019, 10:35 PM · Restricted Project

Sep 12 2019

nickdesaulniers added inline comments to D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode.
Sep 12 2019, 1:38 PM · Restricted Project, Restricted Project
nickdesaulniers added reviewers for D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode: aaron.ballman, rsmith.
Sep 12 2019, 1:01 PM · Restricted Project, Restricted Project
nickdesaulniers committed rG5806022904bc: [Clang][CodeGen] support alias attribute w/ gnu_inline (authored by nickdesaulniers).
[Clang][CodeGen] support alias attribute w/ gnu_inline
Sep 12 2019, 12:54 PM
nickdesaulniers committed rL371766: [Clang][CodeGen] support alias attribute w/ gnu_inline.
[Clang][CodeGen] support alias attribute w/ gnu_inline
Sep 12 2019, 12:52 PM
nickdesaulniers closed D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline.
Sep 12 2019, 12:52 PM · Restricted Project, Restricted Project

Sep 11 2019

nickdesaulniers updated the diff for D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline.
  • adjust parens
Sep 11 2019, 1:49 PM · Restricted Project, Restricted Project
nickdesaulniers created D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline.
Sep 11 2019, 11:48 AM · Restricted Project, Restricted Project

Sep 6 2019

nickdesaulniers committed rL371288: Fix ndesaulniers svn account, s/ndesaulniers/nickdesaulniers.
Fix ndesaulniers svn account, s/ndesaulniers/nickdesaulniers
Sep 6 2019, 10:09 PM
nickdesaulniers committed rL371287: Request commit access for ndesaulniers.
Request commit access for ndesaulniers
Sep 6 2019, 10:06 PM
nickdesaulniers updated subscribers of D67306: [IfConversion] Correctly handle cases where analyzeBranch fails..

FWIW, I verified that this patch fixes pr/42012 and the test case pases. Thanks @eli.friedman !

Sep 6 2019, 5:16 PM · Restricted Project
nickdesaulniers updated the diff for D67196: [Verifier] add invariant check for callbr.
  • rebase
Sep 6 2019, 3:18 PM · Restricted Project
nickdesaulniers committed rG7a7bba289521: [IR] CallBrInst: scan+update arg list when indirect dest list changes (authored by nickdesaulniers).
[IR] CallBrInst: scan+update arg list when indirect dest list changes
Sep 6 2019, 2:52 PM
nickdesaulniers committed rL371262: [IR] CallBrInst: scan+update arg list when indirect dest list changes.
[IR] CallBrInst: scan+update arg list when indirect dest list changes
Sep 6 2019, 2:51 PM
nickdesaulniers closed D67252: [IR] CallBrInst: scan+update arg list when indirect dest list changes.
Sep 6 2019, 2:51 PM · Restricted Project
nickdesaulniers updated the diff for D67252: [IR] CallBrInst: scan+update arg list when indirect dest list changes.
  • git-clang-format HEAD~
Sep 6 2019, 2:24 PM · Restricted Project
nickdesaulniers updated the summary of D67252: [IR] CallBrInst: scan+update arg list when indirect dest list changes.
Sep 6 2019, 12:30 PM · Restricted Project
nickdesaulniers updated the diff for D67252: [IR] CallBrInst: scan+update arg list when indirect dest list changes.
  • updated commit message
Sep 6 2019, 12:30 PM · Restricted Project
nickdesaulniers added a comment to D67252: [IR] CallBrInst: scan+update arg list when indirect dest list changes.

I have verified this allows me to boot:

  • arm64 linux-next (this patch fixes this regression, the below I verified are not regressed)
  • x86_64 linux-next
  • arm linux-next
  • arm linux-next + CONFIG_JUMP_LABEL
  • arm64 linux
  • x86_64 linux
  • arm linux
  • arm linux + CONFIG_JUMP_LABEL
Sep 6 2019, 12:10 PM · Restricted Project
nickdesaulniers added inline comments to D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data.
Sep 6 2019, 10:45 AM · Restricted Project, Restricted Project
nickdesaulniers updated the diff for D67252: [IR] CallBrInst: scan+update arg list when indirect dest list changes.
  • rebase, add/clean up the commit message
Sep 6 2019, 10:17 AM · Restricted Project
nickdesaulniers added inline comments to D67252: [IR] CallBrInst: scan+update arg list when indirect dest list changes.
Sep 6 2019, 10:14 AM · Restricted Project
nickdesaulniers abandoned D62555: [TailDuplicator] prevent tail duplication for INLINEASM_BR.

@eli.friedman fixed this in r371111. Thanks Eli!

Sep 6 2019, 10:00 AM · Restricted Project

Sep 5 2019

nickdesaulniers updated subscribers of D67252: [IR] CallBrInst: scan+update arg list when indirect dest list changes.
Sep 5 2019, 6:24 PM · Restricted Project
nickdesaulniers created D67252: [IR] CallBrInst: scan+update arg list when indirect dest list changes.
Sep 5 2019, 6:24 PM · Restricted Project

Sep 4 2019

nickdesaulniers updated the diff for D67196: [Verifier] add invariant check for callbr.
  • fix my added unit test
Sep 4 2019, 4:36 PM · Restricted Project
nickdesaulniers updated the diff for D67196: [Verifier] add invariant check for callbr.
  • add unit test, add invariant to LangRef, remove "or jump" from LangRef (was never there)
Sep 4 2019, 4:27 PM · Restricted Project
nickdesaulniers added a comment to D67196: [Verifier] add invariant check for callbr.

Is this already documented in LangRef?

Sep 4 2019, 3:41 PM · Restricted Project
nickdesaulniers updated the diff for D67196: [Verifier] add invariant check for callbr.
  • rebase on master, run git-clang-format HEAD~
Sep 4 2019, 3:35 PM · Restricted Project
nickdesaulniers created D67196: [Verifier] add invariant check for callbr.
Sep 4 2019, 3:27 PM · Restricted Project

Aug 28 2019

nickdesaulniers accepted D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.

Ok, thanks for the iteration on code review.

Aug 28 2019, 6:41 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.

Looks good, will likely approve after these 2 questions.

Aug 28 2019, 4:36 PM · Restricted Project, Restricted Project

Aug 27 2019

nickdesaulniers added inline comments to D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
Aug 27 2019, 4:01 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
Aug 27 2019, 2:48 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
Aug 27 2019, 1:34 PM · Restricted Project, Restricted Project

Aug 26 2019

nickdesaulniers added inline comments to D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
Aug 26 2019, 10:40 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.
Aug 26 2019, 5:34 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM.

Cool, I look forward to checking for outdated __builtin_expects in the Linux kernel, if they exist!

Aug 26 2019, 3:16 PM · Restricted Project, Restricted Project

Aug 23 2019

nickdesaulniers accepted D66609: Allow Compiler.h to be included in C files and fix fallthrough warnings.
Aug 23 2019, 10:21 AM · Restricted Project
nickdesaulniers added a comment to D66613: [support][llvm-objcopy] Add support for shell wildcards.

! In D66613#1642709, @MaskRay wrote:

Also a question, for others as well: is this a feature we actually want to carry forward? Are there any users of this feature/is it useful? This isn't something I've come across as actually being used, though I'm happy to review it if is.

I have the same question.

Aug 23 2019, 9:28 AM · Restricted Project

Aug 22 2019

nickdesaulniers accepted D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).

Thanks for being responsive to all this code review! 💃🏽

Aug 22 2019, 4:57 PM · Restricted Project, Restricted Project
nickdesaulniers requested changes to D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
Aug 22 2019, 4:30 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
Aug 22 2019, 4:30 PM · Restricted Project, Restricted Project
nickdesaulniers committed rG2fb0cefb12c1: [Bugfix] fix r369705 unit test (authored by nickdesaulniers).
[Bugfix] fix r369705 unit test
Aug 22 2019, 4:24 PM
nickdesaulniers committed rL369713: [Bugfix] fix r369705 unit test.
[Bugfix] fix r369705 unit test
Aug 22 2019, 4:24 PM
nickdesaulniers closed D66622: [Bugfix] fix r369705 unit test.
Aug 22 2019, 4:24 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D66492: [Clang][CodeGen] set alias linkage on QualType.

@leonardchan thanks for the report, would you mind reviewing: https://reviews.llvm.org/D66622?

Aug 22 2019, 3:48 PM · Restricted Project, Restricted Project
nickdesaulniers created D66622: [Bugfix] fix r369705 unit test.
Aug 22 2019, 3:48 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D66186: [Sema] Don't warn on printf('%hd', [char]) (PR41467).
Aug 22 2019, 2:01 PM · Restricted Project, Restricted Project
nickdesaulniers committed rGf21bca02f7a9: [Clang][CodeGen] set alias linkage on QualType (authored by nickdesaulniers).
[Clang][CodeGen] set alias linkage on QualType
Aug 22 2019, 1:52 PM
nickdesaulniers committed rL369705: [Clang][CodeGen] set alias linkage on QualType.
[Clang][CodeGen] set alias linkage on QualType
Aug 22 2019, 1:51 PM
nickdesaulniers closed D66492: [Clang][CodeGen] set alias linkage on QualType.
Aug 22 2019, 1:51 PM · Restricted Project, Restricted Project
nickdesaulniers updated the diff for D66492: [Clang][CodeGen] set alias linkage on QualType.
  • add unit test for function
Aug 22 2019, 1:25 PM · Restricted Project, Restricted Project
nickdesaulniers accepted D66609: Allow Compiler.h to be included in C files and fix fallthrough warnings.
Aug 22 2019, 12:33 PM · Restricted Project
nickdesaulniers added a reviewer for D66492: [Clang][CodeGen] set alias linkage on QualType: erichkeane.
Aug 22 2019, 11:06 AM · Restricted Project, Restricted Project

Aug 21 2019

nickdesaulniers added inline comments to D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
Aug 21 2019, 12:36 PM · Restricted Project
nickdesaulniers added inline comments to D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
Aug 21 2019, 11:58 AM · Restricted Project

Aug 20 2019

nickdesaulniers accepted D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
Aug 20 2019, 2:48 PM · Restricted Project
nickdesaulniers updated the summary of D66492: [Clang][CodeGen] set alias linkage on QualType.
Aug 20 2019, 12:54 PM · Restricted Project, Restricted Project
nickdesaulniers created D66492: [Clang][CodeGen] set alias linkage on QualType.
Aug 20 2019, 12:45 PM · Restricted Project, Restricted Project
nickdesaulniers requested changes to D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.
Aug 20 2019, 11:55 AM · Restricted Project
nickdesaulniers accepted D66487: Fix -Wimplicit-fallthrough warnings in regcomp.c.

Thanks for fixing the build!

Aug 20 2019, 11:28 AM · Restricted Project