Page MenuHomePhabricator

nickdesaulniers (Nick Desaulniers)
Google

Projects

User does not belong to any projects.

User Details

User Since
Apr 13 2018, 4:23 PM (220 w, 4 d)

Recent Activity

Thu, Jun 30

nickdesaulniers accepted D119296: KCFI sanitizer.

I see you modified the mir parser & printer; consider adding a .mir test.

Thu, Jun 30, 11:21 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

Herald added a project to D101427: Linux support for mimalloc as a custom allocator: Restricted Project.

This is patch is interesting to me because builds of llvm statically linked against musl have numerous memory allocation related functions in their top 20 functions sampled in builds of the Linux kernel.

Tue, Jun 21, 7:14 PM · Restricted Project, Restricted Project

Fri, Jun 17

nickdesaulniers added a comment to D128029: [AArch64] Add target feature "all".

Do we have equivalent "all" features for other architectures? It might be nice to have an interface architectures can provide to list a list of all possible features. Then we have one place to keep up to date, then other call sites can share that code. That might help us notice sooner when the "all" list is missing a new addition if there's more than one user, eventually.

Fri, Jun 17, 10:37 AM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D128030: [llvm-objdump] Default to --mattr=+all for AArch64.
Fri, Jun 17, 10:34 AM · Restricted Project, Restricted Project
nickdesaulniers updated subscribers of D128029: [AArch64] Add target feature "all".
Fri, Jun 17, 9:26 AM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D128029: [AArch64] Add target feature "all".

Honestly, I think this feature list should just exist in the disassembler. Is this generally useful when building code? I don't think so; it's meaning and ABI will change over time as more extensions are added to the architecture.

Fri, Jun 17, 9:26 AM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D128029: [AArch64] Add target feature "all".

Should https://reviews.llvm.org/D128030 be marked in phab as a child to this patch, to show the dependency?

Fri, Jun 17, 9:22 AM · Restricted Project, Restricted Project

Tue, Jun 14

nickdesaulniers added a comment to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

If the GCC developers split this into two distinct flags, should we land something we're just going to have to turn around and modify to match the new flags/semantics they've created?

Tue, Jun 14, 10:14 AM · Restricted Project, Restricted Project

Wed, Jun 8

nickdesaulniers added a comment to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

As for SOCK_MAXADDRLEN, that's a horrid hack, and the definition of struct sockaddr needs to change. :)

Do we want some builtin define so headers can check if we're in -fstrict-flex-arrays mode? It might be hard to mess with the definitions otherwise.

Wed, Jun 8, 11:45 AM · Restricted Project, Restricted Project

Jun 3 2022

nickdesaulniers committed rG1a216dc8910f: llvm: cmake: set CMP0114 to OLD to avoid warning (authored by nickdesaulniers).
llvm: cmake: set CMP0114 to OLD to avoid warning
Jun 3 2022, 9:46 AM · Restricted Project, Restricted Project
nickdesaulniers closed D126923: llvm: cmake: set CMP0114 to OLD to avoid warning.
Jun 3 2022, 9:45 AM · Restricted Project, Restricted Project

Jun 2 2022

nickdesaulniers requested review of D126923: llvm: cmake: set CMP0114 to OLD to avoid warning.
Jun 2 2022, 2:40 PM · Restricted Project, Restricted Project

May 31 2022

nickdesaulniers accepted D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

Thanks again Phoebe for the patch!

May 31 2022, 9:48 AM · Restricted Project, Restricted Project, Restricted Project

May 27 2022

nickdesaulniers requested changes to D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

Let's get this rebased on top of D126511.

May 27 2022, 10:30 AM · Restricted Project, Restricted Project, Restricted Project
nickdesaulniers accepted D126511: [ARM][AArch64] Change -mharden-sls= to use err_drv_unsupported_option_argument.
May 27 2022, 10:18 AM · Restricted Project, Restricted Project

May 26 2022

nickdesaulniers added inline comments to D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.
May 26 2022, 2:33 PM · Restricted Project, Restricted Project, Restricted Project
nickdesaulniers accepted D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

Nice work Phoebe; thank you very much for this patch!

May 26 2022, 11:21 AM · Restricted Project, Restricted Project, Restricted Project

May 24 2022

nickdesaulniers added a comment to D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

Diff 431607 boots for me in QEMU (triple checked that CONFIG_CC_HAS_SLS=y AND CONFIG_SLS=y were set this time ;) ).

May 24 2022, 1:38 PM · Restricted Project, Restricted Project, Restricted Project

May 23 2022

nickdesaulniers added a comment to D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

Therefore, I wonder if it wouldn't be better to name this -mharden-sls=retbr for more consistency across architectures?

May 23 2022, 11:10 AM · Restricted Project, Restricted Project, Restricted Project
nickdesaulniers added a comment to D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`.

Thanks for the patch!

May 23 2022, 11:03 AM · Restricted Project, Restricted Project, Restricted Project

May 19 2022

nickdesaulniers added inline comments to D125421: [TableGen] Add generation of argument register lists.
May 19 2022, 12:22 PM · Restricted Project, Restricted Project
nickdesaulniers accepted D124836: [AArch64] Add support for -fzero-call-used-regs.

Don't forget to rebase this on top of https://reviews.llvm.org/D125421.

May 19 2022, 12:19 PM · Restricted Project, Restricted Project, Restricted Project
nickdesaulniers accepted D125421: [TableGen] Add generation of argument register lists.
May 19 2022, 12:19 PM · Restricted Project, Restricted Project
nickdesaulniers updated subscribers of D125982: [SystemZ] Bugfix for symbolic displacments..
May 19 2022, 9:45 AM · Restricted Project, Restricted Project

May 16 2022

nickdesaulniers added a comment to D125727: [clang] Avoid suggesting typoed directives in `.S` files.

pushed 45e01ce5fe6a5e4dc25ffdf626caa344fbcb93dd

May 16 2022, 3:47 PM · Restricted Project, Restricted Project
nickdesaulniers committed rG45e01ce5fe6a: [clang] Avoid suggesting typoed directives in `.S` files (authored by ken-matsui).
[clang] Avoid suggesting typoed directives in `.S` files
May 16 2022, 3:47 PM · Restricted Project, Restricted Project
nickdesaulniers closed D125727: [clang] Avoid suggesting typoed directives in `.S` files.
May 16 2022, 3:47 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D125727: [clang] Avoid suggesting typoed directives in `.S` files.

sorted, will commit soon

May 16 2022, 3:38 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D125727: [clang] Avoid suggesting typoed directives in `.S` files.

Sorry, it looks like arcanist or my PHP runtime was auto updated on my host and has regressed. I need to sort that out first.

May 16 2022, 3:35 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D125727: [clang] Avoid suggesting typoed directives in `.S` files.

I do not have permission to land this patch, so could you please do it on my behalf?

May 16 2022, 3:33 PM · Restricted Project, Restricted Project
nickdesaulniers accepted D125727: [clang] Avoid suggesting typoed directives in `.S` files.

thanks for the patch!

May 16 2022, 3:28 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D125727: [clang] Avoid suggesting typoed directives in `.S` files.
May 16 2022, 3:21 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D125727: [clang] Avoid suggesting typoed directives in `.S` files.
May 16 2022, 3:03 PM · Restricted Project, Restricted Project
nickdesaulniers retitled D125727: [clang] Avoid suggesting typoed directives in `.S` files from Avoid suggesting typoed directives in `.S` files to [clang] Avoid suggesting typoed directives in `.S` files.
May 16 2022, 2:33 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D125727: [clang] Avoid suggesting typoed directives in `.S` files.
May 16 2022, 2:31 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D125727: [clang] Avoid suggesting typoed directives in `.S` files.
May 16 2022, 2:31 PM · Restricted Project, Restricted Project
nickdesaulniers added a reviewer for D125727: [clang] Avoid suggesting typoed directives in `.S` files: nickdesaulniers.
May 16 2022, 2:30 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D125727: [clang] Avoid suggesting typoed directives in `.S` files.
May 16 2022, 2:30 PM · Restricted Project, Restricted Project

May 11 2022

nickdesaulniers added inline comments to D125421: [TableGen] Add generation of argument register lists.
May 11 2022, 5:18 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D125421: [TableGen] Add generation of argument register lists.
May 11 2022, 5:15 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D125421: [TableGen] Add generation of argument register lists.
May 11 2022, 4:20 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D125421: [TableGen] Add generation of argument register lists.
May 11 2022, 3:48 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D125421: [TableGen] Add generation of argument register lists.
May 11 2022, 3:02 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D124836: [AArch64] Add support for -fzero-call-used-regs.

I'll split off the TableGen changes into a separate patch. It will supersede those changes here, so it shouldn't delay other reviews here. :-)

May 11 2022, 1:58 PM · Restricted Project, Restricted Project, Restricted Project
nickdesaulniers added a comment to D124836: [AArch64] Add support for -fzero-call-used-regs.

I still think this would be easier to review if the isArgumentRegister tablegen changes were separated out into a distinct parent patch and then the existing x86 implementation updated to use, then this would rebased on top of as a child patch.

May 11 2022, 12:23 PM · Restricted Project, Restricted Project, Restricted Project

May 10 2022

nickdesaulniers committed rGc167c0a4dcdb: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters (authored by nickdesaulniers).
[BuildLibCalls] infer inreg param attrs from NumRegisterParameters
May 10 2022, 4:36 PM · Restricted Project, Restricted Project
nickdesaulniers closed D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters.
May 10 2022, 4:36 PM · Restricted Project, Restricted Project
nickdesaulniers updated the diff for D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters.
  • rename fn
May 10 2022, 4:20 PM · Restricted Project, Restricted Project
nickdesaulniers committed rG6baaad740a5a: [Bitcode] Include indirect users of BlockAddresses in bitcode (authored by twd2).
[Bitcode] Include indirect users of BlockAddresses in bitcode
May 10 2022, 4:04 PM · Restricted Project, Restricted Project
nickdesaulniers closed D124878: [Bitcode] Include indirect users of BlockAddresses in bitcode.
May 10 2022, 4:04 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters.

I can't find any libcalls with i64 arguments we emit in IR (on 32-bit targets).

Should I drop the getTypeAllocSize related check for now, if we can't provide test coverage? (I guess I could write a unittest, but plz no).

I guess you could replace it with an assertion? I think I'm fine leaving it without an explicit testcase, though.

May 10 2022, 3:41 PM · Restricted Project, Restricted Project
nickdesaulniers updated the diff for D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters.
  • don't re-attribute varargs, add assertion for params larger than word size
May 10 2022, 3:41 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D124878: [Bitcode] Include indirect users of BlockAddresses in bitcode.

And, a small question: should we use SmallSetVector instead in SmallPtrSet<Function *, 4> BlockAddressUsers; to make sure that the order of users encoded in the bitcode is independent of the internal algorithm of SmallPtrSet?

We don't iterate BlockAddressUsersVisited; I think the code is fine as is. Am I missing something?

It's BlockAddressUsers in Line 3368, your patch added it.

May 10 2022, 2:47 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D124878: [Bitcode] Include indirect users of BlockAddresses in bitcode.

Thank you all for reviewing.

May 10 2022, 2:01 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters.

I can't find any libcalls with i64 arguments we emit in IR (on 32-bit targets).

May 10 2022, 1:46 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters.
May 10 2022, 1:41 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters.

Do you need to exclude varargs functions?

May 10 2022, 1:28 PM · Restricted Project, Restricted Project
nickdesaulniers updated the diff for D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters.
  • add tests for non-int params (ldexp) and varargs (sprintf)
May 10 2022, 1:26 PM · Restricted Project, Restricted Project
nickdesaulniers updated the diff for D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters.
  • remove unused include, save Module*
May 10 2022, 11:44 AM · Restricted Project, Restricted Project
nickdesaulniers updated the diff for D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters.
  • rewrite logic to closer match X86TargetLowering::markLibCallAttributes
May 10 2022, 11:41 AM · Restricted Project, Restricted Project
nickdesaulniers accepted D124878: [Bitcode] Include indirect users of BlockAddresses in bitcode.
May 10 2022, 10:15 AM · Restricted Project, Restricted Project

May 9 2022

nickdesaulniers updated subscribers of D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters.
May 9 2022, 6:48 PM · Restricted Project, Restricted Project
nickdesaulniers requested review of D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters.
May 9 2022, 6:47 PM · Restricted Project, Restricted Project
nickdesaulniers accepted D125142: [clang][auto-init] Remove -enable flag for "zero" mode.

Worth mentioning the deprecation plans in clang/docs/ReleaseNotes.rst and updaing the commit message+description on phab?

May 9 2022, 12:52 PM · Restricted Project, Restricted Project
nickdesaulniers accepted D125167: [WIP] Fix member access of anonymous struct/union fields in C.

Consider adding an AST test; that was something that came up in my patch https://reviews.llvm.org/D95408.

May 9 2022, 12:10 PM · Restricted Project, Restricted Project
nickdesaulniers abandoned D95408: [Sema][C] members of anonymous struct inherit QualType.

Prefer https://reviews.llvm.org/D125167.

May 9 2022, 12:05 PM · Restricted Project, Restricted Project
nickdesaulniers accepted D125142: [clang][auto-init] Remove -enable flag for "zero" mode.

It looks like clang still produces meaningful diagnostics from -Wuninitialized and -Wsometimes-uninitialized even with -ftrivial-auto-var-init=zero. Same for [clang-diagnostic-sometimes-uninitialized], [clang-analyzer-core.uninitialized.UndefReturn], and [clang-diagnostic-uninitialized].

May 9 2022, 10:02 AM · Restricted Project, Restricted Project

May 6 2022

nickdesaulniers updated subscribers of D125142: [clang][auto-init] Remove -enable flag for "zero" mode.
May 6 2022, 4:41 PM · Restricted Project, Restricted Project

May 5 2022

nickdesaulniers added inline comments to D125038: [Instrumentation] Share InstrumentationIRBuilder between TSan and SanCov.
May 5 2022, 2:18 PM · Restricted Project, Restricted Project
nickdesaulniers accepted D125038: [Instrumentation] Share InstrumentationIRBuilder between TSan and SanCov.
May 5 2022, 1:27 PM · Restricted Project, Restricted Project
nickdesaulniers committed rG18fd09ab64b0: [X86SchedSandyBridge] update cost of COPY to 1 cycle from 0 (authored by nickdesaulniers).
[X86SchedSandyBridge] update cost of COPY to 1 cycle from 0
May 5 2022, 11:15 AM · Restricted Project, Restricted Project
nickdesaulniers closed D122350: [X86SchedSandyBridge] update cost of COPY to 1 cycle from 0.
May 5 2022, 11:14 AM · Restricted Project, Restricted Project
nickdesaulniers committed rG617edfa48111: [x86][scheduler] Add MIR test for 41914 (authored by nickdesaulniers).
[x86][scheduler] Add MIR test for 41914
May 5 2022, 11:06 AM · Restricted Project, Restricted Project
nickdesaulniers closed D122348: [x86][scheduler] Add MIR test for 41914.
May 5 2022, 11:06 AM · Restricted Project, Restricted Project

May 4 2022

nickdesaulniers accepted D124937: [ThreadSanitizer] Add fallback DebugLocation for instrumentation calls.
May 4 2022, 2:23 PM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D124878: [Bitcode] Include indirect users of BlockAddresses in bitcode.

Please add a test for:

@foo = global i8* blockaddress(@repro, %label)
May 4 2022, 2:23 PM · Restricted Project, Restricted Project

May 3 2022

nickdesaulniers added a comment to D124878: [Bitcode] Include indirect users of BlockAddresses in bitcode.

Thanks for the patch! Indeed, the users _might_ be Constants rather than just Instructions. One thing to think about is that you can declare global Constants. I used the dyn_cast<Instruction> to check that this was not the case. I think you'll need to differentiate that, too. Meaning, if the user is a Constant, are the Constant's users Instructions (or not if simply GlobalVar).

May 3 2022, 2:35 PM · Restricted Project, Restricted Project
nickdesaulniers retitled D122350: [X86SchedSandyBridge] update cost of COPY to 1 cycle from 0 from [WIP][X86SchedSandyBridge] update cost of COPY to 1 cycle from 0 to [X86SchedSandyBridge] update cost of COPY to 1 cycle from 0.
May 3 2022, 1:56 PM · Restricted Project, Restricted Project
nickdesaulniers updated the diff for D122350: [X86SchedSandyBridge] update cost of COPY to 1 cycle from 0.
  • fix up tests
May 3 2022, 1:55 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D124836: [AArch64] Add support for -fzero-call-used-regs.
May 3 2022, 1:14 PM · Restricted Project, Restricted Project, Restricted Project
nickdesaulniers added inline comments to D124836: [AArch64] Add support for -fzero-call-used-regs.
May 3 2022, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
nickdesaulniers added a comment to D122350: [X86SchedSandyBridge] update cost of COPY to 1 cycle from 0.

Do we still need this one?

May 3 2022, 11:40 AM · Restricted Project, Restricted Project
nickdesaulniers abandoned D124307: make getRegPressureLimit arg const NFC.

I don't plan to land the child patch, so let's "just let sleeping dogs lie."

May 3 2022, 11:39 AM · Restricted Project, Restricted Project
nickdesaulniers abandoned D124308: [MachineScheduler] exclude INLINEASM from schedule when it would increase register pressure.

I'm not comfortable pursuing this approach.

May 3 2022, 11:38 AM · Restricted Project, Restricted Project

Apr 29 2022

nickdesaulniers accepted D119296: KCFI sanitizer.

I'm not an expert on LLVM's pipeline, but it just feels a little awkward and redundant that we need passes to fix what other passes messed up regarding a pass that executed before everything.

Apr 29 2022, 11:29 AM · Restricted Project, Restricted Project, Restricted Project
nickdesaulniers requested changes to D119296: KCFI sanitizer.

(tentatively removing my +1 since this patch has changed quite a bit since my initial review)

Apr 29 2022, 11:07 AM · Restricted Project, Restricted Project, Restricted Project
nickdesaulniers accepted D124211: Add __builtin_kcfi_call_unchecked.
Apr 29 2022, 11:06 AM · Restricted Project, Restricted Project

Apr 28 2022

nickdesaulniers added a comment to D124211: Add __builtin_kcfi_call_unchecked.

Can you link to the lore thread on discussions around the builtin?

There's no LKML discussion about the built-in, but there were earlier proposals of using an attribute to accomplish the same thing. @pcc suggested using a built-in instead, and the reviewers in D122673 agreed that it's a more appropriate solution. In the kernel, the indirect static_call trampoline calls that are patched into direct calls at boot are the primary reason we need a finer-grained method of disabling CFI checks.

Apr 28 2022, 11:47 AM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D124211: Add __builtin_kcfi_call_unchecked.
Apr 28 2022, 11:33 AM · Restricted Project, Restricted Project
nickdesaulniers added a comment to D124211: Add __builtin_kcfi_call_unchecked.

Can you link to the lore thread on discussions around the builtin?

Apr 28 2022, 11:20 AM · Restricted Project, Restricted Project
nickdesaulniers updated subscribers of D124211: Add __builtin_kcfi_call_unchecked.
Apr 28 2022, 11:09 AM · Restricted Project, Restricted Project

Apr 27 2022

nickdesaulniers added a comment to D123198: [LibCalls] Add argument extension attributes to more functions..

Should I be using this approach to solve: https://github.com/llvm/llvm-project/issues/53645?

Apr 27 2022, 1:36 PM · Restricted Project, Restricted Project

Apr 26 2022

nickdesaulniers accepted D124465: [AsmParser] Automatically declare and lex attribute keywords (NFC).

Thanks for the patch!

Apr 26 2022, 10:22 AM · Restricted Project, Restricted Project

Apr 25 2022

nickdesaulniers added a reviewer for D124308: [MachineScheduler] exclude INLINEASM from schedule when it would increase register pressure: MatzeB.
Apr 25 2022, 3:47 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D124308: [MachineScheduler] exclude INLINEASM from schedule when it would increase register pressure.
Apr 25 2022, 1:40 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D124308: [MachineScheduler] exclude INLINEASM from schedule when it would increase register pressure.
Apr 25 2022, 1:31 PM · Restricted Project, Restricted Project
nickdesaulniers added inline comments to D124308: [MachineScheduler] exclude INLINEASM from schedule when it would increase register pressure.
Apr 25 2022, 1:25 PM · Restricted Project, Restricted Project

Apr 22 2022

nickdesaulniers added a comment to D124308: [MachineScheduler] exclude INLINEASM from schedule when it would increase register pressure.

One alternative approach I can think of is rather than shrink the schedule region which is pretty pessimistic (the INLINEASM could have lots of operands of a particular TargetRegisterClass, but the only COPYs the would benefit from rescheduling are of a different TargetRegisterClass); I guess during moving of an instruction, we could check that we weren't moving COPY of a PhysReg past an INLINEASM with an operand of the same TargetRegisterClass would not be permitted if the number of live phyregs at the INLINEASM minus the physregs consumed by the INLINEASM.

Apr 22 2022, 3:47 PM · Restricted Project, Restricted Project
nickdesaulniers added a reviewer for D124308: [MachineScheduler] exclude INLINEASM from schedule when it would increase register pressure: qcolombet.
Apr 22 2022, 3:26 PM · Restricted Project, Restricted Project
nickdesaulniers updated subscribers of D124308: [MachineScheduler] exclude INLINEASM from schedule when it would increase register pressure.
Apr 22 2022, 3:25 PM · Restricted Project, Restricted Project