• rebase on D149675, remove nullptr check

• rebase on top of D149675 (I wasn't sure which would land first)

• remove unnecessary Visit*CastExpr overrides

• remove commented out code, still WIP

• just failing clang/test/CodeGenCXX/atomicinit.cpp

• rebase for presubmits

• rebase for presubmits

• rebase for presubmits

• rebase

• add note about reverse declaration order for variables declared in the same scope

• add note about function signature

• rebase

• update comments as per @MaskRay

• rebase, reformat for presubmit tests

needs rebasing for presubmit tests

In D149675#4313980, @MaskRay wrote:

In D149675#4313962, @efriedma wrote:

LGTM

In D149675#4313944, @nickdesaulniers wrote:

In D149675#4313933, @efriedma wrote:

Maybe it makes sense to revert D149104 while you're fixing the various demanglers to correctly respect the input length?

This should fix-forwards the test. Sorry it took me so long to root cause.

If I understand the situation correctly, all the other demanglers read past the end of the buffer too; we just get lucky that none of the tests on the buildbots use the API in a way which exposes that. I'd prefer to revert to known working, then fix each demangler, then fix the generic demangle() API.

Sounds good. So we need two commits

• Revert D149104. The description of this patch can be used by the revert commit.

• rebase on top of D149703, D149707, and the revert of D149104
• ninja check-llvm check-lldb check-bolt

Thanks for the patch!

Thanks for your patience. I was able to verify that Diff 526181 no longer ICE's as was observed by @maxim-kuvyrkov in linux stable 6.3.y for ARCH=arm allyesconfig https://ci.linaro.org/job/tcwg_kernel--llvm-master-arm-stable-allyesconfig-build/29/artifact/artifacts/06-build_linux/console.log.xz.

• rebase for presubmit testing

• git clang-format HEAD~

• rebase onto D151760, copy back Ashay's changes from D149061

Also, llvm/include/llvm/Demangle/ is the downstream copy from libcxxabi/. I'll have to copy it back in https://reviews.llvm.org/D148566.

In D141712#4377041, @Carrot wrote:

Updated the function replaceValuesPerBlockEntry to replace all OldLoad with NewLoad. So the deleted OldLoad instruction will not be used by later PHI instruction.

@TimNN, @antmo, @nickdesaulniers, @maxim-kuvyrkov could you help to test if this version work for you?

thanks

In D144654#4380488, @john.brawn wrote:

gcc has the same warning so I wasn't expecting this cause to change problems, but looking more closely at gcc's behaviour it looks like it only warns for some builtin macros and not others (though glancing over the gcc source code it's not clear which macros and for what reason).

I'll look at this some more and see if I can improve the behaviour.

• fixup last sentence as per @erichkeane

• fix string literals; still WIP

• one more test fix

• also remove VisitExprWithCleanups, down to two outstanding test failures

In D151572#4376697, @efriedma wrote:

Did you intentionally skip moving the ConstExprEmitter call in tryEmitPrivateForVarInit? (VarDecl::evaluateValue calls the constant evaluator.)

• one more style update

• rebase again for presubmit CI

• one more rebase to rekick presubmit tests

So, @rsmith are you ok with a patch like https://reviews.llvm.org/D76169 that removes those fixmes?

• rebase onto D151260

• remove special case for empty needle; it's already handled

• replace front() with *begin(), length() with size()