Page MenuHomePhabricator

njames93 (Nathan James)
Newb with a keyboard

Projects

User does not belong to any projects.

User Details

User Since
Dec 23 2019, 11:05 AM (4 w, 4 d)

Recent Activity

Yesterday

njames93 added a comment to D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop.

May not be one for this patch, but how does this check handle volatile loop variables and cases where modification isn't visible in the context e.g.

Should be OK, see "if (Var->getType().isVolatileQualified())" in the implementation. Feel free to submit another patch with more tests!

Fri, Jan 24, 8:58 AM · Restricted Project, Restricted Project
njames93 added a comment to D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop.

May not be one for this patch, but how does this check handle volatile loop variables and cases where modification isn't visible in the context e.g.

Fri, Jan 24, 8:04 AM · Restricted Project, Restricted Project
njames93 added reviewers for D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit: JonasToth, alexfh_, hokein.
Fri, Jan 24, 5:28 AM · Restricted Project, Restricted Project
njames93 updated the diff for D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit.
  • Small edge case tweak
Fri, Jan 24, 5:10 AM · Restricted Project, Restricted Project
njames93 added a reviewer for D72553: [clang-tidy] Add performance-prefer-preincrement check: JonasToth.
Fri, Jan 24, 4:08 AM · Restricted Project, Restricted Project

Thu, Jan 23

njames93 added a comment to D72553: [clang-tidy] Add performance-prefer-preincrement check.

Gonna throw it out there, those pre merge fails aren't anything to do with this patch

Thu, Jan 23, 2:40 PM · Restricted Project, Restricted Project
njames93 updated the diff for D72553: [clang-tidy] Add performance-prefer-preincrement check.
  • Rebase trunk and fix a few nits with test file
Thu, Jan 23, 12:57 PM · Restricted Project, Restricted Project
njames93 added inline comments to D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop.
Thu, Jan 23, 8:19 AM · Restricted Project, Restricted Project
njames93 updated the diff for D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions.
  • Added checks for access specifiers
Thu, Jan 23, 7:34 AM · Restricted Project, Restricted Project
njames93 added inline comments to D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions.
Thu, Jan 23, 6:48 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.
  • Small refactor
Thu, Jan 23, 6:48 AM · Restricted Project, Restricted Project
njames93 added inline comments to D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions.
Thu, Jan 23, 3:17 AM · Restricted Project, Restricted Project
njames93 updated the diff for D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions.
  • Dont trim func name before regex
Thu, Jan 23, 2:48 AM · Restricted Project, Restricted Project
njames93 updated the diff for D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions.
  • use regex for func name matching
Thu, Jan 23, 2:44 AM · Restricted Project, Restricted Project

Wed, Jan 22

njames93 updated the diff for D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions.
  • Address nits
Wed, Jan 22, 4:28 PM · Restricted Project, Restricted Project
njames93 updated the diff for D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit.
  • remove unnecessary auto
Wed, Jan 22, 10:05 AM · Restricted Project, Restricted Project
njames93 added inline comments to D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit.
Wed, Jan 22, 10:05 AM · Restricted Project, Restricted Project
njames93 added a comment to D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions.

Does wmain get used in a lot of projects. If it's very niche then I don't feel it warrants a place in here. If it does I'll add it in.

It's not uncommon on Windows, at the very least. I think it's worth supporting.

I'll add that in

Wed, Jan 22, 8:21 AM · Restricted Project, Restricted Project
njames93 updated the summary of D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit.
Wed, Jan 22, 8:12 AM · Restricted Project, Restricted Project
njames93 created D73203: [clang-tidy] Prevent a remove only fixit causing a conflict when enclosed by another fixit.
Wed, Jan 22, 8:05 AM · Restricted Project, Restricted Project

Tue, Jan 21

njames93 added a comment to D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions.
Tue, Jan 21, 2:41 PM · Restricted Project, Restricted Project
njames93 added a comment to D73090: [clang-tidy] Fix PR#44528 'modernize-use-using and enums'.

If you are using diff to create a patch, use -U999999 to get the full context of the patch

Tue, Jan 21, 10:19 AM · Restricted Project, Restricted Project
njames93 added a comment to D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions.

For the record this convention appears everywhere in LLVM even though LLVM style is to have parameters starting with uppercase letters

Tue, Jan 21, 6:12 AM · Restricted Project, Restricted Project
njames93 created D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions.
Tue, Jan 21, 6:03 AM · Restricted Project, Restricted Project
njames93 updated the diff for D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved.
  • Fix assertion causing failing tests in debug
Tue, Jan 21, 1:53 AM · Restricted Project, Restricted Project

Mon, Jan 20

njames93 updated the diff for D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved.
  • rebase master figure out the llvm pre-merge lint test fail
Mon, Jan 20, 5:40 PM · Restricted Project, Restricted Project
njames93 updated the diff for D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved.
  • Added some sanity tests that fix weird crashes
  • Added support for CXXMethodDecls that are referenced with depended scope member expr
Mon, Jan 20, 4:36 PM · Restricted Project, Restricted Project
njames93 added a comment to D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved.

hmmm annoyingly this change causes a crash in a side project I'm creating, gotta go bug hunting now

Mon, Jan 20, 3:41 PM · Restricted Project, Restricted Project
njames93 added inline comments to D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved.
Mon, Jan 20, 10:35 AM · Restricted Project, Restricted Project
njames93 updated the diff for D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved.
  • Added not type template test case
Mon, Jan 20, 10:35 AM · Restricted Project, Restricted Project
njames93 committed rGa42c3eb599cb: [clang-tidy] Add check for CERT-OOP57-CPP (authored by njames93).
[clang-tidy] Add check for CERT-OOP57-CPP
Mon, Jan 20, 9:12 AM
njames93 closed D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
Mon, Jan 20, 9:12 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
  • rebase truck
Mon, Jan 20, 9:12 AM · Restricted Project, Restricted Project
njames93 updated the diff for D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved.
  • replace auto when type isnt explicit
Mon, Jan 20, 9:02 AM · Restricted Project, Restricted Project
njames93 updated the summary of D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved.
Mon, Jan 20, 8:52 AM · Restricted Project, Restricted Project
njames93 retitled D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved from First Draft to [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved.
Mon, Jan 20, 8:52 AM · Restricted Project, Restricted Project
njames93 created D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved.
Mon, Jan 20, 8:52 AM · Restricted Project, Restricted Project

Fri, Jan 17

njames93 updated the diff for D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
  • Fix If stmt and optimise building function name list
Fri, Jan 17, 7:36 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.
  • Updated to trunk, fix release notes
Fri, Jan 17, 6:40 AM · Restricted Project, Restricted Project
njames93 committed rGf9c46229e4ac: [clang-tidy] Disable Checks on If constexpr statements in template… (authored by njames93).
[clang-tidy] Disable Checks on If constexpr statements in template…
Fri, Jan 17, 6:30 AM
njames93 closed D71980: [clang-tidy] Disable Checks on If constexpr statements in template Instantiations for BugproneBranchClone and ReadabilityBracesAroundStatements.
Fri, Jan 17, 6:30 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
  • added few more functions, fix format error
Fri, Jan 17, 5:13 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72553: [clang-tidy] Add performance-prefer-preincrement check.
  • Streamlined replacement application
Fri, Jan 17, 4:16 AM · Restricted Project, Restricted Project

Tue, Jan 14

njames93 updated the diff for D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
  • double ticks
Tue, Jan 14, 6:00 PM · Restricted Project, Restricted Project
njames93 added inline comments to D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
Tue, Jan 14, 6:00 PM · Restricted Project, Restricted Project
njames93 added a comment to D72121: [clang-tidy] Fix readability-identifier-naming missing member variables .

Please also close PRs.

Tue, Jan 14, 3:33 PM · Restricted Project, Restricted Project
njames93 updated the diff for D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
  • remove This check from docs... again
Tue, Jan 14, 2:55 PM · Restricted Project, Restricted Project
njames93 retitled D72553: [clang-tidy] Add performance-prefer-preincrement check from [clang-tidy] Add llvm-prefer-preincrement check to [clang-tidy] Add performance-prefer-preincrement check.
Tue, Jan 14, 2:36 PM · Restricted Project, Restricted Project
njames93 updated the diff for D72553: [clang-tidy] Add performance-prefer-preincrement check.
  • moved check from llvm module to performance
Tue, Jan 14, 2:36 PM · Restricted Project, Restricted Project
njames93 added inline comments to D72553: [clang-tidy] Add performance-prefer-preincrement check.
Tue, Jan 14, 1:47 PM · Restricted Project, Restricted Project
njames93 updated the diff for D72553: [clang-tidy] Add performance-prefer-preincrement check.
  • fix spelling mistake
Tue, Jan 14, 1:18 PM · Restricted Project, Restricted Project
njames93 added inline comments to D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
Tue, Jan 14, 11:32 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
  • Fix a few nits, extra names will follow
Tue, Jan 14, 11:32 AM · Restricted Project, Restricted Project
njames93 added inline comments to D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming.
Tue, Jan 14, 10:51 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72217: [clang-tidy] Added readability-qualified-auto check.
  • Rebase from trunk
Tue, Jan 14, 10:42 AM · Restricted Project, Restricted Project
njames93 added a comment to D72217: [clang-tidy] Added readability-qualified-auto check.

Do you need someone to commit this on your behalf? (If you plan to continue contributing, which I hope you do, it may be a good time for you to obtain commit privileges: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access but I am happy to commit on your behalf if you'd prefer.)

For now I would appreciate it, I have fired off an email though, cheers.

Tue, Jan 14, 7:53 AM · Restricted Project, Restricted Project

Mon, Jan 13

njames93 added a comment to rGc1b13a1b1771: Fix a test case by adding -fno-delayed-template-parsing..

Was this another windows test case fail?

Mon, Jan 13, 3:17 PM
njames93 added a comment to D72121: [clang-tidy] Fix readability-identifier-naming missing member variables .

Is anyone able to commit on my behalf?

Mon, Jan 13, 7:44 AM · Restricted Project, Restricted Project

Sun, Jan 12

njames93 added a comment to D72566: [clang-tidy] Clang tidy is now alias aware.

Another potential solution is leave is as is by default. Then emit a warning if a check is ran twice. The warning could be suppressed by passing a option to say what behaviour you want?

Sun, Jan 12, 11:56 AM · Restricted Project, Restricted Project
njames93 added a comment to D72566: [clang-tidy] Clang tidy is now alias aware.

How does this sound?
I'll put in a config option in there to disable the new alias behaviour.
Personally I'd say default to the new behaviour. Then if an organisation
relies on the old behaviour then can revert back with a command line option
or .clang-tidy file edit

Sun, Jan 12, 8:40 AM · Restricted Project, Restricted Project
njames93 added a comment to D72566: [clang-tidy] Clang tidy is now alias aware.

I agree that the current alias situation is not ideal, though i'm not sure
how much we can fix it since it crosses user interface boundary
(i.e. what fixes won't lead to some regressions from the previous expected behavior)

If you're expecting a test to run twice usually something has gone wrong

Sun, Jan 12, 7:16 AM · Restricted Project, Restricted Project
njames93 added a parent revision for D72568: [clang-tidy] Alias defintions for checks: D72566: [clang-tidy] Clang tidy is now alias aware.
Sun, Jan 12, 6:39 AM · Restricted Project, Restricted Project
njames93 created D72568: [clang-tidy] Alias defintions for checks.
Sun, Jan 12, 6:39 AM · Restricted Project, Restricted Project
njames93 added a child revision for D72566: [clang-tidy] Clang tidy is now alias aware: D72568: [clang-tidy] Alias defintions for checks.
Sun, Jan 12, 6:39 AM · Restricted Project, Restricted Project
njames93 added a comment to D72566: [clang-tidy] Clang tidy is now alias aware.

should warning be printed with all the enabled checks, or just the primary name?

warning: statement should be inside braces [readability-braces-around-statements]

vs

warning: statement should be inside braces [readability-braces-around-statements, hicpp-braces-around-statements]
warning: statement should be inside braces [readability-braces-around-statements], [hicpp-braces-around-statements]
Sun, Jan 12, 6:25 AM · Restricted Project, Restricted Project
njames93 created D72566: [clang-tidy] Clang tidy is now alias aware.
Sun, Jan 12, 4:44 AM · Restricted Project, Restricted Project

Sat, Jan 11

njames93 updated the diff for D72553: [clang-tidy] Add performance-prefer-preincrement check.
  • Rebased onto trunk fixing merge issues
Sat, Jan 11, 11:29 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72553: [clang-tidy] Add performance-prefer-preincrement check.
  • Fix perf alias documentation
Sat, Jan 11, 8:47 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72553: [clang-tidy] Add performance-prefer-preincrement check.
  • 99% sure I have all incriments renamed now
Sat, Jan 11, 8:10 AM · Restricted Project, Restricted Project
njames93 added inline comments to D72553: [clang-tidy] Add performance-prefer-preincrement check.
Sat, Jan 11, 8:10 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72553: [clang-tidy] Add performance-prefer-preincrement check.
  • Renamed incriment in test cases to increment
Sat, Jan 11, 8:01 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72553: [clang-tidy] Add performance-prefer-preincrement check.
  • Added alias for performance module
  • renamed check to prefer-pre-increment
Sat, Jan 11, 8:00 AM · Restricted Project, Restricted Project
njames93 created D72556: [llvm][adt] Added TrimChars parameter to StringRef::Split.
Sat, Jan 11, 7:06 AM · Restricted Project
njames93 updated the diff for D72488: [clang-tidy] Add check for CERT-OOP57-CPP.

Figured out what memset you meant...

Sat, Jan 11, 4:56 AM · Restricted Project, Restricted Project
njames93 added a comment to D72553: [clang-tidy] Add performance-prefer-preincrement check.

could this do with an alias into performance?

Sat, Jan 11, 4:56 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72553: [clang-tidy] Add performance-prefer-preincrement check.
  • Small refactor
Sat, Jan 11, 4:46 AM · Restricted Project, Restricted Project

Fri, Jan 10

njames93 created D72553: [clang-tidy] Add performance-prefer-preincrement check.
Fri, Jan 10, 8:00 PM · Restricted Project, Restricted Project
njames93 updated the diff for D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
  • Reworked options documentation
Fri, Jan 10, 1:03 PM · Restricted Project, Restricted Project
njames93 updated the diff for D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
  • Fixed more documentation nits
Fri, Jan 10, 11:01 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
  • Fix format of options docs and remove unnecessary empty line
Fri, Jan 10, 10:41 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72217: [clang-tidy] Added readability-qualified-auto check.
  • Update docs to use backticks
Fri, Jan 10, 10:22 AM · Restricted Project, Restricted Project
njames93 added inline comments to D72217: [clang-tidy] Added readability-qualified-auto check.
Fri, Jan 10, 10:22 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72217: [clang-tidy] Added readability-qualified-auto check.

reformat/lint

Fri, Jan 10, 10:14 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.

Undid my oopsie sending the wrong patch here

Fri, Jan 10, 9:53 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72488: [clang-tidy] Add check for CERT-OOP57-CPP.

Tweaked a few documentation issues

Fri, Jan 10, 9:53 AM · Restricted Project, Restricted Project
njames93 added a comment to D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.

whoops typo in arc, will fix, this is another patch

Fri, Jan 10, 9:53 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.

Tweaked a few documentation issues

Fri, Jan 10, 9:46 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72217: [clang-tidy] Added readability-qualified-auto check.

Rebase onto trunk

Fri, Jan 10, 7:52 AM · Restricted Project, Restricted Project
njames93 added inline comments to D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
Fri, Jan 10, 7:08 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72488: [clang-tidy] Add check for CERT-OOP57-CPP.

Added a way to specify custom mem set copy and compare functions plus nit fixes

Fri, Jan 10, 7:08 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.

Checks for string initialisations which are spelt with braces

Fri, Jan 10, 5:47 AM · Restricted Project, Restricted Project

Thu, Jan 9

njames93 created D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
Thu, Jan 9, 5:42 PM · Restricted Project, Restricted Project
njames93 updated the diff for D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.

updated release notes

Thu, Jan 9, 10:33 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.

Address nits

Thu, Jan 9, 7:15 AM · Restricted Project, Restricted Project
njames93 added inline comments to D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.
Thu, Jan 9, 7:15 AM · Restricted Project, Restricted Project
njames93 updated the summary of D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.
Thu, Jan 9, 6:37 AM · Restricted Project, Restricted Project
njames93 updated the summary of D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.
Thu, Jan 9, 6:37 AM · Restricted Project, Restricted Project
njames93 created D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.
Thu, Jan 9, 6:27 AM · Restricted Project, Restricted Project
njames93 added inline comments to D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.
Thu, Jan 9, 6:27 AM · Restricted Project, Restricted Project
njames93 updated the diff for D72217: [clang-tidy] Added readability-qualified-auto check.

small nits

Thu, Jan 9, 5:31 AM · Restricted Project, Restricted Project