Page MenuHomePhabricator

njames93 (Nathan James)
Dodd

Projects

User does not belong to any projects.

User Details

User Since
Dec 23 2019, 11:05 AM (132 w, 2 d)

Recent Activity

Yesterday

njames93 updated the diff for D129206: [ADT] Use Empty Base Optimization for Allocators.

Add a static assert to verify smaller size.

Wed, Jul 6, 11:31 PM · Restricted Project, Restricted Project
njames93 added a comment to D129206: [ADT] Use Empty Base Optimization for Allocators.

Got some testing for this? Perhaps some static_asserts in the unit test class that demonstrates the smaller size? (specifically, I thought the EBO only applied to the first base class or something like that, so the StringMap case where the allocator is the second base I'm not sure would correctly trigger EBO?)

The standard places no such restriction and clang(on a 64 bit build) currently determines StringMap to be 32 bytes, after this patch it drops to 24 bytes.

Wed, Jul 6, 11:26 PM · Restricted Project, Restricted Project
njames93 updated the diff for D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS.

Address comments.

Wed, Jul 6, 11:21 PM · Restricted Project, Restricted Project
njames93 added a comment to D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS.

Thank you for working on this, I think it's a nice new diagnostic. You should add a release note to describe it. One question I have is about how chatty this is over real world code, especially older code bases. There used to be two prevailing ways to silence the "unused variable" warnings you would get when a variable is used in an assert: (void)whatever; and whatever = whatever;; I'm worried the latter case is still prevalent enough that having this warning on by default would be a problem, but I'm also optimistic my worry is unfounded.

It's not adding a new warning, so chattiness of this patch shouldn't really be much of an issue.

Wed, Jul 6, 11:21 PM · Restricted Project, Restricted Project
njames93 requested review of D129206: [ADT] Use Empty Base Optimization for Allocators.
Wed, Jul 6, 7:43 AM · Restricted Project, Restricted Project
njames93 updated subscribers of D128770: [yaml] Add support for Anchors and Aliases to yaml::Input.

Thanks for looking at this. Does the Yaml I/O documentation need updating (see llvm/docs/YamlIO.rst)?

I decided against updating the docs link to the YAML specification and this change is simply about bringing the YamlIO implementation more inline with the actual specification.

Wed, Jul 6, 7:16 AM · Restricted Project, Restricted Project
njames93 updated the diff for D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS.

Remove unnecessary extra include.

Wed, Jul 6, 7:10 AM · Restricted Project, Restricted Project
njames93 requested review of D129202: [clang] Add a fixit for warn-self-assign if LHS is a field with the same name as parameter on RHS.
Wed, Jul 6, 7:08 AM · Restricted Project, Restricted Project

Mon, Jul 4

njames93 updated the diff for D129070: [clang-tidy] Fixed an issue in readability-identifier-naming not using options specified..

Small tweak.

Mon, Jul 4, 8:06 AM · Restricted Project, Restricted Project
njames93 requested review of D129070: [clang-tidy] Fixed an issue in readability-identifier-naming not using options specified..
Mon, Jul 4, 3:29 AM · Restricted Project, Restricted Project

Fri, Jul 1

njames93 accepted D127807: [clang-tidy] Properly forward clang-tidy output when running tests.

I'd say land this, but keep a close eye on the build bots as it may need reverting.

Fri, Jul 1, 1:10 PM · Restricted Project, Restricted Project

Thu, Jun 30

njames93 updated the diff for D128605: [yaml] Extract output logic from yaml::Output.

Tweak alias/anchor output.
remove code duplication.

Thu, Jun 30, 4:10 PM · Restricted Project, Restricted Project
njames93 updated the diff for D128379: [clangd] Change the url for clang-tidy check documentation.

Changed to only use the major version.
If this still seems too flaky, happy to go back to just linking to the in progress release notes.

Thu, Jun 30, 1:15 PM · Restricted Project, Restricted Project
njames93 added a comment to D128379: [clangd] Change the url for clang-tidy check documentation.

Hmm, this version looks complicated to me.
And also fragile: downstream we have CLANG_VERSION_STRINGs that don't match upstream, Apple has their own versioning scheme, linux distros tend to do things like 6.0.1~ubuntu3...
Let me sync with @kadircet

The good news is that the ~ubuntu3 isn't part of CLANG_VERSION_STRING I think.
Bad news #1 is that it still may not match llvm.org versions: e.g. our internal distribution is "trunk", Apple's CLANG_VERSION_STRING is 10.0.1 on my machine, but it's approximately LLVM version 7.
Bad news #2 is that the documentation isn't actually available for all these versions: none of 14.0.1->14.0.5 exist, the point releases for 9-13 all have documentation but not 8.0.1. Looking at other projects, the set of docs available is inconsistent.

I don't think this substantially more reliable than just pointing at the HEAD docs, and it certainly doesn't seem "better enough" to be worth any build complexity. Can we revert to the simple version?

(I do think changing the URLs of the clang-tidy check documentation was unfortunate, and setting up server-side redirects for those would be nice to have if it's easy)

Thu, Jun 30, 8:30 AM · Restricted Project, Restricted Project
njames93 requested review of D128379: [clangd] Change the url for clang-tidy check documentation.

Any issues with this now for getting correct version?

Thu, Jun 30, 4:39 AM · Restricted Project, Restricted Project
njames93 updated the diff for D128379: [clangd] Change the url for clang-tidy check documentation.

Fix lit cfg typo

Thu, Jun 30, 4:38 AM · Restricted Project, Restricted Project
njames93 updated the diff for D128379: [clangd] Change the url for clang-tidy check documentation.

Emit documentation links for the version of clangd built.

Thu, Jun 30, 4:36 AM · Restricted Project, Restricted Project
njames93 updated the diff for D128770: [yaml] Add support for Anchors and Aliases to yaml::Input.

Missed something from last update.

Thu, Jun 30, 3:00 AM · Restricted Project, Restricted Project
njames93 updated the diff for D128770: [yaml] Add support for Anchors and Aliases to yaml::Input.

Remove recursive nature of alias expansion as alias nodes cannot be anchored.

Thu, Jun 30, 2:50 AM · Restricted Project, Restricted Project
njames93 updated the diff for D128801: [yaml] Error on alias nodes that have properties attached.

Emit fix hints for removing the tags.

Thu, Jun 30, 2:46 AM · Restricted Project, Restricted Project
njames93 added a comment to D128402: [clang-tidy] Don't treat invalid branches as identical.

Once you see it, can you either confirm -fix-errors was correct originally, or instruct me on how to fix this test failure?

-expect-clang-tidy-error is the technically correct flag to use, but I'm easy either way.

Thu, Jun 30, 1:17 AM · Restricted Project, Restricted Project

Wed, Jun 29

njames93 requested review of D128801: [yaml] Error on alias nodes that have properties attached.
Wed, Jun 29, 3:45 AM · Restricted Project, Restricted Project

Tue, Jun 28

njames93 added reviewers for D128770: [yaml] Add support for Anchors and Aliases to yaml::Input: JDevlieghere, dexonsmith, jhenderson.
Tue, Jun 28, 6:14 PM · Restricted Project, Restricted Project
njames93 added inline comments to D128402: [clang-tidy] Don't treat invalid branches as identical.
Tue, Jun 28, 4:56 PM · Restricted Project, Restricted Project
njames93 requested review of D128770: [yaml] Add support for Anchors and Aliases to yaml::Input.
Tue, Jun 28, 4:29 PM · Restricted Project, Restricted Project

Mon, Jun 27

njames93 updated the diff for D128605: [yaml] Extract output logic from yaml::Output.

Fixed failing test cases by reverting Bitset Flow change
Added infrastructure to simplify emitting complex types.

Mon, Jun 27, 4:30 AM · Restricted Project, Restricted Project

Sun, Jun 26

njames93 requested review of D128605: [yaml] Extract output logic from yaml::Output.
Sun, Jun 26, 3:58 AM · Restricted Project, Restricted Project

Fri, Jun 24

njames93 added a comment to D128379: [clangd] Change the url for clang-tidy check documentation.

Pointing the documentation links based on build configuration and version definitely makes sense as evolving checks could easily confuse users.
Guess the idea is snapshot builds will use the in progress release notes, and release builds can point to the actual release documentation

Fri, Jun 24, 6:27 AM · Restricted Project, Restricted Project

Thu, Jun 23

njames93 committed rGfbf611ed2a76: [clang-tidy] Extend spelling for CheckOptions (authored by njames93).
[clang-tidy] Extend spelling for CheckOptions
Thu, Jun 23, 11:59 AM · Restricted Project, Restricted Project
njames93 closed D128337: [clang-tidy] Extend spelling for CheckOptions.
Thu, Jun 23, 11:59 AM · Restricted Project, Restricted Project
njames93 updated the diff for D128337: [clang-tidy] Extend spelling for CheckOptions.

Rebase to check CI

Thu, Jun 23, 11:28 AM · Restricted Project, Restricted Project
njames93 committed rG5ca68d5845c0: [clang-tidy] Add `-verify-config` command line argument (authored by njames93).
[clang-tidy] Add `-verify-config` command line argument
Thu, Jun 23, 11:23 AM · Restricted Project, Restricted Project
njames93 closed D127446: [clang-tidy] Add `-verify-config` command line argument.
Thu, Jun 23, 11:23 AM · Restricted Project, Restricted Project
njames93 added inline comments to D128379: [clangd] Change the url for clang-tidy check documentation.
Thu, Jun 23, 10:58 AM · Restricted Project, Restricted Project

Wed, Jun 22

njames93 added inline comments to D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check.
Wed, Jun 22, 11:21 PM · Restricted Project, Restricted Project
njames93 added inline comments to D128402: [clang-tidy] Don't treat invalid branches as identical.
Wed, Jun 22, 10:36 PM · Restricted Project, Restricted Project
njames93 requested review of D128379: [clangd] Change the url for clang-tidy check documentation.
Wed, Jun 22, 1:50 PM · Restricted Project, Restricted Project
njames93 committed rG165d69337a7d: [clang-tidy][docs] Fix a couple of missed cases from 6e566bc5523 (authored by njames93).
[clang-tidy][docs] Fix a couple of missed cases from 6e566bc5523
Wed, Jun 22, 1:37 PM · Restricted Project, Restricted Project
njames93 updated the diff for D128337: [clang-tidy] Extend spelling for CheckOptions.

Rebased and addressed comments

Wed, Jun 22, 1:24 PM · Restricted Project, Restricted Project
njames93 committed rGb1cc59fd3a9b: [clang-tidy][docs] Reorganise release notes (authored by njames93).
[clang-tidy][docs] Reorganise release notes
Wed, Jun 22, 1:22 PM · Restricted Project, Restricted Project
njames93 added a comment to D128337: [clang-tidy] Extend spelling for CheckOptions.

I like the changes -- this is a much nicer syntax for specifying configuration options!

The only observable differences are support for the new syntax and -dump=config will emit using the new syntax.

Do you expect the behavior of -dump to cause any problems for folks using that option from a script? I can't think of any that aren't super contrived, but maybe you've got more thoughts there.

Wed, Jun 22, 1:12 PM · Restricted Project, Restricted Project
njames93 added a comment to D127807: [clang-tidy] Properly forward clang-tidy output when running tests.

Thank you for this, it has been annoying me for a while.
I'll give a tentative LG, but I'm no expert in this area so see what everyone else says first.

Wed, Jun 22, 11:30 AM · Restricted Project, Restricted Project
njames93 added a comment to D128072: [clang-tidy] Organize test files into subdirectories by module (NFC).

Just noticed something nice about this, cmake targets are generated for each module
Should speed up development as you now only need to run the lit tests for the module that you are working on check-clang-extra-clang-tidy-checkers-misc etc

Wed, Jun 22, 11:26 AM · Restricted Project, Restricted Project
njames93 abandoned D96286: [clangd][NFC] Change TidyProvider cache to use a linked list approach.
Wed, Jun 22, 9:36 AM · Restricted Project, Restricted Project, Restricted Project
njames93 requested review of D128355: [clangd][NFC] Unify ancestor logic for config and tidy provider..
Wed, Jun 22, 9:35 AM · Restricted Project, Restricted Project
njames93 updated the diff for D128337: [clang-tidy] Extend spelling for CheckOptions.

Update some test files using new syntax.

Wed, Jun 22, 7:32 AM · Restricted Project, Restricted Project
njames93 updated the diff for D126859: [clangd] Validate clang-tidy CheckOptions in clangd config.

Remove typo correction support.

Wed, Jun 22, 7:06 AM · Restricted Project, Restricted Project
njames93 updated subscribers of D127446: [clang-tidy] Add `-verify-config` command line argument.

Before this lands @sammccall @kadircet Do you have any concerns about this API for getting the options not building a static instance here?

Wed, Jun 22, 6:06 AM · Restricted Project, Restricted Project
njames93 added inline comments to D127446: [clang-tidy] Add `-verify-config` command line argument.
Wed, Jun 22, 5:11 AM · Restricted Project, Restricted Project
njames93 requested review of D128337: [clang-tidy] Extend spelling for CheckOptions.
Wed, Jun 22, 5:05 AM · Restricted Project, Restricted Project
njames93 added a comment to D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker.

Can this patch be split in two, it seems strange to be fixing 2 unrelated bugs in one patch.
One fix for the ObjC nodes and another for the patch for the static local variables.

Wed, Jun 22, 3:06 AM · Restricted Project, Restricted Project, Restricted Project
njames93 added a comment to D126859: [clangd] Validate clang-tidy CheckOptions in clangd config.

I also agree with the typo correction verdict. In theory there'll be two cases:

  • typo correction helps, in which case it'll be obvious from the warning itself.
  • typo correction doesn't help, because the option doesn't exist at all, we'll be just showing a random option. I don't think how this'll be helpful.

So I don't think this is providing much of a value compared to the extra logic.

Wed, Jun 22, 2:52 AM · Restricted Project, Restricted Project
njames93 updated the diff for D127446: [clang-tidy] Add `-verify-config` command line argument.

Address reviewer comments.

Wed, Jun 22, 2:46 AM · Restricted Project, Restricted Project
njames93 added inline comments to D127446: [clang-tidy] Add `-verify-config` command line argument.
Wed, Jun 22, 2:46 AM · Restricted Project, Restricted Project
njames93 added a comment to D128204: [clangd] Add fix-it for inserting IWYU pragma: keep.

One of the main issues I have is due to templates not being instantiated which can result in symbols that are actually used not being picked up as the template instantiation that uses them isn't actually instantiated.

I guess you're talking about having the template pattern in the main file, but all the instantiations are in dependents of the code. My mental model was around making the dependents have the include for the type, instead of having it in the file providing the template pattern (header). Does that make sense?
This kind of breaks down when there's actually some types used by all the instantiations, as you'd want them to be included by the header. But I think we should be able to diagnose these cases, as usage of this type should be non-dependent (at least in the cases I can think of), so this sounds like a bug/improvement.

A specific example i encountered is clang/Tooling/DiagnosticsYaml.h Which defines template specializations for inputting/outputting yaml io. That file must be included if you ever want to emit diagnostics as YAML, but the typical use case is to just use the operator<< on a yaml stream. This function internally will use those specializations, but as clangd doesn't look into the function calls and expand all those instantiations, they are treated as being unused(There's many bugs already related to this) and as such the header is marked as being unused.

Wed, Jun 22, 2:24 AM · Restricted Project, Restricted Project

Tue, Jun 21

njames93 added a comment to D128204: [clangd] Add fix-it for inserting IWYU pragma: keep.

I had another idea about offering the export pragma when in a header file but I don't know if that's going too far

Tue, Jun 21, 1:31 PM · Restricted Project, Restricted Project

Mon, Jun 20

njames93 updated the diff for D126859: [clangd] Validate clang-tidy CheckOptions in clangd config.

Reuse implementation from D127446

Mon, Jun 20, 7:35 AM · Restricted Project, Restricted Project
njames93 requested review of D128204: [clangd] Add fix-it for inserting IWYU pragma: keep.
Mon, Jun 20, 7:20 AM · Restricted Project, Restricted Project
njames93 committed rG541a50e20702: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals (authored by jspam).
[clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals
Mon, Jun 20, 5:31 AM · Restricted Project, Restricted Project
njames93 closed D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals.
Mon, Jun 20, 5:30 AM · Restricted Project, Restricted Project
njames93 added a comment to D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals.

Would someone be able to commit this for me, as I do not have the necessary rights? Thanks

Mon, Jun 20, 1:31 AM · Restricted Project, Restricted Project

Sat, Jun 18

njames93 updated the summary of D127446: [clang-tidy] Add `-verify-config` command line argument.
Sat, Jun 18, 7:03 AM · Restricted Project, Restricted Project

Fri, Jun 10

njames93 planned changes to D126859: [clangd] Validate clang-tidy CheckOptions in clangd config.

Gonna wait for the infrastructure from D127446 to land first, can reuse most of that implementation.

Fri, Jun 10, 7:33 AM · Restricted Project, Restricted Project
njames93 added a comment to D127446: [clang-tidy] Add `-verify-config` command line argument.

This sounds like great functionality, surely saving a lot of headaches! Any reason why we wouldn't want this active by default? I'd personally even go one step further and make it hard errors - warnings are easy to miss and ignore - but I can see how it can be problematic for some people.

I choose not to as I'd imagine it could would result in duplicated warnings when batch processing using run_clang_tidy over a large project.
Also if there's any edge cases, maybe with the static analyser, I wouldn't want those diagnostics triggering by default with no way to silence them.
I wouldn't be opposed to the possibility of making on by default after its had some time in the wild.

Fri, Jun 10, 1:42 AM · Restricted Project, Restricted Project

Thu, Jun 9

njames93 committed rGb8317862921d: [clang-tidy][NFC] Tweak identifier-naming options reading/writiing (authored by njames93).
[clang-tidy][NFC] Tweak identifier-naming options reading/writiing
Thu, Jun 9, 11:07 PM · Restricted Project, Restricted Project
njames93 requested review of D127446: [clang-tidy] Add `-verify-config` command line argument.
Thu, Jun 9, 2:49 PM · Restricted Project, Restricted Project
njames93 added a comment to D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).

It would also be nice if there was a redirect that would dynamically translate the old links to new links.

You can do that with .htaccess, but I don't know if that's considered acceptable in clang documentation.

FWIW, I don't have any idea if this is or isn't acceptable.

Mucking around with an .htaccess file is very web server dependent. Surely this can't be the first time that a page of documentation changed names or locations? I'm betting that they didn't worry about putting in redirects and let search engines handle guiding users to the correct page.

Search engines isn't really an issue, its more people who are using older versions of llvm that try and go to the documentation which turns out is a dead link.
Having said that, I still think the lack of a redirect shouldn't block this change.

Thu, Jun 9, 2:42 PM · Restricted Project, Restricted Project

Wed, Jun 8

njames93 added a comment to D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).

Gentle ping

Wed, Jun 8, 9:55 PM · Restricted Project, Restricted Project
njames93 added inline comments to D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init.
Wed, Jun 8, 10:29 AM · Restricted Project, Restricted Project
njames93 added inline comments to D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables.
Wed, Jun 8, 10:23 AM · Restricted Project, Restricted Project, Restricted Project
njames93 accepted D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables.

LGTM, just a couple points but not essential.

Wed, Jun 8, 12:43 AM · Restricted Project, Restricted Project, Restricted Project
njames93 committed rG638b0fb4d651: [ADT][NFC] Early bail out for ComputeEditDistance (authored by njames93).
[ADT][NFC] Early bail out for ComputeEditDistance
Wed, Jun 8, 12:21 AM · Restricted Project, Restricted Project
njames93 closed D127070: [ADT][NFC] Early bail out for ComputeEditDistance.
Wed, Jun 8, 12:20 AM · Restricted Project, Restricted Project

Jun 7 2022

njames93 updated the diff for D127070: [ADT][NFC] Early bail out for ComputeEditDistance.

Add tests to verify bailing out.

Jun 7 2022, 3:12 AM · Restricted Project, Restricted Project

Jun 5 2022

njames93 requested review of D127070: [ADT][NFC] Early bail out for ComputeEditDistance.
Jun 5 2022, 4:20 AM · Restricted Project, Restricted Project
njames93 committed rGa13b61f7f0a2: [ADT] Add edit_distance_insensitive to StringRef (authored by njames93).
[ADT] Add edit_distance_insensitive to StringRef
Jun 5 2022, 4:03 AM · Restricted Project, Restricted Project
njames93 closed D126159: [ADT] Add edit_distance_insensitive to StringRef.
Jun 5 2022, 4:03 AM · Restricted Project, Restricted Project
njames93 updated the diff for D126159: [ADT] Add edit_distance_insensitive to StringRef.

Use reference lifetime extension.

Jun 5 2022, 2:06 AM · Restricted Project, Restricted Project

Jun 3 2022

njames93 added inline comments to D126159: [ADT] Add edit_distance_insensitive to StringRef.
Jun 3 2022, 4:40 PM · Restricted Project, Restricted Project
njames93 accepted D126853: [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves..

I feel that this case should produce a warning akin to the no self assignment diagnostics, obviously nothing to do with this check though.

Jun 3 2022, 8:12 AM · Restricted Project, Restricted Project

Jun 2 2022

njames93 accepted D126780: [clang-tidy] `bugprone-use-after-move`: Fix handling of moves in lambda captures.

LGTM, But please add a note to ReleaseNotes before landing.

Jun 2 2022, 4:15 AM · Restricted Project, Restricted Project
njames93 added a comment to D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC).

Can I ask what the motivation is for this change?

Jun 2 2022, 2:42 AM · Restricted Project, Restricted Project
njames93 updated the diff for D126159: [ADT] Add edit_distance_insensitive to StringRef.

Cache outer loop map item.

Jun 2 2022, 1:48 AM · Restricted Project, Restricted Project
njames93 added inline comments to D126159: [ADT] Add edit_distance_insensitive to StringRef.
Jun 2 2022, 1:40 AM · Restricted Project, Restricted Project
njames93 updated the diff for D126159: [ADT] Add edit_distance_insensitive to StringRef.

Create a new functino ComputeMappedEditDistance to avoid template argument deduction issues.

Jun 2 2022, 1:30 AM · Restricted Project, Restricted Project
njames93 requested review of D126859: [clangd] Validate clang-tidy CheckOptions in clangd config.
Jun 2 2022, 1:16 AM · Restricted Project, Restricted Project

May 25 2022

njames93 committed rG09ef6da8dcd8: [clang-tidy] Update docs for SimplifyDeMorganRelaxed (authored by njames93).
[clang-tidy] Update docs for SimplifyDeMorganRelaxed
May 25 2022, 5:12 AM · Restricted Project, Restricted Project
njames93 committed rGf3c1d281767a: [clang-tidy] Extend SimplifyBooleanExpr demorgan support. (authored by njames93).
[clang-tidy] Extend SimplifyBooleanExpr demorgan support.
May 25 2022, 5:09 AM · Restricted Project, Restricted Project
njames93 closed D126162: [clang-tidy] Extend SimplifyBooleanExpr demorgan support..
May 25 2022, 5:09 AM · Restricted Project, Restricted Project
njames93 updated the diff for D126162: [clang-tidy] Extend SimplifyBooleanExpr demorgan support..

Add note to docs that this new option has no effect if SimplifyDeMorgan is false.

May 25 2022, 5:08 AM · Restricted Project, Restricted Project
njames93 updated the diff for D126159: [ADT] Add edit_distance_insensitive to StringRef.

Remove unnecessary '+'

May 25 2022, 3:47 AM · Restricted Project, Restricted Project
njames93 added inline comments to D126159: [ADT] Add edit_distance_insensitive to StringRef.
May 25 2022, 3:32 AM · Restricted Project, Restricted Project

May 23 2022

njames93 updated the diff for D126159: [ADT] Add edit_distance_insensitive to StringRef.

Remove code duplication by adding an extra Map parameter to llvm::ComputeEditDistance.

May 23 2022, 8:19 PM · Restricted Project, Restricted Project
njames93 added a comment to D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values.

This diff looks like it's rooted on the clang-tools-extra directory which is why the pre-merge bot is failing to build.

May 23 2022, 4:26 AM · Restricted Project, Restricted Project
njames93 added a comment to D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values.

Please upload diff with full context.
Can you add a note about this in the release notes.

May 23 2022, 3:20 AM · Restricted Project, Restricted Project

May 22 2022

njames93 edited reviewers for D126077: Fix stack crash in classIsDerivedFrom triggered by clang-tidy, added: aaron.ballman, njames93, alexfh, LegalizeAdulthood; removed: bixia, aartbik.

Do you know of any other instances where this issue could surface?

May 22 2022, 4:00 AM · Restricted Project, Restricted Project, Restricted Project
njames93 added a comment to D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables.

Pretty much good to go, just a few nits with the tests.
Can you add CHECK-FIXES directives for all warnings if there should be a fixit.
If there shouldn't be one could you either add a comment saying there shouldn't be one, or put a CHECK-FIXES-NOT directive.

May 22 2022, 3:43 AM · Restricted Project, Restricted Project, Restricted Project
njames93 requested review of D126162: [clang-tidy] Extend SimplifyBooleanExpr demorgan support..
May 22 2022, 3:23 AM · Restricted Project, Restricted Project
njames93 committed rG9d0d24eec447: [clang-tidy] Fix not updating storeOptions after af77b1d9901 (authored by njames93).
[clang-tidy] Fix not updating storeOptions after af77b1d9901
May 22 2022, 2:29 AM · Restricted Project, Restricted Project
njames93 planned changes to D125837: [ADT] Make ArrayRef constexpr friendly.

Gonna put this on postpone until we start using c++17 as many things which should be constexpr just aren't as we are using c++14

May 22 2022, 2:10 AM · Restricted Project, Restricted Project