- User Since
- Dec 23 2019, 11:05 AM (132 w, 2 d)
Add a static assert to verify smaller size.
The standard places no such restriction and clang(on a 64 bit build) currently determines StringMap to be 32 bytes, after this patch it drops to 24 bytes.
It's not adding a new warning, so chattiness of this patch shouldn't really be much of an issue.
I decided against updating the docs link to the YAML specification and this change is simply about bringing the YamlIO implementation more inline with the actual specification.
Remove unnecessary extra include.
Mon, Jul 4
Fri, Jul 1
I'd say land this, but keep a close eye on the build bots as it may need reverting.
Thu, Jun 30
Tweak alias/anchor output.
remove code duplication.
Changed to only use the major version.
If this still seems too flaky, happy to go back to just linking to the in progress release notes.
Any issues with this now for getting correct version?
Fix lit cfg typo
Emit documentation links for the version of clangd built.
Missed something from last update.
Remove recursive nature of alias expansion as alias nodes cannot be anchored.
Emit fix hints for removing the tags.
-expect-clang-tidy-error is the technically correct flag to use, but I'm easy either way.
Wed, Jun 29
Tue, Jun 28
Mon, Jun 27
Fixed failing test cases by reverting Bitset Flow change
Added infrastructure to simplify emitting complex types.
Sun, Jun 26
Fri, Jun 24
Pointing the documentation links based on build configuration and version definitely makes sense as evolving checks could easily confuse users.
Guess the idea is snapshot builds will use the in progress release notes, and release builds can point to the actual release documentation
Thu, Jun 23
Rebase to check CI
Wed, Jun 22
Rebased and addressed comments
Thank you for this, it has been annoying me for a while.
I'll give a tentative LG, but I'm no expert in this area so see what everyone else says first.
Just noticed something nice about this, cmake targets are generated for each module
Should speed up development as you now only need to run the lit tests for the module that you are working on check-clang-extra-clang-tidy-checkers-misc etc
Update some test files using new syntax.
Remove typo correction support.
Can this patch be split in two, it seems strange to be fixing 2 unrelated bugs in one patch.
One fix for the ObjC nodes and another for the patch for the static local variables.
Address reviewer comments.
A specific example i encountered is clang/Tooling/DiagnosticsYaml.h Which defines template specializations for inputting/outputting yaml io. That file must be included if you ever want to emit diagnostics as YAML, but the typical use case is to just use the operator<< on a yaml stream. This function internally will use those specializations, but as clangd doesn't look into the function calls and expand all those instantiations, they are treated as being unused(There's many bugs already related to this) and as such the header is marked as being unused.
Tue, Jun 21
I had another idea about offering the export pragma when in a header file but I don't know if that's going too far
Mon, Jun 20
Reuse implementation from D127446
Sat, Jun 18
Fri, Jun 10
Gonna wait for the infrastructure from D127446 to land first, can reuse most of that implementation.
I choose not to as I'd imagine it could would result in duplicated warnings when batch processing using run_clang_tidy over a large project.
Also if there's any edge cases, maybe with the static analyser, I wouldn't want those diagnostics triggering by default with no way to silence them.
I wouldn't be opposed to the possibility of making on by default after its had some time in the wild.
Thu, Jun 9
Search engines isn't really an issue, its more people who are using older versions of llvm that try and go to the documentation which turns out is a dead link.
Having said that, I still think the lack of a redirect shouldn't block this change.
Wed, Jun 8
LGTM, just a couple points but not essential.
Jun 7 2022
Add tests to verify bailing out.
Jun 5 2022
Use reference lifetime extension.
Jun 3 2022
I feel that this case should produce a warning akin to the no self assignment diagnostics, obviously nothing to do with this check though.
Jun 2 2022
LGTM, But please add a note to ReleaseNotes before landing.
Can I ask what the motivation is for this change?
Cache outer loop map item.
Create a new functino ComputeMappedEditDistance to avoid template argument deduction issues.
May 25 2022
Add note to docs that this new option has no effect if SimplifyDeMorgan is false.
Remove unnecessary '+'
May 23 2022
Remove code duplication by adding an extra Map parameter to llvm::ComputeEditDistance.
This diff looks like it's rooted on the clang-tools-extra directory which is why the pre-merge bot is failing to build.
Please upload diff with full context.
Can you add a note about this in the release notes.
May 22 2022
Do you know of any other instances where this issue could surface?
Pretty much good to go, just a few nits with the tests.
Can you add CHECK-FIXES directives for all warnings if there should be a fixit.
If there shouldn't be one could you either add a comment saying there shouldn't be one, or put a CHECK-FIXES-NOT directive.