Page MenuHomePhabricator

njames93 (Nathan James)
Newb with a keyboard

Projects

User does not belong to any projects.

User Details

User Since
Dec 23 2019, 11:05 AM (39 w, 6 d)

Recent Activity

Fri, Sep 25

njames93 added inline comments to D88297: [clangd] Trivial setter support when moving items to fields.
Fri, Sep 25, 9:57 AM · Restricted Project
njames93 updated the diff for D88297: [clangd] Trivial setter support when moving items to fields.

Updated function doc
Fix potential assertion

Fri, Sep 25, 9:57 AM · Restricted Project
njames93 requested review of D88297: [clangd] Trivial setter support when moving items to fields.
Fri, Sep 25, 6:01 AM · Restricted Project

Wed, Sep 16

njames93 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

So, I think either this patch needs to be landed after some tweaking to try and bring the compile size down, though as it only appears to be an issue with clang it can probably afford some regression on gcc. Or we explicitly state that small vector is not safe to self reference itself and add instrumentation to enforce that behaviour. Right now we are in a middle ground where there are some guarantees made but not enough.
I would hedge my bets that there are definitely some code clients(whether in tree or not) that are currently using SmallVector incorrectly and sometimes run into little bugs like this.
Also for the record I have just built with gcc and noticed the same kind of regressions on the text size so at least I can have a look into this myself

Wed, Sep 16, 1:11 AM · Restricted Project

Tue, Sep 15

njames93 added a comment to D87683: [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc.

Please fix the test case first, can't call operator new(unsigned long, void*) with an argument of type void*
The other failures the pre merge bot detected can safely be disregarded

Tue, Sep 15, 9:27 AM · Restricted Project, Restricted Project
njames93 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

@nikic Would you be able to see what the delta with this is https://gist.github.com/njames93/f26f159f06bda9e7ed2270adb39d9b08, should apply on top of trunk. It has the most expensive part of the grow buffer defined outline to dissuade inlining, may reduce binary size and improve performance with gcc9.3

Tue, Sep 15, 4:16 AM · Restricted Project
njames93 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Tested the newest version of this patch and I'm still seeing massive regressions, even larger than before.

Compile-time (instructions retired): https://llvm-compile-time-tracker.com/compare.php?from=cc947207283f934c72af0eb0b1a08978c59d40a2&to=d99c6d441764431519c1c11d490e7e88ffe06775&stat=instructions This is now a 1.4% geomean regression at O3, with 2% at O3, with tramp3d-v4 hitting 3%.

Max RSS: https://llvm-compile-time-tracker.com/compare.php?from=cc947207283f934c72af0eb0b1a08978c59d40a2&to=d99c6d441764431519c1c11d490e7e88ffe06775&stat=max-rss This is now a 1.6% geomean regression at O3, with 2.1% at O0.

Clang text size goes from 80560905 to 82179908, a 2% regression (non-LTO build using GCC 9.3).

I'm still seeing a different picture with clang-10 as the host compiler, I'm only targetting x86 which explains why my binaries are so much smaller than yours.

orig-o3  54404996
this-03  54046228
orig-lto 69549814
this-lto 65981798

The most likely reason for a larger binary in GCC is in the original file, the calls to grow weren't inlined. Now, most of that code for using a new buffer is inlined. Clang may handle things a little differently.
Maybe I could define the swap buffer methods out of line to dissuade inlining.

Tue, Sep 15, 3:20 AM · Restricted Project

Mon, Sep 14

njames93 updated the diff for D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Add tests for SmallVector::assign to ensure contents aren't copied excessive amounts of times.

Mon, Sep 14, 8:07 PM · Restricted Project
njames93 added a comment to D87627: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class.

Please fix the clang-format fail too.

Mon, Sep 14, 7:53 PM · Restricted Project, Restricted Project
njames93 updated the diff for D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Remove excessive this-> from GrowBuffer.
Use range-based loop instead of for_each.

Mon, Sep 14, 7:46 PM · Restricted Project
njames93 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Use global namespace new inside GrowBuffer.

Why this change? Would've thought op new overloads might be desirable, but I certainly don't know the specifics off-hand right now.

SmallVector seems to use global namespace new for all its operations, so I thought I'd follow the convention there.

Mon, Sep 14, 7:46 PM · Restricted Project
njames93 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Format was provided by clang-format-11. the pre-merge bot is using 10 so I think I should ignore the format messages.

Mon, Sep 14, 7:33 AM · Restricted Project
njames93 updated the diff for D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Move grow_size into SmallVectorBase

Mon, Sep 14, 6:23 AM · Restricted Project
njames93 requested review of D87606: [ADT] Remove unnecessary copies in SmallVectorImpl::swap.
Mon, Sep 14, 5:39 AM · Restricted Project
njames93 updated the diff for D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Fix for the case if anyone tries SmallVector.emplace_back(SmallVector[X]) being invalidated on growth.
Added missing else if inside SmallVector append methods.
Refactored GrowBufferBase to take the Size_T as the template arguments to reduce template instantiations.
Use global namespace new inside GrowBuffer.

Mon, Sep 14, 5:01 AM · Restricted Project
njames93 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Yeah, seems that SmallVector::push_back should be fixed to allow a.push_back(a[0]). SmallVector::insert has been fixed in rL134554

It hasn't, that handles the case where the element to insert is moved when shifting the elements down to make room, but not when the element to insert is moved because of container growth.

Yeah, agreed. rL134554 was only half the fix (fixing the non-growth case). Your/this patch now fixes the other half (the growth case) and fixes the push_back case (which only has a problem on growth, doesn't have a problem on non-growth, unlike insert). Great! :)

Yeah thats whats happening here.

Mon, Sep 14, 3:15 AM · Restricted Project
njames93 planned changes to D87237: [ADT] Add ASAN Support for SmallVector.

Adding some potential reviewers

Mon, Sep 14, 2:07 AM · Restricted Project

Sun, Sep 13

njames93 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Yeah, seems that SmallVector::push_back should be fixed to allow a.push_back(a[0]). SmallVector::insert has been fixed in rL134554

Sun, Sep 13, 1:32 AM · Restricted Project
njames93 updated the diff for D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Address a few inlines

Sun, Sep 13, 1:32 AM · Restricted Project
njames93 updated the diff for D87237: [ADT] Add ASAN Support for SmallVector.

Undo SmallVectorTest fix

Sun, Sep 13, 1:06 AM · Restricted Project

Sat, Sep 12

njames93 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Hmm - I think maybe what I had trouble with was understanding how much this shuold generalize. Should this handle subranges? (if you try to append half of a vector onto itself) and if so, how? Anyone happen to know what's guaranteed by the standard (perhaps only push_back of single elements - that's easier to handle)

Sat, Sep 12, 6:47 AM · Restricted Project

Thu, Sep 10

njames93 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Here's the compile-time impact I see with this change:

1.2% regression in instructions retired: https://llvm-compile-time-tracker.com/compare.php?from=3c42c0dcf631ad6b90e718df895c05f79718659f&to=606330864b2349e29beb460ae69fa41c0170674e&stat=instructions
1.0% max-rss regression: https://llvm-compile-time-tracker.com/compare.php?from=3c42c0dcf631ad6b90e718df895c05f79718659f&to=606330864b2349e29beb460ae69fa41c0170674e&stat=max-rss

The max-rss regression is presumably due to an increase in clang binary size. Manually checking the data, size-text goes from 80490755 to 81122130, i.e. 0.8% increase.

What build flags are you using. I tried a release build with thinlto. Also tried to move some of this code into the cpp file by type erasing the template out of GrowBufferBase.
For the record I'm testing on a Ryzen 2600X on ubuntu 20.04 and using clang-10 as the host compiler and linking with lld-10

trunk      - size.text = 42483D6, size.binary = 6141438
this       - size.text = 3EBD276, size.binary = 5DDD940
type-erase - size.text = 3EC0B26, size.binary = 5DE1290
Thu, Sep 10, 2:13 PM · Restricted Project
njames93 updated the diff for D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Fix build error when appending iterators of types convertible to SmallVector::value_type

Thu, Sep 10, 5:56 AM · Restricted Project
njames93 updated the summary of D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.
Thu, Sep 10, 5:22 AM · Restricted Project
njames93 updated the diff for D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Add buffer to append(iterator, iterator) to handle SmallVec.append(SmallVec.begin(), SmallVec.end());

Thu, Sep 10, 5:12 AM · Restricted Project
njames93 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Could you please rebase this to current master? I wasn't able to git apply it. (Sorry, Phabricator troubles. It's hard to believe that a code review tool is incapable of properly retaining merge bases.)

Thu, Sep 10, 4:53 AM · Restricted Project
njames93 updated the diff for D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Rebased trunk and fixed up assign to use new buffer

Thu, Sep 10, 4:52 AM · Restricted Project

Wed, Sep 9

njames93 updated the diff for D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Extend behaviour to more methods.

Wed, Sep 9, 6:56 PM · Restricted Project
njames93 updated the diff for D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Harden test cases for SmallVector

Wed, Sep 9, 4:48 PM · Restricted Project
njames93 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

For the clang tidy naming warnings, is it better to follow the warnings, or the current convention of the file?

Wed, Sep 9, 7:45 AM · Restricted Project

Tue, Sep 8

njames93 requested review of D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.
Tue, Sep 8, 1:45 PM · Restricted Project
njames93 updated the diff for D87237: [ADT] Add ASAN Support for SmallVector.

Undo fix for self referencing insertion

Tue, Sep 8, 12:28 AM · Restricted Project

Mon, Sep 7

njames93 added a comment to D86671: [clang-tidy] Add new case type to check variables with Hungarian notation.

Did you upload this incorrectly again, context is missing and seems to be a relative diff from a previous version of this patch?

Sorry for it, I think it's my bad. It is possible that I manually merged the last master(github) with changes then updated them both via web interface ...

Can I fix it if switch back to the base (14948a0) then merge all my changes, then update the diff again via web interface? Or do you have any better suggestion?

I am curious about how do you know this mistake? You got error messages with arc patch D86671 ?

The no context is easy to spot as phab says context not available. Its easy to find knowing that there is no mention of hungarian notation in the trunk version of IdentifierNamingCheck.cpp, yet there is mention of that in the before diff.

Mon, Sep 7, 10:09 AM · Restricted Project, Restricted Project
njames93 added inline comments to D87237: [ADT] Add ASAN Support for SmallVector.
Mon, Sep 7, 8:46 AM · Restricted Project
njames93 added a comment to D86671: [clang-tidy] Add new case type to check variables with Hungarian notation.

Did you upload this incorrectly again, context is missing and seems to be a relative diff from a previous version of this patch?

Mon, Sep 7, 8:30 AM · Restricted Project, Restricted Project
njames93 requested review of D87237: [ADT] Add ASAN Support for SmallVector.
Mon, Sep 7, 7:37 AM · Restricted Project

Sun, Aug 30

njames93 added a comment to D86671: [clang-tidy] Add new case type to check variables with Hungarian notation.

As Hungarian notation enforces prefixes as well as casing styles it would be wise to warn on cases where the style is Hungarian but a prefix has also been set.

Sun, Aug 30, 12:39 AM · Restricted Project, Restricted Project

Aug 28 2020

njames93 added inline comments to D86671: [clang-tidy] Add new case type to check variables with Hungarian notation.
Aug 28 2020, 8:47 AM · Restricted Project, Restricted Project
njames93 added a comment to D86671: [clang-tidy] Add new case type to check variables with Hungarian notation.

Can you make sure you upload diffs with full context (-U99999). Or using arcanist it will be done automatically.

Aug 28 2020, 1:18 AM · Restricted Project, Restricted Project

Aug 27 2020

njames93 committed rG3776999b494d: [clang-query][NFC] Silence a few lint warnings (authored by njames93).
[clang-query][NFC] Silence a few lint warnings
Aug 27 2020, 5:07 PM

Aug 22 2020

njames93 committed rGdf5335a36d3d: [clang-tidy] readability-simplify-boolean-expr detects negated literals (authored by njames93).
[clang-tidy] readability-simplify-boolean-expr detects negated literals
Aug 22 2020, 5:58 AM
njames93 closed D86176: [clang-tidy] readability-simplify-boolean-expr detects negated literals.
Aug 22 2020, 5:57 AM · Restricted Project

Aug 20 2020

njames93 added inline comments to D86176: [clang-tidy] readability-simplify-boolean-expr detects negated literals.
Aug 20 2020, 11:19 PM · Restricted Project
njames93 added inline comments to D86176: [clang-tidy] readability-simplify-boolean-expr detects negated literals.
Aug 20 2020, 7:02 AM · Restricted Project

Aug 18 2020

njames93 requested review of D86176: [clang-tidy] readability-simplify-boolean-expr detects negated literals.
Aug 18 2020, 3:53 PM · Restricted Project
njames93 committed rG8c9ffe34d932: [NFC][clang-tidy] Put abseil headers in alphabetical order (authored by njames93).
[NFC][clang-tidy] Put abseil headers in alphabetical order
Aug 18 2020, 7:53 AM

Aug 13 2020

njames93 added inline comments to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.
Aug 13 2020, 2:06 PM · Restricted Project, Restricted Project
njames93 added inline comments to D83224: [clangd] Move clang-tidy check modifications into ClangdServer.
Aug 13 2020, 1:32 AM · Restricted Project

Aug 11 2020

njames93 added inline comments to D83224: [clangd] Move clang-tidy check modifications into ClangdServer.
Aug 11 2020, 5:33 PM · Restricted Project
njames93 added inline comments to D85666: [clang-tidy] IncludeInserter: allow <> in header name.
Aug 11 2020, 8:40 AM · Restricted Project
njames93 added a comment to D85666: [clang-tidy] IncludeInserter: allow <> in header name.

Should a line be added to the release notes to explain this behaviour:
'Checks that specify files to include now support wrapping the include in angle brackets to create a system include'?

Aug 11 2020, 2:37 AM · Restricted Project
njames93 added a comment to D85697: [clang-tidy] Add cppcoreguidelines-prefer-scoped-enums-over-unscoped.

Is 'over-unscoped' really needed in the name, would just 'prefer-scoped-enum' be better, WDYT?

Aug 11 2020, 2:28 AM · Restricted Project, Restricted Project

Aug 10 2020

njames93 added a comment to D85621: [clang] Allow DynTypedNode to store a TemplateArgumentLoc.

Please run clang/docs/tools/dump_ast_matchers.py script to update the LibASTMatchersReference.html file.

Done. Note, it looks like this script needs to be run with python 2. Should we document this somewhere?

Aug 10 2020, 1:06 AM · Restricted Project

Aug 8 2020

njames93 accepted D85568: [clang] Fix typo in comment.

LG, pretty trivial fix. Side note running that check over the code base leads to a lot of warnings, however most of false positives, like using abbreviations in the comment or parameter.

Aug 8 2020, 12:10 AM · Restricted Project

Aug 7 2020

njames93 added inline comments to D85568: [clang] Fix typo in comment.
Aug 7 2020, 5:40 PM · Restricted Project
njames93 committed rG01bc708126c5: [NFC] Replace hasName in loop for hasAnyName (authored by njames93).
[NFC] Replace hasName in loop for hasAnyName
Aug 7 2020, 2:23 AM

Aug 6 2020

njames93 added a comment to D85097: [Sema] add warning for comparisons like 'x<=y<=z'.

Also with a name like compare op parenthesis. It sounds like this would consider == and !=

Aug 6 2020, 12:13 AM · Restricted Project

Aug 4 2020

njames93 added a comment to D85072: [ADT] Add getAsOr to Optional.

Hmm, I'm not so sure - getValueOr, for instance, is in std::optional. (value_or)

You're right that 'map', for instance, is not in std::optional, though. That and maybe the "create" function are the non-std::optional API?

And getPointer

I think if this new function was a non-member, it'd probably tidier - wouldn't need an rvalue and non-rvalue overload, as it could use std::forward on both arguments.

non-member could work I guess, and could be adapted for other cases, std::optional or pointers spring to mind.

Aug 4 2020, 6:18 AM · Restricted Project
njames93 updated the diff for D81923: [clang-tidy] Add modernize-use-ranges check..

rebase

Aug 4 2020, 6:12 AM · Restricted Project
njames93 committed rG7c4782ce91d6: [clang-tidy] Fix regression in RenamerClangTidy (authored by njames93).
[clang-tidy] Fix regression in RenamerClangTidy
Aug 4 2020, 1:27 AM

Aug 3 2020

njames93 committed rG3b44b6c900d1: [clang-tidy][NFC] Use correct size call for reserve (authored by njames93).
[clang-tidy][NFC] Use correct size call for reserve
Aug 3 2020, 4:31 PM
njames93 updated the diff for D82089: [clang-tidy] modernize-loop-convert reverse iteration support.
  • Rebased trunk
  • Cleaned up test cases
  • Added support for specifying to include as system include.
Aug 3 2020, 4:10 PM · Restricted Project
njames93 added inline comments to D85097: [Sema] add warning for comparisons like 'x<=y<=z'.
Aug 3 2020, 2:34 PM · Restricted Project
njames93 added inline comments to D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C.
Aug 3 2020, 7:06 AM · Restricted Project, Restricted Project, Restricted Project
njames93 updated the diff for D85072: [ADT] Add getAsOr to Optional.

Delete the rvalue reference version as it can create dangling references

Aug 3 2020, 2:58 AM · Restricted Project
njames93 added a comment to D85072: [ADT] Add getAsOr to Optional.

I forget: Have we already decided that Optional won't be replaced by std::optional? If not, then would be good to not add API surface area that doesn't match std::optional (instead preferring non-member functions, for instance).
If that's already been decided in some previous reviews, etc, this sounds OK I guess.

If that's the case then I'd agree with that.
But I kind of gathered it wouldn't be the case considering how much the llvm::Optional API already differs from std::optional.

Probably doesn't need the enable_if, I'd have thought (could just let the implementation fail as usual - there aren't competing member functions, etc)

Fair enough point there.

the parameter should be U&& to use with std::forward, avoid unnecessary copies, etc.

I'm inclined to disagree with that point, this is mean't to be used with types that are cheap to construct and usually passed by value.
Probably don't need the call to std::forward though.

Aug 3 2020, 2:43 AM · Restricted Project
njames93 updated the diff for D85072: [ADT] Add getAsOr to Optional.

Remove call to forward as it serves no purpose for the use case

Aug 3 2020, 2:42 AM · Restricted Project

Aug 1 2020

njames93 added inline comments to D85028: [clangd] Support new/delete operator in TargetFinder..
Aug 1 2020, 8:51 AM · Restricted Project
njames93 added a comment to D84898: [clang-tidy] Add new checker for complex conditions with no meaning.

I believe all review comments have been address, except for the discussion on implementing this in the CFE or as a tidy check.

Aug 1 2020, 8:47 AM · Restricted Project, Restricted Project
njames93 requested review of D85072: [ADT] Add getAsOr to Optional.
Aug 1 2020, 3:23 AM · Restricted Project
njames93 committed rG9f21947a3312: [clang-tidy][NFC] Small refactor (authored by njames93).
[clang-tidy][NFC] Small refactor
Aug 1 2020, 3:05 AM
njames93 committed rG4888c9ce97d8: [clang-tidy] readability-identifier-naming checks configs for included files (authored by njames93).
[clang-tidy] readability-identifier-naming checks configs for included files
Aug 1 2020, 2:36 AM
njames93 closed D84814: [clang-tidy] readability-identifier-naming checks configs for included files.
Aug 1 2020, 2:35 AM · Restricted Project
njames93 updated the diff for D84814: [clang-tidy] readability-identifier-naming checks configs for included files.

Fix unpunctuated comment and simplify second check command.

Aug 1 2020, 1:19 AM · Restricted Project
njames93 updated the diff for D84814: [clang-tidy] readability-identifier-naming checks configs for included files.
  • Address comments.
  • Added test case for when this behaviour is disabled.
Aug 1 2020, 1:14 AM · Restricted Project

Jul 31 2020

njames93 committed rG1fd2049e38da: [clang-tidy][NFC] Added convienence methods for getting optional options (authored by njames93).
[clang-tidy][NFC] Added convienence methods for getting optional options
Jul 31 2020, 5:46 PM
njames93 closed D84812: [clang-tidy][NFC] Added convienence methods for getting optional options.
Jul 31 2020, 5:46 PM · Restricted Project
njames93 requested review of D84814: [clang-tidy] readability-identifier-naming checks configs for included files.
Jul 31 2020, 3:15 AM · Restricted Project
njames93 updated the diff for D84814: [clang-tidy] readability-identifier-naming checks configs for included files.

Added Option GetConfigPerFile to control this behaviour.
Ensure the check is enabled in the header files configuration before using any configuration found.

Jul 31 2020, 3:14 AM · Restricted Project

Jul 30 2020

njames93 added inline comments to D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency.
Jul 30 2020, 3:57 PM · Restricted Project, Restricted Project
njames93 committed rGc23ae3f18ee3: [clang-tidy][NFC] Use StringMap for ClangTidyCheckFactories::FacoryMap (authored by njames93).
[clang-tidy][NFC] Use StringMap for ClangTidyCheckFactories::FacoryMap
Jul 30 2020, 2:58 PM
njames93 closed D84926: [clang-tidy][NFC] Use StringMap for ClangTidyCheckFactories::FacoryMap.
Jul 30 2020, 2:58 PM · Restricted Project
njames93 added inline comments to D84924: [clang-tidy][WIP] Added command line option `fix-notes`.
Jul 30 2020, 9:30 AM · Restricted Project, Restricted Project
njames93 updated the diff for D84926: [clang-tidy][NFC] Use StringMap for ClangTidyCheckFactories::FacoryMap.

Fix build errors

Jul 30 2020, 3:24 AM · Restricted Project
njames93 requested review of D84926: [clang-tidy][NFC] Use StringMap for ClangTidyCheckFactories::FacoryMap.
Jul 30 2020, 3:03 AM · Restricted Project
njames93 committed rG45a720a86432: [clang-tidy] Use StringMap for ClangTidyOptions::OptionsMap (authored by njames93).
[clang-tidy] Use StringMap for ClangTidyOptions::OptionsMap
Jul 30 2020, 2:31 AM
njames93 closed D84868: [clang-tidy] Use StringMap for ClangTidyOptions::OptionsMap.
Jul 30 2020, 2:31 AM · Restricted Project
njames93 added a comment to D84924: [clang-tidy][WIP] Added command line option `fix-notes`.

This is very much a work in progress
Another direction I was thinking was only apply the fixes found in notes if there is exactly one fix attached to the notes in a diagnostic, instead of just applying the first one we find

Jul 30 2020, 2:23 AM · Restricted Project, Restricted Project
njames93 retitled D84924: [clang-tidy][WIP] Added command line option `fix-notes` from [clang-tidy] Added command line option `fix-notes` to [clang-tidy][WIP] Added command line option `fix-notes`.
Jul 30 2020, 2:22 AM · Restricted Project, Restricted Project
njames93 requested review of D84924: [clang-tidy][WIP] Added command line option `fix-notes`.
Jul 30 2020, 2:22 AM · Restricted Project, Restricted Project
njames93 accepted D84902: [clang-tidy] Fix ODR violation in unittests..

LGTM, Thanks that bug was eating away at me for a good few days.

Jul 30 2020, 1:50 AM · Restricted Project
njames93 added a comment to D84898: [clang-tidy] Add new checker for complex conditions with no meaning.

For the record X < Y < Z does have a mathematical meaning, Y is constrained between X and Z.
However in the context of C the expression isnt parsed like that.
If someone writes this they likely wanted (X < Y) && (Y < Z)
For this specific check as you pointed out we wouldn't want to make that assumption though there is a case for adding notes to silence the warning by wrapping one of the comparisons in parenthesis.

Jul 30 2020, 1:08 AM · Restricted Project, Restricted Project

Jul 29 2020

njames93 updated the diff for D84814: [clang-tidy] readability-identifier-naming checks configs for included files.

Rebase from parent and address comments.

Jul 29 2020, 3:48 PM · Restricted Project
njames93 updated the diff for D84812: [clang-tidy][NFC] Added convienence methods for getting optional options.

Revert to using warning for logging parsing errors

Jul 29 2020, 3:31 PM · Restricted Project
njames93 added reviewers for D75813: [clang-tidy] fix readability-braces-around-statements Stmt type dependency: aaron.ballman, gribozavr2.

*ping*
Sorry, but I have to ask: Is there no interest in improving clang-tidy?
Don't get me wrong. I know it's mostly volunteered time. That's also why this ping took almost 2 months for me.
I frankly lost interest in contributing as I have trouble getting any patches included - and I don't have that much free time anymore. Obviously the time issue is more important, but the other one is still a problem.

Jul 29 2020, 3:09 PM · Restricted Project, Restricted Project
njames93 updated the diff for D84868: [clang-tidy] Use StringMap for ClangTidyOptions::OptionsMap.

Missing call to getValue()

Jul 29 2020, 9:27 AM · Restricted Project
njames93 requested review of D84868: [clang-tidy] Use StringMap for ClangTidyOptions::OptionsMap.
Jul 29 2020, 9:23 AM · Restricted Project
njames93 committed rGbbc2ddecbd34: [clang-tidy] Handled insertion only fixits when determining conflicts. (authored by njames93).
[clang-tidy] Handled insertion only fixits when determining conflicts.
Jul 29 2020, 8:36 AM
njames93 closed D82898: [clang-tidy] Handled insertion only fixits when determining conflicts..
Jul 29 2020, 8:35 AM · Restricted Project, Restricted Project
njames93 committed rG62beb7c6f4f2: [clang-tidy] Fix module options being registered with different priorities (authored by njames93).
[clang-tidy] Fix module options being registered with different priorities
Jul 29 2020, 8:19 AM