Page MenuHomePhabricator

[clang] Make libBasic not depend on MC
ClosedPublic

Authored by thakis on Apr 28 2021, 7:59 AM.

Details

Summary

Reduces numbers of files built for clang-format from 575 to 449.

Requires two small changes.

  1. Don't use llvm::ExceptionHandling in LangOptions. This isn't even quite the right type since we don't use all of its values. Tweaks the changes made in:
  1. Move section name validation code added (long ago) in commit 30ba67439 out of libBasic into Sema and base the check on the triple. This is a bit less OOP-y, but completely in line with what we do in many other places in Sema.

No behavior change.

Diff Detail

Event Timeline

thakis created this revision.Apr 28 2021, 7:59 AM
thakis requested review of this revision.Apr 28 2021, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2021, 7:59 AM
hans accepted this revision.Apr 28 2021, 8:28 AM
This revision is now accepted and ready to land.Apr 28 2021, 8:28 AM
This revision was landed with ongoing or failed builds.Apr 28 2021, 9:16 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2021, 9:16 AM