- User Since
- Mar 7 2019, 1:49 AM (55 w, 2 d)
Thu, Mar 26
Mon, Mar 16
Fri, Mar 6
This patch introduced a crash while I was analyzing the libpressio.
I was using the CodeChecker to drive the analysis with the --enable-all flag.
Wed, Mar 4
Tue, Mar 3
I don't have any technical comments on this patch since I haven't used NoteTags yet, only a couple of readability ones.
Feb 25 2020
Marking comments done.
Declaring the purpose of this checker:
[...] This would help to reduce the *noise* that the `TaintTest` debug checker would introduce and let you focus on the `expected-warning`s that you really care about.
Feb 21 2020
Feb 20 2020
If this patch is good to go, could someone commit it?
I don't have commit access (yet).
Feb 19 2020
Feb 18 2020
Upload the right diff.
Feb 12 2020
Feb 11 2020
Feb 10 2020
Rebased on top of master, instead of D71524.
Feb 7 2020
Clarified example usage, especially in contrast of eg.: debug.TaintTest checker.
- Tests added.
- Clang-format-diff applied.
I genuinely think that in the following case we should warn, since the user already had a chance to express the range assumption using an assert.
Feb 6 2020
Feb 5 2020
I'm convinced that we shouldn't remove taint from expressions used in comparisons.
Jan 28 2020
Dec 31 2019
Nov 22 2019
Oct 30 2019
Oct 24 2019
Oct 19 2019
Oct 15 2019
Thank you guys the responses. I cannot agree more. The sole reason why this option exists is that if you scroll back in the git blame of that line, you would find a commit, which removed this warning for this exact scenario.
Possibly due to some seemingly false positives.
I've added the author of that patch to the reviewers of this change, but did not respond.
I think this patch is ok.
Sep 7 2019
Sep 5 2019
Aug 28 2019
- Flag option marked as 'enabled by default'.
- Reformat all the test cases for C, C++ and Obj C.
- Now uses -verify=tags approach.
- Fixes checker documentation.
Fixes for @NoQ's comments.
I will update the patch.
Aug 27 2019
@Szelethus The mispositioned report message was my fault. I used a different version of clang for the analysis and to upload the results, which resulted in some mispositioned reports.
I've fixed the linked CodeChecker instance.
Aug 26 2019
@Szelethus Your catch with the mispositioned report message is kinda strange. I will investigate that, but I think it's probably connected to something deeper, and most likely related to CodeChecker itself.
@NoQ What do you think, should it be under a flag (as it would be now), or enabled by default?
I think these warnings are valuable and we should consider it enabling by default.
An interesting fact is that previously rGf224820b45c6847b91071da8d7ade59f373b96f3 patch disabled this warning saying that it generates too many false-positives without any real benefit.
Fix copy-paste mistake.
This time upload the correct version.
Reformatted using clang-format-diff.py.
Minor fixes which were requested by @Szelethus.
Thank you for your response @Szelethus.
Fixed, updating the patch.
Aug 2 2019
Do you have some time @Szelethus to check this change?
Your experience and comments would help a lot to finish this.
Jul 3 2019
What do you think, what should I improve in this checker?
Your remarks, @lebedev.ri, were really valuable.
Jun 4 2019
- Removed different signess related parts.
- Don't warn for the casts which are already covered by '-Wcast-align' check.
- Improved the diagnostic messages:
- Now adds notes for the first incompatible members of structs.
- Added alignment, size and type information to most of the warning messages.
Jun 3 2019
The problem with the -Wcast-align is that it will only fire for C-style bitcast expressions, not for reinterpret_cast ones. example
Does anyone know why is that behavior?
Unfortunately the changes that I've made are not available in a diff because I've moved to the monorepo version.
Although, you can see the changes in detail on my llvm-project github fork.
If you don't mind I will finish the leftover work. This will still be committed under your name.
Mar 7 2019
@hgabii Are you planning on finishing this? If not, I'd happily commandeer if not.