Page MenuHomePhabricator

steakhal (Balázs Benics)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 1:49 AM (55 w, 2 d)

Recent Activity

Thu, Mar 26

steakhal created D76837: [NFC] Fix Z3 version detection regexp in llvm/cmake/modules/FindZ3.cmake.
Thu, Mar 26, 4:50 AM · Restricted Project

Mon, Mar 16

steakhal added a comment to D71524: [analyzer] Support tainted objects in GenericTaintChecker.

Are we sure this is what we want? If this is a heuristic, we should document it well, and even then I'm not sure whether we want it. I'm also pretty sure this would make the eventual change to CallDescriptionMap more difficult, because the way taintedness is propagated around std::basic_istream not really the property of the global >> operator and what its parameters are, but rather the property of std::basic_istream<CharT,Traits>::operator>>, right? What do you think?

Mon, Mar 16, 7:35 AM · Restricted Project

Fri, Mar 6

steakhal added a comment to D74735: [analyzer] Add support for CXXInheritedCtorInitExpr..

This patch introduced a crash while I was analyzing the libpressio.
I was using the CodeChecker to drive the analysis with the --enable-all flag.

Fri, Mar 6, 1:07 AM · Restricted Project

Wed, Mar 4

steakhal committed rG95a94df5a9c3: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker (authored by steakhal).
[analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker
Wed, Mar 4, 8:26 AM
steakhal closed D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker.
Wed, Mar 4, 8:26 AM · Restricted Project
steakhal added inline comments to D75229: [clang-tidy] Add signal-in-multithreaded-program check.
Wed, Mar 4, 5:39 AM · Restricted Project, Restricted Project
steakhal added inline comments to D75430: [analyzer][NFC] Introduce CXXDeallocatorCall, deploy it in MallocChecker.
Wed, Mar 4, 3:58 AM · Restricted Project

Tue, Mar 3

steakhal added a comment to D71524: [analyzer] Support tainted objects in GenericTaintChecker.

@steakhal's revision is on the top of this. Changing the order will only cause unnecessary work on both sides.

I would happily rebase this patch if you want.

Tue, Mar 3, 9:56 AM · Restricted Project
steakhal added inline comments to D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint.
Tue, Mar 3, 9:39 AM · Restricted Project
steakhal added a comment to D75514: [Analyzer] Only add container note tags to the operations of the affected container.

I don't have any technical comments on this patch since I haven't used NoteTags yet, only a couple of readability ones.

Tue, Mar 3, 9:05 AM · Restricted Project
steakhal committed rG859bcf4e3bb9: [analyzer][taint] Add isTainted debug expression inspection check (authored by steakhal).
[analyzer][taint] Add isTainted debug expression inspection check
Tue, Mar 3, 5:41 AM
steakhal closed D74131: [analyzer][taint] Add isTainted debug expression inspection check.
Tue, Mar 3, 5:40 AM · Restricted Project
steakhal added a comment to D71524: [analyzer] Support tainted objects in GenericTaintChecker.

@steakhal's revision is on the top of this. Changing the order will only cause unnecessary work on both sides.

Tue, Mar 3, 3:04 AM · Restricted Project

Feb 25 2020

steakhal added a comment to D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker.

Wow. Its a joy to see you do C++. LGTM. Are you planning to introduce CallDescriptionMap at one point? :)

Feb 25 2020, 5:59 AM · Restricted Project
steakhal added a comment to D74131: [analyzer][taint] Add isTainted debug expression inspection check.

Marking comments done.

Feb 25 2020, 5:27 AM · Restricted Project
steakhal updated the diff for D74131: [analyzer][taint] Add isTainted debug expression inspection check.

Declaring the purpose of this checker:

[...]
This would help to reduce the *noise* that the `TaintTest` debug checker would
introduce and let you focus on the `expected-warning`s that you really care
about.
Feb 25 2020, 5:21 AM · Restricted Project

Feb 21 2020

steakhal added inline comments to D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints.
Feb 21 2020, 4:08 AM · Restricted Project

Feb 20 2020

steakhal added a comment to D74131: [analyzer][taint] Add isTainted debug expression inspection check.

If this patch is good to go, could someone commit it?
I don't have commit access (yet).

Feb 20 2020, 4:24 AM · Restricted Project

Feb 19 2020

steakhal added a comment to D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API.
In D74806#1882300, @NoQ wrote:

This is fantastic, i love it!

all tests are preserved and passing; only *the message changed at some places*. In my opinion, these messages are holding the same information.

You make it sound like an accident; i encourage you to have a closer look to make sure that there are no other effects than the ones observed on tests.

Feb 19 2020, 4:32 AM · Restricted Project
steakhal added a reviewer for D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API: Charusso.
Feb 19 2020, 2:04 AM · Restricted Project

Feb 18 2020

steakhal updated the diff for D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API.

Upload the right diff.

Feb 18 2020, 4:32 PM · Restricted Project
steakhal updated the summary of D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API.
Feb 18 2020, 4:32 PM · Restricted Project
steakhal created D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API.
Feb 18 2020, 4:32 PM · Restricted Project

Feb 12 2020

steakhal resigned from D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis.
Feb 12 2020, 8:05 AM · Restricted Project

Feb 11 2020

steakhal added inline comments to D70876: [clang-tidy] Add spuriously-wake-up-functions check.
Feb 11 2020, 11:30 PM · Restricted Project, Restricted Project

Feb 10 2020

steakhal removed a parent revision for D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker: D71524: [analyzer] Support tainted objects in GenericTaintChecker.
Feb 10 2020, 3:05 AM · Restricted Project
steakhal removed a child revision for D71524: [analyzer] Support tainted objects in GenericTaintChecker: D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker.
Feb 10 2020, 3:05 AM · Restricted Project
steakhal updated the diff for D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker.

Rebased on top of master, instead of D71524.

Feb 10 2020, 2:58 AM · Restricted Project
steakhal abandoned D73536: [analyzer][taint] Remove taint from symbolic expressions if used in comparisons.
Feb 10 2020, 2:11 AM · Restricted Project

Feb 7 2020

steakhal updated the diff for D74131: [analyzer][taint] Add isTainted debug expression inspection check.

Clarified example usage, especially in contrast of eg.: debug.TaintTest checker.

Feb 7 2020, 5:35 AM · Restricted Project
steakhal updated the diff for D74131: [analyzer][taint] Add isTainted debug expression inspection check.
  • Tests added.
  • Clang-format-diff applied.
Feb 7 2020, 5:27 AM · Restricted Project
steakhal added a comment to D73536: [analyzer][taint] Remove taint from symbolic expressions if used in comparisons.

I genuinely think that in the following case we should warn, since the user already had a chance to express the range assumption using an assert.

Feb 7 2020, 12:48 AM · Restricted Project

Feb 6 2020

steakhal created D74131: [analyzer][taint] Add isTainted debug expression inspection check.
Feb 6 2020, 7:57 AM · Restricted Project

Feb 5 2020

steakhal updated subscribers of D73536: [analyzer][taint] Remove taint from symbolic expressions if used in comparisons.

I'm convinced that we shouldn't remove taint from expressions used in comparisons.

Feb 5 2020, 6:02 AM · Restricted Project

Jan 28 2020

steakhal created D73536: [analyzer][taint] Remove taint from symbolic expressions if used in comparisons.
Jan 28 2020, 2:42 AM · Restricted Project
steakhal updated subscribers of D73536: [analyzer][taint] Remove taint from symbolic expressions if used in comparisons.
Jan 28 2020, 2:42 AM · Restricted Project

Dec 31 2019

steakhal added inline comments to D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker.
Dec 31 2019, 4:13 AM · Restricted Project
steakhal added a parent revision for D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker: D71524: [analyzer] Support tainted objects in GenericTaintChecker.
Dec 31 2019, 4:06 AM · Restricted Project
steakhal added a child revision for D71524: [analyzer] Support tainted objects in GenericTaintChecker: D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker.
Dec 31 2019, 4:06 AM · Restricted Project
steakhal created D72035: [analyzer][NFC] Use CallEvent checker callback in GenericTaintChecker.
Dec 31 2019, 4:06 AM · Restricted Project

Nov 22 2019

steakhal created D70596: [analyzer][docs] NFC: Extend documentation for MallocOverflow checker.
Nov 22 2019, 5:11 AM · Restricted Project

Oct 30 2019

steakhal added inline comments to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.
Oct 30 2019, 3:17 AM · Restricted Project

Oct 24 2019

steakhal added inline comments to D69181: [clang-tidy] Adding misc-signal-terminated-thread check.
Oct 24 2019, 12:53 PM · Restricted Project, Restricted Project

Oct 19 2019

steakhal added inline comments to D69181: [clang-tidy] Adding misc-signal-terminated-thread check.
Oct 19 2019, 4:08 AM · Restricted Project, Restricted Project

Oct 15 2019

steakhal added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

Thank you guys the responses. I cannot agree more. The sole reason why this option exists is that if you scroll back in the git blame of that line, you would find a commit, which removed this warning for this exact scenario.
Possibly due to some seemingly false positives.
I've added the author of that patch to the reviewers of this change, but did not respond.

Oct 15 2019, 11:45 AM · Restricted Project, Restricted Project
steakhal added a comment to D59516: [analyzer] Add custom filter functions for GenericTaintChecker.

I think this patch is ok.

Oct 15 2019, 1:58 AM · Restricted Project

Sep 7 2019

steakhal added inline comments to D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.
Sep 7 2019, 1:26 AM · Restricted Project

Sep 5 2019

steakhal added inline comments to D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.
Sep 5 2019, 5:04 AM · Restricted Project

Aug 28 2019

steakhal updated the diff for D66733: [analyzer] Add a checker option to detect nested dead stores.

Changes:

  • Flag option marked as 'enabled by default'.
  • Reformat all the test cases for C, C++ and Obj C.
  • Now uses -verify=tags approach.
  • Fixes checker documentation.
Aug 28 2019, 9:04 AM · Restricted Project, Restricted Project
steakhal added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

Fixes for @NoQ's comments.
I will update the patch.

Aug 28 2019, 8:50 AM · Restricted Project, Restricted Project

Aug 27 2019

steakhal added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

@Szelethus The mispositioned report message was my fault. I used a different version of clang for the analysis and to upload the results, which resulted in some mispositioned reports.
I've fixed the linked CodeChecker instance.

Aug 27 2019, 3:36 PM · Restricted Project, Restricted Project

Aug 26 2019

steakhal added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

@Szelethus Your catch with the mispositioned report message is kinda strange. I will investigate that, but I think it's probably connected to something deeper, and most likely related to CodeChecker itself.

Aug 26 2019, 12:52 PM · Restricted Project, Restricted Project
steakhal added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

@NoQ What do you think, should it be under a flag (as it would be now), or enabled by default?
I think these warnings are valuable and we should consider it enabling by default.
An interesting fact is that previously rGf224820b45c6847b91071da8d7ade59f373b96f3 patch disabled this warning saying that it generates too many false-positives without any real benefit.

Aug 26 2019, 8:47 AM · Restricted Project, Restricted Project
steakhal updated the diff for D66733: [analyzer] Add a checker option to detect nested dead stores.

Fix copy-paste mistake.
This time upload the correct version.

Aug 26 2019, 8:39 AM · Restricted Project, Restricted Project
steakhal updated the diff for D66733: [analyzer] Add a checker option to detect nested dead stores.

Reformatted using clang-format-diff.py.
Minor fixes which were requested by @Szelethus.

Aug 26 2019, 8:34 AM · Restricted Project, Restricted Project
steakhal added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

Thank you for your response @Szelethus.
Fixed, updating the patch.

Aug 26 2019, 8:31 AM · Restricted Project, Restricted Project
steakhal created D66733: [analyzer] Add a checker option to detect nested dead stores.
Aug 26 2019, 4:50 AM · Restricted Project, Restricted Project

Aug 2 2019

steakhal added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

Do you have some time @Szelethus to check this change?
Your experience and comments would help a lot to finish this.

Aug 2 2019, 1:16 AM · Restricted Project

Jul 3 2019

steakhal added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

What do you think, what should I improve in this checker?
Your remarks, @lebedev.ri, were really valuable.

Jul 3 2019, 1:14 AM · Restricted Project

Jun 4 2019

steakhal added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

The problem with the -Wcast-align is that it will only fire for C-style bitcast expressions, not for reinterpret_cast ones. example
Does anyone know why is that behavior?

Because reinterpret_cast is by definition allowed to perform these casts, so it is assumed that no warning should be issued.
This part of the check i look forward to.

Jun 4 2019, 5:57 AM · Restricted Project
steakhal updated the diff for D48866: [clang-tidy] Add incorrect-pointer-cast checker.
  • Removed different signess related parts.
  • Don't warn for the casts which are already covered by '-Wcast-align' check.
  • Improved the diagnostic messages:
    • Now adds notes for the first incompatible members of structs.
    • Added alignment, size and type information to most of the warning messages.
Jun 4 2019, 5:13 AM · Restricted Project
steakhal added inline comments to D48866: [clang-tidy] Add incorrect-pointer-cast checker.
Jun 4 2019, 4:55 AM · Restricted Project

Jun 3 2019

steakhal added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

The problem with the -Wcast-align is that it will only fire for C-style bitcast expressions, not for reinterpret_cast ones. example
Does anyone know why is that behavior?

Jun 3 2019, 8:09 AM · Restricted Project
steakhal updated the diff for D48866: [clang-tidy] Add incorrect-pointer-cast checker.

Unfortunately the changes that I've made are not available in a diff because I've moved to the monorepo version.
Although, you can see the changes in detail on my llvm-project github fork.

Jun 3 2019, 7:30 AM · Restricted Project
steakhal commandeered D48866: [clang-tidy] Add incorrect-pointer-cast checker.

If you don't mind I will finish the leftover work. This will still be committed under your name.

Jun 3 2019, 7:19 AM · Restricted Project

Mar 7 2019

Herald updated subscribers of D32198: [TySan] A Type Sanitizer (LLVM).
Mar 7 2019, 5:42 AM
Herald added a project to D48866: [clang-tidy] Add incorrect-pointer-cast checker: Restricted Project.

@hgabii Are you planning on finishing this? If not, I'd happily commandeer if not.

Mar 7 2019, 1:52 AM · Restricted Project