Page MenuHomePhabricator

steakhal (Balázs Benics)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 1:49 AM (24 w, 2 d)

Recent Activity

Fri, Aug 2

steakhal added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

Do you have some time @Szelethus to check this change?
Your experience and comments would help a lot to finish this.

Fri, Aug 2, 1:16 AM · Restricted Project

Jul 3 2019

steakhal added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

What do you think, what should I improve in this checker?
Your remarks, @lebedev.ri, were really valuable.

Jul 3 2019, 1:14 AM · Restricted Project

Jun 4 2019

steakhal added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

The problem with the -Wcast-align is that it will only fire for C-style bitcast expressions, not for reinterpret_cast ones. example
Does anyone know why is that behavior?

Because reinterpret_cast is by definition allowed to perform these casts, so it is assumed that no warning should be issued.
This part of the check i look forward to.

Jun 4 2019, 5:57 AM · Restricted Project
steakhal updated the diff for D48866: [clang-tidy] Add incorrect-pointer-cast checker.
  • Removed different signess related parts.
  • Don't warn for the casts which are already covered by '-Wcast-align' check.
  • Improved the diagnostic messages:
    • Now adds notes for the first incompatible members of structs.
    • Added alignment, size and type information to most of the warning messages.
Jun 4 2019, 5:13 AM · Restricted Project
steakhal added inline comments to D48866: [clang-tidy] Add incorrect-pointer-cast checker.
Jun 4 2019, 4:55 AM · Restricted Project

Jun 3 2019

steakhal added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

The problem with the -Wcast-align is that it will only fire for C-style bitcast expressions, not for reinterpret_cast ones. example
Does anyone know why is that behavior?

Jun 3 2019, 8:09 AM · Restricted Project
steakhal updated the diff for D48866: [clang-tidy] Add incorrect-pointer-cast checker.

Unfortunately the changes that I've made are not available in a diff because I've moved to the monorepo version.
Although, you can see the changes in detail on my llvm-project github fork.

Jun 3 2019, 7:30 AM · Restricted Project
steakhal commandeered D48866: [clang-tidy] Add incorrect-pointer-cast checker.

If you don't mind I will finish the leftover work. This will still be committed under your name.

Jun 3 2019, 7:19 AM · Restricted Project

Mar 7 2019

Herald updated subscribers of D32198: [TySan] A Type Sanitizer (LLVM).
Mar 7 2019, 5:42 AM
Herald added a project to D48866: [clang-tidy] Add incorrect-pointer-cast checker: Restricted Project.

@hgabii Are you planning on finishing this? If not, I'd happily commandeer if not.

Mar 7 2019, 1:52 AM · Restricted Project