Page MenuHomePhabricator

steakhal (Balázs Benics)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 7 2019, 1:49 AM (39 w, 4 d)

Recent Activity

Fri, Nov 22

steakhal created D70596: [analyzer][docs] NFC: Extend documentation for MallocOverflow checker.
Fri, Nov 22, 5:11 AM · Restricted Project

Oct 30 2019

steakhal added inline comments to D69318: [analyzer] Add SufficientSizeArrayIndexingChecker.
Oct 30 2019, 3:17 AM · Restricted Project

Oct 24 2019

steakhal added inline comments to D69181: [clang-tidy] Adding misc-signal-terminated-thread check.
Oct 24 2019, 12:53 PM · Restricted Project, Restricted Project

Oct 19 2019

steakhal added inline comments to D69181: [clang-tidy] Adding misc-signal-terminated-thread check.
Oct 19 2019, 4:08 AM · Restricted Project, Restricted Project

Oct 15 2019

steakhal added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

Thank you guys the responses. I cannot agree more. The sole reason why this option exists is that if you scroll back in the git blame of that line, you would find a commit, which removed this warning for this exact scenario.
Possibly due to some seemingly false positives.
I've added the author of that patch to the reviewers of this change, but did not respond.

Oct 15 2019, 11:45 AM · Restricted Project, Restricted Project
steakhal added a comment to D59516: [analyzer] Add custom filter functions for GenericTaintChecker.

I think this patch is ok.

Oct 15 2019, 1:58 AM · Restricted Project

Sep 7 2019

steakhal added inline comments to D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.
Sep 7 2019, 1:26 AM · Restricted Project

Sep 5 2019

steakhal added inline comments to D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker.
Sep 5 2019, 5:04 AM · Restricted Project

Aug 28 2019

steakhal updated the diff for D66733: [analyzer] Add a checker option to detect nested dead stores.

Changes:

  • Flag option marked as 'enabled by default'.
  • Reformat all the test cases for C, C++ and Obj C.
  • Now uses -verify=tags approach.
  • Fixes checker documentation.
Aug 28 2019, 9:04 AM · Restricted Project, Restricted Project
steakhal added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

Fixes for @NoQ's comments.
I will update the patch.

Aug 28 2019, 8:50 AM · Restricted Project, Restricted Project

Aug 27 2019

steakhal added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

@Szelethus The mispositioned report message was my fault. I used a different version of clang for the analysis and to upload the results, which resulted in some mispositioned reports.
I've fixed the linked CodeChecker instance.

Aug 27 2019, 3:36 PM · Restricted Project, Restricted Project

Aug 26 2019

steakhal added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

@Szelethus Your catch with the mispositioned report message is kinda strange. I will investigate that, but I think it's probably connected to something deeper, and most likely related to CodeChecker itself.

Aug 26 2019, 12:52 PM · Restricted Project, Restricted Project
steakhal added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

@NoQ What do you think, should it be under a flag (as it would be now), or enabled by default?
I think these warnings are valuable and we should consider it enabling by default.
An interesting fact is that previously rGf224820b45c6847b91071da8d7ade59f373b96f3 patch disabled this warning saying that it generates too many false-positives without any real benefit.

Aug 26 2019, 8:47 AM · Restricted Project, Restricted Project
steakhal updated the diff for D66733: [analyzer] Add a checker option to detect nested dead stores.

Fix copy-paste mistake.
This time upload the correct version.

Aug 26 2019, 8:39 AM · Restricted Project, Restricted Project
steakhal updated the diff for D66733: [analyzer] Add a checker option to detect nested dead stores.

Reformatted using clang-format-diff.py.
Minor fixes which were requested by @Szelethus.

Aug 26 2019, 8:34 AM · Restricted Project, Restricted Project
steakhal added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

Thank you for your response @Szelethus.
Fixed, updating the patch.

Aug 26 2019, 8:31 AM · Restricted Project, Restricted Project
steakhal created D66733: [analyzer] Add a checker option to detect nested dead stores.
Aug 26 2019, 4:50 AM · Restricted Project, Restricted Project

Aug 2 2019

steakhal added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

Do you have some time @Szelethus to check this change?
Your experience and comments would help a lot to finish this.

Aug 2 2019, 1:16 AM · Restricted Project

Jul 3 2019

steakhal added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

What do you think, what should I improve in this checker?
Your remarks, @lebedev.ri, were really valuable.

Jul 3 2019, 1:14 AM · Restricted Project

Jun 4 2019

steakhal added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

The problem with the -Wcast-align is that it will only fire for C-style bitcast expressions, not for reinterpret_cast ones. example
Does anyone know why is that behavior?

Because reinterpret_cast is by definition allowed to perform these casts, so it is assumed that no warning should be issued.
This part of the check i look forward to.

Jun 4 2019, 5:57 AM · Restricted Project
steakhal updated the diff for D48866: [clang-tidy] Add incorrect-pointer-cast checker.
  • Removed different signess related parts.
  • Don't warn for the casts which are already covered by '-Wcast-align' check.
  • Improved the diagnostic messages:
    • Now adds notes for the first incompatible members of structs.
    • Added alignment, size and type information to most of the warning messages.
Jun 4 2019, 5:13 AM · Restricted Project
steakhal added inline comments to D48866: [clang-tidy] Add incorrect-pointer-cast checker.
Jun 4 2019, 4:55 AM · Restricted Project

Jun 3 2019

steakhal added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

The problem with the -Wcast-align is that it will only fire for C-style bitcast expressions, not for reinterpret_cast ones. example
Does anyone know why is that behavior?

Jun 3 2019, 8:09 AM · Restricted Project
steakhal updated the diff for D48866: [clang-tidy] Add incorrect-pointer-cast checker.

Unfortunately the changes that I've made are not available in a diff because I've moved to the monorepo version.
Although, you can see the changes in detail on my llvm-project github fork.

Jun 3 2019, 7:30 AM · Restricted Project
steakhal commandeered D48866: [clang-tidy] Add incorrect-pointer-cast checker.

If you don't mind I will finish the leftover work. This will still be committed under your name.

Jun 3 2019, 7:19 AM · Restricted Project

Mar 7 2019

Herald updated subscribers of D32198: [TySan] A Type Sanitizer (LLVM).
Mar 7 2019, 5:42 AM
Herald added a project to D48866: [clang-tidy] Add incorrect-pointer-cast checker: Restricted Project.

@hgabii Are you planning on finishing this? If not, I'd happily commandeer if not.

Mar 7 2019, 1:52 AM · Restricted Project