User Details
- User Since
- Sep 17 2012, 3:16 AM (585 w, 5 d)
Sep 6 2023
Sorry for the late review. This looks good to me, but I hope we will be able to undo it soon :)
Sep 1 2023
LG!
LG!
Aug 31 2023
Aug 29 2023
Aug 28 2023
Thanks! Sometimes I am wondering whether we actually need a full map for PRValues. E.g., once we processed a MaterializeTemporaryExpr, we now have a location for the value, and it feels like we represent the same thing twice, once in ExprToLoc + LocToVal and once in ExprToVal. It is probably not too bad and might be extra work to clean this up.
Aug 25 2023
Aug 23 2023
Aug 22 2023
Aug 21 2023
Reverted in https://github.com/llvm/llvm-project/commit/8330116ebdcba58926f4f6fb402a4a6f010e8afc to unbreak build bot.
Aug 4 2023
Mea culpa. Looks like I did not anticipate non-RPO worklists. Thanks for cleaning this up, looks good to me!
Aug 3 2023
Aug 2 2023
Aug 1 2023
Jul 31 2023
It looks as if, instead, what we should be doing to improve convergence in a sound manner is to implement widening for ExprToLoc. I'll submit a corresponding patch shortly.
Jul 26 2023
Jul 25 2023
Jul 24 2023
Thanks, looks good to me!
Jul 21 2023
Sounds good to me. I believe this will make check author's lives easier.
LGTM!
I did not do a thorough review checking every line, but I read the design paper and skimmed through this patch. Love the direction, and I am OK with landing this as is.
Thanks!
Jul 20 2023
Jul 19 2023
Jul 18 2023
LG, thanks!
Jul 17 2023
Thanks! Looks good to me.
Jul 15 2023
Jul 12 2023
Jul 11 2023
Jul 10 2023
Jul 5 2023
Thanks!
Jul 4 2023
I love it, I think we can land this as is. If there are further comments, we can address those in follow-up PRs.
Overall looks good to me. I think the changes to the notes already make the analyzer more useful so there are some observable benefits to this patch.
Jun 30 2023
Jun 28 2023
Could you rebase this patch to the latest tip of tree?
Jun 27 2023
Thanks!
Jun 26 2023
Nice, looks like this change did catch some unintentional copies! Already paying dividends :)
Jun 23 2023
Is there a measurable perf cost for this determinism?
Should we have some documentation or tooltip explaining the users what the meaning of those names are?