Page MenuHomePhabricator

xazax.hun (Gábor Horváth)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 17 2012, 3:16 AM (548 w, 6 d)

Recent Activity

Yesterday

xazax.hun accepted D146864: [dataflow] Delete legacy aliases.
Sat, Mar 25, 2:57 PM · Restricted Project, Restricted Project

Wed, Mar 22

xazax.hun accepted D144730: [FlowSensitive] Log analysis progress for debugging purposes.
Wed, Mar 22, 10:12 AM · Restricted Project, Restricted Project
xazax.hun added a comment to D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state.

(e.g. does the MLIR dataflow framework have the same idea about how the analysis timeline relates to the CFG and elements within it? And if we want to show the clang AST or the StorageLocation/Value graph, what's the non-clang::dataflow-coupled way to model that?)

Wed, Mar 22, 10:08 AM · Restricted Project, Restricted Project
xazax.hun added inline comments to D144730: [FlowSensitive] Log analysis progress for debugging purposes.
Wed, Mar 22, 9:10 AM · Restricted Project, Restricted Project
xazax.hun added inline comments to D144730: [FlowSensitive] Log analysis progress for debugging purposes.
Wed, Mar 22, 8:51 AM · Restricted Project, Restricted Project
xazax.hun added a comment to D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state.

While I am OK with this approach, I wonder if it would be too much work to split the HTML generation and emitting data up. E.g., the logger could emit YAML or JSON that could be parsed by a python script to create the HTML (or the HTML itself could use JS to parse it and generate the DOM).
This would have a couple of advantages like:

  • People could add additional visualizations or other tools like querying program states more easily just consuming the JSON/YAML file
  • Other static analysis tools could produce similar YAML/JSON so your visualization could potentially work for other analysis tools. E.g., I think people were working on a dataflow analysis framework for MLIR.
Wed, Mar 22, 8:37 AM · Restricted Project, Restricted Project
xazax.hun accepted D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func..
Wed, Mar 22, 8:31 AM · Restricted Project, Restricted Project
xazax.hun added a comment to D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func..

No, I think this is a different case.

Wed, Mar 22, 8:29 AM · Restricted Project, Restricted Project
xazax.hun accepted D146625: [dataflow] handle missing case in value debug strings.
Wed, Mar 22, 8:04 AM · Restricted Project, Restricted Project
xazax.hun accepted D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface..

Thanks!

Wed, Mar 22, 8:03 AM · Restricted Project, Restricted Project

Tue, Mar 21

xazax.hun accepted D146538: [analyzer] Fix crashing getSValFromInitListExpr for nested initlists.

I wonder if we should also open tickets on GitHub to reduce the chance of forgetting addressing the root cause for these. What do you think?

Tue, Mar 21, 9:18 AM · Restricted Project, Restricted Project
xazax.hun accepted D146507: [clang][dataflow][NFC] Eliminate StmtToEnvMap interface..
Tue, Mar 21, 9:03 AM · Restricted Project, Restricted Project
xazax.hun added a comment to D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func..

This fix looks good for me for this particular problem, but I wonder whether the solution is general enough. In case the analysis figures out that a call would not return (e.g., the value method is called on a provably empty optional, and it would throw instead of returning), would this approach still work? Would the analysis update the BlockReachable bitvector on demand?

Tue, Mar 21, 9:01 AM · Restricted Project, Restricted Project
xazax.hun accepted D146527: [dataflow] Log flow condition to the correct stream..
Tue, Mar 21, 8:50 AM · Restricted Project, Restricted Project

Mon, Mar 13

xazax.hun added a comment to D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors.

Do you plan to selectively enable warnings coming from the STL to catch misuses of certain STL types?

Mon, Mar 13, 3:34 PM · Restricted Project, Restricted Project

Tue, Feb 28

xazax.hun accepted D144987: [clang][dataflow] Fix missed fields in field set construction..
Tue, Feb 28, 10:35 AM · Restricted Project, Restricted Project

Feb 22 2023

xazax.hun accepted D144546: [clang][dataflow] Fix assert for CXXConstructExpr argument number.
Feb 22 2023, 8:57 AM · Restricted Project, Restricted Project
xazax.hun added a comment to D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`.

I think at this point it is ok to merge. Any other comments can be addressed in follow-up commits.

Feb 22 2023, 8:55 AM · Restricted Project, Restricted Project

Feb 21 2023

xazax.hun accepted D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`.

Thanks!

Feb 21 2023, 3:13 PM · Restricted Project, Restricted Project

Feb 20 2023

xazax.hun added a comment to D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`.

Overall, I like the structure of this patch and the references back to the standard. But every time we compare type pointers, they might compare inequal when one of the types have sugar on it while the other does not. Please review all of those comparisons to see where do we need to get the canonical types instead, and add some tests with type aliases.

Feb 20 2023, 3:46 PM · Restricted Project, Restricted Project

Feb 15 2023

xazax.hun added a comment to D138037: [analyzer] Remove unjustified assertion from EQClass::simplify.

I am ok with committing this to unblock people hitting this assert, but at the same time I wonder if we want to open a ticket on GitHub that we might want to rethink how some of this works.

Feb 15 2023, 7:36 AM · Restricted Project, Restricted Project

Feb 13 2023

xazax.hun accepted D143920: [clang][dataflow] Change `transfer` API to take a reference..
Feb 13 2023, 8:31 AM · Restricted Project, Restricted Project

Feb 10 2023

xazax.hun accepted D143750: [clang-tidy] Clarify documention of `bugprone-unchecked-optional-access`..
Feb 10 2023, 10:10 AM · Restricted Project, Restricted Project
xazax.hun added inline comments to D143750: [clang-tidy] Clarify documention of `bugprone-unchecked-optional-access`..
Feb 10 2023, 9:24 AM · Restricted Project, Restricted Project
xazax.hun accepted D143735: [clang][dataflow] Convert nonnull pointer parameter to a reference..
Feb 10 2023, 7:38 AM · Restricted Project, Restricted Project

Feb 7 2023

xazax.hun added a comment to D143328: [analyzer] Remove the loop from the exploded graph caused by missing information in program points.

I think the right extra data to include is the CFGElementRef to the destructor element.

Feb 7 2023, 5:31 PM · Restricted Project, Restricted Project
xazax.hun accepted D143328: [analyzer] Remove the loop from the exploded graph caused by missing information in program points.

Thanks! This is exactly what I had in mind! Let's wait for @NoQ just in case he had something different in mind.

Feb 7 2023, 8:34 AM · Restricted Project, Restricted Project

Feb 6 2023

xazax.hun added a comment to D143328: [analyzer] Remove the loop from the exploded graph caused by missing information in program points.

I think this patch should also add a test that fails before your changes.

Feb 6 2023, 6:09 PM · Restricted Project, Restricted Project
xazax.hun accepted D143411: [NFC][clang] Fix static analyzer concern about uninitialized variable.
Feb 6 2023, 8:48 AM · Restricted Project, Restricted Project

Feb 1 2023

xazax.hun added a comment to D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`..

This change looks good to me. I wonder, however, whether the behavior should be parameterized in the future. E.g., whether the user of the analysis should be able to make a decision whether the analysis should be pessimistic or optimistic about unmodeled values.

Interesting idea. I think this goes along with other places where we are unsound. Here, we err on the side of soundness. but, in general, we should have a configuration mechanism for this. FWIW, the only reason we have uninitialized values at this point is recursive types. We also limit the depth of structs, but that should be removed given my recent patch to only model relevant fields. I have an idea for lazy initialization of values that I think could solve the recursion issue. Together, we could remove this concept of unmodeled values altogether from the framework.

Feb 1 2023, 9:05 AM · Restricted Project, Restricted Project

Jan 31 2023

xazax.hun accepted D140897: [clang][dataflow] Fix handling of `DeclRefExpr`s to `BindingDecl`s..

I hope we will be able to get rid of this SkipPast thing at some point by looking at the value categories of the AST instead.

Jan 31 2023, 3:16 PM · Restricted Project, Restricted Project
xazax.hun accepted D142710: [clang][dataflow] Relax validity assumptions in `UncheckedOptionalAccessModel`..

This change looks good to me. I wonder, however, whether the behavior should be parameterized in the future. E.g., whether the user of the analysis should be able to make a decision whether the analysis should be pessimistic or optimistic about unmodeled values.

Jan 31 2023, 3:07 PM · Restricted Project, Restricted Project

Jan 24 2023

xazax.hun added a comment to D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`.

Overall looks good to me, I wonder if the tests could be less manual though. E.g., instead of asserting true/false, checking if the assignment would compile. This way we can be sure that the method in ASTContext matches the behavior of the compiler (and we get notified when the two diverge). If we could extract the corresponding code from Sema, it would be even better, but I do not insist as that might be a lot of work depending on how it interacts with other conversions.

Jan 24 2023, 8:27 AM · Restricted Project, Restricted Project
xazax.hun added a reviewer for D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`: erichkeane.

Since now the patch touches Clang proper, adding one more reviewer.

Jan 24 2023, 8:25 AM · Restricted Project, Restricted Project

Jan 16 2023

xazax.hun added inline comments to D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`.
Jan 16 2023, 1:10 PM · Restricted Project, Restricted Project
xazax.hun added a comment to D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`.

Also, could you open a bug report about the strange exception behavior on GitHub? Hopefully someone working on conformance can take a look.

Jan 16 2023, 10:32 AM · Restricted Project, Restricted Project
xazax.hun accepted D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`.
Jan 16 2023, 10:29 AM · Restricted Project, Restricted Project

Jan 13 2023

xazax.hun accepted D141716: [clang][dataflow] Add (initial) debug printing for `Value` and `Environment`..
Jan 13 2023, 11:49 AM · Restricted Project, Restricted Project
xazax.hun accepted D141709: [clang][dataflow] Fix bug in joining bool values..
Jan 13 2023, 11:48 AM · Restricted Project, Restricted Project

Jan 10 2023

xazax.hun added inline comments to D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`.
Jan 10 2023, 9:15 AM · Restricted Project, Restricted Project
xazax.hun added inline comments to D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`.
Jan 10 2023, 9:13 AM · Restricted Project, Restricted Project
xazax.hun added inline comments to D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`.
Jan 10 2023, 9:03 AM · Restricted Project, Restricted Project

Jan 9 2023

xazax.hun accepted D141319: [clang][dataflow][NFC] Refine names and comments for field filtering..
Jan 9 2023, 1:48 PM · Restricted Project, Restricted Project
xazax.hun accepted D140703: [clang][dataflow] Unify `TransferOptions` and `DataflowAnalysisContext::Options`..
Jan 9 2023, 1:47 PM · Restricted Project, Restricted Project
xazax.hun accepted D141224: [ODRHash] Handle `Integral` and `NullPtr` template parameters in `ODRHash` .

I have one nit that you should look into, otherwise sounds reasonable and looks good to me.

Jan 9 2023, 1:41 PM · Restricted Project, Restricted Project
xazax.hun accepted D139534: [analyzer] Don't escape local static memregions on bind.

Here is the gist of one *new* TP:

Where would sprops get escaped? Did I miss that or was that reduced out of the example?

You are right, it 'never' escapes, yet in the past we modelled all stores to local statics as an 'immediate escape'.
This is what I think we should not do. And this is what this patch removes.

Jan 9 2023, 10:32 AM · Restricted Project, Restricted Project

Jan 8 2023

xazax.hun added a comment to D139534: [analyzer] Don't escape local static memregions on bind.

Here is the gist of one *new* TP:

Jan 8 2023, 3:11 PM · Restricted Project, Restricted Project

Jan 6 2023

xazax.hun accepted D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed..

I think in these cases you can recommit without waiting for a new round of reviews, but I hit accept just in case :)

Jan 6 2023, 2:05 PM · Restricted Project, Restricted Project

Jan 5 2023

xazax.hun added a comment to D139534: [analyzer] Don't escape local static memregions on bind.

Sorry, I got a bit swamped, will try to take a look next week. In the meantime, did you have a chance to run this over some open source projects? Did you find any interesting diffs?

Jan 5 2023, 9:16 AM · Restricted Project, Restricted Project
xazax.hun added a comment to D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed..

I realized I did not say this explicitly in my previous comment, but feel free to commit :)

Jan 5 2023, 9:14 AM · Restricted Project, Restricted Project

Jan 4 2023

xazax.hun accepted D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed..

This is a big improvement, I skimmed through it and looks good to me. There might be some sneaky ways to change values of fields without mentioning them, e.g., casting a pointer to a struct to an array of chars. But I think reasoning about those scenarios is probably not something we want to model anytime soon.

Jan 4 2023, 7:50 AM · Restricted Project, Restricted Project

Jan 3 2023

xazax.hun accepted D140921: [clang][dataflow] Fix bug in optional-checker's handling of nullopt constructor..
Jan 3 2023, 1:35 PM · Restricted Project, Restricted Project

Dec 21 2022

xazax.hun accepted D140506: [clang][dataflow] Simplify handling of nullopt-optionals..
Dec 21 2022, 3:32 PM · Restricted Project, Restricted Project
xazax.hun accepted D140501: [clang][dataflow] Account for global variables in constructor initializers..
Dec 21 2022, 2:35 PM · Restricted Project, Restricted Project

Dec 20 2022

xazax.hun accepted D140430: [clang][dataflow] Fix bug in handling of `return` statements..
Dec 20 2022, 2:14 PM · Restricted Project, Restricted Project

Dec 19 2022

xazax.hun accepted D140344: [clang][dataflow] In optional model, implement `widen` and make `compare` sound..
Dec 19 2022, 2:55 PM · Restricted Project, Restricted Project
xazax.hun accepted D140308: [clang][dataflow][NFC] Fix comments related to widening..
Dec 19 2022, 9:51 AM · Restricted Project, Restricted Project

Dec 16 2022

xazax.hun added a comment to D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns..

I don't mind committing these patches, I have a high confidence in you going back and addressing feedback post-commit if something is coming up.

Dec 16 2022, 8:57 AM · Restricted Project, Restricted Project

Dec 14 2022

xazax.hun accepted D140020: [clang][dataflow] Improve optional model's support for ignoring smart pointers..
Dec 14 2022, 3:01 PM · Restricted Project, Restricted Project
xazax.hun accepted D140021: [clang-tidy] Add configuration option to bugprone-unchecked-optional-access check..
Dec 14 2022, 8:45 AM · Restricted Project, Restricted Project

Dec 9 2022

xazax.hun accepted D139544: [clang][dataflow] Add support for structured bindings of tuple-like types..
Dec 9 2022, 10:17 AM · Restricted Project, Restricted Project
xazax.hun added a comment to D139544: [clang][dataflow] Add support for structured bindings of tuple-like types..

This approach looks good to me. Some context: we kept the CFGs lightweight because it looks like we did not need to do any extensions for the Clang Static Analyzer. I'm glad the dataflow framework can also work with the current representation. On the other hand, I think structured bindings in C++ are really limited, e.g., we cannot nest them, and it is nowhere near what pattern matching can do in other languages like Rust. I do remember seeing papers about extending structured bindings in at least some dimensions like nesting. I wonder if making the representation more explicit in the CFG as structured bindings get more complex will simplify implementations in the future, but that is a problem for tomorrow :)

Dec 9 2022, 9:57 AM · Restricted Project, Restricted Project

Dec 7 2022

xazax.hun added a reviewer for D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.: isuckatcs.
Dec 7 2022, 9:52 AM · Restricted Project, Restricted Project

Dec 5 2022

xazax.hun added inline comments to D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations.
Dec 5 2022, 3:19 PM · Restricted Project, Restricted Project
xazax.hun accepted D139360: [clang][dataflow] Support (in)equality operators in `optional` model..

LGTM!

Dec 5 2022, 1:07 PM · Restricted Project, Restricted Project

Nov 24 2022

xazax.hun accepted D138659: [analyzer] Deprecate FAM analyzer-config, recommend -fstrict-flex-arrays instead.
Nov 24 2022, 10:16 AM · Restricted Project, Restricted Project
xazax.hun accepted D138657: [analyzer] Consider single-elem arrays as FAMs by default.
Nov 24 2022, 10:15 AM · Restricted Project, Restricted Project

Nov 21 2022

xazax.hun added a comment to D108230: [analyzer] Ignore single element arrays in getStaticSize() conditionally.

I am a bit conflicted. It is unfortunate that C and C++ compilers regarded single element array members as flexible array members. On the other hand, looking at GCC, it recently added -fstrict-flex-arrays=2 as an option to no longer consider single element member arrays as FAM. So, it looks like the community wants to migrate away from this. My main concern is whether this option would make the experience worse for people who keep their code tidy and favor people who did not update their FAMs. Overall, I wonder if diagnosing single element arrays that are likely FAMs and suggesting users to fix their code is a better way forward.

Nov 21 2022, 3:57 PM · Restricted Project, Restricted Project
xazax.hun added inline comments to D138426: Fix #58958 on github.
Nov 21 2022, 1:30 PM · Restricted Project, Restricted Project
xazax.hun added inline comments to D138426: Fix #58958 on github.
Nov 21 2022, 1:29 PM · Restricted Project, Restricted Project
xazax.hun added a comment to D138037: [analyzer] Remove unjustified assertion from EQClass::simplify.

I guess there are some more options. We could try keeping representatives alive no matter what. It could be a good exercise to see if doing that makes any difference in the analysis results.

Nov 21 2022, 11:00 AM · Restricted Project, Restricted Project
xazax.hun added a comment to D138037: [analyzer] Remove unjustified assertion from EQClass::simplify.

I did not spend too much time thinking about this yet, but this sounds scary. I wonder if we should target the underlying problem instead, i.e., making sure we never have dead symbols as representatives for eq. classes. What do you think?

Nov 21 2022, 9:58 AM · Restricted Project, Restricted Project
xazax.hun accepted D136603: [analyzer] getBinding should auto-detect type only if it was not given.

Sounds reasonable to me.

Nov 21 2022, 9:49 AM · Restricted Project, Restricted Project

Nov 18 2022

xazax.hun added a comment to D138329: [-Wunsafe-buffer-usage] Add a new recursive matcher to replace `forEachDescendant` in unsafe buffer check.

Is the problem forEachDescendant matching statements inside blocks and lambdas? I wonder if this behavior would surprise people, so I think it would be better to:

  • Potentially add a template bool parameter to forEachDescendant controlling this behavior.
  • Review existing uses because I am not entirely sure if the current behavior is the right default.
Nov 18 2022, 3:08 PM · Restricted Project, Restricted Project
xazax.hun added inline comments to D138321: [-Wunsafe-buffer-usage] Ignore array subscript on literal zero.
Nov 18 2022, 3:05 PM · Restricted Project, Restricted Project
xazax.hun added inline comments to D138318: [-Wunsafe-buffer-usage] Improve pointer match pattern.
Nov 18 2022, 3:04 PM · Restricted Project, Restricted Project
xazax.hun added inline comments to D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming..
Nov 18 2022, 3:02 PM · Restricted Project, Restricted Project
xazax.hun added inline comments to D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations.
Nov 18 2022, 2:43 PM · Restricted Project, Restricted Project
xazax.hun added inline comments to D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns..
Nov 18 2022, 2:39 PM · Restricted Project, Restricted Project
xazax.hun accepted D136811: [-Wunsafe-buffer-usage] WIP: RFC: NFC: User documentation..

Overall, the document looks good to me, I like the general direction. I still see some pending comments (mostly small wording fixes) from Aaron.

Nov 18 2022, 2:23 PM · Restricted Project

Nov 16 2022

xazax.hun accepted D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses..
Nov 16 2022, 10:30 AM · Restricted Project, Restricted Project

Nov 15 2022

xazax.hun accepted D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model..

LGTM, thanks!

Nov 15 2022, 11:58 AM · Restricted Project, Restricted Project
xazax.hun added inline comments to D137346: [-Wunsafe-buffer-usage] Initial commit - Transition away from raw buffer accesses..
Nov 15 2022, 11:45 AM · Restricted Project, Restricted Project
xazax.hun added inline comments to D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model..
Nov 15 2022, 9:15 AM · Restricted Project, Restricted Project

Nov 14 2022

xazax.hun added inline comments to D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model..
Nov 14 2022, 2:06 PM · Restricted Project, Restricted Project

Nov 11 2022

xazax.hun accepted D135851: [clang] Support for read-only types.

Thanks, the latest version looks good to me.

Nov 11 2022, 8:34 AM · Restricted Project, Restricted Project

Nov 7 2022

xazax.hun added inline comments to D136811: [-Wunsafe-buffer-usage] WIP: RFC: NFC: User documentation..
Nov 7 2022, 9:10 AM · Restricted Project
xazax.hun added a comment to D135851: [clang] Support for read-only types.

Mostly looks good to me, but there still is a comment that is unaddressed.

Nov 7 2022, 8:22 AM · Restricted Project, Restricted Project

Nov 4 2022

xazax.hun added inline comments to D137432: [clang][dataflow] Change transfer and diagnoser functions to receive a CFGElement.
Nov 4 2022, 8:43 AM · Restricted Project, Restricted Project

Nov 3 2022

xazax.hun added inline comments to D136811: [-Wunsafe-buffer-usage] WIP: RFC: NFC: User documentation..
Nov 3 2022, 2:05 PM · Restricted Project
xazax.hun accepted D137334: [clang][dataflow] Generalize custom comparison to return tri-value result..
Nov 3 2022, 11:40 AM · Restricted Project, Restricted Project

Nov 2 2022

xazax.hun added inline comments to D136811: [-Wunsafe-buffer-usage] WIP: RFC: NFC: User documentation..
Nov 2 2022, 6:34 PM · Restricted Project
xazax.hun added a comment to D135851: [clang] Support for read-only types.

Start to look good, I still have a couple of questions/comments inline.

Nov 2 2022, 6:04 PM · Restricted Project, Restricted Project

Oct 27 2022

xazax.hun added inline comments to D135851: [clang] Support for read-only types.
Oct 27 2022, 11:36 AM · Restricted Project, Restricted Project

Oct 25 2022

xazax.hun accepted D133698: [clang][dataflow] Implement transferBranch.

With the rest of the comments addressed it looks good to me.

Oct 25 2022, 9:02 AM · Restricted Project, Restricted Project

Oct 14 2022

xazax.hun added a comment to D135965: [analyzer] Move unexecuted test block into it's own source file.

We could also consider reporting a warning or an error in this case to let the caller know that the function doesn't work in this context. Right now it's up to the caller to figure it out on their own, and if they don't see the report they might think there's something wrong with some other part of their code.

Oct 14 2022, 12:40 PM · Restricted Project, Restricted Project
xazax.hun accepted D135978: [clang][dataflow][NFC] Fix reachability warning..

I'd argue the warning is correct as you could store "non-enum" integer values into an enum typed variable (and people do that fairly often with bitwise enums).

Oct 14 2022, 11:38 AM · Restricted Project, Restricted Project
xazax.hun accepted D135964: [clang][dataflow] Add equivalence relation for `Value` type..
Oct 14 2022, 11:31 AM · Restricted Project, Restricted Project
xazax.hun accepted D135965: [analyzer] Move unexecuted test block into it's own source file.

Oh, I see, this look deliberate. I wonder if we want to add an exception for lambdas though but that would be a different discussions unrelated to this PR.

Oct 14 2022, 11:14 AM · Restricted Project, Restricted Project
xazax.hun added a comment to D135965: [analyzer] Move unexecuted test block into it's own source file.

Moved clang_analyzer_eval() out of the lambda body, because no diagnostic was reported from the inside.

Oct 14 2022, 9:50 AM · Restricted Project, Restricted Project