Page MenuHomePhabricator

cchen (Chi Chun Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2019, 11:47 AM (13 w, 13 h)

Recent Activity

Mon, Nov 18

cchen updated the diff for D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema).

Add and fix test.

Mon, Nov 18, 2:28 PM · Restricted Project, Restricted Project

Fri, Nov 15

cchen added a comment to D69204: [OpenMP 5.0] - Extend defaultmap.

Alexey, thanks so much for your help, you really make me learn so much about Clang and coding in general. Can you land this patch for me since I'm still new to llvm/clang and haven't have the commit access. Thanks!

Fri, Nov 15, 9:56 AM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Fix a wrong type

Fri, Nov 15, 9:56 AM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Fix test

Fri, Nov 15, 9:29 AM · Restricted Project, Restricted Project

Thu, Nov 14

cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Fix a silly bug in test

Thu, Nov 14, 1:57 PM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Thu, Nov 14, 1:57 PM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Add test about declare target link/to

Thu, Nov 14, 1:29 PM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Remove redundant code

Thu, Nov 14, 11:57 AM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Thu, Nov 14, 10:34 AM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Fix based on feedback

Thu, Nov 14, 9:11 AM · Restricted Project, Restricted Project

Wed, Nov 13

cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Add a test for OpenMP4.5 defaultmap and add the message back for Clang

Wed, Nov 13, 2:11 PM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Wed, Nov 13, 1:34 PM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Wed, Nov 13, 1:28 PM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Remove duplicate code in test

Wed, Nov 13, 1:10 PM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

fix a misunderstood change

Wed, Nov 13, 9:14 AM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Fix based on feedback

Wed, Nov 13, 8:56 AM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Remove unnecessary enums and do some renaming

Wed, Nov 13, 8:09 AM · Restricted Project, Restricted Project

Tue, Nov 12

cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Tue, Nov 12, 10:18 AM · Restricted Project, Restricted Project

Mon, Nov 11

cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Refactor by taking advantage of helper

Mon, Nov 11, 1:52 PM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Mon, Nov 11, 1:34 PM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Fix based on feedback

Mon, Nov 11, 12:58 PM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Mon, Nov 11, 9:17 AM · Restricted Project, Restricted Project

Fri, Nov 8

cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

clang-format all of my changes and fix based on feedback

Fri, Nov 8, 3:19 PM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Fri, Nov 8, 12:52 PM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Use implicit behavior as key for implicit map

Fri, Nov 8, 11:48 AM · Restricted Project, Restricted Project

Thu, Nov 7

cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Thu, Nov 7, 3:14 PM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Set initial defaultmap modifier to be unknown if not valid and fix based on feedback

Thu, Nov 7, 2:54 PM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Thu, Nov 7, 9:42 AM · Restricted Project, Restricted Project

Wed, Nov 6

cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Remove incorrect DMIB to OMPC_MAP function and do some refactoring.

Wed, Nov 6, 2:10 PM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Wed, Nov 6, 1:15 PM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Wed, Nov 6, 9:40 AM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Wed, Nov 6, 8:45 AM · Restricted Project, Restricted Project

Tue, Nov 5

cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Use sema to generate correct maptype instead of codegen.

Tue, Nov 5, 9:29 PM · Restricted Project, Restricted Project

Mon, Nov 4

cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Mon, Nov 4, 9:38 PM · Restricted Project, Restricted Project

Sat, Nov 2

cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Sat, Nov 2, 2:36 PM · Restricted Project, Restricted Project

Fri, Nov 1

cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Fix firstprivate issue and refactor based on feedback

Fri, Nov 1, 2:45 PM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Fri, Nov 1, 10:57 AM · Restricted Project, Restricted Project

Thu, Oct 31

cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Thu, Oct 31, 2:43 PM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Fix based on feedback

Thu, Oct 31, 2:34 PM · Restricted Project, Restricted Project

Wed, Oct 30

cchen updated the diff for D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema).

Rebase and fix add OpenMP 50 guard

Wed, Oct 30, 1:53 PM · Restricted Project, Restricted Project
cchen updated the summary of D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema).
Wed, Oct 30, 1:34 PM · Restricted Project, Restricted Project
cchen updated the diff for D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema).

Remove the restriction rule for array section to another patch

Wed, Oct 30, 1:34 PM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Wed, Oct 30, 12:56 PM · Restricted Project, Restricted Project

Fri, Oct 25

cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Fri, Oct 25, 1:43 PM · Restricted Project, Restricted Project
cchen updated the diff for D69204: [OpenMP 5.0] - Extend defaultmap.

Update based on the comments:

Fri, Oct 25, 10:53 AM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Fri, Oct 25, 9:29 AM · Restricted Project, Restricted Project
cchen added inline comments to D69204: [OpenMP 5.0] - Extend defaultmap.
Fri, Oct 25, 9:20 AM · Restricted Project, Restricted Project

Tue, Oct 22

cchen updated subscribers of D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema).
Tue, Oct 22, 12:04 PM · Restricted Project, Restricted Project
cchen updated subscribers of D69204: [OpenMP 5.0] - Extend defaultmap.
Tue, Oct 22, 12:04 PM · Restricted Project, Restricted Project
cchen updated the diff for D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema).

Fix summary message

Tue, Oct 22, 12:02 PM · Restricted Project, Restricted Project
cchen updated the summary of D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema).
Tue, Oct 22, 12:02 PM · Restricted Project, Restricted Project
cchen created D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema).
Tue, Oct 22, 11:55 AM · Restricted Project, Restricted Project

Oct 18 2019

cchen added a reviewer for D69204: [OpenMP 5.0] - Extend defaultmap: ABataev.
Oct 18 2019, 3:27 PM · Restricted Project, Restricted Project
cchen created D69204: [OpenMP 5.0] - Extend defaultmap.
Oct 18 2019, 3:27 PM · Restricted Project, Restricted Project

Sep 10 2019

cchen added a comment to D66559: [OPENMP] Update the diagnosis message for canonical loop form.

Oh, I was thinking that I could use "arc land" to commit my patch, but just now realize that I don't have the commit privileges. Would you please commit for me? Thanks.

Sep 10 2019, 2:37 PM · Restricted Project, Restricted Project

Sep 9 2019

cchen added a comment to D66559: [OPENMP] Update the diagnosis message for canonical loop form.

@ABataev, could you mark it as ready to land, please. Thanks.

Sep 9 2019, 3:00 PM · Restricted Project, Restricted Project

Aug 30 2019

cchen updated the diff for D66559: [OPENMP] Update the diagnosis message for canonical loop form.

Fix the code that rely on implicit conversion.

Aug 30 2019, 12:01 PM · Restricted Project, Restricted Project
cchen added a comment to D66559: [OPENMP] Update the diagnosis message for canonical loop form.

I'm not able to arc land my patch since I updated the patch for a minor refactor and the state is "not approve" now. Do I wait for the approval for the new patch so that I can arc land or I don't need to do arc land myself?
Thanks.

Aug 30 2019, 10:23 AM · Restricted Project, Restricted Project
cchen updated the diff for D66559: [OPENMP] Update the diagnosis message for canonical loop form.

Refactor for only load the OpenMP version number once

Aug 30 2019, 9:30 AM · Restricted Project, Restricted Project
cchen updated the diff for D66559: [OPENMP] Update the diagnosis message for canonical loop form.

Refactor the control flow based on the feedback, fix a failing codegen test due
to OpenMP version.

Aug 30 2019, 9:19 AM · Restricted Project, Restricted Project

Aug 29 2019

cchen added a comment to D66559: [OPENMP] Update the diagnosis message for canonical loop form.

"parallel_for_codegen" cannot pass now since it has two test cases for "!=" and it's hard to just add "fopenmp-version=50" since it will break lots of other test cases that have different codegen for OpenMP 5.0.
I can remove the "!=" case from "parallel_for_codegen" and add a new file such as "omp50_parallel_for_codegen" to test it but I doubt it's the right way to do it.

Aug 29 2019, 2:49 PM · Restricted Project, Restricted Project
cchen updated the diff for D66559: [OPENMP] Update the diagnosis message for canonical loop form.

Update lit test for diagnose loop canonical form message for OpenMP 5.0 and
pre-5.0. Only allow fopenmp-version=50 to use "!=" as check condition in loop
canonical form.

Aug 29 2019, 2:47 PM · Restricted Project, Restricted Project

Aug 28 2019

cchen added a comment to D66559: [OPENMP] Update the diagnosis message for canonical loop form.

@ABataev thanks so much for your instruction, I'll look into that.

Aug 28 2019, 1:32 PM · Restricted Project, Restricted Project
cchen added a comment to D66559: [OPENMP] Update the diagnosis message for canonical loop form.

Haven't updated the lit test for OpenMP 5.0 yet since I'm not able to check OPENMP version by using _OPENMP with preprocessor condition checking.

Aug 28 2019, 1:27 PM · Restricted Project, Restricted Project
cchen updated the diff for D66559: [OPENMP] Update the diagnosis message for canonical loop form.

Update the diagnosis message for canonical loop form based on OpenMP version

Aug 28 2019, 1:20 PM · Restricted Project, Restricted Project

Aug 22 2019

cchen added a comment to D66559: [OPENMP] Update the diagnosis message for canonical loop form.

Is there any way that I can find the OpenMP version in Clang? I couldn't find any example in source code. Thanks.

Aug 22 2019, 2:14 PM · Restricted Project, Restricted Project
Herald added a reviewer for D54441: [OPENMP] Support relational-op !- (not-equal) as one of the canonical forms of random access iterator: jdoerfert.
Aug 22 2019, 2:14 PM · Restricted Project, Restricted Project, Restricted Project

Aug 21 2019

cchen added a project to D66559: [OPENMP] Update the diagnosis message for canonical loop form: Restricted Project.
Aug 21 2019, 3:34 PM · Restricted Project, Restricted Project
cchen created D66559: [OPENMP] Update the diagnosis message for canonical loop form.
Aug 21 2019, 2:51 PM · Restricted Project, Restricted Project