LGTM

Can we push this patch back to 14.x release branch?

LG

The SystemZ issue is due to the fact that we assumed that device(cpu) should be evaluated to true and device(gpu) should be evaluated to false in the test so the test should be fixed by specifying the triple. (https://github.com/llvm/llvm-project/commit/3679d2001c87f37101e7f20c646b21e97d8a0867)

In D91944#3009003, @uweigand wrote:

Looks like this was committed again, breaking the SystemZ build bots once again:
https://lab.llvm.org/buildbot/#/builders/94/builds/5661

I reapplied the patch since I forgot to add author's name in the commit

Fix tests and coding style

Fix tests for Windows

Fix flang issue

Rebase and fix warning

Fix ast errors and add some tiny fixes

Add tests and fix coding style

Fix based on suggestions

Remove braces

Fix based on feedback (wait for comment about moving ConstructTrait to IRBuilder)

Rebase and fix based on suggestions

One thing I wanted to do though is keep track of the constructs in the OpenMPIRBuilder instead. So move the

/// Vector of declare variant construct traits.
SmallVector<llvm::omp::TraitProperty, 8> ConstructTraits;

into OpenMPIRBuilder and add/delete the things there. It's not a conceptual difference but makes it easier
to opt-in for Flang later.

Remove debug info and spaces

Remove redundant file

Rebase and avoid assert errors

@alokmishra.besu do you mind if I push the patch for solving those assertions with rebase? The patch does not change the logic in your program and I've made sure that the tests could pass in debug mode.

I'm guessing the tests were not pass on buildbot but passed on the author's side is due to the assertion was disabled on the author's side.
Here is the patch for avoiding all the assertion errors and I'm able to get all the metadirective tests passed (and no regression for the existing omp tests) with this change:

Rebase

what assertion?

I mark this patch as "plan changed" since the assert message indicates that something wrong in IRBuilder or Codegen, however, main branch also have the same issue so I think this patch does not trigger the issue.

Use irbuilder for masked and master construct: https://reviews.llvm.org/D100874.

Initially we did not have an OMPIRBuilder object unconditionally, now we have. Let's move over everything that is ready. So master and critical should be good to go as well I suppose.

In D100514#2693601, @jdoerfert wrote:

Also, don't forget to mark it as done in https://clang.llvm.org/docs/OpenMPSupport.html :)

In D100514#2693600, @jdoerfert wrote:

Any reason we should not unconditionally use the OMPIRBuilder impl? (btw, many thanks for providing one!)
We have an OMPIRBuilder always around in clang's codegen, so there is little reason not to use it if it is feature complete.

Update test and fix code format