Page MenuHomePhabricator

cchen (Chi Chun Chen)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 21 2019, 11:47 AM (149 w, 5 d)

Recent Activity

Tue, Jun 28

cchen abandoned D126494: [clang] avoid assert due to device treated long double as double.
Tue, Jun 28, 12:28 AM · Restricted Project, Restricted Project

Mon, Jun 27

cchen committed rG92fd2eb74f5b: [Clang][OpenMP] Claim nowait clause on taskwait (authored by cchen).
[Clang][OpenMP] Claim nowait clause on taskwait
Mon, Jun 27, 9:03 AM · Restricted Project, Restricted Project
cchen committed rG8322fe200d60: Adding support for target in_reduction (authored by RitanyaB).
Adding support for target in_reduction
Mon, Jun 27, 8:37 AM · Restricted Project, Restricted Project, Restricted Project
cchen closed D125669: Adding support for target in_reduction.
Mon, Jun 27, 8:37 AM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2022

cchen committed rG814a0abccefd: AMDGPU: allow reordering of functions in AMDGPUResourceUsageAnalysis (authored by jweightman).
AMDGPU: allow reordering of functions in AMDGPUResourceUsageAnalysis
Jun 3 2022, 1:56 PM · Restricted Project, Restricted Project
cchen closed D126025: AMDGPU: allow reordering of functions in AMDGPUResourceUsageAnalysis.
Jun 3 2022, 1:56 PM · Restricted Project, Unknown Object (Project), Restricted Project

May 30 2022

cchen added a reviewer for D125669: Adding support for target in_reduction: ABataev.
May 30 2022, 3:45 PM · Restricted Project, Restricted Project, Restricted Project

May 26 2022

cchen added a reviewer for D126494: [clang] avoid assert due to device treated long double as double: efriedma.
May 26 2022, 12:27 PM · Restricted Project, Restricted Project
cchen added inline comments to D126494: [clang] avoid assert due to device treated long double as double.
May 26 2022, 12:26 PM · Restricted Project, Restricted Project
cchen updated the summary of D126494: [clang] avoid assert due to device treated long double as double.
May 26 2022, 12:11 PM · Restricted Project, Restricted Project
cchen requested review of D126494: [clang] avoid assert due to device treated long double as double.
May 26 2022, 12:04 PM · Restricted Project, Restricted Project

Mar 2 2022

Herald added a project to D119676: [OpenMP] libomp: implemented task priorities.: Restricted Project.
Mar 2 2022, 7:33 AM · Restricted Project, Unknown Object (Project)
Herald added a project to D120573: [OpenMP] Support runtime user conditions in metadirective: Restricted Project.
Mar 2 2022, 7:31 AM · Restricted Project, Restricted Project, Restricted Project

Feb 10 2022

cchen added a comment to D119306: InferAddressSpaces: Fix assert on inferred source for inttoptr/ptrtoint.

Can we push this patch back to 14.x release branch?

Feb 10 2022, 1:04 PM · Restricted Project

Dec 16 2021

cchen accepted D115901: [OpenMP][NFC] update status for 5.1 'fail' atomic extension.

LG

Dec 16 2021, 1:32 PM · Restricted Project

Oct 1 2021

cchen added inline comments to D100673: [OPENMP]Fix PR49698: OpenMP declare mapper causes segmentation fault..
Oct 1 2021, 3:28 PM · Unknown Object (Project), Restricted Project

Sep 21 2021

cchen committed rG8c68bd480f3d: [OpenMP][NFC] Add declare variant and metadirective to support page (authored by cchen).
[OpenMP][NFC] Add declare variant and metadirective to support page
Sep 21 2021, 9:29 AM

Sep 20 2021

cchen added a comment to D91944: OpenMP 5.0 metadirective.

The SystemZ issue is due to the fact that we assumed that device(cpu) should be evaluated to true and device(gpu) should be evaluated to false in the test so the test should be fixed by specifying the triple. (https://github.com/llvm/llvm-project/commit/3679d2001c87f37101e7f20c646b21e97d8a0867)

Sep 20 2021, 10:29 AM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen committed rG3679d2001c87: [NCF][OpenMP] Fix metadirective test on SystemZ (authored by cchen).
[NCF][OpenMP] Fix metadirective test on SystemZ
Sep 20 2021, 10:23 AM
cchen added a comment to D91944: OpenMP 5.0 metadirective.

Looks like this was committed again, breaking the SystemZ build bots once again:
https://lab.llvm.org/buildbot/#/builders/94/builds/5661

Sep 20 2021, 9:55 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Sep 18 2021

cchen committed rG000875c127c7: OpenMP 5.0 metadirective (authored by alokmishra.besu).
OpenMP 5.0 metadirective
Sep 18 2021, 11:41 AM

Sep 17 2021

cchen added a reverting change for rG2908fc0d3f16: [OpenMP] Use irbuilder as default for masked and master construct: rG9ff848c5cd88: Revert "[OpenMP] Use irbuilder as default for masked and master construct".
Sep 17 2021, 2:44 PM
cchen committed rG9ff848c5cd88: Revert "[OpenMP] Use irbuilder as default for masked and master construct" (authored by cchen).
Revert "[OpenMP] Use irbuilder as default for masked and master construct"
Sep 17 2021, 2:44 PM
cchen added a reverting change for D100874: [OpenMP] Use irbuilder as default for masked and master construct: rG9ff848c5cd88: Revert "[OpenMP] Use irbuilder as default for masked and master construct".
Sep 17 2021, 2:44 PM · Restricted Project
cchen added a comment to D91944: OpenMP 5.0 metadirective.

I reapplied the patch since I forgot to add author's name in the commit

Sep 17 2021, 2:32 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen committed rG347f3c186d3f: OpenMP 5.0 metadirective (authored by alokmishra.besu).
OpenMP 5.0 metadirective
Sep 17 2021, 2:30 PM
cchen added a reverting change for rGc7d7b98e5263: OpenMP 5.0 metadirective: rG7efb825382c0: Revert "OpenMP 5.0 metadirective".
Sep 17 2021, 2:15 PM
cchen committed rG7efb825382c0: Revert "OpenMP 5.0 metadirective" (authored by cchen).
Revert "OpenMP 5.0 metadirective"
Sep 17 2021, 2:15 PM
cchen added a reverting change for D91944: OpenMP 5.0 metadirective: rG7efb825382c0: Revert "OpenMP 5.0 metadirective".
Sep 17 2021, 2:14 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen committed rGc7d7b98e5263: OpenMP 5.0 metadirective (authored by cchen).
OpenMP 5.0 metadirective
Sep 17 2021, 2:03 PM
cchen closed D91944: OpenMP 5.0 metadirective.
Sep 17 2021, 2:03 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen committed rG2908fc0d3f16: [OpenMP] Use irbuilder as default for masked and master construct (authored by cchen).
[OpenMP] Use irbuilder as default for masked and master construct
Sep 17 2021, 2:02 PM
cchen closed D100874: [OpenMP] Use irbuilder as default for masked and master construct.
Sep 17 2021, 2:01 PM · Restricted Project
cchen updated the diff for D91944: OpenMP 5.0 metadirective.

Fix tests and coding style

Sep 17 2021, 12:41 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen added inline comments to D91944: OpenMP 5.0 metadirective.
Sep 17 2021, 12:21 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen added inline comments to D91944: OpenMP 5.0 metadirective.
Sep 17 2021, 12:11 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen updated the diff for D91944: OpenMP 5.0 metadirective.

Fix tests for Windows

Sep 17 2021, 10:32 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Sep 16 2021

cchen updated the diff for D91944: OpenMP 5.0 metadirective.

Fix flang issue

Sep 16 2021, 9:16 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen updated the diff for D91944: OpenMP 5.0 metadirective.

Rebase and fix warning

Sep 16 2021, 7:55 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen updated the diff for D91944: OpenMP 5.0 metadirective.

Fix ast errors and add some tiny fixes

Sep 16 2021, 4:58 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen committed rG976d474bec35: [OpenMP] Support construct trait set for Clang (authored by cchen).
[OpenMP] Support construct trait set for Clang
Sep 16 2021, 9:35 AM
cchen closed D109635: [OpenMP] Support construct trait set for Clang.
Sep 16 2021, 9:34 AM · Restricted Project

Sep 15 2021

cchen retitled D109635: [OpenMP] Support construct trait set for Clang from [WIP][OpenMP] Support construct trait set for Clang to [OpenMP] Support construct trait set for Clang.
Sep 15 2021, 5:07 PM · Restricted Project
cchen updated the diff for D109635: [OpenMP] Support construct trait set for Clang.

Add tests and fix coding style

Sep 15 2021, 5:06 PM · Restricted Project

Sep 14 2021

cchen added inline comments to D109635: [OpenMP] Support construct trait set for Clang.
Sep 14 2021, 4:15 PM · Restricted Project
cchen updated the diff for D109635: [OpenMP] Support construct trait set for Clang.

Fix based on suggestions

Sep 14 2021, 4:13 PM · Restricted Project
cchen updated the diff for D109635: [OpenMP] Support construct trait set for Clang.

Remove braces

Sep 14 2021, 12:15 PM · Restricted Project
cchen updated the diff for D109635: [OpenMP] Support construct trait set for Clang.

Fix based on feedback (wait for comment about moving ConstructTrait to IRBuilder)

Sep 14 2021, 12:13 PM · Restricted Project

Sep 13 2021

cchen updated subscribers of D109635: [OpenMP] Support construct trait set for Clang.
Sep 13 2021, 2:38 PM · Restricted Project
cchen updated the diff for D109635: [OpenMP] Support construct trait set for Clang.

Rebase and fix based on suggestions

Sep 13 2021, 2:37 PM · Restricted Project
cchen added inline comments to D109635: [OpenMP] Support construct trait set for Clang.
Sep 13 2021, 1:55 PM · Restricted Project
cchen added a comment to D109635: [OpenMP] Support construct trait set for Clang.

One thing I wanted to do though is keep track of the constructs in the OpenMPIRBuilder instead. So move the

/// Vector of declare variant construct traits.
SmallVector<llvm::omp::TraitProperty, 8> ConstructTraits;

into OpenMPIRBuilder and add/delete the things there. It's not a conceptual difference but makes it easier
to opt-in for Flang later.

Sep 13 2021, 12:54 PM · Restricted Project

Sep 10 2021

cchen updated the diff for D91944: OpenMP 5.0 metadirective.

Remove debug info and spaces

Sep 10 2021, 4:52 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen updated the diff for D91944: OpenMP 5.0 metadirective.

Remove redundant file

Sep 10 2021, 4:38 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen updated the diff for D91944: OpenMP 5.0 metadirective.

Rebase and avoid assert errors

Sep 10 2021, 4:36 PM · Restricted Project, Restricted Project, Unknown Object (Project)
cchen added inline comments to D109635: [OpenMP] Support construct trait set for Clang.
Sep 10 2021, 3:42 PM · Restricted Project
cchen added inline comments to D109635: [OpenMP] Support construct trait set for Clang.
Sep 10 2021, 3:41 PM · Restricted Project
cchen requested review of D109635: [OpenMP] Support construct trait set for Clang.
Sep 10 2021, 3:31 PM · Restricted Project

Sep 8 2021

cchen added a comment to D91944: OpenMP 5.0 metadirective.

@alokmishra.besu do you mind if I push the patch for solving those assertions with rebase? The patch does not change the logic in your program and I've made sure that the tests could pass in debug mode.

Sep 8 2021, 1:07 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Sep 2 2021

cchen added a comment to D91944: OpenMP 5.0 metadirective.

I'm guessing the tests were not pass on buildbot but passed on the author's side is due to the assertion was disabled on the author's side.
Here is the patch for avoiding all the assertion errors and I'm able to get all the metadirective tests passed (and no regression for the existing omp tests) with this change:

Sep 2 2021, 11:04 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Apr 26 2021

cchen updated the diff for D100874: [OpenMP] Use irbuilder as default for masked and master construct.

Rebase

Apr 26 2021, 2:10 PM · Restricted Project

Apr 21 2021

cchen added a comment to D100874: [OpenMP] Use irbuilder as default for masked and master construct.

what assertion?

Apr 21 2021, 9:42 AM · Restricted Project

Apr 20 2021

cchen updated the summary of D100874: [OpenMP] Use irbuilder as default for masked and master construct.
Apr 20 2021, 1:38 PM · Restricted Project
cchen added a comment to D100874: [OpenMP] Use irbuilder as default for masked and master construct.

I mark this patch as "plan changed" since the assert message indicates that something wrong in IRBuilder or Codegen, however, main branch also have the same issue so I think this patch does not trigger the issue.

Apr 20 2021, 1:37 PM · Restricted Project
cchen planned changes to D100874: [OpenMP] Use irbuilder as default for masked and master construct.
Apr 20 2021, 1:22 PM · Restricted Project
cchen added a comment to D100514: [OpenMP] Added codegen for masked directive.

Use irbuilder for masked and master construct: https://reviews.llvm.org/D100874.

Apr 20 2021, 11:00 AM · Restricted Project, Restricted Project
cchen requested review of D100874: [OpenMP] Use irbuilder as default for masked and master construct.
Apr 20 2021, 10:58 AM · Restricted Project

Apr 16 2021

cchen added a comment to D100514: [OpenMP] Added codegen for masked directive.

Initially we did not have an OMPIRBuilder object unconditionally, now we have. Let's move over everything that is ready. So master and critical should be good to go as well I suppose.

Apr 16 2021, 3:25 PM · Restricted Project, Restricted Project
cchen added a comment to D100514: [OpenMP] Added codegen for masked directive.

Also, don't forget to mark it as done in https://clang.llvm.org/docs/OpenMPSupport.html :)

Apr 16 2021, 10:23 AM · Restricted Project, Restricted Project
cchen added a comment to D100514: [OpenMP] Added codegen for masked directive.

Any reason we should not unconditionally use the OMPIRBuilder impl? (btw, many thanks for providing one!)
We have an OMPIRBuilder always around in clang's codegen, so there is little reason not to use it if it is feature complete.

Apr 16 2021, 10:23 AM · Restricted Project, Restricted Project

Apr 15 2021

cchen committed rG924cdff0ae18: [OpenMP5][DOCS] Update status of masked construct and correct the color (authored by cchen).
[OpenMP5][DOCS] Update status of masked construct and correct the color
Apr 15 2021, 3:19 PM
cchen committed rGe0c2125d1d1e: [OpenMP] Added codegen for masked directive (authored by cchen).
[OpenMP] Added codegen for masked directive
Apr 15 2021, 10:55 AM
cchen closed D100514: [OpenMP] Added codegen for masked directive.
Apr 15 2021, 10:55 AM · Restricted Project, Restricted Project
cchen updated the diff for D100514: [OpenMP] Added codegen for masked directive.

Update test and fix code format

Apr 15 2021, 9:40 AM · Restricted Project, Restricted Project

Apr 14 2021

cchen requested review of D100514: [OpenMP] Added codegen for masked directive.
Apr 14 2021, 3:27 PM · Restricted Project, Restricted Project

Apr 9 2021

cchen committed rG3d816537df2c: [OpenMP51][DOCS] Claimed masked construct and report current patch, NFC. (authored by cchen).
[OpenMP51][DOCS] Claimed masked construct and report current patch, NFC.
Apr 9 2021, 1:23 PM
cchen committed rG1a43fd27691c: [OpenMP51] Initial support for masked directive and filter clause (authored by cchen).
[OpenMP51] Initial support for masked directive and filter clause
Apr 9 2021, 12:01 PM
cchen closed D99995: [OpenMP51] Initial support for masked directive and filter clause.
Apr 9 2021, 12:01 PM · Restricted Project, Restricted Project
cchen updated the diff for D99995: [OpenMP51] Initial support for masked directive and filter clause.

Fix lit-test failure for dispatch_ast_print and rebase

Apr 9 2021, 11:58 AM · Restricted Project, Restricted Project

Apr 8 2021

cchen updated the diff for D99995: [OpenMP51] Initial support for masked directive and filter clause.

Fix/Add test for "can not have more than one filter clause" issue and rebase.

Apr 8 2021, 10:26 AM · Restricted Project, Restricted Project
cchen added inline comments to D99995: [OpenMP51] Initial support for masked directive and filter clause.
Apr 8 2021, 9:04 AM · Restricted Project, Restricted Project

Apr 7 2021

cchen updated the diff for D99995: [OpenMP51] Initial support for masked directive and filter clause.

Rebase and fix based on comments.

Apr 7 2021, 4:50 PM · Restricted Project, Restricted Project
cchen retitled D99995: [OpenMP51] Initial support for masked directive and filter clause from [OpenMP51] Initial support for marked directive and filter clause to [OpenMP51] Initial support for masked directive and filter clause.
Apr 7 2021, 9:02 AM · Restricted Project, Restricted Project

Apr 6 2021

cchen updated the diff for D99995: [OpenMP51] Initial support for masked directive and filter clause.

Fix comments

Apr 6 2021, 3:26 PM · Restricted Project, Restricted Project
cchen requested review of D99995: [OpenMP51] Initial support for masked directive and filter clause.
Apr 6 2021, 3:19 PM · Restricted Project, Restricted Project

Apr 1 2021

cchen committed rGcba422264c7f: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang (authored by cchen).
[OpenMP51] Accept `primary` as proc bind affinity policy in Clang
Apr 1 2021, 4:14 PM
cchen closed D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang.
Apr 1 2021, 4:13 PM · Restricted Project, Restricted Project
cchen updated the diff for D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang.

Rebase

Apr 1 2021, 4:06 PM · Restricted Project, Restricted Project
cchen committed rG56b39afb5862: [OpenMP51][DOCS] Mark "add present modifier in defaultmap clause" as (authored by cchen).
[OpenMP51][DOCS] Mark "add present modifier in defaultmap clause" as
Apr 1 2021, 9:04 AM
cchen updated the diff for D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang.

Update codegen test

Apr 1 2021, 8:55 AM · Restricted Project, Restricted Project

Mar 31 2021

cchen added inline comments to D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang.
Mar 31 2021, 10:56 AM · Restricted Project, Restricted Project
cchen updated the diff for D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang.

Add some codegen tests

Mar 31 2021, 10:36 AM · Restricted Project, Restricted Project

Mar 30 2021

cchen requested review of D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang.
Mar 30 2021, 3:03 PM · Restricted Project, Restricted Project

Mar 10 2021

cchen accepted D98358: [OpenMP] Restore backwards compatibility for libomptarget.

LGTM.

Mar 10 2021, 11:17 AM · Restricted Project, Unknown Object (Project), Restricted Project
cchen added a comment to D98358: [OpenMP] Restore backwards compatibility for libomptarget.

I think some existing Clang OpenMP codegen tests will break if they are testing against __kmpc_push_target_tripcount.

Mar 10 2021, 9:16 AM · Restricted Project, Unknown Object (Project), Restricted Project

Jan 4 2021

cchen added a comment to D91944: OpenMP 5.0 metadirective.

@alokmishra.besu, I'm trying to play/learn with your patch so I downloaded the diff and apply it to the master branch, however, I'm getting error messages everywhere if llvm::omp::OMPD_metadirective appears:

Jan 4 2021, 3:29 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Dec 15 2020

cchen committed rG82f2c61ca084: [OPENMP51] Add present modifier in defaultmap clause (authored by cchen).
[OPENMP51] Add present modifier in defaultmap clause
Dec 15 2020, 11:51 AM
cchen closed D92427: [OPENMP51] Add present modifier in defaultmap clause.
Dec 15 2020, 11:50 AM · Restricted Project
cchen updated the diff for D92427: [OPENMP51] Add present modifier in defaultmap clause.

Rebase

Dec 15 2020, 11:06 AM · Restricted Project

Dec 11 2020

cchen updated the diff for D92427: [OPENMP51] Add present modifier in defaultmap clause.

Fix outdated comment in test

Dec 11 2020, 1:13 PM · Restricted Project