Page MenuHomePhabricator

thakis (Nico Weber)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (340 w, 3 h)

Recent Activity

Today

thakis added a comment to rL366497: Fix typo in r366494. Spotted by Yuanfang Chen..

No test?

Thu, Jul 18, 3:16 PM
thakis created D64927: lld-link: Demangle symbols from archives in diagnostics.
Thu, Jul 18, 8:33 AM · Restricted Project

Yesterday

thakis committed rG7bb5fc058314: llvm-pdbdump: Fix several smaller issues with injected source compression… (authored by thakis).
llvm-pdbdump: Fix several smaller issues with injected source compression…
Wed, Jul 17, 4:00 PM
thakis added a comment to D64879: llvm-pdbdump: Fix several smaller issues with injected source compression handling.

Thanks!

Wed, Jul 17, 3:24 PM · Restricted Project
thakis created D64879: llvm-pdbdump: Fix several smaller issues with injected source compression handling.
Wed, Jul 17, 12:40 PM · Restricted Project
thakis added a comment to D63648: [Preprocessor] Honor absolute paths in diagnostics.

So maybe Driver::IsCLMode() should take precedence over -fdiagnostics-absolute-paths when using /showIncludes?

Wed, Jul 17, 12:35 PM · Restricted Project
thakis added a comment to D63648: [Preprocessor] Honor absolute paths in diagnostics.

Those aren't diagnostics, so that's not surprising.

What would suggest in that case? Add a new -fpreprocessor-absolute-paths option? Or change the name of -fdiagnostics-absolute-paths for another name that applies to both diagnostics and the preprocessor output?

Wed, Jul 17, 10:33 AM · Restricted Project

Tue, Jul 16

thakis committed rG67cf3d61ee3c: gn build: Merge r366265 (authored by thakis).
gn build: Merge r366265
Tue, Jul 16, 6:22 PM
thakis committed rG420f3f6444ac: gn build: Merge r366216 (authored by thakis).
gn build: Merge r366216
Tue, Jul 16, 6:22 PM
thakis committed rGd100b5dd0197: Teach `llvm-pdbutil pretty -native` about `-injected-sources` (authored by thakis).
Teach `llvm-pdbutil pretty -native` about `-injected-sources`
Tue, Jul 16, 11:06 AM
thakis added inline comments to D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.
Tue, Jul 16, 10:55 AM · Restricted Project
thakis added inline comments to D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.
Tue, Jul 16, 10:04 AM · Restricted Project
thakis updated the diff for D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.

half-address zturner comment

Tue, Jul 16, 9:31 AM · Restricted Project
thakis added inline comments to D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.
Tue, Jul 16, 9:31 AM · Restricted Project

Mon, Jul 15

thakis added inline comments to D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.
Mon, Jul 15, 4:52 PM · Restricted Project
thakis updated the diff for D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.

give NativeInjectedSource a SrcHeaderBlockEntry instead of a const_iterator

Mon, Jul 15, 4:52 PM · Restricted Project
thakis updated the diff for D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.

remove a dead function

Mon, Jul 15, 12:06 PM · Restricted Project
thakis committed rGac6375d99d19: Expand comment about how StringsToBuckets was computed, and add more entries (authored by thakis).
Expand comment about how StringsToBuckets was computed, and add more entries
Mon, Jul 15, 12:00 PM
thakis committed rGa2dcbd364399: Use a unique_ptr instead of manual memory management for LineTable (authored by thakis).
Use a unique_ptr instead of manual memory management for LineTable
Mon, Jul 15, 10:31 AM
thakis committed rG05489f095223: Use a unique_ptr instead of manual memory management for CustomDiagInfo (authored by thakis).
Use a unique_ptr instead of manual memory management for CustomDiagInfo
Mon, Jul 15, 10:22 AM
thakis committed rG0e5f91575766: Use unique_ptr instead of manual delete in one place. No behavior change. (authored by thakis).
Use unique_ptr instead of manual delete in one place. No behavior change.
Mon, Jul 15, 10:13 AM
thakis committed rG62cc16dac205: gn build: Add a note on how to locally tell git to ignore build dir (authored by thakis).
gn build: Add a note on how to locally tell git to ignore build dir
Mon, Jul 15, 8:16 AM
thakis added inline comments to D58710: Added more detailed documentation for clangd.
Mon, Jul 15, 8:00 AM · Restricted Project, Restricted Project
thakis created D64738: Expand comment about how StringsToBuckets was computed, and add more entries.
Mon, Jul 15, 6:26 AM · Restricted Project
thakis added a comment to D64641: PDB HashTable: Make iterator type const.

Thanks!

Mon, Jul 15, 5:19 AM · Restricted Project
thakis committed rG7d5100115af5: PDB HashTable: Make iterator key type const (authored by thakis).
PDB HashTable: Make iterator key type const
Mon, Jul 15, 5:11 AM

Sun, Jul 14

thakis retitled D64641: PDB HashTable: Make iterator type const from PDB HashTable: Make iterator key type const to PDB HashTable: Make iterator type const.
Sun, Jul 14, 6:03 PM · Restricted Project

Sat, Jul 13

thakis closed D64623: [gn] Tag unneeded variable..
Sat, Jul 13, 6:21 PM · Restricted Project

Fri, Jul 12

thakis added a comment to D64655: [Clang][Driver] don't error for unsupported as options for -no-integrated-as.

Sorry, I missed this thread (and the other one) yesterday. Thanks for sorting out my mess; I'll think about what I want to do for the reland.

Fri, Jul 12, 4:43 PM · Restricted Project
thakis committed rG51a52b58930c: PDB HashTable: Move TraitsT from class parameter to the methods that need it (authored by thakis).
PDB HashTable: Move TraitsT from class parameter to the methods that need it
Fri, Jul 12, 4:32 PM
thakis added a comment to D64640: PDB HashTable: Move TraitsT from class parameter to the methods that need it.
In D64640#1583265, @rnk wrote:

The traits object is only used by a few methods. Deserializing a hash
table and walking it is possible without the traits object, so it
shouldn't be required to build a dummy object for that use case.

The traits are needed to do any actual hashing.

Fri, Jul 12, 12:00 PM · Restricted Project
thakis added a comment to D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.

Probably time to call ETIMEOUT on zturner. rnk, can you look at this one too given you already have seen all the prerequisite CLs? I'm pretty happy with this by now.

Fri, Jul 12, 11:36 AM · Restricted Project
thakis updated the diff for D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.

rebase, done

Fri, Jul 12, 11:32 AM · Restricted Project
thakis committed rG13f7ddff17ba: Slightly simplify MappedBlockStream::createIndexedStream() calls (authored by thakis).
Slightly simplify MappedBlockStream::createIndexedStream() calls
Fri, Jul 12, 11:26 AM
thakis committed rGff26aed0d1c9: Add explicit newline at end of `llvm-pdbutil dump` (authored by thakis).
Add explicit newline at end of `llvm-pdbutil dump`
Fri, Jul 12, 11:24 AM
thakis accepted D64623: [gn] Tag unneeded variable..

lgtm, thanks. Do you need someone to land this?

Fri, Jul 12, 10:31 AM · Restricted Project
thakis updated the diff for D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.

better

Fri, Jul 12, 9:25 AM · Restricted Project
thakis updated the summary of D64641: PDB HashTable: Make iterator type const.
Fri, Jul 12, 9:23 AM · Restricted Project
thakis added a parent revision for D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`: D64633: Slightly simplify MappedBlockStream::createIndexedStream() calls.
Fri, Jul 12, 8:45 AM · Restricted Project
thakis added a child revision for D64633: Slightly simplify MappedBlockStream::createIndexedStream() calls: D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.
Fri, Jul 12, 8:45 AM · Restricted Project
thakis added a child revision for D64641: PDB HashTable: Make iterator type const: D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.
Fri, Jul 12, 8:45 AM · Restricted Project
thakis updated the diff for D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.

wip

Fri, Jul 12, 8:45 AM · Restricted Project
thakis added a parent revision for D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`: D64641: PDB HashTable: Make iterator type const.
Fri, Jul 12, 8:45 AM · Restricted Project
thakis updated the summary of D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.
Fri, Jul 12, 8:45 AM · Restricted Project
thakis added a parent revision for D64641: PDB HashTable: Make iterator type const: D64640: PDB HashTable: Move TraitsT from class parameter to the methods that need it.
Fri, Jul 12, 8:36 AM · Restricted Project
thakis added a child revision for D64640: PDB HashTable: Move TraitsT from class parameter to the methods that need it: D64641: PDB HashTable: Make iterator type const.
Fri, Jul 12, 8:36 AM · Restricted Project
thakis created D64641: PDB HashTable: Make iterator type const.
Fri, Jul 12, 8:35 AM · Restricted Project
thakis created D64640: PDB HashTable: Move TraitsT from class parameter to the methods that need it.
Fri, Jul 12, 8:21 AM · Restricted Project
thakis created D64633: Slightly simplify MappedBlockStream::createIndexedStream() calls.
Fri, Jul 12, 7:06 AM · Restricted Project
thakis updated the diff for D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.

-injected-source-content works

Fri, Jul 12, 6:29 AM · Restricted Project
thakis accepted D64623: [gn] Tag unneeded variable..

Thanks!

Fri, Jul 12, 4:58 AM · Restricted Project

Thu, Jul 11

thakis added a comment to D63837: [LLD] [COFF] Fix .rsrc sections with differing permissions.

This fixes the issues mentioned at the bottom of https://reviews.llvm.org/D63109#1558181 , right?

Thu, Jul 11, 8:08 PM · Restricted Project
thakis committed rGe5d5b5c2ac8e: gn build: Merge r365792 (authored by thakis).
gn build: Merge r365792
Thu, Jul 11, 10:10 AM
thakis committed rG96dff9199857: Fix a few 'no newline at end of file' warnings that Xcode emits (authored by thakis).
Fix a few 'no newline at end of file' warnings that Xcode emits
Thu, Jul 11, 8:27 AM
thakis committed rG0e4386e9e773: gn build: Merge r365773 (authored by thakis).
gn build: Merge r365773
Thu, Jul 11, 8:03 AM
thakis closed D64504: Various minor tweaks to CLCompatOptions.td.

r365721

Thu, Jul 11, 6:37 AM

Wed, Jul 10

thakis committed rGe837847ec64a: Change another test I missed in r365724 (authored by thakis).
Change another test I missed in r365724
Wed, Jul 10, 6:22 PM
thakis committed rGda233838c9b0: clang-cl: Remove -O0 option (authored by thakis).
clang-cl: Remove -O0 option
Wed, Jul 10, 6:20 PM
thakis committed rG6765aa552a83: Various minor tweaks to CLCompatOptions.td (authored by thakis).
Various minor tweaks to CLCompatOptions.td
Wed, Jul 10, 6:14 PM
thakis committed rG3daf58faa2cf: Attempt to fix bots after r365703 (authored by thakis).
Attempt to fix bots after r365703
Wed, Jul 10, 4:51 PM
thakis updated the diff for D64504: Various minor tweaks to CLCompatOptions.td.

comments

Wed, Jul 10, 4:25 PM
thakis added inline comments to D64504: Various minor tweaks to CLCompatOptions.td.
Wed, Jul 10, 4:25 PM
thakis updated the summary of D64506: clang-cl: Remove -O0 option.
Wed, Jul 10, 4:20 PM · Restricted Project
thakis updated the summary of D64506: clang-cl: Remove -O0 option.
Wed, Jul 10, 4:18 PM · Restricted Project
thakis updated the diff for D64506: clang-cl: Remove -O0 option.

update tests

Wed, Jul 10, 4:18 PM · Restricted Project
thakis added a comment to D64506: clang-cl: Remove -O0 option.
In D64506#1579251, @rnk wrote:

Does clang-cl -O0 without a / still work, though? It's used:

$ git grep O0 ../compiler-rt/test/asan/TestCases/Windows/
../compiler-rt/test/asan/TestCases/Windows/aligned_mallocs.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
../compiler-rt/test/asan/TestCases/Windows/allocators_sanity.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
../compiler-rt/test/asan/TestCases/Windows/beginthreadex.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
../compiler-rt/test/asan/TestCases/Windows/bitfield.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
../compiler-rt/test/asan/TestCases/Windows/bitfield_uaf.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
../compiler-rt/test/asan/TestCases/Windows/calloc_left_oob.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
../compiler-rt/test/asan/TestCases/Windows/calloc_right_oob.cc:// RUN: %clang_cl_asan -O0 %s -Fe%t
...

Wed, Jul 10, 4:18 PM · Restricted Project
thakis committed rG101c1afdfd1c: driver: Don't warn about assembler flags being unused when not assembling (authored by thakis).
driver: Don't warn about assembler flags being unused when not assembling
Wed, Jul 10, 3:34 PM
thakis added a comment to D64526: [NFC] Unforget a colon in a few CHECK: directives..

(previously: D58061)

Wed, Jul 10, 1:04 PM · Restricted Project, Restricted Project
thakis committed rGc23bc97e85f6: Add support for building with Python 3 (authored by thakis).
Add support for building with Python 3
Wed, Jul 10, 12:32 PM
thakis accepted D64443: Add support for building with Python 3.

lgtm

Wed, Jul 10, 12:29 PM · Restricted Project
thakis committed rG5f5237c2764b: gn build: Merge r365687 (authored by thakis).
gn build: Merge r365687
Wed, Jul 10, 12:22 PM
thakis committed rGd24faac0111d: Add Python 3.6 and 3.7 to the version list (authored by thakis).
Add Python 3.6 and 3.7 to the version list
Wed, Jul 10, 12:19 PM
thakis created D64527: driver: Don't warn about assembler flags being unused when not assembling.
Wed, Jul 10, 12:06 PM · Restricted Project
thakis added a comment to D64506: clang-cl: Remove -O0 option.

I did check that we now warn, like you had requested:

Wed, Jul 10, 9:12 AM · Restricted Project
thakis created D64506: clang-cl: Remove -O0 option.
Wed, Jul 10, 9:12 AM · Restricted Project
thakis created D64504: Various minor tweaks to CLCompatOptions.td.
Wed, Jul 10, 9:04 AM
thakis committed rG30d12be76c26: Remove two unused member variables. (authored by thakis).
Remove two unused member variables.
Wed, Jul 10, 7:50 AM
thakis committed rG8ceee915f350: gn build: Merge r365585 (authored by thakis).
gn build: Merge r365585
Wed, Jul 10, 7:09 AM

Tue, Jul 9

thakis added a comment to D64191: [libcxxabi] Don't process exceptions in cxa_handlers when they're disabled.

FYIe, you can also prevent this symbol to be linked in by putting a cxa_demangle function in an obj file that gets linked first, like so: https://cs.chromium.org/chromium/src/third_party/android_crazy_linker/src/src/crazy_linker_wrappers.cpp?type=cs&q=cxa_demangle+file:android&sq=package:chromium&g=0&l=54 – but I agree that since cxa_demangle is so large, it'd be nice if the upstream version was behind some kind of define. Then we could set that and remove that hack in chromium too. I don't have an opinion on if that should be a new define or if _LIBCXXABI_NO_EXCEPTIONS should be reused. Actually, I think we build libcxxabi with exceptions enabled because some of our test code can in theory throw exceptions, but we have an external dumper so we don't need the stack from terminate() – so it'd be somewhat more convenient for us if we could turn off the stack from terminate() (and the pulling in of __cxa_demangle) while still being able to build without setting _LIBCXXABI_NO_EXCEPTIONS.

Tue, Jul 9, 8:11 PM · Restricted Project
thakis added inline comments to D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.
Tue, Jul 9, 10:40 AM · Restricted Project
thakis created D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`.
Tue, Jul 9, 10:36 AM · Restricted Project
thakis committed rG0efac296f140: Remove a comment that has been obsolete since r327679 (authored by thakis).
Remove a comment that has been obsolete since r327679
Tue, Jul 9, 10:21 AM
thakis committed rGc9c55cf89b0d: Rename llvm/test/tools/llvm-pdbdump to llvm/test/tools/llvm-pdbutil (authored by thakis).
Rename llvm/test/tools/llvm-pdbdump to llvm/test/tools/llvm-pdbutil
Tue, Jul 9, 10:17 AM
thakis added inline comments to D61524: [BPF] Support for compile once and run everywhere.
Tue, Jul 9, 10:16 AM · Restricted Project
thakis committed rGce84e6ae8ead: Make pdbdump-objfilename test work again (authored by thakis).
Make pdbdump-objfilename test work again
Tue, Jul 9, 10:04 AM
Herald added a project to D29044: Add LC_BUILD_VERSION load command: Restricted Project.

You need to add a llvm/test/tools/llvm-objdump/lit.local.cfg that contains config.suffixes = ['.yaml'], else the .yaml files added in this change won't be run by lit.

Tue, Jul 9, 9:53 AM · Restricted Project
thakis committed rG624103568496: gn build: Merge r365453 (authored by thakis).
gn build: Merge r365453
Tue, Jul 9, 6:59 AM
thakis added inline comments to D63773: [clangd] dummy variable extraction on a function scope.
Tue, Jul 9, 6:57 AM · Restricted Project, Restricted Project
thakis committed rGe7a67bf8ceb0: lld-link: Stop accepting /natvis and /fastfail in .drectve sections (authored by thakis).
lld-link: Stop accepting /natvis and /fastfail in .drectve sections
Tue, Jul 9, 6:32 AM

Mon, Jul 8

thakis committed rG9d2538d2dcba: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source (authored by thakis).
Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source
Mon, Jul 8, 5:37 PM
thakis committed rGe3f06b478cfd: Let unaliased Args track which Alias they were created from, and use that in… (authored by thakis).
Let unaliased Args track which Alias they were created from, and use that in…
Mon, Jul 8, 5:37 PM
thakis committed rG9801621616b2: clang-cl: Port cl.exe's C4659 to clang-cl (authored by thakis).
clang-cl: Port cl.exe's C4659 to clang-cl
Mon, Jul 8, 5:04 PM
thakis added a comment to D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics.
5381 361257 out/clang/browser_tests.exe.rsp
Mon, Jul 8, 4:49 PM · Restricted Project
thakis added a comment to D64349: clang-cl: Port cl.exe's C4659 to clang-cl.
In D64349#1574742, @rnk wrote:

lgtm

Mon, Jul 8, 4:46 PM · Restricted Project
thakis added a comment to D64349: clang-cl: Port cl.exe's C4659 to clang-cl.

Thanks!

Mon, Jul 8, 4:31 PM · Restricted Project
thakis updated the diff for D64349: clang-cl: Port cl.exe's C4659 to clang-cl.

comments

Mon, Jul 8, 4:31 PM · Restricted Project
thakis created D64352: lld-link: Stop accepting /natvis and /fastfail in .drectve sections.
Mon, Jul 8, 9:14 AM · Restricted Project
thakis created D64349: clang-cl: Port cl.exe's C4659 to clang-cl.
Mon, Jul 8, 8:45 AM · Restricted Project
thakis added a comment to D63687: gn build: Use thin archives on Windows too when using lld.

I finished measuring the impact of this. It saves some disk, but not all that much, and it slows down links some (but not that much). If the numbers are similar on linux, maybe we shouldn't do thin archives in the llvm gn build? (Maybe the faster filesystem on linux makes hunting down all the .o files on linux less expensive, though.)

Mon, Jul 8, 7:33 AM · Restricted Project
thakis updated the summary of D63687: gn build: Use thin archives on Windows too when using lld.
Mon, Jul 8, 7:30 AM · Restricted Project