Page MenuHomePhabricator

thakis (Nico Weber)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (494 w, 6 d)

Recent Activity

Today

thakis added a comment to rG8d9dc83f35a3: X86: add newline to end of FMA instruction comments..

*did fix things on _linux_

Thu, Jul 7, 5:22 AM · Restricted Project, Restricted Project
thakis added a comment to rG8d9dc83f35a3: X86: add newline to end of FMA instruction comments..

Even after the one test fix, check-lld is still broken on Mac and win:
http://45.33.8.238/macm1/39637/step_10.txt
http://45.33.8.238/win/61745/step_10.txt

Thu, Jul 7, 5:19 AM · Restricted Project, Restricted Project

Yesterday

thakis added a comment to D129223: [Clang] Fix invalid utf-8 detection.
Wed, Jul 6, 2:02 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a reverting change for rG4174f0ca618b: [Clang] Add a warning on invalid UTF-8 in comments.: rGe9fe20dab39e: Revert "[Clang] Add a warning on invalid UTF-8 in comments.".
Wed, Jul 6, 1:53 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a reverting change for rGbf45e27a676d: [Clang] Fix invalid utf-8 detection: rGe9fe20dab39e: Revert "[Clang] Add a warning on invalid UTF-8 in comments.".
Wed, Jul 6, 1:53 PM · Restricted Project, Restricted Project, Restricted Project
thakis committed rGe9fe20dab39e: Revert "[Clang] Add a warning on invalid UTF-8 in comments." (authored by thakis).
Revert "[Clang] Add a warning on invalid UTF-8 in comments."
Wed, Jul 6, 1:53 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a reverting change for D128059: [Clang] Add a warning on invalid UTF-8 in comments.: rGe9fe20dab39e: Revert "[Clang] Add a warning on invalid UTF-8 in comments.".
Wed, Jul 6, 1:53 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a reverting change for D129223: [Clang] Fix invalid utf-8 detection: rGe9fe20dab39e: Revert "[Clang] Add a warning on invalid UTF-8 in comments.".
Wed, Jul 6, 1:53 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D129223: [Clang] Fix invalid utf-8 detection.

Reverted in e9fe20dab39edb911afacdb6ed9ec2c7499a59cf for now.

Wed, Jul 6, 1:52 PM · Restricted Project, Restricted Project, Restricted Project
thakis requested review of D129226: [clang/mac] Make -mmacos-version-min the canonical spelling over -mmacosx-version-min.
Wed, Jul 6, 1:46 PM · Restricted Project
thakis added a comment to D114845: [llvm] [Debuginfod] DebuginfodCollection and DebuginfodServer for tracking local debuginfo..
Wed, Jul 6, 1:24 PM · Restricted Project, Restricted Project
thakis added a comment to D129223: [Clang] Fix invalid utf-8 detection.

This breaks check-clang: http://45.33.8.238/linux/80462/step_7.txt

Wed, Jul 6, 1:23 PM · Restricted Project, Restricted Project, Restricted Project
thakis committed rG39ed08f8d452: try to fix build after babef908cc1 (authored by thakis).
try to fix build after babef908cc1
Wed, Jul 6, 1:15 PM · Restricted Project, Restricted Project
thakis added a comment to D114845: [llvm] [Debuginfod] DebuginfodCollection and DebuginfodServer for tracking local debuginfo..

This doesn't build: http://45.33.8.238/linux/80459/step_4.txt

Wed, Jul 6, 1:04 PM · Restricted Project, Restricted Project
thakis committed rG6148c79a64ff: [gn build] (manually) port 9ee97ce3b8305c5 (authored by thakis).
[gn build] (manually) port 9ee97ce3b8305c5
Wed, Jul 6, 12:34 PM · Restricted Project, Restricted Project
thakis committed rG8f83f8f999fb: [gn build] (manually) port 484b1aa611ca (authored by thakis).
[gn build] (manually) port 484b1aa611ca
Wed, Jul 6, 12:23 PM · Restricted Project, Restricted Project
thakis committed rG67d82b50cff5: [gn build] (manually) port e0b520865026 (authored by thakis).
[gn build] (manually) port e0b520865026
Wed, Jul 6, 12:20 PM · Restricted Project, Restricted Project
thakis added a comment to D128059: [Clang] Add a warning on invalid UTF-8 in comments..

As far as I can tell, this breaks check-clang everywhere: http://45.33.8.238/

Wed, Jul 6, 10:18 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jul 5

thakis added a comment to D126464: [lldb] Add support to load object files from thin archives.

Thanks for the fix! :)

Tue, Jul 5, 2:06 AM · Restricted Project, Restricted Project
thakis committed rGb6ad8cbb3575: [gn build] (manually) port dfb77f2e99a1 (authored by thakis).
[gn build] (manually) port dfb77f2e99a1
Tue, Jul 5, 2:00 AM · Restricted Project, Restricted Project
thakis committed rGdc46ae6df5f7: [lldb] Add support to load object files from thin archives (authored by PRESIDENT810).
[lldb] Add support to load object files from thin archives
Tue, Jul 5, 1:53 AM · Restricted Project
thakis closed D126464: [lldb] Add support to load object files from thin archives.
Tue, Jul 5, 1:53 AM · Restricted Project, Restricted Project
thakis accepted D129080: [gn build] (manually) port 6b3956e123db.

Thanks!

Tue, Jul 5, 1:43 AM · Restricted Project, Restricted Project
thakis added a comment to D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext.

Looks like this breaks tests on windows: http://45.33.8.238/win/61559/step_8.txt

Tue, Jul 5, 12:06 AM · Restricted Project, Restricted Project

Mon, Jul 4

thakis added inline comments to D129059: [lld-macho] Handle LOH_ARM64_ADRP_LDR_GOT optimization hints.
Mon, Jul 4, 2:52 PM · Restricted Project, Restricted Project, Restricted Project
thakis accepted D129032: [llvm-lib] Ignore /NODEFAULTLIB flag.

Looks fine to me.

Mon, Jul 4, 1:38 PM · Restricted Project, Restricted Project
thakis accepted D129059: [lld-macho] Handle LOH_ARM64_ADRP_LDR_GOT optimization hints.

\o/

Mon, Jul 4, 1:21 PM · Restricted Project, Restricted Project, Restricted Project
thakis committed rG1ab37d996ce3: [clang-format] Update documentation (authored by thakis).
[clang-format] Update documentation
Mon, Jul 4, 12:42 PM · Restricted Project, Restricted Project
thakis closed D129050: [clang-format] Update documentation.
Mon, Jul 4, 12:42 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D126464: [lldb] Add support to load object files from thin archives.

What --author flag should I use for you when landing this?

Mon, Jul 4, 12:39 PM · Restricted Project, Restricted Project
thakis added a comment to D129080: [gn build] (manually) port 6b3956e123db.

The auto-merger only auto-merges source lists, not deps. (See llvm/utils/gn/build/sync_source_lists_from_cmake.py – the merge bot just runs llvm/utils/gn/build/sync_source_lists_from_cmake.py --write, and the commits the result if tests pass.)

Mon, Jul 4, 12:37 PM · Restricted Project, Restricted Project
thakis added a comment to D109368: [LV] Vectorize cases with larger number of RT checks, execute only if profitable..

Looks like this breaks check-clang: http://45.33.8.238/linux/80254/step_7.txt

Mon, Jul 4, 8:39 AM · Restricted Project, Restricted Project

Sun, Jul 3

thakis added inline comments to D129050: [clang-format] Update documentation.
Sun, Jul 3, 1:21 PM · Restricted Project, Restricted Project, Restricted Project
thakis requested review of D129050: [clang-format] Update documentation.
Sun, Jul 3, 1:16 PM · Restricted Project, Restricted Project, Restricted Project
thakis committed rGb1f0efc06acc: [clang-format] Tweak help text a bit (authored by thakis).
[clang-format] Tweak help text a bit
Sun, Jul 3, 12:55 PM · Restricted Project, Restricted Project
thakis closed D128984: [clang-format] Tweak help text a bit.
Sun, Jul 3, 12:55 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Jul 1

thakis added a comment to D128991: [NFC] Add a missing test for for clang-repl.

Looks like this breaks tests on Windows: http://45.33.8.238/win/61429/step_7.txt

Fri, Jul 1, 8:45 AM · Restricted Project, Restricted Project
thakis requested review of D128984: [clang-format] Tweak help text a bit.
Fri, Jul 1, 4:40 AM · Restricted Project, Restricted Project, Restricted Project
thakis committed rG12109a3b40e3: [gn build] (manually) port fe66aebd7551 (PseudoCLI) (authored by thakis).
[gn build] (manually) port fe66aebd7551 (PseudoCLI)
Fri, Jul 1, 1:46 AM · Restricted Project, Restricted Project
thakis committed rGbacb56cdc593: [gn build] (manually) port cd2292ef824 (PseudoCXX) (authored by thakis).
[gn build] (manually) port cd2292ef824 (PseudoCXX)
Fri, Jul 1, 1:46 AM · Restricted Project, Restricted Project

Thu, Jun 30

thakis accepted D128942: [lld-macho] Handle LOH_ARM64_ADRP_LDR linker optimization hints.

Lgtm!

Thu, Jun 30, 1:56 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 27

thakis added a comment to D127911: Delete 'llvm.asan.globals' for global metadata..

Looks like this breaks check-clang on windows: http://45.33.8.238/win/61067/step_7.txt

Mon, Jun 27, 11:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sat, Jun 25

thakis added a comment to D128093: [lld-macho] Initial support for Linker Optimization Hints.

Other than that, looks excellent to me.

Sat, Jun 25, 5:55 PM · Restricted Project, Restricted Project, Restricted Project
thakis added inline comments to D128093: [lld-macho] Initial support for Linker Optimization Hints.
Sat, Jun 25, 5:24 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 24

thakis added inline comments to D127083: [MCA] Introducing incremental SourceMgr and resumable pipeline.
Fri, Jun 24, 6:16 PM · Restricted Project, Restricted Project
thakis committed rG012412d19267: [gn build] (manually) port 97579dcc6d3 (LLVMMCATests) (authored by thakis).
[gn build] (manually) port 97579dcc6d3 (LLVMMCATests)
Fri, Jun 24, 6:03 PM · Restricted Project, Restricted Project
thakis added inline comments to D127083: [MCA] Introducing incremental SourceMgr and resumable pipeline.
Fri, Jun 24, 5:57 PM · Restricted Project, Restricted Project
thakis added inline comments to D127083: [MCA] Introducing incremental SourceMgr and resumable pipeline.
Fri, Jun 24, 5:55 PM · Restricted Project, Restricted Project
thakis added inline comments to D127083: [MCA] Introducing incremental SourceMgr and resumable pipeline.
Fri, Jun 24, 5:36 PM · Restricted Project, Restricted Project

Thu, Jun 23

thakis added a comment to D127554: [PowerPC] Allow llvm.ppc.cfence to accept pointer types.

Looks like this breaks tests on non-linux: http://45.33.8.238/macm1/37997/step_11.txt , http://45.33.8.238/win/60800/step_11.txt

Thu, Jun 23, 8:49 PM · Restricted Project, Restricted Project
thakis committed rGa2c1f7c90da7: [lld, ELF and mac] Add --time-trace=<file>, remove --time-trace-file=<file> (authored by thakis).
[lld, ELF and mac] Add --time-trace=<file>, remove --time-trace-file=<file>
Thu, Jun 23, 12:49 PM · Restricted Project
thakis closed D128451: [lld, ELF and mac] Add --time-trace=<file>, remove --time-trace-file=<file>.
Thu, Jun 23, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D128451: [lld, ELF and mac] Add --time-trace=<file>, remove --time-trace-file=<file>.

Thanks!

Thu, Jun 23, 12:46 PM · Restricted Project, Restricted Project, Restricted Project
thakis added inline comments to D128451: [lld, ELF and mac] Add --time-trace=<file>, remove --time-trace-file=<file>.
Thu, Jun 23, 12:30 PM · Restricted Project, Restricted Project, Restricted Project
thakis updated the diff for D128451: [lld, ELF and mac] Add --time-trace=<file>, remove --time-trace-file=<file>.

address most comments

Thu, Jun 23, 12:30 PM · Restricted Project, Restricted Project, Restricted Project
thakis updated the diff for D128451: [lld, ELF and mac] Add --time-trace=<file>, remove --time-trace-file=<file>.

simpler (?) impl by making --time-trace an alias for --time-trace= (without an arg)

Thu, Jun 23, 12:22 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D128451: [lld, ELF and mac] Add --time-trace=<file>, remove --time-trace-file=<file>.

Good suggestion, thanks. Done.

Thu, Jun 23, 12:17 PM · Restricted Project, Restricted Project, Restricted Project
thakis updated the diff for D128451: [lld, ELF and mac] Add --time-trace=<file>, remove --time-trace-file=<file>.
Thu, Jun 23, 12:17 PM · Restricted Project, Restricted Project, Restricted Project
thakis requested review of D128451: [lld, ELF and mac] Add --time-trace=<file>, remove --time-trace-file=<file>.
Thu, Jun 23, 9:18 AM · Restricted Project, Restricted Project, Restricted Project
thakis committed rG0ec87addb7d1: [lld/mac] Add a few TimeTraceScopes (authored by thakis).
[lld/mac] Add a few TimeTraceScopes
Thu, Jun 23, 8:47 AM · Restricted Project
thakis closed D128343: [lld/mac] Add a few TimeTraceScopes.
Thu, Jun 23, 8:47 AM · Restricted Project, Restricted Project, Restricted Project
thakis committed rGed39fd515a9e: [lld-macho] Use source information in duplicate symbol errors (authored by BertalanD).
[lld-macho] Use source information in duplicate symbol errors
Thu, Jun 23, 8:09 AM · Restricted Project
thakis closed D128425: [lld-macho] Use source information in duplicate symbol errors.
Thu, Jun 23, 8:09 AM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D126771: [fastalloc] Support allocate specific register class in fastalloc..

Given that the bot's been red for quite a few hours by now and there's some disagreement about the right fix, I've reverted this in 851a5efe45a026047ba8c0262a892b9895e355bf for now.

Thu, Jun 23, 7:45 AM · Restricted Project, Restricted Project
thakis added a reverting change for rG719658d078c4: [fastalloc] Support allocating specific register class in fastalloc: rG851a5efe45a0: Revert "[fastalloc] Support allocating specific register class in fastalloc".
Thu, Jun 23, 7:45 AM · Restricted Project, Restricted Project
thakis committed rG851a5efe45a0: Revert "[fastalloc] Support allocating specific register class in fastalloc" (authored by thakis).
Revert "[fastalloc] Support allocating specific register class in fastalloc"
Thu, Jun 23, 7:44 AM · Restricted Project, Restricted Project
thakis added a reverting change for D126771: [fastalloc] Support allocate specific register class in fastalloc.: rG851a5efe45a0: Revert "[fastalloc] Support allocating specific register class in fastalloc".
Thu, Jun 23, 7:44 AM · Restricted Project, Restricted Project
thakis added a comment to D126771: [fastalloc] Support allocate specific register class in fastalloc..

This also broke check-llvm on macOS: http://45.33.8.238/macm1/37938/step_11.txt (this both is an M1 mac, not sure if intel vs arm matter).

Thu, Jun 23, 4:54 AM · Restricted Project, Restricted Project
thakis accepted D128425: [lld-macho] Use source information in duplicate symbol errors.

Nice!

Thu, Jun 23, 4:44 AM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D126771: [fastalloc] Support allocate specific register class in fastalloc..

Looks like https://github.com/llvm/llvm-project/commit/6f258c0fd34cf4001ffa08c61f6e4e0f1254c50f fixed it.

Thu, Jun 23, 4:33 AM · Restricted Project, Restricted Project
thakis added a comment to D126771: [fastalloc] Support allocate specific register class in fastalloc..

On many of the official bots too, eg https://lab.llvm.org/buildbot/#/builders/109/builds/41178 (did that not generate an email?)

Thu, Jun 23, 3:23 AM · Restricted Project, Restricted Project
thakis added a comment to D126771: [fastalloc] Support allocate specific register class in fastalloc..

Looks like this breaks check-clang: http://45.33.8.238/linux/79438/step_7.txt

Thu, Jun 23, 3:21 AM · Restricted Project, Restricted Project

Wed, Jun 22

thakis added a comment to D128093: [lld-macho] Initial support for Linker Optimization Hints.

(Also, not sure it's such a bad thing that it defaults to on. Smaller projects won't notice the link time cost, and larger projects will have lots of tweaking flags for better or worse anyways…)

Wed, Jun 22, 10:16 AM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D128093: [lld-macho] Initial support for Linker Optimization Hints.

The added overhead on linking Chromium is 200 milliseconds on my M1 Mac mini, which accounts for about 4% of the total runtime.

Is there measurable overhead when -ignore_optimization_hints is passed? I'm wondering about the overhead from increasing the Reloc struct size

4% overhead is not such a big deal IMO if we can disable it in developer builds (though the fact that it's enabled by default is unfortunate)

Wed, Jun 22, 10:15 AM · Restricted Project, Restricted Project, Restricted Project
thakis requested review of D128343: [lld/mac] Add a few TimeTraceScopes.
Wed, Jun 22, 8:00 AM · Restricted Project, Restricted Project, Restricted Project
thakis committed rG1af1e91bbab6: [gn build] Port c3574ef739fb slightly better (authored by thakis).
[gn build] Port c3574ef739fb slightly better
Wed, Jun 22, 7:44 AM · Restricted Project, Restricted Project
thakis committed rG721875db2b8a: Reland "[gn build] (manually) port b94db7ed7eaf (Confusables.inc)" (authored by thakis).
Reland "[gn build] (manually) port b94db7ed7eaf (Confusables.inc)"
Wed, Jun 22, 7:39 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

thakis committed rG0baf13e282ab: [lld/mac] Parallelize code signature computation (authored by thakis).
[lld/mac] Parallelize code signature computation
Tue, Jun 21, 5:42 PM · Restricted Project
thakis closed D128298: [lld/mac] Parallelize code signature computation.
Tue, Jun 21, 5:41 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D128298: [lld/mac] Parallelize code signature computation.

Anyone interested in a 3% speedup? :)

Tue, Jun 21, 3:59 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a reverting change for rG0cc7ad417585: Revert "[lld-macho] Show source information for undefined references": rG5792797c5b13: Reland "[lld-macho] Show source information for undefined references".
Tue, Jun 21, 3:51 PM · Restricted Project
thakis committed rG5792797c5b13: Reland "[lld-macho] Show source information for undefined references" (authored by BertalanD).
Reland "[lld-macho] Show source information for undefined references"
Tue, Jun 21, 3:51 PM · Restricted Project
thakis added inline comments to D128184: [lld-macho] Show source information for undefined references.
Tue, Jun 21, 2:42 PM · Restricted Project, Restricted Project, Restricted Project
thakis added inline comments to D128184: [lld-macho] Show source information for undefined references.
Tue, Jun 21, 1:45 PM · Restricted Project, Restricted Project, Restricted Project
thakis committed rG77b6efbd8290: [ADT] [lld-macho] Check for end iterator deref in filter_iterator_base (authored by BertalanD).
[ADT] [lld-macho] Check for end iterator deref in filter_iterator_base
Tue, Jun 21, 12:50 PM · Restricted Project, Restricted Project
thakis closed D128294: [ADT] [lld-macho] Check for end iterator deref in filter_iterator_base.
Tue, Jun 21, 12:50 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D128295: [lld/mac] Replace while loop with for loop.

Thanks! :)

Tue, Jun 21, 12:45 PM · Restricted Project, Restricted Project, Restricted Project
thakis committed rG3ade3d372408: [lld/mac] Replace while loop with for loop (authored by thakis).
[lld/mac] Replace while loop with for loop
Tue, Jun 21, 12:45 PM · Restricted Project
thakis closed D128295: [lld/mac] Replace while loop with for loop.
Tue, Jun 21, 12:45 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D128295: [lld/mac] Replace while loop with for loop.

(in any case, it's irrelevant after D128298)

Tue, Jun 21, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D128295: [lld/mac] Replace while loop with for loop.

Nit. Your are not allowed to check getBlockCount() for every iteration. Pull it out of the loop?

Tue, Jun 21, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
thakis requested review of D128298: [lld/mac] Parallelize code signature computation.
Tue, Jun 21, 12:32 PM · Restricted Project, Restricted Project, Restricted Project
thakis added a comment to D128295: [lld/mac] Replace while loop with for loop.

Hm?

Tue, Jun 21, 12:31 PM · Restricted Project, Restricted Project, Restricted Project
thakis requested review of D128295: [lld/mac] Replace while loop with for loop.
Tue, Jun 21, 12:17 PM · Restricted Project, Restricted Project, Restricted Project
thakis committed rG858e8b17f736: [lld/mac] On Apple systems, call CC_SHA256 from libSystem (authored by thakis).
[lld/mac] On Apple systems, call CC_SHA256 from libSystem
Tue, Jun 21, 11:58 AM · Restricted Project
thakis closed D128290: [lld/mac] On Apple systems, call CC_SHA256 from libSystem.
Tue, Jun 21, 11:58 AM · Restricted Project, Restricted Project, Restricted Project
thakis added inline comments to D128294: [ADT] [lld-macho] Check for end iterator deref in filter_iterator_base.
Tue, Jun 21, 11:56 AM · Restricted Project, Restricted Project, Restricted Project
thakis accepted D128294: [ADT] [lld-macho] Check for end iterator deref in filter_iterator_base.

Nice!

Tue, Jun 21, 11:26 AM · Restricted Project, Restricted Project, Restricted Project
thakis committed rGca25baee7ecc: [lld/mac] Extract a sha256() function (authored by thakis).
[lld/mac] Extract a sha256() function
Tue, Jun 21, 11:03 AM · Restricted Project
thakis closed D128289: [lld/mac] Extract a sha256() function.
Tue, Jun 21, 11:03 AM · Restricted Project, Restricted Project, Restricted Project