thakis (Nico Weber)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (253 w, 4 d)

Recent Activity

Tue, Oct 31

thakis added a comment to D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

It could be just

errorToBool(BCData.takeError());

and errorToBool() can handle ErrorSuccess, no?

Tue, Oct 31, 11:35 AM
thakis added a comment to D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

I'm not subscribed to llvm-commits so replying here:

Tue, Oct 31, 10:24 AM
thakis closed D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.
Tue, Oct 31, 9:40 AM
thakis accepted D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

317010

Tue, Oct 31, 9:40 AM
thakis updated the diff for D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

Now with better test. I'm going to land this; happy to address post-commit review comments of course.

Tue, Oct 31, 9:38 AM
thakis updated the diff for D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

Now with test (only for one of the 4 changes, but the one we hit in practice. I don't see how to test the other 3). Feeling pretty good about this now.

Tue, Oct 31, 8:41 AM

Mon, Oct 30

thakis added a comment to D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

rL315477, rL315475, rL315474, rL315473, rL315376, rL315354 seem to not have introduced bugs of this type as far as I can tell.

Mon, Oct 30, 3:52 PM
thakis updated the diff for D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

fix copy-pasto

Mon, Oct 30, 3:31 PM
thakis added inline comments to D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.
Mon, Oct 30, 3:30 PM
thakis created D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.
Mon, Oct 30, 3:28 PM
thakis added a comment to D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library..

Sounds like this ended up being useful for Android too: https://github.com/android-ndk/ndk/issues/105#issuecomment-324179958

Mon, Oct 30, 10:35 AM

Thu, Oct 26

thakis closed D39317: Use -fuse-init-array if no gcc installation is found..

r316713, thanks!

Thu, Oct 26, 4:27 PM

Wed, Oct 25

thakis created D39317: Use -fuse-init-array if no gcc installation is found..
Wed, Oct 25, 9:17 PM
thakis accepted D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros other than NULL..

In general, "I don't see any way to prevent $slow_thing" just means the patch can't move ahead. But in this case, this looks like fairly small overhead for a worst-case input, so this won't be slow on real-world code. So lgtm.

Wed, Oct 25, 2:50 PM · Restricted Project
thakis accepted D39301: Ignore implicity casts for zero-as-null-pointer-constant warning.

Awesome, thanks much! Like lebedev.ri says, adding a test for the "Parens" part would be good.

Wed, Oct 25, 11:51 AM
thakis added a comment to D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros other than NULL..

Can you build some large-ish codebase (say, LLVM) with and without this patch and make sure that this doesn't measurably add to build perf? (With the warning turned on, obviously.)

Wed, Oct 25, 11:49 AM · Restricted Project

Mon, Oct 23

thakis accepted D38972: Add the /v option which prints out the LLD version string..

Thanks!

Mon, Oct 23, 7:41 AM

Oct 20 2017

thakis added a comment to D38973: COFF: Give manifest resource file a name..

because this requires Windows an

Oct 20 2017, 12:10 PM
thakis accepted D39104: Allow /showIncludes with /P.

Thanks!

Oct 20 2017, 12:05 PM
thakis added a comment to D38972: Add the /v option which prints out the LLD version string..

Yes, that's what I meant. clang-cl also has a bunch of Unix style flags. I agree it's a bit strange, but it'd be llvm-consistent.

Oct 20 2017, 5:28 AM

Oct 17 2017

thakis added inline comments to D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported.
Oct 17 2017, 1:44 PM

Oct 16 2017

thakis added a comment to D38972: Add the /v option which prints out the LLD version string..

This would work for me, but it sounds like it'd break mstorsjo :-( Maybe lld-link and clang-cl should both just have a --version. That won't clash, does what it says, and won't break existing code.

Oct 16 2017, 2:56 PM
thakis added a comment to D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros other than NULL..

As said on the bug, this matches gcc's behavior, and with this you won't see this warning for NULL. I don't think this is better.

Oct 16 2017, 7:23 AM · Restricted Project

Oct 6 2017

thakis accepted D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017.

Should probably get a release note too.

Oct 6 2017, 1:55 PM

Sep 27 2017

thakis closed D38291: clang-format/java: Unbreak genenrics formatting after r299952..

r314325, thanks!

Sep 27 2017, 10:59 AM
thakis updated subscribers of D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.
Sep 27 2017, 10:55 AM

Sep 26 2017

thakis created D38294: java import sorting PoC.
Sep 26 2017, 3:30 PM
thakis created D38291: clang-format/java: Unbreak genenrics formatting after r299952..
Sep 26 2017, 3:30 PM

Sep 19 2017

thakis added a comment to D37954: Try to shorten system header paths when using -MD depfiles.

I think for depfile generation, we generally try to be gcc-compatible (I can link to prior changes in this spirit), so I think this seems like a good thing to do to me. gcc only does this for system headers, yes?

Sep 19 2017, 3:30 PM

Sep 5 2017

thakis closed D37452: lld-link: Add --rsp-quoting= flag.

r312594, thanks!

Sep 5 2017, 4:48 PM

Sep 4 2017

thakis updated the diff for D37452: lld-link: Add --rsp-quoting= flag.

fix a comment typo

Sep 4 2017, 4:47 PM
thakis updated the diff for D37452: lld-link: Add --rsp-quoting= flag.

Actually, I talked myself out of this affecting %LINK% / %_LINK_% while writing the patch summary. I removed that bit.

Sep 4 2017, 4:45 PM
thakis created D37452: lld-link: Add --rsp-quoting= flag.
Sep 4 2017, 4:36 PM

Aug 30 2017

thakis closed D37324: Suppress -Wdelete-non-virtual-dtor warnings _about_ classes defined in system headers..

312216, thanks!

Aug 30 2017, 11:18 PM
thakis created D37324: Suppress -Wdelete-non-virtual-dtor warnings _about_ classes defined in system headers..
Aug 30 2017, 7:29 PM
thakis closed D37235: Let -Wdelete-non-virtual-dtor fire in system headers too..

Thanks, landed in r312167.

Aug 30 2017, 1:28 PM

Aug 28 2017

thakis updated the diff for D37235: Let -Wdelete-non-virtual-dtor fire in system headers too..

Don't warn in unevaluated contexts. Ready for a look now.

Aug 28 2017, 3:33 PM
thakis created D37235: Let -Wdelete-non-virtual-dtor fire in system headers too..
Aug 28 2017, 3:08 PM

Aug 23 2017

thakis created D37090: Implement CFG construction for __finally..
Aug 23 2017, 6:35 PM
thakis closed D36914: Implement CFG construction for __try / __except / __leave..
Aug 23 2017, 8:35 AM

Aug 22 2017

thakis updated the diff for D36914: Implement CFG construction for __try / __except / __leave..

add test from rnk

Aug 22 2017, 4:57 PM

Aug 21 2017

thakis added inline comments to D36914: Implement CFG construction for __try / __except / __leave..
Aug 21 2017, 10:43 AM
thakis updated the diff for D36914: Implement CFG construction for __try / __except / __leave..

Just use TryTerminatedBlock

Aug 21 2017, 10:43 AM
thakis updated the summary of D36914: Implement CFG construction for __try / __except / __leave..
Aug 21 2017, 10:43 AM

Aug 18 2017

thakis created D36914: Implement CFG construction for __try / __except / __leave..
Aug 18 2017, 7:03 PM
thakis accepted D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure.

Many driver tests check in a basic representative directory structure (e.g. test/Driver/Inputs/basic_freebsd_tree/ and its many siblings).

Aug 18 2017, 6:49 PM
thakis added a comment to D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure.

This approach looks good to me.

Aug 18 2017, 7:41 AM
thakis added a comment to D36857: [Driver] Set linkPath and MSVT version when cl.exe is detected, plus STL's hacking..

Oh, I guess this is superseded by https://reviews.llvm.org/D36860 ?

Aug 18 2017, 7:39 AM
thakis added inline comments to D36857: [Driver] Set linkPath and MSVT version when cl.exe is detected, plus STL's hacking..
Aug 18 2017, 7:33 AM
thakis added a reviewer for D36857: [Driver] Set linkPath and MSVT version when cl.exe is detected, plus STL's hacking.: zturner.
Aug 18 2017, 7:33 AM

Aug 16 2017

thakis added inline comments to D36758: [LLD COFF / PDB] Incrementally update the BuildId when writing a PDB..
Aug 16 2017, 2:20 PM

Aug 14 2017

thakis updated the summary of D36481: /redundancyReport proof of concept.
Aug 14 2017, 12:05 PM
thakis updated the summary of D36481: /redundancyReport proof of concept.
Aug 14 2017, 12:01 PM
thakis updated the diff for D36481: /redundancyReport proof of concept.
Aug 14 2017, 11:58 AM
thakis updated the summary of D36481: /redundancyReport proof of concept.
Aug 14 2017, 11:58 AM
thakis updated the diff for D36481: /redundancyReport proof of concept.
Aug 14 2017, 11:55 AM

Aug 9 2017

thakis accepted D36526: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare.

Thanks!

Aug 9 2017, 1:56 PM

Aug 8 2017

thakis created D36481: /redundancyReport proof of concept.
Aug 8 2017, 12:28 PM
thakis closed D36413: Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name..

r310376, thanks!

Aug 8 2017, 9:22 AM

Aug 7 2017

thakis created D36413: Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name..
Aug 7 2017, 10:02 AM

Aug 4 2017

thakis added a comment to D36324: Integrate Kostya's clang-proto-fuzzer with LLVM..

Why should this be part of llvm? This seems to come with very heavy dependencies (protobuf), and LLVM has historically tried to minimize the number of things it depends on.

Aug 4 2017, 11:22 AM
thakis added a comment to D36191: [CodeGen] Don't make availability attributes imply default visibility on macos.

Is landing this blocked on internal testing?

Aug 4 2017, 7:22 AM
thakis added a comment to D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name..

Hm, that's unfortunate. I don't see a good way to rescue this patch.

Aug 4 2017, 7:14 AM

Aug 3 2017

thakis closed D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name..

309984.

Aug 3 2017, 2:07 PM
thakis added a comment to D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name..

I'm going to land this. It's early in the 6.0 cycle, so if this causes issues, we should have time to find them and then follow up in case we run into any.

Aug 3 2017, 2:06 PM
thakis closed D36281: Fix llvm-for-windows-on-linux build after LLVM r272701..

309980, thanks!

Aug 3 2017, 1:11 PM
thakis created D36281: Fix llvm-for-windows-on-linux build after LLVM r272701..
Aug 3 2017, 1:08 PM
thakis added a comment to D33900: Print registered targets in clang's version information.

I've reverted this in 309960, as discussed.

Aug 3 2017, 9:47 AM
thakis added a comment to D27827: [ObjC] CodeGen support for @available on macOS.

(Our workaround is to call __builtin_available() once before engaging the sandbox, which isn't so bad. Just thought I'd let you know about it; this isn't a serious bug for us.)

Aug 3 2017, 8:31 AM
thakis added a comment to D27827: [ObjC] CodeGen support for @available on macOS.

Looks like the email reply didn't make it to phab, so here it is again:

Aug 3 2017, 8:05 AM

Aug 2 2017

thakis added a comment to D27827: [ObjC] CodeGen support for @available on macOS.

We just noticed that if you call __builtin_available() for the first time after activating your app's sandbox, the function will fail:

Aug 2 2017, 1:33 PM
thakis created D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name..
Aug 2 2017, 1:30 PM
thakis added a comment to D36191: [CodeGen] Don't make availability attributes imply default visibility on macos.

Awesome, thanks! Maybe mention the PR# for this in the commit message.

Aug 2 2017, 9:14 AM

Jul 28 2017

thakis added a comment to D33900: Print registered targets in clang's version information.

dim: Does putting the target listing behind a different flag work for you? Which problem are you trying to solve here?

Jul 28 2017, 9:53 AM

Jul 26 2017

thakis closed D35872: lld: /manifestuac:no shouldn't disable /manifestdependency:.

Thanks! r309231

Jul 26 2017, 4:38 PM

Jul 25 2017

thakis created D35872: lld: /manifestuac:no shouldn't disable /manifestdependency:.
Jul 25 2017, 6:52 PM
thakis closed D35842: lld: only write .manifest files if /manifest is passed, PR33925.

r308998, thanks!

Jul 25 2017, 11:08 AM
thakis closed D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library..

r308997, thanks!

Jul 25 2017, 11:04 AM
thakis created D35842: lld: only write .manifest files if /manifest is passed, PR33925.
Jul 25 2017, 8:55 AM

Jul 24 2017

thakis added a comment to D33900: Print registered targets in clang's version information.
In D33900#819234, @dim wrote:

Sorry, I just noticed this weeks later. Why are we adding this to --version instead of adding some new flag for printing this? When I pass --version, I'm usually interested in clang's version and don't need a screenful of other information below it (which makes the output I do care about scroll off the screen).

I added it there, for consistency with other LLVM tools, for example:

Jul 24 2017, 12:15 PM
thakis closed D35757: Work around an MSVC2017 update 3 codegen bug..

r308897.

Jul 24 2017, 9:55 AM
thakis added a comment to D33900: Print registered targets in clang's version information.

Sorry, I just noticed this weeks later. Why are we adding this to --version instead of adding some new flag for printing this? When I pass --version, I'm usually interested in clang's version and don't need a screenful of other information below it (which makes the output I do care about scroll off the screen).

Jul 24 2017, 8:37 AM

Jul 23 2017

thakis added a comment to D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library..

Most of the patch is unifying all the toolchains to call the newly-introduced ToolChain::ShouldLinkCXXStdlib() instead of all manually checking for D.CCIsCXX() && !getFlag(nostdlib, nodefaultlibs). The actual behavior change is to make that function check the new nostdlib++ flag too.

Jul 23 2017, 11:57 AM
thakis created D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library..
Jul 23 2017, 11:55 AM

Jul 21 2017

thakis added a comment to D35757: Work around an MSVC2017 update 3 codegen bug..

From what I understand, _MSC_VER changes with each 2017 update.

Jul 21 2017, 9:31 PM
thakis created D35757: Work around an MSVC2017 update 3 codegen bug..
Jul 21 2017, 7:07 PM
thakis closed D35386: Speed up gdb index creation.

r308544

Jul 21 2017, 8:59 AM

Jul 17 2017

thakis closed D35236: Refactor gdb index creation.

(landed in r307867)

Jul 17 2017, 5:26 AM

Jul 14 2017

thakis added inline comments to D35379: Add documentation for @available.
Jul 14 2017, 11:53 AM
thakis added a comment to D35379: Add documentation for @available.

I went ahead and landed this in r308044, given that I addressed the nits and removed the possibly contentious bits. Happy to address remaining nits in a follow-up.

Jul 14 2017, 11:42 AM
thakis added a comment to D35379: Add documentation for @available.

Mostly done, thanks!

Jul 14 2017, 9:26 AM
thakis updated the diff for D35379: Add documentation for @available.

sdy comments

Jul 14 2017, 9:26 AM
thakis updated the diff for D35379: Add documentation for @available.

arphaman comments

Jul 14 2017, 9:17 AM
thakis added a comment to D35379: Add documentation for @available.

Thanks, all done, much better!

Jul 14 2017, 9:16 AM

Jul 13 2017

thakis updated the diff for D35379: Add documentation for @available.

Document *, add example with multiple platforms

Jul 13 2017, 1:58 PM
thakis added inline comments to D35379: Add documentation for @available.
Jul 13 2017, 1:35 PM
thakis updated the diff for D35379: Add documentation for @available.

comments

Jul 13 2017, 1:35 PM
thakis created D35379: Add documentation for @available.
Jul 13 2017, 1:06 PM

Jun 27 2017

thakis closed D34637: [libunwind] Add _LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS.

r306442, thanks!

Jun 27 2017, 11:37 AM

May 25 2017

thakis added a comment to D32862: [AMDGPU] add intrinsic for s_getpc.

http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2604
http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/3280

May 25 2017, 12:20 PM