Looks like this breaks building on Mac: http://45.33.8.238/macm1/57676/step_4.txt

Reverted in efd34ba60f3839b0a68b2e32ff9011b6823bc16f for now.

This seems to break tests: http://45.33.8.238/linux/103038/step_12.txt

Hello, https://github.com/llvm/llvm-project/commit/5fb4147f74ad90095f08f243e5f19877d09d11b9 broke the windows build (http://45.33.8.238/win/76494/step_4.txt) because it's now including system headers within namespace lldb. Please take a look and revert for now if it takes a while to fix.

On Mac too: http://45.33.8.238/macm1/57332/step_11.txt

Ms stl uses this construction to make the warning grouped under -Wdeprecated-declarations: https://github.com/search?q=repo%3Amicrosoft%2FSTL%20_CXX17_DEPRECATE_C_HEADER&type=code

This breaks tests on windows: http://45.33.8.238/win/76177/step_9.txt

This breaks tests: http://45.33.8.238/linux/102084/step_9.txt

It looks like this broke building libunwind. Building it now fails with (when building clang and lld and so on with this patch, and then building libunwind with just-built clang and lld and so on):

(if the presubmit is related, maybe some flang test needs updating? Weird that flang uses clang's diags.)

Lg

Oh, that was reported a while ago already. Reverted in 2eb5ac99a76dbbf8ac68c538211fabeaa5ac0bfd for now.

This breaks tests on windows: http://45.33.8.238/win/75486/step_9.txt

As far as I can tell this doesn't build: http://45.33.8.238/linux/99657/step_10.txt

The enable of this test without tflite broke tests on Mac: http://45.33.8.238/macm1/54722/step_11.txt

Reverts are cheap, we can just revert the last 3.

Let's fix the test or revert the change instead.

Either this or D139168 is breaking tests on Windows: http://45.33.8.238/win/74780/step_7.txt

It looks like this might have broken hwasan tests on Linux: http://45.33.8.238/linux/98629/step_10.txt

Instead of adding an xfail, does it make more sense to pass an explicit triple to lli instead?

This breaks tests on Mac: http://45.33.8.238/macm1/54167/step_11.txt

Thanks!

This breaks tests on Mac: http://45.33.8.238/macm1/54097/step_7.txt

Reverted in adf7ffd51ee34c3a72d3168f5aed8b946ba3d2cc for now.

Looks like the test fails on win: http://45.33.8.238/win/74290/step_7.txt

I figured it's more useful to add this once the tests pass, but sure, LG 🙂

This breaks tests on macOS: http://45.33.8.238/macm1/53215/step_7.txt

Reverted in 95914abd13ef0e447392f9f5e38487d8471a92b7 for now.

This breaks building on windows: http://45.33.8.238/win/73448/step_4.txt

If it's not too much trouble, maybe you could cherry-pick and amend 8d498e08deaf6e06a578cfedb4eb259b722ac7f6 into the commit that relands this.

Reverted in a5f446bc4bb1ac78d6852cc8e251a1229899b783 for now.

I've confirmed that this breaks a pretty vanilla build setup.

In D136315#4065426, @calebzulawski wrote:

I don't think we necessarily need to revert due to the xcrun quirk since I think it's harmless, though I can provide a follow up change if necessary. I just checked Rust's source as a comparison and it appears that for macOS targets it will always attempt to invoke xcrun regardless of host as well.

I just verified that that does indeed happen, and it does:

My bot is a Mac. It doesn't set any env vars (other than the ones that lit always sets). In theory it shouldn't matter since tests aren't supposed to depend on system headers. (Tangential: maybe there should be a flag to turn this off and %clang should expand to clang with that flag?)

This breaks oodles of tests for me: http://45.33.8.238/macm1/52994/step_7.txt

Thanks for the fast revert!

Also fails on 64-bit windows fwiw: http://45.33.8.238/win/73344/step_4.txt

Can you say a few words on _why_ this is emitted in only Objective-C? What's missing for Objective-C++? I was surprised that this warning fired in a .m file but not in a .mm file.

Thanks for this change :)

cb2f23a9b0de9c6747afb1efdc6e05b4691e0c50 did the trick. Thanks for the fix!

Thanks! Still failing with that though: http://45.33.8.238/win/73278/step_7.txt

Looks like this breaks tests on Windows: http://45.33.8.238/win/73276/step_7.txt

Looks like this doesn't build on Windows: http://45.33.8.238/win/73274/step_4.txt

This unit-test based test also fails on non-linux, see e.g. http://45.33.8.238/macm1/52570/step_11.txt

I think this breaks tests on Windows: http://45.33.8.238/win/73191/step_7.txt

Thanks! I'll wait another day, but this has been sitting here for a while, so I think folks had plenty time to comment :)