thakis (Nico Weber)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (267 w, 2 d)

Recent Activity

Thu, Feb 15

thakis added a comment to D43156: Allow disabling PDB generation in Release build.

So should we revert https://reviews.llvm.org/D42632 for now?

Thu, Feb 15, 7:13 AM
thakis added a comment to D42925: Call FlushFileBuffers on readwrite file mappings..

Did this land?

Thu, Feb 15, 7:07 AM

Tue, Feb 13

thakis closed D43221: Teach Wreturn-type, Wunreachable-code, and alpha.deadcode.UnreachableCode to treat __assume(0) like __builtin_unreachable..

r325052, thanks!

Tue, Feb 13, 1:33 PM

Mon, Feb 12

thakis created D43221: Teach Wreturn-type, Wunreachable-code, and alpha.deadcode.UnreachableCode to treat __assume(0) like __builtin_unreachable..
Mon, Feb 12, 9:11 PM
thakis updated the diff for D42910: not for review, just prototyping some msxml stuff.

some attr merging

Mon, Feb 12, 11:56 AM

Fri, Feb 9

thakis added a comment to D43110: [Sema] Don't mark plain MS enums as fixed.

Nice!

Fri, Feb 9, 5:26 AM

Thu, Feb 8

thakis added a comment to D43002: Emit S_OBJNAME symbol in CodeView.

I was about to say "please make sure this honors -fdebug-prefix-map" but I suppose codeview probably contains so many absolute paths at the moment that we should instead have a concerted effort to make debug info cwd-independent at some later point instead.

Thu, Feb 8, 6:58 AM
thakis added inline comments to D42632: Generate PDB files for profiling even in Release build.
Thu, Feb 8, 6:47 AM

Wed, Feb 7

thakis updated the diff for D42910: not for review, just prototyping some msxml stuff.
Wed, Feb 7, 10:42 AM
thakis updated the diff for D42910: not for review, just prototyping some msxml stuff.
Wed, Feb 7, 9:21 AM
thakis added a comment to D36191: [CodeGen] Don't make availability attributes imply default visibility on macos.

Err sorry, landed in rL310382.

Wed, Feb 7, 7:33 AM
thakis added a comment to D36191: [CodeGen] Don't make availability attributes imply default visibility on macos.

What's the status here?

Wed, Feb 7, 7:32 AM

Tue, Feb 6

thakis added a comment to D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple.

I went ahead and landed this with the comments requested by Duncan in r324385. (http://llvm.org/viewvc/llvm-project?view=revision&revision=324385)

Tue, Feb 6, 11:20 AM

Mon, Feb 5

thakis added a comment to D41102: Setup clang-doc frontend framework.

This should be in clang-tools-extra next to clang-tidy, clang-include-fixer, clangd etc, not in the main compiler repo, right?

Mon, Feb 5, 12:44 PM · Restricted Project
thakis created D42910: not for review, just prototyping some msxml stuff.
Mon, Feb 5, 7:55 AM

Thu, Feb 1

thakis added a comment to D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple.

The powers that be updated the SDK on the chromium clang bots, so we need some solution for this issue soon.

Thu, Feb 1, 5:52 AM

Jan 25 2018

thakis closed D42538: [clang-cl] Add support for /arch:AVX512F and /arch:AVX512.

r323433, thanks!

Jan 25 2018, 7:26 AM
thakis updated the summary of D42538: [clang-cl] Add support for /arch:AVX512F and /arch:AVX512.
Jan 25 2018, 7:21 AM
thakis updated the summary of D42538: [clang-cl] Add support for /arch:AVX512F and /arch:AVX512.
Jan 25 2018, 7:11 AM
thakis created D42538: [clang-cl] Add support for /arch:AVX512F and /arch:AVX512.
Jan 25 2018, 7:11 AM
thakis closed D42497: clang-cl: Simplify handling of /arch: flag..

r323426, thanks!

Jan 25 2018, 6:41 AM
thakis added inline comments to D42497: clang-cl: Simplify handling of /arch: flag..
Jan 25 2018, 6:11 AM
thakis updated the diff for D42497: clang-cl: Simplify handling of /arch: flag..
Jan 25 2018, 6:11 AM

Jan 24 2018

thakis created D42497: clang-cl: Simplify handling of /arch: flag..
Jan 24 2018, 12:14 PM

Jan 23 2018

thakis closed D42422: Introduce errorToBool() which converts an Error to a bool and puts the Error in a checked state..
Jan 23 2018, 11:06 AM
thakis accepted D42422: Introduce errorToBool() which converts an Error to a bool and puts the Error in a checked state..

(Rafael reviewed at http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20180122/518553.html , so closing in phab)

Jan 23 2018, 11:05 AM
thakis added a comment to D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

(addressing comments at https://reviews.llvm.org/D42422)

Jan 23 2018, 7:41 AM
thakis created D42422: Introduce errorToBool() which converts an Error to a bool and puts the Error in a checked state..
Jan 23 2018, 7:33 AM

Jan 17 2018

thakis closed D42157: [clang-cl] Let /FA output use intel assembly..

r322652, thanks!

Jan 17 2018, 5:35 AM

Jan 16 2018

thakis created D42157: [clang-cl] Let /FA output use intel assembly..
Jan 16 2018, 6:14 PM
thakis closed D42085: Add va_start()/va_copy()/va_end to Builtins.def.

Yes, I looked at the same file and came to the same conclusion regarding a test :-)

Jan 16 2018, 8:57 AM

Jan 15 2018

thakis created D42085: Add va_start()/va_copy()/va_end to Builtins.def.
Jan 15 2018, 12:19 PM

Jan 2 2018

thakis added a comment to D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it..

FWIW we build with -Wall -Wextra and we disable this warning since it's in our (chromium's) opinion not useful on large real-world code. So I'm not sure it should be in -Wextra. (Also, I believe clang has historically tried to keep -Wall and -Wextra pretty similar?)

Jan 2 2018, 7:33 PM · Restricted Project

Dec 28 2017

thakis added a comment to D41581: [COFF] Do not parse args twice if no rsp files exists.

(to keep things linked up, this broke building chromium, fixed by inglorion in r321512)

Dec 28 2017, 11:21 AM · lld

Oct 31 2017

thakis added a comment to D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

It could be just

errorToBool(BCData.takeError());

and errorToBool() can handle ErrorSuccess, no?

Oct 31 2017, 11:35 AM
thakis added a comment to D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

I'm not subscribed to llvm-commits so replying here:

Oct 31 2017, 10:24 AM
thakis closed D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.
Oct 31 2017, 9:40 AM
thakis accepted D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

317010

Oct 31 2017, 9:40 AM
thakis updated the diff for D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

Now with better test. I'm going to land this; happy to address post-commit review comments of course.

Oct 31 2017, 9:38 AM
thakis updated the diff for D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

Now with test (only for one of the 4 changes, but the one we hit in practice. I don't see how to test the other 3). Feeling pretty good about this now.

Oct 31 2017, 8:41 AM

Oct 30 2017

thakis added a comment to D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

rL315477, rL315475, rL315474, rL315473, rL315376, rL315354 seem to not have introduced bugs of this type as far as I can tell.

Oct 30 2017, 3:52 PM
thakis updated the diff for D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.

fix copy-pasto

Oct 30 2017, 3:31 PM
thakis added inline comments to D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.
Oct 30 2017, 3:30 PM
thakis created D39437: Fix a bunch of assert-on-invalid-bitcode regressions after 315483.
Oct 30 2017, 3:28 PM
thakis added a comment to D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library..

Sounds like this ended up being useful for Android too: https://github.com/android-ndk/ndk/issues/105#issuecomment-324179958

Oct 30 2017, 10:35 AM

Oct 26 2017

thakis closed D39317: Use -fuse-init-array if no gcc installation is found..

r316713, thanks!

Oct 26 2017, 4:27 PM

Oct 25 2017

thakis created D39317: Use -fuse-init-array if no gcc installation is found..
Oct 25 2017, 9:17 PM
thakis accepted D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros other than NULL..

In general, "I don't see any way to prevent $slow_thing" just means the patch can't move ahead. But in this case, this looks like fairly small overhead for a worst-case input, so this won't be slow on real-world code. So lgtm.

Oct 25 2017, 2:50 PM · Restricted Project
thakis accepted D39301: Ignore implicity casts for zero-as-null-pointer-constant warning.

Awesome, thanks much! Like lebedev.ri says, adding a test for the "Parens" part would be good.

Oct 25 2017, 11:51 AM
thakis added a comment to D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros other than NULL..

Can you build some large-ish codebase (say, LLVM) with and without this patch and make sure that this doesn't measurably add to build perf? (With the warning turned on, obviously.)

Oct 25 2017, 11:49 AM · Restricted Project

Oct 23 2017

thakis accepted D38972: Add the /v option which prints out the LLD version string..

Thanks!

Oct 23 2017, 7:41 AM

Oct 20 2017

thakis added a comment to D38973: COFF: Give manifest resource file a name..

because this requires Windows an

Oct 20 2017, 12:10 PM
thakis accepted D39104: Allow /showIncludes with /P.

Thanks!

Oct 20 2017, 12:05 PM
thakis added a comment to D38972: Add the /v option which prints out the LLD version string..

Yes, that's what I meant. clang-cl also has a bunch of Unix style flags. I agree it's a bit strange, but it'd be llvm-consistent.

Oct 20 2017, 5:28 AM

Oct 17 2017

thakis added inline comments to D18953: [ms][dll] #26935 Defining a dllimport function should cause it to be exported.
Oct 17 2017, 1:44 PM

Oct 16 2017

thakis added a comment to D38972: Add the /v option which prints out the LLD version string..

This would work for me, but it sounds like it'd break mstorsjo :-( Maybe lld-link and clang-cl should both just have a --version. That won't clash, does what it says, and won't break existing code.

Oct 16 2017, 2:56 PM
thakis added a comment to D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros other than NULL..

As said on the bug, this matches gcc's behavior, and with this you won't see this warning for NULL. I don't think this is better.

Oct 16 2017, 7:23 AM · Restricted Project

Oct 6 2017

thakis accepted D38646: [MS] Raise the default value of _MSC_VER to 1910, which is in VS 2017.

Should probably get a release note too.

Oct 6 2017, 1:55 PM

Sep 27 2017

thakis closed D38291: clang-format/java: Unbreak genenrics formatting after r299952..

r314325, thanks!

Sep 27 2017, 10:59 AM
thakis updated subscribers of D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types.
Sep 27 2017, 10:55 AM

Sep 26 2017

thakis created D38294: java import sorting PoC.
Sep 26 2017, 3:30 PM
thakis created D38291: clang-format/java: Unbreak genenrics formatting after r299952..
Sep 26 2017, 3:30 PM

Sep 19 2017

thakis added a comment to D37954: Try to shorten system header paths when using -MD depfiles.

I think for depfile generation, we generally try to be gcc-compatible (I can link to prior changes in this spirit), so I think this seems like a good thing to do to me. gcc only does this for system headers, yes?

Sep 19 2017, 3:30 PM

Sep 5 2017

thakis closed D37452: lld-link: Add --rsp-quoting= flag.

r312594, thanks!

Sep 5 2017, 4:48 PM

Sep 4 2017

thakis updated the diff for D37452: lld-link: Add --rsp-quoting= flag.

fix a comment typo

Sep 4 2017, 4:47 PM
thakis updated the diff for D37452: lld-link: Add --rsp-quoting= flag.

Actually, I talked myself out of this affecting %LINK% / %_LINK_% while writing the patch summary. I removed that bit.

Sep 4 2017, 4:45 PM
thakis created D37452: lld-link: Add --rsp-quoting= flag.
Sep 4 2017, 4:36 PM

Aug 30 2017

thakis closed D37324: Suppress -Wdelete-non-virtual-dtor warnings _about_ classes defined in system headers..

312216, thanks!

Aug 30 2017, 11:18 PM
thakis created D37324: Suppress -Wdelete-non-virtual-dtor warnings _about_ classes defined in system headers..
Aug 30 2017, 7:29 PM
thakis closed D37235: Let -Wdelete-non-virtual-dtor fire in system headers too..

Thanks, landed in r312167.

Aug 30 2017, 1:28 PM

Aug 28 2017

thakis updated the diff for D37235: Let -Wdelete-non-virtual-dtor fire in system headers too..

Don't warn in unevaluated contexts. Ready for a look now.

Aug 28 2017, 3:33 PM
thakis created D37235: Let -Wdelete-non-virtual-dtor fire in system headers too..
Aug 28 2017, 3:08 PM

Aug 23 2017

thakis created D37090: Implement CFG construction for __finally..
Aug 23 2017, 6:35 PM
thakis closed D36914: Implement CFG construction for __try / __except / __leave..
Aug 23 2017, 8:35 AM

Aug 22 2017

thakis updated the diff for D36914: Implement CFG construction for __try / __except / __leave..

add test from rnk

Aug 22 2017, 4:57 PM

Aug 21 2017

thakis added inline comments to D36914: Implement CFG construction for __try / __except / __leave..
Aug 21 2017, 10:43 AM
thakis updated the diff for D36914: Implement CFG construction for __try / __except / __leave..

Just use TryTerminatedBlock

Aug 21 2017, 10:43 AM
thakis updated the summary of D36914: Implement CFG construction for __try / __except / __leave..
Aug 21 2017, 10:43 AM

Aug 18 2017

thakis created D36914: Implement CFG construction for __try / __except / __leave..
Aug 18 2017, 7:03 PM
thakis accepted D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure.

Many driver tests check in a basic representative directory structure (e.g. test/Driver/Inputs/basic_freebsd_tree/ and its many siblings).

Aug 18 2017, 6:49 PM
thakis added a comment to D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure.

This approach looks good to me.

Aug 18 2017, 7:41 AM
thakis added a comment to D36857: [Driver] Set linkPath and MSVT version when cl.exe is detected, plus STL's hacking..

Oh, I guess this is superseded by https://reviews.llvm.org/D36860 ?

Aug 18 2017, 7:39 AM
thakis added inline comments to D36857: [Driver] Set linkPath and MSVT version when cl.exe is detected, plus STL's hacking..
Aug 18 2017, 7:33 AM
thakis added a reviewer for D36857: [Driver] Set linkPath and MSVT version when cl.exe is detected, plus STL's hacking.: zturner.
Aug 18 2017, 7:33 AM

Aug 16 2017

thakis added inline comments to D36758: [LLD COFF / PDB] Incrementally update the BuildId when writing a PDB..
Aug 16 2017, 2:20 PM

Aug 14 2017

thakis updated the summary of D36481: /redundancyReport proof of concept.
Aug 14 2017, 12:05 PM
thakis updated the summary of D36481: /redundancyReport proof of concept.
Aug 14 2017, 12:01 PM
thakis updated the diff for D36481: /redundancyReport proof of concept.
Aug 14 2017, 11:58 AM
thakis updated the summary of D36481: /redundancyReport proof of concept.
Aug 14 2017, 11:58 AM
thakis updated the diff for D36481: /redundancyReport proof of concept.
Aug 14 2017, 11:55 AM

Aug 9 2017

thakis accepted D36526: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare.

Thanks!

Aug 9 2017, 1:56 PM

Aug 8 2017

thakis created D36481: /redundancyReport proof of concept.
Aug 8 2017, 12:28 PM
thakis closed D36413: Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name..

r310376, thanks!

Aug 8 2017, 9:22 AM

Aug 7 2017

thakis created D36413: Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name..
Aug 7 2017, 10:02 AM

Aug 4 2017

thakis added a comment to D36324: Integrate Kostya's clang-proto-fuzzer with LLVM..

Why should this be part of llvm? This seems to come with very heavy dependencies (protobuf), and LLVM has historically tried to minimize the number of things it depends on.

Aug 4 2017, 11:22 AM
thakis added a comment to D36191: [CodeGen] Don't make availability attributes imply default visibility on macos.

Is landing this blocked on internal testing?

Aug 4 2017, 7:22 AM
thakis added a comment to D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name..

Hm, that's unfortunate. I don't see a good way to rescue this patch.

Aug 4 2017, 7:14 AM

Aug 3 2017

thakis closed D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name..

309984.

Aug 3 2017, 2:07 PM
thakis added a comment to D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name..

I'm going to land this. It's early in the 6.0 cycle, so if this causes issues, we should have time to find them and then follow up in case we run into any.

Aug 3 2017, 2:06 PM
thakis closed D36281: Fix llvm-for-windows-on-linux build after LLVM r272701..

309980, thanks!

Aug 3 2017, 1:11 PM