Page MenuHomePhabricator

thakis (Nico Weber)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (331 w, 4 d)

Recent Activity

Today

thakis committed rGa7b9e98fd8e2: gn build: Merge r361264 (authored by thakis).
gn build: Merge r361264
Tue, May 21, 7:40 AM
thakis committed rG440dd6df339a: gn build: Run `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format` (authored by thakis).
gn build: Run `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format`
Tue, May 21, 7:23 AM
thakis committed rGe289e9883781: gn build: Merge r361252 (authored by thakis).
gn build: Merge r361252
Tue, May 21, 7:23 AM
thakis committed rG8287b973f0b5: gn build: Merge r361233 (authored by thakis).
gn build: Merge r361233
Tue, May 21, 7:09 AM

Yesterday

thakis committed rGc6f363f578fb: Tweaks for setting CMAKE_LINKER to lld-link (authored by thakis).
Tweaks for setting CMAKE_LINKER to lld-link
Mon, May 20, 8:01 PM
thakis closed D62111: Tweaks for setting CMAKE_LINKER to lld-link.
Mon, May 20, 8:00 PM · Restricted Project
thakis committed rG67510fac36d2: Revert r361206 "[COFF] Store alignment in log2 form, NFC" (authored by thakis).
Revert r361206 "[COFF] Store alignment in log2 form, NFC"
Mon, May 20, 7:05 PM
thakis committed rG4522e2669643: Try to fix build with older gccs after r361152 (authored by thakis).
Try to fix build with older gccs after r361152
Mon, May 20, 5:27 PM
thakis committed rG80efcdcdf882: gn build: Merge r361148 (authored by thakis).
gn build: Merge r361148
Mon, May 20, 12:33 PM
thakis added a comment to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.

Out of interest: The RecursiveASTVisitorTests are part of the ToolingTests binary while this adds a new binary TokensTest. Can you say why?

Mon, May 20, 12:21 PM · Restricted Project
thakis added a comment to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.

Another comment: The new binary is called TokensTest but is in a directory "Syntax". For consistency with all other unit test binaries, please either rename the binary to SyntaxTests, or rename the directory to "Tokens". (From the patch description, the former seems more appropriate.) Note the missing trailing "s" in the binary name too.

Mon, May 20, 12:21 PM · Restricted Project
thakis committed rG7fbbdfd91428: gn build: Merge r361152 (authored by thakis).
gn build: Merge r361152
Mon, May 20, 6:45 AM

Sun, May 19

thakis created D62111: Tweaks for setting CMAKE_LINKER to lld-link.
Sun, May 19, 5:55 PM · Restricted Project
thakis committed rGf61fa1d03866: gn build: Merge r361117 (authored by thakis).
gn build: Merge r361117
Sun, May 19, 5:51 PM

Sat, May 18

thakis accepted D62104: [crt] Use CMAKE_C_COMPILER_ARG1 in compiler invocation.

As said on IRC, a nicer fix would be to make clang-x86_64-debian-fast and friends use use CMAKE_C_COMPILER_LAUNCHER / CMAKE_CXX_COMPILER_LAUNCHER for ccache instead of setting CC / CXX – but it's also good to make the pre-cmake-3.4 way of configuring this work.

Sat, May 18, 8:27 PM · Restricted Project, Restricted Project
thakis added a comment to rL361073: Explicitly remove -stdlib=libc++, as we pass -nostdinc++ anyway. This should….

Any chance this could've caused the build breakage starting at http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/14855 ?

Sat, May 18, 10:13 AM

Fri, May 17

thakis added inline comments to D62060: Make libc++'s libc++abi discovery work in the monorepo layout.
Fri, May 17, 12:47 PM
thakis added inline comments to D62060: Make libc++'s libc++abi discovery work in the monorepo layout.
Fri, May 17, 12:33 PM
thakis added inline comments to D62060: Make libc++'s libc++abi discovery work in the monorepo layout.
Fri, May 17, 12:29 PM
thakis committed rGe4351bfa6788: gn build: Merge r360993 (authored by thakis).
gn build: Merge r360993
Fri, May 17, 11:36 AM
thakis committed rGe78ac9cc72c9: Revert r361033 "Add a Visit overload for DynTypedNode to ASTNodeTraverser" (authored by thakis).
Revert r361033 "Add a Visit overload for DynTypedNode to ASTNodeTraverser"
Fri, May 17, 11:29 AM
thakis committed rG10abc76fce38: gn build: Merge r361033 (authored by thakis).
gn build: Merge r361033
Fri, May 17, 10:34 AM
thakis committed rG762b3ef0785c: Attempt to fix test on Windows after r360998 (authored by thakis).
Attempt to fix test on Windows after r360998
Fri, May 17, 10:32 AM
thakis committed rG9da9ed535227: gn build: Merge r360991 (authored by thakis).
gn build: Merge r360991
Fri, May 17, 10:30 AM
thakis added a comment to D54747: Discard debuginfo for object files empty after GC.

For posterity, https://bugs.chromium.org/p/chromium/issues/detail?id=960881#c31 has the explanation for what exactly was happening in the Chromium/Android build. It's a bit different from rnk's example since no cross-TU imports are happening. It likely explains why rnk couldn't find an example that doesn't use thinlto though: To get the bug, you need to require debug info in a TU but all actual code of the TU needs to be stripped. In regular builds this can't happen, but in thinlto builds it can happen in several cases:

Fri, May 17, 9:05 AM · Restricted Project, lld
thakis added a comment to D61968: HWASan exception support..

The test added here doesn't pass on our bots. I filed https://bugs.llvm.org/show_bug.cgi?id=41923 for that.

Fri, May 17, 5:57 AM · Restricted Project, Restricted Project
thakis added a comment to D62060: Make libc++'s libc++abi discovery work in the monorepo layout.

The motivation here is being able to build libc++ against system libc++abi on macOS. We can explicitly define a few variables to get this to work, but with the old repo layout it Just Works. This is an attempt to make it just work with the monorepo layout as well.

Fri, May 17, 5:48 AM
thakis created D62060: Make libc++'s libc++abi discovery work in the monorepo layout.
Fri, May 17, 5:43 AM

Thu, May 16

thakis committed rG457d7caac822: Revert r360946 "Add Clang shared library with C++ exports" (authored by thakis).
Revert r360946 "Add Clang shared library with C++ exports"
Thu, May 16, 6:42 PM
thakis added a comment to D54747: Discard debuginfo for object files empty after GC.

echristo's comments on the mail thread for this didn't make it to phab. I apologize for repeating more or less everything he said, I had looked on phab before reading email.

Thu, May 16, 6:03 PM · Restricted Project, lld
thakis added a comment to D54747: Discard debuginfo for object files empty after GC.

Thanks for the revert!

Thu, May 16, 5:58 PM · Restricted Project, lld
thakis committed rGd764e7c6601f: Revert r360859: "Reland r360771 "[MergeICmps] Simplify the code."" (authored by thakis).
Revert r360859: "Reland r360771 "[MergeICmps] Simplify the code.""
Thu, May 16, 5:42 PM
thakis added a comment to D54747: Discard debuginfo for object files empty after GC.

This breaking both debug info in thinlto builds and fmodules-debuginfo is probably enough to revert and go back to the drawing board.

Thu, May 16, 2:29 PM · Restricted Project, lld
thakis accepted D62020: [zorg] Build and test LLVM with GN.

Having a bot for this is great, under these conditions:

  • It doesn't send email to regular contributors when it goes red (it can email you and me and others who'd like to opt in)
  • It doesn't show up on http://lab.llvm.org:8011/console
Thu, May 16, 11:57 AM

Wed, May 15

thakis committed rGdbc01b4fdc8e: gn build: Merge r360671 (authored by thakis).
gn build: Merge r360671
Wed, May 15, 5:08 AM
thakis committed rG0a5efc28dba5: gn build: Run `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format` (authored by thakis).
gn build: Run `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format`
Wed, May 15, 5:04 AM

Tue, May 14

thakis added inline comments to D61821: gn build: add RISCV target.
Tue, May 14, 5:49 AM · Restricted Project
thakis committed rG2e9591c23a93: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools (authored by thakis).
Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools
Tue, May 14, 5:31 AM
thakis updated the diff for D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools.

minor tweaks for landing

Tue, May 14, 5:29 AM · Restricted Project

Mon, May 13

thakis added a comment to D61821: gn build: add RISCV target.

Actually, "the first comment below" – phab showed them in a different order in the preview. I meant this comment: https://reviews.llvm.org/D61821#inline-549166

Mon, May 13, 10:17 AM · Restricted Project
thakis accepted D61819: gn build: add Hexagon target.

Like with the Lanai target: lgtm with the usual two comments (1. https://reviews.llvm.org/D61859 treatment for MCTargetDesc; 2. Consider omitting unused llvm_build_Hexago variable)

Mon, May 13, 10:08 AM · Restricted Project
thakis accepted D61818: gn build: add Lanai target.

lgtm with the usual two comments (1. https://reviews.llvm.org/D61859 treatment for MCTargetDesc; 2. Consider omitting unused llvm_build_Lanai variable)

Mon, May 13, 10:06 AM · Restricted Project
thakis closed D61859: gn build: Fewer dependencies in llvm/lib/Target.

Landed in r360600, but forgot to add "Differential Revision:" line to commit message :/

Mon, May 13, 10:02 AM · Restricted Project
thakis abandoned D61710: lld: Add a warning limit, similar to the existing error limit.

I'll abandon this for now, since as said above it doesn't address the use case as I have, and I agree with Rui that it feels like the wrong approach. If I find time, I'll try to make a CL to make /force warnings ignorable.

Mon, May 13, 10:00 AM · Restricted Project
thakis committed rG69a3f9e4656b: gn build: Fewer dependencies in llvm/lib/Target (authored by thakis).
gn build: Fewer dependencies in llvm/lib/Target
Mon, May 13, 10:00 AM
thakis accepted D61820: gn build: add Sparc target.

Nice!

Mon, May 13, 9:59 AM · Restricted Project
thakis added a comment to D61821: gn build: add RISCV target.

Awesome, thanks! Just one real question, the last comment below:

Mon, May 13, 9:56 AM · Restricted Project
thakis created D61859: gn build: Fewer dependencies in llvm/lib/Target.
Mon, May 13, 9:46 AM · Restricted Project
thakis committed rGeadbde32db2f: gn build: Merge r360572 (authored by thakis).
gn build: Merge r360572
Mon, May 13, 9:14 AM
thakis added a comment to D60963: Fix dereferencing null pointer.

Add a test that fails without the code change and that passes with it. I don't know under which conditions this change is needed, so I apologize that I can't make a more concrete suggestion.

Mon, May 13, 7:39 AM · Restricted Project, Restricted Project

Sun, May 12

thakis committed rGd1059e3331cf: gn build: Merge r360540 (authored by thakis).
gn build: Merge r360540
Sun, May 12, 4:47 PM

Fri, May 10

thakis added inline comments to D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools.
Fri, May 10, 6:38 PM · Restricted Project
thakis updated the diff for D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools.

comments

Fri, May 10, 6:38 PM · Restricted Project
thakis added inline comments to D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools.
Fri, May 10, 12:35 PM · Restricted Project
thakis updated the diff for D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools.

Now with more boilerplate!

Fri, May 10, 12:33 PM · Restricted Project
thakis accepted D61797: [crt] Use -std=c11 for crtbegin.o/crtend.o.

lgtm, but shouldn't we set this globally for all projects?

Fri, May 10, 12:06 PM · Restricted Project, Restricted Project
thakis created D61788: Make getObjCEncodingForTypeImpl() take a bitmask instead of 8 bools.
Fri, May 10, 8:17 AM · Restricted Project
thakis added a comment to D61726: [Pass Pipeline] Run another round of reassociation after loop pipeline.

Looks like the new test is failing: http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/9439/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Areassociate-after-unroll.ll

Fri, May 10, 7:19 AM · Restricted Project
thakis committed rG37dc0ced7a10: Fix some gcc warnings in compiler-rt (authored by thakis).
Fix some gcc warnings in compiler-rt
Fri, May 10, 7:15 AM
thakis added inline comments to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Fri, May 10, 7:11 AM · Restricted Project, Restricted Project
thakis committed rGdf12933d918e: Add name comments for bools passed to getObjCEncodingForTypeImpl() (authored by thakis).
Add name comments for bools passed to getObjCEncodingForTypeImpl()
Fri, May 10, 6:55 AM

Thu, May 9

thakis committed rG82e68f5d6a27: gn build: Merge r960255 (authored by thakis).
gn build: Merge r960255
Thu, May 9, 7:12 AM

Wed, May 8

thakis added a comment to D61710: lld: Add a warning limit, similar to the existing error limit.

I'm not confident that this is what the user wants. This might be useful, but at the same time I can imagine that people want to see an entire log rather than the first part of it.

Does clang or other tools have a similar feature?

Wed, May 8, 8:38 PM · Restricted Project
thakis created D61710: lld: Add a warning limit, similar to the existing error limit.
Wed, May 8, 6:15 PM · Restricted Project
thakis added a comment to D54747: Discard debuginfo for object files empty after GC.

That problem only seems to happen when (thin) lto is enabled.

Wed, May 8, 12:42 PM · Restricted Project, lld
thakis added a comment to D61646: Include corecrt.h/vcruntime.h to improve MS compatibility.

I agree with that.

Wed, May 8, 12:32 PM · Restricted Project
thakis added a comment to D54747: Discard debuginfo for object files empty after GC.

Hello, in a bit of a https://xkcd.com/1172/ moment this breaks the chromium/android build. We have a list of "resources" (strings, bitmaps, etc) that we list in an XML file which then generates a header with lots of "IDR_foo" constants. As it turns out, now all of these resources are used on all platforms, so we use the following technique to only keep the ones actually used on android:

Wed, May 8, 12:24 PM · Restricted Project, lld
thakis added a comment to D61646: Include corecrt.h/vcruntime.h to improve MS compatibility.

Did I get the bug right that this adds almost 400kB to every file that includes stddef.h?

Wed, May 8, 11:37 AM · Restricted Project
thakis committed rGa3ff5727b78f: [compiler-rt] Make builtins test pass when using i386 gcc as host compiler (authored by thakis).
[compiler-rt] Make builtins test pass when using i386 gcc as host compiler
Wed, May 8, 8:51 AM
thakis created D61684: [compiler-rt] Make builtins test pass when using i386 gcc as host compiler.
Wed, May 8, 8:40 AM · Restricted Project
thakis committed rGcc433095f29c: gn build: Merge r360151 (authored by thakis).
gn build: Merge r360151
Wed, May 8, 6:41 AM

Tue, May 7

thakis committed rG4b81e9f8d102: lld-link: Allow /? as option prefix, like -? is allowed (authored by thakis).
lld-link: Allow /? as option prefix, like -? is allowed
Tue, May 7, 7:15 AM
thakis committed rG54743d5767f0: Add typo correction for command-line flags to ELF and COFF lld drivers (authored by thakis).
Add typo correction for command-line flags to ELF and COFF lld drivers
Tue, May 7, 6:49 AM
thakis committed rG7399ad31931d: minor cmake formatting style fix (authored by thakis).
minor cmake formatting style fix
Tue, May 7, 6:15 AM
thakis committed rG719a9aed0598: gn build: Merge r360116 (authored by thakis).
gn build: Merge r360116
Tue, May 7, 6:06 AM
thakis committed rGf8759e499cf4: gn build: Run `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format` (authored by thakis).
gn build: Run `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format`
Tue, May 7, 6:01 AM

Mon, May 6

thakis committed rGa2e23f682afb: gn build: More TODO tweaking (authored by thakis).
gn build: More TODO tweaking
Mon, May 6, 10:17 AM
thakis committed rGb2fe1a8f59ee: gn build: Update TODO now that libcxx libcxxabi libunwind clang-tools-extra are… (authored by thakis).
gn build: Update TODO now that libcxx libcxxabi libunwind clang-tools-extra are…
Mon, May 6, 10:14 AM
thakis committed rGf0540a9e4ea0: gn build: Merge r360018 (authored by thakis).
gn build: Merge r360018
Mon, May 6, 8:05 AM

Fri, May 3

thakis accepted D61542: [Driver] Create non-existent directory for -fcrash-diagnostics-dir.
Fri, May 3, 5:18 PM · Restricted Project, Restricted Project
thakis added a comment to D61468: gn build: Update TODO now that libcxx libcxxabi libunwind clang-tools-extra are done.

Are you going to work on those tests?

Fri, May 3, 5:02 PM · Restricted Project
thakis added a comment to D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5.

Thanks for the context. Sounds great :)

Fri, May 3, 12:00 PM · Restricted Project, Restricted Project
thakis committed rG83c95b1ec80d: Attempt to fix the clang-sphinx-docs bot after r358797 (authored by thakis).
Attempt to fix the clang-sphinx-docs bot after r358797
Fri, May 3, 11:54 AM
thakis committed rGbb852a96723a: Revert r359906, "RegAllocFast: Add heuristic to detect values not live-out of a… (authored by thakis).
Revert r359906, "RegAllocFast: Add heuristic to detect values not live-out of a…
Fri, May 3, 11:07 AM
thakis added a comment to D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5.

I happened to see this go by. Is there an explanation of the overall goal somewhere? In general, requiring -- for long flags sounds like a great change to me, but there are a few exceptions: For example. lld-link should keep accepting long flags with a single dash for link.exe compatibility.

Fri, May 3, 10:59 AM · Restricted Project, Restricted Project
thakis committed rG30649ce09bd5: Mark is_trivially_destructible as unsupported with apple-clang-9 (authored by thakis).
Mark is_trivially_destructible as unsupported with apple-clang-9
Fri, May 3, 10:25 AM
thakis added a comment to D48292: use modern type trait implementations when available.

Done in r359907, thanks!

Fri, May 3, 10:24 AM
thakis added a comment to D48292: use modern type trait implementations when available.

This test is broken with Xcode 9:

Fri, May 3, 9:53 AM
thakis committed rGe04167343222: gn build: Merge r359878 (authored by thakis).
gn build: Merge r359878
Fri, May 3, 7:27 AM

Thu, May 2

thakis committed rGecc969caf9fd: Revert r359814 "[Sema] Emit warning for visibility attribute on internal… (authored by thakis).
Revert r359814 "[Sema] Emit warning for visibility attribute on internal…
Thu, May 2, 8:14 PM
thakis closed D60733: [gn] Include PatternInit.cpp..

Merged by now.

Thu, May 2, 8:09 PM · Restricted Project
thakis closed D61456: [gn] Update the clangd test lit site configuration.

This landed in r359825.

Thu, May 2, 8:08 PM · Restricted Project, Restricted Project
thakis closed D61465: lld-link: Add /force:multipleres extension to make dupe resource diag non-fatal.

r359829; forgot to put "Differential Revision" in the commit message :/

Thu, May 2, 3:01 PM · Restricted Project
thakis created D61468: gn build: Update TODO now that libcxx libcxxabi libunwind clang-tools-extra are done.
Thu, May 2, 2:34 PM · Restricted Project
thakis committed rG81862f82ee3d: lld-link: Add /force:multipleres extension to make dupe resource diag non-fatal (authored by thakis).
lld-link: Add /force:multipleres extension to make dupe resource diag non-fatal
Thu, May 2, 2:20 PM
thakis accepted D61462: [gn] Include the missing BUILD.gn file for libcxxabi includes.
Thu, May 2, 2:06 PM · Restricted Project
thakis created D61465: lld-link: Add /force:multipleres extension to make dupe resource diag non-fatal.
Thu, May 2, 2:04 PM · Restricted Project
thakis committed rG55ef9a1078e1: Another attempt to fix "could not find clang-check" lit warning in analyzer… (authored by thakis).
Another attempt to fix "could not find clang-check" lit warning in analyzer…
Thu, May 2, 12:46 PM
thakis accepted D61456: [gn] Update the clangd test lit site configuration.
Thu, May 2, 12:36 PM · Restricted Project, Restricted Project
thakis added a comment to D61456: [gn] Update the clangd test lit site configuration.

Thanks! This is incomplete:

  • Create clangd_lit_site_cfg_files.gni next to this build file, but path to generated files there
  • Edit llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn and add remapping there
Thu, May 2, 11:57 AM · Restricted Project, Restricted Project