Page MenuHomePhabricator

thakis (Nico Weber)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (348 w, 2 d)

Recent Activity

Yesterday

thakis committed rGc7d8cc48c139: lld-link: Make Options.td formatting more self-consistent. (authored by thakis).
lld-link: Make Options.td formatting more self-consistent.
Sat, Sep 14, 4:41 PM
thakis committed rG34b6f49c2ca4: compiler-rt/builtins: Make check-builtins run tests on macOS. (authored by thakis).
compiler-rt/builtins: Make check-builtins run tests on macOS.
Sat, Sep 14, 3:22 PM

Fri, Sep 13

thakis added inline comments to D67542: Fix depfile name construction.
Fri, Sep 13, 6:34 PM · Restricted Project, Restricted Project
thakis committed rGbb69208df851: Fix a few spellos in docs. (authored by thakis).
Fix a few spellos in docs.
Fri, Sep 13, 7:58 AM
thakis committed rGe7e8b51b0314: gn build: pacify "gn format" after 371102 (authored by thakis).
gn build: pacify "gn format" after 371102
Fri, Sep 13, 7:38 AM
thakis updated the diff for D66984: compiler-rt/builtins: Make check-builtins run tests on macOS..

smaller diff

Fri, Sep 13, 7:29 AM · Restricted Project
thakis committed rG41f4d68a50be: clang-format: Add support for formatting (some) lambdas with explicit template… (authored by thakis).
clang-format: Add support for formatting (some) lambdas with explicit template…
Fri, Sep 13, 6:20 AM
thakis closed D67246: clang-format: Add support for formatting lambdas with explicit template parameters..
Fri, Sep 13, 6:20 AM · Restricted Project
thakis committed rGd48ea5da9416: lld-link: Add a flag /lldignoreenv that makes lld-link ignore env vars. (authored by thakis).
lld-link: Add a flag /lldignoreenv that makes lld-link ignore env vars.
Fri, Sep 13, 6:14 AM
thakis committed rG67503ba556cd: gn build: (manually) merge r371834, take 2 (authored by thakis).
gn build: (manually) merge r371834, take 2
Fri, Sep 13, 6:07 AM
thakis committed rGd4604e057883: Revert "gn build: (manually) merge r371834" (authored by thakis).
Revert "gn build: (manually) merge r371834"
Fri, Sep 13, 6:05 AM
thakis added a reverting change for rGabc7e2b6004c: gn build: (manually) merge r371834: rGd4604e057883: Revert "gn build: (manually) merge r371834".
Fri, Sep 13, 6:05 AM
thakis committed rGabc7e2b6004c: gn build: (manually) merge r371834 (authored by thakis).
gn build: (manually) merge r371834
Fri, Sep 13, 6:00 AM
thakis committed rG902e553359ee: gn build: Merge r371822 (authored by thakis).
gn build: Merge r371822
Fri, Sep 13, 6:00 AM
thakis committed rGb6f4a7a107ee: gn build: (manually) merge r371787 (authored by thakis).
gn build: (manually) merge r371787
Fri, Sep 13, 6:00 AM
thakis added inline comments to D66775: [libclang] Expose abort()-ing fatal error handler.
Fri, Sep 13, 5:32 AM · Restricted Project

Thu, Sep 12

thakis added a comment to D66984: compiler-rt/builtins: Make check-builtins run tests on macOS..

What's the next step here?

Thu, Sep 12, 3:56 PM · Restricted Project
thakis added a comment to D67457: lld-link: Make Options.td formatting more self-consistent..

Thanks for taking a look!

Thu, Sep 12, 3:55 PM · Restricted Project
thakis accepted D52524: Add -Wpoison-system-directories warning.
Thu, Sep 12, 2:32 PM · Restricted Project
thakis committed rGd0c800489044: lld-link: Fix tests that do not run on macOS after r371729. (authored by thakis).
lld-link: Fix tests that do not run on macOS after r371729.
Thu, Sep 12, 5:36 AM
thakis committed rG3c44d595be1e: lld-link: Make /linkrepro: take a filename, not a directory. (authored by thakis).
lld-link: Make /linkrepro: take a filename, not a directory.
Thu, Sep 12, 4:45 AM
thakis added a comment to D67461: lld-link: Make /linkrepro: take a filename, not a directory..

Nice!

But is there no help text or user manual that needs to be updated?

Thu, Sep 12, 4:39 AM · Restricted Project

Wed, Sep 11

thakis accepted D67463: [MS] Warn when shadowing template parameters under -fms-compatibility.

Hopefully this is rare enough that putting it under an existing warning flag won't be too inconvenient.

Wed, Sep 11, 8:01 PM · Restricted Project, Restricted Project
thakis committed rG52f6131cc7e6: gn build: Merge r371700 (authored by thakis).
gn build: Merge r371700
Wed, Sep 11, 6:26 PM
thakis committed rG9769a5e7d579: gn build: Merge r371661 (authored by thakis).
gn build: Merge r371661
Wed, Sep 11, 2:25 PM
thakis committed rGefbd7371a028: gn build: Merge r371657 (authored by thakis).
gn build: Merge r371657
Wed, Sep 11, 2:25 PM
thakis created D67461: lld-link: Make /linkrepro: take a filename, not a directory..
Wed, Sep 11, 12:52 PM · Restricted Project
thakis created D67457: lld-link: Make Options.td formatting more self-consistent..
Wed, Sep 11, 12:30 PM · Restricted Project
thakis created D67456: lld-link: Add a flag /lldignoreenv that makes lld-link ignore env vars..
Wed, Sep 11, 12:13 PM · Restricted Project
thakis added a comment to D67246: clang-format: Add support for formatting lambdas with explicit template parameters..

Do you think this should land with the comment FIXME for now? It improves formatting of this language feature when that heuristic is not used, and changing the heuristic is independent of the rest of this patch.

Wed, Sep 11, 10:56 AM · Restricted Project
thakis committed rG85eff49d7488: gn build: Merge r371635 (authored by thakis).
gn build: Merge r371635
Wed, Sep 11, 9:28 AM
thakis committed rGb42565f2fc76: gn build: Merge r371562 (authored by thakis).
gn build: Merge r371562
Wed, Sep 11, 7:40 AM
thakis added a comment to D65026: [Bugpoint redesign] Added pass to reduce Metadata.

The test added in this change has a file leak that causes all possible temp file patterns to be created, at which point it starts failing, see https://bugs.llvm.org/show_bug.cgi?id=43278 (Diego, I tried to cc you, but bugzilla didn't know your email address.) Can you please take a look, and revert if it takes a while to investigate? (remove-funcs seems to have the same problem.)

Wed, Sep 11, 7:38 AM · Restricted Project
thakis committed rGf78474ba8aeb: gn build: add include_dir that's necessary after r371564 (authored by thakis).
gn build: add include_dir that's necessary after r371564
Wed, Sep 11, 5:21 AM
thakis added inline comments to rL368358: Added Delta IR Reduction Tool.
Wed, Sep 11, 5:19 AM
thakis added a comment to D67287: [Diagnostics] Add -Wsizeof-array-div.

Did you collect metrics on number of true/false positives of this warning?

Wed, Sep 11, 5:01 AM · Restricted Project

Tue, Sep 10

thakis added a comment to D59754: [Sema] Add c++2a designated initializer warnings.

Another question about this, sorry. Do you know _why_ C++20 is more restrictive than C99 wrt "mixture of designated and non-designated initializers in the same initializer list is a C99 extension"? Is there some interaction with other C++ features that makes the C99 behavior difficult in C++20?

Tue, Sep 10, 6:56 PM · Restricted Project, Restricted Project
thakis updated the diff for D67246: clang-format: Add support for formatting lambdas with explicit template parameters..

fix nits

Tue, Sep 10, 12:53 PM · Restricted Project
thakis added a comment to D67246: clang-format: Add support for formatting lambdas with explicit template parameters..

Thanks for the thorough review! Indeed, this still gets []<bool b = true && false>(A &&a){}(); wrong, for the reason you mention.

Tue, Sep 10, 12:53 PM · Restricted Project
thakis added a comment to D67262: [git-llvm] Do not reinvent `@{upstream}`.

I don't know what the long-term plans for this script are. I don't have a strong opinion, but weakly agree that it'd be good if it went away. In that case, I personally wouldn't add a warning and just make it temporarily do the (usually :P) right thing of using origin/master as upstream if there's no explicit upstream. If there's a warning however, it'd be nice if it included git checkout -b myNewBranch origin/master as suggested command to run, since I found that difficult to find. (Thanks for mentioning it!)

Tue, Sep 10, 12:37 PM · Restricted Project
thakis added a comment to D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI.

We have the old TODO of changing this warning to be emitted at enum use time (e.g. when Foo_Val is compared to 0) instead of declaration time. Maybe that's a better fix. Or is implementing that very involved?

Tue, Sep 10, 7:38 AM · Restricted Project, Restricted Project
thakis added a comment to D67262: [git-llvm] Do not reinvent `@{upstream}`.

PS – Hi @thakis. I think it is unfair and incorrect to say that "nobody noticed" that the existing behavior was problematic. I noticed. And I'd wager others did also. That being said, the kinds of people that would notice that "origin" is hardcoded into git-llvm also tend to be the kinds of people that can workaround this git-llvm bug until they get tired of doing so and submit a patch.

Tue, Sep 10, 5:08 AM · Restricted Project

Mon, Sep 9

thakis committed rG88d6783f708e: gn build: Merge r371488 (authored by thakis).
gn build: Merge r371488
Mon, Sep 9, 11:34 PM
thakis committed rGa6e5a7b63747: gn build: Merge r371484 (authored by thakis).
gn build: Merge r371484
Mon, Sep 9, 8:19 PM
thakis committed rG939614341227: gn build: Merge r371466 (authored by thakis).
gn build: Merge r371466
Mon, Sep 9, 6:11 PM
thakis committed rGfcbc512f80a9: gn build: (manually) merge r371429 (authored by thakis).
gn build: (manually) merge r371429
Mon, Sep 9, 5:48 PM
thakis added a comment to D67262: [git-llvm] Do not reinvent `@{upstream}`.

To add some more words, previously we could git checkout -b foo, hack a bit commit, and run this script. Now this requires additional, long flags. I don't think making a corner case work that nobody noticed being broken for many months is worth making everything more inconvenient for everyone.

Mon, Sep 9, 5:48 PM · Restricted Project
thakis added a comment to D67262: [git-llvm] Do not reinvent `@{upstream}`.

Similar to leonardchan, this broke my workflow too. Please don't break user's workflows. If there's no good fix for this, I think this should be reverted.

Mon, Sep 9, 5:44 PM · Restricted Project

Fri, Sep 6

thakis committed rG06487b010d48: libclang depends on ClangDriverOptions since r352803 (authored by thakis).
libclang depends on ClangDriverOptions since r352803
Fri, Sep 6, 6:59 AM
thakis committed rG8455294f2ac1: Revert r370635, it caused PR43241. (authored by thakis).
Revert r370635, it caused PR43241.
Fri, Sep 6, 6:23 AM
thakis committed rG68df9dc09818: gn build: Merge r371182 (authored by thakis).
gn build: Merge r371182
Fri, Sep 6, 2:47 AM
thakis committed rG3dbb5c7e8872: gn build: Merge r371179 (authored by thakis).
gn build: Merge r371179
Fri, Sep 6, 2:47 AM

Thu, Sep 5

thakis committed rGb1cf17527182: gn build: Merge r371159 (authored by thakis).
gn build: Merge r371159
Thu, Sep 5, 6:24 PM
thakis created D67246: clang-format: Add support for formatting lambdas with explicit template parameters..
Thu, Sep 5, 5:06 PM · Restricted Project
thakis committed rG3e144ab7fd0f: gn build: Merge r371134 (authored by thakis).
gn build: Merge r371134
Thu, Sep 5, 3:41 PM
thakis added a comment to D66984: compiler-rt/builtins: Make check-builtins run tests on macOS..

delcypher, kubamracek: Would you prefer if someone else looked at this?

Thu, Sep 5, 3:38 PM · Restricted Project
thakis committed rGa47dc841cd6c: Implement Microsoft-compatible mangling for decomposition declarations. (authored by thakis).
Implement Microsoft-compatible mangling for decomposition declarations.
Thu, Sep 5, 2:08 PM
thakis committed rG36b0571d2115: gn build: Merge r371121 (authored by thakis).
gn build: Merge r371121
Thu, Sep 5, 1:59 PM
thakis committed rG1d138a47e21a: gn build: Merge r371117 (authored by thakis).
gn build: Merge r371117
Thu, Sep 5, 1:38 PM
thakis accepted D67202: Implement Microsoft-compatible mangling for decomposition declarations..

Re llvm-undname: That seems to match behavior of MSVC's undname, so I'd say that's all good :)

Thu, Sep 5, 12:16 PM · Restricted Project, Restricted Project
thakis accepted D67228: [llvm-readobj][yaml2obj] Support SHT_LLVM_SYMPART, SHT_LLVM_PART_EHDR and SHT_LLVM_PART_PHDR.
Thu, Sep 5, 12:11 PM · Restricted Project
thakis committed rGf6400e75ebd4: gn build: Merge r371103 (authored by thakis).
gn build: Merge r371103
Thu, Sep 5, 11:17 AM
thakis committed rG1465a40cf80f: gn build: (manually) merge r358706 (authored by thakis).
gn build: (manually) merge r358706
Thu, Sep 5, 11:05 AM
thakis committed rGce7a37291d41: gn build: (manually) merge r371003 (authored by thakis).
gn build: (manually) merge r371003
Thu, Sep 5, 10:23 AM
thakis added inline comments to rL371003: Revert "Revert "[builtins] Rounding mode support for addxf3/subxf3"".
Thu, Sep 5, 10:23 AM

Wed, Sep 4

thakis added a comment to D67202: Implement Microsoft-compatible mangling for decomposition declarations..

ps: Thanks for the patch, this is great :)

Wed, Sep 4, 5:41 PM · Restricted Project, Restricted Project
thakis added a comment to D67202: Implement Microsoft-compatible mangling for decomposition declarations..

Does this pass ninja check-clang? If so, can you add a test for the new mangling, based on the manglings in the godbolt example? See clang/test/CodeGenCXX/mangle-ms-* for many examples; a new file mangle-ms-cxx20.cpp might be appropriate here. You can run bin/llvm-lit -vv clang/test/CodeGenCXX/foo.cpp to run a single lit test for iterating on the local test.

Wed, Sep 4, 5:41 PM · Restricted Project, Restricted Project
thakis committed rG44ca0c55f0df: gn build: Merge r370985 (authored by thakis).
gn build: Merge r370985
Wed, Sep 4, 2:37 PM
thakis added inline comments to D66825: [10/10] [LLD] [COFF] Implement MinGW default manifest handling.
Wed, Sep 4, 9:05 AM · Restricted Project
thakis accepted D66825: [10/10] [LLD] [COFF] Implement MinGW default manifest handling.

Looks horrible, please commit :)

Wed, Sep 4, 6:15 AM · Restricted Project
thakis committed rGe7befecc4211: gn build: Merge r370862 (authored by thakis).
gn build: Merge r370862
Wed, Sep 4, 4:11 AM
thakis committed rG5bfe8b562ffb: gn build: Merge r370843 (authored by thakis).
gn build: Merge r370843
Wed, Sep 4, 12:41 AM

Tue, Sep 3

thakis added inline comments to D66825: [10/10] [LLD] [COFF] Implement MinGW default manifest handling.
Tue, Sep 3, 10:34 AM · Restricted Project
thakis added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Tue, Sep 3, 6:19 AM · Restricted Project
thakis committed rG600f5c572723: gn build: (manually) merge r370499 (authored by thakis).
gn build: (manually) merge r370499
Tue, Sep 3, 6:17 AM
thakis added inline comments to D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool..
Tue, Sep 3, 6:11 AM · Restricted Project
thakis committed rG5f9aea72d6ff: gn build: Merge r370746 (authored by thakis).
gn build: Merge r370746
Tue, Sep 3, 6:01 AM
thakis added a comment to D67039: [ELF] Add a spell corrector for "undefined symbol" diagnostics.

For this to fire and be a true positive, you'd have to have an incorrect declaration but a correct definition of a function. I can't remember ever running into this – and the compiler seems to be in a better place to print a diagnostic for this case in almost all cases (except for if the TU with the correct definition doesn't happen to see the incorrect declaration).

The file that provides the definition may have a mismatch of the declaration and the definition, e.g.

Tue, Sep 3, 4:32 AM · Restricted Project

Mon, Sep 2

thakis added a comment to D67039: [ELF] Add a spell corrector for "undefined symbol" diagnostics.

This is a cool idea, but I'm struggling to come up with a scenario where it's actually useful :)

Mon, Sep 2, 6:31 PM · Restricted Project
thakis added a comment to D66711: [clang] Warning for non-final classes with final destructors.

This is a cool warning. Could the note have a fixit attached to it, so that it's easy to mass-clean-up the warning automatically?

Mon, Sep 2, 3:18 PM · Restricted Project, Restricted Project

Sat, Aug 31

thakis committed rGa627bd3a0255: [libc++] Fix directory_iterator compilation on Win32 (authored by thakis).
[libc++] Fix directory_iterator compilation on Win32
Sat, Aug 31, 4:19 PM

Fri, Aug 30

thakis committed rGb83b4e94056a: gn build: Merge r370512 (authored by thakis).
gn build: Merge r370512
Fri, Aug 30, 1:07 PM
thakis added a comment to D66984: compiler-rt/builtins: Make check-builtins run tests on macOS..

delcypher, kubamracek : ping.

Fri, Aug 30, 12:51 PM · Restricted Project
thakis committed rG7b832322dfe6: gn build: Merge r370500 (authored by thakis).
gn build: Merge r370500
Fri, Aug 30, 11:57 AM
thakis committed rG9976a5bc1db5: gn build: Merge r370490 (authored by thakis).
gn build: Merge r370490
Fri, Aug 30, 10:30 AM
thakis committed rG629f92156857: gn build: Merge r370441 (authored by thakis).
gn build: Merge r370441
Fri, Aug 30, 1:28 AM

Thu, Aug 29

thakis created D66984: compiler-rt/builtins: Make check-builtins run tests on macOS..
Thu, Aug 29, 5:25 PM · Restricted Project
thakis added a comment to D66980: [Windows] Disable TrapUnreachable for Win64, add SEH_NoReturn.

Why expand to int3 instead of nop?

Thu, Aug 29, 4:30 PM · Restricted Project
thakis resigned from D66825: [10/10] [LLD] [COFF] Implement MinGW default manifest handling.

There are enough highly capable reviewers actively looking at this; resigning from this one :)

Thu, Aug 29, 3:32 PM · Restricted Project
thakis accepted D66824: [09/10] [LLD] [COFF] Support merging resource object files.

lgtm, with a suggestion for an (I think?) missing test:

Thu, Aug 29, 2:04 PM · Restricted Project
thakis added a comment to D66824: [09/10] [LLD] [COFF] Support merging resource object files.

I'd vote for not running complicated code unless we have to, so I'd keep this MinGW only.

TBH it's not all that complicated, but in any case, none of that code should run in the cases that are currently supported anyway. It's just choosing between if you want to keep the error, to keep matching link.exe, or be more tolerant and support multiple resource objects even for non-MinGW setups.

Thu, Aug 29, 1:46 PM · Restricted Project
thakis added a comment to D66964: Sort Java imports without newline.

Making the tests in this patch pass sounds good to me too :)

Thu, Aug 29, 1:41 PM · Restricted Project
thakis accepted D66820: [06/10] [COFF] Add a ResourceSectionRef method for getting resource contents.

lgtm, nice.

Thu, Aug 29, 1:37 PM · Restricted Project
thakis accepted D66821: [07/10] [WindowsResource] Avoid duplicating the input filenames for each resource. NFC..
Thu, Aug 29, 1:33 PM · Restricted Project
thakis accepted D66823: [08/10] [WindowsResource] Remove use of global variables in WindowsResourceParser.

Nice!

Thu, Aug 29, 1:32 PM · Restricted Project
thakis added a comment to D66824: [09/10] [LLD] [COFF] Support merging resource object files.

I'd vote for not running complicated code unless we have to, so I'd keep this MinGW only.

Thu, Aug 29, 1:31 PM · Restricted Project
thakis added inline comments to D66959: Update libc++ release notes.
Thu, Aug 29, 10:57 AM · Restricted Project
thakis accepted D66948: [CodeGen]: fix error message for "=r" asm constraint.
Thu, Aug 29, 8:16 AM · Restricted Project, Restricted Project

Wed, Aug 28

thakis added a comment to D66831: [ObjC] Fix type checking for qualified id block parameters..

Yes, that makes sense, thanks.

Wed, Aug 28, 7:06 PM · Restricted Project
thakis added a comment to D66831: [ObjC] Fix type checking for qualified id block parameters..

We're getting a bunch of errors looking like ../../AppsListViewController.m:11:37: error: incompatible block pointer types assigning to 'void (^)(__strong id<AppCellProtocol>)' from 'void (^)(AppCollectionViewCell *__strong)' on code that looks fairly harmless to me. It looks something like this:

Wed, Aug 28, 4:32 PM · Restricted Project