- User Since
- Jan 10 2013, 2:43 PM (305 w, 3 d)
fix a comment
Fri, Nov 16
Thu, Nov 15
rename toolchain to "unix"
Tue, Nov 13
Thanks for the thorough review! I replied "not needed yet" to several items, I hope that's fine.
Mon, Nov 12
Sun, Nov 11
Fri, Nov 9
zero symlinks, in exchange for longer gen command
fix bad exec_script_whitelist default
just one symlink
Wed, Oct 31
Thu, Oct 25
Comment from the peanut gallery:
- I like the whitelist model for gcc-style flags. It allows us to curate them (and /? output) since many don't make much sense in the cl world.
- I like the idea behind this patch (and /clang: seems like a good spelling)
Wed, Oct 24
Oct 19 2018
Thanks for the fix! Do you happen to know what had regressed this?
Oct 9 2018
add requested comment
Thanks for the fast review! All done.
Oct 5 2018
It looks like you ran clang-format on all of lib/Sema/SemaExpr.cpp and changed many lines that are irrelevant to your patch. Can you undo that, please?
forgot to regen diff after latest changes, sorry.
Thanks! Will land with tweaked comment.
Oct 4 2018
krasimir, do you do clang-format reviews these days? If not, do you know who does?
Oct 3 2018
add warning test
Oct 2 2018
Looks good. If this is passed and we invoke lld-link, should we give that a similar flag and pass that to lld-link as well? I think link.exe also prints its outputs.
Sep 28 2018
Sep 26 2018
Sounds great, thanks!
Sep 25 2018
Actually, trying this out with MSVC, I don't see any __chkstk calls with /O1, or with eg. /Gs1 for that matter:
Maybe file a bug on figuring out the /Gs story and add a FIXME linking to it. Weird.
Sep 24 2018
...and to reword this a bit: Clang taking a long time to start up in some configurations is a bug we should profile and fix :-)
Sep 20 2018
Sep 19 2018
Since it helps existing msbuild configs, adding this seems like a good thing to me.
FWIW the recommendation against /Ox in my version is because of https://github.com/ulfjack/ryu/pull/70#issuecomment-412168459
Sep 17 2018
Thanks! Changed the comment; landing.
Sep 15 2018
fix case on variable
The revert helped, see e.g. http://lab.llvm.org:8011/builders/lld-x86_64-darwin13/builds/25686 and http://lab.llvm.org:8011/builders/lld-x86_64-freebsd/builds/23378 (compare to previous build)
I reverted this (and follow-on fix attempts r342154 r342180 r342182 r342193) in r342336 in an attempt to heal the lld bots.
Ah, looks like all changes are mentioned at the top, just not as comments further down.
https://reviews.llvm.org/rLLD342334 too. Thanks!
Sep 14 2018
rebase, minor cleanups
Unrelatedly, another problem with the current design is that llvm.srcdir.txt must contain an absolute path, which makes it impossible to build on one machine and then copy artifacts and test inputs to another machine and run tests on another machine. DebugInfoPDBTests is the only test in all llvm, lld, clang tests that has this restriction. Requiring some defined fixed pwd for unit tests with inputs would address this issue as well. (As would finding a way to not require reading a file off disk for this test.)
Sep 13 2018
Actually, this replaces https://reviews.llvm.org/D51887
This replaces https://reviews.llvm.org/D51957.