*did fix things on _linux_

Even after the one test fix, check-lld is still broken on Mac and win:
http://45.33.8.238/macm1/39637/step_10.txt
http://45.33.8.238/win/61745/step_10.txt

In D129223#3633754, @thakis wrote:

This breaks check-clang: http://45.33.8.238/linux/80462/step_7.txt

Reverted in e9fe20dab39edb911afacdb6ed9ec2c7499a59cf for now.

In D114845#3633730, @thakis wrote:

This doesn't build: http://45.33.8.238/linux/80459/step_4.txt

This breaks check-clang: http://45.33.8.238/linux/80462/step_7.txt

This doesn't build: http://45.33.8.238/linux/80459/step_4.txt

As far as I can tell, this breaks check-clang everywhere: http://45.33.8.238/

Thanks for the fix! :)

Thanks!

Looks like this breaks tests on windows: http://45.33.8.238/win/61559/step_8.txt

Looks fine to me.

\o/

What --author flag should I use for you when landing this?

The auto-merger only auto-merges source lists, not deps. (See llvm/utils/gn/build/sync_source_lists_from_cmake.py – the merge bot just runs llvm/utils/gn/build/sync_source_lists_from_cmake.py --write, and the commits the result if tests pass.)

Looks like this breaks check-clang: http://45.33.8.238/linux/80254/step_7.txt

Looks like this breaks tests on Windows: http://45.33.8.238/win/61429/step_7.txt

Lgtm!

Looks like this breaks check-clang on windows: http://45.33.8.238/win/61067/step_7.txt

Other than that, looks excellent to me.

Looks like this breaks tests on non-linux: http://45.33.8.238/macm1/37997/step_11.txt , http://45.33.8.238/win/60800/step_11.txt

Thanks!

address most comments

simpler (?) impl by making --time-trace an alias for --time-trace= (without an arg)

Good suggestion, thanks. Done.

Given that the bot's been red for quite a few hours by now and there's some disagreement about the right fix, I've reverted this in 851a5efe45a026047ba8c0262a892b9895e355bf for now.

This also broke check-llvm on macOS: http://45.33.8.238/macm1/37938/step_11.txt (this both is an M1 mac, not sure if intel vs arm matter).

Nice!

Looks like https://github.com/llvm/llvm-project/commit/6f258c0fd34cf4001ffa08c61f6e4e0f1254c50f fixed it.

On many of the official bots too, eg https://lab.llvm.org/buildbot/#/builders/109/builds/41178 (did that not generate an email?)

Looks like this breaks check-clang: http://45.33.8.238/linux/79438/step_7.txt

(Also, not sure it's such a bad thing that it defaults to on. Smaller projects won't notice the link time cost, and larger projects will have lots of tweaking flags for better or worse anyways…)

In D128093#3599802, @int3 wrote:

The added overhead on linking Chromium is 200 milliseconds on my M1 Mac mini, which accounts for about 4% of the total runtime.

Is there measurable overhead when -ignore_optimization_hints is passed? I'm wondering about the overhead from increasing the Reloc struct size

4% overhead is not such a big deal IMO if we can disable it in developer builds (though the fact that it's enabled by default is unfortunate)

Anyone interested in a 3% speedup? :)

Thanks! :)

(in any case, it's irrelevant after D128298)

In D128295#3599940, @tschuett wrote:

Nit. Your are not allowed to check getBlockCount() for every iteration. Pull it out of the loop?

Hm?

Nice!