thakis (Nico Weber)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (245 w, 2 d)

Recent Activity

Tue, Sep 19

thakis added a comment to D37954: Try to shorten system header paths when using -MD depfiles.

I think for depfile generation, we generally try to be gcc-compatible (I can link to prior changes in this spirit), so I think this seems like a good thing to do to me. gcc only does this for system headers, yes?

Tue, Sep 19, 3:30 PM

Tue, Sep 5

thakis closed D37452: lld-link: Add --rsp-quoting= flag.

r312594, thanks!

Tue, Sep 5, 4:48 PM

Mon, Sep 4

thakis updated the diff for D37452: lld-link: Add --rsp-quoting= flag.

fix a comment typo

Mon, Sep 4, 4:47 PM
thakis updated the diff for D37452: lld-link: Add --rsp-quoting= flag.

Actually, I talked myself out of this affecting %LINK% / %_LINK_% while writing the patch summary. I removed that bit.

Mon, Sep 4, 4:45 PM
thakis created D37452: lld-link: Add --rsp-quoting= flag.
Mon, Sep 4, 4:36 PM

Wed, Aug 30

thakis closed D37324: Suppress -Wdelete-non-virtual-dtor warnings _about_ classes defined in system headers..

312216, thanks!

Wed, Aug 30, 11:18 PM
thakis created D37324: Suppress -Wdelete-non-virtual-dtor warnings _about_ classes defined in system headers..
Wed, Aug 30, 7:29 PM
thakis closed D37235: Let -Wdelete-non-virtual-dtor fire in system headers too..

Thanks, landed in r312167.

Wed, Aug 30, 1:28 PM

Mon, Aug 28

thakis updated the diff for D37235: Let -Wdelete-non-virtual-dtor fire in system headers too..

Don't warn in unevaluated contexts. Ready for a look now.

Mon, Aug 28, 3:33 PM
thakis created D37235: Let -Wdelete-non-virtual-dtor fire in system headers too..
Mon, Aug 28, 3:08 PM

Aug 23 2017

thakis created D37090: Implement CFG construction for __finally..
Aug 23 2017, 6:35 PM
thakis closed D36914: Implement CFG construction for __try / __except / __leave..
Aug 23 2017, 8:35 AM

Aug 22 2017

thakis updated the diff for D36914: Implement CFG construction for __try / __except / __leave..

add test from rnk

Aug 22 2017, 4:57 PM

Aug 21 2017

thakis added inline comments to D36914: Implement CFG construction for __try / __except / __leave..
Aug 21 2017, 10:43 AM
thakis updated the diff for D36914: Implement CFG construction for __try / __except / __leave..

Just use TryTerminatedBlock

Aug 21 2017, 10:43 AM
thakis updated the summary of D36914: Implement CFG construction for __try / __except / __leave..
Aug 21 2017, 10:43 AM

Aug 18 2017

thakis created D36914: Implement CFG construction for __try / __except / __leave..
Aug 18 2017, 7:03 PM
thakis accepted D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure.

Many driver tests check in a basic representative directory structure (e.g. test/Driver/Inputs/basic_freebsd_tree/ and its many siblings).

Aug 18 2017, 6:49 PM
thakis added a comment to D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure.

This approach looks good to me.

Aug 18 2017, 7:41 AM
thakis added a comment to D36857: [Driver] Set linkPath and MSVT version when cl.exe is detected, plus STL's hacking..

Oh, I guess this is superseded by https://reviews.llvm.org/D36860 ?

Aug 18 2017, 7:39 AM
thakis added inline comments to D36857: [Driver] Set linkPath and MSVT version when cl.exe is detected, plus STL's hacking..
Aug 18 2017, 7:33 AM
thakis added a reviewer for D36857: [Driver] Set linkPath and MSVT version when cl.exe is detected, plus STL's hacking.: zturner.
Aug 18 2017, 7:33 AM

Aug 16 2017

thakis added inline comments to D36758: [LLD COFF / PDB] Incrementally update the BuildId when writing a PDB..
Aug 16 2017, 2:20 PM

Aug 14 2017

thakis updated the summary of D36481: /redundancyReport proof of concept.
Aug 14 2017, 12:05 PM
thakis updated the summary of D36481: /redundancyReport proof of concept.
Aug 14 2017, 12:01 PM
thakis updated the diff for D36481: /redundancyReport proof of concept.
Aug 14 2017, 11:58 AM
thakis updated the summary of D36481: /redundancyReport proof of concept.
Aug 14 2017, 11:58 AM
thakis updated the diff for D36481: /redundancyReport proof of concept.
Aug 14 2017, 11:55 AM

Aug 9 2017

thakis accepted D36526: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare.

Thanks!

Aug 9 2017, 1:56 PM

Aug 8 2017

thakis created D36481: /redundancyReport proof of concept.
Aug 8 2017, 12:28 PM
thakis closed D36413: Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name..

r310376, thanks!

Aug 8 2017, 9:22 AM

Aug 7 2017

thakis created D36413: Use "foo-12345.o.tmp" instead of "foo.o-12345" as temporary file name..
Aug 7 2017, 10:02 AM

Aug 4 2017

thakis added a comment to D36324: Integrate Kostya's clang-proto-fuzzer with LLVM..

Why should this be part of llvm? This seems to come with very heavy dependencies (protobuf), and LLVM has historically tried to minimize the number of things it depends on.

Aug 4 2017, 11:22 AM
thakis added a comment to D36191: [CodeGen] Don't make availability attributes imply default visibility on macos.

Is landing this blocked on internal testing?

Aug 4 2017, 7:22 AM
thakis added a comment to D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name..

Hm, that's unfortunate. I don't see a good way to rescue this patch.

Aug 4 2017, 7:14 AM

Aug 3 2017

thakis closed D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name..

309984.

Aug 3 2017, 2:07 PM
thakis added a comment to D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name..

I'm going to land this. It's early in the 6.0 cycle, so if this causes issues, we should have time to find them and then follow up in case we run into any.

Aug 3 2017, 2:06 PM
thakis closed D36281: Fix llvm-for-windows-on-linux build after LLVM r272701..

309980, thanks!

Aug 3 2017, 1:11 PM
thakis created D36281: Fix llvm-for-windows-on-linux build after LLVM r272701..
Aug 3 2017, 1:08 PM
thakis added a comment to D33900: Print registered targets in clang's version information.

I've reverted this in 309960, as discussed.

Aug 3 2017, 9:47 AM
thakis added a comment to D27827: [ObjC] CodeGen support for @available on macOS.

(Our workaround is to call __builtin_available() once before engaging the sandbox, which isn't so bad. Just thought I'd let you know about it; this isn't a serious bug for us.)

Aug 3 2017, 8:31 AM
thakis added a comment to D27827: [ObjC] CodeGen support for @available on macOS.

Looks like the email reply didn't make it to phab, so here it is again:

Aug 3 2017, 8:05 AM

Aug 2 2017

thakis added a comment to D27827: [ObjC] CodeGen support for @available on macOS.

We just noticed that if you call __builtin_available() for the first time after activating your app's sandbox, the function will fail:

Aug 2 2017, 1:33 PM
thakis created D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name..
Aug 2 2017, 1:30 PM
thakis added a comment to D36191: [CodeGen] Don't make availability attributes imply default visibility on macos.

Awesome, thanks! Maybe mention the PR# for this in the commit message.

Aug 2 2017, 9:14 AM

Jul 28 2017

thakis added a comment to D33900: Print registered targets in clang's version information.

dim: Does putting the target listing behind a different flag work for you? Which problem are you trying to solve here?

Jul 28 2017, 9:53 AM

Jul 26 2017

thakis closed D35872: lld: /manifestuac:no shouldn't disable /manifestdependency:.

Thanks! r309231

Jul 26 2017, 4:38 PM

Jul 25 2017

thakis created D35872: lld: /manifestuac:no shouldn't disable /manifestdependency:.
Jul 25 2017, 6:52 PM
thakis closed D35842: lld: only write .manifest files if /manifest is passed, PR33925.

r308998, thanks!

Jul 25 2017, 11:08 AM
thakis closed D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library..

r308997, thanks!

Jul 25 2017, 11:04 AM
thakis created D35842: lld: only write .manifest files if /manifest is passed, PR33925.
Jul 25 2017, 8:55 AM

Jul 24 2017

thakis added a comment to D33900: Print registered targets in clang's version information.
In D33900#819234, @dim wrote:

Sorry, I just noticed this weeks later. Why are we adding this to --version instead of adding some new flag for printing this? When I pass --version, I'm usually interested in clang's version and don't need a screenful of other information below it (which makes the output I do care about scroll off the screen).

I added it there, for consistency with other LLVM tools, for example:

Jul 24 2017, 12:15 PM
thakis closed D35757: Work around an MSVC2017 update 3 codegen bug..

r308897.

Jul 24 2017, 9:55 AM
thakis added a comment to D33900: Print registered targets in clang's version information.

Sorry, I just noticed this weeks later. Why are we adding this to --version instead of adding some new flag for printing this? When I pass --version, I'm usually interested in clang's version and don't need a screenful of other information below it (which makes the output I do care about scroll off the screen).

Jul 24 2017, 8:37 AM

Jul 23 2017

thakis added a comment to D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library..

Most of the patch is unifying all the toolchains to call the newly-introduced ToolChain::ShouldLinkCXXStdlib() instead of all manually checking for D.CCIsCXX() && !getFlag(nostdlib, nodefaultlibs). The actual behavior change is to make that function check the new nostdlib++ flag too.

Jul 23 2017, 11:57 AM
thakis created D35780: Introduce -nostdlib++ flag to disable linking the C++ standard library..
Jul 23 2017, 11:55 AM

Jul 21 2017

thakis added a comment to D35757: Work around an MSVC2017 update 3 codegen bug..

From what I understand, _MSC_VER changes with each 2017 update.

Jul 21 2017, 9:31 PM
thakis created D35757: Work around an MSVC2017 update 3 codegen bug..
Jul 21 2017, 7:07 PM
thakis closed D35386: Speed up gdb index creation.

r308544

Jul 21 2017, 8:59 AM

Jul 17 2017

thakis closed D35236: Refactor gdb index creation.

(landed in r307867)

Jul 17 2017, 5:26 AM

Jul 14 2017

thakis added inline comments to D35379: Add documentation for @available.
Jul 14 2017, 11:53 AM
thakis added a comment to D35379: Add documentation for @available.

I went ahead and landed this in r308044, given that I addressed the nits and removed the possibly contentious bits. Happy to address remaining nits in a follow-up.

Jul 14 2017, 11:42 AM
thakis added a comment to D35379: Add documentation for @available.

Mostly done, thanks!

Jul 14 2017, 9:26 AM
thakis updated the diff for D35379: Add documentation for @available.

sdy comments

Jul 14 2017, 9:26 AM
thakis updated the diff for D35379: Add documentation for @available.

arphaman comments

Jul 14 2017, 9:17 AM
thakis added a comment to D35379: Add documentation for @available.

Thanks, all done, much better!

Jul 14 2017, 9:16 AM

Jul 13 2017

thakis updated the diff for D35379: Add documentation for @available.

Document *, add example with multiple platforms

Jul 13 2017, 1:58 PM
thakis added inline comments to D35379: Add documentation for @available.
Jul 13 2017, 1:35 PM
thakis updated the diff for D35379: Add documentation for @available.

comments

Jul 13 2017, 1:35 PM
thakis created D35379: Add documentation for @available.
Jul 13 2017, 1:06 PM

Jun 27 2017

thakis closed D34637: [libunwind] Add _LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS.

r306442, thanks!

Jun 27 2017, 11:37 AM

May 25 2017

thakis added a comment to D32862: [AMDGPU] add intrinsic for s_getpc.

http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2604
http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/3280

May 25 2017, 12:20 PM

May 24 2017

thakis added a comment to D33471: [asan] Remove allow_user_segv_handler on Windows..

Either this or the reland of making allow_user_segv_handler to true broke this test on Windows:

May 24 2017, 1:06 PM
thakis added a comment to D33408: MachineCSE: Respect interblock physreg liveness.

The new test fails for me like so, at r303736:

May 24 2017, 11:59 AM

May 10 2017

thakis accepted D26953: clang-format: handle formatting on constexpr if.

This looks good to me, thanks. Sorry about the slow turnaround. Do you have commit access? If not, I can land it for you – but it also looks like you've contributed several patches by now, so you could also ask for commit access if you don't have it yet.

May 10 2017, 8:27 AM

May 5 2017

thakis closed D32879: Warn that the [] spelling of uuid(...) is deprecated..

r302255, thanks!

May 5 2017, 10:19 AM
thakis added a comment to D32914: Introduce Wzero-as-null-pointer-constant..

s/Add one/All done/

May 5 2017, 9:24 AM
thakis closed D32914: Introduce Wzero-as-null-pointer-constant..

Thanks! Add one and landed in r302247.

May 5 2017, 9:24 AM
thakis created D32914: Introduce Wzero-as-null-pointer-constant..
May 5 2017, 8:58 AM

May 4 2017

thakis created D32879: Warn that the [] spelling of uuid(...) is deprecated..
May 4 2017, 1:55 PM

May 1 2017

thakis added inline comments to D32646: Fix a bug that -Wmissing-braces fires on system headers.
May 1 2017, 2:41 PM

Apr 24 2017

thakis created D32435: clang-cl: Add support for /permissive-.
Apr 24 2017, 7:58 AM

Apr 21 2017

thakis closed D32371: Add comments to the diagnostic kinds in Diagnostic.td..

r301039, thanks.

Apr 21 2017, 2:08 PM
thakis added a comment to D32371: Add comments to the diagnostic kinds in Diagnostic.td..

Not sure if this is useful, but this is where I always check first.

Apr 21 2017, 2:00 PM
thakis created D32371: Add comments to the diagnostic kinds in Diagnostic.td..
Apr 21 2017, 2:00 PM
thakis closed D32369: [ms] Give -Wmicrosoft-enum-forward-reference a chance to fire in clang-cl, PR32736.

r301032, thanks.

Apr 21 2017, 1:25 PM
thakis created D32369: [ms] Give -Wmicrosoft-enum-forward-reference a chance to fire in clang-cl, PR32736.
Apr 21 2017, 1:17 PM

Apr 19 2017

thakis added inline comments to D32095: Make empty shell of new cvtres tool..
Apr 19 2017, 1:17 PM
thakis accepted D32095: Make empty shell of new cvtres tool..

Looks good to me.

Apr 19 2017, 1:08 PM
thakis closed D27375: Let ubsan search UBSAN_SYMBOLIZER_PATH for llvm-symbolizer.

I was just confused again by this not working, and didn't remember this review for a while. From a user's point of view it feels like this should work, so I've gone ahead and landed this in r300692.

Apr 19 2017, 7:17 AM

Apr 18 2017

thakis added a comment to D32095: Make empty shell of new cvtres tool..

I'm out today. Since lld will be a client of the library code of this tool, Rui should probably take a look if he's around this week. I'd also already add a test with just a RUN line for running the tool without parameters, just to have test coverage from day one (makes it easier to add tests in the future once the tool actually does something).

Apr 18 2017, 6:32 AM
thakis added a reviewer for D32095: Make empty shell of new cvtres tool.: ruiu.
Apr 18 2017, 6:31 AM

Apr 11 2017

thakis closed D31652: [clang-format] Recognize Java logical shift assignment operator.

Landed in r299952: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20170410/189882.html

Apr 11 2017, 9:03 AM
thakis accepted D31652: [clang-format] Recognize Java logical shift assignment operator.

Looks good. Do you have commit access?

Apr 11 2017, 8:19 AM
thakis added a comment to D29586: [lsan] Enable LSan for arm Linux.

This breaks bootstrap builds. I put the error message in the revert commit description: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20170410/444101.html

Apr 11 2017, 7:42 AM · Restricted Project

Apr 6 2017

thakis added inline comments to D31652: [clang-format] Recognize Java logical shift assignment operator.
Apr 6 2017, 6:41 AM

Mar 27 2017

thakis added a comment to D30504: [sanitizer] Bail out with warning if user dlopens shared library with RTLD_DEEPBIND flag.

We have a test in chromium that loads a small so file and calls some of the functions therein. There are no allocations in the so file. The test used to run fine under tsan, now it fails with the error message you added. I'll disable the test under tsan, but maybe others out there where also calling non-allocating so's without problems before this change.

Mar 27 2017, 7:44 AM · Restricted Project

Mar 22 2017

thakis accepted D31248: [X86] Implement __readgsqword (and the rest) as builtins (PR32373).
Mar 22 2017, 11:48 AM

Mar 18 2017

thakis closed D30959: [pdb] Add support for writing Module Info and module symbols.

I think this landed in r297900.

Mar 18 2017, 9:06 AM

Mar 16 2017

thakis added a comment to D30991: [Driver] Fix cross compiling with Visual Studio 2017.

Ah ok, thanks for explaining. In that case, this sounds fine and I'll leave the review to zturner.

Mar 16 2017, 11:27 AM