Page MenuHomePhabricator

thakis (Nico Weber)Email Not Verified
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (313 w, 5 d)

Recent Activity

Yesterday

thakis accepted D56732: [clang] [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF.

I can't easily test this since only some of our bots see this and I don't have a Linux box at hand, but it looks like it should work and I can verify on the bots once this is in :)

Tue, Jan 15, 6:14 PM
thakis accepted D56727: gn build: Don't assume valgrind.h exists on Linux.

Thanks!

Tue, Jan 15, 8:46 AM
thakis accepted D56713: gn build: Add check-hwasan target..

Nice!!

Tue, Jan 15, 6:13 AM
thakis accepted D56711: gn build: Add a stage2 host toolchain and make the hwasan runtime buildable on x86_64 Linux..
Tue, Jan 15, 6:11 AM
thakis accepted D56710: gn build: Move target flags from toolchain to a .gni file..

I think it might make sense to pretty soon add build/{android,...}/BUILD.gn that defines a build/{android,...}_compiler config that's added to the config list soon, instead of expanding this duplicate way to define compiler flags.

Tue, Jan 15, 6:09 AM
thakis accepted D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..
Tue, Jan 15, 6:06 AM

Mon, Jan 14

thakis created D56677: lld-link: Spelling fixes in comments and minor style tweaks.
Mon, Jan 14, 10:50 AM

Sat, Jan 12

thakis added inline comments to D56565: gn build: Add gn.py wrapper script that adds appropriate --dotfile= and --root= paramers.
Sat, Jan 12, 4:05 AM
thakis updated the diff for D56565: gn build: Add gn.py wrapper script that adds appropriate --dotfile= and --root= paramers.

address comment

Sat, Jan 12, 4:05 AM

Fri, Jan 11

thakis added a comment to D56628: gn build: Add build files for compiler-rt/lib/{hwasan,interception,sanitizer_common,ubsan}..

Nice! There are enough comments below that I won't hit "accept" just yet, but none of the comments are blocking and you can talk me out of all of them if you disagree with the suggestions.

Fri, Jan 11, 6:40 PM
thakis created D56630: gn build: Unbreak Windows build.
Fri, Jan 11, 6:27 PM
thakis accepted D56627: gn build: Split no-RTTI flag into a config..
Fri, Jan 11, 6:25 PM
thakis accepted D56626: gn build: Stop defining LLVM_ON_UNIX globally..

Ah right, this from before I generated llvm-config.h long long ago. Well, that was easy :-)

Fri, Jan 11, 6:25 PM
thakis added a comment to D55491: Implement TemplateArgument dumping in terms of Visitor.

Out of interest, what's the motivation for this? It seems to add way more code than it removes, so there must be some other advantage, but the patch description doesn't say.

Fri, Jan 11, 6:21 PM
thakis updated the summary of D56600: LLD doc tweaks.
Fri, Jan 11, 3:43 PM
thakis added inline comments to D56600: LLD doc tweaks.
Fri, Jan 11, 3:34 PM
thakis updated the diff for D56600: LLD doc tweaks.

move aarch64, arm to production quality

Fri, Jan 11, 3:33 PM
thakis updated the diff for D56600: LLD doc tweaks.
Fri, Jan 11, 8:33 AM
thakis updated the diff for D56600: LLD doc tweaks.
Fri, Jan 11, 8:30 AM
thakis updated the diff for D56600: LLD doc tweaks.
Fri, Jan 11, 8:19 AM
thakis created D56600: LLD doc tweaks.
Fri, Jan 11, 7:53 AM
thakis accepted D56577: gn build: Add a stage2 toolchain for Android..

Super cool!

Fri, Jan 11, 6:40 AM
thakis accepted D56576: gn build: Create a template for unix toolchains..

lgtm!

Fri, Jan 11, 6:32 AM
thakis accepted D56575: gn build: Create a variable for the host toolchain and start using it in the tblgen template..

lgtm assuming that explicitly mentioning the default toolchain in a label is a no-op.

Fri, Jan 11, 6:27 AM
thakis accepted D56427: gn build: s/root_out_dir/root_build_dir/g in llvm/utils/gn/build/write_cmake_config.gni..

lgtm. What about the rest of git grep root_out_dir llvm/utils/?

Fri, Jan 11, 6:26 AM

Thu, Jan 10

thakis created D56565: gn build: Add gn.py wrapper script that adds appropriate --dotfile= and --root= paramers.
Thu, Jan 10, 3:34 PM
thakis added a comment to D56427: gn build: s/root_out_dir/root_build_dir/g in llvm/utils/gn/build/write_cmake_config.gni..

(landed my change; thanks for the review!)

Thu, Jan 10, 3:17 PM

Wed, Jan 9

thakis created D56502: lld-link: Add help strings for /manifest, /nodefaultlib, /noentry; tweak manifest help strings.
Wed, Jan 9, 10:09 AM
thakis created D56489: clang-cl: Fix help text for /O<flags>: '/O2y-' means '/O2 /Oy-', not '/O2 /y-'.
Wed, Jan 9, 6:41 AM
thakis created D56488: clang-cl: Align help texts for /O1 and O2.
Wed, Jan 9, 6:35 AM
thakis added a comment to D56427: gn build: s/root_out_dir/root_build_dir/g in llvm/utils/gn/build/write_cmake_config.gni..

There are many many references to root_out_dir, cmd-f root_out_dir on the lhs in D56487 for example. Does it make sense to change them all at once? Or should we land D56487 fist and at least change all the write_cmake_config ones at once?

Wed, Jan 9, 6:07 AM
thakis accepted D56422: gn build: Use "git rev-parse --git-dir" to discover the path to the .git directory..
Wed, Jan 9, 6:07 AM
thakis created D56487: gn build: Add a template for calling write_cmake_config.py.
Wed, Jan 9, 6:04 AM
thakis added a comment to D56426: gn build: Stop passing -o to ar..

Thanks for the patch! Please run git ls-files '*.gn' '*.gni' | xargs -n 1 gn format after making GN changes. (I forgot that for the PowerPC target too, so I'm running it for this file here too, so nothing to do for you, just pointing it out for next time.)

Wed, Jan 9, 5:02 AM
thakis abandoned D56419: [gn build] Move .gn file to the root of the monorepo.
Wed, Jan 9, 4:53 AM
thakis added a comment to D56419: [gn build] Move .gn file to the root of the monorepo.

Ok, I've abandoned this revision. Thanks for the feedback, everyone!

Wed, Jan 9, 4:53 AM
thakis added a comment to D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang.

…can you land this? :-)

Wed, Jan 9, 4:44 AM

Tue, Jan 8

thakis added a comment to D56469: [ObjC] Allow the use of implemented unavailable methods from within the @implementation context .

(This would also help with https://crbug.com/917351)

Tue, Jan 8, 6:41 PM
thakis accepted D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang.
Tue, Jan 8, 10:37 AM
thakis added a comment to D56419: [gn build] Move .gn file to the root of the monorepo.

I'd be interested in feedback from more people if anyone has any (e.g. "don't care"). Given the current feedback, I'll put this on hold for now.

Tue, Jan 8, 10:14 AM
thakis requested review of D56420: [gn build] Add a TODO.txt file.
Tue, Jan 8, 8:19 AM
thakis added a comment to D56420: [gn build] Add a TODO.txt file.

I'd prefer to land this as a txt file:

  • rst requires a newline after toplevel list entries to accept nested lists, which makes the txt file less readable
  • md doesn't, but it insists on `` around every string that contains an underscore, else parts of the word become italic
Tue, Jan 8, 7:27 AM

Mon, Jan 7

thakis added a comment to D56419: [gn build] Move .gn file to the root of the monorepo.

I'm neutral on the issue but I would urge Nico to really think this through, lashback from some major downstream Linux distro vendors last time was pretty nasty, including flat out dropping Clang/LLVM support if CMake became a second class citizen. Is rehashing the same thing again worth it? Consider that a lot of people, no matter what you say will see it as GN slowly creeping in to replace CMake, not many are familiar with it outside Google or Chromium/Skia contributors.

Mon, Jan 7, 5:05 PM
thakis created D56420: [gn build] Add a TODO.txt file.
Mon, Jan 7, 4:45 PM
thakis added a comment to D56419: [gn build] Move .gn file to the root of the monorepo.
I don't see the downside of adding a hidden file at the toplevel yet.

The change promotes an unsupported, parallel, build system to the top of LLVM. It's precisely the situation I and others who spoke up on llvm-dev were trying to avoid.

Mon, Jan 7, 4:37 PM
thakis added a comment to D56419: [gn build] Move .gn file to the root of the monorepo.

I am strongly against this commit. @thakis when this was discussed on llvm-dev the original proposal was the compromise of placing .gn in utils to signify that it was not the default, recommended, method to build LLVM. With this change LLVM will truly have two, parallel build systems once again.

Mon, Jan 7, 4:11 PM
thakis created D56419: [gn build] Move .gn file to the root of the monorepo.
Mon, Jan 7, 3:40 PM
thakis updated the summary of D56416: [gn build] Add build files for llvm/lib/Target/PowerPC + tests.
Mon, Jan 7, 3:10 PM
thakis updated the diff for D56417: [gn build] Make sync_source_lists_from_cmake.py check that all LLVM unittests are present.
Mon, Jan 7, 3:08 PM
thakis added a child revision for D56374: [gn build] Add build files for llvm/lib/Target/WebAssembly + tests: D56417: [gn build] Make sync_source_lists_from_cmake.py check that all LLVM unittests are present.
Mon, Jan 7, 3:06 PM
thakis added parent revisions for D56417: [gn build] Make sync_source_lists_from_cmake.py check that all LLVM unittests are present: D56374: [gn build] Add build files for llvm/lib/Target/WebAssembly + tests, D56416: [gn build] Add build files for llvm/lib/Target/PowerPC + tests.
Mon, Jan 7, 3:06 PM
thakis added a child revision for D56416: [gn build] Add build files for llvm/lib/Target/PowerPC + tests: D56417: [gn build] Make sync_source_lists_from_cmake.py check that all LLVM unittests are present.
Mon, Jan 7, 3:06 PM
thakis created D56417: [gn build] Make sync_source_lists_from_cmake.py check that all LLVM unittests are present.
Mon, Jan 7, 3:06 PM
thakis created D56416: [gn build] Add build files for llvm/lib/Target/PowerPC + tests.
Mon, Jan 7, 3:05 PM
thakis accepted D56392: [LLD][COFF] Support /ignore:4099. Support /ignore with comma-separated arguments..

Lgtm

Mon, Jan 7, 10:29 AM

Sun, Jan 6

thakis created D56375: [gn build] Update readme.
Sun, Jan 6, 6:12 PM
thakis created D56374: [gn build] Add build files for llvm/lib/Target/WebAssembly + tests.
Sun, Jan 6, 5:55 PM
thakis added a parent revision for D56371: [gn build] Add build files for llvm/lib/Target/ARM + tests: D56364: [gn build] Add build files for llvm/lib/Target/AArch64 + tests.
Sun, Jan 6, 4:45 PM
thakis created D56371: [gn build] Add build files for llvm/lib/Target/ARM + tests.
Sun, Jan 6, 4:45 PM
thakis added a child revision for D56364: [gn build] Add build files for llvm/lib/Target/AArch64 + tests: D56371: [gn build] Add build files for llvm/lib/Target/ARM + tests.
Sun, Jan 6, 4:45 PM
thakis created D56364: [gn build] Add build files for llvm/lib/Target/AArch64 + tests.
Sun, Jan 6, 11:35 AM
thakis added a comment to D53945: [TextAPI] TBD Reader/Writer.

Out of interest, why aren't most of the tests for this lit tests? The usual llvm way of testing stuff is to write a small llvm tool using your library (which will be useful outside of a testing context too) and then use that to write lit tests.

Sun, Jan 6, 8:04 AM
thakis added a comment to D56219: [gn build] Add build files for LLVM unittests with a custom main() function.

Thanks!

Sun, Jan 6, 7:13 AM

Fri, Jan 4

thakis added inline comments to D56219: [gn build] Add build files for LLVM unittests with a custom main() function.
Fri, Jan 4, 8:35 PM
thakis updated the diff for D56219: [gn build] Add build files for LLVM unittests with a custom main() function.

way better

Fri, Jan 4, 8:34 PM
thakis added inline comments to D56219: [gn build] Add build files for LLVM unittests with a custom main() function.
Fri, Jan 4, 8:07 PM
thakis added inline comments to D56219: [gn build] Add build files for LLVM unittests with a custom main() function.
Fri, Jan 4, 7:05 PM
thakis added inline comments to D56330: [gn build] Add build files for unittests that load shared libraries.
Fri, Jan 4, 5:46 PM
thakis added inline comments to D56330: [gn build] Add build files for unittests that load shared libraries.
Fri, Jan 4, 5:39 PM
thakis updated the diff for D56330: [gn build] Add build files for unittests that load shared libraries.

remove needless static_library target

Fri, Jan 4, 1:22 PM
thakis added a child revision for D56324: [gn build] Add build file for DebugInfoPDBTests: D56330: [gn build] Add build files for unittests that load shared libraries.
Fri, Jan 4, 1:18 PM
thakis added a parent revision for D56330: [gn build] Add build files for unittests that load shared libraries: D56324: [gn build] Add build file for DebugInfoPDBTests.
Fri, Jan 4, 1:18 PM
thakis updated the diff for D56324: [gn build] Add build file for DebugInfoPDBTests.

no template

Fri, Jan 4, 1:10 PM
thakis created D56330: [gn build] Add build files for unittests that load shared libraries.
Fri, Jan 4, 1:05 PM
thakis added a comment to D56324: [gn build] Add build file for DebugInfoPDBTests.

It looks like I need to add knowledge about the tests going in target_out_dir in two other places, so I think I'll remove the new template() here and put this directly in the build file of the test, and just add a comment in the gni file along the lines of If you change output_dir, look through git grep target_out_dir '*/unittests/*'`.

Fri, Jan 4, 12:48 PM
thakis created D56328: [gn build] Add build files for unittests under llvm/unittests/ExecutionEngine.
Fri, Jan 4, 12:03 PM
thakis added inline comments to D56219: [gn build] Add build files for LLVM unittests with a custom main() function.
Fri, Jan 4, 11:02 AM
thakis added a parent revision for D56324: [gn build] Add build file for DebugInfoPDBTests: D56219: [gn build] Add build files for LLVM unittests with a custom main() function.
Fri, Jan 4, 10:59 AM
thakis added a child revision for D56219: [gn build] Add build files for LLVM unittests with a custom main() function: D56324: [gn build] Add build file for DebugInfoPDBTests.
Fri, Jan 4, 10:59 AM
thakis created D56324: [gn build] Add build file for DebugInfoPDBTests.
Fri, Jan 4, 10:59 AM
thakis requested review of D56195: [gn build] Add check-llvm target and make it work.
Fri, Jan 4, 8:07 AM
thakis added a comment to D56195: [gn build] Add check-llvm target and make it work.

LGTM, but *only* with respect to the Python 2/3 compatibility of the modification, which is just a drop in the ocean of this patch.

Fri, Jan 4, 5:57 AM
thakis added a child revision for D56316: [gn build] Add build files for llvm/lib/{LineEditor,Testing/Support,TextAPI}: D56195: [gn build] Add check-llvm target and make it work.
Fri, Jan 4, 5:48 AM
thakis added parent revisions for D56195: [gn build] Add check-llvm target and make it work: D56317: [gn build] Add build file for libLTO.dylib, D56316: [gn build] Add build files for llvm/lib/{LineEditor,Testing/Support,TextAPI}.
Fri, Jan 4, 5:48 AM
thakis added a child revision for D56317: [gn build] Add build file for libLTO.dylib: D56195: [gn build] Add check-llvm target and make it work.
Fri, Jan 4, 5:48 AM
thakis updated the diff for D56195: [gn build] Add check-llvm target and make it work.

pulled some stuff out into dependent patches to make this smaller

Fri, Jan 4, 5:48 AM
thakis created D56317: [gn build] Add build file for libLTO.dylib.
Fri, Jan 4, 5:48 AM
thakis created D56316: [gn build] Add build files for llvm/lib/{LineEditor,Testing/Support,TextAPI}.
Fri, Jan 4, 5:43 AM

Thu, Jan 3

Herald added a reviewer for D56195: [gn build] Add check-llvm target and make it work: serge-sans-paille.

phosek: ping :-) Almost done!

Thu, Jan 3, 11:36 AM
thakis added a comment to D56200: Remove unused %host_cc lit pattern.

Looks like dblaikie is away for a bit. rnk, would you mind looking at this one too?

Thu, Jan 3, 10:30 AM
thakis added a reviewer for D56200: Remove unused %host_cc lit pattern: rnk.
Thu, Jan 3, 10:30 AM
thakis updated the diff for D56273: Validate -add-plugin arguments..

remove require

Thu, Jan 3, 8:21 AM
thakis added inline comments to D56273: Validate -add-plugin arguments..
Thu, Jan 3, 8:20 AM
thakis updated the diff for D56273: Validate -add-plugin arguments..

forgot to add test

Thu, Jan 3, 8:19 AM
thakis created D56273: Validate -add-plugin arguments..
Thu, Jan 3, 8:18 AM

Wed, Jan 2

thakis added a child revision for D56217: [gn build] Add even more build files for LLVM unittests: D56219: [gn build] Add build files for LLVM unittests with a custom main() function.
Wed, Jan 2, 1:19 PM
thakis added a parent revision for D56219: [gn build] Add build files for LLVM unittests with a custom main() function: D56217: [gn build] Add even more build files for LLVM unittests.
Wed, Jan 2, 1:19 PM
thakis created D56219: [gn build] Add build files for LLVM unittests with a custom main() function.
Wed, Jan 2, 1:19 PM
thakis added parent revisions for D56217: [gn build] Add even more build files for LLVM unittests: D56213: [gn build] Add more build files for LLVM unittests, D56216: Rename TapiTests to TextAPITests.
Wed, Jan 2, 12:55 PM
thakis added a child revision for D56213: [gn build] Add more build files for LLVM unittests: D56217: [gn build] Add even more build files for LLVM unittests.
Wed, Jan 2, 12:55 PM