Page MenuHomePhabricator

thakis (Nico Weber)
UserEmail Not Verified

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (440 w, 4 d)

Recent Activity

Today

thakis updated the diff for D104681: [lld/mac] Add explicit "no unwind info" entries for functions without unwind info.

upload correct diff

Mon, Jun 21, 7:34 PM · Restricted Project
thakis requested review of D104681: [lld/mac] Add explicit "no unwind info" entries for functions without unwind info.
Mon, Jun 21, 7:31 PM · Restricted Project

Yesterday

thakis committed rG3a6a60f6c9c4: [lld/mac] Make a variable more local; no behavior change (authored by thakis).
[lld/mac] Make a variable more local; no behavior change
Sun, Jun 20, 7:00 PM
thakis added inline comments to D104353: [lld-macho] Avoid force-loading the same archive twice.
Sun, Jun 20, 6:56 PM · Restricted Project, Restricted Project
thakis committed rGe6cb55d5ceb8: [lld/mac] Test zerofill sections after __thread_bss (authored by thakis).
[lld/mac] Test zerofill sections after __thread_bss
Sun, Jun 20, 5:45 PM
thakis closed D104609: [lld/mac] Test zerofill sections after __thread_bss.
Sun, Jun 20, 5:45 PM · Restricted Project, Restricted Project
thakis updated the summary of D104609: [lld/mac] Test zerofill sections after __thread_bss.
Sun, Jun 20, 4:45 PM · Restricted Project, Restricted Project
thakis requested review of D104609: [lld/mac] Test zerofill sections after __thread_bss.
Sun, Jun 20, 4:45 PM · Restricted Project, Restricted Project
thakis accepted D104607: [lld-macho] Have inputOrder default to less than INT_MAX.

Great, thanks!

Sun, Jun 20, 4:30 PM · Restricted Project, Restricted Project

Sat, Jun 19

thakis committed rG1605fce6c307: [gn build] (manually) port b9c05aff205b (MIRTests) (authored by thakis).
[gn build] (manually) port b9c05aff205b (MIRTests)
Sat, Jun 19, 10:04 AM
thakis committed rGc931e12b1d51: [lld/mac] Make sure __thread_ptrs is in front of __thread_bss (authored by thakis).
[lld/mac] Make sure __thread_ptrs is in front of __thread_bss
Sat, Jun 19, 9:57 AM
thakis committed rG17271ece0da6: [lld/mac] Give __DATA,__thread_ptrs type S_THREAD_LOCAL_VARIABLE_POINTERS (authored by thakis).
[lld/mac] Give __DATA,__thread_ptrs type S_THREAD_LOCAL_VARIABLE_POINTERS
Sat, Jun 19, 9:57 AM
thakis closed D104596: [lld/mac] Make sure __thread_ptrs is in front of __thread_bss.
Sat, Jun 19, 9:57 AM · Restricted Project, Restricted Project
thakis closed D104594: [lld/mac] Give __DATA,__thread_ptrs type S_THREAD_LOCAL_VARIABLE_POINTERS.
Sat, Jun 19, 9:57 AM · Restricted Project, Restricted Project
thakis updated the summary of D104596: [lld/mac] Make sure __thread_ptrs is in front of __thread_bss.
Sat, Jun 19, 8:02 AM · Restricted Project, Restricted Project
thakis added a comment to D104596: [lld/mac] Make sure __thread_ptrs is in front of __thread_bss.

The reason it's important that zerofill sections are at the end is because dyld does

Sat, Jun 19, 8:02 AM · Restricted Project, Restricted Project
thakis requested review of D104596: [lld/mac] Make sure __thread_ptrs is in front of __thread_bss.
Sat, Jun 19, 7:59 AM · Restricted Project, Restricted Project
thakis updated the diff for D104594: [lld/mac] Give __DATA,__thread_ptrs type S_THREAD_LOCAL_VARIABLE_POINTERS.

clang-format

Sat, Jun 19, 7:40 AM · Restricted Project, Restricted Project
thakis added inline comments to D102972: [lld-macho][nfc] Sort OutputSections based on explicit order of command-line inputs.
Sat, Jun 19, 7:33 AM · Restricted Project, Restricted Project
thakis requested review of D104594: [lld/mac] Give __DATA,__thread_ptrs type S_THREAD_LOCAL_VARIABLE_POINTERS.
Sat, Jun 19, 7:15 AM · Restricted Project, Restricted Project

Fri, Jun 18

thakis added inline comments to D104353: [lld-macho] Avoid force-loading the same archive twice.
Fri, Jun 18, 6:22 PM · Restricted Project, Restricted Project
thakis added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

FWIW https://lab.llvm.org/buildbot/#/builders/123 has been red for several days after this landed too (eg https://lab.llvm.org/buildbot/#/builders/123/builds/4545)

Fri, Jun 18, 5:55 PM · Restricted Project
thakis added inline comments to D104353: [lld-macho] Avoid force-loading the same archive twice.
Fri, Jun 18, 5:26 PM · Restricted Project, Restricted Project
thakis committed rGc9b241efd68c: Revert "[lld-macho] Avoid force-loading the same archive twice" (authored by thakis).
Revert "[lld-macho] Avoid force-loading the same archive twice"
Fri, Jun 18, 5:26 PM
thakis added a reverting change for rG24706cd73cd1: [lld-macho] Avoid force-loading the same archive twice: rGc9b241efd68c: Revert "[lld-macho] Avoid force-loading the same archive twice".
Fri, Jun 18, 5:26 PM
thakis added a reverting change for D104353: [lld-macho] Avoid force-loading the same archive twice: rGc9b241efd68c: Revert "[lld-macho] Avoid force-loading the same archive twice".
Fri, Jun 18, 5:26 PM · Restricted Project, Restricted Project
thakis added inline comments to D104353: [lld-macho] Avoid force-loading the same archive twice.
Fri, Jun 18, 5:21 PM · Restricted Project, Restricted Project
thakis added inline comments to D104353: [lld-macho] Avoid force-loading the same archive twice.
Fri, Jun 18, 5:17 PM · Restricted Project, Restricted Project
thakis added a comment to D104353: [lld-macho] Avoid force-loading the same archive twice.

Looks like this breaks tests on some windows bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8844046562894240432/+/u/package_clang/stdout?format=raw

$ ":" "RUN: at line 19"
$ "ld64.lld" "-arch" "x86_64" "-platform_version" "macos" "10.15" "11.0" "-syslibroot" "C:/b/s/w/ir/cache/builder/src/third_party/llvm/lld/test\MachO\Inputs\MacOSX.sdk" "-fatal_warnings" "-lSystem" "C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\tools\lld\test\MachO\Output\force-load.s.tmp/foo.o" "-force_load" "C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\tools\lld\test\MachO\Output\force-load.s.tmp/foo.a" "-force_load" "C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\tools\lld\test\MachO\Output\force-load.s.tmp/foo.a" "C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\tools\lld\test\MachO\Output\force-load.s.tmp/test.o" "-o" "/dev/null"
# command stderr:
ld64.lld: error: duplicate symbol: _bar

>>> defined in C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\tools\lld\test\MachO\Output\force-load.s.tmp/foo.a(archive-foo.o)

>>> defined in C:\b\s\w\ir\cache\builder\src\third_party\llvm-bootstrap\tools\lld\test\MachO\Output\force-load.s.tmp/foo.a(archive-foo.o)
Fri, Jun 18, 4:57 PM · Restricted Project, Restricted Project
thakis added a comment to D104353: [lld-macho] Avoid force-loading the same archive twice.

Looks like this breaks tests on some windows bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8844046562894240432/+/u/package_clang/stdout?format=raw

Fri, Jun 18, 4:55 PM · Restricted Project, Restricted Project
thakis added a comment to D88666: DirectoryWatcher: add an implementation for Windows.

We also see check-all timeout recently (fairly consistently), see https://bugs.chromium.org/p/chromium/issues/detail?id=1221702

Fri, Jun 18, 3:53 PM · Restricted Project
thakis added a reverting change for rG76f1baa7875a: Revert "Revert "DirectoryWatcher: add an implementation for Windows"": rGfb32de9e97af: Re-Revert "DirectoryWatcher: add an implementation for Windows".
Fri, Jun 18, 3:53 PM
thakis added a reverting change for rG527a1821e6f8: DirectoryWatcher: also wait for the notifier thread: rGfb32de9e97af: Re-Revert "DirectoryWatcher: add an implementation for Windows".
Fri, Jun 18, 3:53 PM
thakis added a reverting change for rGa6948da86ad7: DirectoryWatcher: close a possible window of race on Windows: rGfb32de9e97af: Re-Revert "DirectoryWatcher: add an implementation for Windows".
Fri, Jun 18, 3:52 PM
thakis committed rGfb32de9e97af: Re-Revert "DirectoryWatcher: add an implementation for Windows" (authored by thakis).
Re-Revert "DirectoryWatcher: add an implementation for Windows"
Fri, Jun 18, 3:52 PM
thakis added a comment to D104354: [lld-macho] Put DATA_IN_CODE immediately after FUNCTION_STARTS.

FYI, strip needs this too. Without this change, the data-in-code change regressed stripping again, with this error:

% strip out/gn/bin/lld
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/strip: fatal error: file not in an order that can be processed (data in code info out of place): /Users/thakis/src/llvm-project/out/gn/bin/lld
Fri, Jun 18, 3:03 PM · Restricted Project, Restricted Project
thakis committed rGf7366890c23f: [lld/mac] Support -data_in_code_info, -function_starts flags (authored by thakis).
[lld/mac] Support -data_in_code_info, -function_starts flags
Fri, Jun 18, 10:06 AM
thakis closed D104543: [lld/mac] Support -data_in_code_info, -function_starts flags.
Fri, Jun 18, 10:06 AM · Restricted Project, Restricted Project
thakis accepted D104548: Rename option -icf MODE to --icf=MODE.

Thanks!

Fri, Jun 18, 9:43 AM · Restricted Project, Restricted Project
thakis added inline comments to D103292: [lld-macho] Implement ICF.
Fri, Jun 18, 9:19 AM · Restricted Project, Restricted Project
thakis added inline comments to D104543: [lld/mac] Support -data_in_code_info, -function_starts flags.
Fri, Jun 18, 8:50 AM · Restricted Project, Restricted Project
thakis requested review of D104543: [lld/mac] Support -data_in_code_info, -function_starts flags.
Fri, Jun 18, 8:50 AM · Restricted Project, Restricted Project
thakis accepted D104514: Allow building for release with EXPENSIVE_CHECKS.
Fri, Jun 18, 6:58 AM · Restricted Project
thakis added a comment to D104028: [llvm][Inliner] Add an optional PriorityInlineOrder.

Looks like this breaks tests on mac: http://45.33.8.238/macm1/11921/step_11.txt

Fri, Jun 18, 3:45 AM · Restricted Project

Thu, Jun 17

thakis accepted D104502: [lld-macho] Handle non-extern symbols marked as private extern.
Thu, Jun 17, 8:31 PM · Restricted Project, Restricted Project
thakis added a comment to D104184: [Coroutine] Properly deal with byval and noalias parameters.

Looks like this breaks tests on windows: http://45.33.8.238/win/40255/step_11.txt

Thu, Jun 17, 7:58 PM · Restricted Project
thakis accepted D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003).

That's a good argument. lgtm.

Thu, Jun 17, 5:14 PM · Restricted Project
thakis requested review of D104466: NOT FOR REVIEW: proof-of-concept for building lib/linux/libclang_rt.profile-x86_64.a on a mac in the gn build.
Thu, Jun 17, 8:00 AM · Restricted Project
thakis added inline comments to D104353: [lld-macho] Avoid force-loading the same archive twice.
Thu, Jun 17, 5:45 AM · Restricted Project, Restricted Project

Wed, Jun 16

thakis added a comment to D57463: Add a module pass for order file instrumentation.

is there any documentation on how to use this? I see that clang has a -forder-file-instrumentation switch to enable this. But what do I do after I enabled it? Run the instrumented program and then…? From the name, I'm guessing maybe the idea is that this will produce an order file?

Wed, Jun 16, 7:15 PM · Restricted Project
thakis added a comment to D57463: Add a module pass for order file instrumentation.

is there any documentation on how to use this? I see that clang has a -forder-file-instrumentation switch to enable this. But what do I do after I enabled it? Run the instrumented program and then…? From the name, I'm guessing maybe the idea is that this will produce an order file?

Wed, Jun 16, 7:01 PM · Restricted Project
thakis added inline comments to D104352: [lld-macho] Handle multiple LC_LINKER_OPTIONs.
Wed, Jun 16, 5:05 PM · Restricted Project, Restricted Project
thakis added inline comments to D104353: [lld-macho] Avoid force-loading the same archive twice.
Wed, Jun 16, 5:04 PM · Restricted Project, Restricted Project
thakis committed rGa127dffc49e5: [gn build] (manually) port f9aba9a5afe (authored by thakis).
[gn build] (manually) port f9aba9a5afe
Wed, Jun 16, 3:05 PM
thakis accepted D104169: [lld-macho][nfc] Put back shouldOmitFromOutput() asserts.

Thanks!

Wed, Jun 16, 11:19 AM · Restricted Project, Restricted Project
thakis accepted D104354: [lld-macho] Put DATA_IN_CODE immediately after FUNCTION_STARTS.
Wed, Jun 16, 10:39 AM · Restricted Project, Restricted Project
thakis accepted D104352: [lld-macho] Handle multiple LC_LINKER_OPTIONs.

Out of interest, how do you end up with an obj file with several of these?

Wed, Jun 16, 10:38 AM · Restricted Project, Restricted Project
thakis added a comment to D104353: [lld-macho] Avoid force-loading the same archive twice.

(I agree with MaskRay that the ELF behavior is nicer, but you solve the problems you have, not the ones you wish you had.)

Wed, Jun 16, 10:36 AM · Restricted Project, Restricted Project
thakis accepted D104353: [lld-macho] Avoid force-loading the same archive twice.
Wed, Jun 16, 10:35 AM · Restricted Project, Restricted Project
thakis added a comment to D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003).

Nice, that's much less convoluted than I had feared :)

Wed, Jun 16, 10:06 AM · Restricted Project
thakis accepted D104346: [lld][MachO] Sort symbols in parallel in -map.

Do you need someone to commit this for you, or do you have commit permissions.

Wed, Jun 16, 3:54 AM · Restricted Project, Restricted Project, lld
thakis committed rGb579938d40b4: [lld/mac] Add support for -no_data_in_code_info flag (authored by thakis).
[lld/mac] Add support for -no_data_in_code_info flag
Wed, Jun 16, 3:43 AM
thakis closed D104345: [lld/mac] Add support for -no_data_in_code_info flag.
Wed, Jun 16, 3:43 AM · Restricted Project, Restricted Project
thakis committed rG46ac1b213ac9: [lld/mac] Put lld-only flags in "LLD-SPECIFIC:" --help section (authored by thakis).
[lld/mac] Put lld-only flags in "LLD-SPECIFIC:" --help section
Wed, Jun 16, 3:40 AM
thakis closed D104347: [lld/mac] Make sure all lld-specific flags show up in the "LLD-SPECIFIC:" --help section.
Wed, Jun 16, 3:39 AM · Restricted Project, Restricted Project

Tue, Jun 15

thakis added a comment to D104346: [lld][MachO] Sort symbols in parallel in -map.

Seems fine, but can you change the patch description to say "When writing a map file, sort symbols in parallel" to make clear that this only affects map file writing?

Tue, Jun 15, 7:07 PM · Restricted Project, Restricted Project, lld
thakis requested review of D104347: [lld/mac] Make sure all lld-specific flags show up in the "LLD-SPECIFIC:" --help section.
Tue, Jun 15, 6:55 PM · Restricted Project, Restricted Project
thakis requested review of D104345: [lld/mac] Add support for -no_data_in_code_info flag.
Tue, Jun 15, 6:40 PM · Restricted Project, Restricted Project
thakis accepted D104333: [lld-macho] Downgrade version mismatch to warning.

Looks like this lacks test coverage if it needs no test update to go along with it?

Tue, Jun 15, 6:39 PM · Restricted Project, Restricted Project

Mon, Jun 14

thakis added inline comments to D104169: [lld-macho][nfc] Put back shouldOmitFromOutput() asserts.
Mon, Jun 14, 9:41 AM · Restricted Project, Restricted Project
thakis added a comment to D104036: [clang][deps] Prevent unintended modifications of the original TU command-line.

Either this or your concurrent commit broke check-clang: http://45.33.8.238/linux/48839/step_7.txt

Mon, Jun 14, 5:11 AM · Restricted Project

Sun, Jun 13

thakis accepted D104195: [ms] [llvm-ml] When parsing MASM, "jmp short" instructions are case insensitive.
Sun, Jun 13, 1:45 PM · Restricted Project
thakis accepted D104177: [lld-macho][nfc] Remove InputSection::outSecFileOff.

I'm a bit surprised that this has such a big effect.

Sun, Jun 13, 1:44 PM · Restricted Project, Restricted Project
thakis added a comment to D103977: [lld-macho][nfc] Move liveness-tracking fields into ConcatInputSection.

But overall, it feels like things get a lot more complicated because we're not creating real InputSections for each literal in literal sections.

I agree, it's quite unfortunate...

Are there so many more literals than normal symboled inputsections? What's the memory / perf hit from just having normal InputSections for each literal?

Good questions! For chromium_framework, here are the relative counts of literals and subsections before deduplication (generated via D104158):

word literals: 145224 (8%)
cstring literals: 353031 (20%)
subsections: 1260720 (72%)

So actual subsections are still by far the largest, but cstrings take up a sizable chunk regardless. I also hacked up a diff that creates one InputSection per string, and even without doing dedup, it's already slower: D104159

The remaining question is... could we trim InputSection's size and close this performance gap? There are definitely opportunities here (e.g. we could replace name, segname, and flags with a pointer to the original section_64 header.) But there's still quite a number of other fields that I doubt can be removed. So while this is not a watertight analysis, I think it's enough to make a case for landing this architectural change.

Sun, Jun 13, 1:44 PM · Restricted Project, Restricted Project
thakis accepted D104199: [lld-macho][nfc] Represent the image loader cache with a ConcatInputSection.
Sun, Jun 13, 1:39 PM · Restricted Project, Restricted Project
thakis committed rG7d4c8a2b8f16: [lld/mac] clarify comment (authored by thakis).
[lld/mac] clarify comment
Sun, Jun 13, 10:30 AM
thakis committed rG5f9bc580d81b: fix comment typos to cycle bots (authored by thakis).
fix comment typos to cycle bots
Sun, Jun 13, 7:19 AM

Fri, Jun 11

thakis added a comment to D103977: [lld-macho][nfc] Move liveness-tracking fields into ConcatInputSection.

You can look at http://45.33.8.238/ , it's public and the Linux bit on it cycles in a little over 3 minutes :)

Fri, Jun 11, 5:49 PM · Restricted Project, Restricted Project
thakis added a comment to D103977: [lld-macho][nfc] Move liveness-tracking fields into ConcatInputSection.

One of your 4 commits broke the build: http://45.33.8.238/linux/48738/step_4.txt

Fri, Jun 11, 4:57 PM · Restricted Project, Restricted Project
thakis added a comment to D86974: [IRSim] Adding basic implementation of llvm-sim..

This seems to break tests everywhere, eg http://45.33.8.238/linux/48721/step_12.txt

Fri, Jun 11, 1:41 PM · Restricted Project
thakis added a comment to D104084: [lld-macho] Add options -(no_)keep_dwarf_unwind.

The intelligent approach isn't _that_ hard, is it? It's < 200 lines in ld64 I think. ld64-linked Chromium Framework leaves some __eh_frame around, so I think removing the whole section generally probably doesn't work.

Yes, I will do it, but wanted this out quickly. (I changed the description to read "... unless and until (maybe later today!) we have a use case ..." :)

When I looked at the CU entries for Chromium Framework, I saw none that had type bits [24..27] == 4, which means UNWIND_X86_64_MODE_DWARF. What am I not seeing?

Fri, Jun 11, 12:36 PM · Restricted Project, Restricted Project
thakis added a comment to D103184: Reland "[AArch64] handle -Wa,-march=".

FWIW the failure goes away locally if I revert this change here, so it's definitely due to this change here.

Things have been red for a while, probably good to revert while you investigate by this point.

Sorry for the delay but my macbook had some issues so I just finished building LLVM, but I can't seem to reproduce the test failure locally (neither by running the test directly with llvm-lit nor with ninja check-clang). In fact I don't quite understand why this test failed. Like @nickdesaulniers mentioned the build failure should have been fixed in https://reviews.llvm.org/rG76d9bc72784d88f4dd57b9939e52c73739438af5 for a different patch. Do you mind sharing the instructions you used to reproduce the test failure? Thanks.

Fri, Jun 11, 10:29 AM · Restricted Project
thakis committed rGf2b1a1e10c5a: [lld/mac] Use sectionType() more (authored by thakis).
[lld/mac] Use sectionType() more
Fri, Jun 11, 8:16 AM
thakis closed D104027: [lld/mac] Use sectionType() more.
Fri, Jun 11, 8:16 AM · Restricted Project, Restricted Project
thakis added a comment to D104084: [lld-macho] Add options -(no_)keep_dwarf_unwind.

The intelligent approach isn't _that_ hard, is it? It's < 200 lines in ld64 I think. ld64-linked Chromium Framework leaves some __eh_frame around, so I think removing the whole section generally probably doesn't work.

Fri, Jun 11, 7:44 AM · Restricted Project, Restricted Project

Thu, Jun 10

thakis committed rG54418c5a355e: [lld/mac] Make binaries written by lld strippable (authored by thakis).
[lld/mac] Make binaries written by lld strippable
Thu, Jun 10, 9:24 PM
thakis closed D104081: [lld/mac] Make binaries written by lld strippable.
Thu, Jun 10, 9:24 PM · Restricted Project, Restricted Project
thakis updated the summary of D104081: [lld/mac] Make binaries written by lld strippable.
Thu, Jun 10, 5:47 PM · Restricted Project, Restricted Project
thakis requested review of D104081: [lld/mac] Make binaries written by lld strippable.
Thu, Jun 10, 5:47 PM · Restricted Project, Restricted Project
thakis committed rG4d11ba38b47d: [gn build] minor TODO.txt update (authored by thakis).
[gn build] minor TODO.txt update
Thu, Jun 10, 9:50 AM
thakis accepted D104008: [ms] [llvm-ml] Warn on command-line redefinition.

LG with tweak below

Thu, Jun 10, 8:50 AM · Restricted Project
thakis added a comment to D104008: [ms] [llvm-ml] Warn on command-line redefinition.

I tried patching this in

Thu, Jun 10, 6:02 AM · Restricted Project
thakis requested review of D104027: [lld/mac] Use sectionType() more.
Thu, Jun 10, 5:59 AM · Restricted Project, Restricted Project
thakis added inline comments to D104008: [ms] [llvm-ml] Warn on command-line redefinition.
Thu, Jun 10, 5:57 AM · Restricted Project
thakis added inline comments to D104008: [ms] [llvm-ml] Warn on command-line redefinition.
Thu, Jun 10, 5:56 AM · Restricted Project
thakis added a comment to D103977: [lld-macho][nfc] Move liveness-tracking fields into ConcatInputSection.

(Also FYI if you use the "Edit Related Revisions…" button in the upper right on phab, the presubmit bots can correctly handle dependent changes)

Thu, Jun 10, 5:55 AM · Restricted Project, Restricted Project
thakis accepted D103977: [lld-macho][nfc] Move liveness-tracking fields into ConcatInputSection.

This change as-is is fine.

Thu, Jun 10, 5:54 AM · Restricted Project, Restricted Project
thakis added inline comments to D103977: [lld-macho][nfc] Move liveness-tracking fields into ConcatInputSection.
Thu, Jun 10, 5:37 AM · Restricted Project, Restricted Project
thakis accepted D103978: [lld-macho][nfc] Have InputSection ctors take some parameters.
Thu, Jun 10, 5:35 AM · Restricted Project, Restricted Project
thakis accepted D103979: [lld-macho] Have dead-stripping work with literal sections.

Nice!

Thu, Jun 10, 5:26 AM · Restricted Project, Restricted Project