- User Since
- Jan 10 2013, 2:43 PM (245 w, 2 d)
Tue, Sep 19
I think for depfile generation, we generally try to be gcc-compatible (I can link to prior changes in this spirit), so I think this seems like a good thing to do to me. gcc only does this for system headers, yes?
Tue, Sep 5
Mon, Sep 4
fix a comment typo
Actually, I talked myself out of this affecting %LINK% / %_LINK_% while writing the patch summary. I removed that bit.
Wed, Aug 30
Thanks, landed in r312167.
Mon, Aug 28
Don't warn in unevaluated contexts. Ready for a look now.
Aug 23 2017
Aug 22 2017
add test from rnk
Aug 21 2017
Just use TryTerminatedBlock
Aug 18 2017
Many driver tests check in a basic representative directory structure (e.g. test/Driver/Inputs/basic_freebsd_tree/ and its many siblings).
This approach looks good to me.
Oh, I guess this is superseded by https://reviews.llvm.org/D36860 ?
Aug 16 2017
Aug 14 2017
Aug 9 2017
Aug 8 2017
Aug 7 2017
Aug 4 2017
Why should this be part of llvm? This seems to come with very heavy dependencies (protobuf), and LLVM has historically tried to minimize the number of things it depends on.
Is landing this blocked on internal testing?
Hm, that's unfortunate. I don't see a good way to rescue this patch.
Aug 3 2017
I'm going to land this. It's early in the 6.0 cycle, so if this causes issues, we should have time to find them and then follow up in case we run into any.
I've reverted this in 309960, as discussed.
(Our workaround is to call __builtin_available() once before engaging the sandbox, which isn't so bad. Just thought I'd let you know about it; this isn't a serious bug for us.)
Looks like the email reply didn't make it to phab, so here it is again:
Aug 2 2017
We just noticed that if you call __builtin_available() for the first time after activating your app's sandbox, the function will fail:
Awesome, thanks! Maybe mention the PR# for this in the commit message.
Jul 28 2017
dim: Does putting the target listing behind a different flag work for you? Which problem are you trying to solve here?
Jul 26 2017
Jul 25 2017
Jul 24 2017
Sorry, I just noticed this weeks later. Why are we adding this to --version instead of adding some new flag for printing this? When I pass --version, I'm usually interested in clang's version and don't need a screenful of other information below it (which makes the output I do care about scroll off the screen).
Jul 23 2017
Most of the patch is unifying all the toolchains to call the newly-introduced ToolChain::ShouldLinkCXXStdlib() instead of all manually checking for D.CCIsCXX() && !getFlag(nostdlib, nodefaultlibs). The actual behavior change is to make that function check the new nostdlib++ flag too.
Jul 21 2017
From what I understand, _MSC_VER changes with each 2017 update.
Jul 17 2017
Jul 14 2017
I went ahead and landed this in r308044, given that I addressed the nits and removed the possibly contentious bits. Happy to address remaining nits in a follow-up.
Mostly done, thanks!
Thanks, all done, much better!
Jul 13 2017
Document *, add example with multiple platforms
Jun 27 2017
May 25 2017
May 24 2017
Either this or the reland of making allow_user_segv_handler to true broke this test on Windows:
The new test fails for me like so, at r303736:
May 10 2017
This looks good to me, thanks. Sorry about the slow turnaround. Do you have commit access? If not, I can land it for you – but it also looks like you've contributed several patches by now, so you could also ask for commit access if you don't have it yet.
May 5 2017
s/Add one/All done/
Thanks! Add one and landed in r302247.
May 4 2017
May 1 2017
Apr 24 2017
Apr 21 2017
Not sure if this is useful, but this is where I always check first.
Apr 19 2017
Looks good to me.
I was just confused again by this not working, and didn't remember this review for a while. From a user's point of view it feels like this should work, so I've gone ahead and landed this in r300692.
Apr 18 2017
I'm out today. Since lld will be a client of the library code of this tool, Rui should probably take a look if he's around this week. I'd also already add a test with just a RUN line for running the tool without parameters, just to have test coverage from day one (makes it easier to add tests in the future once the tool actually does something).
Apr 11 2017
Landed in r299952: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20170410/189882.html
Looks good. Do you have commit access?
This breaks bootstrap builds. I put the error message in the revert commit description: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20170410/444101.html
Apr 6 2017
Mar 27 2017
We have a test in chromium that loads a small so file and calls some of the functions therein. There are no allocations in the so file. The test used to run fine under tsan, now it fails with the error message you added. I'll disable the test under tsan, but maybe others out there where also calling non-allocating so's without problems before this change.
Mar 22 2017
Mar 18 2017
I think this landed in r297900.
Mar 16 2017
Ah ok, thanks for explaining. In that case, this sounds fine and I'll leave the review to zturner.