- User Since
- Jan 10 2013, 2:43 PM (367 w, 5 d)
This breaks check-clang on Windows: http://22.214.171.124/win/6843/step_7.txt
Things have been broken for 1.5 hours now. Time to revert?
This seems to break check-clang everywhere. If the fix isn't obvious, please revert and analyze asynchronously.
This breaks tests on Windows: http://126.96.36.199/win/6812/step_7.txt
Make sense. If it's easy to pull out the one part mentioned above, give that a try, else I think it's fine as-is too.
rnk, could you maybe take a look?
Sat, Jan 25
Not easily. But if this lands, we'll know within a few hours if it helps, we have a bot that does this.
Fri, Jan 24
This is a big diff. But AsmParser is a big interface, so I'm not sure it can be all that much smaller.
This is a duplicate of D72980
I made a reduced repro: https://bugs.llvm.org/show_bug.cgi?id=44652
Heads-up: We're again seeing msan reports after this landed, https://bugs.chromium.org/p/chromium/issues/detail?id=1045291
Thu, Jan 23
Looks like this landed in November: http://reviews.llvm.org/rG703c26f03be74daf6e483380e6b23029a3851081
(ps: I think you've contributed enough good patches to apply for commit access: https://llvm.org/docs/DeveloperPolicy.html#new-contributors)
Wed, Jan 22
This seems to break tests everywhere, e.g. http://188.8.131.52/linux/8152/step_12.txt
Tests on Windows have been broken for over 12h now: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/13808 I've reverted this for now in cd470717d15854fb778f2c96667ba36672af6cf5 . Sorry about the toil!
I figured out the incremental build test problem, see D73202.
Have you seen D67747? Probably makes sense to combine forces there.
Looks like this breaks tests: http://184.108.40.206/linux/8102/step_8.txt
Looks like this breaks tests on Windows: http://220.127.116.11/win/6326/step_11.txt
Mon, Jan 20
Only supporting x86 targets for llvm-ml makes sense to me. As far as I know, msvc doesn't have an ml.exe for arm64 either (?).
Sun, Jan 19
Sat, Jan 18
Doesn't this still break check-clang everywhere? See e.g. http://18.104.22.168/linux/7860/step_7.txt
Fri, Jan 17
Bleh, forgot to add "Differential Revision:" footer. Landed in 1d568bf9605c05ff088b244d7894ab2d88da9811
Realistically, the the only way to find out if this works is to land and see.
This breaks check-llvm everywhere, e.g. http://22.214.171.124/linux/7807/step_12.txt
This breaks check-clang everywhere, see e.g. http://126.96.36.199/linux/7798/step_7.txt
cl.exe prints a different error: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/13716/steps/stage%201%20build/logs/stdio
Looks like this isn't building on Windows: http://188.8.131.52/win/6039/step_4.txt
Thu, Jan 16
Thanks, Windows cycled green: http://184.108.40.206/win/5959/summary.html
In addition to the lit issue on Windows, it looks like the test is also missing a REQUIRES: powerpc-registered-target line: http://lab.llvm.org:8011/builders/clang-cmake-armv7-quick/builds/12986/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Aaix-pic-setting.ll
Also, this breaks tests on Windows: http://220.127.116.11/win/5946/step_11.txt
A very late follow-up to my question in D37272 :)
Wed, Jan 15
Looks fine to me as a first step, with more uncommented code and a not very actionable FIXME removed :)
cc cfe-commits for completeness