Page MenuHomePhabricator

thakis (Nico Weber)
UserEmail Not Verified

Projects

User does not belong to any projects.

User Details

User Since
Jan 10 2013, 2:43 PM (402 w, 5 d)

Recent Activity

Mon, Sep 28

thakis committed rGd89735133582: [gn build] Re-run CompletionModelCodegen when input json files change (authored by thakis).
[gn build] Re-run CompletionModelCodegen when input json files change
Mon, Sep 28, 1:58 PM

Sat, Sep 26

thakis committed rG46b671a90868: [gn build] update TODO (authored by thakis).
[gn build] update TODO
Sat, Sep 26, 9:43 AM

Thu, Sep 24

thakis added a comment to D88054: [lld-macho] handle options -search_paths_first, -search_dylibs_first.

All devs do incremental builds. Of course incremental builds should work.

Thu, Sep 24, 7:32 AM · Restricted Project
thakis committed rG0389eff4047a: lld: Try to fix check-lld on incremental builds after 8f2c31f22b974da (authored by thakis).
lld: Try to fix check-lld on incremental builds after 8f2c31f22b974da
Thu, Sep 24, 6:34 AM
thakis added a comment to D88054: [lld-macho] handle options -search_paths_first, -search_dylibs_first.

Sounds like that puts it in the "takes a while to figure out" category, so revert for now?

Thu, Sep 24, 3:36 AM · Restricted Project

Wed, Sep 23

thakis added a comment to D88054: [lld-macho] handle options -search_paths_first, -search_dylibs_first.

This seems to break tests everywhere, eg http://45.33.8.238/linux/28628/step_11.txt

Wed, Sep 23, 5:19 PM · Restricted Project
thakis accepted D88056: [gn build] Allow option to build with asan/tsan/ubsan.

I believe I used this (by hacking up the gn files) locally on mac a while ago, but I'm not sure. LG, I'll try asan on mac and relax the assert if it works.

Wed, Sep 23, 10:23 AM · Restricted Project

Sat, Sep 19

thakis added inline comments to D86805: [lld-macho] create __TEXT,__unwind_info from __LD,__compact_unwind.
Sat, Sep 19, 6:17 AM · Restricted Project
thakis committed rGe22a4fd59de6: lld/mach-o: Make tool scripts from 2124ca1d5cb py2.7-compatible (authored by thakis).
lld/mach-o: Make tool scripts from 2124ca1d5cb py2.7-compatible
Sat, Sep 19, 6:17 AM
thakis committed rG70409b2897f2: [gn build] Port 2124ca1d5cb (authored by thakis).
[gn build] Port 2124ca1d5cb
Sat, Sep 19, 6:17 AM
thakis added inline comments to D86805: [lld-macho] create __TEXT,__unwind_info from __LD,__compact_unwind.
Sat, Sep 19, 5:33 AM · Restricted Project
thakis committed rGec9fb7327744: [gn build] (manually) merge 2124ca1d5 (authored by thakis).
[gn build] (manually) merge 2124ca1d5
Sat, Sep 19, 5:30 AM
thakis added a reverting change for rG90fffdd0f705: Revert "[gn build] (manually) port 9b6765e784b3" anf follow-ups: rG3618ac203f17: Revert "Revert "[gn build] (manually) port 9b6765e784b3" anf follow-ups".
Sat, Sep 19, 5:29 AM
thakis committed rG3618ac203f17: Revert "Revert "[gn build] (manually) port 9b6765e784b3" anf follow-ups" (authored by thakis).
Revert "Revert "[gn build] (manually) port 9b6765e784b3" anf follow-ups"
Sat, Sep 19, 5:29 AM

Fri, Sep 18

thakis added a comment to rG549e55b3d563: Temporarily Revert "[clangd] Add Random Forest runtime for code completion.".

I agree, it does look pretty complicated :)

Fri, Sep 18, 7:03 PM
thakis committed rG528a1f121c55: [gn build] (manually) port 5495b691646 (authored by thakis).
[gn build] (manually) port 5495b691646
Fri, Sep 18, 6:33 PM
thakis added a comment to rG549e55b3d563: Temporarily Revert "[clangd] Add Random Forest runtime for code completion.".

Which header do you think is missing? It built fine on several machines over here.

Fri, Sep 18, 6:15 PM
thakis added a reverting change for rG442801a7b9b5: [gn build] (manually) port 9b6765e784b3: rG90fffdd0f705: Revert "[gn build] (manually) port 9b6765e784b3" anf follow-ups.
Fri, Sep 18, 6:15 PM
thakis added a reverting change for rG929d91a55616: [gn build] (manually) port 9b6765e784b3 more: rG90fffdd0f705: Revert "[gn build] (manually) port 9b6765e784b3" anf follow-ups.
Fri, Sep 18, 6:15 PM
thakis added a reverting change for rG7c2d83347f4e: [gn build] add file i forgot to add in 929d91a55616: rG90fffdd0f705: Revert "[gn build] (manually) port 9b6765e784b3" anf follow-ups.
Fri, Sep 18, 6:15 PM
thakis committed rG90fffdd0f705: Revert "[gn build] (manually) port 9b6765e784b3" anf follow-ups (authored by thakis).
Revert "[gn build] (manually) port 9b6765e784b3" anf follow-ups
Fri, Sep 18, 6:15 PM
thakis committed rG807777913e82: CompletionModelCodegen: Remove unused import (authored by thakis).
CompletionModelCodegen: Remove unused import
Fri, Sep 18, 1:25 PM
thakis committed rG7502040ed25e: clang: Make changes in 7c8bb409f31e py2.7-compatible (authored by thakis).
clang: Make changes in 7c8bb409f31e py2.7-compatible
Fri, Sep 18, 1:19 PM
thakis committed rG7c2d83347f4e: [gn build] add file i forgot to add in 929d91a55616 (authored by thakis).
[gn build] add file i forgot to add in 929d91a55616
Fri, Sep 18, 1:01 PM
thakis committed rG929d91a55616: [gn build] (manually) port 9b6765e784b3 more (authored by thakis).
[gn build] (manually) port 9b6765e784b3 more
Fri, Sep 18, 12:57 PM
thakis committed rG9b346f974ea6: [gn build] Do not sync filenames containing variable references (authored by thakis).
[gn build] Do not sync filenames containing variable references
Fri, Sep 18, 12:34 PM
thakis committed rG442801a7b9b5: [gn build] (manually) port 9b6765e784b3 (authored by thakis).
[gn build] (manually) port 9b6765e784b3
Fri, Sep 18, 12:27 PM
thakis committed rG0ea2a5727422: clangd: Make ompletionModelCodegen.py tpy2.7 compatible (authored by thakis).
clangd: Make ompletionModelCodegen.py tpy2.7 compatible
Fri, Sep 18, 12:27 PM
thakis added inline comments to D83004: [UpdateCCTestChecks] Include generated functions if asked.
Fri, Sep 18, 7:02 AM · Restricted Project, Restricted Project
thakis accepted D87400: [ms] [llvm-ml] Add support for .radix directive, and accept all radix specifiers.

lg assuming we have tests for float literals containing an e in them somewhere already.

Fri, Sep 18, 6:38 AM · Restricted Project

Thu, Sep 17

thakis committed rG504697e6f40e: [gn build] (manually) port c9af34027bc (authored by thakis).
[gn build] (manually) port c9af34027bc
Thu, Sep 17, 3:37 AM

Wed, Sep 16

thakis committed rG0c6a56e41dbe: [gn build] (manually) port 1321160a2 (authored by thakis).
[gn build] (manually) port 1321160a2
Wed, Sep 16, 3:29 PM
thakis committed rG15c378f6e641: [gn build] unconfuse sync script about "sources = []" in… (authored by thakis).
[gn build] unconfuse sync script about "sources = []" in…
Wed, Sep 16, 11:50 AM
thakis added a comment to D87727: [obj2yaml] - Match ".stack_size" with the original section name, and not the uniquified name..

Looks like this doesn't build: http://45.33.8.238/linux/27982/step_4.txt

Wed, Sep 16, 11:38 AM · Restricted Project
thakis committed rGb3d33f5e838f: [gn build] make "all" target build (authored by thakis).
[gn build] make "all" target build
Wed, Sep 16, 11:22 AM
thakis added a comment to D86360: Add new hidden option -print-changed which only reports changes to IR.

This seems to break tests on most bots, e.g. http://45.33.8.238/linux/27972/step_12.txt

Wed, Sep 16, 10:44 AM · Restricted Project

Tue, Sep 15

thakis added a comment to D86156: [BFI] Make BFI information available through loop passes inside LoopStandardAnalysisResults.

Looks like this breaks tests: http://45.33.8.238/linux/27942/step_12.txt

Tue, Sep 15, 6:44 PM · Restricted Project, Restricted Project
thakis added a comment to D86923: [llvm-readobj/elf] - Don't crash when the size of a dynamic symbol table, inferred from the hash table, is broken..

Looks like this breaks tests on mac: http://45.33.8.238/mac/20491/step_11.txt

Tue, Sep 15, 3:14 PM · Restricted Project
thakis committed rG57752b144944: [gn build] (semi-manually) port 380e746bcca (authored by thakis).
[gn build] (semi-manually) port 380e746bcca
Tue, Sep 15, 6:26 AM
thakis added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

It's not blocking us because we added an explicit flag to force this off to our build config for "normal" builds. (We still get the default-on behavior on our bots that build with trunk clang.) But if others are seeing problems with this too, I think it makes sense to revert so others don't spend time tracking down miscompiles to this commit.

Tue, Sep 15, 6:01 AM · Restricted Project, Restricted Project

Mon, Sep 14

thakis requested changes to D63697: clang-format: Fix error return when using inplace with stdin.

(marking this "request changes" to get it off my dashboard. please ping if you do add a test :) )

Mon, Sep 14, 1:08 PM · Restricted Project, Restricted Project
thakis added inline comments to D87400: [ms] [llvm-ml] Add support for .radix directive, and accept all radix specifiers.
Mon, Sep 14, 12:59 PM · Restricted Project
thakis added inline comments to D87400: [ms] [llvm-ml] Add support for .radix directive, and accept all radix specifiers.
Mon, Sep 14, 10:27 AM · Restricted Project
thakis accepted D87401: [ms] [llvm-ml] Add MASM hex float support.
Mon, Sep 14, 10:25 AM · Restricted Project
thakis accepted D87402: [ms] [llvm-ml] Add REAL10 support (x87 extended precision).
Mon, Sep 14, 10:24 AM · Restricted Project
thakis accepted D87403: [ms] [llvm-ml] Add support for "alias" directive.

Maybe have a test covering the parse error case too.

Mon, Sep 14, 10:22 AM · Restricted Project
thakis accepted D87246: [ms] [llvm-ml] Add missing built-in type aliases.
Mon, Sep 14, 10:03 AM · Restricted Project

Sun, Sep 13

thakis added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Heads-up: We're seeing fairly widespread test failures with this in Chromium that go away when we force this flag off. It's possible that it's due to only a small number of issues and they might be previously-benign UB (no idea), but I figured I'd give an early note. We'll send an update once we've reduced a failing test.

Sun, Sep 13, 6:59 PM · Restricted Project, Restricted Project

Sat, Sep 12

thakis added a comment to D87163: [DSE] Switch to MemorySSA-backed DSE by default..

The fix-up breaks tests: http://45.33.8.238/linux/27687/step_12.txt

Sat, Sep 12, 11:27 AM · Restricted Project, Restricted Project

Fri, Sep 11

thakis committed rG87494def4830: [gn build] slightly improve libcxx_needs_site_config (authored by thakis).
[gn build] slightly improve libcxx_needs_site_config
Fri, Sep 11, 8:33 AM

Thu, Sep 10

thakis added a comment to D86843: [EarlyCSE] Equivalent SELECTs should hash equally.

Looks like this broke check-llvm: http://45.33.8.238/linux/27555/step_12.txt

Thu, Sep 10, 4:57 PM · Restricted Project
thakis committed rG5692497aef08: [gn build] (semi-manually) port 009cd4e4910 (authored by thakis).
[gn build] (semi-manually) port 009cd4e4910
Thu, Sep 10, 12:16 PM
thakis closed D87118: Add an explicit toggle for the static analyzer in clang-tidy.
Thu, Sep 10, 9:21 AM · Restricted Project
thakis committed rG29cecbc5d6fe: Fix clangd build after 33c9dbbd380 (authored by thakis).
Fix clangd build after 33c9dbbd380
Thu, Sep 10, 8:06 AM
thakis committed rG33c9dbbd3809: Add an explicit toggle for the static analyzer in clang-tidy (authored by thakis).
Add an explicit toggle for the static analyzer in clang-tidy
Thu, Sep 10, 7:48 AM

Wed, Sep 9

thakis added inline comments to D87118: Add an explicit toggle for the static analyzer in clang-tidy.
Wed, Sep 9, 11:35 AM · Restricted Project
thakis added inline comments to D87118: Add an explicit toggle for the static analyzer in clang-tidy.
Wed, Sep 9, 11:32 AM · Restricted Project
thakis added inline comments to D87118: Add an explicit toggle for the static analyzer in clang-tidy.
Wed, Sep 9, 11:21 AM · Restricted Project

Tue, Sep 8

thakis added a comment to D87246: [ms] [llvm-ml] Add missing built-in type aliases.

test?

Tue, Sep 8, 10:47 AM · Restricted Project
thakis accepted D87248: [ms] [llvm-ml] Fix struct padding logic.
Tue, Sep 8, 10:47 AM · Restricted Project
thakis accepted D86947: [ms] [llvm-ml] Add support for size queries in MASM.
Tue, Sep 8, 10:46 AM · Restricted Project
thakis committed rG9933188c9061: StructPackAlignCheck: Fix a -Winconsistent-missing-override warning (authored by thakis).
StructPackAlignCheck: Fix a -Winconsistent-missing-override warning
Tue, Sep 8, 7:02 AM
thakis committed rGe09e1d97c112: [gn build] (manually) port 156b127945a8 (authored by thakis).
[gn build] (manually) port 156b127945a8
Tue, Sep 8, 7:01 AM

Fri, Sep 4

thakis added inline comments to D83038: [clang] Add an option for hiding line numbers in diagnostics.
Fri, Sep 4, 12:38 PM
thakis accepted D83038: [clang] Add an option for hiding line numbers in diagnostics.
Fri, Sep 4, 12:36 PM
thakis committed rGfab60665ebc5: sanitizer_common: Implement COMPILER_CHECK using static_assert (authored by thakis).
sanitizer_common: Implement COMPILER_CHECK using static_assert
Fri, Sep 4, 8:08 AM
thakis added a comment to D86917: [Asan] Cleanup atomic usage in allocator.

Reverted this (and some follow-ups that caused conflicts during the revert) in rGdbf04aaade235a0d76c6ad549c091c9fd0ada0e8 to unbreak the Windows build.

Fri, Sep 4, 7:52 AM · Restricted Project
thakis added a reverting change for rG8b8be6f38ab5: [Asan] Cleanup atomic usage in allocator: rGdbf04aaade23: Revert "[Asan] Cleanup atomic usage in allocator".
Fri, Sep 4, 7:51 AM
thakis committed rGdbf04aaade23: Revert "[Asan] Cleanup atomic usage in allocator" (authored by thakis).
Revert "[Asan] Cleanup atomic usage in allocator"
Fri, Sep 4, 7:51 AM
thakis added a reverting change for D86917: [Asan] Cleanup atomic usage in allocator: rGdbf04aaade23: Revert "[Asan] Cleanup atomic usage in allocator".
Fri, Sep 4, 7:51 AM · Restricted Project
thakis committed rG2a03f270d69c: clang: Add test for -Wunreachable-code + weak redeclaration (authored by thakis).
clang: Add test for -Wunreachable-code + weak redeclaration
Fri, Sep 4, 7:36 AM
thakis added a comment to D84625: Execute llvm-lit with the python found by CMake by default.

(I fixed this in the GN build in rGc88a77620436ee475d54d3b5ced30286101e0dc9 and don't care all that much about what happens in the cmake build, so if y'all are happy with what currently happens, it's fine to not change anything here, but it looks strange to me.)

Fri, Sep 4, 7:24 AM · Restricted Project
thakis committed rGc88a77620436: [gn build] fix llvm-lit after d23b15cc16077 (authored by thakis).
[gn build] fix llvm-lit after d23b15cc16077
Fri, Sep 4, 7:24 AM
thakis added a comment to D84625: Execute llvm-lit with the python found by CMake by default.

(ps: No need to touch files in llvm/utils/gn at all, keeping that code updates is up to folks using the gn build.)

Fri, Sep 4, 7:21 AM · Restricted Project
thakis added a comment to D84625: Execute llvm-lit with the python found by CMake by default.

This puts #!/usr/bin/python3.8 instead of #!/usr/bin/env python3.8 in llvm-bulid/bin/llvm-lit (in a cmake build). That seems undesirable?

Fri, Sep 4, 7:21 AM · Restricted Project
thakis added a reverting change for rGe6393ee81317: Canonicalize declaration pointers when forming APValues.: rG7b0332389afd: Revert "Canonicalize declaration pointers when forming APValues.".
Fri, Sep 4, 7:14 AM
thakis committed rG7b0332389afd: Revert "Canonicalize declaration pointers when forming APValues." (authored by thakis).
Revert "Canonicalize declaration pointers when forming APValues."
Fri, Sep 4, 7:14 AM

Thu, Sep 3

thakis requested review of D87118: Add an explicit toggle for the static analyzer in clang-tidy.
Thu, Sep 3, 5:07 PM · Restricted Project
thakis added inline comments to D86947: [ms] [llvm-ml] Add support for size queries in MASM.
Thu, Sep 3, 2:05 PM · Restricted Project
thakis added a comment to D78245: [LIT] Make `%T` unique for every test.

rG82f3c5d4a66 cross-ref so i can find this faster next time

Thu, Sep 3, 1:15 PM · Restricted Project, Restricted Project, Restricted Project
thakis accepted D86946: [ms] [llvm-ml] Allow use of locally-defined variables in expressions.
Thu, Sep 3, 1:14 PM · Restricted Project
thakis added a comment to D83038: [clang] Add an option for hiding line numbers in diagnostics.

Generally seems fine, nits below:

Thu, Sep 3, 1:13 PM
thakis added a comment to D86762: [ELF] Add documentation for --warn-backrefs: a GNU ld compatibility checking tool (and lesser of layering detection).

I don't think this should become the default.

Thu, Sep 3, 1:12 PM · Restricted Project
thakis accepted D86944: [ms] [llvm-ml] Add support for bitwise named operators (AND, NOT, OR) in MASM.
Thu, Sep 3, 1:09 PM · Restricted Project
thakis accepted D86945: [ms] [llvm-ml] Fix STRUCT field alignment.
Thu, Sep 3, 1:08 PM · Restricted Project
thakis accepted D86948: [ms] [llvm-ml] Add basic support for SEH, including PROC FRAME.
Thu, Sep 3, 1:07 PM · Restricted Project
thakis accepted D87100: Remove #llvm buildbot as it doesn't scale to the size of the project anymore.

Thanks!

Thu, Sep 3, 1:06 PM

Wed, Sep 2

thakis committed rG1426ac048295: [gn build] Fix COMPILER_RT_HAS_* defines for libclang_rt.profile (authored by thakis).
[gn build] Fix COMPILER_RT_HAS_* defines for libclang_rt.profile
Wed, Sep 2, 11:30 AM
thakis added a comment to D86290: Move all fields of '-cc1' option related classes into def file databases.

Looks like this broke tests on windows: http://45.33.8.238/win/23171/step_7.txt

Wed, Sep 2, 5:25 AM · Restricted Project

Tue, Sep 1

thakis committed rGab919eed2115: [gn build] port 5ffd940ac02 a bit more (authored by thakis).
[gn build] port 5ffd940ac02 a bit more
Tue, Sep 1, 11:30 AM
thakis added a comment to D86344: [FileCheck] Move FileCheck implementation out of LLVMSupport into its own library.

Thanks for updating the GN files! I just wanted to point out that updating them is completely optional.

Tue, Sep 1, 11:27 AM · Restricted Project

Aug 27 2020

thakis added a comment to D86180: [lld-macho] Make it possible to re-export .tbd files.

One of the N patches that landed 9:45 pm eastern yesterday seems to break check-lld on mac: http://45.33.8.238/mac/19510/step_10.txt

Aug 27 2020, 3:28 AM · Restricted Project

Aug 25 2020

thakis added a comment to D86496: [not][test] Fix disable-symbolization.test when 'printenv' is not available.

@thakis Do you think you can add printenv.exe into https://commondatastorage.googleapis.com/chromium-browser-clang/tools/gnuwin-XX.zip so we can enable the test again on Windows? Please see https://reviews.llvm.org/D86170#inline-799301

Aug 25 2020, 7:01 AM · Restricted Project

Aug 24 2020

thakis added a comment to D86496: [not][test] Fix disable-symbolization.test when 'printenv' is not available.

(I'm guessing it was failing under cmd previously and fails in msys/gig bash now?)

Aug 24 2020, 6:45 PM · Restricted Project
thakis added a comment to D86496: [not][test] Fix disable-symbolization.test when 'printenv' is not available.

This breaks check-llvm on windows: http://45.33.8.238/win/22625/step_11.txt

Aug 24 2020, 6:44 PM · Restricted Project

Aug 21 2020

thakis committed rG72d0f0948988: [gn build] Port 57903cf0933 -- https://reviews.llvm.org/rG57903cf0933 (authored by thakis).
[gn build] Port 57903cf0933 -- https://reviews.llvm.org/rG57903cf0933
Aug 21 2020, 9:03 AM
thakis added inline comments to D86036: [compiler-rt][RISCV] Use muldi3 builtin assembly implementation.
Aug 21 2020, 9:02 AM · Restricted Project

Aug 18 2020

thakis added a reverting change for rGbe3ef93bf58a: PR44685: DebugInfo: Handle address-use-invalid type units referencing non-type…: rGb4bffdbadfcc: Revert "PR44685: DebugInfo: Handle address-use-invalid type units referencing….
Aug 18 2020, 5:41 AM
thakis committed rGb4bffdbadfcc: Revert "PR44685: DebugInfo: Handle address-use-invalid type units referencing… (authored by thakis).
Revert "PR44685: DebugInfo: Handle address-use-invalid type units referencing…
Aug 18 2020, 5:41 AM

Aug 14 2020

thakis added a comment to D83667: [ARM] Fix IT block generation after Thumb2SizeReduce with -Oz.

(I made the crbug public again)

Aug 14 2020, 1:19 PM · Restricted Project