Page MenuHomePhabricator

dreachem (Deepak Eachempati)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 5 2019, 7:41 AM (160 w, 2 d)

Recent Activity

Feb 10 2022

dreachem requested review of D119440: [OpenMP][NFC] update status for 5.1 'nothing' directive to 'worked on'.
Feb 10 2022, 7:17 AM · Restricted Project

Dec 16 2021

dreachem requested review of D115901: [OpenMP][NFC] update status for 5.1 'fail' atomic extension.
Dec 16 2021, 1:26 PM · Restricted Project

Nov 18 2021

dreachem added a comment to D113540: [OpenMP] support depend clause for taskwait directive.

I don't have commit access. Can someone commit this for me? Thanks.

Nov 18 2021, 1:28 PM · Unknown Object (Project), Restricted Project
dreachem added a comment to D113540: [OpenMP] support depend clause for taskwait directive.

I think I've addressed the first set of comments. I added a TODO comment for the OMP IRBuilder (HPE has not implemented this). I also added a diagnostic error message for the case of a mutexinoutset being specified in a depend clause on the taskwait directive, as this is specifically disallowed. Can reviewers take another look and let me know if this looks ready?

Nov 18 2021, 9:00 AM · Unknown Object (Project), Restricted Project
dreachem accepted D114005: [OpenMP][Tools] Fix handling of initial-task-end.
Nov 18 2021, 8:57 AM · Restricted Project, Unknown Object (Project)
dreachem added a comment to D114005: [OpenMP][Tools] Fix handling of initial-task-end.

Thanks. This LGTM.

Nov 18 2021, 6:53 AM · Restricted Project, Unknown Object (Project)

Nov 16 2021

dreachem added a comment to D114005: [OpenMP][Tools] Fix handling of initial-task-end.

What happens for a teams construct? The implicit tasks in that case are all initial tasks. Should this Data->Team->Delete() apply there as well, or only for the implicit parallel region for the whole program?

Nov 16 2021, 8:59 AM · Restricted Project, Unknown Object (Project)

Nov 10 2021

dreachem updated the diff for D113540: [OpenMP] support depend clause for taskwait directive.

Updated comments, added TODO for handing extended taskwait directive in the OpenMPIRBuilder, and added semantic check that 'mutexinoutset' should not be specified in the 'depend' clause on 'taskwait'.

Nov 10 2021, 4:14 PM · Unknown Object (Project), Restricted Project
dreachem added inline comments to D113540: [OpenMP] support depend clause for taskwait directive.
Nov 10 2021, 1:58 PM · Unknown Object (Project), Restricted Project
dreachem added inline comments to D113540: [OpenMP] support depend clause for taskwait directive.
Nov 10 2021, 12:45 PM · Unknown Object (Project), Restricted Project

Nov 9 2021

dreachem requested review of D113540: [OpenMP] support depend clause for taskwait directive.
Nov 9 2021, 8:47 PM · Unknown Object (Project), Restricted Project

Oct 29 2021

dreachem added inline comments to D111788: [OpenMP] Add OMPT support for omp_all_memory task dependence.
Oct 29 2021, 11:21 AM · Unknown Object (Project)

Oct 22 2021

dreachem added a comment to D112292: [Clang][OpenMP] Allow loop iteration var with threadprivate directive.

There still exists a restriction that the loop variable must not be threadprivate in OpenMP 5.1. See Canonical Loop Nest restrictions, p125, line 7:

Oct 22 2021, 12:57 PM · Unknown Object (Project), Restricted Project

Oct 3 2021

dreachem added inline comments to D110193: [RFC] Initial documentation for declare target indirect support..
Oct 3 2021, 4:33 PM · Unknown Object (Project)

Dec 16 2020

dreachem added a comment to D91944: OpenMP 5.0 metadirective.

This looks close to an OpenMP 5.0 implementation. I left comments inlined.

We need tests that show how non-selected alternatives *do not* impact the program. As an example, a template instantiation inside of a non-selected alternative is not actually performed.

We also need test with ill-formed metadirectives.

Dec 16 2020, 5:58 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Nov 5 2020

dreachem added a comment to D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC].

I don't have commit access. @jdoerfert, please commit the change if you think it's ready. Thanks.

Nov 5 2020, 2:10 PM · Restricted Project
dreachem updated the diff for D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC].

Marking the "begin/end declare variant" feature as 'done' in the 5.1 table.

Nov 5 2020, 2:05 PM · Restricted Project
dreachem added inline comments to D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC].
Nov 5 2020, 7:11 AM · Restricted Project

Nov 4 2020

dreachem requested review of D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC].
Nov 4 2020, 3:21 PM · Restricted Project

Jan 22 2020

dreachem added inline comments to D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC].
Jan 22 2020, 12:42 PM · Restricted Project

Nov 7 2019

dreachem added a comment to D69923: [OPENMP][DOCS] Update OpenMP status (NFC).

I don't believe I have commit permissions on this. @ABataev, can you commit this? Thanks.

Nov 7 2019, 8:00 AM · Restricted Project

Nov 6 2019

dreachem created D69923: [OPENMP][DOCS] Update OpenMP status (NFC).
Nov 6 2019, 2:24 PM · Restricted Project