Page MenuHomePhabricator

hans (Hans Wennborg)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 6:48 AM (335 w, 3 d)

Recent Activity

Today

hans added inline comments to D67851: llvm-undname: Add support for demangling typeinfo names.
Mon, Sep 23, 1:54 AM · Restricted Project
hans added inline comments to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Mon, Sep 23, 1:54 AM · Restricted Project
hans committed rL372559: Adding 9.0.0 binaries for Ubuntu.
Adding 9.0.0 binaries for Ubuntu
Mon, Sep 23, 1:41 AM
hans accepted D67851: llvm-undname: Add support for demangling typeinfo names.
Mon, Sep 23, 1:41 AM · Restricted Project
hans committed rL372547: Add 9.0.0 PowerPC binaries.
Add 9.0.0 PowerPC binaries
Mon, Sep 23, 12:03 AM

Fri, Sep 20

hans committed rL372382: Check in 9.0.0 Win binaries.
Check in 9.0.0 Win binaries
Fri, Sep 20, 4:12 AM
hans added inline comments to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Fri, Sep 20, 12:12 AM · Restricted Project

Thu, Sep 19

hans committed rL372331: Fix link text.
Fix link text
Thu, Sep 19, 7:59 AM
hans committed rL372330: Link to the 9.0.0 release.
Link to the 9.0.0 release
Thu, Sep 19, 7:53 AM
hans committed rL372329: Add 9.0.0/LICENSE.TXT.
Add 9.0.0/LICENSE.TXT
Thu, Sep 19, 7:39 AM
hans committed rL372328: Check in 9.0.0 source and docs.
Check in 9.0.0 source and docs
Thu, Sep 19, 7:33 AM
hans committed rL372314: Revert r372285 "GlobalISel: Don't materialize immarg arguments to intrinsics".
Revert r372285 "GlobalISel: Don't materialize immarg arguments to intrinsics"
Thu, Sep 19, 5:35 AM
hans committed rL372312: [cmake] Strip quotes in try_compile_only.
[cmake] Strip quotes in try_compile_only
Thu, Sep 19, 4:29 AM
hans added a comment to D62063: CMake changes to get Windows self-host with PGO working.

I've committed a horrible workaround in r372312.

Thu, Sep 19, 4:29 AM · Restricted Project
hans added a comment to D62063: CMake changes to get Windows self-host with PGO working.

Sadly, we're seeing more breakages on Mac, where CMake test compiles for e.g. armv7 ios are failing with:

Thu, Sep 19, 2:36 AM · Restricted Project

Wed, Sep 18

hans committed rL372226: Follow-up to r372209: Use single quotes for host_ldflags in the lit config.
Follow-up to r372209: Use single quotes for host_ldflags in the lit config
Wed, Sep 18, 7:17 AM
hans added a comment to D62063: CMake changes to get Windows self-host with PGO working.

Maybe config.host_ldflags should be using single quotes?

Wed, Sep 18, 7:16 AM · Restricted Project
hans added a comment to D62063: CMake changes to get Windows self-host with PGO working.

Sadly, this seems to break the lit tests on Mac when building with a profile.

Wed, Sep 18, 6:50 AM · Restricted Project
hans committed rL372225: Revert r372082 "[Clang] Pragma vectorize_width() implies vectorize(enable)".
Revert r372082 "[Clang] Pragma vectorize_width() implies vectorize(enable)"
Wed, Sep 18, 6:41 AM
hans accepted D62063: CMake changes to get Windows self-host with PGO working.
In D62063#1673013, @rnk wrote:

@hans has been trying to build clang with PGO on Windows, so I'll defer this to him.

Wed, Sep 18, 2:26 AM · Restricted Project
hans added inline comments to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.
Wed, Sep 18, 12:18 AM · Restricted Project

Tue, Sep 17

hans accepted D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

lgtm with comments

Tue, Sep 17, 6:42 AM · Restricted Project
hans committed rL372100: Merging r371969:.
Merging r371969:
Tue, Sep 17, 3:17 AM

Mon, Sep 16

hans accepted D67606: Change signature of __builtin_rotateright64 back to unsigned.

Looks good to me! (with comment)

Mon, Sep 16, 2:27 AM · Restricted Project, Restricted Project
hans committed rL371964: ReleaseNotes: known issue: PR40547.
ReleaseNotes: known issue: PR40547
Mon, Sep 16, 2:10 AM
hans added a comment to D67606: Change signature of __builtin_rotateright64 back to unsigned.

A simpler way to test this might be to check for conversion warnings in the existing clang/test/CodeGen/avr-builtins.c test, for example like as above. I think that's better since it covers more of the signatures, e.g. the rotateleft ones too.

Mon, Sep 16, 1:29 AM · Restricted Project, Restricted Project

Fri, Sep 13

hans committed rL371821: Merging r371766:.
Merging r371766:
Fri, Sep 13, 1:14 AM
hans added a comment to D67507: Refer to IEEE 754-2019 in langref instead of 2018 draft.

@hans, is it too late for this to be considered as a candidate for the 9.0.0 release?

Fri, Sep 13, 12:58 AM · Restricted Project
hans added a comment to rL363529: Re-commit r357452 (take 3): "SimplifyCFG SinkCommonCodeFromPredecessors: Also….

Third time's the charm.

Unfortunately there may have to be a fourth time, since this commit causes https://bugs.llvm.org/show_bug.cgi?id=43269 :-)

Fri, Sep 13, 12:27 AM

Thu, Sep 12

hans added a comment to D67461: lld-link: Make /linkrepro: take a filename, not a directory..

But is there no help text or user manual that needs to be updated?

Thu, Sep 12, 12:40 AM · Restricted Project

Tue, Sep 10

hans accepted D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI.

lgtm

Tue, Sep 10, 1:29 AM · Restricted Project, Restricted Project
hans committed rL371490: Merging r371434:.
Merging r371434:
Tue, Sep 10, 12:32 AM

Mon, Sep 9

hans added a comment to D67306: [IfConversion] Correctly handle cases where analyzeBranch fails..

Reviewers, please try to prioritize this one, since it's currently the last patch blocking llvm 9-rc4.

Mon, Sep 9, 7:42 AM · Restricted Project
hans added a comment to D60295: [CodeGen] Replace -max-jump-table-size with -max-jump-table-targets.

I think this keeps the algorithm still withing O(n^2) so that's good.

Mon, Sep 9, 7:20 AM · Restricted Project
hans accepted D67304: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI.

lgtm with comment

Mon, Sep 9, 6:15 AM · Restricted Project, Restricted Project
hans added a comment to D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl.

@hans Can this be put on your list of things for 9.0.1? I searched for [meta] 9.0.1 on bugs.llvm.org but can't find a release blocker bug so I have to bother you directly...

Mon, Sep 9, 5:10 AM · Restricted Project, Restricted Project
hans committed rL371382: Merging r370592:.
Merging r370592:
Mon, Sep 9, 2:51 AM
hans committed rL371381: Merging r371221 and r371224:.
Merging r371221 and r371224:
Mon, Sep 9, 2:42 AM
hans committed rL371378: Merging r371305 and r371307:.
Merging r371305 and r371307:
Mon, Sep 9, 2:35 AM
hans committed rL371377: Merging r371111:.
Merging r371111:
Mon, Sep 9, 2:08 AM
hans committed rL371376: Merging r371262:.
Merging r371262:
Mon, Sep 9, 1:58 AM
hans committed rL371372: Merging r369705 and r369713 for PR43243:.
Merging r369705 and r369713 for PR43243:
Mon, Sep 9, 1:47 AM

Fri, Sep 6

hans added a comment to D65761: Add Windows Control Flow Guard checks (/guard:cf)..

This is very exciting! I didn't look closely at the actual instrumentation code, as rnk knows that better and had some good comments.

Fri, Sep 6, 5:12 AM · Restricted Project, Restricted Project
hans committed rL371197: Merging r371013:.
Merging r371013:
Fri, Sep 6, 4:19 AM
hans committed rL371196: Merging r369828:.
Merging r369828:
Fri, Sep 6, 4:18 AM
hans committed rL371178: Merging r371088 and r371095:.
Merging r371088 and r371095:
Fri, Sep 6, 1:16 AM
hans added inline comments to D67203: [IfConversion] Fix diamond conversion with unanalyzable branches..
Fri, Sep 6, 1:07 AM · Restricted Project
hans added a comment to D67013: [GVN] Verify value equality before doing phi translation for call instruction.

Probably good candidate for 9.0.1.

@hans

Fri, Sep 6, 12:38 AM · Restricted Project

Thu, Sep 5

hans accepted D67201: [Windows] Replace TrapUnreachable with an int3 insertion pass.

lgtm. I only know about this from what rnk told me about the unwinder not wanting the return address to be outside the function, and this seems like a straight-forward solution to that problem.

Thu, Sep 5, 5:38 AM · Restricted Project
hans committed rL371060: Merging r371027:.
Merging r371027:
Thu, Sep 5, 4:55 AM
hans committed rL371059: Merging r370426:.
Merging r370426:
Thu, Sep 5, 4:44 AM
hans committed rL371058: Merging r369760:.
Merging r369760:
Thu, Sep 5, 4:36 AM
hans committed rL371057: Merging r371048:.
Merging r371048:
Thu, Sep 5, 4:35 AM
hans committed rL371053: Merging r370430:.
Merging r370430:
Thu, Sep 5, 3:50 AM
hans committed rL371044: Merging r370720 and r370721:.
Merging r370720 and r370721:
Thu, Sep 5, 2:56 AM
hans committed rL371043: Merging r370753:.
Merging r370753:
Thu, Sep 5, 2:56 AM
hans committed rL371042: Merging r369310:.
Merging r369310:
Thu, Sep 5, 2:50 AM
hans committed rL371040: Merging r370850:.
Merging r370850:
Thu, Sep 5, 2:47 AM
hans committed rL371037: ReleaseNotes tweaks.
ReleaseNotes tweaks
Thu, Sep 5, 2:23 AM
hans committed rL371035: Win: handle \\?\UNC\ prefix in realPathFromHandle (PR43204).
Win: handle \\?\UNC\ prefix in realPathFromHandle (PR43204)
Thu, Sep 5, 2:09 AM
hans closed D67166: Win: handle \\?\UNC\ prefix in realPathFromHandle (PR43204).
Thu, Sep 5, 2:09 AM · Restricted Project
hans committed rL371027: Revert r361885 "[Driver] Fix -working-directory issues".
Revert r361885 "[Driver] Fix -working-directory issues"
Thu, Sep 5, 1:43 AM

Wed, Sep 4

hans updated the diff for D67166: Win: handle \\?\UNC\ prefix in realPathFromHandle (PR43204).
Wed, Sep 4, 10:53 AM · Restricted Project
hans added a comment to D67166: Win: handle \\?\UNC\ prefix in realPathFromHandle (PR43204).

Hi Hans, I am not too familiar with all windows path naming variants. Did you really observe a '\\?UNC\xxxx' path ?

Wed, Sep 4, 10:44 AM · Restricted Project
hans added a comment to D67166: Win: handle \\?\UNC\ prefix in realPathFromHandle (PR43204).
In D67166#1658031, @rnk wrote:

As discussed, maybe we should try harder to revert whatever made us more dependent on this.

Wed, Sep 4, 10:44 AM · Restricted Project
hans created D67166: Win: handle \\?\UNC\ prefix in realPathFromHandle (PR43204).
Wed, Sep 4, 6:27 AM · Restricted Project
hans accepted D65527: Avoid assemble step in verbose-output-quoting.c.

Looks good to me. Thanks!

Wed, Sep 4, 1:27 AM · Restricted Project, Restricted Project
hans committed rL370850: Re-commit r363191 "[MS] Pretend constexpr variable template specializations are….
Re-commit r363191 "[MS] Pretend constexpr variable template specializations are…
Wed, Sep 4, 1:18 AM

Tue, Sep 3

hans committed rL370725: Request commit access for hans.
Request commit access for hans
Tue, Sep 3, 2:41 AM

Fri, Aug 30

hans committed rL370477: index.rst: Remove non-release warning.
index.rst: Remove non-release warning
Fri, Aug 30, 8:17 AM
hans added a comment to D66925: [PPC32] Emit R_PPC_GOT_TPREL16 instead R_PPC_GOT_TPREL16_LO.

@hans This is a merge candidate:)

Fri, Aug 30, 4:42 AM · Restricted Project
hans committed rL370450: Re-generate {Attribute,ClangCommandLine,Diagnostics}Reference.rst.
Re-generate {Attribute,ClangCommandLine,Diagnostics}Reference.rst
Fri, Aug 30, 2:24 AM
hans added a comment to D65280: Add a pass to lower is.constant and objectsize intrinsics.

I've merged the InstructionSimplify.h part of this (r370355) to release_90 in r370447.

Fri, Aug 30, 2:07 AM · Restricted Project
hans committed rL370447: Merging r370355:.
Merging r370355:
Fri, Aug 30, 2:05 AM
hans committed rL370445: Merging r370404:.
Merging r370404:
Fri, Aug 30, 2:05 AM
hans accepted D66959: Update libc++ release notes.

Thanks for writing release notes! Please let me know if you need assistance with committing to the branch.

Fri, Aug 30, 1:16 AM · Restricted Project
hans committed rL370439: ReleaseNotes: pocl and TCE; by Pekka Jääskeläinen.
ReleaseNotes: pocl and TCE; by Pekka Jääskeläinen
Fri, Aug 30, 12:33 AM
hans committed rL370438: Merging r368164:.
Merging r368164:
Fri, Aug 30, 12:26 AM
hans accepted D66980: [Windows] Disable TrapUnreachable for Win64, add SEH_NoReturn.

I'm also not familiar with the unwinder and exception handling, but the code itself and the explanation seems good to me.

Fri, Aug 30, 12:15 AM · Restricted Project

Thu, Aug 29

hans committed rL370370: Merging r370367:.
Merging r370367:
Thu, Aug 29, 7:53 AM
hans committed rL370366: ReleaseNotes: remove in-progress warning and empty sections.
ReleaseNotes: remove in-progress warning and empty sections
Thu, Aug 29, 7:34 AM
hans committed rL370364: ReleaseNotes: remove in-progress warning, remove empty sections.
ReleaseNotes: remove in-progress warning, remove empty sections
Thu, Aug 29, 7:34 AM
hans committed rL370362: ReleaseNotes: remove in-progress warnings and empty sections.
ReleaseNotes: remove in-progress warnings and empty sections
Thu, Aug 29, 7:25 AM
hans committed rL370360: ReleaseNotes: fixes.
ReleaseNotes: fixes
Thu, Aug 29, 7:18 AM
hans committed rL370358: ReleaseNotes: drop in-progress warning and empty sections.
ReleaseNotes: drop in-progress warning and empty sections
Thu, Aug 29, 6:52 AM
hans committed rL370357: ReleaseNotes: cleanups.
ReleaseNotes: cleanups
Thu, Aug 29, 6:43 AM
hans committed rL370356: ReleaseNotes: remove in-progress warning and empty sections.
ReleaseNotes: remove in-progress warning and empty sections
Thu, Aug 29, 6:22 AM
hans committed rL370352: ReleaseNotes: matching wide stores (r362472).
ReleaseNotes: matching wide stores (r362472)
Thu, Aug 29, 6:02 AM
hans committed rL370346: ReleaseNotes: reduce the indent.
ReleaseNotes: reduce the indent
Thu, Aug 29, 5:43 AM
hans committed rL370344: ReleaseNotes: sinking of instructions without uses.
ReleaseNotes: sinking of instructions without uses
Thu, Aug 29, 5:36 AM
hans committed rL370342: ReleaseNotes: omitting range checks for switches with unreachable defaults.
ReleaseNotes: omitting range checks for switches with unreachable defaults
Thu, Aug 29, 5:20 AM
hans committed rL370318: ReleaseNotes from Sam Parker.
ReleaseNotes from Sam Parker
Thu, Aug 29, 3:04 AM
hans committed rL370313: Merging r369184:.
Merging r369184:
Thu, Aug 29, 2:20 AM
hans committed rL370312: Merging r368964:.
Merging r368964:
Thu, Aug 29, 2:20 AM
hans accepted D66905: [X86] Don't emit unreachable stack adjustments.

lgtm

Thu, Aug 29, 2:20 AM · Restricted Project
hans committed rL370306: Merging r370271:.
Merging r370271:
Thu, Aug 29, 1:57 AM

Wed, Aug 28

hans committed rL370213: Merging r370035:.
Merging r370035:
Wed, Aug 28, 7:48 AM
hans added a comment to D65280: Add a pass to lower is.constant and objectsize intrinsics.

I'm also against putting it into 9.0, which is supposed to have a final release Real Soon Now. This is not a obviously-correct change, and it should bake in trunk for at least a couple weeks before going into the release, to shake out any unexpected problems.

I think we should target this for the 9.0.1 patch though, which is why joerg wants to merge the API change to 9.0 now.

Wed, Aug 28, 7:44 AM · Restricted Project
hans added a comment to D56963: Update the license text on the release page to telegraph to users about the relicening..

With llvm 9 coming up, we should update this, but what should it say exactly?

Wed, Aug 28, 7:44 AM
hans added a comment to D65280: Add a pass to lower is.constant and objectsize intrinsics.

Can we not get the entire thing merged? I'd really like that... I think the patch is actually really close. I have a bunch of comments below but they're all pretty boring in reality.

Wed, Aug 28, 7:18 AM · Restricted Project