hans (Hans Wennborg)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 6:48 AM (283 w, 4 d)

Recent Activity

Yesterday

hans added a comment to D51340: Add /Zc:DllexportInlines option to clang-cl.

Ping?

This patch reduced obj size largely, and I expect this makes distributed build (like goma) faster by reducing data transferred on network.

Mon, Sep 24, 7:28 AM
hans committed rL342867: 7.0.0: add Ubuntu binaries.
7.0.0: add Ubuntu binaries
Mon, Sep 24, 7:24 AM
hans committed rL342873: Revert r341932 "[ARM] Enable ARMCodeGenPrepare by default".
Revert r341932 "[ARM] Enable ARMCodeGenPrepare by default"
Mon, Sep 24, 7:24 AM
hans committed rL342864: Fix llvm-diff anon-func.ll test.
Fix llvm-diff anon-func.ll test
Mon, Sep 24, 7:23 AM
hans committed rL342863: Remove debug printf leftover from r342397.
Remove debug printf leftover from r342397
Mon, Sep 24, 7:23 AM

Thu, Sep 20

hans updated the diff for D52266: [clang-cl] Provide separate flags for all the /O variants.

Uploading new diff.

Thu, Sep 20, 3:08 AM
hans added a comment to D52266: [clang-cl] Provide separate flags for all the /O variants.

Sorry, I didn't realize we both set off to do this in parallel. I've incorporated your changes into my patch.

Thu, Sep 20, 3:08 AM
hans committed rL342636: FileCheckify test/Driver/Xarch.c.
FileCheckify test/Driver/Xarch.c
Thu, Sep 20, 2:33 AM
hans committed rC342636: FileCheckify test/Driver/Xarch.c.
FileCheckify test/Driver/Xarch.c
Thu, Sep 20, 2:33 AM
hans committed rL342630: index.html: Link to docs and release notes for sub-projects as well.
index.html: Link to docs and release notes for sub-projects as well
Thu, Sep 20, 1:47 AM
hans committed rL342626: 7.0.0: add darwin binary.
7.0.0: add darwin binary
Thu, Sep 20, 1:01 AM

Wed, Sep 19

hans created D52266: [clang-cl] Provide separate flags for all the /O variants.
Wed, Sep 19, 7:29 AM
hans committed rL342539: Fix PGP key link.
Fix PGP key link
Wed, Sep 19, 4:36 AM
hans committed rL342537: Update links etc. for 7.0.0.
Update links etc. for 7.0.0
Wed, Sep 19, 4:29 AM
hans committed rL342532: [COFF] Emit @feat.00 on 64-bit and set the CFG bit when emitting guardcf tables.
[COFF] Emit @feat.00 on 64-bit and set the CFG bit when emitting guardcf tables
Wed, Sep 19, 3:00 AM
hans closed D52235: [COFF] Emit @feat.00 on 64-bit and set the CFG bit when emitting guardcf tables.
Wed, Sep 19, 3:00 AM
hans committed rL342530: 7.0.0 files.
7.0.0 files
Wed, Sep 19, 2:43 AM
hans added a comment to D52193: RFC: [clang] Multithreaded compilation support.

Thanks for adding the Ninja numbers. It confirms that Ninja is significantly faster than MSBuild + /MP.

Wed, Sep 19, 12:42 AM

Tue, Sep 18

hans created D52235: [COFF] Emit @feat.00 on 64-bit and set the CFG bit when emitting guardcf tables.
Tue, Sep 18, 7:34 AM
hans committed rL342482: Revert r342457 "Fixes removal of dead elements from PressureDiff (PR37252).".
Revert r342457 "Fixes removal of dead elements from PressureDiff (PR37252)."
Tue, Sep 18, 7:15 AM
hans committed rL342470: cl-options.c: Fix negative -cfguard check.
cl-options.c: Fix negative -cfguard check
Tue, Sep 18, 6:11 AM
hans committed rC342470: cl-options.c: Fix negative -cfguard check.
cl-options.c: Fix negative -cfguard check
Tue, Sep 18, 6:11 AM
hans added a comment to D52002: Switch optimization for known maximum switch values.

Thanks Hans for the clarification. I will go ahead and implement your suggestion. Once done, I will re-post the patch for review.

Tue, Sep 18, 4:16 AM
hans added a comment to D52002: Switch optimization for known maximum switch values.

The default is unreachable here because it would "fall off" the end of the function without returning, which is undefined behaviour. So the switch lowering should be able to remove the range check for the jump table.

On second thoughts, I realize that the default may not be unreachable in the case that I mentioned since the block beyond the switch block would then be treated as the default. Am I right?

Tue, Sep 18, 3:00 AM
hans added a comment to D52002: Switch optimization for known maximum switch values.

If the default basic block is unreachable and we completely omit the conditional branch in all such cases, then if the switch value at runtime turns out to be not one of the cases given in the switch block, the execution would reach the vectored branch to the jump table which would fail to reach anywhere.

Tue, Sep 18, 2:22 AM
hans added a comment to D52193: RFC: [clang] Multithreaded compilation support.

What about the timings of clang-cl without /MP?

Tue, Sep 18, 12:45 AM

Mon, Sep 17

hans added a comment to D52002: Switch optimization for known maximum switch values.

I will move the storing of the MaxSwitchValue to the metadata of the instruction. I think that is the right place to store these things.

Mon, Sep 17, 5:31 AM
hans committed rL342371: Creating release candidate final from release_700 branch.
Creating release candidate final from release_700 branch
Mon, Sep 17, 4:53 AM
hans committed rL342373: Creating release candidate final from release_700 branch.
Creating release candidate final from release_700 branch
Mon, Sep 17, 4:52 AM
hans committed rL342379: Creating release candidate final from release_700 branch.
Creating release candidate final from release_700 branch
Mon, Sep 17, 4:49 AM
hans committed rL342383: Creating release candidate final from release_700 branch.
Creating release candidate final from release_700 branch
Mon, Sep 17, 4:49 AM
hans committed rL342382: Creating release candidate final from release_700 branch.
Creating release candidate final from release_700 branch
Mon, Sep 17, 4:49 AM
hans committed rL342381: Creating release candidate final from release_700 branch.
Creating release candidate final from release_700 branch
Mon, Sep 17, 4:48 AM
hans committed rL342380: Creating release candidate final from release_700 branch.
Creating release candidate final from release_700 branch
Mon, Sep 17, 4:48 AM
hans committed rL342372: Creating release candidate final from release_700 branch.
Creating release candidate final from release_700 branch
Mon, Sep 17, 4:47 AM
hans committed rL342377: Creating release candidate final from release_700 branch.
Creating release candidate final from release_700 branch
Mon, Sep 17, 4:45 AM
hans committed rL342376: Creating release candidate final from release_700 branch.
Creating release candidate final from release_700 branch
Mon, Sep 17, 4:44 AM
hans committed rL342375: Creating release candidate final from release_700 branch.
Creating release candidate final from release_700 branch
Mon, Sep 17, 4:44 AM
hans committed rL342374: Creating release candidate final from release_700 branch.
Creating release candidate final from release_700 branch
Mon, Sep 17, 4:40 AM
hans added a comment to D52142: [DebugInfo] Fix build when std::vector::iterator is a pointer.

Without this, the error (abbreviated) is:

lib/CodeGen/AsmPrinter/DwarfDebug.cpp: error: 'llvm::MapVector<>::const_iterator' (aka 'const std::pair<> *') is not a class, namespace, or enumeration
Mon, Sep 17, 12:40 AM

Fri, Sep 14

hans committed rL342240: [clang-cl] Fix PR38934: failing to dllexport class template member w/ explicit….
[clang-cl] Fix PR38934: failing to dllexport class template member w/ explicit…
Fri, Sep 14, 8:20 AM
hans committed rC342240: [clang-cl] Fix PR38934: failing to dllexport class template member w/ explicit….
[clang-cl] Fix PR38934: failing to dllexport class template member w/ explicit…
Fri, Sep 14, 8:20 AM

Thu, Sep 13

hans added a comment to D52002: Switch optimization for known maximum switch values.

I don't think storing the MaxSwitchValue in the switch instructions itself is the right approach. Generally LLVM doesn't store analysis results in the instructions.

Thu, Sep 13, 1:42 AM

Tue, Sep 11

hans accepted D51391: [clang-cl,PCH] Add support for #pragma hdrstop.

Please add a note to docs/ReleaseNotes.rst when landing.

Tue, Sep 11, 2:41 AM
hans committed rL341916: ReleaseNotes: some notes from Andres Freund.
ReleaseNotes: some notes from Andres Freund
Tue, Sep 11, 1:40 AM
hans committed rL341914: Update the release schedule to match reality.
Update the release schedule to match reality
Tue, Sep 11, 1:16 AM
hans committed rL341913: ReleaseNotes: fixes.
ReleaseNotes: fixes
Tue, Sep 11, 1:08 AM
hans committed rL341911: ReleaseNotes.rst: Add Zig to External Open Source Projects Using LLVM 7.
ReleaseNotes.rst: Add Zig to External Open Source Projects Using LLVM 7
Tue, Sep 11, 12:55 AM
hans closed D51118: Release Notes: Add Zig to External Open Source Projects Using LLVM 7.

committed in r341911.

Tue, Sep 11, 12:55 AM

Mon, Sep 10

hans added a comment to D51806: [clang-cl] Enable -march.

@hans Just an after thought: maybe we should prevent usage of -march= and /arch: at the same time. What do you think? I can add another patch for that purpose.

Mon, Sep 10, 7:33 AM
hans accepted D51806: [clang-cl] Enable -march.

lgtm

Mon, Sep 10, 7:17 AM
hans committed rL341829: docs: drop doxygen link; it doesn't work.
docs: drop doxygen link; it doesn't work
Mon, Sep 10, 7:16 AM
hans committed rL341828: docs: drop another in-progress warning.
docs: drop another in-progress warning
Mon, Sep 10, 7:15 AM
hans added a comment to D51806: [clang-cl] Enable -march.

Okay, that sounds good to me.

Mon, Sep 10, 6:47 AM
hans added inline comments to D51340: Add /Zc:DllexportInlines option to clang-cl.
Mon, Sep 10, 5:49 AM
hans committed rL341809: Creating release candidate rc3 from release_700 branch.
Creating release candidate rc3 from release_700 branch
Mon, Sep 10, 5:33 AM
hans committed rL341807: Creating release candidate rc3 from release_700 branch.
Creating release candidate rc3 from release_700 branch
Mon, Sep 10, 5:31 AM
hans committed rL341815: Creating release candidate rc3 from release_700 branch.
Creating release candidate rc3 from release_700 branch
Mon, Sep 10, 5:30 AM
hans committed rL341819: Creating release candidate rc3 from release_700 branch.
Creating release candidate rc3 from release_700 branch
Mon, Sep 10, 5:29 AM
hans committed rL341818: Creating release candidate rc3 from release_700 branch.
Creating release candidate rc3 from release_700 branch
Mon, Sep 10, 5:28 AM
hans committed rL341817: Creating release candidate rc3 from release_700 branch.
Creating release candidate rc3 from release_700 branch
Mon, Sep 10, 5:28 AM
hans committed rL341816: Creating release candidate rc3 from release_700 branch.
Creating release candidate rc3 from release_700 branch
Mon, Sep 10, 5:28 AM
hans committed rL341813: Creating release candidate rc3 from release_700 branch.
Creating release candidate rc3 from release_700 branch
Mon, Sep 10, 5:27 AM
hans committed rL341812: Creating release candidate rc3 from release_700 branch.
Creating release candidate rc3 from release_700 branch
Mon, Sep 10, 5:26 AM
hans committed rL341811: Creating release candidate rc3 from release_700 branch.
Creating release candidate rc3 from release_700 branch
Mon, Sep 10, 5:26 AM
hans committed rL341808: Creating release candidate rc3 from release_700 branch.
Creating release candidate rc3 from release_700 branch
Mon, Sep 10, 5:26 AM
hans committed rL341810: Creating release candidate rc3 from release_700 branch.
Creating release candidate rc3 from release_700 branch
Mon, Sep 10, 5:23 AM
hans committed rL341805: ReleaseNotes: tiny fix.
ReleaseNotes: tiny fix
Mon, Sep 10, 5:16 AM
hans committed rL341804: ReleaseNotes: minor tweaks.
ReleaseNotes: minor tweaks
Mon, Sep 10, 5:09 AM
hans committed rCXX341789: ReleaseNotes: update links to use https.
ReleaseNotes: update links to use https
Mon, Sep 10, 1:59 AM
hans committed rL341789: ReleaseNotes: update links to use https.
ReleaseNotes: update links to use https
Mon, Sep 10, 1:58 AM
hans committed rL341788: ReleaseNotes: update links to use https.
ReleaseNotes: update links to use https
Mon, Sep 10, 1:53 AM
hans committed rLLD341788: ReleaseNotes: update links to use https.
ReleaseNotes: update links to use https
Mon, Sep 10, 1:53 AM
hans committed rCTE341787: ReleaseNotes: update links to use https.
ReleaseNotes: update links to use https
Mon, Sep 10, 1:53 AM
hans committed rL341787: ReleaseNotes: update links to use https.
ReleaseNotes: update links to use https
Mon, Sep 10, 1:53 AM
hans committed rL341786: ReleaseNotes: update links to use https.
ReleaseNotes: update links to use https
Mon, Sep 10, 1:52 AM
hans committed rC341786: ReleaseNotes: update links to use https.
ReleaseNotes: update links to use https
Mon, Sep 10, 1:52 AM
hans committed rL341785: ReleaseNotes: update links to use https.
ReleaseNotes: update links to use https
Mon, Sep 10, 1:51 AM
hans committed rL341783: Merging r341642:.
Merging r341642:
Mon, Sep 10, 1:13 AM
hans added inline comments to D51391: [clang-cl,PCH] Add support for #pragma hdrstop.
Mon, Sep 10, 1:02 AM
hans committed rL341780: Merging r341670 and r341672:.
Merging r341670 and r341672:
Mon, Sep 10, 12:57 AM
hans added a comment to D51806: [clang-cl] Enable -march.

All flags in the m_x86_Features_Group, i.e. -msse, -mavx and so on are all supported. I'm just curious to hear what it is that you need from -march?

Mon, Sep 10, 12:53 AM
hans added inline comments to D51340: Add /Zc:DllexportInlines option to clang-cl.
Mon, Sep 10, 12:30 AM
hans added a comment to rL341775: Part of PR33222: defer enforcing return type mismatch for dependent.

Maybe worth to put this PR33222's fix to release branch too? (+ https://reviews.llvm.org/rL341778)

@hans

Mon, Sep 10, 12:30 AM

Fri, Sep 7

hans committed rL341665: Regenerate DiagnosticsReference.rst.
Regenerate DiagnosticsReference.rst
Fri, Sep 7, 7:39 AM
hans committed rL341664: Remove ReleaseNotes as they were empty.
Remove ReleaseNotes as they were empty
Fri, Sep 7, 7:31 AM
hans committed rL341663: ReleaseNotes: tidy up for the release.
ReleaseNotes: tidy up for the release
Fri, Sep 7, 7:25 AM
hans committed rL341662: ReleaseNotes: tidy up for the release.
ReleaseNotes: tidy up for the release
Fri, Sep 7, 7:25 AM
hans committed rL341661: ReleaseNotes: tidy up for the release.
ReleaseNotes: tidy up for the release
Fri, Sep 7, 7:19 AM
hans committed rL341640: ReleaseNotes: tidy up for the release.
ReleaseNotes: tidy up for the release
Fri, Sep 7, 2:22 AM

Thu, Sep 6

hans committed rL341530: Merging r341512:.
Merging r341512:
Thu, Sep 6, 1:59 AM
hans committed rL341529: Merging r340609:.
Merging r340609:
Thu, Sep 6, 1:57 AM
hans added a comment to D50534: [libc++] Fix handling of negated character classes in regex.

is this fixed in 7.0 release branch too?

@hans

Thu, Sep 6, 1:57 AM
hans added a comment to D51720: [COFF] don't mark lazy symbols as used in regular objects.

Is it possible to have a test for this?

Thu, Sep 6, 1:26 AM
hans committed rL341524: Merging r341442:.
Merging r341442:
Thu, Sep 6, 1:20 AM
hans committed rL341523: Merging r341416:.
Merging r341416:
Thu, Sep 6, 1:20 AM
hans committed rL341522: ReleaseNotes: ARM SVE asm/disasm support.
ReleaseNotes: ARM SVE asm/disasm support
Thu, Sep 6, 1:14 AM
hans committed rL341521: ReleaseNotes: libc++ _LIBCPP_HIDE_FROM_ABI_PER_TU.
ReleaseNotes: libc++ _LIBCPP_HIDE_FROM_ABI_PER_TU
Thu, Sep 6, 1:10 AM
hans committed rL341520: ReleaseNotes: support for new-pm passes in the opt tool.
ReleaseNotes: support for new-pm passes in the opt tool
Thu, Sep 6, 1:04 AM

Wed, Sep 5

hans committed rL341453: ReleaseNotes for PowerPC.
ReleaseNotes for PowerPC
Wed, Sep 5, 1:08 AM