- User Since
- Apr 18 2013, 6:48 AM (239 w, 2 d)
Wed, Nov 15
I think the patch is fine, but Zach should probably sign off on it.
Tue, Nov 14
I tested locally that if there's a current LLVM_ENABLE_LIBXML2:BOOL in CMakeCache.txt, that doesn't break things. There is no warning or error, it just seems to ignore the new string option and use the cached bool one.
Renaming the new flag and making it sufficient to turn on instrumentation by itself.
Minor updates to the diff, updating the description to match the new approach.
Mon, Nov 13
Fri, Nov 10
Rebasing and addressing comments.
Updating to match the LLVM-side: https://reviews.llvm.org/D39287#inline-348143
Thu, Nov 9
Here's a new approach which renames and extends the existing CountingFunctionInserter to run both before and after inlining (with the old PM it's two passes actually) and handle both cygprofile and mcount calls as controlled by function attributes.
Tue, Nov 7
Maybe mention llvm::Expected in the commit message too.
Thanks for working on this!
Mon, Nov 6
Addressing comments and changing the test to exercise Sema more directly.
Fri, Nov 3
Thu, Nov 2
Wed, Nov 1
Starting to look really good.
Thanks! I think that's looking better.
Fri, Oct 27
The request for -fno-cygprofile-args was from another user. You raise a good point, it sounds like mcount() might be perfect for them :-)
Thu, Oct 26
Wed, Oct 25
Thanks! I think doing it here rather than in SimplifyCFG is much better.
Mon, Oct 23
Sun, Oct 22
+Tom who manages the 5.0.1 release.
Oct 18 2017
When we ran into the test failures last time, in PR33859, it turned out there were no upstream buildbots running the tests, so we didn't find out they were failing until we started the release process. Are the tests run by any buildbots now?
Oct 17 2017
Oct 16 2017
Nico, this addresses your needs, right?
Would it be easy to print the version number as part of /? instead? Maybe that's safer.
Oct 12 2017
Oct 11 2017
Check for ERROR_CALL_NOT_IMPLEMENTED instead.
looks amazing to me
Oct 10 2017
Oct 5 2017
Oct 4 2017
Oct 3 2017
Dropping the AMD64_ prefixes except for the YMM registers.
Oct 2 2017
Sep 28 2017
Sep 25 2017
Sep 22 2017
This looks good to me. Do you have commit access, or would you like me to commit for you?