- User Since
- Apr 18 2013, 6:48 AM (231 w, 2 d)
This looks good to me. Do you have commit access, or would you like me to commit for you?
Wed, Sep 20
I'm not familiar with the DBG_VALUE stuff, but this looks good as far as I can tell.
Mon, Sep 18
Very nice, thanks!
Fri, Sep 15
Was I CC'd on this because it's a candidate for 5.0.1? If so, +Tom who manages that release.
Wed, Sep 13
(Meta comment: please upload patches with more context so the rest of the files show up in the review. If you generate the patch with diff or git diff, do it by passing along -U9999.)
Looks good to me.
Tue, Sep 12
Mon, Sep 11
Fri, Sep 8
Thu, Sep 7
Tue, Sep 5
Seems fine to me. Rui should probably sign off on it, though.
Fri, Sep 1
Thu, Aug 31
The X86ISelLowering.cpp change looks good to me.
Seems reasonable, but should probably have a test.
Wed, Aug 30
Tue, Aug 29
Thanks! Looks good to me.
I've gone ahead and committed this to unblock the release.
I'm not sure if Nirav is around.
Based on Dimitry's comment in https://bugs.llvm.org/show_bug.cgi?id=34326#c13 this seems to solve the problem. Can we get it landed so it can be part of 5.0.0?