- User Since
- Apr 18 2013, 6:48 AM (426 w, 4 d)
Thu, Jun 17
More tests, add help text for command-line options.
Wed, Jun 16
Mon, Jun 14
We're seeing new build errors in Chromium after this (http://crbug.com/1219457). Here's a reduced example:
Wed, Jun 9
Tue, Jun 8
Reverted in 386b66b2fc297cda121a3cc8a36887a6ecbcfc68 until this can be fixed.
Mon, Jun 7
We're seeing build non-determinism in Chromium after this patch (after 36ec97f76ac0d8be76fb16ac521f55126766267d specifically). See https://bugs.chromium.org/p/chromium/issues/detail?id=1216316#c20 for a reproducer.
Wed, Jun 2
Are the presubmit errors related to this?
Mon, May 31
Thu, May 27
We tried it, and the warning is still firing in a similar (but not exactly the same) way:
Wed, May 26
Looks good to me!
Tue, May 25
Looks okay to me, but I think Tom still needs to sign off on this since he's the main user of the script.
Apologies for the slow reply, it was a long weekend here.
May 21 2021
Looks great to me!
Looking good overall, just a few nits.
May 20 2021
May 19 2021
Interesting, I hadn't seen __identifier before. It seems like a pretty esoteric feature.
May 10 2021
I don't feel strongly about this one way or the other.
May 5 2021
The test was failing in no-asserts builds, see output at https://ghostbin.com/paste/UMtJl
Is having <yyyymmdd> in the filename really the most useful thing. I'd imagine having the git ref directly might be more useful, or perhaps the output of "git-describe" on it. Or maybe it should have both the git-ref and date in the filename?
And when using the date, perhaps it should use the date of the commit (commitdate, not authordate i guess) rather than the date when the script is run?
Or maybe the script should take a template argument for the filenames?
May 4 2021
May 3 2021
Apr 30 2021
+1 to the comment that it would be nice to have some docs; llvm-reduce should have a page on https://llvm.org/docs/CommandGuide/ really
Apr 28 2021
The real question is how did you find this? :)
Apr 21 2021
Apr 19 2021
Apr 16 2021
slightly different codegen: https://godbolt.org/z/1zebofo98
but probably just as good :)
Apr 14 2021
Apr 7 2021
I'm not familiar with github actions so I'm just skimming the code, but it looks good as far as I can tell.
Apr 6 2021
Mar 29 2021
Mar 17 2021
This caused non-deterministic output from the compiler, see https://bugs.chromium.org/p/chromium/issues/detail?id=1189090#c8 for a reproducer. (Usually this is due to non-deterministic iteration order for hash-based data structures such as DenseMap)
Mar 16 2021
Sorry for being unresponsive for a while, I got distracted by various bugs.
Sorry for the delay, I got distracted by other fires.
Mar 12 2021
This broke the check-profile tests on Mac, see e.g. http://green.lab.llvm.org/green/job/clang-stage1-RA/19301/
There are no Mac bots on the main buildbot waterfall, but I thought Apple were watching Green Dragon?
Mar 8 2021
nit in the change description
So -why_load is the spelling preferred by the linker and -whyload and old
second "and" -> "an"
Mar 4 2021
This broke Chromium's AddressSanitizer build on Mac: https://crbug.com/1184481
Mar 3 2021
Reverted in https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44 until this can be fixed.