Page MenuHomePhabricator

hans (Hans Wennborg)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 6:48 AM (405 w, 1 d)

Recent Activity

Yesterday

hans accepted D95114: HowToReleaseLLVM: Add annual release schedule template.

Thanks, I think having this is super useful!

Thu, Jan 21, 1:04 AM · Restricted Project

Wed, Jan 20

hans added a comment to D56387: [DAGCombiner] Enable SimplifyDemandedBits vector support for TRUNCATE.

This caused asserts in Chromium. See https://bugs.chromium.org/p/chromium/issues/detail?id=1168629#c2 for a reproducer.

Wed, Jan 20, 11:08 AM · Restricted Project
hans added a reverting change for rGcad4275d697c: [DAGCombiner] Enable SimplifyDemandedBits vector support for TRUNCATE: rGa51226057fc3: Revert "[DAGCombiner] Enable SimplifyDemandedBits vector support for TRUNCATE".
Wed, Jan 20, 11:07 AM
hans committed rGa51226057fc3: Revert "[DAGCombiner] Enable SimplifyDemandedBits vector support for TRUNCATE" (authored by hans).
Revert "[DAGCombiner] Enable SimplifyDemandedBits vector support for TRUNCATE"
Wed, Jan 20, 11:07 AM
hans added a reverting change for D56387: [DAGCombiner] Enable SimplifyDemandedBits vector support for TRUNCATE: rGa51226057fc3: Revert "[DAGCombiner] Enable SimplifyDemandedBits vector support for TRUNCATE".
Wed, Jan 20, 11:07 AM · Restricted Project
hans added a reverting change for rG5a391d38ac6c: Following up on PR48517, fix handling of template arguments that refer: rG8ba442bc2136: Revert "Following up on PR48517, fix handling of template arguments that refer".
Wed, Jan 20, 7:02 AM
hans added a reverting change for rG4b574008aef5: [c++20] P1907R1: Support for generalized non-type template arguments of scalar…: rG8ba442bc2136: Revert "Following up on PR48517, fix handling of template arguments that refer".
Wed, Jan 20, 7:02 AM
hans added a reverting change for rG18e093faf726: [msabi] Mangle a template argument referring to array-to-pointer decay: rG8ba442bc2136: Revert "Following up on PR48517, fix handling of template arguments that refer".
Wed, Jan 20, 7:02 AM
hans committed rG8ba442bc2136: Revert "Following up on PR48517, fix handling of template arguments that refer" (authored by hans).
Revert "Following up on PR48517, fix handling of template arguments that refer"
Wed, Jan 20, 7:02 AM

Tue, Jan 19

hans committed rGec877106a38b: [ThinLTO] Also prune Thin-* files from the ThinLTO cache (authored by hans).
[ThinLTO] Also prune Thin-* files from the ThinLTO cache
Tue, Jan 19, 5:44 AM
hans closed D94962: [ThinLTO] Also prune Thin-* files from the ThinLTO cache.
Tue, Jan 19, 5:44 AM · Restricted Project
hans requested review of D94962: [ThinLTO] Also prune Thin-* files from the ThinLTO cache.
Tue, Jan 19, 4:51 AM · Restricted Project
hans added a comment to D94862: [InstCombine] Replace one-use select operand based on condition.

I found the file that's getting miscompiled, and uploaded preprocessed source and some notes here: https://bugs.chromium.org/p/chromium/issues/detail?id=1167890#c6

Tue, Jan 19, 2:54 AM · Restricted Project
hans added a reverting change for rG5238e7b302ff: [InstCombine] Replace one-use select operand based on condition: rG58bdfcfac048: Revert 5238e7b302 "[InstCombine] Replace one-use select operand based on….
Tue, Jan 19, 2:51 AM
hans committed rG58bdfcfac048: Revert 5238e7b302 "[InstCombine] Replace one-use select operand based on… (authored by hans).
Revert 5238e7b302 "[InstCombine] Replace one-use select operand based on…
Tue, Jan 19, 2:51 AM
hans added a reverting change for D94862: [InstCombine] Replace one-use select operand based on condition: rG58bdfcfac048: Revert 5238e7b302 "[InstCombine] Replace one-use select operand based on….
Tue, Jan 19, 2:51 AM · Restricted Project

Mon, Jan 18

hans added a comment to D94862: [InstCombine] Replace one-use select operand based on condition.

We're seeing crashes after this commit (5238e7b302ffc40707677960da9d64e872745dac) in Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=1167890

Mon, Jan 18, 1:07 PM · Restricted Project

Fri, Jan 15

hans added a comment to D94355: [SimplifyCFG] Add relative switch lookup tables.

Some targets already do this. Please check that you don't create regressions, especially on PowerPC.

Fri, Jan 15, 5:57 AM · Restricted Project, Restricted Project
hans updated subscribers of D82862: [ThinLTO] Always parse module level inline asm with At&t dialect.

The motivation for my change was really just to make ThinLTO compiles work the same as non-ThinLTO ones.

Maybe the fact that -x86-asm-syntax=intel doesn't affect inline asm is a bug. I wasn't aware that Clang and GCC's -masm= flags behaved differently in that way, but that certainly suggests there's a problem here.

So I'm wondering, if I remove the above setAssemblerDialect line and revert this commit, we should have inline asm (both module-level and GNU function-leve) respect the target-selected asm dialect variant both for ThinLTO and non-ThinLTO, so they should match again. Would that also solve the problem you were originally tracking?

Fri, Jan 15, 4:33 AM · Restricted Project, Restricted Project
hans added inline comments to D94355: [SimplifyCFG] Add relative switch lookup tables.
Fri, Jan 15, 1:32 AM · Restricted Project, Restricted Project

Thu, Jan 14

hans added a comment to D82862: [ThinLTO] Always parse module level inline asm with At&t dialect.

Hi @hans , we're having some issues with using the AssemblerDialect mechanism to support both the GNU assembler and the IBM HLASM assembler in the SystemZ back-end. See also the discussion started here: https://lists.llvm.org/pipermail/llvm-dev/2020-November/146875.html

One of the issues that showed up is what you're refering to above:

That flag however should not affect the *parsing* of inline assembly in the program.

I'm wondering why this is true. I mean, it is true that the flag currently does not affect parsing of inline asm, but I'm wondering whether it *should* be that way.

Note that the -x86-asm-syntax=intel LLVM flag is used to implement the -masm=intel clang command line option, which exists also in GCC and where hopefully the two compilers should be compatible. But in GCC, that flag is documented to affect parsing of inline assembly just like it affects output. See https://gcc.gnu.org/onlinedocs/gcc-10.2.0/gcc/x86-Options.html#x86-Options

-masm=dialect

Output assembly instructions using selected dialect. Also affects which dialect is used for basic asm (see Basic Asm) and extended asm (see Extended Asm). Supported choices (in dialect order) are ‘att’ or ‘intel’. The default is ‘att’. Darwin does not support ‘intel’.

What is the reason for treating this differently in LLVM?

Thu, Jan 14, 10:15 AM · Restricted Project, Restricted Project
hans added a comment to D94355: [SimplifyCFG] Add relative switch lookup tables.

Based on @hans 's feedback, I added a new enumeration kind called RelOffsetArrayKind, and remove IsRelative flag.
This separates the lookup table and relative lookup table IR generation.
Do you think this helps for the abstraction?
I feel like if it might be better if we can generate the relative lookup table in the first place instead of generating it in a separate pass.

Thu, Jan 14, 4:40 AM · Restricted Project, Restricted Project

Tue, Jan 12

hans added a comment to D94355: [SimplifyCFG] Add relative switch lookup tables.

Great stuff, thanks for working on this!

Tue, Jan 12, 1:56 AM · Restricted Project, Restricted Project

Mon, Jan 11

hans added inline comments to D90976: [NFC] Fixed an issue where diagnostics printed expressions in a roundabout way.
Mon, Jan 11, 6:51 AM · Restricted Project

Dec 18 2020

hans accepted D93493: HowToReleaseLLVM: Update document to match the current release process.

Looks great, thanks!

Dec 18 2020, 2:03 AM · Restricted Project

Dec 9 2020

hans accepted D92866: [COFF][LTO][NPM] Use NPM for LTO with ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER.
Dec 9 2020, 5:20 AM · Restricted Project

Dec 8 2020

hans accepted D92844: [gn build] Link with -Wl,--gdb-index.
Dec 8 2020, 6:56 AM · Restricted Project

Dec 7 2020

hans committed rG3d8b7465c338: Test commit (authored by hans).
Test commit
Dec 7 2020, 8:27 AM

Dec 3 2020

hans accepted D91904: [mac/arm] Fix rtti codegen tests when running on an arm mac.

lgtm

Dec 3 2020, 6:09 AM · Restricted Project

Dec 2 2020

hans committed rG437c4653855f: [ThinLTO] Import symver directives for imported symbols (PR48214) (authored by hans).
[ThinLTO] Import symver directives for imported symbols (PR48214)
Dec 2 2020, 5:57 AM
hans added a comment to D92335: [ThinLTO] Import symver directives for imported symbols (PR48214).

lgtm. Thanks for fixing this, and that's a nice cleanup on the existing handling! One request - could you submit the change to the current handling and associated test changes first, with the symver handling/test as a follow on?

Dec 2 2020, 5:57 AM · Restricted Project
hans closed D92335: [ThinLTO] Import symver directives for imported symbols (PR48214).
Dec 2 2020, 5:57 AM · Restricted Project
hans committed rG45d8a7843253: Simplify append to module inline asm string in IRLinker::run() (authored by hans).
Simplify append to module inline asm string in IRLinker::run()
Dec 2 2020, 5:57 AM

Dec 1 2020

hans added inline comments to D92335: [ThinLTO] Import symver directives for imported symbols (PR48214).
Dec 1 2020, 11:47 AM · Restricted Project
hans updated the diff for D92335: [ThinLTO] Import symver directives for imported symbols (PR48214).

Moving the "Append the module inline asm string" code down, and simplifying it in the process.

Dec 1 2020, 11:46 AM · Restricted Project
hans added inline comments to D92335: [ThinLTO] Import symver directives for imported symbols (PR48214).
Dec 1 2020, 10:18 AM · Restricted Project
hans updated the diff for D92335: [ThinLTO] Import symver directives for imported symbols (PR48214).

Adding test case where the symver doesn't get imported.

Dec 1 2020, 10:18 AM · Restricted Project
hans accepted D92357: clang/darwin: Don't use response files with ld64.

lgtm

Dec 1 2020, 9:59 AM · Restricted Project
hans accepted D92399: clang/darwin: Use response files with ld64.lld.darwinnew.
Dec 1 2020, 8:52 AM · Restricted Project
hans updated the diff for D92335: [ThinLTO] Import symver directives for imported symbols (PR48214).

I just realized this makes Linker/ depend on Object/
I'm not sure whether that's a problem or not, but we could avoid that by storing the symvers in a metadata node again.

Dec 1 2020, 7:43 AM · Restricted Project
hans updated the diff for D92335: [ThinLTO] Import symver directives for imported symbols (PR48214).

Pulling in the symver directives in IRLinker::run() instead. (I didn't do a separate function since it's just a few lines, but happy to do that if you think it would be better.)

Dec 1 2020, 7:39 AM · Restricted Project
hans added a comment to D92335: [ThinLTO] Import symver directives for imported symbols (PR48214).

Thinking through this some more, I think I was making it too hard. I think we should just be able to collect the symvers out of the inline asm when we do the IR linking. However, not in the place you've modified below, as I note there. Instead, take a look at IRLinker::run(), where it appends the module inline asm strings together if !IsPerformingImport. I think here you could add a case where IsPerformingImport, and just invoke ModuleSymbolTable::CollectAsmSymvers here and directly add any symver you find to the DstM (probably do all this in a helper function). I was thinking that we might need to carry it via module metadata to avoid parsing it during IR linking, but I'm now not sure that's necessary - I don't think it should add significant overhead. Let me know if you run into issues with that approach.

Dec 1 2020, 7:36 AM · Restricted Project
hans committed rG2ca4785ac700: Remove rm -f cortex-a57-misched-mla.s; hopefully the bots have all cycled past… (authored by hans).
Remove rm -f cortex-a57-misched-mla.s; hopefully the bots have all cycled past…
Dec 1 2020, 4:55 AM
hans added a comment to D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools.

I'm seeing build failures that might be triggered by this patch: http://lab.llvm.org:8011/#/builders/109/builds/3714

Dec 1 2020, 2:51 AM · Restricted Project, Restricted Project
hans committed rG52f3fac22454: [gn build] Manually merge 40659cd (authored by hans).
[gn build] Manually merge 40659cd
Dec 1 2020, 2:15 AM
hans accepted D92072: [CMake][NewPM] Move ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER into llvm/.

Seems like a good idea to me.

Dec 1 2020, 1:17 AM · Restricted Project, Restricted Project

Nov 30 2020

hans requested review of D92335: [ThinLTO] Import symver directives for imported symbols (PR48214).
Nov 30 2020, 10:56 AM · Restricted Project
hans committed rG25d54abca59b: Try harder to get rid off cortex-a57-misched-mla.s (authored by hans).
Try harder to get rid off cortex-a57-misched-mla.s
Nov 30 2020, 5:32 AM
hans committed rG273641fedc52: Try to fix bots after 112b3cb by removing cortex-a57-misched-mla.s (authored by hans).
Try to fix bots after 112b3cb by removing cortex-a57-misched-mla.s
Nov 30 2020, 5:16 AM
hans committed rG13c42f4ca7fb: [gn build] Manually sync 8da7efb and cac5be4 (authored by hans).
[gn build] Manually sync 8da7efb and cac5be4
Nov 30 2020, 4:38 AM

Nov 27 2020

hans added a reverting change for rG3e9a7b2ba470: [ASTMatchers] Matcher macros with params move params instead of copying: rG0ce32a79825f: Revert "[ASTMatchers] Matcher macros with params move params instead of copying".
Nov 27 2020, 5:52 AM
hans committed rG0ce32a79825f: Revert "[ASTMatchers] Matcher macros with params move params instead of copying" (authored by hans).
Revert "[ASTMatchers] Matcher macros with params move params instead of copying"
Nov 27 2020, 5:52 AM
hans added a reverting change for D75096: [ASTMatchers] Matcher macros with params move params instead of copying: rG0ce32a79825f: Revert "[ASTMatchers] Matcher macros with params move params instead of copying".
Nov 27 2020, 5:52 AM · Restricted Project
hans added a comment to D92191: [clang-scan-deps] Add support for clang-cl.

Seems reasonable to me, but someone who actually knows clang-scan-deps should take a look too.

Nov 27 2020, 2:23 AM · Restricted Project

Nov 24 2020

hans accepted D91970: [lld/mac] Implement basic typo correction for flags.
Nov 24 2020, 8:29 AM · Restricted Project
hans accepted D92037: clang: Pass -platform-version to new MachO LLD.
Nov 24 2020, 8:09 AM · Restricted Project
hans accepted D92028: Fix driver test from e16c0a9a689719.
Nov 24 2020, 7:02 AM · Restricted Project
hans committed rG38236656ab4a: [docs] Try to make this bullet list in ThinLTO.rst actually be a bullet list (authored by hans).
[docs] Try to make this bullet list in ThinLTO.rst actually be a bullet list
Nov 24 2020, 5:09 AM

Nov 23 2020

hans added a comment to D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.

Thanks for the pointers!

Nov 23 2020, 7:40 AM · Restricted Project
hans accepted D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.

(I added a naming comment, but feel free to resolve that as you feel is best.)

Nov 23 2020, 6:35 AM · Restricted Project
hans accepted D91884: clang+lld: Improve clang+ld.darwinnew.lld interaction, pass -demangle.

lgtm, probably check with maskray that he's happy first though.

Nov 23 2020, 6:01 AM · Restricted Project, Restricted Project
hans added inline comments to D91884: clang+lld: Improve clang+ld.darwinnew.lld interaction, pass -demangle.
Nov 23 2020, 5:17 AM · Restricted Project, Restricted Project

Nov 17 2020

hans added a comment to D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.

@hans - Can you check whether this works fine with libfuzzer and LLD's ICF?

Yes, this appears to fix the problem we saw. (I tried on Chromium's base_unittests.exe, where ICF time dropped from 13 s with the bad patch to 73 ms with this patch.) Thanks!

Awesome, thanks! Do you want to have a look at the patch itself and review it, or does @rnk have time? (It's his original suggestion, to emit xdata in .seh_endproc, but the implementation is entirely trivial.)

(I also have a couple more patches that can go on top of this, that simplifies things a bit further, and emits pdata together with xdata at the end of the function.)

Nov 17 2020, 1:23 AM · Restricted Project

Nov 16 2020

hans added a comment to D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.

@hans - Can you check whether this works fine with libfuzzer and LLD's ICF?

Nov 16 2020, 7:23 AM · Restricted Project
hans added a comment to D87544: [CFGuard] Add address-taken IAT tables and delay-load support.

For Chromium, the latest patch seems to fix the issues we saw. Thanks!

Nov 16 2020, 6:24 AM · Restricted Project
hans added a comment to D91083: [AsmPrinter] fix -disable-debug-info option.

Thanks for identifying that. I think I can re-land just without that part of the test. It is not essential, I added it just to try to check all of the dwarf-related output.

Nov 16 2020, 6:10 AM · Restricted Project
hans added a comment to D91494: Build reproducible tarballs for releases.

Making the tarballs more reproducible sounds great.

Nov 16 2020, 6:09 AM · Restricted Project

Nov 13 2020

hans added a comment to D91083: [AsmPrinter] fix -disable-debug-info option.

The test fails on Mac, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863756117615904432/+/steps/package_clang/0/stdout

Nov 13 2020, 4:51 AM · Restricted Project
hans added a reverting change for rG9606ef03f039: [AsmPrinter] fix -disable-debug-info option: rG105ed27ed80d: Revert "[AsmPrinter] fix -disable-debug-info option".
Nov 13 2020, 4:51 AM
hans committed rG105ed27ed80d: Revert "[AsmPrinter] fix -disable-debug-info option" (authored by hans).
Revert "[AsmPrinter] fix -disable-debug-info option"
Nov 13 2020, 4:51 AM
hans added a reverting change for D91083: [AsmPrinter] fix -disable-debug-info option: rG105ed27ed80d: Revert "[AsmPrinter] fix -disable-debug-info option".
Nov 13 2020, 4:51 AM · Restricted Project

Nov 12 2020

hans committed rGa088766508aa: [dllexport] Instantiate default ctor default args for explicit specializations… (authored by hans).
[dllexport] Instantiate default ctor default args for explicit specializations…
Nov 12 2020, 4:35 AM
hans closed D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811).
Nov 12 2020, 4:35 AM · Restricted Project
hans added a comment to D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811).

I don't think it makes sense to try to emit the closure until we have the ctor definition. I'll update the patch to handle this.

Ok. That's a bit different than what MSVC is doing. It generates a closure constructor even if there is only a declaration. But I guess we are not aligning specifically with MSVC!
Look good.

Nov 12 2020, 4:29 AM · Restricted Project
hans committed rGb9d36540a85b: [dllexport] Avoid assert for explicitly defaulted methods in explicit… (authored by hans).
[dllexport] Avoid assert for explicitly defaulted methods in explicit…
Nov 12 2020, 4:26 AM
hans closed D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683).
Nov 12 2020, 4:26 AM · Restricted Project

Nov 11 2020

hans added a comment to D87544: [CFGuard] Add address-taken IAT tables and delay-load support.

This caused a regression when calling through function pointers in a certain way as seen in sqlite3: https://bugs.llvm.org/show_bug.cgi?id=47905

Nov 11 2020, 7:08 AM · Restricted Project
hans added a reverting change for D87544: [CFGuard] Add address-taken IAT tables and delay-load support: rG418f18c6cdfe: Revert "Reland [CFGuard] Add address-taken IAT tables and delay-load support".
Nov 11 2020, 7:04 AM · Restricted Project
hans added a reverting change for rGcfd8481da1ad: Reland [CFGuard] Add address-taken IAT tables and delay-load support: rG418f18c6cdfe: Revert "Reland [CFGuard] Add address-taken IAT tables and delay-load support".
Nov 11 2020, 7:04 AM
hans committed rG418f18c6cdfe: Revert "Reland [CFGuard] Add address-taken IAT tables and delay-load support" (authored by hans).
Revert "Reland [CFGuard] Add address-taken IAT tables and delay-load support"
Nov 11 2020, 7:04 AM

Nov 10 2020

hans updated the diff for D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811).

Handling the decl only case.

Nov 10 2020, 7:53 AM · Restricted Project
hans added a comment to D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811).

clang.exe -c test.cpp
Assertion failed: !hasUninstantiatedDefaultArg() && "Default argument is not yet instantiated!", file D:\IUSERS\zahiraam\llorg_ws\ws1\llvm\clang\lib\AST\Decl.cpp, line 2719
PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace, preprocessed source, and associated run script.

Nov 10 2020, 7:51 AM · Restricted Project

Nov 9 2020

hans added a comment to D79591: Default arguments of an exported default constructor should be instantiated. Fix for Bug45811 - Failed assertion..

I was looking into this today, and sent out what I think is a better approach: https://reviews.llvm.org/D91089

Nov 9 2020, 10:34 AM
hans added a comment to D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811).

Please take a look.

Nov 9 2020, 10:33 AM · Restricted Project
hans requested review of D91089: [dllexport] Instantiate default ctor default args for explicit specializations (PR45811).
Nov 9 2020, 10:28 AM · Restricted Project
hans added inline comments to D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683).
Nov 9 2020, 4:36 AM · Restricted Project
hans updated the diff for D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683).

Addressing comments.

Nov 9 2020, 1:52 AM · Restricted Project
hans added inline comments to D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683).
Nov 9 2020, 1:51 AM · Restricted Project

Nov 5 2020

hans added a comment to D87372: clang-cl: Ignore /Zc:externConstexpr and /Zc:throwingNew.

@hans they are ignored because Clang behaves like MSVC with these options
enabled (C++ standard conformance mode)

Nov 5 2020, 8:54 AM · Restricted Project
hans requested review of D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683).
Nov 5 2020, 6:17 AM · Restricted Project

Nov 4 2020

hans added a comment to D87372: clang-cl: Ignore /Zc:externConstexpr and /Zc:throwingNew.

I'm not sure ignoring these is the right thing to do. Maybe they should be "Unsupported but parsed options" instead?

Nov 4 2020, 5:03 AM · Restricted Project
hans accepted D87368: clang-cl: Alias /wd5054 to -Wno-deprecated-anon-enum-enum-conversion.

lgtm

Nov 4 2020, 5:00 AM · Restricted Project
hans accepted D87364: clang-cl: Alias /wd4238 to -Wno-address-of-temporary.

lgtm

Nov 4 2020, 4:20 AM · Restricted Project
hans accepted D87360: clang-cl: Alias /wd4101 to -Wno-unused-variable.

lgtm

Nov 4 2020, 4:13 AM · Restricted Project

Nov 3 2020

hans committed rG1d3cd7172b2f: Fix GCC error: specialization of 'template<class LeafTy> struct llvm… (authored by hans).
Fix GCC error: specialization of 'template<class LeafTy> struct llvm…
Nov 3 2020, 7:56 AM
hans added a reverting change for rG36c64af9d7f9: [CodeGen] [WinException] Only produce handler data at the end of the function…: rGcbf25fbed5b4: Revert "[CodeGen] [WinException] Only produce handler data at the end of the….
Nov 3 2020, 4:12 AM
hans committed rGcbf25fbed5b4: Revert "[CodeGen] [WinException] Only produce handler data at the end of the… (authored by hans).
Revert "[CodeGen] [WinException] Only produce handler data at the end of the…
Nov 3 2020, 4:12 AM
hans added a reverting change for D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed: rGcbf25fbed5b4: Revert "[CodeGen] [WinException] Only produce handler data at the end of the….
Nov 3 2020, 4:12 AM · Restricted Project
hans added a comment to D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.

Sorry for the late follow-up, but this caused big problems in Chromium.

Nov 3 2020, 4:12 AM · Restricted Project

Nov 2 2020

hans added inline comments to D90291: [clangd] Add lit tests for remote index.
Nov 2 2020, 6:28 AM · Restricted Project