hans (Hans Wennborg)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 6:48 AM (231 w, 2 d)

Recent Activity

Yesterday

hans accepted D37732: Add missing NL (new line) at EOF (end of file).

This looks good to me. Do you have commit access, or would you like me to commit for you?

Fri, Sep 22, 9:25 AM · Restricted Project

Wed, Sep 20

hans committed rL313781: Revert r313771 "[SLP] Vectorize jumbled memory loads.".
Revert r313771 "[SLP] Vectorize jumbled memory loads."
Wed, Sep 20, 11:02 AM
hans committed rL313780: Pacify a gcc -Wparentheses warning.
Pacify a gcc -Wparentheses warning
Wed, Sep 20, 11:01 AM
hans committed rL313779: Pacify gcc's -Wnum-compare after r313775.
Pacify gcc's -Wnum-compare after r313775
Wed, Sep 20, 11:01 AM
hans added a comment to D37732: Add missing NL (new line) at EOF (end of file).
In D37732#869928, @hans wrote:

I don't know much about VS, but doesn't it already have an option to save files with newline at end of file?

Unfortunately, it doesn't have this option.

If we want clang-format to do this, should it perhaps be part of clang-format.exe itself, rather than the plugin?

That would be even better. However, since this is practically a Windows only problem I don't have many hopes.

In Linux/UNIX world, the POSIX requirement for LINE termination is implemented virtually by all text editors. Some don't even have an option to do otherwise.

Wed, Sep 20, 10:45 AM · Restricted Project
hans accepted D38068: [DebugInfo] Use a DenseMap to coalesce MachineOperand locations.

I'm not familiar with the DBG_VALUE stuff, but this looks good as far as I can tell.

Wed, Sep 20, 10:15 AM

Mon, Sep 18

hans committed rL313600: Drop -O1 case from nrvo-string.cpp.
Drop -O1 case from nrvo-string.cpp
Mon, Sep 18, 4:56 PM
hans committed rL313589: Revert r313400 "[DebugInfo] Insert DW_OP_deref when spilling indirect….
Revert r313400 "[DebugInfo] Insert DW_OP_deref when spilling indirect…
Mon, Sep 18, 4:10 PM
hans added inline comments to D37940: Peel off the dominant case in switch statement.
Mon, Sep 18, 12:14 PM
hans accepted D37936: docs: Add instructions for how to submit a merge request.

Very nice, thanks!

Mon, Sep 18, 11:57 AM

Fri, Sep 15

hans added inline comments to D37940: Peel off the dominant case in switch statement.
Fri, Sep 15, 3:56 PM
hans added a comment to D37936: docs: Add instructions for how to submit a merge request.

Good stuff!

Fri, Sep 15, 3:03 PM
hans updated subscribers of D37909: [AutoUpgrade] Fix a compatibility issue with module flag.

Was I CC'd on this because it's a candidate for 5.0.1? If so, +Tom who manages that release.

Fri, Sep 15, 2:33 PM
hans committed rL313376: Revert r313343 "[X86] PR32755 : Improvement in CodeGen instruction selection….
Revert r313343 "[X86] PR32755 : Improvement in CodeGen instruction selection…
Fri, Sep 15, 11:42 AM

Wed, Sep 13

hans committed rL313222: Revert r313157 "ThinLTO: Correctly follow aliasee references when dead….
Revert r313157 "ThinLTO: Correctly follow aliasee references when dead…
Wed, Sep 13, 5:41 PM
hans committed rL313213: Revert r312719 "[MachineCombiner] Update instruction depths incrementally for….
Revert r312719 "[MachineCombiner] Update instruction depths incrementally for…
Wed, Sep 13, 4:24 PM
hans added a comment to D37732: Add missing NL (new line) at EOF (end of file).

(Meta comment: please upload patches with more context so the rest of the files show up in the review. If you generate the patch with diff or git diff, do it by passing along -U9999.)

Wed, Sep 13, 11:47 AM · Restricted Project
hans accepted D37786: merge-request.sh: Update to use new "Fixed by Commit(s)" field.

Looks good to me.

Wed, Sep 13, 8:55 AM

Tue, Sep 12

hans committed rL313071: drop paren.
drop paren
Tue, Sep 12, 1:16 PM
hans committed rL313070: Link to the clang-format extension at the VS Marketplace.
Link to the clang-format extension at the VS Marketplace
Tue, Sep 12, 1:15 PM
hans committed rL313068: Win snapshot: upload clang-format-vs extension with new vsix id.
Win snapshot: upload clang-format-vs extension with new vsix id
Tue, Sep 12, 1:03 PM
hans committed rL313060: clang-format-vs: Update the VSIX ID..
clang-format-vs: Update the VSIX ID.
Tue, Sep 12, 11:40 AM
hans committed rL313050: Win snapshot: r313013.
Win snapshot: r313013
Tue, Sep 12, 10:16 AM
hans committed rL313044: Revert r313009 "[ARM] Use ADDCARRY / SUBCARRY".
Revert r313009 "[ARM] Use ADDCARRY / SUBCARRY"
Tue, Sep 12, 9:25 AM

Mon, Sep 11

hans committed rL312980: Revert r312898 "[ARM] Use ADDCARRY / SUBCARRY".
Revert r312898 "[ARM] Use ADDCARRY / SUBCARRY"
Mon, Sep 11, 4:53 PM
hans committed rL312946: Add MIPS and Debian binaries for 5.0.0.
Add MIPS and Debian binaries for 5.0.0
Mon, Sep 11, 1:46 PM
hans created D37705: Update clang-tidy-vs project files etc to build with VS2017.
Mon, Sep 11, 1:29 PM
hans created D37704: Build the clang-tidy vsix plugin in build_llvm_package.bat.
Mon, Sep 11, 1:28 PM

Fri, Sep 8

hans committed rL312800: Add Ubuntu binaries for 5.0.0.
Add Ubuntu binaries for 5.0.0
Fri, Sep 8, 9:47 AM

Thu, Sep 7

hans committed rL312737: Update links etc for 5.0.0.
Update links etc for 5.0.0
Thu, Sep 7, 11:42 AM
hans committed rL312731: 5.0.0 files.
5.0.0 files
Thu, Sep 7, 10:50 AM

Tue, Sep 5

hans added a comment to D37240: Fix crbug 759265 by suppressing llvm mt warnings..

Seems fine to me. Rui should probably sign off on it, though.

Tue, Sep 5, 2:42 PM
hans committed rL312550: Creating release candidate final from release_500 branch.
Creating release candidate final from release_500 branch
Tue, Sep 5, 11:39 AM
hans committed rL312548: Creating release candidate final from release_500 branch.
Creating release candidate final from release_500 branch
Tue, Sep 5, 11:33 AM
hans committed rL312556: Creating release candidate final from release_500 branch.
Creating release candidate final from release_500 branch
Tue, Sep 5, 11:31 AM
hans committed rL312559: Creating release candidate final from release_500 branch.
Creating release candidate final from release_500 branch
Tue, Sep 5, 11:31 AM
hans committed rL312558: Creating release candidate final from release_500 branch.
Creating release candidate final from release_500 branch
Tue, Sep 5, 11:31 AM
hans committed rL312557: Creating release candidate final from release_500 branch.
Creating release candidate final from release_500 branch
Tue, Sep 5, 11:30 AM
hans committed rL312549: Creating release candidate final from release_500 branch.
Creating release candidate final from release_500 branch
Tue, Sep 5, 11:29 AM
hans committed rL312554: Creating release candidate final from release_500 branch.
Creating release candidate final from release_500 branch
Tue, Sep 5, 11:28 AM
hans committed rL312553: Creating release candidate final from release_500 branch.
Creating release candidate final from release_500 branch
Tue, Sep 5, 11:27 AM
hans committed rL312552: Creating release candidate final from release_500 branch.
Creating release candidate final from release_500 branch
Tue, Sep 5, 11:27 AM
hans committed rL312551: Creating release candidate final from release_500 branch.
Creating release candidate final from release_500 branch
Tue, Sep 5, 11:23 AM

Fri, Sep 1

hans committed rL312369: Creating release candidate rc5 from release_500 branch.
Creating release candidate rc5 from release_500 branch
Fri, Sep 1, 2:16 PM
hans committed rL312367: Creating release candidate rc5 from release_500 branch.
Creating release candidate rc5 from release_500 branch
Fri, Sep 1, 2:13 PM
hans committed rL312375: Creating release candidate rc5 from release_500 branch.
Creating release candidate rc5 from release_500 branch
Fri, Sep 1, 2:13 PM
hans committed rL312378: Creating release candidate rc5 from release_500 branch.
Creating release candidate rc5 from release_500 branch
Fri, Sep 1, 2:11 PM
hans committed rL312377: Creating release candidate rc5 from release_500 branch.
Creating release candidate rc5 from release_500 branch
Fri, Sep 1, 2:11 PM
hans committed rL312376: Creating release candidate rc5 from release_500 branch.
Creating release candidate rc5 from release_500 branch
Fri, Sep 1, 2:11 PM
hans committed rL312368: Creating release candidate rc5 from release_500 branch.
Creating release candidate rc5 from release_500 branch
Fri, Sep 1, 2:10 PM
hans committed rL312373: Creating release candidate rc5 from release_500 branch.
Creating release candidate rc5 from release_500 branch
Fri, Sep 1, 2:09 PM
hans committed rL312372: Creating release candidate rc5 from release_500 branch.
Creating release candidate rc5 from release_500 branch
Fri, Sep 1, 2:09 PM
hans committed rL312371: Creating release candidate rc5 from release_500 branch.
Creating release candidate rc5 from release_500 branch
Fri, Sep 1, 2:08 PM
hans committed rL312370: Creating release candidate rc5 from release_500 branch.
Creating release candidate rc5 from release_500 branch
Fri, Sep 1, 2:06 PM
hans committed rL312334: Merging r312065:.
Merging r312065:
Fri, Sep 1, 9:33 AM
hans committed rL312333: Merging r312285:.
Merging r312285:
Fri, Sep 1, 9:30 AM

Thu, Aug 31

hans accepted D37317: [X86] Don't pull carry through X86ISD::ADD carryin, -1 if we can't guranteed we're really using the carry flag from the add..
Thu, Aug 31, 12:46 PM
hans accepted D37336: [clang-cl] Explicitly set object format to COFF in CL mode.

lgtm

Thu, Aug 31, 12:40 PM
hans added a comment to D37317: [X86] Don't pull carry through X86ISD::ADD carryin, -1 if we can't guranteed we're really using the carry flag from the add..

The X86ISelLowering.cpp change looks good to me.

Thu, Aug 31, 11:54 AM
hans added a comment to D37336: [clang-cl] Explicitly set object format to COFF in CL mode.
In D37336#857802, @hans wrote:

But why isn't that failure showing on some buildbot, then?

The test needs system-windows to run:

// REQUIRES: system-windows

There is no windows buildbot that builds clang defaulted to the AArch64 target.

Thu, Aug 31, 9:29 AM
hans added a comment to D37336: [clang-cl] Explicitly set object format to COFF in CL mode.

Seems reasonable, but should probably have a test.

Thu, Aug 31, 8:52 AM
hans added inline comments to D37240: Fix crbug 759265 by suppressing llvm mt warnings..
Thu, Aug 31, 8:42 AM

Wed, Aug 30

hans committed rL312193: Fix the test fix from r312181.
Fix the test fix from r312181
Wed, Aug 30, 4:27 PM
hans committed rL312182: Revert r312139 "Verifier: Verify the correctness of fragment expressions….
Revert r312139 "Verifier: Verify the correctness of fragment expressions…
Wed, Aug 30, 3:42 PM
hans committed rL312178: Revert r312154 "Re-enable "[MachineCopyPropagation] Extend pass to do COPY….
Revert r312154 "Re-enable "[MachineCopyPropagation] Extend pass to do COPY…
Wed, Aug 30, 3:16 PM
hans committed rL312155: ReleaseNotes: one back-tick too many.
ReleaseNotes: one back-tick too many
Wed, Aug 30, 11:44 AM
hans committed rL312153: ReleaseNotes: remove another in-progress warning.
ReleaseNotes: remove another in-progress warning
Wed, Aug 30, 11:42 AM
hans committed rL312152: ReleaseNotes: remove another in-progress warning.
ReleaseNotes: remove another in-progress warning
Wed, Aug 30, 11:39 AM
hans committed rL312150: Merging r312149:.
Merging r312149:
Wed, Aug 30, 11:37 AM
hans committed rL312149: docs: typo fix.
docs: typo fix
Wed, Aug 30, 11:37 AM
hans committed rL312142: docs: remove dead doxygen tarball link.
docs: remove dead doxygen tarball link
Wed, Aug 30, 10:41 AM

Tue, Aug 29

hans added inline comments to D37240: Fix crbug 759265 by suppressing llvm mt warnings..
Tue, Aug 29, 5:51 PM
hans added inline comments to D36255: Integrate manifest merging library into LLD..
Tue, Aug 29, 5:22 PM
hans added inline comments to D36255: Integrate manifest merging library into LLD..
Tue, Aug 29, 5:20 PM
hans committed rL312071: Creating release candidate rc4 from release_500 branch.
Creating release candidate rc4 from release_500 branch
Tue, Aug 29, 5:02 PM
hans committed rL312077: Creating release candidate rc4 from release_500 branch.
Creating release candidate rc4 from release_500 branch
Tue, Aug 29, 5:01 PM
hans committed rL312069: Creating release candidate rc4 from release_500 branch.
Creating release candidate rc4 from release_500 branch
Tue, Aug 29, 5:00 PM
hans committed rL312080: Creating release candidate rc4 from release_500 branch.
Creating release candidate rc4 from release_500 branch
Tue, Aug 29, 4:59 PM
hans committed rL312079: Creating release candidate rc4 from release_500 branch.
Creating release candidate rc4 from release_500 branch
Tue, Aug 29, 4:59 PM
hans committed rL312078: Creating release candidate rc4 from release_500 branch.
Creating release candidate rc4 from release_500 branch
Tue, Aug 29, 4:58 PM
hans committed rL312070: Creating release candidate rc4 from release_500 branch.
Creating release candidate rc4 from release_500 branch
Tue, Aug 29, 4:58 PM
hans committed rL312075: Creating release candidate rc4 from release_500 branch.
Creating release candidate rc4 from release_500 branch
Tue, Aug 29, 4:57 PM
hans committed rL312074: Creating release candidate rc4 from release_500 branch.
Creating release candidate rc4 from release_500 branch
Tue, Aug 29, 4:57 PM
hans committed rL312073: Creating release candidate rc4 from release_500 branch.
Creating release candidate rc4 from release_500 branch
Tue, Aug 29, 4:56 PM
hans committed rL312072: Creating release candidate rc4 from release_500 branch.
Creating release candidate rc4 from release_500 branch
Tue, Aug 29, 4:54 PM
hans accepted D37278: Restore clang_rt library name on i686-android..

Thanks! Looks good to me.

Tue, Aug 29, 2:52 PM
hans committed rL312041: Merging r312022:.
Merging r312022:
Tue, Aug 29, 2:39 PM
hans added a comment to D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386.

IMHO it was a very bad idea to include the "architecture name" (not even a target triple!) in the library path in the first place. No one else does that. GCC made the right choice and called theirs "libasan.so".

My plan is to tweak the code that sets the library name to use i686 when the target is i386 and the os is android, both in compiler-rt and in clang. There will be no duplicate targets.

Tue, Aug 29, 2:07 PM
hans accepted D37272: [cmake] Stop putting the revision info in LLVM_VERSION_STRING.
Tue, Aug 29, 2:07 PM
hans committed rL312022: [DAG] Bound loop dependence check in merge optimization..
[DAG] Bound loop dependence check in merge optimization.
Tue, Aug 29, 11:47 AM
hans added a comment to D37220: [DAG] Bound loop dependence check in merge optimization..

I've gone ahead and committed this to unblock the release.

Tue, Aug 29, 11:42 AM
hans closed D37220: [DAG] Bound loop dependence check in merge optimization. by committing rL312022: [DAG] Bound loop dependence check in merge optimization..
Tue, Aug 29, 11:42 AM
hans added inline comments to D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386.
Tue, Aug 29, 11:27 AM
hans committed rL312016: Merging r312008:.
Merging r312008:
Tue, Aug 29, 10:34 AM
hans committed rL312014: Merging r311835:.
Merging r311835:
Tue, Aug 29, 10:18 AM
hans committed rL312013: Merging r311823: (+update ClangCommandLineReference.rst).
Merging r311823: (+update ClangCommandLineReference.rst)
Tue, Aug 29, 10:15 AM
hans added a reviewer for D37220: [DAG] Bound loop dependence check in merge optimization.: dim.

I'm not sure if Nirav is around.

Tue, Aug 29, 10:07 AM
hans added a comment to D37220: [DAG] Bound loop dependence check in merge optimization..

Based on Dimitry's comment in https://bugs.llvm.org/show_bug.cgi?id=34326#c13 this seems to solve the problem. Can we get it landed so it can be part of 5.0.0?

Tue, Aug 29, 9:46 AM

Mon, Aug 28

hans committed rL311932: ReleaseNotes: NetBSD LLDB improvements.
ReleaseNotes: NetBSD LLDB improvements
Mon, Aug 28, 1:56 PM
hans added a comment to D33852: Enable __declspec(selectany) on linux.

Sorry for so late fixes, but it would be good to put it in 5.0

I do not think this should be in 5.0, as I believe we're only accepting regression fixes at this point.

This is a regression. __declspec(selectany) works completely fine on linux with 4.0. Without it clang-5.0 will be useless for any major windows project compiled on linux.

edit:
here is a regression: https://reviews.llvm.org/D32083

This is also adding new functionality that has had zero testing because it removes *all* target-specific checking for the attribute. Under the previous functionality (changed in D32083), this still required some mention of microsoft something (it went from requiring microsoft extensions to be enabled to instead require a Windows target) -- that's been entirely removed from this patch so now you can use this attribute for all target architectures, so it's not purely fixing a regression. Given how late we are in the release cycle, I am uncomfortable with this going in to 5.0, but I'd have no problems letting it bake for a bit and putting it into 5.1 (or 5.0.1, however we're naming bug releases these days).

Mon, Aug 28, 1:53 PM