hans (Hans Wennborg)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 6:48 AM (274 w, 2 d)

Recent Activity

Fri, Jul 6

hans committed rLLD336424: Relax filechecks in r336405 tests.
Relax filechecks in r336405 tests
Fri, Jul 6, 1:49 AM
hans committed rLLD336423: dos2unix.
dos2unix
Fri, Jul 6, 1:49 AM
hans committed rL336424: Relax filechecks in r336405 tests.
Relax filechecks in r336405 tests
Fri, Jul 6, 1:49 AM
hans committed rL336423: dos2unix.
dos2unix
Fri, Jul 6, 1:49 AM

Thu, Jul 5

hans committed rL336415: [ms] Fix mangling of string literals used to initialize arrays larger or….
[ms] Fix mangling of string literals used to initialize arrays larger or…
Thu, Jul 5, 11:59 PM
hans committed rC336415: [ms] Fix mangling of string literals used to initialize arrays larger or….
[ms] Fix mangling of string literals used to initialize arrays larger or…
Thu, Jul 5, 11:59 PM
hans closed D48928: [ms] Fix mangling of string literals used to initialize arrays larger or smaller than the literal.
Thu, Jul 5, 11:59 PM
hans added inline comments to D48928: [ms] Fix mangling of string literals used to initialize arrays larger or smaller than the literal.
Thu, Jul 5, 11:47 PM

Wed, Jul 4

hans added a comment to D48928: [ms] Fix mangling of string literals used to initialize arrays larger or smaller than the literal.

I couldn't get MSVC to create a symbol with padding at the end; they seem to always insert the padding with a separate loop during initialization, but this does show the truncated case: https://godbolt.org/g/B8ktA3

Wed, Jul 4, 3:26 AM
hans created D48928: [ms] Fix mangling of string literals used to initialize arrays larger or smaller than the literal.
Wed, Jul 4, 3:24 AM

Tue, Jul 3

hans updated the diff for D48875: [ADT] Align unique_function::CallImpl when using clang on Windows.

Trying not to get the #ifdefs backwards..

Tue, Jul 3, 5:11 AM
hans created D48875: [ADT] Align unique_function::CallImpl when using clang on Windows.
Tue, Jul 3, 5:08 AM
hans committed rL336192: build_llvm_package.bat: Re-try the build steps.
build_llvm_package.bat: Re-try the build steps
Tue, Jul 3, 4:34 AM
hans committed rL336190: Win snapshot: r336178.
Win snapshot: r336178
Tue, Jul 3, 4:30 AM
hans added a comment to D45045: [DebugInfo] Generate debug information for labels..

This broke the Chromium build. I've uploaded a reproducer at https://bugs.chromium.org/p/chromium/issues/detail?id=841170#c1

I'm guessing maybe a Clang bootstrap with debug info might also reproduce the problem, but I haven't tried that.

Reverted in r331861.

https://reviews.llvm.org/D46738 should fix the bug.

rL336176 has fixed the bug. Could I revert the commit?
You could refer to PR37395.

Tue, Jul 3, 2:38 AM
hans committed rL336175: Revert r336021 "PR33924: merge local declarations that have linkage of some….
Revert r336021 "PR33924: merge local declarations that have linkage of some…
Tue, Jul 3, 12:56 AM
hans committed rC336175: Revert r336021 "PR33924: merge local declarations that have linkage of some….
Revert r336021 "PR33924: merge local declarations that have linkage of some…
Tue, Jul 3, 12:56 AM
hans accepted D48601: Added -fcrash-diagnostics-dir flag.

lgtm

Tue, Jul 3, 12:37 AM

Mon, Jul 2

hans accepted D48781: [ms] Fix mangling of char16_t and char32_t to be compatible with MSVC..

lgtm with nit

Mon, Jul 2, 5:09 AM

Fri, Jun 29

hans accepted D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.

This looks good to me.

Fri, Jun 29, 4:54 AM

Thu, Jun 28

hans accepted D48690: lld-link: align sections to 16 bytes if referenced from the gfids table.
Thu, Jun 28, 8:24 AM
hans added a comment to D48690: lld-link: align sections to 16 bytes if referenced from the gfids table.

Nice! I like how simple this turned out.

Thu, Jun 28, 4:44 AM
hans committed rL335831: s/TablesChecked/TableChecked/ after r335823.
s/TablesChecked/TableChecked/ after r335823
Thu, Jun 28, 3:29 AM

Wed, Jun 27

hans added inline comments to D48601: Added -fcrash-diagnostics-dir flag.
Wed, Jun 27, 2:16 AM

Tue, Jun 26

hans committed rL335601: Users.html: Ericsson.
Users.html: Ericsson
Tue, Jun 26, 6:51 AM
hans added a comment to D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.

This looks reasonable to me as far as I can tell. Thanks!

Tue, Jun 26, 6:03 AM

Mon, Jun 25

hans committed rL335466: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801).
[clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801)
Mon, Jun 25, 6:28 AM
hans committed rC335466: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801).
[clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801)
Mon, Jun 25, 6:28 AM
hans closed D48426: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801).
Mon, Jun 25, 6:28 AM
hans added inline comments to D48426: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801).
Mon, Jun 25, 5:52 AM
hans updated the diff for D48426: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801).

Added special-casing for explicit template instantiations, and missing test case suggested by Nico.

Mon, Jun 25, 4:42 AM
hans added a comment to D48494: [doc] Show the git config for Windows to do line-endings correctly.

I've only ever had bad experiences from the version control system trying to fix line endings. I'd prefer recommending people staying with the default, core.autocrlf = false.

Mon, Jun 25, 12:51 AM

Fri, Jun 22

hans added a comment to D48426: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801).

I hit a snag while building some more Chromium targets. For class templates with explicit instantiation decls in the PCH file and explicit instantiation definitions in a .cc file, the function definition will be marked as coming from the PCH, even though it wasn't defined there. For example:

Fri, Jun 22, 7:31 AM
hans updated the diff for D48426: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801).

Addressing review comments.

Fri, Jun 22, 3:00 AM
hans added a comment to D48426: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801).
In D48426#1139823, @rnk wrote:

LangOpts.ModulesCodegen is very related in spirit to this, but I think we need a distinct option because that was designed to handle all inline functions (too much), not just dllexport inline functions. + @dblaikie

Does it have to be only the dllexported inline functions - or could this be used to home all inline functions? (I guess not - presumably it's not acceptable for the compiler to implicitly promote something to dllexport (& if it doesn't do that promotion, then the function wouldn't be visible from the use))

Fri, Jun 22, 2:58 AM

Jun 21 2018

hans added a comment to D48426: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801).

PCHs aren't compatible with themselves if only the compiler revision changes, so I'm not sure changing that field should be worse than a regular compiler revision update (which happens at every commit). But I don't know what this field is for. I don't remember any trouble from me changing it though, and if it was bad to change it I'd hope there'd be a comment right above the field telling us why. (If I had run into problems, I would've expected me to add a comment like this.)

Jun 21 2018, 8:18 AM
hans added a comment to D48426: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801).

I think you revved the PCH version last. Did you have to do anything special, e.g. will it break vendors who ship PCH files as part of SDKs and such? Or are things generally set up to handle this?

Jun 21 2018, 6:57 AM
hans created D48426: [clang-cl] Don't emit dllexport inline functions etc. from pch files (PR37801).
Jun 21 2018, 6:19 AM

Jun 20 2018

hans added a comment to D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers.
In D46652#1138375, @rnk wrote:

@hans, think you'll have time to look at this with your recent dllexport PCH experimentation?

Jun 20 2018, 11:58 PM

Jun 18 2018

hans accepted D48219: Update copyright year in license files.

@hans maybe this task should go on the release manager checklist? That's the closest thing to an annual reminder I can think of, that is likely to work.

Jun 18 2018, 1:43 AM

Jun 14 2018

hans committed rC334692: [clang-format] Add SpaceBeforeCpp11BracedList option..
[clang-format] Add SpaceBeforeCpp11BracedList option.
Jun 14 2018, 1:06 AM
hans committed rL334692: [clang-format] Add SpaceBeforeCpp11BracedList option..
[clang-format] Add SpaceBeforeCpp11BracedList option.
Jun 14 2018, 1:05 AM
hans closed D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..
Jun 14 2018, 1:05 AM

Jun 13 2018

hans added a comment to D47578: Do not enforce absolute path argv0 in windows.

Rui-san, can I ask you to merge this?

Jun 13 2018, 7:37 AM
hans committed rL334602: Do not enforce absolute path argv0 in windows.
Do not enforce absolute path argv0 in windows
Jun 13 2018, 7:33 AM
hans committed rL334584: GettingStarted.rst: Fix 'If you you' typo (PR37787).
GettingStarted.rst: Fix 'If you you' typo (PR37787)
Jun 13 2018, 2:25 AM
hans committed rL334582: Fix -DLLVM_ENABLE_THREADS=OFF build after r334537.
Fix -DLLVM_ENABLE_THREADS=OFF build after r334537
Jun 13 2018, 2:15 AM
hans accepted D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease.

Nice! Looks good to me.

Jun 13 2018, 1:27 AM
hans added a comment to D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

Ross, do you have commit access or do you need someone to commit this for you?

Jun 13 2018, 1:07 AM

Jun 12 2018

hans committed rC334574: crash-report-modules.m: Shorten path length to make Windows bot happy.
crash-report-modules.m: Shorten path length to make Windows bot happy
Jun 12 2018, 11:53 PM
hans committed rL334574: crash-report-modules.m: Shorten path length to make Windows bot happy.
crash-report-modules.m: Shorten path length to make Windows bot happy
Jun 12 2018, 11:53 PM
hans committed rL334494: Re-apply r334418 "Enable crash recovery tests on Windows, globs work in the lit….
Re-apply r334418 "Enable crash recovery tests on Windows, globs work in the lit…
Jun 12 2018, 4:56 AM
hans committed rC334494: Re-apply r334418 "Enable crash recovery tests on Windows, globs work in the lit….
Re-apply r334418 "Enable crash recovery tests on Windows, globs work in the lit…
Jun 12 2018, 4:55 AM
hans committed rC334493: Revert r334418 "Enable crash recovery tests on Windows, globs work in the lit….
Revert r334418 "Enable crash recovery tests on Windows, globs work in the lit…
Jun 12 2018, 4:38 AM
hans committed rL334493: Revert r334418 "Enable crash recovery tests on Windows, globs work in the lit….
Revert r334418 "Enable crash recovery tests on Windows, globs work in the lit…
Jun 12 2018, 4:38 AM
hans added a comment to D46024: [clang-format] Add SpaceBeforeCpp11BracedList option..

FWIW, please note that this space-before-brace style is not specific to WebKit; CppCoreGuidelines exhibits it as well:
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es23-prefer-the--initializer-syntax

Jun 12 2018, 2:00 AM
hans committed rL334484: Add 7.0.0 release schedule.
Add 7.0.0 release schedule
Jun 12 2018, 1:37 AM

Jun 11 2018

hans added a comment to D47672: [Headers] Add _Interlocked*_HLEAcquire/_HLERelease.

It sounds like adding proper support for HLE prefixes is a largeish project.

Jun 11 2018, 8:18 AM

Jun 10 2018

hans committed rC334388: [MS ABI] Mangle unnamed empty enums (PR37723).
[MS ABI] Mangle unnamed empty enums (PR37723)
Jun 10 2018, 11:59 PM
hans committed rL334388: [MS ABI] Mangle unnamed empty enums (PR37723).
[MS ABI] Mangle unnamed empty enums (PR37723)
Jun 10 2018, 11:58 PM
hans closed D47875: [MS ABI] Mangle unnamed empty enums (PR37723).
Jun 10 2018, 11:58 PM

Jun 8 2018

hans updated the diff for D47875: [MS ABI] Mangle unnamed empty enums (PR37723).

Falling back to the "Otherwise, number using $S" code for non-empty enums.

Jun 8 2018, 1:27 AM

Jun 7 2018

hans added a comment to D47875: [MS ABI] Mangle unnamed empty enums (PR37723).

Thanks!

Jun 7 2018, 8:02 AM
hans added a comment to D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin.

If we really want to special-case NSInteger, and given that you're targeting a specific wide-spread pattern maybe that's the right thing to do, I think we should make -Wformat accept (move the warning behind -Wformat-pedantic I suppose) printing NSInteger with *any* integral type of the right size, not just size_t.

Would you be similarly okay with %ld and %d on Windows platforms when mixing up int and long?

No, I'm against a general relaxation of -Wformat, but to solve JF's problem I think special-casing NSInteger might be reasonable.

How is JF's problem different?

Jun 7 2018, 7:15 AM
hans added a comment to D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin.

If we really want to special-case NSInteger, and given that you're targeting a specific wide-spread pattern maybe that's the right thing to do, I think we should make -Wformat accept (move the warning behind -Wformat-pedantic I suppose) printing NSInteger with *any* integral type of the right size, not just size_t.

Would you be similarly okay with %ld and %d on Windows platforms when mixing up int and long?

Jun 7 2018, 6:51 AM
hans added a comment to D47290: [Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin.

What's special about size_t though? If I understand your patch correctly, it would suppress warning about printing NSInteger with %zd, but still warn about %ld even though ssize_t=long on the target? As a user I'd find this confusing.

Jun 7 2018, 5:42 AM
hans added a comment to D47875: [MS ABI] Mangle unnamed empty enums (PR37723).

Please take a look.

Jun 7 2018, 4:54 AM
hans created D47875: [MS ABI] Mangle unnamed empty enums (PR37723).
Jun 7 2018, 4:53 AM

Jun 6 2018

hans accepted D47760: utils/release: Add merge-git.sh.

lgtm, just some comments on the comments

Jun 6 2018, 11:39 PM
hans committed rL334100: Relax shtest-run-at-line.py.
Relax shtest-run-at-line.py
Jun 6 2018, 7:57 AM

Jun 4 2018

hans edited reviewers for D47760: utils/release: Add merge-git.sh, added: hans; removed: hansw.
Jun 4 2018, 11:43 PM
hans added a comment to D47760: utils/release: Add merge-git.sh.

Cool!

Jun 4 2018, 11:42 PM

May 30 2018

hans committed rL333521: Win snapshot: r333363..
Win snapshot: r333363.
May 30 2018, 2:16 AM
hans committed rL333520: Set underlying type for enum with GNU_PROPERTY_X86_FEATURE_1_AND constant.
Set underlying type for enum with GNU_PROPERTY_X86_FEATURE_1_AND constant
May 30 2018, 2:09 AM
hans committed rC333515: Add missing curly from r333509.
Add missing curly from r333509
May 30 2018, 1:09 AM
hans committed rL333515: Add missing curly from r333509.
Add missing curly from r333509
May 30 2018, 1:09 AM

May 24 2018

hans committed rL333170: Fix ASTImporterTest on Windows after r333082.
Fix ASTImporterTest on Windows after r333082
May 24 2018, 3:54 AM
hans committed rC333170: Fix ASTImporterTest on Windows after r333082.
Fix ASTImporterTest on Windows after r333082
May 24 2018, 3:54 AM

May 23 2018

hans committed rL333067: Revert r333044 "Use zeroinitializer for (trailing zero portion of) large array….
Revert r333044 "Use zeroinitializer for (trailing zero portion of) large array…
May 23 2018, 1:28 AM
hans committed rC333067: Revert r333044 "Use zeroinitializer for (trailing zero portion of) large array….
Revert r333044 "Use zeroinitializer for (trailing zero portion of) large array…
May 23 2018, 1:28 AM

May 22 2018

hans committed rL332967: LangRef.rst: the "\01" prefix applies not just to variables.
LangRef.rst: the "\01" prefix applies not just to variables
May 22 2018, 3:18 AM

May 17 2018

hans accepted D46966: [lld] Use a real timestamp, with the option to use hash or explicit value.

(Please don't wait for me to land this though, as I'll be ooo for the next couple of days.)

May 17 2018, 2:14 AM
hans added inline comments to D46966: [lld] Use a real timestamp, with the option to use hash or explicit value.
May 17 2018, 1:55 AM

May 16 2018

hans added a comment to D45604: Support for multiarch runtimes layout.

I only looked a little at the Clang parts (the compiler-rt and libcxx cmake stuff I'm not familiar with). It seems reasonable, and would make it easier to ship a cross-compiler I suppose, but I think folks with a higher-level Clang view need to take a look too.

May 16 2018, 7:13 AM

May 15 2018

hans committed rC332335: Make ast-print-record-decl.c pass on Windows after r332314.
Make ast-print-record-decl.c pass on Windows after r332314
May 15 2018, 3:23 AM
hans committed rL332335: Make ast-print-record-decl.c pass on Windows after r332314.
Make ast-print-record-decl.c pass on Windows after r332314
May 15 2018, 3:23 AM

May 14 2018

hans accepted D46786: COFF: Allow ICFing sections with different alignments..

Looks good to me.

May 14 2018, 2:43 AM

May 9 2018

hans committed rC331861: Revert r331843 "[DebugInfo] Generate debug information for labels.".
Revert r331843 "[DebugInfo] Generate debug information for labels."
May 9 2018, 2:33 AM
hans committed rL331861: Revert r331843 "[DebugInfo] Generate debug information for labels.".
Revert r331843 "[DebugInfo] Generate debug information for labels."
May 9 2018, 2:33 AM
hans added a comment to D45045: [DebugInfo] Generate debug information for labels..

This broke the Chromium build. I've uploaded a reproducer at https://bugs.chromium.org/p/chromium/issues/detail?id=841170#c1

May 9 2018, 2:33 AM
hans added a comment to D46527: Object: Find terminator correctly when getting long filenames from GNU archives.

Thanks, Peter! I've committed a test based on this in r331854.

May 9 2018, 1:25 AM
hans committed rL331854: Add a test for r331746..
Add a test for r331746.
May 9 2018, 1:24 AM
hans added a comment to D46520: [Driver] Use -fuse-line-directives by default in MSVC mode.
In D46520#1092233, @rnk wrote:

Please don't do this, this is actually really problematic, since #line directives lose information about what's a system header. That means the result of -E usually won't compile, since Windows headers are typically full of warnings and default-error warnings.

May 9 2018, 12:18 AM

May 8 2018

hans accepted D46572: [clang-format] Add raw string formatting to release notes.

Thanks!

May 8 2018, 2:03 AM
hans committed rL331746: Object: Find terminator correctly when reading long filenames in GNU archives….
Object: Find terminator correctly when reading long filenames in GNU archives…
May 8 2018, 1:26 AM
hans closed D46527: Object: Find terminator correctly when getting long filenames from GNU archives.
May 8 2018, 1:26 AM
hans added a comment to D46527: Object: Find terminator correctly when getting long filenames from GNU archives.

Maybe you can test this by checking in a binary file?

May 8 2018, 1:26 AM

May 7 2018

hans added a reviewer for D46527: Object: Find terminator correctly when getting long filenames from GNU archives: pcc.

+pcc too

May 7 2018, 8:20 AM
hans created D46527: Object: Find terminator correctly when getting long filenames from GNU archives.
May 7 2018, 8:04 AM
hans accepted D46520: [Driver] Use -fuse-line-directives by default in MSVC mode.

Seems reasonable to me (but please update the comment before landing).

May 7 2018, 4:52 AM