Page MenuHomePhabricator

hans (Hans Wennborg)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 6:48 AM (426 w, 4 d)

Recent Activity

Today

hans committed rG5958dc75ced4: Try to fix clang/test/Driver/cl-include.c failure (authored by hans).
Try to fix clang/test/Driver/cl-include.c failure
Mon, Jun 21, 8:21 AM
hans committed rG3063a5472266: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support… (authored by hans).
[clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support…
Mon, Jun 21, 6:42 AM
hans closed D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003).
Mon, Jun 21, 6:42 AM · Restricted Project
hans added inline comments to D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003).
Mon, Jun 21, 6:34 AM · Restricted Project

Thu, Jun 17

hans added inline comments to D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003).
Thu, Jun 17, 6:18 AM · Restricted Project
hans updated the diff for D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003).

More tests, add help text for command-line options.

Thu, Jun 17, 6:18 AM · Restricted Project

Wed, Jun 16

hans accepted D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators..
Wed, Jun 16, 9:07 AM · Restricted Project
hans requested review of D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003).
Wed, Jun 16, 8:02 AM · Restricted Project

Mon, Jun 14

hans added a comment to D99696: [clang] NRVO: Improvements and handling of more cases..

Since it seems more discussion is needed here, I've reverted in c60dd3b2626a4d9eefd9f82f9a406b0d28d3fd72. Since they were hard to tease apart, the revert is for both D99696 and D99005.

Mon, Jun 14, 7:48 AM · Restricted Project
hans added a reverting change for rG1e50c3d785f4: [clang] NRVO: Improvements and handling of more cases.: rGc60dd3b2626a: Revert "[clang] NRVO: Improvements and handling of more cases.".
Mon, Jun 14, 7:47 AM
hans added a reverting change for rGbf2063178218: [clang] Implement P2266 Simpler implicit move: rGc60dd3b2626a: Revert "[clang] NRVO: Improvements and handling of more cases.".
Mon, Jun 14, 7:47 AM
hans committed rGc60dd3b2626a: Revert "[clang] NRVO: Improvements and handling of more cases." (authored by hans).
Revert "[clang] NRVO: Improvements and handling of more cases."
Mon, Jun 14, 7:47 AM
hans added a reverting change for D99005: [clang] Implement P2266 Simpler implicit move: rGc60dd3b2626a: Revert "[clang] NRVO: Improvements and handling of more cases.".
Mon, Jun 14, 7:47 AM · Restricted Project
hans added a reverting change for D99696: [clang] NRVO: Improvements and handling of more cases.: rGc60dd3b2626a: Revert "[clang] NRVO: Improvements and handling of more cases.".
Mon, Jun 14, 7:47 AM · Restricted Project
hans added a comment to D99696: [clang] NRVO: Improvements and handling of more cases..

@hans: FYI, that looks related to the immediately following D99005, not D99696 specifically.

Mon, Jun 14, 7:24 AM · Restricted Project
hans updated subscribers of D99696: [clang] NRVO: Improvements and handling of more cases..

We're seeing new build errors in Chromium after this (http://crbug.com/1219457). Here's a reduced example:

Mon, Jun 14, 6:42 AM · Restricted Project
hans added inline comments to D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators..
Mon, Jun 14, 1:50 AM · Restricted Project

Wed, Jun 9

hans committed rG64dbd649cf66: [clang-cl] Parse /await:strict, new in MSVC 16.10 (authored by hans).
[clang-cl] Parse /await:strict, new in MSVC 16.10
Wed, Jun 9, 5:27 AM

Tue, Jun 8

hans committed rG172fcd9600e1: [clang-cl] Parse the /external: flags (PR36003) (authored by hans).
[clang-cl] Parse the /external: flags (PR36003)
Tue, Jun 8, 9:00 AM
hans added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

Reverted in 386b66b2fc297cda121a3cc8a36887a6ecbcfc68 until this can be fixed.

Tue, Jun 8, 5:58 AM · debug-info, Restricted Project
hans added a reverting change for rG36ec97f76ac0: 3rd Reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP…: rG386b66b2fc29: Revert "3rd Reapply "[DebugInfo] Use variadic debug values to salvage BinOps….
Tue, Jun 8, 5:57 AM
hans committed rG386b66b2fc29: Revert "3rd Reapply "[DebugInfo] Use variadic debug values to salvage BinOps… (authored by hans).
Revert "3rd Reapply "[DebugInfo] Use variadic debug values to salvage BinOps…
Tue, Jun 8, 5:57 AM

Mon, Jun 7

hans added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

We're seeing build non-determinism in Chromium after this patch (after 36ec97f76ac0d8be76fb16ac521f55126766267d specifically). See https://bugs.chromium.org/p/chromium/issues/detail?id=1216316#c20 for a reproducer.

Mon, Jun 7, 6:49 AM · debug-info, Restricted Project

Wed, Jun 2

hans accepted D102402: LineEditor: Add a bare-bones readline-based implementation.

Are the presubmit errors related to this?

Wed, Jun 2, 12:48 AM · Restricted Project

Mon, May 31

hans added a comment to D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.

Sorry, had to revert it as this fails under sanitizer : https://lab.llvm.org/buildbot/#/builders/5/builds/8150

Thanks!

I missed adding "Ident_abstract" in the Parser initialize function. Should be fixed now. CC: @hans

Mon, May 31, 9:51 AM · Restricted Project
hans committed rG116179c2ee52: Re-commit [clang] Add support for the "abstract" contextual keyword of MSVC (authored by AbbasSabra).
Re-commit [clang] Add support for the "abstract" contextual keyword of MSVC
Mon, May 31, 9:51 AM
hans closed D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.
Mon, May 31, 9:51 AM · Restricted Project
hans added a comment to D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.

Pushed as http://github.com/llvm/llvm-project/commit/818338add77411f5e9713247ea66142f332ef350

Mon, May 31, 1:45 AM · Restricted Project
hans committed rG818338add774: [clang] Add support for the "abstract" contextual keyword of MSVC (authored by AbbasSabra).
[clang] Add support for the "abstract" contextual keyword of MSVC
Mon, May 31, 1:45 AM
hans closed D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.
Mon, May 31, 1:45 AM · Restricted Project

Thu, May 27

hans added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

We tried it, and the warning is still firing in a similar (but not exactly the same) way:

Thu, May 27, 1:42 PM · Restricted Project

Wed, May 26

hans accepted D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.

Looks good to me!

Wed, May 26, 7:21 AM · Restricted Project
hans committed rGa8f75d497daa: [clang-cl] Add driver support for /std:c++20 and bump /std:c++latest (PR50465) (authored by hans).
[clang-cl] Add driver support for /std:c++20 and bump /std:c++latest (PR50465)
Wed, May 26, 7:09 AM
hans closed D103155: [clang-cl] Add driver support for /std:c++20 and bump /std:c++latest (PR50465).
Wed, May 26, 7:09 AM · Restricted Project
hans requested review of D103155: [clang-cl] Add driver support for /std:c++20 and bump /std:c++latest (PR50465).
Wed, May 26, 4:09 AM · Restricted Project

Tue, May 25

hans accepted D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation.
Tue, May 25, 4:40 AM · Restricted Project
hans added a comment to D101446: [llvm] Improve export.sh with help and snapshot.

Looks okay to me, but I think Tom still needs to sign off on this since he's the main user of the script.

Tue, May 25, 1:23 AM · Restricted Project
hans added a comment to D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.

Apologies for the slow reply, it was a long weekend here.

Tue, May 25, 1:19 AM · Restricted Project

May 21 2021

hans committed rGb5b3843f8d93: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete" (authored by super_concat).
[clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"
May 21 2021, 2:14 AM
hans closed D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete".
May 21 2021, 2:14 AM · Restricted Project
hans accepted D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation.

Looks great to me!

May 21 2021, 1:45 AM · Restricted Project
hans added a comment to D102517: [clang] Add support for the "abstract" contextual keyword of MSVC.

Looking good overall, just a few nits.

May 21 2021, 1:31 AM · Restricted Project

May 20 2021

hans accepted D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete".

lgtm

May 20 2021, 4:47 AM · Restricted Project

May 19 2021

hans added a comment to D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete".

Interesting, I hadn't seen __identifier before. It seems like a pretty esoteric feature.

May 19 2021, 5:22 AM · Restricted Project

May 10 2021

hans added a comment to D101446: [llvm] Improve export.sh with help and snapshot.

I don't feel strongly about this one way or the other.

May 10 2021, 6:44 AM · Restricted Project

May 5 2021

hans added a comment to D99272: [AArch64] Adds a pre-indexed paired Load/Store optimization for LDR-STR..

We tracked some test failures in Chromium down to this patch (https://crbug.com/1205459) and it appears the fix (D101888) fixed it for us too.

May 5 2021, 9:22 AM · Restricted Project
hans added a comment to D101805: [WebAssembly] Add codegen test for wasm_simd128.h.

The test was failing in no-asserts builds, see output at https://ghostbin.com/paste/UMtJl

May 5 2021, 2:43 AM · Restricted Project
hans committed rG4f4aa7b78df5: Require asserts for clang/test/Headers/wasm.c (authored by hans).
Require asserts for clang/test/Headers/wasm.c
May 5 2021, 2:43 AM
hans added a comment to D101446: [llvm] Improve export.sh with help and snapshot.

Is having <yyyymmdd> in the filename really the most useful thing. I'd imagine having the git ref directly might be more useful, or perhaps the output of "git-describe" on it. Or maybe it should have both the git-ref and date in the filename?
And when using the date, perhaps it should use the date of the commit (commitdate, not authordate i guess) rather than the date when the script is run?
Or maybe the script should take a template argument for the filenames?

May 5 2021, 2:06 AM · Restricted Project

May 4 2021

hans accepted D101832: [clang] accept -fsanitize-ignorelist= in addition to -fsanitize-blacklist=.

lgtm

May 4 2021, 7:20 AM · Restricted Project, Restricted Project, Restricted Project

May 3 2021

hans committed rG876bf516e7d4: [clang-cl] Add parsing support for a bunch of new flags (authored by hans).
[clang-cl] Add parsing support for a bunch of new flags
May 3 2021, 5:00 AM
hans closed D101439: [clang-cl] Add parsing support for a bunch of new flags.
May 3 2021, 5:00 AM · Restricted Project
hans added inline comments to D101439: [clang-cl] Add parsing support for a bunch of new flags.
May 3 2021, 4:59 AM · Restricted Project

Apr 30 2021

hans accepted D101278: [llvm-reduce] Add flag to only run specific passes.

+1 to the comment that it would be nice to have some docs; llvm-reduce should have a page on https://llvm.org/docs/CommandGuide/ really

Apr 30 2021, 6:21 AM · Restricted Project
hans committed rGcbe62f2f2f1e: Require shell for lld/test/MachO/reproduce.s (authored by hans).
Require shell for lld/test/MachO/reproduce.s
Apr 30 2021, 5:26 AM

Apr 28 2021

hans accepted D101463: [clang] Make libBasic not depend on MC.
Apr 28 2021, 8:28 AM · Restricted Project, Restricted Project
hans accepted D101457: [clang] remove dead code after 2a1332245fc.

The real question is how did you find this? :)

Apr 28 2021, 7:26 AM · Restricted Project
hans added a comment to D101439: [clang-cl] Add parsing support for a bunch of new flags.

Do we silently ignore those all now? Are any of them semantically important enough that we should emit an "not implemented, ignoring" diag instead?

Apr 28 2021, 6:30 AM · Restricted Project
hans requested review of D101439: [clang-cl] Add parsing support for a bunch of new flags.
Apr 28 2021, 4:01 AM · Restricted Project
hans committed rG2d37f2115d17: Try to fix clang/test/Driver/cl-options.c on non-x86 hosts (authored by hans).
Try to fix clang/test/Driver/cl-options.c on non-x86 hosts
Apr 28 2021, 2:58 AM
hans committed rG789549bea441: [clang-cl] Map /QIntel-jcc-erratum to -mbranches-within-32B-boundaries (authored by hans).
[clang-cl] Map /QIntel-jcc-erratum to -mbranches-within-32B-boundaries
Apr 28 2021, 2:15 AM
hans committed rGe9fe387ac55c: Require asserts for llvm/test/Verifier/token1.ll (authored by hans).
Require asserts for llvm/test/Verifier/token1.ll
Apr 28 2021, 12:59 AM

Apr 21 2021

hans accepted D100957: [Support] Don't include VirtualFileSystem.h in CommandLine.h.

nice!

Apr 21 2021, 7:06 AM · Restricted Project, Restricted Project

Apr 19 2021

hans committed rGaa1e3914020b: Fix test/Frontend/print-header-includes.c (authored by hans).
Fix test/Frontend/print-header-includes.c
Apr 19 2021, 6:39 AM
hans committed rGbb36dc8dcf1c: Rename -show-skipped-includes to -fshow-skipped-includes and make it a driver… (authored by hans).
Rename -show-skipped-includes to -fshow-skipped-includes and make it a driver…
Apr 19 2021, 6:22 AM
hans closed D100759: Rename -show-skipped-includes to -fshow-skipped-includes and make it a driver option.
Apr 19 2021, 6:22 AM · Restricted Project
hans requested review of D100759: Rename -show-skipped-includes to -fshow-skipped-includes and make it a driver option.
Apr 19 2021, 6:13 AM · Restricted Project
hans accepted D100505: Fix android-x86 library name in asan_device_setup..
Apr 19 2021, 2:10 AM · Restricted Project

Apr 16 2021

hans accepted D100659: [ADT] Don't include <algorithm> in iterator.h.
Apr 16 2021, 9:15 AM · Restricted Project
hans accepted D100657: [Support] Don't include <algorithm> in Hashing.h.
Apr 16 2021, 9:05 AM · Restricted Project
hans accepted D100656: [Support] Don't include <algorithm> in MathExtras.h.

slightly different codegen: https://godbolt.org/z/1zebofo98
but probably just as good :)

Apr 16 2021, 8:49 AM · Restricted Project

Apr 14 2021

hans committed rGf29dcbdde10c: Add flag for showing skipped headers in -H / --show-includes output (authored by hans).
Add flag for showing skipped headers in -H / --show-includes output
Apr 14 2021, 8:07 AM
hans closed D100480: Add flag for showing skipped headers in -H / --show-includes output.
Apr 14 2021, 8:07 AM · Restricted Project
hans requested review of D100480: Add flag for showing skipped headers in -H / --show-includes output.
Apr 14 2021, 7:48 AM · Restricted Project

Apr 7 2021

hans accepted D95284: utils/release: Add script for building release documentation.
Apr 7 2021, 1:17 AM · Restricted Project
hans accepted D99780: workflows: Add GitHub action for automating some release tasks.

I'm not familiar with github actions so I'm just skimming the code, but it looks good as far as I can tell.

Apr 7 2021, 1:13 AM · Restricted Project

Apr 6 2021

hans accepted D99921: [llvm-reduce] Remove unwanted module inline asm.
Apr 6 2021, 4:02 AM · Restricted Project

Mar 29 2021

hans committed rGc6e5c4654bd5: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places (authored by hans).
Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places
Mar 29 2021, 4:17 AM
hans closed D97484: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places.
Mar 29 2021, 4:17 AM · Restricted Project

Mar 17 2021

hans added a comment to D88232: [DebugInfo] Handle multiple variable location operands in IR.

This caused non-deterministic output from the compiler, see https://bugs.chromium.org/p/chromium/issues/detail?id=1189090#c8 for a reproducer. (Usually this is due to non-deterministic iteration order for hash-based data structures such as DenseMap)

Mar 17 2021, 5:46 AM · Restricted Project, debug-info
hans committed rG01ac6d1587e8: Revert "[DebugInfo] Handle multiple variable location operands in IR" (authored by hans).
Revert "[DebugInfo] Handle multiple variable location operands in IR"
Mar 17 2021, 5:44 AM
hans added a reverting change for rGdf69c69427de: [DebugInfo] Handle multiple variable location operands in IR: rG01ac6d1587e8: Revert "[DebugInfo] Handle multiple variable location operands in IR".
Mar 17 2021, 5:44 AM
hans added a reverting change for D88232: [DebugInfo] Handle multiple variable location operands in IR: rG01ac6d1587e8: Revert "[DebugInfo] Handle multiple variable location operands in IR".
Mar 17 2021, 5:44 AM · Restricted Project, debug-info

Mar 16 2021

hans added a comment to D94355: [Passes] Add relative lookup table converter pass.

Sorry for being unresponsive for a while, I got distracted by various bugs.

Mar 16 2021, 10:56 AM · Restricted Project, Restricted Project
hans updated the diff for D97484: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places.

Sorry for the delay, I got distracted by other fires.

Mar 16 2021, 6:25 AM · Restricted Project
hans updated the summary of D97484: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places.
Mar 16 2021, 5:48 AM · Restricted Project

Mar 12 2021

hans added a comment to D98325: [InstrProfiling] Don't generate __llvm_profile_runtime_user.

This broke the check-profile tests on Mac, see e.g. http://green.lab.llvm.org/green/job/clang-stage1-RA/19301/
There are no Mac bots on the main buildbot waterfall, but I thought Apple were watching Green Dragon?

Mar 12 2021, 4:57 AM · Restricted Project
hans added a reverting change for rGc7712087cbb5: [InstrProfiling] Don't generate __llvm_profile_runtime_user: rGf50aef745c3b: Revert "[InstrProfiling] Don't generate __llvm_profile_runtime_user".
Mar 12 2021, 4:55 AM
hans committed rGf50aef745c3b: Revert "[InstrProfiling] Don't generate __llvm_profile_runtime_user" (authored by hans).
Revert "[InstrProfiling] Don't generate __llvm_profile_runtime_user"
Mar 12 2021, 4:55 AM
hans added a reverting change for rG87fd09b25f88: [InstrProfiling] Generate runtime hook for ELF platforms: rGf50aef745c3b: Revert "[InstrProfiling] Don't generate __llvm_profile_runtime_user".
Mar 12 2021, 4:55 AM
hans added a reverting change for D98061: [InstrProfiling] Generate runtime hook for ELF platforms: rGf50aef745c3b: Revert "[InstrProfiling] Don't generate __llvm_profile_runtime_user".
Mar 12 2021, 4:55 AM · Restricted Project, Restricted Project
hans added a reverting change for D98325: [InstrProfiling] Don't generate __llvm_profile_runtime_user: rGf50aef745c3b: Revert "[InstrProfiling] Don't generate __llvm_profile_runtime_user".
Mar 12 2021, 4:55 AM · Restricted Project

Mar 8 2021

hans accepted D98156: [clang/mac] Accept -why_load and make -whyload an alias for it.

nit in the change description

So -why_load is the spelling preferred by the linker and -whyload and old

second "and" -> "an"

Mar 8 2021, 1:04 AM · Restricted Project

Mar 4 2021

aralisza awarded rG840a16d3c4cb: Revert "[darwin] switch blocking mutex from osspinlock to os_unfair_lock" a Like token.
Mar 4 2021, 12:21 PM
hans added a comment to D97509: [darwin] switch blocking mutex from osspinlock to os_unfair_lock.

This broke Chromium's AddressSanitizer build on Mac: https://crbug.com/1184481

Mar 4 2021, 3:23 AM · Restricted Project
hans added a reverting change for rG71ef54337d5e: [darwin] switch blocking mutex from osspinlock to os_unfair_lock: rG840a16d3c4cb: Revert "[darwin] switch blocking mutex from osspinlock to os_unfair_lock".
Mar 4 2021, 3:23 AM
hans committed rG840a16d3c4cb: Revert "[darwin] switch blocking mutex from osspinlock to os_unfair_lock" (authored by hans).
Revert "[darwin] switch blocking mutex from osspinlock to os_unfair_lock"
Mar 4 2021, 3:23 AM
hans added a reverting change for D97509: [darwin] switch blocking mutex from osspinlock to os_unfair_lock: rG840a16d3c4cb: Revert "[darwin] switch blocking mutex from osspinlock to os_unfair_lock".
Mar 4 2021, 3:23 AM · Restricted Project
hans added a comment to D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR.

Thanks! I pushed a fix for the issue in 75805dce5ff8. @hans, would it be possible to check if D92808 + 75805dce5ff8 fixes the issue or should we just recommit D92808?

Mar 4 2021, 1:23 AM · Restricted Project, Restricted Project

Mar 3 2021

hans added a comment to D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR.

Reverted in https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44 until this can be fixed.

Mar 3 2021, 7:00 AM · Restricted Project, Restricted Project