- User Since
- Apr 18 2013, 6:48 AM (326 w, 3 d)
Fri, Jul 19
Thu, Jul 18
Looks good to me!
Wed, Jul 17
I think this is going to be my favourite new feature in clang 9 :-) Do you want to put a small note in docs/ReleaseNotes.rst?
Thanks for polishing the UX! :-)
I will try to take a look, but can you please expand the patch description a little to make it more clear exactly what you're proposing to change? Sorry for all the questions below, I'm just trying to understand exactly what the issue is.
My initial thought when I saw the filename was that this was a github version of test-release.sh. Which we'll need too, but it's not this one :-) What do you think about renaming to github-upload-release.py, or something else that has "upload" in the name to make it more explicit?
Thu, Jun 27
Wed, Jun 26
Tue, Jun 25
The reverts of this revision are tangled so it is a bit tricky to revert it.
Mon, Jun 24
It's hard to argue llvm-c.dll is part of the toolchain though :-/
Jun 21 2019
This is weird though because it suggests that the find_darwin_sdk_dir(DARWIN_iossim_SYSROOT iphonesimulator) call isn't finding the iOS simulator SDK in your toolchain. Is your toolchain a modified Apple toolchain? For the normal (included with Xcode) Apple toolchain our CMake code doesn't have a problem finding the simulator SDK.
Jun 19 2019
$ bin/clang -m32 -O0 /tmp/a.c && ./a.out
-nanBefore your change, it prints 3.140000.
I've reverted in r363790 until a solution can be found.
Jun 18 2019
The System V i386 bug fix (https://reviews.llvm.org/D59744) makes it impossible
Jun 17 2019
I tried replying on the cfe-commits email, but both Pengfei and Wei's email addresses seem to bounce, so replying here instead:
Jun 14 2019
Jun 13 2019
Jun 12 2019
Jun 11 2019
May 29 2019
May 28 2019
Looks great, thanks!
May 27 2019
May 23 2019
Want to add a line to docs/ReleaseNotes.rst too? :-)
Thanks! This looks good to me.
May 22 2019
May 17 2019
Interesting! I didn't know about most of this.
May 16 2019
May 14 2019
May 13 2019
May 9 2019
May 8 2019
May 6 2019
Apr 30 2019
Thanks! I've rebuilt and published the extension: https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.llvm-toolchain (version 1.0.359557).
Apr 29 2019
Apr 26 2019
I'm also not really familiar with code in compiler-rt.
Seems okay to me.
I'm trying to follow along here, but there's so much churn I'm not sure what I'm supposed to be reviewing?
I'll commit this now since it seems like an obvious fix. Happy to take post-commit review comments.