Page MenuHomePhabricator

hans (Hans Wennborg)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 6:48 AM (326 w, 3 d)

Recent Activity

Fri, Jul 19

hans committed rL366556: Merging r366511:.
Merging r366511:
Fri, Jul 19, 2:57 AM
hans committed rL366554: Merging r366480:.
Merging r366480:
Fri, Jul 19, 2:45 AM
hans committed rL366553: Merging r366433:.
Merging r366433:
Fri, Jul 19, 2:39 AM
hans committed rL366552: Merging r366429:.
Merging r366429:
Fri, Jul 19, 2:36 AM
hans committed rL366550: Drop svn version suffix..
Drop svn version suffix.
Fri, Jul 19, 2:23 AM
hans committed rL366549: Drop svn version suffix..
Drop svn version suffix.
Fri, Jul 19, 2:22 AM
hans committed rL366548: Drop svn version suffix..
Drop svn version suffix.
Fri, Jul 19, 2:22 AM
hans committed rL366547: Drop svn version suffix..
Drop svn version suffix.
Fri, Jul 19, 2:22 AM

Thu, Jul 18

hans committed rL366427: Bump the trunk version to 10.0.0svn.
Bump the trunk version to 10.0.0svn
Thu, Jul 18, 4:51 AM
hans committed rL366408: clang-tidy release notes: Split and order changes by type.
clang-tidy release notes: Split and order changes by type
Thu, Jul 18, 12:12 AM
hans accepted D64841: Add github-release.py script.

Looks good to me!

Thu, Jul 18, 12:01 AM · Restricted Project

Wed, Jul 17

hans added a comment to D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics.

I think this is going to be my favourite new feature in clang 9 :-) Do you want to put a small note in docs/ReleaseNotes.rst?

Wed, Jul 17, 3:08 AM · Restricted Project
hans added a comment to D64504: Various minor tweaks to CLCompatOptions.td.

Thanks for polishing the UX! :-)

Wed, Jul 17, 3:05 AM
hans added a comment to D63648: [Preprocessor] Honor absolute paths in diagnostics.

I will try to take a look, but can you please expand the patch description a little to make it more clear exactly what you're proposing to change? Sorry for all the questions below, I'm just trying to understand exactly what the issue is.

Wed, Jul 17, 2:59 AM · Restricted Project
hans added a comment to D64841: Add github-release.py script.

My initial thought when I saw the filename was that this was a github version of test-release.sh. Which we'll need too, but it's not this one :-) What do you think about renaming to github-upload-release.py, or something else that has "upload" in the name to make it more explicit?

Wed, Jul 17, 2:40 AM · Restricted Project

Thu, Jun 27

hans committed rL364543: Revert r363658 "[SVE][IR] Scalable Vector IR Type with pr42210 fix".
Revert r363658 "[SVE][IR] Scalable Vector IR Type with pr42210 fix"
Thu, Jun 27, 6:55 AM
hans committed rL364505: Fix -Wunused-variable warnings after r364464.
Fix -Wunused-variable warnings after r364464
Thu, Jun 27, 12:36 AM
hans committed rL364504: Fix GCC 4 build after r364464.
Fix GCC 4 build after r364464
Thu, Jun 27, 12:36 AM
hans accepted D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].

Thank you Douglas!

Thu, Jun 27, 12:17 AM · Restricted Project, Restricted Project

Wed, Jun 26

hans committed rL364414: Fix the build after r364401.
Fix the build after r364401
Wed, Jun 26, 4:57 AM
hans committed rL364400: Revert r364332 "[scudo][standalone] Introduce the C & C++ wrappers".
Revert r364332 "[scudo][standalone] Introduce the C & C++ wrappers"
Wed, Jun 26, 2:47 AM

Tue, Jun 25

hans added a comment to D63772: [ELF] Don't error on relocations to STT_SECTION symbols if the sections were discarded.

The reverts of this revision are tangled so it is a bit tricky to revert it.

Tue, Jun 25, 9:26 AM · Restricted Project
hans committed rL364321: Revert r362743 "Revert "Revert "Reland D61583 [ELF] Error on relocations to….
Revert r362743 "Revert "Revert "Reland D61583 [ELF] Error on relocations to…
Tue, Jun 25, 8:11 AM
hans committed rL364277: Add llvm-symbolizer to LLVM_TOOLCHAIN_TOOLS (PR40152).
Add llvm-symbolizer to LLVM_TOOLCHAIN_TOOLS (PR40152)
Tue, Jun 25, 12:17 AM
hans committed rL364275: [LLVM-C] Add LLVM-C.dll to Windows installer package.
[LLVM-C] Add LLVM-C.dll to Windows installer package
Tue, Jun 25, 12:07 AM
hans closed D63717: [LLVM-C] Add LLVM-C.dll to Windows installer package.
Tue, Jun 25, 12:07 AM · Restricted Project
hans added a comment to D63717: [LLVM-C] Add LLVM-C.dll to Windows installer package.

Thanks for the review!

I'm pretty sure libclang.[lib|dll] is only installed and not used by any of the shipped binaries so not really part of the toolchain either. Not sure about LTO.[lib|dll] tho. I would be happy if LLVM-C and libclang was offered as a separate download.

Tue, Jun 25, 12:07 AM · Restricted Project

Mon, Jun 24

hans accepted D63717: [LLVM-C] Add LLVM-C.dll to Windows installer package.

It's hard to argue llvm-c.dll is part of the toolchain though :-/

Mon, Jun 24, 7:52 AM · Restricted Project
hans added a comment to D63674: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #3..

@hans @thakis Could one of you check that this patch doesn't break your build?

Mon, Jun 24, 1:54 AM · Restricted Project, Restricted Project
hans committed rL364166: 9.0.0 release schedule.
9.0.0 release schedule
Mon, Jun 24, 1:08 AM

Jun 21 2019

hans added inline comments to D62315: [compiler-rt][crt] Pass -fno-lto in check_cxx_section_exists.
Jun 21 2019, 5:23 AM · Restricted Project
hans added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

This is weird though because it suggests that the find_darwin_sdk_dir(DARWIN_iossim_SYSROOT iphonesimulator) call isn't finding the iOS simulator SDK in your toolchain. Is your toolchain a modified Apple toolchain? For the normal (included with Xcode) Apple toolchain our CMake code doesn't have a problem finding the simulator SDK.

Jun 21 2019, 5:06 AM · Restricted Project, Restricted Project
hans committed rL364034: Win snapshot: r361807.
Win snapshot: r361807
Jun 21 2019, 4:41 AM

Jun 19 2019

hans added a comment to D59744: Fix i386 ABI "__m64" type bug.

$ bin/clang -m32 -O0 /tmp/a.c && ./a.out
-nan

Before your change, it prints 3.140000.
Jun 19 2019, 7:51 AM · Restricted Project, Restricted Project
hans committed rL363790: Revert r363116 "[X86] [ABI] Fix i386 ABI "__m64" type bug".
Revert r363116 "[X86] [ABI] Fix i386 ABI "__m64" type bug"
Jun 19 2019, 4:31 AM
hans added a comment to D59744: Fix i386 ABI "__m64" type bug.

I've reverted in r363790 until a solution can be found.

Jun 19 2019, 4:31 AM · Restricted Project, Restricted Project
hans added a comment to D59744: Fix i386 ABI "__m64" type bug.

Can anyone provide me some small reproducers code for the issue tripped over by Chromium / Skia?

Sorry, I don't have a small repro yet. I'm still working on finding out exactly what's happening in Chromium, but it's a large test. It's easy to find where the x87 state gets clobbered after your change, but I haven't found what code was depending on that state yet.

Jun 19 2019, 4:18 AM · Restricted Project, Restricted Project
hans committed rL363780: Make TargetParserTest.ARMExtensionFeatures not run out of memory on 32-bit….
Make TargetParserTest.ARMExtensionFeatures not run out of memory on 32-bit…
Jun 19 2019, 2:45 AM
hans committed rL363779: Revert r363633 "[CMake] Fix the value of `config.target_cflags` for non-macOS….
Revert r363633 "[CMake] Fix the value of `config.target_cflags` for non-macOS…
Jun 19 2019, 2:08 AM
hans added a comment to D61242: [CMake] Fix the value of `config.target_cflags` for non-macOS Apple platforms. Attempt #2..

@juliehockett Sorry I completely dropped the ball here and forgot to land this. I've rebased and committed the change. @thakis I noticed I had a merge conflict with your change. Hopefully this hasn't broken anything for you.

Jun 19 2019, 2:08 AM · Restricted Project, Restricted Project
hans added a comment to D59744: Fix i386 ABI "__m64" type bug.

Can anyone provide me some small reproducers code for the issue tripped over by Chromium / Skia?

Jun 19 2019, 1:07 AM · Restricted Project, Restricted Project
hans committed rL363769: vs integration: bump version nbr.
vs integration: bump version nbr
Jun 19 2019, 12:36 AM
hans committed rL363768: Revert r359557 "vs integration: vs2019 support".
Revert r359557 "vs integration: vs2019 support"
Jun 19 2019, 12:35 AM

Jun 18 2019

hans added a comment to D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior.

The System V i386 bug fix (https://reviews.llvm.org/D59744) makes it impossible

Jun 18 2019, 2:00 AM · Restricted Project
hans added a comment to D59744: Fix i386 ABI "__m64" type bug.

@hans

Please make sure all Chromium for 32-bit Linux libraries are following System V ABI (i.e., m64 is passed on mmx register). I suspect that there are some hand written assembly code in your libraries which is not following the ABI.

Jun 18 2019, 1:49 AM · Restricted Project, Restricted Project

Jun 17 2019

hans added a comment to D59744: Fix i386 ABI "__m64" type bug.

I tried replying on the cfe-commits email, but both Pengfei and Wei's email addresses seem to bounce, so replying here instead:

Jun 17 2019, 6:51 AM · Restricted Project, Restricted Project
hans accepted D63387: clang: Promote -fdebug-compilation-dir from cc1 flag to driver-level flag.

lgtm

Jun 17 2019, 4:24 AM · debug-info, Restricted Project
hans committed rL363529: Re-commit r357452 (take 3): "SimplifyCFG SinkCommonCodeFromPredecessors: Also….
Re-commit r357452 (take 3): "SimplifyCFG SinkCommonCodeFromPredecessors: Also…
Jun 17 2019, 12:44 AM

Jun 14 2019

hans committed rL363358: Revert r363326 "[libFuzzer] simplify the DFT trace collection using the new….
Revert r363326 "[libFuzzer] simplify the DFT trace collection using the new…
Jun 14 2019, 12:29 AM

Jun 13 2019

hans committed rL363230: clang-format extension: Widen the supported versions range.
clang-format extension: Widen the supported versions range
Jun 13 2019, 12:05 AM

Jun 12 2019

hans committed rL363134: Revert r362676 "[Profile]: Add runtime interface to specify file handle for….
Revert r362676 "[Profile]: Add runtime interface to specify file handle for…
Jun 12 2019, 1:41 AM

Jun 11 2019

hans accepted D63116: Let writeWindowsResourceCOFF() take a TimeStamp parameter.

lgtm

Jun 11 2019, 1:49 AM · Restricted Project

May 29 2019

hans accepted D62490: clang-cl: Fix mangling of catchable types with names longer than 4kiB.

lgtm

May 29 2019, 5:01 AM · Restricted Project

May 28 2019

hans committed rL361836: Win snapshot: r361807.
Win snapshot: r361807
May 28 2019, 7:58 AM
hans accepted D62523: Add release note entries for recent typo correction changes.

Looks great, thanks!

May 28 2019, 7:02 AM · Restricted Project
hans committed rL361812: Cleanups for r361807 that I somehow failed to commit.
Cleanups for r361807 that I somehow failed to commit
May 28 2019, 5:28 AM
hans committed rC361811: Re-commit r357452 (take 2): "SimplifyCFG SinkCommonCodeFromPredecessors: Also….
Re-commit r357452 (take 2): "SimplifyCFG SinkCommonCodeFromPredecessors: Also…
May 28 2019, 5:18 AM
hans committed rL361811: Re-commit r357452 (take 2): "SimplifyCFG SinkCommonCodeFromPredecessors: Also….
Re-commit r357452 (take 2): "SimplifyCFG SinkCommonCodeFromPredecessors: Also…
May 28 2019, 5:18 AM
hans committed rL361807: Fix some llvm-readelf tests after r361633.
Fix some llvm-readelf tests after r361633
May 28 2019, 4:24 AM

May 27 2019

hans added a comment to D62315: [compiler-rt][crt] Pass -fno-lto in check_cxx_section_exists.

This lgtm, but it suggests there's no upstream bot building llvm with lto, and running tests with it. I'm not sure I want to be in the business of owning test coverage for that config -- should we have an LTO bot on the llvm buildbot master?

May 27 2019, 9:02 AM · Restricted Project
hans committed rL361751: Cmake: allow using LLVM_EXTERNAL_PROJECTS with LLVM_ENABLE_PROJECTS.
Cmake: allow using LLVM_EXTERNAL_PROJECTS with LLVM_ENABLE_PROJECTS
May 27 2019, 2:00 AM
hans closed D62289: CMake: allow using LLVM_EXTERNAL_PROJECTS with LLVM_ENABLE_PROJECTS.
May 27 2019, 2:00 AM · Restricted Project

May 23 2019

hans created D62315: [compiler-rt][crt] Pass -fno-lto in check_cxx_section_exists.
May 23 2019, 7:19 AM · Restricted Project
hans created D62289: CMake: allow using LLVM_EXTERNAL_PROJECTS with LLVM_ENABLE_PROJECTS.
May 23 2019, 12:40 AM · Restricted Project
hans accepted D62276: lld-link, clang: Treat non-existent input files as possible spellos for option flags.

Want to add a line to docs/ReleaseNotes.rst too? :-)

May 23 2019, 12:29 AM · Restricted Project
hans accepted D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..

Thanks! This looks good to me.

May 23 2019, 12:29 AM · Restricted Project
hans accepted D62270: [Driver] Move the "-o OUT -x TYPE SRC.c" flags to the end of -cc1.

Nice, lgtm.

May 23 2019, 12:12 AM · Restricted Project

May 22 2019

hans added inline comments to D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..
May 22 2019, 4:20 AM · Restricted Project
hans added inline comments to D60982: [SimplifyCFG] Use lookup tables when they are more space efficient or a huge speed win..
May 22 2019, 1:42 AM · Restricted Project

May 17 2019

hans added a comment to D62040: [docs] Add new document on building distributions.

The Windows packages currently includes at least the asan runtime (and a bunch of other stuff like openmp that people ask for but I'm never quite sure if it works).

But I assume you're not building them using the just-built clang (LLVM_ENABLE_RUNTIMES). I'm not sure how any of our current mechanisms for installing those would work with cpack.

May 17 2019, 10:45 AM · Restricted Project
hans added a comment to D62040: [docs] Add new document on building distributions.

@hans I have some ideas on how to make package work. There is a simple solution to make it work as long as you're not using any runtime components, but I have an idea on how to make it work with runtime components.

May 17 2019, 10:37 AM · Restricted Project
hans added a comment to D62040: [docs] Add new document on building distributions.

Interesting! I didn't know about most of this.

May 17 2019, 12:23 AM · Restricted Project

May 16 2019

hans committed rL360878: Revert r360876 "[Object] Change object::SectionRef::getContents() to return….
Revert r360876 "[Object] Change object::SectionRef::getContents() to return…
May 16 2019, 5:06 AM

May 14 2019

hans committed rC360657: Revert r360637 "PR41817: Fix regression in r359260 that caused the MS….
Revert r360637 "PR41817: Fix regression in r359260 that caused the MS…
May 14 2019, 3:12 AM
hans committed rL360657: Revert r360637 "PR41817: Fix regression in r359260 that caused the MS….
Revert r360637 "PR41817: Fix regression in r359260 that caused the MS…
May 14 2019, 3:12 AM

May 13 2019

hans committed rC360580: Revert r360559 "[c++20] P1064R0: Allow virtual function calls in constant….
Revert r360559 "[c++20] P1064R0: Allow virtual function calls in constant…
May 13 2019, 6:16 AM
hans committed rL360580: Revert r360559 "[c++20] P1064R0: Allow virtual function calls in constant….
Revert r360559 "[c++20] P1064R0: Allow virtual function calls in constant…
May 13 2019, 6:16 AM

May 9 2019

hans committed rL360320: X86WinAllocaExpander: Drop code looking through register copies (PR41786).
X86WinAllocaExpander: Drop code looking through register copies (PR41786)
May 9 2019, 2:20 AM
hans closed D61671: X86WinAllocaExpander: Drop code looking through register copies (PR41786).
May 9 2019, 2:20 AM · Restricted Project

May 8 2019

hans accepted D61684: [compiler-rt] Make builtins test pass when using i386 gcc as host compiler.
May 8 2019, 8:45 AM · Restricted Project
hans added inline comments to D61671: X86WinAllocaExpander: Drop code looking through register copies (PR41786).
May 8 2019, 4:38 AM · Restricted Project
hans updated the diff for D61671: X86WinAllocaExpander: Drop code looking through register copies (PR41786).
May 8 2019, 4:38 AM · Restricted Project
hans created D61671: X86WinAllocaExpander: Drop code looking through register copies (PR41786).
May 8 2019, 3:06 AM · Restricted Project

May 6 2019

hans committed rC360024: Revert r359949 "[clang] adding explicit(bool) from c++2a".
Revert r359949 "[clang] adding explicit(bool) from c++2a"
May 6 2019, 2:50 AM
hans committed rLLDB360024: Revert r359949 "[clang] adding explicit(bool) from c++2a".
Revert r359949 "[clang] adding explicit(bool) from c++2a"
May 6 2019, 2:49 AM
hans committed rL360024: Revert r359949 "[clang] adding explicit(bool) from c++2a".
Revert r359949 "[clang] adding explicit(bool) from c++2a"
May 6 2019, 2:49 AM

Apr 30 2019

hans accepted D61317: Add llvm-profdata to LLVM_TOOLCHAIN_TOOLS.

lgtm

Apr 30 2019, 8:26 AM · Restricted Project
hans added a comment to D61193: vs integration: Use llvm-lib for librarian.

Thanks! I've rebuilt and published the extension: https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.llvm-toolchain (version 1.0.359557).

Apr 30 2019, 5:49 AM · Restricted Project
hans committed rL359557: vs integration: vs2019 support.
vs integration: vs2019 support
Apr 30 2019, 5:39 AM

Apr 29 2019

hans committed rL359429: gn: Fix check-clang build after r359179.
gn: Fix check-clang build after r359179
Apr 29 2019, 2:58 AM

Apr 26 2019

hans added a comment to D61132: [builtins] run-time support for sparse maps in llvm.

I'm also not really familiar with code in compiler-rt.

Apr 26 2019, 2:20 AM · Restricted Project, Restricted Project
hans accepted D61177: [MinGW] Always emit local typeinfo.

lgtm

Apr 26 2019, 2:13 AM · Restricted Project
hans accepted D61176: [MinGW] Do dllexport inline methods in template instantiation.

lgtm

Apr 26 2019, 2:08 AM · Restricted Project
hans accepted D61175: [MinGW] Don't let template instantiation declarations cover nested classes.

Seems okay to me.

Apr 26 2019, 2:01 AM · Restricted Project
hans added a comment to D60982: [SimplifyCFG] Use lookup tables when they are more space efficient or a huge speed win..

I'm trying to follow along here, but there's so much churn I'm not sure what I'm supposed to be reviewing?

Apr 26 2019, 1:58 AM · Restricted Project
hans committed rL359287: Fix alignment in AArch64InstructionSelector::emitConstantPoolEntry().
Fix alignment in AArch64InstructionSelector::emitConstantPoolEntry()
Apr 26 2019, 1:29 AM
hans closed D61124: Fix alignment in AArch64InstructionSelector::emitConstantPoolEntry().
Apr 26 2019, 1:29 AM · Restricted Project
hans added a comment to D61124: Fix alignment in AArch64InstructionSelector::emitConstantPoolEntry().

I'll commit this now since it seems like an obvious fix. Happy to take post-commit review comments.

Apr 26 2019, 1:24 AM · Restricted Project

Apr 25 2019

hans created D61124: Fix alignment in AArch64InstructionSelector::emitConstantPoolEntry().
Apr 25 2019, 3:09 AM · Restricted Project
hans added a comment to D60295: [CodeGen] Change the jump table size unit from entry to target.

I still think looking at the number of cases isn't that much better than looking at the size of the range though. As you said, the point is to limit the load on the branch target predictor, and IIUC that's limited on the number of *different branch targets*, which is really orthogonal to the number of cases. I realize that we don't have that information as readily available, but do you agree that limiting the jump table to a certain number of different targets would be a better approach?

For each case there is a target in the table, that may potentially be reached or not at run time, but would prevent stressing the predictor. So, cases and targets are not orthogonal, but the same.

Apr 25 2019, 2:02 AM · Restricted Project