Page MenuHomePhabricator

hans (Hans Wennborg)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 6:48 AM (309 w, 4 d)

Recent Activity

Today

hans committed rL356879: 8.0.0: Add ubuntu-14.04 binary.
8.0.0: Add ubuntu-14.04 binary
Mon, Mar 25, 3:13 AM
hans committed rL356877: 8.0.0: powerpc64le binary.
8.0.0: powerpc64le binary
Mon, Mar 25, 2:45 AM
hans committed rL356875: Fix the build with GCC 4.8 after r356783.
Fix the build with GCC 4.8 after r356783
Mon, Mar 25, 2:27 AM

Thu, Mar 21

hans committed rL356660: 8.0.0: Add AArch64 and ARMv7 binaries.
8.0.0: Add AArch64 and ARMv7 binaries
Thu, Mar 21, 5:35 AM
hans committed rL356650: 8.0.0: Add Ubuntu and SLES binaries.
8.0.0: Add Ubuntu and SLES binaries
Thu, Mar 21, 1:45 AM

Wed, Mar 20

hans committed rL356544: Update links etc. for the 8.0.0 release.
Update links etc. for the 8.0.0 release
Wed, Mar 20, 3:51 AM
hans committed rL356539: Check in the 8.0.0 release.
Check in the 8.0.0 release
Wed, Mar 20, 2:14 AM

Mon, Mar 18

hans added inline comments to D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows..
Mon, Mar 18, 2:49 AM · Restricted Project

Fri, Mar 15

hans committed rL356240: Re-generate DiagnosticsReference.rst (PR41080).
Re-generate DiagnosticsReference.rst (PR41080)
Fri, Mar 15, 1:45 AM

Thu, Mar 14

hans committed rL356139: gn build: Merge r356080.
gn build: Merge r356080
Thu, Mar 14, 5:23 AM
hans committed rL356128: gn build: Merge r356082.
gn build: Merge r356082
Thu, Mar 14, 3:09 AM

Wed, Mar 13

hans committed rL356034: ReleaseNotes: Changes to the JIT APIs; by Lang Hames.
ReleaseNotes: Changes to the JIT APIs; by Lang Hames
Wed, Mar 13, 1:55 AM
hans committed rL356033: ReleaseNotes: fix sorting, spotted by Eugene Zelenko.
ReleaseNotes: fix sorting, spotted by Eugene Zelenko
Wed, Mar 13, 1:48 AM

Tue, Mar 12

hans committed rL355916: ReleaseNotes: SystemZ, by Ulrich Weigand..
ReleaseNotes: SystemZ, by Ulrich Weigand.
Tue, Mar 12, 5:51 AM
hans committed rL355898: Merging r355743:.
Merging r355743:
Tue, Mar 12, 1:28 AM
hans added a comment to D59201: [RegAllocHints] Avoid compile time regression.
In D59201#1424675, @dim wrote:

@hans it's really late but if you're going to spin 8.0.0 rc5, it would be nice if this one gets merged too, after it's been committed. Or if not, I'll probably merge into the FreeBSD version of clang anyway, since we hit this issue first. :)

Tue, Mar 12, 1:16 AM

Fri, Mar 8

hans added a comment to D59038: [8.0 Regression] Fix handling of `__builtin_constant_p` inside template arguments, enumerators, case statements, and the enable_if attribute..

LGTM, and I think this is safe enough to take for Clang 8.

Fri, Mar 8, 10:11 AM · Restricted Project
hans committed rL355682: clang-cl : Parse all /d2 options.
clang-cl : Parse all /d2 options
Fri, Mar 8, 2:00 AM
hans committed rC355682: clang-cl : Parse all /d2 options.
clang-cl : Parse all /d2 options
Fri, Mar 8, 2:00 AM
hans committed rL355677: Merging r355489:.
Merging r355489:
Fri, Mar 8, 1:27 AM
hans committed rL355675: Merging r352119:.
Merging r352119:
Fri, Mar 8, 1:25 AM
hans committed rL355674: Merging r355491:.
Merging r355491:
Fri, Mar 8, 1:15 AM
hans committed rL355673: Merging r354937:.
Merging r354937:
Fri, Mar 8, 1:08 AM
hans committed rC355670: Add another test for r354937 that came up in PR40890.
Add another test for r354937 that came up in PR40890
Fri, Mar 8, 1:00 AM
hans committed rL355670: Add another test for r354937 that came up in PR40890.
Add another test for r354937 that came up in PR40890
Fri, Mar 8, 1:00 AM

Thu, Mar 7

hans added a comment to D59038: [8.0 Regression] Fix handling of `__builtin_constant_p` inside template arguments, enumerators, case statements, and the enable_if attribute..

I think I'll have to defer to Richard for reviewing this, since I'm not familiar with the code. Since it's a regression we probably want to merge it to clang 8. Can you give any guidance to how bad a regression this is, e.g. does it break some important piece of code?

Thu, Mar 7, 3:09 AM · Restricted Project
hans committed rL355584: ReleaseNotes: Open Dylan; by Peter Housel.
ReleaseNotes: Open Dylan; by Peter Housel
Thu, Mar 7, 12:47 AM

Wed, Mar 6

hans committed rL355492: Win snapshot: r355397.
Win snapshot: r355397
Wed, Mar 6, 2:49 AM
hans committed rL355491: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890).
Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)
Wed, Mar 6, 2:26 AM
hans committed rC355491: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890).
Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890)
Wed, Mar 6, 2:26 AM
hans closed D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890).
Wed, Mar 6, 2:25 AM · Restricted Project
hans committed rL355489: clang-cl: Parse /Qspectre and a few other missing options (PR40964).
clang-cl: Parse /Qspectre and a few other missing options (PR40964)
Wed, Mar 6, 1:38 AM
hans committed rC355489: clang-cl: Parse /Qspectre and a few other missing options (PR40964).
clang-cl: Parse /Qspectre and a few other missing options (PR40964)
Wed, Mar 6, 1:38 AM

Tue, Mar 5

hans updated the diff for D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890).

Extract code to a new method in APValue.

Tue, Mar 5, 7:32 AM · Restricted Project
hans added inline comments to D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890).
Tue, Mar 5, 7:31 AM · Restricted Project
hans accepted D58958: [sanitizers] Don't use Windows Trace Logging with Clang in MSVC mode either.

Thanks!

Tue, Mar 5, 4:25 AM · Restricted Project, Restricted Project
hans committed rL355383: Merging r355227 and r355228:.
Merging r355227 and r355228:
Tue, Mar 5, 1:58 AM

Mon, Mar 4

hans committed rL355313: Merging r355136:.
Merging r355136:
Mon, Mar 4, 4:55 AM
hans committed rL355311: Merging r352465:.
Merging r352465:
Mon, Mar 4, 4:45 AM
hans committed rL355310: Merging r355116 and r355117:.
Merging r355116 and r355117:
Mon, Mar 4, 4:41 AM
hans added a comment to D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890).

Can you include a patch for something like (int *)0xdeadbeeeeeef on amd64? That's a valid value for "n", but clearly too large for int. Thanks for looking at this, it is one of the two large remaining show stoppers for the asm constraint check.

Mon, Mar 4, 3:14 AM · Restricted Project
hans updated the diff for D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890).

Address comments.

Mon, Mar 4, 3:14 AM · Restricted Project
hans added a comment to D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890).

Can you include a patch for something like (int *)0xdeadbeeeeeef on amd64? That's a valid value for "n", but clearly too large for int. Thanks for looking at this, it is one of the two large remaining show stoppers for the asm constraint check.

Mon, Mar 4, 3:13 AM · Restricted Project

Fri, Mar 1

hans created D58821: Inline asm constraints: allow ICE-like pointers for the "n" constraint (PR40890).
Fri, Mar 1, 5:27 AM · Restricted Project

Wed, Feb 27

hans committed rL355004: Added release notes for clangd 8.
Added release notes for clangd 8
Wed, Feb 27, 8:51 AM
hans closed D58721: Added release notes for clangd 8.
Wed, Feb 27, 8:51 AM · Restricted Project, Restricted Project
hans committed rL354997: Merging r354777, r354778, r354779, r354786, r354865, and r354992.
Merging r354777, r354778, r354779, r354786, r354865, and r354992
Wed, Feb 27, 8:18 AM
hans committed rL354986: ReleaseNotes: tidy up.
ReleaseNotes: tidy up
Wed, Feb 27, 7:03 AM
hans committed rL354985: ReleaseNotes: remove another empty section.
ReleaseNotes: remove another empty section
Wed, Feb 27, 7:01 AM
hans committed rL354984: Merging r354957:.
Merging r354957:
Wed, Feb 27, 6:58 AM
hans committed rL354983: Merging r354765:.
Merging r354765:
Wed, Feb 27, 6:57 AM
hans committed rL354982: Merging r354505:.
Merging r354505:
Wed, Feb 27, 6:56 AM
hans committed rL354981: Merging r354505:.
Merging r354505:
Wed, Feb 27, 6:56 AM
hans committed rL354980: Merging r353422:.
Merging r353422:
Wed, Feb 27, 6:52 AM
hans committed rL354979: ReleaseNotes: tidy up (clangd notes are still expected).
ReleaseNotes: tidy up (clangd notes are still expected)
Wed, Feb 27, 6:52 AM
hans committed rL354977: ReleaseNotes: tidy up.
ReleaseNotes: tidy up
Wed, Feb 27, 6:32 AM
hans committed rL354973: ReleaseNotes: add Known Issues, clean up, etc..
ReleaseNotes: add Known Issues, clean up, etc.
Wed, Feb 27, 5:55 AM
hans committed rL354971: Re-generate AttributeReference.rst again.
Re-generate AttributeReference.rst again
Wed, Feb 27, 5:12 AM
hans committed rL354970: Merging r354968:.
Merging r354968:
Wed, Feb 27, 5:12 AM
hans committed rL354968: AttrDocs.td: fix broken bullet-point indentation.
AttrDocs.td: fix broken bullet-point indentation
Wed, Feb 27, 5:10 AM
hans committed rC354968: AttrDocs.td: fix broken bullet-point indentation.
AttrDocs.td: fix broken bullet-point indentation
Wed, Feb 27, 5:10 AM
hans committed rL354967: Re-generate attribute docs.
Re-generate attribute docs
Wed, Feb 27, 5:01 AM
hans committed rL354956: Merging r354207:.
Merging r354207:
Wed, Feb 27, 2:15 AM

Tue, Feb 26

hans committed rL354892: Add note on libFuzzer for Windows to release notes.
Add note on libFuzzer for Windows to release notes
Tue, Feb 26, 8:19 AM
hans closed D58676: Add note on libFuzzer for Windows to release notes.
Tue, Feb 26, 8:19 AM · Restricted Project
hans accepted D58676: Add note on libFuzzer for Windows to release notes.

I don't think committing to the branch works from the monorepo, so either check out the branch with svn (svn co https://llvm.org/svn/llvm-project/llvm/branches/release_80/docs/), or let me know and I'll commit for you.

Tue, Feb 26, 8:05 AM · Restricted Project
hans committed rL354860: Merging r354733:.
Merging r354733:
Tue, Feb 26, 2:33 AM
hans committed rL354859: Merging r354723:.
Merging r354723:
Tue, Feb 26, 2:28 AM
hans committed rL354858: Merging r354721:.
Merging r354721:
Tue, Feb 26, 2:28 AM
hans committed rL354857: Merging r354756:.
Merging r354756:
Tue, Feb 26, 2:21 AM
hans committed rL354856: Merging r354764:.
Merging r354764:
Tue, Feb 26, 2:04 AM
hans added a reverting change for D50129: [XRay][tools] Use Support/JSON.h in llvm-xray convert: rL354856: Merging r354764:.
Tue, Feb 26, 2:04 AM
hans added a comment to D58584: [XRay][tools] Revert "Use Support/JSON.h in llvm-xray convert".

Was I added as a review because you want this merged to release_80?

Yep, i did file https://bugs.llvm.org/show_bug.cgi?id=40839

Tue, Feb 26, 2:04 AM · Restricted Project
hans committed rL354855: ReleaseNotes: ARM64 SEH, pointed out by David Major.
ReleaseNotes: ARM64 SEH, pointed out by David Major
Tue, Feb 26, 1:59 AM
hans added a comment to D58504: [OpenCL][8.0.0 Release] Notes for OpenCL.

Many thanks!

Tue, Feb 26, 1:32 AM · Restricted Project

Mon, Feb 25

hans committed rL354794: ReleaseNotes: drop mention of -ftrivial-auto-var-init=zero.
ReleaseNotes: drop mention of -ftrivial-auto-var-init=zero
Mon, Feb 25, 8:06 AM
hans added a comment to D58584: [XRay][tools] Revert "Use Support/JSON.h in llvm-xray convert".

Was I added as a review because you want this merged to release_80?

Mon, Feb 25, 8:01 AM · Restricted Project
hans added inline comments to D58504: [OpenCL][8.0.0 Release] Notes for OpenCL.
Mon, Feb 25, 7:52 AM · Restricted Project

Feb 22 2019

hans committed rL354660: ReleaseNotes: -ftrivial-auto-var-init.
ReleaseNotes: -ftrivial-auto-var-init
Feb 22 2019, 12:44 AM
hans committed rL354659: Release notes: a few lldb changes, by Raphael Isemann!.
Release notes: a few lldb changes, by Raphael Isemann!
Feb 22 2019, 12:13 AM

Feb 21 2019

hans committed rL354583: ReleaseNotes: speculative load hardening; text by Kristof.
ReleaseNotes: speculative load hardening; text by Kristof
Feb 21 2019, 6:19 AM
hans committed rL354582: ReleaseNotes: speculative load hardening; text by Kristof.
ReleaseNotes: speculative load hardening; text by Kristof
Feb 21 2019, 6:17 AM
hans committed rL354555: Merging r354497:.
Merging r354497:
Feb 21 2019, 12:57 AM
hans committed rL354554: ReleaseNotes: profile-driven cache prefetching. Text by Mircea!.
ReleaseNotes: profile-driven cache prefetching. Text by Mircea!
Feb 21 2019, 12:52 AM
hans added inline comments to D58454: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures.
Feb 21 2019, 12:39 AM · Restricted Project, Restricted Project

Feb 20 2019

hans committed rL354472: Speculative buildfix for Mac.
Speculative buildfix for Mac
Feb 20 2019, 6:56 AM
hans committed rL354469: Fix the build with gcc/libstdc++ 4.8.2 after r354441.
Fix the build with gcc/libstdc++ 4.8.2 after r354441
Feb 20 2019, 6:49 AM
hans committed rL354460: Merging r354402:.
Merging r354402:
Feb 20 2019, 5:00 AM
hans committed rL354459: Merging r354351:.
Merging r354351:
Feb 20 2019, 4:50 AM
hans committed rL354458: ReleaseNotes: all PowerPC changes.
ReleaseNotes: all PowerPC changes
Feb 20 2019, 4:43 AM
hans committed rL354457: ReleaseNotes: AArch64 tiny code model.
ReleaseNotes: AArch64 tiny code model
Feb 20 2019, 4:38 AM
hans committed rL354450: ReleaseNotes: mention the new rotation builtins, text by Sanjay.
ReleaseNotes: mention the new rotation builtins, text by Sanjay
Feb 20 2019, 3:39 AM
hans committed rL354448: ReleaseNotes: initial ppc support in llvm-exegesis.
ReleaseNotes: initial ppc support in llvm-exegesis
Feb 20 2019, 3:31 AM
hans accepted D57523: Fix uninitialized value in ABIArgInfo.

I've been staring at this, trying to figure out if the code somehow ends up using the uninitialized values, but I can't find it. So either it's hard to find, or GCC is doing something wrong.

Feb 20 2019, 3:17 AM · Restricted Project, Restricted Project
hans committed rL354440: Merging r354422:.
Merging r354422:
Feb 20 2019, 12:21 AM

Feb 19 2019

hans committed rL354353: index.rst: Remove bb-chapuni from list of IRC bots.
index.rst: Remove bb-chapuni from list of IRC bots
Feb 19 2019, 9:01 AM
hans committed rL354352: index.rst: Remove Dragonegg link.
index.rst: Remove Dragonegg link
Feb 19 2019, 9:01 AM
hans committed rL354351: Remove extraneous space in MSVC-style diagnostic output.
Remove extraneous space in MSVC-style diagnostic output
Feb 19 2019, 8:59 AM
hans committed rC354351: Remove extraneous space in MSVC-style diagnostic output.
Remove extraneous space in MSVC-style diagnostic output
Feb 19 2019, 8:59 AM
hans closed D58377: Remove extraneous space in MSVC-style diagnostic output.
Feb 19 2019, 8:59 AM · Restricted Project