- User Since
- Apr 18 2013, 6:48 AM (363 w, 6 d)
Mon, Apr 6
Seems reasonable to me.
Seems okay to me.
Thu, Apr 2
Looks reasonable to me. Just some nits.
Fri, Mar 27
Thu, Mar 26
Wed, Mar 25
Tue, Mar 24
Sorry for the slow reply. For some reason I didn't see this until now.
Mon, Mar 23
Fri, Mar 20
Thu, Mar 19
Wed, Mar 18
This seems to have caused https://bugs.llvm.org/show_bug.cgi?id=45218
Please take a look.
Mon, Mar 16
Sounds reasonable to me.
This seems reasonable, but can we wait until after the release? I would prefer to not change these things right now.
Fri, Mar 13
Seems to have broken this bot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/26137/
Thu, Mar 12
Dylan, can you please add a note about this in llvm/docs/ReleaseNotes.rst?
Wed, Mar 11
Looks good to me.
Mar 6 2020
Mar 5 2020
lgtm, thanks for the quick fix!
Very nice, thanks!
Mar 4 2020
Mar 3 2020
There were some concerns raised on this patch, and also in PR44780.
Mar 2 2020
lgtm with comment
I also just noticed that this broke the Chromium build, see the attached reproducer at https://bugs.chromium.org/p/chromium/issues/detail?id=1057559#c1
Feb 28 2020
Please include the PR number next time :-) PR45034 in this case.
It seems a little bit unfortunate to have to sprinkle !isNVPTX everywhere, but I don't have any better ideas, so lgtm.
I don't really know anything about Sphinx, but sounds good to me if it works I guess :-)
These correspond to the addresses of -4096 and -8192. Hopefully, such a key is never inserted into a DenseMap.
Regarding the explicit instantiation, all of the methods are still defined in the header, so any users with non-default template args will instantiate their own definitions of Allocate & co.