Page MenuHomePhabricator

hans (Hans Wennborg)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 18 2013, 6:48 AM (363 w, 6 d)

Recent Activity

Yesterday

hans accepted D77585: Stop passing site cfg files via --param to llvm-lit..

lgtm

Tue, Apr 7, 1:35 AM · Restricted Project
hans committed rG717a46086763: Drop the number of thinlto jobs in some tests to avoid crashing on 32-bit… (authored by hans).
Drop the number of thinlto jobs in some tests to avoid crashing on 32-bit…
Tue, Apr 7, 1:03 AM

Mon, Apr 6

hans accepted D77553: [Support,Windows] Tolerate failure of CryptGenRandom.

Seems reasonable to me.

Mon, Apr 6, 10:18 AM · Restricted Project
hans committed rGf8e1fc20cb39: Make clang/test/Driver/cl-options.cu pass in 32-bit builds (authored by hans).
Make clang/test/Driver/cl-options.cu pass in 32-bit builds
Mon, Apr 6, 7:33 AM
hans committed rG64c231275082: Revert 43f031d3126 "Enable IBT(Indirect Branch Tracking) in JIT with CET… (authored by hans).
Revert 43f031d3126 "Enable IBT(Indirect Branch Tracking) in JIT with CET…
Mon, Apr 6, 6:28 AM
hans added a reverting change for rG43f031d31264: Enable IBT(Indirect Branch Tracking) in JIT with CET(Control-flow Enforcement…: rG64c231275082: Revert 43f031d3126 "Enable IBT(Indirect Branch Tracking) in JIT with CET….
Mon, Apr 6, 6:28 AM
hans committed rG6a800f6f622a: Add a triple to test/ExecutionEngine/MCJIT/cet-code-model-lager.ll (authored by hans).
Add a triple to test/ExecutionEngine/MCJIT/cet-code-model-lager.ll
Mon, Apr 6, 5:55 AM
hans accepted D77496: Make paths in generated llvm-lit relative as well..

Seems okay to me.

Mon, Apr 6, 1:36 AM · Restricted Project

Thu, Apr 2

hans accepted D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang.

Looks reasonable to me. Just some nits.

Thu, Apr 2, 3:13 AM · Restricted Project

Fri, Mar 27

hans committed rGeb85e90350e9: clang-format: Fix pointer alignment for overloaded operators (PR45107) (authored by hans).
clang-format: Fix pointer alignment for overloaded operators (PR45107)
Fri, Mar 27, 3:12 AM
hans closed D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107).
Fri, Mar 27, 3:12 AM · Restricted Project
hans added inline comments to D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107).
Fri, Mar 27, 3:10 AM · Restricted Project

Thu, Mar 26

hans created D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107).
Thu, Mar 26, 7:33 AM · Restricted Project

Wed, Mar 25

hans committed rGc278e8f8f916: Build fix: AttributeCommonInfo::AS_C2x (authored by hans).
Build fix: AttributeCommonInfo::AS_C2x
Wed, Mar 25, 8:05 AM

Tue, Mar 24

hans added a comment to D76513: [ReleaseNotes,ARM] MVE intrinsics are all implemented!.

Sorry for the slow reply. For some reason I didn't see this until now.

Tue, Mar 24, 2:07 AM · Restricted Project, Restricted Project

Mon, Mar 23

hans committed rGd32170dbd5b0: [CUDA] Warn about unsupported CUDA SDK version only if it's used. (authored by tra).
[CUDA] Warn about unsupported CUDA SDK version only if it's used.
Mon, Mar 23, 8:42 AM
hans added a comment to D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used..
In D76030#1925445, @tra wrote:

@hans -- this should be cherry-picked into 10 if it's not too late yet.

It's probably too late for 10.0.0, but sounds like a good candidate for 10.0.1.

Mon, Mar 23, 8:41 AM · Restricted Project
hans accepted D76531: [Win64] Insert int3 into trailing empty BBs.

lgtm

Mon, Mar 23, 6:30 AM · Restricted Project

Fri, Mar 20

hans accepted D76444: Use FinishThunk to finish musttail thunks.

lgtm

Fri, Mar 20, 3:45 AM · Restricted Project

Thu, Mar 19

hans committed rGcfa792458fc4: [Transforms] add phase ordering tests for min/max/abs; NFC (authored by spatel).
[Transforms] add phase ordering tests for min/max/abs; NFC
Thu, Mar 19, 2:41 AM
hans committed rG35627038123b: [Concepts] Fix incorrect control flow when TryAnnotateTypeConstraint annotates… (authored by saar.raz).
[Concepts] Fix incorrect control flow when TryAnnotateTypeConstraint annotates…
Thu, Mar 19, 2:40 AM
hans committed rGa36a14b70f18: [Concepts] Fix incorrect DeclContext for transformed RequiresExprBodyDecl (authored by saar.raz).
[Concepts] Fix incorrect DeclContext for transformed RequiresExprBodyDecl
Thu, Mar 19, 2:40 AM
hans committed rG5401d393f88b: ../llvm/utils/update_test_checks.py --opt-binary bin/opt .. (authored by hans).
../llvm/utils/update_test_checks.py --opt-binary bin/opt ..
Thu, Mar 19, 2:40 AM
hans committed rG623461b2ce42: [EarlyCSE] avoid crashing when detecting min/max/abs patterns (PR41083) (authored by spatel).
[EarlyCSE] avoid crashing when detecting min/max/abs patterns (PR41083)
Thu, Mar 19, 2:40 AM

Wed, Mar 18

hans added a comment to D66332: [clang-format] Fix the bug that joins template closer and > or >>.

This seems to have caused https://bugs.llvm.org/show_bug.cgi?id=45218
Please take a look.

Wed, Mar 18, 3:13 AM · Restricted Project
hans added a comment to D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used..
In D76030#1925445, @tra wrote:

@hans -- this should be cherry-picked into 10 if it's not too late yet.

Wed, Mar 18, 2:41 AM · Restricted Project
hans committed rG26c762df6c48: Revert "[Concepts] Fix incorrect control flow when TryAnnotateTypeConstraint… (authored by hans).
Revert "[Concepts] Fix incorrect control flow when TryAnnotateTypeConstraint…
Wed, Mar 18, 2:09 AM
hans added a reverting change for rG135744ce6895: [Concepts] Fix incorrect control flow when TryAnnotateTypeConstraint annotates…: rG26c762df6c48: Revert "[Concepts] Fix incorrect control flow when TryAnnotateTypeConstraint….
Wed, Mar 18, 2:09 AM
hans committed rG52c365aa9ca0: Revert "[Concepts] Fix incorrect DeclContext for transformed… (authored by hans).
Revert "[Concepts] Fix incorrect DeclContext for transformed…
Wed, Mar 18, 2:09 AM
hans added a reverting change for rG9e0bd5ec03cb: [Concepts] Fix incorrect DeclContext for transformed RequiresExprBodyDecl: rG52c365aa9ca0: Revert "[Concepts] Fix incorrect DeclContext for transformed….
Wed, Mar 18, 2:09 AM

Mon, Mar 16

hans accepted D76191: Turn off core dumps before starting the main body of test-release.sh..

Sounds reasonable to me.

Mon, Mar 16, 1:37 AM · Restricted Project
hans accepted D76192: Use maximum compression when packaging release tarballs..

This seems reasonable, but can we wait until after the release? I would prefer to not change these things right now.

Mon, Mar 16, 1:37 AM · Restricted Project

Fri, Mar 13

hans added a comment to D70097: [SCEV] Add missing cache queries.

Seems to have broken this bot: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/26137/

Fri, Mar 13, 8:33 AM · Restricted Project
hans added a comment to D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash.

Looks like there's a memory corruption detected by ASAN, but I'm not sure it's related to my change. Maybe someone with a more expert eye could tell?

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/26137/steps/check-asan%20in%20gcc%20build/logs/stdio

Fri, Mar 13, 8:33 AM · Restricted Project, Restricted Project
hans committed rGb406eab88802: add a missing dash to the release notes (authored by hans).
add a missing dash to the release notes
Fri, Mar 13, 6:56 AM
hans committed rG92f7aebe2d7e: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a… (authored by aganea).
[Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a…
Fri, Mar 13, 6:22 AM
hans accepted D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash.
Fri, Mar 13, 3:41 AM · Restricted Project, Restricted Project

Thu, Mar 12

hans committed rGd9bd6e3c1943: PR45083: Mark statement expressions as being dependent if they appear in a… (authored by rsmith).
PR45083: Mark statement expressions as being dependent if they appear in a…
Thu, Mar 12, 5:15 AM
hans committed rG5e062819d5ad: Revert "PR45083: Mark statement expressions as being dependent if they appear… (authored by hans).
Revert "PR45083: Mark statement expressions as being dependent if they appear…
Thu, Mar 12, 5:14 AM
hans committed rG5b5a111c6794: PR45124: Don't leave behind pending cleanups when declaring implicit deduction… (authored by rsmith).
PR45124: Don't leave behind pending cleanups when declaring implicit deduction…
Thu, Mar 12, 5:14 AM
hans added a reverting change for rG3a843031a5ad: PR45083: Mark statement expressions as being dependent if they appear in…: rG5e062819d5ad: Revert "PR45083: Mark statement expressions as being dependent if they appear….
Thu, Mar 12, 5:14 AM
hans added a comment to D75099: [AVR] Include AVR by default in LLVM builds.

Dylan, can you please add a note about this in llvm/docs/ReleaseNotes.rst?

Thu, Mar 12, 5:13 AM · Restricted Project

Wed, Mar 11

hans accepted D75853: [Clang][test] Add .i files for test discovery.

Looks good to me.

Wed, Mar 11, 3:03 AM · Restricted Project
hans accepted D75406: Avoid including FileManager.h from SourceManager.h.

lgtm

Wed, Mar 11, 3:03 AM · Restricted Project, Restricted Project

Mar 6 2020

hans committed rGedcd83a669b6: [mlir] NFC: Rename index_t to index_type (authored by ro).
[mlir] NFC: Rename index_t to index_type
Mar 6 2020, 6:05 AM
hans accepted D75712: Avoid emitting unreachable SP adjustments after `throw`.
Mar 6 2020, 5:31 AM · Restricted Project

Mar 5 2020

hans accepted D75675: [clang-format] do not insert spaces around inline asm symbolic names.

lgtm, thanks for the quick fix!

Mar 5 2020, 5:29 AM · Restricted Project, Restricted Project
hans added a comment to D75675: [clang-format] do not insert spaces around inline asm symbolic names.

Very nice, thanks!

Mar 5 2020, 4:56 AM · Restricted Project, Restricted Project

Mar 4 2020

hans committed rGc290cb61fdca: llvm docs: drop index.rst release version warning (authored by hans).
llvm docs: drop index.rst release version warning
Mar 4 2020, 5:06 AM
hans committed rG3a843031a5ad: PR45083: Mark statement expressions as being dependent if they appear in… (authored by rsmith).
PR45083: Mark statement expressions as being dependent if they appear in…
Mar 4 2020, 12:40 AM
hans committed rGbca373f73fc8: [clangd] DefineOutline won't copy virtual specifiers on methods (authored by njames93).
[clangd] DefineOutline won't copy virtual specifiers on methods
Mar 4 2020, 12:40 AM

Mar 3 2020

hans committed rGdb366f91e5bc: Revert "Reland "[gn build] (manually) merge 68a235d07f9e70"" (authored by hans).
Revert "Reland "[gn build] (manually) merge 68a235d07f9e70""
Mar 3 2020, 6:03 AM
hans added a reverting change for rG68a235d07f9e: build: reduce CMake handling for zlib: rGdb366f91e5bc: Revert "Reland "[gn build] (manually) merge 68a235d07f9e70"".
Mar 3 2020, 6:03 AM
hans added a reverting change for rG94d4ca90040a: Reland "[gn build] (manually) merge 68a235d07f9e70": rGdb366f91e5bc: Revert "Reland "[gn build] (manually) merge 68a235d07f9e70"".
Mar 3 2020, 6:03 AM
hans committed rG5f9211bc46fa: Revert abb00753 "build: reduce CMake handling for zlib" (PR44780) (authored by hans).
Revert abb00753 "build: reduce CMake handling for zlib" (PR44780)
Mar 3 2020, 6:03 AM
hans added a reverting change for rGabb007530695: build: reduce CMake handling for zlib: rG5f9211bc46fa: Revert abb00753 "build: reduce CMake handling for zlib" (PR44780).
Mar 3 2020, 6:02 AM
hans committed rG93c73d4834a9: Revert "Reland "[gn build] (manually) merge 68a235d07f9e70"" (authored by hans).
Revert "Reland "[gn build] (manually) merge 68a235d07f9e70""
Mar 3 2020, 2:41 AM
hans added a reverting change for rG68a235d07f9e: build: reduce CMake handling for zlib: rG93c73d4834a9: Revert "Reland "[gn build] (manually) merge 68a235d07f9e70"".
Mar 3 2020, 2:40 AM
hans added a reverting change for rG94d4ca90040a: Reland "[gn build] (manually) merge 68a235d07f9e70": rG93c73d4834a9: Revert "Reland "[gn build] (manually) merge 68a235d07f9e70"".
Mar 3 2020, 2:40 AM
hans committed rG916be8fd6a0a: Revert abb00753 "build: reduce CMake handling for zlib" (PR44780) (authored by hans).
Revert abb00753 "build: reduce CMake handling for zlib" (PR44780)
Mar 3 2020, 2:12 AM
hans added a reverting change for rGabb007530695: build: reduce CMake handling for zlib: rG916be8fd6a0a: Revert abb00753 "build: reduce CMake handling for zlib" (PR44780).
Mar 3 2020, 2:12 AM
hans added a comment to D70764: build: reduce CMake handling for zlib.

There were some concerns raised on this patch, and also in PR44780.

Mar 3 2020, 2:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 2 2020

hans accepted D75469: Add C standard upgrade in clang-11 release note.

lgtm with comment

Mar 2 2020, 10:20 AM · Restricted Project
hans committed rG1939a0f40c99: Minor ReleaseNotes fixes (authored by hans).
Minor ReleaseNotes fixes
Mar 2 2020, 5:52 AM
hans committed rG0bf4795d0696: [WinEH] Fix inttoptr+phi optimization in presence of catchswitch (authored by rnk).
[WinEH] Fix inttoptr+phi optimization in presence of catchswitch
Mar 2 2020, 2:43 AM
hans added a comment to D75266: SROA: Don't drop atomic load/store alignments (PR45010).
In D75266#1898238, @jfb wrote:

I meant compare and exchange, as well as RMW.

Mar 2 2020, 2:33 AM · Restricted Project
hans committed rG99e5b2ff9df5: clang-format: fix spacing in `operator const char*()` (authored by krasimir).
clang-format: fix spacing in `operator const char*()`
Mar 2 2020, 2:31 AM
hans added a comment to D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions.

@MyDeveloperDay @hans what about adding this to the release notes?
I was trying clang-format 10 on Firefox code base and I noticed this change which isn't documented in
https://prereleases.llvm.org/10.0.0/rc1/tools/clang/docs/ReleaseNotes.html#clang-format
(I can do it if you want)

Mar 2 2020, 2:30 AM · Restricted Project, Restricted Project, Restricted Project
hans added a comment to D72911: clang-format: fix spacing in `operator const char*()`.

@krasimir @MyDeveloperDay @hans Looks like it is a regression from https://reviews.llvm.org/D72911
and the fix isn't in 10.0rc2.
Should we take it?

Mar 2 2020, 2:30 AM · Restricted Project
hans committed rG6b16ce944fef: Attempt to fix ZLIB CMake logic on Windows (authored by rnk).
Attempt to fix ZLIB CMake logic on Windows
Mar 2 2020, 2:19 AM
hans committed rG917119e95aa1: [CMake] Link against ZLIB::ZLIB (authored by phosek).
[CMake] Link against ZLIB::ZLIB
Mar 2 2020, 2:19 AM
hans committed rG499b1699621e: [CMake] Use PUBLIC link mode for static libraries (authored by phosek).
[CMake] Use PUBLIC link mode for static libraries
Mar 2 2020, 2:19 AM
hans added a comment to D74176: [CMake] Link against ZLIB::ZLIB.
In D74176#1899793, @rnk wrote:
and rGe441a584f3f7d743ab77031a47d9ad60ee56b53d.

I've pushed that to 10.x in f5fd8a37c18439102eb30c85dadac68c260a1a0d, as we had also merged the patch it's fixing.

I'll look at doing the same thing for zlib. Also, cmake is horrible.

Mar 2 2020, 2:18 AM · Restricted Project
hans committed rGf5fd8a37c184: Try to fix WindowsManifest CMake logic on Windows (authored by rnk).
Try to fix WindowsManifest CMake logic on Windows
Mar 2 2020, 1:55 AM
hans added a comment to D74176: [CMake] Link against ZLIB::ZLIB.
In D74176#1899793, @rnk wrote:
and rGe441a584f3f7d743ab77031a47d9ad60ee56b53d.
Mar 2 2020, 1:54 AM · Restricted Project
hans added a comment to D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.

I also just noticed that this broke the Chromium build, see the attached reproducer at https://bugs.chromium.org/p/chromium/issues/detail?id=1057559#c1

Mar 2 2020, 1:31 AM · Restricted Project, Restricted Project
hans committed rG5405c262a4ab: [llvm][Support][modulemap] Exclude WindowsSupport.h from the LLVM_Util module (authored by Bigcheese).
[llvm][Support][modulemap] Exclude WindowsSupport.h from the LLVM_Util module
Mar 2 2020, 1:07 AM
hans added a comment to D74599: llvm-ar: Fix MinGW compilation.

I pushed a commit fixing this in rG0b6abe428164 by just excluding the header.

Mar 2 2020, 1:05 AM · Restricted Project
hans added a comment to D75373: [Clang] Fix Hurd toolchain class hierarchy.

@hans, do you think this could be included in 10.0?

Mar 2 2020, 12:45 AM · Restricted Project
hans committed rG802b22b5c8c3: Revert "[DebugInfo][clang][DWARF5]: Added support for debuginfo generation for… (authored by hans).
Revert "[DebugInfo][clang][DWARF5]: Added support for debuginfo generation for…
Mar 2 2020, 12:43 AM
hans added a reverting change for rGc2b437d53d40: [DebugInfo][clang][DWARF5]: Added support for debuginfo generation for…: rG802b22b5c8c3: Revert "[DebugInfo][clang][DWARF5]: Added support for debuginfo generation for….
Mar 2 2020, 12:43 AM
hans added a comment to D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates.
Mar 2 2020, 12:43 AM · Restricted Project, Restricted Project

Feb 28 2020

hans committed rG4c6e58998596: ReleaseNotes: remove in-progress warnings, tidy up a bit (authored by hans).
ReleaseNotes: remove in-progress warnings, tidy up a bit
Feb 28 2020, 8:15 AM
hans committed rG7f015d0d4f0b: Re-generate docs (authored by hans).
Re-generate docs
Feb 28 2020, 7:56 AM
hans committed rG4ce4b0c36786: update clang-cl flag section in UsersManual.rst (authored by hans).
update clang-cl flag section in UsersManual.rst
Feb 28 2020, 7:56 AM
hans committed rGcef9526ce77d: [gn build] Port a0f50d73163 (authored by LLVM GN Syncbot <llvmgnsyncbot@gmail.com>).
[gn build] Port a0f50d73163
Feb 28 2020, 7:45 AM
hans committed rG73c53e612aa1: build: process the libxml2 library path for embedding (authored by compnerd).
build: process the libxml2 library path for embedding
Feb 28 2020, 3:24 AM
hans committed rGcd0926d087a8: No longer generate calls to *_finite (authored by serge-sans-paille).
No longer generate calls to *_finite
Feb 28 2020, 3:02 AM
hans added a comment to D74712: Remove *_finite library support, following upstream.

Please include the PR number next time :-) PR45034 in this case.

Feb 28 2020, 2:58 AM · Restricted Project
hans accepted D75310: [CUDA,clang-cl] Filter out unsupported arguments for device-side compilation..

It seems a little bit unfortunate to have to sprinkle !isNVPTX everywhere, but I don't have any better ideas, so lgtm.

Feb 28 2020, 2:58 AM · Restricted Project
hans added a comment to D75284: [Sphinx] Adjust for source_parsers deprecation in Sphinx 3.0 .

I don't really know anything about Sphinx, but sounds good to me if it works I guess :-)

Feb 28 2020, 2:40 AM · Restricted Project
hans committed rG7cb682929128: SROA: Don't drop atomic load/store alignments (PR45010) (authored by hans).
SROA: Don't drop atomic load/store alignments (PR45010)
Feb 28 2020, 2:38 AM
hans committed rGdaae05af2a5d: llvm-ar: Fix MinGW compilation (authored by hans).
llvm-ar: Fix MinGW compilation
Feb 28 2020, 2:38 AM
hans committed rGd48c981697a4: SROA: Don't drop atomic load/store alignments (PR45010) (authored by hans).
SROA: Don't drop atomic load/store alignments (PR45010)
Feb 28 2020, 2:09 AM
hans closed D75266: SROA: Don't drop atomic load/store alignments (PR45010).
Feb 28 2020, 2:09 AM · Restricted Project
hans accepted D75301: [ADT] Allow K to be incomplete during DenseMap<K*, V> instantiation.

These correspond to the addresses of -4096 and -8192. Hopefully, such a key is never inserted into a DenseMap.

Feb 28 2020, 2:08 AM · Restricted Project
hans added inline comments to D75266: SROA: Don't drop atomic load/store alignments (PR45010).
Feb 28 2020, 2:08 AM · Restricted Project
hans committed rG01f9abbb50b1: llvm-ar: Fix MinGW compilation (authored by hans).
llvm-ar: Fix MinGW compilation
Feb 28 2020, 1:05 AM
hans closed D74599: llvm-ar: Fix MinGW compilation.
Feb 28 2020, 1:05 AM · Restricted Project
hans added a comment to D75281: BumpPtrAllocator: Use extern templates and out of line methods.

Regarding the explicit instantiation, all of the methods are still defined in the header, so any users with non-default template args will instantiate their own definitions of Allocate & co.

Feb 28 2020, 1:04 AM · Restricted Project