- User Since
- Apr 18 2013, 6:48 AM (335 w, 3 d)
Fri, Sep 20
Thu, Sep 19
I've committed a horrible workaround in r372312.
Sadly, we're seeing more breakages on Mac, where CMake test compiles for e.g. armv7 ios are failing with:
Wed, Sep 18
Maybe config.host_ldflags should be using single quotes?
Sadly, this seems to break the lit tests on Mac when building with a profile.
Tue, Sep 17
lgtm with comments
Mon, Sep 16
Looks good to me! (with comment)
A simpler way to test this might be to check for conversion warnings in the existing clang/test/CodeGen/avr-builtins.c test, for example like as above. I think that's better since it covers more of the signatures, e.g. the rotateleft ones too.
Fri, Sep 13
Thu, Sep 12
But is there no help text or user manual that needs to be updated?
Tue, Sep 10
Mon, Sep 9
Reviewers, please try to prioritize this one, since it's currently the last patch blocking llvm 9-rc4.
I think this keeps the algorithm still withing O(n^2) so that's good.
lgtm with comment
Fri, Sep 6
This is very exciting! I didn't look closely at the actual instrumentation code, as rnk knows that better and had some good comments.
Thu, Sep 5
lgtm. I only know about this from what rnk told me about the unwinder not wanting the return address to be outside the function, and this seems like a straight-forward solution to that problem.
Wed, Sep 4
Looks good to me. Thanks!
Tue, Sep 3
Fri, Aug 30
I've merged the InstructionSimplify.h part of this (r370355) to release_90 in r370447.
Thanks for writing release notes! Please let me know if you need assistance with committing to the branch.
I'm also not familiar with the unwinder and exception handling, but the code itself and the explanation seems good to me.
Thu, Aug 29
Wed, Aug 28
I'm also against putting it into 9.0, which is supposed to have a final release Real Soon Now. This is not a obviously-correct change, and it should bake in trunk for at least a couple weeks before going into the release, to shake out any unexpected problems.
I think we should target this for the 9.0.1 patch though, which is why joerg wants to merge the API change to 9.0 now.
With llvm 9 coming up, we should update this, but what should it say exactly?
Can we not get the entire thing merged? I'd really like that... I think the patch is actually really close. I have a bunch of comments below but they're all pretty boring in reality.