Page MenuHomePhabricator

tianshilei1992 (Shilei Tian)
Ph.D. student in Stony Brook University

Projects

User does not belong to any projects.

User Details

User Since
Oct 12 2019, 11:44 AM (78 w, 2 d)

Recent Activity

Fri, Apr 9

tianshilei1992 added a comment to D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA.

Ping...

Fri, Apr 9, 10:54 AM · Restricted Project

Tue, Mar 23

tianshilei1992 added a comment to D99020: [OpenMP] Disable hidden helper task by default.

planning to land this ?

Tue, Mar 23, 8:39 AM · Restricted Project

Sun, Mar 21

tianshilei1992 added a comment to D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA.

@tra, so you think we should not do this? The user will see a link error late I assume, might be better.

Sun, Mar 21, 7:26 PM · Restricted Project
tianshilei1992 updated the diff for D99020: [OpenMP] Disable hidden helper task by default.

update tests

Sun, Mar 21, 2:23 PM · Restricted Project

Sat, Mar 20

tianshilei1992 added inline comments to D99020: [OpenMP] Disable hidden helper task by default.
Sat, Mar 20, 6:23 PM · Restricted Project
tianshilei1992 updated the diff for D99020: [OpenMP] Disable hidden helper task by default.

comments

Sat, Mar 20, 6:14 PM · Restricted Project
tianshilei1992 added inline comments to D99020: [OpenMP] Disable hidden helper task by default.
Sat, Mar 20, 6:02 PM · Restricted Project
tianshilei1992 requested review of D99020: [OpenMP] Disable hidden helper task by default.
Sat, Mar 20, 10:00 AM · Restricted Project

Thu, Mar 18

tianshilei1992 added a comment to D98838: [OpenMP] Fixed a crash in hidden helper thread.

We reported the problem fairly quickly after we saw the assert issue.

I appreciate your report. Seriously. However, no one would like to tell us how to reproduce the bug. Even now this patch has already been merged, I still didn't get any reproducer (in any form) from whom reported the issue at the very beginning. I can get that we're approaching release, and we want a stable product. However, if nobody provides steps to reproduce bugs, and just asks to revert patch, we will probably NEVER have new features.

Thu, Mar 18, 5:01 PM · Restricted Project
tianshilei1992 committed rG2df65f87c1ea: [OpenMP] Fixed a crash in hidden helper thread (authored by tianshilei1992).
[OpenMP] Fixed a crash in hidden helper thread
Thu, Mar 18, 3:25 PM
tianshilei1992 closed D98838: [OpenMP] Fixed a crash in hidden helper thread.
Thu, Mar 18, 3:25 PM · Restricted Project
tianshilei1992 updated the summary of D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA.
Thu, Mar 18, 3:15 PM · Restricted Project
tianshilei1992 added a comment to D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA.
In D98902#2635930, @tra wrote:

My question is, if DeviceOffloadingKind == Action::OFK_Cuda, and we use -S, do we also want to skip as well?

I do not think so. Libdevice is needed to implement some libcalls that LLVM currently does not know how to handle.
We do need it even when we compile with -S. It may work without it in many cases, but it's still needed in general.

Thu, Mar 18, 3:14 PM · Restricted Project
tianshilei1992 added a reviewer for D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA: kkwli0.
Thu, Mar 18, 2:58 PM · Restricted Project
tianshilei1992 requested review of D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA.
Thu, Mar 18, 2:56 PM · Restricted Project
tianshilei1992 added a comment to D98838: [OpenMP] Fixed a crash in hidden helper thread.

__kmp_hidden_helper_initialize() always initializes all hidden threads at once. Right? In this case, you modifications make sense.

Right.

Thu, Mar 18, 1:30 PM · Restricted Project
tianshilei1992 updated the diff for D98838: [OpenMP] Fixed a crash in hidden helper thread.

comments

Thu, Mar 18, 1:29 PM · Restricted Project
tianshilei1992 added a comment to D98838: [OpenMP] Fixed a crash in hidden helper thread.

I did some experiments with different versions of lbm:

  • SPEC2021: didn't observe performance regression (three variants: with hht, with hht but disable it via env, and w/o hht)
  • Ron's reproducer: observed performance regression if running with numactl --localalloc --physcpubind=0-xxx. In this case, disabling it via env can help. If running w/o numactl, almost no performance difference. (unclear the tiny difference is noise or not)

All run 10 times.

Thu, Mar 18, 12:38 PM · Restricted Project
tianshilei1992 added a comment to D98838: [OpenMP] Fixed a crash in hidden helper thread.

[AMD Public Use]

Shilei
I offered you a spec cpu 619.lbm reproducer for the performance issue.
takes 2 minutes or less to compile and run.
Do you want that?

Ron

Thu, Mar 18, 11:18 AM · Restricted Project
tianshilei1992 added a comment to D98838: [OpenMP] Fixed a crash in hidden helper thread.

Shilei,

How much time do  you think you  need to resolve or conclude to revert or disable with macros in 12.0

Some would like to stabilize their performance numbers and would like to do it as early as possible.
Thanks
Ravi

Thu, Mar 18, 11:10 AM · Restricted Project
tianshilei1992 added inline comments to D98838: [OpenMP] Fixed a crash in hidden helper thread.
Thu, Mar 18, 9:59 AM · Restricted Project
tianshilei1992 updated the diff for D98838: [OpenMP] Fixed a crash in hidden helper thread.

comments

Thu, Mar 18, 9:57 AM · Restricted Project
tianshilei1992 added a comment to D98838: [OpenMP] Fixed a crash in hidden helper thread.

I didn't recall we have that conclusion. My memory told me the patch will be reverted if we can't fix issues before the release. No?

Thu, Mar 18, 9:43 AM · Restricted Project
tianshilei1992 added inline comments to D98838: [OpenMP] Fixed a crash in hidden helper thread.
Thu, Mar 18, 8:44 AM · Restricted Project
tianshilei1992 added inline comments to D98838: [OpenMP] Fixed a crash in hidden helper thread.
Thu, Mar 18, 6:01 AM · Restricted Project

Wed, Mar 17

tianshilei1992 updated the diff for D98838: [OpenMP] Fixed a crash in hidden helper thread.

avoid potential integer overflow

Wed, Mar 17, 7:19 PM · Restricted Project
tianshilei1992 added a comment to D77609: [OpenMP] Added the support for hidden helper task in RTL.

Try to fix the crash in D98838

Wed, Mar 17, 7:07 PM · Restricted Project
tianshilei1992 requested review of D98838: [OpenMP] Fixed a crash in hidden helper thread.
Wed, Mar 17, 7:07 PM · Restricted Project
tianshilei1992 added a comment to D77609: [OpenMP] Added the support for hidden helper task in RTL.

I find a stable way to reproduce the assertion. Let's say the default __kmp_threads_capacity is N. If hidden helper thread is enabled, __kmp_threads_capacity will be offset to N+8 by default. If the number of threads we need exceeds N+8, e.g. via num_threads clause, we need to expand __kmp_threads. In __kmp_expand_threads, the expansion starts from __kmp_threads_capacity, and repeatedly doubling it until the new capacity meets the requirement. Let's assume the new requirement is Y. If Y happens to meet the constraint (N+8)*2^X=Y where X is the number of iterations, then the new capacity is not enough because we have 8 slots for hidden helper threads.

#include <vector>
Wed, Mar 17, 5:17 PM · Restricted Project

Tue, Mar 16

tianshilei1992 added a comment to D77609: [OpenMP] Added the support for hidden helper task in RTL.

Also, the reproducer doesn't need to be a small piece of code. It can be steps to reproduce it as long as I can access the source code.

Tue, Mar 16, 4:50 PM · Restricted Project
tianshilei1992 added a comment to D77609: [OpenMP] Added the support for hidden helper task in RTL.

Again, it doesn't help if we don't have a way to reproduce it. We can disable it, we can revert it, sure, but it will NEVER be enabled back because we don't have a reproducer to tell what is wrong, and nobody will use it if it is disabled. We can't guarantee that rewriting the whole thing in a "simpler" way can work if we don't have a way to test it.

Tue, Mar 16, 4:35 PM · Restricted Project
tianshilei1992 added a comment to D77609: [OpenMP] Added the support for hidden helper task in RTL.

Seems like the two assertions mentioned above are caused by a same problem that __kmp_threads is somehow touched and all elements are not NULL. I'd appreciate if someone could provide a reproducer.

Tue, Mar 16, 9:34 AM · Restricted Project

Mon, Mar 15

tianshilei1992 accepted D98654: [libomptarget] Build amdgpu plugin by default.

LG.

Mon, Mar 15, 1:01 PM · Restricted Project
tianshilei1992 added a comment to D98651: [libomptarget] Fix devicertl build.

Yep. Also, DEVICE now always expands to whitespace, so that can go.

Mon, Mar 15, 12:55 PM · Restricted Project
tianshilei1992 added a comment to D77609: [OpenMP] Added the support for hidden helper task in RTL.

Without a reproducer, I cannot tell what was going wrong. And your code is out of date. What is the assertion at line 3691 in kmp_runtime.cpp?

Mon, Mar 15, 12:37 PM · Restricted Project

Mar 13 2021

tianshilei1992 accepted D98565: [libomptarget][amdgcn] Drop use of inttypes.h, moving closer to freestanding.

LGTM.

Mar 13 2021, 6:41 PM · Restricted Project
tianshilei1992 updated the summary of D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.
Mar 13 2021, 11:57 AM · Restricted Project, Restricted Project
tianshilei1992 updated the diff for D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.

remove the requirement of size_t size

Mar 13 2021, 11:56 AM · Restricted Project, Restricted Project

Mar 12 2021

tianshilei1992 accepted D97883: [libomptarget] Add allocator support for target memory.

LGTM.

Mar 12 2021, 8:02 PM · Restricted Project
tianshilei1992 added inline comments to D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.
Mar 12 2021, 6:52 PM · Restricted Project, Restricted Project
tianshilei1992 added a comment to D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.

We probably don't need the index for size_t size. If the ArgNo is out of range, we simply return nullptr. Besides, CUDA function cudaLaunchKernel doesn't have an argument for size as well.

Mar 12 2021, 6:51 PM · Restricted Project, Restricted Project
tianshilei1992 retitled D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata from [RFC] Introduce callback argument encoding mode into callback metadata to [RFC][POC] Introduce callback argument encoding mode into callback metadata.
Mar 12 2021, 6:49 PM · Restricted Project, Restricted Project
tianshilei1992 updated the diff for D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.

add the support for stacked mode in AbstractCallSite::getCallArgOperand

Mar 12 2021, 6:48 PM · Restricted Project, Restricted Project
tianshilei1992 added a comment to D98349: [OpenMP][PoC][WIP] Device Rewrite, ICVs, ThreadState.

Sure. Will do.

Mar 12 2021, 8:14 AM · Restricted Project

Mar 11 2021

tianshilei1992 added inline comments to D98349: [OpenMP][PoC][WIP] Device Rewrite, ICVs, ThreadState.
Mar 11 2021, 12:48 PM · Restricted Project

Mar 10 2021

tianshilei1992 added a comment to D97883: [libomptarget] Add allocator support for target memory.

LGTM, let's move functions around separatly. @tianshilei1992 any other comment?

Mar 10 2021, 7:26 PM · Restricted Project

Mar 9 2021

tianshilei1992 updated the diff for D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.

put the encoding mode into ParameterEncoding

Mar 9 2021, 6:25 PM · Restricted Project, Restricted Project
tianshilei1992 added inline comments to D97883: [libomptarget] Add allocator support for target memory.
Mar 9 2021, 3:58 PM · Restricted Project

Mar 8 2021

tianshilei1992 retitled D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata from [WIP][RFC] Introduce callback argument encoding mode into callback metadata to [RFC] Introduce callback argument encoding mode into callback metadata.
Mar 8 2021, 7:26 PM · Restricted Project, Restricted Project
tianshilei1992 updated the diff for D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.

update llvm doc

Mar 8 2021, 7:25 PM · Restricted Project, Restricted Project
tianshilei1992 updated the summary of D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.
Mar 8 2021, 4:50 PM · Restricted Project, Restricted Project
tianshilei1992 updated the diff for D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.

update doc in clang

Mar 8 2021, 4:49 PM · Restricted Project, Restricted Project
tianshilei1992 committed rGc41ae246ac67: [OpenMP][Clang][NVPTX] Only build one bitcode library for each SM (authored by tianshilei1992).
[OpenMP][Clang][NVPTX] Only build one bitcode library for each SM
Mar 8 2021, 9:03 AM
tianshilei1992 closed D97198: [OpenMP][Clang][NVPTX] Only build one bitcode library for each SM.
Mar 8 2021, 9:03 AM · Restricted Project, Restricted Project

Mar 7 2021

tianshilei1992 updated the diff for D97198: [OpenMP][Clang][NVPTX] Only build one bitcode library for each SM.

rebase and ping

Mar 7 2021, 8:12 PM · Restricted Project, Restricted Project

Mar 6 2021

tianshilei1992 updated the summary of D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.
Mar 6 2021, 8:11 PM · Restricted Project, Restricted Project
tianshilei1992 updated the summary of D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.
Mar 6 2021, 8:10 PM · Restricted Project, Restricted Project
tianshilei1992 added inline comments to D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.
Mar 6 2021, 8:09 PM · Restricted Project, Restricted Project
tianshilei1992 requested review of D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata.
Mar 6 2021, 8:07 PM · Restricted Project, Restricted Project

Mar 3 2021

tianshilei1992 added inline comments to D97883: [libomptarget] Add allocator support for target memory.
Mar 3 2021, 7:22 PM · Restricted Project

Feb 24 2021

tianshilei1992 added a comment to D97329: [OpenMP] Fixed a crash when offloading to x86_64 with target nowait.

This patch fixes the segfault in __kmp_push_task, when executing the code with OMP_NUM_THREADS>1.
I accidentally ran the test case in this patch with OMP_NUM_THREADS=1 (which happens to be the default on our cluster) and could not even get a stacktrace after the crash.

I'll take a look and fix it in another patch.

Feb 24 2021, 9:42 AM · Restricted Project
tianshilei1992 committed rGe5da63d5a9ed: [OpenMP] Fixed a crash when offloading to x86_64 with target nowait (authored by tianshilei1992).
[OpenMP] Fixed a crash when offloading to x86_64 with target nowait
Feb 24 2021, 9:38 AM
tianshilei1992 closed D97329: [OpenMP] Fixed a crash when offloading to x86_64 with target nowait.
Feb 24 2021, 9:37 AM · Restricted Project

Feb 23 2021

tianshilei1992 updated the diff for D97329: [OpenMP] Fixed a crash when offloading to x86_64 with target nowait.

update test case

Feb 23 2021, 6:15 PM · Restricted Project
tianshilei1992 updated the diff for D97329: [OpenMP] Fixed a crash when offloading to x86_64 with target nowait.

Added the test although it is expected to fail on x86_64

Feb 23 2021, 6:13 PM · Restricted Project
tianshilei1992 abandoned D81989: [OpenMP] Introduce low level dependency process to target offloading.
Feb 23 2021, 3:46 PM · Restricted Project
tianshilei1992 abandoned D96519: [Clang][OpenMP] Fixed an issue that `target team` is emitted incorrectly.

This patch is abandoned and will propose a new patch to unify interface of target and target teams.

Feb 23 2021, 1:38 PM · Restricted Project
tianshilei1992 added a comment to D77609: [OpenMP] Added the support for hidden helper task in RTL.

@protze.joachim
Can you try https://reviews.llvm.org/D97329 to see if it works?

Feb 23 2021, 12:48 PM · Restricted Project
tianshilei1992 added a comment to D97329: [OpenMP] Fixed a crash when offloading to x86_64 with target nowait.

I didn't include the reproducer because it cannot pass because of computation error. The same code can pass on NVPTX target.

Feb 23 2021, 12:46 PM · Restricted Project
tianshilei1992 requested review of D97329: [OpenMP] Fixed a crash when offloading to x86_64 with target nowait.
Feb 23 2021, 12:45 PM · Restricted Project
tianshilei1992 added a comment to D97004: [OpenMP][NVPTX] Add the support for CUDA 11.2 and CUDA 11.1.

I can confirm, that with the following, I can build release successfully:

set(cuda_version_list 112 111 110 102 101 100 92 91 90 80)
set(ptx_feature_list 70 70 70 65 64 63 61 61 60 42)
Feb 23 2021, 11:21 AM · Restricted Project
tianshilei1992 committed rGf6c2984a090e: [OpenMP][NVPTX] Fixed a compilation error in deviceRTLs caused by unsupported… (authored by tianshilei1992).
[OpenMP][NVPTX] Fixed a compilation error in deviceRTLs caused by unsupported…
Feb 23 2021, 10:20 AM
tianshilei1992 closed D97195: [OpenMP][NVPTX] Fixed a compilation error in deviceRTLs caused by unsupported feature in release verion of LLVM.
Feb 23 2021, 10:20 AM · Restricted Project

Feb 22 2021

tianshilei1992 updated the summary of D97198: [OpenMP][Clang][NVPTX] Only build one bitcode library for each SM.
Feb 22 2021, 10:49 AM · Restricted Project, Restricted Project
tianshilei1992 updated the diff for D97198: [OpenMP][Clang][NVPTX] Only build one bitcode library for each SM.

use ptx61 instead

Feb 22 2021, 10:49 AM · Restricted Project, Restricted Project
tianshilei1992 added a comment to D77609: [OpenMP] Added the support for hidden helper task in RTL.

I'm getting a segfault, when running code with target nowait compiled for x86 offloading. The segfault is in __kmp_push_task for a task marked as hidden_task.

I tried to find the thread with __kmp_gtid = 2 (assuming that's still the task identified as gtid=2) :

(gdb) t 11
[Switching to thread 11 (Thread 0x2aab18000800 (LWP 16111))]
(gdb) p __kmp_gtid
$34 = 2
(gdb) bt
#0  0x00002aaabddea9cc in .omp_outlined._debug__ (.global_tid.=0x2aab17ffef00, .bound_tid.=0x2aab17ffeef8, BlockC=@0x2aab17fff238: 0x2aab20000d30, BlockA=@0x2aab17fff230: 0x2aab3c010da0, 
    BlockB=@0x2aab17fff228: 0x2aab40010da0) at targetnowait.cpp:109
#1  0x00002aaabddeaa95 in .omp_outlined. (.global_tid.=0x2aab17ffef00, .bound_tid.=0x2aab17ffeef8, BlockC=@0x2aab17fff238: 0x2aab20000d30, BlockA=@0x2aab17fff230: 0x2aab3c010da0, 
    BlockB=@0x2aab17fff228: 0x2aab40010da0) at targetnowait.cpp:105
#2  0x00002aaaab584803 in __kmp_invoke_microtask () at llvm-project/openmp/runtime/src/z_Linux_asm.S:1166
#3  0x00002aaaab51741c in __kmp_fork_call (loc=0x2aaabdfeada0, gtid=<optimized out>, call_context=fork_context_intel, argc=3, microtask=<optimized out>, invoker=0x2aaaab51c020 <__kmp_invoke_task_func>, 
    ap=0x2aab17fff1d0) at llvm-project/openmp/runtime/src/kmp_runtime.cpp:1906
#4  0x00002aaaab509048 in __kmpc_fork_call (loc=0x2aaabdfeada0, argc=<optimized out>, microtask=0x2aaabddeaa60 <.omp_outlined.>) at llvm-project/openmp/runtime/src/kmp_csupport.cpp:307
#5  0x00002aaabddea8aa in __omp_offloading_3b_1502eaf5__Z24BlockMatMul_TargetNowaitR11BlockMatrixS0_S0__l101_debug__ (BlockC=0x2aab20000d30, BlockA=0x2aab3c010da0, BlockB=0x2aab40010da0) at targetnowait.cpp:105
#6  0x00002aaabddeaac5 in __omp_offloading_3b_1502eaf5__Z24BlockMatMul_TargetNowaitR11BlockMatrixS0_S0__l101 (BlockC=0x2aab20000d30, BlockA=0x2aab3c010da0, BlockB=0x2aab40010da0) at targetnowait.cpp:101
#7  0x00002aaaadccce2c in ffi_call_unix64 () from /lib64/libffi.so.6
#8  0x00002aaaadccc755 in ffi_call () from /lib64/libffi.so.6
#9  0x00002aaaadac4a56 in __tgt_rtl_run_target_team_region () from /home/x/sw/UTIL/clang//12.0-release/lib/../lib/libomptarget.rtl.x86_64.so
#10 0x00002aaaab7c0be0 in DeviceTy::runTeamRegion(void*, void**, long*, int, int, int, unsigned long, __tgt_async_info*) () from /home/x/sw/UTIL/clang//12.0-release/lib/libomptarget.so.12
#11 0x00002aaaab7d02f2 in target(ident_t*, long, void*, int, void**, void**, long*, long*, void**, void**, int, int, int) () from /home/x/sw/UTIL/clang//12.0-release/lib/libomptarget.so.12
#12 0x00002aaaab7c5d96 in __tgt_target_teams_mapper () from /home/x/sw/UTIL/clang//12.0-release/lib/libomptarget.so.12

We also got report in openmp-dev mail list of this issue. I'll investigate it.

Feb 22 2021, 9:07 AM · Restricted Project
tianshilei1992 requested review of D97198: [OpenMP][Clang][NVPTX] Only build one bitcode library for each SM.
Feb 22 2021, 8:31 AM · Restricted Project, Restricted Project
tianshilei1992 committed rG76151acf893a: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target (authored by tianshilei1992).
[Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target
Feb 22 2021, 8:01 AM
tianshilei1992 closed D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target.
Feb 22 2021, 8:00 AM · Restricted Project
tianshilei1992 requested review of D97195: [OpenMP][NVPTX] Fixed a compilation error in deviceRTLs caused by unsupported feature in release verion of LLVM.
Feb 22 2021, 7:52 AM · Restricted Project
tianshilei1992 added a comment to D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing.

to me this is still desired + cmake creating libomptarget-nvptx-unknown.bc as a solution for forward compatibility until a clean solution lands.

We’ll have newer version LLVM like 12.1 or 12.01 w/ a *right* solution. I don’t think we need to think that further.

This doesn't help people who needs to run exactly 12.0. Also cannot wait for a minor release, need things to work right away when a new cuda toolkit is installed intentionally.

Feb 22 2021, 6:37 AM · Restricted Project
tianshilei1992 added a comment to D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing.

to me this is still desired + cmake creating libomptarget-nvptx-unknown.bc as a solution for forward compatibility until a clean solution lands.

Feb 22 2021, 6:18 AM · Restricted Project
tianshilei1992 added a comment to D97004: [OpenMP][NVPTX] Add the support for CUDA 11.2 and CUDA 11.1.

That looks very similar to the above problem with ptx72.

While I sympathise with a desire to run on the latest cuda, openmp building for ptx versions that clang doesn't support seems over-ambitious. Suggest we dial this list back to only those ptx/cuda combinations that clang generates code for, until such point someone (possibly from the openmp effort) updates clang.

Feb 22 2021, 6:15 AM · Restricted Project
tianshilei1992 added a comment to D97004: [OpenMP][NVPTX] Add the support for CUDA 11.2 and CUDA 11.1.

The error is because PTX71 support is not in the release. I’ll hot fix it today.

Feb 22 2021, 6:14 AM · Restricted Project
tianshilei1992 added a comment to D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing.

I think we might not this patch. We’re gonna not support old version of CUDA anyway.

Feb 22 2021, 6:13 AM · Restricted Project
tianshilei1992 added a comment to D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target.

If there is no objection, I’ll merge it.

Feb 22 2021, 6:11 AM · Restricted Project

Feb 20 2021

tianshilei1992 updated the diff for D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target.

optimize error handle process

Feb 20 2021, 5:15 PM · Restricted Project
tianshilei1992 updated the diff for D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target.

update test case

Feb 20 2021, 5:10 PM · Restricted Project
tianshilei1992 updated the diff for D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target.

fixed the test

Feb 20 2021, 1:15 PM · Restricted Project
tianshilei1992 updated the diff for D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target.

rebase

Feb 20 2021, 12:22 PM · Restricted Project
tianshilei1992 committed rG33d660939d9a: [Clang][OpenMP] Update driver test case for OpenMP offload to use sm_35 (authored by tianshilei1992).
[Clang][OpenMP] Update driver test case for OpenMP offload to use sm_35
Feb 20 2021, 12:14 PM
tianshilei1992 closed D97120: [Clang][OpenMP] Update driver test case for OpenMP offload to use sm_35.
Feb 20 2021, 12:14 PM · Restricted Project
tianshilei1992 requested review of D97120: [Clang][OpenMP] Update driver test case for OpenMP offload to use sm_35.
Feb 20 2021, 10:30 AM · Restricted Project
tianshilei1992 committed rG309b00a42e90: [OpenMP][NFC] clang-format the whole openmp project (authored by tianshilei1992).
[OpenMP][NFC] clang-format the whole openmp project
Feb 20 2021, 9:47 AM
tianshilei1992 closed D97088: [OpenMP][NFC] clang-format the whole openmp project.
Feb 20 2021, 9:46 AM · Restricted Project

Feb 19 2021

tianshilei1992 updated the diff for D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target.

Use CUDA 9.1 for failure test

Feb 19 2021, 7:08 PM · Restricted Project
tianshilei1992 updated the diff for D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target.

Update to CUDA 9.2

Feb 19 2021, 7:07 PM · Restricted Project
tianshilei1992 retitled D97003: [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target from [Clang][OpenMP] Require CUDA 9+ for OpenMP offloading on NVPTX target to [Clang][OpenMP] Require CUDA 9.2+ for OpenMP offloading on NVPTX target.
Feb 19 2021, 6:37 PM · Restricted Project
tianshilei1992 updated the diff for D97088: [OpenMP][NFC] clang-format the whole openmp project.

Fixed comments

Feb 19 2021, 6:32 PM · Restricted Project
tianshilei1992 added inline comments to D97088: [OpenMP][NFC] clang-format the whole openmp project.
Feb 19 2021, 2:21 PM · Restricted Project