Page MenuHomePhabricator

tianshilei1992 (Shilei Tian)
Ph.D. student in Stony Brook University

Projects

User does not belong to any projects.

User Details

User Since
Oct 12 2019, 11:44 AM (58 w, 5 d)

Recent Activity

Today

tianshilei1992 accepted D92143: [libomptarget][cuda] Detect missing symbols in plugin at build time.

LGTM.

Thu, Nov 26, 10:51 AM · Restricted Project

Yesterday

tianshilei1992 added a comment to D92143: [libomptarget][cuda] Detect missing symbols in plugin at build time.

This is a nice change, but not all plugins can implement all interfaces listed in exports. For example, if the plugin doesn't support async operations, then those interfaces suffix with _async will not be implemented by the plugin, and libomptarget can acknowledge that because dlopen returns nullptr.

Wed, Nov 25, 4:56 PM · Restricted Project

Sat, Nov 21

tianshilei1992 added a comment to D91713: [libomptarget] Implement get_device_num for amdgcn, nvptx.

Open to suggestions on testing. Calling it from a target region on amdgcn with multiple GPUs works. I don't have a cuda machine with multiple cards. A machine with one target returns 0 with or without this patch.

Do we have any runtime tests for openmp in tree? Would need a CI machine with GPUs

Sat, Nov 21, 6:25 PM · Restricted Project

Thu, Nov 19

tianshilei1992 accepted D82245: [libomptarget] Add support for target update non-contiguous.

LGTM. Thanks.

Thu, Nov 19, 8:52 AM · Restricted Project, Restricted Project

Wed, Nov 18

tianshilei1992 added a comment to D82245: [libomptarget] Add support for target update non-contiguous.

Would you please take a thorough check with your patch? I can still find many code that still don't conform with the standard. Thanks. The test case is fine as we don't have unified standard.

Wed, Nov 18, 7:21 PM · Restricted Project, Restricted Project
tianshilei1992 added a comment to D91713: [libomptarget] Implement get_device_num for amdgcn, nvptx.

Please also add test case(s) for this. However, it actually depends on the native runtime that which device should be 0, 1, etc., which is probably hard to determine in OpenMP.

Wed, Nov 18, 11:23 AM · Restricted Project
tianshilei1992 accepted D91713: [libomptarget] Implement get_device_num for amdgcn, nvptx.

Overall LGTM.

Wed, Nov 18, 11:16 AM · Restricted Project
tianshilei1992 added a comment to D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.

Rebasing. Sorry I got it confused, @tianshilei1992 you said you had a crash using this patch, I haven't encountered any errors on my machine. Could you verify that this doesn't cause any issues for you?

Wed, Nov 18, 8:51 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Nov 17

tianshilei1992 added inline comments to D82245: [libomptarget] Add support for target update non-contiguous.
Tue, Nov 17, 5:02 PM · Restricted Project, Restricted Project

Thu, Nov 12

tianshilei1992 committed rG24d0ef0f503f: [OpenMP] Fixed a bug when displaying affinity (authored by tianshilei1992).
[OpenMP] Fixed a bug when displaying affinity
Thu, Nov 12, 7:28 PM
tianshilei1992 closed D91309: [OpenMP] Fixed a bug when displaying affinity.
Thu, Nov 12, 7:27 PM · Restricted Project
tianshilei1992 updated the diff for D91309: [OpenMP] Fixed a bug when displaying affinity.

Rebased the patch to fix the two failed cases...

Thu, Nov 12, 7:43 AM · Restricted Project

Wed, Nov 11

tianshilei1992 requested review of D91309: [OpenMP] Fixed a bug when displaying affinity.
Wed, Nov 11, 5:04 PM · Restricted Project
tianshilei1992 updated the summary of D77609: [OpenMP] Added the support for unshackled task in RTL.
Wed, Nov 11, 8:58 AM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Removed the marcro USE_UNSHACKLED_TASK

Wed, Nov 11, 8:53 AM · Restricted Project

Tue, Nov 10

tianshilei1992 added inline comments to D82245: [libomptarget] Add support for target update non-contiguous.
Tue, Nov 10, 12:06 PM · Restricted Project, Restricted Project
tianshilei1992 added a comment to D82245: [libomptarget] Add support for target update non-contiguous.

Fix coding style

I'm not sure whether this is still WIP because I didn't see any change in the touched code.

I've changed the name of the argument in that function and apply clang-format on the function. Is there any place that I'm not following the coding style? I'm just waiting for acceptance to merge the patch.

Tue, Nov 10, 12:05 PM · Restricted Project, Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Added the missing variable initialization

Tue, Nov 10, 11:17 AM · Restricted Project
tianshilei1992 added a comment to D82245: [libomptarget] Add support for target update non-contiguous.

Fix coding style

Tue, Nov 10, 11:16 AM · Restricted Project, Restricted Project
tianshilei1992 added a comment to D77609: [OpenMP] Added the support for unshackled task in RTL.

Some variables are only defined when the MACRO is enabled. I have changed some code to make it more readable and less complex.

As I said before, I don't see the point in omitting declarations. It just increases our testing surface for no real benefit. If you don't use this but have two more functions and a few declarations, all of which you don't use, you really don't pay a price in the big scheme of things.

What is a right way to detect whether a CMake variable or macro is defined?

In C/C++ (#ifdef) or in CMake (idk)?

The point is, our test cases are not run by CMake, so it cannot detect whether we define any variable.

Then make USE_UNSHACKLED_TASK default and remove all the uses that elide declarations and definitions.

Better to have a way to elide unshackled thread team creation at runtime before putting LIBOMP_USE_UNSHACKLED_TASK by default.

Tue, Nov 10, 10:07 AM · Restricted Project
tianshilei1992 added a comment to D77609: [OpenMP] Added the support for unshackled task in RTL.

Some variables are only defined when the MACRO is enabled. I have changed some code to make it more readable and less complex.

As I said before, I don't see the point in omitting declarations. It just increases our testing surface for no real benefit. If you don't use this but have two more functions and a few declarations, all of which you don't use, you really don't pay a price in the big scheme of things.

What is a right way to detect whether a CMake variable or macro is defined?

In C/C++ (#ifdef) or in CMake (idk)?

Tue, Nov 10, 9:36 AM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Added support for setting number of unshackled threads via environment variable

Tue, Nov 10, 9:32 AM · Restricted Project

Mon, Nov 9

tianshilei1992 abandoned D91107: [Clang][Driver] Added the support for setting GCC toolchain via environment variable.

This code could be improved, but I don't think adding a specific environment variable for this a good solution. You can use the existing CCC_OVERRIDE_OPTIONS to get the same effect. e.g. CCC_OVERRIDE_OPTIONS=^--gcc-toolchain=/path/to/gcc

More documentation can be found here: https://github.com/llvm-mirror/clang/blob/master/tools/driver/driver.cpp#L75

Mon, Nov 9, 6:42 PM · Restricted Project
tianshilei1992 requested review of D91107: [Clang][Driver] Added the support for setting GCC toolchain via environment variable.
Mon, Nov 9, 3:58 PM · Restricted Project
tianshilei1992 added inline comments to D82245: [libomptarget] Add support for target update non-contiguous.
Mon, Nov 9, 10:01 AM · Restricted Project, Restricted Project
tianshilei1992 added inline comments to D82245: [libomptarget] Add support for target update non-contiguous.
Mon, Nov 9, 9:28 AM · Restricted Project, Restricted Project

Sun, Nov 8

tianshilei1992 requested changes to D82245: [libomptarget] Add support for target update non-contiguous.
Sun, Nov 8, 5:34 PM · Restricted Project, Restricted Project
tianshilei1992 reopened D82245: [libomptarget] Add support for target update non-contiguous.

This patch breaks the building of OpenMP. Please fix it.

FAILED: libomptarget/src/CMakeFiles/omptarget.dir/omptarget.cpp.o
/home/shiltian/Documents/deploy/llvm/release/bin/clang++  -DOMPTARGET_DEBUG -Domptarget_EXPORTS -I/home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/include -Wall -Wcast-qual -Wformat-pedantic -Wimplicit-fallthrough -Wsign-compare -Wno-extra -Wno-pedantic -std=gnu++14 -g -fPIC -MD -MT libomptarget/src/CMakeFiles/omptarget.dir/omptarget.cpp.o -MF libomptarget/src/CMakeFiles/omptarget.dir/omptarget.cpp.o.d -o libomptarget/src/CMakeFiles/omptarget.dir/omptarget.cpp.o -c /home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/src/omptarget.cpp
/home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/src/omptarget.cpp:664:8: error: use of undeclared identifier 'arg_sizes'
       arg_sizes[i], DPxPTR(TgtPtrBegin), DPxPTR(HstPtrBegin));
       ^
/home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/src/omptarget.cpp:664:18: error: use of undeclared identifier 'i'
       arg_sizes[i], DPxPTR(TgtPtrBegin), DPxPTR(HstPtrBegin));
                 ^
/home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/src/omptarget.cpp:691:8: error: use of undeclared identifier 'arg_sizes'
       arg_sizes[i], DPxPTR(HstPtrBegin), DPxPTR(TgtPtrBegin));
       ^
/home/shiltian/Documents/vscode/llvm-project/openmp/libomptarget/src/omptarget.cpp:691:18: error: use of undeclared identifier 'i'
       arg_sizes[i], DPxPTR(HstPtrBegin), DPxPTR(TgtPtrBegin));
                 ^
4 errors generated.

What's more, please follow LLVM coding style.

Sun, Nov 8, 5:33 PM · Restricted Project, Restricted Project

Tue, Nov 3

tianshilei1992 committed rGf5eebc25cc37: [OpenMP] Fixed an issue in the test case parallel_offloading_map (authored by tianshilei1992).
[OpenMP] Fixed an issue in the test case parallel_offloading_map
Tue, Nov 3, 12:59 PM
tianshilei1992 closed D90642: [OpenMP] Fixed an issue in the test case parallel_offloading_map.
Tue, Nov 3, 12:59 PM · Restricted Project
tianshilei1992 added a comment to D81054: [OpenMP] Introduce target memory manager.

The test asserts for x86 offloading:

memory_manager.cpp.tmp-x86_64-pc-linux-gnu: llvm-project/openmp/libomptarget/test/offloading/memory_manager.cpp:37: int main(int, char **): Assertion `buffer[j] == i' failed.
memory_manager.cpp.tmp-x86_64-pc-linux-gnu: llvm-project/openmp/libomptarget/test/offloading/memory_manager.cpp:37: int main(int, char **): Assertion `buffer[j] == i' failed.
Tue, Nov 3, 9:36 AM · Restricted Project

Mon, Nov 2

tianshilei1992 added a reviewer for D90642: [OpenMP] Fixed an issue in the test case parallel_offloading_map: protze.joachim.
Mon, Nov 2, 1:24 PM · Restricted Project
tianshilei1992 requested review of D90642: [OpenMP] Fixed an issue in the test case parallel_offloading_map.
Mon, Nov 2, 1:24 PM · Restricted Project
tianshilei1992 added a comment to D74145: [OpenMP][Offloading] Added support for multiple streams so that multiple kernels can be executed concurrently.

The test started to fail recently

Mon, Nov 2, 1:18 PM · Restricted Project

Sun, Nov 1

tianshilei1992 added a comment to D90519: [Libomptarget][NFC] Move global Libomptarget state to a struct.

I believe this patch is the first one of a series to refactor the libomptarget. I suggest to add your plan into the description. Otherwise, I didn't see any "encapsulation" from this patch. All members in the new class can still be accessed casually.

Sun, Nov 1, 8:48 AM · Restricted Project

Thu, Oct 29

tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Changed some code to make it more readable and less complex.

Thu, Oct 29, 10:05 AM · Restricted Project
tianshilei1992 added a comment to D77609: [OpenMP] Added the support for unshackled task in RTL.

I left some comments. Generally, I would prefer we minimize the use of the macro to elide declarations. I'd also prefer to use the macro as part of the conditions to avoid duplication.
Instead of

#ifdef MACRO
foo(X)
#else 
foo(Y)
#endif

we do

v = MACRO ? X : Y;
foo(v);

which is really helpful if foo is complex code and just as fast.

Thu, Oct 29, 10:03 AM · Restricted Project

Wed, Oct 28

tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Enhanced one test case and fixed some comments

Wed, Oct 28, 8:03 PM · Restricted Project
tianshilei1992 committed rG0661328d7efb: [Clang][OpenMP] Added the support for target data nowait (authored by tianshilei1992).
[Clang][OpenMP] Added the support for target data nowait
Wed, Oct 28, 12:53 PM
tianshilei1992 closed D90099: [Clang][OpenMP] Added the support for target data nowait.
Wed, Oct 28, 12:53 PM · Restricted Project
tianshilei1992 added a comment to D90099: [Clang][OpenMP] Added the support for target data nowait.

The two failed test cases should have nothing to do with this patch. Will merge this patch.

Wed, Oct 28, 12:52 PM · Restricted Project
tianshilei1992 retitled D90099: [Clang][OpenMP] Added the support for target data nowait from [Clang][OpenMP][WIP] Added the support for target data nowait to [Clang][OpenMP] Added the support for target data nowait.
Wed, Oct 28, 12:52 PM · Restricted Project
tianshilei1992 updated the diff for D90099: [Clang][OpenMP] Added the support for target data nowait.

Fixed all failed test cases

Wed, Oct 28, 11:22 AM · Restricted Project
tianshilei1992 added a comment to D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.

This patch caused segment fault in D90099 where the map variable info pointer is nullptr but it is deferenced.

Was it this one, or was it D90172. This patch only changes the code generation in Clang so I don't think it references the generated mapping pointers. It's possible I forget to check the status of the pointer somewhere in the RTL.

Wed, Oct 28, 10:45 AM · Restricted Project, Restricted Project, Restricted Project
tianshilei1992 added a comment to D89802: [OpenMP] Add Passing in Original Declaration Names To Mapper API.

This patch caused segment fault in D90099 where the map variable info pointer is nullptr but it is deferenced.

Wed, Oct 28, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
tianshilei1992 updated the diff for D90099: [Clang][OpenMP] Added the support for target data nowait.

Rebased (again) to involve the reversion of another patch that can cause clang crash

Wed, Oct 28, 10:24 AM · Restricted Project
tianshilei1992 added inline comments to D77609: [OpenMP] Added the support for unshackled task in RTL.
Wed, Oct 28, 7:41 AM · Restricted Project

Oct 27 2020

tianshilei1992 updated the diff for D90099: [Clang][OpenMP] Added the support for target data nowait.

Fixed a rebase issue

Oct 27 2020, 7:05 PM · Restricted Project
tianshilei1992 updated the diff for D90099: [Clang][OpenMP] Added the support for target data nowait.

Fixed a rebase error

Oct 27 2020, 5:49 PM · Restricted Project
tianshilei1992 updated the diff for D90099: [Clang][OpenMP] Added the support for target data nowait.

Rebased and fixed one test case

Oct 27 2020, 5:47 PM · Restricted Project

Oct 26 2020

tianshilei1992 committed rGd38788b357ad: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is… (authored by tianshilei1992).
[Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is…
Oct 26 2020, 9:03 PM
tianshilei1992 closed D90101: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper.
Oct 26 2020, 9:02 PM · Restricted Project
tianshilei1992 updated the diff for D90101: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper.

Rebased the patch

Oct 26 2020, 8:02 PM · Restricted Project
tianshilei1992 updated the diff for D90099: [Clang][OpenMP] Added the support for target data nowait.

Fixed a major issue and one test case

Oct 26 2020, 7:35 PM · Restricted Project
tianshilei1992 committed rGe20d64c3d9d8: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait (authored by tianshilei1992).
[Clang][OpenMP] Fixed an issue of segment fault when using target nowait
Oct 26 2020, 7:33 PM
tianshilei1992 closed D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.
Oct 26 2020, 7:33 PM · Restricted Project, Restricted Project
tianshilei1992 updated the summary of D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.
Oct 26 2020, 11:55 AM · Restricted Project, Restricted Project
tianshilei1992 retitled D90101: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper from [Clang][OpenMP][WIP] Avoid unnecessary privatization of mapper array when there is no user defined mapper to [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper.
Oct 26 2020, 11:55 AM · Restricted Project
tianshilei1992 updated the diff for D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.

Added a test case

Oct 26 2020, 11:54 AM · Restricted Project, Restricted Project
tianshilei1992 updated the diff for D90101: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper.

Fixed two test cases

Oct 26 2020, 10:56 AM · Restricted Project

Oct 24 2020

tianshilei1992 updated the diff for D90101: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper.

Fixed some test cases

Oct 24 2020, 6:00 PM · Restricted Project
tianshilei1992 updated the diff for D90101: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper.

Fixed an issue that caused compiler crash

Oct 24 2020, 3:23 PM · Restricted Project
tianshilei1992 requested review of D90101: [Clang][OpenMP] Avoid unnecessary privatization of mapper array when there is no user defined mapper.
Oct 24 2020, 10:25 AM · Restricted Project
tianshilei1992 updated the summary of D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.
Oct 24 2020, 9:56 AM · Restricted Project, Restricted Project
tianshilei1992 retitled D90099: [Clang][OpenMP] Added the support for target data nowait from [Clang][OpenMP] Added the support for target data nowait to [Clang][OpenMP][WIP] Added the support for target data nowait.
Oct 24 2020, 9:53 AM · Restricted Project
tianshilei1992 requested review of D90099: [Clang][OpenMP] Added the support for target data nowait.
Oct 24 2020, 9:52 AM · Restricted Project
tianshilei1992 added a comment to D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.

I don't think the failed case has anything to do with this patch. It must be a random issue in the bolt.

Oct 24 2020, 9:38 AM · Restricted Project, Restricted Project

Oct 23 2020

tianshilei1992 updated the summary of D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.
Oct 23 2020, 7:56 PM · Restricted Project, Restricted Project
tianshilei1992 updated the diff for D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.

Reverted changes for target data. It will be in another patch.

Oct 23 2020, 7:54 PM · Restricted Project, Restricted Project
tianshilei1992 updated the summary of D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.
Oct 23 2020, 5:48 PM · Restricted Project, Restricted Project
tianshilei1992 retitled D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait from [Clang][OpenMP][WIP] Fixed an issue of segment fault when using target nowait to [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.
Oct 23 2020, 5:44 PM · Restricted Project, Restricted Project
tianshilei1992 updated the diff for D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.

Fixed the issue using a way that no need to change test cases

Oct 23 2020, 5:44 PM · Restricted Project, Restricted Project
tianshilei1992 updated the diff for D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.

Removed useless code and fixed some cases

Oct 23 2020, 12:15 PM · Restricted Project, Restricted Project

Oct 22 2020

tianshilei1992 added a comment to D89878: [OpenMP] Fixed a potential integer overflow.

LGTM.

Though, now that D89426 landed we could also call the LLVM ADT method for this ;)

Oct 22 2020, 6:23 PM · Restricted Project
tianshilei1992 committed rG3091ed099f2f: [OpenMP] Fixed a potential integer overflow (authored by tianshilei1992).
[OpenMP] Fixed a potential integer overflow
Oct 22 2020, 6:22 PM
tianshilei1992 closed D89878: [OpenMP] Fixed a potential integer overflow.
Oct 22 2020, 6:22 PM · Restricted Project

Oct 21 2020

tianshilei1992 updated the diff for D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.

Tried to fix some cases

Oct 21 2020, 3:06 PM · Restricted Project, Restricted Project
tianshilei1992 updated the diff for D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.

Fixed an issue that when there is mapper, the variable in the generated wrapped
task still uses the one in the encountering function

Oct 21 2020, 2:16 PM · Restricted Project, Restricted Project
tianshilei1992 added a comment to D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.

Getting this even when compiling without offload. You can use the reproducer from the original bug report.

I noticed one issue and I'm working on it now.

Oct 21 2020, 11:44 AM · Restricted Project, Restricted Project
tianshilei1992 updated the summary of D89878: [OpenMP] Fixed a potential integer overflow.
Oct 21 2020, 6:25 AM · Restricted Project
tianshilei1992 requested review of D89878: [OpenMP] Fixed a potential integer overflow.
Oct 21 2020, 6:23 AM · Restricted Project

Oct 20 2020

tianshilei1992 requested review of D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait.
Oct 20 2020, 8:00 PM · Restricted Project, Restricted Project

Oct 19 2020

tianshilei1992 retitled D77609: [OpenMP] Added the support for unshackled task in RTL from [OpenMP][WIP] Added the support for unshackled task in RTL to [OpenMP] Added the support for unshackled task in RTL.
Oct 19 2020, 12:58 PM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Disabled unshackled task on macOS as well

Oct 19 2020, 11:55 AM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Fixed test case description

Oct 19 2020, 11:45 AM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Added a new test case for taskgroup

Oct 19 2020, 11:43 AM · Restricted Project

Oct 16 2020

tianshilei1992 added a comment to D77609: [OpenMP] Added the support for unshackled task in RTL.

Enabled unshackled thread by default

What is the current supported way of turning off unshackled thread team with zero side effect?

Oct 16 2020, 5:36 PM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Enabled unshackled thread by default

Oct 16 2020, 4:04 PM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Updated some tests

Oct 16 2020, 8:11 AM · Restricted Project
tianshilei1992 added a comment to D89426: [libomptarget] Require LLVM source tree to build libomptarget.

It is a FATAL_ERROR so when CMake decides to include libomptarget, this would break the CMake generation.

Oct 16 2020, 6:51 AM · Restricted Project

Oct 15 2020

tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Refactored code in z_Linux_util.cpp

Oct 15 2020, 3:46 PM · Restricted Project
tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Added the missing part for the team destroy

Oct 15 2020, 1:26 PM · Restricted Project

Oct 11 2020

tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Still trying to fix a race problem

Oct 11 2020, 1:02 PM · Restricted Project

Oct 9 2020

tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Fixed a potental race condition

Oct 9 2020, 11:41 AM · Restricted Project

Oct 8 2020

tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Added another test case to test dependence process

Oct 8 2020, 2:33 PM · Restricted Project

Oct 5 2020

tianshilei1992 added a comment to D85274: [OpenMP] Introduced a bump-like allocator into the target memory management.

I just revisited this patch. It seems it's based on a very early implementation of the base memory manager patch (D81054). Can you rebase the patch so that we review it? Thanks!

Oct 5 2020, 11:30 AM · Restricted Project

Oct 2 2020

tianshilei1992 updated the diff for D77609: [OpenMP] Added the support for unshackled task in RTL.

Fixed some problems and added the first test case. More cases are on the way.

Oct 2 2020, 10:51 AM · Restricted Project

Sep 25 2020

tianshilei1992 committed rGebb1092a2875: [Clang][OpenMP] Added support for nowait target in CodeGen via regular task (authored by tianshilei1992).
[Clang][OpenMP] Added support for nowait target in CodeGen via regular task
Sep 25 2020, 7:11 PM
tianshilei1992 closed D78075: [Clang][OpenMP] Added support for nowait target in CodeGen via regular task.
Sep 25 2020, 7:10 PM · Restricted Project
tianshilei1992 retitled D78075: [Clang][OpenMP] Added support for nowait target in CodeGen via regular task from [Clang][OpenMP] Added support for nowait target in CodeGen to [Clang][OpenMP] Added support for nowait target in CodeGen via regular task.
Sep 25 2020, 11:09 AM · Restricted Project