Page MenuHomePhabricator

Szelethus (Kristóf Umann)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2017, 6:59 AM (204 w, 5 d)

Recent Activity

Thu, Jun 17

Szelethus added inline comments to D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings.
Thu, Jun 17, 3:02 AM · Restricted Project
Szelethus committed rG9cca5c1391d6: [analyzer] Make checker silencing work for non-pathsensitive bug reports (authored by Szelethus).
[analyzer] Make checker silencing work for non-pathsensitive bug reports
Thu, Jun 17, 1:28 AM
Szelethus closed D102914: [analyzer] Make checker silencing work for non-pathsensitive bug reports.
Thu, Jun 17, 1:28 AM · Restricted Project
Szelethus added a comment to D104136: [analyzer] Add better tracking for RetainCountChecker leak warnings.

Aha, alright! So the tracker tracked back to where the tracked expression got computed to node N, which is the return value of some identity function. Unless its explicitly told that there is a link in between the return value and the parameter, the tracker can't figure this out that it could track further (why would it, right?). So it asks its handlers whether they want to do anything with N, which IdentityHandler does -- it digs out the node where the parameter was evaluated, and tells the tracker to go on. Awesome!

Thu, Jun 17, 12:16 AM · Restricted Project

Wed, Jun 16

Szelethus requested review of D104439: [analyzer][NFC] Demonstrate a move from the analyzer-configs `.def` file to a TableGen file.
Wed, Jun 16, 11:30 PM · Restricted Project

Mon, Jun 14

Szelethus added a comment to D103605: [analyzer] Introduce a new interface for tracking.

Sorry for the absence, took my time to catch up with this series! Really interesting insight into how a new interface is being designed! I need some time to digest things, but can't wait to help on the remaining patches.

Mon, Jun 14, 8:05 AM · Restricted Project
Szelethus added inline comments to D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler.
Mon, Jun 14, 6:14 AM · Restricted Project
Szelethus added a comment to D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker.

I know I'm late to the party, and am just mostly thinking aloud. Awesome patch series!

Mon, Jun 14, 6:12 AM · Restricted Project
Szelethus added inline comments to D103630: [analyzer] Refactor trackRValueExpression into ExpressionHandler.
Mon, Jun 14, 5:53 AM · Restricted Project
Szelethus added inline comments to D103618: [analyzer] Change FindLastStoreBRVisitor to use Tracker.
Mon, Jun 14, 4:27 AM · Restricted Project
Szelethus added inline comments to D103616: [analyzer] Reimplement trackExpressionValue as ExpressionHandler.
Mon, Jun 14, 4:16 AM · Restricted Project

Fri, Jun 11

Szelethus requested changes to D100829: [analyzer][docs] Highlight some differences between ArrayBound and V2.
Fri, Jun 11, 3:03 AM · Restricted Project

May 21 2021

Szelethus updated the diff for D102914: [analyzer] Make checker silencing work for non-pathsensitive bug reports.

Fix the test file.

May 21 2021, 5:58 AM · Restricted Project
Szelethus updated the summary of D102914: [analyzer] Make checker silencing work for non-pathsensitive bug reports.
May 21 2021, 5:20 AM · Restricted Project
Szelethus requested review of D102914: [analyzer] Make checker silencing work for non-pathsensitive bug reports.
May 21 2021, 5:17 AM · Restricted Project

May 20 2021

Szelethus added inline comments to D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr.
May 20 2021, 5:26 AM · Restricted Project
Szelethus added a comment to D102835: [analyzer] Correctly propagate ConstructionContextLayer thru ParenExpr.

This looks great!

May 20 2021, 4:28 AM · Restricted Project

May 19 2021

Szelethus committed rG479ea2a8ed95: [analyzer] Check the checker name, rather than the ProgramPointTag when… (authored by Szelethus).
[analyzer] Check the checker name, rather than the ProgramPointTag when…
May 19 2021, 3:40 AM
Szelethus closed D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker.
May 19 2021, 3:40 AM · Restricted Project

May 18 2021

Szelethus added a comment to D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker.

While I still see checker silencing as a solution to a problem that shouldn't exist, I'm unsure about the amount of tedious and invasive work required to make the underlying infrastructure elegant just for the sake of it being elegant. Most notably, checker silencing solves the problem where a checker finds fatal errors -- disabling such a checker also gets rid of the sink node, which makes the entire analysis behave differently. This is desirable, as explained by @a.sidorin in https://lists.llvm.org/pipermail/cfe-dev/2019-August/063135.html. Although I still have concerns about the user interface if we promoted checker silencing to be user facing, it might be worth investigating a bit further.

May 18 2021, 5:57 AM · Restricted Project
Szelethus updated the summary of D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker.
May 18 2021, 5:50 AM · Restricted Project
Szelethus requested review of D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker.
May 18 2021, 5:23 AM · Restricted Project
Szelethus accepted D102643: [analyzer][Z3][NFC] Use GTEST_SKIP instead of hacks.

Cheers!

May 18 2021, 3:10 AM · Restricted Project

May 13 2021

Szelethus closed D96163: [analyzer] Add 12.0.0. release notes.

Pushed this to the 12.0.0 release branch, just forgot to close it!

May 13 2021, 9:14 AM · Restricted Project

Mar 4 2021

Szelethus accepted D97936: [analyzer][docs][NFC] Fix typo in checkers.rst.

Neat!

Mar 4 2021, 6:04 AM · Restricted Project

Feb 18 2021

Szelethus requested changes to D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs.

As far as content goes, here are my thoughts:

Feb 18 2021, 8:15 AM · Restricted Project

Feb 16 2021

Szelethus accepted D94673: [analyzer][CTU] API for CTU macro expansions.

LGTM! You may wanna wait for someone more knowledgeable about CTU to give it another accept.

Feb 16 2021, 8:17 AM · Restricted Project

Feb 15 2021

Szelethus added a comment to D96163: [analyzer] Add 12.0.0. release notes.

ping

Feb 15 2021, 5:31 AM · Restricted Project

Feb 12 2021

Szelethus added a comment to D87519: [analyzer][Liveness][NFC] Enqueue the CFGBlocks post-order.

I don't insist on this patch, though I will end up removing the FIXME even if I leave the actual code unchanged, as it seems to be outdated.

Feb 12 2021, 8:24 AM · Restricted Project
Szelethus committed rG33e731e62dae: [analyzer][Liveness][NFC] Remove an unneeded pass to collect variables that… (authored by Szelethus).
[analyzer][Liveness][NFC] Remove an unneeded pass to collect variables that…
Feb 12 2021, 7:20 AM
Szelethus closed D87518: [analyzer][Liveness][NFC] Remove an unneeded pass to collect variables that appear in an assignment.
Feb 12 2021, 7:20 AM · Restricted Project

Feb 10 2021

Szelethus added reviewers for D90691: [analyzer] Add new checker for unchecked return value.: NoQ, vsavchenko.

Looks like a neat checker! I guess the only question is the function matching, and I don't dislike it in its current state. @martong, do you have any thoughts on this?

Feb 10 2021, 8:02 PM · Restricted Project
Szelethus accepted D96389: [analyzer] Update static analyzer to be support sarif-html.
Feb 10 2021, 4:30 PM · Restricted Project
Szelethus added inline comments to D96389: [analyzer] Update static analyzer to be support sarif-html.
Feb 10 2021, 10:05 AM · Restricted Project

Feb 9 2021

Szelethus accepted D94476: [analyzer] Implement conversion from Clang diagnostics to PathDiagnostics..

LGTM! As a side note, are we aware of anyone that uses short messages instead of the full length one?

Feb 9 2021, 8:39 PM · Restricted Project
Szelethus added inline comments to D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis.
Feb 9 2021, 7:44 PM · Restricted Project
Szelethus accepted D93224: [analyzer] Use the MacroExpansionContext for macro expansions in plists.

Happy to see this mess go. It was obvious even after the first few hurdles that it wouldn't work out in the long term.

Feb 9 2021, 7:24 PM · Restricted Project
Szelethus accepted D93223: [analyzer] Create MacroExpansionContext member in AnalysisConsumer.

My no1. thought is that I wish the new functionality you're implementing was in the interface of the Preprocessor. I found, and still find it so hard to believe that you couldn't just retrieve this information -- your projects seems to plug this gaping hole in the design. I respect that this is an opt-in functionality for now though, and I guess we could make this a default feature with relative ease.

Feb 9 2021, 7:14 PM · Restricted Project
Szelethus accepted D93222: [analyzer] Introduce MacroExpansionContext to libAnalysis.

This is amazing. We longed for a sensible implementation for this for a long time. Really liking the unit tests as well!

Feb 9 2021, 7:03 PM · Restricted Project
Szelethus updated the diff for D96163: [analyzer] Add 12.0.0. release notes.

Fix'd!

Feb 9 2021, 5:28 PM · Restricted Project

Feb 5 2021

Szelethus requested review of D96163: [analyzer] Add 12.0.0. release notes.
Feb 5 2021, 11:05 AM · Restricted Project

Nov 23 2020

Szelethus added a comment to D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs.

I don't have the time to comb through this doc, unfortunately, but I want to applaud this effort to make the iterator checker family more accessible. Its certainly a forerunner in modeling tricky C++ constructs, and I can't wait to be a more valuable reviewer after being a bit more knowledgeable about it.

Nov 23 2020, 5:07 AM · Restricted Project

Nov 2 2020

Szelethus committed rG22e7182002b5: [analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator (authored by Szelethus).
[analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator
Nov 2 2020, 7:41 AM
Szelethus closed D83678: [analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator.
Nov 2 2020, 7:41 AM · Restricted Project

Oct 27 2020

Szelethus added a comment to D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef.
In D89987#2350649, @NoQ wrote:

Honestly i'd rather eliminate SymExpr and go with Symbol everywhere. It's an overloaded term but appending "Expr" to it doesn't really make it significantly less overloaded.

Oct 27 2020, 10:14 AM · Restricted Project

Oct 19 2020

Szelethus added a comment to D89638: [Analyzer][WebKit] Add attributes to suppress specific checkers.

I'll just add a generic comment because I don't know much (==anything) about webkit checkers. Do you expect to stumble across false positives regularly enough so that an attribute like this would be necessary? Do these checkers rely on some heuristic?

Oct 19 2020, 12:09 PM

Oct 14 2020

Szelethus accepted D89414: clang/StaticAnalyzer: Stop using SourceManager::getBuffer.

Sounds good! Thanks!

Oct 14 2020, 2:31 PM · Restricted Project

Oct 12 2020

Szelethus updated subscribers of D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis..
Oct 12 2020, 1:40 PM · Restricted Project

Sep 29 2020

Szelethus added a comment to D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'..

I am not sure if this checker is worth to further development. A part of the found bugs can be detected with other checkers too, specially if the preconditions of many standard functions are checked (more than what is done now) and by modeling the function calls with assumed error return value.

Sep 29 2020, 9:59 AM · Restricted Project

Sep 28 2020

Szelethus added inline comments to D88312: "ErrorReturn checker" WIP review.
Sep 28 2020, 6:01 AM · Restricted Project
Szelethus added a reviewer for D88332: [WIP][Analyzer] PtrToIntegCastLibcChecker: martong.

@martong has been working hard on libc support for the analyzer, I'll add him :)

Sep 28 2020, 12:10 AM
Szelethus added inline comments to D88332: [WIP][Analyzer] PtrToIntegCastLibcChecker.
Sep 28 2020, 12:09 AM

Sep 25 2020

Szelethus added a comment to D87043: [Analyzer] Fix for dereferece of smart pointer after branching on unknown inner pointer.

Congrats on your GSoC! Unless I missed it, it seems like you haven't posted your final report on cfe-dev, even though its an amazing looking document with a lot of examples and explanations. I think it would be great to spread the message, its a work to be proud of!

Sep 25 2020, 3:00 AM · Restricted Project

Sep 22 2020

Szelethus accepted D88100: [analyzer][StdLibraryFunctionsChecker] Separate the signature from the summaries.

Yup, we've talked about this before. This is indeed a better interface design. LGTM!

Sep 22 2020, 10:30 PM · Restricted Project
Szelethus accepted D88092: [analyzer][StdLibraryFunctionsChecker] Fix getline/getdelim signatures.

A joy of reviewing C++ code is that you get to marvel in all the great things the language has, without having to pull fistfuls of hair out to get get to that point. These patches are always a treat. LGTM!

Sep 22 2020, 10:27 PM · Restricted Project

Sep 21 2020

Szelethus accepted D87942: [Analyzer] GNU named variadic macros in Plister.

LGTM! Thanks!

Sep 21 2020, 11:41 AM · Restricted Project

Sep 20 2020

Szelethus added a comment to D87942: [Analyzer] GNU named variadic macros in Plister.

The fix is great, thank you so much! The test seems to be annoying, it might be worth looking into it some other time, but that is definitely orthogonal to this patch.

Sep 20 2020, 10:27 PM · Restricted Project
Szelethus added a comment to D71524: [analyzer] Support tainted objects in GenericTaintChecker.

I figured you're still working on this, sorry! I'd really like to chat about my earlier comment D71524#1917251, as it kind of challenges the high level idea.

Sep 20 2020, 10:17 PM · Restricted Project

Sep 16 2020

Szelethus added a comment to D87800: [WIP][Analyzer] find stack addresses leaked via out-params.

There are some immediate observation to the patch, like a new kind of check definitely warrants a different warning message. However, I see that this is WIP patch, so I'll try to keep this high level.

Sep 16 2020, 10:45 PM

Sep 15 2020

Szelethus added a comment to D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite.

Post-commit LGTM on the post-commit changes!

Sep 15 2020, 10:11 PM · Restricted Project
Szelethus committed rGdd1d5488e47d: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing… (authored by Szelethus).
[analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing…
Sep 15 2020, 8:45 AM
Szelethus closed D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist.
Sep 15 2020, 8:45 AM · Restricted Project
Szelethus committed rG7c6f5b7fbf5a: [analyzer] Add documentation for alpha.fuchsia.Lock and alpha.core.C11Lock (authored by Szelethus).
[analyzer] Add documentation for alpha.fuchsia.Lock and alpha.core.C11Lock
Sep 15 2020, 7:58 AM
Szelethus closed D86532: (Urgent!) [docs][analyzer] Add documentation for alpha.fuchsia.Lock and alpha.core.C11Lock.
Sep 15 2020, 7:57 AM · Restricted Project
Szelethus closed D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.
Sep 15 2020, 7:52 AM · Restricted Project
Szelethus added a comment to D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.

Sorry for the slack (which is kind of ironic with my attention grabbing title :) ). Landed in rG791b7e9f73e0064153a7c3db8045a7333a8c390c. Thanks everyone!

Sep 15 2020, 7:52 AM · Restricted Project

Sep 14 2020

Szelethus accepted D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite.

@balazske may have some closing words.

Sep 14 2020, 10:39 PM · Restricted Project

Sep 11 2020

Szelethus requested review of D87519: [analyzer][Liveness][NFC] Enqueue the CFGBlocks post-order.
Sep 11 2020, 9:12 AM · Restricted Project
Szelethus updated the summary of D87518: [analyzer][Liveness][NFC] Remove an unneeded pass to collect variables that appear in an assignment.
Sep 11 2020, 9:04 AM · Restricted Project
Szelethus requested review of D87518: [analyzer][Liveness][NFC] Remove an unneeded pass to collect variables that appear in an assignment.
Sep 11 2020, 9:02 AM · Restricted Project
Szelethus updated the diff for D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist.

Rename the live statements checker to live expressions checker. The test file added in a revert commit changed rather heavily, but it makes sense that these entries are removed IMO. Unless somebody objects, I intend to land this as-is.

Sep 11 2020, 8:40 AM · Restricted Project
Szelethus committed rGb9bca883c970: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a… (authored by Szelethus).
[analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a…
Sep 11 2020, 6:59 AM
Szelethus closed D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait.
Sep 11 2020, 6:59 AM · Restricted Project
Szelethus updated the diff for D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait.

Reinstate the assert removed in rG032b78a0762bee129f33e4255ada6d374aa70c71, add a test. Enforce that Environment only makes an exception for ReturnStmt in terms of non-expression statements (and hope that isn't going to stay that way for long).

Sep 11 2020, 6:43 AM · Restricted Project
Szelethus committed rGbe0d79f32930: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to… (authored by Szelethus).
[analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to…
Sep 11 2020, 5:08 AM
Szelethus closed D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__.
Sep 11 2020, 5:08 AM · Restricted Project
Szelethus committed rG7527898fef47: [analyzer][MacroExpansion][NFC] Fix a missing test output check (authored by Szelethus).
[analyzer][MacroExpansion][NFC] Fix a missing test output check
Sep 11 2020, 4:49 AM
Szelethus committed rG26d9a9468105: [analyzer][MacroExpansion][NFC] Fix incorrectly calling parameters arguments (authored by Szelethus).
[analyzer][MacroExpansion][NFC] Fix incorrectly calling parameters arguments
Sep 11 2020, 4:35 AM
Szelethus committed rG1c08da38676d: [analyzer][MacroExpansion] Add a few dumps functions (authored by Szelethus).
[analyzer][MacroExpansion] Add a few dumps functions
Sep 11 2020, 4:32 AM

Sep 10 2020

Szelethus added a comment to D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait.
In D86736#2257880, @NoQ wrote:

i'm very glad that we now consistently use expressions in our Environment.

Sep 10 2020, 2:09 AM · Restricted Project
Szelethus accepted D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics.

What if we'd add a toString method to the constraints and we'd add this to Msg? This way we'd know the contents of the constraint, thus we we'd know how the constraint is violated.

I mean we'd know what is not satisfied. But, to know why exactly that is not satisfied we should dump the whole State but that's obviously not an option. Perhaps we could track which symbols and expressions are participating in the assumption related to the constraint and we could dump only those, but this seems to be a very complex approach.

Sep 10 2020, 12:41 AM · Restricted Project

Sep 9 2020

Szelethus accepted D83678: [analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator.

LGTM on my end!

Sep 9 2020, 7:26 AM · Restricted Project
Szelethus retitled D83678: [analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator from [analyzer] Move ReturnPtrRange checker out of alpha by fixing a false positive on end() iterator to [analyzer][ReturnPtrRangeChecker] Fix a false positive on end() iterator.
Sep 9 2020, 7:25 AM · Restricted Project

Sep 7 2020

Szelethus added a comment to D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__.

Perfectly clear, thank you. However, I would still rely on the others to accept this :|

BTW why does the plist-macros-with-expansion.cpp.plist change? It makes the diff somewhat noisy :s

Sep 7 2020, 8:33 AM · Restricted Project
Szelethus accepted D87240: [analyzer][StdLibraryFunctionsChecker] Have proper weak dependencies.

This is exactly how I imagines weak dependencies to work. LGTM on my end.

Sep 7 2020, 8:30 AM · Restricted Project
Szelethus updated the diff for D86135: [analyzer][MacroExpansion] Fix a crash where multiple parameters resolved to __VA_ARGS__.

Added some documentation to the code snippet pointed out by @martong.

Sep 7 2020, 7:51 AM · Restricted Project
Szelethus added inline comments to D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.
Sep 7 2020, 6:46 AM · Restricted Project
Szelethus updated the diff for D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.

Added a line about D78933.

Sep 7 2020, 6:46 AM · Restricted Project
Szelethus added a comment to D86874: [analyzer] Fix ArrayBoundCheckerV2 false positive regarding size_t indexer.

I can only imagine how long it took for you to write all this, because reading it wasn't that short either. Thank you so much! It really gave me a perspective on how you see this problem, as well as what is actually happening (and should happen) in the checker.

Sep 7 2020, 6:02 AM · Restricted Project
Szelethus added a reviewer for D87118: Add an explicit toggle for the static analyzer in clang-tidy: NoQ.

@NoQ in particular has been working hard on the common infrastructure in between the static analyzer and clang-tidy, I'll add him :)

Sep 7 2020, 3:26 AM · Restricted Project
Szelethus added a comment to D76590: [Analyzer] Model `empty()` member function of containers.

I'm in favor of most, if not all of the changes, though I will admit that this patch seems pretty cluttered, you are doing a lot of refactoring under the same hood. You're moving, adding, removing and changing helper functions and their invocations. Would be possible to make this patch a bit leaner?

Sep 7 2020, 3:19 AM · Restricted Project
Szelethus accepted D84415: [analyzer][StdLibraryFunctionsChecker] Add POSIX pthread handling functions.

@balazske seems to be very involved, he might have some closing words -- from my end, LGTM!

Sep 7 2020, 2:30 AM · Restricted Project
Szelethus added a comment to D85351: [Analyzer] Fix for `ExprEngine::computeObjectUnderConstruction()` for base and delegating consturctor initializers.

The tests look great, thanks! I still lack the confidence to accept, unfortunately.

Sep 7 2020, 1:24 AM · Restricted Project
Szelethus added a comment to D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite.

The patch looks great, in fact, it demonstrates how well thought out your summary crafting machinery is.

Sep 7 2020, 1:20 AM · Restricted Project

Sep 2 2020

Szelethus accepted D87004: [analyzer] Evaluate PredefinedExpressions.

LGTM! Nice!

Sep 2 2020, 2:51 AM · Restricted Project
Szelethus added a comment to D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'..

The summary of this last discussion is that it is not acceptable to have only the simple check for the explicit comparison with a fixed constant. At least not for return types where the "implicit" check (a check that is always true or false for the error return value) is possible, for example the char* case.

Sep 2 2020, 2:42 AM · Restricted Project

Sep 1 2020

Szelethus added a comment to D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait.

I don't have anymore immediate concerns, but I will need more time to comb through the rest of the patch in more details... hopefully I can do that in the following days.

Sep 1 2020, 10:03 AM · Restricted Project
Szelethus added inline comments to D86736: [analyzer][NFC] Don't bind values to ObjCForCollectionStmt, replace it with a GDM trait.
Sep 1 2020, 5:01 AM · Restricted Project
Szelethus added a comment to D86873: [analyzer][NFC] Refactor ArrayBoundCheckerV2.

Before we dive into this too much, if you can point to discussion that explains why we have a 2 versions of the same checker, that would be nice. Why did you chose to work on this one, and not the other? I recall us talking about this in a meeting, but its always great to have it set in stone.

Sep 1 2020, 1:54 AM · Restricted Project
Szelethus updated the summary of D86533: (Urgent!) [release][docs][analyzer] Add 11.0.0. release notes.
Sep 1 2020, 1:49 AM · Restricted Project