Page MenuHomePhabricator

Szelethus (Kristóf Umann)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2017, 6:59 AM (79 w, 10 h)

Recent Activity

Today

Szelethus added a comment to D57062: [analyzer] Re-enable the "System is over constrained" assertion on optimized builds..

And if we find out that this is far too painful, we can always put it back anyways. Doubt that'll happen though.

Wed, Jan 23, 12:28 AM
Szelethus accepted D57062: [analyzer] Re-enable the "System is over constrained" assertion on optimized builds..

Hmmm, came across this one in the not too distant future, and always wondered how painful that performance hit would be that even Release+Asserts should be spared from it. I think 5% performance hit, if asserts are enabled, is an acceptable tradeoff, if the assert is crucial.

Wed, Jan 23, 12:24 AM
Szelethus added a comment to D55400: [analyzer] Move out tracking retain count for OSObjects into a separate checker.

Hmmm, does this mess with options that bad? Could you please clarify?

registerChecker gets-or-creates a checker object. A checker name (used for getting the options) is set the first time it's created.
The checker which was created first "wins" and gets to name the resulting checker.
In practice it basically means that options and checkers reusing the same class do not work.
Do you have better ideas on how this could be arranged?

Wed, Jan 23, 12:20 AM

Yesterday

Szelethus added a comment to D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields.

If you don't mind, I'd prefer to finally get over this patch. I'll commit on the 31st, but will wait for any potential feedback 'til then.

Tue, Jan 22, 3:50 PM
Szelethus added a comment to D55400: [analyzer] Move out tracking retain count for OSObjects into a separate checker.

Poor wording on my end, sorry about that. Let me clarify.

Tue, Jan 22, 12:41 PM

Mon, Jan 21

Szelethus accepted D35068: [analyzer] Detect usages of unsafe I/O functions.

Yup, I'm sold on that.

Mon, Jan 21, 1:44 AM
Szelethus added a comment to D54429: [analyzer] Creating standard Sphinx documentation.

Cheers, this is as good as it gets! IRL we also mentioned making a unipage for each checker which would be awesome (and would require a lot of tedious work), but as a start, I'd much prefer browsing through this doc than the current one. Very much appreciated!

Mon, Jan 21, 12:57 AM · Restricted Project
Szelethus retitled D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments from [analyzer][NFC] Fully initialize CheckerRegistry in by the end of construction to [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments.
Mon, Jan 21, 12:24 AM

Sun, Jan 20

Szelethus updated the diff for D55429: [analyzer] Add CheckerManager::getChecker, make sure that a registry function registers no more than 1 checker.

Rebase.

Sun, Jan 20, 4:57 PM
Szelethus added a child revision for D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments: D54438: [analyzer] Reimplement dependencies between checkers.
Sun, Jan 20, 4:53 PM
Szelethus edited parent revisions for D54438: [analyzer] Reimplement dependencies between checkers, added: 1; removed: 1.
Sun, Jan 20, 4:53 PM
Szelethus removed a child revision for D55424: [analyzer] Supply all checkers with a shouldRegister function: D54438: [analyzer] Reimplement dependencies between checkers.
Sun, Jan 20, 4:53 PM
Szelethus updated the diff for D54438: [analyzer] Reimplement dependencies between checkers.
  • Rebase
  • Resolve the issue mentioned above by not enabling checkers that has any of their dependencies explicitly disabled
  • Introduce osx.RetainCountBase to "solve" the issue mentioned in D55400#1364683, but the test files are still untouched. This leads to 9 lit test failures, but since this patch is ancient, I'd rather update it now and follow up with another, final version later.
Sun, Jan 20, 4:52 PM
Szelethus added a child revision for D55424: [analyzer] Supply all checkers with a shouldRegister function: D56988: [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions.
Sun, Jan 20, 4:40 PM
Szelethus added a parent revision for D56988: [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions: D55424: [analyzer] Supply all checkers with a shouldRegister function.
Sun, Jan 20, 4:40 PM
Szelethus added a child revision for D56988: [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions: D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments.
Sun, Jan 20, 4:35 PM
Szelethus added a parent revision for D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments: D56988: [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions.
Sun, Jan 20, 4:35 PM
Szelethus updated the diff for D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments.

Remove mutable specifiers from all fields of CheckerRegistry.

Sun, Jan 20, 4:35 PM
Szelethus retitled D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments from [analyzer][NFC] Fully initialize CheckerRegistry in by the end of construction, make all methods const to [analyzer][NFC] Fully initialize CheckerRegistry in by the end of construction.
Sun, Jan 20, 4:26 PM
Szelethus created D56989: [analyzer][NFC] Keep track of whether enabling a checker was explictly specified in command line arguments.
Sun, Jan 20, 4:26 PM
Szelethus updated the summary of D56988: [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions.
Sun, Jan 20, 4:02 PM
Szelethus updated the summary of D56988: [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions.
Sun, Jan 20, 4:02 PM
Szelethus created D56988: [analyzer][NFC] Supply CheckerRegistry with AnalyzerOptions.
Sun, Jan 20, 3:57 PM
Szelethus updated the diff for D55424: [analyzer] Supply all checkers with a shouldRegister function.

Rebase.

Sun, Jan 20, 3:55 PM
Szelethus added a comment to D55424: [analyzer] Supply all checkers with a shouldRegister function.
In D55424#1326397, @NoQ wrote:

Should we also pass CheckerManager into shouldRegister...? Or is it entirely useless?

Sun, Jan 20, 3:39 PM
Szelethus added a comment to D55400: [analyzer] Move out tracking retain count for OSObjects into a separate checker.

I'm working on rebasing my dependency branches on top of trunk, and I'm somewhat stuck on this patch, could you lend a hand please?

Sun, Jan 20, 3:19 PM
Szelethus added a comment to D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields.

Ping^3. @NoQ @george.karpenkov Could you please take a look? @xazax.hun Any other objections?

Sun, Jan 20, 11:45 AM

Thu, Jan 17

Szelethus requested changes to D35068: [analyzer] Detect usages of unsafe I/O functions.
In D35068#811436, @NoQ wrote:

I wonder how noisy this check is - did you test it on large codebases? Because these functions are popular, and in many cases it'd be fine to use insecure functions, i wonder if it's worth it to have this check on by default. Like, if it's relatively quiet - it's fine, but if it'd constitute 90% of the analyzer's warnings on popular projects, that'd probably not be fine.

Thu, Jan 17, 10:17 AM
Szelethus added inline comments to D35068: [analyzer] Detect usages of unsafe I/O functions.
Thu, Jan 17, 10:07 AM
Szelethus accepted D35068: [analyzer] Detect usages of unsafe I/O functions.

Overall I think this looks great, thanks! I left some inlines that would be nice to fix before commiting, but all of them are minor nits.

Thu, Jan 17, 10:07 AM
Szelethus accepted D56824: [analyzer] MoveChecker: add ".assign" to the list of common reinitializing methods..
Thu, Jan 17, 1:26 AM

Wed, Jan 16

Szelethus added inline comments to D56632: [analyzer] Track region liveness only through base regions..
Wed, Jan 16, 4:50 AM

Tue, Jan 15

Szelethus added a comment to D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields.

Ping^2

Tue, Jan 15, 3:58 AM

Mon, Jan 14

Szelethus accepted D56632: [analyzer] Track region liveness only through base regions..

Awesome detective work! I glanced over the code, it looks great. I'd love to dedicate more time to your liveness-related patches, but university is a thing, so finding typos and the like is the best I can do for a while.

Mon, Jan 14, 7:49 AM

Mon, Jan 7

Szelethus added a comment to D56340: [analyzer] [NFC] Reverse the argument order for "diff" in tests.

Always bothered me! Is there a way to squeeze this into %diff_plist?

Mon, Jan 7, 4:52 AM

Fri, Dec 28

Szelethus added a comment to D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'.

Missed out on the developments. Thank you so much for handling this!

Fri, Dec 28, 7:26 AM

Dec 20 2018

Szelethus accepted D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'.

Thanks! Sorry about being a little slow with this, I'm sadly busier than I expected, but I'll definitely think about a nicer solution.

Dec 20 2018, 1:06 PM
Szelethus added a comment to D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'.

Sure! I'm on my phone, and will be for a little while, can you commit on my behalf?

Dec 20 2018, 12:50 PM

Dec 19 2018

Szelethus added inline comments to D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'.
Dec 19 2018, 11:34 AM
Szelethus updated the diff for D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'.

I'm still looking for a sensible solution, but I'll at least share a patch that actually works.

Dec 19 2018, 11:32 AM
Szelethus added inline comments to D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'.
Dec 19 2018, 11:11 AM
Szelethus accepted D55873: [analyzer] CStringChecker: Fix a crash when an argument of a weird type is encountered..

Cheers!

Dec 19 2018, 7:08 AM
Szelethus added a comment to D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'.

Yea, should've used hasArg anyways. I'll look into this tonight.

Dec 19 2018, 1:50 AM
Szelethus added inline comments to D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'.
Dec 19 2018, 12:21 AM

Dec 18 2018

Szelethus accepted D55792: Allow direct navigation to static analysis checker documentation through SARIF exports.

This is awesome. Please wait for either @NoQ or @george.karpenkov to have the final say.

Dec 18 2018, 10:18 AM
Szelethus added a comment to D55792: Allow direct navigation to static analysis checker documentation through SARIF exports.

Global nit: I guess having both DESC and DOCS as variable/macro arg names is confusing. Can we instead use DOCSURI/DocsUri?

Dec 18 2018, 8:10 AM
Szelethus created D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'.
Dec 18 2018, 6:38 AM
Szelethus added a comment to D55792: Allow direct navigation to static analysis checker documentation through SARIF exports.

Thank you so much for working on this! The lack of a proper documentation is indeed a weak points of the project.

Dec 18 2018, 4:42 AM

Dec 17 2018

Szelethus added a comment to D54438: [analyzer] Reimplement dependencies between checkers.

I still expect some skeletons to fall out of the closet

This patch doesn't handle -analyzer-disable-checker, which leads to assertation failures in later pathes. Since the way which checker should/shouldnt be enabled is implemented rather poorly, I'll probably try to find a long-term solution.

Dec 17 2018, 8:15 AM
Szelethus added a comment to D51866: [analyzer][UninitializedObjectChecker] New flag to ignore guarded uninitialized fields.

Ping.

Dec 17 2018, 6:10 AM
Szelethus added a comment to D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions.

Lit test failures are gone for Windows after reverting this. Will probably deal with this revision after 8.0.0.

Dec 17 2018, 5:11 AM
Szelethus reopened D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions.

Reverted in rC349344.

Dec 17 2018, 4:31 AM
Szelethus committed rL349344: Revert rC349281 '[analyzer][MallocChecker][NFC] Document and reorganize some….
Revert rC349281 '[analyzer][MallocChecker][NFC] Document and reorganize some…
Dec 17 2018, 4:29 AM
Szelethus added a reverting change for rC349281: [analyzer][MallocChecker][NFC] Document and reorganize some functions: rC349344: Revert rC349281 '[analyzer][MallocChecker][NFC] Document and reorganize some….
Dec 17 2018, 4:29 AM
Szelethus committed rC349344: Revert rC349281 '[analyzer][MallocChecker][NFC] Document and reorganize some….
Revert rC349281 '[analyzer][MallocChecker][NFC] Document and reorganize some…
Dec 17 2018, 4:29 AM
Szelethus added a reverting change for rC349283: [analyzer][MallocChecker] Improve warning messages on double-delete errors: rC349344: Revert rC349281 '[analyzer][MallocChecker][NFC] Document and reorganize some….
Dec 17 2018, 4:29 AM
Szelethus reopened D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors.

Reverted in rC349340. With the wrong revision name... oops...

Dec 17 2018, 4:12 AM
Szelethus added a reverting change for rCTE349288: Fix a lit test failure after MallocChecker changes: rCTE349341: Revert rCTE349288 'Fix a lit test failure after MallocChecker changes'.
Dec 17 2018, 4:12 AM
Szelethus committed rCTE349341: Revert rCTE349288 'Fix a lit test failure after MallocChecker changes'.
Revert rCTE349288 'Fix a lit test failure after MallocChecker changes'
Dec 17 2018, 4:12 AM
Szelethus committed rL349341: Revert rCTE349288 'Fix a lit test failure after MallocChecker changes'.
Revert rCTE349288 'Fix a lit test failure after MallocChecker changes'
Dec 17 2018, 4:12 AM
Szelethus committed rC349340: Revert rC349281 '[analyzer][MallocChecker][NFC] Document and reorganize some….
Revert rC349281 '[analyzer][MallocChecker][NFC] Document and reorganize some…
Dec 17 2018, 4:11 AM
Szelethus added a reverting change for rC349281: [analyzer][MallocChecker][NFC] Document and reorganize some functions: rC349340: Revert rC349281 '[analyzer][MallocChecker][NFC] Document and reorganize some….
Dec 17 2018, 4:11 AM
Szelethus committed rL349340: Revert rC349281 '[analyzer][MallocChecker][NFC] Document and reorganize some….
Revert rC349281 '[analyzer][MallocChecker][NFC] Document and reorganize some…
Dec 17 2018, 4:11 AM
Szelethus committed rC349336: Reverting bitfield size to attempt to fix a windows buildbot.
Reverting bitfield size to attempt to fix a windows buildbot
Dec 17 2018, 2:34 AM
Szelethus committed rL349336: Reverting bitfield size to attempt to fix a windows buildbot.
Reverting bitfield size to attempt to fix a windows buildbot
Dec 17 2018, 2:34 AM
Szelethus added a comment to D38675: [analyzer] MoveChecker Pt.10: Move the checker out of alpha state..

A little late to the party, but I don't see anything against this.

Dec 17 2018, 1:56 AM
Szelethus added a comment to D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp.

@boga95 Do you have commit access, or need this to be commited on your behalf?

Dec 17 2018, 1:54 AM · Restricted Project
Szelethus added a comment to D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors.

Interesting, I've been watching the bots closely, but got no mail after a while. I'm not sure what the cause is, so I'll revert one-by-one.

Dec 17 2018, 1:51 AM

Dec 16 2018

Szelethus added inline comments to D55730: [analyzer] MoveChecker Pt.9: Add a "peaceful" mode in which it finds only 100% authentic bugs..
Dec 16 2018, 11:11 AM

Dec 15 2018

Szelethus committed rCTE349288: Fix a lit test failure after MallocChecker changes.
Fix a lit test failure after MallocChecker changes
Dec 15 2018, 4:05 PM
Szelethus committed rL349288: Fix a lit test failure after MallocChecker changes.
Fix a lit test failure after MallocChecker changes
Dec 15 2018, 4:03 PM
Szelethus committed rL349283: [analyzer][MallocChecker] Improve warning messages on double-delete errors.
[analyzer][MallocChecker] Improve warning messages on double-delete errors
Dec 15 2018, 10:45 AM
Szelethus committed rC349283: [analyzer][MallocChecker] Improve warning messages on double-delete errors.
[analyzer][MallocChecker] Improve warning messages on double-delete errors
Dec 15 2018, 10:44 AM
Szelethus closed D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors.
Dec 15 2018, 10:44 AM
Szelethus added inline comments to D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors.
Dec 15 2018, 10:41 AM
Szelethus added a comment to D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors.
In D54834#1315475, @NoQ wrote:

Thanks, nice catch!

It seems that the ReportDoubleDelete() thing was never used for reporting double-delete, but it was used for some strange check when a destructor is called.

Dec 15 2018, 10:40 AM
Szelethus committed rC349281: [analyzer][MallocChecker][NFC] Document and reorganize some functions.
[analyzer][MallocChecker][NFC] Document and reorganize some functions
Dec 15 2018, 10:37 AM
Szelethus committed rL349281: [analyzer][MallocChecker][NFC] Document and reorganize some functions.
[analyzer][MallocChecker][NFC] Document and reorganize some functions
Dec 15 2018, 10:37 AM
Szelethus closed D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions.
Dec 15 2018, 10:37 AM
Szelethus added a comment to D55734: [analyzer] Revise GenericTaintChecker's internal representation.

Hmm, I find the revision title and summary a little vague -- I'd expect a revision called "Refactoring" not to feature any funcitonal change, yet you changed how variadic functions are handled. Please

  • Keep purely formatting changes to your earlier revision, and rebase this patch on that
  • Edit the revision title and/or summary about what your patch does,
  • If it features any change in the checker's behavior, include tests.
Dec 15 2018, 10:30 AM
Szelethus committed rC349280: [analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry.
[analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry
Dec 15 2018, 10:15 AM
Szelethus committed rL349280: [analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry.
[analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry
Dec 15 2018, 10:15 AM
Szelethus closed D54437: [analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry.
Dec 15 2018, 10:15 AM
Szelethus committed rC349279: Link examples/clang-interpreter against clangSerialization.
Link examples/clang-interpreter against clangSerialization
Dec 15 2018, 10:07 AM
Szelethus committed rL349279: Link examples/clang-interpreter against clangSerialization.
Link examples/clang-interpreter against clangSerialization
Dec 15 2018, 10:06 AM
Szelethus committed rL349278: Fix a compilation error in examples/.
Fix a compilation error in examples/
Dec 15 2018, 9:16 AM
Szelethus committed rC349278: Fix a compilation error in examples/.
Fix a compilation error in examples/
Dec 15 2018, 9:16 AM
Szelethus committed rC349275: [analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend.
[analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend
Dec 15 2018, 8:28 AM
Szelethus committed rL349275: [analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend.
[analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend
Dec 15 2018, 8:27 AM
Szelethus closed D54436: [analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend.
Dec 15 2018, 8:27 AM
Szelethus closed D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp.

Commited in rC349274.

Dec 15 2018, 8:25 AM
Szelethus committed rC349274: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp.
[analyzer] Prefer returns values to out-params in CheckerRegistry.cpp
Dec 15 2018, 7:47 AM
Szelethus committed rL349274: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp.
[analyzer] Prefer returns values to out-params in CheckerRegistry.cpp
Dec 15 2018, 7:47 AM
Szelethus accepted D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp.

Hmm, actually, if you're doing changes all over the file in the followup patches, it shouldn't matter much. Let's just wait a couple days for ppl to object, now that they are subscribed.

Dec 15 2018, 3:19 AM · Restricted Project
Szelethus added a comment to D54429: [analyzer] Creating standard Sphinx documentation.

That I think sounds great! Thanks!

Dec 15 2018, 3:02 AM · Restricted Project
Szelethus added inline comments to D55734: [analyzer] Revise GenericTaintChecker's internal representation.
Dec 15 2018, 2:57 AM
Szelethus added inline comments to D55730: [analyzer] MoveChecker Pt.9: Add a "peaceful" mode in which it finds only 100% authentic bugs..
Dec 15 2018, 2:49 AM
Szelethus added a comment to D54811: [analyzer] Remove GDM checking from the ConditionBRVisitor.

I guess we used to have something that would result in an event duplication (which was the motivation for this patch), but it's long forgotten.

Dec 15 2018, 2:43 AM · Restricted Project
Szelethus accepted D55683: [analyzer] Tests for scan-build?.

I don't really use scan-build, so I can't barrage you with suggestions, but the patch looks great.

Dec 15 2018, 2:38 AM
Szelethus added a comment to D54918: [analyzer] Apply clang-format to GenericTaintChecker.cpp.

Please don't mind me intruding.
If you create a patch for the Clang Static Analyzer, please add "[analyzer]" in the revision title, because many of us are automatically subscribed to those patches. Also, upload patches with full context.
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Dec 15 2018, 2:30 AM · Restricted Project