Page MenuHomePhabricator

Szelethus (Kristóf Umann)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2017, 6:59 AM (108 w, 4 d)

Recent Activity

Today

Szelethus added a comment to D62899: [analyzer][UninitializedObjectChecker] Mark uninitialized regions as interesting..
In D62899#1551312, @NoQ wrote:

Added a proper testfile. The only downside of it is that it doesn't test anything.

Use creduce!

Sun, Aug 18, 5:21 PM · Restricted Project
Szelethus edited reviewers for D66404: [CFG] Make destructor calls more accurate, added: NoQ; removed: dergachev.a.
Sun, Aug 18, 4:34 PM · Restricted Project
Szelethus accepted D64274: [analyzer] VirtualCallChecker overhaul..

Thank you, and sorry for dragging you through this! At the very least, we got to learn a lot from it :)

Sun, Aug 18, 3:35 PM · Restricted Project

Yesterday

Szelethus added a parent revision for D66381: [analyzer] Enable control dependency condition tracking by default: D66131: [analyzer] Don't track the condition of foreach loops.
Sat, Aug 17, 10:24 AM · Restricted Project
Szelethus added a child revision for D66131: [analyzer] Don't track the condition of foreach loops: D66381: [analyzer] Enable control dependency condition tracking by default.
Sat, Aug 17, 10:24 AM · Restricted Project
Szelethus created D66381: [analyzer] Enable control dependency condition tracking by default.
Sat, Aug 17, 10:24 AM · Restricted Project
Szelethus added inline comments to D65287: [analyzer][CFG] Don't track the condition of asserts.
Sat, Aug 17, 10:06 AM · Restricted Project, Restricted Project
Szelethus committed rG032e1fdcd47e: [analyzer] Turn an assert into an if condition (authored by Szelethus).
[analyzer] Turn an assert into an if condition
Sat, Aug 17, 9:55 AM
Szelethus committed rL369195: [analyzer] Turn an assert into an if condition.
[analyzer] Turn an assert into an if condition
Sat, Aug 17, 9:55 AM

Fri, Aug 16

Szelethus added a comment to D65453: [analyzer] Improve the accuracy of the Clang call graph analysis.

I hope you dont mind me changing the revision title -- many of us are subscribed to the "analyzer" tag and like learning about whats changing :)

Fri, Aug 16, 1:43 PM · Restricted Project
Szelethus retitled D65453: [analyzer] Improve the accuracy of the Clang call graph analysis from Improve the accuracy of the Clang call graph analysis to [analyzer] Improve the accuracy of the Clang call graph analysis.
Fri, Aug 16, 1:41 PM · Restricted Project
Szelethus added a comment to D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message.

I really like the change, thanks! Let's settle on the diagnostic message then.

Fri, Aug 16, 5:45 AM · Restricted Project

Thu, Aug 15

Szelethus added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

You seem to have diffed against your latest local commit, rather than against trunk (or master, if you use the monorepo). Phabricator isn't smart enough to put two and two together, and only displays the uploaded diff (though one has to admit, its doing a damn good job at that at least!).

Thu, Aug 15, 5:23 PM · Restricted Project
Szelethus added inline comments to D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values.
Thu, Aug 15, 4:45 PM · Restricted Project
Szelethus added a comment to D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values.
In D66267#1632164, @NoQ wrote:

Shouldn't we just delete this entire visitor altogether and merge it into ConditionBRVisitor (like, eventually, not right now)? It seems to be a relic of the past.

I'm actually curious about one particular mess that we have here. Namely, there's a visitor that says "assuming..." and there's checker notes when checkers themselves assume something; how can we be sure they don't duplicate each other?

Thu, Aug 15, 3:43 PM · Restricted Project
Szelethus added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

Oh, there is no need for a new differential, you can update this one by clicking on 'update diff' in the right panel.

Thu, Aug 15, 9:44 AM · Restricted Project
Szelethus added a comment to D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

Yup, you can upload it and the green checkmark will stay. If it doesn't, I'll accept again.

Thu, Aug 15, 9:44 AM · Restricted Project
Szelethus committed rGa1aef90bdd9a: [analyzer] Warn about -analyzer-configs being meant for development purposes… (authored by Szelethus).
[analyzer] Warn about -analyzer-configs being meant for development purposes…
Thu, Aug 15, 1:57 AM
Szelethus committed rGe6e133b70076: [analyzer] Add docs for cplusplus.InnerPointer (authored by Szelethus).
[analyzer] Add docs for cplusplus.InnerPointer
Thu, Aug 15, 1:53 AM
Szelethus committed rL368980: [analyzer] Warn about -analyzer-configs being meant for development purposes….
[analyzer] Warn about -analyzer-configs being meant for development purposes…
Thu, Aug 15, 1:53 AM
Szelethus closed D66261: [analyzer] Warn about -analyzer-configs being meant for development purposes only.
Thu, Aug 15, 1:53 AM · Restricted Project, Restricted Project
Szelethus committed rL368979: [analyzer] Add docs for cplusplus.InnerPointer.
[analyzer] Add docs for cplusplus.InnerPointer
Thu, Aug 15, 1:53 AM
Szelethus closed D60281: [analyzer] Add docs for cplusplus.InnerPointer.
Thu, Aug 15, 1:53 AM · Restricted Project, Restricted Project

Wed, Aug 14

Szelethus added a comment to D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values.

Shouldn't we just delete this entire visitor altogether and merge it into ConditionBRVisitor (like, eventually, not right now)? It seems to be a relic of the past.

Wed, Aug 14, 6:10 PM · Restricted Project
Szelethus accepted D66265: [NFCI] Always initialize BugReport const fields.

LGTM, thanks!

Wed, Aug 14, 5:35 PM · Restricted Project, Restricted Project
Szelethus added a comment to D60281: [analyzer] Add docs for cplusplus.InnerPointer.
In D60281#1630646, @NoQ wrote:

Thanks!

One more quick question: Who is Husi???

Wed, Aug 14, 5:21 PM · Restricted Project, Restricted Project
Szelethus updated the diff for D60281: [analyzer] Add docs for cplusplus.InnerPointer.

Fixed!

Wed, Aug 14, 5:06 PM · Restricted Project, Restricted Project
Szelethus created D66261: [analyzer] Warn about -analyzer-configs being meant for development purposes only.
Wed, Aug 14, 5:04 PM · Restricted Project, Restricted Project
Szelethus updated the diff for D60281: [analyzer] Add docs for cplusplus.InnerPointer.

Revised the documentation according to @NoQ's comments. By literally copy pasting it. Like any good programmer should do :^)

Wed, Aug 14, 4:29 PM · Restricted Project, Restricted Project
Szelethus accepted D65182: [analyzer] Add fix-it hint support..
In D65182#1630540, @NoQ wrote:

Hmm, why the need for checker options? Why not have them by default? If fixits are an experimental feature, maybe we should have a global enable-fixits config. But I don't insist :)

I did this because fixits have a much higher quality standard that warnings (because people often apply them blindly). This means that fixit support is likely to be lagging behind in meeting the quality standards and therefore it's important to allow some (but not necessarily all) on-by-default checkers have alpha fixits.

Wed, Aug 14, 4:15 PM · Restricted Project
Szelethus added a comment to D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value.
In D63279#1630491, @NoQ wrote:

the only reason it's not enabled by default yet is because we forgot to do that :(

Wed, Aug 14, 3:41 PM · Restricted Project
Szelethus added a comment to D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value.

For me it is all the same whether to continue this patch or taking over Péter's.

Wed, Aug 14, 2:52 PM · Restricted Project
Szelethus commandeered D60281: [analyzer] Add docs for cplusplus.InnerPointer.

I'll gladly add the finishing touches :)

Wed, Aug 14, 2:36 PM · Restricted Project, Restricted Project
Szelethus added a comment to D65361: [analyzer] Trust global initializers when analyzing main()..

I really like the high level idea proposed by this patch, and the test files make me believe that its correct as well! I'm really not familiar around this part of the code, so if its okay, I'll take my time to do the usual find references, inserting unreachables/asserts to gain a better understanding before the green checkmark.

Wed, Aug 14, 2:19 PM · Restricted Project
Szelethus added inline comments to D65182: [analyzer] Add fix-it hint support..
Wed, Aug 14, 2:05 PM · Restricted Project
Szelethus added inline comments to D66042: [analyzer] Analysis: Silence checkers.
Wed, Aug 14, 1:51 PM · Restricted Project, Restricted Project
Szelethus added inline comments to D66042: [analyzer] Analysis: Silence checkers.
Wed, Aug 14, 1:49 PM · Restricted Project, Restricted Project
Szelethus added a comment to D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling.

I agree with @gamesh411 here, would it be much trouble to see how this behaves on a bigger codebase?

Wed, Aug 14, 12:46 PM · Restricted Project
Szelethus added a comment to D65065: [clang-tidy] Possibility of displaying duplicate warnings.

I have no authority to accept patches in clang-tidy (though please feel free to add me as a reviewer, I can more easily participate in the discussion!), but in any case, this looks good to me too, thanks!

Wed, Aug 14, 12:25 PM · Restricted Project
Szelethus added inline comments to D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field.
Wed, Aug 14, 12:16 PM · Restricted Project
Szelethus added inline comments to D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field.
Wed, Aug 14, 12:15 PM · Restricted Project
Szelethus updated the diff for D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field.
  • Make the generic messages in-class, constexpr fields.
  • Provide plenty of test cases for captured lambda variables. In our meeting we had both had a sight of relief, and some still lingering concerns about this, so maybe it deserves fixing in the long term.
Wed, Aug 14, 12:15 PM · Restricted Project
Szelethus added inline comments to D66042: [analyzer] Analysis: Silence checkers.
Wed, Aug 14, 12:07 PM · Restricted Project, Restricted Project
Szelethus accepted D66042: [analyzer] Analysis: Silence checkers.

You know what, I argued that we should use configs because this flag is incomplete. So I shouldn't be all up and down that it isn't.

Wed, Aug 14, 12:06 PM · Restricted Project, Restricted Project
Szelethus added inline comments to D66042: [analyzer] Analysis: Silence checkers.
Wed, Aug 14, 12:02 PM · Restricted Project, Restricted Project
Szelethus added inline comments to D66042: [analyzer] Analysis: Silence checkers.
Wed, Aug 14, 12:00 PM · Restricted Project, Restricted Project
Szelethus added a comment to D66042: [analyzer] Analysis: Silence checkers.

I swear this is my last objection :) As soon as this is settled, I'll accept.

Wed, Aug 14, 11:49 AM · Restricted Project, Restricted Project
Szelethus added a comment to D66042: [analyzer] Analysis: Silence checkers.

Now that I had ever more time to think about this patch, I see a great potential in it for development use, for example, we could silence a checker before splitting it up to see whether we could disable it altogether or really having to go through the process of splitting it into a modeling and reporting portion.

Wed, Aug 14, 10:49 AM · Restricted Project, Restricted Project
Szelethus committed rG92541e359e4b: [CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock (authored by Szelethus).
[CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock
Wed, Aug 14, 10:09 AM
Szelethus committed rL368883: [CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock.
[CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock
Wed, Aug 14, 10:05 AM
Szelethus closed D65196: [CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock.
Wed, Aug 14, 10:05 AM · Restricted Project, Restricted Project
Szelethus added inline comments to D66042: [analyzer] Analysis: Silence checkers.
Wed, Aug 14, 7:34 AM · Restricted Project, Restricted Project
Szelethus added inline comments to D66042: [analyzer] Analysis: Silence checkers.
Wed, Aug 14, 7:18 AM · Restricted Project, Restricted Project
Szelethus added a comment to D66042: [analyzer] Analysis: Silence checkers.

Thanks!!! Please note that BugReporter.cpp (especially the parts you touched) just got refactored extensively, so you'll need to rebase on master.

Wed, Aug 14, 7:16 AM · Restricted Project, Restricted Project
Szelethus committed rG571c52af58d9: [analyzer][NFC] Prove that we only track the evaluated part of the condition (authored by Szelethus).
[analyzer][NFC] Prove that we only track the evaluated part of the condition
Wed, Aug 14, 6:52 AM
Szelethus committed rL368853: [analyzer][NFC] Prove that we only track the evaluated part of the condition.
[analyzer][NFC] Prove that we only track the evaluated part of the condition
Wed, Aug 14, 6:52 AM
Szelethus closed D65290: [analyzer][NFC] Prove that we only track the evaluated part of the condition.
Wed, Aug 14, 6:52 AM · Restricted Project, Restricted Project
Szelethus accepted D65182: [analyzer] Add fix-it hint support..

Hmm, why the need for checker options? Why not have them by default? If fixits are an experimental feature, maybe we should have a global enable-fixits config maybe. But I don't insist :)

Wed, Aug 14, 6:29 AM · Restricted Project
Szelethus committed rGdd53bdbfdec7: [analyzer][CFG] Don't track the condition of asserts (authored by Szelethus).
[analyzer][CFG] Don't track the condition of asserts
Wed, Aug 14, 5:22 AM
Szelethus committed rL368836: [analyzer][CFG] Don't track the condition of asserts.
[analyzer][CFG] Don't track the condition of asserts
Wed, Aug 14, 5:21 AM
Szelethus closed D65287: [analyzer][CFG] Don't track the condition of asserts.
Wed, Aug 14, 5:21 AM · Restricted Project, Restricted Project
Szelethus added a comment to D66042: [analyzer] Analysis: Silence checkers.
In D66042#1627760, @NoQ wrote:

But without this patch clang seems to have the same two ANALYZE log lines regardless of whether I enable core checkers or not

Yup, it seems as if clang-tidy enables core as long as at least one Static Analyzer checker is enabled (even if it's path-insensitive).

It would be nice, if Static Analyzer would hide this from the users completely. The user would specify the list of checkers they need and CSA would enable whatever additional checkers it needs (if any) and then filter out their results. Is it feasible?

Wed, Aug 14, 4:16 AM · Restricted Project, Restricted Project
Szelethus committed rG967583bc087c: [analyzer] Note last writes to a condition only in a nested stackframe (authored by Szelethus).
[analyzer] Note last writes to a condition only in a nested stackframe
Wed, Aug 14, 2:42 AM
Szelethus committed rL368817: [analyzer] Note last writes to a condition only in a nested stackframe.
[analyzer] Note last writes to a condition only in a nested stackframe
Wed, Aug 14, 2:39 AM
Szelethus closed D64272: [analyzer] Note last writes to a condition only in a nested stackframe.
Wed, Aug 14, 2:39 AM · Restricted Project, Restricted Project

Tue, Aug 13

Szelethus accepted D66192: [analyzer] Don't delete TaintConfig copy constructor.

This really shouldn't matter much. Go for it!

Tue, Aug 13, 6:02 PM · Restricted Project, Restricted Project
Szelethus committed rG3f7c66d551ef: [analyzer][NFC] Prepare visitors for different tracking kinds (authored by Szelethus).
[analyzer][NFC] Prepare visitors for different tracking kinds
Tue, Aug 13, 5:53 PM
Szelethus committed rL368777: [analyzer][NFC] Prepare visitors for different tracking kinds.
[analyzer][NFC] Prepare visitors for different tracking kinds
Tue, Aug 13, 5:48 PM
Szelethus closed D64270: [analyzer][NFC] Prepare visitors for different tracking kinds.
Tue, Aug 13, 5:48 PM · Restricted Project, Restricted Project
Szelethus added a comment to D65287: [analyzer][CFG] Don't track the condition of asserts.

If you have no major objections, could you please accept formally? :)

Tue, Aug 13, 5:48 PM · Restricted Project, Restricted Project
Szelethus committed rG0df9c8c57802: [analyzer] Track the right hand side of the last store regardless of its value (authored by Szelethus).
[analyzer] Track the right hand side of the last store regardless of its value
Tue, Aug 13, 4:50 PM
Szelethus committed rL368773: [analyzer] Track the right hand side of the last store regardless of its value.
[analyzer] Track the right hand side of the last store regardless of its value
Tue, Aug 13, 4:49 PM
Szelethus closed D64287: [analyzer] Track the right hand side of the last store regardless of its value.
Tue, Aug 13, 4:49 PM · Restricted Project
Szelethus committed rG46929df72333: [analyzer] Prune calls to functions with linear CFGs that return a non-zero… (authored by Szelethus).
[analyzer] Prune calls to functions with linear CFGs that return a non-zero…
Tue, Aug 13, 4:23 PM
Szelethus committed rL368771: [analyzer] Prune calls to functions with linear CFGs that return a non-zero….
[analyzer] Prune calls to functions with linear CFGs that return a non-zero…
Tue, Aug 13, 4:21 PM
Szelethus closed D64232: [analyzer] Prune calls to functions with linear CFGs that return a non-zero constrained value.
Tue, Aug 13, 4:21 PM · Restricted Project, Restricted Project
Szelethus committed rGe1117addd664: [analyzer][NFC] Make sure that the BugReport is not modified during the… (authored by Szelethus).
[analyzer][NFC] Make sure that the BugReport is not modified during the…
Tue, Aug 13, 3:05 PM
Szelethus committed rL368755: [analyzer][NFC] Make sure that the BugReport is not modified during the….
[analyzer][NFC] Make sure that the BugReport is not modified during the…
Tue, Aug 13, 3:05 PM
Szelethus closed D65578: [analyzer][NFC] Make sure that the BugReport is not modified during the construction of non-visitor pieces.
Tue, Aug 13, 3:05 PM · Restricted Project, Restricted Project
Szelethus committed rG6c1b19ac9e85: [analyzer][NFC] Refactoring BugReporter.cpp P6.: Completely get rid of… (authored by Szelethus).
[analyzer][NFC] Refactoring BugReporter.cpp P6.: Completely get rid of…
Tue, Aug 13, 2:48 PM
Szelethus committed rL368752: [analyzer][NFC] Refactoring BugReporter.cpp P6.: Completely get rid of….
[analyzer][NFC] Refactoring BugReporter.cpp P6.: Completely get rid of…
Tue, Aug 13, 2:47 PM
Szelethus closed D65487: [analyzer][NFC] Refactoring BugReporter.cpp P6.: Completely get rid of interestingness propagation.
Tue, Aug 13, 2:47 PM · Restricted Project, Restricted Project
Szelethus added a comment to D66042: [analyzer] Analysis: Silence checkers.

Any analyzer config flag is equally accessible to anyone as the driver flags as they are both flags. The only difference is the config flags are more code to implement, and a lot more difficult to use. @NoQ, why the hell would we pick another type of flag which makes zero improvement? The goal is to introduce the best possible solution, which is already here.

Tue, Aug 13, 2:41 PM · Restricted Project, Restricted Project
Szelethus accepted D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts.

LGTM, thanks! Do you need someone to commit this on your behalf? Also, could you please make the comments capitalized, terminated, and fitting in 80 columns?

Tue, Aug 13, 2:04 PM · Restricted Project
Szelethus added a comment to D61027: Fix crash on switch conditions of non-integer types in templates.

Like @riccibruno said, check-clang-tools will run them. However, before committing a patch, please run check-all -- you never know what your patch can affect.

Tue, Aug 13, 1:50 PM · Restricted Project
Szelethus committed rGedb788592d56: [analyzer][NFC] Address inlines of D65484 (authored by Szelethus).
[analyzer][NFC] Address inlines of D65484
Tue, Aug 13, 1:43 PM
Szelethus committed rL368745: [analyzer][NFC] Address inlines of D65484.
[analyzer][NFC] Address inlines of D65484
Tue, Aug 13, 1:42 PM
Szelethus closed D65484: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects.

The deed is done.

Tue, Aug 13, 1:42 PM · Restricted Project, Restricted Project
Szelethus added a comment to D66042: [analyzer] Analysis: Silence checkers.

We might also want to change the revision title, but the commit message for sure, to make it clear that this affects all checkers, something along the lines of "[analyzer] Add an analyzer config to silence diagnostics from user specified checkers/packages"

Tue, Aug 13, 1:38 PM · Restricted Project, Restricted Project
Szelethus added a comment to D66042: [analyzer] Analysis: Silence checkers.
In D66042#1627765, @NoQ wrote:

I really appreacite your ideas. It is unbelievable you guys bring up 20 different ideas for 5 LOC. I cannot really argue about any idea, as every of them could be a possible solution. I have to pick the right solution, and drop the other 19. I believe with that in mind what is an experimental feature and how we support to use the Analyzer, none of the 19 ideas would born. I did not want to refuse that many ideas, but I have to, because we could pick at most 1 to implement per patch. That is why I really try to emphasize it is under that experimental feature umbrella and we have to think no more about that patch from that point: since the beginning.

Given our discussion, we've thrown out all but 1 of the 4, by the way (fixing the actual problem, making this a config, creating checker/package options, solving this in scan-build only), ideas. Make this a config. You're correct, thats about 5 LOC change in this patch, at which point I'd be happy to accept :)

You mean something like -analyzer-config silence-checkers=core.DivideZero? I guess we can do that, right?

Tue, Aug 13, 1:34 PM · Restricted Project, Restricted Project
Szelethus reopened D65484: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects.

Oh, crap, forgot to address inlines. I'll see how buildbots react to these changes and will follow up in a smaller patch. Reopening as a reminder.

Tue, Aug 13, 12:11 PM · Restricted Project, Restricted Project
Szelethus committed rGf9d75bede84e: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function… (authored by Szelethus).
[analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function…
Tue, Aug 13, 12:03 PM
Szelethus committed rL368737: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function….
[analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function…
Tue, Aug 13, 12:03 PM
Szelethus closed D65484: [analyzer][NFC] Refactoring BugReporter.cpp P5.: Compact mile long function invocations into objects.
Tue, Aug 13, 12:02 PM · Restricted Project, Restricted Project
Szelethus committed rGfc76d8551f54: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it… (authored by Szelethus).
[analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it…
Tue, Aug 13, 11:48 AM
Szelethus committed rL368735: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it….
[analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it…
Tue, Aug 13, 11:48 AM
Szelethus closed D65382: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it const.
Tue, Aug 13, 11:48 AM · Restricted Project, Restricted Project
Szelethus added a comment to D66152: Fix false negatives of statement local lifetime analysis for some STL implementation.

Apologies for going off-topic, but would it make sense to start lifetime related patches with the tag [LifetimeAnalysis] or similar (like [analyzer] for static analyzer patches)? I dont feel knowledgable enough to participate, but would gladly add a herald rule to be subscribed and learn about the development process of it.

Tue, Aug 13, 11:05 AM · Restricted Project, Restricted Project
Szelethus committed rG6d716ef1814b: [analyzer][NFC] Refactoring BugReporter.cpp P3.: std… (authored by Szelethus).
[analyzer][NFC] Refactoring BugReporter.cpp P3.: std…
Tue, Aug 13, 9:47 AM
Szelethus committed rL368717: [analyzer][NFC] Refactoring BugReporter.cpp P3.: std….
[analyzer][NFC] Refactoring BugReporter.cpp P3.: std…
Tue, Aug 13, 9:47 AM