Page MenuHomePhabricator

Szelethus (Kristóf Umann)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2017, 6:59 AM (131 w, 6 d)

Recent Activity

Dec 23 2019

Szelethus accepted D71791: [CFG] Fix an assertion failure with static initializers.

I decided to fix the unittests. Having CFGs full of dangling pointers to the AST does not look fun at all, so I think this change was long overdue.

Dec 23 2019, 2:51 PM · Restricted Project

Dec 21 2019

Szelethus added a comment to D71791: [CFG] Fix an assertion failure with static initializers.

I am not sure what would be the best way to test this change here.

Dec 21 2019, 3:41 PM · Restricted Project

Nov 21 2019

Szelethus accepted D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools.

For reasons other than being a part of the project, CodeChecker is objectively an amazing tool to use with the analyzer. LGTM!

Nov 21 2019, 2:20 AM · Restricted Project

Nov 14 2019

Szelethus added a comment to D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition()..
In D69962#1744679, @NoQ wrote:

Try to add a non-sanitizer built tablegen: -DCLANG_TABLEGEN=/path/to/non/sanitized/clang-tblgen -DLLVM_TABLEGEN=/path/to/non/sanitized/llvm-tblgen

Yay nice! The clang that i built this way is still unusable though, i.e. crashes on almost all tests :( I guess i'm doing something wrong.

I'd like to commit the test as is and then keep looking for the solution in the background.

Nov 14 2019, 12:32 AM · Restricted Project

Nov 12 2019

Szelethus added a comment to D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition()..

Accepted accidentally. Well, in any case, I trust your judgement on this! I'd prefer not to commit the test file as-is.

Nov 12 2019, 7:22 AM · Restricted Project
Szelethus accepted D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition()..
In D69962#1741503, @NoQ wrote:
In D69962#1739440, @NoQ wrote:

Nice catch! Though, wouldn't the memory sanitizer buildbots break on this reliably?

I kinda hope so; i'll take a look at home.

Memory sanitizer at home: *fails with 1700 uninitialized reads in TableGen*.

Nov 12 2019, 7:22 AM · Restricted Project
Szelethus accepted D70047: [Analyzer] Use a reference in a range-based for.

Whoo!

Nov 12 2019, 7:22 AM · Restricted Project

Nov 8 2019

Szelethus accepted D59516: [analyzer] Add custom filter functions for GenericTaintChecker.

LGTM, provided that the inlines are addressed! Thanks!

Nov 8 2019, 5:31 AM · Restricted Project
Szelethus added inline comments to D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition()..
Nov 8 2019, 5:19 AM · Restricted Project
Szelethus added a comment to D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition()..

Nice catch! Though, wouldn't the memory sanitizer buildbots break on this reliably?

Nov 8 2019, 5:00 AM · Restricted Project

Nov 6 2019

Szelethus added a comment to D69813: [analyzer] CERTStrChecker: Model gets().

Hmm, so this checker is rather a collection of CERT rule checkers, right? Shouldn't the checker name contain the actual rule name (STR31-C)? User interfacewise, I would much prefer smaller, leaner checkers than a big one with a lot of options, which are barely supported for end-users. I would expect a cert package to contain subpackages like cert.str, and checker names cert.str.31StringSize, or similar.

It is the STR rules of CERT, nothing else. Most of the rules are tied together, and that is why the checker needs to be designed as one checker at first. I am not sure which part of the STR I will cover, so may when the checker evolves and some functions does not need the same helper methods we need to create new checkers. STR31 and STR32 are my projects which is like one single project. Also I did not except the users to specify the rule number, but this checker could be something like cert.str.Termination. There is two floating-point CERT checkers inside the insecureAPI that is why I have introduced the cert package, which will have three members, one is that new checker. I think a new package is only necessary if it contains at least two checkers.

Nov 6 2019, 10:09 AM · Restricted Project

Nov 5 2019

Szelethus added a comment to D69813: [analyzer] CERTStrChecker: Model gets().

Hmm, so this checker is rather a collection of CERT rule checkers, right? Shouldn't the checker name contain the actual rule name (STR31-C)? User interfacewise, I would much prefer smaller, leaner checkers than a big one with a lot of options, which are barely supported for end-users. I would expect a cert package to contain subpackages like cert.str, and checker names cert.str.31StringSize, or similar. Also, shouldn't we move related checkers from security.insecureAPI to cert? Or just mention the rule name in the description, and continue not having a cert package?

Nov 5 2019, 9:42 AM · Restricted Project

Nov 4 2019

Szelethus added inline comments to D69745: [analyzer] Checker: check::BeginAnalysis.
Nov 4 2019, 6:05 AM · Restricted Project
Szelethus added a comment to D69745: [analyzer] Checker: check::BeginAnalysis.

YES PLEASE. Debug checkers that only dump from check::EndAnalysis won't rely on the analysis not actually crashing. Which is ironically exactly when we want to use them.

Nov 4 2019, 6:05 AM · Restricted Project
Szelethus added a comment to D69726: [analyzer] DynamicSize: Store the dynamic size.

Changes to MallocChecker really highlight the positive effects of this patch. Nice!

Nov 4 2019, 5:49 AM · Restricted Project
Szelethus added a comment to D69662: [Checkers] Avoid using evalCall in StreamChecker..

I wanted to remove eval::Call because only one checker can do this otherwise it is undefined behavior (according to the not very new "Analyzer Guide"). If it is essentially needed in this checker it will remain.

Nov 4 2019, 5:42 AM · Restricted Project

Oct 30 2019

Szelethus accepted D67706: [clang][analyzer] Using CallDescription in StreamChecker..

Let's make it 3! Thank you so much for sticking by, I guess one of the reasons why a patch so obviously great and desired took so long is that we still didn't figure out how we imagine the CallDescriptionMap to be integrated into larger checkers :) In any case, this is a major step in the right direction, MallocChecker and some of the others should take notes.

Oct 30 2019, 6:39 PM · Restricted Project
Szelethus accepted D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer .
Oct 30 2019, 8:06 AM · Restricted Project
Szelethus resigned from D65912: [clang-tidy] Add new check for math constants.

I have no authority in clang-tidy, but the idea is nice! You may wanna reupload with full context though.

Oct 30 2019, 8:06 AM · Restricted Project, Restricted Project
Szelethus added a comment to D69308: [analyzer] Test cases for the unsupported features for Clang Static Analyzer .

LGTM given that the inlines are fixed.

Oct 30 2019, 8:06 AM · Restricted Project
Szelethus added a comment to D67706: [clang][analyzer] Using CallDescription in StreamChecker..

Its becoming a bit difficult to navigate inlines, could you please mark them as done as you address them?

Oct 30 2019, 7:56 AM · Restricted Project
Szelethus accepted D69602: [analyzer] Test case for lambda capture by value modelling.

LGTM, can we remove the open projects entry under the same breath?

Oct 30 2019, 7:49 AM · Restricted Project

Oct 22 2019

Szelethus added a reviewer for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker: NoQ.
Oct 22 2019, 9:09 PM · Restricted Project
Szelethus added reviewers for D69318: [analyzer] Add SufficientSizeArrayIndexingChecker: baloghadamsoftware, xazax.hun, rnkovacs, Charusso, dcoughlin.

Please feel free to add more reviewers.

Oct 22 2019, 9:09 PM · Restricted Project

Oct 14 2019

Szelethus added a comment to D66733: [analyzer] Add a checker option to detect nested dead stores.

I added it to the release notes here : https://reviews.llvm.org/rC374593
I am wondering if the option( WarnForDeadNestedAssignments ) to disable it is really necessary?
I haven't seen any false positive while deadstore has some.

Oct 14 2019, 5:19 AM · Restricted Project, Restricted Project

Oct 11 2019

Szelethus accepted D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection.

This is amazing, thanks!! LGTM.

Oct 11 2019, 8:42 AM · Restricted Project
Szelethus added inline comments to D67706: [clang][analyzer] Using CallDescription in StreamChecker..
Oct 11 2019, 8:04 AM · Restricted Project
Szelethus added a comment to D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters.

I forgot to emphasise that the entire point of the patch was to get rid of getAllocationFamily, at least the way it used to work, because it was a mess and prevented me from moving forward with changing things to a CallDescriptionMap.

Oct 11 2019, 7:27 AM · Restricted Project

Oct 10 2019

Szelethus accepted D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling.
Oct 10 2019, 7:16 AM · Restricted Project

Oct 7 2019

Szelethus created D68591: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor.
Oct 7 2019, 2:07 PM · Restricted Project
Szelethus closed D54834: [analyzer][MallocChecker] Improve warning messages on double-delete errors.
Oct 7 2019, 3:14 AM · Restricted Project

Oct 2 2019

Szelethus updated the diff for D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap.

Rebase.

Oct 2 2019, 3:22 AM · Restricted Project
Szelethus added inline comments to D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap.
Oct 2 2019, 3:22 AM · Restricted Project
Szelethus updated the diff for D68163: [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to CallDescription.

Rebase, unforget to support 3-arg malloc, for which apparently were no tests at all.

Oct 2 2019, 3:14 AM · Restricted Project
Szelethus updated the diff for D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters.

Use regular parameters instead of template parameters.

Oct 2 2019, 2:47 AM · Restricted Project
Szelethus added inline comments to D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap.
Oct 2 2019, 2:39 AM · Restricted Project

Oct 1 2019

Szelethus added a comment to D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters.
In D68162#1686810, @NoQ wrote:

Thank you, fantastic finding!

in fact we know it compile time

Yeah, but is it accidental or is there a good reason behind always having this information at compile time? 'Cause i don't want to restrict the code to always provide this information at compile time if we're not sure it'll always be able to provide it in compile time.

Oct 1 2019, 7:20 AM · Restricted Project
Szelethus added inline comments to D67706: [clang][analyzer] Using CallDescription in StreamChecker..
Oct 1 2019, 7:01 AM · Restricted Project
Szelethus added a comment to D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling.

The logic of the patch is fine in my eyes, but I dislike the formatting. Could you please make the code obey the LLVM coding style, and after that use clang-format-diff.py?
https://llvm.org/docs/CodingStandards.html
https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting

Oct 1 2019, 6:43 AM · Restricted Project
Szelethus added inline comments to D67706: [clang][analyzer] Using CallDescription in StreamChecker..
Oct 1 2019, 6:43 AM · Restricted Project
Szelethus added a comment to D67706: [clang][analyzer] Using CallDescription in StreamChecker..

A few nits inline, otherwise the patch is awesome, thank you!!

Oct 1 2019, 4:12 AM · Restricted Project

Sep 30 2019

Szelethus updated the diff for D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis.

I'm starting to be really happy with the current direction! I think I'll start splitting this up soon, I'm confident that the current interface (after some polishing) is general enough to develop incrementally.

Sep 30 2019, 4:23 PM · Restricted Project

Sep 28 2019

Szelethus added a comment to D68172: Don't install example analyzer plugins.

The patch looks alright, I won't formally accept because if I knew how these worked, it wouldn't have caused so much pain to so many people :)

Sep 28 2019, 4:57 AM · Restricted Project, Restricted Project
Szelethus added inline comments to D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap.
Sep 28 2019, 4:54 AM · Restricted Project
Szelethus added inline comments to D68163: [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to CallDescription.
Sep 28 2019, 2:21 AM · Restricted Project

Sep 27 2019

Szelethus added inline comments to D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap.
Sep 27 2019, 3:25 PM · Restricted Project
Szelethus added a parent revision for D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap: D68163: [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to CallDescription.
Sep 27 2019, 3:22 PM · Restricted Project
Szelethus created D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap.
Sep 27 2019, 3:22 PM · Restricted Project
Szelethus added a child revision for D68163: [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to CallDescription: D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap.
Sep 27 2019, 3:22 PM · Restricted Project
Szelethus added a parent revision for D68163: [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to CallDescription: D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters.
Sep 27 2019, 3:12 PM · Restricted Project
Szelethus added a child revision for D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters: D68163: [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to CallDescription.
Sep 27 2019, 3:12 PM · Restricted Project
Szelethus created D68163: [analyzer][MallocChecker][NFC] Change the use of IdentifierInfo* to CallDescription.
Sep 27 2019, 3:11 PM · Restricted Project
Szelethus created D68162: [analyzer][MallocChecker][NFC] Communicate the allocation family to auxiliary functions with parameters.
Sep 27 2019, 3:11 PM · Restricted Project
Szelethus added a comment to D67706: [clang][analyzer] Using CallDescription in StreamChecker..

It seems like this patch is diffed against your latest commit, not the master branch.

Sep 27 2019, 7:13 AM · Restricted Project

Sep 24 2019

Szelethus added a comment to D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake..

I have no objections on my end.

Sep 24 2019, 7:24 AM · Restricted Project
Szelethus accepted D67932: [analyzer] Fix accidentally skipping the call during inlined defensive check suppression..

If you could change that, it would be awesome! But since this revision has its own side effect, let's commit as-is. LGTM!

Sep 24 2019, 2:00 AM · Restricted Project

Sep 23 2019

Szelethus added a comment to D67932: [analyzer] Fix accidentally skipping the call during inlined defensive check suppression..

Hmm, so before this patch, we just used LVNode everywhere and ignored InputNode. It may not have made much sense, but its still not as confusing as using both if the creation of LVNode is unnecessary overall. Could we just remove it?

Sep 23 2019, 3:30 PM · Restricted Project
Szelethus accepted D67934: [static-analyzer] Remove --analyze-auto.

Never knew about this either, so I'm not gonna miss it. Thanks!

Sep 23 2019, 2:40 PM · Restricted Project
Szelethus added a comment to D67682: [WIP] Add support for preprocessing sources for analyzer.

I really don't think so, but I'll ask around in the office.

Sep 23 2019, 1:47 PM
Szelethus updated the diff for D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis.

The following words are echoing in my ears as I'm knowingly going completely against them:

Sep 23 2019, 11:43 AM · Restricted Project

Sep 21 2019

Szelethus added a comment to D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake..

Apologies for the intrusion, but these plugins were added by me, and test an important case for our internal plugins. Could you please give me just a day or so the check whether the tests work for us correctly?

Sep 21 2019, 9:44 AM · Restricted Project
Szelethus retitled D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake. from Conditionnaly include clang Analysis examples with cmake. to [analyzer] Conditionnaly include clang Analysis examples with cmake..
Sep 21 2019, 9:41 AM · Restricted Project
Szelethus committed rL372462: Attempt to fix a windows buildbot failure.
Attempt to fix a windows buildbot failure
Sep 21 2019, 12:58 AM

Sep 20 2019

Szelethus added a comment to D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions.

Welp, windows builtbots broke again. I'll try to see whats wrong with undef sanitizer, but fear this will end up in a revert.

Sep 20 2019, 12:50 PM · Restricted Project, Restricted Project
Szelethus committed rL372419: Fix a documentation error.
Fix a documentation error
Sep 20 2019, 11:27 AM
Szelethus added inline comments to D67079: [analyzer] CastValueChecker: Model inheritance.
Sep 20 2019, 11:25 AM · Restricted Project
Szelethus committed rL372414: Reland '[analyzer][MallocChecker][NFC] Document and reorganize some functions'.
Reland '[analyzer][MallocChecker][NFC] Document and reorganize some functions'
Sep 20 2019, 11:01 AM
Szelethus closed D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions.
Sep 20 2019, 11:01 AM · Restricted Project, Restricted Project

Sep 19 2019

Szelethus added a comment to D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions.

In retrospect, I would have made this patch a little more fragmented (its almost a year old, does it beat the revival of the symbolreaper patch?), but it would be a painful chore to separate at this point, if you dont mind. I have a couple more cooking in the cauldron that are more digestible, so, lesson learned :)

Sep 19 2019, 1:56 PM · Restricted Project, Restricted Project
Szelethus added a comment to D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions.
In D54823#1675604, @NoQ wrote:

Is it just me or phabricator somehow refuses to display the changes since the last diff here? That's probably the commit diff is involved somehow. So i'm confused what exactly has changed >.<

Sep 19 2019, 1:28 PM · Restricted Project, Restricted Project
Szelethus added a comment to D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions.

Rebase, fix (suspected) error that caused buildbot errors. Hold off commiting in favor checking whether putting CallDescriptionMap in would be too invasive, but really, can't be worse then it already is.

Sep 19 2019, 11:33 AM · Restricted Project, Restricted Project
Szelethus set the repository for D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions to rG LLVM Github Monorepo.
Sep 19 2019, 8:36 AM · Restricted Project, Restricted Project
Szelethus updated the diff for D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions.

Rebase, fix (suspected) error that caused buildbot errors. Hold off commiting in favor checking whether putting CallDescriptionMap in would be too invasive, but really, can't be worse then it already is.

Sep 19 2019, 8:36 AM · Restricted Project, Restricted Project
Herald added a project to D54823: [analyzer][MallocChecker][NFC] Document and reorganize some functions: Restricted Project.
Sep 19 2019, 7:51 AM · Restricted Project, Restricted Project

Sep 18 2019

Szelethus added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

We have no solid evidence to conclude that such an event should not occur at a BlockEntrance, so fixing this error mustn't be that bad. I certainly should've used llvm::isa_or_nonnull, so the patch overall makes sense, so I'm commiting it as is. With that said, this test case highlights a fundamental flaw in how loop wideining is implemented (hence it being off-by-default), and it should be addressed later separately.

Sep 18 2019, 3:31 PM · Restricted Project, Restricted Project
Szelethus committed rL372269: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic….
[analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic…
Sep 18 2019, 3:23 PM
Szelethus closed D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.
Sep 18 2019, 3:23 PM · Restricted Project, Restricted Project
Szelethus retitled D67706: [clang][analyzer] Using CallDescription in StreamChecker. from [clang][checkers] Using CallDescription in StreamChecker. to [clang][analyzer] Using CallDescription in StreamChecker..
Sep 18 2019, 9:57 AM · Restricted Project

Sep 17 2019

Szelethus edited reviewers for D67682: [WIP] Add support for preprocessing sources for analyzer, added: NoQ; removed: dergachev.a.
Sep 17 2019, 6:04 PM

Sep 16 2019

Szelethus added reviewers for D67545: [clang-tidy] Added DefaultOperatorNewCheck.: aaron.ballman, alexfh, JonasToth, lebedev.ri.
Sep 16 2019, 7:37 AM · Restricted Project
Szelethus added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

While we're there, could you please see whether the included test case (note how condition tracking is turned off) fails on your platform without the rest of the patch applied (it definitely does on mine, which is why I was surprised to see this bug report pop up only now)? If not, I can just push a small commit with the llvm::isa_and_nonnull change to get some breathing room.

Sep 16 2019, 5:23 AM · Restricted Project, Restricted Project
Szelethus added a comment to D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction.

Hi there,

just checking in, is this patch still going ahead?

thanks
Tom W

Sep 16 2019, 5:20 AM · Restricted Project, Restricted Project

Sep 15 2019

Szelethus added inline comments to D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions..
Sep 15 2019, 8:00 AM · Restricted Project

Sep 14 2019

Szelethus added a comment to D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions..

Aha, so every user gets to create their own PathDiagnosticConsumerOptions object, makes sense! There is no interface misconception, because -analyzer-config will only configure what the analyzer would tinket with. I like this patch! If you dont mind, I'd prefer to have one last round with this, but otherwise LGTM.

Sep 14 2019, 9:42 AM · Restricted Project

Sep 12 2019

Szelethus added a comment to D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks".

Yes, thank you! I've been keeping my mailbox open and commiting slowly, it seems like the buildbots have a wrong email address set up for me.

Sep 12 2019, 2:33 PM · Restricted Project, Restricted Project
Szelethus added a comment to D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions..
In D67420#1668474, @NoQ wrote:

It's not that AnalyzerOptions is necessary to construct this, it's more like sufficient.

Sep 12 2019, 2:25 PM · Restricted Project
Szelethus committed rL371765: [CFG] Add dumps for CFGElement and CFGElementRef.
[CFG] Add dumps for CFGElement and CFGElementRef
Sep 12 2019, 12:52 PM
Szelethus closed D66715: [CFG] Add dumps for CFGElement and CFGElementRef.
Sep 12 2019, 12:51 PM · Restricted Project, Restricted Project
Szelethus committed rL371760: [analyzer][NFC] Fix inconsistent references to checkers as "checks".
[analyzer][NFC] Fix inconsistent references to checkers as "checks"
Sep 12 2019, 12:11 PM
Szelethus closed D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks".
Sep 12 2019, 12:11 PM · Restricted Project, Restricted Project
Szelethus committed rL371756: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers.
[analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers
Sep 12 2019, 11:55 AM
Szelethus closed D66714: [analyzer] Don't run the analyzer for -analyzer-list-enabled-checkers.
Sep 12 2019, 11:54 AM · Restricted Project, Restricted Project
Szelethus added a comment to D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions..
In D67420#1666578, @NoQ wrote:

I do!

Hmm, it sounds like you want to force both Clang frontend and Clang-Tidy to use the same set of flags to control these options (?) Much like -analyzer-config, these flags will have different "style" compared to other flags in the tool. Which is probably not too bad for hidden frontend flags that control the Analyzer because they're anyway set by a separate GUI checkbox, but the inconsistency with other flags would be super glaring in case of Clang-Tidy CLI. Do we really want to go in that direction? I'll be much more comfortable with letting each tool deal with its flags the way it prefers - this doesn't look like a good place for code reuse to me.

Sep 12 2019, 10:36 AM · Restricted Project
Szelethus retitled D67480: [analyzer] Add 'freopen' support to SimpleStreamChecker. from [Clang][Checkers] Add 'freopen' support to SimpleStreamChecker. to [analyzer] Add 'freopen' support to SimpleStreamChecker..
Sep 12 2019, 8:19 AM · Restricted Project

Sep 11 2019

Szelethus added a comment to D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions..

@Szelethus: I could have stored PathDiagnosticConsumerOptions in AnalyzerOptions by value and pass a const reference around, but it wasn't pleasant to integrate with AnalyzerOptions.def. I.e., i'd have to implement a new kind of option that doesn't allocate its own field but instead re-uses a field within a sub-object. Do you want me to go for it or is this implementation good enough?

Sep 11 2019, 7:27 AM · Restricted Project
Szelethus added a comment to D67419: [analyzer] NFC: Move PathDiagnostic to libAnalysis..

Looks great! Are we sure that PathDiagnostic.h is a good header name?

Sep 11 2019, 5:19 AM · Restricted Project, Restricted Project
Szelethus accepted D67382: [analyzer] NFC: Move getStmt() and createEndOfPath() out of PathDiagnostic..

LGTM! I think code readability improved geatly.

Sep 11 2019, 5:15 AM · Restricted Project, Restricted Project
Szelethus accepted D67381: [analyzer] NFC: Move stack hints to a side map..

I'm open to discuss a better design here. Eg., i thought about making it part of the visitor interface instead, but i don't immediately see how to do this without breaking the logic of "only add the note at the call site in which the event has happened, not every time allocated memory is returned from anywhere".

Sep 11 2019, 4:46 AM · Restricted Project, Restricted Project
Szelethus accepted D67418: [analyzer] NFC: Move PathDiagnostic::resetDiagnosticLocationToMainFile to bug reporter..

Sure!

Sep 11 2019, 2:49 AM · Restricted Project, Restricted Project

Sep 8 2019

Szelethus added inline comments to D67335: [analyzer][NFC] Refactor the checker registration unit test file.
Sep 8 2019, 3:18 PM · Restricted Project