Page MenuHomePhabricator

Szelethus (Kristóf Umann)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2017, 6:59 AM (258 w, 2 d)

Recent Activity

Today

Szelethus added a comment to D127643: [Static Analyzer] Structured bindings to data members.

I read https://en.cppreference.com/w/cpp/language/structured_binding carefully, and there are a number of interesting rules that might deserve their own test case, even if this isn't the patch where you solve that issue, or believe that the solution handles it without the need for special case handling.

Fri, Jul 1, 3:37 AM · Restricted Project, Restricted Project

Yesterday

Szelethus retitled D127973: [analyzer] Eval construction of non POD type arrays. from [Static Analyzer] Eval construction of non POD type arrays. to [analyzer] Eval construction of non POD type arrays..
Thu, Jun 30, 6:15 AM · Restricted Project, Restricted Project
Szelethus added a comment to D128064: [Static Analyzer] Small array binding policy.

No need for post commit fixes, just general observations since I noticed them.

Thu, Jun 30, 6:13 AM · Restricted Project, Restricted Project

Tue, Jun 28

Szelethus accepted D128716: [analyzer] Fix BindingDecl evaluation for reference types..

I tried poking this from a few directions, like nasty GNU extension types, ObjCObjectPointerType, but those seem orthogonal to this patch. Looks great! I'd wait for someone else's approval as well, as I try my best to pick up the thread.

Tue, Jun 28, 5:31 AM · Restricted Project, Restricted Project
Szelethus added inline comments to D128716: [analyzer] Fix BindingDecl evaluation for reference types..
Tue, Jun 28, 4:39 AM · Restricted Project, Restricted Project

Mon, Jun 6

Szelethus accepted D124738: [Documentation][Clang] Clang LibASTMatchers tutorial typo fix.

LGTM

Mon, Jun 6, 10:45 AM · Restricted Project, Restricted Project

Apr 8 2022

Szelethus committed rGfd8e5762f86f: [analyzer] Don't track function calls as control dependencies (authored by Szelethus).
[analyzer] Don't track function calls as control dependencies
Apr 8 2022, 1:19 AM · Restricted Project, Restricted Project
Szelethus closed D116597: [analyzer] Don't track function calls as control dependencies.
Apr 8 2022, 1:18 AM · Restricted Project, Restricted Project

Mar 30 2022

Szelethus added inline comments to D116597: [analyzer] Don't track function calls as control dependencies.
Mar 30 2022, 7:03 AM · Restricted Project, Restricted Project
Szelethus updated the diff for D116597: [analyzer] Don't track function calls as control dependencies.

Fixes according to reviewer comments.

Mar 30 2022, 7:03 AM · Restricted Project, Restricted Project
Szelethus abandoned D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null.

Very well :) Let's abandon this in its current state, I share this sentiment:

Mar 30 2022, 4:43 AM · Restricted Project, Restricted Project

Mar 24 2022

Szelethus accepted D122244: [analyzer] Turn missing tablegen doc entry of a checker into fatal error.

LGTM! You did check whether a missing doc field will actually trigger this error, right?

Mar 24 2022, 1:44 AM · Restricted Project, Restricted Project

Mar 23 2022

Szelethus added a comment to D122285: [analyzer] Add path note tags to standard library function summaries..

LGTM on my end, this is awesome!

Mar 23 2022, 5:53 AM · Restricted Project, Restricted Project

Mar 22 2022

Szelethus added a reviewer for D122150: [clang][analyzer] Add checker for bad use of 'errno'.: ASDenysPetrov.
Mar 22 2022, 5:51 AM · Restricted Project, Restricted Project

Mar 16 2022

Szelethus added a comment to D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals.

Seems like all new files are missing the header blurb about the licence.

Mar 16 2022, 5:02 AM · Restricted Project, Restricted Project

Mar 11 2022

Szelethus accepted D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page.

Nice!

Mar 11 2022, 2:29 AM · Restricted Project, Restricted Project

Mar 8 2022

Szelethus added a comment to D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null.

This check checks must-properties/all-paths properties. This has to be a data flow / CFG-based warning. I don't think there's a way around.

Mar 8 2022, 2:06 AM · Restricted Project, Restricted Project

Mar 6 2022

Szelethus added inline comments to D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null.
Mar 6 2022, 5:53 AM · Restricted Project, Restricted Project

Mar 4 2022

Szelethus requested review of D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null.
Mar 4 2022, 5:42 AM · Restricted Project, Restricted Project

Mar 3 2022

Szelethus committed rGd832078904c6: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators (authored by Szelethus).
[analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators
Mar 3 2022, 2:28 AM · Restricted Project
Szelethus closed D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators.
Mar 3 2022, 2:28 AM · Restricted Project, Restricted Project

Mar 1 2022

Szelethus committed rG32ac21d04909: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs (authored by Szelethus).
[NFC][analyzer] Allow CallDescriptions to be matched with CallExprs
Mar 1 2022, 8:13 AM
Szelethus closed D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.
Mar 1 2022, 8:13 AM · Restricted Project

Feb 25 2022

Szelethus committed rG5048a58a6792: [analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not… (authored by Szelethus).
[analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not…
Feb 25 2022, 7:52 AM
Szelethus closed D120325: [analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not built with it.
Feb 25 2022, 7:52 AM · Restricted Project

Feb 23 2022

Szelethus added inline comments to D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.
Feb 23 2022, 8:29 AM · Restricted Project
Szelethus updated the diff for D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.

Remove a newline.

Feb 23 2022, 8:29 AM · Restricted Project

Feb 22 2022

Szelethus added a comment to D119128: [analyzer] Fix taint propagation by remembering to the location context.

Can we reopen this if the code is not upstream at this time?

Feb 22 2022, 7:54 AM · Restricted Project
Szelethus requested review of D120325: [analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not built with it.
Feb 22 2022, 6:55 AM · Restricted Project

Feb 10 2022

Szelethus accepted D118987: [analyzer] Add failing test case demonstrating buggy taint propagation.

Sorry for the slack, I assumed this was accepted already. Thanks!

Feb 10 2022, 4:24 AM · Restricted Project

Feb 9 2022

Szelethus added inline comments to D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators.
Feb 9 2022, 4:30 AM · Restricted Project, Restricted Project
Szelethus updated the diff for D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators.

Fixes according to reviewer comments.

Feb 9 2022, 4:30 AM · Restricted Project, Restricted Project
Szelethus updated the diff for D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.
  • Rename from .*Imprecise to .*AsWritten.
  • Copy comments to relevant functions.
Feb 9 2022, 3:32 AM · Restricted Project

Feb 8 2022

Szelethus accepted D119245: [analyzer][docs][NFC] Fix some broken links and some cosmetic changes.

Cheers!

Feb 8 2022, 7:52 AM · Restricted Project
Szelethus accepted D119129: [analyzer] Fix taint rule of fgets and setproctitle_init.

LGTM! Unrelated to this review, I don't think the term 'sink' is good in a warning message, are users expected to know what that is?

Feb 8 2022, 1:31 AM · Restricted Project
Szelethus accepted D119128: [analyzer] Fix taint propagation by remembering to the location context.

LGTM!

Feb 8 2022, 12:55 AM · Restricted Project

Feb 7 2022

Szelethus added a comment to D119128: [analyzer] Fix taint propagation by remembering to the location context.

Sounds about right! Just a nit, otherwise LGTM.

Feb 7 2022, 5:27 AM · Restricted Project

Feb 5 2022

Szelethus added a comment to D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.

Now that I remember, the ever so slightly different overloads of ProgramState::getSVal is a prime example I think. I always percieved that I have the means to invoke several of them at any point, but I never really knew which one. Though, to be fair, they were not documented particularly well (at least as I remember it).

Feb 5 2022, 2:41 AM · Restricted Project

Feb 4 2022

Szelethus added a comment to D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.

I strongly belive that this should be an overload to the existing 'matches' API. Maybe add a comment that prefer the other overload if can. But having an overload for that alread implies this anyway.

Feb 4 2022, 9:18 AM · Restricted Project
Szelethus updated the diff for D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators.

Move CallDescription specific changes to D119004.

Feb 4 2022, 9:08 AM · Restricted Project, Restricted Project
Szelethus requested review of D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.
Feb 4 2022, 8:23 AM · Restricted Project

Feb 3 2022

Szelethus requested review of D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators.
Feb 3 2022, 1:34 AM · Restricted Project, Restricted Project

Feb 1 2022

Szelethus added a comment to D116597: [analyzer] Don't track function calls as control dependencies.

Ping ^-^

Feb 1 2022, 6:34 AM · Restricted Project, Restricted Project

Jan 24 2022

Szelethus updated the diff for D116597: [analyzer] Don't track function calls as control dependencies.

Fix tests, mention that this is purely a heuristic.

Jan 24 2022, 8:44 AM · Restricted Project, Restricted Project
Szelethus committed rG3ad35ba4dea5: [Templight] Don't display empty strings for names of unnamed template parameters (authored by Szelethus).
[Templight] Don't display empty strings for names of unnamed template parameters
Jan 24 2022, 7:37 AM
Szelethus closed D115521: [Templight] Don't display empty strings for names of unnamed template parameters.
Jan 24 2022, 7:37 AM · Restricted Project

Jan 11 2022

Szelethus added inline comments to D115521: [Templight] Don't display empty strings for names of unnamed template parameters.
Jan 11 2022, 1:38 AM · Restricted Project

Jan 4 2022

Szelethus requested review of D116597: [analyzer] Don't track function calls as control dependencies.
Jan 4 2022, 5:53 AM · Restricted Project, Restricted Project
Szelethus added inline comments to D115716: [Analyzer][BugReporter] Replace the example bug report with the one used to generate PathDiagnostic.
Jan 4 2022, 1:54 AM · Restricted Project

Jan 3 2022

Szelethus added a comment to D115716: [Analyzer][BugReporter] Replace the example bug report with the one used to generate PathDiagnostic.

First off, your patch is great, and I'm pretty sure we want it!

Jan 3 2022, 10:00 AM · Restricted Project
Szelethus updated the diff for D115521: [Templight] Don't display empty strings for names of unnamed template parameters.

Add a default text, if another, unhandled unnamed identifier pops up.

Jan 3 2022, 6:25 AM · Restricted Project

Dec 11 2021

Szelethus retitled D115521: [Templight] Don't display empty strings for names of unnamed template parameters from [Templight] Don't return string for name for unnamed template parameters to [Templight] Don't display empty strings for names of unnamed template parameters.
Dec 11 2021, 6:56 AM · Restricted Project

Dec 10 2021

Szelethus requested review of D115521: [Templight] Don't display empty strings for names of unnamed template parameters.
Dec 10 2021, 7:06 AM · Restricted Project

Nov 19 2021

Szelethus accepted D113589: [analyzer][NFC] Introduce CallDescriptionSets.

LGTM!

Nov 19 2021, 6:08 AM · Restricted Project

Nov 15 2021

Szelethus committed rGd896c9f40a22: Fix an unused variable warning (authored by Szelethus).
Fix an unused variable warning
Nov 15 2021, 6:46 AM
Szelethus committed rG29a8d45c5a23: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators (authored by Szelethus).
[clang-tidy] Fix a crash in modernize-loop-convert around conversion operators
Nov 15 2021, 4:12 AM
Szelethus closed D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators.
Nov 15 2021, 4:12 AM · Restricted Project
Szelethus requested changes to D113589: [analyzer][NFC] Introduce CallDescriptionSets.

I recognize the problem, but don't agree with the solution: this is a CallDescriptionSet at this point, not a CallDescriptionMap. Also, I just don't think this is the place to use template specialization, nor do I think we should keep the function name lookup, if we only care about whether the call is in the set or not.

Nov 15 2021, 4:04 AM · Restricted Project
Szelethus accepted D113588: [analyzer][NFC] Make the API of CallDescription safer slightly.

I guess this constructor prevents us from to just put this into ArrayRef:

Nov 15 2021, 3:17 AM
Szelethus accepted D113587: [analyzer][NFC] Separate CallDescription from CallEvent.
Nov 15 2021, 2:49 AM · Restricted Project, Restricted Project

Nov 11 2021

Szelethus added a reviewer for D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators: Eugene.Zelenko.

I'll intend to land this by friday unless there are objections!

Nov 11 2021, 3:31 AM · Restricted Project

Nov 9 2021

Szelethus committed rG8cc2de667ec2: [analyzer][docs] Fix the incorrect structure of the checker docs (authored by Szelethus).
[analyzer][docs] Fix the incorrect structure of the checker docs
Nov 9 2021, 6:26 AM
Szelethus closed D113397: [analyzer][docs] Fix the incorrect structure of the checker docs.
Nov 9 2021, 6:26 AM · Restricted Project
Szelethus accepted D113401: [analyzer][docs] Ellaborate the docs of cplusplus.StringChecker.

Maybe we should change the name of this checker to NullConstructedString or something, instead of piling even more different kinds of warnings into it in the future. Or maybe not. In any case, the patch LGTM!

Nov 9 2021, 5:25 AM · Restricted Project
Szelethus added inline comments to D113004: [analyzer][docs] Add Configuration section to user-docs.
Nov 9 2021, 5:20 AM · Restricted Project
Szelethus added inline comments to D113401: [analyzer][docs] Ellaborate the docs of cplusplus.StringChecker.
Nov 9 2021, 2:55 AM · Restricted Project

Nov 8 2021

Szelethus updated the diff for D113397: [analyzer][docs] Fix the incorrect structure of the checker docs.

Add context.

Nov 8 2021, 7:02 AM · Restricted Project
Szelethus updated the diff for D113397: [analyzer][docs] Fix the incorrect structure of the checker docs.

Fix incorrect sectioning.

Nov 8 2021, 6:50 AM · Restricted Project
Szelethus requested review of D113397: [analyzer][docs] Fix the incorrect structure of the checker docs.
Nov 8 2021, 5:47 AM · Restricted Project
Szelethus updated the diff for D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators.

Clarify the summary.
Delete unnecessary includes.
More fitting iterator names in the test files.

Nov 8 2021, 5:20 AM · Restricted Project

Nov 4 2021

Szelethus requested review of D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators.
Nov 4 2021, 9:56 AM · Restricted Project

Nov 2 2021

Szelethus added a comment to D113004: [analyzer][docs] Add Configuration section to user-docs.

Big yes to the idea, the config of choice as the first to document seems fine, but I'm not sure we should lecture the user right in the very first paragraph. How about a short description of what a FAM is in the first place, than examples of the 3 types of it, and why we assume that only the first and the second to be such by default. If you insist, a word of caution would be okay in the last paragraph.

Nov 2 2021, 5:08 AM · Restricted Project

Sep 23 2021

Szelethus closed D108912: [release][analyzer] Add 13.0.0 release notes.

Commited in rGee6913cc8317c08b603daed64b07a17a95ec926a to release/13.x.

Sep 23 2021, 3:10 AM · Restricted Project
Szelethus accepted D108912: [release][analyzer] Add 13.0.0 release notes.
Sep 23 2021, 3:09 AM · Restricted Project

Sep 14 2021

Szelethus added a comment to D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it.

rGfb4d590a622f4031900516360c07ee6ace01c5e6 should sort this out!

Sep 14 2021, 7:12 AM · Restricted Project
Szelethus committed rGfb4d590a622f: Fix a unittest file after D108695 when Z3 is enabled (authored by Szelethus).
Fix a unittest file after D108695 when Z3 is enabled
Sep 14 2021, 7:11 AM
Szelethus added a comment to D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it.

I'll attend to this ASAP. Thanks for the heads up!

Sep 14 2021, 4:23 AM · Restricted Project

Sep 13 2021

Szelethus added a comment to D108912: [release][analyzer] Add 13.0.0 release notes.

Gonna land this in a day or two, regardless of whether its accepted! Please take a look if you have anything to object to!

Sep 13 2021, 6:06 AM · Restricted Project
Szelethus committed rG9d359f6c7386: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a… (authored by Szelethus).
[analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a…
Sep 13 2021, 6:02 AM
Szelethus closed D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default.
Sep 13 2021, 6:02 AM · Restricted Project
Szelethus committed rG0213d7ec0c50: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire… (authored by Szelethus).
[analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire…
Sep 13 2021, 4:51 AM
Szelethus closed D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it.
Sep 13 2021, 4:51 AM · Restricted Project
Szelethus added a comment to D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream ..

I like everything I see here so far! As soon as those debug functions are in, the patch should land!

Sep 13 2021, 3:46 AM · Restricted Project

Sep 8 2021

Szelethus added a comment to D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default.

This looks good!

I guess one way to make this even more conservative would be to match the variable inside the delete-expression to the one we expect to get deallocated.

Sep 8 2021, 3:40 PM · Restricted Project

Sep 4 2021

Szelethus reopened D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it.
Sep 4 2021, 2:34 AM · Restricted Project

Sep 3 2021

Szelethus added a comment to D108912: [release][analyzer] Add 13.0.0 release notes.

I suppose that the SmartPtrModelling patches from GSoC this year shouldn't be added since they only involve an alpha checker.

Sep 3 2021, 6:00 AM · Restricted Project
Szelethus added a comment to D108912: [release][analyzer] Add 13.0.0 release notes.
Sep 3 2021, 5:58 AM · Restricted Project
Szelethus updated the diff for D108912: [release][analyzer] Add 13.0.0 release notes.

I suppose that the SmartPtrModelling patches from GSoC this year shouldn't be added since they only involve an alpha checker.

Sep 3 2021, 5:56 AM · Restricted Project
Szelethus added a comment to D108912: [release][analyzer] Add 13.0.0 release notes.

Maybe a couple other noteworthy commits:
efa7df1682c2859dabe3646ee7dc01e68629417f: better R-value tracking.
aa454dda2eed4e71081bc57b1f32dfce2486b177: fixing the modeling of std::bit_cast<>.

Sep 3 2021, 5:43 AM · Restricted Project
Szelethus updated the diff for D108912: [release][analyzer] Add 13.0.0 release notes.

Fixes according to reviewer comments, cheers!

Sep 3 2021, 5:43 AM · Restricted Project
Szelethus updated the diff for D108753: [analyzer] MallocChecker: Add notes from NoOwnershipChangeVisitor only when a function "intents", but doesn't change ownership, enable by default.

indent->intent

Sep 3 2021, 5:22 AM · Restricted Project
Szelethus accepted D108824: [analyzer] SValBuilder should have an easy access to AnalyzerOptions.

Lets go! Mind that you wrote "eazy" instead of "easy" in the revision name. But, if you are just being that "kewl", I don't mind!

Sep 3 2021, 5:07 AM · Restricted Project
Szelethus committed rGa375bfb5b729: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire… (authored by Szelethus).
[analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire…
Sep 3 2021, 4:51 AM
Szelethus closed D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it.
Sep 3 2021, 4:50 AM · Restricted Project

Sep 2 2021

Szelethus reopened D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it.
Sep 2 2021, 8:28 AM · Restricted Project
Szelethus added a reverting change for rG7d0e62bfb773: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire…: rG3891b45a06f9: Revert "[analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check….
Sep 2 2021, 8:20 AM
Szelethus added a reverting change for D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it: rG3891b45a06f9: Revert "[analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check….
Sep 2 2021, 8:20 AM · Restricted Project
Szelethus committed rG3891b45a06f9: Revert "[analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check… (authored by Szelethus).
Revert "[analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check…
Sep 2 2021, 8:20 AM
Szelethus committed rG7d0e62bfb773: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire… (authored by Szelethus).
[analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire…
Sep 2 2021, 7:57 AM
Szelethus closed D108695: [analyzer][NFCI] Allow clients of NoStateChangeFuncVisitor to check entire function calls, rather than each ExplodedNode in it.
Sep 2 2021, 7:57 AM · Restricted Project