Page MenuHomePhabricator

Szelethus (Kristóf Umann)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2017, 6:59 AM (87 w, 5 d)

Recent Activity

Today

Szelethus accepted D59622: [analyzer] C++17: PR41142: Ignore transparent InitListExprs in ExprEngine as well..
Mon, Mar 25, 9:54 AM · Restricted Project
Szelethus requested changes to D59516: [analyzer] Add custom filter functions for GenericTaintChecker.

Same thing.

Mon, Mar 25, 6:12 AM · Restricted Project
Szelethus added a comment to D59555: [analyzer] Add yaml parser to GenericTaintChecker.

I think the idea is awesome, thanks!

Mon, Mar 25, 6:01 AM · Restricted Project

Sat, Mar 23

Szelethus added a comment to D59465: [analyzer] Add example plugin for checker option handling.

Would you be more comfortable with this patch I didn't touch the examples folder?

Sat, Mar 23, 3:54 AM · Restricted Project
Szelethus added a comment to D57858: [analyzer] Add a new frontend flag to display all checker options.

This patch isn't intended for end users, which is why -analyzer-checker-option-help is a frontend flag -- besides, some of the plain frontend flags aren't either. It is purely for development purposes, though exposing an end user friendly subset of these through a driver flag would be cool.

Sat, Mar 23, 3:48 AM · Restricted Project
Szelethus added a comment to D57860: [analyzer] Validate checker option names and values.

I think it would be better if the default for compatibility mode were 'true'. That way this change will be backwards compatible and clients who want to enforce stricter checking could enable it. Setting compatibility mode to be true in the driver is not sufficient since many build systems call the frontend directly.

Sat, Mar 23, 3:41 AM · Restricted Project

Fri, Mar 22

Szelethus added a comment to D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers.

Although, as you rightly pointed out that ordered sets of pointers are as non-deterministic as unordered ones.

Fri, Mar 22, 12:27 AM · Restricted Project

Thu, Mar 21

Szelethus added a comment to D58573: [analyzer] Move UninitializedObject out of alpha.

Ping, @NoQ, if we settled on optin.cplusplus, would you be fine with this patch?

Thu, Mar 21, 6:06 AM · Restricted Project

Wed, Mar 20

Szelethus retitled D57855: [analyzer][NFC] Reimplement checker options from [analyzer] Reimplement checker options to [analyzer][NFC] Reimplement checker options.
Wed, Mar 20, 4:21 AM · Restricted Project

Tue, Mar 19

Szelethus added a reviewer for D59464: [analyzer] Add an example plugin for checker dependency handling: dcoughlin.
Tue, Mar 19, 11:22 AM · Restricted Project
Szelethus added a reviewer for D58065: [analyzer] Document the frontend library: dcoughlin.
Tue, Mar 19, 5:19 AM · Restricted Project
Szelethus requested changes to D59516: [analyzer] Add custom filter functions for GenericTaintChecker.

I'm very much guilty of doing functional and refactoring changes within the same patch, but I think working on GenericTaintChecker AND in the same patch doing (seemingly unrelated) function name changes in ProgramState might be overkill -- Could you please divide this patch into smaller parts please?

Tue, Mar 19, 4:30 AM · Restricted Project
Szelethus added a comment to D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry.

Please rename the patch. Its name does not really express its content.

Tue, Mar 19, 2:36 AM · Restricted Project
Szelethus retitled D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry from [analyzer][NFC] Use capital variable names in CheckerRegistry to [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry.
Tue, Mar 19, 2:30 AM · Restricted Project

Sat, Mar 16

Szelethus updated the summary of D59464: [analyzer] Add an example plugin for checker dependency handling.
Sat, Mar 16, 1:35 PM · Restricted Project
Szelethus removed a child revision for D57855: [analyzer][NFC] Reimplement checker options: D57858: [analyzer] Add a new frontend flag to display all checker options.
Sat, Mar 16, 1:08 PM · Restricted Project
Szelethus edited parent revisions for D57858: [analyzer] Add a new frontend flag to display all checker options, added: 1; removed: 1.
Sat, Mar 16, 1:08 PM · Restricted Project
Szelethus added a child revision for D59195: [analyzer] Remove the default value arg from getChecker*Option: D57858: [analyzer] Add a new frontend flag to display all checker options.
Sat, Mar 16, 1:08 PM · Restricted Project
Szelethus updated the diff for D57858: [analyzer] Add a new frontend flag to display all checker options.

Add a test case for then checker plugin.

Sat, Mar 16, 1:06 PM · Restricted Project
Szelethus updated the diff for D59195: [analyzer] Remove the default value arg from getChecker*Option.

Remove the default argument from the plugin, also add a test case for it.

Sat, Mar 16, 1:02 PM · Restricted Project
Szelethus updated the diff for D57860: [analyzer] Validate checker option names and values.

Add a test case for checker plugins.

Sat, Mar 16, 12:52 PM · Restricted Project
Szelethus updated the diff for D59195: [analyzer] Remove the default value arg from getChecker*Option.

Rebase.

Sat, Mar 16, 12:52 PM · Restricted Project
Szelethus removed a child revision for D57855: [analyzer][NFC] Reimplement checker options: D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable.
Sat, Mar 16, 12:47 PM · Restricted Project
Szelethus edited parent revisions for D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable, added: 1; removed: 1.
Sat, Mar 16, 12:47 PM · Restricted Project
Szelethus added a child revision for D59465: [analyzer] Add example plugin for checker option handling: D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable.
Sat, Mar 16, 12:47 PM · Restricted Project
Szelethus updated the diff for D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable.

Add a test case for checker plugins.

Sat, Mar 16, 12:47 PM · Restricted Project
Szelethus added parent revisions for D59465: [analyzer] Add example plugin for checker option handling: D57855: [analyzer][NFC] Reimplement checker options, D59464: [analyzer] Add an example plugin for checker dependency handling.
Sat, Mar 16, 12:19 PM · Restricted Project
Szelethus added a child revision for D57855: [analyzer][NFC] Reimplement checker options: D59465: [analyzer] Add example plugin for checker option handling.
Sat, Mar 16, 12:19 PM · Restricted Project
Szelethus added a child revision for D59464: [analyzer] Add an example plugin for checker dependency handling: D59465: [analyzer] Add example plugin for checker option handling.
Sat, Mar 16, 12:19 PM · Restricted Project
Szelethus created D59465: [analyzer] Add example plugin for checker option handling.
Sat, Mar 16, 12:18 PM · Restricted Project
Szelethus added a parent revision for D59464: [analyzer] Add an example plugin for checker dependency handling: D59461: [analyzer] Fix an assertion failure if plugins added dependencies.
Sat, Mar 16, 12:13 PM · Restricted Project
Szelethus added a child revision for D59461: [analyzer] Fix an assertion failure if plugins added dependencies: D59464: [analyzer] Add an example plugin for checker dependency handling.
Sat, Mar 16, 12:13 PM · Restricted Project
Szelethus created D59464: [analyzer] Add an example plugin for checker dependency handling.
Sat, Mar 16, 12:10 PM · Restricted Project
Szelethus updated the diff for D57860: [analyzer] Validate checker option names and values.

Rebase.

Sat, Mar 16, 10:55 AM · Restricted Project
Szelethus updated the diff for D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable.

Rebase.

Sat, Mar 16, 10:52 AM · Restricted Project
Szelethus added a child revision for D59461: [analyzer] Fix an assertion failure if plugins added dependencies: D57855: [analyzer][NFC] Reimplement checker options.
Sat, Mar 16, 10:52 AM · Restricted Project
Szelethus updated the diff for D57855: [analyzer][NFC] Reimplement checker options.
  • Moved every non-related change to smaller patches, this should ease a lot on reviewers.
  • Now processing options once all checkers are added to the registry. This is important, because I use binary searches to find the checkers and packages that need to be modified -- if a plugin however called CheckerRegistry::add*Option, it would've cause an assertion failure.
Sat, Mar 16, 10:52 AM · Restricted Project
Szelethus added a parent revision for D57855: [analyzer][NFC] Reimplement checker options: D59461: [analyzer] Fix an assertion failure if plugins added dependencies.
Sat, Mar 16, 10:52 AM · Restricted Project
Szelethus added a comment to D59461: [analyzer] Fix an assertion failure if plugins added dependencies.

Don't let the testcase fool you, it's merely added because there wasn't any for that particular case, I still need to add the plugin, but that moves quite a few files around, so I might separate that to another patch.

Sat, Mar 16, 10:44 AM · Restricted Project
Szelethus added a child revision for D59459: [analyzer][NFC] Prefer binary searches in CheckerRegistry: D59461: [analyzer] Fix an assertion failure if plugins added dependencies.
Sat, Mar 16, 10:41 AM · Restricted Project
Szelethus added a parent revision for D59461: [analyzer] Fix an assertion failure if plugins added dependencies: D59459: [analyzer][NFC] Prefer binary searches in CheckerRegistry.
Sat, Mar 16, 10:41 AM · Restricted Project
Szelethus created D59461: [analyzer] Fix an assertion failure if plugins added dependencies.
Sat, Mar 16, 10:41 AM · Restricted Project
Szelethus added a parent revision for D59458: [analyzer][NFC] Clang-format CheckerRegistry: D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry.
Sat, Mar 16, 10:32 AM · Restricted Project
Szelethus added a child revision for D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry: D59458: [analyzer][NFC] Clang-format CheckerRegistry.
Sat, Mar 16, 10:32 AM · Restricted Project
Szelethus added a parent revision for D59459: [analyzer][NFC] Prefer binary searches in CheckerRegistry: D59458: [analyzer][NFC] Clang-format CheckerRegistry.
Sat, Mar 16, 10:32 AM · Restricted Project
Szelethus added a child revision for D59458: [analyzer][NFC] Clang-format CheckerRegistry: D59459: [analyzer][NFC] Prefer binary searches in CheckerRegistry.
Sat, Mar 16, 10:32 AM · Restricted Project
Szelethus created D59459: [analyzer][NFC] Prefer binary searches in CheckerRegistry.
Sat, Mar 16, 10:32 AM · Restricted Project
Szelethus created D59458: [analyzer][NFC] Clang-format CheckerRegistry.
Sat, Mar 16, 10:28 AM · Restricted Project
Szelethus created D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry.
Sat, Mar 16, 10:28 AM · Restricted Project

Fri, Mar 15

Szelethus planned changes to D57855: [analyzer][NFC] Reimplement checker options.

Alright, I'll de-clutter this patch a bit.

Fri, Mar 15, 10:15 AM · Restricted Project

Thu, Mar 14

Szelethus committed rG4962816e7242: [analyzer] Fix an assertation failure for invalid sourcelocation, add a new… (authored by Szelethus).
[analyzer] Fix an assertation failure for invalid sourcelocation, add a new…
Thu, Mar 14, 9:13 AM
Szelethus committed rL356161: [analyzer] Fix an assertation failure for invalid sourcelocation, add a new….
[analyzer] Fix an assertation failure for invalid sourcelocation, add a new…
Thu, Mar 14, 9:09 AM
Szelethus committed rC356161: [analyzer] Fix an assertation failure for invalid sourcelocation, add a new….
[analyzer] Fix an assertation failure for invalid sourcelocation, add a new…
Thu, Mar 14, 9:09 AM
Szelethus closed D58777: [analyzer] Fix an assertation failurure for invalid sourcelocation, add a new debug checker.
Thu, Mar 14, 9:09 AM · Restricted Project
Szelethus added inline comments to D58777: [analyzer] Fix an assertation failurure for invalid sourcelocation, add a new debug checker.
Thu, Mar 14, 9:02 AM · Restricted Project
Szelethus updated the diff for D58777: [analyzer] Fix an assertation failurure for invalid sourcelocation, add a new debug checker.

Fixes according to inline comments.

Thu, Mar 14, 9:02 AM · Restricted Project
Szelethus updated the diff for D57860: [analyzer] Validate checker option names and values.

Add a testcase for packages.

Thu, Mar 14, 7:54 AM · Restricted Project
Szelethus updated the diff for D57860: [analyzer] Validate checker option names and values.

Fixes according to inline comments.

Thu, Mar 14, 7:48 AM · Restricted Project
Szelethus updated the diff for D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable.
Thu, Mar 14, 7:46 AM · Restricted Project
Szelethus added a reviewer for D53701: [Analyzer] Instead of recording comparisons in interator checkers do an eager state split: Szelethus.
Thu, Mar 14, 7:44 AM · Restricted Project
Szelethus updated the diff for D57858: [analyzer] Add a new frontend flag to display all checker options.

Also, don't forget package options :^)

Thu, Mar 14, 7:32 AM · Restricted Project
Szelethus added a comment to D57855: [analyzer][NFC] Reimplement checker options.

Let's put at least a FIXME here that the documentation for this option was missing.

Thu, Mar 14, 7:27 AM · Restricted Project
Szelethus committed rG7b907bed3c17: [analyzer] Fix function macro crash (authored by Szelethus).
[analyzer] Fix function macro crash
Thu, Mar 14, 6:41 AM
Szelethus committed rC356142: [analyzer] Fix function macro crash.
[analyzer] Fix function macro crash
Thu, Mar 14, 6:40 AM
Szelethus committed rL356142: [analyzer] Fix function macro crash.
[analyzer] Fix function macro crash
Thu, Mar 14, 6:40 AM
Szelethus closed D57893: [analyzer] Fix function macro crash.
Thu, Mar 14, 6:40 AM · Restricted Project, Restricted Project

Wed, Mar 13

Szelethus accepted D57893: [analyzer] Fix function macro crash.

Ah so it was a past-the-end iterator dereference error. Cheers!

Wed, Mar 13, 2:56 PM · Restricted Project, Restricted Project
Szelethus added a comment to D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers.

Could you please add a commit that changes the top of the file on your previous commit? Feel free to do that without review (I can't commit it myself atm).

Wed, Mar 13, 12:02 PM · Restricted Project
Szelethus added a comment to D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers.
3. Currently, we also do not check for what happens inside the for loop. Not all iterations may causes non-determinism. For example, counting or summing up the elements should not be non-deterministic.
Wed, Mar 13, 4:32 AM · Restricted Project
Szelethus requested changes to D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers.

Code is great, idea's great, so green light on my part, but maybe we should allow some folks who are more knowledgeable on AST matching to have a say in this.

Wed, Mar 13, 4:28 AM · Restricted Project

Tue, Mar 12

Szelethus added a comment to D57893: [analyzer] Fix function macro crash.

Some bots also break but emit a different message:

Tue, Mar 12, 6:24 AM · Restricted Project, Restricted Project
Szelethus requested changes to D57893: [analyzer] Fix function macro crash.

Let's investigate what's behind this.

Tue, Mar 12, 6:16 AM · Restricted Project, Restricted Project
Szelethus reopened D57893: [analyzer] Fix function macro crash.

Ugh. Reverted the patch.

Tue, Mar 12, 6:16 AM · Restricted Project, Restricted Project
Szelethus added a comment to D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor..

Would NoteTags be displayed in a dumped exploded graph?

Tue, Mar 12, 5:32 AM · Restricted Project
Szelethus added a reviewer for D58573: [analyzer] Move UninitializedObject out of alpha: baloghadamsoftware.
Tue, Mar 12, 4:51 AM · Restricted Project
Szelethus added inline comments to D57860: [analyzer] Validate checker option names and values.
Tue, Mar 12, 4:39 AM · Restricted Project
Szelethus committed rGe58dde2a8024: Revert "[analyzer] Fix function macro crash" (authored by Szelethus).
Revert "[analyzer] Fix function macro crash"
Tue, Mar 12, 4:23 AM
Szelethus committed rC355911: Revert "[analyzer] Fix function macro crash".
Revert "[analyzer] Fix function macro crash"
Tue, Mar 12, 4:23 AM
Szelethus committed rL355911: Revert "[analyzer] Fix function macro crash".
Revert "[analyzer] Fix function macro crash"
Tue, Mar 12, 4:23 AM
Szelethus committed rG9f92b3d08122: [analyzer] Fix function macro crash (authored by Szelethus).
[analyzer] Fix function macro crash
Tue, Mar 12, 3:04 AM
Szelethus committed rL355903: [analyzer] Fix function macro crash.
[analyzer] Fix function macro crash
Tue, Mar 12, 3:03 AM
Szelethus committed rC355903: [analyzer] Fix function macro crash.
[analyzer] Fix function macro crash
Tue, Mar 12, 3:03 AM
Szelethus closed D57893: [analyzer] Fix function macro crash.
Tue, Mar 12, 3:03 AM · Restricted Project, Restricted Project
Szelethus requested changes to D57890: [analyzer] Fix in self assignment checker.

Yup, I agree.

Tue, Mar 12, 3:03 AM · Restricted Project
Szelethus added inline comments to D57855: [analyzer][NFC] Reimplement checker options.
Tue, Mar 12, 2:24 AM · Restricted Project
Szelethus updated the diff for D57855: [analyzer][NFC] Reimplement checker options.

Fixes according to reviewer comments.

Tue, Mar 12, 2:24 AM · Restricted Project

Mon, Mar 11

Szelethus accepted D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes..

LGTM!

Mon, Mar 11, 5:23 AM · Restricted Project, Restricted Project
Szelethus added a reviewer for D58065: [analyzer] Document the frontend library: aaron.ballman.

Oops.

Mon, Mar 11, 5:05 AM · Restricted Project
Szelethus edited reviewers for D58065: [analyzer] Document the frontend library, added: baloghadamsoftware; removed: aaron.ballman.
Mon, Mar 11, 4:57 AM · Restricted Project

Sun, Mar 10

Szelethus edited parent revisions for D57860: [analyzer] Validate checker option names and values, added: 1; removed: 1.
Sun, Mar 10, 2:39 PM · Restricted Project
Szelethus removed a child revision for D57855: [analyzer][NFC] Reimplement checker options: D57860: [analyzer] Validate checker option names and values.
Sun, Mar 10, 2:39 PM · Restricted Project
Szelethus added a child revision for D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable: D57860: [analyzer] Validate checker option names and values.
Sun, Mar 10, 2:39 PM · Restricted Project
Szelethus added a parent revision for D59195: [analyzer] Remove the default value arg from getChecker*Option: D57860: [analyzer] Validate checker option names and values.
Sun, Mar 10, 2:39 PM · Restricted Project
Szelethus added a child revision for D57860: [analyzer] Validate checker option names and values: D59195: [analyzer] Remove the default value arg from getChecker*Option.
Sun, Mar 10, 2:39 PM · Restricted Project
Szelethus created D59195: [analyzer] Remove the default value arg from getChecker*Option.
Sun, Mar 10, 2:37 PM · Restricted Project
Szelethus updated the diff for D57860: [analyzer] Validate checker option names and values.

Refactored the entire patch, NFC compared to the earlier diff. This was needed as in a followup revision, much of the code would be rewritten.

Sun, Mar 10, 2:15 PM · Restricted Project
Szelethus added inline comments to D57855: [analyzer][NFC] Reimplement checker options.
Sun, Mar 10, 2:10 PM · Restricted Project
Szelethus updated the diff for D57855: [analyzer][NFC] Reimplement checker options.

Adding explicit to CheckerInfo's constructor.

Sun, Mar 10, 2:10 PM · Restricted Project
Szelethus updated the diff for D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable.

Removed every piece of code not directly related to inserting checker option to the config table, moving it to a new patch. This essentially restores the revision to it's earliest state, except that it's even simpler: no changes are made to AnalyzerOptions.

Sun, Mar 10, 2:03 PM · Restricted Project
Szelethus added a comment to D58573: [analyzer] Move UninitializedObject out of alpha.
In D58573#1422198, @NoQ wrote:

Also, hmm, how about the following heuristics (looked at the positive in rtags and thought about this):

  • if the field is public, don't warn (the structure seems to be used simply as a convenient group of variables?)

I disagree with this. If anything, public uninitialized fields should be reported the most.

  • if all uninitialized fields are in all cases written into immediately after the constructor ends, suppress the warning (i vaguely remember that something similar was already proposed, but i might be wrong)

I think we'd need dataflow analysis for that. We do suppress reports though where all fields of an object is uninitialized.

Sun, Mar 10, 8:52 AM · Restricted Project