Page MenuHomePhabricator

Szelethus (Kristóf Umann)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 19 2017, 6:59 AM (297 w, 3 d)

Recent Activity

Tue, Mar 28

Szelethus added a comment to D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker..

Please run this on open source projects and upload the results.

Tue, Mar 28, 5:15 AM · Restricted Project, Restricted Project

Mon, Mar 13

Szelethus added inline comments to D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors.
Mon, Mar 13, 3:30 AM · Restricted Project, Restricted Project

Thu, Mar 9

Szelethus accepted D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker..

LGTM

Thu, Mar 9, 1:42 AM · Restricted Project, Restricted Project

Wed, Mar 8

Szelethus added a comment to D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors.

We worked on this together, so I waited a bit for others to have a say in this, but this design seems like a no brainer to me. Please fix those comments, otherwise LGTM.

Wed, Mar 8, 5:27 AM · Restricted Project, Restricted Project

Mar 2 2023

Szelethus added reviewers for D144977: [analyzer] Fix of the initialization list parsing.: xazax.hun, isuckatcs.
Mar 2 2023, 5:44 AM · Restricted Project, Restricted Project

Feb 27 2023

Szelethus added a comment to D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker..

A high level comment before getting into (even more) nitty gritty stuff. But shut me down if I misunderstood whats happening.

Feb 27 2023, 5:16 AM · Restricted Project, Restricted Project

Feb 23 2023

Szelethus added a comment to D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place.

The challenging part with note tags is how do you figure out whether your bug report is taint-related. The traditional solution is to check the BugType but in this case an indeterminate amount of checkers may emit taint-related reports.

Feb 23 2023, 5:42 AM · Restricted Project, Restricted Project

Feb 22 2023

Szelethus added a comment to D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker..

Ugh, I admit, its a little hard to follow what happened here. You moved a lot of code around (I agree with that!), but also changed code as well. Can you just summarize what is NOT just moved code and needs a more thorough look?

Feb 22 2023, 7:33 AM · Restricted Project, Restricted Project

Feb 14 2023

Szelethus added a reviewer for D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.: gamesh411.
Feb 14 2023, 7:54 AM · Restricted Project, Restricted Project
Szelethus added a reviewer for D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.: gamesh411.
Feb 14 2023, 7:43 AM · Restricted Project, Restricted Project
Szelethus accepted D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly.

LGTM!

Feb 14 2023, 7:42 AM · Restricted Project, Restricted Project

Feb 10 2023

Szelethus added a comment to D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly.

A small nit, otherwise LGTM.

Feb 10 2023, 5:26 AM · Restricted Project, Restricted Project

Feb 3 2023

Szelethus added a reviewer for D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly: gamesh411.

Awesome, been a long time coming!!

Feb 3 2023, 4:40 AM · Restricted Project, Restricted Project

Feb 2 2023

Szelethus added a comment to D142354: [analyzer] Create a stub for an std::variant checker.

While we were there, we also dug into std::any, and learned that the analyzer can model it shockingly well. Hopefully we can submit a few patches that demonstrates it in a form of some test files.

Feb 2 2023, 5:04 AM · Restricted Project, Restricted Project

Jan 25 2023

Szelethus added a comment to D142354: [analyzer] Create a stub for an std::variant checker.

Interesting, what specific goals do you have here? Are you planning to find specific bugs (eg. force-unwrap to a wrong type) or just to model the semantics?

Jan 25 2023, 5:47 AM · Restricted Project, Restricted Project

Jan 5 2023

Szelethus added a comment to D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker..

LGTM! I think I prefer this solution anyways. Please commit (the entire patchstack).

Jan 5 2023, 4:32 AM · Restricted Project, Restricted Project

Jan 4 2023

Szelethus added inline comments to D137790: [clang][analyzer] Remove report of null stream from StreamChecker..
Jan 4 2023, 6:41 AM · Restricted Project, Restricted Project
Szelethus accepted D137790: [clang][analyzer] Remove report of null stream from StreamChecker..

Please rerun the evaluation before commiting to confirm the results haven't changed! Otherwise, LGTM.

Jan 4 2023, 6:38 AM · Restricted Project, Restricted Project
Szelethus accepted D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker..
Jan 4 2023, 6:36 AM · Restricted Project, Restricted Project
Szelethus accepted D140395: [clang][analyzer] Extend StreamChecker with some new functions..

LGTM

Jan 4 2023, 6:36 AM · Restricted Project, Restricted Project
Szelethus added a comment to D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker..

LGTM, granted you add that test in the followup commit. If possible, I'd prefer to have features tested in the patch that added them (but this is fine for now).

Jan 4 2023, 6:34 AM · Restricted Project, Restricted Project

Jan 3 2023

Szelethus added a comment to D140395: [clang][analyzer] Extend StreamChecker with some new functions..

Mostly LGTM, but I see that you have tests for the predecessor patch here as well, so I'll accept both at once.

Jan 3 2023, 7:44 AM · Restricted Project, Restricted Project
Szelethus added inline comments to D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker..
Jan 3 2023, 7:30 AM · Restricted Project, Restricted Project
Szelethus added a comment to D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker..

Would be possible to test the errno specific changes as well?

Jan 3 2023, 7:12 AM · Restricted Project, Restricted Project

Jan 2 2023

Szelethus added a comment to D137790: [clang][analyzer] Remove report of null stream from StreamChecker..

Are you sure that the refactoring made no changes to the results? Could you maybe just run a nightly or something like that to confirm?

Jan 2 2023, 8:31 AM · Restricted Project, Restricted Project
Szelethus added a comment to D140395: [clang][analyzer] Extend StreamChecker with some new functions..

Does this patch fix any false positives from before, or is this just all new stuff? I ask, because I wonder whats the shortest path towards popping these checkers out of alpha, and fix what we already have. By no means am I saying that we should postpone landing this, but take a more directed attempt at tying off loose ends after this stack.

Jan 2 2023, 8:28 AM · Restricted Project, Restricted Project
Szelethus added a reviewer for D140395: [clang][analyzer] Extend StreamChecker with some new functions.: gamesh411.
Jan 2 2023, 6:50 AM · Restricted Project, Restricted Project
Szelethus added a comment to D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker..

Would be possible to test the errno specific changes as well?

Jan 2 2023, 6:13 AM · Restricted Project, Restricted Project

Dec 20 2022

Szelethus added a comment to D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker..

This patch and D140395 is (almost) the same code as D135360 and D135247. The changes are separated for the different checkers. Tests are added at the second patch.

Dec 20 2022, 8:01 AM · Restricted Project, Restricted Project
Szelethus added a reviewer for D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker.: gamesh411.

Some of the changes are also present in D135247. I suppose you're in the middle of splitting those patches apart and remaking the patch stack?

Dec 20 2022, 5:30 AM · Restricted Project, Restricted Project

Dec 19 2022

Szelethus added a comment to D137790: [clang][analyzer] Remove report of null stream from StreamChecker..

I have a fear that we may have too few results as well -- maybe we should expand our testing infrastructure with more POSIX API heavy codebases. Looking at a few new projects, https://github.com/audacity/audacity looks like a good candidate, but of course it often turns out that adding a new project to the benchmark is more troublesome than it appears...

Dec 19 2022, 6:29 AM · Restricted Project, Restricted Project
Szelethus added a comment to D137790: [clang][analyzer] Remove report of null stream from StreamChecker..

On the postgres results, the second is one that can be fixed in the checker (add special cases to StdLibraryFunctionsChecker for zero len or size fread and fwrite arguments). The others are false positives because the error path is impossible because implicit constraints (what is not known to the analyzer) on variables.

Dec 19 2022, 6:09 AM · Restricted Project, Restricted Project
Szelethus added inline comments to D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker..
Dec 19 2022, 5:40 AM · Restricted Project, Restricted Project
Szelethus added a comment to D137790: [clang][analyzer] Remove report of null stream from StreamChecker..

Some reports can be found here (if the link works and the data does not expire), the runs stored on 2022-12-09.

Results appeared only projects "postgres" and "curl" (from memcached,tmux,curl,twin,vim,openssl,sqlite,ffmpeg,postgres,libwebm) from checkers StdCLibraryFunctionArgs and Errno.

On the postgres results, the second is one that can be fixed in the checker (add special cases to StdLibraryFunctionsChecker for zero len or size fread and fwrite arguments). The others are false positives because the error path is impossible because implicit constraints (what is not known to the analyzer) on variables.

These curl results look faulty, the last fclose call looks not recognized.

Dec 19 2022, 3:30 AM · Restricted Project, Restricted Project

Dec 13 2022

Szelethus added a comment to D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker..

My current approach is that the POSIX is more strict than the C standard (POSIX allows a subset of what C allows). I do not see (errno related) contradiction between these standards

Dec 13 2022, 4:12 AM · Restricted Project, Restricted Project
Szelethus added inline comments to D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker..
Dec 13 2022, 3:46 AM · Restricted Project, Restricted Project
Szelethus added inline comments to D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker..
Dec 13 2022, 3:44 AM · Restricted Project, Restricted Project
Szelethus added a comment to D137790: [clang][analyzer] Remove report of null stream from StreamChecker..

IIRC we talked about it would only really make sense to evaluate this patch stack as a whole, not piece by piece, but I'm not seeing results on open source projects here either. Can you please post them?

Dec 13 2022, 1:49 AM · Restricted Project, Restricted Project

Dec 11 2022

Szelethus added a comment to D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker..

The patch looks OK now, I'll get to inspecting the others.

The "strange" test failures that showed up earlier were probably caused by a bug that is fixed in the D137722. I just read that this patch is rebased to D137722 too, fixed the dependency stack.

Very well!

There was another problem with circular dependencies (because StdCLibraryFunctionArgsChecker had a dependency to StreamChecker, this is removed in the last patch). The checker option must be not a problem, the checker (StdLibraryFunctionsChecker) can be disabled (but is normally not because it is an apiModeling checker) or the ModelPOSIX option turned off independently if StreamChecker is enabled or not.

Okay, so the checker behaves OK if StdLibraryFunctionsChecker is disabled. As long as it doesn't crash, this is fine, you shouldn't disable it in practice anyways!

The goal (should work at the end of this patch stack) is that StreamChecker can report all bugs that it can find, and there is no case when both checkers report a bug (in different way). If ModelPOSIX is turned off and StreamChecker is enabled, for fseek for example no bug is found if stream is NULL, and value of errno is just invalidated in all cases (like it works if StreamChecker is disabled too), but the stream state and file position is still checked by StreamChecker for all functions.

This sounds reasonable. It means that no parts of StdLibraryFunctionsChecker (including its option) is a "hard" dependency.

Dec 11 2022, 3:06 PM · Restricted Project, Restricted Project
Szelethus added inline comments to D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker..
Dec 11 2022, 2:58 PM · Restricted Project, Restricted Project

Dec 8 2022

Szelethus added a comment to D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker..

I found some anomalies during development:

  • If the checker StdCLibraryFunctions is added as dependency for alpha.unix.Stream in checkers.td I get some "unexplainable" test failures.

Could you please elaborate? I don't see how to help you with it without seeing more details.

Dec 8 2022, 6:32 AM · Restricted Project, Restricted Project

Dec 6 2022

Szelethus added a comment to D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker..

Sorry abour my previous reply, I messed up the thread I was replying to. I better see what is going on.

Dec 6 2022, 7:56 AM · Restricted Project, Restricted Project

Dec 5 2022

Szelethus added a comment to D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker..
Dec 5 2022, 11:54 PM · Restricted Project, Restricted Project

Oct 26 2022

Szelethus committed rGa504ddc8bf9d: [analyzer] Initialize regions returned by CXXNew to undefined (authored by Szelethus).
[analyzer] Initialize regions returned by CXXNew to undefined
Oct 26 2022, 8:22 AM · Restricted Project, Restricted Project
Szelethus closed D135375: [analyzer] Initialize regions returned by CXXNew to undefined.
Oct 26 2022, 8:22 AM · Restricted Project, Restricted Project

Oct 25 2022

Szelethus added a comment to D135375: [analyzer] Initialize regions returned by CXXNew to undefined.

Seems like the issues mentioned above are real, but orthogonal to this patch. Would it be okay to address them in followup patches? @martong @NoQ

Oct 25 2022, 7:20 AM · Restricted Project, Restricted Project

Oct 11 2022

Szelethus added a comment to D135375: [analyzer] Initialize regions returned by CXXNew to undefined.

Some early results:

Oct 11 2022, 5:46 AM · Restricted Project, Restricted Project

Oct 7 2022

Szelethus updated the summary of D135375: [analyzer] Initialize regions returned by CXXNew to undefined.
Oct 7 2022, 1:52 AM · Restricted Project, Restricted Project

Oct 6 2022

Szelethus added a comment to D135375: [analyzer] Initialize regions returned by CXXNew to undefined.

Just a note on the test files -- I've diverged from the usual stance of just changing what the new output is, to modifying the test files. The reason is that reading an undefined value is a fatal error, leading to the analyzer to stop analyzing prematurely, and I think these cases were trying to test something else, not uninitialized value usage.

Oct 6 2022, 10:38 AM · Restricted Project, Restricted Project
Szelethus requested review of D135375: [analyzer] Initialize regions returned by CXXNew to undefined.
Oct 6 2022, 10:32 AM · Restricted Project, Restricted Project

Jul 19 2022

Szelethus updated subscribers of D130055: Clang extensions yolo, woot & kaboom.

Yeah, I'm afraid no fun is allowed on this block. On another note, kaboom is interesting, shouldn't we assume all functions to be kaboom unless proven to be woot?

Jul 19 2022, 4:30 AM · Restricted Project, Restricted Project

Jul 13 2022

Szelethus accepted D127973: [analyzer] Eval construction of non POD type arrays..

I suppose enough has been said! Well done! Please attend to the rest of the inlines and commit at your convenience.

Jul 13 2022, 4:11 AM · Restricted Project, Restricted Project

Jul 12 2022

Szelethus added a comment to D127973: [analyzer] Eval construction of non POD type arrays..

LLVM finished as well, with 2 new warnings! The link above is the complete evaluation of your patch on our benchmark.

Jul 12 2022, 10:15 AM · Restricted Project, Restricted Project
Szelethus added a comment to D127973: [analyzer] Eval construction of non POD type arrays..

Some early results: https://codechecker-demo.eastus.cloudapp.azure.com/Default/reports?run=qtbase_v6.2.0_pod_array_bindings_baseline&run=protobuf_v3.13.0_pod_array_bindings_baseline&items-per-page=100&sort-by=runDate&sort-desc=true&newcheck=qtbase_v6.2.0_pod_array_bindings&newcheck=protobuf_v3.13.0_pod_array_bindings&is-unique=on&diff-type=New

Jul 12 2022, 2:30 AM · Restricted Project, Restricted Project

Jul 7 2022

Szelethus added a comment to D127973: [analyzer] Eval construction of non POD type arrays..

So sorry, I know I took my sweet time -- the patch looks great, and currently I'm running some analysis with it. As soon as I have the results on my hand I'd be happy to share and accept. I added a couple nots here and there, none of them are particularly interesting, feel free to attend to them when we are sure that no meaningful changes are needed to be made.

Jul 7 2022, 5:55 AM · Restricted Project, Restricted Project

Jul 1 2022

Szelethus added a comment to D127643: [Static Analyzer] Structured bindings to data members.

I read https://en.cppreference.com/w/cpp/language/structured_binding carefully, and there are a number of interesting rules that might deserve their own test case, even if this isn't the patch where you solve that issue, or believe that the solution handles it without the need for special case handling.

Jul 1 2022, 3:37 AM · Restricted Project, Restricted Project

Jun 30 2022

Szelethus retitled D127973: [analyzer] Eval construction of non POD type arrays. from [Static Analyzer] Eval construction of non POD type arrays. to [analyzer] Eval construction of non POD type arrays..
Jun 30 2022, 6:15 AM · Restricted Project, Restricted Project
Szelethus added a comment to D128064: [Static Analyzer] Small array binding policy.

No need for post commit fixes, just general observations since I noticed them.

Jun 30 2022, 6:13 AM · Restricted Project, Restricted Project

Jun 28 2022

Szelethus accepted D128716: [analyzer] Fix BindingDecl evaluation for reference types..

I tried poking this from a few directions, like nasty GNU extension types, ObjCObjectPointerType, but those seem orthogonal to this patch. Looks great! I'd wait for someone else's approval as well, as I try my best to pick up the thread.

Jun 28 2022, 5:31 AM · Restricted Project, Restricted Project
Szelethus added inline comments to D128716: [analyzer] Fix BindingDecl evaluation for reference types..
Jun 28 2022, 4:39 AM · Restricted Project, Restricted Project

Jun 6 2022

Szelethus accepted D124738: [Documentation][Clang] Clang LibASTMatchers tutorial typo fix.

LGTM

Jun 6 2022, 10:45 AM · Restricted Project, Restricted Project

Apr 8 2022

Szelethus committed rGfd8e5762f86f: [analyzer] Don't track function calls as control dependencies (authored by Szelethus).
[analyzer] Don't track function calls as control dependencies
Apr 8 2022, 1:19 AM · Restricted Project, Restricted Project
Szelethus closed D116597: [analyzer] Don't track function calls as control dependencies.
Apr 8 2022, 1:18 AM · Restricted Project, Restricted Project

Mar 30 2022

Szelethus added inline comments to D116597: [analyzer] Don't track function calls as control dependencies.
Mar 30 2022, 7:03 AM · Restricted Project, Restricted Project
Szelethus updated the diff for D116597: [analyzer] Don't track function calls as control dependencies.

Fixes according to reviewer comments.

Mar 30 2022, 7:03 AM · Restricted Project, Restricted Project
Szelethus abandoned D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null.

Very well :) Let's abandon this in its current state, I share this sentiment:

Mar 30 2022, 4:43 AM · Restricted Project, Restricted Project

Mar 24 2022

Szelethus accepted D122244: [analyzer] Turn missing tablegen doc entry of a checker into fatal error.

LGTM! You did check whether a missing doc field will actually trigger this error, right?

Mar 24 2022, 1:44 AM · Restricted Project, Restricted Project

Mar 23 2022

Szelethus added a comment to D122285: [analyzer] Add path note tags to standard library function summaries..

LGTM on my end, this is awesome!

Mar 23 2022, 5:53 AM · Restricted Project, Restricted Project

Mar 22 2022

Szelethus added a reviewer for D122150: [clang][analyzer] Add checker for bad use of 'errno'.: ASDenysPetrov.
Mar 22 2022, 5:51 AM · Restricted Project, Restricted Project

Mar 16 2022

Szelethus added a comment to D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals.

Seems like all new files are missing the header blurb about the licence.

Mar 16 2022, 5:02 AM · Restricted Project, Restricted Project

Mar 11 2022

Szelethus accepted D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page.

Nice!

Mar 11 2022, 2:29 AM · Restricted Project, Restricted Project

Mar 8 2022

Szelethus added a comment to D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null.

This check checks must-properties/all-paths properties. This has to be a data flow / CFG-based warning. I don't think there's a way around.

Mar 8 2022, 2:06 AM · Restricted Project, Restricted Project

Mar 6 2022

Szelethus added inline comments to D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null.
Mar 6 2022, 5:53 AM · Restricted Project, Restricted Project

Mar 4 2022

Szelethus requested review of D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null.
Mar 4 2022, 5:42 AM · Restricted Project, Restricted Project

Mar 3 2022

Szelethus committed rGd832078904c6: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators (authored by Szelethus).
[analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators
Mar 3 2022, 2:28 AM · Restricted Project
Szelethus closed D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators.
Mar 3 2022, 2:28 AM · Restricted Project, Restricted Project

Mar 1 2022

Szelethus committed rG32ac21d04909: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs (authored by Szelethus).
[NFC][analyzer] Allow CallDescriptions to be matched with CallExprs
Mar 1 2022, 8:13 AM
Szelethus closed D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.
Mar 1 2022, 8:13 AM · Restricted Project

Feb 25 2022

Szelethus committed rG5048a58a6792: [analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not… (authored by Szelethus).
[analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not…
Feb 25 2022, 7:52 AM
Szelethus closed D120325: [analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not built with it.
Feb 25 2022, 7:52 AM · Restricted Project

Feb 23 2022

Szelethus added inline comments to D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.
Feb 23 2022, 8:29 AM · Restricted Project
Szelethus updated the diff for D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.

Remove a newline.

Feb 23 2022, 8:29 AM · Restricted Project

Feb 22 2022

Szelethus added a comment to D119128: [analyzer] Fix taint propagation by remembering to the location context.

Can we reopen this if the code is not upstream at this time?

Feb 22 2022, 7:54 AM · Restricted Project
Szelethus requested review of D120325: [analyzer] Don't crash if the analyzer-constraint is set to Z3, but llvm is not built with it.
Feb 22 2022, 6:55 AM · Restricted Project

Feb 10 2022

Szelethus accepted D118987: [analyzer] Add failing test case demonstrating buggy taint propagation.

Sorry for the slack, I assumed this was accepted already. Thanks!

Feb 10 2022, 4:24 AM · Restricted Project

Feb 9 2022

Szelethus added inline comments to D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators.
Feb 9 2022, 4:30 AM · Restricted Project, Restricted Project
Szelethus updated the diff for D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators.

Fixes according to reviewer comments.

Feb 9 2022, 4:30 AM · Restricted Project, Restricted Project
Szelethus updated the diff for D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.
  • Rename from .*Imprecise to .*AsWritten.
  • Copy comments to relevant functions.
Feb 9 2022, 3:32 AM · Restricted Project

Feb 8 2022

Szelethus accepted D119245: [analyzer][docs][NFC] Fix some broken links and some cosmetic changes.

Cheers!

Feb 8 2022, 7:52 AM · Restricted Project
Szelethus accepted D119129: [analyzer] Fix taint rule of fgets and setproctitle_init.

LGTM! Unrelated to this review, I don't think the term 'sink' is good in a warning message, are users expected to know what that is?

Feb 8 2022, 1:31 AM · Restricted Project
Szelethus accepted D119128: [analyzer] Fix taint propagation by remembering to the location context.

LGTM!

Feb 8 2022, 12:55 AM · Restricted Project

Feb 7 2022

Szelethus added a comment to D119128: [analyzer] Fix taint propagation by remembering to the location context.

Sounds about right! Just a nit, otherwise LGTM.

Feb 7 2022, 5:27 AM · Restricted Project

Feb 5 2022

Szelethus added a comment to D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.

Now that I remember, the ever so slightly different overloads of ProgramState::getSVal is a prime example I think. I always percieved that I have the means to invoke several of them at any point, but I never really knew which one. Though, to be fair, they were not documented particularly well (at least as I remember it).

Feb 5 2022, 2:41 AM · Restricted Project

Feb 4 2022

Szelethus added a comment to D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.

I strongly belive that this should be an overload to the existing 'matches' API. Maybe add a comment that prefer the other overload if can. But having an overload for that alread implies this anyway.

Feb 4 2022, 9:18 AM · Restricted Project
Szelethus updated the diff for D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators.

Move CallDescription specific changes to D119004.

Feb 4 2022, 9:08 AM · Restricted Project, Restricted Project
Szelethus requested review of D119004: [NFC][analyzer] Allow CallDescriptions to be matched with CallExprs.
Feb 4 2022, 8:23 AM · Restricted Project

Feb 3 2022

Szelethus requested review of D118880: [analyzer] Improve NoOwnershipChangeVisitor's understanding of deallocators.
Feb 3 2022, 1:34 AM · Restricted Project, Restricted Project

Feb 1 2022

Szelethus added a comment to D116597: [analyzer] Don't track function calls as control dependencies.

Ping ^-^

Feb 1 2022, 6:34 AM · Restricted Project, Restricted Project

Jan 24 2022

Szelethus updated the diff for D116597: [analyzer] Don't track function calls as control dependencies.

Fix tests, mention that this is purely a heuristic.

Jan 24 2022, 8:44 AM · Restricted Project, Restricted Project
Szelethus committed rG3ad35ba4dea5: [Templight] Don't display empty strings for names of unnamed template parameters (authored by Szelethus).
[Templight] Don't display empty strings for names of unnamed template parameters
Jan 24 2022, 7:37 AM