The term "next stack offset" is misleading because the next argument is
not necessarily allocated at this offset due to alignment constrains.
It also does not make much sense when allocating arguments at negative
offsets (introduced in a follow-up patch), because the returned offset
would be past the end of the next argument.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/include/llvm/CodeGen/CallingConvLower.h | ||
---|---|---|
178 | Maybe CurrentStackSize would help make it clearer this is a stateful thing which may keep increasing |
llvm/include/llvm/CodeGen/CallingConvLower.h | ||
---|---|---|
178 | I can rename this variable and/or add a comment (there is an equivalent in GISel), |
@dmgreen Could you take a look? This renames some local variables in ARM/AArch64, other targets are less affected.
Maybe CurrentStackSize would help make it clearer this is a stateful thing which may keep increasing