Page MenuHomePhabricator

luke (Luke Lau)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2019, 6:59 AM (19 w, 2 d)

Recent Activity

Jul 15 2019

luke added a comment to D60761: [FunctionAttrs] Remove readonly and writeonly assertion.

@vivekvpandya if possible, please

Jul 15 2019, 8:40 AM · Restricted Project
luke added a reviewer for D60761: [FunctionAttrs] Remove readonly and writeonly assertion: vivekvpandya.
Jul 15 2019, 6:25 AM · Restricted Project
luke updated the diff for D60761: [FunctionAttrs] Remove readonly and writeonly assertion.

Rebase

Jul 15 2019, 3:10 AM · Restricted Project

Jul 12 2019

luke added a comment to D60761: [FunctionAttrs] Remove readonly and writeonly assertion.

ping @homerdin

Jul 12 2019, 1:23 AM · Restricted Project

Jun 18 2019

luke added a comment to D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

@RKSimon @shchenz I don't have commit access, can someone else commit this for me? Thanks

Jun 18 2019, 3:59 AM · Restricted Project

Jun 17 2019

luke updated the diff for D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

Rebase against master

Jun 17 2019, 2:48 AM · Restricted Project
luke added a comment to D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

@RKSimon the X86 vaarg codegen tests seem to be passing now with EXPENSIVE_CHECKS enabled

Jun 17 2019, 2:47 AM · Restricted Project

Jun 13 2019

luke closed D62726: [X86] Use fresh MemOps when emitting VAARG64.
Jun 13 2019, 6:48 AM · Restricted Project
luke added a comment to D62726: [X86] Use fresh MemOps when emitting VAARG64.

@RKSimon I don't have commit access, would you be able to do this?

Jun 13 2019, 4:08 AM · Restricted Project
luke updated the diff for D62726: [X86] Use fresh MemOps when emitting VAARG64.
  • Remove extraneous newline
Jun 13 2019, 3:36 AM · Restricted Project
luke updated the diff for D62726: [X86] Use fresh MemOps when emitting VAARG64.
  • Add getMachineMemOperand overload for setting flags
Jun 13 2019, 3:33 AM · Restricted Project
luke updated the diff for D62726: [X86] Use fresh MemOps when emitting VAARG64.
  • Add getMachineMemOperand overload for setting flags
Jun 13 2019, 3:31 AM · Restricted Project

Jun 7 2019

luke added a reviewer for D62726: [X86] Use fresh MemOps when emitting VAARG64: sunfish.
Jun 7 2019, 1:48 AM · Restricted Project

Jun 4 2019

luke added inline comments to D62726: [X86] Use fresh MemOps when emitting VAARG64.
Jun 4 2019, 2:46 AM · Restricted Project
luke updated the diff for D62726: [X86] Use fresh MemOps when emitting VAARG64.

Remember other flags when cloning

Jun 4 2019, 2:41 AM · Restricted Project

May 31 2019

luke added inline comments to D62726: [X86] Use fresh MemOps when emitting VAARG64.
May 31 2019, 2:46 AM · Restricted Project
luke added a comment to D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

I've created a separate patch for this assertion

May 31 2019, 2:45 AM · Restricted Project
luke created D62726: [X86] Use fresh MemOps when emitting VAARG64.
May 31 2019, 2:42 AM · Restricted Project
luke added a comment to D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

Building this locally with EXPENSIVE_CHECKS enabled causes a large number of warnings in the x86 test:

    • Bad machine code: Missing mayStore flag ***
  • function: test_large_vec_vaarg
  • basic block: %bb.0 (0x25e70f4da58)
  • instruction: %11:gr32 = MOV32rm %stack.0.args, 1, $noreg, 0, $noreg :: (load store 8 on %ir.args)
May 31 2019, 2:31 AM · Restricted Project

May 28 2019

luke added a comment to D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

@RKSimon @shchenz Thanks. I don't have commit rights, would someone else mind landing this instead?

May 28 2019, 4:08 AM · Restricted Project

May 27 2019

luke added inline comments to D60762: [SelectionDAG] Legalize vaargs that require vector splitting.
May 27 2019, 9:03 AM · Restricted Project
luke updated the diff for D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

Get alignment from new vector type

May 27 2019, 9:02 AM · Restricted Project

May 23 2019

luke updated the diff for D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

Remove stray CHECK

May 23 2019, 7:39 AM · Restricted Project
luke added a comment to D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

Adding some PowerPC people to double check

May 23 2019, 7:37 AM · Restricted Project
luke updated the diff for D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

Removed endianness swapping and added PowerPC BE/LE test: (I'm not familiar with it: does this look ok?)

May 23 2019, 7:28 AM · Restricted Project
luke added reviewers for D60761: [FunctionAttrs] Remove readonly and writeonly assertion: evandro, rnk.
May 23 2019, 2:41 AM · Restricted Project
luke added inline comments to D60762: [SelectionDAG] Legalize vaargs that require vector splitting.
May 23 2019, 2:36 AM · Restricted Project

May 22 2019

luke updated the diff for D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

Run update_llc_test_checks.py

May 22 2019, 8:25 AM · Restricted Project

May 21 2019

luke updated the diff for D60762: [SelectionDAG] Legalize vaargs that require vector splitting.

Add full context to the patch

May 21 2019, 5:47 AM · Restricted Project

May 20 2019

luke added reviewers for D60762: [SelectionDAG] Legalize vaargs that require vector splitting: RKSimon, tpr.
May 20 2019, 2:51 AM · Restricted Project

Apr 26 2019

luke added a comment to D60761: [FunctionAttrs] Remove readonly and writeonly assertion.

@jdoerfert Can you commit this?

Apr 26 2019, 6:46 AM · Restricted Project

Apr 17 2019

luke added a comment to D60761: [FunctionAttrs] Remove readonly and writeonly assertion.

Hopefully not!
Also just a heads up, I don't have commit access to land this

Apr 17 2019, 8:12 AM · Restricted Project

Apr 16 2019

luke created D60762: [SelectionDAG] Legalize vaargs that require vector splitting.
Apr 16 2019, 1:36 AM · Restricted Project
luke created D60761: [FunctionAttrs] Remove readonly and writeonly assertion.
Apr 16 2019, 1:30 AM · Restricted Project