Page MenuHomePhabricator

yusra.syeda (Yusra Syeda)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2020, 11:40 AM (134 w, 2 h)

Recent Activity

Tue, Jul 19

yusra.syeda committed rG6fb27bc2e3ea: [SystemZ][z/OS] Introduce CCAssignToRegAndStack to calling convention (authored by yusra.syeda).
[SystemZ][z/OS] Introduce CCAssignToRegAndStack to calling convention
Tue, Jul 19, 10:58 AM · Restricted Project, Restricted Project
yusra.syeda closed D127328: [Systemz/z/OS] Introduce CCAssignToRegAndStack to calling convention.
Tue, Jul 19, 10:57 AM · Restricted Project, Restricted Project

Jun 10 2022

yusra.syeda updated the diff for D127328: [Systemz/z/OS] Introduce CCAssignToRegAndStack to calling convention.

Update documentation for CCAssignToRegAndStack in WritingAnLLVMBackend.rst

Jun 10 2022, 12:00 PM · Restricted Project, Restricted Project
yusra.syeda updated the summary of D127328: [Systemz/z/OS] Introduce CCAssignToRegAndStack to calling convention.
Jun 10 2022, 10:55 AM · Restricted Project, Restricted Project
yusra.syeda committed rG487ace4c7362: [SystemZ][z/OS] Add llvm.read_register() intrinsic support for zOS (authored by yusra.syeda).
[SystemZ][z/OS] Add llvm.read_register() intrinsic support for zOS
Jun 10 2022, 9:30 AM · Restricted Project, Restricted Project
yusra.syeda closed D127412: [Systemz/z/OS] Add llvm.read_register() intrinsic support for zOS.
Jun 10 2022, 9:30 AM · Restricted Project, Restricted Project

Jun 9 2022

yusra.syeda requested review of D127412: [Systemz/z/OS] Add llvm.read_register() intrinsic support for zOS.
Jun 9 2022, 9:04 AM · Restricted Project, Restricted Project

Jun 8 2022

yusra.syeda requested review of D127328: [Systemz/z/OS] Introduce CCAssignToRegAndStack to calling convention.
Jun 8 2022, 11:44 AM · Restricted Project, Restricted Project

May 18 2022

yusra.syeda committed rG1e14b1a7977b: [SystemZ][z/OS] Add missing include to llvm/include/llvm/BinaryFormat/GOFF.h (authored by yusra.syeda).
[SystemZ][z/OS] Add missing include to llvm/include/llvm/BinaryFormat/GOFF.h
May 18 2022, 1:00 PM · Restricted Project, Restricted Project
yusra.syeda closed D125921: [SystemZ][z/OS] Add missing include .
May 18 2022, 12:59 PM · Restricted Project, Restricted Project
yusra.syeda added a comment to D125725: [SystemZ][z/OS] Add PPA1 support.

Hey @yusra.syeda ! It looks like your patch broke the macOS lldb bot: https://green.lab.llvm.org/green/job/lldb-cmake/

/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/BinaryFormat/GOFF.h:23:23: error: missing '#include <_types/_uint8_t.h>'; 'uint8_t' must be declared before it is used
enum SubsectionKind : uint8_t {
                      ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/_types/_uint8_t.h:31:23: note: declaration here is not visible
typedef unsigned char uint8_t;

You're basically missing an include. Let me know if you need help reproducing / fixing this 🙂

May 18 2022, 12:51 PM · Restricted Project, Restricted Project
yusra.syeda requested review of D125921: [SystemZ][z/OS] Add missing include .
May 18 2022, 12:50 PM · Restricted Project, Restricted Project
yusra.syeda committed rG5ac411aea802: [SystemZ][z/OS] Add the PPA1 to SystemZAsmPrinter (authored by yusra.syeda).
[SystemZ][z/OS] Add the PPA1 to SystemZAsmPrinter
May 18 2022, 11:13 AM · Restricted Project, Restricted Project
yusra.syeda closed D125725: [SystemZ][z/OS] Add PPA1 support.
May 18 2022, 11:13 AM · Restricted Project, Restricted Project

May 17 2022

yusra.syeda updated the diff for D125725: [SystemZ][z/OS] Add PPA1 support.

apply clang format

May 17 2022, 8:49 AM · Restricted Project, Restricted Project

May 16 2022

yusra.syeda requested review of D125725: [SystemZ][z/OS] Add PPA1 support.
May 16 2022, 1:37 PM · Restricted Project, Restricted Project

Jan 5 2022

yusra.syeda updated the diff for D115269: [SystemZ][z/OS] Add entry point marker to PPA.

Rebasing on latest main

Jan 5 2022, 7:14 AM · Restricted Project

Dec 14 2021

yusra.syeda updated the diff for D115269: [SystemZ][z/OS] Add entry point marker to PPA.

Removed the FIXME

Dec 14 2021, 10:53 AM · Restricted Project

Dec 7 2021

yusra.syeda edited reviewers for D115269: [SystemZ][z/OS] Add entry point marker to PPA, added: Everybody0523; removed: neumannh.
Dec 7 2021, 11:02 AM · Restricted Project
yusra.syeda added reviewers for D115269: [SystemZ][z/OS] Add entry point marker to PPA: Kai, uweigand, neumannh.
Dec 7 2021, 11:01 AM · Restricted Project
yusra.syeda requested review of D115269: [SystemZ][z/OS] Add entry point marker to PPA.
Dec 7 2021, 10:59 AM · Restricted Project

Aug 19 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Removed unnecessary white space, empty constructors, and addressed minor comments

Aug 19 2021, 1:03 PM · Restricted Project

Jul 5 2021

yusra.syeda accepted D105204: [MCParser][z/OS] Mark a few tests as unsupported for the z/OS Target.

LGTM

Jul 5 2021, 8:05 AM · Restricted Project

Jun 28 2021

yusra.syeda added inline comments to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.
Jun 28 2021, 1:37 PM · Restricted Project
yusra.syeda added a comment to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

Say, I can't find any file in the llvm repository named "GOFF*". They don't show up on Github, either, so I'm not sure what's going on. Where is the GOFF support in the LLVM tree currently? There's no "https://github.com/llvm/llvm-project/tree/main/llvm/lib/Object/GOFFObjectFile.cpp", for example.

Jun 28 2021, 1:36 PM · Restricted Project
yusra.syeda updated the diff for D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

Removed unused enum and a redundant if statement

Jun 28 2021, 1:30 PM · Restricted Project

Jun 16 2021

yusra.syeda added inline comments to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.
Jun 16 2021, 1:43 PM · Restricted Project

Jun 15 2021

yusra.syeda added inline comments to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.
Jun 15 2021, 2:36 PM · Restricted Project
yusra.syeda updated the diff for D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

Updated the unit test and cleaned up return statements

Jun 15 2021, 2:31 PM · Restricted Project

Jun 14 2021

yusra.syeda added inline comments to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.
Jun 14 2021, 12:29 PM · Restricted Project

Jun 11 2021

yusra.syeda added inline comments to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.
Jun 11 2021, 7:22 AM · Restricted Project
yusra.syeda updated the diff for D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

Update the getElementEsdId function

Jun 11 2021, 7:19 AM · Restricted Project

Jun 10 2021

yusra.syeda updated the diff for D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

Removed unused functions, and addressed some more review comments

Jun 10 2021, 7:19 AM · Restricted Project

Jun 9 2021

yusra.syeda updated the diff for D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

Address comments in the unit test

Jun 9 2021, 11:40 AM · Restricted Project

Jun 8 2021

yusra.syeda added a comment to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

ping :)

Jun 8 2021, 2:11 PM · Restricted Project

Jun 4 2021

yusra.syeda abandoned D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Jun 4 2021, 8:53 AM · Restricted Project

Jun 1 2021

yusra.syeda added reviewers for D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader: Kai, jhenderson, kpn, MaskRay, uweigand.
Jun 1 2021, 1:45 PM · Restricted Project
yusra.syeda requested review of D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.
Jun 1 2021, 1:41 PM · Restricted Project

May 28 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Fixed typo

May 28 2021, 6:42 AM · Restricted Project

May 27 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Changed variable type from int to size_t for RecordNum variable, fixed build error, and added size to enums

May 27 2021, 7:07 AM · Restricted Project

May 26 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
May 26 2021, 8:02 PM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Moved function body of the getData function to GOFFObjectFile.cpp to avoid clang tidy warning

May 26 2021, 8:01 PM · Restricted Project
yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
May 26 2021, 3:28 PM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Added record number to the error messages

May 26 2021, 3:24 PM · Restricted Project

May 25 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Fixed typo

May 25 2021, 6:38 AM · Restricted Project

May 19 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
May 19 2021, 2:11 PM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Added more detail to error messages
Added missing include

May 19 2021, 2:09 PM · Restricted Project

May 17 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
May 17 2021, 12:12 PM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Removed setters from llvm/include/llvm/Object/GOFF.h.
I will add more details to the error messages in the next update.

May 17 2021, 12:08 PM · Restricted Project

May 14 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
May 14 2021, 11:20 AM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Fixed function naming style

May 14 2021, 11:15 AM · Restricted Project

May 12 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Moved non trivial function out of header file and into llvm/lib/Object/GOFFObjectFile.cpp

May 12 2021, 1:16 PM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Addressed comments and cleaned up code to adhere to LLVM style

May 12 2021, 10:49 AM · Restricted Project

May 11 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Addressed some comments and added the following tests:
Check for invalid symbol types
Check for invalid external reference executable types
Check if a record is a continuation, then the previous record should be marked as continued
Check that the last continuation record is terminated correctly

May 11 2021, 11:23 AM · Restricted Project

Apr 30 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Apr 30 2021, 8:19 AM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Added the following tests:
Invalid cases of continutation records
Check for missing HDR record
Check for missing END record
Handling of concatenated GOFF object files

Apr 30 2021, 8:14 AM · Restricted Project

Apr 19 2021

yusra.syeda added a comment to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Ping :)

Apr 19 2021, 7:54 AM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Clean up some formatting

Apr 19 2021, 7:31 AM · Restricted Project

Apr 14 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Apr 14 2021, 2:49 PM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Address comment regarding removing unnecessary variables
Address clang tidy suggestion

Apr 14 2021, 2:48 PM · Restricted Project

Apr 9 2021

yusra.syeda added a comment to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
In D98437#2672051, @kpn wrote:

The convention here is to wait a week or so before a ping, and the same between pings.

Apr 9 2021, 11:39 AM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Added more error checking

Apr 9 2021, 11:24 AM · Restricted Project

Apr 6 2021

yusra.syeda added a comment to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Double ping :) All comments have been addressed. Reviewers, please have a look.

Apr 6 2021, 6:51 AM · Restricted Project

Apr 1 2021

yusra.syeda added a comment to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Ping :)

Apr 1 2021, 8:29 AM · Restricted Project

Mar 31 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Removed Mask variable in getBits function

Mar 31 2021, 7:59 AM · Restricted Project

Mar 30 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Mar 30 2021, 11:58 AM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Address more formatting comments

Mar 30 2021, 11:53 AM · Restricted Project

Mar 29 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Addressed formatting comments

Mar 29 2021, 10:58 AM · Restricted Project

Mar 25 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Added test for ESD continuation records, and for 2 symbols in the symbol table

Mar 25 2021, 2:37 PM · Restricted Project

Mar 23 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Mar 23 2021, 7:20 AM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Updated handling of continuation records
Addressed other comments in the patch

Mar 23 2021, 7:13 AM · Restricted Project

Mar 15 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Mar 15 2021, 2:06 PM · Restricted Project

Mar 11 2021

yusra.syeda added a comment to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

I created a smaller patch supporting just the HDR, ESD and END records here: https://reviews.llvm.org/D98437. Please continue the review in the new patch.

Mar 11 2021, 10:24 AM · Restricted Project
yusra.syeda retitled D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records from Add GOFFObjectFile class support for HDR, ESD and END records to [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Mar 11 2021, 10:15 AM · Restricted Project
yusra.syeda requested review of D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Mar 11 2021, 10:12 AM · Restricted Project

Mar 9 2021

yusra.syeda added a comment to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
In D89071#2614095, @kpn wrote:

The majority of your code is still untested as far as I can see. There appear to be three test cases you have so far:

  1. An invalid size for a GOFF object.
  2. A valid size for a GOFF object.
  3. That getSymbolName returns the name of a single symbol in the symbol table.

What about all the rest of the functionality that is included in this patch, including, but certainly not limited to, the following?

  1. More than one symbol in the symbol table.
  2. Other properties of symbols.
  3. The various properties of records.
  4. Relocations.
  5. And so on...

For each bit of code you have written, consider whether a test would fail if that bit of code was broken in some way, or didn't exist. If no test fails, then that code needs a new test case of some form. There may also be other cases where testing is appropriate, e.g. where two separate aspects of the same system interact in some way, although those are harder to judge.

Here's an idea: I found, at least when running in batch, that the Binder (linker) will link an object consisting of nothing more than a HDR card, then ESD cards followed by an END card (meaning, just symbols). It will also link an object consisting of HDR, ESD, TXT, and END cards with zero relocations. Does it work that way when not running in batch? Because if it does then it might make sense to split this ticket up into a new ticket with just support for HDR+ESD+END cards.

That would make this patch smaller, and it would reduce the amount of tests that need to be written to get some initial GOFF support into the tree. The tests that @jhenderson requested would still be needed, but you'd only need the ones that were relevant to the smaller amount of code in the new ticket. A new ticket should refer back to this ticket because this ticket shows the direction you are going, and it has a bunch of comments that should probably be left for posterity. Later tickets can build on this foundation.

The LLVM community tends to prefer smaller patches over larger ones. Typically, anyway.

It's an idea. Thoughts?

Mar 9 2021, 11:11 AM · Restricted Project

Mar 8 2021

yusra.syeda retitled D98199: [SystemZ][NFC] Renaming of ELF specific variables from [SystemZ] Renaming of ELF specific variables to [SystemZ][NFC] Renaming of ELF specific variables.
Mar 8 2021, 11:20 AM · Restricted Project
yusra.syeda retitled D98199: [SystemZ][NFC] Renaming of ELF specific variables from Renaming of ELF specific variables to [SystemZ] Renaming of ELF specific variables.
Mar 8 2021, 10:42 AM · Restricted Project
yusra.syeda requested review of D98199: [SystemZ][NFC] Renaming of ELF specific variables.
Mar 8 2021, 10:39 AM · Restricted Project

Mar 1 2021

yusra.syeda added a comment to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

I've not reviewed the testing yet, but my immediate thought is that there needs to be a lot more, handling all the different code paths.

@jhenderson can you please review the testing? Currently the tests construct a GOFF object with a valid sized record (80 bytes), an invalid sized record (!80 bytes), and obtains the symbol name from the ESD record. Testing for relocations will be added in a future patch.

Mar 1 2021, 1:25 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Added size to ESDExecutable enum
Reformatted unit tests

Mar 1 2021, 1:00 PM · Restricted Project

Feb 17 2021

yusra.syeda added reviewers for D96887: [SystemZ/z/OS] Initial changes to add the XPLink calling convention to tablegen: uweigand, Kai, MaskRay, anirudhp.
Feb 17 2021, 12:06 PM · Restricted Project
yusra.syeda requested review of D96887: [SystemZ/z/OS] Initial changes to add the XPLink calling convention to tablegen.
Feb 17 2021, 11:44 AM · Restricted Project
yusra.syeda added reviewers for D96867: [SystemZ] Separate LoZ ELF specifics in tablegen: uweigand, Kai, MaskRay, anirudhp.
Feb 17 2021, 7:10 AM · Restricted Project
yusra.syeda requested review of D96867: [SystemZ] Separate LoZ ELF specifics in tablegen.
Feb 17 2021, 7:05 AM · Restricted Project

Jan 8 2021

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Jan 8 2021, 1:43 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Fix error message formatting

Jan 8 2021, 1:38 PM · Restricted Project

Dec 18 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Apply clang format suggestion

Dec 18 2020, 11:57 AM · Restricted Project
yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Dec 18 2020, 11:53 AM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Update error statement, clean up getSymbolName function, add size to enum

Dec 18 2020, 11:35 AM · Restricted Project

Dec 15 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Dec 15 2020, 12:01 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Fix typo

Dec 15 2020, 11:59 AM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Change return type of getSymbolType function from Error to Expected<StringRef>
Also remove StringRef parameter passed by reference to the function
Update error messages to be more descriptive

Dec 15 2020, 11:56 AM · Restricted Project

Dec 14 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Dec 14 2020, 12:49 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Return Error instead of error_code for function getSymbolName
Address other review comments

Dec 14 2020, 11:31 AM · Restricted Project

Dec 9 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Added unit test GOFFObjectFileTest.cpp, and added GOFF case in TestFileMagic.cpp
Addressed more review comments

Dec 9 2020, 8:26 AM · Restricted Project

Nov 24 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 24 2020, 12:50 PM · Restricted Project

Nov 23 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 23 2020, 3:13 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Remove setERSymbolType and getERSymbolType functions

Nov 23 2020, 3:12 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Remove return after llvm_unreachable statement

Nov 23 2020, 11:57 AM · Restricted Project