Page MenuHomePhabricator

yusra.syeda (Yusra Syeda)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2020, 11:40 AM (73 w, 3 d)

Recent Activity

Yesterday

yusra.syeda added inline comments to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.
Wed, Jun 16, 1:43 PM · Restricted Project

Tue, Jun 15

yusra.syeda added inline comments to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.
Tue, Jun 15, 2:36 PM · Restricted Project
yusra.syeda updated the diff for D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

Updated the unit test and cleaned up return statements

Tue, Jun 15, 2:31 PM · Restricted Project

Mon, Jun 14

yusra.syeda added inline comments to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.
Mon, Jun 14, 12:29 PM · Restricted Project

Fri, Jun 11

yusra.syeda added inline comments to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.
Fri, Jun 11, 7:22 AM · Restricted Project
yusra.syeda updated the diff for D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

Update the getElementEsdId function

Fri, Jun 11, 7:19 AM · Restricted Project

Thu, Jun 10

yusra.syeda updated the diff for D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

Removed unused functions, and addressed some more review comments

Thu, Jun 10, 7:19 AM · Restricted Project

Wed, Jun 9

yusra.syeda updated the diff for D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

Address comments in the unit test

Wed, Jun 9, 11:40 AM · Restricted Project

Tue, Jun 8

yusra.syeda added a comment to D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.

ping :)

Tue, Jun 8, 2:11 PM · Restricted Project

Fri, Jun 4

yusra.syeda abandoned D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Fri, Jun 4, 8:53 AM · Restricted Project

Tue, Jun 1

yusra.syeda added reviewers for D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader: Kai, jhenderson, kpn, MaskRay, uweigand.
Tue, Jun 1, 1:45 PM · Restricted Project
yusra.syeda requested review of D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader.
Tue, Jun 1, 1:41 PM · Restricted Project

Fri, May 28

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Fixed typo

Fri, May 28, 6:42 AM · Restricted Project

Thu, May 27

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Changed variable type from int to size_t for RecordNum variable, fixed build error, and added size to enums

Thu, May 27, 7:07 AM · Restricted Project

Wed, May 26

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Wed, May 26, 8:02 PM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Moved function body of the getData function to GOFFObjectFile.cpp to avoid clang tidy warning

Wed, May 26, 8:01 PM · Restricted Project
yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Wed, May 26, 3:28 PM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Added record number to the error messages

Wed, May 26, 3:24 PM · Restricted Project

Tue, May 25

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Fixed typo

Tue, May 25, 6:38 AM · Restricted Project

Wed, May 19

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Wed, May 19, 2:11 PM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Added more detail to error messages
Added missing include

Wed, May 19, 2:09 PM · Restricted Project

May 17 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
May 17 2021, 12:12 PM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Removed setters from llvm/include/llvm/Object/GOFF.h.
I will add more details to the error messages in the next update.

May 17 2021, 12:08 PM · Restricted Project

May 14 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
May 14 2021, 11:20 AM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Fixed function naming style

May 14 2021, 11:15 AM · Restricted Project

May 12 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Moved non trivial function out of header file and into llvm/lib/Object/GOFFObjectFile.cpp

May 12 2021, 1:16 PM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Addressed comments and cleaned up code to adhere to LLVM style

May 12 2021, 10:49 AM · Restricted Project

May 11 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Addressed some comments and added the following tests:
Check for invalid symbol types
Check for invalid external reference executable types
Check if a record is a continuation, then the previous record should be marked as continued
Check that the last continuation record is terminated correctly

May 11 2021, 11:23 AM · Restricted Project

Apr 30 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Apr 30 2021, 8:19 AM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Added the following tests:
Invalid cases of continutation records
Check for missing HDR record
Check for missing END record
Handling of concatenated GOFF object files

Apr 30 2021, 8:14 AM · Restricted Project

Apr 19 2021

yusra.syeda added a comment to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Ping :)

Apr 19 2021, 7:54 AM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Clean up some formatting

Apr 19 2021, 7:31 AM · Restricted Project

Apr 14 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Apr 14 2021, 2:49 PM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Address comment regarding removing unnecessary variables
Address clang tidy suggestion

Apr 14 2021, 2:48 PM · Restricted Project

Apr 9 2021

yusra.syeda added a comment to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
In D98437#2672051, @kpn wrote:

The convention here is to wait a week or so before a ping, and the same between pings.

Apr 9 2021, 11:39 AM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Added more error checking

Apr 9 2021, 11:24 AM · Restricted Project

Apr 6 2021

yusra.syeda added a comment to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Double ping :) All comments have been addressed. Reviewers, please have a look.

Apr 6 2021, 6:51 AM · Restricted Project

Apr 1 2021

yusra.syeda added a comment to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Ping :)

Apr 1 2021, 8:29 AM · Restricted Project

Mar 31 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Removed Mask variable in getBits function

Mar 31 2021, 7:59 AM · Restricted Project

Mar 30 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Mar 30 2021, 11:58 AM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Address more formatting comments

Mar 30 2021, 11:53 AM · Restricted Project

Mar 29 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Addressed formatting comments

Mar 29 2021, 10:58 AM · Restricted Project

Mar 25 2021

yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Added test for ESD continuation records, and for 2 symbols in the symbol table

Mar 25 2021, 2:37 PM · Restricted Project

Mar 23 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Mar 23 2021, 7:20 AM · Restricted Project
yusra.syeda updated the diff for D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.

Updated handling of continuation records
Addressed other comments in the patch

Mar 23 2021, 7:13 AM · Restricted Project

Mar 15 2021

yusra.syeda added inline comments to D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Mar 15 2021, 2:06 PM · Restricted Project

Mar 11 2021

yusra.syeda added a comment to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

I created a smaller patch supporting just the HDR, ESD and END records here: https://reviews.llvm.org/D98437. Please continue the review in the new patch.

Mar 11 2021, 10:24 AM · Restricted Project
yusra.syeda retitled D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records from Add GOFFObjectFile class support for HDR, ESD and END records to [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Mar 11 2021, 10:15 AM · Restricted Project
yusra.syeda requested review of D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records.
Mar 11 2021, 10:12 AM · Restricted Project

Mar 9 2021

yusra.syeda added a comment to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
In D89071#2614095, @kpn wrote:

The majority of your code is still untested as far as I can see. There appear to be three test cases you have so far:

  1. An invalid size for a GOFF object.
  2. A valid size for a GOFF object.
  3. That getSymbolName returns the name of a single symbol in the symbol table.

What about all the rest of the functionality that is included in this patch, including, but certainly not limited to, the following?

  1. More than one symbol in the symbol table.
  2. Other properties of symbols.
  3. The various properties of records.
  4. Relocations.
  5. And so on...

For each bit of code you have written, consider whether a test would fail if that bit of code was broken in some way, or didn't exist. If no test fails, then that code needs a new test case of some form. There may also be other cases where testing is appropriate, e.g. where two separate aspects of the same system interact in some way, although those are harder to judge.

Here's an idea: I found, at least when running in batch, that the Binder (linker) will link an object consisting of nothing more than a HDR card, then ESD cards followed by an END card (meaning, just symbols). It will also link an object consisting of HDR, ESD, TXT, and END cards with zero relocations. Does it work that way when not running in batch? Because if it does then it might make sense to split this ticket up into a new ticket with just support for HDR+ESD+END cards.

That would make this patch smaller, and it would reduce the amount of tests that need to be written to get some initial GOFF support into the tree. The tests that @jhenderson requested would still be needed, but you'd only need the ones that were relevant to the smaller amount of code in the new ticket. A new ticket should refer back to this ticket because this ticket shows the direction you are going, and it has a bunch of comments that should probably be left for posterity. Later tickets can build on this foundation.

The LLVM community tends to prefer smaller patches over larger ones. Typically, anyway.

It's an idea. Thoughts?

Mar 9 2021, 11:11 AM · Restricted Project

Mar 8 2021

yusra.syeda retitled D98199: [SystemZ][NFC] Renaming of ELF specific variables from [SystemZ] Renaming of ELF specific variables to [SystemZ][NFC] Renaming of ELF specific variables.
Mar 8 2021, 11:20 AM · Restricted Project
yusra.syeda retitled D98199: [SystemZ][NFC] Renaming of ELF specific variables from Renaming of ELF specific variables to [SystemZ] Renaming of ELF specific variables.
Mar 8 2021, 10:42 AM · Restricted Project
yusra.syeda requested review of D98199: [SystemZ][NFC] Renaming of ELF specific variables.
Mar 8 2021, 10:39 AM · Restricted Project

Mar 1 2021

yusra.syeda added a comment to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

I've not reviewed the testing yet, but my immediate thought is that there needs to be a lot more, handling all the different code paths.

@jhenderson can you please review the testing? Currently the tests construct a GOFF object with a valid sized record (80 bytes), an invalid sized record (!80 bytes), and obtains the symbol name from the ESD record. Testing for relocations will be added in a future patch.

Mar 1 2021, 1:25 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Added size to ESDExecutable enum
Reformatted unit tests

Mar 1 2021, 1:00 PM · Restricted Project

Feb 17 2021

yusra.syeda added reviewers for D96887: [SystemZ/z/OS] Initial changes to add the XPLink calling convention to tablegen: uweigand, Kai, MaskRay, anirudhp.
Feb 17 2021, 12:06 PM · Restricted Project
yusra.syeda requested review of D96887: [SystemZ/z/OS] Initial changes to add the XPLink calling convention to tablegen.
Feb 17 2021, 11:44 AM · Restricted Project
yusra.syeda added reviewers for D96867: [SystemZ] Separate LoZ ELF specifics in tablegen: uweigand, Kai, MaskRay, anirudhp.
Feb 17 2021, 7:10 AM · Restricted Project
yusra.syeda requested review of D96867: [SystemZ] Separate LoZ ELF specifics in tablegen.
Feb 17 2021, 7:05 AM · Restricted Project

Jan 8 2021

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Jan 8 2021, 1:43 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Fix error message formatting

Jan 8 2021, 1:38 PM · Restricted Project

Dec 18 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Apply clang format suggestion

Dec 18 2020, 11:57 AM · Restricted Project
yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Dec 18 2020, 11:53 AM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Update error statement, clean up getSymbolName function, add size to enum

Dec 18 2020, 11:35 AM · Restricted Project

Dec 15 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Dec 15 2020, 12:01 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Fix typo

Dec 15 2020, 11:59 AM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Change return type of getSymbolType function from Error to Expected<StringRef>
Also remove StringRef parameter passed by reference to the function
Update error messages to be more descriptive

Dec 15 2020, 11:56 AM · Restricted Project

Dec 14 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Dec 14 2020, 12:49 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Return Error instead of error_code for function getSymbolName
Address other review comments

Dec 14 2020, 11:31 AM · Restricted Project

Dec 9 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Added unit test GOFFObjectFileTest.cpp, and added GOFF case in TestFileMagic.cpp
Addressed more review comments

Dec 9 2020, 8:26 AM · Restricted Project

Nov 24 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 24 2020, 12:50 PM · Restricted Project

Nov 23 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 23 2020, 3:13 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Remove setERSymbolType and getERSymbolType functions

Nov 23 2020, 3:12 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Remove return after llvm_unreachable statement

Nov 23 2020, 11:57 AM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Add check for ESD name length field size
Update loops to comply with LLVM coding standard:
https://llvm.org/docs/CodingStandards.html#don-t-evaluate-end-every-time-through-a-loop

Nov 23 2020, 11:39 AM · Restricted Project

Nov 17 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Clean up some cast statements from const uint8_t * to const char *

Nov 17 2020, 1:54 PM · Restricted Project
yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 17 2020, 8:36 AM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Change errorCodeToError to createStringError in GOFFObjectFile constructor

Nov 17 2020, 8:32 AM · Restricted Project

Nov 13 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Address formatting comments

Nov 13 2020, 1:27 PM · Restricted Project
yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 13 2020, 9:38 AM · Restricted Project

Nov 12 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Address some formatting comments

Nov 12 2020, 1:20 PM · Restricted Project

Nov 10 2020

yusra.syeda added a comment to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

@jhenderson the comments you left have been addressed. Are there any other suggestions you have?

Nov 10 2020, 11:10 AM · Restricted Project

Nov 3 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 3 2020, 1:12 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update cleans up reinterpret_cast<> statements in GOFFObjectFile related to EsdPtrs, TextPtrs, and RldPtrs

Nov 3 2020, 10:48 AM · Restricted Project

Oct 30 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Oct 30 2020, 2:26 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update cleans up GOFF.h by replacing various set/get functions with templated functions.

Oct 30 2020, 2:18 PM · Restricted Project

Oct 28 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This updates the function createGOFFObjectFile to use Error instead of std::error_code as described in https://llvm.org/docs/ProgrammersManual.html#fallible-constructors

Oct 28 2020, 12:45 PM · Restricted Project

Oct 27 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Update llvm/include/llvm/Object/GOFF.h to consider endianness of the host system for parsing GOFF records.

Oct 27 2020, 9:42 AM · Restricted Project

Oct 23 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Oct 23 2020, 1:52 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update removes the RLDRelocationType enum from llvm/include/llvm/BinaryFormat/GOFF.h and clarifies comments regarding endianness.

Oct 23 2020, 1:49 PM · Restricted Project

Oct 20 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update removes variable definitions which are used only in the immediate next line and not used elsewhere.

Oct 20 2020, 11:23 AM · Restricted Project

Oct 19 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update fixes formatting issues, along with stubbing functions that are unnecessary
to implement for the time being from the GOFFObjectFile class

Oct 19 2020, 11:39 AM · Restricted Project

Oct 8 2020

yusra.syeda abandoned D88749: [SystemZ/z/OS] Add GOFF reader.

This patch has been broken down into the following 3 patches:
https://reviews.llvm.org/D89071
https://reviews.llvm.org/D89073
https://reviews.llvm.org/D89074

Oct 8 2020, 2:21 PM · Restricted Project
yusra.syeda updated the summary of D89074: [SystemZ/z/OS] Add GOFF support for llvm-objdump.
Oct 8 2020, 2:19 PM · Restricted Project
yusra.syeda requested review of D89074: [SystemZ/z/OS] Add GOFF support for llvm-objdump.
Oct 8 2020, 2:14 PM · Restricted Project
yusra.syeda updated the summary of D89073: [SystemZ/z/OS] Add the GOFFDumper.
Oct 8 2020, 2:11 PM · Restricted Project
yusra.syeda requested review of D89073: [SystemZ/z/OS] Add the GOFFDumper.
Oct 8 2020, 2:08 PM · Restricted Project
yusra.syeda retitled D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format from Add GOFFObjectFile class and details of GOFF file format to [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Oct 8 2020, 2:02 PM · Restricted Project
yusra.syeda requested review of D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Oct 8 2020, 1:56 PM · Restricted Project

Oct 6 2020

yusra.syeda added a comment to D88749: [SystemZ/z/OS] Add GOFF reader.

It looks to me like you uploaded the wrong diff. You need to upload a diff of your entire final commit that this will be committed as, when making edits to the code. If you intend to upload a series of individual commits, and want them all reviewed together, you should create separate patches for each of them and link them together using the "edit related objects" option to create a patch series.

This patch adds support for a large number of different dumping options all at once. Please break it down into separate smaller pieces. For example, your first patch could just create the GOFFDumper, and do nothing with it, the next adds section header support, the next symbol table support and so on. It is not going to be straightforward to review such a large piece of work all at once.

Oct 6 2020, 9:44 AM · Restricted Project