- User Since
- Jan 20 2020, 11:40 AM (52 w, 1 d)
Fri, Jan 8
Fix error message formatting
Dec 18 2020
Apply clang format suggestion
Update error statement, clean up getSymbolName function, add size to enum
Dec 15 2020
Change return type of getSymbolType function from Error to Expected<StringRef>
Also remove StringRef parameter passed by reference to the function
Update error messages to be more descriptive
Dec 14 2020
Return Error instead of error_code for function getSymbolName
Address other review comments
Dec 9 2020
Added unit test GOFFObjectFileTest.cpp, and added GOFF case in TestFileMagic.cpp
Addressed more review comments
Nov 24 2020
Nov 23 2020
Remove setERSymbolType and getERSymbolType functions
Remove return after llvm_unreachable statement
Add check for ESD name length field size
Update loops to comply with LLVM coding standard:
Nov 17 2020
Clean up some cast statements from const uint8_t * to const char *
Change errorCodeToError to createStringError in GOFFObjectFile constructor
Nov 13 2020
Address formatting comments
Nov 12 2020
Address some formatting comments
Nov 10 2020
@jhenderson the comments you left have been addressed. Are there any other suggestions you have?
Nov 3 2020
This update cleans up reinterpret_cast<> statements in GOFFObjectFile related to EsdPtrs, TextPtrs, and RldPtrs
Oct 30 2020
This update cleans up GOFF.h by replacing various set/get functions with templated functions.
Oct 28 2020
This updates the function createGOFFObjectFile to use Error instead of std::error_code as described in https://llvm.org/docs/ProgrammersManual.html#fallible-constructors
Oct 27 2020
Update llvm/include/llvm/Object/GOFF.h to consider endianness of the host system for parsing GOFF records.
Oct 23 2020
This update removes the RLDRelocationType enum from llvm/include/llvm/BinaryFormat/GOFF.h and clarifies comments regarding endianness.
Oct 20 2020
This update removes variable definitions which are used only in the immediate next line and not used elsewhere.
Oct 19 2020
This update fixes formatting issues, along with stubbing functions that are unnecessary
to implement for the time being from the GOFFObjectFile class
Oct 8 2020
Oct 6 2020
It looks to me like you uploaded the wrong diff. You need to upload a diff of your entire final commit that this will be committed as, when making edits to the code. If you intend to upload a series of individual commits, and want them all reviewed together, you should create separate patches for each of them and link them together using the "edit related objects" option to create a patch series.
This patch adds support for a large number of different dumping options all at once. Please break it down into separate smaller pieces. For example, your first patch could just create the GOFFDumper, and do nothing with it, the next adds section header support, the next symbol table support and so on. It is not going to be straightforward to review such a large piece of work all at once.
This update uploads the correct diff with all changes
Oct 5 2020
Fix formatting issues
Oct 2 2020
Mar 4 2020
Overall the patch LGTM, aside from 1 change we may want to make.