Page MenuHomePhabricator

yusra.syeda (Yusra Syeda)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2020, 11:40 AM (52 w, 1 d)

Recent Activity

Fri, Jan 8

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Fri, Jan 8, 1:43 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Fix error message formatting

Fri, Jan 8, 1:38 PM · Restricted Project

Dec 18 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Apply clang format suggestion

Dec 18 2020, 11:57 AM · Restricted Project
yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Dec 18 2020, 11:53 AM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Update error statement, clean up getSymbolName function, add size to enum

Dec 18 2020, 11:35 AM · Restricted Project

Dec 15 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Dec 15 2020, 12:01 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Fix typo

Dec 15 2020, 11:59 AM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Change return type of getSymbolType function from Error to Expected<StringRef>
Also remove StringRef parameter passed by reference to the function
Update error messages to be more descriptive

Dec 15 2020, 11:56 AM · Restricted Project

Dec 14 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Dec 14 2020, 12:49 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Return Error instead of error_code for function getSymbolName
Address other review comments

Dec 14 2020, 11:31 AM · Restricted Project

Dec 9 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Added unit test GOFFObjectFileTest.cpp, and added GOFF case in TestFileMagic.cpp
Addressed more review comments

Dec 9 2020, 8:26 AM · Restricted Project

Nov 24 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 24 2020, 12:50 PM · Restricted Project

Nov 23 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 23 2020, 3:13 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Remove setERSymbolType and getERSymbolType functions

Nov 23 2020, 3:12 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Remove return after llvm_unreachable statement

Nov 23 2020, 11:57 AM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Add check for ESD name length field size
Update loops to comply with LLVM coding standard:
https://llvm.org/docs/CodingStandards.html#don-t-evaluate-end-every-time-through-a-loop

Nov 23 2020, 11:39 AM · Restricted Project

Nov 17 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Clean up some cast statements from const uint8_t * to const char *

Nov 17 2020, 1:54 PM · Restricted Project
yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 17 2020, 8:36 AM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Change errorCodeToError to createStringError in GOFFObjectFile constructor

Nov 17 2020, 8:32 AM · Restricted Project

Nov 13 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Address formatting comments

Nov 13 2020, 1:27 PM · Restricted Project
yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 13 2020, 9:38 AM · Restricted Project

Nov 12 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Address some formatting comments

Nov 12 2020, 1:20 PM · Restricted Project

Nov 10 2020

yusra.syeda added a comment to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

@jhenderson the comments you left have been addressed. Are there any other suggestions you have?

Nov 10 2020, 11:10 AM · Restricted Project

Nov 3 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Nov 3 2020, 1:12 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update cleans up reinterpret_cast<> statements in GOFFObjectFile related to EsdPtrs, TextPtrs, and RldPtrs

Nov 3 2020, 10:48 AM · Restricted Project

Oct 30 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Oct 30 2020, 2:26 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update cleans up GOFF.h by replacing various set/get functions with templated functions.

Oct 30 2020, 2:18 PM · Restricted Project

Oct 28 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This updates the function createGOFFObjectFile to use Error instead of std::error_code as described in https://llvm.org/docs/ProgrammersManual.html#fallible-constructors

Oct 28 2020, 12:45 PM · Restricted Project

Oct 27 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

Update llvm/include/llvm/Object/GOFF.h to consider endianness of the host system for parsing GOFF records.

Oct 27 2020, 9:42 AM · Restricted Project

Oct 23 2020

yusra.syeda added inline comments to D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Oct 23 2020, 1:52 PM · Restricted Project
yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update removes the RLDRelocationType enum from llvm/include/llvm/BinaryFormat/GOFF.h and clarifies comments regarding endianness.

Oct 23 2020, 1:49 PM · Restricted Project

Oct 20 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update removes variable definitions which are used only in the immediate next line and not used elsewhere.

Oct 20 2020, 11:23 AM · Restricted Project

Oct 19 2020

yusra.syeda updated the diff for D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.

This update fixes formatting issues, along with stubbing functions that are unnecessary
to implement for the time being from the GOFFObjectFile class

Oct 19 2020, 11:39 AM · Restricted Project

Oct 8 2020

yusra.syeda abandoned D88749: [SystemZ/z/OS] Add GOFF reader.

This patch has been broken down into the following 3 patches:
https://reviews.llvm.org/D89071
https://reviews.llvm.org/D89073
https://reviews.llvm.org/D89074

Oct 8 2020, 2:21 PM · Restricted Project
yusra.syeda updated the summary of D89074: [SystemZ/z/OS] Add GOFF support for llvm-objdump.
Oct 8 2020, 2:19 PM · Restricted Project
yusra.syeda requested review of D89074: [SystemZ/z/OS] Add GOFF support for llvm-objdump.
Oct 8 2020, 2:14 PM · Restricted Project
yusra.syeda updated the summary of D89073: [SystemZ/z/OS] Add the GOFFDumper.
Oct 8 2020, 2:11 PM · Restricted Project
yusra.syeda requested review of D89073: [SystemZ/z/OS] Add the GOFFDumper.
Oct 8 2020, 2:08 PM · Restricted Project
yusra.syeda retitled D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format from Add GOFFObjectFile class and details of GOFF file format to [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Oct 8 2020, 2:02 PM · Restricted Project
yusra.syeda requested review of D89071: [SystemZ/z/OS] Add GOFFObjectFile class and details of GOFF file format.
Oct 8 2020, 1:56 PM · Restricted Project

Oct 6 2020

yusra.syeda added a comment to D88749: [SystemZ/z/OS] Add GOFF reader.

It looks to me like you uploaded the wrong diff. You need to upload a diff of your entire final commit that this will be committed as, when making edits to the code. If you intend to upload a series of individual commits, and want them all reviewed together, you should create separate patches for each of them and link them together using the "edit related objects" option to create a patch series.

This patch adds support for a large number of different dumping options all at once. Please break it down into separate smaller pieces. For example, your first patch could just create the GOFFDumper, and do nothing with it, the next adds section header support, the next symbol table support and so on. It is not going to be straightforward to review such a large piece of work all at once.

Oct 6 2020, 9:44 AM · Restricted Project
yusra.syeda updated the diff for D88749: [SystemZ/z/OS] Add GOFF reader.

This update uploads the correct diff with all changes

Oct 6 2020, 9:31 AM · Restricted Project

Oct 5 2020

yusra.syeda updated the diff for D88749: [SystemZ/z/OS] Add GOFF reader.

Fix formatting issues

Oct 5 2020, 1:11 PM · Restricted Project

Oct 2 2020

yusra.syeda removed a reviewer for D88749: [SystemZ/z/OS] Add GOFF reader: jhenderson.
Oct 2 2020, 12:01 PM · Restricted Project
yusra.syeda retitled D88749: [SystemZ/z/OS] Add GOFF reader from goff reader to [SystemZ/z/OS] Add GOFF reader.
Oct 2 2020, 12:00 PM · Restricted Project
yusra.syeda requested review of D88749: [SystemZ/z/OS] Add GOFF reader.
Oct 2 2020, 11:53 AM · Restricted Project

Mar 4 2020

yusra.syeda added a comment to D74166: [AIX][Frontend] Static init implementation for AIX considering no priority.

Overall the patch LGTM, aside from 1 change we may want to make.

Mar 4 2020, 7:52 AM · Restricted Project, Restricted Project

Jan 24 2020

yusra.syeda created D73378: [SystemZ] Add implementation for the intrinsic llvm.read_register.
Jan 24 2020, 12:16 PM · Restricted Project