Details

Reviewers

asb
craig.topper
jrtc27
Jim
luismarques
kito-cheng
frasercrmck

Summary

The Zbpbo extension is part of the P extension, and its instructions overlap with the B extension.
Details: https://github.com/riscv/riscv-p-spec/blob/master/P-ext-proposal.adoc#zbpbo

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	60,090 ms	x64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::scariness_score_test.cpp Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -shared-libasan -O0 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/asan/TestCases/scariness_score_test.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxDynamicConfig/TestCases/Output/scariness_score_test.cpp.tmp
	60,100 ms	x64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -O0 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/asan/TestCases/scariness_score_test.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxConfig/TestCases/Output/scariness_score_test.cpp.tmp

Event Timeline

sunshaoce created this revision.Jun 26 2022, 3:32 AM

Herald added a project: Restricted Project. · View Herald TranscriptJun 26 2022, 3:32 AM

Herald added subscribers: VincentWu, luke957, StephenFan and 23 others. · View Herald Transcript

sunshaoce requested review of this revision.Jun 26 2022, 3:32 AM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 26 2022, 3:32 AM

Herald added subscribers: llvm-commits, cfe-commits, pcwang-thead and 2 others. · View Herald Transcript

Harbormaster completed remote builds in B172074: Diff 440052.Jun 26 2022, 4:58 AM

Add more tests

Harbormaster completed remote builds in B172228: Diff 440267.Jun 27 2022, 10:53 AM

Fully supported Zbpbo v0.9.11

Herald added a subscriber: jdoerfert. · View Herald TranscriptJun 27 2022, 11:13 AM

sunshaoce retitled this revision from [WIP][RISCV] Support Zbpbo extension to [RISCV] Support Zbpbo extension.Jun 27 2022, 11:14 AM

sunshaoce edited the summary of this revision. (Show Details)

sunshaoce added inline comments.

llvm/lib/Support/RISCVISAInfo.cpp
356	Modifications here have been submitted separately in D128644.

Harbormaster completed remote builds in B172272: Diff 440324.Jun 27 2022, 1:21 PM

Rebased on D128644

Harbormaster completed remote builds in B172471: Diff 440613.Jun 28 2022, 7:47 AM

craig.topper added inline comments.Jun 28 2022, 9:06 AM

clang/include/clang/Basic/BuiltinsRISCV.def
21	What's preventing __builtin_riscv_clz_32 from being used on rv64 with Zbpbo? I think you need to add it to isRISCV32Builtin in SemaChecking.cpp but you'll also need to check that Zbb isn't enabled.

Address @craig.topper's comment. Thanks!

Harbormaster completed remote builds in B172551: Diff 440714.Jun 28 2022, 1:08 PM

Add alias instructions

Harbormaster completed remote builds in B172797: Diff 441052.Jun 29 2022, 11:12 AM

Rebase

Harbormaster completed remote builds in B173380: Diff 441872.Jul 2 2022, 2:02 AM

Rebase on D99158

sunshaoce retitled this revision from [RISCV] Support Zbpbo extension to [RISCV] Support Zbpbo extension v0.9.11.Jul 3 2022, 2:34 AM

sunshaoce added a parent revision: D99158: [RISCV] Implement intrinsics for P extension.

Harbormaster completed remote builds in B173435: Diff 441931.Jul 3 2022, 2:35 AM

Rebase

Harbormaster completed remote builds in B174604: Diff 443555.Jul 10 2022, 10:26 PM

Jim added inline comments.Jul 11 2022, 1:05 AM

llvm/lib/Target/RISCV/RISCVInstrInfoZb.td
467	FSR and FSRI only exist on RV32 for Zbpbo.
488	CLZ only exist on RV32 for Zbpbo.

[RISCV] Support Zbpbo extension v0.9.11
Needs ReviewPublic
Actions

Details

Diff Detail

Unit TestsFailed
View All

Event Timeline

Revision Contents
Changeset List

Diff 441052

clang/include/clang/Basic/BuiltinsRISCV.def

clang/lib/Sema/SemaChecking.cpp

clang/test/CodeGen/RISCV/rvp-intrinsics/riscv32-zbpbo.c

clang/test/CodeGen/RISCV/rvp-intrinsics/riscv64-zbpbo.c

clang/test/Driver/riscv-arch.c

clang/test/Preprocessor/riscv-target-features.c

llvm/lib/Support/RISCVISAInfo.cpp

llvm/lib/Target/RISCV/RISCV.td

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

llvm/lib/Target/RISCV/RISCVInstrInfoZb.td

llvm/lib/Target/RISCV/RISCVSubtarget.h

llvm/test/CodeGen/RISCV/attributes.ll

llvm/test/CodeGen/RISCV/rv32zbpbo-intrinsics.ll

llvm/test/CodeGen/RISCV/rv32zbpbo.ll

llvm/test/CodeGen/RISCV/rv64zbpbo-intrinsics.ll

llvm/test/CodeGen/RISCV/rv64zbpbo.ll

llvm/test/MC/RISCV/attribute-arch.s

llvm/test/MC/RISCV/rv32zbpbo-aliases-valid.s

llvm/test/MC/RISCV/rv32zbpbo-valid.s

llvm/test/MC/RISCV/rv64zbpbo-aliases-valid.s

llvm/test/MC/RISCV/rv64zbpbo-valid.s

[RISCV] Support Zbpbo extension v0.9.11Needs ReviewPublicActions

Details

Diff Detail

Unit TestsFailedView All

Event Timeline

Revision ContentsChangeset List

Diff 441052

clang/include/clang/Basic/BuiltinsRISCV.def

clang/lib/Sema/SemaChecking.cpp

clang/test/CodeGen/RISCV/rvp-intrinsics/riscv32-zbpbo.c

clang/test/CodeGen/RISCV/rvp-intrinsics/riscv64-zbpbo.c

clang/test/Driver/riscv-arch.c

clang/test/Preprocessor/riscv-target-features.c

llvm/lib/Support/RISCVISAInfo.cpp

llvm/lib/Target/RISCV/RISCV.td

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

llvm/lib/Target/RISCV/RISCVInstrInfoZb.td

llvm/lib/Target/RISCV/RISCVSubtarget.h

llvm/test/CodeGen/RISCV/attributes.ll

llvm/test/CodeGen/RISCV/rv32zbpbo-intrinsics.ll

llvm/test/CodeGen/RISCV/rv32zbpbo.ll

llvm/test/CodeGen/RISCV/rv64zbpbo-intrinsics.ll

llvm/test/CodeGen/RISCV/rv64zbpbo.ll

llvm/test/MC/RISCV/attribute-arch.s

llvm/test/MC/RISCV/rv32zbpbo-aliases-valid.s

llvm/test/MC/RISCV/rv32zbpbo-valid.s

llvm/test/MC/RISCV/rv64zbpbo-aliases-valid.s

llvm/test/MC/RISCV/rv64zbpbo-valid.s

[RISCV] Support Zbpbo extension v0.9.11
Needs ReviewPublic
Actions

Unit TestsFailed
View All

Revision Contents
Changeset List