Page MenuHomePhabricator

luke957 (Luke)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 26 2021, 7:22 PM (14 w, 4 d)

Recent Activity

Thu, Apr 29

luke957 added inline comments to D101469: [RISCV] Enable interleaved vectorization for RVV.
Thu, Apr 29, 9:06 AM · Restricted Project
luke957 updated the diff for D101469: [RISCV] Enable interleaved vectorization for RVV.
Thu, Apr 29, 8:55 AM · Restricted Project

Wed, Apr 28

luke957 added reviewers for D101469: [RISCV] Enable interleaved vectorization for RVV: craig.topper, frasercrmck, HsiangKai.
Wed, Apr 28, 9:19 AM · Restricted Project
luke957 requested review of D101469: [RISCV] Enable interleaved vectorization for RVV.
Wed, Apr 28, 9:17 AM · Restricted Project
luke957 added a comment to D99509: [RISCV] Add legality check for vectoring reduction.

ping

Wed, Apr 28, 12:32 AM · Restricted Project

Thu, Apr 22

luke957 added inline comments to D99509: [RISCV] Add legality check for vectoring reduction.
Thu, Apr 22, 9:35 AM · Restricted Project
luke957 updated the diff for D99509: [RISCV] Add legality check for vectoring reduction.
Thu, Apr 22, 8:58 AM · Restricted Project

Thu, Apr 15

luke957 added a reviewer for D99509: [RISCV] Add legality check for vectoring reduction: dmgreen.
Thu, Apr 15, 6:23 AM · Restricted Project
luke957 added a comment to D99509: [RISCV] Add legality check for vectoring reduction.

ping

Thu, Apr 15, 3:17 AM · Restricted Project

Tue, Apr 13

luke957 abandoned D99492: [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions.
Tue, Apr 13, 7:59 PM · Restricted Project

Apr 8 2021

luke957 added inline comments to D99509: [RISCV] Add legality check for vectoring reduction.
Apr 8 2021, 1:36 AM · Restricted Project
luke957 updated the diff for D99509: [RISCV] Add legality check for vectoring reduction.
Apr 8 2021, 1:25 AM · Restricted Project

Apr 7 2021

luke957 added inline comments to D99509: [RISCV] Add legality check for vectoring reduction.
Apr 7 2021, 8:38 AM · Restricted Project
luke957 updated the diff for D99509: [RISCV] Add legality check for vectoring reduction.
Apr 7 2021, 8:34 AM · Restricted Project

Apr 5 2021

luke957 added inline comments to D99509: [RISCV] Add legality check for vectoring reduction.
Apr 5 2021, 9:32 AM · Restricted Project
luke957 added inline comments to D99509: [RISCV] Add legality check for vectoring reduction.
Apr 5 2021, 9:23 AM · Restricted Project

Mar 30 2021

luke957 added inline comments to D99492: [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions.
Mar 30 2021, 3:36 AM · Restricted Project
luke957 added a comment to D99492: [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions.

There is no such implication in the V specification. See https://github.com/riscv/riscv-v-spec/issues/608.

Mar 30 2021, 3:34 AM · Restricted Project

Mar 29 2021

luke957 requested review of D99509: [RISCV] Add legality check for vectoring reduction.
Mar 29 2021, 8:15 AM · Restricted Project
luke957 added reviewers for D99492: [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions: frasercrmck, HsiangKai, StephenFan.
Mar 29 2021, 3:48 AM · Restricted Project
luke957 retitled D99492: [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions from [RISCV] "V" Extention coming with "F" "D" "Zfh" to [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions.
Mar 29 2021, 3:44 AM · Restricted Project
luke957 requested review of D99492: [RISCV] "V" Extention coming with "F" "D" "Zfh" Extentions.
Mar 29 2021, 2:38 AM · Restricted Project

Mar 4 2021

luke957 committed rGd28297ff68ee: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector (authored by luke957).
[RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector
Mar 4 2021, 6:56 PM
luke957 closed D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Mar 4 2021, 6:56 PM · Restricted Project
luke957 added a comment to D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.

LGTM. I wouldn't say my last suggestion is a hard requirement.

Mar 4 2021, 4:57 AM · Restricted Project
luke957 added inline comments to D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Mar 4 2021, 4:26 AM · Restricted Project
luke957 updated the diff for D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Mar 4 2021, 4:23 AM · Restricted Project

Mar 3 2021

luke957 added inline comments to D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Mar 3 2021, 10:46 PM · Restricted Project
luke957 updated the diff for D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Mar 3 2021, 10:42 PM · Restricted Project

Mar 2 2021

luke957 added a comment to D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.

The changes LGTM, thanks for adding a test case.

However, I think the commit title/message could be expanded upon somewhat. For example, *how* does it improve LoopVectorizer support? Since we've got both fixed-length and scalable vectorization, I think it would be helpful to clarify that this relates to fixed-length vectorization. More specifically, doesn't this change *enable* fixed-length vectorization, not just improve upon it?

Mar 2 2021, 7:24 PM · Restricted Project
luke957 retitled D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector from [RISCV] Improve support of LoopVectorizer for RISC-V Vector to [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Mar 2 2021, 7:17 PM · Restricted Project

Mar 1 2021

luke957 added a comment to D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.

Test case?

Mar 1 2021, 7:37 PM · Restricted Project
luke957 updated the diff for D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.

Add test case riscv-unroll.ll

Mar 1 2021, 7:13 PM · Restricted Project

Feb 26 2021

luke957 added reviewers for D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector: HsiangKai, craig.topper.
Feb 26 2021, 6:21 AM · Restricted Project
luke957 requested review of D97549: [RISCV] Enable fixed-length vectorization of LoopVectorizer for RISC-V Vector.
Feb 26 2021, 6:03 AM · Restricted Project