Page MenuHomePhabricator

[RISCV] Support experimental 'P' extension 0.9.11
Needs ReviewPublic

Authored by Jim on Aug 16 2021, 11:37 PM.

Details

Summary

Support arch features, arch attributes and preprocessor definitions
for experimental 'P' extension with version 0.9.11

Diff Detail

Unit TestsFailed

TimeTest
60,120 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::scariness_score_test.cpp
Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -shared-libasan -O0 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/asan/TestCases/scariness_score_test.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxDynamicConfig/TestCases/Output/scariness_score_test.cpp.tmp
60,130 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
Script: -- : 'RUN: at line 4'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only -m64 -O0 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/asan/TestCases/scariness_score_test.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/asan/X86_64LinuxConfig/TestCases/Output/scariness_score_test.cpp.tmp
60,060 msx64 debian > BOLT.runtime/X86::exceptions-pic.test
Script: -- : 'RUN: at line 5'; /usr/bin/clang --driver-mode=g++ -fpic -Wl,-q /var/lib/buildkite-agent/builds/llvm-project/bolt/test/runtime/X86/Inputs/exception4.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/tools/bolt/test/runtime/X86/Output/exceptions-pic.test.tmp.pic
60,130 msx64 debian > LLVM.CodeGen/NVPTX::wmma.py
Script: -- : 'RUN: at line 5'; "/usr/bin/python3.9" /var/lib/buildkite-agent/builds/llvm-project/llvm/test/CodeGen/NVPTX/wmma.py --ptx=60 --gpu-arch=70 > /var/lib/buildkite-agent/builds/llvm-project/build/test/CodeGen/NVPTX/Output/wmma.py.tmp-ptx60-sm_70.ll
60,040 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp
Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=thread -Wall -m64 -msse4.2 -gline-tables-only -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/../ -std=c++11 -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/../ -O1 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/restore_stack.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/restore_stack.cpp.tmp && not /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/restore_stack.cpp.tmp 2>&1 | FileCheck /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/restore_stack.cpp

Event Timeline

Jim created this revision.Aug 16 2021, 11:37 PM
Jim requested review of this revision.Aug 16 2021, 11:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2021, 11:37 PM
Jim edited the summary of this revision. (Show Details)Aug 16 2021, 11:38 PM
Jim added reviewers: craig.topper, jrtc27.

Could you fix that based on my patch? I believe that would be a universal way to handle all arch string related stuffs: https://reviews.llvm.org/D105168

Jim added a comment.Aug 22 2021, 7:36 PM

Could you fix that based on my patch? I believe that would be a universal way to handle all arch string related stuffs: https://reviews.llvm.org/D105168

In P extension, zprvsfextra sub-extension is RV64 only. RV32 + zprvsfextra is invalid.
It seems have to add specific checking for this.
Do you have any suggestion where should I add checking for it.

Jim updated this revision to Diff 370484.Sep 2 2021, 10:53 PM

Base on D105168 to support arch features, arch attributes and
preprocessor definitions.

Herald added a project: Restricted Project. · View Herald TranscriptSep 2 2021, 10:53 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Jim retitled this revision from [RISCV] Add arch attribute support for P extension to [RISCV] Support experimental 'P' extension 0.93.Sep 2 2021, 10:54 PM
Jim edited the summary of this revision. (Show Details)
Jim added reviewers: HsiangKai, kito-cheng.
Jim updated this revision to Diff 372058.Sep 10 2021, 11:28 PM

Update to 0.96 and remove Zprvsfextra

Jim retitled this revision from [RISCV] Support experimental 'P' extension 0.93 to [RISCV] Support experimental 'P' extension 0.96.Sep 10 2021, 11:28 PM
Jim edited the summary of this revision. (Show Details)

Hi, @Jim.
What time is P extension going to upstream to community since it's been no update for some months?

Jim added a comment.Jan 20 2022, 6:09 PM

Hi, @Jim.
What time is P extension going to upstream to community since it's been no update for some months?

Hi @zixuan-wu,

From RVP 0.9.7, it has lots of changes (new sub-extension Zbpbo). I am still working on it.
Sorry for reply late.

Jim updated this revision to Diff 407770.Feb 10 2022, 9:56 PM

Rebase

Jim updated this revision to Diff 433612.Jun 1 2022, 6:35 PM

Rebase

Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2022, 6:35 PM
sunshaoce retitled this revision from [RISCV] Support experimental 'P' extension 0.96 to [RISCV] Support experimental 'P' extension 0.9.11.Jul 3 2022, 1:08 AM
sunshaoce edited the summary of this revision. (Show Details)
sunshaoce updated this revision to Diff 441925.Jul 3 2022, 1:10 AM

Support for P extension version 0.9.11