5/5
DiagnosticSemaKinds.td -
attr-likelihood-if-branch-weights.cpp -
include/llvm/Transforms/Scalar/ -
LowerExpectIntrinsic.cpp
| | Authored by Mordante on Aug 2 2020, 4:42 AM. Event TimelineHerald added a project: Restricted Project. Mordante requested review of this revision. Mordante planned changes to this revision. Mordante marked 14 inline comments as done. Mordante marked 14 inline comments as done. Mordante marked 8 inline comments as done. Mordante marked 4 inline comments as done. Mordante marked 7 inline comments as done. Mordante marked 2 inline comments as done. Mordante marked an inline comment as done. This revision is now accepted and ready to land. Mordante marked 2 inline comments as done. This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Path | Size |
---|
| | | | | 10 lines | | 40 lines | | 5 lines | | 9 lines | | | | | | 62 lines | | 3 lines | | 42 lines | | | | 2 lines | | | | 46 lines | | 50 lines | | | | | | 25 lines | | | | 1 line | | | | 4 lines | | | | 101 lines | | | | 2 lines | | | | include/ | llvm/ | Transforms/ | Scalar/ |
| | | 3 lines | | | | 5 lines |
|
Hmm, I'm on the fence about specifying 201803 for these attributes. Given that this is only the start of supporting the attribute, do we want to claim it already matches the standard's behavior? Or do we just want to return 1 to signify that we understand this attribute but we don't yet fully support it in common cases (such as on labels in switch statements, etc)?
As another question, should we consider adding a C2x spelling [[clang::likely]] and [[clang::unlikely]] to add this functionality to C?