Page MenuHomePhabricator

Quuxplusone (Arthur O'Dwyer)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 27 2014, 8:52 PM (224 w, 6 d)

Recent Activity

Sun, Apr 14

Quuxplusone added inline comments to D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.
Sun, Apr 14, 5:25 PM · Restricted Project

Sat, Apr 13

Quuxplusone added a comment to D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

As you're making tests for ADL corner cases, you might also consider testing the interactions between ADL and defaulted function parameters, e.g. https://godbolt.org/z/vHnyFl
It looks like everyone (except MSVC) already gets that stuff right (or at least portable-between-the-big-three). I bet the behavior naturally falls out of some other rules; you might say "there's no way that could possibly break, so we don't need to test it," and I'd accept that.

Sat, Apr 13, 10:02 AM · Restricted Project
Quuxplusone added inline comments to D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.
Sat, Apr 13, 6:54 AM · Restricted Project

Fri, Apr 12

Quuxplusone added inline comments to D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.
Fri, Apr 12, 4:53 AM · Restricted Project

Thu, Apr 11

Quuxplusone added inline comments to D60561: [clang] fixing diagnostics of constexpr callstack.
Thu, Apr 11, 6:17 AM · Restricted Project

Thu, Mar 21

Quuxplusone updated the diff for D47358: <experimental/memory_resource>: Implement {un,}synchronized_pool_resource..

Rebased. Added _NOEXCEPT to upstream_resource() and options() (this is OK per [res.on.exception.handling]/5).

Thu, Mar 21, 7:09 PM
Quuxplusone updated the diff for D47111: <experimental/memory_resource>: Implement monotonic_buffer_resource..

Rebased on master. Added _NOEXCEPT to the resource() method (this is OK per [res.on.exception.handling]/5).

Thu, Mar 21, 6:51 PM
Quuxplusone abandoned D54673: Fix some `-Wshadow` diagnostics emitted by Clang trunk.
Thu, Mar 21, 6:34 PM

Mar 8 2019

Quuxplusone added a comment to D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()".

@Quuxplusone Since the LLVM license has changed since you created this, I need you to confirm that you accept LLVM's new license.

Mar 8 2019, 3:50 PM

Mar 6 2019

Quuxplusone updated the diff for D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()".

Oops, really replace the destructor this time. (Hadn't git commited.)

Mar 6 2019, 3:07 PM
Quuxplusone updated the diff for D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()".
  • Replace the unnecessary destructor in class __new_delete_resource_imp.
  • Add LWG2843 to the list of completed issues (thanks @zoecarver!)
Mar 6 2019, 3:06 PM
Quuxplusone added inline comments to D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()".
Mar 6 2019, 1:32 PM

Mar 4 2019

Quuxplusone updated the diff for D58582: Implement P0433: deduction guides for <set>.

clang-format'ed.

Mar 4 2019, 7:36 PM
Quuxplusone retitled D58587: Implement P0433: deduction guides for <map> from Implement deduction guides for <map> to Implement P0433: deduction guides for <map>.
Mar 4 2019, 7:25 PM
Quuxplusone retitled D58590: Implement P0433: deduction guides for <unordered_map> from Implement deduction guides for <unordered_map> to Implement P0433: deduction guides for <unordered_map>.
Mar 4 2019, 7:25 PM
Quuxplusone retitled D58582: Implement P0433: deduction guides for <set> from Implement deduction guides for <set> to Implement P0433: deduction guides for <set>.
Mar 4 2019, 7:25 PM
Quuxplusone updated the diff for D58590: Implement P0433: deduction guides for <unordered_map>.

Mark LWG3025 status "Complete". (Thanks @STL_MSFT for pointing me at that issue!)

Mar 4 2019, 1:34 PM
Quuxplusone updated the diff for D58587: Implement P0433: deduction guides for <map>.

Remove an unused struct NotAnAllocator from the tests. NFC.

Mar 4 2019, 12:04 PM

Mar 3 2019

Quuxplusone updated the diff for D58617: Implement deduction guides for <unordered_set>.

Use ASSERT_SAME_TYPE. Add comments in deduct.fail.cpp. Rebase.

Mar 3 2019, 2:56 PM
Quuxplusone updated the summary of D58617: Implement deduction guides for <unordered_set>.
Mar 3 2019, 2:55 PM
Quuxplusone updated the diff for D58590: Implement P0433: deduction guides for <unordered_map>.

Use ASSERT_SAME_TYPE. Add comments to deduct.fail.cpp. Rebase.

Mar 3 2019, 2:27 PM

Feb 27 2019

Quuxplusone added inline comments to D58587: Implement P0433: deduction guides for <map>.
Feb 27 2019, 9:45 PM
Quuxplusone updated the diff for D58587: Implement P0433: deduction guides for <map>.

Use ASSERT_SAME_TYPE.
Better comments in .fail.cpp.
Fix some whitespace in my comments.

Feb 27 2019, 9:43 PM
Quuxplusone updated the diff for D58582: Implement P0433: deduction guides for <set>.

Use ASSERT_SAME_TYPE. Better comments in the .fail.cpp file.

Feb 27 2019, 9:35 PM

Feb 25 2019

Quuxplusone created D58617: Implement deduction guides for <unordered_set>.
Feb 25 2019, 6:39 AM
Quuxplusone updated the diff for D58590: Implement P0433: deduction guides for <unordered_map>.

Add <algorithm> header to the tests, for the benefit of libstdc++.

Feb 25 2019, 6:26 AM

Feb 24 2019

Quuxplusone created D58590: Implement P0433: deduction guides for <unordered_map>.
Feb 24 2019, 12:11 AM
Quuxplusone added a child revision for D58587: Implement P0433: deduction guides for <map>: D58590: Implement P0433: deduction guides for <unordered_map>.
Feb 24 2019, 12:11 AM
Quuxplusone added a parent revision for D58590: Implement P0433: deduction guides for <unordered_map>: D58587: Implement P0433: deduction guides for <map>.
Feb 24 2019, 12:11 AM

Feb 23 2019

Quuxplusone updated the diff for D58582: Implement P0433: deduction guides for <set>.

Oops, fix a cut-and-paste thinko in the test for multiset.

Feb 23 2019, 6:43 PM
Quuxplusone created D58587: Implement P0433: deduction guides for <map>.
Feb 23 2019, 6:43 PM
Quuxplusone created D58582: Implement P0433: deduction guides for <set>.
Feb 23 2019, 12:38 PM

Feb 8 2019

Quuxplusone added a comment to D57906: [CTU] Do not allow different CPP dialects in CTU.

Consider this STL code:

template<typename _Alloc>
  struct __alloc_traits
#if __cplusplus >= 201103L
  : std::allocator_traits<_Alloc>
#endif
  { // ...
  };

This class template would create ODR errors during merging the two units,
since in one translation unit the class template has a base class, however
in the other unit it has none.

Feb 8 2019, 7:32 AM · Restricted Project
Quuxplusone added inline comments to D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.
Feb 8 2019, 7:30 AM · Restricted Project

Feb 6 2019

Quuxplusone added inline comments to D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted.
Feb 6 2019, 10:39 AM · Restricted Project

Feb 5 2019

Quuxplusone updated the diff for D57734: priority_queue::replace_top(x).

Reverted names back to friendly names. (The uglified __names were a conforming extension; but the friendly names are what people would actually want to use. As this patch is likely going to be stagnant on Phab for a while, I'd rather have it be in the state that's directly apply-able for anyone who does want to merge it locally.)

Feb 5 2019, 10:22 AM · Restricted Project
Quuxplusone added a comment to D57734: priority_queue::replace_top(x).

@mclow.lists wrote:

Now no one outside of libc++ can call it (legally)

Feb 5 2019, 9:16 AM · Restricted Project
Quuxplusone added inline comments to D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.
Feb 5 2019, 9:10 AM · Restricted Project
Quuxplusone updated the diff for D57734: priority_queue::replace_top(x).

@mclow.lists: Easy peasy! Please take another look.

Feb 5 2019, 8:45 AM · Restricted Project

Feb 4 2019

Quuxplusone updated the diff for D57734: priority_queue::replace_top(x).

Brought unit tests into line with https://reviews.llvm.org/rL353086

Feb 4 2019, 11:21 PM · Restricted Project
Quuxplusone updated the diff for D47360: Implement <memory_resource> as a copy of <experimental/memory_resource>..

Rebased on master. Added to <version> by updating and running the Python script.

Feb 4 2019, 10:08 PM
Quuxplusone added a comment to D57624: Support tests in freestanding.

Hi @jfb, this commit broke /utils/generate_feature_test_macro_components.py in the libc++ repo by replacing two curly braces with one curly brace:

Feb 4 2019, 9:31 PM · Restricted Project
Quuxplusone updated the diff for D47358: <experimental/memory_resource>: Implement {un,}synchronized_pool_resource..

Rebased on master. @EricWF (cc @AlisdairM) ping!

Feb 4 2019, 9:18 PM
Quuxplusone updated the diff for D47111: <experimental/memory_resource>: Implement monotonic_buffer_resource..

Rebased on master. @EricWF (cc @AlisdairM) ping!

Feb 4 2019, 8:44 PM
Quuxplusone updated the diff for D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()".

Rebased on master. @EricWF ping! It's been quite a few months...

Feb 4 2019, 8:17 PM
Quuxplusone created D57734: priority_queue::replace_top(x).
Feb 4 2019, 8:12 PM · Restricted Project
Quuxplusone added inline comments to D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted.
Feb 4 2019, 3:03 PM · Restricted Project

Feb 3 2019

Quuxplusone added a comment to D57626: Disallow trivial_abi on a class if all copy and move constructors are deleted.

Can you give more intuition on why classes with no copy/move operations should be forced non-trivial-abi? Let's take this specific example:

Feb 3 2019, 7:55 AM · Restricted Project

Jan 17 2019

Quuxplusone added a comment to D54472: Disable invalid isPodLike<> specialization.

LGTM!

Jan 17 2019, 9:23 AM

Jan 15 2019

Quuxplusone added a comment to D56731: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides..

we need to keep in mind while making that decision that a warning that is either off-by-default or turned off by nearly everyone delivers much less value

Jan 15 2019, 11:00 PM
Quuxplusone added a comment to D56731: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides..

Concretely, I think we could warn if, during template instantiation from a type-dependent initializer, we select the copy deduction candidate and there was another viable candidate (the optional o(x) case, the tuple t{args...} case, etc), maybe under a new -Wctad-unwrap or similar.

Jan 15 2019, 3:38 PM
Quuxplusone added inline comments to D56731: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides..
Jan 15 2019, 2:24 PM
Quuxplusone added inline comments to D56731: Add -Wctad-maybe-unsupported to diagnose CTAD on types with no user defined deduction guides..
Jan 15 2019, 10:46 AM

Jan 14 2019

Quuxplusone added a comment to D56277: AggressiveInstCombine: Add tests for full multiplication pattern match.

@lebedev.ri ping?

Jan 14 2019, 5:18 PM

Jan 7 2019

Quuxplusone added inline comments to D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch..
Jan 7 2019, 3:25 PM
Quuxplusone added inline comments to D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch..
Jan 7 2019, 1:56 PM

Jan 5 2019

Quuxplusone added inline comments to D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch..
Jan 5 2019, 9:16 AM

Jan 4 2019

Quuxplusone added inline comments to D55933: [Sema] Do not print default template parameters..
Jan 4 2019, 10:16 AM

Jan 3 2019

Quuxplusone added inline comments to D56277: AggressiveInstCombine: Add tests for full multiplication pattern match.
Jan 3 2019, 10:25 AM
Quuxplusone added inline comments to D55933: [Sema] Do not print default template parameters..
Jan 3 2019, 9:06 AM

Jan 2 2019

Quuxplusone added inline comments to D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128.
Jan 2 2019, 3:39 PM · Restricted Project

Dec 29 2018

Quuxplusone added a comment to D47111: <experimental/memory_resource>: Implement monotonic_buffer_resource..

@EricWF ping!
and oops, I never submitted these comments, I guess.

Dec 29 2018, 4:34 PM
Quuxplusone updated the diff for D47111: <experimental/memory_resource>: Implement monotonic_buffer_resource..

Updated and addressed review comments.
test/std/experimental/memory/memory.resource.monotonic.buffer/monotonic.buffer.mem/allocate_overaligned_request.pass.cpp is now XFAILed on OSX platforms, using code copied-and-pasted from test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpp.

Dec 29 2018, 4:33 PM
Quuxplusone updated the diff for D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()".
Dec 29 2018, 2:27 PM
Quuxplusone added a comment to D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()".

@EricWF ping!

Dec 29 2018, 1:32 PM

Dec 24 2018

Quuxplusone added inline comments to D55955: Properly diagnose [[nodiscard]] on the body of a range-based for loop.
Dec 24 2018, 12:33 PM

Dec 22 2018

Quuxplusone added a comment to D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`.
  • using CTAD on arbitrary class templates that weren't designed for it creates a source compatibility problem that the class template author has no control over nor say in
  • using CTAD on class templates that were designed for it does not create a new source compatibility problem -- the class template author created the source compatibility problem themselves when they designed how their class templates would interact with CTAD
Dec 22 2018, 10:14 AM

Dec 21 2018

Quuxplusone added inline comments to D55933: [Sema] Do not print default template parameters..
Dec 21 2018, 1:52 PM
Quuxplusone added a comment to D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`.

Since I don't know what it means, I don't know if I want a diagnostic for it :-)

Dec 21 2018, 1:34 PM

Dec 20 2018

Quuxplusone added a comment to D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`.

@rsmith ping! It's been a week since the last ping...

Dec 20 2018, 11:40 PM
Quuxplusone added inline comments to D55933: [Sema] Do not print default template parameters..
Dec 20 2018, 8:11 AM

Dec 19 2018

Quuxplusone added inline comments to D54472: Disable invalid isPodLike<> specialization.
Dec 19 2018, 11:10 AM
Quuxplusone added inline comments to D54472: Disable invalid isPodLike<> specialization.
Dec 19 2018, 11:02 AM
Quuxplusone added a comment to D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..

LGTM. Tiny style suggestions, which I won't mind if you ignore.

Dec 19 2018, 9:25 AM
Quuxplusone added inline comments to D54472: Disable invalid isPodLike<> specialization.
Dec 19 2018, 8:21 AM

Dec 14 2018

Quuxplusone added a comment to D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()".

@EricWF ping!

Dec 14 2018, 8:43 AM
Quuxplusone added a comment to D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`.

@rsmith ping!

Dec 14 2018, 8:42 AM
Quuxplusone updated the summary of D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`.
Dec 14 2018, 8:39 AM
Quuxplusone retitled D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat` from Introduce `-Wc++14-compat-ctad` as a subgroup of `-Wc++14-compat` to Introduce `-Wctad` as a subgroup of `-Wc++14-compat`.
Dec 14 2018, 8:38 AM

Dec 13 2018

Quuxplusone added a comment to D54472: Disable invalid isPodLike<> specialization.

LGTM at this point modulo my two comments (one important but trivial, the other completely trivial).
I don't know whether Chandler's concern about __has_feature in "include/llvm/ADT/PointerIntPair.h" has been 100% resolved yet — @chandlerc?

Dec 13 2018, 7:49 AM

Dec 11 2018

Quuxplusone added inline comments to D48753: [libcxx] Use custom allocator's `construct` in C++03 when available..
Dec 11 2018, 5:28 PM
Quuxplusone added a comment to D55270: [Sema] Further improvements to to static_assert diagnostics..

@courbet: On the cpplang Slack, Peter Feichtinger mentioned that defaulted template arguments should perhaps be treated differently. Is there any way to suppress the , std::allocator<int> part of this diagnostic? https://godbolt.org/z/TM0UHc

Dec 11 2018, 2:42 PM
Quuxplusone added inline comments to D55552: [Sema] Better static assert diagnostics for expressions involving temporaries..
Dec 11 2018, 7:05 AM

Dec 10 2018

Quuxplusone added inline comments to D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch..
Dec 10 2018, 12:34 PM
Quuxplusone updated the diff for D47111: <experimental/memory_resource>: Implement monotonic_buffer_resource..

@EricWF ping!

Dec 10 2018, 9:28 AM
Quuxplusone updated the diff for D47344: LWG 2843 "Unclear behavior of std::pmr::memory_resource::do_allocate()".

Address review comments.

Dec 10 2018, 7:39 AM

Dec 9 2018

Quuxplusone added a comment to D47111: <experimental/memory_resource>: Implement monotonic_buffer_resource..

@EricWF ping? This still needs someone to land it; I don't have commit privs. Thanks!

Dec 9 2018, 1:58 PM

Dec 8 2018

Quuxplusone added inline comments to D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch..
Dec 8 2018, 8:41 AM
Quuxplusone updated subscribers of D55270: [Sema] Further improvements to to static_assert diagnostics..
Dec 8 2018, 8:25 AM

Dec 7 2018

Quuxplusone added inline comments to D55270: [Sema] Further improvements to to static_assert diagnostics..
Dec 7 2018, 7:07 AM

Dec 6 2018

Quuxplusone updated the diff for D54565: Introduce `-Wctad` as a subgroup of `-Wc++14-compat`.

Rename -Wc++14-compat-ctad to just -Wctad, per @rsmith's comment to "move this out of -Wc++14-compat."

Dec 6 2018, 5:08 AM

Dec 4 2018

Quuxplusone added inline comments to D55270: [Sema] Further improvements to to static_assert diagnostics..
Dec 4 2018, 2:31 PM
Quuxplusone added inline comments to D54472: Disable invalid isPodLike<> specialization.
Dec 4 2018, 9:50 AM

Nov 30 2018

Quuxplusone added inline comments to D54472: Disable invalid isPodLike<> specialization.
Nov 30 2018, 6:18 PM
Quuxplusone added a comment to D54903: [Sema] Improve static_assert diagnostics..

Looks fine to me; please don't let me block this any further. :) Someone else, e.g. @aaron.ballman, should be the one to accept it, though.

Nov 30 2018, 5:20 PM

Nov 29 2018

Quuxplusone accepted D55005: Avoid redundant reference to isPodLike in SmallVect implementation.

LGTM, for what that's worth!

Nov 29 2018, 9:15 AM

Nov 28 2018

Quuxplusone added a comment to D55005: Avoid redundant reference to isPodLike in SmallVect implementation.

My comment on D54472 didn't mention it because I thought it would be obvious, but the same pattern applies to your proposed diffs in "include/llvm/ADT/Optional.h".

Nov 28 2018, 12:02 PM
Quuxplusone added inline comments to D55005: Avoid redundant reference to isPodLike in SmallVect implementation.
Nov 28 2018, 11:59 AM
Quuxplusone added inline comments to D54903: [Sema] Improve static_assert diagnostics..
Nov 28 2018, 11:54 AM
Quuxplusone added inline comments to D54903: [Sema] Improve static_assert diagnostics..
Nov 28 2018, 5:39 AM