Page MenuHomePhabricator

riccibruno (Bruno Ricci)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2018, 8:27 AM (67 w, 20 h)

Recent Activity

Tue, Aug 27

riccibruno committed rGc397a266f01d: [clang] Ensure that statements, expressions and types are trivially destructible (authored by riccibruno).
[clang] Ensure that statements, expressions and types are trivially destructible
Tue, Aug 27, 4:58 AM
riccibruno committed rG2535f04338c6: [clang] Ensure that comment classes are trivially destructible (authored by riccibruno).
[clang] Ensure that comment classes are trivially destructible
Tue, Aug 27, 4:23 AM
riccibruno closed D66722: [clang] Ensure that comment classes are trivially destructible.
Tue, Aug 27, 4:22 AM · Restricted Project

Sun, Aug 25

riccibruno updated the diff for D66722: [clang] Ensure that comment classes are trivially destructible.

Also test that DeclInfo is trivially destructible.

Sun, Aug 25, 1:59 PM · Restricted Project
riccibruno retitled D66646: [clang] Ensure that statements, expressions and types are trivially destructible from Ensure that statements, expressions and types are trivially destructible with a static_assert to [clang] Ensure that statements, expressions and types are trivially destructible.
Sun, Aug 25, 12:01 PM · Restricted Project, Restricted Project
riccibruno created D66722: [clang] Ensure that comment classes are trivially destructible.
Sun, Aug 25, 12:00 PM · Restricted Project
riccibruno added a comment to D66646: [clang] Ensure that statements, expressions and types are trivially destructible.

I was looking at SpecificBumpPtrAllocator, which knows it's type.
But if i look down the indirection, i think AllocatorBase::Allocate<T>()/AllocatorBase::Deallocate<T>() is the place.

Sun, Aug 25, 4:19 AM · Restricted Project, Restricted Project

Aug 23 2019

riccibruno added a comment to D66646: [clang] Ensure that statements, expressions and types are trivially destructible.

SGTM, but i wonder if this should be done one level up, in BumpPtrAllocator itself?

Aug 23 2019, 6:02 AM · Restricted Project, Restricted Project
riccibruno created D66646: [clang] Ensure that statements, expressions and types are trivially destructible.
Aug 23 2019, 5:48 AM · Restricted Project, Restricted Project

Aug 22 2019

riccibruno added a comment to D66397: [Diagnostics] Improve -Wxor-used-as-pow.

This should not warn. Please verify that patch was applied correctly and you use newly built clang with this patch. (I use arc patch DXXXXX)

Aug 22 2019, 6:52 AM · Restricted Project

Aug 21 2019

riccibruno added a comment to D66397: [Diagnostics] Improve -Wxor-used-as-pow.

Is the test up-to-date ? I tried to apply the patch locally and I get a bunch of failures :

Aug 21 2019, 5:36 AM · Restricted Project

Aug 20 2019

riccibruno added a comment to D66481: [C++20] Support for lambdas in unevaluated context.

Can you submit the patch with the full context (ie: git diff -U9999999) ?

Aug 20 2019, 8:41 AM · Restricted Project
riccibruno updated the diff for D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions..

Rebased

Aug 20 2019, 8:25 AM · Restricted Project
riccibruno updated the diff for D58297: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=.

Rebased

Aug 20 2019, 8:24 AM · Restricted Project
riccibruno updated the diff for D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:.

Rebased

Aug 20 2019, 8:24 AM · Restricted Project
riccibruno updated the diff for D57660: [Sema] SequenceChecker: Handle references, members and structured bindings..

Rebased

Aug 20 2019, 8:24 AM · Restricted Project
riccibruno updated the diff for D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches.

Rebased. Thanks for the review @xbolva00 !

Aug 20 2019, 8:15 AM · Restricted Project
riccibruno added a comment to D57660: [Sema] SequenceChecker: Handle references, members and structured bindings..

Added some reviewers

Patch improves suboptimal diagnostic, which misses bugs like:
https://bugs.llvm.org/show_bug.cgi?id=43052

Aug 20 2019, 6:23 AM · Restricted Project

Aug 13 2019

riccibruno added a comment to D61027: Fix crash on switch conditions of non-integer types in templates.

I think that you have to run check-clang-tools. I too was surprised that it was not included in check-clang.

Aug 13 2019, 1:30 PM · Restricted Project

Aug 12 2019

riccibruno added a comment to D65591: [AST] Add a flag indicating if any subexpression had errors.

It seems that these two options are not exactly the same right ? The ContainsError bit is useful to quickly answer "Does this expression contains an invalid sub-expression" without doing the search, while adding an ErrorExpr node is useful to note that this sub-expression is invalid (and as Aaron says the hypothetical ErrorExpr node can carry more info about the error).

That's true. I had figured that answering "does this expression contain an invalid sub-expression" could be implemented with a walk of the expression tree rather than consuming a bit. To consumers of containsErrors(), there shouldn't be much difference aside from performance (and that may be sufficient reason to go with a bit, but I think I'd like to see performance measurements that show the bit is necessary).

Are expression bits scarce?
We don't have any checks if expressions contain errors now, we simply drop too many invalid expressions and never put them into the AST.
It's impossible to do the measurements at this point, but it would be nice if adding those checks was cheap.

Aug 12 2019, 7:55 AM · Restricted Project
riccibruno added a comment to D65591: [AST] Add a flag indicating if any subexpression had errors.

It seems that these two options are not exactly the same right ? The ContainsError bit is useful to quickly answer "Does this expression contains an invalid sub-expression" without doing the search, while adding an ErrorExpr node is useful to note that this sub-expression is invalid (and as Aaron says the hypothetical ErrorExpr node can carry more info about the error).

That's true. I had figured that answering "does this expression contain an invalid sub-expression" could be implemented with a walk of the expression tree rather than consuming a bit. To consumers of containsErrors(), there shouldn't be much difference aside from performance (and that may be sufficient reason to go with a bit, but I think I'd like to see performance measurements that show the bit is necessary).

Aug 12 2019, 6:50 AM · Restricted Project
riccibruno added a comment to D65591: [AST] Add a flag indicating if any subexpression had errors.

It seems that these two options are not exactly the same right ? The ContainsError bit is useful to quickly answer "Does this expression contains an invalid sub-expression" without doing the search, while adding an ErrorExpr node is useful to note that this sub-expression is invalid (and as Aaron says the hypothetical ErrorExpr node can carry more info about the error).

Aug 12 2019, 6:26 AM · Restricted Project

Jul 27 2019

riccibruno added inline comments to D63276: [AST] Add FunctionDecl::getParametersSourceRange().
Jul 27 2019, 9:37 AM · Restricted Project

May 15 2019

riccibruno added a comment to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.

Ping :)

May 15 2019, 11:52 AM · Restricted Project

May 8 2019

riccibruno updated the diff for D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.

Address Aaron's comments.

May 8 2019, 5:28 AM · Restricted Project
riccibruno added inline comments to D60910: [WIP] Dumping the AST to JSON.
May 8 2019, 5:10 AM

May 2 2019

riccibruno added inline comments to D61432: Non-8-bit bytes showcase.
May 2 2019, 7:18 AM · Restricted Project

May 1 2019

riccibruno added a comment to D61389: Bump DIAG_SIZE_SEMA up to 4000.

Already done in r359702 :)

May 1 2019, 12:17 PM · Restricted Project

Apr 30 2019

riccibruno added inline comments to D61288: [Diagnostics] Implemented support for -Wswitch-default.
Apr 30 2019, 5:04 AM · Restricted Project

Apr 29 2019

riccibruno added a comment to D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997).

@rsmith Do you have an opinion on whether this ADL rule should be implemented ?

Apr 29 2019, 5:26 PM · Restricted Project
riccibruno added a comment to D61288: [Diagnostics] Implemented support for -Wswitch-default.

Is it intentional to warn even if all the cases are covered ?

Apr 29 2019, 5:20 PM · Restricted Project
riccibruno added inline comments to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Apr 29 2019, 5:17 PM · Restricted Project
riccibruno updated the diff for D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Apr 29 2019, 5:11 PM · Restricted Project
riccibruno added a comment to D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI.

Since this is target-specific, is it right to put this here ?

Apr 29 2019, 1:20 PM · Restricted Project, Restricted Project

Apr 25 2019

riccibruno planned changes to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Apr 25 2019, 6:05 AM · Restricted Project

Apr 23 2019

riccibruno resigned from D60523: [clang] Don't segfault on incorrect using directive (PR41400).

I will take a look at this tomorrow, I know that it is annoying to get no feedback!

Apr 23 2019, 2:20 PM · Restricted Project, Restricted Project
riccibruno added inline comments to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Apr 23 2019, 10:50 AM · Restricted Project
riccibruno abandoned D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map.
Apr 23 2019, 9:30 AM
riccibruno commandeered D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map.

Closing this since the issue was fixed in r358674.

Apr 23 2019, 9:30 AM
riccibruno added a comment to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.

Added a test which exposes a new problem that this patch incidentally solves (see N_conflicting_namespace_alias). Because of the using directive using namespace M;, the namespace alias i for the namespace Q is found in the redeclaration lookup. Before this patch, since getAsSingle used internally getUnderlyingDecl(), PrevDecl was for the NamespaceDecl for Q, and not for the VarDecl for Q::i. Then the declaration for the enumerator i was mistakenly rejected since Q is in the same scope.

Apr 23 2019, 9:16 AM · Restricted Project
riccibruno added inline comments to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Apr 23 2019, 9:12 AM · Restricted Project
riccibruno updated the diff for D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
  • Added a test (see N_shadow) for the behavior of Wshadow. This test showed that I forgot to change CheckShadow(New, PrevDecl, R); to CheckShadow(New, PrevDecl->getUnderlyingDecl(), R); to match change in the condition of the if statement.
Apr 23 2019, 9:01 AM · Restricted Project

Apr 22 2019

riccibruno committed rGaf3e50ad4083: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG… (authored by riccibruno).
[Sema] ADL: Associated namespaces for class types and enumeration types (CWG…
Apr 22 2019, 5:18 AM
riccibruno added inline comments to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Apr 22 2019, 5:08 AM · Restricted Project
riccibruno committed rG1f30dba14daa: [Sema][NFC] Add more tests for the behavior of argument-dependent name lookup (authored by riccibruno).
[Sema][NFC] Add more tests for the behavior of argument-dependent name lookup
Apr 22 2019, 4:40 AM

Apr 21 2019

riccibruno accepted D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

@Quuxplusone Do you have other objections apart from the template-id issue ? If not, since D60573 depends on this patch, I would like to commit this with a comment explaining the issue instead of the FIXME.

Sure, go for it!

Apr 21 2019, 5:09 PM · Restricted Project, Restricted Project
riccibruno added a reviewer for D60523: [clang] Don't segfault on incorrect using directive (PR41400): riccibruno.

I will take a look at this tomorrow, I know that it is annoying to get no feedback!

Apr 21 2019, 2:52 PM · Restricted Project, Restricted Project
riccibruno added a comment to D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

@Quuxplusone Do you have other objections apart from the template-id issue ? If not, since D60573 depends on this patch, I would like to commit this with a comment explaining the issue instead of the FIXME.

Apr 21 2019, 2:46 PM · Restricted Project, Restricted Project
riccibruno created D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Apr 21 2019, 2:42 PM · Restricted Project
riccibruno added inline comments to D50360: [Concepts] Requires Expressions.
Apr 21 2019, 10:25 AM · Restricted Project
riccibruno committed rGba7ffae0c564: [Sema][MSVC] Fix bogus microsoft-pure-definition warning on member function of… (authored by riccibruno).
[Sema][MSVC] Fix bogus microsoft-pure-definition warning on member function of…
Apr 21 2019, 6:12 AM
riccibruno accepted D29707: Fix improper microsoft-pure-definition warning on template class.

This looks reasonable to me (although I think that the test should be in SemaCXX/ and not in Parser/, but the test for the non-template case is already in Parser/ so ok).

Apr 21 2019, 5:48 AM · Restricted Project

Apr 20 2019

riccibruno added a comment to D60910: [WIP] Dumping the AST to JSON.

A few comments/questions:

  1. How stable is the format going to be, and how much state is going to be exposed ?

I don't expect it to be particularly stable (I'm not suggesting we conform to some particular schema) and for my own needs, I'm happy enough if new Clang releases break us due to new, deleted, or renamed information. I need to expose as much state as required for our research team to import the data and reason about the AST; I'd guess it's going to be roughly the same as the textual dumper, but different in spots.

Apr 20 2019, 10:03 AM
riccibruno added a comment to D60934: [clang] adding explicit(bool) from c++2a.

This patch certainly took a few hours to write. Can you spend 5 minutes on making the summary readable (spelling, capitalization, formatting, well-formed sentences, ...) ?

Apr 20 2019, 8:37 AM · Restricted Project, Restricted Project
riccibruno updated subscribers of D60910: [WIP] Dumping the AST to JSON.

A few comments/questions:

Apr 20 2019, 5:21 AM

Apr 18 2019

riccibruno committed rG9f1a40c24fb0: [Sema][NFC] Mark DR1563 as done (List-initialization and overloaded function… (authored by riccibruno).
[Sema][NFC] Mark DR1563 as done (List-initialization and overloaded function…
Apr 18 2019, 8:44 AM
riccibruno committed rG0e37bebaee10: [Sema][NFC] Mark DR705 (Suppressing argument-dependent lookup via parentheses)… (authored by riccibruno).
[Sema][NFC] Mark DR705 (Suppressing argument-dependent lookup via parentheses)…
Apr 18 2019, 8:36 AM
riccibruno committed rG2751b69dd394: [Serialization] Stable serialization order for OpenCLTypeExtMap and… (authored by riccibruno).
[Serialization] Stable serialization order for OpenCLTypeExtMap and…
Apr 18 2019, 8:14 AM
riccibruno added a comment to D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap.

By the way, I am wondering about how much this is tested. I did look quickly in test/PCH and it appears that there are only 3 (short) tests : ocl_types.cl, opencl-extensions.cl and no-validate-pch.

This is tested in test/SemaOpenCL/extension-begin.cl: https://reviews.llvm.org/D53200

Apr 18 2019, 6:17 AM · Restricted Project, Restricted Project

Apr 17 2019

riccibruno added a comment to D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap.

By the way, I am wondering about how much this is tested. I did look quickly in test/PCH and it appears that there are only 3 (short) tests : ocl_types.cl, opencl-extensions.cl and no-validate-pch.

Apr 17 2019, 2:46 PM · Restricted Project, Restricted Project
riccibruno added a comment to D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map.

What about something like D60835 ?

Apr 17 2019, 2:37 PM
riccibruno created D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap.
Apr 17 2019, 2:37 PM · Restricted Project, Restricted Project
riccibruno added a comment to D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map.

Maybe, but is there an equivalent to getTypeID for declarations ?

Apr 17 2019, 6:48 AM
riccibruno added a comment to D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map.

Mmm. I hope I am not missing something obvious, but how is this actually fixing the issue ? I don't see why the order between the Type * and between the Decl * should be deterministic (I think they will be when they are part of the same slab in the allocator, but I don't see why the slab ordering should be stable).

Apr 17 2019, 6:35 AM
riccibruno updated subscribers of D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

@rsmith @aaron.ballman Do you have any opinion on whether the ADL rules from CWG 997 should be implemented ? The issue here as I understand it is that these rules expand ADL, but no one apart from GCC implement them. By implementing these rules, the argument to remove them in the future becomes weaker since real code might actually start to depend on them.

Apr 17 2019, 6:26 AM · Restricted Project, Restricted Project

Apr 15 2019

riccibruno added a comment to D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests..

This is also very useful to test that a given warning is only emitted in c++xx. Funnily when grepping for verify= in test/ most matches are from tests exercising this functionality.

Apr 15 2019, 3:09 PM · Restricted Project, Restricted Project
riccibruno added a comment to D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997).

For information we are discussing in D60570 whether it is actually a good idea to implement this rule.

Apr 15 2019, 6:31 AM · Restricted Project
riccibruno added a comment to D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

(I have numbered your examples to make the discussion easier, and moved to a non-inline comment to have more space)

Apr 15 2019, 6:23 AM · Restricted Project, Restricted Project

Apr 14 2019

riccibruno updated the diff for D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

Also test that typedef-names and using-declarations are not considered.

Apr 14 2019, 10:39 AM · Restricted Project, Restricted Project
riccibruno added a comment to D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).

Hmm. Does this never impact code that's just using a locally-defined type within its scope? I guess if ADL is involved, unqualified lookup must have reached the scope of the innermost namespace, and so it would be searching that namespace anyway.

In that case, I think I'm mollified that the source-compatibility risk is low and we should just unconditionally apply the new rule. LGTM.

I am not sure about what you mean. It is certainly possible to construct a piece of C++11 code which breaks with this patch.

Yes, but these examples are contrived, so it's easy to rationalize that the source impact is low. The typical use-pattern of a local type is that you only use it locally, so the most important question would be whether it is possible to change the semantics of, say,

void test() {
  struct A { ... };
  foo(A{});
}

But I think the answer is "no", for the reasons I explained.

Apr 14 2019, 7:02 AM · Restricted Project
riccibruno added a child revision for D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691): D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997).
Apr 14 2019, 6:26 AM · Restricted Project
riccibruno added a parent revision for D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997): D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).
Apr 14 2019, 6:26 AM · Restricted Project
riccibruno created D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997).
Apr 14 2019, 6:26 AM · Restricted Project
riccibruno updated the diff for D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.
Apr 14 2019, 6:05 AM · Restricted Project, Restricted Project
riccibruno added a comment to D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

As you're making tests for ADL corner cases, you might also consider testing the interactions between ADL and defaulted function parameters, e.g. https://godbolt.org/z/vHnyFl
It looks like everyone (except MSVC) already gets that stuff right (or at least portable-between-the-big-three). I bet the behavior naturally falls out of some other rules; you might say "there's no way that could possibly break, so we don't need to test it," and I'd accept that.

Apr 14 2019, 6:03 AM · Restricted Project, Restricted Project

Apr 13 2019

riccibruno added a comment to D60561: [clang] fixing diagnostics of constexpr callstack.

the impact was much higher than i expected, around 1% slower in average on 50 compilation of SemaDecl with -fsyntax-only.

Apr 13 2019, 5:23 AM · Restricted Project

Apr 12 2019

Herald added a project to D50360: [Concepts] Requires Expressions: Restricted Project.
Apr 12 2019, 4:36 PM · Restricted Project
Herald added a reviewer for D44352: [Concepts] Type Constraints: martong.
Apr 12 2019, 4:33 PM · Restricted Project
Herald added a reviewer for D43357: [Concepts] Function trailing requires clauses: martong.
Apr 12 2019, 4:33 PM · Restricted Project
Herald added a project to D41910: [Concepts] Constrained partial specializations and function overloads.: Restricted Project.
Apr 12 2019, 4:33 PM · Restricted Project
Herald added a project to D41569: [Concepts] Constraint enforcement and diagnostics: Restricted Project.
Apr 12 2019, 4:33 PM · Restricted Project
Herald added a project to D41284: [Concepts] Associated constraints infrastructure.: Restricted Project.
Apr 12 2019, 4:33 PM · Restricted Project
riccibruno added a comment to D60561: [clang] fixing diagnostics of constexpr callstack.

@rsmith i don't think collecting theses values is expansive compared to evaluating the expression.
but i agree that we can disable the collection of these values when no diagnostics can be emited.

Apr 12 2019, 11:41 AM · Restricted Project
riccibruno added a comment to D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions..

Friendly ping.

Apr 12 2019, 9:35 AM · Restricted Project
riccibruno committed rG061865093f0d: [AST][NFC] Add const children() accessors to all AST nodes (authored by riccibruno).
[AST][NFC] Add const children() accessors to all AST nodes
Apr 12 2019, 8:37 AM
riccibruno added inline comments to D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.
Apr 12 2019, 7:15 AM · Restricted Project, Restricted Project
riccibruno committed rGf6c7692d60ba: [AST] Forbid copy/move of statements/types (authored by riccibruno).
[AST] Forbid copy/move of statements/types
Apr 12 2019, 6:26 AM
riccibruno accepted D60029: Add const children() accessors to all AST nodes..
Apr 12 2019, 6:24 AM · Restricted Project
riccibruno added a comment to D60029: Add const children() accessors to all AST nodes..

Sorry for the delay. Thanks a lot for the patch!

Apr 12 2019, 6:24 AM · Restricted Project

Apr 11 2019

riccibruno added a comment to D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).

I have applied the fix to all language versions, even though I think that the DR only applies to C++14

DRs don't have a specific version that they are intended to apply to; that's up to us to determine, and generally we apply them retroactively as far back as they make sense -- they are supposed to be bug fixes, after all. (From ISO's perspective, C++11 was retracted and replaced by C++14 when the latter was published, so it's simply not meaningful for a DR to officially target anything older than that, and the only version that DRs can meaningfully list is whatever version was most recently published when they were approved.)

This looks good to me. Thanks!

Apr 11 2019, 5:21 PM · Restricted Project
riccibruno added a comment to D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).

Hmm. Does this never impact code that's just using a locally-defined type within its scope? I guess if ADL is involved, unqualified lookup must have reached the scope of the innermost namespace, and so it would be searching that namespace anyway.

In that case, I think I'm mollified that the source-compatibility risk is low and we should just unconditionally apply the new rule. LGTM.

Apr 11 2019, 5:18 PM · Restricted Project
riccibruno updated the diff for D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).

Removed the call to isTransparentContext() in the loop in CollectEnclosingNamespace. It is not actually needed since we only care about finding the innermost enclosing namespace.

Apr 11 2019, 2:41 PM · Restricted Project
riccibruno updated the diff for D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

Also test for inline namespaces.

Apr 11 2019, 2:36 PM · Restricted Project, Restricted Project
riccibruno resigned from D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract..

I am not the best person to review this, sorry!

Apr 11 2019, 1:42 PM · Restricted Project, Restricted Project
riccibruno edited reviewers for D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions., added: rjmccall, Quuxplusone; removed: aaron.ballman.
Apr 11 2019, 1:40 PM · Restricted Project
riccibruno edited reviewers for D57660: [Sema] SequenceChecker: Handle references, members and structured bindings., added: rjmccall, Quuxplusone; removed: aaron.ballman.
Apr 11 2019, 1:40 PM · Restricted Project
riccibruno added a comment to D57660: [Sema] SequenceChecker: Handle references, members and structured bindings..

Friendly ping.

Apr 11 2019, 1:40 PM · Restricted Project
riccibruno added a parent revision for D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691): D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.
Apr 11 2019, 11:50 AM · Restricted Project
riccibruno added a child revision for D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup: D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).
Apr 11 2019, 11:50 AM · Restricted Project, Restricted Project
riccibruno created D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).
Apr 11 2019, 11:50 AM · Restricted Project