Page MenuHomePhabricator

riccibruno (Bruno Ricci)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2018, 8:27 AM (49 w, 2 d)

Recent Activity

Wed, May 15

riccibruno added a comment to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.

Ping :)

Wed, May 15, 11:52 AM · Restricted Project

Wed, May 8

riccibruno updated the diff for D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.

Address Aaron's comments.

Wed, May 8, 5:28 AM · Restricted Project
riccibruno added inline comments to D60910: [WIP] Dumping the AST to JSON.
Wed, May 8, 5:10 AM

Thu, May 2

riccibruno added inline comments to D61432: Non-8-bit bytes showcase.
Thu, May 2, 7:18 AM · Restricted Project

Wed, May 1

riccibruno added a comment to D61389: Bump DIAG_SIZE_SEMA up to 4000.

Already done in r359702 :)

Wed, May 1, 12:17 PM · Restricted Project

Tue, Apr 30

riccibruno added inline comments to D61288: [Diagnostics] Implemented support for -Wswitch-default.
Tue, Apr 30, 5:04 AM · Restricted Project

Mon, Apr 29

riccibruno added a comment to D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997).

@rsmith Do you have an opinion on whether this ADL rule should be implemented ?

Mon, Apr 29, 5:26 PM · Restricted Project
riccibruno added a comment to D61288: [Diagnostics] Implemented support for -Wswitch-default.

Is it intentional to warn even if all the cases are covered ?

Mon, Apr 29, 5:20 PM · Restricted Project
riccibruno added inline comments to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Mon, Apr 29, 5:17 PM · Restricted Project
riccibruno updated the diff for D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Mon, Apr 29, 5:11 PM · Restricted Project
riccibruno added a comment to D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI.

Since this is target-specific, is it right to put this here ?

Mon, Apr 29, 1:20 PM · Restricted Project, Restricted Project

Thu, Apr 25

riccibruno planned changes to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Thu, Apr 25, 6:05 AM · Restricted Project

Tue, Apr 23

riccibruno resigned from D60523: [clang] Don't segfault on incorrect using directive (PR41400).

I will take a look at this tomorrow, I know that it is annoying to get no feedback!

Tue, Apr 23, 2:20 PM · Restricted Project
riccibruno added inline comments to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Tue, Apr 23, 10:50 AM · Restricted Project
riccibruno abandoned D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map.
Tue, Apr 23, 9:30 AM
riccibruno commandeered D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map.

Closing this since the issue was fixed in r358674.

Tue, Apr 23, 9:30 AM
riccibruno added a comment to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.

Added a test which exposes a new problem that this patch incidentally solves (see N_conflicting_namespace_alias). Because of the using directive using namespace M;, the namespace alias i for the namespace Q is found in the redeclaration lookup. Before this patch, since getAsSingle used internally getUnderlyingDecl(), PrevDecl was for the NamespaceDecl for Q, and not for the VarDecl for Q::i. Then the declaration for the enumerator i was mistakenly rejected since Q is in the same scope.

Tue, Apr 23, 9:16 AM · Restricted Project
riccibruno added inline comments to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Tue, Apr 23, 9:12 AM · Restricted Project
riccibruno updated the diff for D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
  • Added a test (see N_shadow) for the behavior of Wshadow. This test showed that I forgot to change CheckShadow(New, PrevDecl, R); to CheckShadow(New, PrevDecl->getUnderlyingDecl(), R); to match change in the condition of the if statement.
Tue, Apr 23, 9:01 AM · Restricted Project

Mon, Apr 22

riccibruno committed rGaf3e50ad4083: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG… (authored by riccibruno).
[Sema] ADL: Associated namespaces for class types and enumeration types (CWG…
Mon, Apr 22, 5:18 AM
riccibruno added inline comments to D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Mon, Apr 22, 5:08 AM · Restricted Project
riccibruno committed rG1f30dba14daa: [Sema][NFC] Add more tests for the behavior of argument-dependent name lookup (authored by riccibruno).
[Sema][NFC] Add more tests for the behavior of argument-dependent name lookup
Mon, Apr 22, 4:40 AM

Sun, Apr 21

riccibruno accepted D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

@Quuxplusone Do you have other objections apart from the template-id issue ? If not, since D60573 depends on this patch, I would like to commit this with a comment explaining the issue instead of the FIXME.

Sure, go for it!

Sun, Apr 21, 5:09 PM · Restricted Project, Restricted Project
riccibruno added a reviewer for D60523: [clang] Don't segfault on incorrect using directive (PR41400): riccibruno.

I will take a look at this tomorrow, I know that it is annoying to get no feedback!

Sun, Apr 21, 2:52 PM · Restricted Project
riccibruno added a comment to D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

@Quuxplusone Do you have other objections apart from the template-id issue ? If not, since D60573 depends on this patch, I would like to commit this with a comment explaining the issue instead of the FIXME.

Sun, Apr 21, 2:46 PM · Restricted Project, Restricted Project
riccibruno created D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator.
Sun, Apr 21, 2:42 PM · Restricted Project
riccibruno added inline comments to D50360: [Concepts] Requires Expressions.
Sun, Apr 21, 10:25 AM · Restricted Project

Apr 21 2019

riccibruno committed rGba7ffae0c564: [Sema][MSVC] Fix bogus microsoft-pure-definition warning on member function of… (authored by riccibruno).
[Sema][MSVC] Fix bogus microsoft-pure-definition warning on member function of…
Apr 21 2019, 6:12 AM
riccibruno accepted D29707: Fix improper microsoft-pure-definition warning on template class.

This looks reasonable to me (although I think that the test should be in SemaCXX/ and not in Parser/, but the test for the non-template case is already in Parser/ so ok).

Apr 21 2019, 5:48 AM · Restricted Project

Apr 20 2019

riccibruno added a comment to D60910: [WIP] Dumping the AST to JSON.

A few comments/questions:

  1. How stable is the format going to be, and how much state is going to be exposed ?

I don't expect it to be particularly stable (I'm not suggesting we conform to some particular schema) and for my own needs, I'm happy enough if new Clang releases break us due to new, deleted, or renamed information. I need to expose as much state as required for our research team to import the data and reason about the AST; I'd guess it's going to be roughly the same as the textual dumper, but different in spots.

Apr 20 2019, 10:03 AM
riccibruno added a comment to D60934: [clang] adding explicit(bool) from c++2a.

This patch certainly took a few hours to write. Can you spend 5 minutes on making the summary readable (spelling, capitalization, formatting, well-formed sentences, ...) ?

Apr 20 2019, 8:37 AM · Restricted Project, Restricted Project
riccibruno updated subscribers of D60910: [WIP] Dumping the AST to JSON.

A few comments/questions:

Apr 20 2019, 5:21 AM

Apr 18 2019

riccibruno committed rG9f1a40c24fb0: [Sema][NFC] Mark DR1563 as done (List-initialization and overloaded function… (authored by riccibruno).
[Sema][NFC] Mark DR1563 as done (List-initialization and overloaded function…
Apr 18 2019, 8:44 AM
riccibruno committed rG0e37bebaee10: [Sema][NFC] Mark DR705 (Suppressing argument-dependent lookup via parentheses)… (authored by riccibruno).
[Sema][NFC] Mark DR705 (Suppressing argument-dependent lookup via parentheses)…
Apr 18 2019, 8:36 AM
riccibruno committed rG2751b69dd394: [Serialization] Stable serialization order for OpenCLTypeExtMap and… (authored by riccibruno).
[Serialization] Stable serialization order for OpenCLTypeExtMap and…
Apr 18 2019, 8:14 AM
riccibruno added a comment to D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap.

By the way, I am wondering about how much this is tested. I did look quickly in test/PCH and it appears that there are only 3 (short) tests : ocl_types.cl, opencl-extensions.cl and no-validate-pch.

This is tested in test/SemaOpenCL/extension-begin.cl: https://reviews.llvm.org/D53200

Apr 18 2019, 6:17 AM · Restricted Project, Restricted Project

Apr 17 2019

riccibruno added a comment to D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap.

By the way, I am wondering about how much this is tested. I did look quickly in test/PCH and it appears that there are only 3 (short) tests : ocl_types.cl, opencl-extensions.cl and no-validate-pch.

Apr 17 2019, 2:46 PM · Restricted Project, Restricted Project
riccibruno added a comment to D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map.

What about something like D60835 ?

Apr 17 2019, 2:37 PM
riccibruno created D60835: [Serialization] Stable serialization order for OpenCLTypeExtMap and OpenCLDeclExtMap.
Apr 17 2019, 2:37 PM · Restricted Project, Restricted Project
riccibruno added a comment to D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map.

Maybe, but is there an equivalent to getTypeID for declarations ?

Apr 17 2019, 6:48 AM
riccibruno added a comment to D60778: Make precompiled headers reproducible by switching OpenCL extension to std::map.

Mmm. I hope I am not missing something obvious, but how is this actually fixing the issue ? I don't see why the order between the Type * and between the Decl * should be deterministic (I think they will be when they are part of the same slab in the allocator, but I don't see why the slab ordering should be stable).

Apr 17 2019, 6:35 AM
riccibruno updated subscribers of D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

@rsmith @aaron.ballman Do you have any opinion on whether the ADL rules from CWG 997 should be implemented ? The issue here as I understand it is that these rules expand ADL, but no one apart from GCC implement them. By implementing these rules, the argument to remove them in the future becomes weaker since real code might actually start to depend on them.

Apr 17 2019, 6:26 AM · Restricted Project, Restricted Project

Apr 15 2019

riccibruno added a comment to D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests..

This is also very useful to test that a given warning is only emitted in c++xx. Funnily when grepping for verify= in test/ most matches are from tests exercising this functionality.

Apr 15 2019, 3:09 PM · Restricted Project, Restricted Project
riccibruno added a comment to D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997).

For information we are discussing in D60570 whether it is actually a good idea to implement this rule.

Apr 15 2019, 6:31 AM · Restricted Project
riccibruno added a comment to D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

(I have numbered your examples to make the discussion easier, and moved to a non-inline comment to have more space)

Apr 15 2019, 6:23 AM · Restricted Project, Restricted Project

Apr 14 2019

riccibruno updated the diff for D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

Also test that typedef-names and using-declarations are not considered.

Apr 14 2019, 10:39 AM · Restricted Project, Restricted Project
riccibruno added a comment to D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).

Hmm. Does this never impact code that's just using a locally-defined type within its scope? I guess if ADL is involved, unqualified lookup must have reached the scope of the innermost namespace, and so it would be searching that namespace anyway.

In that case, I think I'm mollified that the source-compatibility risk is low and we should just unconditionally apply the new rule. LGTM.

I am not sure about what you mean. It is certainly possible to construct a piece of C++11 code which breaks with this patch.

Yes, but these examples are contrived, so it's easy to rationalize that the source impact is low. The typical use-pattern of a local type is that you only use it locally, so the most important question would be whether it is possible to change the semantics of, say,

void test() {
  struct A { ... };
  foo(A{});
}

But I think the answer is "no", for the reasons I explained.

Apr 14 2019, 7:02 AM · Restricted Project
riccibruno added a child revision for D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691): D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997).
Apr 14 2019, 6:26 AM · Restricted Project
riccibruno added a parent revision for D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997): D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).
Apr 14 2019, 6:26 AM · Restricted Project
riccibruno created D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997).
Apr 14 2019, 6:26 AM · Restricted Project
riccibruno updated the diff for D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.
Apr 14 2019, 6:05 AM · Restricted Project, Restricted Project
riccibruno added a comment to D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

As you're making tests for ADL corner cases, you might also consider testing the interactions between ADL and defaulted function parameters, e.g. https://godbolt.org/z/vHnyFl
It looks like everyone (except MSVC) already gets that stuff right (or at least portable-between-the-big-three). I bet the behavior naturally falls out of some other rules; you might say "there's no way that could possibly break, so we don't need to test it," and I'd accept that.

Apr 14 2019, 6:03 AM · Restricted Project, Restricted Project

Apr 13 2019

riccibruno added a comment to D60561: [clang] fixing diagnostics of constexpr callstack.

the impact was much higher than i expected, around 1% slower in average on 50 compilation of SemaDecl with -fsyntax-only.

Apr 13 2019, 5:23 AM · Restricted Project

Apr 12 2019

Herald added a project to D50360: [Concepts] Requires Expressions: Restricted Project.
Apr 12 2019, 4:36 PM · Restricted Project
Herald added a reviewer for D44352: [Concepts] Type Constraints: martong.
Apr 12 2019, 4:33 PM · Restricted Project
Herald added a reviewer for D43357: [Concepts] Function trailing requires clauses: martong.
Apr 12 2019, 4:33 PM · Restricted Project
Herald added a project to D41910: [Concepts] Constrained partial specializations and function overloads.: Restricted Project.
Apr 12 2019, 4:33 PM · Restricted Project
Herald added a project to D41569: [Concepts] Constraint enforcement and diagnostics: Restricted Project.
Apr 12 2019, 4:33 PM · Restricted Project
Herald added a project to D41284: [Concepts] Associated constraints infrastructure.: Restricted Project.
Apr 12 2019, 4:33 PM · Restricted Project
riccibruno added a comment to D60561: [clang] fixing diagnostics of constexpr callstack.

@rsmith i don't think collecting theses values is expansive compared to evaluating the expression.
but i agree that we can disable the collection of these values when no diagnostics can be emited.

Apr 12 2019, 11:41 AM · Restricted Project
riccibruno added a comment to D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expression..

Friendly ping.

Apr 12 2019, 9:35 AM · Restricted Project
riccibruno committed rG061865093f0d: [AST][NFC] Add const children() accessors to all AST nodes (authored by riccibruno).
[AST][NFC] Add const children() accessors to all AST nodes
Apr 12 2019, 8:37 AM
riccibruno added inline comments to D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.
Apr 12 2019, 7:15 AM · Restricted Project, Restricted Project
riccibruno committed rGf6c7692d60ba: [AST] Forbid copy/move of statements/types (authored by riccibruno).
[AST] Forbid copy/move of statements/types
Apr 12 2019, 6:26 AM
riccibruno accepted D60029: Add const children() accessors to all AST nodes..
Apr 12 2019, 6:24 AM · Restricted Project
riccibruno added a comment to D60029: Add const children() accessors to all AST nodes..

Sorry for the delay. Thanks a lot for the patch!

Apr 12 2019, 6:24 AM · Restricted Project

Apr 11 2019

riccibruno added a comment to D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).

I have applied the fix to all language versions, even though I think that the DR only applies to C++14

DRs don't have a specific version that they are intended to apply to; that's up to us to determine, and generally we apply them retroactively as far back as they make sense -- they are supposed to be bug fixes, after all. (From ISO's perspective, C++11 was retracted and replaced by C++14 when the latter was published, so it's simply not meaningful for a DR to officially target anything older than that, and the only version that DRs can meaningfully list is whatever version was most recently published when they were approved.)

This looks good to me. Thanks!

Apr 11 2019, 5:21 PM · Restricted Project
riccibruno added a comment to D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).

Hmm. Does this never impact code that's just using a locally-defined type within its scope? I guess if ADL is involved, unqualified lookup must have reached the scope of the innermost namespace, and so it would be searching that namespace anyway.

In that case, I think I'm mollified that the source-compatibility risk is low and we should just unconditionally apply the new rule. LGTM.

Apr 11 2019, 5:18 PM · Restricted Project
riccibruno updated the diff for D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).

Removed the call to isTransparentContext() in the loop in CollectEnclosingNamespace. It is not actually needed since we only care about finding the innermost enclosing namespace.

Apr 11 2019, 2:41 PM · Restricted Project
riccibruno updated the diff for D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.

Also test for inline namespaces.

Apr 11 2019, 2:36 PM · Restricted Project, Restricted Project
riccibruno resigned from D59221: [asan] Add gcc 8's driver option -fsanitize=pointer-compare and -fsanitize=pointer-substract..

I am not the best person to review this, sorry!

Apr 11 2019, 1:42 PM · Restricted Project, Restricted Project
riccibruno edited reviewers for D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expression., added: rjmccall, Quuxplusone; removed: aaron.ballman.
Apr 11 2019, 1:40 PM · Restricted Project
riccibruno edited reviewers for D57660: [Sema] SequenceChecker: Handle references, members and structured bindings., added: rjmccall, Quuxplusone; removed: aaron.ballman.
Apr 11 2019, 1:40 PM · Restricted Project
riccibruno added a comment to D57660: [Sema] SequenceChecker: Handle references, members and structured bindings..

Friendly ping.

Apr 11 2019, 1:40 PM · Restricted Project
riccibruno added a parent revision for D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691): D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.
Apr 11 2019, 11:50 AM · Restricted Project
riccibruno added a child revision for D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup: D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).
Apr 11 2019, 11:50 AM · Restricted Project, Restricted Project
riccibruno created D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691).
Apr 11 2019, 11:50 AM · Restricted Project
riccibruno created D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup.
Apr 11 2019, 11:02 AM · Restricted Project, Restricted Project

Apr 8 2019

riccibruno added a comment to D60379: Make precompiled headers reproducible.

After looking at the bug report (https://bugs.debian.org/877359), I would like to point out that there is currently *absolutely* no stability guarantee for the serialization format (ie, you need the exact same revision). In regard of this I am wondering how sane it is to ship pch files.

I agree we shouldn't make guarantees about pch file format stability and that distributing pch files isn't a good idea. Having said that, making clang write the same output when given the same input is still a Good Thing as it enables caching these outputs e.g. with tools like distcc.

Apr 8 2019, 2:35 PM · Restricted Project
riccibruno added a comment to D60379: Make precompiled headers reproducible.

After looking at the bug report (https://bugs.debian.org/877359), I would like to point out that there is currently *absolutely* no stability guarantee for the serialization format (ie, you need the exact same revision). In regard of this I am wondering how sane it is to ship pch files.

Apr 8 2019, 11:09 AM · Restricted Project
riccibruno added inline comments to D60379: Make precompiled headers reproducible.
Apr 8 2019, 11:04 AM · Restricted Project

Apr 2 2019

riccibruno updated the diff for D60123: [AST] Forbid copy/move of statements/types..
Apr 2 2019, 6:27 AM · Restricted Project
riccibruno added a comment to D60123: [AST] Forbid copy/move of statements/types..

Probably Decl too?

Yep. I though it was already done but after checking it seems I remembered incorrectly.

Apr 2 2019, 6:19 AM · Restricted Project
riccibruno updated the diff for D60123: [AST] Forbid copy/move of statements/types..
Apr 2 2019, 6:14 AM · Restricted Project
riccibruno added a comment to D60123: [AST] Forbid copy/move of statements/types..

Probably Decl too?

Apr 2 2019, 6:05 AM · Restricted Project
riccibruno created D60123: [AST] Forbid copy/move of statements/types..
Apr 2 2019, 5:49 AM · Restricted Project

Mar 31 2019

riccibruno added inline comments to D59467: [clang] Adding the Likelihood Attribute from C++2a.
Mar 31 2019, 6:59 AM · Restricted Project

Mar 30 2019

riccibruno updated subscribers of D59467: [clang] Adding the Likelihood Attribute from C++2a.

It seems that the tests are not present in this diff ? Also, again, could you please:

  1. Use clang-format, and
  2. Make sure that the comments are full sentences with appropriate punctuation, and
  3. Follow the style guide regarding for the names of variables and functions.
Mar 30 2019, 1:08 PM · Restricted Project
riccibruno added a comment to D60029: Add const children() accessors to all AST nodes..

Did you go over all the statements on Stmt.h systematically ?

Yes.

You could also do the same thing for all of the statements/expressions in StmtCXX.h, Expr.h, ExprCXX.h, and so on.

I will go over those soon. I believe that Expr.h is mostly done.

Apart from this did you run clang-format on the patch ?

I tried to stick to the style of the non-const functions, even when it was wrong. I will clang-format the next patch!

Mar 30 2019, 11:28 AM · Restricted Project
riccibruno added a comment to D60029: Add const children() accessors to all AST nodes..

+1. I wanted to do this but never bothered. Did you go over all the statements on Stmt.h systematically ? You could also do the same thing for all of the statements/expressions in StmtCXX.h, Expr.h, ExprCXX.h, and so on. Apart from this did you run clang-format on the patch ?

Mar 30 2019, 10:49 AM · Restricted Project

Mar 29 2019

riccibruno added a comment to D57660: [Sema] SequenceChecker: Handle references, members and structured bindings..

Ping.

Mar 29 2019, 11:03 AM · Restricted Project

Mar 25 2019

riccibruno added inline comments to D59797: [COFF] Reduce the size of Chunk and SectionChunk, NFC.
Mar 25 2019, 4:00 PM · Restricted Project, Restricted Project
riccibruno committed rG95550e412f3a: [Sema] Don't check for array bounds when the types in the base expression are… (authored by riccibruno).
[Sema] Don't check for array bounds when the types in the base expression are…
Mar 25 2019, 2:37 PM
riccibruno committed rG70ad396bc49a: [Sema][NFCI] Don't allocate storage for the various CorrectionCandidateCallback… (authored by riccibruno).
[Sema][NFCI] Don't allocate storage for the various CorrectionCandidateCallback…
Mar 25 2019, 10:08 AM
riccibruno created D59776: [Sema] Don't check for array bounds when the types in the base expression are dependent..
Mar 25 2019, 9:19 AM · Restricted Project, Restricted Project

Mar 24 2019

riccibruno accepted D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".

Great! Since this already received one round of reviews I guess this looks okay.

Mar 24 2019, 4:28 PM · Restricted Project
riccibruno added inline comments to D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block".
Mar 24 2019, 4:02 PM · Restricted Project
riccibruno removed a reviewer for D59752: Un-revert "[coroutines][PR40978] Emit error for co_yield within catch block": bricci.
Mar 24 2019, 3:19 PM · Restricted Project

Mar 23 2019

riccibruno added a comment to D59467: [clang] Adding the Likelihood Attribute from C++2a.

Before any further review, could you please run clang-format on your patch (but not necessarily on the tests and not on the *.td files), wrap lines to 80 cols, and in general use complete sentences in comments (that is with proper punctuation and capitalization) ? To run clang-format on your patch you can use clang-format-diff. This is the command I use :

Mar 23 2019, 11:44 AM · Restricted Project

Mar 22 2019

riccibruno added a comment to D59467: [clang] Adding the Likelihood Attribute from C++2a.

To expand on the above, if you need to add a few bits to a statement/expression you can use the bit-field classes in Stmt (for example: IfStmtBitfields). You will also need to update the serialization code in Serialization/ASTWriterStmt.cpp and Serialization/ASTReaderStmt.cpp.

Mar 22 2019, 10:04 AM · Restricted Project