Page MenuHomePhabricator

riccibruno (Bruno Ricci)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 10 2018, 8:27 AM (124 w, 16 h)

Recent Activity

Sep 17 2020

riccibruno added inline comments to D87831: [clang] Expose helper function to turn PP keywords spelling into PPKeywordKind.
Sep 17 2020, 7:56 AM · Restricted Project

Sep 15 2020

riccibruno added inline comments to D87540: [clang-tidy] Fix false positive issue in performance-unnecessary-value-param for arguments being moved in the function body..
Sep 15 2020, 6:54 AM · Restricted Project, Restricted Project

Sep 8 2020

riccibruno accepted D87278: [Ignore Expressions] Fix performance regression by inlining `Ignore*SingleStep`.

Thanks!

Sep 8 2020, 9:55 AM · Restricted Project

Sep 7 2020

riccibruno added a comment to rG81aa66f65f50: Extract infrastructure to ignore intermediate expressions into….

This causes a measurable performance regression (http://llvm-compile-time-tracker.com/compare.php?from=8d64df9f139038b48344dd9f1f20a38b22aba8c9&to=81aa66f65f504af18982baa078a5f3f7d2aa88fa&stat=instructions), probably because the various single step functions are not inlined anymore.

Sep 7 2020, 3:49 PM
riccibruno added a comment to D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName.

To make this patch more acceptable I could also add a Visit function for DecompositionDecl and MSGuidDecl such that the current behaviour is preserved (I won't be able to test it though since these implicit AST nodes are not visited).

Sep 7 2020, 1:18 PM · Restricted Project
riccibruno added a comment to D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr.

This change allow a CallExpr to have optional FPOptionsOverride object,

Sep 7 2020, 11:58 AM · Restricted Project
riccibruno added a comment to D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations..

And what if deserialization is forced?

Sep 7 2020, 3:53 AM · Restricted Project

Sep 4 2020

riccibruno retitled D85613: [clang] Also consider structured bindings when checking whether a local entity is odr-used in a default argument. from [clang] Look through bindings when checking whether a default argument references a local entity. to [clang] Also consider structured bindings when checking whether a local entity is odr-used in a default argument..
Sep 4 2020, 4:08 AM · Restricted Project

Sep 2 2020

riccibruno added inline comments to D85613: [clang] Also consider structured bindings when checking whether a local entity is odr-used in a default argument..
Sep 2 2020, 10:17 AM · Restricted Project
riccibruno added a comment to D86207: Set InvalidDecl directly when deserializing a Decl.

Is my comment on the deserialization of BindingDecls in https://reviews.llvm.org/D85613?id=284364 related to this change?

Not sure. The FIXME comment on the code is correct, and it would be correct after this change. But notice that Decomp is also not set when constructing a BindingDecl from the parser: first we build the BindingDecls in Sema::ActOnDecompositionDeclarator (there Decomp remains unset), then build the DecompositionDecl from that in Sema::ActOnVariableDeclarator. The constructor of DecompositionDecl is then calling setDecomposedDecl on all bindings, so Decomp is set as soon as that's finished. But the BindingDecls exist without Decomp for a while.

Sep 2 2020, 9:46 AM · Restricted Project
riccibruno added inline comments to D87004: [analyzer] Evaluate PredefinedExpressions.
Sep 2 2020, 6:41 AM · Restricted Project
riccibruno added a comment to D86207: Set InvalidDecl directly when deserializing a Decl.

Is my comment on the deserialization of BindingDecls in https://reviews.llvm.org/D85613?id=284364 related to this change?

Sep 2 2020, 5:50 AM · Restricted Project
riccibruno added inline comments to D87004: [analyzer] Evaluate PredefinedExpressions.
Sep 2 2020, 5:41 AM · Restricted Project
riccibruno added a comment to D87004: [analyzer] Evaluate PredefinedExpressions.

I don't know how could a PredefinedExpression lack the function name, probably @riccibruno or @rjmccall can help with this - according to D53605.

Sep 2 2020, 5:40 AM · Restricted Project

Aug 21 2020

riccibruno added a comment to D81003: [clang] SequenceChecker: Also visit default arguments and default initializers..

Friendly ping on this patch: this is the last change to SequenceChecker I had in mind.

Aug 21 2020, 8:44 AM · Restricted Project
riccibruno added a comment to D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName.

Friendly ping on this patch; the patches depending on this patch (D84658 and D85033 on Phab + others not uploaded yet) significantly improve the handling of unnamed entities in diagnostics.

Aug 21 2020, 8:42 AM · Restricted Project

Aug 11 2020

riccibruno updated the diff for D85613: [clang] Also consider structured bindings when checking whether a local entity is odr-used in a default argument..

Remove the now-unused const VarDecl * parameter to DiagnoseIfOdrUse.

Aug 11 2020, 9:57 AM · Restricted Project
riccibruno committed rGf4dccf115cc1: [clang] Add a matcher for template template parameters. (authored by riccibruno).
[clang] Add a matcher for template template parameters.
Aug 11 2020, 8:02 AM
riccibruno closed D85536: [clang] Add a matcher for template template parameters..
Aug 11 2020, 8:01 AM · Restricted Project
riccibruno added inline comments to D85613: [clang] Also consider structured bindings when checking whether a local entity is odr-used in a default argument..
Aug 11 2020, 7:41 AM · Restricted Project
riccibruno added inline comments to D85613: [clang] Also consider structured bindings when checking whether a local entity is odr-used in a default argument..
Aug 11 2020, 7:39 AM · Restricted Project
riccibruno updated the diff for D85613: [clang] Also consider structured bindings when checking whether a local entity is odr-used in a default argument..
Aug 11 2020, 7:38 AM · Restricted Project

Aug 10 2020

riccibruno added inline comments to D85613: [clang] Also consider structured bindings when checking whether a local entity is odr-used in a default argument..
Aug 10 2020, 7:52 AM · Restricted Project
riccibruno updated the diff for D85613: [clang] Also consider structured bindings when checking whether a local entity is odr-used in a default argument..

Refer to the binding in the diagnostic.

Aug 10 2020, 7:46 AM · Restricted Project

Aug 9 2020

riccibruno updated the summary of D85613: [clang] Also consider structured bindings when checking whether a local entity is odr-used in a default argument..
Aug 9 2020, 2:11 PM · Restricted Project
riccibruno added a comment to D85144: [clang] Improve Dumping of APValues.

I agree with you that it's fine to use printPretty for leaves (and additionally it would be annoying to duplicate the LValue case); that's what I was planning to do anyway.

Aug 9 2020, 11:36 AM · Restricted Project
riccibruno requested review of D85613: [clang] Also consider structured bindings when checking whether a local entity is odr-used in a default argument..
Aug 9 2020, 9:25 AM · Restricted Project
riccibruno added inline comments to D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type.
Aug 9 2020, 9:25 AM · Restricted Project

Aug 8 2020

riccibruno added inline comments to D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype.
Aug 8 2020, 7:28 AM · Restricted Project, Restricted Project
riccibruno added inline comments to D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype.
Aug 8 2020, 6:19 AM · Restricted Project, Restricted Project

Aug 7 2020

riccibruno added a comment to D85545: [Diagnostics] Diagnose missing comma in string array initialization.

Is there a way to suppress this diagnostic if someone wants to legitimately initialize an element of the array with a long string by relying on string literal concatenation?

Aug 7 2020, 1:12 PM · Restricted Project
riccibruno added a comment to D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName.

... or if a string such as (unnamed struct at /path/to/input.cc:1:3) is suitable in an USR then printName can be used.

Aug 7 2020, 12:45 PM · Restricted Project
riccibruno retitled D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName from [clang-index] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName to [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName.
Aug 7 2020, 12:37 PM · Restricted Project
riccibruno requested review of D85536: [clang] Add a matcher for template template parameters..
Aug 7 2020, 9:52 AM · Restricted Project
riccibruno added inline comments to D85144: [clang] Improve Dumping of APValues.
Aug 7 2020, 7:34 AM · Restricted Project

Aug 5 2020

riccibruno committed rG4dcbb9cef71a: [clang] Add -fno-delayed-template-parsing to the added unit tests in… (authored by riccibruno).
[clang] Add -fno-delayed-template-parsing to the added unit tests in…
Aug 5 2020, 6:14 AM
riccibruno committed rGf7a039de7af7: [clang][NFC] DeclPrinter: use NamedDecl::getDeclName instead of NamedDecl… (authored by riccibruno).
[clang][NFC] DeclPrinter: use NamedDecl::getDeclName instead of NamedDecl…
Aug 5 2020, 5:56 AM
riccibruno committed rG94b43118e220: [clang][NFCI] Get rid of ConstantMatrixTypeBitfields to avoid increasing the… (authored by riccibruno).
[clang][NFCI] Get rid of ConstantMatrixTypeBitfields to avoid increasing the…
Aug 5 2020, 5:56 AM
riccibruno committed rG19701458d469: [clang][nearly-NFC] Remove some superfluous uses of NamedDecl::getNameAsString (authored by riccibruno).
[clang][nearly-NFC] Remove some superfluous uses of NamedDecl::getNameAsString
Aug 5 2020, 5:56 AM
riccibruno committed rG6f2fa9d312fc: [clang][NFC] Document NamedDecl::printName (authored by riccibruno).
[clang][NFC] Document NamedDecl::printName
Aug 5 2020, 5:56 AM
riccibruno committed rGbc29634b93ac: [clang][NFC] Remove an old workaround for MSVC 2013 (authored by riccibruno).
[clang][NFC] Remove an old workaround for MSVC 2013
Aug 5 2020, 5:56 AM
riccibruno committed rG98b4b4570542: [clang][NFC] Add a test showcasing an unnamed template parameter in a diagnostic (authored by riccibruno).
[clang][NFC] Add a test showcasing an unnamed template parameter in a diagnostic
Aug 5 2020, 5:55 AM
riccibruno committed rG00b89f66f988: [clang][NFC] Remove spurious +x flag on DeclTemplate.cpp and DeclTemplate.h (authored by riccibruno).
[clang][NFC] Remove spurious +x flag on DeclTemplate.cpp and DeclTemplate.h
Aug 5 2020, 5:55 AM

Aug 3 2020

riccibruno added inline comments to D85144: [clang] Improve Dumping of APValues.
Aug 3 2020, 11:59 AM · Restricted Project
riccibruno added a comment to D85144: [clang] Improve Dumping of APValues.

Thanks for finishing this.

Aug 3 2020, 11:53 AM · Restricted Project
riccibruno added inline comments to D83261: [OPENMP]Redesign of OMPExecutableDirective representation..
Aug 3 2020, 9:52 AM · Restricted Project
riccibruno added a comment to D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName.

(Disclaimer: I am not at all familiar with this code)

Aug 3 2020, 6:35 AM · Restricted Project

Aug 1 2020

riccibruno updated the diff for D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures..

Don't forget to increment the field iterator in the loop of maybePrintFieldForLambdaCapture, and modify the tests to test this.

Aug 1 2020, 5:33 AM · Restricted Project

Jul 31 2020

riccibruno updated the summary of D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures..
Jul 31 2020, 2:52 PM · Restricted Project
riccibruno updated the diff for D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures..

Add -fno-delayed-template-parsing to the new unit tests to also pass on Windows.

Jul 31 2020, 2:33 PM · Restricted Project
riccibruno committed rG38d3e7533279: [clang] Use the location of the void parameters when complaining that only a… (authored by Jac1494).
[clang] Use the location of the void parameters when complaining that only a…
Jul 31 2020, 12:37 PM
riccibruno closed D84678: [clang] False line number in a function definition with "void" parameter.
Jul 31 2020, 12:37 PM · Restricted Project
riccibruno updated the diff for D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures..

Make the unit tests in NamedDeclPrinterTest.cpp more robust.

Jul 31 2020, 12:13 PM · Restricted Project
riccibruno added a comment to D84678: [clang] False line number in a function definition with "void" parameter.

Hi @aaron.ballman ,
Address your review comments.
Thank you for accepting this. I don't have commit access please commit this.
Thanks.

As discussed with Aaron on IRC I can commit it for you. To do that I need a name and an email for the attribution.
But first move the test to the already existing test/Sema/void_arg.c which already test this diagnostic.

Jul 31 2020, 10:39 AM · Restricted Project
riccibruno added a comment to D84678: [clang] False line number in a function definition with "void" parameter.

Hi @aaron.ballman ,
Address your review comments.
Thank you for accepting this. I don't have commit access please commit this.
Thanks.

Jul 31 2020, 10:27 AM · Restricted Project
riccibruno added a reviewer for D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures.: aaron.ballman.
Jul 31 2020, 9:44 AM · Restricted Project
riccibruno updated the summary of D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures..
Jul 31 2020, 9:25 AM · Restricted Project
riccibruno retitled D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures. from [clang] Provide a better name for unnamed parameters, lambda classes and lambda captures. to [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures..
Jul 31 2020, 9:24 AM · Restricted Project
riccibruno requested review of D85033: [clang] Provide a better pretty-printed name for unnamed parameters, lambda classes and lambda captures..
Jul 31 2020, 9:02 AM · Restricted Project

Jul 30 2020

riccibruno updated the diff for D81003: [clang] SequenceChecker: Also visit default arguments and default initializers..

Rebased with a few clang-format fixes.

Jul 30 2020, 11:33 AM · Restricted Project

Jul 29 2020

riccibruno added inline comments to D84005: Introduce ns_error_domain attribute..
Jul 29 2020, 6:57 AM · Restricted Project
riccibruno committed rG517fe058d42a: [clang][NFC] clang-format fix after eb10b065f2a870b425dcc2040b9955e0eee464b4 (authored by riccibruno).
[clang][NFC] clang-format fix after eb10b065f2a870b425dcc2040b9955e0eee464b4
Jul 29 2020, 6:55 AM
riccibruno committed rG1ae63b4179c2: [clang][NFC] Pass the ASTContext to CXXRecordDecl::setCaptures (authored by riccibruno).
[clang][NFC] Pass the ASTContext to CXXRecordDecl::setCaptures
Jul 29 2020, 6:55 AM
riccibruno added a reviewer for D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName: kadircet.
Jul 29 2020, 6:04 AM · Restricted Project
riccibruno added inline comments to D84005: Introduce ns_error_domain attribute..
Jul 29 2020, 5:48 AM · Restricted Project

Jul 28 2020

riccibruno updated the diff for D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities.

Add the forgotten context.

Jul 28 2020, 3:03 PM · Restricted Project
riccibruno updated the diff for D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities.

Use a less generic name instead of get{Open,Close}Delimiter. I went with get{Open,Close}DelimiterForUnnamedEntity but I am happy to change it.

Jul 28 2020, 3:02 PM · Restricted Project
riccibruno added a comment to D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities.

Note that I am planning two improvements as a follow-up to this patch:

Jul 28 2020, 8:20 AM · Restricted Project
riccibruno committed rG984cf99055a2: [clang][NFC] Add some documentation about the use of NamedDecl::getDeclName in… (authored by riccibruno).
[clang][NFC] Add some documentation about the use of NamedDecl::getDeclName in…
Jul 28 2020, 7:43 AM
riccibruno committed rG01302ec08609: [Support][NFC] Fix a Wdocumentation warning in FileSystem.h (authored by riccibruno).
[Support][NFC] Fix a Wdocumentation warning in FileSystem.h
Jul 28 2020, 7:36 AM
riccibruno committed rGb81fd5aeecd8: [clang-format][NFC] Fix a Wdocumentation warning in TokenAnnotator.cpp (authored by riccibruno).
[clang-format][NFC] Fix a Wdocumentation warning in TokenAnnotator.cpp
Jul 28 2020, 2:59 AM
riccibruno added a comment to D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName.

The overloads of NamedDecl::printName are in D84658.

Jul 28 2020, 2:43 AM · Restricted Project
riccibruno committed rGeb10b065f2a8: [clang] Pass the NamedDecl* instead of the DeclarationName into many… (authored by riccibruno).
[clang] Pass the NamedDecl* instead of the DeclarationName into many…
Jul 28 2020, 2:36 AM
riccibruno committed rGf5acd11d2c0e: [clang-format][NFC] Be more careful about the layout of FormatToken. (authored by riccibruno).
[clang-format][NFC] Be more careful about the layout of FormatToken.
Jul 28 2020, 2:36 AM
riccibruno closed D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics..
Jul 28 2020, 2:36 AM · Restricted Project
riccibruno closed D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..
Jul 28 2020, 2:36 AM · Restricted Project, Restricted Project
riccibruno added inline comments to D84678: [clang] False line number in a function definition with "void" parameter.
Jul 28 2020, 2:26 AM · Restricted Project
riccibruno added a comment to D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..

Thank you for the patch, this LGTM, I think this kind of change should help reduce memory usage and I feel improves the readability.

Jul 28 2020, 2:22 AM · Restricted Project, Restricted Project

Jul 27 2020

riccibruno added inline comments to D84678: [clang] False line number in a function definition with "void" parameter.
Jul 27 2020, 3:01 PM · Restricted Project
riccibruno added inline comments to D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities.
Jul 27 2020, 1:36 PM · Restricted Project
riccibruno updated the diff for D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities.

Address Erich's comments.

Jul 27 2020, 1:32 PM · Restricted Project
riccibruno added a comment to D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics..

The changes LGTM but it seems like there may be some formatting issues with the patch (or the lint tool is acting up).

Jul 27 2020, 12:44 PM · Restricted Project
riccibruno updated the diff for D84306: [clang-format][NFC] Be more careful about the layout of FormatToken..

Remove a few missed getPackingKind.

Jul 27 2020, 12:26 PM · Restricted Project, Restricted Project
riccibruno added inline comments to D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities.
Jul 27 2020, 7:49 AM · Restricted Project
riccibruno added inline comments to D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities.
Jul 27 2020, 7:44 AM · Restricted Project
riccibruno added reviewers for D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities: hokein, akyrtzi.
Jul 27 2020, 7:37 AM · Restricted Project
riccibruno retitled D81865: [clang] Use string tables for static diagnostic descriptions from use string tables for static diagnostic descriptions to [clang] Use string tables for static diagnostic descriptions.
Jul 27 2020, 7:27 AM · Restricted Project
riccibruno added a comment to D81865: [clang] Use string tables for static diagnostic descriptions.

Add some reviewers based on git diff --name-only | xargs -n 1 git blame --porcelain | grep "^author " | sort | uniq -c | sort -nr | head -30.

Jul 27 2020, 7:24 AM · Restricted Project
riccibruno added reviewers for D81865: [clang] Use string tables for static diagnostic descriptions: akyrtzi, bkramer, dblaikie, MaskRay.
Jul 27 2020, 7:24 AM · Restricted Project
riccibruno updated the summary of D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities.
Jul 27 2020, 7:14 AM · Restricted Project
riccibruno added a comment to D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics..

I looked through the code changes, and they all seem quite mechanical. I believe they are all correct.

After reading through the test changes, I believe that this change is strictly an improvement thanks to printing the template arguments. Therefore, I don't believe I know of any way that htis is controversial.

That said, because I'm approving so quickly after submission, please give at least a few hours before committing to give the other reviewers a chance to take a look.

Jul 27 2020, 7:08 AM · Restricted Project
riccibruno created D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities.
Jul 27 2020, 7:07 AM · Restricted Project
riccibruno created D84656: [clang] Pass the NamedDecl* instead of the DeclarationName into many diagnostics..
Jul 27 2020, 6:56 AM · Restricted Project
riccibruno added inline comments to D84461: [Concepts] Fix ast dump for immediately declared constraint..
Jul 27 2020, 2:55 AM · Restricted Project
riccibruno added a comment to D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter.

Will do. By the way, is there something more tailored than ninja check-clang to run these ast-dump tests? ninja check-clang takes quite a while to run...

Jul 27 2020, 2:52 AM · Restricted Project

Jul 26 2020

riccibruno updated the diff for D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName.

Update a comment I originally missed.

Jul 26 2020, 9:56 AM · Restricted Project
riccibruno created D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName.
Jul 26 2020, 9:49 AM · Restricted Project
riccibruno committed rGb0512eed1e9d: [clang][NFC] Add a test for __attribute__((flag_enum)) with an unnamed… (authored by riccibruno).
[clang][NFC] Add a test for __attribute__((flag_enum)) with an unnamed…
Jul 26 2020, 9:27 AM
riccibruno committed rGa2f83d5a07da: [clang][NFC] Add tests for the use of NamedDecl::getDeclName in the… (authored by riccibruno).
[clang][NFC] Add tests for the use of NamedDecl::getDeclName in the…
Jul 26 2020, 9:27 AM
riccibruno committed rGca9bfc20f48c: [clang][NFC] Remove spurious +x flag on SemaConcept.cpp (authored by riccibruno).
[clang][NFC] Remove spurious +x flag on SemaConcept.cpp
Jul 26 2020, 9:27 AM