Page MenuHomePhabricator

Mordante (Mark de Wever)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 9:08 AM (163 w, 2 d)

Recent Activity

Today

Mordante added a comment to D127953: [libc++] Mark standard-mandated includes as such.

I'm not precisely sure what you mean by 'which tool', but here's a reproduction using a cut-down reproduction of the standard test using clang trunk with libc++

https://godbolt.org/z/jYs7Pz8qj

Sun, Jun 26, 2:27 AM · Restricted Project, Restricted Project
Mordante requested review of D128603: [libc++][chrono] Adds operator<=> for day..
Sun, Jun 26, 2:02 AM · Restricted Project, Restricted Project

Yesterday

Mordante updated the diff for D128214: [libc++] Makes `unique_ptr operator*() noexcept..

Poke CI.

Sat, Jun 25, 11:56 AM · Restricted Project, Restricted Project
Mordante updated the diff for D127570: [libc++][format] Use forwarding references..

Rebased
Addresses review comments
Updates the release notes to the latest style

Sat, Jun 25, 11:11 AM · Restricted Project, Restricted Project
Mordante added reviewers for D128577: [libc++][chrono] Implements formatter day.: ldionne, vitaut.
Sat, Jun 25, 11:03 AM · Restricted Project, Restricted Project
Mordante added a comment to D127570: [libc++][format] Use forwarding references..

Thanks for the review!

Sat, Jun 25, 10:50 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128577: [libc++][chrono] Implements formatter day..

With the CI green, reenable all CI jobs.

Sat, Jun 25, 8:25 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128577: [libc++][chrono] Implements formatter day..

More CI fixes and disables more green CIs

Sat, Jun 25, 7:50 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128577: [libc++][chrono] Implements formatter day..

More CI fixes.

Sat, Jun 25, 7:20 AM · Restricted Project, Restricted Project
Mordante added a comment to D127226: [libc++] Simplify type_traits and use more builtins.

@ayzhao, @cjdb Thanks for the additional information.

Sat, Jun 25, 6:03 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128577: [libc++][chrono] Implements formatter day..

More CI fixes.

Sat, Jun 25, 5:54 AM · Restricted Project, Restricted Project
Mordante added a comment to D127953: [libc++] Mark standard-mandated includes as such.

I'm curious about how we handle proposals in the working group.

https://cplusplus.github.io/LWG/issue3378

Suggests that some of the same language applies to the tuple helpers when including array, etc. Some industry-standard conformance tests are checking for the behavior defined in issue 3378.

Sat, Jun 25, 5:45 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128577: [libc++][chrono] Implements formatter day..

Attempt to fix buildkite

Sat, Jun 25, 5:17 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128577: [libc++][chrono] Implements formatter day..

Fixes some CI issue.
Note temporary disable quite some CI runs, since I expect several non-Linux systems to still fail.

Sat, Jun 25, 5:05 AM · Restricted Project, Restricted Project
Mordante requested review of D128577: [libc++][chrono] Implements formatter day..
Sat, Jun 25, 2:39 AM · Restricted Project, Restricted Project

Thu, Jun 23

Mordante added a comment to D128416: [libc++] Implement the deque functions of P1206R7.

Thanks for working on this. I did a shallow review and hope to find time for a more in depth review at another time.

Thu, Jun 23, 10:36 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128139: [libc++][format] Improve integral formatters..

Fixes CI.

Thu, Jun 23, 10:24 AM · Restricted Project, Restricted Project
Mordante added a comment to D128139: [libc++][format] Improve integral formatters..

This patch seems to be moving around quite a bit of code. Would it be possible to do some of the reorganization before this patch as a NFC to ease reviewing this?

Thu, Jun 23, 9:43 AM · Restricted Project, Restricted Project
Mordante added a comment to D128400: [libc++][NFC] Replace enable_if with __enable_if_t in a few places.

In general I'm happy. But please avoid unrelated NFC code changes is these kind of commits. Especially since the title nor the description mentions them. (Thus some minor whitespace fixes are not an issue.)

Thu, Jun 23, 9:27 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128139: [libc++][format] Improve integral formatters..

Rebased and addresses review comments.

Thu, Jun 23, 9:20 AM · Restricted Project, Restricted Project
Mordante added a comment to D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.

SGTM, but for now I prefer to leave the approval to people more familiar with the details of this patch and AIX.

Thu, Jun 23, 9:12 AM · Restricted Project, Restricted Project, Restricted Project
Mordante committed rG9afaa158f52c: [libc++][format] Copy code to new location. (authored by Mordante).
[libc++][format] Copy code to new location.
Thu, Jun 23, 8:22 AM · Restricted Project, Restricted Project
Mordante closed D128367: [libc++][format] Copy code to new location..
Thu, Jun 23, 8:21 AM · Restricted Project, Restricted Project
Mordante added a comment to D128367: [libc++][format] Copy code to new location..

Thanks for the review!

Thu, Jun 23, 8:20 AM · Restricted Project, Restricted Project

Wed, Jun 22

Mordante added a comment to D128021: [libc++] Don't call key_eq in unordered_map/set rehashing routine.

Would this example be enough?
I could've messed up compile flags, and guidance would be appreciated if i did so

Wed, Jun 22, 10:58 PM · Restricted Project, Restricted Project
Mordante added a comment to D127226: [libc++] Simplify type_traits and use more builtins.

This seems like same as the problem that was fixed by https://reviews.llvm.org/rGe6a39f00e8d0cd3684df54fb03d288efe2969202 and re-introduced by this patch.

Wed, Jun 22, 10:47 PM · Restricted Project, Restricted Project
Mordante requested review of D128367: [libc++][format] Copy code to new location..
Wed, Jun 22, 11:46 AM · Restricted Project, Restricted Project
Mordante committed rG21ba9d0b62c1: [libc++][NFC] Merges unused functions in callers. (authored by Mordante).
[libc++][NFC] Merges unused functions in callers.
Wed, Jun 22, 10:46 AM · Restricted Project, Restricted Project
Mordante closed D127760: [libc++][NFC] Merges unused functions in callers..
Wed, Jun 22, 10:46 AM · Restricted Project, Restricted Project
Mordante accepted D128362: [libc++] Clarify std::function release note.

LGTM!

Wed, Jun 22, 10:44 AM · Restricted Project, Restricted Project
Mordante added inline comments to D127834: [libc++][ranges] Implement `ranges::stable_sort`..
Wed, Jun 22, 10:43 AM · Restricted Project, Restricted Project
Mordante accepted D128236: [libc++] Add a test to pin down the set of transitive public includes.

LGTM when the CI is happy.

Wed, Jun 22, 10:17 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128214: [libc++] Makes `unique_ptr operator*() noexcept..

Poke CI.

Wed, Jun 22, 9:50 AM · Restricted Project, Restricted Project
Mordante committed rGcf927669eba9: [libc++] Reduces std::to_chars instantiations. (authored by Mordante).
[libc++] Reduces std::to_chars instantiations.
Wed, Jun 22, 9:47 AM · Restricted Project, Restricted Project
Mordante closed D128215: [libc++] Reduces std::to_chars instantiations..
Wed, Jun 22, 9:47 AM · Restricted Project, Restricted Project
Mordante updated the diff for D127760: [libc++][NFC] Merges unused functions in callers..

Poke CI

Wed, Jun 22, 9:20 AM · Restricted Project, Restricted Project
Mordante added a comment to D124569: Re-enable libc++ gdb-pretty-printer tests for all versions of clang..

Thanks! I see different errors now. I'll see what I can do about it. At the moment our CI is rather unstable so I'll look at it when that's fixed.

Wed, Jun 22, 9:18 AM · Restricted Project, Restricted Project
Mordante updated the diff for D127760: [libc++][NFC] Merges unused functions in callers..

Rebased and addresses review comments.

Wed, Jun 22, 9:12 AM · Restricted Project, Restricted Project
Mordante committed rG88c279b1d93f: [libc++][CI] Use GCC 12 labels. (authored by Mordante).
[libc++][CI] Use GCC 12 labels.
Wed, Jun 22, 9:12 AM · Restricted Project, Restricted Project
Mordante added inline comments to D128215: [libc++] Reduces std::to_chars instantiations..
Wed, Jun 22, 8:58 AM · Restricted Project, Restricted Project
Mordante added a comment to D127760: [libc++][NFC] Merges unused functions in callers..

Thanks for the reviews!

Wed, Jun 22, 8:58 AM · Restricted Project, Restricted Project
Mordante added a comment to D128285: [libc++][AIX] Make basic_string layout compatible with earlier version.

Thanks for working on this!

Wed, Jun 22, 8:40 AM · Restricted Project, Restricted Project, Restricted Project
Mordante updated the diff for D128215: [libc++] Reduces std::to_chars instantiations..

Final polishing, when the CI passes I'll land this version.

Wed, Jun 22, 8:27 AM · Restricted Project, Restricted Project
Mordante committed rG65f44c9218e5: [libc++] Fixes GCC-12 build. (authored by Mordante).
[libc++] Fixes GCC-12 build.
Wed, Jun 22, 8:27 AM · Restricted Project, Restricted Project

Tue, Jun 21

Mordante added a comment to D128215: [libc++] Reduces std::to_chars instantiations..

Yes we still support 32-bit platforms, using a 64-bit value there would give a performance penalty, especially on platforms with a small number or registers.

Isn't size_t 32 bits wide on 32-bit platforms?

Another reason why I prefer 32-bits is that I'm quite sure that division of a 32-bit value by a constant is more efficient than the division of a 64-bit value. (The compiler will transform it in a multiplication and a shift which IIRC always fits in a 64-bit register, when using a 32-bit value.) This is what we're doing for base 10.

Could you do a benchmark to check if using a 32-bit wide instantiation yields better performance even on 64-bit platforms?

Tue, Jun 21, 11:24 PM · Restricted Project, Restricted Project
Mordante committed rG77ad77c0710f: [libc++][format] Improve string formatters (authored by Mordante).
[libc++][format] Improve string formatters
Tue, Jun 21, 10:41 PM · Restricted Project, Restricted Project
Mordante closed D125606: [libc++][format] Improve string formatters.
Tue, Jun 21, 10:40 PM · Restricted Project, Restricted Project
Mordante updated the diff for D128215: [libc++] Reduces std::to_chars instantiations..

Fixes C++03.

Tue, Jun 21, 11:43 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128214: [libc++] Makes `unique_ptr operator*() noexcept..

tab -> space.

Tue, Jun 21, 11:26 AM · Restricted Project, Restricted Project
Mordante planned changes to D128214: [libc++] Makes `unique_ptr operator*() noexcept..
Tue, Jun 21, 11:21 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128215: [libc++] Reduces std::to_chars instantiations..

tab -> space

Tue, Jun 21, 11:20 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128214: [libc++] Makes `unique_ptr operator*() noexcept..

An experiment to fix the CI issue.

Tue, Jun 21, 11:18 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128215: [libc++] Reduces std::to_chars instantiations..

Rebased and adresses review comments.

Tue, Jun 21, 10:53 AM · Restricted Project, Restricted Project
Mordante added inline comments to D128215: [libc++] Reduces std::to_chars instantiations..
Tue, Jun 21, 10:49 AM · Restricted Project, Restricted Project
Mordante added a comment to D124569: Re-enable libc++ gdb-pretty-printer tests for all versions of clang..

I can't manage to get the buildbot environment working to test this. It consistently fails with

clang: error: unable to execute command: posix_spawn failed: Operation not permitted

Not sure the best thing to do here. I think it should work fine, but am stumped on how to test it.

Tue, Jun 21, 10:17 AM · Restricted Project, Restricted Project
Mordante committed rGeb12ad9d7ff6: [libc++][CI] Updates GCC to version 12. (authored by Mordante).
[libc++][CI] Updates GCC to version 12.
Tue, Jun 21, 9:59 AM · Restricted Project, Restricted Project
Mordante closed D126667: [libc++][CI] Updates GCC to version 12..
Tue, Jun 21, 9:59 AM · Restricted Project, Restricted Project, Restricted Project
Mordante added a comment to D128236: [libc++] Add a test to pin down the set of transitive public includes.

Thanks for working on this! I think this is really useful to have. The makes it easier to remove includes from subheaders and see whether that as a user visible impact.
I'm a bit curious whether it will cause a lot of build failures. (I know it shouldn't.)

Tue, Jun 21, 9:57 AM · Restricted Project, Restricted Project
Mordante updated subscribers of D128087: [libc++][lit][AIX] Port tests for getting time to AIX.

Thanks very much, @Mordante and @philnik! There isn't an AIX maintainer IIUC but I will wait a couple of days to see if other reviewers have any comments. Thanks again!

Tue, Jun 21, 9:30 AM · Restricted Project, Restricted Project, Restricted Project
Mordante accepted D128220: [libc++][lit][AIX] Port tests for money format to AIX.

Thanks for working on this, LGTM! Please wait for one of the AIX maintainers to approve too.

Tue, Jun 21, 9:21 AM · Restricted Project, Restricted Project, Restricted Project
Mordante updated the diff for D125606: [libc++][format] Improve string formatters.

Addresses all review comments and rebased.
Make sure the CI passes since during the last iteration the CI was down.

Tue, Jun 21, 9:09 AM · Restricted Project, Restricted Project
Mordante added a comment to D125606: [libc++][format] Improve string formatters.

Thanks for the reviews!

Tue, Jun 21, 8:59 AM · Restricted Project, Restricted Project
Mordante updated the diff for D126667: [libc++][CI] Updates GCC to version 12..

Removed the parent commit and test again with -Wno-tautological-compare.

Tue, Jun 21, 8:49 AM · Restricted Project, Restricted Project, Restricted Project
Mordante committed rG3561ee586ed0: [libc++] Improve charconv base10 algorithm. (authored by Mordante).
[libc++] Improve charconv base10 algorithm.
Tue, Jun 21, 8:46 AM · Restricted Project, Restricted Project
Mordante closed D127764: [libc++] Improve charconv base10 algorithm..
Tue, Jun 21, 8:46 AM · Restricted Project, Restricted Project
Mordante updated the summary of D126667: [libc++][CI] Updates GCC to version 12..
Tue, Jun 21, 8:34 AM · Restricted Project, Restricted Project, Restricted Project
Mordante added a comment to D127764: [libc++] Improve charconv base10 algorithm..

Thanks for the review!

Tue, Jun 21, 8:31 AM · Restricted Project, Restricted Project
Mordante committed rG5517bc6c4a05: [libc++][format] Improves the handle test. (authored by Mordante).
[libc++][format] Improves the handle test.
Tue, Jun 21, 8:25 AM · Restricted Project, Restricted Project
Mordante closed D127767: [libc++][format] Improves the handle test..
Tue, Jun 21, 8:25 AM · Restricted Project, Restricted Project

Mon, Jun 20

Mordante accepted D128181: [libc++] Make _LIBCPP_DEBUG_RANDOMIZE_RANGE a function.

LGTM once the CI passes. I think it would be good for @ldionne to also have a look so I leave the final approval to him.

Mon, Jun 20, 10:46 AM · Restricted Project, Restricted Project
Mordante added a comment to D128215: [libc++] Reduces std::to_chars instantiations..

Is there a reason to not just instantiate it for that largest integral type? Or size_t and the largest integral type to avoid using multiple registers for smaller types?

Mon, Jun 20, 10:40 AM · Restricted Project, Restricted Project
Mordante planned changes to D128214: [libc++] Makes `unique_ptr operator*() noexcept..

Thanks for the review!

Mon, Jun 20, 10:20 AM · Restricted Project, Restricted Project
Mordante added a comment to D89057: Add the C++17 <memory_resource> header (mono-patch).

Is this still being worked on? It would be nice (from a user point of view) if this could be in one of the next releases of libc++.

Mon, Jun 20, 10:03 AM · Restricted Project, Restricted Project
Mordante added inline comments to D128215: [libc++] Reduces std::to_chars instantiations..
Mon, Jun 20, 9:39 AM · Restricted Project, Restricted Project
Mordante requested review of D128215: [libc++] Reduces std::to_chars instantiations..
Mon, Jun 20, 9:38 AM · Restricted Project, Restricted Project
Mordante added inline comments to D128146: [libc++] Use uninitialized algorithms for vector.
Mon, Jun 20, 9:19 AM · Restricted Project, Restricted Project
Mordante requested review of D128214: [libc++] Makes `unique_ptr operator*() noexcept..
Mon, Jun 20, 9:08 AM · Restricted Project, Restricted Project
Mordante added inline comments to D127978: [libc++][test] Replaces TEST_IS_CONSTANT_EVALUATED..
Mon, Jun 20, 9:04 AM · Restricted Project, Restricted Project
Mordante updated the diff for D128139: [libc++][format] Improve integral formatters..

Try restarting CI.

Mon, Jun 20, 8:09 AM · Restricted Project, Restricted Project

Sun, Jun 19

Mordante requested review of D128139: [libc++][format] Improve integral formatters..
Sun, Jun 19, 6:03 AM · Restricted Project, Restricted Project

Sat, Jun 18

Mordante added a comment to D128021: [libc++] Don't call key_eq in unordered_map/set rehashing routine.

One request, when you address a review comment, can you check the "done" button this makes reviewing easier.

Sat, Jun 18, 3:47 AM · Restricted Project, Restricted Project
Mordante added a comment to D128084: [libc++] Add CI job testing on FreeBSD.

I have some WIP patches for the locale tests that I should update . I'm not sure how long it will take to fix all the tests so maybe xfail is better so that regressions are caught?

Sat, Jun 18, 3:12 AM · Restricted Project, Restricted Project
Mordante accepted D128087: [libc++][lit][AIX] Port tests for getting time to AIX.

LGTM, but please wait for approval of an AIX maintainer.

Sat, Jun 18, 3:08 AM · Restricted Project, Restricted Project, Restricted Project
Mordante updated the diff for D125606: [libc++][format] Improve string formatters.

Address review comments.

Sat, Jun 18, 3:02 AM · Restricted Project, Restricted Project

Fri, Jun 17

Mordante accepted D127674: [libc++] Add Implemented Papers section.

LGTM, but please give other reviewers a bit more time to have a look.

Fri, Jun 17, 12:55 PM · Restricted Project, Restricted Project
Mordante added a comment to D126667: [libc++][CI] Updates GCC to version 12..

Thanks for the review!

Fri, Jun 17, 12:49 PM · Restricted Project, Restricted Project, Restricted Project
Mordante added a comment to D128084: [libc++] Add CI job testing on FreeBSD.

@infrandomness thanks a lot for providing this CI runner!

Fri, Jun 17, 12:43 PM · Restricted Project, Restricted Project
Mordante added a comment to D128087: [libc++][lit][AIX] Port tests for getting time to AIX.

Thanks for working on this!

Fri, Jun 17, 12:31 PM · Restricted Project, Restricted Project, Restricted Project
Mordante added inline comments to D127978: [libc++][test] Replaces TEST_IS_CONSTANT_EVALUATED..
Fri, Jun 17, 12:23 PM · Restricted Project, Restricted Project
Mordante published D126667: [libc++][CI] Updates GCC to version 12. for review.
Fri, Jun 17, 12:00 PM · Restricted Project, Restricted Project, Restricted Project
Mordante published D127978: [libc++][test] Replaces TEST_IS_CONSTANT_EVALUATED. for review.

I've rebased the GCC-12 CI changes (D126667) on top of this one and the GCC CI is happy (https://buildkite.com/llvm-project/libcxx-ci/builds/11560).
So that means the only tautological comparison issues where the constant evaluated messages.

Fri, Jun 17, 11:57 AM · Restricted Project, Restricted Project
Mordante added a comment to D128021: [libc++] Don't call key_eq in unordered_map/set rehashing routine.

Thanks for your contribution! I'll have another look after all comment have been addressed.

Fri, Jun 17, 10:15 AM · Restricted Project, Restricted Project
Mordante added a comment to D128053: [libc++] Pass -fno-modules to clang-tidy instead of disabling it for the modules build.

No real objection, but I think having an XFAIL will give us feedback when modules start working with modules.

Fri, Jun 17, 10:02 AM · Restricted Project, Restricted Project
Mordante accepted D127418: [libc++] Use bounded iterators in std::span when the debug mode is enabled.

LGTM after the CI passes. I leave the final approval to @philnik since he also had some comments.

Fri, Jun 17, 9:56 AM · Restricted Project, Restricted Project
Mordante accepted D127953: [libc++] Mark standard-mandated includes as such.

I can't speak to the testing issues--perhaps it would be good to add them in a subsequent change. But getting correct code working again would be really good, and what is here addresses that.

Fri, Jun 17, 9:30 AM · Restricted Project, Restricted Project
Mordante accepted D127987: [libc++] Don't force -O2 when building the benchmarks.

LGTM, thanks!

Fri, Jun 17, 9:18 AM · Restricted Project, Restricted Project
Mordante added inline comments to D125606: [libc++][format] Improve string formatters.
Fri, Jun 17, 9:16 AM · Restricted Project, Restricted Project

Thu, Jun 16

Mordante added a comment to D125606: [libc++][format] Improve string formatters.

@ldionne I've the suggested changes, but before putting it up for review again I want to see whether these changes impact other work-in-progress code. (Not merge conflicts, but incompatibilities.)

Thu, Jun 16, 11:58 AM · Restricted Project, Restricted Project
Mordante committed rG3433f78c407b: [libc++][doc] Update formatting status. (authored by Mordante).
[libc++][doc] Update formatting status.
Thu, Jun 16, 10:38 AM · Restricted Project, Restricted Project
Mordante accepted D127557: [libc++][ranges] Implement `ranges::sort`..

LGTM when the CI passes.

Thu, Jun 16, 9:44 AM · Restricted Project, Restricted Project