Page MenuHomePhabricator

Mordante (Mark de Wever)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 9:08 AM (89 w, 2 d)

Recent Activity

Today

Mordante updated the diff for D95248: [libc++][doc] Update the release notes.

Fixes a grammar error found by @tschuett.

Sun, Jan 24, 5:27 AM · Restricted Project
Mordante added inline comments to D95248: [libc++][doc] Update the release notes.
Sun, Jan 24, 5:26 AM · Restricted Project
Mordante updated the diff for D95248: [libc++][doc] Update the release notes.

Addresses review comments.
Updates C++2b status on the index page.

Sun, Jan 24, 4:17 AM · Restricted Project
Mordante added inline comments to D95248: [libc++][doc] Update the release notes.
Sun, Jan 24, 4:13 AM · Restricted Project

Yesterday

Mordante committed rG99d5fad7a5ca: [libc++] Remove invalid C++20 code from a test. (authored by Mordante).
[libc++] Remove invalid C++20 code from a test.
Sat, Jan 23, 11:14 AM
Mordante updated the diff for D91986: [libc++] Implements concept constructible_from.

The in C++11 deprecated throw() has been removed in C++20. Remove the test using this feature.

Sat, Jan 23, 11:01 AM · Restricted Project
Mordante added inline comments to D93461: [libc++] Implements concept default_initializable..
Sat, Jan 23, 10:55 AM · Restricted Project
Mordante added a comment to D91986: [libc++] Implements concept constructible_from.

Thanks for the review.

Sat, Jan 23, 10:53 AM · Restricted Project
Mordante updated the diff for D91986: [libc++] Implements concept constructible_from.
  • Rebased.
  • Ran clang-format.
  • Added more unit tests at @cjdb's suggestion.
Sat, Jan 23, 10:21 AM · Restricted Project
Mordante committed rGa8e06361ddba: [libc++] Implements concept destructible (authored by Mordante).
[libc++] Implements concept destructible
Sat, Jan 23, 9:17 AM
Mordante closed D91004: [libc++] Implements concept destructible.
Sat, Jan 23, 9:17 AM · Restricted Project
Mordante updated the diff for D91004: [libc++] Implements concept destructible.
  • Addresses review comments.
    • Add some fundamental types to the unit test
    • Ran clang-format on the patch
  • Rebased to test against a recent main before landing the patch
Sat, Jan 23, 5:18 AM · Restricted Project
Mordante added a comment to D91004: [libc++] Implements concept destructible.

Thanks for the review. I'll address your comments and run a CI build before landing this revision.

Sat, Jan 23, 5:15 AM · Restricted Project
Mordante updated the diff for D90999: [libc++] Implements ranges::enable_borrowed_range.

Rebase to trigger CI. The last build failed, but so did main.

Sat, Jan 23, 4:13 AM · Restricted Project
Mordante updated the diff for D92214: [libc++] Implement format_error..

Rebase to trigger CI. The last build failed, but so did main.

Sat, Jan 23, 4:12 AM · Restricted Project

Fri, Jan 22

Mordante added a comment to D95248: [libc++][doc] Update the release notes.

Do what ever you want, but a lot sounds a bit cheap. Or give some concrete examples?

Fri, Jan 22, 11:43 AM · Restricted Project
Mordante added inline comments to D95248: [libc++][doc] Update the release notes.
Fri, Jan 22, 11:33 AM · Restricted Project
Mordante committed rG3317b38ef86e: [NFC][libc++] Update the implementation status. (authored by Mordante).
[NFC][libc++] Update the implementation status.
Fri, Jan 22, 11:27 AM
Mordante added a comment to D93912: [libc++][P1679] add string contains.

The paper is fully implemented.

With the caveat that std::string::contains is not constexpr yet.
std::string_view::contains is constexpr

Fri, Jan 22, 10:58 AM · Restricted Project
Mordante requested review of D95248: [libc++][doc] Update the release notes.
Fri, Jan 22, 10:28 AM · Restricted Project
Mordante updated the diff for D90999: [libc++] Implements ranges::enable_borrowed_range.
  • Removed unimplemented part of the synopsis
  • Ran clang-format on the patch
  • Rebased to trigger CI again
Fri, Jan 22, 9:14 AM · Restricted Project
Mordante added a comment to D93912: [libc++][P1679] add string contains.

@WimLeflere I just noticed that during review we didn't mention the https://libcxx.llvm.org/docs/Cxx2bStatus.html should be updated. Does this commit fully implement the paper?

Fri, Jan 22, 8:55 AM · Restricted Project
Mordante updated the diff for D92214: [libc++] Implement format_error..
  • Addresses review comments:
    • Removed unimplemented part of the synopsis
    • Removed cpp version check in format.cpp
  • Replace c++ version number 2a with 20 where appropriate. This reflects changes done in main by unrelated commits.
  • Rebased to trigger CI again.
Fri, Jan 22, 8:48 AM · Restricted Project
Mordante added inline comments to D92214: [libc++] Implement format_error..
Fri, Jan 22, 8:44 AM · Restricted Project
Mordante planned changes to D93166: [libc++][format] Add basic_format_parse_context..
Fri, Jan 22, 8:35 AM · Restricted Project
Mordante planned changes to D93593: [libc++][format] Add __format_arg_store..
Fri, Jan 22, 8:35 AM · Restricted Project

Mon, Jan 11

Mordante added inline comments to D94409: [libc++] [C++2b] [P1048] Add is_scoped_enum and is_scoped_enum_v..
Mon, Jan 11, 11:37 AM · Restricted Project
Mordante added inline comments to D94409: [libc++] [C++2b] [P1048] Add is_scoped_enum and is_scoped_enum_v..
Mon, Jan 11, 10:46 AM · Restricted Project

Tue, Jan 5

Mordante added a comment to D93912: [libc++][P1679] add string contains.

The macro should be added to libcxx/utils/generate_feature_test_macro_components.py, then run the script to generate the proper macros and tests.

Thanks!
Should I check in the (changed) generated files?

Tue, Jan 5, 10:31 AM · Restricted Project
Mordante added a comment to D93912: [libc++][P1679] add string contains.

Where are the feature test macros defined?
__cpp_lib_string_contains should be added

Tue, Jan 5, 8:47 AM · Restricted Project

Dec 22 2020

Mordante accepted D93582: [libc++] [libc++abi] Correctly quote source and target names in tests. NFC..

Thanks, LGTM.

Dec 22 2020, 11:50 AM · Restricted Project, Restricted Project

Dec 20 2020

Mordante added a comment to D93582: [libc++] [libc++abi] Correctly quote source and target names in tests. NFC..

One minor question, otherwise LGTM.

Dec 20 2020, 4:59 AM · Restricted Project, Restricted Project
Mordante added a comment to D93593: [libc++][format] Add __format_arg_store..

It seems the CI build fails since it can't process the dependencies properly. I'll rebase and trigger an CI build once the dependencies have landed.

Dec 20 2020, 4:44 AM · Restricted Project
Mordante requested review of D93593: [libc++][format] Add __format_arg_store..
Dec 20 2020, 4:36 AM · Restricted Project
Mordante updated the diff for D93166: [libc++][format] Add basic_format_parse_context..

Replace a std:: with _VSTD::

Dec 20 2020, 4:17 AM · Restricted Project

Dec 19 2020

Mordante committed rG5740f96d8eed: [NFC][libc++] Fixes swapped comments. (authored by Mordante).
[NFC][libc++] Fixes swapped comments.
Dec 19 2020, 7:17 AM

Dec 17 2020

Mordante requested review of D93461: [libc++] Implements concept default_initializable..
Dec 17 2020, 8:16 AM · Restricted Project
Mordante updated the diff for D93414: [libc++] Adds a make_string test helper function..

Improve the formatting as requested by @mclow.lists.
Disabled the automatic formatting to make sure the formatting won't be updated
automatically.

Dec 17 2020, 8:04 AM · Restricted Project
Mordante added a comment to D93414: [libc++] Adds a make_string test helper function..

Thanks for the review!

Dec 17 2020, 7:52 AM · Restricted Project

Dec 16 2020

Mordante updated the diff for D93414: [libc++] Adds a make_string test helper function..

Disable unit test when localization is disabled.

Dec 16 2020, 11:56 AM · Restricted Project
Mordante requested review of D93414: [libc++] Adds a make_string test helper function..
Dec 16 2020, 11:12 AM · Restricted Project

Dec 15 2020

Mordante added inline comments to D67086: Implement syncstream (p0053).
Dec 15 2020, 10:14 AM · Restricted Project
Mordante added a comment to D93283: [libcxx] Remove ifdefs in the message to static_assert. NFC..

LGTM, once it passes CI.

Dec 15 2020, 9:34 AM · Restricted Project
Mordante added inline comments to D93166: [libc++][format] Add basic_format_parse_context..
Dec 15 2020, 9:22 AM · Restricted Project
Mordante added inline comments to D92229: [libc++] Update clang-format configuration.
Dec 15 2020, 8:58 AM · Restricted Project

Dec 14 2020

Mordante added a comment to D92229: [libc++] Update clang-format configuration.

Do we need to discuss the wanted formatting in this patch or on Slack/dev-ml?

Dec 14 2020, 8:56 AM · Restricted Project
Mordante updated the diff for D93166: [libc++][format] Add basic_format_parse_context..

Addresses review comments.

Dec 14 2020, 7:32 AM · Restricted Project
Mordante added a comment to D93166: [libc++][format] Add basic_format_parse_context..

Thanks for the review!

Dec 14 2020, 7:09 AM · Restricted Project

Dec 12 2020

Mordante updated the diff for D93166: [libc++][format] Add basic_format_parse_context..

Fixes a GCC shadow warning.

Dec 12 2020, 12:06 PM · Restricted Project
Mordante requested review of D93166: [libc++][format] Add basic_format_parse_context..
Dec 12 2020, 11:04 AM · Restricted Project
Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Rebased.

Dec 12 2020, 5:18 AM · Restricted Project
Mordante updated the diff for D90999: [libc++] Implements ranges::enable_borrowed_range.

Rebased.

Dec 12 2020, 5:11 AM · Restricted Project
Mordante updated the diff for D92214: [libc++] Implement format_error..

Rebased.

Dec 12 2020, 5:03 AM · Restricted Project

Dec 10 2020

Mordante added a comment to D92214: [libc++] Implement format_error..

@ldionne Can you have a look?

Dec 10 2020, 7:49 AM · Restricted Project

Dec 7 2020

Mordante added inline comments to D92730: [libc++] [LWG3221] Add tests for wrapping operator+(year_month, months)..
Dec 7 2020, 9:45 AM · Restricted Project

Dec 6 2020

Mordante added a comment to D92730: [libc++] [LWG3221] Add tests for wrapping operator+(year_month, months)..

A few minor nits, but otherwise LGTM.

Dec 6 2020, 11:58 AM · Restricted Project
Mordante added inline comments to D92725: [libc++] [LWG2993] reference_wrapper<T> conversion from U&&.
Dec 6 2020, 9:36 AM · Restricted Project
Mordante added inline comments to D92725: [libc++] [LWG2993] reference_wrapper<T> conversion from U&&.
Dec 6 2020, 7:58 AM · Restricted Project

Dec 5 2020

Mordante committed rGce6269f9ba6c: [NFC][libc++] Update C++20 issues status. (authored by Mordante).
[NFC][libc++] Update C++20 issues status.
Dec 5 2020, 7:38 AM
Mordante committed rGf687b4ac84a3: [NFC][clang-tidy] Fixes comment typos. (authored by Mordante).
[NFC][clang-tidy] Fixes comment typos.
Dec 5 2020, 7:32 AM

Dec 3 2020

Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Implement all new header tests as suggested by @curdeius in D92214.

Dec 3 2020, 9:39 AM · Restricted Project
Mordante updated the diff for D90999: [libc++] Implements ranges::enable_borrowed_range.

Implement all new header tests as suggested by @curdeius in D92214.

Dec 3 2020, 9:37 AM · Restricted Project
Mordante updated the diff for D92214: [libc++] Implement format_error..

Implement all new header tests as suggested by @curdeius.

Dec 3 2020, 9:34 AM · Restricted Project
Mordante added inline comments to D92214: [libc++] Implement format_error..
Dec 3 2020, 9:31 AM · Restricted Project

Dec 2 2020

Mordante updated the diff for D92214: [libc++] Implement format_error..

Updated the Apple ABI list and synopsis.

Dec 2 2020, 10:55 AM · Restricted Project
Mordante added a comment to D92214: [libc++] Implement format_error..

Thanks for the review.

Dec 2 2020, 10:48 AM · Restricted Project
Mordante added a comment to D92306: [libc++] [docs] Add C++2b (to be C++23) status page..

Thanks for the patch.
One minor nit, other than that LGTM.

Dec 2 2020, 9:39 AM · Restricted Project
Mordante planned changes to D92214: [libc++] Implement format_error..
Dec 2 2020, 9:12 AM · Restricted Project
Mordante updated the diff for D92214: [libc++] Implement format_error..

Rebase to trigger CI to generate the Apple ABI list.

Dec 2 2020, 9:11 AM · Restricted Project

Nov 28 2020

Mordante committed rGae5f792002d8: [libc++] Disable some tests using gcc 9. (authored by Mordante).
[libc++] Disable some tests using gcc 9.
Nov 28 2020, 11:10 AM
Mordante committed rG67c88e47bdba: [libc++] P1645 constexpr for <numeric> (authored by Mordante).
[libc++] P1645 constexpr for <numeric>
Nov 28 2020, 8:04 AM
Mordante closed D90569: [libc++] P1645 constexpr for <numeric>.
Nov 28 2020, 8:04 AM · Restricted Project
Mordante updated the diff for D90569: [libc++] P1645 constexpr for <numeric>.

Disable the unit tests on clang-8, they fail and we don't support these old compilers for libc++.
Switch to the new status page
Adjusted the unit tests modified in D61170 to work in constexpr evaluation. Since constexpr string isn't supported yet the std::string tests are disabled in constant evaluation context.

Nov 28 2020, 6:48 AM · Restricted Project
Mordante updated the diff for D92214: [libc++] Implement format_error..

Disable the Apple unit tests as suggested by @curdeius.
Formatted the manually written code with the .clang-format settings as proposed in D92229.

Nov 28 2020, 5:04 AM · Restricted Project
Mordante added a comment to D92229: [libc++] Update clang-format configuration.

Thanks @curdeius for looking into this! The lack of proper clang-format rules for libc++ also bothered me a bit. Ut didn't bother me enough to look into it yet.

Nov 28 2020, 4:57 AM · Restricted Project
Mordante added a comment to D92214: [libc++] Implement format_error..

To fix Apple back-deployment build, you'll need to mark your test with sth like:

Nov 28 2020, 4:40 AM · Restricted Project

Nov 27 2020

Mordante updated the diff for D92214: [libc++] Implement format_error..

Properly guard the code in format.cpp to only be used in C++20 mode.
Update the x86_64 ABI list.
Note the Apple ABI list is still out of date.

Nov 27 2020, 3:35 AM · Restricted Project
Mordante planned changes to D92214: [libc++] Implement format_error..

Thanks for the review!

Nov 27 2020, 3:11 AM · Restricted Project
Mordante requested review of D92214: [libc++] Implement format_error..
Nov 27 2020, 1:10 AM · Restricted Project

Nov 26 2020

Mordante committed rG83d26603e040: [NFC][libc++] Mark LWG3296 as complete. (authored by Mordante).
[NFC][libc++] Mark LWG3296 as complete.
Nov 26 2020, 1:41 AM

Nov 25 2020

Mordante added a comment to D91004: [libc++] Implements concept destructible.

@ldionne the patch passes the CI build and I addressed all previous review comments. When you have time can you have a look?

Nov 25 2020, 5:30 AM · Restricted Project
Mordante reopened D90569: [libc++] P1645 constexpr for <numeric>.

Reopened since I reverted to commit. It fails on several build bots using LLVM 8.

Nov 25 2020, 4:48 AM · Restricted Project
Mordante added a reverting change for rGeb9b063539c3: [libc++] P1645 constexpr for <numeric>: rGecabb39ca11c: Revert "[libc++] P1645 constexpr for <numeric>".
Nov 25 2020, 4:46 AM
Mordante committed rGecabb39ca11c: Revert "[libc++] P1645 constexpr for <numeric>" (authored by Mordante).
Revert "[libc++] P1645 constexpr for <numeric>"
Nov 25 2020, 4:46 AM
Mordante added a reverting change for D90569: [libc++] P1645 constexpr for <numeric>: rGecabb39ca11c: Revert "[libc++] P1645 constexpr for <numeric>".
Nov 25 2020, 4:46 AM · Restricted Project
Mordante committed rGeb9b063539c3: [libc++] P1645 constexpr for <numeric> (authored by Mordante).
[libc++] P1645 constexpr for <numeric>
Nov 25 2020, 4:19 AM
Mordante closed D90569: [libc++] P1645 constexpr for <numeric>.
Nov 25 2020, 4:19 AM · Restricted Project
Mordante updated the diff for D90999: [libc++] Implements ranges::enable_borrowed_range.

Move the enable_borrowed_range to a helper header to avoid including <ranges> in <span> and <string_view> as suggested by @miscco.

Nov 25 2020, 2:48 AM · Restricted Project
Mordante updated the diff for D90569: [libc++] P1645 constexpr for <numeric>.

Rebase to trigger CI.

Nov 25 2020, 2:31 AM · Restricted Project

Nov 24 2020

Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Rebase to trigger CI build.

Nov 24 2020, 9:25 AM · Restricted Project
Mordante added a comment to D91986: [libc++] Implements concept constructible_from.

@CaseyCarter had this to say back in D74291.

There's tons of coverage here for class types and reference types. What about void, function types, pointers, arrays, pointers-to-members? (I don't know about clang/libc++, but the MSVC STL tests for type traits tend to _be_ the tests for compiler intrinsics used to implement those traits, so we consequently cover everything under the sun.)

I'd suggest we apply this here as well.

Nov 24 2020, 9:19 AM · Restricted Project
Mordante updated the diff for D91004: [libc++] Implements concept destructible.

Rebase to trigger CI.

Nov 24 2020, 8:53 AM · Restricted Project
Mordante updated the diff for D90569: [libc++] P1645 constexpr for <numeric>.

Rebase to trigger CI.

Nov 24 2020, 8:45 AM · Restricted Project
Mordante committed rG1a036e9cc82a: [libcxx] Implement P1956 rename low-level bit functions (authored by Mordante).
[libcxx] Implement P1956 rename low-level bit functions
Nov 24 2020, 8:37 AM
Mordante closed D90551: [libcxx] Implement P1956 rename low-level bit functions.
Nov 24 2020, 8:37 AM · Restricted Project
Mordante added a comment to D90569: [libc++] P1645 constexpr for <numeric>.

Thanks for the review.
I've switched to arc, so that should solve the CI issues.

Nov 24 2020, 8:35 AM · Restricted Project
Mordante updated the diff for D90551: [libcxx] Implement P1956 rename low-level bit functions.

Rebase to trigger the bildkite.

Nov 24 2020, 6:00 AM · Restricted Project

Nov 23 2020

Mordante requested review of D91986: [libc++] Implements concept constructible_from.
Nov 23 2020, 11:37 AM · Restricted Project
Mordante updated the diff for D90569: [libc++] P1645 constexpr for <numeric>.

This should complete the implementation of P1645
Additional changes

  • Since constexpr vector isn't available some test have a workaround to be tested without this feature. The changes are marked with a fixme to be removed once the support is available.
  • Enables additional unit tests in libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan_op.pass.cpp. These were disabled when added, but that seems an oversight.
  • Changes the changed numeric functions to all use _LIBCPP_INLINE_VISIBILITY and removed the unneeded inline.
Nov 23 2020, 9:51 AM · Restricted Project

Nov 18 2020

Mordante added a comment to D90569: [libc++] P1645 constexpr for <numeric>.

Is there a reason why their signatures differ or is it an oversight?
Shall I fix them in this patch?

I believe those are oversights, and the blame seems to confirm this. Good catch, and please fix them in this patch. You don't need inline though, just _LIBCPP_INLINE_VISIBILITY. These functions are already inline (i.e. linkonce-ODR) because they are templates.

Nov 18 2020, 10:25 AM · Restricted Project