User Details
- User Since
- May 10 2019, 9:08 AM (89 w, 2 d)
Today
Fixes a grammar error found by @tschuett.
Addresses review comments.
Updates C++2b status on the index page.
Yesterday
The in C++11 deprecated throw() has been removed in C++20. Remove the test using this feature.
Thanks for the review.
- Rebased.
- Ran clang-format.
- Added more unit tests at @cjdb's suggestion.
- Addresses review comments.
- Add some fundamental types to the unit test
- Ran clang-format on the patch
- Rebased to test against a recent main before landing the patch
Thanks for the review. I'll address your comments and run a CI build before landing this revision.
Rebase to trigger CI. The last build failed, but so did main.
Rebase to trigger CI. The last build failed, but so did main.
Fri, Jan 22
- Removed unimplemented part of the synopsis
- Ran clang-format on the patch
- Rebased to trigger CI again
@WimLeflere I just noticed that during review we didn't mention the https://libcxx.llvm.org/docs/Cxx2bStatus.html should be updated. Does this commit fully implement the paper?
- Addresses review comments:
- Removed unimplemented part of the synopsis
- Removed cpp version check in format.cpp
- Replace c++ version number 2a with 20 where appropriate. This reflects changes done in main by unrelated commits.
- Rebased to trigger CI again.
Mon, Jan 11
Tue, Jan 5
Dec 22 2020
Thanks, LGTM.
Dec 20 2020
One minor question, otherwise LGTM.
It seems the CI build fails since it can't process the dependencies properly. I'll rebase and trigger an CI build once the dependencies have landed.
Replace a std:: with _VSTD::
Dec 19 2020
Dec 17 2020
Improve the formatting as requested by @mclow.lists.
Disabled the automatic formatting to make sure the formatting won't be updated
automatically.
Thanks for the review!
Dec 16 2020
Disable unit test when localization is disabled.
Dec 15 2020
LGTM, once it passes CI.
Dec 14 2020
Do we need to discuss the wanted formatting in this patch or on Slack/dev-ml?
Addresses review comments.
Thanks for the review!
Dec 12 2020
Fixes a GCC shadow warning.
Rebased.
Rebased.
Rebased.
Dec 10 2020
@ldionne Can you have a look?
Dec 7 2020
Dec 6 2020
A few minor nits, but otherwise LGTM.
Dec 5 2020
Dec 3 2020
Implement all new header tests as suggested by @curdeius.
Dec 2 2020
Updated the Apple ABI list and synopsis.
Thanks for the review.
Thanks for the patch.
One minor nit, other than that LGTM.
Rebase to trigger CI to generate the Apple ABI list.
Nov 28 2020
Disable the unit tests on clang-8, they fail and we don't support these old compilers for libc++.
Switch to the new status page
Adjusted the unit tests modified in D61170 to work in constexpr evaluation. Since constexpr string isn't supported yet the std::string tests are disabled in constant evaluation context.
Disable the Apple unit tests as suggested by @curdeius.
Formatted the manually written code with the .clang-format settings as proposed in D92229.
Thanks @curdeius for looking into this! The lack of proper clang-format rules for libc++ also bothered me a bit. Ut didn't bother me enough to look into it yet.
Nov 27 2020
Properly guard the code in format.cpp to only be used in C++20 mode.
Update the x86_64 ABI list.
Note the Apple ABI list is still out of date.
Thanks for the review!
Nov 26 2020
Nov 25 2020
@ldionne the patch passes the CI build and I addressed all previous review comments. When you have time can you have a look?
Reopened since I reverted to commit. It fails on several build bots using LLVM 8.
Move the enable_borrowed_range to a helper header to avoid including <ranges> in <span> and <string_view> as suggested by @miscco.
Rebase to trigger CI.
Nov 24 2020
Rebase to trigger CI build.
Rebase to trigger CI.
Rebase to trigger CI.
Thanks for the review.
I've switched to arc, so that should solve the CI issues.
Rebase to trigger the bildkite.
Nov 23 2020
This should complete the implementation of P1645
Additional changes
- Since constexpr vector isn't available some test have a workaround to be tested without this feature. The changes are marked with a fixme to be removed once the support is available.
- Enables additional unit tests in libcxx/test/std/numerics/numeric.ops/inclusive.scan/inclusive_scan_op.pass.cpp. These were disabled when added, but that seems an oversight.
- Changes the changed numeric functions to all use _LIBCPP_INLINE_VISIBILITY and removed the unneeded inline.