- User Since
- May 10 2019, 9:08 AM (37 w, 6 h)
Tue, Jan 21
Would it make sense to also allow wmain with wchar_t? https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?view=vs-2019
Sun, Jan 19
I proposed D73007 as fix.
Sat, Jan 18
Thanks for your report. I think it's similar to https://bugs.llvm.org/show_bug.cgi?id=44556. I'll look for a fix.
Thanks for the review!
Sun, Jan 12
Sat, Jan 11
Thanks for the review!
I only have some naming nits
- incriment -> increment
- decriment -> decrement
Friendly ping, it would be nice to get this in the next release.
Adding Depends on D72284 would add the patches to the stack.
I like the patch!
Tue, Jan 7
While looking at the test failures I noticed the tests pointer_to_integral_type_conv in clang/test/Sema/MicrosoftExtensions.c were not tested. Will look into it later.
You're welcome. It would be nice if we can get this one in the release.
Mon, Jan 6
Thanks for the feedback!
Sun, Jan 5
Made some improvements based on feedback of @craig.topper:
- Adds a not
- Implements an example of the maximum string length when using -Wpedantic
Nice to see this patch! I intended to look at a similar patch, but that's no longer required.
Rebased on master. This adds one new fix and removes the ones done by others.
Sat, Jan 4
@eugene Please don't use auto when type is spelled in same statement or iterator. do you mean type is not spelled ?
I like this change, but I don't feel qualified to fully review the patch.
I proposed the same change in D72210, but I'll adjust that patch once accepted.
Added support for some additional features:
- Allow limits from the C standard, either sharing the C++ constants or separately.
- Allow to document the design choices for the limit.
- Allow to track the status of the limit. (This may become obsolete ones all limits are implemented, but that can take a while.)
Thu, Jan 2
Wed, Jan 1
Thanks for the review! I'll commit all the -Wrange-loop-analysis patches later today.
Reviewed the types and added a * for pointers and added a const when applicable.
Sun, Dec 29
Fixes the compilation issues with the clang unit tests.
Sat, Dec 28
The merge bot noticed I forgot to update clang's unittests. Will look at that.
Thanks for writing this document! I noticed the document contains a lot of long sentences. These may be harder to understand for non-native speakers. I pointed a few out, but for some I don't have better suggestions.
I like the goal of this patch and the simplifications it does. I don't feel qualified to do a full review.
Dec 24 2019
Dec 22 2019
@aaron.ballman thanks for the reviews. I'll drop the top-level const in this and the related patches.