Page MenuHomePhabricator

Mordante (Mark de Wever)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 9:08 AM (37 w, 6 h)

Recent Activity

Tue, Jan 21

Mordante added a comment to D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions.

Would it make sense to also allow wmain with wchar_t? https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?view=vs-2019

Tue, Jan 21, 12:23 PM · Restricted Project, Restricted Project
Mordante committed rG41fcd17250fa: [Sema] Avoid Wrange-loop-analysis false positives (authored by Mordante).
[Sema] Avoid Wrange-loop-analysis false positives
Tue, Jan 21, 12:14 PM
Mordante closed D73007: [Sema] Avoid Wrange-loop-analysis false positives.
Tue, Jan 21, 12:14 PM · Restricted Project
Mordante added inline comments to D73007: [Sema] Avoid Wrange-loop-analysis false positives.
Tue, Jan 21, 11:55 AM · Restricted Project
Mordante added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

LGTM! Do you think this should also be pushed onto the release branch?

Tue, Jan 21, 11:46 AM · Restricted Project
Mordante added a comment to D73007: [Sema] Avoid Wrange-loop-analysis false positives.

Yes, but minimal fix is better for release branch, so @hans should merge it.

Handling your case probably needs more work and patches..

Tue, Jan 21, 11:46 AM · Restricted Project

Sun, Jan 19

Mordante added a comment to D68912: Adds -Wrange-loop-analysis to -Wall.

I proposed D73007 as fix.

Sun, Jan 19, 10:12 AM · Restricted Project
Mordante created D73007: [Sema] Avoid Wrange-loop-analysis false positives.
Sun, Jan 19, 10:03 AM · Restricted Project

Sat, Jan 18

Mordante added a comment to D68912: Adds -Wrange-loop-analysis to -Wall.

Thanks for your report. I think it's similar to https://bugs.llvm.org/show_bug.cgi?id=44556. I'll look for a fix.

Sat, Jan 18, 12:06 PM · Restricted Project
Mordante added a comment to D71966: [Wdocumentation][RFC] Improve identifier's of \param.

Thanks for the review!

Sat, Jan 18, 11:56 AM · Restricted Project

Sun, Jan 12

Mordante closed D72560: Add -Wrange-loop-analysis changes to ReleaseNotes.

Committed as https://reviews.llvm.org/rGdc422e968e73790178e500f506e8fb7cfa1e62ea

Sun, Jan 12, 11:06 AM · Restricted Project

Sat, Jan 11

Mordante committed rGdc422e968e73: Add -Wrange-loop-analysis changes to ReleaseNotes (authored by Mordante).
Add -Wrange-loop-analysis changes to ReleaseNotes
Sat, Jan 11, 11:03 AM
Mordante added a comment to D72560: Add -Wrange-loop-analysis changes to ReleaseNotes.

Thanks for the review!

Sat, Jan 11, 11:03 AM · Restricted Project
Mordante created D72560: Add -Wrange-loop-analysis changes to ReleaseNotes.
Sat, Jan 11, 10:10 AM · Restricted Project
Mordante added inline comments to D72052: [UserManual] Update the C++ standard support.
Sat, Jan 11, 8:46 AM · Restricted Project
Mordante added a comment to D72553: [clang-tidy] Add performance-prefer-preincrement check.
  • 99% sure I have all incriments renamed now
Sat, Jan 11, 8:46 AM · Restricted Project, Restricted Project
Mordante added a comment to D72553: [clang-tidy] Add performance-prefer-preincrement check.

I only have some naming nits

  • incriment -> increment
  • decriment -> decrement
Sat, Jan 11, 7:24 AM · Restricted Project, Restricted Project
Mordante added a comment to D72052: [UserManual] Update the C++ standard support.

Friendly ping, it would be nice to get this in the next release.

Sat, Jan 11, 7:06 AM · Restricted Project
Mordante added a comment to D72378: [clang-tidy] Add `bugprone-reserved-identifier`.

Adding Depends on D72284 would add the patches to the stack.
I like the patch!

Sat, Jan 11, 6:58 AM · Restricted Project, Restricted Project
Mordante committed rG9c74fb402e1b: [Sema] Improve -Wrange-loop-analysis warnings. (authored by Mordante).
[Sema] Improve -Wrange-loop-analysis warnings.
Sat, Jan 11, 6:38 AM
Mordante closed D72212: [Sema] Improve -Wrange-loop-analysis warnings.
Sat, Jan 11, 6:38 AM · Restricted Project
Mordante added inline comments to D72212: [Sema] Improve -Wrange-loop-analysis warnings.
Sat, Jan 11, 6:38 AM · Restricted Project

Tue, Jan 7

Mordante planned changes to D72231: [Sema] Adds the pointer-to-int-cast diagnostic.

While looking at the test failures I noticed the tests pointer_to_integral_type_conv in clang/test/Sema/MicrosoftExtensions.c were not tested. Will look into it later.

Tue, Jan 7, 1:08 PM · Restricted Project
Mordante added a comment to D72212: [Sema] Improve -Wrange-loop-analysis warnings.

You're welcome. It would be nice if we can get this one in the release.

Tue, Jan 7, 11:31 AM · Restricted Project

Mon, Jan 6

Mordante committed rG5e0e0e3ff05f: [NFC] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[NFC] Fixes -Wrange-loop-analysis warnings
Mon, Jan 6, 3:52 PM
Mordante added a comment to D72053: [RFC] Handling implementation limits.

Thanks for the feedback!

Mon, Jan 6, 2:44 PM · Restricted Project
Mordante added inline comments to D72053: [RFC] Handling implementation limits.
Mon, Jan 6, 8:48 AM · Restricted Project
Mordante committed rGeec0240f9718: Adds -Wrange-loop-analysis to -Wall (authored by Mordante).
Adds -Wrange-loop-analysis to -Wall
Mon, Jan 6, 8:39 AM
Mordante committed rG1d549cff48cd: [NFC] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[NFC] Fixes -Wrange-loop-analysis warnings
Mon, Jan 6, 8:38 AM
Mordante closed D72210: [NFC] Fixes -Wrange-loop-analysis warnings.
Mon, Jan 6, 8:38 AM · Restricted Project, lld

Sun, Jan 5

Mordante added a comment to D72231: [Sema] Adds the pointer-to-int-cast diagnostic.

The diagnostic is not enabled by default

But GCC enables it for C even without "-Wall or -Wextra". Clang should follow it..

Sun, Jan 5, 12:16 PM · Restricted Project
Mordante created D72231: [Sema] Adds the pointer-to-int-cast diagnostic.
Sun, Jan 5, 11:43 AM · Restricted Project
Mordante updated the diff for D72053: [RFC] Handling implementation limits.

Made some improvements based on feedback of @craig.topper:

  • Adds a not
  • Implements an example of the maximum string length when using -Wpedantic
Sun, Jan 5, 7:35 AM · Restricted Project
Mordante added a comment to D72217: [clang-tidy] Added readability-qualified-auto check.

Nice to see this patch! I intended to look at a similar patch, but that's no longer required.

Sun, Jan 5, 6:03 AM · Restricted Project, Restricted Project
Mordante updated the diff for D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

Rebased on master. This adds one new fix and removes the ones done by others.

Sun, Jan 5, 5:43 AM · Restricted Project, lld
Mordante added inline comments to D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names.
Sun, Jan 5, 5:25 AM · Restricted Project, Restricted Project
Mordante added inline comments to D72212: [Sema] Improve -Wrange-loop-analysis warnings.
Sun, Jan 5, 5:15 AM · Restricted Project

Sat, Jan 4

Mordante updated subscribers of D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names.

@eugene Please don't use auto when type is spelled in same statement or iterator. do you mean type is not spelled ?

Sat, Jan 4, 2:05 PM · Restricted Project, Restricted Project
Mordante added inline comments to D72053: [RFC] Handling implementation limits.
Sat, Jan 4, 1:55 PM · Restricted Project
Mordante added inline comments to D72212: [Sema] Improve -Wrange-loop-analysis warnings.
Sat, Jan 4, 1:46 PM · Restricted Project
Mordante added a comment to D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names.

I like this change, but I don't feel qualified to fully review the patch.

Sat, Jan 4, 1:38 PM · Restricted Project, Restricted Project
Mordante added a comment to D72210: [NFC] Fixes -Wrange-loop-analysis warnings.

You can drop changes to lld. I've fixed lld -Wrange-loop-analysis a few days ago in 681b1be774964a804beabfb7c5e3bdab8f979e4a . (Archive::Child c was also deleted).

For mlir, only mlir/lib/Dialect/Linalg/Utils/Utils.cpp:117:8 needs a fix. I've fixed others in eeef50b1fee91dbe993187324003d2665ceae331.

Sat, Jan 4, 12:52 PM · Restricted Project, lld
Mordante created D72212: [Sema] Improve -Wrange-loop-analysis warnings.
Sat, Jan 4, 12:51 PM · Restricted Project
Mordante accepted D72211: [ELF] Drop const qualifier to fix -Wrange-loop-analysis. NFC.

LGTM
I proposed the same change in D72210, but I'll adjust that patch once accepted.

Sat, Jan 4, 12:15 PM · Restricted Project
Mordante created D72210: [NFC] Fixes -Wrange-loop-analysis warnings.
Sat, Jan 4, 11:29 AM · Restricted Project, lld
Mordante added a comment to D71857: [NFC] Fixes -Wrange-loop-analysis warnings.

I think there is a false positive.

https://github.com/llvm/llvm-project/tree/master/lld/ELF/Relocations.cpp#L1622

for (const std::pair<ThunkSection *, uint32_t> ts : isd->thunkSections)
Sat, Jan 4, 11:20 AM · Restricted Project, Restricted Project, Restricted Project
Mordante updated the diff for D72053: [RFC] Handling implementation limits.

Added support for some additional features:

  • Allow limits from the C standard, either sharing the C++ constants or separately.
  • Allow to document the design choices for the limit.
  • Allow to track the status of the limit. (This may become obsolete ones all limits are implemented, but that can take a while.)
Sat, Jan 4, 10:42 AM · Restricted Project

Thu, Jan 2

Mordante created D72103: [Sema] Avoid using an invalid InsertPos.
Thu, Jan 2, 12:59 PM · Restricted Project
Mordante added a comment to D71857: [NFC] Fixes -Wrange-loop-analysis warnings.

However, I am afraid I don't like some of the fixes here. You can replace const auto with const auto & and call that a fix... IMHO if the type is not obvious, const ConcreteType & will be better.

Thu, Jan 2, 11:24 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jan 1

Mordante added a reverting change for rGd8117542ac57: Adds -Wrange-loop-analysis to -Wall: rG8ca79dac5592: Revert "Adds -Wrange-loop-analysis to -Wall".
Wed, Jan 1, 1:26 PM
Mordante committed rG8ca79dac5592: Revert "Adds -Wrange-loop-analysis to -Wall" (authored by Mordante).
Revert "Adds -Wrange-loop-analysis to -Wall"
Wed, Jan 1, 1:26 PM
Mordante committed rGd8117542ac57: Adds -Wrange-loop-analysis to -Wall (authored by Mordante).
Adds -Wrange-loop-analysis to -Wall
Wed, Jan 1, 11:08 AM
Mordante closed D68912: Adds -Wrange-loop-analysis to -Wall.
Wed, Jan 1, 11:08 AM · Restricted Project
Mordante committed rGe5ab1e49f958: Improve Wrange-loop-analyses for rvalue reference (authored by Mordante).
Improve Wrange-loop-analyses for rvalue reference
Wed, Jan 1, 11:08 AM
Mordante closed D71806: Improve Wrange-loop-analyses for rvalue reference.
Wed, Jan 1, 11:08 AM · Restricted Project
Mordante committed rGf022a5a792fd: Adds fixit hints to the -Wrange-loop-analysis (authored by Mordante).
Adds fixit hints to the -Wrange-loop-analysis
Wed, Jan 1, 11:08 AM
Mordante closed D68913: Adds fixit hints to the Wrange-loop-analysis.
Wed, Jan 1, 11:08 AM · Restricted Project
Mordante committed rG8dc7b982b455: [NFC] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[NFC] Fixes -Wrange-loop-analysis warnings
Wed, Jan 1, 11:07 AM
Mordante closed D71857: [NFC] Fixes -Wrange-loop-analysis warnings.
Wed, Jan 1, 11:07 AM · Restricted Project, Restricted Project, Restricted Project
Mordante created D72053: [RFC] Handling implementation limits.
Wed, Jan 1, 7:53 AM · Restricted Project
Mordante added a comment to D71857: [NFC] Fixes -Wrange-loop-analysis warnings.

Thanks for the review! I'll commit all the -Wrange-loop-analysis patches later today.

Wed, Jan 1, 7:39 AM · Restricted Project, Restricted Project, Restricted Project
Mordante added inline comments to D71857: [NFC] Fixes -Wrange-loop-analysis warnings.
Wed, Jan 1, 7:26 AM · Restricted Project, Restricted Project, Restricted Project
Mordante updated the diff for D71857: [NFC] Fixes -Wrange-loop-analysis warnings.

Reviewed the types and added a * for pointers and added a const when applicable.

Wed, Jan 1, 7:22 AM · Restricted Project, Restricted Project, Restricted Project
Mordante created D72052: [UserManual] Update the C++ standard support.
Wed, Jan 1, 7:17 AM · Restricted Project

Sun, Dec 29

Mordante updated the diff for D71966: [Wdocumentation][RFC] Improve identifier's of \param.

Fixes the compilation issues with the clang unit tests.

Sun, Dec 29, 11:01 AM · Restricted Project

Sat, Dec 28

Mordante added a comment to D71966: [Wdocumentation][RFC] Improve identifier's of \param.

The merge bot noticed I forgot to update clang's unittests. Will look at that.

Sat, Dec 28, 12:02 PM · Restricted Project
Mordante created D71966: [Wdocumentation][RFC] Improve identifier's of \param.
Sat, Dec 28, 11:16 AM · Restricted Project
Mordante added a comment to D71916: High-Level Code-Review Documentation Update.

Thanks for writing this document! I noticed the document contains a lot of long sentences. These may be harder to understand for non-native speakers. I pointed a few out, but for some I don't have better suggestions.

Sat, Dec 28, 7:56 AM · Restricted Project
Mordante added a comment to D71920: [AST] Refactor propagation of dependency bits. NFC.

I like the goal of this patch and the simplifications it does. I don't feel qualified to do a full review.

Sat, Dec 28, 7:14 AM · Restricted Project

Dec 24 2019

Mordante created D71857: [NFC] Fixes -Wrange-loop-analysis warnings.
Dec 24 2019, 11:06 AM · Restricted Project, Restricted Project, Restricted Project

Dec 22 2019

Mordante committed rG2d903cc9656d: [AMDGPU] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[AMDGPU] Fixes -Wrange-loop-analysis warnings
Dec 22 2019, 10:40 AM
Mordante closed D71815: [AMDGPU] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 10:40 AM · Restricted Project
Mordante committed rG9c11026c1b01: [Hexagon] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[Hexagon] Fixes -Wrange-loop-analysis warnings
Dec 22 2019, 10:36 AM
Mordante closed D71814: [Hexagon] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 10:36 AM · Restricted Project
Mordante committed rG31262d6722c7: [NVPTX] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[NVPTX] Fixes -Wrange-loop-analysis warnings
Dec 22 2019, 10:31 AM
Mordante closed D71812: [NVPTX] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 10:31 AM · Restricted Project
Mordante committed rG1b344e7967a7: [PowerPC] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[PowerPC] Fixes -Wrange-loop-analysis warnings
Dec 22 2019, 10:24 AM
Mordante closed D71811: [PowerPC] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 10:24 AM · Restricted Project
Mordante committed rG098d3347e74a: [Transforms] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[Transforms] Fixes -Wrange-loop-analysis warnings
Dec 22 2019, 10:21 AM
Mordante closed D71810: [Transforms] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 10:21 AM · Restricted Project
Mordante committed rGb6d9e976629a: [Analyzer] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[Analyzer] Fixes -Wrange-loop-analysis warnings
Dec 22 2019, 10:15 AM
Mordante closed D71809: [Analyzer] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 10:15 AM · Restricted Project
Mordante committed rG536c9a604e82: [Tools] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[Tools] Fixes -Wrange-loop-analysis warnings
Dec 22 2019, 10:12 AM
Mordante closed D71808: [Tools] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 10:12 AM · Restricted Project
Mordante committed rGe8d448ec255c: [TableGen] Fixes -Wrange-loop-analysis warnings (authored by Mordante).
[TableGen] Fixes -Wrange-loop-analysis warnings
Dec 22 2019, 10:06 AM
Mordante closed D71807: [TableGen] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 10:06 AM · Restricted Project
Mordante added a comment to D71807: [TableGen] Fixes -Wrange-loop-analysis warnings.

@aaron.ballman thanks for the reviews. I'll drop the top-level const in this and the related patches.

Dec 22 2019, 9:56 AM · Restricted Project
Mordante created D71815: [AMDGPU] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 8:39 AM · Restricted Project
Mordante created D71814: [Hexagon] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 8:30 AM · Restricted Project
Mordante created D71812: [NVPTX] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 8:25 AM · Restricted Project
Mordante created D71811: [PowerPC] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 8:16 AM · Restricted Project
Mordante created D71810: [Transforms] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 8:02 AM · Restricted Project
Mordante created D71809: [Analyzer] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 7:44 AM · Restricted Project
Herald added a reviewer for D71808: [Tools] Fixes -Wrange-loop-analysis warnings: alexshap.
Dec 22 2019, 7:30 AM · Restricted Project
Mordante created D71807: [TableGen] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 7:14 AM · Restricted Project
Mordante created D71806: Improve Wrange-loop-analyses for rvalue reference.
Dec 22 2019, 7:05 AM · Restricted Project
Mordante added a child revision for D68913: Adds fixit hints to the Wrange-loop-analysis: D71806: Improve Wrange-loop-analyses for rvalue reference.
Dec 22 2019, 7:05 AM · Restricted Project
Mordante added a comment to D68912: Adds -Wrange-loop-analysis to -Wall.

All is fixed now?

Dec 22 2019, 6:49 AM · Restricted Project

Dec 21 2019

Mordante committed rGbe1a9b3863b6: [Wdocumentation] Implement \anchor (authored by Mordante).
[Wdocumentation] Implement \anchor
Dec 21 2019, 5:54 AM
Mordante committed rG70d592d68c7a: [Analyzer] Use a reference in a range-based for (authored by Mordante).
[Analyzer] Use a reference in a range-based for
Dec 21 2019, 5:54 AM