Page MenuHomePhabricator

Mordante (Mark de Wever)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 9:08 AM (23 w, 2 h)

Recent Activity

Sat, Oct 12

Mordante updated the diff for D64874: [Sema] Improve handling of function pointer conversions.

Removed the language version test.

Sat, Oct 12, 10:18 AM · Restricted Project
Mordante created D68912: Adds -Wrange-loop-analysis to -Wall.
Sat, Oct 12, 8:56 AM · Restricted Project
Mordante created D68913: Adds fixit hints to the Wrange-loop-analysis.
Sat, Oct 12, 8:56 AM · Restricted Project
Mordante updated the diff for D62778: [1/2] Add a benchmark for map operations..

Adds additional tests to makes sure the order doesn't result in always removing the first element as observed by @mclow.lists .

Sat, Oct 12, 8:37 AM · Restricted Project

Sat, Oct 5

Mordante added a comment to D65695: Implements CWG 1601 in [over.ics.rank/4.2].

Thanks for the review. Can you commit the patch since I don't have commit access?

Sat, Oct 5, 9:35 AM · Restricted Project, Restricted Project
Mordante added a comment to D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used.

Thanks for the review. Can you commit the patch since I don't have commit access?

Sat, Oct 5, 9:35 AM · Restricted Project, Restricted Project
Herald updated subscribers of D50119: P1144 "Trivially relocatable" (0/3): Compiler support for `__is_trivially_relocatable(T)`.
Sat, Oct 5, 9:33 AM · Restricted Project

Wed, Sep 18

Mordante updated the diff for D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..

Adds a helper function __test_back_ref to avoid code duplication.

Wed, Sep 18, 11:49 AM · Restricted Project
Mordante added a comment to D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..

I think there is a minor misunderstanding. I don't mind to avoid duplicating code. But __parse_BACKREF can't be used in both places. So the question was which of the proposed APIs you prefer. I'll post patch with my preferred solution. I'll wait with updating D62453 until this patch is approved.

Wed, Sep 18, 11:40 AM · Restricted Project

Sep 6 2019

Mordante added a comment to D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.

Thanks for the review.
Could you commit this patch? I don't have commit access.

Sep 6 2019, 12:10 PM · Restricted Project

Sep 5 2019

Mordante updated the diff for D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.

Removes the unnecessary std::move as suggested by @aaron.ballman.

Sep 5 2019, 12:36 PM · Restricted Project
Mordante added inline comments to D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.
Sep 5 2019, 12:36 PM · Restricted Project

Sep 3 2019

Mordante added inline comments to D67052: Add reference type transformation builtins.
Sep 3 2019, 12:41 PM · Restricted Project, Restricted Project

Sep 2 2019

Mordante added a comment to D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer.

Thanks for the review.

using D = void();
D &d = ...; ///< \return none

Is no issue, I added tests for it.

Sep 2 2019, 9:26 AM · Restricted Project, Restricted Project
Mordante updated the diff for D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer.

Adds extra unit tests for references.

Sep 2 2019, 9:26 AM · Restricted Project, Restricted Project

Sep 1 2019

Mordante updated the diff for D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer.

As discussed on IRC no longer allow \return on a typedef'ed type. This is consistent with \param.

  • Reverts all prior changes in lib/AST/Comment.cpp
  • Adds extra tests in Sema::isFunctionOrBlockPointerVarLikeDecl
  • Updates unit tests
Sep 1 2019, 8:24 AM · Restricted Project, Restricted Project
Mordante added reviewers for D62453: Regex backreference [3/3] Validate backreferences in the constructor.: ldionne, EricWF.
Sep 1 2019, 5:12 AM · Restricted Project
Mordante added reviewers for D62451: Regex backreference [1/3] Fixes backreferences for extended grammar.: ldionne, EricWF.
Sep 1 2019, 5:12 AM · Restricted Project
Mordante added reviewers for D62779: [2/2] Fix complexity of map insert_or_assign with a hint.: ldionne, EricWF.
Sep 1 2019, 5:11 AM · Restricted Project
Mordante added reviewers for D62778: [1/2] Add a benchmark for map operations.: ldionne, EricWF.
Sep 1 2019, 5:10 AM · Restricted Project
Mordante updated the diff for D65694: Properly instantiate a decltype in argument's default initializer.

Changed the approach to use addInstantiatedParametersToScope as suggested by @rsmith. Since the function was static in another file I made it a member of LocalInstantiationScope and adjusted all callers.

Sep 1 2019, 5:01 AM · Restricted Project

Aug 31 2019

Mordante updated the diff for D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.

Update bug number references:

Aug 31 2019, 7:04 AM · Restricted Project
Mordante updated the diff for D65695: Implements CWG 1601 in [over.ics.rank/4.2].

Addresses the review remarks:

Aug 31 2019, 6:09 AM · Restricted Project, Restricted Project
Mordante updated the diff for D64874: [Sema] Improve handling of function pointer conversions.

Addresses the review remarks:

Aug 31 2019, 5:22 AM · Restricted Project
Mordante updated the diff for D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used.

Addresses the review remarks:

Aug 31 2019, 4:36 AM · Restricted Project, Restricted Project

Aug 30 2019

Mordante added inline comments to D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer.
Aug 30 2019, 10:17 AM · Restricted Project, Restricted Project

Aug 25 2019

Mordante added a reviewer for D66722: [clang] Ensure that comment classes are trivially destructible: gribozavr.

Please also add a test for the DeclInfo struct. It isn't a CommentNode but also allocated with the BumpPtrAllocator.
I also like @gribozavr's input.

Aug 25 2019, 12:44 PM · Restricted Project
Mordante added inline comments to D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer.
Aug 25 2019, 11:08 AM · Restricted Project, Restricted Project

Aug 24 2019

Mordante added a comment to D66700: [Wdocumentation] improve wording of a warning message.

Thanks.

Aug 24 2019, 12:02 PM · Restricted Project, Restricted Project
Mordante added a comment to D66700: [Wdocumentation] improve wording of a warning message.

You're welcome @davezarzycki. Can one of you commit the patch?

Aug 24 2019, 10:22 AM · Restricted Project, Restricted Project
Mordante created D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer.
Aug 24 2019, 10:18 AM · Restricted Project, Restricted Project
Mordante added a comment to D64696: Adds a warning when an inline Doxygen comment has no argument.

I created D66700 with an improved warning message.

Aug 24 2019, 3:21 AM · Restricted Project, Restricted Project
Mordante created D66700: [Wdocumentation] improve wording of a warning message.
Aug 24 2019, 3:18 AM · Restricted Project, Restricted Project
Mordante added inline comments to D66067: Push lambda scope earlier when transforming lambda expression.
Aug 24 2019, 2:46 AM · Restricted Project, Restricted Project
Mordante added inline comments to D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..
Aug 24 2019, 2:44 AM · Restricted Project

Aug 17 2019

Mordante updated the diff for D62453: Regex backreference [3/3] Validate backreferences in the constructor..

Fixes the issues found by @zoecarver.
Only the unit tests don't fail for me. Will try to catch @zoecarver on IRC.

Aug 17 2019, 12:55 PM · Restricted Project
Mordante updated the diff for D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..

Fixes the issue found by @zoecarver .

Aug 17 2019, 12:52 PM · Restricted Project
Mordante added inline comments to D66067: Push lambda scope earlier when transforming lambda expression.
Aug 17 2019, 11:35 AM · Restricted Project, Restricted Project
Mordante added inline comments to D62453: Regex backreference [3/3] Validate backreferences in the constructor..
Aug 17 2019, 11:08 AM · Restricted Project
Mordante added inline comments to D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..
Aug 17 2019, 11:00 AM · Restricted Project
Mordante added a comment to D62453: Regex backreference [3/3] Validate backreferences in the constructor..

Ping

Aug 17 2019, 6:06 AM · Restricted Project
Mordante added a comment to D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..

Ping

Aug 17 2019, 6:06 AM · Restricted Project
Mordante added a comment to D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used.

Ping

Aug 17 2019, 6:01 AM · Restricted Project, Restricted Project
Mordante added a comment to D64874: [Sema] Improve handling of function pointer conversions.

Ping

Aug 17 2019, 6:00 AM · Restricted Project
Mordante updated the diff for D65695: Implements CWG 1601 in [over.ics.rank/4.2].

Implemented the changes requested by @rsmith.

Aug 17 2019, 3:23 AM · Restricted Project, Restricted Project
Mordante added inline comments to D65695: Implements CWG 1601 in [over.ics.rank/4.2].
Aug 17 2019, 3:21 AM · Restricted Project, Restricted Project

Aug 15 2019

Mordante updated the diff for D65695: Implements CWG 1601 in [over.ics.rank/4.2].

Add the proper markers in the unit test to update cxx_dr_status.html. As discussed on IRC; the up to date cwg_index.html is not public, so I only updated the unit test and removed the changes to cxx_dr_status.html.

Aug 15 2019, 12:49 PM · Restricted Project, Restricted Project
Mordante updated the diff for D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments.

Updated the unit tests as requested. This required the Sema::ActOnParamDefaultArgument to delay a part of the ODR validation until the default argument has been 'instantiated'.
As discussed on IRC; the up to date cwg_index.html is not public, so I only updated the unit test and removed the changes to cxx_dr_status.html.

Aug 15 2019, 11:33 AM · Restricted Project
Mordante updated the diff for D64811: Warn when NumParams overflows.

Moved the testing from Parse to Sema.
Added additional safeguards for template instantiation.
Added more unit tests.
The comments may be a bit noisy, but they explain why the templates need to be tested at two locations.

Aug 15 2019, 10:18 AM · Restricted Project

Aug 6 2019

Mordante added a comment to D64696: Adds a warning when an inline Doxygen comment has no argument.

Unfortunately I'm not able to quickly find the Doxygen output of Swift online. When I process:
A limited variant of \c @objc that's used for classes with generic ancestry.
with Doxygen I get:
A limited variant of that's used for classes with generic ancestry.
Since the @ is used for commands I think they should be escaped like:
include/swift/AST/Decl.h: /// such as \c \@testable and \c \@usableFromInline into account.

Aug 6 2019, 10:50 AM · Restricted Project, Restricted Project

Aug 5 2019

Mordante added a comment to D64696: Adds a warning when an inline Doxygen comment has no argument.

I think it should warn; according to the documentation [1] \c expects a word. Testing with Doxygen indeed gives a warning.

Aug 5 2019, 9:45 AM · Restricted Project, Restricted Project

Aug 4 2019

Mordante added inline comments to D65695: Implements CWG 1601 in [over.ics.rank/4.2].
Aug 4 2019, 10:08 AM · Restricted Project, Restricted Project
Mordante added inline comments to D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments.
Aug 4 2019, 10:05 AM · Restricted Project

Aug 3 2019

Mordante created D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments.
Aug 3 2019, 3:46 AM · Restricted Project
Mordante created D65695: Implements CWG 1601 in [over.ics.rank/4.2].
Aug 3 2019, 2:58 AM · Restricted Project, Restricted Project
Mordante created D65694: Properly instantiate a decltype in argument's default initializer.
Aug 3 2019, 2:10 AM · Restricted Project

Jul 31 2019

Mordante added inline comments to D64811: Warn when NumParams overflows.
Jul 31 2019, 12:42 PM · Restricted Project

Jul 29 2019

Mordante added a comment to D64696: Adds a warning when an inline Doxygen comment has no argument.

Thanks for the review.

Jul 29 2019, 9:35 AM · Restricted Project, Restricted Project

Jul 23 2019

Mordante updated the diff for D64696: Adds a warning when an inline Doxygen comment has no argument.

Addresses @gribozavr comments.

Jul 23 2019, 11:32 AM · Restricted Project, Restricted Project
Mordante added a comment to D64696: Adds a warning when an inline Doxygen comment has no argument.

All inline commands defined in include/clang/AST/CommentCommands.td require an argument. The escape commands, like \&, are handled in the switch starting at lib/AST/CommentLexer.cpp:366. They are stored as Text and not as an InlineCommand.

Jul 23 2019, 11:32 AM · Restricted Project, Restricted Project

Jul 17 2019

Mordante created D64874: [Sema] Improve handling of function pointer conversions.
Jul 17 2019, 11:16 AM · Restricted Project

Jul 16 2019

Mordante created D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used.
Jul 16 2019, 2:24 PM · Restricted Project, Restricted Project
Mordante updated the diff for D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.

Remove the includes from the test.
Changed the std::is_constructible to is_same since the latter is easier to mock.

Jul 16 2019, 12:00 PM · Restricted Project
Mordante created D64811: Warn when NumParams overflows.
Jul 16 2019, 11:01 AM · Restricted Project
Mordante updated the diff for D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.

Fixes @lebedev.ri's remark and adds the requested test.
While working on the test I discovered the initial assumption in bug 35682 was incorrect. Updated the title and summary accordingly.

Jul 16 2019, 10:12 AM · Restricted Project

Jul 13 2019

Mordante added a comment to D63975: Warn when ScopeDepthOrObjCQuals overflows.

Thanks for the review. I don't have SVN access, can you commit these changes?

Jul 13 2019, 11:58 AM · Restricted Project
Mordante updated the diff for D63975: Warn when ScopeDepthOrObjCQuals overflows.

Addresses @rjmccall's remarks.
Fixes the tests for the nested lambda's.
As suspected the blocks also have the same nesting limit, thus added a test for them.

Jul 13 2019, 10:45 AM · Restricted Project
Mordante created D64696: Adds a warning when an inline Doxygen comment has no argument.
Jul 13 2019, 9:04 AM · Restricted Project, Restricted Project

Jul 12 2019

Mordante added a comment to D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.

Thanks for feedback. I'll whether I can find a way to generate a nice test case.

Jul 12 2019, 10:03 AM · Restricted Project
Mordante created D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.
Jul 12 2019, 9:44 AM · Restricted Project
Mordante updated the diff for D63975: Warn when ScopeDepthOrObjCQuals overflows.

Moved the test out of the loop as suggested by rjmccall.

Jul 12 2019, 9:25 AM · Restricted Project
Mordante added inline comments to D63975: Warn when ScopeDepthOrObjCQuals overflows.
Jul 12 2019, 9:23 AM · Restricted Project

Jul 11 2019

Mordante updated the diff for D63975: Warn when ScopeDepthOrObjCQuals overflows.

tab -> space
adds an extra unit test for lambdas
fixes an off by one error found while testing the lambdas

Jul 11 2019, 2:48 PM · Restricted Project
Mordante added inline comments to D63975: Warn when ScopeDepthOrObjCQuals overflows.
Jul 11 2019, 2:48 PM · Restricted Project

Jul 9 2019

Mordante added a comment to D62779: [2/2] Fix complexity of map insert_or_assign with a hint..

It seems there already is a unit test "test/std/containers/associative/map/map.modifiers/insert_or_assign.pass.cpp". I'll add extra tests to this file.

Jul 9 2019, 11:20 AM · Restricted Project
Mordante updated the diff for D62453: Regex backreference [3/3] Validate backreferences in the constructor..

Added more unit tests.
Moved the range validation from D62451 in this patch.

Jul 9 2019, 10:57 AM · Restricted Project
Mordante updated the diff for D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..

Removes the throw and move that to D62453.

Jul 9 2019, 10:46 AM · Restricted Project

Jun 29 2019

Mordante updated the diff for D62778: [1/2] Add a benchmark for map operations..

I added 3 extra iterator positions for all hint cases:

  • end() as you suggested.
  • begin() this is most of the time the wrong iterator.
  • the third element this is most of the time the wrong iterator. Just to avoid the code will use special optimizations on begin() and end().
Jun 29 2019, 11:40 AM · Restricted Project
Mordante created D63975: Warn when ScopeDepthOrObjCQuals overflows.
Jun 29 2019, 11:09 AM · Restricted Project

Jun 27 2019

Mordante added inline comments to D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..
Jun 27 2019, 12:11 PM · Restricted Project
Mordante added a comment to D63059: Implements multiline regex support.

Thanks for the review.

Jun 27 2019, 11:50 AM · Restricted Project
Mordante added a comment to D62452: Regex backreference [2/3] Validate the entire regex is consumed..

Thanks for the review!

Jun 27 2019, 11:50 AM · Restricted Project
Mordante updated the diff for D62452: Regex backreference [2/3] Validate the entire regex is consumed..

Removed the ABI question in the comment

Jun 27 2019, 11:42 AM · Restricted Project

Jun 9 2019

Mordante created D63059: Implements multiline regex support.
Jun 9 2019, 7:30 AM · Restricted Project

Jun 1 2019

Mordante created D62779: [2/2] Fix complexity of map insert_or_assign with a hint..
Jun 1 2019, 9:30 AM · Restricted Project
Mordante created D62778: [1/2] Add a benchmark for map operations..
Jun 1 2019, 9:30 AM · Restricted Project

May 27 2019

Mordante added a comment to D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..

I added a unit test in part 3 of the series [1]. Would you prefer to have the test for this fix in this patch?

May 27 2019, 2:10 PM · Restricted Project

May 25 2019

Mordante created D62453: Regex backreference [3/3] Validate backreferences in the constructor..
May 25 2019, 12:02 PM · Restricted Project
Mordante created D62452: Regex backreference [2/3] Validate the entire regex is consumed..
May 25 2019, 11:55 AM · Restricted Project
Mordante created D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..
May 25 2019, 11:55 AM · Restricted Project
Mordante added a comment to D61828: Throw the proper exception on a regex range error.

Thanks for the review.
Yes, please commit it for me since I don't have commit access.

May 25 2019, 7:25 AM · Restricted Project

May 11 2019

Mordante created D61828: Throw the proper exception on a regex range error.
May 11 2019, 12:45 PM · Restricted Project