User Details
- User Since
- May 10 2019, 9:08 AM (163 w, 2 d)
Today
Yesterday
Poke CI.
Rebased
Addresses review comments
Updates the release notes to the latest style
Thanks for the review!
With the CI green, reenable all CI jobs.
More CI fixes and disables more green CIs
More CI fixes.
More CI fixes.
Attempt to fix buildkite
Fixes some CI issue.
Note temporary disable quite some CI runs, since I expect several non-Linux systems to still fail.
Thu, Jun 23
Thanks for working on this. I did a shallow review and hope to find time for a more in depth review at another time.
Fixes CI.
In general I'm happy. But please avoid unrelated NFC code changes is these kind of commits. Especially since the title nor the description mentions them. (Thus some minor whitespace fixes are not an issue.)
Rebased and addresses review comments.
SGTM, but for now I prefer to leave the approval to people more familiar with the details of this patch and AIX.
Thanks for the review!
Wed, Jun 22
LGTM!
LGTM when the CI is happy.
Poke CI.
Poke CI
Thanks! I see different errors now. I'll see what I can do about it. At the moment our CI is rather unstable so I'll look at it when that's fixed.
Rebased and addresses review comments.
Thanks for the reviews!
Thanks for working on this!
Final polishing, when the CI passes I'll land this version.
Tue, Jun 21
Fixes C++03.
tab -> space.
tab -> space
An experiment to fix the CI issue.
Rebased and adresses review comments.
Thanks for working on this! I think this is really useful to have. The makes it easier to remove includes from subheaders and see whether that as a user visible impact.
I'm a bit curious whether it will cause a lot of build failures. (I know it shouldn't.)
Thanks for working on this, LGTM! Please wait for one of the AIX maintainers to approve too.
Addresses all review comments and rebased.
Make sure the CI passes since during the last iteration the CI was down.
Thanks for the reviews!
Removed the parent commit and test again with -Wno-tautological-compare.
Thanks for the review!
Mon, Jun 20
LGTM once the CI passes. I think it would be good for @ldionne to also have a look so I leave the final approval to him.
Thanks for the review!
Try restarting CI.
Sun, Jun 19
Sat, Jun 18
One request, when you address a review comment, can you check the "done" button this makes reviewing easier.
LGTM, but please wait for approval of an AIX maintainer.
Address review comments.
Fri, Jun 17
LGTM, but please give other reviewers a bit more time to have a look.
Thanks for the review!
@infrandomness thanks a lot for providing this CI runner!
Thanks for working on this!
I've rebased the GCC-12 CI changes (D126667) on top of this one and the GCC CI is happy (https://buildkite.com/llvm-project/libcxx-ci/builds/11560).
So that means the only tautological comparison issues where the constant evaluated messages.
Thanks for your contribution! I'll have another look after all comment have been addressed.
No real objection, but I think having an XFAIL will give us feedback when modules start working with modules.
LGTM after the CI passes. I leave the final approval to @philnik since he also had some comments.
LGTM, thanks!
Thu, Jun 16
@ldionne I've the suggested changes, but before putting it up for review again I want to see whether these changes impact other work-in-progress code. (Not merge conflicts, but incompatibilities.)
LGTM when the CI passes.