Page MenuHomePhabricator

Mordante (Mark de Wever)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 9:08 AM (212 w, 1 d)

Recent Activity

Today

Mordante updated the diff for D150031: [libc++][format] Adds a UTF transcoder..

Rebased and adjusted to upstream changes.

Sat, Jun 3, 8:44 AM · Restricted Project, Restricted Project
Mordante added a comment to D150264: [libcxx] Add strict weak ordering checks to sorting algorithms.

I don't have commit rights, can you help me submit the change?

Danila Kutenin
kutdanila@yandex.ru

Sat, Jun 3, 7:16 AM · Restricted Project, Restricted Project, Restricted Project
Mordante accepted D146094: [libc++][spaceship] Implement `operator<=>` for `stack`.

LGTM after addressing the review comments.

Sat, Jun 3, 7:03 AM · Restricted Project, Restricted Project
Mordante accepted D146066: [libc++][spaceship] Implement `operator<=>` for `queue`.

LGTM!

Sat, Jun 3, 6:58 AM · Restricted Project, Restricted Project
Mordante added a comment to D151559: [libc++] implement std::`jthread`.

I didn't do an in depth review, I mainly looked at the code out of curiosity.

Sat, Jun 3, 6:50 AM · Restricted Project, Restricted Project
Mordante added inline comments to D151792: [libc++][NFC] Granularise <thread> header.
Sat, Jun 3, 6:45 AM · Restricted Project, Restricted Project
Mordante accepted D146398: [libcxx] Fix using std::wcout/wcin on Windows with streams configured in wide mode.

LGTM modulo 2 nits.

Sat, Jun 3, 6:41 AM · Restricted Project, Restricted Project
Mordante updated the diff for D149672: [libc++][format] Fixes UTF-8 continuation..

Rebased and address review comments.

Sat, Jun 3, 6:25 AM · Restricted Project, Restricted Project
Mordante added a comment to D149672: [libc++][format] Fixes UTF-8 continuation..

Thanks for the review!

Sat, Jun 3, 6:24 AM · Restricted Project, Restricted Project
Mordante requested review of D152062: [chrono][test] Fixes some tests on Windows..
Sat, Jun 3, 4:39 AM · Restricted Project, Restricted Project
Mordante added a comment to D151814: [libc++][modules] Adds the C++23 std module..

Hello, i'll add the support of this patch in XMake today :)

Sat, Jun 3, 4:27 AM · Restricted Project, Restricted Project
Mordante retitled D151814: [libc++][modules] Adds the C++23 std module. from libc++][modules] Adds the C++23 std module. to [libc++][modules] Adds the C++23 std module..
Sat, Jun 3, 4:18 AM · Restricted Project, Restricted Project
Mordante requested changes to D152008: [libc++] Use .gen.py tests for the transitive inclusion tests.

In general the approach seems fine, but I want to do some testing with this patch.
Especially to see what happens when the regenerate_expected_results flag is toggled.

Sat, Jun 3, 4:17 AM · Restricted Project, Restricted Project

Thu, Jun 1

Mordante added a comment to D151814: [libc++][modules] Adds the C++23 std module..

Thanks for the review!

Thu, Jun 1, 1:32 PM · Restricted Project, Restricted Project
Mordante accepted D151893: [libc++] Use Lit annotations for all .gen.py tests.

Thanks for working on these improvements! LGTM!

Thu, Jun 1, 1:11 PM · Restricted Project, Restricted Project
Mordante accepted D151830: [libc++] Refactor the mandatory header inclusion tests to .gen.py.

LGTM!

Thu, Jun 1, 1:10 PM · Restricted Project, Restricted Project
Mordante accepted D151913: [libc++] Make sure we use POSIX paths in header_information.py.

Now with approval selected ;-)

Thu, Jun 1, 12:56 PM · Restricted Project, Restricted Project
Mordante added a comment to D151913: [libc++] Make sure we use POSIX paths in header_information.py.

LGTM!

Thu, Jun 1, 12:56 PM · Restricted Project, Restricted Project
Mordante added a comment to D146066: [libc++][spaceship] Implement `operator<=>` for `queue`.

In general I'm happy, but I would like to see whether custom_container_iterator can be removed.

Thu, Jun 1, 12:37 PM · Restricted Project, Restricted Project
Mordante added a comment to D151900: [libc++][NFC] Create a new folder for config-related headers..

Could you add some information in the commit message why this is a good idea?

Thu, Jun 1, 10:06 AM · Restricted Project, Restricted Project
Mordante published D151814: [libc++][modules] Adds the C++23 std module. for review.
Thu, Jun 1, 8:12 AM · Restricted Project, Restricted Project

Wed, May 31

Mordante added inline comments to D151830: [libc++] Refactor the mandatory header inclusion tests to .gen.py.
Wed, May 31, 1:29 PM · Restricted Project, Restricted Project
Mordante added a comment to D151654: [libc++] Transition all remaining generated tests to the new .gen format.

Did we add documentation for this new feature?
LGTM!

It is documented in format.py like we do for other types of tests.

Wed, May 31, 1:15 PM · Restricted Project, Restricted Project
Mordante accepted D151825: [libc++][NFC] Use TEST_HAS_NO_FILESYSTEM_LIBRARY in the test suite.

LGTM, thanks for fixing this.

Wed, May 31, 12:35 PM · Restricted Project, Restricted Project
Mordante added a reviewer for D151629: [libc++][ranges] Implement P2494R2 (Relaxing range adaptors to allow for move only types): var-const.

I mainly glossed over it. I'm not to familiar with the details of these internals of ranges.

Wed, May 31, 10:37 AM · Restricted Project, Restricted Project
Mordante accepted D151654: [libc++] Transition all remaining generated tests to the new .gen format.

Did we add documentation for this new feature?
LGTM!

Wed, May 31, 10:28 AM · Restricted Project, Restricted Project
Mordante added a comment to D151740: [libc++] Include "bits/alltypes.h" to provide mbstate_t when using musl libc.

Please don't land libc++ patches until the libc++ group has approved.

Oops, sorry for my ignorance, @philnik... I didn't know this rule existed for libc++ patch reviews. Thank you for educating me.

Wed, May 31, 10:23 AM · Restricted Project, Restricted Project
Mordante accepted D151792: [libc++][NFC] Granularise <thread> header.

LGTM after undoing the formatting changes and the CI passes.
Can you make two followup commits

  • format all the new files, I don't like to do that is the same commit, that makes tracking changes in git harder
  • modernize the code _LIBCPP_INLINE_VISIBILITY -> _LIBCPP_HIDE_FROM_ABI, _VSTD -> std, typedef -> using
Wed, May 31, 10:21 AM · Restricted Project, Restricted Project
Mordante committed rGf29f1c7e23d5: [libc++]{CI] Bumps clang-tidy version used. (authored by Mordante).
[libc++]{CI] Bumps clang-tidy version used.
Wed, May 31, 8:26 AM · Restricted Project, Restricted Project
Mordante closed D151628: [libc++]{CI] Bumps clang-tidy version used..
Wed, May 31, 8:25 AM · Restricted Project, Restricted Project
Mordante committed rGcf64668b8c41: [libc++][test] Prefers the newer clang-tidy version. (authored by Mordante).
[libc++][test] Prefers the newer clang-tidy version.
Wed, May 31, 8:25 AM · Restricted Project, Restricted Project
Mordante closed D149455: [libc++][test] Prefers the newer clang-tidy version..
Wed, May 31, 8:24 AM · Restricted Project, Restricted Project
Mordante committed rG5d4281d5493c: [libc++] Gives ignore external linkage. (authored by Mordante).
[libc++] Gives ignore external linkage.
Wed, May 31, 8:23 AM · Restricted Project, Restricted Project
Mordante closed D151490: [libc++] Gives ignore external linkage..
Wed, May 31, 8:23 AM · Restricted Project, Restricted Project
Mordante committed rGac7d60f73a4a: [libc++] Fixes use-after move diagnostic. (authored by Mordante).
[libc++] Fixes use-after move diagnostic.
Wed, May 31, 8:22 AM · Restricted Project, Restricted Project
Mordante closed D151223: [libc++] Fixes use-after move diagnostic..
Wed, May 31, 8:21 AM · Restricted Project, Restricted Project
Mordante added a comment to D150813: [libc++][docs] Add note about RFCs for significant changes.

LGTM!

Wed, May 31, 8:10 AM · Restricted Project, Restricted Project

Tue, May 30

Mordante added inline comments to D150908: [libc++][ci] Use ccache in the jobs that build Clang.
Tue, May 30, 11:00 PM · Restricted Project, Restricted Project
Mordante committed rG4de9936fe0e3: [libc++][CI] Escape quoting. (authored by Mordante).
[libc++][CI] Escape quoting.
Tue, May 30, 10:56 PM · Restricted Project, Restricted Project
Mordante added a comment to D151223: [libc++] Fixes use-after move diagnostic..

Thanks for catching me copy-pasting from the wrong place.

Tue, May 30, 10:50 PM · Restricted Project, Restricted Project
Mordante updated the diff for D151223: [libc++] Fixes use-after move diagnostic..

Addresses review comments.

Tue, May 30, 10:49 PM · Restricted Project, Restricted Project
Mordante committed rG0ee73debf744: [libc++][format] Fixes year formatter on Windows. (authored by Mordante).
[libc++][format] Fixes year formatter on Windows.
Tue, May 30, 9:58 AM · Restricted Project, Restricted Project
Mordante closed D151612: [libc++][format] Fixes year formatter on Windows..
Tue, May 30, 9:58 AM · Restricted Project, Restricted Project
Mordante committed rG66c7388c83bb: [libc++] Deprecate the classes in strstream. (authored by Mordante).
[libc++] Deprecate the classes in strstream.
Tue, May 30, 9:57 AM · Restricted Project, Restricted Project
Mordante closed D151474: [libc++] Deprecate the classes in strstream..
Tue, May 30, 9:57 AM · Restricted Project, Restricted Project
Mordante added a comment to D151474: [libc++] Deprecate the classes in strstream..

Thanks for the reviews. I'll add release notes before committing.

Tue, May 30, 9:52 AM · Restricted Project, Restricted Project
Mordante added inline comments to D151490: [libc++] Gives ignore external linkage..
Tue, May 30, 9:48 AM · Restricted Project, Restricted Project
Mordante added inline comments to D151223: [libc++] Fixes use-after move diagnostic..
Tue, May 30, 9:45 AM · Restricted Project, Restricted Project
Mordante updated the diff for D151223: [libc++] Fixes use-after move diagnostic..

Addresses review comments.

Tue, May 30, 9:43 AM · Restricted Project, Restricted Project
Mordante committed rGd951c6a53363: [libc++][CI] Installs libomp. (authored by Mordante).
[libc++][CI] Installs libomp.
Tue, May 30, 9:41 AM · Restricted Project, Restricted Project
Mordante closed D151488: [libc++][CI] Installs libomp..
Tue, May 30, 9:40 AM · Restricted Project, Restricted Project
Mordante added inline comments to D151223: [libc++] Fixes use-after move diagnostic..
Tue, May 30, 8:23 AM · Restricted Project, Restricted Project
Mordante updated the summary of D151223: [libc++] Fixes use-after move diagnostic..
Tue, May 30, 8:21 AM · Restricted Project, Restricted Project

Sun, May 28

Mordante updated the diff for D151628: [libc++]{CI] Bumps clang-tidy version used..

CI fixes

Sun, May 28, 7:59 AM · Restricted Project, Restricted Project
Mordante requested review of D151628: [libc++]{CI] Bumps clang-tidy version used..
Sun, May 28, 5:25 AM · Restricted Project, Restricted Project
Mordante updated the diff for D149455: [libc++][test] Prefers the newer clang-tidy version..

Adds an extra test.
Rebased on top of D151223.

Sun, May 28, 3:24 AM · Restricted Project, Restricted Project
Mordante published D151612: [libc++][format] Fixes year formatter on Windows. for review.
Sun, May 28, 3:21 AM · Restricted Project, Restricted Project

Sat, May 27

Mordante accepted D148416: [libc++][spaceship] Implement `operator<=>` for `multiset` and `set`.
Sat, May 27, 8:54 AM · Restricted Project, Restricted Project
Mordante added a comment to D151267: mdspan: implement layout_right.

Thanks for working on this! I didn't compare the code with the Standard. A few minor nits.

Sat, May 27, 6:03 AM · Restricted Project, Restricted Project
Mordante committed rG48985f58b41a: [libc++][format][test] Adds Windows support. (authored by Mordante).
[libc++][format][test] Adds Windows support.
Sat, May 27, 4:58 AM · Restricted Project, Restricted Project
Mordante committed rGcbaa3597aaf6: Reland "[CMake] Bumps minimum version to 3.20.0. (authored by Mordante).
Reland "[CMake] Bumps minimum version to 3.20.0.
Sat, May 27, 3:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Mordante added a reverting change for rGd763c6e5e2d0: Revert "Reland "[CMake] Bumps minimum version to 3.20.0."": rGcbaa3597aaf6: Reland "[CMake] Bumps minimum version to 3.20.0..
Sat, May 27, 3:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Mordante added a reverting change for D137724: [CMake] Warn when the version is older than 3.20.0.: rGcbaa3597aaf6: Reland "[CMake] Bumps minimum version to 3.20.0..
Sat, May 27, 3:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Mordante closed D151344: Reland "[CMake] Bumps minimum version to 3.20.0..
Sat, May 27, 3:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Mordante accepted D151344: Reland "[CMake] Bumps minimum version to 3.20.0..

Thank you for making another try for the treewide change (which is admittedly very painful and not many people do such work).

Sat, May 27, 3:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Mordante added a reverting change for D137724: [CMake] Warn when the version is older than 3.20.0.: D151344: Reland "[CMake] Bumps minimum version to 3.20.0..
Sat, May 27, 3:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Mordante updated the summary of D151344: Reland "[CMake] Bumps minimum version to 3.20.0..
Sat, May 27, 3:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, May 26

Mordante published D151490: [libc++] Gives ignore external linkage. for review.
Fri, May 26, 11:50 AM · Restricted Project, Restricted Project
Mordante added a comment to D151521: [libc++] Optimize transform_reduce for floating point types.

Not looked at the patch closely but I wonder about the usage of the pragma and their scope.

Fri, May 26, 11:50 AM · Restricted Project, Restricted Project
Mordante added a comment to D150907: [libc++][ci] Install ccache in the Docker image.

LGTM! I wonder whether it would make sense to store the cache itself outside the docker image so is can be reused between runs or does the image keep running?

My understanding is that the container keeps running between CI jobs, so that shouldn't be needed.

Fri, May 26, 11:44 AM · Restricted Project, Restricted Project
Mordante published D151223: [libc++] Fixes use-after move diagnostic. for review.
Fri, May 26, 11:42 AM · Restricted Project, Restricted Project
Mordante updated the diff for D151474: [libc++] Deprecate the classes in strstream..
  • Rebased to fix CI
  • Fixes and modernizes some tests
Fri, May 26, 8:12 AM · Restricted Project, Restricted Project

Thu, May 25

Mordante added a comment to D151244: [libc++][NFC] Remove regex matchers for static_assert in .verify tests.

I don't know if Xcode 14.3 (Apple Clang 14.0.3 base on LLVM15) is a supported compiler

Thu, May 25, 12:53 PM · Restricted Project, Restricted Project
Mordante requested review of D151488: [libc++][CI] Installs libomp..
Thu, May 25, 12:39 PM · Restricted Project, Restricted Project
Mordante updated the diff for D151474: [libc++] Deprecate the classes in strstream..

Addresses review comments.

Thu, May 25, 12:22 PM · Restricted Project, Restricted Project
Mordante added inline comments to D151474: [libc++] Deprecate the classes in strstream..
Thu, May 25, 12:21 PM · Restricted Project, Restricted Project
Mordante requested review of D151474: [libc++] Deprecate the classes in strstream..
Thu, May 25, 11:05 AM · Restricted Project, Restricted Project
Mordante committed rG32d8c2427712: [libc++][test] Mark throw_format_error as noreturn. (authored by Mordante).
[libc++][test] Mark throw_format_error as noreturn.
Thu, May 25, 10:46 AM · Restricted Project, Restricted Project

Wed, May 24

Mordante accepted D151274: [libc++] Optimize for_each for segmented iterators.

I'm happy, but since Louis had some remarks I leave the final approval to him.

Wed, May 24, 2:08 PM · Restricted Project, Restricted Project
Mordante accepted D151265: [libc++] Introduce __for_each_segment and use it in copy/move.

LGTM, if possible I still would like benchmarks, but not a blocker.

Wed, May 24, 2:05 PM · Restricted Project, Restricted Project
Mordante added a comment to D149672: [libc++][format] Fixes UTF-8 continuation..

@tahonermann when you have time can you have a look?

Wed, May 24, 10:59 AM · Restricted Project, Restricted Project
Mordante accepted D151240: [libc++][PSTL] Make sure that -fexperimental-library enables the PSTL.

LGTM, thanks!

Wed, May 24, 10:49 AM · Restricted Project, Restricted Project
Mordante accepted D150763: [NFC][Py Reformat] Reformat python files in libcxx/libcxxabi.

LGTM!

Wed, May 24, 10:29 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Mordante requested changes to D151244: [libc++][NFC] Remove regex matchers for static_assert in .verify tests.

I like the change, but want to see a green CI before looking closer at it.

Wed, May 24, 10:16 AM · Restricted Project, Restricted Project
Mordante added a comment to D151274: [libc++] Optimize for_each for segmented iterators.

Benchmark numbers:

Wed, May 24, 10:14 AM · Restricted Project, Restricted Project
Mordante added a comment to D151265: [libc++] Introduce __for_each_segment and use it in copy/move.

Would it make sense to add benchmarks? The number in D151274 look quite impressive.

Wed, May 24, 10:03 AM · Restricted Project, Restricted Project
Mordante accepted D151248: [libc++][spaceship][NFC] Improved consistency - removed `inline` specifier for `operator<=>`.

Thanks, LGTM!

Wed, May 24, 9:43 AM · Restricted Project, Restricted Project
Mordante added a comment to D144509: [CMake] Bumps minimum version to 3.20.0..

I've created D151344 @glandium @hans @thakis I really would appreciate when you can test the patch locally to avoid another revert round.

Wed, May 24, 9:19 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Mordante added a reverting change for rGd763c6e5e2d0: Revert "Reland "[CMake] Bumps minimum version to 3.20.0."": D151344: Reland "[CMake] Bumps minimum version to 3.20.0..
Wed, May 24, 9:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Mordante requested review of D151344: Reland "[CMake] Bumps minimum version to 3.20.0..
Wed, May 24, 9:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Mordante committed rG81fb5a0e1cf8: [libc++] Fixes clang-tidy plugin for clang-tidy 17. (authored by Mordante).
[libc++] Fixes clang-tidy plugin for clang-tidy 17.
Wed, May 24, 9:07 AM · Restricted Project, Restricted Project
Mordante closed D151224: [libc++] Fixes clang-tidy plugin for clang-tidy 17..
Wed, May 24, 9:07 AM · Restricted Project, Restricted Project
Mordante added a comment to D151224: [libc++] Fixes clang-tidy plugin for clang-tidy 17..

Are you sure this is expected? I can't really imagine a scenario where an attribute doesn't have a name. Clang itself also seems to assume that the pointer is non-null, since it just dereferences it instantly in quite a few places.

Wed, May 24, 8:30 AM · Restricted Project, Restricted Project
Mordante committed rGdff62f5251f2: [libc++][format] Removes the experimental status. (authored by Mordante).
[libc++][format] Removes the experimental status.
Wed, May 24, 8:16 AM · Restricted Project, Restricted Project
Mordante closed D150802: [libc++][format] Removes the experimental status..
Wed, May 24, 8:16 AM · Restricted Project, Restricted Project

Tue, May 23

Mordante updated the diff for D150802: [libc++][format] Removes the experimental status..

Rebased.

Tue, May 23, 10:56 PM · Restricted Project, Restricted Project
Mordante committed rGbea2ff655068: [libc++] Untangles invoke. (authored by Mordante).
[libc++] Untangles invoke.
Tue, May 23, 10:51 PM · Restricted Project, Restricted Project
Mordante closed D150538: [libc++] Untangles invoke..
Tue, May 23, 10:51 PM · Restricted Project, Restricted Project
Mordante committed rG00c97cbc5700: [libc++] Adds C++26 support. (authored by Mordante).
[libc++] Adds C++26 support.
Tue, May 23, 10:49 PM · Restricted Project, Restricted Project
Mordante closed D151026: [libc++] Adds C++26 support..
Tue, May 23, 10:49 PM · Restricted Project, Restricted Project