Page MenuHomePhabricator

Mordante (Mark de Wever)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 9:08 AM (14 w, 2 d)

Recent Activity

Yesterday

Mordante updated the diff for D62453: Regex backreference [3/3] Validate backreferences in the constructor..

Fixes the issues found by @zoecarver.
Only the unit tests don't fail for me. Will try to catch @zoecarver on IRC.

Sat, Aug 17, 12:55 PM · Restricted Project
Mordante updated the diff for D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..

Fixes the issue found by @zoecarver .

Sat, Aug 17, 12:52 PM · Restricted Project
Mordante added inline comments to D66067: Push lambda scope earlier when transforming lambda expression.
Sat, Aug 17, 11:35 AM · Restricted Project
Mordante added inline comments to D62453: Regex backreference [3/3] Validate backreferences in the constructor..
Sat, Aug 17, 11:08 AM · Restricted Project
Mordante added inline comments to D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..
Sat, Aug 17, 11:00 AM · Restricted Project
Mordante added a comment to D62453: Regex backreference [3/3] Validate backreferences in the constructor..

Ping

Sat, Aug 17, 6:06 AM · Restricted Project
Mordante added a comment to D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..

Ping

Sat, Aug 17, 6:06 AM · Restricted Project
Mordante added a comment to D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used.

Ping

Sat, Aug 17, 6:01 AM · Restricted Project
Mordante added a comment to D64874: [Sema] Improve handling of function pointer conversions.

Ping

Sat, Aug 17, 6:00 AM · Restricted Project
Mordante updated the diff for D65695: Implements CWG 1601 in [over.ics.rank/4.2].

Implemented the changes requested by @rsmith.

Sat, Aug 17, 3:23 AM · Restricted Project
Mordante added inline comments to D65695: Implements CWG 1601 in [over.ics.rank/4.2].
Sat, Aug 17, 3:21 AM · Restricted Project

Thu, Aug 15

Mordante updated the diff for D65695: Implements CWG 1601 in [over.ics.rank/4.2].

Add the proper markers in the unit test to update cxx_dr_status.html. As discussed on IRC; the up to date cwg_index.html is not public, so I only updated the unit test and removed the changes to cxx_dr_status.html.

Thu, Aug 15, 12:49 PM · Restricted Project
Mordante updated the diff for D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments.

Updated the unit tests as requested. This required the Sema::ActOnParamDefaultArgument to delay a part of the ODR validation until the default argument has been 'instantiated'.
As discussed on IRC; the up to date cwg_index.html is not public, so I only updated the unit test and removed the changes to cxx_dr_status.html.

Thu, Aug 15, 11:33 AM · Restricted Project
Mordante updated the diff for D64811: Warn when NumParams overflows.

Moved the testing from Parse to Sema.
Added additional safeguards for template instantiation.
Added more unit tests.
The comments may be a bit noisy, but they explain why the templates need to be tested at two locations.

Thu, Aug 15, 10:18 AM · Restricted Project

Tue, Aug 6

Mordante added a comment to D64696: Adds a warning when an inline Doxygen comment has no argument.

Unfortunately I'm not able to quickly find the Doxygen output of Swift online. When I process:
A limited variant of \c @objc that's used for classes with generic ancestry.
with Doxygen I get:
A limited variant of that's used for classes with generic ancestry.
Since the @ is used for commands I think they should be escaped like:
include/swift/AST/Decl.h: /// such as \c \@testable and \c \@usableFromInline into account.

Tue, Aug 6, 10:50 AM · Restricted Project, Restricted Project

Mon, Aug 5

Mordante added a comment to D64696: Adds a warning when an inline Doxygen comment has no argument.

I think it should warn; according to the documentation [1] \c expects a word. Testing with Doxygen indeed gives a warning.

Mon, Aug 5, 9:45 AM · Restricted Project, Restricted Project

Sun, Aug 4

Mordante added inline comments to D65695: Implements CWG 1601 in [over.ics.rank/4.2].
Sun, Aug 4, 10:08 AM · Restricted Project
Mordante added inline comments to D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments.
Sun, Aug 4, 10:05 AM · Restricted Project

Sat, Aug 3

Mordante created D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments.
Sat, Aug 3, 3:46 AM · Restricted Project
Mordante created D65695: Implements CWG 1601 in [over.ics.rank/4.2].
Sat, Aug 3, 2:58 AM · Restricted Project
Mordante created D65694: Properly instantiate a decltype in argument's default initializer.
Sat, Aug 3, 2:10 AM · Restricted Project

Wed, Jul 31

Mordante added inline comments to D64811: Warn when NumParams overflows.
Wed, Jul 31, 12:42 PM · Restricted Project

Mon, Jul 29

Mordante added a comment to D64696: Adds a warning when an inline Doxygen comment has no argument.

Thanks for the review.

Mon, Jul 29, 9:35 AM · Restricted Project, Restricted Project

Tue, Jul 23

Mordante updated the diff for D64696: Adds a warning when an inline Doxygen comment has no argument.

Addresses @gribozavr comments.

Tue, Jul 23, 11:32 AM · Restricted Project, Restricted Project
Mordante added a comment to D64696: Adds a warning when an inline Doxygen comment has no argument.

All inline commands defined in include/clang/AST/CommentCommands.td require an argument. The escape commands, like \&, are handled in the switch starting at lib/AST/CommentLexer.cpp:366. They are stored as Text and not as an InlineCommand.

Tue, Jul 23, 11:32 AM · Restricted Project, Restricted Project

Jul 17 2019

Mordante created D64874: [Sema] Improve handling of function pointer conversions.
Jul 17 2019, 11:16 AM · Restricted Project

Jul 16 2019

Mordante created D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used.
Jul 16 2019, 2:24 PM · Restricted Project
Mordante updated the diff for D64644: Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.

Remove the includes from the test.
Changed the std::is_constructible to is_same since the latter is easier to mock.

Jul 16 2019, 12:00 PM · Restricted Project
Mordante created D64811: Warn when NumParams overflows.
Jul 16 2019, 11:01 AM · Restricted Project
Mordante updated the diff for D64644: Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.

Fixes @lebedev.ri's remark and adds the requested test.
While working on the test I discovered the initial assumption in bug 35682 was incorrect. Updated the title and summary accordingly.

Jul 16 2019, 10:12 AM · Restricted Project

Jul 13 2019

Mordante added a comment to D63975: Warn when ScopeDepthOrObjCQuals overflows.

Thanks for the review. I don't have SVN access, can you commit these changes?

Jul 13 2019, 11:58 AM · Restricted Project
Mordante updated the diff for D63975: Warn when ScopeDepthOrObjCQuals overflows.

Addresses @rjmccall's remarks.
Fixes the tests for the nested lambda's.
As suspected the blocks also have the same nesting limit, thus added a test for them.

Jul 13 2019, 10:45 AM · Restricted Project
Mordante created D64696: Adds a warning when an inline Doxygen comment has no argument.
Jul 13 2019, 9:04 AM · Restricted Project, Restricted Project

Jul 12 2019

Mordante added a comment to D64644: Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.

Thanks for feedback. I'll whether I can find a way to generate a nice test case.

Jul 12 2019, 10:03 AM · Restricted Project
Mordante created D64644: Fixes an assertion failure while instantiation a template with an incomplete typo corrected type.
Jul 12 2019, 9:44 AM · Restricted Project
Mordante updated the diff for D63975: Warn when ScopeDepthOrObjCQuals overflows.

Moved the test out of the loop as suggested by rjmccall.

Jul 12 2019, 9:25 AM · Restricted Project
Mordante added inline comments to D63975: Warn when ScopeDepthOrObjCQuals overflows.
Jul 12 2019, 9:23 AM · Restricted Project

Jul 11 2019

Mordante updated the diff for D63975: Warn when ScopeDepthOrObjCQuals overflows.

tab -> space
adds an extra unit test for lambdas
fixes an off by one error found while testing the lambdas

Jul 11 2019, 2:48 PM · Restricted Project
Mordante added inline comments to D63975: Warn when ScopeDepthOrObjCQuals overflows.
Jul 11 2019, 2:48 PM · Restricted Project

Jul 9 2019

Mordante added a comment to D62779: [2/2] Fix complexity of map insert_or_assign with a hint..

It seems there already is a unit test "test/std/containers/associative/map/map.modifiers/insert_or_assign.pass.cpp". I'll add extra tests to this file.

Jul 9 2019, 11:20 AM · Restricted Project
Mordante updated the diff for D62453: Regex backreference [3/3] Validate backreferences in the constructor..

Added more unit tests.
Moved the range validation from D62451 in this patch.

Jul 9 2019, 10:57 AM · Restricted Project
Mordante updated the diff for D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..

Removes the throw and move that to D62453.

Jul 9 2019, 10:46 AM · Restricted Project

Jun 29 2019

Mordante updated the diff for D62778: [1/2] Add a benchmark for map operations..

I added 3 extra iterator positions for all hint cases:

  • end() as you suggested.
  • begin() this is most of the time the wrong iterator.
  • the third element this is most of the time the wrong iterator. Just to avoid the code will use special optimizations on begin() and end().
Jun 29 2019, 11:40 AM · Restricted Project
Mordante created D63975: Warn when ScopeDepthOrObjCQuals overflows.
Jun 29 2019, 11:09 AM · Restricted Project

Jun 27 2019

Mordante added inline comments to D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..
Jun 27 2019, 12:11 PM · Restricted Project
Mordante added a comment to D63059: Implements multiline regex support.

Thanks for the review.

Jun 27 2019, 11:50 AM · Restricted Project
Mordante added a comment to D62452: Regex backreference [2/3] Validate the entire regex is consumed..

Thanks for the review!

Jun 27 2019, 11:50 AM · Restricted Project
Mordante updated the diff for D62452: Regex backreference [2/3] Validate the entire regex is consumed..

Removed the ABI question in the comment

Jun 27 2019, 11:42 AM · Restricted Project

Jun 9 2019

Mordante created D63059: Implements multiline regex support.
Jun 9 2019, 7:30 AM · Restricted Project

Jun 1 2019

Mordante created D62779: [2/2] Fix complexity of map insert_or_assign with a hint..
Jun 1 2019, 9:30 AM · Restricted Project
Mordante created D62778: [1/2] Add a benchmark for map operations..
Jun 1 2019, 9:30 AM · Restricted Project

May 27 2019

Mordante added a comment to D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..

I added a unit test in part 3 of the series [1]. Would you prefer to have the test for this fix in this patch?

May 27 2019, 2:10 PM · Restricted Project

May 25 2019

Mordante created D62453: Regex backreference [3/3] Validate backreferences in the constructor..
May 25 2019, 12:02 PM · Restricted Project
Mordante created D62452: Regex backreference [2/3] Validate the entire regex is consumed..
May 25 2019, 11:55 AM · Restricted Project
Mordante created D62451: Regex backreference [1/3] Fixes backreferences for extended grammar..
May 25 2019, 11:55 AM · Restricted Project
Mordante added a comment to D61828: Throw the proper exception on a regex range error.

Thanks for the review.
Yes, please commit it for me since I don't have commit access.

May 25 2019, 7:25 AM · Restricted Project

May 11 2019

Mordante created D61828: Throw the proper exception on a regex range error.
May 11 2019, 12:45 PM · Restricted Project