Page MenuHomePhabricator

Mordante (Mark de Wever)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2019, 9:08 AM (110 w, 3 d)

Recent Activity

Today

Mordante updated the diff for D103357: [libc++][format] Add __format_arg_store..

Revert last change.
Included more headers and the test passes locally.

Mon, Jun 21, 11:44 AM · Restricted Project
Mordante updated the diff for D103357: [libc++][format] Add __format_arg_store..

Forward declare visit_format_arg. Test whether this fixes the modular build.

Mon, Jun 21, 11:11 AM · Restricted Project
Mordante added a comment to D103357: [libc++][format] Add __format_arg_store..

LGTM but this will need to be reviewed by someone familiar with libc++ of course =).

Mon, Jun 21, 10:57 AM · Restricted Project
Mordante updated the diff for D103357: [libc++][format] Add __format_arg_store..

Tab -> space.

Mon, Jun 21, 10:47 AM · Restricted Project

Thu, Jun 17

Mordante updated the diff for D103357: [libc++][format] Add __format_arg_store..

Tabs -> space.

Thu, Jun 17, 10:50 AM · Restricted Project
Mordante added a comment to D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").

LGTM, but there's one comment not addressed yet. Please fix that before landing the patch.

Thu, Jun 17, 10:35 AM · Restricted Project
Mordante added inline comments to D103983: [libc++][rfc] Improve atomic_fetch_(add|sub).*..
Thu, Jun 17, 10:29 AM · Restricted Project
Mordante updated the diff for D103357: [libc++][format] Add __format_arg_store..

Addresses review comments.
Update module map.
Update P2216 status; it will be part of C++23 and backported to C++20.

Thu, Jun 17, 10:12 AM · Restricted Project

Wed, Jun 16

Mordante accepted D104414: [libcxx][iwyu] 🎨 adds more headers to IWYU.

If buildkite's happy, I'm happy.

Wed, Jun 16, 12:25 PM · Restricted Project
Mordante added a comment to D97742: [C++23] [P1518R2] Better CTAD behavior for containers with allocators.

Minor nit-pick found while reading e-mail, haven't looked at the rest of the patch.

Wed, Jun 16, 12:22 PM · Restricted Project
Mordante updated the summary of D103357: [libc++][format] Add __format_arg_store..
Wed, Jun 16, 11:31 AM · Restricted Project
Mordante planned changes to D103357: [libc++][format] Add __format_arg_store..

Thanks for the review!

Wed, Jun 16, 11:31 AM · Restricted Project

Thu, Jun 10

Mordante added inline comments to D103983: [libc++][rfc] Improve atomic_fetch_(add|sub).*..
Thu, Jun 10, 12:17 PM · Restricted Project
Mordante added a comment to D103983: [libc++][rfc] Improve atomic_fetch_(add|sub).*..

I'll look at implementing the proper constrains for the final patch.
For now I would like to determine whether we want to keep or remove the non-standard extension.
(Not sure whether they're extensions or bugs.)

Thu, Jun 10, 9:00 AM · Restricted Project

Wed, Jun 9

Mordante committed rGe7c621a60788: [libc++][nfc] Test std::unique_ptr self move assignment. (authored by Mordante).
[libc++][nfc] Test std::unique_ptr self move assignment.
Wed, Jun 9, 11:43 AM
Mordante closed D103764: [libc++][nfc] Test std::unique_ptr self move assignment..
Wed, Jun 9, 11:43 AM · Restricted Project
Mordante requested review of D103983: [libc++][rfc] Improve atomic_fetch_(add|sub).*..
Wed, Jun 9, 11:41 AM · Restricted Project
Mordante updated the diff for D103764: [libc++][nfc] Test std::unique_ptr self move assignment..

Rebase to make sure CI failures aren't due to this patch.

Wed, Jun 9, 9:22 AM · Restricted Project
Mordante updated the summary of D96664: [libc++][format] Implement formatters..
Wed, Jun 9, 8:54 AM · Restricted Project

Tue, Jun 8

Mordante updated the diff for D103357: [libc++][format] Add __format_arg_store..

Fixes an bug in the format_arg constructor for string_view.
Improve the format_arg constructor for string by addressing LWG3542.

Tue, Jun 8, 10:59 PM · Restricted Project
Mordante updated the summary of D103357: [libc++][format] Add __format_arg_store..
Tue, Jun 8, 10:50 PM · Restricted Project
Mordante added a comment to D103863: [libcxx][ci] enables assertions for runtimes-build.

@Mordante The runtimes build doesn't run on macOS nodes, so I think this is fine.

Tue, Jun 8, 9:13 AM · Restricted Project

Mon, Jun 7

Mordante added a comment to D103558: [libcxx] Remove VLA from libcxx locale header.

Just FYI when we approve with the condition the CI is green after a rebase, you're free to land the patch after the CI passes.
So feel free to land the patch, or do you need somebody to commit it on your behalf?
If so please provide your name and e-mail address so we commit it on your behalf.

Mon, Jun 7, 11:17 PM · Restricted Project
Mordante accepted D103863: [libcxx][ci] enables assertions for runtimes-build.

The change is fine by me, but I've some concerns with the build node used for this feature.
The Apple nodes aren't the fastest neither the most reliable build nodes we have.
This combination makes this node less than ideal for build iterations.
So I'm not happy to _only_ enable it for this node, but the improvements can be done in a separate patch.

Mon, Jun 7, 11:09 PM · Restricted Project
Mordante requested changes to D103769: [libcxx] Implement P0883R2 ("Fixing Atomic Initialization").

Thanks for working this. (Actually I was considering to look at it, but happy I didn't start ;-))
Can you investigate the CI errors that are introduced with this patch?

Mon, Jun 7, 10:06 AM · Restricted Project
Mordante accepted D103753: [libc++] [P0619] Add _LIBCPP_ABI_NO_BINDER_BASES and remove binder typedefs in C++20..

LGTM.

Mon, Jun 7, 9:20 AM · Restricted Project

Sun, Jun 6

Mordante requested review of D103765: [libc++][nfc] Update atomic synopsis..
Sun, Jun 6, 5:52 AM · Restricted Project
Mordante requested review of D103764: [libc++][nfc] Test std::unique_ptr self move assignment..
Sun, Jun 6, 4:49 AM · Restricted Project
Mordante requested changes to D103581: [libc++][compare]Implement compare_three_way_result[_t].

We recently started implementing libc++ is more granular headers. Can you adopt that style for these changes too?
You an use D103734 as an example.
I see a lot of build failure. I did a quick look and I expect none of them are due to this patch, but to main not working properly. Can you rebase your patch to see whether it passes the build?

Sun, Jun 6, 3:06 AM · Restricted Project
Mordante requested changes to D102135: [libcxx][ranges] adds _`semiregular-box`_.

I didn't look closely at the unit test, but there seems several missing. "…semiregular-box<T> behaves exactly like optional<T> with the following differences…". The optional has several member functions not tested. For example constexpr T* operator->(), constexpr T& operator*(). I also miss the implementation of several of optional's constructors.

Sun, Jun 6, 2:37 AM · Restricted Project
Mordante accepted D103734: [libcxx][modularisation] moves <utility> content out of <type_traits>.

I like this direction! I assume the patch has no changes in the moved code.
LGTM modulo one minor nit.

Sun, Jun 6, 2:00 AM · Restricted Project
Mordante added a comment to D103753: [libc++] [P0619] Add _LIBCPP_ABI_NO_BINDER_BASES and remove binder typedefs in C++20..

Thanks for the clean-up. I see no big issues, but would like to discuss the backwards compatibility flags before approving.

Sun, Jun 6, 1:30 AM · Restricted Project

Sat, Jun 5

Mordante committed rGfbe4c839e8a2: [libc++][doc] Update Format status. (authored by Mordante).
[libc++][doc] Update Format status.
Sat, Jun 5, 5:00 AM
Mordante updated the summary of D103670: [libc++][format] Adds bool formatter..
Sat, Jun 5, 4:18 AM · Restricted Project
Mordante updated the summary of D103466: [libc++][format] Adds char formatter..
Sat, Jun 5, 4:17 AM · Restricted Project
Mordante updated the summary of D103433: [libc++][format] Adds integer formatter..
Sat, Jun 5, 4:16 AM · Restricted Project
Mordante updated the summary of D103425: [libc++][format] Adds string formatter..
Sat, Jun 5, 4:15 AM · Restricted Project
Mordante updated the summary of D103413: [libc++][format] Implement Unicode support..
Sat, Jun 5, 4:12 AM · Restricted Project
Mordante updated the summary of D103379: [libc++][format] Add a CMake Unicode option..
Sat, Jun 5, 4:10 AM · Restricted Project
Mordante updated the summary of D103368: [libc++][format] Adds parser std-format-spec..
Sat, Jun 5, 4:09 AM · Restricted Project
Mordante updated the summary of D96664: [libc++][format] Implement formatters..
Sat, Jun 5, 4:07 AM · Restricted Project
Mordante abandoned D93593: [libc++][format] Add __format_arg_store..

This patch has been abandoned in favour of D103357. Some of the prerequisites have landed which causes the CI to have merge issues.

Sat, Jun 5, 4:01 AM · Restricted Project
Mordante updated the summary of D103357: [libc++][format] Add __format_arg_store..
Sat, Jun 5, 3:59 AM · Restricted Project

Thu, Jun 3

Mordante accepted D103444: [libcxx] Don't use an undefined '+' in unsigned/octal/hexal print formats.

SMGT, but I'd like some unit tests to test the new correct behaviour.

Hmm, so a test under libcxx/test/libcxx somewhere, with a local class subclassing std::__1::__num_put_base so that the protected method __format_int can be called, and then testing the different flag combinations?

Thu, Jun 3, 11:12 PM · Restricted Project
Mordante requested review of D103670: [libc++][format] Adds bool formatter..
Thu, Jun 3, 10:59 PM · Restricted Project
Mordante updated the diff for D103466: [libc++][format] Adds char formatter..

Rebase.
Disable a failing test on Windows.

Thu, Jun 3, 10:50 PM · Restricted Project
Mordante updated the diff for D103433: [libc++][format] Adds integer formatter..
  • Rebase
  • Fix octal buffer size off by 1.
  • Add test for maximum integral values.
  • Fixes Windows issue
  • Polishing
Thu, Jun 3, 12:44 PM · Restricted Project
Mordante committed rGfd3a5260852a: [libc++][nfc] Add more nasty macros. (authored by Mordante).
[libc++][nfc] Add more nasty macros.
Thu, Jun 3, 9:23 AM
Mordante closed D103541: [libc++][nfc] Add more nasty macros..
Thu, Jun 3, 9:23 AM · Restricted Project
Mordante accepted D103558: [libcxx] Remove VLA from libcxx locale header.

Note that, while the base prefix for hex (0x) is slightly longer than the
base prefix for octal (0), this isn't a concern. The difference in the space
needed for the value portion of the string is enough to make up for this.

Thu, Jun 3, 9:16 AM · Restricted Project
Mordante updated the diff for D103425: [libc++][format] Adds string formatter..

Disable the failing part of a test on Windows.

Thu, Jun 3, 9:05 AM · Restricted Project

Wed, Jun 2

Mordante updated the diff for D103425: [libc++][format] Adds string formatter..
  • Rebase
  • Rename __pre and __post since they are reserved on Windows. D103541 will add these names to the nasty macros
  • Remove a dupliated hunk. The hunk was moved to its own function to used for Boolean formatting, but the original remained instead of calling the new function.
Wed, Jun 2, 11:25 PM · Restricted Project
Mordante added a comment to D103551: [libcxx][module-map] creates submodules for private headers.

Thanks a lot for working on this! And thanks @ldionne for setting up a CI to catch these issues earlier!

Wed, Jun 2, 11:04 PM · Restricted Project
Mordante updated the diff for D103413: [libc++][format] Implement Unicode support..

Temporary disable a failing test on Windows.

Wed, Jun 2, 10:47 PM · Restricted Project
Mordante updated the diff for D103413: [libc++][format] Implement Unicode support..

Rebase.
Improve comments.

Wed, Jun 2, 12:17 PM · Restricted Project
Mordante added inline comments to D103541: [libc++][nfc] Add more nasty macros..
Wed, Jun 2, 11:31 AM · Restricted Project
Mordante requested review of D103541: [libc++][nfc] Add more nasty macros..
Wed, Jun 2, 11:00 AM · Restricted Project
Mordante updated the diff for D103379: [libc++][format] Add a CMake Unicode option..

Rebase.
Fixes minor grammar error in comment.

Wed, Jun 2, 10:29 AM · Restricted Project
Mordante added inline comments to D102006: [libcxx][ranges] Add range.subrange..
Wed, Jun 2, 10:14 AM · Restricted Project
Mordante updated the diff for D103368: [libc++][format] Adds parser std-format-spec..

Tabs -> spaces.

Wed, Jun 2, 9:25 AM · Restricted Project
Mordante updated the diff for D103368: [libc++][format] Adds parser std-format-spec..

Rebase.
Mark unit test requiring concepts.
Minor cleanup.

Wed, Jun 2, 9:02 AM · Restricted Project

Tue, Jun 1

Mordante accepted D103339: [libcxx][NFC] Tidy up calculation of __nbuf in num_put::do_put, and add comments.

rebase

Tue, Jun 1, 11:04 PM · Restricted Project
Mordante updated the diff for D96664: [libc++][format] Implement formatters..

Removed iterator_different_t work-around
Use proper constrain in
vformat_to (_CharT instead of char)
Polishing

Tue, Jun 1, 10:43 PM · Restricted Project
Mordante added a comment to D103478: [libc++][compare] Implement three_way_comparable[_with] concepts.

Thanks for working on this.

Tue, Jun 1, 1:15 PM · Restricted Project
Mordante added inline comments to D103357: [libc++][format] Add __format_arg_store..
Tue, Jun 1, 12:48 PM · Restricted Project
Mordante updated the diff for D103357: [libc++][format] Add __format_arg_store..

Attempt to fix the build.

Tue, Jun 1, 12:20 PM · Restricted Project
Mordante updated the diff for D103357: [libc++][format] Add __format_arg_store..

Rebased on main
Polishing
implement a real output_iterator concept, main has the require prerequisite.

Tue, Jun 1, 11:42 AM · Restricted Project
Mordante accepted D102992: [libcxx][type_traits] remove `std::is_literal_type` and `std::result_of` for C++20.

Thanks for the updates, LGTM!

Tue, Jun 1, 10:31 AM · Restricted Project
Mordante requested review of D103466: [libc++][format] Adds char formatter..
Tue, Jun 1, 9:20 AM · Restricted Project
Mordante added a comment to D103444: [libcxx] Don't use an undefined '+' in unsigned/octal/hexal print formats.

SMGT, but I'd like some unit tests to test the new correct behaviour. I think @Quuxplusone's proposed change is more readable, but I don't object against your version.

Tue, Jun 1, 8:55 AM · Restricted Project
Mordante updated the diff for D103433: [libc++][format] Adds integer formatter..

Cast to the proper signedness that should fix the AArch and ARM builds.

Tue, Jun 1, 8:20 AM · Restricted Project

Mon, May 31

Mordante added inline comments to D103339: [libcxx][NFC] Tidy up calculation of __nbuf in num_put::do_put, and add comments.
Mon, May 31, 11:12 PM · Restricted Project
Mordante updated the diff for D103433: [libc++][format] Adds integer formatter..

Adds a required inline, fixes the build issue.

Mon, May 31, 11:01 PM · Restricted Project
Mordante requested review of D103433: [libc++][format] Adds integer formatter..
Mon, May 31, 10:39 PM · Restricted Project
Mordante requested review of D103425: [libc++][format] Adds string formatter..
Mon, May 31, 12:32 PM · Restricted Project
Mordante updated the diff for D103413: [libc++][format] Implement Unicode support..

Remove an accidental edit, which caused the code to become invalid.

Mon, May 31, 9:40 AM · Restricted Project
Mordante added a comment to D103339: [libcxx][NFC] Tidy up calculation of __nbuf in num_put::do_put, and add comments.

Nice catch! Can you rebase the patch to rerun the CI?

Mon, May 31, 9:29 AM · Restricted Project
Mordante requested review of D103413: [libc++][format] Implement Unicode support..
Mon, May 31, 9:05 AM · Restricted Project

Sun, May 30

Mordante updated the diff for D103379: [libc++][format] Add a CMake Unicode option..

Reupload to fix the build breakage. The patch should be stand-alone but seems
to have an issue to apply the patch when not part of the series.

Sun, May 30, 5:20 AM · Restricted Project
Mordante requested review of D103379: [libc++][format] Add a CMake Unicode option..
Sun, May 30, 5:16 AM · Restricted Project
Mordante updated the diff for D103368: [libc++][format] Adds parser std-format-spec..

Updates the paper status.
Fixes no-except and no-localization unit tests.

Sun, May 30, 3:13 AM · Restricted Project
Mordante updated the diff for D96664: [libc++][format] Implement formatters..

Disable the formatter.const_char_array.pass.cpp on gcc 11 and apple-clang.

Sun, May 30, 3:09 AM · Restricted Project

Sat, May 29

Mordante added a comment to D103369: [libc++] NFC: Move unwrap_iter to its own header.

Well, my solution was to add this new header (and all new headers) to module.modulemap. So I assume this PR will fail buildkite as-is; it would need to add this header (and/or other new headers) to module.modulemap in order to keep buildkite happy. But I recommend people discuss the issue/solution(s) over on https://reviews.llvm.org/D102781#inline-979125 just to keep it all in the same place.

Sat, May 29, 1:39 PM · Restricted Project
Mordante updated the diff for D103369: [libc++] NFC: Move unwrap_iter to its own header.

Rebase on top of D102781, see whether the CI likes this version better.

Sat, May 29, 1:28 PM · Restricted Project
Mordante requested review of D103369: [libc++] NFC: Move unwrap_iter to its own header.
Sat, May 29, 1:24 PM · Restricted Project
Mordante updated the diff for D103368: [libc++][format] Adds parser std-format-spec..

Reupload, forgot to set the dependencies so CI failed.

Sat, May 29, 1:16 PM · Restricted Project
Mordante requested review of D103368: [libc++][format] Adds parser std-format-spec..
Sat, May 29, 1:09 PM · Restricted Project
Mordante updated the diff for D96664: [libc++][format] Implement formatters..

Disable the iostream in unit tests when localization is disabled. This should fix the no localization build.

Sat, May 29, 11:01 AM · Restricted Project
Mordante added inline comments to D96664: [libc++][format] Implement formatters..
Sat, May 29, 9:29 AM · Restricted Project
Mordante updated the diff for D96664: [libc++][format] Implement formatters..

Another attempt to fix the build.

  • used #ifndef instead of #ifdef
  • test whether the CI accepts Arthurs UNSUPPORTED helper
Sat, May 29, 9:27 AM · Restricted Project
Mordante updated the diff for D96664: [libc++][format] Implement formatters..

Fix CI issues:

  • Remove an extra semi-column
  • Remove clang::musttail attribute since not everywhere supported
  • Disable debug iterators for a test copying an library string
Sat, May 29, 8:15 AM · Restricted Project
Mordante updated the diff for D96664: [libc++][format] Implement formatters..

Reworked the enitre patch.
Changed the dependency from D93593 to D103357 since the former no longer can be build on the CI.
There are still some minor changes planned, but want to test the CI build.

Sat, May 29, 5:26 AM · Restricted Project
Mordante updated the summary of D96664: [libc++][format] Implement formatters..
Sat, May 29, 4:52 AM · Restricted Project
Mordante updated the diff for D103357: [libc++][format] Add __format_arg_store..

Fixes build for platforms without 128-bit support.

Sat, May 29, 4:15 AM · Restricted Project
Mordante accepted D103160: [libc++] Update ABI docs.

LGTM, but please wait for the reaction of @ldionne and @mclow.lists.

Sat, May 29, 1:46 AM · Restricted Project
Mordante accepted D103309: [libcxx] [test] Don't look for the literal spelling __mbstate_t.

LGTM, modulo the remark.

Sat, May 29, 1:42 AM · Restricted Project
Mordante updated the diff for D103357: [libc++][format] Add __format_arg_store..

Remove non-ASCII comment.

Sat, May 29, 1:41 AM · Restricted Project
Mordante requested review of D103357: [libc++][format] Add __format_arg_store..
Sat, May 29, 1:29 AM · Restricted Project
Mordante added a comment to rG9968896cd62a: [libc++] NFC: Move unwrap_iter to its own header.

This commit seems to be the cause of the recent build failures of main. A local revert fixed the broken unit tests.

Sat, May 29, 12:52 AM
Mordante added a reverting change for rG9968896cd62a: [libc++] NFC: Move unwrap_iter to its own header: rGb13edf6e907b: Revert "[libc++] NFC: Move unwrap_iter to its own header".
Sat, May 29, 12:51 AM