Would it make sense to also allow wmain with wchar_t? https://docs.microsoft.com/en-us/cpp/cpp/main-function-command-line-args?view=vs-2019

In D73007#1829597, @aaron.ballman wrote:

LGTM! Do you think this should also be pushed onto the release branch?

In D73007#1829709, @xbolva00 wrote:

Yes, but minimal fix is better for release branch, so @hans should merge it.

Handling your case probably needs more work and patches..

I proposed D73007 as fix.

Thanks for your report. I think it's similar to https://bugs.llvm.org/show_bug.cgi?id=44556. I'll look for a fix.

Thanks for the review!

Committed as https://reviews.llvm.org/rGdc422e968e73790178e500f506e8fb7cfa1e62ea

Thanks for the review!

In D72553#1815558, @njames93 wrote:

• 99% sure I have all incriments renamed now

I only have some naming nits

• incriment -> increment
• decriment -> decrement

Friendly ping, it would be nice to get this in the next release.

Adding Depends on D72284 would add the patches to the stack.
I like the patch!

While looking at the test failures I noticed the tests pointer_to_integral_type_conv in clang/test/Sema/MicrosoftExtensions.c were not tested. Will look into it later.

You're welcome. It would be nice if we can get this one in the release.

Thanks for the feedback!

In D72231#1804929, @xbolva00 wrote:

The diagnostic is not enabled by default

But GCC enables it for C even without "-Wall or -Wextra". Clang should follow it..

Made some improvements based on feedback of @craig.topper:

• Adds a not
• Implements an example of the maximum string length when using -Wpedantic

Nice to see this patch! I intended to look at a similar patch, but that's no longer required.

Rebased on master. This adds one new fix and removes the ones done by others.

@eugene Please don't use auto when type is spelled in same statement or iterator. do you mean type is not spelled ?

I like this change, but I don't feel qualified to fully review the patch.

In D72210#1804355, @MaskRay wrote:

You can drop changes to lld. I've fixed lld -Wrange-loop-analysis a few days ago in 681b1be774964a804beabfb7c5e3bdab8f979e4a . (Archive::Child c was also deleted).

For mlir, only mlir/lib/Dialect/Linalg/Utils/Utils.cpp:117:8 needs a fix. I've fixed others in eeef50b1fee91dbe993187324003d2665ceae331.

LGTM
I proposed the same change in D72210, but I'll adjust that patch once accepted.

In D71857#1800663, @MaskRay wrote:

I think there is a false positive.

https://github.com/llvm/llvm-project/tree/master/lld/ELF/Relocations.cpp#L1622

for (const std::pair<ThunkSection *, uint32_t> ts : isd->thunkSections)

Added support for some additional features:

• Allow limits from the C standard, either sharing the C++ constants or separately.
• Allow to document the design choices for the limit.
• Allow to track the status of the limit. (This may become obsolete ones all limits are implemented, but that can take a while.)

In D71857#1800663, @MaskRay wrote:

However, I am afraid I don't like some of the fixes here. You can replace const auto with const auto & and call that a fix... IMHO if the type is not obvious, const ConcreteType & will be better.

Thanks for the review! I'll commit all the -Wrange-loop-analysis patches later today.

Reviewed the types and added a * for pointers and added a const when applicable.

Fixes the compilation issues with the clang unit tests.

The merge bot noticed I forgot to update clang's unittests. Will look at that.

Thanks for writing this document! I noticed the document contains a lot of long sentences. These may be harder to understand for non-native speakers. I pointed a few out, but for some I don't have better suggestions.

I like the goal of this patch and the simplifications it does. I don't feel qualified to do a full review.

@aaron.ballman thanks for the reviews. I'll drop the top-level const in this and the related patches.

In D68912#1794138, @xbolva00 wrote:

All is fixed now?