- User Since
- Dec 3 2019, 7:48 AM (60 w, 1 d)
Wed, Jan 20
rebased, fixed my own comments.
Dec 17 2020
No problem at all.
Is there a reason why assembly files have a different flag (i.e. -mmark-bti-property) to create the .note.gnu.property with the BTI entry?
The .note.gnu.property is already generated when C/C++ files are compiled with -mbranch-protection=bti.
-mmark-bti-property is only for assembly file where the .note.gnu.property should be added manually otherwise.
Dec 16 2020
@manojgupta Thanks for the feedback, let me know if you have updates.
Dec 10 2020
Dec 3 2020
unwind_leaffunction.pass.cpp could be enable too for aarch64.
Dec 2 2020
Nov 17 2020
Nov 11 2020
Nov 10 2020
Done see: D91182
Nov 9 2020
Nov 5 2020
Nov 2 2020
Oct 30 2020
Oct 29 2020
https://bugs.llvm.org/show_bug.cgi?id=47142 this effects this. the missing unwind info make forceunwind fragile.
Oct 26 2020
self.cxx has a function to test compiler flags addFlagIfSupported but there is no support for linker flag (yet).
rebase, add MINGW32
Oct 19 2020
Oct 17 2020
Add a simple test and fixes.
This version passes on arm32 - armv7l-unknown-linux-gnueabihf -
Oct 16 2020
_Unwind_Stop_Fn shall not have different signature for EHABI.
Oct 15 2020
Those are gone from the view, so ignore what I said.
Oct 12 2020
LGTM, just please fix the lint issues in the llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h
The system-* and native are used in clang and lldb only, so dropped.
I only added them for consistency across llvm components.
Sep 29 2020
some test never runs due to these features are missing. I realised this when tried to run this one: https://github.com/llvm/llvm-project/blob/master/libunwind/test/remember_state_leak.pass.sh.s#L1
Sep 28 2020
Sep 25 2020
update module flag handling due to the change is merged in: D85649.
Sep 24 2020
Thanks for the review. It looks like I still need someone from the libunwind group to accept it.
one kernel image that runs on hardware both with and without BTI ISA extensions?
In case of BTI one image could run on both HW due to BTI is in the no-op space.
Sep 21 2020
LGTM, refactor looks correct. in case of _LIBUNWIND_ARM_EHABI the director of the iteration over the phdrs changed but that is fine.
Sep 18 2020
I think error is fine because realistically linking modules with different BTI settings will result probably a binary that crash runtime anyway if BTI is on.
otherwise turning BTI on just of a subset of object is useless.
Sorry for the trouble for now the patch is reverted.
I you agre I will resubmit it with ; REQUIRES: x86_64-linux and then figure out the rest of the targets later.
Sep 17 2020
Sep 16 2020
rebasing to the new patch series.
Rebased top of D85649.
adding an option _LIBUNWIND_REMEMBER_HEAP to store the state on the heap.
I kept the default on the stack because it should be fine for most cases.
Sep 15 2020
@nickdesaulniers Thanks for the review, comments are addressed.
Sep 11 2020
I'll update this after other PAC/BTI patches got merged.
Sep 4 2020
Sep 1 2020
I support the idea, once I proposed back then ( see D75181 )