Page MenuHomePhabricator

danielkiss (Daniel Kiss)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2019, 7:48 AM (79 w, 5 d)

Recent Activity

Thu, May 27

danielkiss added a comment to D102912: [libunwind] AARCH64 use inline assembly for pointer authentication.

/usr/bin/clang-11 --version
Ubuntu clang version 11.0.0-2~ubuntu20.04.1

Seems it is fixed in 11.0.1 and trunk or at least I was not able to reproduce the crash, codegen looks fine.

Thu, May 27, 12:42 PM · Restricted Project, Restricted Project, Restricted Project

Fri, May 21

danielkiss added a comment to D102912: [libunwind] AARCH64 use inline assembly for pointer authentication.

LGTM just please run once more git clang-format HEAD^1 on the patch.

Fri, May 21, 5:57 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss added a reviewer for D102912: [libunwind] AARCH64 use inline assembly for pointer authentication: danielkiss.
Fri, May 21, 5:48 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 20

danielkiss committed rG801ab71032e1: [ARM][AArch64] SLSHardening: make non-comdat thunks possible (authored by danielkiss).
[ARM][AArch64] SLSHardening: make non-comdat thunks possible
Thu, May 20, 8:07 AM
danielkiss closed D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.
Thu, May 20, 8:07 AM · Restricted Project, Restricted Project

Wed, May 19

danielkiss added inline comments to D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.
Wed, May 19, 6:02 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.
Wed, May 19, 6:00 AM · Restricted Project, Restricted Project

Tue, May 18

danielkiss updated the diff for D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.

address review comments.

Tue, May 18, 5:41 AM · Restricted Project, Restricted Project

May 11 2021

danielkiss added a comment to D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

ARM EHABI is very different from the Itanium implementation. Someone should move the implementation to a separate file.

Sorry, do you mean the content of the libunwind/include/unwind.h ?

I mean all the #if defined(_LIBCXXABI_ARM_EHABI) branches make the file difficult to read. reduce sharing and move the implementation to a separate file.
Many sanitizer files are organized this way.

May 11 2021, 1:32 PM
danielkiss added inline comments to D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.
May 11 2021, 1:27 PM · Restricted Project, Restricted Project

May 10 2021

danielkiss added inline comments to D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.
May 10 2021, 9:34 AM · Restricted Project, Restricted Project
danielkiss added inline comments to D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.
May 10 2021, 9:19 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.

Adding a fronted flag and tests.
comdat is still the default, feels fine but I'm not sure.

May 10 2021, 9:17 AM · Restricted Project, Restricted Project

May 7 2021

danielkiss added a comment to D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

@jroelofs Thanks for the review, all addressed.

May 7 2021, 9:41 AM
danielkiss updated the diff for D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..
May 7 2021, 9:39 AM
danielkiss added a comment to D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

ARM EHABI is very different from the Itanium implementation. Someone should move the implementation to a separate file.

Sorry, do you mean the content of the libunwind/include/unwind.h ?

May 7 2021, 7:45 AM

May 5 2021

danielkiss updated the diff for D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

Rebased, retested on ToT.

May 5 2021, 1:58 PM
danielkiss added a comment to D101920: [AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP).

Wondering if AArch64InstrInfo::getOutliningType and the outline should do the same because it might emit PACIASP.
see the old change:
https://reviews.llvm.org/D77565?id=256025#change-SC49e8S7FnMX

May 5 2021, 11:52 AM · Restricted Project

Apr 23 2021

danielkiss committed rGb1f463dcae3a: [AArch64] Fix for BTI landing pad insertion with PAC-RET+bkey. (authored by danielkiss).
[AArch64] Fix for BTI landing pad insertion with PAC-RET+bkey.
Apr 23 2021, 1:07 AM
danielkiss closed D100996: [AArch64] Fix for BTI landing pad insertion with PAC-RET+bkey..
Apr 23 2021, 1:07 AM · Restricted Project

Apr 21 2021

danielkiss updated the diff for D100996: [AArch64] Fix for BTI landing pad insertion with PAC-RET+bkey..

Ah, right. EMITBKEY should be a meta one but it seems as a problematic change.
Let's simplify this now and hope no other need to be added too.

Apr 21 2021, 2:22 PM · Restricted Project
danielkiss requested review of D100996: [AArch64] Fix for BTI landing pad insertion with PAC-RET+bkey..
Apr 21 2021, 1:57 PM · Restricted Project

Apr 15 2021

danielkiss requested review of D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible.
Apr 15 2021, 4:18 AM · Restricted Project, Restricted Project

Apr 13 2021

danielkiss accepted D99417: [AArch64][v8.5A] Add BTI to all function starts.

LGTM

Apr 13 2021, 12:16 PM · Restricted Project
danielkiss abandoned D77565: [AArch64] Remove implicit landing pads..

see D99417, way different approach is needed to reduce the number of landing pads.

Apr 13 2021, 6:27 AM · Restricted Project

Apr 12 2021

danielkiss added inline comments to D90202: [libunwind] Fix linker flag handling in the tests..
Apr 12 2021, 9:06 AM · Restricted Project, Restricted Project
danielkiss committed rGa46effbd2aec: [compiler-rt][aarch64] Add PAC-RET/BTI support to HWASAN. (authored by danielkiss).
[compiler-rt][aarch64] Add PAC-RET/BTI support to HWASAN.
Apr 12 2021, 8:03 AM
danielkiss closed D100143: [compiler-rt][aarch64] Add PAC-RET/BTI support to HWASAN..
Apr 12 2021, 8:03 AM · Restricted Project

Apr 8 2021

danielkiss requested review of D100143: [compiler-rt][aarch64] Add PAC-RET/BTI support to HWASAN..
Apr 8 2021, 2:45 PM · Restricted Project
danielkiss requested review of D100142: [compiler-rt][aarch64] Add PAC-RET/BTI support to TSan..
Apr 8 2021, 2:42 PM

Mar 18 2021

danielkiss added inline comments to D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 18 2021, 2:06 PM · Restricted Project
danielkiss committed rG4220531ceff0: [AArch64][compiler-rt] Strip PAC from the link register. (authored by danielkiss).
[AArch64][compiler-rt] Strip PAC from the link register.
Mar 18 2021, 2:05 PM
danielkiss committed rGc1940aac99ea: Revert "[AArch64][compiler-rt] Strip PAC from the link register." (authored by danielkiss).
Revert "[AArch64][compiler-rt] Strip PAC from the link register."
Mar 18 2021, 2:05 PM
danielkiss added a reverting change for rGad40453fc425: [AArch64][compiler-rt] Strip PAC from the link register.: rGc1940aac99ea: Revert "[AArch64][compiler-rt] Strip PAC from the link register.".
Mar 18 2021, 2:05 PM
danielkiss added a reverting change for D98008: [AArch64][compiler-rt] Strip PAC from the link register.: rGc1940aac99ea: Revert "[AArch64][compiler-rt] Strip PAC from the link register.".
Mar 18 2021, 2:04 PM · Restricted Project

Mar 15 2021

danielkiss committed rGad40453fc425: [AArch64][compiler-rt] Strip PAC from the link register. (authored by danielkiss).
[AArch64][compiler-rt] Strip PAC from the link register.
Mar 15 2021, 2:27 AM
danielkiss closed D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 15 2021, 2:26 AM · Restricted Project

Mar 12 2021

danielkiss updated the diff for D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 12 2021, 2:47 PM · Restricted Project
danielkiss added inline comments to D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 12 2021, 11:44 AM · Restricted Project
danielkiss updated the diff for D98008: [AArch64][compiler-rt] Strip PAC from the link register..

Implementing the review comment.

Mar 12 2021, 11:36 AM · Restricted Project

Mar 11 2021

danielkiss added inline comments to D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 11 2021, 11:51 AM · Restricted Project
danielkiss updated the diff for D98008: [AArch64][compiler-rt] Strip PAC from the link register..

fix for lint

Mar 11 2021, 9:28 AM · Restricted Project
danielkiss added inline comments to D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 11 2021, 7:46 AM · Restricted Project
danielkiss updated the diff for D98008: [AArch64][compiler-rt] Strip PAC from the link register..

The current think is that the unstripped value of the return addresses is not too problematic.
Let's keep it simple now.

Mar 11 2021, 7:35 AM · Restricted Project

Mar 10 2021

danielkiss committed rG201550852be4: [AArch64][compiler-rt] Add Pointer Authentication support for VFORK. (authored by danielkiss).
[AArch64][compiler-rt] Add Pointer Authentication support for VFORK.
Mar 10 2021, 7:40 AM
danielkiss closed D98009: [AArch64][compiler-rt] Add Pointer Authentication support for VFORK..
Mar 10 2021, 7:40 AM · Restricted Project

Mar 9 2021

danielkiss added inline comments to D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 9 2021, 11:55 AM · Restricted Project
danielkiss added a comment to D98008: [AArch64][compiler-rt] Strip PAC from the link register..

Keep the PAC in the stack trace and only strip it when necessary like comparing traces, looking up symbols.

Interesting, I'm not saying it's necessarily a bad idea, but could you explain the motivation? The previous approach (stripping the stack trace PCs at the point of capturing stack trace) seemed simpler, easier to implement and presumably faster (less stripping operations overall).

Storing the PAC protected return addresses sounds safer because the values in trace can't be used directly as jump addresses. Assuming some might use sanitisers in production.

Mar 9 2021, 11:46 AM · Restricted Project
danielkiss updated the diff for D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 9 2021, 10:30 AM · Restricted Project
danielkiss planned changes to D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 9 2021, 6:03 AM · Restricted Project
danielkiss updated the diff for D98008: [AArch64][compiler-rt] Strip PAC from the link register..

Keep the PAC in the stack trace and only strip it when necessary like comparing traces, looking up symbols.
Moved the strip to the sanitizer_ptrauth.h.

Mar 9 2021, 4:45 AM · Restricted Project

Mar 5 2021

danielkiss added a comment to D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 5 2021, 11:52 AM · Restricted Project

Mar 4 2021

danielkiss requested review of D98009: [AArch64][compiler-rt] Add Pointer Authentication support for VFORK..
Mar 4 2021, 11:13 PM · Restricted Project
danielkiss requested review of D98008: [AArch64][compiler-rt] Strip PAC from the link register..
Mar 4 2021, 11:08 PM · Restricted Project

Feb 17 2021

danielkiss added a comment to D96901: [libunwind] Add support for PC reg column in arm64.

Could you add [libunwind] to the beginning of title?
but otherwise LGTM as the author of the corresponding dwarf spec change.

Feb 17 2021, 4:53 PM · Restricted Project, Restricted Project

Feb 15 2021

danielkiss accepted D96560: libunwind: Don't attempt to authenticate a null return address..

LGTM, Thanks.

Feb 15 2021, 2:16 AM · Restricted Project, Restricted Project

Feb 8 2021

danielkiss updated the diff for D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

Reenables tests ( revert of a4fa667dee60 )

Feb 8 2021, 10:01 AM

Feb 4 2021

danielkiss added a reviewer for D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI.: Restricted Project.
Feb 4 2021, 11:35 AM
danielkiss added inline comments to D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..
Feb 4 2021, 11:07 AM
danielkiss updated the diff for D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

@MaskRay Thanks for the test case.

Feb 4 2021, 11:04 AM

Feb 2 2021

danielkiss accepted D95880: typo.

LGTM, thanks.

Feb 2 2021, 9:46 AM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2021

danielkiss updated the diff for D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

rebased, fixed my own comments.

Jan 20 2021, 4:20 PM

Dec 17 2020

danielkiss added a comment to D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti.

Thanks Daniel for the explanation.

No problem at all.

Dec 17 2020, 1:45 PM · Restricted Project
danielkiss added a comment to D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti.

Is there a reason why assembly files have a different flag (i.e. -mmark-bti-property) to create the .note.gnu.property with the BTI entry?

Dec 17 2020, 10:11 AM · Restricted Project
danielkiss added a comment to D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti.

The .note.gnu.property is already generated when C/C++ files are compiled with -mbranch-protection=bti.
-mmark-bti-property is only for assembly file where the .note.gnu.property should be added manually otherwise.

Dec 17 2020, 3:52 AM · Restricted Project

Dec 16 2020

danielkiss added a comment to D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

@manojgupta Thanks for the feedback, let me know if you have updates.

Dec 16 2020, 8:39 AM
danielkiss retitled D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI. from [WIP][Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI. to [Arm][Unwind] Add _Unwind_ForcedUnwind to EHABI..
Dec 16 2020, 8:31 AM

Dec 10 2020

danielkiss added inline comments to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Dec 10 2020, 1:48 AM · Restricted Project, Restricted Project

Dec 3 2020

danielkiss accepted D90898: [libunwind] Unwind through aarch64/Linux sigreturn frame.

unwind_leaffunction.pass.cpp could be enable too for aarch64.

Dec 3 2020, 9:29 AM · Restricted Project, Restricted Project
danielkiss accepted D92549: [compiler-rt] Fix building the aarch64 out-of-line atomics assembly for non-ELF platforms.

LGTM

Dec 3 2020, 3:47 AM · Restricted Project

Dec 2 2020

danielkiss accepted D91156: [AArch64] Compiler-rt interface for out-of-line atomics..

LGTM, Thanks.

Dec 2 2020, 5:27 AM · Restricted Project

Nov 17 2020

danielkiss added inline comments to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Nov 17 2020, 8:56 AM · Restricted Project

Nov 11 2020

danielkiss added inline comments to D90868: [IR] Define @llvm.ptrauth intrinsics..
Nov 11 2020, 4:49 PM · Restricted Project
danielkiss committed rGe7b8d3776f36: [libunwind] LIBUNWIND_REMEMBER_HEAP_ALLOC to cmake. (authored by danielkiss).
[libunwind] LIBUNWIND_REMEMBER_HEAP_ALLOC to cmake.
Nov 11 2020, 2:21 AM
danielkiss closed D91182: [libunwind] LIBUNWIND_REMEMBER_HEAP_ALLOC to cmake..
Nov 11 2020, 2:21 AM · Restricted Project, Restricted Project

Nov 10 2020

danielkiss added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

Done see: D91182

Nov 10 2020, 9:03 AM · Restricted Project, Restricted Project
danielkiss requested review of D91182: [libunwind] LIBUNWIND_REMEMBER_HEAP_ALLOC to cmake..
Nov 10 2020, 9:02 AM · Restricted Project, Restricted Project
danielkiss added inline comments to D91156: [AArch64] Compiler-rt interface for out-of-line atomics..
Nov 10 2020, 8:41 AM · Restricted Project

Nov 9 2020

danielkiss added inline comments to D91087: [AArch64] Select PAC/PACGA for ptrauth.sign/sign_generic..
Nov 9 2020, 11:04 AM · Restricted Project
danielkiss added inline comments to D90898: [libunwind] Unwind through aarch64/Linux sigreturn frame.
Nov 9 2020, 7:26 AM · Restricted Project, Restricted Project

Nov 5 2020

danielkiss added inline comments to D89483: [ARM][MachineOutliner] Emit more CFI instructions.
Nov 5 2020, 3:00 PM · Restricted Project

Nov 2 2020

danielkiss accepted D90615: [libunwind] Add missing #include <alloca.h>.

LGTM, Thanks!

Nov 2 2020, 7:56 AM · Restricted Project, Restricted Project

Oct 30 2020

danielkiss added inline comments to D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage.
Oct 30 2020, 11:30 AM · Restricted Project, Restricted Project
danielkiss committed rG1d7786d45f48: [libunwind] Support DW_CFA_remember/restore_state without heap allocation. (authored by danielkiss).
[libunwind] Support DW_CFA_remember/restore_state without heap allocation.
Oct 30 2020, 9:45 AM
danielkiss closed D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..
Oct 30 2020, 9:45 AM · Restricted Project, Restricted Project

Oct 29 2020

danielkiss committed rGfd1c064845e5: [libcxx] Add targets to available features. (authored by danielkiss).
[libcxx] Add targets to available features.
Oct 29 2020, 6:04 AM
danielkiss closed D88027: [libcxx] Add targets to available features..
Oct 29 2020, 6:04 AM · Restricted Project
danielkiss committed rG05598e3d3047: [libunwind] Fix linker flag handling in the tests. (authored by danielkiss).
[libunwind] Fix linker flag handling in the tests.
Oct 29 2020, 6:03 AM
danielkiss closed D90202: [libunwind] Fix linker flag handling in the tests..
Oct 29 2020, 6:02 AM · Restricted Project, Restricted Project
danielkiss added a comment to D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

https://bugs.llvm.org/show_bug.cgi?id=47142 this effects this. the missing unwind info make forceunwind fragile.

Oct 29 2020, 5:59 AM

Oct 26 2020

danielkiss added a comment to D90202: [libunwind] Fix linker flag handling in the tests..

self.cxx has a function to test compiler flags addFlagIfSupported but there is no support for linker flag (yet).

Oct 26 2020, 5:44 PM · Restricted Project, Restricted Project
danielkiss added inline comments to D83573: [libunwind] Support for leaf function unwinding..
Oct 26 2020, 5:40 PM · Restricted Project, Restricted Project
danielkiss requested review of D90202: [libunwind] Fix linker flag handling in the tests..
Oct 26 2020, 5:39 PM · Restricted Project, Restricted Project
danielkiss updated the diff for D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

rebase, add MINGW32

Oct 26 2020, 3:01 PM · Restricted Project, Restricted Project

Oct 19 2020

danielkiss added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

ping

Oct 19 2020, 7:53 AM · Restricted Project, Restricted Project

Oct 17 2020

danielkiss updated the diff for D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..
Oct 17 2020, 4:11 PM
danielkiss updated the diff for D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

Add a simple test and fixes.
This version passes on arm32 - armv7l-unknown-linux-gnueabihf -

Oct 17 2020, 4:07 PM
danielkiss planned changes to D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..
Oct 17 2020, 1:54 PM

Oct 16 2020

danielkiss updated the diff for D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..

_Unwind_Stop_Fn shall not have different signature for EHABI.

Oct 16 2020, 12:53 PM
danielkiss changed the visibility for D89570: [Arm][Unwind][libc++abi] Add _Unwind_ForcedUnwind to EHABI..
Oct 16 2020, 11:05 AM