Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

danielkiss (Daniel Kiss)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2019, 7:48 AM (198 w, 5 d)

Recent Activity

Tue, Sep 12

danielkiss added inline comments to D149635: [libunwind] Use __builtin_alloca to avoid missing include.
Tue, Sep 12, 7:22 AM · Restricted Project, Restricted Project, Restricted Project

Aug 14 2023

danielkiss committed rG1ef3de6b09f6: Disable sanitizer's on ifunc resolvers. (authored by danielkiss).
Disable sanitizer's on ifunc resolvers.
Aug 14 2023, 11:57 AM · Restricted Project, Restricted Project
danielkiss closed D150262: Disable sanitizer's on ifunc resolvers..
Aug 14 2023, 11:57 AM · Restricted Project, Restricted Project
danielkiss added a comment to D150262: Disable sanitizer's on ifunc resolvers..

Peter's out of office. This patch looks fine to me, and I'll land it for you.

ok, I can land it too, no worries.

Aug 14 2023, 6:05 AM · Restricted Project, Restricted Project
danielkiss added a comment to D150262: Disable sanitizer's on ifunc resolvers..

@pcc Do you mind to land this?
chromium run into this recently: https://bugs.chromium.org/p/chromium/issues/detail?id=1454613

Aug 14 2023, 5:58 AM · Restricted Project, Restricted Project

Aug 11 2023

danielkiss accepted D157688: [LowerTypeTests,ARM] Support Armv8-M BTI in jump tables..
Aug 11 2023, 6:05 AM · Restricted Project, Restricted Project

Jun 29 2023

danielkiss committed rG92fbb602f3b6: [lld][AArch64] Add BTI landing pad to PLT entries when the symbol is exported. (authored by danielkiss).
[lld][AArch64] Add BTI landing pad to PLT entries when the symbol is exported.
Jun 29 2023, 1:17 PM · Restricted Project
danielkiss closed D153264: [lld][AArch64] Add BTI landing pad to PLT entries when the symbol is exported..
Jun 29 2023, 1:17 PM · Restricted Project, Restricted Project
danielkiss added inline comments to D153264: [lld][AArch64] Add BTI landing pad to PLT entries when the symbol is exported..
Jun 29 2023, 1:15 PM · Restricted Project, Restricted Project
danielkiss updated the diff for D153264: [lld][AArch64] Add BTI landing pad to PLT entries when the symbol is exported..
Jun 29 2023, 10:27 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D153264: [lld][AArch64] Add BTI landing pad to PLT entries when the symbol is exported..
Jun 29 2023, 9:02 AM · Restricted Project, Restricted Project

Jun 28 2023

danielkiss updated the diff for D153264: [lld][AArch64] Add BTI landing pad to PLT entries when the symbol is exported..

@peter.smith & @MaskRay Thanks for the comments, patch is updated.
Moved the example to a bug.

Jun 28 2023, 6:24 AM · Restricted Project, Restricted Project

Jun 26 2023

danielkiss accepted D153012: Update module flags documentation for Min..
Jun 26 2023, 9:05 AM · Restricted Project, Restricted Project

Jun 19 2023

danielkiss planned changes to D153264: [lld][AArch64] Add BTI landing pad to PLT entries when the symbol is exported..
Jun 19 2023, 1:13 PM · Restricted Project, Restricted Project
danielkiss added a comment to D153264: [lld][AArch64] Add BTI landing pad to PLT entries when the symbol is exported..

minimised reproducer (crashes on a BTI enabled system without the patch, work with the patch)

Jun 19 2023, 7:16 AM · Restricted Project, Restricted Project
danielkiss requested review of D153264: [lld][AArch64] Add BTI landing pad to PLT entries when the symbol is exported..
Jun 19 2023, 4:17 AM · Restricted Project, Restricted Project

Jun 8 2023

danielkiss added a comment to D150262: Disable sanitizer's on ifunc resolvers..

Ping @pcc

Jun 8 2023, 9:35 AM · Restricted Project, Restricted Project

May 30 2023

danielkiss added a reviewer for D150262: Disable sanitizer's on ifunc resolvers.: pcc.
May 30 2023, 8:09 AM · Restricted Project, Restricted Project

May 23 2023

danielkiss accepted D150867: [AArch64][FMV] Prevent target attribute using for multiversioning..

LGTM

May 23 2023, 2:56 AM · Restricted Project, Restricted Project
danielkiss accepted D150800: [AArch64][FMV] Fix name mangling..

LGTM

May 23 2023, 2:55 AM · Restricted Project, Restricted Project

May 10 2023

danielkiss requested review of D150262: Disable sanitizer's on ifunc resolvers..
May 10 2023, 5:52 AM · Restricted Project, Restricted Project

May 9 2023

danielkiss committed rGe305dcc6fdc7: Do not link asan_rtl_x86_64.S for non x86_64 platforms. (authored by CaseySmalley).
Do not link asan_rtl_x86_64.S for non x86_64 platforms.
May 9 2023, 11:12 AM · Restricted Project, Restricted Project
danielkiss closed D149957: Do not link asan_rtl_x86_64.S for non x86_64 platforms..
May 9 2023, 11:12 AM · Restricted Project, Restricted Project, Restricted Project

May 2 2023

danielkiss added inline comments to D149635: [libunwind] Use __builtin_alloca to avoid missing include.
May 2 2023, 2:10 AM · Restricted Project, Restricted Project, Restricted Project

Apr 28 2023

danielkiss committed rGd75e70d7ae1f: [AArch64] Add preserve_all calling convention. (authored by danielkiss).
[AArch64] Add preserve_all calling convention.
Apr 28 2023, 5:56 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss closed D135652: [AArch64] Add preserve_all calling convention..
Apr 28 2023, 5:55 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss updated the diff for D135652: [AArch64] Add preserve_all calling convention..

@efriedma Thanks!
Rebased.

Apr 28 2023, 5:01 AM · Restricted Project, Restricted Project, Restricted Project

Apr 23 2023

danielkiss committed rG60827df76515: [lld][AArch64] Add BTI landing pad to PLT when it is accessed by a range… (authored by danielkiss).
[lld][AArch64] Add BTI landing pad to PLT when it is accessed by a range…
Apr 23 2023, 2:17 PM · Restricted Project
danielkiss closed D148704: [lld][AArch64] Add BTI landing pad to PLT when it is accessed by a range extension thunk..
Apr 23 2023, 2:17 PM · Restricted Project, Restricted Project
danielkiss updated the diff for D148704: [lld][AArch64] Add BTI landing pad to PLT when it is accessed by a range extension thunk..
Apr 23 2023, 2:14 PM · Restricted Project, Restricted Project

Apr 21 2023

danielkiss updated the diff for D148704: [lld][AArch64] Add BTI landing pad to PLT when it is accessed by a range extension thunk..
Apr 21 2023, 12:27 PM · Restricted Project, Restricted Project

Apr 20 2023

danielkiss added inline comments to D148704: [lld][AArch64] Add BTI landing pad to PLT when it is accessed by a range extension thunk..
Apr 20 2023, 3:08 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D148704: [lld][AArch64] Add BTI landing pad to PLT when it is accessed by a range extension thunk..
Apr 20 2023, 3:04 AM · Restricted Project, Restricted Project

Apr 19 2023

danielkiss added inline comments to D148704: [lld][AArch64] Add BTI landing pad to PLT when it is accessed by a range extension thunk..
Apr 19 2023, 11:42 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D148704: [lld][AArch64] Add BTI landing pad to PLT when it is accessed by a range extension thunk..
Apr 19 2023, 11:40 AM · Restricted Project, Restricted Project
danielkiss requested review of D148704: [lld][AArch64] Add BTI landing pad to PLT when it is accessed by a range extension thunk..
Apr 19 2023, 3:43 AM · Restricted Project, Restricted Project

Mar 28 2023

danielkiss accepted D146839: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions.

LGTM, thanks!

Mar 28 2023, 3:13 PM · Restricted Project, Restricted Project

Mar 27 2023

danielkiss added a comment to D146839: [TLI][AArch64] Extend SLEEF vectorized functions mapping with VLA functions.

I'd add note to the documentation too when scalable vectors are used the sleef library is expect to be compiled with it.

Mar 27 2023, 3:15 AM · Restricted Project, Restricted Project

Mar 22 2023

danielkiss added a comment to D135652: [AArch64] Add preserve_all calling convention..

ping

Mar 22 2023, 8:48 AM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2023

danielkiss added a comment to D144982: Fix -fsplit-lto-unit with ifuncs.

Thanks!

Mar 21 2023, 7:36 AM · Restricted Project, Restricted Project
danielkiss committed rG83dc4734ba69: Fix -fsplit-lto-unit with ifuncs (authored by danielkiss).
Fix -fsplit-lto-unit with ifuncs
Mar 21 2023, 7:36 AM · Restricted Project, Restricted Project
danielkiss closed D144982: Fix -fsplit-lto-unit with ifuncs.
Mar 21 2023, 7:36 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D144982: Fix -fsplit-lto-unit with ifuncs.
Mar 21 2023, 3:40 AM · Restricted Project, Restricted Project

Mar 13 2023

danielkiss added a comment to D144982: Fix -fsplit-lto-unit with ifuncs.

Last version fixes the Chromium and others crashes. Generic solution for CloneModule is conceptually more complex and probably orthogonal to this change.

Mar 13 2023, 12:50 PM · Restricted Project, Restricted Project

Mar 8 2023

danielkiss updated the diff for D144982: Fix -fsplit-lto-unit with ifuncs.

let's remove ifuncs if not used.

Mar 8 2023, 10:32 AM · Restricted Project, Restricted Project
danielkiss added a comment to D144982: Fix -fsplit-lto-unit with ifuncs.

I'm a little confused - did we create an illegal split module by cloning the ifunc to the regular LTO split module? Should the handling in CloneModule (particularly with its use of the ShouldCloneDefinition callback) be changed so that ifunc are not cloned if their resolver is not cloned?

simplifyExternals turns the resolver to external. Externals won't be in the module summary which will be referenced by the ifunc.

Right, simplifyExternals ensures that any symbols cloned into the merged Module as declarations are either dropped if there are no references or made external if there are. But this is not specific to resolver functions.

Ah, I see that the latest version of the patch has moved the new ifunc handling into simplifyExternals, and only drops the ifunc if the resolver func is not defined in the module. This is better as it isn't unconditional.

What I was asking was whether we can handle this directly in CloneModule via the callback, instead of removing the ifunc later. I.e. should CloneModule be changed to invoke ShouldCloneDefinition on the ifunc resolver function before deciding whether to clone over each ifunc definition? Because it generally seems incorrect to create a module with an ifunc with a resolver function not defined in that module (i.e. not just when splitting the ThinLTO module, but any time we invoke CloneModule with a callback that doesn't simply return true for everything).

Mar 8 2023, 10:31 AM · Restricted Project, Restricted Project

Mar 6 2023

danielkiss accepted D145392: [AArch64] Don't map llvm sqrt intrinsics to veclib functions.

LGTM

Mar 6 2023, 9:02 AM · Restricted Project, Restricted Project
danielkiss added a comment to D144982: Fix -fsplit-lto-unit with ifuncs.

I'm a little confused - did we create an illegal split module by cloning the ifunc to the regular LTO split module? Should the handling in CloneModule (particularly with its use of the ShouldCloneDefinition callback) be changed so that ifunc are not cloned if their resolver is not cloned?

simplifyExternals turns the resolver to external. Externals won't be in the module summary which will be referenced by the ifunc.

Mar 6 2023, 3:24 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D144982: Fix -fsplit-lto-unit with ifuncs.
Mar 6 2023, 3:00 AM · Restricted Project, Restricted Project

Mar 1 2023

danielkiss updated the summary of D144982: Fix -fsplit-lto-unit with ifuncs.
Mar 1 2023, 7:35 AM · Restricted Project, Restricted Project
danielkiss added a reviewer for D144982: Fix -fsplit-lto-unit with ifuncs: nikic.
Mar 1 2023, 7:30 AM · Restricted Project, Restricted Project

Feb 28 2023

danielkiss requested review of D144982: Fix -fsplit-lto-unit with ifuncs.
Feb 28 2023, 10:01 AM · Restricted Project, Restricted Project

Jan 25 2023

danielkiss added inline comments to D142572: [AArch64] fix bug #55005 handle DW_CFA_GNU_window_save.
Jan 25 2023, 11:41 AM · Restricted Project, Restricted Project

Jan 23 2023

danielkiss accepted D142265: [AArch64] Function multi-versioning release notes added. NFC..

LGTM Thanks

Jan 23 2023, 6:39 AM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2023

danielkiss committed rGc4fa504f797f: [AArch64] Enable libm vectorized functions via SLEEF (authored by danielkiss).
[AArch64] Enable libm vectorized functions via SLEEF
Jan 20 2023, 9:53 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss closed D134719: [AArch64] Enable libm vectorized functions via SLEEF.
Jan 20 2023, 9:52 AM · Restricted Project, Restricted Project, Restricted Project

Jan 18 2023

danielkiss updated the diff for D134719: [AArch64] Enable libm vectorized functions via SLEEF.

clean up createTLII since now fronted checks for the target support.

Jan 18 2023, 8:53 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss accepted D141978: Revert "[AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP)".

Thanks for the patch. LGTM.

Jan 18 2023, 1:00 AM · Restricted Project, Restricted Project

Jan 17 2023

danielkiss added inline comments to D134719: [AArch64] Enable libm vectorized functions via SLEEF.
Jan 17 2023, 10:13 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss resigned from D102912: [libunwind] AARCH64 use inline assembly for pointer authentication.
Jan 17 2023, 3:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 16 2023

danielkiss added a comment to D134719: [AArch64] Enable libm vectorized functions via SLEEF.

Is there any chance of enabling this on platforms other than AArch64? Sleef has x86, AArch32, PowerPC64, System/390, CUDA, and WebAssembly support (although I am mostly interested in x86), in addition to AArch64.

I'll look into adding x86, x86_64, probably in new patch top of this. I would add targets where we have demand.

Jan 16 2023, 6:57 AM · Restricted Project, Restricted Project, Restricted Project

Jan 13 2023

danielkiss added inline comments to D138792: [AArch64] Improve TargetParser API.
Jan 13 2023, 8:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
danielkiss added a comment to D101920: [AArch64][v8.3A] Avoid inserting implicit landing pads (PACI*SP).

Linux kernel sets the the BT0 (and BT1) to 1 unconditionally.
This results the When the PE is executing at EL0, PACIASP and PACIBSP are not compatible with PSTATE.BTYPE == 0b11. (ArmARM)
That means PACI*SP is just a BTI C from BTI point of view.

Jan 13 2023, 7:13 AM · Restricted Project, Restricted Project

Jan 10 2023

danielkiss accepted D141411: [AArch64] Make -march and target("arch=..") attributes imply dependent features.

jut a NIT, LGTM otherwise.

Jan 10 2023, 11:44 AM · Restricted Project, Restricted Project, Restricted Project

Jan 3 2023

danielkiss added a comment to D134719: [AArch64] Enable libm vectorized functions via SLEEF.

ping

Jan 3 2023, 10:58 AM · Restricted Project, Restricted Project, Restricted Project

Dec 9 2022

danielkiss accepted D127812: [AArch64] FMV support and necessary target features dependencies..

just small comment, thanks @ilinpv
LGTM, just let others to chime in.

Dec 9 2022, 11:51 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
danielkiss committed rG218b77c85057: [AArch64][NFC] Move hasFeature fields initiations to the declaration (authored by danielkiss).
[AArch64][NFC] Move hasFeature fields initiations to the declaration
Dec 9 2022, 7:23 AM · Restricted Project, Restricted Project
danielkiss closed D139622: [AArch64][NFC] Move hasFeature fields initiations to the declaration.
Dec 9 2022, 7:23 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D139622: [AArch64][NFC] Move hasFeature fields initiations to the declaration.
Dec 9 2022, 3:25 AM · Restricted Project, Restricted Project
danielkiss added inline comments to D139622: [AArch64][NFC] Move hasFeature fields initiations to the declaration.
Dec 9 2022, 1:52 AM · Restricted Project, Restricted Project

Dec 8 2022

danielkiss requested review of D139622: [AArch64][NFC] Move hasFeature fields initiations to the declaration.
Dec 8 2022, 4:34 AM · Restricted Project, Restricted Project

Dec 7 2022

danielkiss accepted D139503: [Headers][ARM] Allow `struct _Unwind_Exception` in unwind.h.

Wondering if we could deduplicate the headers?

Dec 7 2022, 7:54 AM · Restricted Project, Restricted Project
danielkiss committed rG7d40baa82b1f: [AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH (authored by danielkiss).
[AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH
Dec 7 2022, 7:30 AM · Restricted Project, Restricted Project
danielkiss added a reverting change for rGcfd44221e3e1: [AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH: rG7925e2828e32: Revert "[AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH".
Dec 7 2022, 6:20 AM · Restricted Project, Restricted Project
danielkiss committed rG7925e2828e32: Revert "[AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH" (authored by danielkiss).
Revert "[AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH"
Dec 7 2022, 6:20 AM · Restricted Project, Restricted Project
danielkiss added a reverting change for D139445: [AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH: rG7925e2828e32: Revert "[AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH".
Dec 7 2022, 6:19 AM · Restricted Project, Restricted Project
danielkiss committed rGcfd44221e3e1: [AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH (authored by danielkiss).
[AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH
Dec 7 2022, 5:53 AM · Restricted Project, Restricted Project
danielkiss closed D139445: [AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH.
Dec 7 2022, 5:53 AM · Restricted Project, Restricted Project

Dec 6 2022

danielkiss requested review of D139445: [AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH.
Dec 6 2022, 11:16 AM · Restricted Project, Restricted Project

Nov 30 2022

danielkiss added inline comments to D134719: [AArch64] Enable libm vectorized functions via SLEEF.
Nov 30 2022, 2:32 AM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2022

danielkiss updated the diff for D134719: [AArch64] Enable libm vectorized functions via SLEEF.

address review comments, added more tests. rebased.

Nov 29 2022, 12:03 PM · Restricted Project, Restricted Project, Restricted Project
danielkiss added inline comments to D127812: [AArch64] FMV support and necessary target features dependencies..
Nov 29 2022, 1:30 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 8 2022

danielkiss accepted D137617: [AArch64] Allow users-facing feature names in clang target attributes.

LGTM.

Nov 8 2022, 2:30 AM · Restricted Project, Restricted Project

Nov 7 2022

danielkiss accepted D123394: [CodeGen] Late cleanup of redundant address/immediate definitions..

LGTM to enable this on Arm/AArch64.

Nov 7 2022, 2:30 AM · Restricted Project, Restricted Project

Oct 25 2022

danielkiss accepted D135647: [AArch64][ARM] Alter v8.3a complex neon intrinsics to be target-based, not preprocessor based.

LGTM

Oct 25 2022, 1:42 AM · Restricted Project, Restricted Project

Oct 18 2022

danielkiss committed rG0d0ca64356ff: [AArch64] Make ACLE intrinsics always available part MTE (authored by danielkiss).
[AArch64] Make ACLE intrinsics always available part MTE
Oct 18 2022, 2:03 AM · Restricted Project, Restricted Project
danielkiss added a reverting change for rG09aaf190d933: [AArch64] Make ACLE intrinsics always available part MTE: rGa175d8b1772f: Revert "[AArch64] Make ACLE intrinsics always available part MTE".
Oct 18 2022, 1:46 AM · Restricted Project, Restricted Project
danielkiss committed rGa175d8b1772f: Revert "[AArch64] Make ACLE intrinsics always available part MTE" (authored by danielkiss).
Revert "[AArch64] Make ACLE intrinsics always available part MTE"
Oct 18 2022, 1:46 AM · Restricted Project, Restricted Project
danielkiss added a reverting change for D136062: [AArch64] Make ACLE intrinsics always available part MTE: rGa175d8b1772f: Revert "[AArch64] Make ACLE intrinsics always available part MTE".
Oct 18 2022, 1:46 AM · Restricted Project, Restricted Project
danielkiss committed rG09aaf190d933: [AArch64] Make ACLE intrinsics always available part MTE (authored by danielkiss).
[AArch64] Make ACLE intrinsics always available part MTE
Oct 18 2022, 1:36 AM · Restricted Project, Restricted Project
danielkiss closed D136062: [AArch64] Make ACLE intrinsics always available part MTE.
Oct 18 2022, 1:36 AM · Restricted Project, Restricted Project

Oct 17 2022

danielkiss updated the diff for D136062: [AArch64] Make ACLE intrinsics always available part MTE.

adding test

Oct 17 2022, 11:16 AM · Restricted Project, Restricted Project
danielkiss added a comment to D134719: [AArch64] Enable libm vectorized functions via SLEEF.

ping

Oct 17 2022, 3:11 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss requested review of D136062: [AArch64] Make ACLE intrinsics always available part MTE.
Oct 17 2022, 3:09 AM · Restricted Project, Restricted Project

Oct 14 2022

danielkiss committed rG30b67c677c6b: [AArch64] Make ACLE intrinsics always available part1 (authored by danielkiss).
[AArch64] Make ACLE intrinsics always available part1
Oct 14 2022, 8:23 AM · Restricted Project, Restricted Project
danielkiss closed D133359: [AArch64] Make ACLE intrinsics always available part1.
Oct 14 2022, 8:23 AM · Restricted Project, Restricted Project

Oct 13 2022

danielkiss added inline comments to D135652: [AArch64] Add preserve_all calling convention..
Oct 13 2022, 1:29 PM · Restricted Project, Restricted Project, Restricted Project
danielkiss updated the diff for D135652: [AArch64] Add preserve_all calling convention..

update docs.

Oct 13 2022, 1:27 PM · Restricted Project, Restricted Project, Restricted Project
danielkiss updated the diff for D135652: [AArch64] Add preserve_all calling convention..

To accommodate better to the vector ABI, AAPCS the vector parameter registers are not preserved by the callee but save the whole vector registers.

Oct 13 2022, 4:46 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss updated the diff for D133359: [AArch64] Make ACLE intrinsics always available part1.

MTE/TME parts are removed, they will get their own patch.

Oct 13 2022, 4:22 AM · Restricted Project, Restricted Project