- User Since
- Dec 3 2019, 7:48 AM (79 w, 5 d)
Thu, May 27
Seems it is fixed in 11.0.1 and trunk or at least I was not able to reproduce the crash, codegen looks fine.
Fri, May 21
LGTM just please run once more git clang-format HEAD^1 on the patch.
Thu, May 20
Wed, May 19
Tue, May 18
address review comments.
May 11 2021
May 10 2021
Adding a fronted flag and tests.
comdat is still the default, feels fine but I'm not sure.
May 7 2021
@jroelofs Thanks for the review, all addressed.
Sorry, do you mean the content of the libunwind/include/unwind.h ?
May 5 2021
Rebased, retested on ToT.
Wondering if AArch64InstrInfo::getOutliningType and the outline should do the same because it might emit PACIASP.
see the old change:
Apr 23 2021
Apr 21 2021
Ah, right. EMITBKEY should be a meta one but it seems as a problematic change.
Let's simplify this now and hope no other need to be added too.
Apr 15 2021
Apr 13 2021
see D99417, way different approach is needed to reduce the number of landing pads.
Apr 12 2021
Apr 8 2021
Mar 18 2021
Mar 15 2021
Mar 12 2021
Implementing the review comment.
Mar 11 2021
fix for lint
The current think is that the unstripped value of the return addresses is not too problematic.
Let's keep it simple now.
Mar 10 2021
Mar 9 2021
Storing the PAC protected return addresses sounds safer because the values in trace can't be used directly as jump addresses. Assuming some might use sanitisers in production.
Keep the PAC in the stack trace and only strip it when necessary like comparing traces, looking up symbols.
Moved the strip to the sanitizer_ptrauth.h.
Mar 5 2021
Mar 4 2021
Feb 17 2021
Could you add [libunwind] to the beginning of title?
but otherwise LGTM as the author of the corresponding dwarf spec change.
Feb 15 2021
Feb 8 2021
Reenables tests ( revert of a4fa667dee60 )
Feb 4 2021
@MaskRay Thanks for the test case.
Feb 2 2021
Jan 20 2021
rebased, fixed my own comments.
Dec 17 2020
No problem at all.
Is there a reason why assembly files have a different flag (i.e. -mmark-bti-property) to create the .note.gnu.property with the BTI entry?
The .note.gnu.property is already generated when C/C++ files are compiled with -mbranch-protection=bti.
-mmark-bti-property is only for assembly file where the .note.gnu.property should be added manually otherwise.
Dec 16 2020
@manojgupta Thanks for the feedback, let me know if you have updates.
Dec 10 2020
Dec 3 2020
unwind_leaffunction.pass.cpp could be enable too for aarch64.
Dec 2 2020
Nov 17 2020
Nov 11 2020
Nov 10 2020
Done see: D91182
Nov 9 2020
Nov 5 2020
Nov 2 2020
Oct 30 2020
Oct 29 2020
https://bugs.llvm.org/show_bug.cgi?id=47142 this effects this. the missing unwind info make forceunwind fragile.
Oct 26 2020
self.cxx has a function to test compiler flags addFlagIfSupported but there is no support for linker flag (yet).
rebase, add MINGW32
Oct 19 2020
Oct 17 2020
Add a simple test and fixes.
This version passes on arm32 - armv7l-unknown-linux-gnueabihf -
Oct 16 2020
_Unwind_Stop_Fn shall not have different signature for EHABI.