Page MenuHomePhabricator

danielkiss (Daniel Kiss)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2019, 7:48 AM (135 w, 1 d)

Recent Activity

Tue, Jul 5

danielkiss accepted D129135: [doc][ReleaseNotes] Document AArch64 SVE ABI fix from D127209.

LGTM

Tue, Jul 5, 2:44 AM · Restricted Project, Restricted Project

Tue, Jun 28

danielkiss added a comment to D127812: [AArch64] Function multiversioning support added..

Your understanding is correct. target attribute has two usage model. One is just redefine the to be used codegen options, this is used already widely for Arm and AArch64. The other use of the target attribute is the multi versioning and the rational for the target_version attribute is the easier distinction between the two usage mode, also not to break any code out there by changing the behaviour of an attribute.

I don't think differentiating the uses here is a good idea. I think it would have been a GREAT idea about 10 years ago, but that ship has already sailed once GCC started using it that way however. We should be keeping the current behavior, otherwise we're going to have a horrible mix of target/target_version working inconsistently between platforms.

That largely is my concern as well. The existing behavior of target is just that -- the existing behavior. I think deviating from that existing behavior will be confusing in practice. Adding additional attributes doesn't improve that confusion because users then have to know to decide between two very similar attributes, which means they then need to educate themselves on the differences between them. If we're going to push them towards the documentation to correctly use the attribute anyway, that's basically the same situation they're in today with the confusing dual behavior of target.

Tue, Jun 28, 12:53 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mon, Jun 27

danielkiss accepted D128522: [libunwind,EHABI,ARM] Fix get/set of RA_AUTH_CODE..

LGTM.

Mon, Jun 27, 1:25 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 22

danielkiss added a comment to D127812: [AArch64] Function multiversioning support added..

I'm concerned as to the design of this addition, I don't particularly appreciate the reasons for making 'target_clones' different, nor the purpose for adding a new attribute instead of using 'target' for what seems like exactly that? IF the new spelling is THAT necessary, we perhaps don't need a whole new attribute for it either.

Thank you for fair concern, "target_clones" for AArch64 has different format, semantic, e.g. "default" is not required. Therefore it diverges with X86 in these parts.

Is it *necessary* that it diverges like this? (Is there some published standards document you're trying to conform to, is there an implementation difficulty with not diverging, something else?)

Wed, Jun 22, 5:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sat, Jun 11

danielkiss added a comment to D102912: [libunwind] AARCH64 use inline assembly for pointer authentication.

Patch is only needed due to a clang bug which is fixed already in 11.x releases and TOT. For me the original code looks better and I don't see the need for the patch but I let other from the @libunwind group to disagree with me.

Sat, Jun 11, 3:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
danielkiss added a comment to D123493: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET.

This behavior requires that all participating modules have the module flag. In the absence of the module flag, what should be behavior be?

For module flags like "sign-return-address", I see that you just emit the flag unconditionally (which can be zero).

Absence of the "branch-target-enforcement" and "sign-return-address"` means features are off. So the flag merger will take an existing flag and the feature could be turned on, which is bad.
AutoUpdater should insert the attributes with zero value if they are missing.

Sat, Jun 11, 3:25 PM · Restricted Project, Restricted Project, Restricted Project

May 20 2022

danielkiss added a comment to D123692: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE..

c218fd3d7d3764eb123c8429bbcd33bacfe2e633 added libcxxabi/test/native/AArch64/ra_sign_state.pass.cpp -- was that intended, or should it have been added to libunwind/test/[...]? It also started failing in the CI in the -fno-exceptions configuration -- I think it is just missing a XFAIL so I'll add it, but please investigate whether the file needs to be moved (I think it does).

Tests in libunwind can't depend on libcxx (failed in llvm-libunwind-static.cfg.in) so the test is moved to libcxxabi, because test test case needs exception. (simple backtrace won't trigger the problem)

May 20 2022, 7:11 AM · Restricted Project, Restricted Project, Restricted Project

May 19 2022

Herald added a project to D82745: [ThinLto] Fix Ifunc symbol usage: Restricted Project.
May 19 2022, 10:38 AM · Restricted Project, Restricted Project
danielkiss added inline comments to D123692: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE..
May 19 2022, 12:44 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss committed rGd3a6f5739130: [libunwind] Remove -Wsign-conversion warning (authored by danielkiss).
[libunwind] Remove -Wsign-conversion warning
May 19 2022, 12:42 AM · Restricted Project

May 18 2022

danielkiss committed rGc218fd3d7d37: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE. (authored by danielkiss).
[libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE.
May 18 2022, 9:02 AM · Restricted Project

May 15 2022

danielkiss added a comment to D123692: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE..

Hi @danielkiss,

the FAIL: llvm-libunwind-static.cfg.in:: aarch64.ra_sign_state.pass.cpp test is getting failed on Linux Ubuntu/Aarch64 toolchain builders with the following output:

terminate called after throwing an instance of 'int'
terminate called recursively

here is more details: https://lab.llvm.org/buildbot/#/builders/119/builds/8501/steps/12/logs/FAIL__llvm-libunwind-static_cfg_in___aarch64_ra_si

https://lab.llvm.org/buildbot/#/builders/119/builds/8501

May 15 2022, 12:44 PM · Restricted Project, Restricted Project, Restricted Project

May 13 2022

danielkiss committed rGf6366ef7f4f3: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE. (authored by danielkiss).
[libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE.
May 13 2022, 1:06 AM · Restricted Project
danielkiss closed D123692: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE..
May 13 2022, 1:06 AM · Restricted Project, Restricted Project, Restricted Project

May 5 2022

danielkiss added a comment to D123692: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE..

@MaskRay thanks so much.

May 5 2022, 2:08 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss updated the diff for D123692: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE..
May 5 2022, 2:06 AM · Restricted Project, Restricted Project, Restricted Project

May 4 2022

danielkiss added a comment to D123692: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE..

ping?

May 4 2022, 1:38 AM · Restricted Project, Restricted Project, Restricted Project

May 2 2022

danielkiss added a comment to D124765: [libunwind][SystemZ] Unwind out of signal handlers.

some tests from libcxxabi could be enabled for SystemZ too e.g. libcxxabi/test/forced*

May 2 2022, 5:57 AM · Restricted Project, Restricted Project, Restricted Project

Apr 29 2022

danielkiss added inline comments to D124522: [libunwind][AArch64] Fix _Unwind_ForcedUnwind via sigreturn..
Apr 29 2022, 12:47 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss committed rG6830ebb07eb9: Disable test for Android/Bionic. (authored by danielkiss).
Disable test for Android/Bionic.
Apr 29 2022, 12:47 AM · Restricted Project

Apr 28 2022

danielkiss committed rGf326df34bc17: [libunwind][AArch64] Fix _Unwind_ForcedUnwind via sigreturn. (authored by danielkiss).
[libunwind][AArch64] Fix _Unwind_ForcedUnwind via sigreturn.
Apr 28 2022, 9:42 AM · Restricted Project
danielkiss closed D124522: [libunwind][AArch64] Fix _Unwind_ForcedUnwind via sigreturn..
Apr 28 2022, 9:42 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss updated the diff for D124522: [libunwind][AArch64] Fix _Unwind_ForcedUnwind via sigreturn..
Apr 28 2022, 12:58 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss updated the diff for D124522: [libunwind][AArch64] Fix _Unwind_ForcedUnwind via sigreturn..
Apr 28 2022, 12:45 AM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2022

danielkiss added reviewers for D123692: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE.: MaskRay, ldionne, mstorsjo.
Apr 27 2022, 8:00 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss requested review of D124522: [libunwind][AArch64] Fix _Unwind_ForcedUnwind via sigreturn..
Apr 27 2022, 5:22 AM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2022

danielkiss committed rGde07cde67b5d: [AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions. (authored by danielkiss).
[AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions.
Apr 22 2022, 4:26 AM · Restricted Project, Restricted Project
danielkiss closed D111780: [AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions..
Apr 22 2022, 4:26 AM · Restricted Project, Restricted Project
danielkiss added a comment to D111780: [AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions..

Can this change be taken into consideration again now that D114545 has been merged?

Yes, I'm running a few tests, will land later today.

Apr 22 2022, 12:25 AM · Restricted Project, Restricted Project

Apr 14 2022

danielkiss added a comment to D123394: [CodeGen] Late cleanup of redundant address/immediate definitions..

I have looked at AArch64/Arm tests.
These are okay due to just Codegen is improved here:
llvm/test/CodeGen/AArch64/framelayout-sve.mir
llvm/test/CodeGen/AArch64/strict-fp-int-promote.ll
llvm/test/CodeGen/AArch64/sve-calling-convention-mixed.ll
llvm/test/CodeGen/AArch64/sve-ld1r.mir
llvm/test/CodeGen/AArch64/sve-ldstnt1.mir
llvm/test/CodeGen/ARM/arm-shrink-wrapping.ll
llvm/test/CodeGen/ARM/reg_sequence.ll
llvm/test/CodeGen/ARM/machine-outliner-calls.mir
llvm/test/CodeGen/ARM/jump-table-islands.ll
llvm/test/CodeGen/ARM/ifcvt-branch-weight-bug.ll
llvm/test/CodeGen/Thumb2/mve-vst4.ll
llvm/test/CodeGen/Thumb2/mve-fpclamptosat_vec.ll

Apr 14 2022, 7:39 AM · Restricted Project, Restricted Project

Apr 13 2022

danielkiss requested review of D123692: [libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE..
Apr 13 2022, 10:28 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss committed rGb0343a38a591: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET (authored by danielkiss).
Support the min of module flags when linking, use for AArch64 BTI/PAC-RET
Apr 13 2022, 12:32 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss closed D123493: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET.
Apr 13 2022, 12:32 AM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2022

danielkiss updated the diff for D123493: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET.

Thanks, test is added.

Apr 12 2022, 2:01 PM · Restricted Project, Restricted Project, Restricted Project
danielkiss updated the diff for D123493: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET.

Can we add logic to llvm/lib/IR/AutoUpgrade.cpp to change Error to Min if we see one of these module flags? I think that should allow old bitcode to continue working.

Apr 12 2022, 9:47 AM · Restricted Project, Restricted Project, Restricted Project

Apr 11 2022

danielkiss updated the diff for D123493: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET.
Apr 11 2022, 5:40 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss added a comment to D123493: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET.

This would silently reduce protection, when incompatible modules are linked?

Yes, but that happens also with the normal linker too by default.

Apr 11 2022, 5:29 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss requested review of D123493: Support the min of module flags when linking, use for AArch64 BTI/PAC-RET.
Apr 11 2022, 3:34 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss added a comment to D123428: [libunwind] Add configuration to disable sigreturn frame check.

Thanks for the patch.

Apr 11 2022, 1:44 AM · Restricted Project, Restricted Project, Restricted Project

Mar 21 2022

danielkiss accepted D121707: [llvm][AArch64] Insert "bti j" after call to setjmp.

Add to the commit message Fixes #48888 to make the connection on github.

Mar 21 2022, 2:14 AM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2022

danielkiss accepted D121432: [ARM] __cxa_end_cleanup: avoid clobbering r4.

LGTM, thanks for the patch.

Mar 11 2022, 1:57 AM · Restricted Project, Restricted Project

Mar 8 2022

danielkiss added inline comments to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Mar 8 2022, 5:31 AM · Restricted Project, Restricted Project, Restricted Project

Mar 4 2022

danielkiss added inline comments to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Mar 4 2022, 12:34 PM · Restricted Project, Restricted Project, Restricted Project

Feb 24 2022

danielkiss accepted D114545: [CodeGen] Async unwind - add a pass to fix CFI information.

LGMT

Feb 24 2022, 11:03 AM · Restricted Project, Restricted Project
danielkiss added a comment to D112330: [AArch64] Async unwind - function epilogues.

LGTM

Feb 24 2022, 10:56 AM · Restricted Project, Restricted Project
danielkiss accepted D111411: [AArch64] Async unwind - function prologues.
Feb 24 2022, 10:36 AM · Restricted Project, Restricted Project

Feb 14 2022

danielkiss added a comment to D114545: [CodeGen] Async unwind - add a pass to fix CFI information.

Could you please rebase the series? it generated a lot of conflict for me.
the generated directives in the tests are looking good.

Feb 14 2022, 10:54 AM · Restricted Project, Restricted Project

Feb 4 2022

danielkiss accepted D112328: [AArch64] Async unwind - Always place the first LDP at the end when ReverseCSRRestoreSeq is true .

LGTM

Feb 4 2022, 3:16 AM · Restricted Project

Feb 1 2022

danielkiss added inline comments to D108416: [llvm-libgcc] initial commit.
Feb 1 2022, 3:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 28 2022

danielkiss added a comment to D108416: [llvm-libgcc] initial commit.

Thanks for update.

Jan 28 2022, 7:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 6 2022

danielkiss added a comment to D111780: [AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions..

This causes unwind problems when landing pads of the exception handlers involved, because for those the .cfi_negate_ra_state is processed twice and the signature from the return address is not stripped but should be.
Let's reland after D114545.

Jan 6 2022, 10:22 AM · Restricted Project, Restricted Project
danielkiss added a reverting change for rGf903c8505515: [AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions.: rG131c06e6da79: Revert "[AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions.".
Jan 6 2022, 10:19 AM
danielkiss committed rG131c06e6da79: Revert "[AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions." (authored by danielkiss).
Revert "[AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions."
Jan 6 2022, 10:18 AM
danielkiss added a reverting change for D111780: [AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions.: rG131c06e6da79: Revert "[AArch64] Emit .cfi_negate_ra_state for PAC-auth instructions.".
Jan 6 2022, 10:18 AM · Restricted Project, Restricted Project

Dec 16 2021

danielkiss committed rG2b4e6052b3bf: [lld] Add cet-report and bti-report flags (authored by danielkiss).
[lld] Add cet-report and bti-report flags
Dec 16 2021, 7:26 AM
danielkiss closed D113901: [lld] Add cet-report and bti-report flags.
Dec 16 2021, 7:26 AM · Restricted Project
danielkiss updated the diff for D113901: [lld] Add cet-report and bti-report flags.

Out of town for ~10 days. Sorry for the long delay.
LGTM.

Not a problem, thanks!

Dec 16 2021, 7:15 AM · Restricted Project
danielkiss accepted D103626: [lldb] Remove non address bits from memory read arguments.

Maybe this is something worth considering for LLDB memory dumps?

I'm working on that at the moment, it's on my github branch. This is what it looks like with the right options: (others look weird at the moment due to ordering issues)

(lldb) memory read mte_buf mte_buf+32 -f "x" -l 1 -s 16
0xfffff7ff6000: 0x00000000000000000000000000000000 (tag: 0x0)
0xfffff7ff6010: 0x00000000000000000000000000000000 (tag: 0x1)

The format is mostly a guess on my part, given that I'm mostly testing the debugger itself not MTE enabled software.

That looks really good, could help a lot to understand tagging related issues. Looking forward for that patch :)

Dec 16 2021, 4:40 AM · Restricted Project, Restricted Project

Dec 13 2021

danielkiss added a comment to D113901: [lld] Add cet-report and bti-report flags.

ping?

Dec 13 2021, 8:51 AM · Restricted Project

Dec 10 2021

danielkiss added inline comments to D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures.
Dec 10 2021, 5:49 AM · Restricted Project, Restricted Project

Dec 8 2021

danielkiss accepted D112432: [ARM][libcxxabi] Add PACBTI-M support to libcxxabi.

Thanks for the rebase, LGTM

Dec 8 2021, 1:19 AM · Restricted Project

Dec 7 2021

danielkiss accepted D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT.

@danielkiss Yes that needs to be addressed, but we are doing that in another patch that will (hopefully) cover all permutations of architecture and branch protection values on both the cmdline and as function attributes.

sound good, Thanks!

Dec 7 2021, 10:35 AM · Restricted Project

Dec 6 2021

danielkiss added a comment to D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT.

I think rejecting\warning the b-key from the command line maybe a more developer friendly way.

Dec 6 2021, 4:31 AM · Restricted Project

Dec 3 2021

danielkiss accepted D114818: [libunwind] Fix unwind_leaffunction test.

Thanks for the update. LGTM.

Dec 3 2021, 12:56 AM · Restricted Project, Restricted Project

Dec 2 2021

danielkiss added inline comments to D114818: [libunwind] Fix unwind_leaffunction test.
Dec 2 2021, 7:14 AM · Restricted Project, Restricted Project

Dec 1 2021

danielkiss abandoned D111290: [libunwind] Fix test execution..

fixed in other changes.

Dec 1 2021, 3:42 AM
danielkiss requested changes to D112432: [ARM][libcxxabi] Add PACBTI-M support to libcxxabi.

Cloud you please rebase this patch? there were a few changes to __cxa_end_cleanup recently.

Dec 1 2021, 3:02 AM · Restricted Project
danielkiss accepted D114818: [libunwind] Fix unwind_leaffunction test.

Do we need to apply __attribute__((noinline)) to main? Can you try that out and let me know if that helps?

Clang automatically adds noinline to main.

Dec 1 2021, 2:02 AM · Restricted Project, Restricted Project

Nov 30 2021

danielkiss added inline comments to D114385: [libunwind] Fix testing with sanitizers enabled.
Nov 30 2021, 8:47 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss added inline comments to D114385: [libunwind] Fix testing with sanitizers enabled.
Nov 30 2021, 8:43 AM · Restricted Project, Restricted Project, Restricted Project
danielkiss added inline comments to D114385: [libunwind] Fix testing with sanitizers enabled.
Nov 30 2021, 1:06 AM · Restricted Project, Restricted Project, Restricted Project

Nov 29 2021

danielkiss updated the summary of D113901: [lld] Add cet-report and bti-report flags.
Nov 29 2021, 5:38 AM · Restricted Project
danielkiss updated the diff for D113901: [lld] Add cet-report and bti-report flags.
Nov 29 2021, 5:29 AM · Restricted Project

Nov 26 2021

danielkiss accepted D112429: [ARM] Implement PAC return address signing mechanism for PACBTI-M.

LGTM besides NITs.
Could you make clang-format happy?

Nov 26 2021, 9:01 AM · Restricted Project, Restricted Project
danielkiss updated the summary of D112429: [ARM] Implement PAC return address signing mechanism for PACBTI-M.
Nov 26 2021, 8:59 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D113901: [lld] Add cet-report and bti-report flags.
Nov 26 2021, 7:35 AM · Restricted Project
danielkiss added inline comments to D113901: [lld] Add cet-report and bti-report flags.
Nov 26 2021, 7:05 AM · Restricted Project
danielkiss updated the diff for D113901: [lld] Add cet-report and bti-report flags.
Nov 26 2021, 7:04 AM · Restricted Project
danielkiss updated the diff for D113901: [lld] Add cet-report and bti-report flags.
Nov 26 2021, 7:01 AM · Restricted Project
danielkiss updated the diff for D113901: [lld] Add cet-report and bti-report flags.
Nov 26 2021, 6:55 AM · Restricted Project
danielkiss committed rG632acec73776: [libunwind][ARM] Handle end of stack during unwind (authored by danielkiss).
[libunwind][ARM] Handle end of stack during unwind
Nov 26 2021, 4:27 AM
danielkiss closed D109856: [libunwind][ARM] Handle end of stack during unwind.
Nov 26 2021, 4:26 AM · Restricted Project, Restricted Project
danielkiss added a comment to D109856: [libunwind][ARM] Handle end of stack during unwind.

Looks reasonable I think. Is this a deficiency in the EHABI implementation only, i.e. this aspect works as it should in the regular dwarf implementation?

Yes, it works on dwarf already ( also the test pass on X86/Aarch64 ).

Nov 26 2021, 2:48 AM · Restricted Project, Restricted Project

Nov 24 2021

danielkiss updated the diff for D113901: [lld] Add cet-report and bti-report flags.

Hopefully later other reports like lam-report can be added easier.

Nov 24 2021, 11:13 AM · Restricted Project

Nov 23 2021

danielkiss updated subscribers of D109856: [libunwind][ARM] Handle end of stack during unwind.
Nov 23 2021, 4:06 AM · Restricted Project, Restricted Project
danielkiss added a comment to D109856: [libunwind][ARM] Handle end of stack during unwind.

Ping

Nov 23 2021, 4:04 AM · Restricted Project, Restricted Project

Nov 18 2021

danielkiss added a comment to D113901: [lld] Add cet-report and bti-report flags.

-z force-bti with -Werror has the same behaviour but not always possible to use -Werror and dangerous to rely on it.

GCC/Clang support -Werror. ld.bfd/gold/ld.lld support --fatal-warnings.

I'm in favour of adding the additional flag. It is useful when an effort has been made to get all input files marked, and we want to make sure that the program stays that way. I think that complements the existing force-bti flag which is useful when transitioning a program into compatibility.

One thought is that this could also be useful for ibt. Is there scope for -z fail-if-not=bti and -z fail-if-not=ibt which might make this more extensible for future property flags?

Does this have the same semantics as -z cet-report=error? (https://bugs.llvm.org/show_bug.cgi?id=45483)
If yes, we can use a similar tri-state option.

It does look very similar, the -z cet-report=error also includes a warning state, whereas -z fail-if-not=bti only has an error state. Will have to let Daniel comment on that.

Nov 18 2021, 12:40 AM · Restricted Project

Nov 17 2021

danielkiss updated subscribers of D109254: [AArch64] Enable CFIInstrInserter.
Nov 17 2021, 8:45 AM · Restricted Project, Restricted Project

Nov 16 2021

danielkiss accepted D112423: [ARM] add common parts for PACBTI-M support in the backend.

LGTM

Nov 16 2021, 12:24 AM · Restricted Project
danielkiss requested changes to D102912: [libunwind] AARCH64 use inline assembly for pointer authentication.

I think we can drop this change.

Nov 16 2021, 12:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 15 2021

danielkiss requested review of D113901: [lld] Add cet-report and bti-report flags.
Nov 15 2021, 7:53 AM · Restricted Project
danielkiss accepted D112430: [ARM][libunwind] add PACBTI-M support for libunwind.

LGTM, Thanks.

Nov 15 2021, 7:43 AM · Restricted Project, Restricted Project

Nov 12 2021

danielkiss added inline comments to D51650: Implement target_clones multiversioning.
Nov 12 2021, 8:08 AM · Restricted Project

Nov 11 2021

danielkiss accepted D91087: [AArch64] Select PAC/PACGA for ptrauth.sign/sign_generic..

LGTM, any triplet could work here, where it matters we can add a new RUN line with an other triplet.

Nov 11 2021, 12:08 PM · Restricted Project
danielkiss accepted D90868: [IR] Define @llvm.ptrauth intrinsics..

LGTM, I'm happy with the current state.

Nov 11 2021, 12:01 PM · Restricted Project
danielkiss added reviewers for D109856: [libunwind][ARM] Handle end of stack during unwind: MaskRay, compnerd, mstorsjo.
Nov 11 2021, 7:18 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D109856: [libunwind][ARM] Handle end of stack during unwind.
Nov 11 2021, 5:51 AM · Restricted Project, Restricted Project
danielkiss accepted D51650: Implement target_clones multiversioning.

But nit made.

NIT: clang-format issues still present. Maybe you need to update your local clang-format.

Nov 11 2021, 5:48 AM · Restricted Project
danielkiss updated the diff for D109856: [libunwind][ARM] Handle end of stack during unwind.

Make the CI happy.

Nov 11 2021, 1:25 AM · Restricted Project, Restricted Project
danielkiss accepted D113607: [libunwind][AIX] Mark signal_frame.pass.cpp UNSUPPORTED on AIX.
Nov 11 2021, 1:06 AM · Restricted Project, Restricted Project