Page MenuHomePhabricator

danielkiss (Daniel Kiss)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 3 2019, 7:48 AM (18 w, 2 d)

Recent Activity

Today

danielkiss added a reviewer for D77786: [AArch64] Add v8.5 Branch Target Identification support.: miyuki.
Thu, Apr 9, 2:41 AM · Restricted Project, Restricted Project
danielkiss added a comment to D77786: [AArch64] Add v8.5 Branch Target Identification support..

Please help me how to add a test for it, in the current state this patch won't do anything because the standard build for libunwind does not add -mbranch-protection=standard (or bti).

Thu, Apr 9, 2:40 AM · Restricted Project, Restricted Project
danielkiss created D77786: [AArch64] Add v8.5 Branch Target Identification support..
Thu, Apr 9, 2:40 AM · Restricted Project, Restricted Project

Yesterday

danielkiss added inline comments to D75181: [AArch64] Handle BTI/PAC in case of generated functions..
Wed, Apr 8, 2:08 PM · Restricted Project, Restricted Project
danielkiss updated the diff for D75044: [AArch64] __builtin_extract_return_addr for PAuth..

Rebased and address review comments.

Wed, Apr 8, 10:51 AM · Restricted Project, Restricted Project
danielkiss added inline comments to D75044: [AArch64] __builtin_extract_return_addr for PAuth..
Wed, Apr 8, 10:51 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D77565: [AArch64] Remove implicit landing pads..
Wed, Apr 8, 8:07 AM · Restricted Project

Mon, Apr 6

danielkiss created D77565: [AArch64] Remove implicit landing pads..
Mon, Apr 6, 9:44 AM · Restricted Project
danielkiss updated the diff for D75181: [AArch64] Handle BTI/PAC in case of generated functions..

Fix review comments from Tamas.

Mon, Apr 6, 8:06 AM · Restricted Project, Restricted Project

Fri, Apr 3

danielkiss updated the diff for D75044: [AArch64] __builtin_extract_return_addr for PAuth..

Rebased.

Fri, Apr 3, 3:11 PM · Restricted Project, Restricted Project
danielkiss updated the diff for D75181: [AArch64] Handle BTI/PAC in case of generated functions..

The patched is rebased and the hopefully the logic is now simpler.

Fri, Apr 3, 6:24 AM · Restricted Project, Restricted Project

Thu, Apr 2

danielkiss added inline comments to D75181: [AArch64] Handle BTI/PAC in case of generated functions..
Thu, Apr 2, 7:01 AM · Restricted Project, Restricted Project
danielkiss committed rG37ced5a57106: [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines (authored by danielkiss).
[clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines
Thu, Apr 2, 4:19 AM
danielkiss closed D77134: [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines.
Thu, Apr 2, 4:19 AM · Restricted Project
danielkiss committed rG7314aea5a42d: [clang] Move branch-protection from CodeGenOptions to LangOptions (authored by danielkiss).
[clang] Move branch-protection from CodeGenOptions to LangOptions
Thu, Apr 2, 1:36 AM
danielkiss closed D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions.
Thu, Apr 2, 1:36 AM · Restricted Project

Wed, Apr 1

danielkiss added inline comments to D75181: [AArch64] Handle BTI/PAC in case of generated functions..
Wed, Apr 1, 2:43 AM · Restricted Project, Restricted Project
danielkiss edited reviewers for D75044: [AArch64] __builtin_extract_return_addr for PAuth., added: chill; removed: momchil.velikov.
Wed, Apr 1, 1:44 AM · Restricted Project, Restricted Project

Tue, Mar 31

danielkiss added a comment to D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions.

just a nit, LGTM otherwise.

Tue, Mar 31, 4:23 AM · Restricted Project

Mon, Mar 30

danielkiss added inline comments to D77044: Extend max register size to accommodate AArch64 SVE vector regs.
Mon, Mar 30, 7:00 AM
danielkiss added a comment to D75181: [AArch64] Handle BTI/PAC in case of generated functions..

ping

Mon, Mar 30, 5:55 AM · Restricted Project, Restricted Project

Fri, Mar 20

danielkiss added reviewers for D75181: [AArch64] Handle BTI/PAC in case of generated functions.: peter.smith, srhines, nickdesaulniers.
Fri, Mar 20, 4:18 PM · Restricted Project, Restricted Project
danielkiss added reviewers for D75044: [AArch64] __builtin_extract_return_addr for PAuth.: nickdesaulniers, srhines, peter.smith.
Fri, Mar 20, 4:18 PM · Restricted Project, Restricted Project

Fri, Mar 13

danielkiss updated the diff for D75181: [AArch64] Handle BTI/PAC in case of generated functions..

Patch is rebased, test is updated.

Fri, Mar 13, 6:55 AM · Restricted Project, Restricted Project

Mar 5 2020

danielkiss committed rG11ab687c6601: [AArch64] Harmonize print format of hint instructions. (authored by danielkiss).
[AArch64] Harmonize print format of hint instructions.
Mar 5 2020, 6:36 AM
danielkiss closed D75625: [AArch64] Harmonize print format of hint instructions..
Mar 5 2020, 6:35 AM · Restricted Project

Mar 4 2020

danielkiss added reviewers for D75625: [AArch64] Harmonize print format of hint instructions.: pbarrio, LukeCheeseman, vsk.
Mar 4 2020, 10:07 AM · Restricted Project
danielkiss created D75625: [AArch64] Harmonize print format of hint instructions..
Mar 4 2020, 10:05 AM · Restricted Project
danielkiss updated the diff for D75181: [AArch64] Handle BTI/PAC in case of generated functions..
Mar 4 2020, 10:05 AM · Restricted Project, Restricted Project
danielkiss added inline comments to D75181: [AArch64] Handle BTI/PAC in case of generated functions..
Mar 4 2020, 9:32 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D75181: [AArch64] Handle BTI/PAC in case of generated functions..

Thanks for the comments, patch is improved
isStringAttribute() check removed, the attribute is always a string in this case or "null" so the check is not needed.
Function level the attribute is now only change when needed, so as the function level attribute is expected to be rare I hope the performance won't be impacted by the patch.
I kept the "tri-state" logic because of the emitted functions. Introducing a "branch-target-enforcement-disabled" attribute seems even more confusing for me.

Mar 4 2020, 9:32 AM · Restricted Project, Restricted Project

Feb 28 2020

danielkiss updated the diff for D75181: [AArch64] Handle BTI/PAC in case of generated functions..

Previous version of the patch handled only the functions that are created in clang. Sanitizers can't see the codegen options therefore they also disables BTI.
This version of the patch is less invasive in my opinion, effects only aarch64.
branch-target-enforcement(BTI) and sign-return-address(PAC) are added to all function that comes from clang frontend.
If the backend encounters with the function without BTI attribute but the module is compiled with BTI then it assumes it should be made BTI compatible.

Feb 28 2020, 3:24 AM · Restricted Project, Restricted Project

Feb 26 2020

danielkiss created D75181: [AArch64] Handle BTI/PAC in case of generated functions..
Feb 26 2020, 7:46 AM · Restricted Project, Restricted Project
danielkiss added reviewers for D75044: [AArch64] __builtin_extract_return_addr for PAuth.: momchil.velikov, nsz.
Feb 26 2020, 6:04 AM · Restricted Project, Restricted Project
danielkiss updated the diff for D75044: [AArch64] __builtin_extract_return_addr for PAuth..

rebased and test is updated.

Feb 26 2020, 5:49 AM · Restricted Project, Restricted Project

Feb 25 2020

danielkiss added inline comments to D75044: [AArch64] __builtin_extract_return_addr for PAuth..
Feb 25 2020, 5:00 AM · Restricted Project, Restricted Project

Feb 24 2020

danielkiss created D75044: [AArch64] __builtin_extract_return_addr for PAuth..
Feb 24 2020, 5:10 AM · Restricted Project, Restricted Project

Feb 20 2020

danielkiss committed rG14d7b802db4f: [LLD][ELF][ARM] Add test cases for R_ARM_THM_MOV*-type relocs (authored by tamas.petz).
[LLD][ELF][ARM] Add test cases for R_ARM_THM_MOV*-type relocs
Feb 20 2020, 1:06 AM
danielkiss closed D74827: [LLD][ELF][ARM] Add test cases for R_ARM_THM_MOV*-type relocs.
Feb 20 2020, 1:06 AM · lld, Restricted Project

Feb 18 2020

danielkiss committed rGb6162622c054: [LLD][ELF][AArch64] Change the semantics of -z pac-plt. (authored by danielkiss).
[LLD][ELF][AArch64] Change the semantics of -z pac-plt.
Feb 18 2020, 1:01 AM
danielkiss closed D74537: [LLD][ELF][AArch64] Change the semantics of -z pac-plt..
Feb 18 2020, 1:01 AM · Restricted Project

Feb 17 2020

danielkiss added a comment to D74537: [LLD][ELF][AArch64] Change the semantics of -z pac-plt..

Could you submit it on my behalf?

Feb 17 2020, 12:31 AM · Restricted Project

Feb 16 2020

danielkiss updated the diff for D74537: [LLD][ELF][AArch64] Change the semantics of -z pac-plt..

Rebased to 105a270028ab and rename pacPlt to zPacPlt is applied.

Feb 16 2020, 9:06 AM · Restricted Project

Feb 15 2020

danielkiss added inline comments to D74537: [LLD][ELF][AArch64] Change the semantics of -z pac-plt..
Feb 15 2020, 2:19 AM · Restricted Project

Feb 14 2020

danielkiss updated the diff for D74537: [LLD][ELF][AArch64] Change the semantics of -z pac-plt..
Feb 14 2020, 7:00 AM · Restricted Project
danielkiss accepted rG105a270028ab: [ELF][AArch64] Rename pacPlt to zPacPlt and forceBti to zForceIbt after D71327..

LGTM

Feb 14 2020, 6:23 AM

Feb 13 2020

danielkiss added inline comments to D74537: [LLD][ELF][AArch64] Change the semantics of -z pac-plt..
Feb 13 2020, 8:24 AM · Restricted Project
danielkiss created D74537: [LLD][ELF][AArch64] Change the semantics of -z pac-plt..
Feb 13 2020, 2:30 AM · Restricted Project
danielkiss added a comment to D74492: [AArch64] Fix BTI landing pad generation..

I don't have commit right, could you please commit it on my behalf?

Feb 13 2020, 2:21 AM · Restricted Project
danielkiss updated the diff for D74492: [AArch64] Fix BTI landing pad generation..
Feb 13 2020, 12:59 AM · Restricted Project

Feb 12 2020

danielkiss created D74492: [AArch64] Fix BTI landing pad generation..
Feb 12 2020, 8:51 AM · Restricted Project

Jan 20 2020

danielkiss updated the diff for D71761: [lldb] Add a setting to not install the main executable.

Patch is rebased due to conflict with the upstream changes.

Jan 20 2020, 9:49 AM · Restricted Project

Jan 14 2020

danielkiss added a comment to D71761: [lldb] Add a setting to not install the main executable.

Thanks for the review, I have no push rights, could you please submit it on my behalf?

Jan 14 2020, 4:09 AM · Restricted Project

Jan 13 2020

danielkiss added reviewers for D71761: [lldb] Add a setting to not install the main executable: labath, clayborg.
Jan 13 2020, 8:12 AM · Restricted Project

Dec 20 2019

danielkiss created D71761: [lldb] Add a setting to not install the main executable.
Dec 20 2019, 6:38 AM · Restricted Project