User Details
- User Since
- Dec 3 2019, 7:48 AM (135 w, 1 d)
Tue, Jul 5
LGTM
Tue, Jun 28
Mon, Jun 27
LGTM.
Wed, Jun 22
Sat, Jun 11
Patch is only needed due to a clang bug which is fixed already in 11.x releases and TOT. For me the original code looks better and I don't see the need for the patch but I let other from the @libunwind group to disagree with me.
Absence of the "branch-target-enforcement" and "sign-return-address"` means features are off. So the flag merger will take an existing flag and the feature could be turned on, which is bad.
AutoUpdater should insert the attributes with zero value if they are missing.
May 20 2022
Tests in libunwind can't depend on libcxx (failed in llvm-libunwind-static.cfg.in) so the test is moved to libcxxabi, because test test case needs exception. (simple backtrace won't trigger the problem)
May 19 2022
May 18 2022
May 15 2022
May 13 2022
May 5 2022
@MaskRay thanks so much.
May 4 2022
ping?
May 2 2022
some tests from libcxxabi could be enabled for SystemZ too e.g. libcxxabi/test/forced*
Apr 29 2022
Apr 28 2022
Apr 27 2022
Apr 22 2022
Yes, I'm running a few tests, will land later today.
Apr 14 2022
I have looked at AArch64/Arm tests.
These are okay due to just Codegen is improved here:
llvm/test/CodeGen/AArch64/framelayout-sve.mir
llvm/test/CodeGen/AArch64/strict-fp-int-promote.ll
llvm/test/CodeGen/AArch64/sve-calling-convention-mixed.ll
llvm/test/CodeGen/AArch64/sve-ld1r.mir
llvm/test/CodeGen/AArch64/sve-ldstnt1.mir
llvm/test/CodeGen/ARM/arm-shrink-wrapping.ll
llvm/test/CodeGen/ARM/reg_sequence.ll
llvm/test/CodeGen/ARM/machine-outliner-calls.mir
llvm/test/CodeGen/ARM/jump-table-islands.ll
llvm/test/CodeGen/ARM/ifcvt-branch-weight-bug.ll
llvm/test/CodeGen/Thumb2/mve-vst4.ll
llvm/test/CodeGen/Thumb2/mve-fpclamptosat_vec.ll
Apr 13 2022
Apr 12 2022
Thanks, test is added.
Apr 11 2022
Yes, but that happens also with the normal linker too by default.
Thanks for the patch.
Mar 21 2022
Add to the commit message Fixes #48888 to make the connection on github.
Mar 11 2022
LGTM, thanks for the patch.
Mar 8 2022
Mar 4 2022
Feb 24 2022
LGMT
LGTM
Feb 14 2022
Could you please rebase the series? it generated a lot of conflict for me.
the generated directives in the tests are looking good.
Feb 4 2022
LGTM
Feb 1 2022
Jan 28 2022
Thanks for update.
Jan 6 2022
This causes unwind problems when landing pads of the exception handlers involved, because for those the .cfi_negate_ra_state is processed twice and the signature from the return address is not stripped but should be.
Let's reland after D114545.
Dec 16 2021
Not a problem, thanks!
That looks really good, could help a lot to understand tagging related issues. Looking forward for that patch :)
Dec 13 2021
ping?
Dec 10 2021
Dec 8 2021
Thanks for the rebase, LGTM
Dec 7 2021
sound good, Thanks!
Dec 6 2021
I think rejecting\warning the b-key from the command line maybe a more developer friendly way.
Dec 3 2021
Thanks for the update. LGTM.
Dec 2 2021
Dec 1 2021
fixed in other changes.
Cloud you please rebase this patch? there were a few changes to __cxa_end_cleanup recently.
Clang automatically adds noinline to main.
Nov 30 2021
Nov 29 2021
Nov 26 2021
LGTM besides NITs.
Could you make clang-format happy?
Yes, it works on dwarf already ( also the test pass on X86/Aarch64 ).
Nov 24 2021
Hopefully later other reports like lam-report can be added easier.
Nov 23 2021
Ping
Nov 18 2021
Nov 17 2021
Nov 16 2021
LGTM
I think we can drop this change.
Nov 15 2021
LGTM, Thanks.
Nov 12 2021
Nov 11 2021
LGTM, any triplet could work here, where it matters we can add a new RUN line with an other triplet.
LGTM, I'm happy with the current state.
NIT: clang-format issues still present. Maybe you need to update your local clang-format.
Make the CI happy.