Page MenuHomePhabricator

[Alignment][NFC] Deprecate Align::None()
ClosedPublic

Authored by gchatelet on Jan 21 2020, 6:03 AM.

Details

Summary

This is a follow up on https://reviews.llvm.org/D71473#inline-647262.
There's a caveat here that Align(1) relies on the compiler understanding of Log2_64 implementation to produce good code. One could use Align() as a replacement but I believe it is less clear that the alignment is one in that case.

Diff Detail

Event Timeline

gchatelet created this revision.Jan 21 2020, 6:03 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
gchatelet updated this revision to Diff 240148.Fri, Jan 24, 3:44 AM
  • rebasing
courbet accepted this revision.Fri, Jan 24, 3:53 AM
This revision is now accepted and ready to land.Fri, Jan 24, 3:53 AM
This revision was automatically updated to reflect the committed changes.