Page MenuHomePhabricator

xbolva00 (Dávid Bolvanský)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2018, 5:18 PM (40 w, 5 d)

Recent Activity

Tue, Jan 1

xbolva00 added a comment to D49966: [X86] Performing DAG pruning before selection of LEA instructions..

https://godbolt.org/z/0ZOx52

Tue, Jan 1, 3:15 PM
xbolva00 added a comment to D49966: [X86] Performing DAG pruning before selection of LEA instructions..

Does this handle also e.g.

Tue, Jan 1, 2:51 AM

Mon, Dec 31

xbolva00 added a comment to D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case).

Ok, so create new revision with tests? Somebody will commit it for you.

Mon, Dec 31, 7:09 AM

Sun, Dec 30

xbolva00 committed rL350162: [NFC] Fixed extra semicolon warning.
[NFC] Fixed extra semicolon warning
Sun, Dec 30, 5:23 AM

Mon, Dec 24

xbolva00 added a reviewer for D56057: [X86] Individually simplify both operands of PMULDQ/PMULUDQ using the other entry point of SimplifyDemandedBits that allows the one use check of the root node to be suppressed.: chandlerc.
Mon, Dec 24, 3:01 AM

Fri, Dec 21

xbolva00 added reviewers for D53765: [RFC prototype] Implementation of asm-goto support in LLVM: hfinkel, efriedma, chandlerc.
Fri, Dec 21, 1:20 PM

Thu, Dec 20

xbolva00 added inline comments to D52002: Omit range checks from jump tables when lowering switches with unreachable default.
Thu, Dec 20, 5:23 AM

Dec 16 2018

xbolva00 added inline comments to D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Dec 16 2018, 1:24 PM

Dec 5 2018

xbolva00 added a comment to D55186: [eh-simplify] SelfReview.

Nice work!

Dec 5 2018, 2:39 PM

Nov 28 2018

xbolva00 requested review of D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Nov 28 2018, 2:58 PM
xbolva00 updated the diff for D52835: [Diagnostics] Check integer to floating point number implicit conversions.
  • Updated. Addressed review comments.
Nov 28 2018, 2:57 PM

Nov 25 2018

xbolva00 added inline comments to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Nov 25 2018, 11:35 AM

Nov 23 2018

xbolva00 added a comment to D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case).

Btw, why we do not this transformation on IR-level at first?

Nov 23 2018, 4:18 PM

Nov 22 2018

xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

I have no idea how to fix Clang side :/

Okay. Does that need to happen as a prerequisite to this patch?

Nov 22 2018, 7:25 AM
xbolva00 added inline comments to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Nov 22 2018, 1:48 AM

Nov 21 2018

xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

I have no idea how to fix Clang side :/

Nov 21 2018, 10:20 PM

Nov 20 2018

xbolva00 added inline comments to D54593: [X86] Fix PR39658: avoid duplicated successors in condibr merge.
Nov 20 2018, 4:37 PM

Nov 19 2018

xbolva00 added inline comments to D52653: [CodeGen, AArch64] Combine Interleaved Loads which are not covered by the Vectorizer.
Nov 19 2018, 10:39 AM

Nov 18 2018

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

I removed _Float16 related tests since some bots may fall with it, i dont know much about this custom type.
Anyway, It is fine on linux x86 64. I will restore them.

Nov 18 2018, 9:13 AM

Nov 17 2018

xbolva00 updated the diff for D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Addressed comments, fixed tests

Nov 17 2018, 5:30 AM

Nov 15 2018

xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Ping :)

Nov 15 2018, 4:53 AM
xbolva00 added a comment to D54571: [WebAssembly] Split BBs after throw instructions.

Sorry for little offtopic at first.

Nov 15 2018, 1:39 AM

Nov 14 2018

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Ok, I will address your comments soon.

Nov 14 2018, 6:31 AM
xbolva00 committed rL346866: Reverted D52835 to fix review comments.
Reverted D52835 to fix review comments
Nov 14 2018, 6:30 AM
xbolva00 committed rC346866: Reverted D52835 to fix review comments.
Reverted D52835 to fix review comments
Nov 14 2018, 6:30 AM
xbolva00 reopened D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Nov 14 2018, 6:30 AM
xbolva00 committed rL346865: [Diagnostics] Check integer to floating point number implicit conversions.
[Diagnostics] Check integer to floating point number implicit conversions
Nov 14 2018, 6:27 AM
xbolva00 committed rC346865: [Diagnostics] Check integer to floating point number implicit conversions.
[Diagnostics] Check integer to floating point number implicit conversions
Nov 14 2018, 6:27 AM
xbolva00 closed D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Nov 14 2018, 6:27 AM
xbolva00 accepted D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Nov 14 2018, 6:09 AM

Nov 12 2018

xbolva00 added a comment to D53706: [MultiTailCallElimination]: Pass to eliminate multiple tail calls.

Very interesting work!

Nov 12 2018, 6:56 AM

Nov 11 2018

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Since no futher comments, i think it is ok.
After day or two I will commit it.

Nov 11 2018, 7:46 AM

Nov 9 2018

xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Ping

Nov 9 2018, 1:26 PM

Nov 7 2018

xbolva00 added a comment to D53554: [Argument Promotion] Only promote args when function attributes are compatible.

@echristo wanted to look at this

Nov 7 2018, 10:28 AM
xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

@aaron.ballman

Nov 7 2018, 9:58 AM

Nov 6 2018

xbolva00 added a comment to D52109: [TwoAddressInstructionPass] Don't update SrcRegMap for copies inserted for tied register constraint when the src isn't killed.

Any benchmark results w/o this patch?

Nov 6 2018, 3:25 PM

Nov 5 2018

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Ping :)

Nov 5 2018, 1:28 AM

Nov 4 2018

xbolva00 added inline comments to rLLDB346093: NativeProcessProtocol: Simplify breakpoint setting code.
Nov 4 2018, 4:22 AM

Nov 3 2018

xbolva00 updated the diff for D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Nov 3 2018, 4:18 PM

Nov 1 2018

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Since I don't think we have any false positives here, maybe it would be useful to add it to -Wall or -Wextra?

Nov 1 2018, 9:48 AM
xbolva00 committed rC345847: [Diagnostics] Implement -Wsizeof-pointer-div .
[Diagnostics] Implement -Wsizeof-pointer-div
Nov 1 2018, 9:30 AM
xbolva00 committed rL345847: [Diagnostics] Implement -Wsizeof-pointer-div .
[Diagnostics] Implement -Wsizeof-pointer-div
Nov 1 2018, 9:30 AM
xbolva00 closed D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
Nov 1 2018, 9:29 AM
xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

maybe @aaron.ballman wants to take a look too

Nov 1 2018, 7:36 AM
xbolva00 added a comment to D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
  • Addressed review comments.
Nov 1 2018, 6:46 AM
xbolva00 updated the diff for D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
Nov 1 2018, 6:43 AM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Ping

Nov 1 2018, 1:56 AM

Oct 31 2018

xbolva00 added reviewers for D52835: [Diagnostics] Check integer to floating point number implicit conversions: aaron.ballman, efriedma.
Oct 31 2018, 2:14 PM
xbolva00 added a reviewer for D52949: [Diagnostics] Implement -Wsizeof-pointer-div : aaron.ballman.
Oct 31 2018, 2:14 PM
xbolva00 added a comment to D45444: [clang-tidy] implement new check for const-correctness.

Are you still looking at this?

Oct 31 2018, 12:33 PM
xbolva00 committed rLLDB345755: [NFC] Fixed -Wsign-compare warning.
[NFC] Fixed -Wsign-compare warning
Oct 31 2018, 11:06 AM
xbolva00 committed rL345755: [NFC] Fixed -Wsign-compare warning.
[NFC] Fixed -Wsign-compare warning
Oct 31 2018, 11:06 AM
xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Anything else to be done here? I would like to finish this patch to work on other things.

Oct 31 2018, 8:00 AM
xbolva00 updated the diff for D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
  • New warning text, added another test line
Oct 31 2018, 7:55 AM
xbolva00 committed rL345721: [DAGCombiner] Fold 0 div/rem X to 0.
[DAGCombiner] Fold 0 div/rem X to 0
Oct 31 2018, 7:22 AM
xbolva00 closed D52504: [DAGCombiner] Fold 0 div/rem X to 0.
Oct 31 2018, 7:22 AM
xbolva00 retitled D52504: [DAGCombiner] Fold 0 div/rem X to 0 from [DAGCombiner] Div/rem folds to [DAGCombiner] Fold 0 div/rem X to 0.
Oct 31 2018, 7:08 AM
xbolva00 added a comment to D52504: [DAGCombiner] Fold 0 div/rem X to 0.

Sanjay's changes don't seem to be rebased ?

Oct 31 2018, 6:44 AM
xbolva00 updated the diff for D52504: [DAGCombiner] Fold 0 div/rem X to 0.
Oct 31 2018, 6:44 AM
xbolva00 updated the diff for D53666: [Tests] Updated tests for D53342.
Oct 31 2018, 6:44 AM
xbolva00 updated the diff for D53666: [Tests] Updated tests for D53342.
Oct 31 2018, 6:43 AM
xbolva00 added inline comments to D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5).
Oct 31 2018, 6:30 AM

Oct 30 2018

xbolva00 updated the diff for D52504: [DAGCombiner] Fold 0 div/rem X to 0.
  • Rebased
Oct 30 2018, 3:18 PM
xbolva00 committed rL345665: [ARM][NFC] Make tests immune to better div optimizations.
[ARM][NFC] Make tests immune to better div optimizations
Oct 30 2018, 3:10 PM
xbolva00 closed D53901: [ARM][NFC] Make tests immune to better div optimizations.
Oct 30 2018, 3:10 PM
xbolva00 updated the diff for D53901: [ARM][NFC] Make tests immune to better div optimizations.
Oct 30 2018, 3:02 PM
xbolva00 added a comment to D52504: [DAGCombiner] Fold 0 div/rem X to 0.

Ok, https://reviews.llvm.org/D53901

Oct 30 2018, 2:55 PM
xbolva00 created D53901: [ARM][NFC] Make tests immune to better div optimizations.
Oct 30 2018, 2:54 PM
xbolva00 added a comment to D52949: [Diagnostics] Implement -Wsizeof-pointer-div .

Any ideas for better warning message? Except for the warning text, I see this patch as ready.

Oct 30 2018, 1:57 PM
xbolva00 updated the diff for D52504: [DAGCombiner] Fold 0 div/rem X to 0.
  • Rebased
Oct 30 2018, 10:30 AM
xbolva00 added a comment to D52949: [Diagnostics] Implement -Wsizeof-pointer-div .

Ping @MTC or @rsmith

Oct 30 2018, 2:21 AM
xbolva00 committed rL345575: [DAGCombiner] Improve X div/rem Y fold if single bit element type.
[DAGCombiner] Improve X div/rem Y fold if single bit element type
Oct 30 2018, 2:09 AM
xbolva00 closed D52668: [DAGCombiner] Improve X div/rem Y fold if single bit element type.
Oct 30 2018, 2:09 AM

Oct 28 2018

xbolva00 added a comment to D52668: [DAGCombiner] Improve X div/rem Y fold if single bit element type.

Ping

Oct 28 2018, 3:49 AM

Oct 25 2018

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

ping

Oct 25 2018, 3:12 PM

Oct 24 2018

xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Side idea:
From C function callsites with size arg we could theoretically determine some pointer aliasing info..

Oct 24 2018, 3:39 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
  • formatting fixes
Oct 24 2018, 3:24 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Oct 24 2018, 3:11 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
  • drop problematic nonnull attributes with unknown size arg
Oct 24 2018, 3:08 PM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Maybe we can also drop nonnull attributes for certain functions with size argument, here, in instcombine?

Oct 24 2018, 2:56 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
  • updated test file
Oct 24 2018, 1:25 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
  • Avoid marking if address spaces
Oct 24 2018, 1:21 PM
xbolva00 updated the diff for D53666: [Tests] Updated tests for D53342.
Oct 24 2018, 1:17 PM
xbolva00 added inline comments to D53666: [Tests] Updated tests for D53342.
Oct 24 2018, 1:15 PM
xbolva00 added a reviewer for D53666: [Tests] Updated tests for D53342: efriedma.
Oct 24 2018, 12:56 PM
xbolva00 retitled D53342: [SimplifyLibCalls] Mark known arguments with nonnull from [SimplifyLibCalls][WIP] Mark known arguments with nonnull to [SimplifyLibCalls] Mark known arguments with nonnull.
Oct 24 2018, 12:51 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
  • Tests updated
Oct 24 2018, 12:51 PM
xbolva00 created D53666: [Tests] Updated tests for D53342.
Oct 24 2018, 12:50 PM

Oct 23 2018

xbolva00 added a reviewer for D53419: [SourceMgr][FileCheck] Obey -color by extending WithColor: zturner.
Oct 23 2018, 2:19 PM
xbolva00 added a comment to D53534: [hot-cold-split] Name split functions with ".cold" suffix.

Does the pass groups hot code together? is it in your plans?

Oct 23 2018, 1:07 PM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Thanks @spatel, I missed it :(

Oct 23 2018, 12:50 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Oct 23 2018, 12:49 PM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

https://pastebin.com/8bxCuV5V + this patch
opt -instcombine p.ll -S

Oct 23 2018, 10:56 AM
xbolva00 updated the diff for D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
  • Added MTC's example case to test file
Oct 23 2018, 10:45 AM
xbolva00 added a comment to D52949: [Diagnostics] Implement -Wsizeof-pointer-div .

No warning for your case.

Oct 23 2018, 10:43 AM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Ping @spatel whether he has any idea why instcombine turns
define dso_local i32 @fff6(i8* nocapture readonly %s) local_unnamed_addr #5 {
entry:
%call = tail call i64 @strlen(i8* nonnull %s) #8
%conv = trunc i64 %call to i32
ret i32 %conv
}

Oct 23 2018, 10:27 AM

Oct 22 2018

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Ping

Oct 22 2018, 11:18 AM
xbolva00 added a comment to D52949: [Diagnostics] Implement -Wsizeof-pointer-div .

Ping

Oct 22 2018, 11:18 AM

Oct 19 2018

xbolva00 added inline comments to D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler and linker.
Oct 19 2018, 12:17 AM

Oct 18 2018

xbolva00 added a comment to D52668: [DAGCombiner] Improve X div/rem Y fold if single bit element type.

I reverted D50656 fix for pr38539 and pr38539.ll passed fine. So pr38539.ll tests nothing in the current trunk and it should not block this patch.

Oct 18 2018, 3:06 PM