User Details
- User Since
- Apr 5 2018, 5:18 PM (285 w, 2 d)
Sun, Sep 17
Yes, cc1 flag would be useful.
So we can start by giving these objects full-expression lifetime, chase down any program bugs that that uncovers (which will all *unquestionably* be program bugs under the standard), and then gradually work on landing the more aggressive rule (perhaps even for non-trivial types).
Wed, Sep 6
Will gcc use counted_by or element_count ?
Fri, Aug 25
Maybe mention https://github.com/llvm/llvm-project/issues/42210
Aug 24 2023
Aug 13 2023
Aug 8 2023
Do we again hit https://reviews.llvm.org/D102834?
This is serious, please fix or revert from release branches.
Aug 7 2023
Tests?
Jul 28 2023
Jul 18 2023
In my opinion it makes sense to adjust that kernel code based on this warning in the current inplementation state.
Jul 17 2023
You should add a testcase which uses “expected no diagnostics”.
We should not warn for macros.
Jul 16 2023
Jul 13 2023
Jul 12 2023
Not all tests are updated? X86/licm-nested.ll
It would be great to have reusable general algo with N as parameter.
fold -> expand? or inline?
Happy to see it!
Jul 11 2023
Jul 8 2023
efriedma:
(instcombine specifically won't work; for the sake of compile-time performance, we've forbidden instcombine from changing the cfg.)
Jul 5 2023
Jun 29 2023
Jun 28 2023
Jun 26 2023
whole struct would be probably better, less churn. Plus, can we static_assert that size is <= XY?
Looks fine
Jun 24 2023
If all you want is (1), that doesn't require any attribute (the optimizer will do it automatically).
Jun 21 2023
Jun 16 2023
Jun 15 2023
Jun 12 2023
You have to update that file anyway. Pre-commit builds are clearly failing.
https://reviews.llvm.org/D136737 used 'builtin_unspecified_value' which could be okay. .. or builtin_undefined_value maybe?
Jun 11 2023
You should update checks in loopstrengthreduce::scaling-factor-incompat-type.ll
Jun 7 2023
Jun 4 2023
I am wondering if we could enable it for X86 too. Any known blockers?
Jun 1 2023
Added missing comment.
May 31 2023
Addressed review comments.
Addressed review feedback
May 30 2023
May 29 2023
But I prefer if things are slow rather than faulty.
May 27 2023
May 25 2023
May 22 2023
May 18 2023
Rebased and updated callsites.
May 14 2023
May 13 2023
May 9 2023
May 7 2023
Addressed review feedback, thanks.
any futher comments?
May 5 2023
Something "cheap" we could do is attach nonnull attributes to arguments of inlined calls, when appropriate.
May 4 2023
Remove useless PhaseOrdering test.
Addressed review feedback. Added new test with char duplication.
May 3 2023
Rebased.
May 2 2023
We generally fail to call 'foldBinOpIntoSelectOrPhi' in commonIDivTransforms and commonIRemTransforms
any futher comments?
May 1 2023
Apr 30 2023
Addressed review feedback.
Apr 28 2023
Use USHRT_MAX. Added check.
Apr 21 2023
alignment info generally hits same issue
Apr 19 2023
Yes, please, as I would be able to commit it for you only next week.
Apr 14 2023
Added check 'CB.getAttributes().hasParamAttr(ArgNo, Attribute::NoUndef)'. The impact of this PR is non-trivial:
https://llvm-compile-time-tracker.com/compare.php?from=06ddb7bfe24891eee43bcf19252708b0cf684562&to=d1559cc73ad38f7684a026f8c69c6c96af9246a3&stat=instructions:u