Page MenuHomePhabricator

xbolva00 (Dávid Bolvanský)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2018, 5:18 PM (167 w, 4 d)

Recent Activity

Today

xbolva00 added a comment to D104636: [LoopIdiom] [LoopNest] let the pass deal with runtime memset size.

I am quite skeptical how useful this can be in practise. Any motivation examples from real world codes/benchmarks?

Mon, Jun 21, 6:18 AM · Restricted Project
xbolva00 added inline comments to D104623: [X86] Update MachineLoopInfo in CMOV conversion..
Mon, Jun 21, 3:25 AM · Restricted Project

Yesterday

xbolva00 added a reviewer for D104597: [SimplifyCFG] Tail-merging all blocks with `ret` terminator: dmgreen.
Sun, Jun 20, 5:02 AM · Restricted Project

Fri, Jun 18

xbolva00 added inline comments to D104445: [SimplifyCFGPass] Tail-merging function-terminating blocks.
Fri, Jun 18, 7:53 AM · Restricted Project

Tue, Jun 15

xbolva00 added inline comments to D103009: [DSE] Transform memset + malloc --> calloc (PR25892).
Tue, Jun 15, 4:05 AM · Restricted Project
xbolva00 added inline comments to D103009: [DSE] Transform memset + malloc --> calloc (PR25892).
Tue, Jun 15, 4:04 AM · Restricted Project
xbolva00 added inline comments to D103009: [DSE] Transform memset + malloc --> calloc (PR25892).
Tue, Jun 15, 3:59 AM · Restricted Project
xbolva00 added inline comments to D103009: [DSE] Transform memset + malloc --> calloc (PR25892).
Tue, Jun 15, 3:08 AM · Restricted Project

Sat, Jun 12

xbolva00 added a comment to D99249: [PassManager] Run additional LICM before LoopRotate.

Maybe this caused https://bugs.llvm.org/show_bug.cgi?id=50550. Could you check and comment it?

Sat, Jun 12, 3:33 AM · Restricted Project
xbolva00 added inline comments to D103638: [SLP]Improve vectorization of PHI instructions..
Sat, Jun 12, 3:26 AM · Restricted Project

Thu, Jun 10

xbolva00 added inline comments to D74436: Change clang option -ffp-model=precise to select ffp-contract=on.
Thu, Jun 10, 6:44 AM · Restricted Project
xbolva00 added inline comments to D74436: Change clang option -ffp-model=precise to select ffp-contract=on.
Thu, Jun 10, 6:36 AM · Restricted Project

Wed, Jun 9

xbolva00 added a comment to D103949: Only consider built-in compound assignment operators for -Wunused-but-set-*.

Ok thanks for info. We should follow gcc in this case.

Wed, Jun 9, 4:22 AM · Restricted Project
xbolva00 added a comment to D103949: Only consider built-in compound assignment operators for -Wunused-but-set-*.

gcc also ignores it?

Wed, Jun 9, 2:41 AM · Restricted Project

Mon, Jun 7

xbolva00 added a comment to D103820: [X86] Prefer vpmovq2m over vpternlogd + vpcmpgtq.

Actually, wait. Something weird is going on at the mid-level. These two functions should generate the same optimized IR, right?

typedef int V __attribute__((vector_size(64)));

V lt_zero_x_y(V mask, V x, V y) { return mask <  0 ? x : y; }
V ge_zero_y_x(V mask, V x, V y) { return mask >= 0 ? y : x; }
Mon, Jun 7, 9:59 AM · Restricted Project

Sun, Jun 6

xbolva00 added a comment to D102615: [LoopDeletion] Break backedge if we can prove that the loop is exited on 1st iteration (try 3).

The new results look fine.

Sun, Jun 6, 3:12 PM · Restricted Project

Sat, Jun 5

xbolva00 added inline comments to D102574: [InstCombine] Missed optimization for pow(x, y) * pow(x, z) with fast-math.
Sat, Jun 5, 3:06 AM · Restricted Project

Fri, Jun 4

xbolva00 added inline comments to rG23a116c8c446: [InstCombine] convert lshr to ashr to eliminate cast op.
Fri, Jun 4, 4:33 AM
xbolva00 added inline comments to D103660: [ScalarEvolution] Fix pointer/int type handling converting select/phi to min/max..
Fri, Jun 4, 1:38 AM · Restricted Project

Thu, Jun 3

xbolva00 added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

http://sprunge.us/FJzZXL is a file from harfbuzz and it warns

a.cc:28670:32: error: variable 'supp_size' set but not used [-Werror,-Wunused-but-set-variable]
    unsigned int size0, size1, supp_size = 0;

I do not have -Werror enabled but it still is reported as error. There is no way to disable this warning ?

Thu, Jun 3, 9:13 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 2

xbolva00 accepted D103523: [BuildLibCalls][NFC] Remove redundant attribute list from emitCalloc.

Thanks!

Wed, Jun 2, 7:35 AM · Restricted Project
xbolva00 added a comment to D102748: [LoopUnroll] Don't unroll before vectorisation.

And there is something weird in terms of cost modelling between vectorizers.

See https://bugs.llvm.org/show_bug.cgi?id=47491

If we dont unroll the loop, llvm loop vectorizer vectorizes the loop (cost model says it is profitable).

If we unroll the loop, slp does not vectorize the unrolled loop.

And other one: https://bugs.llvm.org/show_bug.cgi?id=50552 ... SLP just misses currently these patterns.

Wed, Jun 2, 4:47 AM · Restricted Project
xbolva00 added a comment to D99438: [SimplifyLibCalls] Take size of int into consideration when emitting ldexp/ldexpf.

Commited without approval?

Wed, Jun 2, 3:20 AM · Restricted Project

Tue, Jun 1

xbolva00 added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

I think there is a false positive with this @george.burgess.iv:
In this we have the warning triggered:
mozglue/baseprofiler/core/platform-linux-android.cpp:216:9: error: variable 'r' set but not used [-Werror,-Wunused-but-set-variable]

SigHandlerCoordinator() {
  PodZero(&mUContext);
  int r = sem_init(&mMessage2, /* pshared */ 0, 0);
  r |= sem_init(&mMessage3, /* pshared */ 0, 0);
  r |= sem_init(&mMessage4, /* pshared */ 0, 0);
  MOZ_ASSERT(r == 0);
}
Tue, Jun 1, 10:29 PM · Restricted Project, Restricted Project, Restricted Project
xbolva00 added a comment to D102748: [LoopUnroll] Don't unroll before vectorisation.

And there is something weird in terms of cost modelling between vectorizers.

See https://bugs.llvm.org/show_bug.cgi?id=47491

If we dont unroll the loop, llvm loop vectorizer vectorizes the loop (cost model says it is profitable).

If we unroll the loop, slp does not vectorize the unrolled loop.

Tue, Jun 1, 7:56 AM · Restricted Project
xbolva00 added a comment to D102615: [LoopDeletion] Break backedge if we can prove that the loop is exited on 1st iteration (try 3).

What are the latest compile time data for this patch?

There have been several separate follow-ups to address the compile time, but I believe we never measured it all together.

Could we get new data? @nikic? I am not sure if followups were not reverted as well so if follow up patches can recommited as NFC(I) patches, it would be great.

The followups were all reverted and integrated into this one. I see no point in merging them separately, unless we want more pain with reverts (if it is needed again). They are just part of the algorithm.

Tue, Jun 1, 3:03 AM · Restricted Project

Mon, May 31

xbolva00 added a comment to D102615: [LoopDeletion] Break backedge if we can prove that the loop is exited on 1st iteration (try 3).

Can this patch optimize code from comment #4 in https://bugs.llvm.org/show_bug.cgi?id=47491 ?

Mon, May 31, 9:45 PM · Restricted Project
xbolva00 added a comment to D102615: [LoopDeletion] Break backedge if we can prove that the loop is exited on 1st iteration (try 3).

What are the latest compile time data for this patch?

There have been several separate follow-ups to address the compile time, but I believe we never measured it all together.

Mon, May 31, 9:45 PM · Restricted Project
xbolva00 added a comment to D103009: [DSE] Transform memset + malloc --> calloc (PR25892).

I think this should check for just LibFunc_malloc and nothing else. MallocLike just means an allocation function that return null on failure, and the nothrow new variants are considered MallocLike and not OpNewLike.

Mon, May 31, 7:15 AM · Restricted Project
xbolva00 added a comment to D103009: [DSE] Transform memset + malloc --> calloc (PR25892).

Ok, this looks fine now I think.

Mon, May 31, 6:53 AM · Restricted Project

Sun, May 30

xbolva00 added a comment to D102615: [LoopDeletion] Break backedge if we can prove that the loop is exited on 1st iteration (try 3).

What are the latest compile time data for this patch?

Sun, May 30, 11:29 PM · Restricted Project
xbolva00 added a comment to D96223: [clang-tidy] Simplify static assert check.

Reverted in be6b9e8ae71768d2e09ec14619ca4ecfdef553fa - https://godbolt.org/z/3zdqvbfxj
While there, please ensure that other such simplifications don't have similar lingering effects.

Thanks for catching the issue!

FWIW, I think that reverting something several months after it lands is a bit disruptive and the test case causing the revert feels arbitrary without further context that should have been explicitly mentioned in the reverting commit message. The context is that this change broke a test that should have caught the failure: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/test/clang-tidy/checkers/misc-static-assert.cpp#L86-L87 which led to this bug report: https://bugs.llvm.org/show_bug.cgi?id=50532. I'm still not convinced the correct action was to revert a change with no discussion that already was shipped in a release, however. Next time, I think it'd be a bit friendlier to mention the regression on the patch to see if the author can do a quick fix -- if no one noticed it for almost four months, it's hard to argue it's a critical issue that needs an immediate revert. (The reversion mildly worries me because this change already shipped as part of Clang 12 and larger reversions make for harder git blame logic to follow along with, both of which can lead to potential confusion for folks.)

Sun, May 30, 7:56 AM · Restricted Project, Restricted Project

Sat, May 29

xbolva00 added inline comments to rG625920dabf49: [LoopUnroll] Make DomTree explicitly required (NFC).
Sat, May 29, 1:15 AM

Fri, May 28

xbolva00 added inline comments to D103009: [DSE] Transform memset + malloc --> calloc (PR25892).
Fri, May 28, 8:51 AM · Restricted Project
xbolva00 added a comment to D103009: [DSE] Transform memset + malloc --> calloc (PR25892).

Since instcombine is currently only user of emitCalloc, so after you commit this patch, please delete AttrsList parameter from emitCalloc (and adjust this new callsite in DSE) together with removal of this transformation from instcombine.

Fri, May 28, 12:22 AM · Restricted Project

Wed, May 26

xbolva00 added a comment to D103009: [DSE] Transform memset + malloc --> calloc (PR25892).

And remove transformation from instcombine?

Wed, May 26, 11:03 PM · Restricted Project
xbolva00 added inline comments to D102615: [LoopDeletion] Break backedge if we can prove that the loop is exited on 1st iteration (try 3).
Wed, May 26, 10:50 PM · Restricted Project
xbolva00 added a comment to D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+..

Well, no, I'm afraid it is actually clear that that code does have UB according to the C++ standard. Perhaps you mean that it *shouldn't* have UB, or that Clang should define its behavior despite the standard.

I might agree with you that I don't see the value in using this stronger rule in C++, but I think it would help to understand the problem a little better. I assume this is causing problems for a less trivial test case? Or do you really have code that's relying on that loop not terminating?

I see. I guess it's good (and bad) that this discovered this UB in our code base. The example I posted is almost exactly what's in our test case. For this particular one, we need a non-terminating thread, so a thread_create function is passed do_nothing. Locally, we could get around this by using something like inline assembly to avoid UB.

(Potentially deviating from this patch) While an infinite loop may be UB according to the standard, it's also something fairly common that can be in a lot of code bases. Although it may be an unintended side-effect, it still seems a bit abrupt that we found about this UB from this patch rather than ubsan or a compiler diagnostic. Are there any plans in the future for something along the lines of improving catching this type of UB? Or alternatively, are there plans of maybe defining it in clang (like a language extension) as @rjmccall points out?

Wed, May 26, 6:20 PM · Restricted Project
xbolva00 added a comment to D102615: [LoopDeletion] Break backedge if we can prove that the loop is exited on 1st iteration (try 3).

@nikic > Is the "at" part an important part of this optimization?

Unfortunately yes, without it the motivating test won't pass. I'll simply make option to enable/disable this transform.

Wed, May 26, 2:11 AM · Restricted Project

Tue, May 25

xbolva00 added a comment to D96418: [clang] Refactor mustprogress handling, add it to all loops in c++11+..

Would it be fine to revert this for now to work out the kinks?

Tue, May 25, 10:01 PM · Restricted Project

Mon, May 24

xbolva00 added a comment to D102748: [LoopUnroll] Don't unroll before vectorisation.

And there is something weird in terms of cost modelling between vectorizers.

Mon, May 24, 9:48 PM · Restricted Project
xbolva00 added a comment to D102615: [LoopDeletion] Break backedge if we can prove that the loop is exited on 1st iteration (try 3).

Can this patch optimize code from comment #4 in https://bugs.llvm.org/show_bug.cgi?id=47491 ?

Mon, May 24, 9:42 PM · Restricted Project
xbolva00 added inline comments to D101440: [DSE] Eliminate store after calloc (PR50143).
Mon, May 24, 2:41 AM · Restricted Project

May 22 2021

xbolva00 added inline comments to D102864: [InstSimplify] Transform X * Y % Y --> 0..
May 22 2021, 7:47 PM · Restricted Project
xbolva00 added a comment to D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops..

Ah right:) I understand now.

May 22 2021, 6:38 PM · Restricted Project
xbolva00 added a comment to D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops..

Hello, this work was brought to my attention in D102748. Would be good to get this in, and seems almost finished too. Any plans to pick this up? Otherwise I think I would be interested in doing that.

This should be much easier to implement after non-power-2 in SLP support.

May 22 2021, 4:08 PM · Restricted Project
xbolva00 added inline comments to rGc5638a71d805: [MinGW] Mark a number of library functions unavailable for mingw targets.
May 22 2021, 3:43 PM

May 21 2021

xbolva00 added inline comments to D99205: Add jump-threading optimization for deterministic finite automata.
May 21 2021, 1:48 AM · Restricted Project

May 20 2021

xbolva00 added a comment to D97122: [SCEV] Improve handling of pointer compares involving subtractions (WIP)..

Re-ping

May 20 2021, 9:11 PM · Restricted Project
xbolva00 added a comment to D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable.

Also fix a few places where this warning is correctly triggered.

May 20 2021, 8:22 PM · Restricted Project, Restricted Project, Restricted Project
xbolva00 added a comment to D93838: [SCCP] Add Function Specialization pass.

getting this all right and enabled by default with the first commit is probably not achievable

May 20 2021, 1:36 AM · Restricted Project

May 19 2021

xbolva00 added a comment to D93838: [SCCP] Add Function Specialization pass.

What about C-ray? Does function specialization help?

May 19 2021, 9:30 PM · Restricted Project
xbolva00 added a comment to D102453: [CMake][ELF] Add -fno-semantic-interposition for GCC and Clang>=13.

Great, thanks!

May 19 2021, 4:47 PM · Restricted Project
xbolva00 added inline comments to D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.
May 19 2021, 3:52 PM · Restricted Project
xbolva00 added inline comments to D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.
May 19 2021, 3:51 PM · Restricted Project
xbolva00 updated subscribers of D102748: [LoopUnroll] Don't unroll before vectorisation.

If we improved the robustness of our other optimizations w.r.t. vector instructions, we'd probably be a lot less sensitive to the proposed pass reordering.

May 19 2021, 11:30 AM · Restricted Project
xbolva00 added a comment to D102748: [LoopUnroll] Don't unroll before vectorisation.

This, I think, also relies on the loop vectoriser which seems more powerful than SLP vectorisation currently.

May 19 2021, 2:40 AM · Restricted Project
xbolva00 added a comment to D102748: [LoopUnroll] Don't unroll before vectorisation.

Instead of removing early full unroll pass (see @nikic's concerns), couldn't we run loop vectorizer before full unroll pass?

May 19 2021, 2:03 AM · Restricted Project
xbolva00 added a comment to D102748: [LoopUnroll] Don't unroll before vectorisation.

I don't have suggestion on how to move forward *this* patch, because I think it's fundamentally the wrong direction to take.

May 19 2021, 2:00 AM · Restricted Project

May 18 2021

xbolva00 added inline comments to D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.
May 18 2021, 4:27 PM · Restricted Project
xbolva00 added a comment to D102675: [SLP] Fix "gathering" of vector values.

Add testcase?

May 18 2021, 2:12 AM · Restricted Project

May 16 2021

xbolva00 added a reviewer for D102574: [InstCombine] Missed optimization for pow(x, y) * pow(x, z) with fast-math: efriedma.
May 16 2021, 9:26 AM · Restricted Project
xbolva00 added inline comments to D102478: [Matrix] Emit assumption that matrix indices are valid..
May 16 2021, 9:21 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D102478: [Matrix] Emit assumption that matrix indices are valid..
May 16 2021, 9:16 AM · Restricted Project, Restricted Project

May 15 2021

xbolva00 added a comment to D102453: [CMake][ELF] Add -fno-semantic-interposition for GCC and Clang>=13.

hold off this patch.

May 15 2021, 3:47 PM · Restricted Project
xbolva00 added a comment to D102453: [CMake][ELF] Add -fno-semantic-interposition for GCC and Clang>=13.

If that's implemented in GCC then this change here to build with -fno-semantic-interposition would mean that the test failures seen in D102090 would resurface.

May 15 2021, 3:45 PM · Restricted Project

May 14 2021

xbolva00 added a comment to D102496: [Passes] Run vector-combine early with -fenable-matrix..

Any testcase to ensure that passes together now produce what you want?

May 14 2021, 7:19 AM · Restricted Project
xbolva00 added a comment to D93838: [SCCP] Add Function Specialization pass.

It further requires us to split the current pass into an analysis one and a transformed

+1, agree.

May 14 2021, 12:21 AM · Restricted Project

May 13 2021

xbolva00 added a comment to D93838: [SCCP] Add Function Specialization pass.

I think we could limit the numbers of function specialized.

May 13 2021, 8:02 PM · Restricted Project
xbolva00 added a comment to D102452: [Remarks] Add analysis remarks for memset/memcpy/memmove lengths.

Maybe additional info about upper bound (if dst or src is local/global buffer; getDerefenceableBytes API) may be interesting too?

May 13 2021, 5:30 PM · Restricted Project
xbolva00 updated subscribers of D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions.

I cannot figure out how to make -fno-semantic-interposition specific to llvm/ and clang/.

May 13 2021, 3:30 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D93838: [SCCP] Add Function Specialization pass.

I think it would take a long time to tune the heuristics and the cost model may be changing during the evolution process.

May 13 2021, 4:16 AM · Restricted Project
xbolva00 added a comment to D93838: [SCCP] Add Function Specialization pass.

absolute numbers being small: do you have any insight into whether the impact is expected to be less on larger benchmarks/binaries?

May 13 2021, 4:01 AM · Restricted Project
xbolva00 added a comment to D93838: [SCCP] Add Function Specialization pass.

Manually tagging those arguments with an attribute in exchange for guaranteed specialisation when they're constant would be high value, even without any heuristics to automate the decision.

May 13 2021, 3:57 AM · Restricted Project

May 12 2021

xbolva00 added inline comments to D101680: Change the context instruction for computeKnownBits in LoadStoreVectorizer pass.
May 12 2021, 3:26 PM · Restricted Project
xbolva00 added a comment to D98798: Produce warning for performing pointer arithmetic on a null pointer..

You dont have to use -Wno-…

May 12 2021, 10:42 AM · Restricted Project
xbolva00 added a comment to D101970: [X86FixupLEAs] Transform the sequence LEA/SUB to SUB/SUB.

Whether we want to run this transformation on newer archs - as you said, it brings us nothing, so atleast we should check it is free in terms of compile time in the backend.

May 12 2021, 1:53 AM · Restricted Project

May 11 2021

xbolva00 added inline comments to D99438: [SimplifyLibCalls] Take size of int into consideration when emitting ldexp/ldexpf.
May 11 2021, 1:41 PM · Restricted Project
xbolva00 added a comment to D99439: Update @llvm.powi to handle different int sizes for the exponent.

What about IR backward compatibility?

May 11 2021, 1:36 PM · Restricted Project, Restricted Project
xbolva00 added inline comments to D99439: Update @llvm.powi to handle different int sizes for the exponent.
May 11 2021, 1:34 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D101970: [X86FixupLEAs] Transform the sequence LEA/SUB to SUB/SUB.

Can you try this patch with http://llvm-compile-time-tracker.com/ ?

May 11 2021, 6:39 AM · Restricted Project

May 10 2021

xbolva00 added inline comments to D102215: [SelectionDAG] Propagate scoped AA metadata when lowering mem intrinsics..
May 10 2021, 9:33 PM · Restricted Project

May 9 2021

xbolva00 added a comment to D102096: [DAGCombiner] Fix DAG combine store elimination, different address space..

What about DeadStoreElimination ? It can also merge stores.. maybe dse needs similar fix.

May 9 2021, 9:33 PM · Restricted Project
xbolva00 added a comment to D101692: [SCEV] Handle and/or in applyLoopGuards().

This could help with https://bugs.llvm.org/show_bug.cgi?id=50105 ?

May 9 2021, 11:24 AM · Restricted Project

May 7 2021

xbolva00 added a comment to D102005: [libcxx]: Unroll std::find on AIX.

it seems like we dont specialize std::find to use memchr if possible?

May 7 2021, 11:20 AM · Restricted Project
xbolva00 added a comment to D102005: [libcxx]: Unroll std::find on AIX.

Just curious, why you cannot use:

May 7 2021, 11:19 AM · Restricted Project
xbolva00 updated subscribers of D101176: [SimplifyLibCalls] Transform malloc to calloc with redundant memsets elimination (PR25892).

Hello, some days ago I was looking at it.

May 7 2021, 5:10 AM · Restricted Project

May 6 2021

xbolva00 added a comment to D101536: [SimplifyCFG] Common code sinking: drop profitability check in presence of conditional predecessors (PR30244).
May 6 2021, 3:24 PM · Restricted Project
xbolva00 added a comment to D101536: [SimplifyCFG] Common code sinking: drop profitability check in presence of conditional predecessors (PR30244).

Can you collect some performance stats?

  • testsuite/spec benchmarks/etc?
May 6 2021, 11:30 AM · Restricted Project

May 4 2021

xbolva00 added a reverting change for rG4e7a4c73dab6: [InstSimplify] Added tests for PR50173, NFC: rG62fcda93788a: Revert "[InstSimplify] Added tests for PR50173, NFC".
May 4 2021, 2:04 PM
xbolva00 committed rG62fcda93788a: Revert "[InstSimplify] Added tests for PR50173, NFC" (authored by xbolva00).
Revert "[InstSimplify] Added tests for PR50173, NFC"
May 4 2021, 2:04 PM
xbolva00 abandoned D101840: [InstCombine] ctlz(x) -> 0 if x is known negative number.

Moved to InstCombine.

Your test already passes before your change. If the Known bits is negative, PossibleZeros and DefiniteZeros will both be 0 which triggers the PossibleZeros == DefiniteZeros case.

May 4 2021, 2:02 PM · Restricted Project
xbolva00 added a reviewer for D99205: Add jump-threading optimization for deterministic finite automata: efriedma.
May 4 2021, 1:07 PM · Restricted Project
xbolva00 updated the diff for D101840: [InstCombine] ctlz(x) -> 0 if x is known negative number.

Moved to InstCombine.

May 4 2021, 1:03 PM · Restricted Project
xbolva00 added a comment to D101840: [InstCombine] ctlz(x) -> 0 if x is known negative number.

// FIXME: This should be in InstSimplify because we're replacing an ...

May 4 2021, 12:27 PM · Restricted Project
xbolva00 added a comment to D101840: [InstCombine] ctlz(x) -> 0 if x is known negative number.

No strong opinion, but everybody should agree.

May 4 2021, 11:35 AM · Restricted Project
xbolva00 committed rG4e7a4c73dab6: [InstSimplify] Added tests for PR50173, NFC (authored by xbolva00).
[InstSimplify] Added tests for PR50173, NFC
May 4 2021, 10:33 AM
xbolva00 added inline comments to D101840: [InstCombine] ctlz(x) -> 0 if x is known negative number.
May 4 2021, 10:31 AM · Restricted Project
xbolva00 updated the diff for D101840: [InstCombine] ctlz(x) -> 0 if x is known negative number.

Rebased.

May 4 2021, 10:30 AM · Restricted Project
xbolva00 updated the diff for D101840: [InstCombine] ctlz(x) -> 0 if x is known negative number.

Generalization.

May 4 2021, 8:46 AM · Restricted Project