xbolva00 (Dávid Bolvanský)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2018, 5:18 PM (32 w, 3 d)

Recent Activity

Yesterday

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

I removed _Float16 related tests since some bots may fall with it, i dont know much about this custom type.
Anyway, It is fine on linux x86 64. I will restore them.

Sun, Nov 18, 9:13 AM

Sat, Nov 17

xbolva00 updated the diff for D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Addressed comments, fixed tests

Sat, Nov 17, 5:30 AM

Thu, Nov 15

xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Ping :)

Thu, Nov 15, 4:53 AM
xbolva00 added a comment to D54571: [WebAssembly] Split BBs after throw instructions.

Sorry for little offtopic at first.

Thu, Nov 15, 1:39 AM

Wed, Nov 14

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Ok, I will address your comments soon.

Wed, Nov 14, 6:31 AM
xbolva00 committed rL346866: Reverted D52835 to fix review comments.
Reverted D52835 to fix review comments
Wed, Nov 14, 6:30 AM
xbolva00 committed rC346866: Reverted D52835 to fix review comments.
Reverted D52835 to fix review comments
Wed, Nov 14, 6:30 AM
xbolva00 reopened D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Wed, Nov 14, 6:30 AM
xbolva00 committed rL346865: [Diagnostics] Check integer to floating point number implicit conversions.
[Diagnostics] Check integer to floating point number implicit conversions
Wed, Nov 14, 6:27 AM
xbolva00 committed rC346865: [Diagnostics] Check integer to floating point number implicit conversions.
[Diagnostics] Check integer to floating point number implicit conversions
Wed, Nov 14, 6:27 AM
xbolva00 closed D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Wed, Nov 14, 6:27 AM
xbolva00 accepted D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Wed, Nov 14, 6:09 AM

Mon, Nov 12

xbolva00 added a comment to D53706: [RecursionStackElimination]: Pass to eliminate recursions.

Very interesting work!

Mon, Nov 12, 6:56 AM

Sun, Nov 11

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Since no futher comments, i think it is ok.
After day or two I will commit it.

Sun, Nov 11, 7:46 AM

Fri, Nov 9

xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Ping

Fri, Nov 9, 1:26 PM

Wed, Nov 7

xbolva00 added a comment to D53554: [Argument Promotion] Only promote args when function attributes are compatible.

@echristo wanted to look at this

Wed, Nov 7, 10:28 AM
xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

@aaron.ballman

Wed, Nov 7, 9:58 AM

Tue, Nov 6

xbolva00 added a comment to D52109: [TwoAddressInstructionPass] Don't update SrcRegMap for copies inserted for tied register constraint when the src isn't killed.

Any benchmark results w/o this patch?

Tue, Nov 6, 3:25 PM

Mon, Nov 5

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Ping :)

Mon, Nov 5, 1:28 AM

Sun, Nov 4

xbolva00 added inline comments to rLLDB346093: NativeProcessProtocol: Simplify breakpoint setting code.
Sun, Nov 4, 4:22 AM

Sat, Nov 3

xbolva00 updated the diff for D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Sat, Nov 3, 4:18 PM

Thu, Nov 1

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Since I don't think we have any false positives here, maybe it would be useful to add it to -Wall or -Wextra?

Thu, Nov 1, 9:48 AM
xbolva00 committed rC345847: [Diagnostics] Implement -Wsizeof-pointer-div .
[Diagnostics] Implement -Wsizeof-pointer-div
Thu, Nov 1, 9:30 AM
xbolva00 committed rL345847: [Diagnostics] Implement -Wsizeof-pointer-div .
[Diagnostics] Implement -Wsizeof-pointer-div
Thu, Nov 1, 9:30 AM
xbolva00 closed D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
Thu, Nov 1, 9:29 AM
xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

maybe @aaron.ballman wants to take a look too

Thu, Nov 1, 7:36 AM
xbolva00 added a comment to D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
  • Addressed review comments.
Thu, Nov 1, 6:46 AM
xbolva00 updated the diff for D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
Thu, Nov 1, 6:43 AM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Ping

Thu, Nov 1, 1:56 AM

Wed, Oct 31

xbolva00 added reviewers for D52835: [Diagnostics] Check integer to floating point number implicit conversions: aaron.ballman, efriedma.
Wed, Oct 31, 2:14 PM
xbolva00 added a reviewer for D52949: [Diagnostics] Implement -Wsizeof-pointer-div : aaron.ballman.
Wed, Oct 31, 2:14 PM
xbolva00 added a comment to D45444: [clang-tidy] implement new check for const-correctness.

Are you still looking at this?

Wed, Oct 31, 12:33 PM
xbolva00 committed rLLDB345755: [NFC] Fixed -Wsign-compare warning.
[NFC] Fixed -Wsign-compare warning
Wed, Oct 31, 11:06 AM
xbolva00 committed rL345755: [NFC] Fixed -Wsign-compare warning.
[NFC] Fixed -Wsign-compare warning
Wed, Oct 31, 11:06 AM
xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Anything else to be done here? I would like to finish this patch to work on other things.

Wed, Oct 31, 8:00 AM
xbolva00 updated the diff for D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
  • New warning text, added another test line
Wed, Oct 31, 7:55 AM
xbolva00 committed rL345721: [DAGCombiner] Fold 0 div/rem X to 0.
[DAGCombiner] Fold 0 div/rem X to 0
Wed, Oct 31, 7:22 AM
xbolva00 closed D52504: [DAGCombiner] Fold 0 div/rem X to 0.
Wed, Oct 31, 7:22 AM
xbolva00 retitled D52504: [DAGCombiner] Fold 0 div/rem X to 0 from [DAGCombiner] Div/rem folds to [DAGCombiner] Fold 0 div/rem X to 0.
Wed, Oct 31, 7:08 AM
xbolva00 added a comment to D52504: [DAGCombiner] Fold 0 div/rem X to 0.

Sanjay's changes don't seem to be rebased ?

Wed, Oct 31, 6:44 AM
xbolva00 updated the diff for D52504: [DAGCombiner] Fold 0 div/rem X to 0.
Wed, Oct 31, 6:44 AM
xbolva00 updated the diff for D53666: [Tests] Updated tests for D53342.
Wed, Oct 31, 6:44 AM
xbolva00 updated the diff for D53666: [Tests] Updated tests for D53342.
Wed, Oct 31, 6:43 AM
xbolva00 added inline comments to D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5).
Wed, Oct 31, 6:30 AM

Tue, Oct 30

xbolva00 updated the diff for D52504: [DAGCombiner] Fold 0 div/rem X to 0.
  • Rebased
Tue, Oct 30, 3:18 PM
xbolva00 committed rL345665: [ARM][NFC] Make tests immune to better div optimizations.
[ARM][NFC] Make tests immune to better div optimizations
Tue, Oct 30, 3:10 PM
xbolva00 closed D53901: [ARM][NFC] Make tests immune to better div optimizations.
Tue, Oct 30, 3:10 PM
xbolva00 updated the diff for D53901: [ARM][NFC] Make tests immune to better div optimizations.
Tue, Oct 30, 3:02 PM
xbolva00 added a comment to D52504: [DAGCombiner] Fold 0 div/rem X to 0.

Ok, https://reviews.llvm.org/D53901

Tue, Oct 30, 2:55 PM
xbolva00 created D53901: [ARM][NFC] Make tests immune to better div optimizations.
Tue, Oct 30, 2:54 PM
xbolva00 added a comment to D52949: [Diagnostics] Implement -Wsizeof-pointer-div .

Any ideas for better warning message? Except for the warning text, I see this patch as ready.

Tue, Oct 30, 1:57 PM
xbolva00 updated the diff for D52504: [DAGCombiner] Fold 0 div/rem X to 0.
  • Rebased
Tue, Oct 30, 10:30 AM
xbolva00 added a comment to D52949: [Diagnostics] Implement -Wsizeof-pointer-div .

Ping @MTC or @rsmith

Tue, Oct 30, 2:21 AM
xbolva00 committed rL345575: [DAGCombiner] Improve X div/rem Y fold if single bit element type.
[DAGCombiner] Improve X div/rem Y fold if single bit element type
Tue, Oct 30, 2:09 AM
xbolva00 closed D52668: [DAGCombiner] Improve X div/rem Y fold if single bit element type.
Tue, Oct 30, 2:09 AM

Sun, Oct 28

xbolva00 added a comment to D52668: [DAGCombiner] Improve X div/rem Y fold if single bit element type.

Ping

Sun, Oct 28, 3:49 AM

Thu, Oct 25

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

ping

Thu, Oct 25, 3:12 PM

Wed, Oct 24

xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Side idea:
From C function callsites with size arg we could theoretically determine some pointer aliasing info..

Wed, Oct 24, 3:39 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
  • formatting fixes
Wed, Oct 24, 3:24 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Wed, Oct 24, 3:11 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
  • drop problematic nonnull attributes with unknown size arg
Wed, Oct 24, 3:08 PM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Maybe we can also drop nonnull attributes for certain functions with size argument, here, in instcombine?

Wed, Oct 24, 2:56 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
  • updated test file
Wed, Oct 24, 1:25 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
  • Avoid marking if address spaces
Wed, Oct 24, 1:21 PM
xbolva00 updated the diff for D53666: [Tests] Updated tests for D53342.
Wed, Oct 24, 1:17 PM
xbolva00 added inline comments to D53666: [Tests] Updated tests for D53342.
Wed, Oct 24, 1:15 PM
xbolva00 added a reviewer for D53666: [Tests] Updated tests for D53342: efriedma.
Wed, Oct 24, 12:56 PM
xbolva00 retitled D53342: [SimplifyLibCalls] Mark known arguments with nonnull from [SimplifyLibCalls][WIP] Mark known arguments with nonnull to [SimplifyLibCalls] Mark known arguments with nonnull.
Wed, Oct 24, 12:51 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
  • Tests updated
Wed, Oct 24, 12:51 PM
xbolva00 created D53666: [Tests] Updated tests for D53342.
Wed, Oct 24, 12:50 PM

Tue, Oct 23

xbolva00 added a reviewer for D53419: [SourceMgr][FileCheck] Obey -color by extending WithColor: zturner.
Tue, Oct 23, 2:19 PM
xbolva00 added a comment to D53534: [hot-cold-split] Name split functions with ".cold" suffix.

Does the pass groups hot code together? is it in your plans?

Tue, Oct 23, 1:07 PM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Thanks @spatel, I missed it :(

Tue, Oct 23, 12:50 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Tue, Oct 23, 12:49 PM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

https://pastebin.com/8bxCuV5V + this patch
opt -instcombine p.ll -S

Tue, Oct 23, 10:56 AM
xbolva00 updated the diff for D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
  • Added MTC'c case to test file
Tue, Oct 23, 10:45 AM
xbolva00 added a comment to D52949: [Diagnostics] Implement -Wsizeof-pointer-div .

No warning for your case.

Tue, Oct 23, 10:43 AM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Ping @spatel whether he has any idea why instcombine turns
define dso_local i32 @fff6(i8* nocapture readonly %s) local_unnamed_addr #5 {
entry:
%call = tail call i64 @strlen(i8* nonnull %s) #8
%conv = trunc i64 %call to i32
ret i32 %conv
}

Tue, Oct 23, 10:27 AM

Mon, Oct 22

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Ping

Mon, Oct 22, 11:18 AM
xbolva00 added a comment to D52949: [Diagnostics] Implement -Wsizeof-pointer-div .

Ping

Mon, Oct 22, 11:18 AM

Oct 19 2018

xbolva00 added inline comments to D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler and linker.
Oct 19 2018, 12:17 AM

Oct 18 2018

xbolva00 added a comment to D52668: [DAGCombiner] Improve X div/rem Y fold if single bit element type.

I reverted D50656 fix for pr38539 and pr38539.ll passed fine. So pr38539.ll tests nothing in the current trunk and it should not block this patch.

Oct 18 2018, 3:06 PM
xbolva00 committed rC344762: [Test] Fix test file for C++98 mode.
[Test] Fix test file for C++98 mode
Oct 18 2018, 2:28 PM
xbolva00 committed rL344762: [Test] Fix test file for C++98 mode.
[Test] Fix test file for C++98 mode
Oct 18 2018, 2:28 PM
xbolva00 committed rL344761: [Diagnostics] Add missing expected warning to test file.
[Diagnostics] Add missing expected warning to test file
Oct 18 2018, 2:08 PM
xbolva00 committed rC344761: [Diagnostics] Add missing expected warning to test file.
[Diagnostics] Add missing expected warning to test file
Oct 18 2018, 2:08 PM
xbolva00 committed rC344759: [Diagnostics] Check for integer overflow in array size expressions .
[Diagnostics] Check for integer overflow in array size expressions
Oct 18 2018, 1:52 PM
xbolva00 closed D52750: [Diagnostics] Check for integer overflow in array size expressions .
Oct 18 2018, 1:52 PM
xbolva00 committed rL344759: [Diagnostics] Check for integer overflow in array size expressions .
[Diagnostics] Check for integer overflow in array size expressions
Oct 18 2018, 1:52 PM
xbolva00 added inline comments to D52784: [ARM][AArch64] Pass through endianness flags to the GNU assembler and linker.
Oct 18 2018, 1:37 PM
xbolva00 added a comment to D52949: [Diagnostics] Implement -Wsizeof-pointer-div .

Second thought, I don't think we should recommend std::size here (maybe it should be okay for clang static analyzers)

Oct 18 2018, 1:22 PM
xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Is PrecisionConversion acceptable? If not, any suggestions for name?

Oct 18 2018, 1:15 PM
xbolva00 added a comment to D49966: [X86] Performing DAG pruning before selection of LEA instructions..

Also we should avoid cases like
mov eax, dword ptr [rsi]
lea eax, [rax + rdi]

Oct 18 2018, 10:18 AM
xbolva00 added a reviewer for D52750: [Diagnostics] Check for integer overflow in array size expressions : Rakete1111.
Oct 18 2018, 7:56 AM
xbolva00 added a comment to D34795: Supporting -f(no)-reorder-functions flag, llvm side change.

Ping, plesse rebase

Oct 18 2018, 3:12 AM
xbolva00 updated subscribers of D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

InstCombine does something weird for me.

Oct 18 2018, 2:19 AM
xbolva00 abandoned D50039: [FunctionAttrs] Added nonnull atribute to libc function args.
Oct 18 2018, 2:19 AM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
  • Updated
Oct 18 2018, 2:19 AM
xbolva00 added a comment to D53362: [Prototype] Heap-To-Stack Conversion Pass.

Thanks for stats, interesting! Maybe try with some big C benchmarks/codebases? SPECs? :)

Oct 18 2018, 2:11 AM

Oct 17 2018

xbolva00 updated the diff for D50039: [FunctionAttrs] Added nonnull atribute to libc function args.
  • More marked functions
Oct 17 2018, 4:31 PM