Page MenuHomePhabricator

xbolva00 (Dávid Bolvanský)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2018, 5:18 PM (67 w, 3 d)

Recent Activity

Today

xbolva00 added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Ping

Mon, Jul 22, 6:38 AM · Restricted Project

Yesterday

xbolva00 added inline comments to D65047: [DAGCombine] matchBinOpReduction - add partial reduction matching.
Sun, Jul 21, 6:20 AM · Restricted Project

Sat, Jul 20

xbolva00 added a comment to D63082: [Diagnostics] Added support for -Wint-in-bool-context.

Ping @rsmith

Sat, Jul 20, 10:12 AM · Restricted Project
xbolva00 abandoned D63192: [Diagnostics] Implement -Wswitch-default.
Sat, Jul 20, 10:11 AM · Restricted Project
xbolva00 added a comment to D63139: [Diagnostics] Implement -Wswitch-unreachable.

Ping @rsmith

Sat, Jul 20, 10:11 AM · Restricted Project

Fri, Jul 19

xbolva00 resigned from D59754: [Sema] Add c++2a designated initializer warnings.
Fri, Jul 19, 12:40 PM · Restricted Project
xbolva00 resigned from D63058: [InlineCost] Fix bug 42084: return the first negative result.
Fri, Jul 19, 12:40 PM · Restricted Project
xbolva00 added a comment to rGdec624682e06: [MachineCSE][MachinePRE] Avoid hoisting code from code regions into hot BBs..

Should be backported to 9.0 branch?

Fri, Jul 19, 6:12 AM
xbolva00 updated subscribers of D64888: Use the MachineBasicBlock symbol for a callbr target.

It would be nice to merge this fix into 9.0 branch after some time in trunk. What do you think?

Fri, Jul 19, 2:31 AM · Restricted Project

Thu, Jul 18

xbolva00 updated subscribers of D43256: [MBP] Move a latch block with conditional exit and multi predecessors to top of loop.

(should be probably reverted from 9.0 branch)

Thu, Jul 18, 4:10 AM · Restricted Project
xbolva00 added a comment to D43256: [MBP] Move a latch block with conditional exit and multi predecessors to top of loop.

Can you provide benchmark results from "public" ones like SPEC or LLVM test-suite? I think this should be mandatory to land performance critical patches (always provide results from SPEC/test suite).

Thu, Jul 18, 4:04 AM · Restricted Project

Wed, Jul 17

xbolva00 added inline comments to D64888: Use the MachineBasicBlock symbol for a callbr target.
Wed, Jul 17, 3:12 PM · Restricted Project
xbolva00 added a comment to D64888: Use the MachineBasicBlock symbol for a callbr target.

Fixes https://bugs.llvm.org/show_bug.cgi?id=42147 ?

Wed, Jul 17, 3:07 PM · Restricted Project
xbolva00 added reviewers for D64888: Use the MachineBasicBlock symbol for a callbr target: nickdesaulniers, craig.topper.
Wed, Jul 17, 2:51 PM · Restricted Project
xbolva00 added a comment to D64888: Use the MachineBasicBlock symbol for a callbr target.

Test?

Wed, Jul 17, 2:50 PM · Restricted Project
xbolva00 updated the diff for D64859: [InstCombine] strncmp(x,y,strlen(x|y)+1) -> strcmp(x,y).
Wed, Jul 17, 2:12 PM · Restricted Project
xbolva00 updated the diff for D64859: [InstCombine] strncmp(x,y,strlen(x|y)+1) -> strcmp(x,y).

Added multi-use tests.

Wed, Jul 17, 4:46 AM · Restricted Project
xbolva00 added a reviewer for D64859: [InstCombine] strncmp(x,y,strlen(x|y)+1) -> strcmp(x,y): spatel.
Wed, Jul 17, 4:38 AM · Restricted Project
xbolva00 added inline comments to D64859: [InstCombine] strncmp(x,y,strlen(x|y)+1) -> strcmp(x,y).
Wed, Jul 17, 4:38 AM · Restricted Project
xbolva00 created D64859: [InstCombine] strncmp(x,y,strlen(x|y)+1) -> strcmp(x,y).
Wed, Jul 17, 4:32 AM · Restricted Project

Tue, Jul 16

xbolva00 added inline comments to D64838: [Attr] Support _attribute__ ((fallthrough)).
Tue, Jul 16, 4:52 PM · Restricted Project
xbolva00 added a comment to D64838: [Attr] Support _attribute__ ((fallthrough)).

Thanks, I think this is fine solution for now.

Tue, Jul 16, 4:43 PM · Restricted Project
xbolva00 added inline comments to D64838: [Attr] Support _attribute__ ((fallthrough)).
Tue, Jul 16, 4:37 PM · Restricted Project
xbolva00 added inline comments to D64512: [InstCombine] Dropping redundant masking before left-shift [0/5] (PR42563).
Tue, Jul 16, 6:37 AM · Restricted Project
xbolva00 accepted D64512: [InstCombine] Dropping redundant masking before left-shift [0/5] (PR42563).

Looks fine

Tue, Jul 16, 5:41 AM · Restricted Project
xbolva00 added reviewers for D64483: [CMake] Define _FILE_OFFSET_BITS=64 on Solaris: tstellar, hans.
Tue, Jul 16, 2:44 AM · Restricted Project
xbolva00 added a reviewer for D64713: [InstCombine] X *fast (C ? 1.0 : 0.0) -> C ? X : 0.0: lebedev.ri.
Tue, Jul 16, 2:17 AM · Restricted Project

Mon, Jul 15

xbolva00 added reviewers for D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss: aaron.ballman, efriedma.
Mon, Jul 15, 12:06 PM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Revert unneeded change.

Mon, Jul 15, 10:50 AM · Restricted Project
xbolva00 updated subscribers of D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss.

Probably @aaron.ballman would like to review this too..

Mon, Jul 15, 10:45 AM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.
Mon, Jul 15, 8:09 AM · Restricted Project
xbolva00 added inline comments to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.
Mon, Jul 15, 8:07 AM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Updated.

Mon, Jul 15, 8:06 AM · Restricted Project
xbolva00 updated the summary of D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.
Mon, Jul 15, 8:05 AM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.
Mon, Jul 15, 4:57 AM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.
Mon, Jul 15, 4:56 AM · Restricted Project
xbolva00 added a comment to D60761: [FunctionAttrs] Remove readonly and writeonly assertion.

Thanks. I wanted to land it for you, but since I dont use monorepo now, it does not apply well for me.

Mon, Jul 15, 4:52 AM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Check if prefix is unique.

Mon, Jul 15, 4:49 AM · Restricted Project
xbolva00 added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

FileCheck says
"Prefixes must be unique, *start with a letter* and contain only alphanumeric characters, hyphens and underscores"

Mon, Jul 15, 4:46 AM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Handle empty prefixes.

Mon, Jul 15, 4:43 AM · Restricted Project
xbolva00 added inline comments to D64713: [InstCombine] X *fast (C ? 1.0 : 0.0) -> C ? X : 0.0.
Mon, Jul 15, 4:23 AM · Restricted Project
xbolva00 added inline comments to D64713: [InstCombine] X *fast (C ? 1.0 : 0.0) -> C ? X : 0.0.
Mon, Jul 15, 4:21 AM · Restricted Project
xbolva00 added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

@gbedwell Thanks for ideas!

Mon, Jul 15, 4:18 AM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Reworked to use regex to check prefixes.

Mon, Jul 15, 4:17 AM · Restricted Project
xbolva00 added inline comments to D64713: [InstCombine] X *fast (C ? 1.0 : 0.0) -> C ? X : 0.0.
Mon, Jul 15, 3:26 AM · Restricted Project
xbolva00 added a comment to D64713: [InstCombine] X *fast (C ? 1.0 : 0.0) -> C ? X : 0.0.

b) yes, one more test never hurts
c) e.g.; broken precondition, missing 'fast' ?

Mon, Jul 15, 3:20 AM · Restricted Project
xbolva00 added a comment to D64713: [InstCombine] X *fast (C ? 1.0 : 0.0) -> C ? X : 0.0.

Not sure how other reviewers, but I consider the use of 'C' as confusing here, since 'C' is usually a constant. I would recommend to avoid 'C', if it is not a constant.

Mon, Jul 15, 2:41 AM · Restricted Project
xbolva00 added a comment to D64713: [InstCombine] X *fast (C ? 1.0 : 0.0) -> C ? X : 0.0.

I think we need a few more tests here

Mon, Jul 15, 2:39 AM · Restricted Project
xbolva00 added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Any futher comments?

Mon, Jul 15, 2:16 AM · Restricted Project

Sun, Jul 14

xbolva00 added reviewers for D55107: Prototype BasicAA improvements for discussion on llvm-dev: george.burgess.iv, hfinkel, asbirlea.
Sun, Jul 14, 2:13 PM
xbolva00 added a comment to D59349: Let CorrelatedValuePropagation preserve LazyValueInfo.

Please rebase

Sun, Jul 14, 2:08 PM · Restricted Project

Sat, Jul 13

xbolva00 added inline comments to D64697: [GitSVN][NFC] Mark dry-run commits as such in the log output.
Sat, Jul 13, 10:24 AM · Restricted Project

Fri, Jul 12

xbolva00 added inline comments to rG000ba715ddbd: [DirectoryWatcher][NFC] Silence warnings in release build.
Fri, Jul 12, 3:30 PM
xbolva00 added inline comments to D63923: [Loop Peeling] Enable peeling for loops with multiple exits.
Fri, Jul 12, 3:23 PM · Restricted Project
xbolva00 added inline comments to D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss.
Fri, Jul 12, 3:13 PM · Restricted Project
xbolva00 added a comment to D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss.

You can check also https://reviews.llvm.org/D52835. I hit there issue which I didn't know how to solve.

Hi David,

Can you elaborate what issues you encountered? Thank you.

Fri, Jul 12, 3:06 PM · Restricted Project
xbolva00 added a comment to D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss.

You can check also https://reviews.llvm.org/D52835. I hit there issue which I didn't know how to solve.

Fri, Jul 12, 2:29 PM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Add checker to all update scripts.

Fri, Jul 12, 2:21 PM · Restricted Project
xbolva00 committed rG9f0d718c6628: [InstCombine] Disable fold from D64285 for non-integer types (authored by xbolva00).
[InstCombine] Disable fold from D64285 for non-integer types
Fri, Jul 12, 2:16 PM
xbolva00 added a comment to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

if (Bitwidth == 0) {

  IC->dump();
}

%cmp.i = icmp ne %struct.LIST_HELP* %List.addr.0, null

Yep, its a pointer. Just disable the transform if !CmpRHs->getType()->isIntOrIntVectorTy()

Fri, Jul 12, 2:16 PM · Restricted Project
xbolva00 committed rL365959: [InstCombine] Disable fold from D64285 for non-integer types.
[InstCombine] Disable fold from D64285 for non-integer types
Fri, Jul 12, 2:15 PM
xbolva00 added a comment to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

getScalarSizeInBits probably returns 0 for pointers. Only DataLayout knows pointer size.

Fri, Jul 12, 2:02 PM · Restricted Project
xbolva00 added a comment to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

%cmp.i = icmp ne %struct.LIST_HELP* %List.addr.0, null

Fri, Jul 12, 2:01 PM · Restricted Project
xbolva00 added inline comments to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).
Fri, Jul 12, 1:41 PM · Restricted Project
xbolva00 added a comment to D60761: [FunctionAttrs] Remove readonly and writeonly assertion.

Hopefully not!
Also just a heads up, I don't have commit access to land this

Fri, Jul 12, 12:54 PM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Also check IR.

Fri, Jul 12, 11:25 AM · Restricted Project
xbolva00 added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

is there anyway that we could move this to common.py so we can reuse it in the other update scripts?

Fri, Jul 12, 9:56 AM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Moved to common.

Fri, Jul 12, 9:56 AM · Restricted Project
xbolva00 added a reviewer for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option: nikic.
Fri, Jul 12, 9:20 AM · Restricted Project
xbolva00 committed rGaf1b3185f55b: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X… (authored by xbolva00).
[InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X…
Fri, Jul 12, 4:32 AM
xbolva00 committed rL365893: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X….
[InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X…
Fri, Jul 12, 4:31 AM
xbolva00 closed D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).
Fri, Jul 12, 4:31 AM · Restricted Project

Thu, Jul 11

xbolva00 added a comment to D64376: [MBP] Avoid tail duplication if it can't bring benefit.

What about CTMark? SPEC?

Thu, Jul 11, 4:07 PM · Restricted Project
xbolva00 added a reviewer for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option: craig.topper.
Thu, Jul 11, 2:38 PM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Renamed variable.

Thu, Jul 11, 2:38 PM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.
Thu, Jul 11, 2:35 PM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Improved.

Thu, Jul 11, 2:32 PM · Restricted Project
xbolva00 added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

I'm not confident that will do the right thing. (i expect this to have some false-negatives, iff it is allowed to specify -check-prefix= more than once)
I see two paths:

  1. split the runline by whitespace, and check every element that starts with -check-prefix= that it does not contain ,. Will not have false-positives and no false-negatives, but kinda ugly.
  2. Revert to the previous diff, complain if there are any -check-prefix= IFF we had more than a single prefix; the warning will need to be changed - it will have false-positives - so it is more of a stylistic guideline.
Thu, Jul 11, 2:32 PM · Restricted Project
xbolva00 added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

^ This won't be detected, not sure if worth to match. What do you think?

Thu, Jul 11, 2:02 PM · Restricted Project
xbolva00 added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

Thank you, i have stumbled into this a few times :)

To be noted, the problem is: --check-prefix=A,B,C.
But i'm not sure about --check-prefix=A --check-prefix=B --check-prefix=C.

Thu, Jul 11, 1:57 PM · Restricted Project
xbolva00 updated the diff for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

More precise checker.

Thu, Jul 11, 1:57 PM · Restricted Project
xbolva00 added reviewers for D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option: spatel, RKSimon.
Thu, Jul 11, 1:44 PM · Restricted Project
xbolva00 created D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.
Thu, Jul 11, 1:42 PM · Restricted Project
xbolva00 added a comment to D64589: [UpdateTestChecks] Emit warning when invalid value for -check-prefix(es) option.

lebedev.ri hit this recently so I added him as reviewer.

Thu, Jul 11, 1:42 PM · Restricted Project
xbolva00 committed rGfcffa7c201c6: [UpdateTestChecks] Emit warning when invalid test paths (authored by xbolva00).
[UpdateTestChecks] Emit warning when invalid test paths
Thu, Jul 11, 1:15 PM
xbolva00 committed rL365818: [UpdateTestChecks] Emit warning when invalid test paths.
[UpdateTestChecks] Emit warning when invalid test paths
Thu, Jul 11, 1:14 PM
xbolva00 closed D64572: [UpdateTestChecks] Emit warning when invalid test paths.
Thu, Jul 11, 1:14 PM · Restricted Project
xbolva00 added a comment to D64572: [UpdateTestChecks] Emit warning when invalid test paths.

Thank you all!

Thu, Jul 11, 1:14 PM · Restricted Project
xbolva00 added a comment to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

It should be fine now.

Thu, Jul 11, 12:43 PM · Restricted Project
xbolva00 updated the diff for D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

Fixes

Thu, Jul 11, 12:42 PM · Restricted Project
xbolva00 committed rG5dca95bc4e07: [NFC] Revisited tests for D64285 (authored by xbolva00).
[NFC] Revisited tests for D64285
Thu, Jul 11, 12:40 PM
xbolva00 committed rL365815: [NFC] Revisited tests for D64285.
[NFC] Revisited tests for D64285
Thu, Jul 11, 12:40 PM
xbolva00 updated the diff for D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).
Thu, Jul 11, 12:32 PM · Restricted Project
xbolva00 added a comment to D64572: [UpdateTestChecks] Emit warning when invalid test paths.

Maybe @spatel would like to leave a comment too?

Thu, Jul 11, 12:22 PM · Restricted Project
xbolva00 added a reviewer for D64572: [UpdateTestChecks] Emit warning when invalid test paths: nikic.
Thu, Jul 11, 12:22 PM · Restricted Project
xbolva00 updated the diff for D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

Updated..

Thu, Jul 11, 12:19 PM · Restricted Project
xbolva00 added a comment to D64285: [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y)).

(yeah, I saw this missed optimization on the rust github issue tracker)

Thu, Jul 11, 9:53 AM · Restricted Project
xbolva00 added a comment to D64572: [UpdateTestChecks] Emit warning when invalid test paths.

LGTM.

Thu, Jul 11, 9:44 AM · Restricted Project
xbolva00 retitled D64572: [UpdateTestChecks] Emit warning when invalid test paths from [UpdateTestChecks] Emit error when invalid test paths to [UpdateTestChecks] Emit warning when invalid test paths.
Thu, Jul 11, 9:44 AM · Restricted Project
xbolva00 updated the diff for D64572: [UpdateTestChecks] Emit warning when invalid test paths.

Improve code, emit warning instead of error.

Thu, Jul 11, 9:43 AM · Restricted Project