Page MenuHomePhabricator

xbolva00 (Dávid Bolvanský)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2018, 5:18 PM (49 w, 4 d)

Recent Activity

Today

xbolva00 added a reviewer for D59534: Enable tail call in MemCpyOptimization: efriedma.
Tue, Mar 19, 6:20 AM · Restricted Project

Fri, Mar 15

xbolva00 added a comment to D58882: [Diagnostics] Address of a standard library function.

Ping

Fri, Mar 15, 2:08 AM · Restricted Project

Mon, Mar 11

xbolva00 added a comment to D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.

Ping

Mon, Mar 11, 5:17 AM · Restricted Project

Sat, Mar 9

xbolva00 added inline comments to D58878: [Diagnostics] Warn for assignments in bool contexts.
Sat, Mar 9, 5:02 AM · Restricted Project

Fri, Mar 8

xbolva00 added a comment to rL355733: [RegionPass] Fix forgotten "!"..

There are no tests which would catch this issue ?

Fri, Mar 8, 1:29 PM

Thu, Mar 7

xbolva00 added a comment to D58878: [Diagnostics] Warn for assignments in bool contexts.

Addressed notes.

Thu, Mar 7, 7:04 AM · Restricted Project
xbolva00 updated the diff for D58878: [Diagnostics] Warn for assignments in bool contexts.
Thu, Mar 7, 7:04 AM · Restricted Project

Sat, Mar 2

xbolva00 updated the diff for D58882: [Diagnostics] Address of a standard library function.
Sat, Mar 2, 11:52 PM · Restricted Project
xbolva00 updated the diff for D58882: [Diagnostics] Address of a standard library function.

Removed extra new line, changed test

Sat, Mar 2, 11:52 PM · Restricted Project
xbolva00 created D58882: [Diagnostics] Address of a standard library function.
Sat, Mar 2, 11:33 PM · Restricted Project
xbolva00 created D58878: [Diagnostics] Warn for assignments in bool contexts.
Sat, Mar 2, 1:19 PM · Restricted Project
xbolva00 resigned from D57367: [DAGCombine] Do several rounds of combine for nodes using SimplifyDemandedBits..
Sat, Mar 2, 12:38 PM · Restricted Project

Fri, Mar 1

xbolva00 added inline comments to D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.
Fri, Mar 1, 12:54 PM · Restricted Project
xbolva00 added a comment to D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.
Fri, Mar 1, 12:39 PM · Restricted Project
xbolva00 updated the diff for D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.

Remove from -Wextra

Fri, Mar 1, 12:10 PM · Restricted Project
xbolva00 updated the summary of D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.
Fri, Mar 1, 11:24 AM · Restricted Project
xbolva00 added a reviewer for D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility: aaron.ballman.
Fri, Mar 1, 11:21 AM · Restricted Project
xbolva00 updated the summary of D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.
Fri, Mar 1, 11:11 AM · Restricted Project
xbolva00 created D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.
Fri, Mar 1, 11:10 AM · Restricted Project

Wed, Feb 27

xbolva00 added a comment to D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher.

Maybe move it to LLVM? As this watcher may be useful for other projects in the future?

Wed, Feb 27, 11:34 AM · Restricted Project
xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

@aaron.ballman does it make sense to warn for this case only in C mode? Since this case in C++ is handled by -Wnarrowing, as we see from tests.

Wed, Feb 27, 11:13 AM

Tue, Feb 26

xbolva00 added a comment to D57779: [SLP] Add support for throttling..

Since cost computing was changed, can you rerun spec benchmarks?

Tue, Feb 26, 6:01 AM
xbolva00 added inline comments to D57779: [SLP] Add support for throttling..
Tue, Feb 26, 5:58 AM

Mon, Feb 25

xbolva00 added inline comments to D58541: [CodeComplete] Propagate preferred type for function arguments in more cases.
Mon, Feb 25, 3:03 AM · Restricted Project, Restricted Project

Feb 5 2019

xbolva00 added inline comments to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..
Feb 5 2019, 12:01 AM · Restricted Project

Feb 2 2019

xbolva00 added a reverting change for D52835: [Diagnostics] Check integer to floating point number implicit conversions: rG3cc2ef80d1a7: Reverted D52835 to fix review comments.
Feb 2 2019, 9:24 AM

Feb 1 2019

Herald added a project to D57220: Test fix for isViableInline remark message: Restricted Project.
Feb 1 2019, 8:03 AM · Restricted Project

Jan 31 2019

xbolva00 added inline comments to D57445: [ARM] Fix TTI IntImmCost.
Jan 31 2019, 6:02 AM
xbolva00 accepted D57089: Provide reason messages for unviable inlining.

Looks fine for me

Jan 31 2019, 3:27 AM · Restricted Project

Jan 29 2019

xbolva00 added a comment to rLLD352459: [MinGW] Ignore the --plugin and --plugin-opt option.

Possibly backport it to 8.0 ? (In time for GCC 9)

Jan 29 2019, 3:19 AM

Jan 27 2019

xbolva00 added inline comments to D33587: [DAGCombine] Do several rounds of combine..
Jan 27 2019, 10:12 AM · Restricted Project

Jan 25 2019

xbolva00 added inline comments to D57089: Provide reason messages for unviable inlining.
Jan 25 2019, 7:56 AM · Restricted Project
xbolva00 added inline comments to D57089: Provide reason messages for unviable inlining.
Jan 25 2019, 6:54 AM · Restricted Project

Jan 24 2019

xbolva00 added inline comments to D56796: [DAGCombiner][x86] add transform/hook to vectorize: cast(extract V, Y).
Jan 24 2019, 3:34 AM

Jan 22 2019

xbolva00 added inline comments to D57018: Fix lvm::is_trivially_copyable portability issues.
Jan 22 2019, 1:34 AM

Jan 1 2019

xbolva00 added a comment to D49966: [X86] Performing DAG pruning before selection of LEA instructions..

https://godbolt.org/z/0ZOx52

Jan 1 2019, 3:15 PM
xbolva00 added a comment to D49966: [X86] Performing DAG pruning before selection of LEA instructions..

Does this handle also e.g.

Jan 1 2019, 2:51 AM

Dec 31 2018

xbolva00 added a comment to D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case).

Ok, so create new revision with tests? Somebody will commit it for you.

Dec 31 2018, 7:09 AM · Restricted Project

Dec 30 2018

xbolva00 committed rL350162: [NFC] Fixed extra semicolon warning.
[NFC] Fixed extra semicolon warning
Dec 30 2018, 5:23 AM

Dec 24 2018

xbolva00 added a reviewer for D56057: [X86] Individually simplify both operands of PMULDQ/PMULUDQ using the other entry point of SimplifyDemandedBits that allows the one use check of the root node to be suppressed.: chandlerc.
Dec 24 2018, 3:01 AM

Dec 21 2018

xbolva00 added reviewers for D53765: [RFC prototype] Implementation of asm-goto support in LLVM: hfinkel, efriedma, chandlerc.
Dec 21 2018, 1:20 PM · Restricted Project

Dec 20 2018

xbolva00 added inline comments to D52002: Omit range checks from jump tables when lowering switches with unreachable default.
Dec 20 2018, 5:23 AM · Restricted Project

Dec 16 2018

xbolva00 added inline comments to D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Dec 16 2018, 1:24 PM

Dec 5 2018

xbolva00 added a comment to D55186: [eh-simplify] SelfReview.

Nice work!

Dec 5 2018, 2:39 PM

Nov 28 2018

xbolva00 requested review of D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Nov 28 2018, 2:58 PM
xbolva00 updated the diff for D52835: [Diagnostics] Check integer to floating point number implicit conversions.
  • Updated. Addressed review comments.
Nov 28 2018, 2:57 PM

Nov 25 2018

xbolva00 added inline comments to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Nov 25 2018, 11:35 AM

Nov 23 2018

xbolva00 added a comment to D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case).

Btw, why we do not this transformation on IR-level at first?

Nov 23 2018, 4:18 PM · Restricted Project

Nov 22 2018

xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

I have no idea how to fix Clang side :/

Okay. Does that need to happen as a prerequisite to this patch?

Nov 22 2018, 7:25 AM
xbolva00 added inline comments to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Nov 22 2018, 1:48 AM

Nov 21 2018

xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

I have no idea how to fix Clang side :/

Nov 21 2018, 10:20 PM

Nov 20 2018

xbolva00 added inline comments to D54593: [X86] Fix PR39658: avoid duplicated successors in condibr merge.
Nov 20 2018, 4:37 PM

Nov 19 2018

xbolva00 added inline comments to D52653: [CodeGen, AArch64] Combine Interleaved Loads which are not covered by the Vectorizer.
Nov 19 2018, 10:39 AM

Nov 18 2018

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

I removed _Float16 related tests since some bots may fall with it, i dont know much about this custom type.
Anyway, It is fine on linux x86 64. I will restore them.

Nov 18 2018, 9:13 AM

Nov 17 2018

xbolva00 updated the diff for D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Addressed comments, fixed tests

Nov 17 2018, 5:30 AM

Nov 15 2018

xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Ping :)

Nov 15 2018, 4:53 AM
xbolva00 added a comment to D54571: [WebAssembly] Split BBs after throw instructions.

Sorry for little offtopic at first.

Nov 15 2018, 1:39 AM

Nov 14 2018

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Ok, I will address your comments soon.

Nov 14 2018, 6:31 AM
xbolva00 committed rL346866: Reverted D52835 to fix review comments.
Reverted D52835 to fix review comments
Nov 14 2018, 6:30 AM
xbolva00 committed rC346866: Reverted D52835 to fix review comments.
Reverted D52835 to fix review comments
Nov 14 2018, 6:30 AM
xbolva00 reopened D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Nov 14 2018, 6:30 AM
xbolva00 committed rL346865: [Diagnostics] Check integer to floating point number implicit conversions.
[Diagnostics] Check integer to floating point number implicit conversions
Nov 14 2018, 6:27 AM
xbolva00 committed rC346865: [Diagnostics] Check integer to floating point number implicit conversions.
[Diagnostics] Check integer to floating point number implicit conversions
Nov 14 2018, 6:27 AM
xbolva00 closed D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Nov 14 2018, 6:27 AM
xbolva00 accepted D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Nov 14 2018, 6:09 AM

Nov 12 2018

xbolva00 added a comment to D53706: [MultiTailCallElimination]: Pass to eliminate multiple tail calls.

Very interesting work!

Nov 12 2018, 6:56 AM

Nov 11 2018

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Since no futher comments, i think it is ok.
After day or two I will commit it.

Nov 11 2018, 7:46 AM

Nov 9 2018

xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Ping

Nov 9 2018, 1:26 PM

Nov 7 2018

xbolva00 added a comment to D53554: [Argument Promotion] Only promote args when function attributes are compatible.

@echristo wanted to look at this

Nov 7 2018, 10:28 AM
xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

@aaron.ballman

Nov 7 2018, 9:58 AM

Nov 6 2018

xbolva00 added a comment to D52109: [TwoAddressInstructionPass] Don't update SrcRegMap for copies inserted for tied register constraint when the src isn't killed.

Any benchmark results w/o this patch?

Nov 6 2018, 3:25 PM

Nov 5 2018

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Ping :)

Nov 5 2018, 1:28 AM

Nov 4 2018

xbolva00 added inline comments to rLLDB346093: NativeProcessProtocol: Simplify breakpoint setting code.
Nov 4 2018, 4:22 AM

Nov 3 2018

xbolva00 updated the diff for D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Nov 3 2018, 4:18 PM

Nov 1 2018

xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Since I don't think we have any false positives here, maybe it would be useful to add it to -Wall or -Wextra?

Nov 1 2018, 9:48 AM
xbolva00 committed rC345847: [Diagnostics] Implement -Wsizeof-pointer-div .
[Diagnostics] Implement -Wsizeof-pointer-div
Nov 1 2018, 9:30 AM
xbolva00 committed rL345847: [Diagnostics] Implement -Wsizeof-pointer-div .
[Diagnostics] Implement -Wsizeof-pointer-div
Nov 1 2018, 9:30 AM
xbolva00 closed D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
Nov 1 2018, 9:29 AM
xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

maybe @aaron.ballman wants to take a look too

Nov 1 2018, 7:36 AM
xbolva00 added a comment to D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
  • Addressed review comments.
Nov 1 2018, 6:46 AM
xbolva00 updated the diff for D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
Nov 1 2018, 6:43 AM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Ping

Nov 1 2018, 1:56 AM

Oct 31 2018

xbolva00 added reviewers for D52835: [Diagnostics] Check integer to floating point number implicit conversions: aaron.ballman, efriedma.
Oct 31 2018, 2:14 PM
xbolva00 added a reviewer for D52949: [Diagnostics] Implement -Wsizeof-pointer-div : aaron.ballman.
Oct 31 2018, 2:14 PM
xbolva00 added a comment to D45444: [clang-tidy] implement new check for const-correctness.

Are you still looking at this?

Oct 31 2018, 12:33 PM
xbolva00 committed rLLDB345755: [NFC] Fixed -Wsign-compare warning.
[NFC] Fixed -Wsign-compare warning
Oct 31 2018, 11:06 AM
xbolva00 committed rL345755: [NFC] Fixed -Wsign-compare warning.
[NFC] Fixed -Wsign-compare warning
Oct 31 2018, 11:06 AM
xbolva00 added a comment to D52835: [Diagnostics] Check integer to floating point number implicit conversions.

Anything else to be done here? I would like to finish this patch to work on other things.

Oct 31 2018, 8:00 AM
xbolva00 updated the diff for D52949: [Diagnostics] Implement -Wsizeof-pointer-div .
  • New warning text, added another test line
Oct 31 2018, 7:55 AM
xbolva00 committed rL345721: [DAGCombiner] Fold 0 div/rem X to 0.
[DAGCombiner] Fold 0 div/rem X to 0
Oct 31 2018, 7:22 AM
xbolva00 closed D52504: [DAGCombiner] Fold 0 div/rem X to 0.
Oct 31 2018, 7:22 AM
xbolva00 retitled D52504: [DAGCombiner] Fold 0 div/rem X to 0 from [DAGCombiner] Div/rem folds to [DAGCombiner] Fold 0 div/rem X to 0.
Oct 31 2018, 7:08 AM
xbolva00 added a comment to D52504: [DAGCombiner] Fold 0 div/rem X to 0.

Sanjay's changes don't seem to be rebased ?

Oct 31 2018, 6:44 AM
xbolva00 updated the diff for D52504: [DAGCombiner] Fold 0 div/rem X to 0.
Oct 31 2018, 6:44 AM
xbolva00 updated the diff for D53666: [Tests] Updated tests for D53342.
Oct 31 2018, 6:44 AM
xbolva00 updated the diff for D53666: [Tests] Updated tests for D53342.
Oct 31 2018, 6:43 AM
xbolva00 added inline comments to D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5).
Oct 31 2018, 6:30 AM

Oct 30 2018

xbolva00 updated the diff for D52504: [DAGCombiner] Fold 0 div/rem X to 0.
  • Rebased
Oct 30 2018, 3:18 PM
xbolva00 committed rL345665: [ARM][NFC] Make tests immune to better div optimizations.
[ARM][NFC] Make tests immune to better div optimizations
Oct 30 2018, 3:10 PM
xbolva00 closed D53901: [ARM][NFC] Make tests immune to better div optimizations.
Oct 30 2018, 3:10 PM