- User Since
- Apr 5 2018, 5:18 PM (67 w, 3 d)
Sat, Jul 20
Fri, Jul 19
Should be backported to 9.0 branch?
It would be nice to merge this fix into 9.0 branch after some time in trunk. What do you think?
Thu, Jul 18
(should be probably reverted from 9.0 branch)
Can you provide benchmark results from "public" ones like SPEC or LLVM test-suite? I think this should be mandatory to land performance critical patches (always provide results from SPEC/test suite).
Wed, Jul 17
Added multi-use tests.
Tue, Jul 16
Thanks, I think this is fine solution for now.
Mon, Jul 15
Revert unneeded change.
Probably @aaron.ballman would like to review this too..
Thanks. I wanted to land it for you, but since I dont use monorepo now, it does not apply well for me.
Check if prefix is unique.
"Prefixes must be unique, *start with a letter* and contain only alphanumeric characters, hyphens and underscores"
Handle empty prefixes.
@gbedwell Thanks for ideas!
Reworked to use regex to check prefixes.
b) yes, one more test never hurts
c) e.g.; broken precondition, missing 'fast' ?
Not sure how other reviewers, but I consider the use of 'C' as confusing here, since 'C' is usually a constant. I would recommend to avoid 'C', if it is not a constant.
I think we need a few more tests here
Any futher comments?
Sun, Jul 14
Sat, Jul 13
Fri, Jul 12
You can check also https://reviews.llvm.org/D52835. I hit there issue which I didn't know how to solve.
Add checker to all update scripts.
%cmp.i = icmp ne %struct.LIST_HELP* %List.addr.0, null
Also check IR.
Moved to common.
Thu, Jul 11
What about CTMark? SPEC?
^ This won't be detected, not sure if worth to match. What do you think?
More precise checker.
lebedev.ri hit this recently so I added him as reviewer.
Thank you all!
It should be fine now.
Maybe @spatel would like to leave a comment too?
(yeah, I saw this missed optimization on the rust github issue tracker)
Improve code, emit warning instead of error.