Page MenuHomePhabricator

xbolva00 (Dávid Bolvanský)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2018, 5:18 PM (220 w, 6 d)

Recent Activity

Yesterday

xbolva00 added a comment to D128364: [InstCombine] Look through more casts when folding memchr and memcmp.

Maybe reland with better patch title as this patch affects more libcalls than just two ones?

Wed, Jun 29, 1:28 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D127604: [SLP][X86] Add 32-bit vector stores to help vectorization opportunities.

Does anybody see any major regressions?

Wed, Jun 29, 5:07 AM · Restricted Project, Restricted Project

Tue, Jun 28

xbolva00 added a comment to D127392: [InstCombine] Combine consecutive loads which are being merged to form a wider load..

We also see some use scenarios of TTI in InstCombine

Tue, Jun 28, 9:20 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D128645: Update developer policy..
Tue, Jun 28, 9:18 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D128645: Update developer policy..
Tue, Jun 28, 8:59 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D128645: Update developer policy..
Tue, Jun 28, 8:27 AM · Restricted Project, Restricted Project

Sat, Jun 25

xbolva00 added a comment to D128582: Enable SeparateConstOffsetFromGEPPass() at -O3 and -O2.

Missing context
Missing test
x264_r regression is big one..

Sat, Jun 25, 6:40 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.

-fsanitize=array-bounds workaround for size-1 array as the last member of a structure

Sat, Jun 25, 2:09 AM · Restricted Project, Restricted Project

Thu, Jun 23

xbolva00 added a comment to D128407: Undefined behaviour in Support/DJB.h.

Thanks for your comment.

You are completely right. I got misled by the output
SUMMARY: UndefinedbehaviorSanitizer, but after googling the message I
realised that this was a check added to integer in 2020 as you correctly
pointed out.

I am happy for this suggestion to be closed.

Thu, Jun 23, 6:10 AM · Restricted Project, Restricted Project

Wed, Jun 22

xbolva00 added a comment to D128011: [SimplifyLibCalls] Transform memchr(STR, C, N) to chain of ORs.

We don't want to limit the total number of characters being checked, but rather the number of of non-contiguous ranges.

Wed, Jun 22, 12:11 PM · Restricted Project, Restricted Project
xbolva00 added a reviewer for D128364: [InstCombine] Look through more casts when folding memchr and memcmp: efriedma.
Wed, Jun 22, 11:02 AM · Restricted Project, Restricted Project
xbolva00 accepted D127460: Rename GCCBuiltin into ClangBuiltin.
Wed, Jun 22, 5:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
xbolva00 added a comment to D128011: [SimplifyLibCalls] Transform memchr(STR, C, N) to chain of ORs.

Ping

Wed, Jun 22, 4:09 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D127460: Rename GCCBuiltin into ClangBuiltin.

This is my first LLVM contribution so I don't think I do? If I do have a commit access anyway, do you have a link to the documentation where it explains what I'm supposed to do by any chance?

Wed, Jun 22, 3:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
xbolva00 requested changes to D127460: Rename GCCBuiltin into ClangBuiltin.

Patch description needs to be added, especially answer the question why we should rename it, why we want it..

Wed, Jun 22, 3:06 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sun, Jun 19

xbolva00 added a comment to D127604: [SLP][X86] Add 32-bit vector stores to help vectorization opportunities.

@dtemirbulatov thanks, looks neutral.

Sun, Jun 19, 1:05 PM · Restricted Project, Restricted Project
xbolva00 updated the diff for D128011: [SimplifyLibCalls] Transform memchr(STR, C, N) to chain of ORs.

Update memchr.ll

Sun, Jun 19, 8:03 AM · Restricted Project, Restricted Project
xbolva00 added a reviewer for D128011: [SimplifyLibCalls] Transform memchr(STR, C, N) to chain of ORs: spatel.
Sun, Jun 19, 12:12 AM · Restricted Project, Restricted Project

Sat, Jun 18

xbolva00 added inline comments to D127812: [AArch64] Function multiversioning support added..
Sat, Jun 18, 10:33 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Fri, Jun 17

xbolva00 added a comment to D128011: [SimplifyLibCalls] Transform memchr(STR, C, N) to chain of ORs.

strchr is transformed to memchr, if possible. See test strchr_to_memchr_n_equals_len.

Fri, Jun 17, 8:13 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D128011: [SimplifyLibCalls] Transform memchr(STR, C, N) to chain of ORs.

This looks quite nice for the examples -- but can't this create a very large chain of comparisons in some cases? Like if you check every second character you'd end up with 128 comparisons? (Or maybe you need every third, I can imagine that we manage to fold every second character to am mask).

Fri, Jun 17, 6:32 AM · Restricted Project, Restricted Project
xbolva00 updated the diff for D128011: [SimplifyLibCalls] Transform memchr(STR, C, N) to chain of ORs.

Added PhaseOrdering test to ensure instcombine + simplifycfg produces optimal switch code.

Fri, Jun 17, 6:26 AM · Restricted Project, Restricted Project
xbolva00 retitled D128011: [SimplifyLibCalls] Transform memchr(STR, C, N) to chain of ORs from [SimplifyLibCalls] Transform memchr(STR C, N) to chain of ORs to [SimplifyLibCalls] Transform memchr(STR, C, N) to chain of ORs.
Fri, Jun 17, 5:15 AM · Restricted Project, Restricted Project

Thu, Jun 16

xbolva00 requested review of D128011: [SimplifyLibCalls] Transform memchr(STR, C, N) to chain of ORs.
Thu, Jun 16, 2:51 PM · Restricted Project, Restricted Project
xbolva00 committed rGcb111ef090c5: Reland "[NFC] Precommited tests from D73000" (authored by xbolva00).
Reland "[NFC] Precommited tests from D73000"
Thu, Jun 16, 11:39 AM · Restricted Project, Restricted Project
xbolva00 added a reverting change for rG814c9f4e0c4d: [NFC] Precommited tests from D73000: rGed72f40d0be7: Revert "[NFC] Precommited tests from D73000".
Thu, Jun 16, 11:39 AM · Restricted Project, Restricted Project
xbolva00 committed rGed72f40d0be7: Revert "[NFC] Precommited tests from D73000" (authored by xbolva00).
Revert "[NFC] Precommited tests from D73000"
Thu, Jun 16, 11:38 AM · Restricted Project, Restricted Project
xbolva00 committed rG814c9f4e0c4d: [NFC] Precommited tests from D73000 (authored by xbolva00).
[NFC] Precommited tests from D73000
Thu, Jun 16, 11:17 AM · Restricted Project, Restricted Project

Wed, Jun 15

xbolva00 retitled D127899: [MLInliner] Don't inline call sites in unreachable basic blocks from [inline] Don't inline call sites in unreachable basic blocks to [MLInliner] Don't inline call sites in unreachable basic blocks.
Wed, Jun 15, 3:22 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D127461: [SelectionDAG] Use __memcmpeq to replace bcmp and bool usage memcmp.

What do you think about just using the clang AST and checking if there is a valid definition for __memcmpeq + isGNUEnvironment?

Wed, Jun 15, 2:26 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..

Seems fine as well.

Wed, Jun 15, 12:28 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D125723: [MSVC] Add initial support for MSVC pragma optimize.

Thanks

Wed, Jun 15, 11:29 AM · Restricted Project, Restricted Project
xbolva00 added reviewers for D127461: [SelectionDAG] Use __memcmpeq to replace bcmp and bool usage memcmp: MaskRay, rnk.
Wed, Jun 15, 10:14 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D127461: [SelectionDAG] Use __memcmpeq to replace bcmp and bool usage memcmp.

Maybe new flag like -fglibc-version=ver ?

Wed, Jun 15, 10:13 AM · Restricted Project, Restricted Project
xbolva00 updated subscribers of D127461: [SelectionDAG] Use __memcmpeq to replace bcmp and bool usage memcmp.

Ideally LLVM should just "enable" memcmpeq if glibc version is > XYZ. Not sure if there is a realiable way to do it. @efriedma ?

Wed, Jun 15, 9:49 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D125723: [MSVC] Add initial support for MSVC pragma optimize.
Wed, Jun 15, 9:26 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..

I guess we can go with the flag being used by gcc: -fextra-libc-function=__memcmpeq.

Wed, Jun 15, 9:21 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D125723: [MSVC] Add initial support for MSVC pragma optimize.

LGTM! But given the number of people who've expressed opinions on this, please wait a day or two before landing in case other reviewers have additional feedback.

Wed, Jun 15, 9:12 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D125723: [MSVC] Add initial support for MSVC pragma optimize.
Wed, Jun 15, 9:11 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D127461: [SelectionDAG] Use __memcmpeq to replace bcmp and bool usage memcmp.

Clang side should match gcc’s https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596335.html

Wed, Jun 15, 8:39 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D127565: [Clang] New attribute optsize.
Wed, Jun 15, 6:06 AM · Restricted Project

Tue, Jun 14

xbolva00 added inline comments to D127565: [Clang] New attribute optsize.
Tue, Jun 14, 11:52 AM · Restricted Project
xbolva00 added a comment to D126984: [clang] Add support for optimize function attribute.

Also note that there is a '#pragma GCC optimize' pragma. After this patch, it should be hard to implement it.

Tue, Jun 14, 11:46 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..

See what you mean and why it might be necessary.

Tue, Jun 14, 10:35 AM · Restricted Project, Restricted Project
Herald added a project to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5).: Restricted Project.

@courbet Any followup as we have got "'__memcmpeq" ?

Tue, Jun 14, 10:33 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D125723: [MSVC] Add initial support for MSVC pragma optimize.

I would like to hear quite strong motivating words.

Tue, Jun 14, 8:57 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D127565: [Clang] New attribute optsize.
Tue, Jun 14, 8:54 AM · Restricted Project
xbolva00 added a comment to D126984: [clang] Add support for optimize function attribute.

That's not stopped us from exposing attributes like minsize (and you proposed optsize as well) which get described in the same terms as -Os/-Oz in our documentation, so this ship has somewhat sailed.

Tue, Jun 14, 8:41 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D125723: [MSVC] Add initial support for MSVC pragma optimize.

I think it's fine to implement this, but I wanted to share some of the motivation for the current state of things. In our experience, the majority of uses of pragma optimize were to work around MSVC compiler bugs. So, instead of honoring them, we felt it was best to ignore them with a warning (-Wignored-pragma-optimize). Of course, that warning is typically disabled in build systems of large projects, so our current behavior can still surprise users. Implementing the feature is probably the most predictable and least surprising thing Clang can do.

Something we can't easily support for either GCC or MSVC attribute is enabling optimizations for some functions in an -O0 build. Maybe it's now possible to set up a full pass pipeline after semantic analysis is complete, but it's not straightforward. You should consider what to do with that corner case.

Tue, Jun 14, 8:15 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D126984: [clang] Add support for optimize function attribute.

IIRC in the past there was a strong preference to not have the pass manager support this sort of thing
if you want to support this, there should be an RFC for how the optimization part of this will work as it may require invasive changes to the LLVM pass manager

(if this is purely a clang frontend thing then ignore me)

We actually should *not* make this a clang frontend only thing. It is confusing and not helpful. That said, we have code to integrate this into the new PM already as we were planning on proposing something along these lines too. We didn't manage to get to it during last years GSoC but the code could be used as a basis still.

+1 for RFC
strong preference for proper integration of this into the new PM.

I'm not opposed to an RFC to extend this functionality, but it seems to me that we have incremental progress already with this patch and landing this patch unblocks the work @steplong was originally doing for the MSVC pragma. Do you have a concern if we move forward with this less-functional form so that work isn't held up on an RFC for the more fully functional form?

Tue, Jun 14, 8:09 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D127565: [Clang] New attribute optsize.
Tue, Jun 14, 8:03 AM · Restricted Project
xbolva00 added a reviewer for D127726: [SimplifyCFG] Don't sink common code if PHI node with some GEPs is created: lebedev.ri.
Tue, Jun 14, 1:41 AM · Restricted Project, Restricted Project

Mon, Jun 13

xbolva00 added a comment to D126984: [clang] Add support for optimize function attribute.

If you compile file with -Ofast and use optimise(-Os) for F - I would expect no fast math flags for function F but I am worried a bit that only “optsize” is added. Plesse verify and/or add such test.

Mon, Jun 13, 2:35 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D126984: [clang] Add support for optimize function attribute.

Would that work for you (and you as well @aeubanks)?

Mon, Jun 13, 10:51 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D124071: [NewGVN][LoadCoercion][1/3] Add support for load coercion between store and load instructions.
Mon, Jun 13, 3:20 AM · Restricted Project, Restricted Project

Sun, Jun 12

xbolva00 added inline comments to rG1cf9b24da3b8: [DAG] Enable ISD::FSHL/R SimplifyMultipleUseDemandedBits handling inside….
Sun, Jun 12, 11:53 AM · Restricted Project, Restricted Project
xbolva00 added a reviewer for D127604: [SLP][X86] Add 32-bit vector stores to help vectorization opportunities: asbirlea.
Sun, Jun 12, 10:46 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D109368: [LV] Vectorize cases with larger number of RT checks, execute only if profitable..

The patch should not be blocked by other patches, or? or any blocker?

Sun, Jun 12, 9:47 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D124284: [SLP]Try partial store vectorization if supported by target..
Sun, Jun 12, 9:45 AM · Restricted Project, Restricted Project

Sat, Jun 11

xbolva00 added inline comments to rG684a82fbc543: [InstCombine] Remove unnecessary UB from some tests..
Sat, Jun 11, 3:57 PM · Restricted Project, Restricted Project
xbolva00 updated the summary of D127565: [Clang] New attribute optsize.
Sat, Jun 11, 2:50 AM · Restricted Project
xbolva00 added a reviewer for D127565: [Clang] New attribute optsize: steplong.
Sat, Jun 11, 2:50 AM · Restricted Project
xbolva00 added inline comments to D126984: [clang] Add support for optimize function attribute.
Sat, Jun 11, 2:45 AM · Restricted Project, Restricted Project
xbolva00 requested review of D127565: [Clang] New attribute optsize.
Sat, Jun 11, 2:42 AM · Restricted Project

Fri, Jun 10

xbolva00 added inline comments to D126984: [clang] Add support for optimize function attribute.
Fri, Jun 10, 2:04 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D126984: [clang] Add support for optimize function attribute.

But where I think this feature could be very useful in following case from gcc test suite where there is some FP computation..
Imagine you compile you program with -ffast-math and then you have function:

Fri, Jun 10, 1:59 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D126984: [clang] Add support for optimize function attribute.

Are you opposed to exposing #pragma optimize? (https://docs.microsoft.com/en-us/cpp/preprocessor/optimize?view=msvc-170) If yes, I think Stephen should run an RFC on Discourse to see if there's general agreement.

No, I like it, seems more useful and general than "pragma clang optimize on/off"

Are you opposed to the direction of condensing the optimization semantic attributes (the things in the AST) down into one? If yes, I'd like to understand why better.

No :)

Are you still opposed to exposing a neutered form of the GCC optimize attribute as a parsed attribute (the thing users write in their source)? If yes, that's fine by me, but then I'd still like to see most of this patch land, just without a way for the user to spell the attribute themselves. We can adjust the semantic attribute's enumeration to cover only the cases we want to support.

Fri, Jun 10, 1:49 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D126984: [clang] Add support for optimize function attribute.

"The optimize attribute should be used for debugging purposes only. It is not suitable in production code."

Fri, Jun 10, 12:49 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D126984: [clang] Add support for optimize function attribute.

I agree with @aeubanks , this feature requires major changes to pass manager and I see no value to land this currently.

I see that somebody may prefer “opt for size”, but this is exposed via “minsize” attribute so I see no strong need for optimize(“-Os”)

Fri, Jun 10, 12:23 PM · Restricted Project, Restricted Project
xbolva00 committed rGb3b08ad6239c: [Clang] Added missing doc for minsize attribute (authored by xbolva00).
[Clang] Added missing doc for minsize attribute
Fri, Jun 10, 12:19 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D126984: [clang] Add support for optimize function attribute.

[[gnu::optimize("O0")]] is okay but [[gnu::optimize("O3")]] is not gonna work without major changes. Not sure why we should deliver half-broken new attribute.

Fri, Jun 10, 12:02 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D126984: [clang] Add support for optimize function attribute.

I agree with @aeubanks , this feature requires major changes to pass manager and I see no value to land this currently.

Fri, Jun 10, 10:56 AM · Restricted Project, Restricted Project

Thu, Jun 9

xbolva00 added a comment to D125998: [Metadata] Add a resize capability to MDNodes and add a push_back interface to MDNodes..
Thu, Jun 9, 11:02 AM · Restricted Project, Restricted Project

Tue, Jun 7

xbolva00 added a comment to D127231: Restore isa<Ty>(X) asserts inside cast<Ty>(X).

Is it possible to create simple testcase?

Tue, Jun 7, 11:32 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D127202: [InlineFunction] Handle early exit during getUnderlyingObjects due to MaxLookup.

in AddAliasScopeMetadata: the default value of MaxLookup is not enough to identify the underlying object, and the alias info added by AddAliasScopeMetadata() is wrong, resulting in wrong schedule decisions in machine-scheduler.

Tue, Jun 7, 5:29 AM · Restricted Project, Restricted Project

Fri, Jun 3

xbolva00 added inline comments to D126885: [SLP]Cost for a constant buildvector..
Fri, Jun 3, 1:03 PM · Restricted Project, Restricted Project
xbolva00 added inline comments to D126864: [clang] Introduce -fstrict-flex-arrays=<n> for stricter handling of flexible arrays.
Fri, Jun 3, 7:14 AM · Restricted Project, Restricted Project

Thu, Jun 2

xbolva00 added a comment to D126885: [SLP]Cost for a constant buildvector..

Some unfortunate regressions

Thu, Jun 2, 8:38 AM · Restricted Project, Restricted Project

May 29 2022

xbolva00 added inline comments to D124284: [SLP]Try partial store vectorization if supported by target..
May 29 2022, 10:13 AM · Restricted Project, Restricted Project

May 27 2022

xbolva00 added a comment to D123819: [InstCombine] Fold strlen and strnlen recursively..

Cases like strlen (x ? s1 : s2) should be handled in more general fashion and rewrite fn (x ? s1 : s2) as x ? fn(s1) : fn(s2) if fn(s1) and (or?) fn(s2) can be optimized to just some (constant) value.

May 27 2022, 9:00 AM · Restricted Project, Restricted Project
Herald added a reviewer for D72386: [ThinLTO] pass UnrollLoops/VectorizeLoop/VectorizeSLP in CGOpts down to pass builder in ltobackend: MaskRay.
May 27 2022, 6:04 AM · Restricted Project, Restricted Project, Restricted Project

May 23 2022

xbolva00 added a comment to D126190: [InstCombine] Add combine for fcmp sqrt(x),C --> fcmp x,C*C.

Maybe also worth to check gcc's issues with this transformation:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91734

May 23 2022, 12:35 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D126190: [InstCombine] Add combine for fcmp sqrt(x),C --> fcmp x,C*C.

Is this “safe” even with fast math for all predicates?

May 23 2022, 8:29 AM · Restricted Project, Restricted Project

May 21 2022

xbolva00 added a comment to D126040: [InstCombine] Fold a mul with bool value into and.

Botan AES-128 benchmark, maybe others..

May 21 2022, 2:00 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D126040: [InstCombine] Fold a mul with bool value into and.

LG

May 21 2022, 1:11 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D126040: [InstCombine] Fold a mul with bool value into and.
May 21 2022, 1:11 AM · Restricted Project, Restricted Project

May 20 2022

xbolva00 added a comment to D126040: [InstCombine] Fold a mul with bool value into and.

Please rebase.

May 20 2022, 3:16 PM · Restricted Project, Restricted Project
xbolva00 added inline comments to D126040: [InstCombine] Fold a mul with bool value into and.
May 20 2022, 4:44 AM · Restricted Project, Restricted Project
xbolva00 added a reviewer for D126040: [InstCombine] Fold a mul with bool value into and: RKSimon.
May 20 2022, 4:40 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D126040: [InstCombine] Fold a mul with bool value into and.
May 20 2022, 12:38 AM · Restricted Project, Restricted Project

May 18 2022

xbolva00 added a comment to D125299: [ValueTracking] Enable -branch-on-poison-as-ub by default.

also Polly.DeLICM::pr41656.ll fails in precommit CI.

May 18 2022, 7:56 AM · Restricted Project, Restricted Project

May 17 2022

xbolva00 added inline comments to D84941: [JumpThreading] Let ProcessImpliedCondition look into freeze instructions.
May 17 2022, 4:51 AM · Restricted Project, Restricted Project

May 13 2022

xbolva00 added inline comments to D124284: [SLP]Try partial store vectorization if supported by target..
May 13 2022, 5:26 AM · Restricted Project, Restricted Project

May 10 2022

xbolva00 added a comment to D100780: [Passes] Add extra LoopSimplifyCFG run after IndVarSimplify..

This could be done by either exposing a simplifyLoopCFG helper function ...

May 10 2022, 3:38 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D125078: Implement a feature to show line numbers in diagnostics.

I support turning it on by default. I'm simply passing on the message.

May 10 2022, 10:32 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D125299: [ValueTracking] Enable -branch-on-poison-as-ub by default.
May 10 2022, 3:47 AM · Restricted Project, Restricted Project

May 9 2022

xbolva00 added a comment to D125078: Implement a feature to show line numbers in diagnostics.

I'm in favour of this, but @rsmith warned me a little while ago that we mightn't be able to have stuff like this on by default because scripts probably depend on specific compiler output. Hyrum's Law strikes again :(

(I personally think we should have it on by default and give a way to opt out, rather than opt in.)

May 9 2022, 10:04 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D125223: [Clang] Attribute musttail - adjust signature check.

It is not safe to change this in Clang only. As mentioned in https://github.com/llvm/llvm-project/issues/54964#issuecomment-1101667557, these rules would need to be loosed at both the Clang and LLVM levels.

If we change Clang only, it will produce LLVM IR that will fail to verify: https://github.com/llvm/llvm-project/blob/09c2b7c35af8c4bad39f03e9f60df8bd07323028/llvm/test/Verifier/musttail-invalid.ll#L13-L18

May 9 2022, 9:47 AM · Restricted Project
xbolva00 added a reviewer for D125223: [Clang] Attribute musttail - adjust signature check: aaron.ballman.
May 9 2022, 9:40 AM · Restricted Project
xbolva00 added a comment to D124633: [SimplifyLibCalls] Pointers passed to libcalls must point to valid objects.

This revision looks good to me. I suggest reviewing the rest of the folders for missing annotations and adding those in a follow up patch.

May 9 2022, 9:31 AM · Restricted Project, Restricted Project