Page MenuHomePhabricator

xbolva00 (Dávid Bolvanský)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2018, 5:18 PM (94 w, 4 d)

Recent Activity

Today

xbolva00 added a comment to D73387: [MBP] Partial tail duplication into hot predecessors.

Thanks!

Tue, Jan 28, 11:22 AM · Restricted Project
xbolva00 added inline comments to D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null..
Tue, Jan 28, 9:35 AM · Restricted Project

Yesterday

xbolva00 added inline comments to D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null..
Mon, Jan 27, 4:24 PM · Restricted Project
xbolva00 accepted D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null..

Thanks

Mon, Jan 27, 4:09 PM · Restricted Project
xbolva00 added a comment to D73410: [InstCombine] Push negation through multiply (PR44234).

Thanks on working on this

Mon, Jan 27, 12:53 PM · Restricted Project

Sun, Jan 26

xbolva00 added inline comments to D73428: [Attributor] Improve `noalias` deduction based on memory information.
Sun, Jan 26, 10:23 AM · Restricted Project
xbolva00 added inline comments to D73428: [Attributor] Improve `noalias` deduction based on memory information.
Sun, Jan 26, 6:07 AM · Restricted Project

Fri, Jan 24

xbolva00 added a comment to D73387: [MBP] Partial tail duplication into hot predecessors.

New improvements looks cool, any data for clang itself (large binary too)?

Fri, Jan 24, 4:09 PM · Restricted Project
xbolva00 added a comment to D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

Thanks, +1.

Fri, Jan 24, 3:50 PM · Restricted Project
xbolva00 added a comment to D73380: [clang] Annotating C++'s `operator new` with more attributes.

LLVM already infers noalias nonnull for eg. _Znwm so noalias and nonnull info added by clang will not increase power of LLVM. Or?

Fri, Jan 24, 1:40 PM · Restricted Project, Restricted Project
xbolva00 updated subscribers of D73235: [GlobalMerge] Preserve symbol visibility when merging globals.

Worth to backport @hans

Fri, Jan 24, 11:13 AM · Restricted Project
xbolva00 added inline comments to D71710: [instrinsics] Add @llvm.memcpy.inline instrinsics.
Fri, Jan 24, 4:43 AM · Restricted Project
xbolva00 added inline comments to D71710: [instrinsics] Add @llvm.memcpy.inline instrinsics.
Fri, Jan 24, 4:08 AM · Restricted Project

Wed, Jan 22

xbolva00 added a comment to D73099: [Alignment][NFC] Deprecate Align::None().

+1

Wed, Jan 22, 3:25 PM · Restricted Project, Restricted Project
xbolva00 added inline comments to D73181: [SCEV] Use backedge SCEV of PHI only if its input is loop invariant.
Wed, Jan 22, 9:36 AM · Restricted Project

Mon, Jan 20

xbolva00 updated subscribers of D73000: [InstCombine] Optimize strchr(cststr, C).
Mon, Jan 20, 11:22 AM · Restricted Project
xbolva00 updated subscribers of D73007: [Sema] Avoid Wrange-loop-analysis false positives.

Yes, but minimal fix is better for release branch, so @hans should merge it.

Mon, Jan 20, 8:42 AM · Restricted Project

Sun, Jan 19

xbolva00 updated the summary of D73000: [InstCombine] Optimize strchr(cststr, C).
Sun, Jan 19, 7:08 AM · Restricted Project
xbolva00 planned changes to D71312: [InstCombine] X / (select C, X, -X) -> select C ? 1 : -1.

I'm not sure if this does everything you want, but you probably should look at:
InstCombiner::SimplifySelectsFeedingBinaryOp()

Sun, Jan 19, 6:58 AM · Restricted Project
xbolva00 created D73000: [InstCombine] Optimize strchr(cststr, C).
Sun, Jan 19, 6:58 AM · Restricted Project
xbolva00 updated the diff for D73000: [InstCombine] Optimize strchr(cststr, C).

up

Sun, Jan 19, 6:58 AM · Restricted Project

Sat, Jan 18

xbolva00 added a comment to D72916: [JumpThreading] Reduce duplicate threshold at Oz.

I agree that adjusting BBDuplicateThreshold for code size is better choice than disabling the whole pass.

Sat, Jan 18, 3:39 AM · Restricted Project

Fri, Jan 17

xbolva00 added a comment to D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null..

(just passing-by remark)

I believe if I request AA in Inliner.cpp and pass it down to FindAvailableLoadedValue through tryPromoteCall (D71308), it would work without this patch.

Is it okay to assume that a) the AA is BasicAA and b) BasicAA is stateless since the AA interface is more generic? Is there a way to condition this logic on those conditions?

Perhaps it may be more productive to explain why this This is a simple form of alias analysis. *has* to exist?
Why can't, as suggested, BasicAA be used? What goes wrong if BasicAA is used?

Fri, Jan 17, 1:17 PM · Restricted Project

Thu, Jan 16

xbolva00 accepted D72643: [InstCombine] form copysign from select of FP constants (PR44153).

Looks ok

Thu, Jan 16, 11:39 AM · Restricted Project
xbolva00 added inline comments to D72643: [InstCombine] form copysign from select of FP constants (PR44153).
Thu, Jan 16, 11:39 AM · Restricted Project
xbolva00 added inline comments to rG870094decfc9: [ELF] Decrease alignment of ThunkSection on 64-bit targets from 8 to 4.
Thu, Jan 16, 11:20 AM

Tue, Jan 14

xbolva00 added a comment to D72689: [SLP] Revectorize partially vectorized instructions.

I saw similar thing in recent research

Tue, Jan 14, 3:06 AM · Restricted Project

Sun, Jan 12

xbolva00 added inline comments to rGce35010d782c: [X86][AVX] Add lowerShuffleAsLanePermuteAndSHUFP lowering.
Sun, Jan 12, 2:31 AM

Sat, Jan 11

xbolva00 added a comment to D72052: [UserManual] Update the C++ standard support.

+1

Sat, Jan 11, 8:29 AM · Restricted Project

Fri, Jan 10

xbolva00 added inline comments to D72467: Remove "mask" operand from shufflevector..
Fri, Jan 10, 4:07 PM · Restricted Project, Restricted Project

Thu, Jan 9

xbolva00 accepted D70304: [Loop Peeling] Add possibility to enable peeling on loop nests..

Makes sense and no regressions expected since off by default.

Thu, Jan 9, 8:12 AM · Restricted Project
xbolva00 accepted D71374: Improve support of GNU mempcpy.

LG

Thu, Jan 9, 7:43 AM · Restricted Project

Wed, Jan 8

xbolva00 added inline comments to D72312: [DAGCombine] Fold the (fma -x, y, -z) to -(fma x, y, z).
Wed, Jan 8, 4:08 AM · Restricted Project

Mon, Jan 6

xbolva00 added a comment to D72300: [DAGCombiner] reduce shuffle of concat of same vector.

Accept button missed?

Mon, Jan 6, 2:35 PM · Restricted Project
xbolva00 added inline comments to rGf3f7dc3d2990: [APFloat] Fix compilation warnings.
Mon, Jan 6, 2:36 AM

Sun, Jan 5

xbolva00 added a comment to D72231: [Sema] Adds the pointer-to-int-cast diagnostic.

The diagnostic is not enabled by default

Sun, Jan 5, 11:52 AM · Restricted Project

Sat, Jan 4

xbolva00 added inline comments to D72212: [Sema] Improve -Wrange-loop-analysis warnings.
Sat, Jan 4, 3:45 PM · Restricted Project
xbolva00 added inline comments to D72212: [Sema] Improve -Wrange-loop-analysis warnings.
Sat, Jan 4, 1:28 PM · Restricted Project
xbolva00 added a comment to D68298: [GlobalOpt] Pass DTU to removeUnreachableBlocks instead of recomputing..

Yes, we're still on the legacy manager, so DT is not available here. I've just verified that reverting this patch does indeed reclaim a sizable part of the LLVM 10 compile-time regressions (end-to-end timings).

Sat, Jan 4, 12:06 PM · Restricted Project

Fri, Jan 3

xbolva00 added a comment to D72007: [InstCombine] try to pull 'not' of select into compare operands.

Looks good

Fri, Jan 3, 5:07 PM · Restricted Project
xbolva00 added inline comments to D71993: [Transforms][GlobalSRA] huge array causes long compilation time and huge memory usage..
Fri, Jan 3, 2:17 PM · Restricted Project
xbolva00 added a comment to D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation.

Ah, true.

Fri, Jan 3, 1:20 PM · Restricted Project
xbolva00 added a comment to D70638: [Diagnostic] add a warning which warns about misleading indentation.

(re-ping; I think this false positive for goto label case is important to be fixed before 10 release)

Fri, Jan 3, 11:24 AM · Restricted Project
xbolva00 reopened D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation.

Can you add a test case for that crash? Otherwise OK.

Fri, Jan 3, 11:22 AM · Restricted Project

Thu, Jan 2

xbolva00 added inline comments to D67495: [RISCV] Collect Statistics on Compressed Instructions.
Thu, Jan 2, 3:57 AM · Restricted Project

Tue, Dec 31

xbolva00 accepted D71952: [X86][InstCombine] Add constant folding and simplification support for pdep and pext.
Tue, Dec 31, 2:04 PM · Restricted Project
xbolva00 accepted D72019: [X86] Use carry flag from add for (seteq (add X, -1), -1)..

lg too

Tue, Dec 31, 2:04 PM · Restricted Project
xbolva00 added inline comments to D71857: [NFC] Fixes -Wrange-loop-analysis warnings.
Tue, Dec 31, 5:41 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Dec 30

xbolva00 added inline comments to rG987eb8e26ccf: [InstCombine] propagate sign argument through nested copysigns.
Mon, Dec 30, 9:36 AM
xbolva00 added a comment to D71568: [InstCombine] `select + mul` -> `select + shl` with power of twos..

Another hopeless ping before NY

Mon, Dec 30, 8:03 AM · Restricted Project
xbolva00 added inline comments to D71568: [InstCombine] `select + mul` -> `select + shl` with power of twos..
Mon, Dec 30, 8:03 AM · Restricted Project
xbolva00 added a comment to D63324: [clang-tidy] Replace memcpy by std::copy.

if(num != 0) memmove is missed optimization opportunity. Such branch can be removed (if profitable).

Mon, Dec 30, 7:26 AM · Restricted Project, Restricted Project

Dec 29 2019

xbolva00 added a comment to D48388: [EarlyCSE] Understand WriteOnly function calls in EarlyCSE with MSSA.

Re-ping.

Dec 29 2019, 12:33 PM
xbolva00 added a comment to D46313: [clang] Add WriteOnly attribute.

Re-ping.

Dec 29 2019, 12:33 PM
xbolva00 added a comment to D71952: [X86][InstCombine] Add constant folding and simplification support for pdep and pext.

Looks fine for me

Dec 29 2019, 3:25 AM · Restricted Project

Dec 28 2019

xbolva00 added reviewers for D71967: [opt] Fix run-twice crash and detection problem: rnk, jdoerfert.
Dec 28 2019, 3:10 PM · Restricted Project
xbolva00 updated subscribers of D71942: Update LLVMCallConv.

Is there any chance to backport this into LLVM 9.0.1?

Dec 28 2019, 2:40 PM · Restricted Project
xbolva00 added a comment to D71967: [opt] Fix run-twice crash and detection problem.

Tests?

Dec 28 2019, 1:54 PM · Restricted Project

Dec 26 2019

xbolva00 added a comment to D57953: [Jump Threading] Convert conditional branches into unconditional branches using GVN results.

Re-ping

Dec 26 2019, 2:40 AM
xbolva00 added reviewers for D57953: [Jump Threading] Convert conditional branches into unconditional branches using GVN results: efriedma, fhahn.
Dec 26 2019, 2:40 AM

Dec 25 2019

xbolva00 updated subscribers of D69868: Allow "callbr" to return non-void values.
Dec 25 2019, 3:38 PM · Restricted Project, Restricted Project
xbolva00 added inline comments to D71047: [LV][NFC] Keep dominator tree up to date during vectorization..
Dec 25 2019, 4:45 AM · Restricted Project

Dec 24 2019

xbolva00 added inline comments to rG42dba633a3b3: [TypePromotion] Make TypeSize a class member.
Dec 24 2019, 3:56 AM
xbolva00 added a comment to D61802: [LoopVectorize] Enable float minmax reductions via instruction flag.

But checking for nsz should happen on the 'select' rather than the 'fcmp'. I think we should fix the fundamental problems in the IR itself instead of trying to hack around them any more.

Dec 24 2019, 12:35 AM · Restricted Project

Dec 23 2019

xbolva00 added a comment to D71817: Fix LLVM tool --version build mode printing for MSVC.
Dec 23 2019, 10:04 AM · Restricted Project

Dec 22 2019

xbolva00 added a comment to D71817: Fix LLVM tool --version build mode printing for MSVC.

Worth to fix too?

Dec 22 2019, 3:21 PM · Restricted Project
xbolva00 added inline comments to D71817: Fix LLVM tool --version build mode printing for MSVC.
Dec 22 2019, 3:21 PM · Restricted Project
xbolva00 accepted D71812: [NVPTX] Fixes -Wrange-loop-analysis warnings.
Dec 22 2019, 8:34 AM · Restricted Project
xbolva00 added a comment to D66088: AMD Znver2 (Rome) Scheduler enablement.

Do you have the commit rights?

Dec 22 2019, 5:41 AM · Restricted Project
xbolva00 added a comment to D68912: Adds -Wrange-loop-analysis to -Wall.

All is fixed now?

Dec 22 2019, 4:18 AM · Restricted Project

Dec 21 2019

xbolva00 added inline comments to D71047: [LV][NFC] Keep dominator tree up to date during vectorization..
Dec 21 2019, 8:46 AM · Restricted Project

Dec 19 2019

xbolva00 added a comment to D59254: [RFC] Implementation of Clang randstruct.

Re-ping

Dec 19 2019, 5:04 PM · Restricted Project
xbolva00 added inline comments to D71037: [Diagnostic] Add ftabstop to -Wmisleading-indentation.
Dec 19 2019, 10:03 AM · Restricted Project

Dec 18 2019

xbolva00 added inline comments to D71660: [ValueTracking] isKnownNonZero() should take non-null-ness assumptions into consideration (PR43267).
Dec 18 2019, 12:14 PM · Restricted Project
xbolva00 added inline comments to D70767: [Attributor] Add an Attributor CG-SCC pass.
Dec 18 2019, 6:33 AM · Restricted Project
xbolva00 added a comment to D70767: [Attributor] Add an Attributor CG-SCC pass.

Nice work!

Dec 18 2019, 5:27 AM · Restricted Project

Dec 17 2019

xbolva00 added a comment to D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions..

Maybe @aaron.ballman / @rsmith could take a look? This patch blocks the whole patch stack.

Dec 17 2019, 9:26 AM · Restricted Project
xbolva00 added a comment to D57660: [Sema] SequenceChecker: Handle references, members and structured bindings..

Hello @aaron.ballman / @rsmith, can you please take a look so this patch?

Dec 17 2019, 9:24 AM · Restricted Project
xbolva00 accepted D70870: [IR] Use a reference in a range-based for.
Dec 17 2019, 4:35 AM · Restricted Project
xbolva00 accepted D70869: [Analyzer] Use a reference in a range-based for.
Dec 17 2019, 4:35 AM · Restricted Project

Dec 16 2019

xbolva00 added inline comments to rG4c4f4dd3f894: Silence an MSVC "not all control paths" diagnostic; NFC..
Dec 16 2019, 6:52 AM
xbolva00 added inline comments to D71473: [Alignment][NFC] Deprecate untyped variants of CreateMemCpy/CreateMemMove.
Dec 16 2019, 6:52 AM · Restricted Project

Dec 15 2019

xbolva00 accepted D71530: [Frontend] Fixes -Wrange-loop-analysis warnings.
Dec 15 2019, 3:09 PM · Restricted Project
xbolva00 accepted D71527: [Driver] Avoid copies in range-based for loops.
Dec 15 2019, 3:09 PM · Restricted Project
xbolva00 accepted D71526: [AST] Use a reference in a range-based for.
Dec 15 2019, 9:28 AM · Restricted Project
xbolva00 added a comment to D71525: [libc++] Fix typo in std::midpoint.

Not covered by tests ? :/

Dec 15 2019, 8:43 AM · Restricted Project

Dec 14 2019

xbolva00 accepted D58017: [DAG] Add SimplifyDemandedBits support for BSWAP.

Seems fine.

Dec 14 2019, 7:49 AM · Restricted Project
xbolva00 added inline comments to D71442: [X86] Add calculation for elements in structures in getting uniform base for the Gather/Scatter intrinsic..
Dec 14 2019, 2:45 AM · Restricted Project
xbolva00 added inline comments to D71442: [X86] Add calculation for elements in structures in getting uniform base for the Gather/Scatter intrinsic..
Dec 14 2019, 2:36 AM · Restricted Project

Dec 13 2019

xbolva00 added a comment to D71486: [clang-tools-extra] Fix switch coverage warning.

It should be possible to test this by adapting a test case from the original ed8dadb, but I'm not certain...

Dec 13 2019, 1:18 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D71374: Improve support of GNU mempcpy.

@xbolva00 should I remove the lowering part and leave it to llvm?

Dec 13 2019, 4:54 AM · Restricted Project
xbolva00 added a comment to D71374: Improve support of GNU mempcpy.

LLVM already converts mempcpy to memcpy..

Dec 13 2019, 3:12 AM · Restricted Project

Dec 12 2019

xbolva00 added a comment to D71374: Improve support of GNU mempcpy.

Please add a IR codegen test.

Dec 12 2019, 11:46 PM · Restricted Project

Dec 11 2019

xbolva00 added a comment to rG9e260c12bce7: [Diagnostics] Make behaviour of Clang's -Wdeprecated-copy same as in GCC.

I read somewhere that cfe-commits list has a issue with names containing non-english characters.

Dec 11 2019, 1:39 AM
xbolva00 added a comment to rG9e260c12bce7: [Diagnostics] Make behaviour of Clang's -Wdeprecated-copy same as in GCC.

GCC compatibility (they do it to reduce noise; so if we use same flag, we should diagnose same things).
I think it is good that clang and gcc warns same way now. But, if you want to improve it somehow (new flag?), patches are welcome.

Dec 11 2019, 1:36 AM

Dec 10 2019

xbolva00 retitled D71312: [InstCombine] X / (select C, X, -X) -> select C ? 1 : -1 from [InstCombine] Fold X / abs(X) to X < 0 ? -1 : 1 to [InstCombine] X / (select C, X, -X) -> select C ? 1 : -1.
Dec 10 2019, 5:23 PM · Restricted Project
xbolva00 updated the diff for D71312: [InstCombine] X / (select C, X, -X) -> select C ? 1 : -1.

Implement general pattern.

Dec 10 2019, 5:14 PM · Restricted Project
xbolva00 added a comment to D71312: [InstCombine] X / (select C, X, -X) -> select C ? 1 : -1.

Isn't it sufficient to just check that the true/false values of the select are x and -x. The condition itself doesn't matter. x / (select c, x, -x) -> select c ? 1 : -1

Dec 10 2019, 4:55 PM · Restricted Project
xbolva00 updated the diff for D71312: [InstCombine] X / (select C, X, -X) -> select C ? 1 : -1.

Addressed comments.

Dec 10 2019, 4:46 PM · Restricted Project
xbolva00 added a comment to D71312: [InstCombine] X / (select C, X, -X) -> select C ? 1 : -1.

Yeah, thanks. Alive proof:

Dec 10 2019, 4:46 PM · Restricted Project