Page MenuHomePhabricator

xbolva00 (Dávid Bolvanský)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2018, 5:18 PM (58 w, 2 d)

Recent Activity

Wed, May 15

xbolva00 reclaimed D61409: [SimplifyCFG] Added condition assumption for unreachable blocks.
Wed, May 15, 2:00 PM · Restricted Project
xbolva00 added a comment to D61409: [SimplifyCFG] Added condition assumption for unreachable blocks.

Possibly. But more fixes are needed as preconditions to enable this, as you mentioned here (fix oneUse check). Without them, we cannot push this futher.

Wed, May 15, 2:00 PM · Restricted Project
xbolva00 committed rGeef2060bd9c5: [clang-format] Fixed self assignment (authored by xbolva00).
[clang-format] Fixed self assignment
Wed, May 15, 1:29 PM
xbolva00 abandoned D61409: [SimplifyCFG] Added condition assumption for unreachable blocks.
Wed, May 15, 1:29 PM · Restricted Project
xbolva00 committed rL360810: [clang-format] Fixed self assignment.
[clang-format] Fixed self assignment
Wed, May 15, 1:27 PM
xbolva00 committed rC360810: [clang-format] Fixed self assignment.
[clang-format] Fixed self assignment
Wed, May 15, 1:27 PM
xbolva00 closed D61281: [clang-format] Fixed self assignment.
Wed, May 15, 1:26 PM · Restricted Project

Tue, May 14

xbolva00 updated the diff for D61281: [clang-format] Fixed self assignment.

removed line

Tue, May 14, 12:43 PM · Restricted Project

Fri, May 10

xbolva00 added inline comments to D61743: New clang option -MD-filter=prefix to filter files from make dependencies.
Fri, May 10, 12:30 AM · Restricted Project, Restricted Project

Thu, May 9

xbolva00 added inline comments to D61743: New clang option -MD-filter=prefix to filter files from make dependencies.
Thu, May 9, 2:18 PM · Restricted Project, Restricted Project

Fri, May 3

xbolva00 added a comment to D61409: [SimplifyCFG] Added condition assumption for unreachable blocks.

Any advices about next steps for this patch?

Fri, May 3, 4:20 PM · Restricted Project
xbolva00 added inline comments to D52109: [TwoAddressInstructionPass] Don't update SrcRegMap for copies inserted for tied register constraint when the src isn't killed.
Fri, May 3, 3:36 PM · Restricted Project
xbolva00 added a comment to rL359873: [SelectionDAG] Use INT_MIN as (1 << 31) is UB for signed integers. NFCI..

There is no compiler warning to catch this UB?

Fri, May 3, 6:42 AM
Herald added a project to D52109: [TwoAddressInstructionPass] Don't update SrcRegMap for copies inserted for tied register constraint when the src isn't killed: Restricted Project.

I wonder hot it looks now. Can you rebase it?

Fri, May 3, 5:55 AM · Restricted Project

Thu, May 2

xbolva00 added a comment to D60934: [clang] adding explicit(bool) from c++2a.

Also please update
https://clang.llvm.org/cxx_status.html

Thu, May 2, 3:57 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D61409: [SimplifyCFG] Added condition assumption for unreachable blocks.

It would be good if anybody familiar with llvm patternmatch could fix m_OneUse to ignore llvm.assume.

Thu, May 2, 10:38 AM · Restricted Project
xbolva00 added a reviewer for D61409: [SimplifyCFG] Added condition assumption for unreachable blocks: RKSimon.
Thu, May 2, 9:24 AM · Restricted Project
xbolva00 added a comment to D61409: [SimplifyCFG] Added condition assumption for unreachable blocks.

Since llvm.assume is not a really true use, oneUse check fails? Then we should really fix it to not count it.

Thu, May 2, 1:12 AM · Restricted Project

Wed, May 1

xbolva00 added a reviewer for D61409: [SimplifyCFG] Added condition assumption for unreachable blocks: craig.topper.
Wed, May 1, 11:56 PM · Restricted Project
xbolva00 added a comment to D61409: [SimplifyCFG] Added condition assumption for unreachable blocks.
Wed, May 1, 4:45 PM · Restricted Project
xbolva00 updated the diff for D61409: [SimplifyCFG] Added condition assumption for unreachable blocks.

Update old tests

Wed, May 1, 4:01 PM · Restricted Project
xbolva00 created D61409: [SimplifyCFG] Added condition assumption for unreachable blocks.
Wed, May 1, 3:41 PM · Restricted Project
xbolva00 abandoned D61288: [Diagnostics] Implemented support for -Wswitch-default.
Wed, May 1, 7:26 AM · Restricted Project
xbolva00 added a comment to D61288: [Diagnostics] Implemented support for -Wswitch-default.

I am not familiar with clang-tidy’s codebase and I personally prefer good compiler warnings than dependency on another tool (clang-tidy). I mean the cases when diagnostic check is easy to do in the compiler.

Wed, May 1, 7:01 AM · Restricted Project
xbolva00 added a comment to D61288: [Diagnostics] Implemented support for -Wswitch-default.

Some coding guidelines may require switch to have always default label. Even if devs know that default is not reachable, they can add default: abort(); or assert to increase safety (and warning will be silenced).

Wed, May 1, 6:24 AM · Restricted Project
xbolva00 added inline comments to D61288: [Diagnostics] Implemented support for -Wswitch-default.
Wed, May 1, 5:58 AM · Restricted Project

Tue, Apr 30

xbolva00 added inline comments to D60934: [clang] adding explicit(bool) from c++2a.
Tue, Apr 30, 2:58 PM · Restricted Project, Restricted Project
xbolva00 added inline comments to D60582: [IPSCCP] Add general integer range support..
Tue, Apr 30, 8:16 AM · Restricted Project
xbolva00 added inline comments to D61279: [PDB] Fixed null pointer dereference.
Tue, Apr 30, 4:23 AM · Restricted Project
xbolva00 added inline comments to D61288: [Diagnostics] Implemented support for -Wswitch-default.
Tue, Apr 30, 3:18 AM · Restricted Project
xbolva00 committed rG59b6889238a6: Revert r359520 (authored by xbolva00).
Revert r359520
Tue, Apr 30, 3:09 AM
xbolva00 committed rL359544: Revert r359520.
Revert r359520
Tue, Apr 30, 3:09 AM

Mon, Apr 29

xbolva00 added a comment to D61288: [Diagnostics] Implemented support for -Wswitch-default.

GCC warns even for for that case, so this patch implements GCC's behaviour for now.

Mon, Apr 29, 5:32 PM · Restricted Project
xbolva00 updated the diff for D61288: [Diagnostics] Implemented support for -Wswitch-default.

Removed redundant line in DiagnosticGroups

Mon, Apr 29, 5:15 PM · Restricted Project
xbolva00 created D61288: [Diagnostics] Implemented support for -Wswitch-default.
Mon, Apr 29, 5:11 PM · Restricted Project
xbolva00 committed rG1a52eaf77338: [PDB] Fixed null pointer dereference (authored by xbolva00).
[PDB] Fixed null pointer dereference
Mon, Apr 29, 4:57 PM
xbolva00 committed rL359520: [PDB] Fixed null pointer dereference.
[PDB] Fixed null pointer dereference
Mon, Apr 29, 4:57 PM
xbolva00 closed D61279: [PDB] Fixed null pointer dereference.
Mon, Apr 29, 4:57 PM · Restricted Project
xbolva00 committed rGefba22cb6cad: [Diagnostics] Support -Wtype-limits for GCC compatibility (authored by xbolva00).
[Diagnostics] Support -Wtype-limits for GCC compatibility
Mon, Apr 29, 4:23 PM
xbolva00 committed rL359516: [Diagnostics] Support -Wtype-limits for GCC compatibility.
[Diagnostics] Support -Wtype-limits for GCC compatibility
Mon, Apr 29, 4:23 PM
xbolva00 committed rC359516: [Diagnostics] Support -Wtype-limits for GCC compatibility.
[Diagnostics] Support -Wtype-limits for GCC compatibility
Mon, Apr 29, 4:22 PM
xbolva00 closed D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.
Mon, Apr 29, 4:22 PM · Restricted Project
xbolva00 added a reviewer for D61279: [PDB] Fixed null pointer dereference: rnk.
Mon, Apr 29, 4:22 PM · Restricted Project
xbolva00 updated the diff for D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.

Rebased

Mon, Apr 29, 4:20 PM · Restricted Project
xbolva00 added a comment to D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.

Ok, reclaiming patch.

Mon, Apr 29, 2:32 PM · Restricted Project
xbolva00 reclaimed D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.
Mon, Apr 29, 2:30 PM · Restricted Project
xbolva00 created D61281: [clang-format] Fixed self assignment.
Mon, Apr 29, 2:14 PM · Restricted Project
xbolva00 created D61279: [PDB] Fixed null pointer dereference.
Mon, Apr 29, 2:11 PM · Restricted Project
xbolva00 abandoned D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.
Mon, Apr 29, 2:11 PM · Restricted Project
xbolva00 abandoned D52835: [Diagnostics] Check integer to floating point number implicit conversions.
Mon, Apr 29, 2:11 PM
xbolva00 abandoned D58878: [Diagnostics] Warn for assignments in bool contexts.
Mon, Apr 29, 2:11 PM · Restricted Project

Apr 10 2019

xbolva00 updated subscribers of rGbbd798f71c3d: MCSymbolicELF: simplify. (Flags & (x << s)) >> s is equivalent to Flags >> s & x.

@spatel maybe missing pattern in instcombine?

Apr 10 2019, 4:03 AM

Apr 5 2019

xbolva00 updated subscribers of rG70f25ebc6d15: luporl, adalava pending patches !!!!!!!!!.
Apr 5 2019, 5:45 AM
xbolva00 updated subscribers of rG70f25ebc6d15: luporl, adalava pending patches !!!!!!!!!.

No review ?

Apr 5 2019, 5:42 AM

Apr 3 2019

xbolva00 added a comment to D59936: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259).

Maybe you can add more tests with these intrinsics?

Apr 3 2019, 4:04 AM · Restricted Project
xbolva00 committed rG937720e75b46: [InstCombine] Simplify ctpop with bitreverse/bswap (authored by xbolva00).
[InstCombine] Simplify ctpop with bitreverse/bswap
Apr 3 2019, 1:08 AM
xbolva00 committed rL357564: [InstCombine] Simplify ctpop with bitreverse/bswap.
[InstCombine] Simplify ctpop with bitreverse/bswap
Apr 3 2019, 1:07 AM
xbolva00 closed D60148: [InstCombine] Simplify ctpop with bitreverse/bswap.
Apr 3 2019, 1:07 AM · Restricted Project

Apr 2 2019

xbolva00 created D60148: [InstCombine] Simplify ctpop with bitreverse/bswap.
Apr 2 2019, 1:26 PM · Restricted Project
xbolva00 committed rG9f179b2c65b1: [InstCombine] Added tests for PR41337 (authored by xbolva00).
[InstCombine] Added tests for PR41337
Apr 2 2019, 1:20 PM
xbolva00 committed rL357522: [InstCombine] Added tests for PR41337.
[InstCombine] Added tests for PR41337
Apr 2 2019, 1:20 PM
xbolva00 committed rG5ba60b22a476: [InstCombine] Simplify ctlz/cttz with bitreverse (authored by xbolva00).
[InstCombine] Simplify ctlz/cttz with bitreverse
Apr 2 2019, 1:13 PM
xbolva00 committed rL357521: [InstCombine] Simplify ctlz/cttz with bitreverse.
[InstCombine] Simplify ctlz/cttz with bitreverse
Apr 2 2019, 1:13 PM
xbolva00 closed D60096: [InstCombine] Simplify ctlz/cttz with bitreverse.
Apr 2 2019, 1:13 PM · Restricted Project
xbolva00 updated the diff for D60096: [InstCombine] Simplify ctlz/cttz with bitreverse.

Do not use builder.

Apr 2 2019, 12:55 PM · Restricted Project
xbolva00 updated the diff for D60096: [InstCombine] Simplify ctlz/cttz with bitreverse.
  • Added and precommited more tests
Apr 2 2019, 11:40 AM · Restricted Project
xbolva00 committed rG9bba938de46f: [InstCombine] Added tests for PR41273 (authored by xbolva00).
[InstCombine] Added tests for PR41273
Apr 2 2019, 11:33 AM
xbolva00 committed rL357508: [InstCombine] Added tests for PR41273.
[InstCombine] Added tests for PR41273
Apr 2 2019, 11:32 AM

Apr 1 2019

xbolva00 added a comment to D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.

Ping @rsmith

Apr 1 2019, 10:04 PM · Restricted Project
xbolva00 created D60096: [InstCombine] Simplify ctlz/cttz with bitreverse.
Apr 1 2019, 1:41 PM · Restricted Project
xbolva00 added a comment to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.

Do we have any checker to recommend llvm functions over std ?

Apr 1 2019, 11:06 AM · Restricted Project, Restricted Project, Restricted Project
xbolva00 added inline comments to D59978: [Attributor] Deduce "no-return" function attribute.
Apr 1 2019, 10:21 AM · Restricted Project

Mar 31 2019

xbolva00 added inline comments to D60048: [InstCombine] eliminate commuted select-shuffles + binop (PR41304).
Mar 31 2019, 10:36 AM · Restricted Project

Mar 30 2019

xbolva00 added inline comments to D59919: [Attributor] Deduce "returned" argument attribute.
Mar 30 2019, 1:11 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D59534: Enable tail call in MemCpyOptimization.

Maybe Attributor can infer tail call marks too?

Mar 30 2019, 12:04 PM · Restricted Project
xbolva00 added reviewers for D60031: Split tailcallelim into tailcallmark and tailcallelim: jdoerfert, efriedma.
Mar 30 2019, 12:04 PM · Restricted Project
xbolva00 added a reviewer for D59534: Enable tail call in MemCpyOptimization: jdoerfert.
Mar 30 2019, 12:01 PM · Restricted Project
xbolva00 added a comment to D59534: Enable tail call in MemCpyOptimization.

Couldn’t passes like FunctionAttrs / Attributor infer “tail call mark” ?
Not sure how many times these passes go, indeed.

Mar 30 2019, 12:00 PM · Restricted Project
xbolva00 added a comment to D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5)..

We should avoid this transformation for glibc environment..

Mar 30 2019, 3:23 AM · Restricted Project

Mar 29 2019

xbolva00 added a comment to D54411: [Codegen] Merge tail blocks with no successors after block placement.

Please rebase/update

Mar 29 2019, 12:32 AM · Restricted Project

Mar 26 2019

xbolva00 added reviewers for D32140: Global code motion of congruent computations: chandlerc, efriedma.
Mar 26 2019, 4:04 PM · Restricted Project
Herald added a project to D32140: Global code motion of congruent computations: Restricted Project.

Plesse try to add more reviewers. This seems to be very promising.

Mar 26 2019, 4:04 PM · Restricted Project
xbolva00 added a comment to D41324: [SLPVectorizer] Add shuffle instruction cost for jumbled load.

Test?

Mar 26 2019, 5:46 AM

Mar 25 2019

xbolva00 added a comment to D46662: [X86] condition branches folding for three-way conditional codes.

There is a regression with -O3 -march=native on Haswell. It is slower than standard -O3. GCC 9 with -O3 -march=native produces faster code than standard -O3.

Mar 25 2019, 2:52 PM · Restricted Project

Mar 24 2019

xbolva00 added inline comments to D59754: [Sema] Add c++2a designated initializer warnings.
Mar 24 2019, 5:07 PM · Restricted Project
xbolva00 accepted D56073: Typo fix: NewDepth -> NewHeight.
Mar 24 2019, 10:39 AM · Restricted Project

Mar 22 2019

xbolva00 added a comment to rG238af52ded43: [ExpandMemCmp] Trigger on bcmp too..

int cmpcomp(char *s, char *p) {

return memcmp(s,p,10) == bcmp(s,p,10) ;

}

Mar 22 2019, 5:43 PM
xbolva00 added reviewers for D57591: fix weights for promoted indirect calls: tejohnson, efriedma.
Mar 22 2019, 4:39 PM · Restricted Project
xbolva00 added a comment to D57779: [SLP] Add support for throttling..

Did you check the 462.libquantum 's regression?

Mar 22 2019, 12:23 PM
xbolva00 added a comment to D17407: [Sema] PR25755 Handle out of order designated initializers .

Please check also https://bugs.llvm.org/show_bug.cgi?id=40030

Mar 22 2019, 1:07 AM · Restricted Project

Mar 21 2019

xbolva00 abandoned D58882: [Diagnostics] Address of a standard library function.
Mar 21 2019, 2:50 AM · Restricted Project

Mar 20 2019

xbolva00 added a comment to D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.

Ping @aaron.ballman @rsmith

Mar 20 2019, 4:11 PM · Restricted Project
xbolva00 added a comment to rG238af52ded43: [ExpandMemCmp] Trigger on bcmp too..

offtopic a bit..

Mar 20 2019, 5:34 AM

Mar 19 2019

xbolva00 added a comment to D59442: Enable Operand Reordering for Commutative Instructions in the FunctionComparator/MergeFunctions.

Cannot we canonicalize to have a smaller index as lhs ?

Mar 19 2019, 10:26 AM · Restricted Project
xbolva00 added a reviewer for D59534: Enable tail call in MemCpyOptimization: efriedma.
Mar 19 2019, 6:20 AM · Restricted Project

Mar 15 2019

xbolva00 added a comment to D58882: [Diagnostics] Address of a standard library function.

Ping

Mar 15 2019, 2:08 AM · Restricted Project

Mar 11 2019

xbolva00 added a comment to D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility.

Ping

Mar 11 2019, 5:17 AM · Restricted Project

Mar 9 2019

xbolva00 added inline comments to D58878: [Diagnostics] Warn for assignments in bool contexts.
Mar 9 2019, 5:02 AM · Restricted Project

Mar 8 2019

xbolva00 added a comment to rL355733: [RegionPass] Fix forgotten "!"..

There are no tests which would catch this issue ?

Mar 8 2019, 1:29 PM

Mar 7 2019

xbolva00 added a comment to D58878: [Diagnostics] Warn for assignments in bool contexts.

Addressed notes.

Mar 7 2019, 7:04 AM · Restricted Project