Page MenuHomePhabricator

xbolva00 (Dávid Bolvanský)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2018, 5:18 PM (129 w, 5 d)

Recent Activity

Today

xbolva00 added a comment to D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .

Ping @rsmith

Wed, Sep 30, 6:03 AM
xbolva00 added a comment to D86019: [SLC] Optimize mempcpy_chk to mempcpy.

Ping @efriedma

Wed, Sep 30, 6:02 AM · Restricted Project

Yesterday

xbolva00 added a comment to D88492: [InstCombine] visitTrunc - remove dead trunc(lshr (zext A), C) combine.

Binary changes

Tue, Sep 29, 11:42 PM · Restricted Project

Sun, Sep 27

xbolva00 committed rG155ac333945d: [BuildLibCalls] Add noalias for strcat and stpcpy (authored by xbolva00).
[BuildLibCalls] Add noalias for strcat and stpcpy
Sun, Sep 27, 12:39 PM
xbolva00 closed D88335: [BuildLibCalls] Add noalias for strcat and stpcpy.
Sun, Sep 27, 12:39 PM · Restricted Project

Sat, Sep 26

xbolva00 added a comment to D88335: [BuildLibCalls] Add noalias for strcat and stpcpy.

FWIW, noalias on these arguments is, by itself, not doing anything. It does something if you know how much memory is accessed by the function through such an argument *for sure* and what other memory is accessed for sure. Such memory regions are not overlapping. (This is way too vague actually but I guess it doesn't matter for the gist.)

Sat, Sep 26, 1:12 AM · Restricted Project

Fri, Sep 25

xbolva00 added a comment to D88335: [BuildLibCalls] Add noalias for strcat and stpcpy.

That would be really overconservative

Fri, Sep 25, 1:42 PM · Restricted Project
xbolva00 added a comment to D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644).

I think it would be good to update the commit message to just state that this adds no capture and write only to the first arg of strcpy & co. It also unifies strcpy & stpcpy handling. might be good to do separately first.

Fri, Sep 25, 12:59 PM · Restricted Project
xbolva00 requested review of D88335: [BuildLibCalls] Add noalias for strcat and stpcpy.
Fri, Sep 25, 12:58 PM · Restricted Project
xbolva00 added a comment to D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644).

Interestingly, as we can see, something is broken with NPM (hopefully not a blocker for this patch)

Fri, Sep 25, 12:08 PM · Restricted Project
xbolva00 requested review of D88328: [InferAttrs] Improve DSE for libcalls (partial fix for PR47644).
Fri, Sep 25, 12:06 PM · Restricted Project
xbolva00 committed rG179e15d53acd: [SystemZ] Optimize bcmp calls (PR47420) (authored by xbolva00).
[SystemZ] Optimize bcmp calls (PR47420)
Fri, Sep 25, 8:56 AM
xbolva00 closed D87988: [SystemZ] Optimize bcmp calls (PR47420).
Fri, Sep 25, 8:56 AM · Restricted Project
xbolva00 added a comment to D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .
Fri, Sep 25, 6:08 AM
xbolva00 added reviewers for D88293: [ControlDependentDCE] Add Control Dependent DCE pass: efriedma, asbirlea, fhahn.
Fri, Sep 25, 5:20 AM · Restricted Project
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

Does that sound reasonable?

Fri, Sep 25, 2:13 AM · Restricted Project, Restricted Project

Wed, Sep 23

xbolva00 added a comment to D87988: [SystemZ] Optimize bcmp calls (PR47420).

Right, I will adjust to make it more clear.

I still think it would be nice to mention this in SelectionDAGTargetInfo.h (in the comment for EmitTargetCodeForMemcmp()) as well...?

Wed, Sep 23, 1:02 PM · Restricted Project
xbolva00 updated the diff for D87988: [SystemZ] Optimize bcmp calls (PR47420).
Wed, Sep 23, 1:01 PM · Restricted Project

Tue, Sep 22

xbolva00 added a comment to rG8fdac7cb7abb: Revert D71539 "Recommit "[SCEV] Look through single value PHIs."".

mafft regressed quite a lot (compile time) so it would be good to handle possibly weird cases well - some limit/threshold/bailout?

Tue, Sep 22, 12:45 PM
xbolva00 added a comment to D84951: [LV] Try to sink users recursively for first-order recurrences..

Cool, great!

Tue, Sep 22, 12:35 PM · Restricted Project
xbolva00 updated the diff for D87988: [SystemZ] Optimize bcmp calls (PR47420).
Tue, Sep 22, 11:10 AM · Restricted Project
xbolva00 added a comment to D87988: [SystemZ] Optimize bcmp calls (PR47420).

Maybe also have the test case from my original patch which transforms a memcmp to a bcmp...?

Tue, Sep 22, 11:01 AM · Restricted Project
xbolva00 added a comment to D87988: [SystemZ] Optimize bcmp calls (PR47420).

Maybe also have the test case from my original patch which transforms a memcmp to a bcmp...?

If it is really ok to pass bcmp to visitMemCmpCall(), I think a comment on that specifies this would be nice, both for visitMemCmpCall() and EmitTargetCodeForMemcmp().

Tue, Sep 22, 10:57 AM · Restricted Project
xbolva00 added a reviewer for D87988: [SystemZ] Optimize bcmp calls (PR47420): jonpa.
Tue, Sep 22, 3:30 AM · Restricted Project

Mon, Sep 21

xbolva00 updated subscribers of D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.
Mon, Sep 21, 12:03 PM · Restricted Project, Restricted Project
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

X86 data collected by @lebedev.ri looks good as well.

Mon, Sep 21, 12:02 PM · Restricted Project, Restricted Project
xbolva00 added inline comments to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.
Mon, Sep 21, 5:55 AM · Restricted Project, Restricted Project

Sun, Sep 20

xbolva00 added inline comments to D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .
Sun, Sep 20, 3:01 PM
xbolva00 updated the diff for D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .

Addressed review comments.
New test cases.

Sun, Sep 20, 3:00 PM
xbolva00 requested review of D87990: [Diagnostics] Diagnose -Wsizeof-array-div for array of pointers .
Sun, Sep 20, 11:15 AM
xbolva00 added a comment to rG7903ae4720a8: [InstCombine] factorize left shifts of add/sub.

Thanks, great! :)

Sun, Sep 20, 10:07 AM
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

I have tested this patch internally and seen gains and losses. On one document search related benchmark 3~5% improvement. One zippy (snappy) there is 3~5% regression. Perhaps we do need a conditional extra SROA run.

Sun, Sep 20, 10:02 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

I have tested this patch internally and seen gains and losses. On one document search related benchmark 3~5% improvement. One zippy (snappy) there is 3~5% regression. Perhaps we do need a conditional extra SROA run.

Sun, Sep 20, 9:51 AM · Restricted Project, Restricted Project
xbolva00 retitled D87988: [SystemZ] Optimize bcmp calls (PR47420) from [SystemZ] Optimize bcmp calls to [SystemZ] Optimize bcmp calls (PR47420).
Sun, Sep 20, 9:21 AM · Restricted Project
xbolva00 requested review of D87988: [SystemZ] Optimize bcmp calls (PR47420).
Sun, Sep 20, 9:19 AM · Restricted Project
xbolva00 committed rG2ae182258c49: [Diagnostics] Fixed -Wsizeof-array-div false positive when divisor is sizeof… (authored by xbolva00).
[Diagnostics] Fixed -Wsizeof-array-div false positive when divisor is sizeof…
Sun, Sep 20, 8:43 AM
xbolva00 committed rG2990518b0324: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument (authored by xbolva00).
[MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument
Sun, Sep 20, 5:02 AM
xbolva00 added a comment to D87971: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument.

Thanks!

Sun, Sep 20, 5:02 AM · Restricted Project
xbolva00 closed D87971: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument.
Sun, Sep 20, 5:02 AM · Restricted Project
xbolva00 added inline comments to D87971: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument.
Sun, Sep 20, 4:51 AM · Restricted Project
xbolva00 updated the diff for D87971: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument.

Addressed review comments.

Sun, Sep 20, 4:50 AM · Restricted Project
xbolva00 added inline comments to D87971: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument.
Sun, Sep 20, 4:40 AM · Restricted Project
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

https://reviews.llvm.org/D68593 added late SROA to NPM so it would be good to enable it for LPM as well.

Sun, Sep 20, 4:38 AM · Restricted Project, Restricted Project
xbolva00 added inline comments to D87971: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument.
Sun, Sep 20, 3:42 AM · Restricted Project
xbolva00 added a comment to D63060: [InstCombine] usub.sat(a, b) + b => umax(a, b) (PR42178).

We'll also want to handle uadd.sat(a, b) - b, which is more complicated.

Sun, Sep 20, 2:38 AM · Restricted Project

Sat, Sep 19

xbolva00 added a reviewer for D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling: Carrot.
Sat, Sep 19, 10:40 PM · Restricted Project, Restricted Project
xbolva00 accepted D87322: [Passes] Move ADCE before DSE & LICM..

lg too

Sat, Sep 19, 12:30 PM · Restricted Project
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

geomean compile-time cost of +0.08%

Sat, Sep 19, 11:56 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

Maybe this could help https://bugs.llvm.org/show_bug.cgi?id=47439 too?

Sat, Sep 19, 11:55 AM · Restricted Project, Restricted Project
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

I meant added run line for OLDPM in unroll-sroa.ll.

Sat, Sep 19, 11:54 AM · Restricted Project, Restricted Project
xbolva00 added a comment to rL219644: Add some optional passes around the vectorizer to both better prepare.

Maybe some passes are “free” in terms of compile time and could be enabled? Now with llvm compile time tracker, it should be easy to find “cheap/expensive passes”.

Sat, Sep 19, 11:39 AM
xbolva00 added a comment to D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling.

Resolves also https://bugs.llvm.org/show_bug.cgi?id=42794?

Sat, Sep 19, 11:36 AM · Restricted Project, Restricted Project
xbolva00 committed rGfa33235df5a2: [BasicAA] Regenerate test checks (authored by xbolva00).
[BasicAA] Regenerate test checks
Sat, Sep 19, 10:36 AM
xbolva00 requested review of D87971: [MemLoc] Support lllvm.memcpy.inline in MemoryLocation::getForArgument.
Sat, Sep 19, 10:32 AM · Restricted Project
xbolva00 committed rGd716f1608cf3: [MemLoc] Support bcmp in MemoryLocation::getForArgument (authored by xbolva00).
[MemLoc] Support bcmp in MemoryLocation::getForArgument
Sat, Sep 19, 8:13 AM
xbolva00 closed D87964: [MemLoc] Support bcmp in MemoryLocation::getForArgument.
Sat, Sep 19, 8:13 AM · Restricted Project
xbolva00 updated the diff for D87964: [MemLoc] Support bcmp in MemoryLocation::getForArgument.
Sat, Sep 19, 7:58 AM · Restricted Project
xbolva00 added a comment to D87964: [MemLoc] Support bcmp in MemoryLocation::getForArgument.

Could you also add a test for BasicAA, in llvm/test/Analysis/BasicAA/libfuncs.ll?

Sat, Sep 19, 7:57 AM · Restricted Project
xbolva00 updated the diff for D87964: [MemLoc] Support bcmp in MemoryLocation::getForArgument.

Added testcase

Sat, Sep 19, 7:56 AM · Restricted Project
xbolva00 updated the diff for D87964: [MemLoc] Support bcmp in MemoryLocation::getForArgument.

Fixed test name.

Sat, Sep 19, 7:23 AM · Restricted Project
xbolva00 updated subscribers of D86725: [MemLoc] Support memcmp in MemoryLocation::getForArgument..

Okey, so as a starting point, bcmo case: https://reviews.llvm.org/D87964

Sat, Sep 19, 7:21 AM · Restricted Project
xbolva00 requested review of D87964: [MemLoc] Support bcmp in MemoryLocation::getForArgument.
Sat, Sep 19, 7:20 AM · Restricted Project
xbolva00 added a comment to D86019: [SLC] Optimize mempcpy_chk to mempcpy.

ping

Sat, Sep 19, 2:53 AM · Restricted Project

Fri, Sep 18

xbolva00 added a comment to D84951: [LV] Try to sink users recursively for first-order recurrences..

Does this patch improve some public benchmarks?

Fri, Sep 18, 12:40 AM · Restricted Project

Thu, Sep 17

xbolva00 added a comment to D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops..

Reping

Thu, Sep 17, 2:53 AM · Restricted Project

Wed, Sep 16

xbolva00 added a comment to D86019: [SLC] Optimize mempcpy_chk to mempcpy.

ping

Wed, Sep 16, 12:43 PM · Restricted Project
xbolva00 requested changes to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.

Tested the newest version of this patch and I'm still seeing massive regressions, even larger than before.

Wed, Sep 16, 1:26 AM · Restricted Project

Sat, Sep 12

xbolva00 updated the diff for D86019: [SLC] Optimize mempcpy_chk to mempcpy.

Updated.

Sat, Sep 12, 7:08 AM · Restricted Project
xbolva00 added a comment to D87479: [InstCombine] Don't sink the fdiv from (fmul (fdiv 1.0, %x), %y) if the fdiv isn't in the same basic block as the fmul.

Ouch, sorry

Sat, Sep 12, 6:35 AM · Restricted Project

Fri, Sep 11

xbolva00 added a comment to D87479: [InstCombine] Don't sink the fdiv from (fmul (fdiv 1.0, %x), %y) if the fdiv isn't in the same basic block as the fmul.

Maybe PR4268 is similar issue..

Fri, Sep 11, 11:11 AM · Restricted Project

Thu, Sep 10

xbolva00 added a comment to D87326: [ADT] Fix reference invalidation when self referencing a SmallVector.
Thu, Sep 10, 2:21 PM · Restricted Project
xbolva00 added inline comments to D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added.
Thu, Sep 10, 1:19 PM · Restricted Project
xbolva00 added a comment to D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added.
Thu, Sep 10, 12:52 PM · Restricted Project

Wed, Sep 9

xbolva00 accepted D87163: [DSE] Switch to MemorySSA-backed DSE by default..

Thanks, amazing work!

Wed, Sep 9, 6:53 AM · Restricted Project, Restricted Project

Mon, Sep 7

xbolva00 added a comment to D87183: [SCCP] Compute ranges for supported intrinsics.

@okura @uenoku Can we copy this logic into AAConstantRange too?

Mon, Sep 7, 3:18 PM · Restricted Project
xbolva00 added inline comments to rG8b300679192b: [InstCombine] improve fold of pointer differences.
Mon, Sep 7, 1:27 PM

Sun, Sep 6

xbolva00 added a comment to D57779: [SLP] Add support for throttling..

Good enough for initial implementation?

Sun, Sep 6, 7:35 AM · Restricted Project
xbolva00 updated the diff for D86019: [SLC] Optimize mempcpy_chk to mempcpy.
Sun, Sep 6, 2:10 AM · Restricted Project
xbolva00 updated the diff for D86019: [SLC] Optimize mempcpy_chk to mempcpy.

Fixed.

Sun, Sep 6, 2:08 AM · Restricted Project

Fri, Sep 4

xbolva00 added inline comments to D87163: [DSE] Switch to MemorySSA-backed DSE by default..
Fri, Sep 4, 2:19 PM · Restricted Project, Restricted Project

Wed, Sep 2

xbolva00 added a comment to D86967: [PassManager] Move load/store motion pass after DSE in LTO pipeline..

. I don't think it's worth adding new options to print the LPM pipelines for a minor change such as this one.

Wed, Sep 2, 4:26 AM · Restricted Project

Tue, Sep 1

xbolva00 updated subscribers of D86967: [PassManager] Move load/store motion pass after DSE in LTO pipeline..

cc @tejohnson

Tue, Sep 1, 1:53 PM · Restricted Project
xbolva00 added a comment to D86967: [PassManager] Move load/store motion pass after DSE in LTO pipeline..

Seems reasonable.

Tue, Sep 1, 1:09 PM · Restricted Project
xbolva00 added a comment to D86815: [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments..

Clang/LLVM accepts memcpy(NULL, NULL, 0) while GCC assumes dst/src pointers are not null. LLVM is conservative here.

Tue, Sep 1, 12:27 PM · Restricted Project
xbolva00 retitled D86815: [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments. from [LangRef] Adjust guarantee for llvm.memcyp to also allow equal arguments. to [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments..
Tue, Sep 1, 12:02 PM · Restricted Project

Aug 29 2020

xbolva00 added a comment to D37821: [SimplifyCfg] Don't sink loads/stores to geps of allocas.

Since you work with rust-lang, maybe you are interested in this patch. (Patch mentions improvements for rust code).

Aug 29 2020, 1:11 PM
xbolva00 added a comment to D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added.

No furher comments from me. If possible, commit new tests and rebase this patch.

Aug 29 2020, 9:25 AM · Restricted Project
xbolva00 added inline comments to D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added.
Aug 29 2020, 9:01 AM · Restricted Project
xbolva00 added reviewers for D37821: [SimplifyCfg] Don't sink loads/stores to geps of allocas: nikic, jdoerfert, efriedma.
Aug 29 2020, 8:10 AM
xbolva00 added inline comments to D86395: [InstCombine] transform pattern "(~A & B) ^ A -> (A | B)" added.
Aug 29 2020, 7:45 AM · Restricted Project
xbolva00 updated subscribers of rG3e69871ab5a6: [InstCombine] Take 2: Perform trivial PHI CSE.

Atleast @spatel @efriedma should really look at it..

Aug 29 2020, 4:09 AM
xbolva00 added a comment to rG3e69871ab5a6: [InstCombine] Take 2: Perform trivial PHI CSE.

No review?

Aug 29 2020, 4:05 AM
xbolva00 added a comment to D86815: [LangRef] Adjust guarantee for llvm.memcpy to also allow equal arguments..

Why would we change this? What's the point of having separate memcpy and memmove intrinsics?

I'm reading this as clang mis-uses llvm.memcpy when it probably should be using llvm.memmove

Aug 29 2020, 1:33 AM · Restricted Project

Aug 28 2020

xbolva00 added inline comments to D86725: [MemLoc] Support memcmp in MemoryLocation::getForArgument..
Aug 28 2020, 3:51 AM · Restricted Project

Aug 27 2020

xbolva00 added a comment to D84108: [SimplifyCFG][LoopRotate] SimplifyCFG: disable common instruction hoisting by default, enable late in pipeline.

But according to https://reviews.llvm.org/D65060#1596212 , the hoinsting should be done..

Aug 27 2020, 4:23 PM · Restricted Project
xbolva00 added inline comments to D86724: [BuildLibCalls] Add argmemonly to more lib calls..
Aug 27 2020, 10:18 AM · Restricted Project
xbolva00 added inline comments to D86724: [BuildLibCalls] Add argmemonly to more lib calls..
Aug 27 2020, 10:04 AM · Restricted Project
xbolva00 added inline comments to D86724: [BuildLibCalls] Add argmemonly to more lib calls..
Aug 27 2020, 10:00 AM · Restricted Project
xbolva00 added inline comments to D86687: [DAGCombiner] Enhance (zext(setcc)).
Aug 27 2020, 1:24 AM · Restricted Project

Aug 26 2020

xbolva00 added a comment to rG71f3169e1bae: [X86] Default to -mtune=generic unless -march is passed to the driver. Add….

Maybe unexpected compile time regression?

Aug 26 2020, 3:41 PM