Page MenuHomePhabricator
People xbolva00

xbolva00 (Dávid Bolvanský)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 5 2018, 5:18 PM (75 w, 2 d)

Recent Activity
View All

Today

xbolva00 added inline comments to D66688: [LoopVectorize] Leverage speculation safety to avoid masked.loads.
Sun, Sep 15, 3:15 AM · Restricted Project

Yesterday

xbolva00 added inline comments to rG6bc1236d3951: Add debug check for null pointers passed to <string_view>.
Sat, Sep 14, 1:58 PM
xbolva00 committed rGb8185153f354: [Diagnostics] Added silence note for -Wsizeof-array-div; suggest extra parens (authored by xbolva00).
[Diagnostics] Added silence note for -Wsizeof-array-div; suggest extra parens
Sat, Sep 14, 12:43 PM
xbolva00 committed rL371924: [Diagnostics] Added silence note for -Wsizeof-array-div; suggest extra parens.
[Diagnostics] Added silence note for -Wsizeof-array-div; suggest extra parens
Sat, Sep 14, 12:38 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Removed left over call.

Sat, Sep 14, 12:16 PM
xbolva00 updated the diff for D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

Addressed review comments.

Sat, Sep 14, 12:16 PM
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.

We should ditch “removeNonNull” handling since Clang never annotates callsites (Clang only annotates function signatures - currently nonnull is dropped, great!)

Sat, Sep 14, 11:51 AM
xbolva00 added inline comments to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
Sat, Sep 14, 11:27 AM
xbolva00 added reviewers for D67318: [SimplifyCFG] FoldTwoEntryPHINode(): consider *total* speculation cost, not per-BB cost: hfinkel, chandlerc.
Sat, Sep 14, 8:45 AM · Restricted Project

Fri, Sep 13

xbolva00 added a comment to D67287: [Diagnostics] Add -Wsizeof-array-div.

Hm, yes, I will disable this warning if the element type is an array I think.

Fri, Sep 13, 4:27 PM · Restricted Project
xbolva00 added a comment to D67287: [Diagnostics] Add -Wsizeof-array-div.

I added that triple yesterday, failing bot is green with it. Did you pull latest sources?

Fri, Sep 13, 11:59 AM · Restricted Project
xbolva00 added a comment to D67487: [CodeEmitter] Support instruction widths > 64 bits.

There are tests in llvm/test/TableGen/BigEncoder.td.

Fri, Sep 13, 4:14 AM · Restricted Project

Thu, Sep 12

xbolva00 added reviewers for D67512: Allow -scalar-evolution-max-iterations more than once: lebedev.ri, sanjoy, reames.
Thu, Sep 12, 12:28 PM · Restricted Project
xbolva00 added a comment to D67512: Allow -scalar-evolution-max-iterations more than once.

I dont like this. You should fix your build system instead of introducing workarounds to LLVM.

Thu, Sep 12, 12:28 PM · Restricted Project
xbolva00 added a comment to D67287: [Diagnostics] Add -Wsizeof-array-div.

Thanks, ugh, that’s weird. Yes, very questionable code. I would probably change it to

Thu, Sep 12, 2:44 AM · Restricted Project

Wed, Sep 11

xbolva00 added inline comments to D67259: [X86] Enable -mprefer-vector-width=256 by default for Skylake-avx512 and later Intel CPUs..
Wed, Sep 11, 1:00 PM · Restricted Project
xbolva00 committed rG82d9e0e12218: [NFC] Added triple to test file to avoid arm buildbots failures (authored by xbolva00).
[NFC] Added triple to test file to avoid arm buildbots failures
Wed, Sep 11, 11:56 AM
xbolva00 committed rL371646: [NFC] Added triple to test file to avoid arm buildbots failures.
[NFC] Added triple to test file to avoid arm buildbots failures
Wed, Sep 11, 11:54 AM
xbolva00 added a comment to D67287: [Diagnostics] Add -Wsizeof-array-div.

gcc devs going to implement it too (inspired by this patch ;-))

Wed, Sep 11, 10:56 AM · Restricted Project
xbolva00 added a comment to D67287: [Diagnostics] Add -Wsizeof-array-div.

This adds a new enabled-by-default warning which can break people's builds if they have -Werror.

Wed, Sep 11, 5:30 AM · Restricted Project
xbolva00 added a comment to D67287: [Diagnostics] Add -Wsizeof-array-div.

Can sou show me a false positive case?

Wed, Sep 11, 5:15 AM · Restricted Project
xbolva00 committed rG3240ad4ced0d: [Diagnostics] Add -Wsizeof-array-div (authored by xbolva00).
[Diagnostics] Add -Wsizeof-array-div
Wed, Sep 11, 4:05 AM
xbolva00 committed rL371605: [Diagnostics] Add -Wsizeof-array-div.
[Diagnostics] Add -Wsizeof-array-div
Wed, Sep 11, 3:59 AM
xbolva00 closed D67287: [Diagnostics] Add -Wsizeof-array-div.
Wed, Sep 11, 3:58 AM · Restricted Project
xbolva00 added inline comments to D65026: [Bugpoint redesign] Added pass to reduce Metadata.
Wed, Sep 11, 3:57 AM · Restricted Project
xbolva00 committed rGaf5ba2873f5e: [NFC] Updated objsize-64.ll test (authored by xbolva00).
[NFC] Updated objsize-64.ll test
Wed, Sep 11, 3:56 AM
xbolva00 committed rL371604: [NFC] Updated objsize-64.ll test.
[NFC] Updated objsize-64.ll test
Wed, Sep 11, 3:49 AM
xbolva00 added a comment to D66890: [IndVarSimplify] Do not use SCEV expander for IVCount in LFTR when possible..

How can I land tests in precommit?

Wed, Sep 11, 3:49 AM · Restricted Project
xbolva00 added inline comments to D67383: Add new optimization pass of Tree-Height-Reduction.
Wed, Sep 11, 3:47 AM · Restricted Project
xbolva00 committed rG57ebb50a0ad4: [NFC] Fixed test (authored by xbolva00).
[NFC] Fixed test
Wed, Sep 11, 3:44 AM
xbolva00 committed rL371603: [NFC] Fixed test.
[NFC] Fixed test
Wed, Sep 11, 3:40 AM
xbolva00 committed rG4dae283cd3e7: [InstCombine] Fixed handling of isOpNewLike (PR11748) (authored by xbolva00).
[InstCombine] Fixed handling of isOpNewLike (PR11748)
Wed, Sep 11, 3:38 AM
xbolva00 committed rL371602: [InstCombine] Fixed handling of isOpNewLike (PR11748).
[InstCombine] Fixed handling of isOpNewLike (PR11748)
Wed, Sep 11, 3:37 AM

Tue, Sep 10

xbolva00 added a comment to D67287: [Diagnostics] Add -Wsizeof-array-div.

Thanks for review/advices!

Tue, Sep 10, 1:42 PM · Restricted Project
xbolva00 updated the diff for D67287: [Diagnostics] Add -Wsizeof-array-div.
  • use S.Context.getAsArrayType
Tue, Sep 10, 1:42 PM · Restricted Project
xbolva00 added inline comments to D67287: [Diagnostics] Add -Wsizeof-array-div.
Tue, Sep 10, 1:14 PM · Restricted Project
xbolva00 updated the diff for D67287: [Diagnostics] Add -Wsizeof-array-div.

Addressed review notes

Tue, Sep 10, 1:14 PM · Restricted Project
xbolva00 added inline comments to D67356: [InstCombine] Simplify @llvm.usub.with.overflow+non-zero check (PR43251).
Tue, Sep 10, 1:05 PM · Restricted Project
xbolva00 added inline comments to D67356: [InstCombine] Simplify @llvm.usub.with.overflow+non-zero check (PR43251).
Tue, Sep 10, 12:49 PM · Restricted Project
xbolva00 added a comment to rG664d9d2da27d: [ExpandMemCmp] Add lit.local.cfg.

Please also fix Clang test CodeGenCXX/auto-var-init.cpp

Tue, Sep 10, 3:34 AM

Mon, Sep 9

xbolva00 added inline comments to D67356: [InstCombine] Simplify @llvm.usub.with.overflow+non-zero check (PR43251).
Mon, Sep 9, 1:51 PM · Restricted Project

Sun, Sep 8

xbolva00 added inline comments to D67105: [TargetLowering] Fix another potential FPE in expandFP_TO_UINT.
Sun, Sep 8, 8:53 AM · Restricted Project
xbolva00 updated subscribers of D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3.

Initial results from your benchmark does not indicate perf issues, but some time ago, this was posted:
https://lists.llvm.org/pipermail/llvm-dev/2018-August/125313.html

Sun, Sep 8, 2:23 AM · Restricted Project

Sat, Sep 7

xbolva00 added a comment to D67318: [SimplifyCFG] FoldTwoEntryPHINode(): consider *total* speculation cost, not per-BB cost.

Nice, these new results look very good!

Sat, Sep 7, 1:05 PM · Restricted Project
xbolva00 added reviewers for D67318: [SimplifyCFG] FoldTwoEntryPHINode(): consider *total* speculation cost, not per-BB cost: fhahn, Carrot.
Sat, Sep 7, 10:06 AM · Restricted Project
xbolva00 added a comment to D67318: [SimplifyCFG] FoldTwoEntryPHINode(): consider *total* speculation cost, not per-BB cost.

I dont have such setup, but some folks could run SPEC for you. Maybe send a RFC about this patch to llvm-dev? :)

Sat, Sep 7, 10:04 AM · Restricted Project
xbolva00 added a comment to D67318: [SimplifyCFG] FoldTwoEntryPHINode(): consider *total* speculation cost, not per-BB cost.
4 major improvements
Sat, Sep 7, 7:22 AM · Restricted Project
xbolva00 added a comment to D67259: [X86] Enable -mprefer-vector-width=256 by default for Skylake-avx512 and later Intel CPUs..

I am wondering if this can solve bad perf with avx512 reported here:
https://www.phoronix.com/scan.php?page=article&item=gcc-clang-2019&num=6

Sat, Sep 7, 6:50 AM · Restricted Project
xbolva00 added a comment to D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3.

I compared your jsons using

Sat, Sep 7, 3:54 AM · Restricted Project

Fri, Sep 6

xbolva00 added inline comments to D67287: [Diagnostics] Add -Wsizeof-array-div.
Fri, Sep 6, 2:24 PM · Restricted Project
xbolva00 updated the diff for D67287: [Diagnostics] Add -Wsizeof-array-div.

Addressed comments by @rsmith

Fri, Sep 6, 2:22 PM · Restricted Project
xbolva00 added inline comments to D67199: [InstCombine] Expand the simplification of log().
Fri, Sep 6, 2:13 PM · Restricted Project
xbolva00 accepted D67300: [ConstantFolding] Fold constant calls to log2().

Ok

Fri, Sep 6, 2:13 PM · Restricted Project
xbolva00 added a comment to D65303: [BPI] Adjust the probability for floating point unordered comparison.

I think this patch was motivated by the perf of some (micro)benchmarks attached in @Carrot’s previous patch and patch fixes the perf issue.

Fri, Sep 6, 11:19 AM · Restricted Project
xbolva00 accepted D65303: [BPI] Adjust the probability for floating point unordered comparison.

I think this change makes sense for plain static mode.

Fri, Sep 6, 11:04 AM · Restricted Project
xbolva00 added a comment to D53342: [SimplifyLibCalls] Mark known arguments with nonnull.
In D53342#1654084, @xbolva00 wrote:

We should ditch “removeNonNull” handling since Clang never annotates callsites (Clang only annotates function signatures - currently nonnull is dropped, great!)

Fri, Sep 6, 11:03 AM
xbolva00 created D67287: [Diagnostics] Add -Wsizeof-array-div.
Fri, Sep 6, 9:42 AM · Restricted Project
xbolva00 added inline comments to D66688: [LoopVectorize] Leverage speculation safety to avoid masked.loads.
Fri, Sep 6, 9:34 AM · Restricted Project
xbolva00 committed rG454e40eaf328: [NFCI] Unbreak buildbots (authored by xbolva00).
[NFCI] Unbreak buildbots
Fri, Sep 6, 9:31 AM
xbolva00 committed rL371226: [NFCI] Unbreak buildbots.
[NFCI] Unbreak buildbots
Fri, Sep 6, 9:29 AM
xbolva00 committed rGd1cc181d03b3: [NFC] Added new tests for r371222 (authored by xbolva00).
[NFC] Added new tests for r371222
Fri, Sep 6, 9:18 AM
xbolva00 committed rL371223: [NFC] Added new tests for r371222.
[NFC] Added new tests for r371222
Fri, Sep 6, 9:16 AM
xbolva00 committed rGfd0756807468: [Diagnostics] Refactor code for -Wsizeof-pointer-div, catch more cases; also… (authored by xbolva00).
[Diagnostics] Refactor code for -Wsizeof-pointer-div, catch more cases; also…
Fri, Sep 6, 9:13 AM
xbolva00 committed rL371222: [Diagnostics] Refactor code for -Wsizeof-pointer-div, catch more cases; also….
[Diagnostics] Refactor code for -Wsizeof-pointer-div, catch more cases; also…
Fri, Sep 6, 9:13 AM
xbolva00 updated subscribers of D67248: [InstCombine] pow(x, +/- 0.0) -> 1.0.

@spatel fixed it

Fri, Sep 6, 9:13 AM · Restricted Project
xbolva00 added a comment to D67259: [X86] Enable -mprefer-vector-width=256 by default for Skylake-avx512 and later Intel CPUs..

Maybe you should mention this also in Release news, that the default setting was changed and also inform users how to keep old behaviour in case new setting would cause regressions for them.

Fri, Sep 6, 6:34 AM · Restricted Project
xbolva00 added a comment to D67192: [X86] Use MOVSX instead of CBW to extend i8 to AX for i8 sdiv..

Please also update the patch summary before commiting

Fri, Sep 6, 4:27 AM · Restricted Project
xbolva00 updated subscribers of D65148: [SimplifyCFG] Bump phi-node-folding-threshold from 2 to 3.

Yes, we need test suite numbers.

Fri, Sep 6, 3:01 AM · Restricted Project
xbolva00 accepted D67248: [InstCombine] pow(x, +/- 0.0) -> 1.0.

lg too

Fri, Sep 6, 2:31 AM · Restricted Project

Thu, Sep 5

xbolva00 added inline comments to D67232: [Attributor][Fix] Initialize the cache prior to using it.
Thu, Sep 5, 5:24 PM · Restricted Project
xbolva00 committed rG591679929373: [GSYM][NFC] Fixed -Wdocumentation warning (authored by xbolva00).
[GSYM][NFC] Fixed -Wdocumentation warning
Thu, Sep 5, 2:14 PM
xbolva00 updated subscribers of D67013: [GVN] Verify value equality before doing phi translation for call instruction.

Probably good candidate for 9.0.1.

Thu, Sep 5, 2:14 PM · Restricted Project
xbolva00 committed rL371125: [GSYM][NFC] Fixed -Wdocumentation warning.
[GSYM][NFC] Fixed -Wdocumentation warning
Thu, Sep 5, 2:08 PM
xbolva00 added a comment to D67192: [X86] Use MOVSX instead of CBW to extend i8 to AX for i8 sdiv..

New codegen looks nice

Thu, Sep 5, 1:51 PM · Restricted Project
xbolva00 committed rG872108bea55f: [Diagnostics] Minor improvements for -Wxor-used-as-pow (authored by xbolva00).
[Diagnostics] Minor improvements for -Wxor-used-as-pow
Thu, Sep 5, 1:51 PM
xbolva00 committed rL371122: [Diagnostics] Minor improvements for -Wxor-used-as-pow.
[Diagnostics] Minor improvements for -Wxor-used-as-pow
Thu, Sep 5, 1:49 PM
xbolva00 added a reviewer for D67205: [SimplifyCFG] Don't SimplifyBranchOnICmpChain with ExtraCase: efriedma.
Thu, Sep 5, 11:01 AM · Restricted Project
xbolva00 added inline comments to rG97aa42f5dfcd: [X86] Add a FIXME about why the CWD/CDQ/CQO have a bogus implicit def of the A….
Thu, Sep 5, 10:55 AM
xbolva00 added inline comments to rG8360c42e2510: [InstCombine] foldICmpBinOp(): consider inverted check in 'unsigned sub….
Thu, Sep 5, 10:49 AM
xbolva00 added a comment to D42981: [COST] Fix cost model of load instructions on X86.

benchmarks?

Thu, Sep 5, 8:36 AM · Restricted Project

Wed, Sep 4

xbolva00 added a comment to D66397: [Diagnostics] Improve -Wxor-used-as-pow.

Ok, I will fix it as you suggested.

Wed, Sep 4, 3:18 PM · Restricted Project
xbolva00 abandoned D66397: [Diagnostics] Improve -Wxor-used-as-pow.
Wed, Sep 4, 3:09 PM · Restricted Project
xbolva00 added inline comments to D66397: [Diagnostics] Improve -Wxor-used-as-pow.
Wed, Sep 4, 3:04 PM · Restricted Project
xbolva00 added inline comments to D66397: [Diagnostics] Improve -Wxor-used-as-pow.
Wed, Sep 4, 2:57 PM · Restricted Project
xbolva00 added inline comments to D66397: [Diagnostics] Improve -Wxor-used-as-pow.
Wed, Sep 4, 2:30 PM · Restricted Project
xbolva00 added inline comments to D66397: [Diagnostics] Improve -Wxor-used-as-pow.
Wed, Sep 4, 2:30 PM · Restricted Project
xbolva00 added a comment to rL370972: [c++20] P1143R2: Add support for the C++20 'constinit' keyword..

gcc also added __constinit as C extension.

Wed, Sep 4, 1:37 PM
xbolva00 added a comment to D67188: [InstCombine] sub(xor(x, y), or(x, y)) -> neg(and(x, y)).

Thank you.

Wed, Sep 4, 11:07 AM · Restricted Project
xbolva00 committed rG420cbb6190e9: [InstCombine] sub(xor(x, y), or(x, y)) -> neg(and(x, y)) (authored by xbolva00).
[InstCombine] sub(xor(x, y), or(x, y)) -> neg(and(x, y))
Wed, Sep 4, 11:04 AM
xbolva00 committed rL370945: [InstCombine] sub(xor(x, y), or(x, y)) -> neg(and(x, y)).
[InstCombine] sub(xor(x, y), or(x, y)) -> neg(and(x, y))
Wed, Sep 4, 11:02 AM
xbolva00 closed D67188: [InstCombine] sub(xor(x, y), or(x, y)) -> neg(and(x, y)).
Wed, Sep 4, 11:01 AM · Restricted Project
xbolva00 committed rGf6233d90f0d8: [NFC] Added tests for new fold (authored by xbolva00).
[NFC] Added tests for new fold
Wed, Sep 4, 10:38 AM
xbolva00 created D67188: [InstCombine] sub(xor(x, y), or(x, y)) -> neg(and(x, y)).
Wed, Sep 4, 10:37 AM · Restricted Project
xbolva00 committed rL370941: [NFC] Added tests for new fold.
[NFC] Added tests for new fold
Wed, Sep 4, 10:35 AM
xbolva00 committed rG2ceb00db768c: [NFC] Adjust test filename (authored by xbolva00).
[NFC] Adjust test filename
Wed, Sep 4, 10:34 AM
xbolva00 committed rL370939: [NFC] Adjust test filename.
[NFC] Adjust test filename
Wed, Sep 4, 10:33 AM
xbolva00 committed rG0e07248704fa: [InstCombine] Fold sub (and A, B) (or A, B)) to neg (xor A, B) (authored by xbolva00).
[InstCombine] Fold sub (and A, B) (or A, B)) to neg (xor A, B)
Wed, Sep 4, 10:33 AM
xbolva00 committed rL370934: [InstCombine] Fold sub (and A, B) (or A, B)) to neg (xor A, B).
[InstCombine] Fold sub (and A, B) (or A, B)) to neg (xor A, B)
Wed, Sep 4, 10:29 AM
xbolva00 closed D67155: [InstCombine] Fold sub (and A, B) (or A, B)) to neg (xor A, B).
Wed, Sep 4, 10:29 AM · Restricted Project
xbolva00 added a reviewer for D67159: [clang] New __attribute__((__clang_arm_mve_alias)).: aaron.ballman.
Wed, Sep 4, 5:50 AM · Restricted Project