- User Since
- Thu, Apr 5, 5:18 PM (2 w, 2 d)
@efriedma is it now OK? Or is there anything to improve?
Fixed things .
Which additional tests you would like to see?
Thu, Apr 19
No you can merge this patch, @spatel
@efriedma . may I add tests for "capture detection" only for one IO call, e.g. fwrite? Since all others depends on the "isReplaceableWithUnlockedVariant" anyway..
Another idea if you want to implement it - check fopen.
Shouldn't it catch in curl also this code?
Wed, Apr 18
Adressed notes by @efriedma
NoCapture attributes check now work.
Update with the context
Tue, Apr 17
Would be ok if we simplify getc to fgetc_unlocked and not getc_unlocked?
Mon, Apr 16
Added tests for atol, atoll, strtoll.
Updated, fixed things.
Updated with changes requested by @efriedma .
Any review or merge? @spatel ?
Sun, Apr 15
@efriedma , is now everything ok?
Sat, Apr 14
Please update with the context.
Fri, Apr 13
Thu, Apr 12
Updated, use strtoll now. @efriedma
Wed, Apr 11
Patch updated with suggested changes by @lebedev.ri
I would like to hear your feedback on these three changes
Fixed things noted by @efriedma
Is patch now ok for you, @efriedma ?