- User Since
- Apr 5 2018, 5:18 PM (75 w, 2 d)
Removed left over call.
Addressed review comments.
We should ditch “removeNonNull” handling since Clang never annotates callsites (Clang only annotates function signatures - currently nonnull is dropped, great!)
Fri, Sep 13
Hm, yes, I will disable this warning if the element type is an array I think.
I added that triple yesterday, failing bot is green with it. Did you pull latest sources?
There are tests in llvm/test/TableGen/BigEncoder.td.
Thu, Sep 12
I dont like this. You should fix your build system instead of introducing workarounds to LLVM.
Thanks, ugh, that’s weird. Yes, very questionable code. I would probably change it to
Wed, Sep 11
gcc devs going to implement it too (inspired by this patch ;-))
This adds a new enabled-by-default warning which can break people's builds if they have -Werror.
Can sou show me a false positive case?
How can I land tests in precommit?
Tue, Sep 10
Thanks for review/advices!
- use S.Context.getAsArrayType
Addressed review notes
Please also fix Clang test CodeGenCXX/auto-var-init.cpp
Mon, Sep 9
Sun, Sep 8
Initial results from your benchmark does not indicate perf issues, but some time ago, this was posted:
Sat, Sep 7
Nice, these new results look very good!
I dont have such setup, but some folks could run SPEC for you. Maybe send a RFC about this patch to llvm-dev? :)
4 major improvements
I am wondering if this can solve bad perf with avx512 reported here:
I compared your jsons using
Fri, Sep 6
Addressed comments by @rsmith
I think this patch was motivated by the perf of some (micro)benchmarks attached in @Carrot’s previous patch and patch fixes the perf issue.
I think this change makes sense for plain static mode.
@spatel fixed it
Maybe you should mention this also in Release news, that the default setting was changed and also inform users how to keep old behaviour in case new setting would cause regressions for them.
Please also update the patch summary before commiting
Yes, we need test suite numbers.
Thu, Sep 5
Probably good candidate for 9.0.1.
New codegen looks nice
Wed, Sep 4
Ok, I will fix it as you suggested.
gcc also added __constinit as C extension.