[libcxx][spaceship][doc] Repair links and clean up spaceship progress doc

[mumbleskates]

Summary

Previously the specification was in a table in paragraph 14 of [container.requirements.general] but it has since been given its own sub section header, 24.2.2.4 [container.opt.reqmts].

This happened in https://github.com/cplusplus/draft/commit/93ff092d1cd2b335f372b9546365b3d495caf2d8

This update also includes misc. other cleanups of the spaceship projects sheet.

[avogelsgesang]

libcxx/docs/Status/SpaceshipProjects.csv

38

I get a 404 error when opening https://wg21.link/container.opt.reqmts

[mumbleskates]

• use a version of the link that does not currently 404 on wg21.link

[mumbleskates]

libcxx/docs/Status/SpaceshipProjects.csv

38

yeah, i don't know why. it should work, it's present in https://eel.is/c++draft/container.opt.reqmts . this change was committed to the draft document in early february, over 6 months ago.

it seems that wg21 may be either lagging very far behind by accident or lagging behind on purpose because it is indexing the headers of an older version of the standards document. in the former case someone should see if they can kick it and get it up to date, and in the latter case it should instead redirect to a site that hosts the version of the document it is trying to reflect.

[mumbleskates]

• fix typo in "chrono::time_point"
• fix broken formatting for the "basic_string" hyperlink
• link to differentials of completed project items
• Merge branch 'main' into doc2

[avogelsgesang]

LGTM, thanks!

[avogelsgesang]

libcxx/docs/Status/SpaceshipProjects.csv

43

https://wg21.link/container.opt.reqmts was fixed! :) Let's go back to using https://wg21.link/container.opt.reqmts

[mumbleskates]

• Revert "use a version of the link that does not currently 404 on wg21.link"

[mumbleskates]

• Merge remote-tracking branch 'upstream/main' into doc2

[mumbleskates]

• Merge branch 'main' into doc2

[mumbleskates]

Sorry! Something has gone horribly wrong with my usage of arcanist and it diffed against a very old version of main. i will try to repair the reviewers list.

[Mordante]

Please update the commit message to use proper sentences.

Otherwise LGTM and thanks for updating the page!

libcxx/docs/Status/SpaceshipProjects.csv

34

This page is only used to track the status of the spaceship operator. After it's implemented the page will be removed.
I don't mind that you spend time on finding the commit and adding it, but I just want to make sure that you know what the status of this page itself will be.
(For the format status I tend to be more aggressive in removing details.)

[avogelsgesang]

libcxx/docs/Status/SpaceshipProjects.csv

34

Afaict, before calling P1614R2 done, we will have to go through this list once more to make sure we actually implemented everything correctly. (As we saw the other day, this list here is unfortunately incomplete). I guess for this double-checking, having the correct review linked will be useful...

[mumbleskates]

libcxx/docs/Status/SpaceshipProjects.csv

34

Yes to both of these comments. I added these links for consistency and because it's extremely easy to find the related differentials from the blame of the doc. After this is looking done I'm planning to do a full pass through the P1614R2 doc and making sure everything is in.

[Mordante]

libcxx/docs/Status/SpaceshipProjects.csv

34

We indeed have to validate it since we know the list is incomplete :-( But for that we don't need the revision numbers per se. I just wanted to make sure we're all aware this page is intended to be temporary.

I know that for regex the removal of the operator!=s is missing, but I'll add these when I start to work on them; probably next week. (I get the impression more of these removals are missing.)

[mumbleskates]

libcxx/docs/Status/SpaceshipProjects.csv

34

You're right, this is a big one to check. when i created the document i did so by grepping through the (at the time) current draft standard for "<=>", so i didn't really find any of the non-ordering operator removals.

[Mordante]

libcxx/docs/Status/SpaceshipProjects.csv

34

I think it would be easier to grep the paper for removal of operator!= and look for the ones where no operator<=> is added.

[avogelsgesang]

libcxx/docs/Status/SpaceshipProjects.csv

34

note that grepping for operator!= might still not be sufficient. In some cases (e.g., filesystem::space_info, the paper added an operator== but no operator<=>

libcxx/docs/Status/SpaceshipProjects.csv

 "| `[variant.relops] <https://wg21.link/variant.relops>`_
 | `[variant.monostate.relops] <https://wg21.link/variant.monostate.relops>`_","| `monostate <https://reviews.llvm.org/D131372>`_
 | `variant <https://reviews.llvm.org/D131372>`_",None,Kent Ross,|Complete|
 | `[unique.ptr.special] <https://wg21.link/unique.ptr.special>`_,| `unique_ptr <https://reviews.llvm.org/D130838>`_,[comparisons.three.way],Adrian Vogelsgesang,|Complete|
 | `[util.smartptr.shared.cmp] <https://wg21.link/util.smartptr.shared.cmp>`_,| `shared_ptr <https://reviews.llvm.org/D130852>`_,[comparisons.three.way],Adrian Vogelsgesang,|Complete|
 | `[type.index.members] <https://wg21.link/type.index.members>`_,| `type_index <https://reviews.llvm.org/D131357>`_,None,Adrian Vogelsgesang,|Complete|
 | `[charconv.syn] <https://wg21.link/charconv.syn>`_,| to_chars_result,None,Mark de Wever,|Complete|
 | `[charconv.syn] <https://wg21.link/charconv.syn>`_,| from_chars_result,None,Mark de Wever,|Complete|
 | `[stacktrace.entry.cmp] <https://wg21.link/stacktrace.entry.cmp>`_,| stacktrace_entry,None,Unassigned,|Not Started|
 | `[stacktrace.basic.cmp] <https://wg21.link/stacktrace.basic.cmp>`_,| basic_stacktrace,[alg.three.way],Unassigned,|Not Started|
 | `[string.cmp] <https://wg21.link/string.cmp>`_,| `basic_string <https://reviews.llvm.org/D131421>`,None,Mark de Wever,|Complete|
 | `[string.view.comparison] <https://wg21.link/string.view.comparison>`_,| `basic_string_view <https://reviews.llvm.org/D130295>`_,None,Mark de Wever,|Complete|
-| `[array.syn] <https://wg21.link/array.syn>`_ (`general <https://wg21.link/container.requirements.general#14>`_),| array,[expos.only.func],Unassigned,|Not Started|
-| `[deque.syn] <https://wg21.link/deque.syn>`_ (`general <https://wg21.link/container.requirements.general#14>`_),| deque,[expos.only.func],Unassigned,|Not Started|
-| `[forward.list.syn] <https://wg21.link/forward.list.syn>`_ (`general <https://wg21.link/container.requirements.general#14>`_),| forward_list,[expos.only.func],Unassigned,|Not Started|
-| `[list.syn] <https://wg21.link/list.syn>`_ (`general <https://wg21.link/container.requirements.general#14>`_),| list,[expos.only.func],Unassigned,|Not Started|
-| `[vector.syn] <https://wg21.link/vector.syn>`_ (`general <https://wg21.link/container.requirements.general#14>`_),| vector,[expos.only.func],Unassigned,|Not Started|
-| `[associative.map.syn] <https://wg21.link/associative.map.syn>`_ (`general <https://wg21.link/container.requirements.general#14>`_),"| map
+| `[array.syn] <https://wg21.link/array.syn>`_ (`general <https://wg21.link/container.opt.reqmts>`_),| array,[expos.only.func],Unassigned,|Not Started|
+| `[deque.syn] <https://wg21.link/deque.syn>`_ (`general <https://wg21.link/container.opt.reqmts>`_),| deque,[expos.only.func],Unassigned,|Not Started|
+| `[forward.list.syn] <https://wg21.link/forward.list.syn>`_ (`general <https://wg21.link/container.opt.reqmts>`_),| forward_list,[expos.only.func],Unassigned,|Not Started|
+| `[list.syn] <https://wg21.link/list.syn>`_ (`general <https://wg21.link/container.opt.reqmts>`_),| list,[expos.only.func],Unassigned,|Not Started|
+| `[vector.syn] <https://wg21.link/vector.syn>`_ (`general <https://wg21.link/container.opt.reqmts>`_),| vector,[expos.only.func],Unassigned,|Not Started|
+| `[associative.map.syn] <https://wg21.link/associative.map.syn>`_ (`general <https://wg21.link/container.opt.reqmts>`_),"| map
 | multimap",[expos.only.func],Unassigned,|Not Started|
-| `[associative.set.syn] <https://wg21.link/associative.set.syn>`_ (`general <https://wg21.link/container.requirements.general#14>`_),"| multiset
+| `[associative.set.syn] <https://wg21.link/associative.set.syn>`_ (`general <https://wg21.link/container.opt.reqmts>`_),"| multiset
 | set",[expos.only.func],Unassigned,|Not Started|
 | `[queue.ops] <https://wg21.link/queue.ops>`_,| queue,None,Unassigned,|Not Started|
 | `[stack.ops] <https://wg21.link/stack.ops>`_,| stack,None,Unassigned,|Not Started|
 | `[reverse.iter.cmp] <https://wg21.link/reverse.iter.cmp>`_,| reverse_iterator,None,Mikhail Maltsev,|Complete|
 | `[move.iter.op.comp] <https://wg21.link/move.iter.op.comp>`_,| move_iterator,None,Unassigned,|Not Started|
 | `[counted.iter.cmp] <https://wg21.link/counted.iter.cmp>`_,| counted_iterator,None,Unassigned,|Not Started|
 | `[range.iota.iterator] <https://wg21.link/range.iota.iterator>`_,| `ranges::iota_view::iterator <https://reviews.llvm.org/D110774>`_,[concepts.cmp],Arthur O'Dwyer,|Complete|
 | `[range.transform.iterator] <https://wg21.link/range.transform.iterator>`_,| `ranges::transform_view::iterator <https://reviews.llvm.org/D110774>`_,[concepts.cmp],Arthur O'Dwyer,|Complete|