Page MenuHomePhabricator

rriddle (River Riddle)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2016, 2:24 PM (260 w, 5 d)

Recent Activity

Today

rriddle accepted D104489: [mlir] Add notes about using external interface application..
Thu, Jun 17, 2:40 PM · Restricted Project
rriddle added a comment to D104369: [mlir-tblgen] Avoid ODS verifier duplication.

Thanks for looking into this! Looks like a great improvement!

Thu, Jun 17, 2:15 AM · Restricted Project
rriddle accepted D104443: [mlir-reduce] Improve diagnostic message and clean build dependency.

Looks good, thanks!

Thu, Jun 17, 2:13 AM · Restricted Project
rriddle accepted D103969: [mlir] Add EmitC dialect.

Thanks a lot for the work! This looks fine to land and build on.

Thu, Jun 17, 2:11 AM · Restricted Project
rriddle accepted D104397: [mlir] Enable delayed registration of attribute/operation/type interfaces.
Thu, Jun 17, 1:59 AM · Restricted Project
rriddle accepted D104294: [mlir] separable registration of operation interfaces.
Thu, Jun 17, 1:48 AM · Restricted Project

Yesterday

rriddle added a comment to D104430: Improve error reporting on pass registration collision (NFC) # Please enter the commit message for your changes. Lines starting.

LGTM (but I think you already landed this)

I haven't actually :)

Wed, Jun 16, 7:47 PM · Restricted Project
rriddle committed rG5a55205bb31f: [mlir] Fixed dynamic operand storage on big-endian machines. (authored by imaihal).
[mlir] Fixed dynamic operand storage on big-endian machines.
Wed, Jun 16, 6:42 PM
rriddle closed D104225: [mlir] Fixed dynamic operand storage on big-endian machines..
Wed, Jun 16, 6:42 PM · Restricted Project
rriddle accepted D104430: Improve error reporting on pass registration collision (NFC) # Please enter the commit message for your changes. Lines starting.

LGTM (but I think you already landed this)

Wed, Jun 16, 6:35 PM · Restricted Project
rriddle committed rG854ef875b929: [mlir-vscode] Add a link to mlir.llvm.org at the top of the vscode extension doc (authored by rriddle).
[mlir-vscode] Add a link to mlir.llvm.org at the top of the vscode extension doc
Wed, Jun 16, 6:22 PM
rriddle committed rGd3c895a870d3: [mlir-lsp-server] Add an explicit blurb on where to send code contributions. (authored by rriddle).
[mlir-lsp-server] Add an explicit blurb on where to send code contributions.
Wed, Jun 16, 6:22 PM
rriddle committed rGfcecfcb92c77: [mlir-lsp-server][Docs] Tweak the documentation for the visual studio code… (authored by rriddle).
[mlir-lsp-server][Docs] Tweak the documentation for the visual studio code…
Wed, Jun 16, 5:59 PM
rriddle accepted D104384: [mlir] ODS: emit interface traits outside of the interface class.
Wed, Jun 16, 5:32 PM · Restricted Project
rriddle accepted D104429: Remove deprecated registration APIs (NFC).

Can you fix the description?

Wed, Jun 16, 5:23 PM · Restricted Project
rriddle added inline comments to D104421: Decouple registring passes from specifying argument/description.
Wed, Jun 16, 4:37 PM · Restricted Project
rriddle added a comment to D104421: Decouple registring passes from specifying argument/description.

We should update the docs as well.

Wed, Jun 16, 3:24 PM · Restricted Project
rriddle accepted D104421: Decouple registring passes from specifying argument/description.
Wed, Jun 16, 2:35 PM · Restricted Project
rriddle accepted D104399: Add hook for dialect specializing processing blocks post inlining calls.
Wed, Jun 16, 12:45 PM · Restricted Project
rriddle added a comment to D104399: Add hook for dialect specializing processing blocks post inlining calls.

Missing the test?

Wed, Jun 16, 12:15 PM · Restricted Project
rriddle added inline comments to D104411: Fix verifier crashing on some invalid IR.
Wed, Jun 16, 12:12 PM · Restricted Project
rriddle accepted D104411: Fix verifier crashing on some invalid IR.
Wed, Jun 16, 12:11 PM · Restricted Project

Tue, Jun 15

rriddle accepted D104234: [mlir] separable registration of attribute and type interfaces.

LG thanks! This has been on the TODO for a while, but just never found the time.

Tue, Jun 15, 1:10 AM · Restricted Project
rriddle added a comment to D103969: [mlir] Add EmitC dialect.

Thanks, took another pass. Probably just one more after this one.

Tue, Jun 15, 12:54 AM · Restricted Project
rriddle added a comment to D104110: [mlir][Linalg] Introduce a BufferizationAliasInfo (6/n).

Thanks! Starting working through, mostly stylistic nits while digesting the design.

Tue, Jun 15, 12:38 AM · Restricted Project

Mon, Jun 14

rriddle accepted D104274: [mlir:OpFormatGen] Add Support for `$_ctxt` in the transformer..
Mon, Jun 14, 6:00 PM · Restricted Project
rriddle added inline comments to D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.
Mon, Jun 14, 2:39 PM · Restricted Project
rriddle added inline comments to D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.
Mon, Jun 14, 2:33 PM · Restricted Project
rriddle added inline comments to D104167: [mlir][OpGen] Cache Identifiers for known attribute names in AbstractOperation..
Mon, Jun 14, 1:45 PM · Restricted Project
rriddle updated the diff for D104167: [mlir][OpGen] Cache Identifiers for known attribute names in AbstractOperation..

rebase

Mon, Jun 14, 1:45 PM · Restricted Project
rriddle added inline comments to D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.
Mon, Jun 14, 12:39 PM · Restricted Project
rriddle updated the diff for D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.

update

Mon, Jun 14, 12:38 PM · Restricted Project
rriddle accepted D104225: [mlir] Fixed dynamic operand storage on big-endian machines..

Nice, thanks for the fix!

Mon, Jun 14, 11:22 AM · Restricted Project
rriddle committed rG66e27082054b: [mlir:Linalg] Populate LinalgOp patterns on LinalgDialect as opposed to each op (authored by rriddle).
[mlir:Linalg] Populate LinalgOp patterns on LinalgDialect as opposed to each op
Mon, Jun 14, 11:21 AM
rriddle closed D104160: [mlir:Linalg] Populate LinalgOp patterns on LinalgDialect as opposed to each op.
Mon, Jun 14, 11:21 AM · Restricted Project
rriddle accepted D104233: [mlir] ODS: do not emit trailing const for static methods.

Nice, thanks!

Mon, Jun 14, 11:15 AM · Restricted Project
rriddle accepted D104243: [PassManager] Save compile time by not running the verifier unnecessarily. NFC.

LGTM, nice!

Mon, Jun 14, 11:14 AM · Restricted Project
rriddle added a comment to D104173: [mlir] Add value_begin/value_end methods to DenseElementsAttr.

Im missing the motivation a little bit: is this to reduce number of characters typed or what is the benefit?

Mon, Jun 14, 11:06 AM · Restricted Project
rriddle accepted D104207: [Verifier] Parallelize verification and dom checking. NFC..

LGTM, thanks!

Mon, Jun 14, 12:51 AM · Restricted Project

Sat, Jun 12

rriddle accepted D104189: Simplify getArgAttrDict/getResultAttrDict by removing unnecessary checks.
Sat, Jun 12, 3:21 PM · Restricted Project

Fri, Jun 11

rriddle requested review of D104173: [mlir] Add value_begin/value_end methods to DenseElementsAttr.
Fri, Jun 11, 9:05 PM · Restricted Project
rriddle added a comment to D104167: [mlir][OpGen] Cache Identifiers for known attribute names in AbstractOperation..

OOC what is the memory usage impact?

Fri, Jun 11, 9:03 PM · Restricted Project
rriddle requested review of D104167: [mlir][OpGen] Cache Identifiers for known attribute names in AbstractOperation..
Fri, Jun 11, 6:10 PM · Restricted Project
rriddle requested review of D104160: [mlir:Linalg] Populate LinalgOp patterns on LinalgDialect as opposed to each op.
Fri, Jun 11, 4:55 PM · Restricted Project

Thu, Jun 10

rriddle requested changes to D103969: [mlir] Add EmitC dialect.

Thanks, starting to work through it.

Thu, Jun 10, 6:24 PM · Restricted Project
rriddle committed rG8800047707a9: [mlir-ir-printing] Prefix the dump message with the split marker(// -----) (authored by rriddle).
[mlir-ir-printing] Prefix the dump message with the split marker(// -----)
Thu, Jun 10, 5:43 PM
rriddle closed D104073: [mlir-ir-printing] Prefix the dump message with the split marker(// -----).
Thu, Jun 10, 5:43 PM · Restricted Project
rriddle committed rGc42dd5dbb015: [mlir] Add new SubElementAttr/SubElementType Interfaces (authored by rriddle).
[mlir] Add new SubElementAttr/SubElementType Interfaces
Thu, Jun 10, 5:29 PM
rriddle committed rGf8a1d652da00: [mlir][IR] Move MemRefElementTypeInterface to a new BuiltinTypeInterfaces file (authored by rriddle).
[mlir][IR] Move MemRefElementTypeInterface to a new BuiltinTypeInterfaces file
Thu, Jun 10, 5:29 PM
rriddle closed D102945: [mlir] Add new SubElementAttr/SubElementType Interfaces.
Thu, Jun 10, 5:28 PM · Restricted Project
rriddle requested review of D104073: [mlir-ir-printing] Prefix the dump message with the split marker(// -----).
Thu, Jun 10, 4:28 PM · Restricted Project
rriddle committed rGc0e6f2f43a4c: [mlir-vscode] Fix dependencies to enable packaging the extension properly. (authored by rriddle).
[mlir-vscode] Fix dependencies to enable packaging the extension properly.
Thu, Jun 10, 11:34 AM
rriddle committed rGbb97959949ff: [mlir-lsp-server] Document the features provided by the language server (authored by rriddle).
[mlir-lsp-server] Document the features provided by the language server
Thu, Jun 10, 11:04 AM
rriddle committed rGff81a2c95ddb: [mlir-lsp-server] Add support for textDocument/documentSymbols (authored by rriddle).
[mlir-lsp-server] Add support for textDocument/documentSymbols
Thu, Jun 10, 11:04 AM
rriddle closed D103942: [mlir-lsp-server] Document the features provided by the language server.
Thu, Jun 10, 11:04 AM · Restricted Project
rriddle closed D103729: [mlir-lsp-server] Add support for textDocument/documentSymbols.
Thu, Jun 10, 11:04 AM · Restricted Project
rriddle accepted D102525: [MLIR] Document that Dialect Conversion traverses in preorder.

Thanks. (Sorry, missed this somehow)

Thu, Jun 10, 10:24 AM · Restricted Project
rriddle added inline comments to D103729: [mlir-lsp-server] Add support for textDocument/documentSymbols.
Thu, Jun 10, 10:22 AM · Restricted Project

Wed, Jun 9

rriddle added a comment to D103591: [mlir] Allow move-only RewritePattern arguments.

Are the test failures related? They look like they might be.

Yes, they are real. The arguments here are rvalues, so after the first pattern they are use-after-move.

I'm not sure if I want to proceed with this change. It might be safer to require using the add() overload on line 960 if pattern arguments are move-only. WDYT?

Wed, Jun 9, 12:05 AM · Restricted Project

Tue, Jun 8

rriddle accepted D103356: Reset all options in cl::ResetCommandLineParser().

This looks right to me, but might be good to get another LGTM.

Tue, Jun 8, 11:29 PM · Restricted Project
rriddle updated the diff for D103942: [mlir-lsp-server] Document the features provided by the language server.

update

Tue, Jun 8, 11:12 PM · Restricted Project
rriddle requested review of D103942: [mlir-lsp-server] Document the features provided by the language server.
Tue, Jun 8, 11:08 PM · Restricted Project
rriddle added a comment to D103373: [Verifier] Speed up and parallelize dominance checking. NFC.

I thought you abandoned this change? Looks like you landed it.

Tue, Jun 8, 2:12 PM · Restricted Project
rriddle added inline comments to D103822: [MLIR] Mark additional builtin attr methods const.
Tue, Jun 8, 12:38 PM · Restricted Project
rriddle added inline comments to D103827: [mlir] Make MemRef element type extensible.
Tue, Jun 8, 1:26 AM · Restricted Project
rriddle accepted D103827: [mlir] Make MemRef element type extensible.

Can you add a link to the discussion for this?

https://llvm.discourse.group/t/rfc-memref-of-custom-types/3558

Tue, Jun 8, 1:24 AM · Restricted Project
rriddle accepted D103828: [mlir] support memref of memref in standard-to-llvm conversion.
Tue, Jun 8, 1:20 AM · Restricted Project
rriddle accepted D103754: [Core] Add Twine support for StringAttr and Identifier. NFC..
Tue, Jun 8, 1:16 AM · Restricted Project

Mon, Jun 7

rriddle added a comment to D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.

Thanks for the review, PTAL.

Mon, Jun 7, 5:35 PM · Restricted Project
rriddle updated the diff for D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.

update

Mon, Jun 7, 5:34 PM · Restricted Project
rriddle added inline comments to D103649: [mlir] Add support to SourceMgrDiagnosticHandler for filtering FileLineColLocs.
Mon, Jun 7, 5:34 PM · Restricted Project
rriddle updated the diff for D103729: [mlir-lsp-server] Add support for textDocument/documentSymbols.

update

Mon, Jun 7, 4:00 PM · Restricted Project
rriddle committed rG2db4701cafd4: [mlir-lsp-server] Fix bug in symbol use/def tracking (authored by rriddle).
[mlir-lsp-server] Fix bug in symbol use/def tracking
Mon, Jun 7, 2:11 PM
rriddle committed rG4c3adea7a4ab: [mlir-lsp-server] Add support for hover on symbol references (authored by rriddle).
[mlir-lsp-server] Add support for hover on symbol references
Mon, Jun 7, 2:11 PM
rriddle committed rGf492c3596503: [mlir-lsp-server] Add support for hover on region operations (authored by rriddle).
[mlir-lsp-server] Add support for hover on region operations
Mon, Jun 7, 2:11 PM
rriddle closed D103730: [mlir-lsp-server] Fix bug in symbol use/def tracking.
Mon, Jun 7, 2:11 PM · Restricted Project
rriddle closed D103728: [mlir-lsp-server] Add support for hover on symbol references.
Mon, Jun 7, 2:10 PM · Restricted Project
rriddle closed D103727: [mlir-lsp-server] Add support for hover on region operations.
Mon, Jun 7, 2:10 PM · Restricted Project
rriddle added inline comments to D103728: [mlir-lsp-server] Add support for hover on symbol references.
Mon, Jun 7, 1:51 PM · Restricted Project
rriddle added inline comments to D103727: [mlir-lsp-server] Add support for hover on region operations.
Mon, Jun 7, 1:35 PM · Restricted Project
rriddle added inline comments to D103830: [MLIR][GPU] Simplify memcpy of cast.
Mon, Jun 7, 11:25 AM · Restricted Project
rriddle added a comment to D103591: [mlir] Allow move-only RewritePattern arguments.

Are the test failures related? They look like they might be.

Mon, Jun 7, 10:52 AM · Restricted Project
rriddle added a comment to D103754: [Core] Add Twine support for StringAttr and Identifier. NFC..

I'm open to that, only two downsides I can think of:

  1. absolutely tiny additional runtime overhead, slight codebloat for making the temporary twine. I'm not concerned about this.
  1. additional header depedency for everything that uses these methods, they'd have to include twine.h. This may already be happening implicitly though.
Mon, Jun 7, 10:48 AM · Restricted Project
rriddle accepted D103822: [MLIR] Mark additional builtin attr methods const.
Mon, Jun 7, 10:45 AM · Restricted Project
rriddle added inline comments to D103828: [mlir] support memref of memref in standard-to-llvm conversion.
Mon, Jun 7, 10:41 AM · Restricted Project
rriddle added a comment to D103827: [mlir] Make MemRef element type extensible.

Can you add a link to the discussion for this?

Mon, Jun 7, 10:33 AM · Restricted Project

Fri, Jun 4

rriddle requested review of D103730: [mlir-lsp-server] Fix bug in symbol use/def tracking.
Fri, Jun 4, 5:08 PM · Restricted Project
rriddle requested review of D103729: [mlir-lsp-server] Add support for textDocument/documentSymbols.
Fri, Jun 4, 5:07 PM · Restricted Project
rriddle requested review of D103728: [mlir-lsp-server] Add support for hover on symbol references.
Fri, Jun 4, 5:06 PM · Restricted Project
rriddle requested review of D103727: [mlir-lsp-server] Add support for hover on region operations.
Fri, Jun 4, 5:06 PM · Restricted Project
rriddle added inline comments to D103669: Avoid assertion failure on printing scf.for in debug dump..
Fri, Jun 4, 4:45 PM · Restricted Project
rriddle added inline comments to D103632: [mlir][sparse] add option for 32-bit indices in scatter/gather.
Fri, Jun 4, 1:56 PM · Restricted Project

Thu, Jun 3

rriddle requested changes to D103669: Avoid assertion failure on printing scf.for in debug dump..
Thu, Jun 3, 11:57 PM · Restricted Project
rriddle added inline comments to D103669: Avoid assertion failure on printing scf.for in debug dump..
Thu, Jun 3, 11:57 PM · Restricted Project
rriddle added inline comments to D103669: Avoid assertion failure on printing scf.for in debug dump..
Thu, Jun 3, 11:36 PM · Restricted Project
rriddle accepted D103657: [NFC] Add ArrayRef includes to two files..
Thu, Jun 3, 4:22 PM · Restricted Project
rriddle committed rGd6af89beb26d: [mlir-lsp-server] Add support for tracking the use/def chains of symbols (authored by rriddle).
[mlir-lsp-server] Add support for tracking the use/def chains of symbols
Thu, Jun 3, 4:12 PM
rriddle closed D103585: [mlir-lsp-server] Add support for tracking the use/def chains of symbols.
Thu, Jun 3, 4:12 PM · Restricted Project
rriddle added inline comments to D103585: [mlir-lsp-server] Add support for tracking the use/def chains of symbols.
Thu, Jun 3, 4:08 PM · Restricted Project
rriddle updated the diff for D103585: [mlir-lsp-server] Add support for tracking the use/def chains of symbols.

Update

Thu, Jun 3, 4:04 PM · Restricted Project