Page MenuHomePhabricator

rriddle (River Riddle)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2016, 2:24 PM (308 w, 4 d)

Recent Activity

Yesterday

rriddle added inline comments to D124782: [mlir:PDLL] Add proper support for operation result type inference.
Wed, May 18, 2:20 AM · Restricted Project, Restricted Project
rriddle updated the diff for D125650: [mlir] Add documentation for PDLL LSP features and setup.
Wed, May 18, 2:19 AM · Restricted Project, Restricted Project
rriddle updated the diff for D124881: [mlir:PDLL] Add better support for providing Constraint/Pattern/Rewrite documentation.
Wed, May 18, 2:19 AM · Restricted Project, Restricted Project
rriddle updated the diff for D124817: [mlir:PDLL] Rework the C++ generation of native Constraint/Rewrite arguments and results.
Wed, May 18, 2:19 AM · Restricted Project, Restricted Project
rriddle updated the diff for D124784: [mlir:PDLL] Fix signature help for operation operands.
Wed, May 18, 2:19 AM · Restricted Project, Restricted Project
rriddle updated the diff for D124783: [mlir:PDLL-LSP] Add a custom LSP command for viewing the output of PDLL.
Wed, May 18, 2:19 AM · Restricted Project, Restricted Project
rriddle updated the diff for D124782: [mlir:PDLL] Add proper support for operation result type inference.
Wed, May 18, 2:19 AM · Restricted Project, Restricted Project
rriddle committed rGaa568e082b4c: [mlir:GreedyDriver] Return WalkResult::skip after deleting a known constant (authored by rriddle).
[mlir:GreedyDriver] Return WalkResult::skip after deleting a known constant
Wed, May 18, 2:18 AM · Restricted Project, Restricted Project
rriddle committed rG7814b559bd5e: [GreedyPatternRewriter] Avoid reversing constant order (authored by rkayaith).
[GreedyPatternRewriter] Avoid reversing constant order
Wed, May 18, 12:56 AM · Restricted Project, Restricted Project, Restricted Project
rriddle closed D125623: [GreedyPatternRewriter] Avoid reversing constant order.
Wed, May 18, 12:56 AM · Restricted Project, Restricted Project, Restricted Project
rriddle committed rGebad5fb30957: [mlir][Canonicalize] Fix command-line options (authored by rkayaith).
[mlir][Canonicalize] Fix command-line options
Wed, May 18, 12:38 AM · Restricted Project, Restricted Project
rriddle closed D125621: [mlir][Canonicalize] Fix command-line options.
Wed, May 18, 12:38 AM · Restricted Project, Restricted Project
rriddle committed rG17e2e7b7885c: [mlir:PDLL] Don't append / for directory code completion (authored by rriddle).
[mlir:PDLL] Don't append / for directory code completion
Wed, May 18, 12:24 AM · Restricted Project, Restricted Project
rriddle committed rG6d4471efb0b9: [mlir:PDLL] Improve the location ranges of several expressions during parsing (authored by rriddle).
[mlir:PDLL] Improve the location ranges of several expressions during parsing
Wed, May 18, 12:24 AM · Restricted Project, Restricted Project
rriddle committed rGe213e5a999db: [mlir:PDLL] Drop space as a completion commit character (authored by rriddle).
[mlir:PDLL] Drop space as a completion commit character
Wed, May 18, 12:24 AM · Restricted Project, Restricted Project

Tue, May 17

rriddle accepted D125809: [mlir][ods] Simplify useDefaultType/AttributePrinterParser.
Tue, May 17, 11:08 PM · Restricted Project, Restricted Project
rriddle added a comment to D125440: [mlir][Tablegen-LSP] Add support for a basic TableGen language server.
Tue, May 17, 10:31 AM · Restricted Project, Restricted Project
rriddle added inline comments to D125809: [mlir][ods] Simplify useDefaultType/AttributePrinterParser.
Tue, May 17, 10:23 AM · Restricted Project, Restricted Project
rriddle accepted D125797: [MLIR] Make `parseDimensionListRanked` configurable wrt parsing a trailing `x`.

Could you add a test somewhere?

Tue, May 17, 10:19 AM · Restricted Project, Restricted Project
rriddle added inline comments to D124023: [mlir][Arith] Add integer range inference analysis.
Tue, May 17, 2:10 AM · Restricted Project, Restricted Project
rriddle added a comment to D125440: [mlir][Tablegen-LSP] Add support for a basic TableGen language server.

Turns out we specifically don't include tablegen in the llvm shared library https://github.com/llvm/llvm-project/blob/main/llvm/tools/llvm-shlib/CMakeLists.txt#L20.

If I do it will link but you get:

FAILED: tools/clang/include/clang/Sema/AttrParsedAttrList.inc
<...>
: CommandLine Error: Option 'o' registered more than once!
LLVM ERROR: inconsistency in registered CommandLine options

Given that this is a language server would it make sense to disable building it if LLVM_LINK_LLVM_DYLIB is on?

Tue, May 17, 2:08 AM · Restricted Project, Restricted Project
rriddle added a reviewer for D125650: [mlir] Add documentation for PDLL LSP features and setup: jpienaar.
Tue, May 17, 1:48 AM · Restricted Project, Restricted Project

Mon, May 16

rriddle accepted D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.

I'm fine with landing this to unbreak things, but we really shouldn't need to define this IMO (the infra should automatically handle it).

Mon, May 16, 6:22 PM · Restricted Project, Restricted Project
rriddle added a reviewer for D125734: [mlir-vscode] Add support for highlighting pdll and tablegen markdown code blocks: jpienaar.
Mon, May 16, 4:55 PM · Restricted Project, Restricted Project
rriddle requested review of D125734: [mlir-vscode] Add support for highlighting pdll and tablegen markdown code blocks.
Mon, May 16, 4:53 PM · Restricted Project, Restricted Project
rriddle committed rG6593886a3502: [mlir][NFC] Fix the tags for various doc code blocks (authored by rriddle).
[mlir][NFC] Fix the tags for various doc code blocks
Mon, May 16, 4:47 PM · Restricted Project, Restricted Project
rriddle committed rG1febbd67aa9c: [mlir][PDLL] Tweak the grammar to highlight partial code better (authored by rriddle).
[mlir][PDLL] Tweak the grammar to highlight partial code better
Mon, May 16, 4:47 PM · Restricted Project, Restricted Project
rriddle committed rG9f39867b1032: [mlir][NFC] Fix a few langref typos (authored by rriddle).
[mlir][NFC] Fix a few langref typos
Mon, May 16, 4:23 PM · Restricted Project, Restricted Project
rriddle committed rG5de12bb703c5: [mlir][Tablegen-LSP] Add support for a basic TableGen language server (authored by rriddle).
[mlir][Tablegen-LSP] Add support for a basic TableGen language server
Mon, May 16, 4:04 PM · Restricted Project, Restricted Project
rriddle closed D125440: [mlir][Tablegen-LSP] Add support for a basic TableGen language server.
Mon, May 16, 4:04 PM · Restricted Project, Restricted Project
rriddle committed rGe0c3b94c8014: [mlir] Restrict dialect doc gen to a single dialect (authored by rriddle).
[mlir] Restrict dialect doc gen to a single dialect
Mon, May 16, 3:35 PM · Restricted Project, Restricted Project
rriddle closed D125651: [mlir] Restrict dialect doc gen to a single dialect.
Mon, May 16, 3:35 PM · Restricted Project, Restricted Project
rriddle added a comment to D125651: [mlir] Restrict dialect doc gen to a single dialect.

Did none of the cmake files need to change? If I'm reading this change correctly it just bails out if no dialect is specified, and so I'd expect some to fail (well except if the default cmake config already does set this flag)

Mon, May 16, 3:17 PM · Restricted Project, Restricted Project
rriddle updated the diff for D125651: [mlir] Restrict dialect doc gen to a single dialect.
Mon, May 16, 3:16 PM · Restricted Project, Restricted Project
rriddle added a comment to D125651: [mlir] Restrict dialect doc gen to a single dialect.

Thanks, and yes with Marius 's change for doc includes (couple months back :-)) there isn't really reason to have multiple be generated website side. Being explicit here is better.

Did none of the cmake files need to change? If I'm reading this change correctly it just bails out if no dialect is specified, and so I'd expect some to fail (well except if the default cmake config already does set this flag)

Mon, May 16, 2:46 PM · Restricted Project, Restricted Project
rriddle added a comment to D125051: [mlir] Tighten the verification of SameOperandsAndResultType.

they can get the same behavior by using the SameOperandsAndResultShape and SameOperandsAndResultElementType traits.

Should SameOperandsAndResultShape be renamed CompatibleOperandsAndResultShape?

Yeah, let me do that in a followup.

But the user really wants them to be the same dynamically. E.g., if you have ?x? and ?x?, the same shape is where the four unknowns are dynamically pairwise equal. Treating ?==? as true, isn't the goal as these could be different dynamically, but statically they aren't known. And restricting shape equality to static interpretation is more lax as it doesn't require dynamic equality but merely about static type. Yes verify wise equivalent'ish, but concept captured differs. Same here represents an equality constraint, statically we don't have sufficient information to reject so we have to be permissive. But it means where you have ?x? and 7x?, the first shape's unknown can be inferred to be 7 and propagated. That's not true for compatible.

Mon, May 16, 2:42 PM · Restricted Project, Restricted Project
rriddle committed rGa6cef03f66ca: [mlir] Remove the `type` keyword from type alias definitions (authored by rriddle).
[mlir] Remove the `type` keyword from type alias definitions
Mon, May 16, 1:57 PM · Restricted Project, Restricted Project, Restricted Project
rriddle closed D125501: [mlir] Remove the `type` keyword from type alias definitions.
Mon, May 16, 1:57 PM · Restricted Project, Restricted Project, Restricted Project
rriddle added inline comments to D125063: [mlir][transforms] Add a topological sort utility and pass.
Mon, May 16, 1:56 PM · Restricted Project, Restricted Project
rriddle accepted D125445: [mlir][ods] Fix verification of attribute + colon type ambiguity.

Looks good. I think we can do some more generalizations of the verification though (doesn't have to be in this commit). There are various other ambiguities that it'd be nice if they were simple to add the core checks for (e.g. attr-dict next to a region).

Mon, May 16, 1:43 PM · Restricted Project, Restricted Project
rriddle added a comment to D125724: [mlir][ods] Ignore AttributeSelfTypeParameter in assembly formats.

There's a further wrinkle here: attribute parsers embedded in operation assembly formats won't be able to have types.

def MyAttr : ... {
  let parameters = (ins "int":$a, AttributeSelfTypeParameter<"">:$type);
  let assemblyFormat = "$a";
}

def MyOp : ... {
  let arguments = (ins MyAttr:$a);
  let assemblyFormat = "$a attr-dict"
}

The pretty format won't be able to have a type because the parser directly invokes MyAttr::parse and won't be able to look ahead for the type.

Mon, May 16, 1:24 PM · Restricted Project, Restricted Project
rriddle accepted D125724: [mlir][ods] Ignore AttributeSelfTypeParameter in assembly formats.

Thanks!

Mon, May 16, 1:18 PM · Restricted Project, Restricted Project
rriddle accepted D125621: [mlir][Canonicalize] Fix command-line options.
Mon, May 16, 9:43 AM · Restricted Project, Restricted Project
rriddle accepted D125697: [mlir:toy][NFC] Remove unnecessary trailing return type.
Mon, May 16, 9:41 AM · Restricted Project, Restricted Project
rriddle updated the diff for D125443: [mlir][Tablegen-LSP] Add support for a tracking definitions and references.
Mon, May 16, 12:41 AM · Restricted Project, Restricted Project
rriddle updated the diff for D125442: [mlir][Tablegen-LSP] Add support for include file link and hover.
Mon, May 16, 12:40 AM · Restricted Project, Restricted Project
rriddle updated the diff for D125441: [mlir][Tablegen-LSP] Add support for a compilation database.
Mon, May 16, 12:40 AM · Restricted Project, Restricted Project
rriddle updated the diff for D125440: [mlir][Tablegen-LSP] Add support for a basic TableGen language server.
Mon, May 16, 12:40 AM · Restricted Project, Restricted Project

Sun, May 15

rriddle added inline comments to D125621: [mlir][Canonicalize] Fix command-line options.
Sun, May 15, 10:33 PM · Restricted Project, Restricted Project
rriddle accepted D125590: [LLVM][Casting.h] Add trivial self-cast.
Sun, May 15, 10:06 PM · Restricted Project, Restricted Project
rriddle added reviewers for D125651: [mlir] Restrict dialect doc gen to a single dialect: lattner, jpienaar.
Sun, May 15, 4:41 PM · Restricted Project, Restricted Project
rriddle requested review of D125651: [mlir] Restrict dialect doc gen to a single dialect.
Sun, May 15, 4:40 PM · Restricted Project, Restricted Project
rriddle updated the diff for D125650: [mlir] Add documentation for PDLL LSP features and setup.
Sun, May 15, 3:30 PM · Restricted Project, Restricted Project
rriddle requested review of D125650: [mlir] Add documentation for PDLL LSP features and setup.
Sun, May 15, 3:25 PM · Restricted Project, Restricted Project
rriddle updated the diff for D124881: [mlir:PDLL] Add better support for providing Constraint/Pattern/Rewrite documentation.
Sun, May 15, 3:25 PM · Restricted Project, Restricted Project
rriddle updated the diff for D124817: [mlir:PDLL] Rework the C++ generation of native Constraint/Rewrite arguments and results.
Sun, May 15, 3:25 PM · Restricted Project, Restricted Project
rriddle updated the diff for D124784: [mlir:PDLL] Fix signature help for operation operands.
Sun, May 15, 3:24 PM · Restricted Project, Restricted Project
rriddle updated the diff for D124783: [mlir:PDLL-LSP] Add a custom LSP command for viewing the output of PDLL.
Sun, May 15, 3:24 PM · Restricted Project, Restricted Project
rriddle updated the diff for D124782: [mlir:PDLL] Add proper support for operation result type inference.
Sun, May 15, 3:24 PM · Restricted Project, Restricted Project
rriddle accepted D125623: [GreedyPatternRewriter] Avoid reversing constant order.
Sun, May 15, 2:46 PM · Restricted Project, Restricted Project, Restricted Project
rriddle added a comment to D125623: [GreedyPatternRewriter] Avoid reversing constant order.

Nice! Can you look into the flang test failures?

Sun, May 15, 2:13 AM · Restricted Project, Restricted Project, Restricted Project

Fri, May 13

rriddle added a comment to D125590: [LLVM][Casting.h] Add trivial self-cast.

The test failures look real here, can you take a look? Looks like this doesn't properly handle the non-const case.

Fri, May 13, 4:36 PM · Restricted Project, Restricted Project
rriddle accepted D125576: [LLVM][Casting.h] Add ForwardToPointerCast trait.

Was there somewhere in MLIR that could take advantage of this? Trying to recall from another patch.

Fri, May 13, 3:36 PM · Restricted Project, Restricted Project
rriddle added a comment to D125587: [ParseResult] Fix warning in flang build, incorporate feedback from River..

Sweet, thanks!

Fri, May 13, 3:33 PM · Restricted Project, Restricted Project, Restricted Project
rriddle accepted D125578: [LLVM][Casting.h] Remove CastInfo pointer partial specialization..
Fri, May 13, 2:40 PM · Restricted Project, Restricted Project
rriddle added a comment to D125427: [TableGen] Add a new json textmate description for syntax highlighting.

Thanks all for the review!

Fri, May 13, 1:13 PM · Restricted Project, Restricted Project
rriddle committed rGf0792c715dc5: [TableGen] Add a new json textmate description for syntax highlighting (authored by rriddle).
[TableGen] Add a new json textmate description for syntax highlighting
Fri, May 13, 1:13 PM · Restricted Project, Restricted Project
rriddle closed D125427: [TableGen] Add a new json textmate description for syntax highlighting.
Fri, May 13, 1:13 PM · Restricted Project, Restricted Project
rriddle added inline comments to D125427: [TableGen] Add a new json textmate description for syntax highlighting.
Fri, May 13, 12:23 PM · Restricted Project, Restricted Project
rriddle updated the diff for D125427: [TableGen] Add a new json textmate description for syntax highlighting.
Fri, May 13, 12:22 PM · Restricted Project, Restricted Project
rriddle added a comment to D125549: [ParseResult] Mark this as LLVM_NODISCARD (like LogicalResult) and fix issues..

Nice!

Fri, May 13, 11:15 AM · Restricted Project, Restricted Project
rriddle added a comment to D125562: [mlir][AsmPrinter] WIP - Attempt to fix roundtripping issue on op names containing multiple '.' characters..

We should have some test dialect operations that use default dialect, should be easy to use a test dialect operation with multiple dots within the regions of one of those operations.

Fri, May 13, 10:21 AM · Restricted Project, Restricted Project
rriddle added a comment to D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again.

@bzcheeseman Can you advise if this is the easiest way to do a "self" cast?

Fri, May 13, 10:11 AM · Restricted Project, Restricted Project
rriddle added a reviewer for D125543: [mlir] support isa/cast/dyn_cast<Operation *>(operation) again: bzcheeseman.
Fri, May 13, 10:10 AM · Restricted Project, Restricted Project
rriddle added a reviewer for D125427: [TableGen] Add a new json textmate description for syntax highlighting: jpienaar.
Fri, May 13, 12:24 AM · Restricted Project, Restricted Project
rriddle added a comment to D125427: [TableGen] Add a new json textmate description for syntax highlighting.

Yeah, I'm not sure who would be good to review the actual json itself. Mostly just wondering if I should care about the existing xml package or not, happy to land this and not care about the other thing.

Fri, May 13, 12:21 AM · Restricted Project, Restricted Project

Thu, May 12

rriddle added a comment to D125201: [mlir] Add Dynamic Dialects.

Can you also add documentation on how to add/define a purely dynamic dialect?

Thu, May 12, 11:21 PM · Restricted Project, Restricted Project
rriddle added inline comments to D125201: [mlir] Add Dynamic Dialects.
Thu, May 12, 11:20 PM · Restricted Project, Restricted Project
rriddle requested changes to D124023: [mlir][Arith] Add integer range inference analysis.

( @rriddle To bring the signed/unsigned/ConstantRange discussion out of inline comments)

I've got a few reasons I'd say it's reasonable to track the signed and unsigned interpretations of values separately, in contrast with LLVM's approach.

  1. The LLVM approach appears to rely on having a bunch of flow-sensitive reasoning that generates things like nsw in order to make their analysis more precise. We don't have, and probably don't want to recreate, all that infrastructure, especially with how extensible MLIR is. So, we need another avenue to get analysis precision.
  2. Having signed/unsigned bounds like this makes it easier to reason about what the range inference implementations are doing, especially when dealing with mixtures of signed and unsigned ops (like divui or remsi). Trying to precisely get bounds out of mixed code like that is tricky.
  3. In most cases, we don't have double computation - the three ops that really have to do duplicate reasoning about the signed and unsigned result are addition, subtraction, and multiplication. Just about everything else can call fromSigned or fromUnsigned after computing one set of bounds to copy the bounds over if that's a valid thing to do.
  4. Initial attempts at a one-range system were a confusing mess and I'm not looking to fight through making sure that's implemented correctly.
Thu, May 12, 10:23 PM · Restricted Project, Restricted Project
rriddle committed rG80c28a400cfe: [mlir] Bump mlir-vscode to 0.0.7 (authored by rriddle).
[mlir] Bump mlir-vscode to 0.0.7
Thu, May 12, 3:53 PM · Restricted Project, Restricted Project
rriddle committed rG86f5caeee955: [mlir] Significantly overhaul the textmate grammar (authored by rriddle).
[mlir] Significantly overhaul the textmate grammar
Thu, May 12, 3:51 PM · Restricted Project, Restricted Project
rriddle closed D125458: [mlir] Significantly overhaul the textmate grammar.
Thu, May 12, 3:50 PM · Restricted Project, Restricted Project
rriddle added a comment to D125458: [mlir] Significantly overhaul the textmate grammar.

Here is a quick screencap of PDL before and after:

Thu, May 12, 3:25 PM · Restricted Project, Restricted Project
rriddle committed rG86e1c2f097ca: [mlir] Fix pipeline-parsing.mlir on windows (authored by rriddle).
[mlir] Fix pipeline-parsing.mlir on windows
Thu, May 12, 1:56 PM · Restricted Project, Restricted Project
rriddle added reviewers for D125501: [mlir] Remove the `type` keyword from type alias definitions: jpienaar, mehdi_amini.
Thu, May 12, 1:37 PM · Restricted Project, Restricted Project, Restricted Project
rriddle updated the diff for D125501: [mlir] Remove the `type` keyword from type alias definitions.
Thu, May 12, 1:36 PM · Restricted Project, Restricted Project, Restricted Project
rriddle added inline comments to D125501: [mlir] Remove the `type` keyword from type alias definitions.
Thu, May 12, 1:34 PM · Restricted Project, Restricted Project, Restricted Project
rriddle requested review of D125501: [mlir] Remove the `type` keyword from type alias definitions.
Thu, May 12, 1:33 PM · Restricted Project, Restricted Project, Restricted Project
rriddle committed rGc2fb9c29b407: [mlir:Pass] Add support for op-agnostic pass managers (authored by rriddle).
[mlir:Pass] Add support for op-agnostic pass managers
Thu, May 12, 1:13 PM · Restricted Project, Restricted Project
rriddle closed D123536: [mlir:Pass] Add support for op-agnostic pass managers.
Thu, May 12, 1:13 PM · Restricted Project, Restricted Project
rriddle updated the diff for D125458: [mlir] Significantly overhaul the textmate grammar.
Thu, May 12, 10:16 AM · Restricted Project, Restricted Project
rriddle added a comment to D125458: [mlir] Significantly overhaul the textmate grammar.

I validated the results using most of our upstream test cases. I may have missed some potential edge cases, but this is a much better iteration point that what we had before. There are a few places where we miscolor, but that is mostly because it's impossible in some cases to differentiate a region from an attribute dictionary.

Thu, May 12, 3:06 AM · Restricted Project, Restricted Project
rriddle added reviewers for D125458: [mlir] Significantly overhaul the textmate grammar: mehdi_amini, jpienaar.
Thu, May 12, 3:04 AM · Restricted Project, Restricted Project
rriddle requested review of D125458: [mlir] Significantly overhaul the textmate grammar.
Thu, May 12, 3:03 AM · Restricted Project, Restricted Project

Wed, May 11

rriddle committed rG1155c1fe6589: [mlir:Parser] Emit a better diagnostic when a custom operation is unknown (authored by rriddle).
[mlir:Parser] Emit a better diagnostic when a custom operation is unknown
Wed, May 11, 10:55 PM · Restricted Project, Restricted Project
rriddle closed D125351: [mlir:Parser] Emit a better diagnostic when a custom operation is unknown.
Wed, May 11, 10:55 PM · Restricted Project, Restricted Project
rriddle added inline comments to D124963: [MLIR][Operation] Simplify Operation casting, NFC.
Wed, May 11, 9:42 PM · Restricted Project, Restricted Project
rriddle accepted D125447: [DenseElementAttr] Simplify the public API for creating these..
Wed, May 11, 9:40 PM · Restricted Project, Restricted Project
rriddle added a comment to D124022: [mlir][Arith] Implement InferIntRangeInterface for arithmetic ops.

Yep. I'm waiting for the design to settle out on the lower layers before reviewing this one.

Wed, May 11, 9:07 PM · Restricted Project, Restricted Project
rriddle added inline comments to D124023: [mlir][Arith] Add integer range inference analysis.
Wed, May 11, 8:41 PM · Restricted Project, Restricted Project