Page MenuHomePhabricator

rriddle (River Riddle)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2016, 2:24 PM (314 w, 2 d)

Recent Activity

Yesterday

rriddle accepted D127537: [mlir] Prevent SubElementInterface from going into infinite recursion.

I would prefer if we could test this outside of the LLVM dialect if possible, given that it should just be a matter of using the Recursive type in the test dialect right?

Mon, Jun 27, 1:12 PM · Restricted Project, Restricted Project
rriddle accepted D128293: [mlir][ods] Add convertFromStorage field to parameters.

Can you add documentation for this field in the AttributesAndTypes.md doc?

Mon, Jun 27, 12:52 PM · Restricted Project, Restricted Project
rriddle added a comment to D128616: [mlir] Generalize Affine transforms to work on FunctionOpInterface..

Nothing sticks out to me here as wrong/broken, but given this is affine stuff I'll defer to @bondhugula for approval.

Mon, Jun 27, 12:50 PM · Restricted Project, Restricted Project, Restricted Project
rriddle accepted D123774: Introduce a new Dense Array attribute.

This looks like a good starting point to land and build on. (discussion on RFC seemed positive as well)

Mon, Jun 27, 12:42 PM · Restricted Project, Restricted Project
rriddle accepted D126428: [mlir][ods] Add codegen support for AttrOrTypeParameter verifiers.

Looks really great! Thanks for tackling this. (Sorry for the delay, coming back from two week OOO)

Mon, Jun 27, 12:17 PM · Restricted Project, Restricted Project
rriddle added a comment to D123774: Introduce a new Dense Array attribute.

Looking great!

Mon, Jun 27, 11:49 AM · Restricted Project, Restricted Project
rriddle added a comment to D127537: [mlir] Prevent SubElementInterface from going into infinite recursion.

Can we have a test that checks that we no longer go into infinite recursion? Otherwise, LG!

Mon, Jun 27, 11:31 AM · Restricted Project, Restricted Project
rriddle added a comment to D127072: [mlir][Inliner] Bug-Fix #53492. Inliner goes into infinite loop.

Thanks for updating! (Sorry, coming back from OOO)

Mon, Jun 27, 11:26 AM · Restricted Project, Restricted Project
rriddle added reviewers for D126446: [mlir] Allow for attaching external resources to .mlir files: stellaraccident, mehdi_amini.
Mon, Jun 27, 10:21 AM · Restricted Project, Restricted Project
rriddle accepted D127076: [MLIR][Parser] Fix AffineParser colliding bare identifiers with primitive types.

LG (I've been OOO for the past few weeks)

Mon, Jun 27, 9:28 AM · Restricted Project, Restricted Project
rriddle accepted D128537: [mlir][NFC] Use proper c++ namespaces in .td files.

Can you improve the commit title/description? Right now it isn't super clear, e.g. maybe just: [mlir][NFC] Use proper c++ namespaces in .td files?

Mon, Jun 27, 9:27 AM · Restricted Project, Restricted Project
rriddle accepted D128229: [vscode-mlir] add tablegen <> bracket colorization.
Mon, Jun 27, 9:19 AM · Restricted Project, Restricted Project
rriddle added a comment to D128353: [MLIR] Add LLVM_NODISCARD to MLIR builders for types and attributes..

We don't need to touch the declarations in the .h at all?

Mon, Jun 27, 8:45 AM · Restricted Project, Restricted Project

Thu, Jun 16

rriddle requested changes to D127537: [mlir] Prevent SubElementInterface from going into infinite recursion.
Thu, Jun 16, 6:59 PM · Restricted Project, Restricted Project

Wed, Jun 15

rriddle added inline comments to D127918: [mlir][LLVMIR] Memorize compatible LLVM types.
Wed, Jun 15, 9:11 PM · Restricted Project, Restricted Project
rriddle added a comment to D127455: [MLIR] Add `comdat` to globals when translating to LLVM IR on Windows.

Does the MLIR LLVM dialect not have comdats? That seems like a missing feature, a lack of fidelity that would prevent lossless conversion from LLVM IR to MLIR & back. Clang uses comdat groups for some esoteric features, the D5 destructor alias group, and MSVC RTTI.

I couldn't find a way to add comdats to MLIR (unless I missed something).

Wed, Jun 15, 9:10 PM · Restricted Project, Restricted Project, Restricted Project
rriddle added a comment to D127537: [mlir] Prevent SubElementInterface from going into infinite recursion.

I'm not sure I understand what you're getting at. Mutability is tied to the abstract type/attribute implementation. Instead of abstractType->isMutable(), could we not have abstractType->hasTrait<TypeTrait::Mutable>()?

I see, I thought you were referring to "trait" as a general C++ concept rather than MLIR's Trait.

IIRC trait needs to be manually annotated on a type or attribute, while my current approach detects mutability out of the box. The reason I chose the current way was because TypeStorage/AttributeStorage use the same way to see if a type/attribute can be mutated. And I'm a little worry that using trait might make such property out-of-sync with TypeStorage/AttributeStorage, if, let's say, a dialect forgets to annotate their mutable types or attributes with trait.

Wed, Jun 15, 9:04 PM · Restricted Project, Restricted Project

Mon, Jun 13

rriddle added a comment to D127688: [mlir][ods] Make Attr/Type def accessors match the dialect.

LG, but please do not land patches that are marked as "Requested Changes".

Mon, Jun 13, 10:14 PM · Restricted Project, Restricted Project
rriddle accepted D127700: [mlir] Fix inconsistency with SparseElementsAttr indices type.
Mon, Jun 13, 3:01 PM · Restricted Project, Restricted Project
rriddle added a comment to D127688: [mlir][ods] Make Attr/Type def accessors match the dialect.

I don't see a reason to regress from Attr/TypeDef using prefixed always, can we instead just fix the emission there to properly convert snake case?

Mon, Jun 13, 1:40 PM · Restricted Project, Restricted Project
rriddle requested changes to D127688: [mlir][ods] Make Attr/Type def accessors match the dialect.

This looks like a regression to me in many cases. We are trying to remove snake case, but this seems to be adding more uses of it.

Mon, Jun 13, 1:36 PM · Restricted Project, Restricted Project
rriddle added inline comments to D127521: [mlir][ods] Allow sharding of op definitions.
Mon, Jun 13, 12:09 AM · Restricted Project, Restricted Project

Sun, Jun 12

rriddle accepted D126751: [mlir] Add a generic data-flow analysis framework.

I think this is in a good enough state that we can land and iterate on in-tree.

Sun, Jun 12, 11:52 PM · Restricted Project, Restricted Project
rriddle accepted D127239: [mlir] Support getSuccessorInputs from parent op.
Sun, Jun 12, 11:45 PM · Restricted Project, Restricted Project

Sat, Jun 11

rriddle accepted D126044: [mlir][Arithmetic] Fold NegF in MulF and DivF..
Sat, Jun 11, 1:06 AM · Restricted Project, Restricted Project
rriddle accepted D127180: [mlir:MultiOpDriver] Add operands to worklist should be checked.
Sat, Jun 11, 1:01 AM · Restricted Project, Restricted Project
rriddle accepted D124022: [mlir][Arith] Implement InferIntRangeInterface for arithmetic ops.

LG, mostly stylistic comments.

Sat, Jun 11, 1:00 AM · Restricted Project, Restricted Project
rriddle accepted D125676: [mlir] Fix endian conversion of sub-byte types.
Sat, Jun 11, 12:49 AM · Restricted Project, Restricted Project
rriddle added a comment to D126352: [mlir][ods] Add base class for simple types.

Sorry didn't get notification of comments.

We should really be moving away from DialectType, can we move ShapeDialect types to ODS instead?

DialectType and DialectAttribute is only used for docgen at this point.

We could, I mostly just used these as an example of the other as was simple change. Would preference be leaving the shape dialect ones as is and just adding the helpers, or use the helpers an migrate them to ODS post? (It's not too many lines either way).

Sat, Jun 11, 12:47 AM · Restricted Project, Restricted Project
rriddle added a comment to D127537: [mlir] Prevent SubElementInterface from going into infinite recursion.

Yeah, the set should be unnecessary in 99% of cases. This is something that is only necessary for mutable attributes/types, given that those are the only ones that could be recursive. Conceptually we could detect mutability on registration, add a bit for that to the AbstractAttribute/Type classes, and check that here.

Sat, Jun 11, 12:42 AM · Restricted Project, Restricted Project

Fri, Jun 10

rriddle updated the diff for D126447: [mlir] Refactor pass crash reproducer generation to be an assembly resource.
Fri, Jun 10, 3:59 PM · Restricted Project, Restricted Project
rriddle updated the diff for D126446: [mlir] Allow for attaching external resources to .mlir files.
Fri, Jun 10, 3:59 PM · Restricted Project, Restricted Project
rriddle added a comment to D127522: [mlir][test] Shard and reorganize the test dialect.

I agree with the fact that the test dialect should be sharded based on features instead of being a monolithic definition!

That said we need the sharding for our internal out-of-tree dialects still so it is a useful addition independently :)
(and the test dialect is just used to test the sharding feature)

To come back to the patch: what I'd like is the ability to change the sharding count in the CMake file without touching any source code anywhere. I just talked to Jeff about this and I think he has a solution for this!

Fri, Jun 10, 1:47 PM · Restricted Project, Restricted Project
rriddle added a comment to D127522: [mlir][test] Shard and reorganize the test dialect.

You mean moving ops into different dialects?

I foresee sadness and pain

Fri, Jun 10, 1:43 PM · Restricted Project, Restricted Project
rriddle added a comment to D127522: [mlir][test] Shard and reorganize the test dialect.

The sharding here feels very arbitrary. Can we instead separate the operations based on what they are testing? That feels like a much better cleanup, and a better end state than sharding.

Fri, Jun 10, 12:17 PM · Restricted Project, Restricted Project
rriddle requested changes to D127522: [mlir][test] Shard and reorganize the test dialect.

The sharding here feels very arbitrary. Can we instead separate the operations based on what they are testing?

Fri, Jun 10, 12:00 PM · Restricted Project, Restricted Project

Thu, Jun 9

rriddle added inline comments to D123758: [MLIR][Presburger] introduce SlowMPInt, an auto-resizing APInt for fully correct signed integer computations.
Thu, Jun 9, 10:56 AM · Restricted Project, Restricted Project
rriddle added inline comments to D123758: [MLIR][Presburger] introduce SlowMPInt, an auto-resizing APInt for fully correct signed integer computations.
Thu, Jun 9, 8:44 AM · Restricted Project, Restricted Project

Wed, Jun 8

rriddle accepted D127370: [mlir][tosa] Replace StructAttrs with AttrDefs.
Wed, Jun 8, 8:10 PM · Restricted Project, Restricted Project
rriddle accepted D127375: [mlir][ods] Remove StructAttr.
Wed, Jun 8, 8:08 PM · Restricted Project, Restricted Project
rriddle accepted D127352: [mlir][gpu] Move GPU headers into IR/ and Transforms/.
Wed, Jun 8, 8:06 PM · Restricted Project, Restricted Project
rriddle accepted D127348: [mlir][nvvm] Change MMAShapeAttr to AttrDef.
Wed, Jun 8, 8:04 PM · Restricted Project, Restricted Project
rriddle accepted D127350: [mlir][gpu] Change ParalellLoopMappingAttr to AttrDef.
Wed, Jun 8, 8:02 PM · Restricted Project, Restricted Project

Tue, Jun 7

rriddle accepted D127231: Restore isa<Ty>(X) asserts inside cast<Ty>(X).

Really appreciate catching this and raising the discussion! (Approval for whenever you need/want to land)

Tue, Jun 7, 11:12 AM · Restricted Project, Restricted Project

Mon, Jun 6

rriddle added a comment to D127180: [mlir:MultiOpDriver] Add operands to worklist should be checked.

@rriddle
I'm not sure if we should do the check in AddToWorklist or just make it as this CL. Besides, I found this bug by the assertion we had before. Do you think we need a test (testing remove/replace/insert operations) or still have the assertion is enough?
What do you think?

Ahah, missed this comment before I sent the other one. What do you mean by if we should do the check in AddToWorklist? Also, I think it'd be nice to have a test for this if we can.

Sorry, didn't say that clearly. I mean things this like

virtual void AddToWorklist(...); // in GreedyPatternRewriteDriver
void AddToWorklist(...) override { // in MultiOpPatternRewriteDriver
  if (strictMode) ...
}

Then we may only need to override notifyOperationRemoved. Not sure which one is better in term of design.

Mon, Jun 6, 11:43 PM · Restricted Project, Restricted Project
rriddle added inline comments to D124022: [mlir][Arith] Implement InferIntRangeInterface for arithmetic ops.
Mon, Jun 6, 11:22 PM · Restricted Project, Restricted Project
rriddle added inline comments to D126751: [mlir] Add a generic data-flow analysis framework.
Mon, Jun 6, 11:15 PM · Restricted Project, Restricted Project
rriddle added inline comments to D126751: [mlir] Add a generic data-flow analysis framework.
Mon, Jun 6, 11:11 PM · Restricted Project, Restricted Project
rriddle added inline comments to D126751: [mlir] Add a generic data-flow analysis framework.
Mon, Jun 6, 11:10 PM · Restricted Project, Restricted Project
rriddle added a comment to D127180: [mlir:MultiOpDriver] Add operands to worklist should be checked.

@rriddle
I'm not sure if we should do the check in AddToWorklist or just make it as this CL. Besides, I found this bug by the assertion we had before. Do you think we need a test (testing remove/replace/insert operations) or still have the assertion is enough?
What do you think?

Mon, Jun 6, 11:06 PM · Restricted Project, Restricted Project
rriddle added a comment to D127180: [mlir:MultiOpDriver] Add operands to worklist should be checked.

Is there a test we can add here?

Mon, Jun 6, 11:04 PM · Restricted Project, Restricted Project
rriddle added inline comments to D126032: [mlir:LSP] Switch document sync mode to Incremental.
Mon, Jun 6, 8:21 PM · Restricted Project, Restricted Project
rriddle committed rG5919eab55c1d: [mlir:PDLL] Add support for inlay hints (authored by rriddle).
[mlir:PDLL] Add support for inlay hints
Mon, Jun 6, 8:21 PM · Restricted Project, Restricted Project
rriddle committed rGa3a4f0335fcc: [vscode-mlir] Bump to version 0.9 (authored by rriddle).
[vscode-mlir] Bump to version 0.9
Mon, Jun 6, 8:21 PM · Restricted Project, Restricted Project
rriddle committed rG6187178e832c: [mlir:LSP] Switch document sync mode to Incremental (authored by rriddle).
[mlir:LSP] Switch document sync mode to Incremental
Mon, Jun 6, 8:20 PM · Restricted Project, Restricted Project
rriddle closed D126033: [mlir:PDLL] Add support for inlay hints.
Mon, Jun 6, 8:20 PM · Restricted Project, Restricted Project
rriddle closed D126032: [mlir:LSP] Switch document sync mode to Incremental.
Mon, Jun 6, 8:20 PM · Restricted Project, Restricted Project
rriddle accepted D127085: [NFC] Use predecessors to replace make_range..
Mon, Jun 6, 6:44 PM · Restricted Project, Restricted Project
rriddle committed rG1b501cbcbb27: [mlir] Add documentation for TableGen LSP features and setup (authored by rriddle).
[mlir] Add documentation for TableGen LSP features and setup
Mon, Jun 6, 6:30 PM · Restricted Project, Restricted Project
rriddle accepted D127039: [mlir] Refactoring the tablegen Tensor types.
Mon, Jun 6, 6:03 PM · Restricted Project, Restricted Project
rriddle added a comment to D127085: [NFC] Use predecessors to replace make_range..

The mlir tag in the commit title looks off, this is a change in polly (which is based on LLVMIR)

Mon, Jun 6, 6:02 PM · Restricted Project, Restricted Project
rriddle committed rG731dfca8a018: [mlir] Add documentation for PDLL LSP features and setup (authored by rriddle).
[mlir] Add documentation for PDLL LSP features and setup
Mon, Jun 6, 1:16 PM · Restricted Project, Restricted Project
rriddle closed D125650: [mlir] Add documentation for PDLL LSP features and setup.
Mon, Jun 6, 1:15 PM · Restricted Project, Restricted Project

Sun, Jun 5

rriddle added inline comments to D127077: [mlir][NFC] Replace some llvm::find with llvm::is_contained..
Sun, Jun 5, 7:39 PM · Restricted Project, Restricted Project
rriddle accepted D127077: [mlir][NFC] Replace some llvm::find with llvm::is_contained..
Sun, Jun 5, 7:38 PM · Restricted Project, Restricted Project
rriddle added inline comments to D127076: [MLIR][Parser] Fix AffineParser colliding bare identifiers with primitive types.
Sun, Jun 5, 7:02 PM · Restricted Project, Restricted Project
rriddle added inline comments to D127076: [MLIR][Parser] Fix AffineParser colliding bare identifiers with primitive types.
Sun, Jun 5, 4:18 PM · Restricted Project, Restricted Project
rriddle requested changes to D127076: [MLIR][Parser] Fix AffineParser colliding bare identifiers with primitive types.
Sun, Jun 5, 4:14 PM · Restricted Project, Restricted Project
rriddle requested changes to D127072: [mlir][Inliner] Bug-Fix #53492. Inliner goes into infinite loop.

Thanks for looking into this! Have you considered/looked into using the same approach as LLVM? i.e. keeping an inline history to track what's already been inlined?

Sun, Jun 5, 11:35 AM · Restricted Project, Restricted Project

Sat, Jun 4

rriddle added inline comments to D127064: [mlir] Add Dead Code Analysis.
Sat, Jun 4, 8:42 PM · Restricted Project, Restricted Project
rriddle added a comment to D126751: [mlir] Add a generic data-flow analysis framework.

Took a quick scan, will look more in detail tomorrow. Really appreciate the detailed documentation.

Sat, Jun 4, 8:37 PM · Restricted Project, Restricted Project
rriddle added a comment to D126751: [mlir] Add a generic data-flow analysis framework.

I think River's up next :)

But sure!

Sat, Jun 4, 10:50 AM · Restricted Project, Restricted Project
rriddle requested changes to D126911: [mlir] Add integer range analysis to SCCP.

From a quick first pass we should really avoid building multiple analysis if we can. Each analysis is going to do full passes of the IR.

Sat, Jun 4, 10:37 AM · Restricted Project, Restricted Project
rriddle updated the diff for D126447: [mlir] Refactor pass crash reproducer generation to be an assembly resource.
Sat, Jun 4, 12:52 AM · Restricted Project, Restricted Project
rriddle updated the diff for D126446: [mlir] Allow for attaching external resources to .mlir files.
Sat, Jun 4, 12:52 AM · Restricted Project, Restricted Project

Thu, Jun 2

rriddle added a comment to D126446: [mlir] Allow for attaching external resources to .mlir files.

The current implementation uses hexadecimal, which requires 16 bits (2 bytes) to encode 8 bits of binary data. base64 would be an improvement over the current implementation that uses hexadecimal, requiring 8 bits to encode 6 bits of binary data. (The other constraint here is that encoding needs to be handled by the parser, which in the original example, means it can't have a quotation mark.) IMO, base64 is:

  • smaller than hex
  • somewhat ubiquitous
  • compatible with the existing parser (I think?)
  • a reasonable default for situations where the size overhead is an acceptable tradeoff for having the MLIR file be text-based and self-contained.

For text-based MLIR file situations where the size increase is an issue, I could imagine the config data containing a string with the name of an external file, and an application-defined way to resolve the full path. That could be out-of-tree and/or dialect specific.

Thu, Jun 2, 10:39 PM · Restricted Project, Restricted Project
rriddle committed rGee1cf1f64519: [mlir][NFC] Simplify the various `parseSourceFile<T>` overloads (authored by rriddle).
[mlir][NFC] Simplify the various `parseSourceFile<T>` overloads
Thu, Jun 2, 7:25 PM · Restricted Project, Restricted Project
rriddle updated the diff for D126033: [mlir:PDLL] Add support for inlay hints.
Thu, Jun 2, 5:41 PM · Restricted Project, Restricted Project
rriddle updated the diff for D126032: [mlir:LSP] Switch document sync mode to Incremental.
Thu, Jun 2, 5:41 PM · Restricted Project, Restricted Project
rriddle updated the diff for D125650: [mlir] Add documentation for PDLL LSP features and setup.
Thu, Jun 2, 5:41 PM · Restricted Project, Restricted Project
rriddle committed rGbb81b3b274d8: [vscode-mlir] Bump to version 0.8 (authored by rriddle).
[vscode-mlir] Bump to version 0.8
Thu, Jun 2, 4:35 PM · Restricted Project, Restricted Project
rriddle committed rGbf352e0b2ef9: [mlir:PDLL] Add better support for providing Constraint/Pattern/Rewrite… (authored by rriddle).
[mlir:PDLL] Add better support for providing Constraint/Pattern/Rewrite…
Thu, Jun 2, 4:31 PM · Restricted Project, Restricted Project
rriddle closed D124881: [mlir:PDLL] Add better support for providing Constraint/Pattern/Rewrite documentation.
Thu, Jun 2, 4:31 PM · Restricted Project, Restricted Project
rriddle added inline comments to D124881: [mlir:PDLL] Add better support for providing Constraint/Pattern/Rewrite documentation.
Thu, Jun 2, 2:38 PM · Restricted Project, Restricted Project
rriddle accepted D126920: [NFC] Fix -Wunused-result in test dialect.

Thanks!

Thu, Jun 2, 1:57 PM · Restricted Project, Restricted Project
rriddle accepted D124023: [mlir] Add integer range inference analysis.

Thanks! I really appreciate the patience during the review. This is really great work.

Thu, Jun 2, 12:05 PM · Restricted Project, Restricted Project
rriddle accepted D126899: [mlir:MultiOpDriver] Don't add ops which are not in the allowed list.
Thu, Jun 2, 11:18 AM · Restricted Project, Restricted Project
rriddle added a comment to D124023: [mlir] Add integer range inference analysis.

I do want this functionality downstream for non-test reasons, though.

If it makes more sense, I can make -fold-inferred-constants a test pass in
the MLIR codebase and then temporarily pull it out of test/ in our fork
when I'm backporting this patch series. Would that work?

Or, if you don't think the SCCP evolution will be too contentious, I can
just split that into it's own patch and add it to the series - another few
days to make sure we get this right aren't the end of the world.

Thu, Jun 2, 10:03 AM · Restricted Project, Restricted Project
rriddle added inline comments to D126428: [mlir][ods] Add codegen support for AttrOrTypeParameter verifiers.
Thu, Jun 2, 1:31 AM · Restricted Project, Restricted Project
rriddle added a comment to D124023: [mlir] Add integer range inference analysis.

I will admit I'm not entirely happy with the SCCP integration - if you see any ways I could tighten it up, please do let me know.

Thu, Jun 2, 1:20 AM · Restricted Project, Restricted Project
rriddle accepted D126594: [mlir][cf] Implement missing SwitchOp::build function.
Thu, Jun 2, 1:02 AM · Restricted Project, Restricted Project
rriddle abandoned D126445: [mlir] Add an AsmParserConfig class to start encapsulating parser options.
Thu, Jun 2, 12:58 AM · Restricted Project, Restricted Project

Wed, Jun 1

rriddle added a comment to D126444: [mlir]Implement SoftwareBF16 to handle the bf16 type.

A part of the motivation that is missing here (but was mentioned in the RFC) is why do this at this level than in LLVM? E.g., type conversions for backends not supporting specific types is already in LLVM with all kinds of helpers of how one can generally lower by combining overflow behavior of compare odd with add with carry op (as example). It feels like one would need to reimplement some of those expansions here if done at this level. Given it was mentioned, was this discussed and evaluated?

Wed, Jun 1, 2:54 PM · Restricted Project, Restricted Project

Tue, May 31

rriddle added inline comments to D126446: [mlir] Allow for attaching external resources to .mlir files.
Tue, May 31, 12:33 PM · Restricted Project, Restricted Project

Mon, May 30

rriddle requested review of D126447: [mlir] Refactor pass crash reproducer generation to be an assembly resource.
Mon, May 30, 10:49 PM · Restricted Project, Restricted Project
rriddle requested review of D126446: [mlir] Allow for attaching external resources to .mlir files.
Mon, May 30, 10:49 PM · Restricted Project, Restricted Project
rriddle requested review of D126445: [mlir] Add an AsmParserConfig class to start encapsulating parser options.
Mon, May 30, 10:49 PM · Restricted Project, Restricted Project
rriddle committed rG1c2edb026ed6: [mlir:PDLL] Rework the C++ generation of native Constraint/Rewrite arguments… (authored by rriddle).
[mlir:PDLL] Rework the C++ generation of native Constraint/Rewrite arguments…
Mon, May 30, 5:44 PM · Restricted Project, Restricted Project
rriddle committed rG0429472efe6a: [mlir:PDLL] Fix signature help for operation operands (authored by rriddle).
[mlir:PDLL] Fix signature help for operation operands
Mon, May 30, 5:44 PM · Restricted Project, Restricted Project
rriddle committed rG01652d889cf3: [mlir:PDLL-LSP] Add a custom LSP command for viewing the output of PDLL (authored by rriddle).
[mlir:PDLL-LSP] Add a custom LSP command for viewing the output of PDLL
Mon, May 30, 5:44 PM · Restricted Project, Restricted Project