Page MenuHomePhabricator

rriddle (River Riddle)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2016, 2:24 PM (354 w, 6 h)

Recent Activity

Thu, Mar 30

rriddle added a comment to D147262: [mlir][matchers] Add m_Op(StringRef) and m_Attr matchers.

Thanks @rriddle, done!
Am I correct in assuming that struct names remain in the same format (snake_case)?

Thu, Mar 30, 4:58 PM · Restricted Project, Restricted Project
rriddle accepted D147262: [mlir][matchers] Add m_Op(StringRef) and m_Attr matchers.

Looks good to me, nice!

Thu, Mar 30, 4:15 PM · Restricted Project, Restricted Project
rriddle committed rGa3252d1a2c56: [lldb][NFC] Move various constructor definitions from .h to .cpp (authored by rriddle).
[lldb][NFC] Move various constructor definitions from .h to .cpp
Thu, Mar 30, 1:27 PM · Restricted Project
rriddle closed D147252: [lldb][NFC] Move various constructor definitions from .h to .cpp.
Thu, Mar 30, 1:26 PM · Restricted Project, Restricted Project
rriddle added inline comments to D147262: [mlir][matchers] Add m_Op(StringRef) and m_Attr matchers.
Thu, Mar 30, 1:16 PM · Restricted Project, Restricted Project
rriddle added a reviewer for D147252: [lldb][NFC] Move various constructor definitions from .h to .cpp: wallace.
Thu, Mar 30, 11:44 AM · Restricted Project, Restricted Project
rriddle requested review of D147252: [lldb][NFC] Move various constructor definitions from .h to .cpp.
Thu, Mar 30, 11:44 AM · Restricted Project, Restricted Project

Tue, Mar 28

rriddle added a comment to D147053: Implement Pass and Dialect plugins for mlir-opt.

Can you please reupload the full diff? The newest diff just looks like formatting changes.

Tue, Mar 28, 11:34 AM · Restricted Project, Restricted Project

Mon, Mar 27

rriddle added inline comments to D146785: [mlir] Catch the case using ir print without disabling multithread.
Mon, Mar 27, 9:54 AM · Restricted Project, Restricted Project

Sat, Mar 25

rriddle accepted D146843: [mlir] Add missing cast functions to mlir namespace.
Sat, Mar 25, 11:05 AM · Restricted Project, Restricted Project

Tue, Mar 21

rriddle accepted D146607: [mlir] Fix typo for unknown operation.
Tue, Mar 21, 11:17 PM · Restricted Project, Restricted Project
rriddle added a comment to D145582: [mlir] Argument and result attribute handling during inlining..

Still, LGTM (feel free to land).

I was waiting due to the blocking review of @jpienaar. Is it ok to land nevertheless?

Tue, Mar 21, 12:08 PM · Restricted Project, Restricted Project
rriddle accepted D146125: [mlir][IR] Add ReverseDominanceIterator for IR walkers.
Tue, Mar 21, 12:05 PM · Restricted Project, Restricted Project
rriddle accepted D146134: [mlir][Transforms][NFC] Improve builder/listener API of OperationFolder.
Tue, Mar 21, 12:04 PM · Restricted Project, Restricted Project
rriddle added a comment to D145582: [mlir] Argument and result attribute handling during inlining..

Still, LGTM (feel free to land).

Tue, Mar 21, 12:02 PM · Restricted Project, Restricted Project
rriddle added inline comments to D144815: Add a breakpoint manager that matches based on File/Line/Col Locations.
Tue, Mar 21, 11:59 AM · Restricted Project, Restricted Project
rriddle added inline comments to D146456: [MLIR] Address post-commit comments on function deduplication.
Tue, Mar 21, 11:56 AM · Restricted Project, Restricted Project
rriddle added a comment to D146555: [mlir][bytecode] Allow client to specify an older version of the bytecode to emit.

If we can't guarantee it can be generated, I don't think this should be added.

Tue, Mar 21, 11:45 AM · Restricted Project, Restricted Project

Thu, Mar 16

rriddle committed rG9f991ed3e82d: [mlir][StorageUniquer] Use allocators per thread instead of per shard (authored by rriddle).
[mlir][StorageUniquer] Use allocators per thread instead of per shard
Thu, Mar 16, 2:56 PM · Restricted Project, Restricted Project
rriddle closed D145991: [mlir][StorageUniquer] Use allocators per thread instead of per shard.
Thu, Mar 16, 2:56 PM · Restricted Project, Restricted Project
rriddle accepted D146246: [InferTypeOpInterface.h] Remove extra '\' at the end of comment line.
Thu, Mar 16, 10:24 AM · Restricted Project, Restricted Project

Wed, Mar 15

rriddle accepted D145582: [mlir] Argument and result attribute handling during inlining..

Patch looks reasonable to me.

Wed, Mar 15, 12:20 AM · Restricted Project, Restricted Project
rriddle added a comment to D144817: Add a GDB/LLDB interface for interactive debugging of MLIR Actions.

I think for this revision we definitely need some high level usage docs

Wed, Mar 15, 12:10 AM · Restricted Project, Restricted Project
rriddle added inline comments to D144692: [mlir] Introduce IRDL dialect.
Wed, Mar 15, 12:02 AM · Restricted Project, Restricted Project

Mon, Mar 13

rriddle added inline comments to D145991: [mlir][StorageUniquer] Use allocators per thread instead of per shard.
Mon, Mar 13, 7:09 PM · Restricted Project, Restricted Project
rriddle updated the diff for D145991: [mlir][StorageUniquer] Use allocators per thread instead of per shard.
Mon, Mar 13, 7:08 PM · Restricted Project, Restricted Project
rriddle added a comment to D145991: [mlir][StorageUniquer] Use allocators per thread instead of per shard.

This assumes less threads than shards overall right?

Mon, Mar 13, 5:43 PM · Restricted Project, Restricted Project
rriddle added a reviewer for D145991: [mlir][StorageUniquer] Use allocators per thread instead of per shard: mehdi_amini.
Mon, Mar 13, 5:33 PM · Restricted Project, Restricted Project
rriddle updated the diff for D145991: [mlir][StorageUniquer] Use allocators per thread instead of per shard.
Mon, Mar 13, 5:32 PM · Restricted Project, Restricted Project
rriddle requested review of D145991: [mlir][StorageUniquer] Use allocators per thread instead of per shard.
Mon, Mar 13, 3:00 PM · Restricted Project, Restricted Project
rriddle added a comment to D144820: [mlir] Dialect type/attr bytecode read/write generator..

Took an initial scan, brain too fried to look at tablegen backend code but will take a look tomorrow.

Mon, Mar 13, 12:34 AM · Restricted Project, Restricted Project
rriddle added inline comments to D144818: Refactor the mlir-opt command line options related to debugging in a helper.
Mon, Mar 13, 12:20 AM · Restricted Project, Restricted Project
rriddle accepted D144816: Add tracing for pattern application in a ApplyPatternAction.
Mon, Mar 13, 12:15 AM · Restricted Project, Restricted Project
rriddle added inline comments to D144815: Add a breakpoint manager that matches based on File/Line/Col Locations.
Mon, Mar 13, 12:14 AM · Restricted Project, Restricted Project
rriddle accepted D144814: Add capture of "IRUnits" as context for an MLIR Action.
Mon, Mar 13, 12:02 AM · Restricted Project, Restricted Project

Sun, Mar 12

rriddle accepted D144813: Add an Observer for logging actions application to a stream.

LGTM with Jacques comments addressed

Sun, Mar 12, 11:59 PM · Restricted Project, Restricted Project
rriddle requested changes to D145699: [mlir][toy] Fix ConstantOp::parse in Ch2.
Sun, Mar 12, 11:53 PM · Restricted Project, Restricted Project
rriddle accepted D145469: Add a message to mlir-opt when reading from stdin to avoid being waiting for nothing.
Sun, Mar 12, 11:48 PM · Restricted Project, Restricted Project
rriddle accepted D144888: [mlir][IR] Add ForwardDominanceIterator for IR walkers.
Sun, Mar 12, 11:46 PM · Restricted Project, Restricted Project
rriddle accepted D145889: Add a `skipRegion()` feature to the OpPrintingFlags for MLIR ASM printer.
Sun, Mar 12, 11:39 PM · Restricted Project, Restricted Project

Fri, Mar 10

rriddle accepted D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".
Fri, Mar 10, 10:03 AM · Restricted Project, Restricted Project

Thu, Mar 9

rriddle accepted D145710: [ORC] Fix name shadowing issue, NFC..
Thu, Mar 9, 11:05 AM · Restricted Project, Restricted Project
rriddle added a comment to D145066: [mlir][core] Fix inline pass default pipeline dump.

I'd be fine landing this patch for now to fix the issue. The root of the inliner issues should be fixed when I rebase+land https://reviews.llvm.org/D134480

Will this be enough to solve the entire dump including the members of the InlinerPass class?

Thu, Mar 9, 10:14 AM · Restricted Project, Restricted Project

Wed, Mar 8

rriddle added inline comments to D144814: Add capture of "IRUnits" as context for an MLIR Action.
Wed, Mar 8, 10:17 PM · Restricted Project, Restricted Project
rriddle accepted D144812: Introduce mlir::tracing::ExecutionContext.
Wed, Mar 8, 10:11 PM · Restricted Project, Restricted Project

Tue, Mar 7

rriddle added inline comments to D144813: Add an Observer for logging actions application to a stream.
Tue, Mar 7, 12:16 AM · Restricted Project, Restricted Project
rriddle added a comment to D144812: Introduce mlir::tracing::ExecutionContext.

Is there a commit in this stack that handles updating/adding documentation?

Tue, Mar 7, 12:11 AM · Restricted Project, Restricted Project
rriddle added inline comments to D144812: Introduce mlir::tracing::ExecutionContext.
Tue, Mar 7, 12:10 AM · Restricted Project, Restricted Project

Mon, Mar 6

rriddle added a comment to D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".

Looking very close, thanks!

Mon, Mar 6, 11:59 PM · Restricted Project, Restricted Project
rriddle added inline comments to D144693: [mlir][irdl] Add IRDL registration.
Mon, Mar 6, 11:35 AM · Restricted Project, Restricted Project
rriddle requested changes to D144693: [mlir][irdl] Add IRDL registration.

This patch seems to be doing a lot of things at once. I would split out registration in mlir-opt from the various IRDL things being added, and make things a bit more incremental, given the IRDL constructs could be tested via a test-pass (for example).

Mon, Mar 6, 11:33 AM · Restricted Project, Restricted Project
rriddle accepted D144690: [mlir] Add setters for Dynamic[Type|Attr]Definition.
Mon, Mar 6, 11:25 AM · Restricted Project, Restricted Project

Fri, Mar 3

rriddle accepted D145182: [mlir][Parser] Make parse{Attribute,Type} null-terminate input.
Fri, Mar 3, 1:37 PM · Restricted Project, Restricted Project
rriddle added a comment to D144888: [mlir][IR] Add ForwardDominanceIterator for IR walkers.

Why can't we just use the ReversePostOrderTraversal infra in LLVM?

Fri, Mar 3, 10:07 AM · Restricted Project, Restricted Project
rriddle added a comment to D145152: [mlir][IR] Hash result types in OperationFingerPrint.

LGTM

Fri, Mar 3, 9:54 AM · Restricted Project, Restricted Project
rriddle added a comment to D144887: [mlir][IR][NFC] Move `walk` definitions to header file.

The failures look real, seems missing clang-format

Fri, Mar 3, 9:53 AM · Restricted Project, Restricted Project
rriddle accepted D144887: [mlir][IR][NFC] Move `walk` definitions to header file.
Fri, Mar 3, 9:53 AM · Restricted Project, Restricted Project
rriddle accepted D144549: [mlir][IR] Trigger notifyOperationModified for replacements.
Fri, Mar 3, 9:50 AM · Restricted Project, Restricted Project
rriddle accepted D144969: [mlir][IR] Clean up mergeBlockBefore and mergeBlocks.

Feel free to rename the API, I don't think the API churn in this case would be that bad.

Fri, Mar 3, 9:48 AM · Restricted Project, Restricted Project
rriddle accepted D145066: [mlir][core] Fix inline pass default pipeline dump.

I'd be fine landing this patch for now to fix the issue. The root of the inliner issues should be fixed when I rebase+land https://reviews.llvm.org/D134480

Fri, Mar 3, 9:44 AM · Restricted Project, Restricted Project

Thu, Mar 2

rriddle accepted D145213: [mlir] Update signal failure error message.
Thu, Mar 2, 8:27 PM · Restricted Project, Restricted Project

Feb 27 2023

rriddle committed rG964997a143cf: [mlir][core] Fix ValueRange printing in AsmPrinter (authored by wpmed92).
[mlir][core] Fix ValueRange printing in AsmPrinter
Feb 27 2023, 2:54 PM · Restricted Project, Restricted Project
rriddle added a comment to D144833: [mlir][core] Fix ValueRange printing in AsmPrinter.

Sure, can you provide an author name and email to attach to the commit? (arc doesn't want to patch this commit automatically for me).

Feb 27 2023, 12:46 PM · Restricted Project, Restricted Project
rriddle added inline comments to D144804: [mlir][AsmParser] Improve parse{Attribute,Type} error handling.
Feb 27 2023, 12:41 PM · Restricted Project, Restricted Project
rriddle accepted D144782: Expose a convenient registerCLOptions() for MlirOptMainConfig.
Feb 27 2023, 12:24 PM · Restricted Project, Restricted Project
rriddle accepted D144804: [mlir][AsmParser] Improve parse{Attribute,Type} error handling.
Feb 27 2023, 12:24 PM · Restricted Project, Restricted Project
rriddle accepted D144833: [mlir][core] Fix ValueRange printing in AsmPrinter.
Feb 27 2023, 12:21 PM · Restricted Project, Restricted Project
rriddle added inline comments to D143352: [mlir][python] Add generic operation parse APIs.
Feb 27 2023, 12:09 PM · Restricted Project, Restricted Project
rriddle added inline comments to D144811: Delete ActionManager and replace it with a simple callback on the Context.
Feb 27 2023, 11:04 AM · Restricted Project, Restricted Project
rriddle added a comment to D144887: [mlir][IR][NFC] Move `walk` definitions to header file.

Any idea of how this will affect build times? This code is now going to get instantiated a lot.

Feb 27 2023, 10:57 AM · Restricted Project, Restricted Project
rriddle added inline comments to D144811: Delete ActionManager and replace it with a simple callback on the Context.
Feb 27 2023, 10:55 AM · Restricted Project, Restricted Project
rriddle added inline comments to D144738: [MLIR] Add pass to deduplicate functions.
Feb 27 2023, 10:22 AM · Restricted Project, Restricted Project
rriddle added inline comments to D144735: [MLIR] Expose region equivalence check through OperationEquivalence.
Feb 27 2023, 10:15 AM · Restricted Project, Restricted Project
rriddle added a comment to D144810: Add a virtual method on Action to indicate if they can be skipped safely.

After looking at the followup, I'd honestly just fold this into the followup.

Feb 27 2023, 9:43 AM · Restricted Project, Restricted Project
rriddle accepted D144811: Delete ActionManager and replace it with a simple callback on the Context.
Feb 27 2023, 9:42 AM · Restricted Project, Restricted Project
rriddle added a comment to D144810: Add a virtual method on Action to indicate if they can be skipped safely.

This patch feels kind of weird here, why not delay this until when it can actually be used?

Feb 27 2023, 9:37 AM · Restricted Project, Restricted Project
rriddle accepted D144809: Rename DebugAction to tracing::Action and move related code from lib/Support to lib/IR and lib/Debug.
Feb 27 2023, 9:36 AM · Restricted Project, Restricted Project
rriddle accepted D144808: Change the DebugAction paradigm to delegate the control to the handler.
Feb 27 2023, 9:32 AM · Restricted Project, Restricted Project

Feb 25 2023

rriddle accepted D144796: [DebugInfo] Remove `dbg.addr` from MLIR.
Feb 25 2023, 4:20 PM · debug-info, Restricted Project, Restricted Project

Feb 22 2023

rriddle added inline comments to D144391: [mlir] Complety remove old `fold` API.
Feb 22 2023, 1:29 PM · Restricted Project, Restricted Project
rriddle accepted D142406: [mlir:PDL] Set debug name for PDL match result patterns.
Feb 22 2023, 9:38 AM · Restricted Project, Restricted Project
rriddle accepted D142868: [mlir][NFC] Cleanup Passes documentation.
Feb 22 2023, 9:33 AM · Restricted Project, Restricted Project
rriddle accepted D144266: [mlir][IR] Trigger notifyBlockCreated when cloning ops.
Feb 22 2023, 9:31 AM · Restricted Project, Restricted Project
rriddle added inline comments to D144257: [mlir][IR] Add Iterator template option to IR walkers.
Feb 22 2023, 9:29 AM · Restricted Project, Restricted Project
rriddle added a comment to D144408: tree-sitter-mlir: contribute a more complete grammar.js.

Something that doesn't seem great about this approach is the need for every operation of every dialect to have an explicit entry. For MLIR that severely limits the situations that the grammar can be useful (effectively no downstream user can benefit), and is also hard to maintain, is there not a more generic fuzzy approach that gets us the correct highlighting most of the time (similarly to the textmate grammar)? @jpienaar

Feb 22 2023, 9:27 AM · Restricted Project, Restricted Project
rriddle added a comment to D143339: [mlir][IR] RewriterBase: Use composition instead of inheritance for Listener.

I am out, but this seems alright to me.

Feb 22 2023, 9:23 AM · Restricted Project, Restricted Project
rriddle accepted D144463: [mlir][IR] Use Listener for IR callbacks in OperationFolder.
Feb 22 2023, 9:21 AM · Restricted Project, Restricted Project
rriddle added inline comments to D144507: [mlir] Add a SharedSymbolTableCollection class.
Feb 22 2023, 9:15 AM · Restricted Project, Restricted Project
rriddle accepted D144507: [mlir] Add a SharedSymbolTableCollection class.

This seems like a fine start. It'd be nice if the name was a bit closer to "ThreadSafe" aspect, like "LockedSymbolTableCollection"(or something), to make it more apparent what the purpose is on first glance.

Feb 22 2023, 9:14 AM · Restricted Project, Restricted Project
rriddle added a comment to D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".

In addition to the stuff mentioned, I'd also love to see top-level docs detailing versioning, how it's structured, and how to hook in.

Feb 22 2023, 9:12 AM · Restricted Project, Restricted Project
rriddle added a comment to D143829: Refactor a MlirOptMainConfig class to hold the configuration of MlirOptMain (NFC).

The windows build failures look real

Feb 22 2023, 9:09 AM · Restricted Project, Restricted Project
rriddle accepted D143829: Refactor a MlirOptMainConfig class to hold the configuration of MlirOptMain (NFC).
Feb 22 2023, 9:09 AM · Restricted Project, Restricted Project

Feb 17 2023

rriddle requested changes to D143647: Extension of "Implement IR versioning through post-parsing upgrade through OpAsmDialectInterface".

Haven't had time to dig in here, but adding an attribute doesn't feel right for version. Why is this necessary? As opposed to being something specific to the assembly format?

Feb 17 2023, 11:04 AM · Restricted Project, Restricted Project

Feb 16 2023

rriddle accepted D144193: [mlir][IR] Trigger notifyOperationRemoved callback for nested ops.

How does the interact with dialect conversion?

Feb 16 2023, 11:53 PM · Restricted Project, Restricted Project
rriddle accepted D144204: [mlir] Reintroduce API for creating operations with a DictionaryAttr.
Feb 16 2023, 3:06 PM · Restricted Project, Restricted Project

Feb 14 2023

rriddle accepted D144069: Add a pass that builds a debug info scope for LLVMFuncOp (adding a DISubprogramAttr).

Nice

Feb 14 2023, 10:15 PM · Restricted Project, Restricted Project

Feb 10 2023

rriddle added a reviewer for D143808: [mlir][Pass] Add a timing scope for the verifier runs: mehdi_amini.
Feb 10 2023, 10:48 PM · Restricted Project, Restricted Project
rriddle added a reviewer for D143807: [mlir][Pass] Integrate pass timing hooks into Pass: mehdi_amini.
Feb 10 2023, 10:48 PM · Restricted Project, Restricted Project
rriddle requested review of D143808: [mlir][Pass] Add a timing scope for the verifier runs.
Feb 10 2023, 10:48 PM · Restricted Project, Restricted Project
rriddle requested review of D143807: [mlir][Pass] Integrate pass timing hooks into Pass.
Feb 10 2023, 10:48 PM · Restricted Project, Restricted Project