- User Since
- Jun 18 2016, 2:24 PM (308 w, 4 d)
Tue, May 17
Could you add a test somewhere?
Mon, May 16
I'm fine with landing this to unbreak things, but we really shouldn't need to define this IMO (the infra should automatically handle it).
Looks good. I think we can do some more generalizations of the verification though (doesn't have to be in this commit). There are various other ambiguities that it'd be nice if they were simple to add the core checks for (e.g. attr-dict next to a region).
Sun, May 15
Nice! Can you look into the flang test failures?
Fri, May 13
The test failures look real here, can you take a look? Looks like this doesn't properly handle the non-const case.
Was there somewhere in MLIR that could take advantage of this? Trying to recall from another patch.
Thanks all for the review!
We should have some test dialect operations that use default dialect, should be easy to use a test dialect operation with multiple dots within the regions of one of those operations.
@bzcheeseman Can you advise if this is the easiest way to do a "self" cast?
Yeah, I'm not sure who would be good to review the actual json itself. Mostly just wondering if I should care about the existing xml package or not, happy to land this and not care about the other thing.
Thu, May 12
Can you also add documentation on how to add/define a purely dynamic dialect?
Here is a quick screencap of PDL before and after:
I validated the results using most of our upstream test cases. I may have missed some potential edge cases, but this is a much better iteration point that what we had before. There are a few places where we miscolor, but that is mostly because it's impossible in some cases to differentiate a region from an attribute dictionary.
Wed, May 11
Yep. I'm waiting for the design to settle out on the lower layers before reviewing this one.