User Details
User Details
- User Since
- Jun 18 2016, 2:24 PM (239 w, 10 h)
Yesterday
Yesterday
rriddle added inline comments to D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.
Fri, Jan 15, 10:32 PM · Restricted Project
rriddle added a comment to D94638: [mlir][Pattern] Create a new IRRewriter class to enable sharing code with pattern rewrites.
Fri, Jan 15, 8:25 PM · Restricted Project
rriddle updated the summary of D94831: [mlir] Add an interface for Cast-Like operations.
Fri, Jan 15, 6:44 PM · Restricted Project
rriddle added inline comments to D94831: [mlir] Add an interface for Cast-Like operations.
Fri, Jan 15, 6:44 PM · Restricted Project
rriddle added inline comments to D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.
Fri, Jan 15, 6:44 PM · Restricted Project
rriddle updated the diff for D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.
Address most comments
Fri, Jan 15, 6:43 PM · Restricted Project
rriddle updated the diff for D94831: [mlir] Add an interface for Cast-Like operations.
Address comments
Fri, Jan 15, 6:43 PM · Restricted Project
rriddle retitled D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation from [mlir] Add a new builtin `partial_conversion_cast` operation to [mlir] Add a new builtin `unrealized_conversion_cast` operation.
Fri, Jan 15, 6:43 PM · Restricted Project
rriddle committed rG2a27a9819a1e: [mlir][AsmPrinter] Properly escape strings when printing locations (authored by rriddle).
[mlir][AsmPrinter] Properly escape strings when printing locations
Fri, Jan 15, 5:15 PM · Restricted Project
rriddle requested review of D94847: [mlir][AsmPrinter] Properly escape strings when printing locations.
Fri, Jan 15, 4:55 PM · Restricted Project
rriddle updated the diff for D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.
Rebase
Fri, Jan 15, 3:36 PM · Restricted Project
rriddle updated the diff for D94831: [mlir] Add an interface for Cast-Like operations.
Fix accidental incorrect behavior for casts
Fri, Jan 15, 3:36 PM · Restricted Project
rriddle updated the summary of D94831: [mlir] Add an interface for Cast-Like operations.
Fri, Jan 15, 3:36 PM · Restricted Project
rriddle added inline comments to D94831: [mlir] Add an interface for Cast-Like operations.
Fri, Jan 15, 3:02 PM · Restricted Project
rriddle added inline comments to D94831: [mlir] Add an interface for Cast-Like operations.
Fri, Jan 15, 2:55 PM · Restricted Project
rriddle requested review of D94832: [mlir] Add a new builtin `unrealized_conversion_cast` operation.
Fri, Jan 15, 2:48 PM · Restricted Project
rriddle requested review of D94831: [mlir] Add an interface for Cast-Like operations.
Fri, Jan 15, 2:48 PM · Restricted Project
Thu, Jan 14
Thu, Jan 14
rriddle added inline comments to D94737: [mlir] Add better support for f80 and f128.
Thu, Jan 14, 6:46 PM · Restricted Project
Did a pass through, and looks good to me.
Thu, Jan 14, 6:18 PM · Restricted Project
rriddle added a comment to D94662: [mlir] Remove over specified memory effects.
Thu, Jan 14, 2:29 PM · Restricted Project
Thanks!
Thu, Jan 14, 12:29 PM · Restricted Project
Thu, Jan 14, 12:07 PM · Restricted Project
rriddle committed rGc8fb6ee34151: [mlir][PatternRewriter] Add a new hook to selectively replace uses of an… (authored by rriddle).
[mlir][PatternRewriter] Add a new hook to selectively replace uses of an…
rriddle closed D94632: [mlir][PatternRewriter] Add a new hook to selectively replace uses of an operation.
Thu, Jan 14, 12:05 PM · Restricted Project
rriddle committed rG93592b726c75: [mlir][OpFormatGen] Format enum attribute cases as keywords when possible (authored by rriddle).
[mlir][OpFormatGen] Format enum attribute cases as keywords when possible
rriddle committed rG00a61b327dd8: [mlir][ODS] Add new RangedTypesMatchWith operation predicate (authored by rriddle).
[mlir][ODS] Add new RangedTypesMatchWith operation predicate
Thu, Jan 14, 11:43 AM · Restricted Project
Thu, Jan 14, 11:43 AM · Restricted Project
Awesome!
Thu, Jan 14, 11:16 AM · Restricted Project
Wed, Jan 13
Wed, Jan 13
Wed, Jan 13, 10:03 PM · Restricted Project
rriddle added a comment to D94638: [mlir][Pattern] Create a new IRRewriter class to enable sharing code with pattern rewrites.
I went with IRRewriterImpl as this seems close to a SmallVectorImpl situation, but happy to rename to something else if there are suggestions.
Wed, Jan 13, 2:53 PM · Restricted Project
rriddle requested review of D94638: [mlir][Pattern] Create a new IRRewriter class to enable sharing code with pattern rewrites.
Wed, Jan 13, 2:52 PM · Restricted Project
rriddle requested review of D94632: [mlir][PatternRewriter] Add a new hook to selectively replace uses of an operation.
Wed, Jan 13, 1:30 PM · Restricted Project
Wed, Jan 13, 11:28 AM · Restricted Project
Tue, Jan 12
Tue, Jan 12
rriddle requested review of D94575: [mlir][OpFormatGen] Format enum attribute cases as keywords when possible.
Tue, Jan 12, 6:30 PM · Restricted Project
rriddle requested review of D94574: [mlir][ODS] Add new RangedTypesMatchWith operation predicate.
Tue, Jan 12, 6:29 PM · Restricted Project
Mon, Jan 11
Mon, Jan 11
rriddle added inline comments to D94451: Proposal for allowing unsupported build system configuration in-tree.
rriddle added inline comments to D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.
Mon, Jan 11, 5:32 PM · Restricted Project
rriddle committed rGd79642b3db1d: [mlir][IR][NFC] Move the definitions of Complex/Function/Integer/Opaque/TupleTy… (authored by rriddle).
[mlir][IR][NFC] Move the definitions of Complex/Function/Integer/Opaque/TupleTy…
rriddle committed rG948be58258dd: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef (authored by rriddle).
[mlir][TypeDefGen] Add support for adding builders when generating a TypeDef
rriddle committed rG207417730134: [mlir][ODS] Add a C++ abstraction for OpBuilders (authored by rriddle).
[mlir][ODS] Add a C++ abstraction for OpBuilders
rriddle closed D94275: [mlir][IR][NFC] Move the definitions of Complex/Function/Integer/Opaque/TupleType to ODS.
Mon, Jan 11, 12:08 PM · Restricted Project
rriddle closed D94274: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef.
Mon, Jan 11, 12:08 PM · Restricted Project
Mon, Jan 11, 12:08 PM · Restricted Project
rriddle added inline comments to D94434: [mlir][vector] Add side-effect information to different load/store ops.
Mon, Jan 11, 12:00 PM · Restricted Project
Sun, Jan 10
Sun, Jan 10
Sun, Jan 10, 7:07 PM · Restricted Project
Fri, Jan 8
Fri, Jan 8
rriddle added inline comments to D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper.
Fri, Jan 8, 4:55 PM · Restricted Project
rriddle committed rG77501bd1754f: [mlir][PassManager] Properly set the initialization generation when cloning a… (authored by rriddle).
[mlir][PassManager] Properly set the initialization generation when cloning a…
rriddle added inline comments to D94340: [MLIR][Linalg] Refactor transforms to use linalg::getDynOperands helper.
Fri, Jan 8, 2:05 PM · Restricted Project
rriddle committed rG1ba5ea67a301: [mlir] Add a hook for initializing passes before execution and use it in the… (authored by rriddle).
[mlir] Add a hook for initializing passes before execution and use it in the…
rriddle closed D93147: [mlir] Add a hook for initializing passes before execution and use it in the Canonicalizer.
Fri, Jan 8, 1:38 PM · Restricted Project
rriddle added inline comments to D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.
Fri, Jan 8, 1:35 PM · Restricted Project
rriddle requested changes to D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg.
Fri, Jan 8, 1:29 PM · Restricted Project
rriddle updated the diff for D93147: [mlir] Add a hook for initializing passes before execution and use it in the Canonicalizer.
Resolve comments and rebase
Fri, Jan 8, 1:24 PM · Restricted Project
[mlir][PDL] Use ODS for defining PDL types
Fri, Jan 8, 12:45 PM · Restricted Project
Fri, Jan 8, 12:31 PM · Restricted Project
rriddle added a comment to D94274: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef.
+Chris as I think you also ran into a need for this.
Fri, Jan 8, 12:23 PM · Restricted Project
rriddle added a reviewer for D94274: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef: lattner.
Fri, Jan 8, 12:23 PM · Restricted Project
Thu, Jan 7
Thu, Jan 7
Thu, Jan 7, 6:46 PM · Restricted Project
rriddle requested review of D94275: [mlir][IR][NFC] Move the definitions of Complex/Function/Integer/Opaque/TupleType to ODS.
Thu, Jan 7, 4:32 PM · Restricted Project
rriddle requested review of D94274: [mlir][TypeDefGen] Add support for adding builders when generating a TypeDef.
Thu, Jan 7, 4:31 PM · Restricted Project
rriddle requested review of D94273: [mlir][ODS] Add a C++ abstraction for OpBuilders.
Thu, Jan 7, 4:31 PM · Restricted Project
LGTM from me, but can you send a post to llvm-dev to make sure there is general consensus?
Thu, Jan 7, 1:08 AM · Restricted Project
rriddle accepted D94218: Fix two pessimizing moves..
Wed, Jan 6
Wed, Jan 6
rriddle added a comment to D94191: [mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as deprecated..
Wed, Jan 6, 10:59 PM · Restricted Project
rriddle committed rG238dbeb1e7ba: [mlir][ODS] Fix missed rename of TypeParameter 'description' to 'summary' (authored by rriddle).
[mlir][ODS] Fix missed rename of TypeParameter 'description' to 'summary'
Nice!
Wed, Jan 6, 5:39 PM · Restricted Project
rriddle accepted D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
LGTM after adding error messages. Thanks!
Wed, Jan 6, 3:56 PM · Restricted Project
rriddle added inline comments to D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Wed, Jan 6, 3:50 PM · Restricted Project
rriddle added inline comments to D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Wed, Jan 6, 3:49 PM · Restricted Project
rriddle added a comment to D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Wed, Jan 6, 3:32 PM · Restricted Project
rriddle added a comment to D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Wed, Jan 6, 3:22 PM · Restricted Project
rriddle requested changes to D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Wed, Jan 6, 3:19 PM · Restricted Project
rriddle committed rG41d919aa2946: [mlir][TypeDefGen] Remove the need to define parser/printer for singleton types (authored by rriddle).
[mlir][TypeDefGen] Remove the need to define parser/printer for singleton types
rriddle closed D94194: [mlir][TypeDefGen] Remove the need to define parser/printer for singleton types.
Wed, Jan 6, 3:00 PM · Restricted Project
rriddle committed rGc42cee0c64fe: [mlir][ODS] Fix the use of cppClassName in Type constraints for TypeDefs (authored by rriddle).
[mlir][ODS] Fix the use of cppClassName in Type constraints for TypeDefs
rriddle committed rGe0a93e4b65b6: [mlir][ODS] Rename several uses of 'description' to 'summary' (authored by rriddle).
[mlir][ODS] Rename several uses of 'description' to 'summary'
Wed, Jan 6, 2:22 PM · Restricted Project
Wed, Jan 6, 2:22 PM · Restricted Project
rriddle updated the diff for D94135: [mlir][PDL] Use ODS for defining PDL types.
Rebase
Wed, Jan 6, 1:50 PM · Restricted Project
rriddle requested review of D94194: [mlir][TypeDefGen] Remove the need to define parser/printer for singleton types.
Wed, Jan 6, 1:49 PM · Restricted Project
rriddle updated the diff for D94135: [mlir][PDL] Use ODS for defining PDL types.
Rebase
Wed, Jan 6, 1:36 PM · Restricted Project
rriddle updated the diff for D94135: [mlir][PDL] Use ODS for defining PDL types.
Rebase
Wed, Jan 6, 1:22 PM · Restricted Project
rriddle requested review of D94192: [mlir][ODS] Fix the use of cppClassName in Type constraints for TypeDefs.
Wed, Jan 6, 1:22 PM · Restricted Project
rriddle updated the diff for D94133: [mlir][ODS] Rename several uses of 'description' to 'summary'.
Rebase
Wed, Jan 6, 1:21 PM · Restricted Project
rriddle added a comment to D94191: [mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as deprecated..
Nice!
Wed, Jan 6, 1:04 PM · Restricted Project
rriddle accepted D94191: [mlir] Mark methods from mlir::OpState that just forward to mlir::Operation as deprecated..
Wed, Jan 6, 1:04 PM · Restricted Project
Tue, Jan 5
Tue, Jan 5
rriddle requested review of D94135: [mlir][PDL] Use ODS for defining PDL types.
Tue, Jan 5, 3:53 PM · Restricted Project
rriddle requested review of D94133: [mlir][ODS] Rename several uses of 'description' to 'summary'.
Tue, Jan 5, 3:51 PM · Restricted Project
rriddle added a comment to D93908: [AsmPrinter] Make OpAsmPrinter::printFunctionalType be resilient to null values..
Thanks!
Tue, Jan 5, 2:41 PM · Restricted Project
rriddle accepted D93908: [AsmPrinter] Make OpAsmPrinter::printFunctionalType be resilient to null values..
Tue, Jan 5, 2:41 PM · Restricted Project
rriddle added inline comments to D94116: Update the maximum integer bitwidth in MLIR. .
Tue, Jan 5, 1:17 PM · Restricted Project
rriddle added a comment to D93147: [mlir] Add a hook for initializing passes before execution and use it in the Canonicalizer.
Tue, Jan 5, 11:40 AM · Restricted Project
rriddle updated the diff for D93147: [mlir] Add a hook for initializing passes before execution and use it in the Canonicalizer.
Change to using "Generations" for initialization, and add docs
Tue, Jan 5, 11:38 AM · Restricted Project
Tue, Dec 29
Tue, Dec 29
rriddle added a comment to D93896: Revert "[mlir][spirv] Create a pass for testing SCFToSPIRV patterns".
How does this break the Tensorflow test suite? Can you add more context?
Tue, Dec 29, 3:52 AM · Restricted Project
rriddle added inline comments to D93869: [IR] Make Value::getType() work better with invalid IR..
Tue, Dec 29, 3:11 AM · Restricted Project
Dec 17 2020
Dec 17 2020
rriddle committed rGfc5cf50e892b: [mlir] Remove the MutableDictionaryAttr class (authored by rriddle).
[mlir] Remove the MutableDictionaryAttr class
Dec 17 2020, 5:19 PM · Restricted Project