Page MenuHomePhabricator

rriddle (River Riddle)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2016, 2:24 PM (222 w, 5 d)

Recent Activity

Fri, Sep 18

rriddle requested changes to D87776: [mlir][ODS] Add TypeRef directive in Declarative Assembly Format to allow custom UserDirective parser to receive previously parsed types..

I have several concerns with this as is. Blocking while OOO.

Fri, Sep 18, 1:30 AM · Restricted Project

Wed, Sep 16

rriddle added inline comments to D87703: [mlir][Vector] Add a folder for vector.broadcast.
Wed, Sep 16, 3:00 AM · Restricted Project
rriddle added a comment to D86904: [mlir] Support for defining Types in tblgen.

Thanks for driving this!

Wed, Sep 16, 2:24 AM · Restricted Project, Restricted Project
rriddle added inline comments to D87703: [mlir][Vector] Add a folder for vector.broadcast.
Wed, Sep 16, 2:06 AM · Restricted Project

Mon, Sep 14

rriddle added inline comments to D87546: [mlir][openacc] Add loop op verifier.
Mon, Sep 14, 5:38 PM · Restricted Project

Tue, Sep 8

rriddle accepted D87334: Wordsmith RegionBranchOpInterface verification errors.
Tue, Sep 8, 4:01 PM · Restricted Project
rriddle added inline comments to D86287: [MLIR][Standard] Update `tensor_from_elements` assembly format.
Tue, Sep 8, 5:08 AM · Restricted Project
rriddle accepted D87177: Add more explicit error message when creating a type or attribute for an unregistered dialect (NFC).
Tue, Sep 8, 4:10 AM · Restricted Project
rriddle added inline comments to D85513: [mlir] Added support for loops in BufferPlacement transformation..
Tue, Sep 8, 3:27 AM · Restricted Project
rriddle added inline comments to D86619: [mlir] Conv ops vectorization pass.
Tue, Sep 8, 2:39 AM · Restricted Project
rriddle added inline comments to D87241: [mlir][VectorOps] Redo the scalar loop emission in VectoToSCF to pad instead of clipping.
Tue, Sep 8, 2:29 AM · Restricted Project

Mon, Sep 7

rriddle accepted D86985: [MLIR] Change Operation::create() methods to use Value/Type/Block ranges..

Thanks!

Mon, Sep 7, 2:59 PM · Restricted Project
rriddle requested changes to D87177: Add more explicit error message when creating a type or attribute for an unregistered dialect (NFC).
Mon, Sep 7, 2:58 PM · Restricted Project
rriddle accepted D87181: Add documentation for getDependentDialects() in the PassManagement infra docs.
Mon, Sep 7, 2:53 PM · Restricted Project
rriddle added inline comments to D87230: [MLIR] Fix Win test due to partial order of CHECK directives.
Mon, Sep 7, 1:57 PM · Restricted Project
rriddle added inline comments to D87150: [mlir][Vector] Revisit VectorToSCF..
Mon, Sep 7, 3:35 AM · Restricted Project

Sun, Sep 6

rriddle requested changes to D87206: [MLIR][SPIRV] Support identified and recursive structs..

I have concerns about several aspects of what you are doing here. Blocking until I have time to review.

Sun, Sep 6, 11:29 AM · Restricted Project

Wed, Sep 2

rriddle added a comment to D86904: [mlir] Support for defining Types in tblgen.

Thanks! This all looks really really good. I'm extremely busy over the next few days, but I'll try to give it a run over this weekend. Happy to see this coming to fruition.

Wed, Sep 2, 11:11 PM · Restricted Project, Restricted Project
rriddle accepted D87072: Decouple OpPassManager from the the MLIRContext (NFC).
Wed, Sep 2, 10:37 PM · Restricted Project
rriddle added a comment to D87068: Introduce subtraction for FlatAffineConstraints.

Please resolve the clang-tidy and clang-format issues.

Wed, Sep 2, 7:00 PM · Restricted Project
rriddle added inline comments to D86392: Implement a new kind of Pass: dynamic pass pipeline.
Wed, Sep 2, 5:11 PM · Restricted Project
rriddle added inline comments to D86392: Implement a new kind of Pass: dynamic pass pipeline.
Wed, Sep 2, 5:05 PM · Restricted Project
rriddle requested review of D87060: [mlir][Toy] Update the tutorial to use tablegen for dialect declarations.
Wed, Sep 2, 3:27 PM · Restricted Project
rriddle accepted D86994: Store an Identifier instead of a StringRef for the OperationName inside an AbstractOperation (NFC).
Wed, Sep 2, 11:33 AM · Restricted Project

Tue, Sep 1

rriddle added inline comments to D86985: [MLIR] Change Operation::create() methods to use Value/Type/Block ranges..
Tue, Sep 1, 4:22 PM · Restricted Project
rriddle added a comment to D86985: [MLIR] Change Operation::create() methods to use Value/Type/Block ranges..

Thanks!

Tue, Sep 1, 3:45 PM · Restricted Project
rriddle accepted D86915: Use an Identifier instead of an OperationName internally for OpPassManager identification (NFC).
Tue, Sep 1, 3:12 PM · Restricted Project
rriddle added inline comments to D86915: Use an Identifier instead of an OperationName internally for OpPassManager identification (NFC).
Tue, Sep 1, 2:59 PM · Restricted Project
rriddle committed rG431bb8b31825: [mlir][ODS] Use c++ types for integer attributes of fixed width when possible. (authored by rriddle).
[mlir][ODS] Use c++ types for integer attributes of fixed width when possible.
Tue, Sep 1, 2:03 PM
rriddle closed D86739: [mlir][ODS] Use c++ types for integer attributes of fixed width when possible..
Tue, Sep 1, 2:03 PM · Restricted Project
rriddle updated the diff for D86739: [mlir][ODS] Use c++ types for integer attributes of fixed width when possible..

Resolve comments

Tue, Sep 1, 1:32 PM · Restricted Project
rriddle added inline comments to D86915: Use an Identifier instead of an OperationName internally for OpPassManager identification (NFC).
Tue, Sep 1, 1:22 PM · Restricted Project
rriddle added inline comments to D86915: Use an Identifier instead of an OperationName internally for OpPassManager identification (NFC).
Tue, Sep 1, 9:57 AM · Restricted Project
rriddle added inline comments to D86915: Use an Identifier instead of an OperationName internally for OpPassManager identification (NFC).
Tue, Sep 1, 9:54 AM · Restricted Project
rriddle added inline comments to D86287: [MLIR][Standard] Update `tensor_from_elements` assembly format.
Tue, Sep 1, 8:55 AM · Restricted Project

Mon, Aug 31

rriddle accepted D86897: Fix mlir-reduce to explicitly register dialects and disable the global dialect registry by default.
Mon, Aug 31, 3:52 PM · Restricted Project
rriddle accepted D86753: [mlir][openacc] Add missing attributes and operands for acc.loop.
Mon, Aug 31, 1:33 PM · Restricted Project
rriddle committed rG2481846a303d: [mlir][PDL] Move the formats for PatternOp and RewriteOp to the declarative… (authored by rriddle).
[mlir][PDL] Move the formats for PatternOp and RewriteOp to the declarative…
Mon, Aug 31, 1:27 PM
rriddle committed rGeaeadce9bd11: [mlir][OpFormatGen] Add initial support for regions in the custom op assembly… (authored by rriddle).
[mlir][OpFormatGen] Add initial support for regions in the custom op assembly…
Mon, Aug 31, 1:27 PM
rriddle committed rG24b88920fed7: [mlir][ODS] Add new SymbolNameAttr and add support for in assemblyFormat (authored by rriddle).
[mlir][ODS] Add new SymbolNameAttr and add support for in assemblyFormat
Mon, Aug 31, 1:27 PM
rriddle committed rG88c6e25e4f06: [mlir][OpFormatGen] Add support for specifiy "custom" directives. (authored by rriddle).
[mlir][OpFormatGen] Add support for specifiy "custom" directives.
Mon, Aug 31, 1:27 PM
rriddle closed D86830: [mlir][PDL] Move the formats for PatternOp and RewriteOp to the declarative form..
Mon, Aug 31, 1:27 PM · Restricted Project
rriddle closed D86760: [mlir][OpFormatGen] Add initial support for regions in the custom op assembly format.
Mon, Aug 31, 1:27 PM · Restricted Project
rriddle closed D86759: [mlir][ODS] Add new SymbolNameAttr and add support for in assemblyFormat.
Mon, Aug 31, 1:27 PM · Restricted Project
rriddle closed D84719: [mlir][OpFormatGen] Add support for specifiy "custom" directives..
Mon, Aug 31, 1:27 PM · Restricted Project
rriddle added a comment to D86811: Make namespace handling uniform across dialect backends..

Please run clang-format, seems like there are a few issues sprinkled about.

Mon, Aug 31, 12:06 PM · Restricted Project

Fri, Aug 28

rriddle requested review of D86830: [mlir][PDL] Move the formats for PatternOp and RewriteOp to the declarative form..
Fri, Aug 28, 7:48 PM · Restricted Project
rriddle updated the diff for D86760: [mlir][OpFormatGen] Add initial support for regions in the custom op assembly format.

Address comment

Fri, Aug 28, 7:48 PM · Restricted Project
rriddle updated the diff for D86759: [mlir][ODS] Add new SymbolNameAttr and add support for in assemblyFormat.

Rebase

Fri, Aug 28, 7:48 PM · Restricted Project
rriddle updated the diff for D84719: [mlir][OpFormatGen] Add support for specifiy "custom" directives..

Rebase

Fri, Aug 28, 7:47 PM · Restricted Project
rriddle updated the diff for D86760: [mlir][OpFormatGen] Add initial support for regions in the custom op assembly format.

Resolve comments

Fri, Aug 28, 3:49 PM · Restricted Project
rriddle updated the diff for D86759: [mlir][ODS] Add new SymbolNameAttr and add support for in assemblyFormat.

Resolve comments

Fri, Aug 28, 3:49 PM · Restricted Project
rriddle updated the diff for D84719: [mlir][OpFormatGen] Add support for specifiy "custom" directives..

Address comments

Fri, Aug 28, 3:48 PM · Restricted Project
rriddle added inline comments to D86760: [mlir][OpFormatGen] Add initial support for regions in the custom op assembly format.
Fri, Aug 28, 3:08 PM · Restricted Project
rriddle requested changes to D86811: Make namespace handling uniform across dialect backends..

Thanks.

Fri, Aug 28, 3:03 PM · Restricted Project
rriddle added inline comments to D86683: Add Location, Region and Block to MLIR Python bindings..
Fri, Aug 28, 2:54 PM · Restricted Project
rriddle added inline comments to D86809: Make struct dialects have the same field name as everything else, 'dialect'..
Fri, Aug 28, 1:10 PM · Restricted Project
rriddle accepted D86810: Fix operator!= for Dialects..
Fri, Aug 28, 1:09 PM · Restricted Project
rriddle accepted D86807: Allow Dialects to be initialized via nullptr..

Ah, I see that it already has an operator bool. Please still add the justification though. It's just as important to know why a change is happening as it is to know what is changing.

Fri, Aug 28, 1:05 PM · Restricted Project
rriddle added a comment to D86807: Allow Dialects to be initialized via nullptr..

Please add justification in the description for why. Seems like this could be handled wherever Dialect is being constructed.

Fri, Aug 28, 1:02 PM · Restricted Project
rriddle added inline comments to D86756: [MLIR][Affine][VectorOps] Vectorize uniform values in SuperVectorizer.
Fri, Aug 28, 1:01 PM · Restricted Project
rriddle added inline comments to D86753: [mlir][openacc] Add missing attributes and operands for acc.loop.
Fri, Aug 28, 1:00 PM · Restricted Project

Thu, Aug 27

rriddle updated the diff for D86760: [mlir][OpFormatGen] Add initial support for regions in the custom op assembly format.

Rebase

Thu, Aug 27, 8:09 PM · Restricted Project
rriddle updated the diff for D86759: [mlir][ODS] Add new SymbolNameAttr and add support for in assemblyFormat.

Rebase

Thu, Aug 27, 8:08 PM · Restricted Project
rriddle updated the diff for D84719: [mlir][OpFormatGen] Add support for specifiy "custom" directives..

Rebase

Thu, Aug 27, 8:08 PM · Restricted Project
rriddle accepted D86755: Add a global flag to disable the global dialect registry "process wise".
Thu, Aug 27, 8:05 PM · Restricted Project
rriddle updated the diff for D86759: [mlir][ODS] Add new SymbolNameAttr and add support for in assemblyFormat.

format

Thu, Aug 27, 8:00 PM · Restricted Project
rriddle updated the diff for D84719: [mlir][OpFormatGen] Add support for specifiy "custom" directives..

format

Thu, Aug 27, 7:59 PM · Restricted Project
rriddle requested review of D86760: [mlir][OpFormatGen] Add initial support for regions in the custom op assembly format.
Thu, Aug 27, 7:58 PM · Restricted Project
rriddle requested review of D86759: [mlir][ODS] Add new SymbolNameAttr and add support for in assemblyFormat.
Thu, Aug 27, 7:58 PM · Restricted Project
rriddle updated the diff for D84719: [mlir][OpFormatGen] Add support for specifiy "custom" directives..

Rebase

Thu, Aug 27, 7:57 PM · Restricted Project
rriddle added inline comments to D86384: [MLIR][GPUToSPIRV] Passing gpu module name to SPIR-V module.
Thu, Aug 27, 6:06 PM · Restricted Project
rriddle accepted D86747: [MLIR] Add an OpRewritePattern constructor that uses generated names.
Thu, Aug 27, 3:55 PM · Restricted Project
rriddle updated the diff for D86739: [mlir][ODS] Use c++ types for integer attributes of fixed width when possible..

Fix accidental getSExtValue for unsigned

Thu, Aug 27, 2:43 PM · Restricted Project
rriddle requested review of D86739: [mlir][ODS] Use c++ types for integer attributes of fixed width when possible..
Thu, Aug 27, 2:40 PM · Restricted Project

Wed, Aug 26

rriddle added inline comments to D86112: [MLIR][mlir-spirv-cpu-runner] A pass to emulate a call to kernel in LLVM.
Wed, Aug 26, 2:57 PM · Restricted Project
rriddle added a comment to D86648: [mlir] NFC: fix trivial typo under test and tools.

Thanks!!

Wed, Aug 26, 12:19 PM · Restricted Project
rriddle accepted D86648: [mlir] NFC: fix trivial typo under test and tools.
Wed, Aug 26, 12:19 PM · Restricted Project
rriddle added inline comments to D86619: [mlir] Conv ops vectorization pass.
Wed, Aug 26, 8:28 AM · Restricted Project
rriddle added inline comments to D86619: [mlir] Conv ops vectorization pass.
Wed, Aug 26, 8:07 AM · Restricted Project
rriddle added inline comments to D86273: [MLIR][OpenMP] Conversion pattern to convert OpenMP ops to OpenMP ops with LLVM dialect.
Wed, Aug 26, 7:00 AM · Restricted Project
rriddle requested changes to D86619: [mlir] Conv ops vectorization pass.

Please run clang-format.

Wed, Aug 26, 6:45 AM · Restricted Project
rriddle added a comment to D86592: Fix MLIR build with MLIR_INCLUDE_TESTS=OFF.

I do not have commit access, someone has to commit the change for me (with attribution). Thanks

Wed, Aug 26, 6:37 AM · Restricted Project
rriddle committed rGd289a97f9144: [mlir][PDL] Add a PDL Interpreter Dialect (authored by rriddle).
[mlir][PDL] Add a PDL Interpreter Dialect
Wed, Aug 26, 5:24 AM
rriddle closed D84579: [mlir][PDL] Add a PDL Interpreter Dialect.
Wed, Aug 26, 5:24 AM · Restricted Project
rriddle updated the diff for D84580: [mlir] Add a conversion pass between PDL and the PDL Interpreter Dialect.

Rebase

Wed, Aug 26, 5:09 AM · Restricted Project
rriddle added inline comments to D84579: [mlir][PDL] Add a PDL Interpreter Dialect.
Wed, Aug 26, 5:08 AM · Restricted Project
rriddle updated the diff for D84579: [mlir][PDL] Add a PDL Interpreter Dialect.

Address comments

Wed, Aug 26, 5:08 AM · Restricted Project
rriddle added a comment to D85634: [MLIR][Standard] Fix cast materialization for incompatible types.

@rriddle, the mlir-cuda-runner tests are still failing because they materialize invalid casts. They did not fail earlier because there the verifier is not invoked when lowering to LLVM (?) and the the lowering for llvm.mlir.cast is actually able to deal with the index, it seems.

Has the fix you mentioned landed yet? I could not find it.

Wed, Aug 26, 3:51 AM · Restricted Project
rriddle accepted D82531: [MLIR][Shape] Fold `shape.size_eq`.
Wed, Aug 26, 3:23 AM · Restricted Project
rriddle accepted D86606: [MLIR][Shape] Fix typo.
Wed, Aug 26, 3:05 AM · Restricted Project
rriddle committed rG474f7639e349: [mlir] Fix bug in block merging when the types of the operands differ (authored by rriddle).
[mlir] Fix bug in block merging when the types of the operands differ
Wed, Aug 26, 1:17 AM
rriddle closed D86594: [mlir] Fix bug in block merging when the types of the operands differ.
Wed, Aug 26, 1:17 AM · Restricted Project
rriddle accepted D86273: [MLIR][OpenMP] Conversion pattern to convert OpenMP ops to OpenMP ops with LLVM dialect.
Wed, Aug 26, 1:16 AM · Restricted Project
rriddle updated the diff for D86594: [mlir] Fix bug in block merging when the types of the operands differ.

Address comments

Wed, Aug 26, 1:13 AM · Restricted Project
rriddle requested review of D86594: [mlir] Fix bug in block merging when the types of the operands differ.
Wed, Aug 26, 1:01 AM · Restricted Project

Tue, Aug 25

rriddle accepted D86588: Adjust assertion when casting to an unregistered operation.
Tue, Aug 25, 11:17 PM · Restricted Project
rriddle added a comment to D86588: Adjust assertion when casting to an unregistered operation.

The relationship between the op classes and registration feels under documented and easily error prone to new users. The fact that isa<AffineForOp>(op) will silently fail on an affine.for operation because the affine dialect isn't registered will likely feel wrong to many as an initial reaction. I'm not saying we should allow or encourage the use of the *Op classes when something is unregistered(we shouldn't), but it feels like we could make debugging/understanding a misconfiguration much easier; which if I recall is the original intention of the assert. E.g. as a bare bone hint, could we add a debug log that detects such situations and issues a message? e.g. something like:

Tue, Aug 25, 10:50 PM · Restricted Project

Aug 25 2020

rriddle added inline comments to D86236: MemRef Normalization for Dialects.
Aug 25 2020, 1:47 AM · Restricted Project

Aug 24 2020

rriddle added inline comments to D86273: [MLIR][OpenMP] Conversion pattern to convert OpenMP ops to OpenMP ops with LLVM dialect.
Aug 24 2020, 10:40 PM · Restricted Project