Page MenuHomePhabricator

rriddle (River Riddle)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2016, 2:24 PM (192 w, 6 d)

Recent Activity

Yesterday

rriddle updated the diff for D74440: [mlir][SideEffects] Enable specifying side effects directly on the arguments/results of an operation..

Resolve comments

Fri, Feb 28, 3:03 PM · Restricted Project
rriddle added a comment to D74930: [MLIR] Move from add_dependencies() to DEPENDS.

This looks like it broke the build:
https://buildkite.com/mlir/mlir-core/builds/3071#3151b122-398c-4834-b7b5-c8f88ad91720

Fri, Feb 28, 12:11 PM · Restricted Project
rriddle added a comment to D75369: [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG..

Do you need me to land this for you?

Fri, Feb 28, 11:41 AM · Restricted Project
rriddle created D75374: [mlir] Update several usages of IntegerType to properly handled unsignedness..
Fri, Feb 28, 11:12 AM · Restricted Project
rriddle accepted D75369: [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG..
Fri, Feb 28, 11:01 AM · Restricted Project
rriddle retitled D75369: [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG. from Abort early if a subregion has a disconnected CFG. to [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG..
Fri, Feb 28, 10:52 AM · Restricted Project
rriddle added a comment to D75369: [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG..

Can you please make sure to add a [mlir] tag to the beginning of the commit title?

Fri, Feb 28, 10:51 AM · Restricted Project

Thu, Feb 27

rriddle added a comment to D75260: Fix/clarify parts of MLIR toy tutorial chaper 4..

Thanks for the quick review! I don't have write access. Any chance you could submit this? (Same question for the other commits you reviewed?)

Thu, Feb 27, 6:08 PM · Restricted Project
rriddle committed rGda0257563f5f: [mlir][Tutorial] Fix comment position in SimplifyRedundantTranspose. (authored by matthiaskramm).
[mlir][Tutorial] Fix comment position in SimplifyRedundantTranspose.
Thu, Feb 27, 5:59 PM
rriddle committed rG45d522d691cc: [mlir] Fix/Clarify parts of MLIR toy tutorial chapter 6+7 (authored by matthiaskramm).
[mlir] Fix/Clarify parts of MLIR toy tutorial chapter 6+7
Thu, Feb 27, 5:59 PM
rriddle closed D75264: Flip if condition of SimplifyRedundantTranspose..
Thu, Feb 27, 5:59 PM · Restricted Project
rriddle committed rG240769c8bbfc: Fix/Clarify parts of MLIR toy tutorial chapter 5 (authored by matthiaskramm).
Fix/Clarify parts of MLIR toy tutorial chapter 5
Thu, Feb 27, 5:59 PM
rriddle closed D75263: Fix/Clarify parts of MLIR toy tutorial chapter 6+7.
Thu, Feb 27, 5:59 PM · Restricted Project
rriddle closed D75262: Fix/Clarify parts of MLIR toy tutorial chapter 5.
Thu, Feb 27, 5:59 PM · Restricted Project
rriddle committed rGd8392f76bc65: [mlir] Fix/clarify parts of MLIR toy tutorial chaper 4. (authored by matthiaskramm).
[mlir] Fix/clarify parts of MLIR toy tutorial chaper 4.
Thu, Feb 27, 5:59 PM
rriddle committed rG79c17330d359: [mlir] Fix comma+typo in MLIR toy tutorial chapter 3. (authored by matthiaskramm).
[mlir] Fix comma+typo in MLIR toy tutorial chapter 3.
Thu, Feb 27, 5:59 PM
rriddle closed D75260: Fix/clarify parts of MLIR toy tutorial chaper 4..
Thu, Feb 27, 5:59 PM · Restricted Project
rriddle closed D75258: Fix comma+typo in MLIR toy tutorial chapter 3..
Thu, Feb 27, 5:59 PM · Restricted Project
rriddle committed rG9f6617dcd9a3: [mlir] Clarify/Fix parts of MLIR toy tutorial chapter 2 (authored by matthiaskramm).
[mlir] Clarify/Fix parts of MLIR toy tutorial chapter 2
Thu, Feb 27, 5:50 PM
rriddle closed D75256: Clarify/Fix parts of MLIR toy tutorial chapter 2.
Thu, Feb 27, 5:50 PM · Restricted Project
Herald added a reviewer for D75318: [mlir] Remove successor operands from the Operation class: antiagainst.
Thu, Feb 27, 4:47 PM · Restricted Project
rriddle created D75317: [mlir] Automatically populate `operand_segment_sizes` in the auto-generated build methods..
Thu, Feb 27, 4:47 PM · Restricted Project
Herald added a reviewer for D75315: [mlir][DeclarativeParser] Add support for formatting operations with AttrSizedOperandSegments.: nicolasvasilache.
Thu, Feb 27, 4:47 PM · Restricted Project
rriddle added a child revision for D75316: [mlir] Refactor a few users to no longer rely on the successor operand API of Operation.: D75317: [mlir] Automatically populate `operand_segment_sizes` in the auto-generated build methods..
Thu, Feb 27, 4:47 PM · Restricted Project
rriddle added a child revision for D75317: [mlir] Automatically populate `operand_segment_sizes` in the auto-generated build methods.: D75318: [mlir] Remove successor operands from the Operation class.
Thu, Feb 27, 4:47 PM · Restricted Project
rriddle added a child revision for D75315: [mlir][DeclarativeParser] Add support for formatting operations with AttrSizedOperandSegments.: D75316: [mlir] Refactor a few users to no longer rely on the successor operand API of Operation..
Thu, Feb 27, 4:47 PM · Restricted Project
rriddle created D75316: [mlir] Refactor a few users to no longer rely on the successor operand API of Operation..
Thu, Feb 27, 4:47 PM · Restricted Project
rriddle added a child revision for D75313: [mlir] Add traits for verifying the number of successors and providing relevant accessors.: D75314: [mlir] Add a new BranchOpInterface to allow for opaquely interfacing with branching terminator operations..
Thu, Feb 27, 4:47 PM · Restricted Project
rriddle added a child revision for D75314: [mlir] Add a new BranchOpInterface to allow for opaquely interfacing with branching terminator operations.: D75315: [mlir][DeclarativeParser] Add support for formatting operations with AttrSizedOperandSegments..
Thu, Feb 27, 4:47 PM · Restricted Project
rriddle created D75314: [mlir] Add a new BranchOpInterface to allow for opaquely interfacing with branching terminator operations..
Thu, Feb 27, 4:47 PM · Restricted Project
rriddle created D75313: [mlir] Add traits for verifying the number of successors and providing relevant accessors..
Thu, Feb 27, 4:47 PM · Restricted Project
rriddle accepted D74865: [MLIR] add show-dialects option for mlir-opt.
Thu, Feb 27, 10:41 AM · Restricted Project
rriddle accepted D75272: [MLIR] Refactor library initialization of JitRunner..
Thu, Feb 27, 10:13 AM · Restricted Project
rriddle accepted D75263: Fix/Clarify parts of MLIR toy tutorial chapter 6+7.
Thu, Feb 27, 10:02 AM · Restricted Project
rriddle accepted D75262: Fix/Clarify parts of MLIR toy tutorial chapter 5.
Thu, Feb 27, 10:00 AM · Restricted Project
rriddle accepted D75260: Fix/clarify parts of MLIR toy tutorial chaper 4..
Thu, Feb 27, 10:00 AM · Restricted Project
rriddle accepted D75258: Fix comma+typo in MLIR toy tutorial chapter 3..
Thu, Feb 27, 9:59 AM · Restricted Project
rriddle accepted D75256: Clarify/Fix parts of MLIR toy tutorial chapter 2.
Thu, Feb 27, 9:59 AM · Restricted Project
rriddle accepted D75264: Flip if condition of SimplifyRedundantTranspose..

Thanks Matthias!

Thu, Feb 27, 9:43 AM · Restricted Project
rriddle added inline comments to D75141: [MLIR] Add llvm.mlir.cast op for semantic preserving cast between dialect types..
Thu, Feb 27, 8:44 AM · Restricted Project
rriddle added inline comments to D75257: [mlir] NFC - Split out RunnerUtils that don't require a C++ runtime.
Thu, Feb 27, 8:41 AM · Restricted Project
rriddle added inline comments to D75240: Add a pass that specializes parallel loops for easier unrolling and vectorization.
Thu, Feb 27, 8:38 AM · Restricted Project
rriddle added inline comments to D75232: [MLIR][Loops] Expose transformations on loop.parallel in header (NFC)..
Thu, Feb 27, 8:36 AM · Restricted Project

Wed, Feb 26

rriddle accepted D75208: [MLIR] Add `take_back()` to STLExtras.h for completeness..
Wed, Feb 26, 12:20 PM · Restricted Project
rriddle added inline comments to D75195: [mlir][spirv] Add some folders for spv.LogicalAnd/spv.LogicalOr.
Wed, Feb 26, 10:13 AM · Restricted Project
rriddle accepted D75195: [mlir][spirv] Add some folders for spv.LogicalAnd/spv.LogicalOr.
Wed, Feb 26, 10:13 AM · Restricted Project
rriddle added inline comments to D75195: [mlir][spirv] Add some folders for spv.LogicalAnd/spv.LogicalOr.
Wed, Feb 26, 9:54 AM · Restricted Project

Tue, Feb 25

rriddle added inline comments to D75146: [mlir][Linalg] NFC - Refactor LinalgStructuredOps towards "named" Linalg ops.
Tue, Feb 25, 3:35 PM · Restricted Project
rriddle added inline comments to D75146: [mlir][Linalg] NFC - Refactor LinalgStructuredOps towards "named" Linalg ops.
Tue, Feb 25, 3:14 PM · Restricted Project
rriddle accepted D75146: [mlir][Linalg] NFC - Refactor LinalgStructuredOps towards "named" Linalg ops.
Tue, Feb 25, 3:14 PM · Restricted Project
rriddle committed rGb3e6487f02ac: [mlir][DenseElementsAttr] Fix storage size for bfloat16 when parsing from hex. (authored by rriddle).
[mlir][DenseElementsAttr] Fix storage size for bfloat16 when parsing from hex.
Tue, Feb 25, 3:05 PM
rriddle closed D75133: [mlir][DenseElementsAttr] Fix storage size for bfloat16 when parsing from hex..
Tue, Feb 25, 3:05 PM · Restricted Project
rriddle added inline comments to D74439: [mlir][SideEffects] Define a set of interfaces and traits for defining side effects.
Tue, Feb 25, 2:56 PM · Restricted Project
rriddle updated the diff for D74439: [mlir][SideEffects] Define a set of interfaces and traits for defining side effects.

Rebase and resolve comments

Tue, Feb 25, 2:55 PM · Restricted Project
rriddle created D75133: [mlir][DenseElementsAttr] Fix storage size for bfloat16 when parsing from hex..
Tue, Feb 25, 12:10 PM · Restricted Project

Mon, Feb 24

rriddle accepted D74401: [MLIR] Add std.atomic_rmw op.

Thanks!

Mon, Feb 24, 4:45 PM · Restricted Project
rriddle accepted D75066: [mlir][spirv] NFC: Move test passes to test/lib.

Thanks Lei!

Mon, Feb 24, 11:07 AM · Restricted Project
rriddle added inline comments to D75058: [mlir] simplify affine maps and operands in affine.min/max.
Mon, Feb 24, 9:17 AM · Restricted Project
rriddle added inline comments to D74954: Add a basic tiling pass for parallel loops.
Mon, Feb 24, 9:17 AM · Restricted Project

Fri, Feb 21

rriddle committed rG42060c0a9870: [mlir][DeclarativeParser][NFC] Use explicit type names in TypeSwitch to appease… (authored by rriddle).
[mlir][DeclarativeParser][NFC] Use explicit type names in TypeSwitch to appease…
Fri, Feb 21, 4:21 PM
rriddle committed rGb1de971ba8c8: [mlir][ODS] Add support for specifying the successors of an operation. (authored by rriddle).
[mlir][ODS] Add support for specifying the successors of an operation.
Fri, Feb 21, 3:26 PM
rriddle committed rG0050e8f0cf57: [mlir][Tutorial] Add a section to Toy Ch.2 detailing the custom assembly format. (authored by rriddle).
[mlir][Tutorial] Add a section to Toy Ch.2 detailing the custom assembly format.
Fri, Feb 21, 3:26 PM
rriddle committed rG9eb436feaa7f: [mlir][DeclarativeParser] Add support for formatting the successors of an… (authored by rriddle).
[mlir][DeclarativeParser] Add support for formatting the successors of an…
Fri, Feb 21, 3:26 PM
rriddle committed rG93813e5feb18: [mlir] Add a utility iterator range that repeats a given value `n` times. (authored by rriddle).
[mlir] Add a utility iterator range that repeats a given value `n` times.
Fri, Feb 21, 3:25 PM
rriddle closed D74789: [mlir][DeclarativeParser] Add support for formatting the successors of an operation..
Fri, Feb 21, 3:25 PM · Restricted Project
rriddle closed D74938: [mlir][Tutorial] Add a section to Toy Ch.2 detailing the custom assembly format..
Fri, Feb 21, 3:25 PM · Restricted Project
rriddle closed D74783: [mlir][ODS] Add support for specifying the successors of an operation..
Fri, Feb 21, 3:25 PM · Restricted Project
rriddle committed rG26222db01b07: [mlir][DeclarativeParser] Add support for the TypesMatchWith trait. (authored by rriddle).
[mlir][DeclarativeParser] Add support for the TypesMatchWith trait.
Fri, Feb 21, 3:25 PM
rriddle committed rGca4ea51c0af2: [mlir][DeclarativeParser] Add an 'attr-dict-with-keyword' directive (authored by rriddle).
[mlir][DeclarativeParser] Add an 'attr-dict-with-keyword' directive
Fri, Feb 21, 3:25 PM
rriddle committed rG2d0477a00368: [mlir][DeclarativeParser] Add basic support for optional groups in the assembly… (authored by rriddle).
[mlir][DeclarativeParser] Add basic support for optional groups in the assembly…
Fri, Feb 21, 3:25 PM
rriddle closed D74683: [mlir] Add a utility iterator range that repeats a given value `n` times..
Fri, Feb 21, 3:25 PM · Restricted Project
rriddle closed D74681: [mlir][DeclarativeParser] Add basic support for optional groups in the assembly format..
Fri, Feb 21, 3:25 PM · Restricted Project
rriddle closed D74682: [mlir][DeclarativeParser] Add an 'attr-dict-with-keyword' directive.
Fri, Feb 21, 3:25 PM · Restricted Project
rriddle closed D74648: [mlir][DeclarativeParser] Add support for the TypesMatchWith trait..
Fri, Feb 21, 3:25 PM · Restricted Project
rriddle updated the summary of D74681: [mlir][DeclarativeParser] Add basic support for optional groups in the assembly format..
Fri, Feb 21, 2:02 PM · Restricted Project
rriddle updated the diff for D74938: [mlir][Tutorial] Add a section to Toy Ch.2 detailing the custom assembly format..

Add missing mlir:: to Ch.2 doc

Fri, Feb 21, 1:25 PM · Restricted Project
rriddle added inline comments to D74681: [mlir][DeclarativeParser] Add basic support for optional groups in the assembly format..
Fri, Feb 21, 1:15 PM · Restricted Project
rriddle updated the diff for D74938: [mlir][Tutorial] Add a section to Toy Ch.2 detailing the custom assembly format..

Rebase

Fri, Feb 21, 1:15 PM · Restricted Project
rriddle updated the diff for D74789: [mlir][DeclarativeParser] Add support for formatting the successors of an operation..

Resolve comments

Fri, Feb 21, 1:15 PM · Restricted Project
rriddle updated the diff for D74783: [mlir][ODS] Add support for specifying the successors of an operation..

Resolve comments.

Fri, Feb 21, 1:15 PM · Restricted Project
rriddle updated the diff for D74682: [mlir][DeclarativeParser] Add an 'attr-dict-with-keyword' directive.

Resolve comments.

Fri, Feb 21, 1:15 PM · Restricted Project
rriddle updated the diff for D74681: [mlir][DeclarativeParser] Add basic support for optional groups in the assembly format..

Resolve comments

Fri, Feb 21, 1:15 PM · Restricted Project
rriddle updated the diff for D74648: [mlir][DeclarativeParser] Add support for the TypesMatchWith trait..

Resolve comments

Fri, Feb 21, 1:15 PM · Restricted Project
rriddle added a comment to D74648: [mlir][DeclarativeParser] Add support for the TypesMatchWith trait..

Nice! Can we also update the doc regarding which traits are supported? Otherwise it's quite obscure for somebody to figure out what works and what not.

Fri, Feb 21, 12:46 PM · Restricted Project
rriddle committed rG69d757c0e8ff: Move StandardOps/Ops.h to StandardOps/IR/Ops.h (authored by rsuderman).
Move StandardOps/Ops.h to StandardOps/IR/Ops.h
Fri, Feb 21, 12:04 PM
rriddle closed D74940: Move StandardOps/Ops.h to StandardOps/IR/Ops.h.
Fri, Feb 21, 12:04 PM · Restricted Project
rriddle updated the diff for D74938: [mlir][Tutorial] Add a section to Toy Ch.2 detailing the custom assembly format..

Make all ops pretty.

Fri, Feb 21, 11:54 AM · Restricted Project
rriddle updated the diff for D74683: [mlir] Add a utility iterator range that repeats a given value `n` times..

Resolve comments.

Fri, Feb 21, 11:54 AM · Restricted Project
rriddle accepted D74978: [MLIR] Remove constexpr from LoopOps.td.

Feel free to submit a small+simple fix like this directly next time.

Fri, Feb 21, 11:48 AM · Restricted Project
rriddle added inline comments to D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .
Fri, Feb 21, 11:18 AM · Restricted Project
rriddle added inline comments to D74174: [MLIR] Allow Loop dialect IfOp and ForOp to define values .
Fri, Feb 21, 11:11 AM · Restricted Project

Thu, Feb 20

rriddle updated the diff for D74789: [mlir][DeclarativeParser] Add support for formatting the successors of an operation..

Rebase

Thu, Feb 20, 10:33 PM · Restricted Project
rriddle updated the diff for D74783: [mlir][ODS] Add support for specifying the successors of an operation..

Rebase

Thu, Feb 20, 10:33 PM · Restricted Project
rriddle added inline comments to D74783: [mlir][ODS] Add support for specifying the successors of an operation..
Thu, Feb 20, 9:15 PM · Restricted Project
rriddle committed rGc32c8fd1437c: [mlir] Use getOperation()->setAttr when generating attribute set methods. (authored by rriddle).
[mlir] Use getOperation()->setAttr when generating attribute set methods.
Thu, Feb 20, 8:13 PM
rriddle accepted D74940: Move StandardOps/Ops.h to StandardOps/IR/Ops.h.

Awesome! Thank you for doing this!

Thu, Feb 20, 6:24 PM · Restricted Project
rriddle created D74938: [mlir][Tutorial] Add a section to Toy Ch.2 detailing the custom assembly format..
Thu, Feb 20, 5:01 PM · Restricted Project
rriddle added a child revision for D74789: [mlir][DeclarativeParser] Add support for formatting the successors of an operation.: D74938: [mlir][Tutorial] Add a section to Toy Ch.2 detailing the custom assembly format..
Thu, Feb 20, 5:01 PM · Restricted Project
rriddle committed rG51bf5d3cc19a: [mlir][Parser] Update DenseElementsAttr to print in hex when the number of… (authored by rriddle).
[mlir][Parser] Update DenseElementsAttr to print in hex when the number of…
Thu, Feb 20, 2:49 PM
rriddle closed D74922: [mlir][Parser] Update DenseElementsAttr to print in hex when the number of elements is over a certain threshold..
Thu, Feb 20, 2:48 PM · Restricted Project