Page MenuHomePhabricator

rriddle (River Riddle)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2016, 2:24 PM (160 w, 3 d)

Recent Activity

Mon, Jun 24

rriddle added a comment to D63632: Update the llvm::enumerate utility class result_pair to use the 'iterator_traits<R>::reference' instead of 'ValueOfIter<R> &'..

My understanding is that input_iterators do not have to return a reference, and may return a value type or some other proxy object.

Mon, Jun 24, 3:32 PM · Restricted Project

Thu, Jun 20

rriddle created D63632: Update the llvm::enumerate utility class result_pair to use the 'iterator_traits<R>::reference' instead of 'ValueOfIter<R> &'..
Thu, Jun 20, 4:52 PM · Restricted Project

May 26 2019

rriddle added a comment to D62467: NFC: Change usage of 'DenseSet' to 'DenseSetImpl' in DenseSetImpl::ConstIterator..

Updated. This was actually a missed change from the split of DenseSet here(https://reviews.llvm.org/D25628) that results in build errors on MSVC when forward declaring DenseSet. This friend decl does not forward declare the template arguments as well, which creates a mismatch.

May 26 2019, 11:35 AM · Restricted Project
rriddle updated the summary of D62467: NFC: Change usage of 'DenseSet' to 'DenseSetImpl' in DenseSetImpl::ConstIterator..
May 26 2019, 11:33 AM · Restricted Project
rriddle created D62467: NFC: Change usage of 'DenseSet' to 'DenseSetImpl' in DenseSetImpl::ConstIterator..
May 26 2019, 11:00 AM · Restricted Project

Jan 5 2018

rriddle added a comment to D41334: [CodeExtractor] Use subset of function attributes for extracted function..

I was actually responsible for the target dependent attrs patch, Sean was nice enough to commit for me at the time.

Jan 5 2018, 6:52 AM

Dec 11 2017

rriddle created D41079: [RFC][WIP] Add VS extension for viewing optimization remarks to clang-tools-extra..
Dec 11 2017, 11:04 AM · Restricted Project

Dec 8 2017

rriddle added inline comments to rL320229: [MachineOutliner] Outline calls.
Dec 8 2017, 7:53 PM
rriddle accepted D40413: [CodeExtractor] Add debug locations for new call and branch instrs..

LGTM

Dec 8 2017, 5:11 AM

Dec 5 2017

rriddle added inline comments to D40413: [CodeExtractor] Add debug locations for new call and branch instrs..
Dec 5 2017, 3:10 PM
rriddle added inline comments to D40413: [CodeExtractor] Add debug locations for new call and branch instrs..
Dec 5 2017, 11:31 AM

Sep 13 2017

rriddle added a comment to D37762: [InstCombine] Remove single use restriction from InstCombine's explicit sinking code..

Has there been any sort of discussion on expanding/using the existing IR level code sinking pass? I am referring to the SinkingPass in scalar/sink.cpp. AFAIK it's only used in the AMDGPU preisel pipeline. I don't know it's current state/usability but the description of the pass is:

Sep 13 2017, 2:39 PM

Jul 31 2017

rriddle abandoned D36043: [WIP] Add interprocedural IR outliner pass..
Jul 31 2017, 10:54 PM
rriddle abandoned D35980: [WIP] Add a generic interface for outlining..

We will have more discussion before moving forward.

Jul 31 2017, 10:51 PM

Jul 28 2017

rriddle added a reviewer for D36043: [WIP] Add interprocedural IR outliner pass.: paquette.
Jul 28 2017, 10:01 PM
rriddle added a parent revision for D36043: [WIP] Add interprocedural IR outliner pass.: D35980: [WIP] Add a generic interface for outlining..
Jul 28 2017, 9:50 PM
rriddle added a child revision for D35980: [WIP] Add a generic interface for outlining.: D36043: [WIP] Add interprocedural IR outliner pass..
Jul 28 2017, 9:50 PM
rriddle updated subscribers of D36043: [WIP] Add interprocedural IR outliner pass..
Jul 28 2017, 9:44 PM
rriddle added reviewers for D36043: [WIP] Add interprocedural IR outliner pass.: davide, silvas, qcolombet.
Jul 28 2017, 9:40 PM
rriddle created D36043: [WIP] Add interprocedural IR outliner pass..
Jul 28 2017, 9:39 PM
rriddle updated the diff for D35980: [WIP] Add a generic interface for outlining..

Finish moving outlining utilities to the interface.

Jul 28 2017, 7:55 PM
rriddle abandoned D36042: Move GVNExpression DenseMapInfo to GVNExpression.h.

Going to define a custom DenseMapInfo for my use case for now.

Jul 28 2017, 6:37 PM
rriddle created D36042: Move GVNExpression DenseMapInfo to GVNExpression.h.
Jul 28 2017, 5:51 PM
rriddle updated the diff for D35980: [WIP] Add a generic interface for outlining..

Fix patch format.

Jul 28 2017, 10:13 AM
rriddle updated the diff for D35980: [WIP] Add a generic interface for outlining..

Slight NFC.

Jul 28 2017, 9:55 AM
rriddle created D35980: [WIP] Add a generic interface for outlining..
Jul 28 2017, 12:39 AM

Dec 15 2016

rriddle abandoned D21496: LoadCombine Load Aliasing Fix.
Dec 15 2016, 3:49 AM
rriddle abandoned D21498: Load Combine : Load combining for multiple subchains.
Dec 15 2016, 3:49 AM
rriddle abandoned D22710: Add option to CodeExtractor for hoisting static allocas with uses contained within extracted region.
Dec 15 2016, 3:48 AM
rriddle abandoned D23348: CodeExtractor : Move exit block splitting logic from PartialInliner to CodeExtractor.
Dec 15 2016, 3:48 AM

Nov 17 2016

rriddle added a comment to D21498: Load Combine : Load combining for multiple subchains.

It never landed and load combine isn't really used, so it wasn't a big priority. The problem with load combine in general, AFAIK, is the cost analysis for if it is even profitable to combine loads.

Nov 17 2016, 11:49 PM

Aug 10 2016

rriddle retitled D23348: CodeExtractor : Move exit block splitting logic from PartialInliner to CodeExtractor from to CodeExtractor : Move exit block splitting logic from PartialInliner to CodeExtractor.
Aug 10 2016, 3:15 AM

Aug 1 2016

rriddle updated the diff for D22744: CodeExtractor : Add ability to preserve profile data..

Manual computation of BFI and BPI in partial inliner.

Aug 1 2016, 6:54 PM

Jul 31 2016

rriddle updated the diff for D22710: Add option to CodeExtractor for hoisting static allocas with uses contained within extracted region.

Updated to reflect Sean's comments

Jul 31 2016, 8:13 PM
rriddle updated the diff for D22744: CodeExtractor : Add ability to preserve profile data..

Updated to reflect Sean's comments

Jul 31 2016, 7:10 PM

Jul 29 2016

rriddle updated the diff for D22744: CodeExtractor : Add ability to preserve profile data..
Jul 29 2016, 12:04 AM
rriddle updated the diff for D22744: CodeExtractor : Add ability to preserve profile data..

Updated after David's comments

Jul 29 2016, 12:02 AM

Jul 28 2016

rriddle updated the diff for D22713: Fix - CodeExtractor : Inherit Target Dependent Attributes from the parent function..

Fixed test description

Jul 28 2016, 11:56 PM
rriddle updated the diff for D22713: Fix - CodeExtractor : Inherit Target Dependent Attributes from the parent function..

Updated after Sean's comments

Jul 28 2016, 2:55 PM

Jul 27 2016

rriddle updated the diff for D22744: CodeExtractor : Add ability to preserve profile data..

Updated after Sean and David's comments

Jul 27 2016, 10:14 PM
rriddle added inline comments to D22744: CodeExtractor : Add ability to preserve profile data..
Jul 27 2016, 5:17 PM
rriddle added a comment to D22744: CodeExtractor : Add ability to preserve profile data..
Jul 27 2016, 4:53 PM
rriddle added inline comments to D22744: CodeExtractor : Add ability to preserve profile data..
Jul 27 2016, 11:15 AM
rriddle added inline comments to D22744: CodeExtractor : Add ability to preserve profile data..
Jul 27 2016, 11:14 AM

Jul 26 2016

rriddle updated the diff for D22744: CodeExtractor : Add ability to preserve profile data..

Updated after Davids comments

Jul 26 2016, 4:15 PM

Jul 25 2016

rriddle updated the diff for D22744: CodeExtractor : Add ability to preserve profile data..

Formatting

Jul 25 2016, 11:09 AM
rriddle updated the diff for D22744: CodeExtractor : Add ability to preserve profile data..

Hard exit if an exit frequency is zero.

Jul 25 2016, 11:07 AM
rriddle updated the diff for D22699: Refactor - CodeExtractor : Move check for valid block to static utility and add assumption checks..

Moving assumptions to later patch

Jul 25 2016, 10:21 AM
rriddle retitled D22744: CodeExtractor : Add ability to preserve profile data. from to CodeExtractor : Add ability to preserve profile data..
Jul 25 2016, 12:09 AM

Jul 24 2016

rriddle retitled D22743: Cleanup : Reformat PartialInliner.cpp to have current LLVM style conventions from to Cleanup : Reformat PartialInliner.cpp to have current LLVM style conventions.
Jul 24 2016, 10:53 PM
rriddle updated the diff for D22706: Fix : Partial Inliner requires AssumptionCacheTracker.

Updated from Sean's comments

Jul 24 2016, 8:04 PM

Jul 23 2016

rriddle updated the diff for D22706: Fix : Partial Inliner requires AssumptionCacheTracker.

Updated to reflect r276515

Jul 23 2016, 4:09 PM
rriddle updated the diff for D22710: Add option to CodeExtractor for hoisting static allocas with uses contained within extracted region.

Formatting

Jul 23 2016, 1:45 PM
rriddle updated the diff for D22713: Fix - CodeExtractor : Inherit Target Dependent Attributes from the parent function..

Updated formatting and fixed error in test case

Jul 23 2016, 1:43 PM

Jul 22 2016

rriddle updated D22713: Fix - CodeExtractor : Inherit Target Dependent Attributes from the parent function..
Jul 22 2016, 6:09 PM
rriddle updated D22713: Fix - CodeExtractor : Inherit Target Dependent Attributes from the parent function..
Jul 22 2016, 6:09 PM
rriddle retitled D22713: Fix - CodeExtractor : Inherit Target Dependent Attributes from the parent function. from to Fix - CodeExtractor : Inherit Target Dependent Attributes from the parent function..
Jul 22 2016, 6:08 PM
rriddle retitled D22710: Add option to CodeExtractor for hoisting static allocas with uses contained within extracted region from to Add option to CodeExtractor for hoisting dominated static allocas.
Jul 22 2016, 5:12 PM
rriddle updated the diff for D22706: Fix : Partial Inliner requires AssumptionCacheTracker.

Fix the formatting of the implementation and added a test case for the assumption cache.

Jul 22 2016, 4:51 PM
rriddle added a comment to D22706: Fix : Partial Inliner requires AssumptionCacheTracker.

The new pass manager doesn't use AssumptionCacheTracker, providing a replacement instead with AssumptionAnalysis.

Jul 22 2016, 3:54 PM
rriddle updated the diff for D22706: Fix : Partial Inliner requires AssumptionCacheTracker.

Explicit dependency for LegacyPass

Jul 22 2016, 3:53 PM
rriddle added a comment to D22706: Fix : Partial Inliner requires AssumptionCacheTracker.

Also, the pass was already ported to the new pass manager, this just moves the code into a different structure.

Jul 22 2016, 3:36 PM
rriddle added a comment to D22706: Fix : Partial Inliner requires AssumptionCacheTracker.

Sorry, I was under the impression that the new pass managed had a functor for the ACT. I guess that was a pass that hadn't landed yet.

Jul 22 2016, 3:34 PM
rriddle added a comment to D22706: Fix : Partial Inliner requires AssumptionCacheTracker.

It was already ported to the new pass manager, but given that InlineFunction directly accesses the ACT it will crash if run via legacy.

Jul 22 2016, 3:31 PM
rriddle retitled D22706: Fix : Partial Inliner requires AssumptionCacheTracker from to Fix : Partial Inliner requires AssumptionCacheTracker.
Jul 22 2016, 3:13 PM
rriddle updated the diff for D22699: Refactor - CodeExtractor : Move check for valid block to static utility and add assumption checks..
Jul 22 2016, 2:06 PM
rriddle retitled D22699: Refactor - CodeExtractor : Move check for valid block to static utility and add assumption checks. from to Refactor - CodeExtractor : Move check for valid block to static utility and add assumption checks..
Jul 22 2016, 2:00 PM

Jun 28 2016

rriddle added a comment to D21496: LoadCombine Load Aliasing Fix.

Sorry about that.

Jun 28 2016, 10:35 AM
rriddle updated the diff for D21496: LoadCombine Load Aliasing Fix.

Updated tests

Jun 28 2016, 10:35 AM

Jun 19 2016

rriddle updated the diff for D21496: LoadCombine Load Aliasing Fix.

Refactor CombineLoads

Jun 19 2016, 2:27 PM
rriddle updated the diff for D21496: LoadCombine Load Aliasing Fix.
Jun 19 2016, 2:12 PM
rriddle updated the diff for D21496: LoadCombine Load Aliasing Fix.

Fixed load sorting

Jun 19 2016, 2:07 PM
rriddle updated the diff for D21496: LoadCombine Load Aliasing Fix.

Redundant checks and comments. Updated test arguments.

Jun 19 2016, 2:04 PM
rriddle updated the diff for D21496: LoadCombine Load Aliasing Fix.

Updated Memory location creation

Jun 19 2016, 12:41 PM
rriddle updated the diff for D21496: LoadCombine Load Aliasing Fix.

Fixed argument aliasing and updated test suite

Jun 19 2016, 12:37 PM
rriddle abandoned D21496: LoadCombine Load Aliasing Fix.
Jun 19 2016, 9:24 AM

Jun 18 2016

rriddle added a comment to D21499: Load Combine : Combine Loads formed from GEPS with negative indexes .

Hey David, This is my first patch so Im not too sure about the process for committing. Accordingly, Im fairly certain that I don't have commit access.
Thanks River

Jun 18 2016, 7:20 PM
rriddle added inline comments to D21496: LoadCombine Load Aliasing Fix.
Jun 18 2016, 7:17 PM
rriddle added inline comments to D21496: LoadCombine Load Aliasing Fix.
Jun 18 2016, 7:12 PM
rriddle added inline comments to D21496: LoadCombine Load Aliasing Fix.
Jun 18 2016, 6:29 PM
rriddle updated the diff for D21499: Load Combine : Combine Loads formed from GEPS with negative indexes .

Fixed the size type change mistake. Changed the iteration variable to be a separate value.

Jun 18 2016, 6:15 PM
rriddle retitled D21499: Load Combine : Combine Loads formed from GEPS with negative indexes from to Load Combine : Combine Loads formed from GEPS with negative indexes .
Jun 18 2016, 5:55 PM
rriddle retitled D21498: Load Combine : Load combining for multiple subchains from to Load Combine : Load combining for multiple subchains.
Jun 18 2016, 5:52 PM
rriddle updated the diff for D21496: LoadCombine Load Aliasing Fix.

Removed the other patch fixes and added a test to the test suite

Jun 18 2016, 5:48 PM
rriddle retitled D21496: LoadCombine Load Aliasing Fix from LoadCombine BugFixes : Combine negative index GEPS and fix load aliasing to LoadCombine Load Aliasing Fix.
Jun 18 2016, 5:47 PM
rriddle retitled D21496: LoadCombine Load Aliasing Fix from to LoadCombine BugFixes : Combine negative index GEPS and fix load aliasing.
Jun 18 2016, 3:12 PM