User Details
User Details
- User Since
- Dec 24 2019, 5:47 AM (131 w, 6 d)
Tue, Jun 28
Tue, Jun 28
Thanks for making this clearer!
antiagainst added inline comments to D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
antiagainst updated the diff for D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
Address comments
antiagainst committed rGe1e0ecb96e0a: [mlir][spirv] Support more comparisons on boolean values (authored by antiagainst).
[mlir][spirv] Support more comparisons on boolean values
Mon, Jun 27
Mon, Jun 27
antiagainst requested review of D128692: [mlir][spirv] Support more comparisons on boolean values.
Fri, Jun 24
Fri, Jun 24
antiagainst added inline comments to D127286: [MLIR][Math] Add round operation.
Thu, Jun 23
Thu, Jun 23
antiagainst committed rGb2671d8898e9: [mlir][spirv] Fix bitcast input order for UnifyAliasedResourcePass (authored by antiagainst).
[mlir][spirv] Fix bitcast input order for UnifyAliasedResourcePass
antiagainst requested review of D128473: [mlir][spirv] Fix bitcast input order for UnifyAliasedResourcePass.
Wed, Jun 22
Wed, Jun 22
antiagainst committed rGefe603e70dec: [mlir][vulkan-runner] fix VK_ERROR_INCOMPATIBLE_DRIVER error (authored by jackalcooper).
[mlir][vulkan-runner] fix VK_ERROR_INCOMPATIBLE_DRIVER error
antiagainst added a comment to D128173: [mlir][vulkan-runner] fix VK_ERROR_INCOMPATIBLE_DRIVER error.
Tue, Jun 21
Tue, Jun 21
Thu, Jun 16
Thu, Jun 16
antiagainst committed rG2320a4ae907f: [mlir][spirv] Workaround driver bug in math.ctlz conversion again (authored by antiagainst).
[mlir][spirv] Workaround driver bug in math.ctlz conversion again
antiagainst updated the diff for D127930: [mlir][spirv] Workaround driver bug in math.ctlz conversion again.
Fix typos
Wed, Jun 15
Wed, Jun 15
antiagainst retitled D127930: [mlir][spirv] Workaround driver bug in math.ctlz conversion again from [mlir][spirv] Woraround driver bug in math.ctlz converion again to [mlir][spirv] Workaround driver bug in math.ctlz conversion again.
antiagainst requested review of D127930: [mlir][spirv] Workaround driver bug in math.ctlz conversion again.
antiagainst committed rGf3bc0fccd68a: [mlir][spirv] Define spv.ISubBorrowOp (authored by antiagainst).
[mlir][spirv] Define spv.ISubBorrowOp
antiagainst updated the diff for D127909: [mlir][spirv] Define spv.ISubBorrowOp.
Update example
antiagainst requested review of D127909: [mlir][spirv] Define spv.ISubBorrowOp.
Tue, Jun 14
Tue, Jun 14
antiagainst committed rG06c6758a9816: [mlir][spirv] Handle corner cases for math.powf conversion (authored by antiagainst).
[mlir][spirv] Handle corner cases for math.powf conversion
antiagainst requested review of D127816: [mlir][spirv] Handle corner cases for math.powf conversion.
antiagainst committed rGb4dff404f37a: [mlir][spirv] Fix math.ctlz for full zero bit cases (authored by antiagainst).
[mlir][spirv] Fix math.ctlz for full zero bit cases
antiagainst updated the diff for D127747: [mlir][spirv] Fix math.ctlz for full zero bit cases.
Rebase
antiagainst requested review of D127747: [mlir][spirv] Fix math.ctlz for full zero bit cases.
Mon, Jun 13
Mon, Jun 13
antiagainst committed rGb5192cbe506c: [mlir][spirv] Fix result type for arith.cmpi/cmpf conversion (authored by antiagainst).
[mlir][spirv] Fix result type for arith.cmpi/cmpf conversion
antiagainst committed rG91de20c36d58: [mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV (authored by antiagainst).
[mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV
antiagainst added inline comments to D127573: [mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV.
antiagainst committed rGcc020a2236af: [mlir][spirv] Convert math.ctlz to spv.GLSL.FindUMsb (authored by antiagainst).
[mlir][spirv] Convert math.ctlz to spv.GLSL.FindUMsb
antiagainst updated the diff for D127582: [mlir][spirv] Convert math.ctlz to spv.GLSL.FindUMsb.
Add some negative tests
antiagainst added a reviewer for D127582: [mlir][spirv] Convert math.ctlz to spv.GLSL.FindUMsb: rsuderman.
antiagainst added inline comments to D127573: [mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV.
antiagainst committed rGa10c09d1e38b: [mlir][spirv] Remove unused `traits` from `SPV_Attr` (authored by antiagainst).
[mlir][spirv] Remove unused `traits` from `SPV_Attr`
antiagainst committed rGa4360efb2c59: [mlir][spirv] Convert single element vector.splat/fma (authored by antiagainst).
[mlir][spirv] Convert single element vector.splat/fma
Sat, Jun 11
Sat, Jun 11
antiagainst retitled D127572: [mlir][spirv] Convert single element vector.splat/fma from [mlir][spirv] Convert single element vector.splat to [mlir][spirv] Convert single element vector.splat/fma.
antiagainst updated the diff for D127572: [mlir][spirv] Convert single element vector.splat/fma.
Update
antiagainst requested review of D127582: [mlir][spirv] Convert math.ctlz to spv.GLSL.FindUMsb.
antiagainst added a reviewer for D127572: [mlir][spirv] Convert single element vector.splat/fma: mravishankar.
antiagainst added a reviewer for D127573: [mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV: mravishankar.
antiagainst added a reviewer for D127574: [mlir][spirv] Fix result type for arith.cmpi/cmpf conversion: mravishankar.
antiagainst requested review of D127574: [mlir][spirv] Fix result type for arith.cmpi/cmpf conversion.
antiagainst requested review of D127573: [mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV.
antiagainst requested review of D127572: [mlir][spirv] Convert single element vector.splat/fma.
Fri, Jun 10
Fri, Jun 10
antiagainst committed rGe90b56e41186: [mlir][vulkan] Add missing '<>' in test IRs to fix test (authored by antiagainst).
[mlir][vulkan] Add missing '<>' in test IRs to fix test
antiagainst committed rG11cf2d5f62f9: [mlir][spirv] Unify aliases of different bitwidth scalar types (authored by antiagainst).
[mlir][spirv] Unify aliases of different bitwidth scalar types
Thu, Jun 9
Thu, Jun 9
Nice, thanks for migrating these!
Wed, Jun 8
Wed, Jun 8
antiagainst committed rG2dfefe02832a: [mlir][spirv] NFC: fix typo in UnifyAliasedResourcePass pass (authored by antiagainst).
[mlir][spirv] NFC: fix typo in UnifyAliasedResourcePass pass
Tue, Jun 7
Tue, Jun 7
antiagainst updated the diff for D127266: [mlir][spirv] Unify aliases of different bitwidth scalar types.
Fix order
antiagainst requested review of D127266: [mlir][spirv] Unify aliases of different bitwidth scalar types.
antiagainst requested review of D127265: [mlir][spirv] NFC: fix typo in UnifyAliasedResourcePass pass.
Mon, Jun 6
Mon, Jun 6
May 25 2022
May 25 2022
antiagainst committed rGe0ea1fc6f8aa: [mlir][spirv] Fix capability check for 64-bit element types (authored by antiagainst).
[mlir][spirv] Fix capability check for 64-bit element types
antiagainst committed rG413fbb045d71: [mlir][scf] Retain existing attributes in scf.for transforms (authored by antiagainst).
[mlir][scf] Retain existing attributes in scf.for transforms
May 24 2022
May 24 2022
antiagainst added a reviewer for D126320: [mlir][scf] Retain existing attributes in scf.for transforms: mravishankar.
antiagainst requested review of D126320: [mlir][scf] Retain existing attributes in scf.for transforms.
antiagainst added a reviewer for D126256: [mlir][spirv] Fix capability check for 64-bit element types: mravishankar.
May 23 2022
May 23 2022
antiagainst requested review of D126256: [mlir][spirv] Fix capability check for 64-bit element types.
antiagainst updated the diff for D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
Fix func.func
antiagainst updated the summary of D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
antiagainst added inline comments to D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
antiagainst updated the diff for D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
Remove vector.fma generation
Nice, thanks for this, Thomas!
Not needed anymore.
May 19 2022
May 19 2022
antiagainst updated the diff for D126004: [mlir][vector] Canonicalize contract to fma when possible.
Fix return value
antiagainst requested review of D126004: [mlir][vector] Canonicalize contract to fma when possible.
Apr 28 2022
Apr 28 2022
antiagainst committed rGbbffece3835d: [mlir][spirv] Remove layout decoration on unneeded storage classes (authored by antiagainst).
[mlir][spirv] Remove layout decoration on unneeded storage classes
antiagainst committed rG8854b736065c: [mlir][spirv] Convert memref.alloca to spv.Variable (authored by antiagainst).
[mlir][spirv] Convert memref.alloca to spv.Variable
Apr 27 2022
Apr 27 2022
antiagainst requested review of D124543: [mlir][spirv] Remove layout decoration on unneeded storage classes.
antiagainst requested review of D124542: [mlir][spirv] Convert memref.alloca to spirv.Variable.
antiagainst committed rGd137c05fc9a3: [mlir][spirv] Add conversion from vector.reduction (authored by antiagainst).
[mlir][spirv] Add conversion from vector.reduction
antiagainst added inline comments to D124380: [mlir][spirv] Add conversion from vector.reduction.
antiagainst committed rG38e802a09de6: [mlir][spirv] Allow converting from index type in unsigned ops (authored by antiagainst).
[mlir][spirv] Allow converting from index type in unsigned ops
Apr 26 2022
Apr 26 2022
antiagainst requested review of D124451: [mlir][spirv] Allow converting from index type in unsigned ops.
Apr 25 2022
Apr 25 2022
antiagainst updated the summary of D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
antiagainst updated the diff for D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
Update to fix another invalid case
antiagainst requested review of D124380: [mlir][spirv] Add conversion from vector.reduction.
Apr 22 2022
Apr 22 2022
antiagainst committed rG6f28fd0bf7f8: [mlir][vector] Fold 1-element reduction into extract or arith ops (authored by antiagainst).
[mlir][vector] Fold 1-element reduction into extract or arith ops
antiagainst added a reviewer for D124207: [MLIR] introduce and use add_mlir_{tool,executable} variants: rriddle.
antiagainst added inline comments to D124129: [mlir][vector] Fold one-element reduction into extract.