♟ antiagainst

Thanks for fixing this!

[mlir][spirv] Define spv.GLSL.Fma and add lowerings

In D94896#2504223, @ergawy wrote:

I couldn't find any place that filters on signed ops. If there is any such place please let me know.

[mlir][linalg] Support generating builders for named op attributes

[mlir][linalg] Add docstring support for named op spec

[mlir][linalg] Use attributes in named ops' indexing maps

Not ready for review yet.

Update commit message

[mlir][spirv] NFC: split deserialization into multiple source files

Thanks for fixing this!

Reland "[mlir][linalg] Support parsing attributes in named op spec"

In D94240#2491177, @mehdi_amini wrote:

Sorry I had to revert in 110775809ad1 as it broke the gcc-5 build (which has been broken for hours by another change that just got reverted, so I didn't want to lose more coverage right now and need to get it back green ASAP).

Oh, right. Didn't notice that. :)

[mlir][spirv] NFC: place ops in the proper file for their categories

In D94360#2489436, @ergawy wrote:

Nice! Actually last Friday I was looking into seeing whether doing the same would be beneficial for SPIRVOps.cpp. Using -ftime-trace shows that it takes ~19 seconds to cleanly compile it. Most of that time ~13 is spent in the backend. So I guess parallelized compilation can be beneficial here as well. If you aren't planning to do that already, I can split it.

[mlir][linalg] Support permutation when lowering to loop nests

[mlir][linalg] Support parsing attributes in named op spec

Awesome! I just have a few nits left now. Marked as blocking because we need to avoid change Clang code.

[mlir][spirv] Replace SPIRVOpLowering with OpConversionPattern

Looks much better. Thanks for cleaning it up!!

Add support for vector attributes

In D94240#2484860, @mehdi_amini wrote:

Not specific to this revision, but is there a documentation for the .tc? (I don't see docs being updated here)

[mlir][spirv] Update pass docs

Add accidentially deleted commit

Just two remaining nits. Feel free to land after fixing them.

Thanks for the contribution and sorry about the delay; I was out of office for quite some time. :)

This looks awesome! Thanks so much! Just one request.

[mlir][spirv] De-template serialization

[mlir][spirv] De-template deserialization

[mlir][spirv] NFC: rename SPIR-V conversion files for consistency

[mlir][spirv] Create a pass for testing SCFToSPIRV patterns

[mlir][spirv] Convert functions returning one value

antiagainst (Lei Zhang)
User

Projects

User Details

Recent Activity
View All

Yesterday

Wed, Jan 20

Tue, Jan 19

Fri, Jan 15

Thu, Jan 14

Wed, Jan 13

Tue, Jan 12

Mon, Jan 11

Sun, Jan 10

Sat, Jan 9

Fri, Jan 8

Thu, Jan 7

Wed, Jan 6

Tue, Jan 5

Wed, Dec 23

Dec 18 2020

antiagainst (Lei Zhang)User