Page MenuHomePhabricator
People antiagainst

antiagainst (Lei Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 24 2019, 5:47 AM (169 w, 4 d)

Recent Activity
View All

Wed, Mar 22

antiagainst accepted D146597: [mlir][arith] Add `sitofp` support to WIE.

Nice, thanks!

Wed, Mar 22, 3:06 PM · Restricted Project, Restricted Project
antiagainst accepted D146606: [mlir][arith] Add `uitofp` support to WIE.
Wed, Mar 22, 2:56 PM · Restricted Project, Restricted Project

Fri, Mar 17

antiagainst accepted D146307: [mlir][spirv] Allow vectors of index types in elementwise conversions.
Fri, Mar 17, 10:17 AM · Restricted Project, Restricted Project

Wed, Mar 15

antiagainst committed rG59e4fbfcd064: [mlir][memref] Fold subview into GPU subgroup MMA load/store ops (authored by antiagainst).
[mlir][memref] Fold subview into GPU subgroup MMA load/store ops
Wed, Mar 15, 10:59 AM · Restricted Project, Restricted Project
antiagainst closed D146150: [mlir][memref] Fold subview into GPU subgroup MMA load/store ops.
Wed, Mar 15, 10:58 AM · Restricted Project, Restricted Project
antiagainst added inline comments to D146150: [mlir][memref] Fold subview into GPU subgroup MMA load/store ops.
Wed, Mar 15, 10:39 AM · Restricted Project, Restricted Project
antiagainst updated the summary of D146150: [mlir][memref] Fold subview into GPU subgroup MMA load/store ops.
Wed, Mar 15, 10:38 AM · Restricted Project, Restricted Project
antiagainst updated the diff for D146150: [mlir][memref] Fold subview into GPU subgroup MMA load/store ops.

Address comments

Wed, Mar 15, 10:36 AM · Restricted Project, Restricted Project
antiagainst added inline comments to D146150: [mlir][memref] Fold subview into GPU subgroup MMA load/store ops.
Wed, Mar 15, 9:19 AM · Restricted Project, Restricted Project
antiagainst requested review of D146150: [mlir][memref] Fold subview into GPU subgroup MMA load/store ops.
Wed, Mar 15, 9:12 AM · Restricted Project, Restricted Project

Tue, Mar 14

antiagainst committed rG141b7d49a3a4: [mlir][spirv] Fix UnifyAliasedResourcePass for 64-bit index (authored by antiagainst).
[mlir][spirv] Fix UnifyAliasedResourcePass for 64-bit index
Tue, Mar 14, 4:55 PM · Restricted Project, Restricted Project
antiagainst closed D145079: [mlir][spirv] Fix UnifyAliasedResourcePass for 64-bit index.
Tue, Mar 14, 4:54 PM · Restricted Project, Restricted Project
antiagainst added inline comments to D145079: [mlir][spirv] Fix UnifyAliasedResourcePass for 64-bit index.
Tue, Mar 14, 4:47 PM · Restricted Project, Restricted Project
antiagainst added inline comments to D146080: [mlir][spirv] Fix scf.yield pattern conversion.
Tue, Mar 14, 3:09 PM · Restricted Project, Restricted Project
antiagainst accepted D146077: [mlir][spirv][NFC] Clean up scf-to-spirv pass.
Tue, Mar 14, 3:05 PM · Restricted Project, Restricted Project
antiagainst accepted D146080: [mlir][spirv] Fix scf.yield pattern conversion.
Tue, Mar 14, 3:04 PM · Restricted Project, Restricted Project

Fri, Mar 10

antiagainst accepted D145760: [mlir][spirv][vector] Add pattern to convert reduction to SPIR-V dot prod.

Awesome!

Fri, Mar 10, 10:42 AM · Restricted Project, Restricted Project

Mon, Mar 6

antiagainst accepted D145423: [mlir][arith] Canonicalize `addi(x, muli(y, -1))` -> `subi(x, y)`.

Thanks!

Mon, Mar 6, 2:48 PM · Restricted Project, Restricted Project

Wed, Mar 1

antiagainst accepted D145090: [mlir][spirv] Support shaped types with index element.

Nice, thanks for fixing this!

Wed, Mar 1, 11:02 AM · Restricted Project, Restricted Project
antiagainst requested review of D145079: [mlir][spirv] Fix UnifyAliasedResourcePass for 64-bit index.
Wed, Mar 1, 9:41 AM · Restricted Project, Restricted Project

Sun, Feb 26

antiagainst committed rG85365b16c8c3: [mlir][spirv] Fix Physical32/Physical64 support for OpenCL (authored by antiagainst).
[mlir][spirv] Fix Physical32/Physical64 support for OpenCL
Sun, Feb 26, 10:41 PM · Restricted Project, Restricted Project
antiagainst closed D144827: [mlir][spirv] Fix Physical32/Physical64 support for OpenCL.
Sun, Feb 26, 10:40 PM · Restricted Project, Restricted Project
antiagainst committed rG9a4c768a7d83: [mlir][spirv] Respect client API requirements for 64-bit index (authored by antiagainst).
[mlir][spirv] Respect client API requirements for 64-bit index
Sun, Feb 26, 10:22 PM · Restricted Project, Restricted Project
antiagainst closed D144819: [mlir][spirv] Respect client API requirements for 64-bit index.
Sun, Feb 26, 10:22 PM · Restricted Project, Restricted Project
antiagainst added inline comments to D144819: [mlir][spirv] Respect client API requirements for 64-bit index.
Sun, Feb 26, 10:12 PM · Restricted Project, Restricted Project
antiagainst added a comment to D144827: [mlir][spirv] Fix Physical32/Physical64 support for OpenCL.
In D144827#4153899, @kuhar wrote:

The patch LGTM, but I have a design question: have you considered moving PhysicalXY from the module level to target env? I understand that this follows SPIR-V proper, but what do we gain much by keeping those separate?

Sun, Feb 26, 3:08 PM · Restricted Project, Restricted Project
antiagainst added inline comments to D144819: [mlir][spirv] Respect client API requirements for 64-bit index.
Sun, Feb 26, 2:36 PM · Restricted Project, Restricted Project
antiagainst committed rG80bb9477a973: [mlir] NFC: Prepare GPUToSPIRV tests for supporting 64bit index (authored by antiagainst).
[mlir] NFC: Prepare GPUToSPIRV tests for supporting 64bit index
Sun, Feb 26, 2:14 PM · Restricted Project, Restricted Project
antiagainst closed D144826: [mlir] NFC: Prepare GPUToSPIRV tests for supporting 64bit index.
Sun, Feb 26, 2:13 PM · Restricted Project, Restricted Project
antiagainst requested review of D144827: [mlir][spirv] Fix Physical32/Physical64 support for OpenCL.
Sun, Feb 26, 8:02 AM · Restricted Project, Restricted Project
antiagainst updated the diff for D144819: [mlir][spirv] Respect client API requirements for 64-bit index.

Rebase

Sun, Feb 26, 7:32 AM · Restricted Project, Restricted Project
antiagainst requested review of D144826: [mlir] NFC: Prepare GPUToSPIRV tests for supporting 64bit index.
Sun, Feb 26, 7:31 AM · Restricted Project, Restricted Project

Sat, Feb 25

antiagainst requested review of D144819: [mlir][spirv] Respect client API requirements for 64-bit index.
Sat, Feb 25, 10:24 PM · Restricted Project, Restricted Project

Fri, Feb 24

antiagainst planned changes to D107846: [mlir] Graduate op availability to OpBase.td.
Fri, Feb 24, 2:12 PM · Restricted Project, Restricted Project
antiagainst planned changes to D133872: [mlir][tensor] Add pattern to extract from insert_slice destination.
Fri, Feb 24, 2:12 PM · Restricted Project, Restricted Project
antiagainst planned changes to D133873: [mlir][tensor] Add pattern to hoist extract/insert slice ops.
Fri, Feb 24, 2:12 PM · Restricted Project, Restricted Project
antiagainst planned changes to D135546: [mlir][vector] Simplify vector transfer hoisting logic.
Fri, Feb 24, 2:11 PM · Restricted Project, Restricted Project
antiagainst accepted D144725: [mlir][SPIRV] Enable use of opaque-pointers in spirv-cpu-runner.
Fri, Feb 24, 8:09 AM · Restricted Project, Restricted Project
antiagainst accepted D144460: [mlir][GPUToVulkan] Port conversion passes and `mlir-vulkan-runner` to opaque pointers.

Thanks for plumbing this through!

Fri, Feb 24, 8:09 AM · Restricted Project, Restricted Project

Feb 16 2023

antiagainst added a comment to D144113: [mlir][vectorToGPU] Fix type used when folding transpose into read op.

To close the loop: https://reviews.llvm.org/D144159 landed for improving the accessor methods.

Feb 16 2023, 11:05 AM · Restricted Project, Restricted Project

Feb 15 2023

antiagainst committed rGa1aad28d297a: [mlir][vector] NFC: Improve vector type accessor methods (authored by antiagainst).
[mlir][vector] NFC: Improve vector type accessor methods
Feb 15 2023, 8:12 PM · Restricted Project, Restricted Project
antiagainst closed D144159: [mlir][vector] Improve vector type accessor methods.
Feb 15 2023, 8:11 PM · Restricted Project, Restricted Project
antiagainst added a comment to D144159: [mlir][vector] Improve vector type accessor methods.
In D144159#4130931, @ThomasRaoux wrote:

please mark it as NFC

Feb 15 2023, 8:09 PM · Restricted Project, Restricted Project
antiagainst requested review of D144159: [mlir][vector] Improve vector type accessor methods.
Feb 15 2023, 7:05 PM · Restricted Project, Restricted Project
antiagainst committed rG78e172fc92e7: [mlir][spirv] Support i32 memref.atomic_rmw conversion (authored by antiagainst).
[mlir][spirv] Support i32 memref.atomic_rmw conversion
Feb 15 2023, 9:54 AM · Restricted Project, Restricted Project
antiagainst closed D143952: [mlir][spirv] Support i32 memref.atomic_rmw conversion.
Feb 15 2023, 9:54 AM · Restricted Project, Restricted Project
antiagainst added a comment to D144113: [mlir][vectorToGPU] Fix type used when folding transpose into read op.

IMO, the accessor name could use some improvements---it's very confusing and error-prone just being getVectorType(); making it something like getSrcVectorType() would make it far easier to avoid pitfalls. At least for me, I need to read the impl to double check what it means by just getVectorType().

Feb 15 2023, 9:53 AM · Restricted Project, Restricted Project

Feb 14 2023

antiagainst accepted D144043: [mlir][spirv] Validate float type bitwidths.
Feb 14 2023, 2:46 PM · Restricted Project, Restricted Project
antiagainst accepted D144039: [mlir][spirv] Fix crash when decorating physical storage buffer pointers.
Feb 14 2023, 1:10 PM · Restricted Project, Restricted Project

Feb 13 2023

antiagainst requested review of D143952: [mlir][spirv] Support i32 memref.atomic_rmw conversion.
Feb 13 2023, 2:38 PM · Restricted Project, Restricted Project
antiagainst accepted D143801: [mlir][arith] Fold selection over constant vector conditions.
Feb 13 2023, 10:09 AM · Restricted Project, Restricted Project
antiagainst accepted D143900: [mlir][SPIRVToLLVM] Add pass option to emit opaque-pointers.

Nice, thanks!

Feb 13 2023, 10:07 AM · Restricted Project, Restricted Project
antiagainst accepted D143922: [mlir][gpu] Add support for unsigned integer extend in vector to gpu.subgroup_mma lowering.

LG, thanks!

Feb 13 2023, 10:05 AM · Restricted Project, Restricted Project

Feb 11 2023

antiagainst accepted D143777: [mlir][spirv] Drop outdated TODO comment.
Feb 11 2023, 9:11 AM · Restricted Project, Restricted Project

Feb 1 2023

antiagainst committed rG2c46051aa9d3: [mlir][spirv] Fix vector type mismatch in UnifyAliasedResourcePass (authored by antiagainst).
[mlir][spirv] Fix vector type mismatch in UnifyAliasedResourcePass
Feb 1 2023, 12:27 PM · Restricted Project, Restricted Project
antiagainst closed D143042: [mlir][spirv] Fix vector type mismatch in UnifyAliasedResourcePass.
Feb 1 2023, 12:26 PM · Restricted Project, Restricted Project

Jan 31 2023

antiagainst updated the diff for D143042: [mlir][spirv] Fix vector type mismatch in UnifyAliasedResourcePass.

Update

Jan 31 2023, 6:42 PM · Restricted Project, Restricted Project
antiagainst requested review of D143042: [mlir][spirv] Fix vector type mismatch in UnifyAliasedResourcePass.
Jan 31 2023, 6:14 PM · Restricted Project, Restricted Project

Jan 30 2023

antiagainst accepted D142922: [mlir][vector] Add folder for bitcast of integer splat constants.
Jan 30 2023, 4:34 PM · Restricted Project, Restricted Project
antiagainst committed rGd3ddbe153e4c: [mlir][vector] Clarify vector.contract promotion behavior (authored by antiagainst).
[mlir][vector] Clarify vector.contract promotion behavior
Jan 30 2023, 4:09 PM · Restricted Project, Restricted Project
antiagainst closed D142915: [mlir][vector] Clarify vector.contract promotion behavior.
Jan 30 2023, 4:08 PM · Restricted Project, Restricted Project
antiagainst retitled D142915: [mlir][vector] Clarify vector.contract promotion behavior from [mlir][vector] Clarify integer vector.contract promotion behavior to [mlir][vector] Clarify vector.contract promotion behavior.
Jan 30 2023, 3:11 PM · Restricted Project, Restricted Project
antiagainst updated the summary of D142915: [mlir][vector] Clarify vector.contract promotion behavior.
Jan 30 2023, 3:11 PM · Restricted Project, Restricted Project
antiagainst updated the diff for D142915: [mlir][vector] Clarify vector.contract promotion behavior.

Address comments

Jan 30 2023, 3:02 PM · Restricted Project, Restricted Project
antiagainst updated the diff for D142915: [mlir][vector] Clarify vector.contract promotion behavior.

Grammar

Jan 30 2023, 11:18 AM · Restricted Project, Restricted Project
antiagainst added inline comments to D142915: [mlir][vector] Clarify vector.contract promotion behavior.
Jan 30 2023, 11:18 AM · Restricted Project, Restricted Project
antiagainst updated the diff for D142915: [mlir][vector] Clarify vector.contract promotion behavior.

Address comments

Jan 30 2023, 11:18 AM · Restricted Project, Restricted Project
antiagainst requested review of D142915: [mlir][vector] Clarify vector.contract promotion behavior.
Jan 30 2023, 10:44 AM · Restricted Project, Restricted Project

Jan 28 2023

antiagainst accepted D142810: [mlir][gpu][spirv] Gpu min/max reductions lowering to SPIR-V.
Jan 28 2023, 5:08 PM · Restricted Project, Restricted Project

Jan 23 2023

antiagainst committed rGb41eb9601cf1: [mlir][spirv] Move uint asm name test to the proper place (authored by antiagainst).
[mlir][spirv] Move uint asm name test to the proper place
Jan 23 2023, 11:09 AM · Restricted Project, Restricted Project
antiagainst added inline comments to D142295: [mlir] support unsigned int in mlir::spirv::ConstantOp::getAsmResultNames.
Jan 23 2023, 11:09 AM · Restricted Project, Restricted Project
antiagainst added inline comments to D142295: [mlir] support unsigned int in mlir::spirv::ConstantOp::getAsmResultNames.
Jan 23 2023, 10:51 AM · Restricted Project, Restricted Project

Jan 19 2023

antiagainst accepted D142105: [mlir] Update VectorToGPU to new memory space.
Jan 19 2023, 9:07 AM · Restricted Project, Restricted Project

Jan 17 2023

antiagainst added a comment to D141856: Fix crash in Spirv -lower-host-to-llvm pass.

Nice, thanks Mehdi!

Jan 17 2023, 9:59 AM · Restricted Project, Restricted Project

Jan 13 2023

antiagainst accepted D141695: [mlir][spirv] Fix crash in spirv-lower-abi-attributes.
Jan 13 2023, 7:51 AM · Restricted Project, Restricted Project

Jan 12 2023

antiagainst accepted D141615: [mlir][arith][spirv] Add missing fptoui conversion.
Jan 12 2023, 8:33 AM · Restricted Project, Restricted Project

Jan 11 2023

antiagainst accepted D141524: [mlir][spirv] Migrate to new fold API.
Jan 11 2023, 10:54 AM · Restricted Project, Restricted Project

Jan 9 2023

antiagainst committed rG84ce59a0e4e4: [mlir][spirv] Fix MLIR code snippet marker in TD files (authored by antiagainst).
[mlir][spirv] Fix MLIR code snippet marker in TD files
Jan 9 2023, 12:59 PM · Restricted Project, Restricted Project
antiagainst closed D141316: [mlir][spirv] Fix MLIR code snippet marker in TD files.
Jan 9 2023, 12:58 PM · Restricted Project, Restricted Project
antiagainst requested review of D141316: [mlir][spirv] Fix MLIR code snippet marker in TD files.
Jan 9 2023, 12:26 PM · Restricted Project, Restricted Project
antiagainst accepted D141292: [mlir][spirv] Account for type conversion failures in scf-to-spirv.
Jan 9 2023, 8:34 AM · Restricted Project, Restricted Project

Jan 6 2023

antiagainst accepted D141163: [mlir][spirv] Add folder for LogicalNotEqual.
Jan 6 2023, 3:11 PM · Restricted Project, Restricted Project
antiagainst accepted D141159: [mlir][spirv] Clean up transform pass definitions. NFC..

Thanks for the cleanup!

Jan 6 2023, 1:54 PM · Restricted Project, Restricted Project

Jan 5 2023

antiagainst accepted D141096: [mlir][spirv] Add smul_extended expansion for WebGPU.
Jan 5 2023, 4:42 PM · Restricted Project, Restricted Project
antiagainst accepted D141085: [mlir][spirv] Fix extended umul expansion for WebGPU.

nice, thanks for fixing it!

Jan 5 2023, 2:10 PM · Restricted Project, Restricted Project

Jan 4 2023

antiagainst accepted D140995: [mlir][spirv] Add pattern to expand UMulExtended for WebGPU.
Jan 4 2023, 9:19 AM · Restricted Project, Restricted Project

Dec 30 2022

antiagainst accepted D140576: [mlir][gpu][spirv] Lower gpu reduction ops to spirv.
Dec 30 2022, 8:29 AM · Restricted Project, Restricted Project

Dec 29 2022

antiagainst committed rG56c069887b95: [mlir][spirv] Fail vector.bitcast conversion with different bitwidth (authored by antiagainst).
[mlir][spirv] Fail vector.bitcast conversion with different bitwidth
Dec 29 2022, 3:44 PM · Restricted Project, Restricted Project
antiagainst closed D140437: [mlir][spirv] Fail vector.bitcast conversion with different bitwidth.
Dec 29 2022, 3:44 PM · Restricted Project, Restricted Project
antiagainst added inline comments to D140644: [mlir][gpu] Migrate hard-coded address space integers to an enum attribute (gpu::AddressSpaceAttr).
Dec 29 2022, 3:43 PM · Restricted Project, Restricted Project
antiagainst requested changes to D140576: [mlir][gpu][spirv] Lower gpu reduction ops to spirv.

Nice! Just a few nits.

Dec 29 2022, 3:22 PM · Restricted Project, Restricted Project
antiagainst accepted D139866: [mlir][ROCDL] Translate known block size attributes to ROCDL.
Dec 29 2022, 3:11 PM · Restricted Project, Restricted Project
antiagainst accepted D140766: Re-land D139865 "Add known_block_size and known_grid_size to gpu.func".
Dec 29 2022, 3:09 PM · Restricted Project, Restricted Project

Dec 22 2022

antiagainst committed rG1a0453eb44cd: [mlir][vector] Fix bug in extractOp folding (authored by ThomasRaoux).
[mlir][vector] Fix bug in extractOp folding
Dec 22 2022, 2:54 PM · Restricted Project, Restricted Project
antiagainst closed D140533: [mlir][vector] Fix bug in extractOp folding.
Dec 22 2022, 2:53 PM · Restricted Project, Restricted Project
antiagainst accepted D139865: [mlir][GPU] Add known_block_size and known_grid_size to gpu.func.
Dec 22 2022, 12:29 PM · Restricted Project, Restricted Project
antiagainst committed rGc03fe1ebbd8e: [mlir][spirv] Add StreamingInterfaceINTEL to SPIRVBase.td (authored by mmendell).
[mlir][spirv] Add StreamingInterfaceINTEL to SPIRVBase.td
Dec 22 2022, 10:28 AM · Restricted Project, Restricted Project
antiagainst added a comment to D140476: [mlir][spirv] Add StreamingInterfaceINTEL to mlir SPIRVBase.td.

Should this be set somewhere in Phabricator?

Dec 22 2022, 10:28 AM · Restricted Project, Restricted Project
antiagainst closed D140476: [mlir][spirv] Add StreamingInterfaceINTEL to mlir SPIRVBase.td.
Dec 22 2022, 10:28 AM · Restricted Project, Restricted Project
antiagainst added a comment to D140476: [mlir][spirv] Add StreamingInterfaceINTEL to mlir SPIRVBase.td.
In D140476#4013091, @mmendell wrote:

I am unable to commit this. Can someone please do so?

Dec 22 2022, 10:15 AM · Restricted Project, Restricted Project