- User Since
- Dec 24 2019, 5:47 AM (39 w, 2 d)
Thanks for the fix!
Fri, Sep 18
Looks good to me. Thanks for fixing this!
Thu, Sep 10
Wed, Sep 9
Can we add a test for it in slicing-utils.mlir?
Fri, Sep 4
Thu, Sep 3
Sure thing. Happy to do that. Thanks for the contribution!
Done. Thanks for the contribution! :)
Wed, Sep 2
FYI: this change fails the following tests:
Tue, Sep 1
My only concern with that is that this is compiler dependent. (for instance visual studio doesn't use this notation). Are you suggesting handling this with a ifdef to deal with different compilers? That's what I was trying to avoid.
Aug 11 2020
Sorry for the delay! For future patches, please feel free to land once you've gotten Mahesh's approval; no need to wait for mine.
Aug 6 2020
Cool, thanks for the contribution!
Aug 5 2020
Aug 4 2020
Awesome, great to see that you are interested in bring up the OpenCL conversion path! :)
This looks awesome! Sorry about the delay... LGTM; just a few nits. I see River has comments so would be good to get his consent too.
LGTM for SPIR-V side.
Jul 28 2020
Jul 25 2020
Jul 24 2020
Jul 23 2020
Awesome! Can we also support (de)serialization for this?
Jul 22 2020
Jul 20 2020
Jul 16 2020
Jul 15 2020
This is awesome doc! Thanks George!
Jul 13 2020
Looks to me #include <optional> is not really needed. Removed it via https://github.com/llvm/llvm-project/commit/9cafbf8f66c9596d8b31293830d8892db0837745.
FYI: this breaks MLIR's buildbot https://buildkite.com/mlir/mlir-core/builds/6347#749c8761-2489-490e-bde9-edc50ea9207c