Page MenuHomePhabricator

antiagainst (Lei Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 24 2019, 5:47 AM (56 w, 3 d)

Recent Activity

Yesterday

antiagainst accepted D95120: [mlir][StandardToSPIRV] Add support for lowering uitofp to SPIR-V.
Thu, Jan 21, 2:10 PM · Restricted Project
antiagainst requested changes to D95120: [mlir][StandardToSPIRV] Add support for lowering uitofp to SPIR-V.
Thu, Jan 21, 5:44 AM · Restricted Project

Wed, Jan 20

antiagainst accepted D95098: [mlir]][SPIRV] Define OrderedOp and UnorderedOp and add lowerings from Standard..

Thanks for fixing this!

Wed, Jan 20, 3:03 PM · Restricted Project
antiagainst accepted D95097: [mlir][SPIRV] Rename OpSpecConstantOperation -> OpSpecConstantOp.
Wed, Jan 20, 3:02 PM · Restricted Project

Tue, Jan 19

antiagainst committed rG3a56a96664de: [mlir][spirv] Define spv.GLSL.Fma and add lowerings (authored by antiagainst).
[mlir][spirv] Define spv.GLSL.Fma and add lowerings
Tue, Jan 19, 6:18 AM
antiagainst closed D94965: [mlir][spirv] Define spv.GLSL.Fma and add lowerings.
Tue, Jan 19, 6:18 AM · Restricted Project
antiagainst added inline comments to D94965: [mlir][spirv] Define spv.GLSL.Fma and add lowerings.
Tue, Jan 19, 6:13 AM · Restricted Project
antiagainst added reviewers for D94966: [mlir][linalg] Define a depthwise 2-D convolution op: mravishankar, hanchung.
Tue, Jan 19, 5:10 AM · Restricted Project
antiagainst requested review of D94966: [mlir][linalg] Define a depthwise 2-D convolution op.
Tue, Jan 19, 5:09 AM · Restricted Project
antiagainst added reviewers for D94965: [mlir][spirv] Define spv.GLSL.Fma and add lowerings: hanchung, ThomasRaoux.
Tue, Jan 19, 5:08 AM · Restricted Project
antiagainst requested review of D94965: [mlir][spirv] Define spv.GLSL.Fma and add lowerings.
Tue, Jan 19, 5:08 AM · Restricted Project
antiagainst accepted D94896: [MLIR][SPIRV] Add `SignedOp` trait..
Tue, Jan 19, 4:36 AM · Restricted Project
antiagainst added a comment to D94896: [MLIR][SPIRV] Add `SignedOp` trait..

I couldn't find any place that filters on signed ops. If there is any such place please let me know.

Tue, Jan 19, 4:36 AM · Restricted Project

Fri, Jan 15

antiagainst committed rG0acc260b574e: [mlir][linalg] Support generating builders for named op attributes (authored by antiagainst).
[mlir][linalg] Support generating builders for named op attributes
Fri, Jan 15, 6:01 AM
antiagainst closed D94733: [mlir][linalg] Support generating builders for named op attributes.
Fri, Jan 15, 6:00 AM · Restricted Project

Thu, Jan 14

antiagainst added reviewers for D94733: [mlir][linalg] Support generating builders for named op attributes: nicolasvasilache, mravishankar, hanchung.
Thu, Jan 14, 4:58 PM · Restricted Project
antiagainst requested review of D94733: [mlir][linalg] Support generating builders for named op attributes.
Thu, Jan 14, 4:57 PM · Restricted Project
antiagainst committed rG6b9fa8a50d0f: [mlir][linalg] Add docstring support for named op spec (authored by antiagainst).
[mlir][linalg] Add docstring support for named op spec
Thu, Jan 14, 6:58 AM
antiagainst closed D94548: [mlir][linalg] Add docstring support for named op spec.
Thu, Jan 14, 6:58 AM · Restricted Project

Wed, Jan 13

antiagainst committed rG3bc7555ffac0: [mlir][linalg] Use attributes in named ops' indexing maps (authored by antiagainst).
[mlir][linalg] Use attributes in named ops' indexing maps
Wed, Jan 13, 7:08 AM
antiagainst closed D94335: [mlir][linalg] Use attributes in named ops' indexing maps.
Wed, Jan 13, 7:08 AM · Restricted Project
antiagainst updated the diff for D94548: [mlir][linalg] Add docstring support for named op spec.

Fix typos

Wed, Jan 13, 7:03 AM · Restricted Project
antiagainst updated the diff for D94335: [mlir][linalg] Use attributes in named ops' indexing maps.

Address comments

Wed, Jan 13, 7:03 AM · Restricted Project

Tue, Jan 12

antiagainst added reviewers for D94548: [mlir][linalg] Add docstring support for named op spec: mravishankar, hanchung.
Tue, Jan 12, 1:11 PM · Restricted Project
antiagainst abandoned D94549: [mlir][linalg] Define a depthwise 2-D convolution op.

Not ready for review yet.

Tue, Jan 12, 1:10 PM · Restricted Project
antiagainst requested review of D94549: [mlir][linalg] Define a depthwise 2-D convolution op.
Tue, Jan 12, 1:07 PM · Restricted Project
antiagainst updated the diff for D94548: [mlir][linalg] Add docstring support for named op spec.

Rebase

Tue, Jan 12, 1:02 PM · Restricted Project
antiagainst updated the diff for D94335: [mlir][linalg] Use attributes in named ops' indexing maps.

Add doc

Tue, Jan 12, 1:02 PM · Restricted Project
antiagainst added a reviewer for D94548: [mlir][linalg] Add docstring support for named op spec: nicolasvasilache.
Tue, Jan 12, 12:56 PM · Restricted Project
antiagainst requested review of D94548: [mlir][linalg] Add docstring support for named op spec.
Tue, Jan 12, 12:54 PM · Restricted Project
antiagainst retitled D94335: [mlir][linalg] Use attributes in named ops' indexing maps from [mlir][linalg] Use attributes in indexing maps to [mlir][linalg] Use attributes in named ops' indexing maps.
Tue, Jan 12, 8:32 AM · Restricted Project
antiagainst updated the diff for D94335: [mlir][linalg] Use attributes in named ops' indexing maps.

Update commit message

Tue, Jan 12, 8:31 AM · Restricted Project
antiagainst committed rG8349fa0fdd3a: [mlir][spirv] NFC: split deserialization into multiple source files (authored by antiagainst).
[mlir][spirv] NFC: split deserialization into multiple source files
Tue, Jan 12, 8:22 AM
antiagainst closed D94360: [mlir][spirv] NFC: split deserialization into multiple source files.
Tue, Jan 12, 8:22 AM · Restricted Project
antiagainst added a comment to D94407: [mlir] Fix for LIT tests.

Thanks for fixing this!

Tue, Jan 12, 8:09 AM · Restricted Project
antiagainst committed rG4086072f8a92: Reland "[mlir][linalg] Support parsing attributes in named op spec" (authored by antiagainst).
Reland "[mlir][linalg] Support parsing attributes in named op spec"
Tue, Jan 12, 8:00 AM
antiagainst added a comment to D94240: [mlir][linalg] Support parsing attributes in named op spec.

Sorry I had to revert in 110775809ad1 as it broke the gcc-5 build (which has been broken for hours by another change that just got reverted, so I didn't want to lose more coverage right now and need to get it back green ASAP).

Tue, Jan 12, 7:58 AM · Restricted Project
antiagainst abandoned D94497: [mlir] Define inline functions in headers as static.
Tue, Jan 12, 7:49 AM · Restricted Project
antiagainst added a comment to D94497: [mlir] Define inline functions in headers as static.

Oh, right. Didn't notice that. :)

Tue, Jan 12, 7:47 AM · Restricted Project
antiagainst added a reviewer for D94497: [mlir] Define inline functions in headers as static: ftynse.
Tue, Jan 12, 7:43 AM · Restricted Project
antiagainst requested review of D94497: [mlir] Define inline functions in headers as static.
Tue, Jan 12, 7:43 AM · Restricted Project
antiagainst committed rG2f7ec77e3cdb: [mlir][spirv] NFC: place ops in the proper file for their categories (authored by antiagainst).
[mlir][spirv] NFC: place ops in the proper file for their categories
Tue, Jan 12, 7:28 AM
antiagainst closed D94413: [mlir][spirv] NFC: place ops in the proper file for their categories.
Tue, Jan 12, 7:28 AM · Restricted Project

Mon, Jan 11

antiagainst added reviewers for D94413: [mlir][spirv] NFC: place ops in the proper file for their categories: hanchung, ThomasRaoux, ergawy.
Mon, Jan 11, 7:02 AM · Restricted Project
antiagainst requested review of D94413: [mlir][spirv] NFC: place ops in the proper file for their categories.
Mon, Jan 11, 7:00 AM · Restricted Project
antiagainst added a comment to D94360: [mlir][spirv] NFC: split deserialization into multiple source files.

Nice! Actually last Friday I was looking into seeing whether doing the same would be beneficial for SPIRVOps.cpp. Using -ftime-trace shows that it takes ~19 seconds to cleanly compile it. Most of that time ~13 is spent in the backend. So I guess parallelized compilation can be beneficial here as well. If you aren't planning to do that already, I can split it.

Mon, Jan 11, 6:16 AM · Restricted Project
antiagainst committed rG55225471d983: [mlir][linalg] Support permutation when lowering to loop nests (authored by antiagainst).
[mlir][linalg] Support permutation when lowering to loop nests
Mon, Jan 11, 6:14 AM
antiagainst closed D91795: [mlir][linalg] Support permutation when lowering to loop nests.
Mon, Jan 11, 6:13 AM · Restricted Project
antiagainst added reviewers for D94360: [mlir][spirv] NFC: split deserialization into multiple source files: hanchung, ergawy, ThomasRaoux.
Mon, Jan 11, 6:12 AM · Restricted Project
antiagainst committed rGdf86f15f0c53: [mlir][linalg] Support parsing attributes in named op spec (authored by antiagainst).
[mlir][linalg] Support parsing attributes in named op spec
Mon, Jan 11, 6:06 AM
antiagainst closed D94240: [mlir][linalg] Support parsing attributes in named op spec.
Mon, Jan 11, 6:06 AM · Restricted Project
antiagainst added inline comments to D94240: [mlir][linalg] Support parsing attributes in named op spec.
Mon, Jan 11, 6:06 AM · Restricted Project

Sun, Jan 10

antiagainst accepted D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..

Awesome, thanks!

Sun, Jan 10, 7:58 AM · Restricted Project, Restricted Project

Sat, Jan 9

antiagainst requested changes to D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..

Awesome! I just have a few nits left now. Marked as blocking because we need to avoid change Clang code.

Sat, Jan 9, 6:32 AM · Restricted Project, Restricted Project
antiagainst requested review of D94360: [mlir][spirv] NFC: split deserialization into multiple source files.
Sat, Jan 9, 6:08 AM · Restricted Project
antiagainst committed rG7c3ae48fe85f: [mlir][spirv] Replace SPIRVOpLowering with OpConversionPattern (authored by antiagainst).
[mlir][spirv] Replace SPIRVOpLowering with OpConversionPattern
Sat, Jan 9, 5:08 AM
antiagainst closed D94080: [mlir][spirv] Replace SPIRVOpLowering with OpConversionPattern.
Sat, Jan 9, 5:08 AM · Restricted Project
antiagainst updated the diff for D94080: [mlir][spirv] Replace SPIRVOpLowering with OpConversionPattern.

Rebase

Sat, Jan 9, 5:04 AM · Restricted Project

Fri, Jan 8

antiagainst accepted D94273: [mlir][ODS] Add a C++ abstraction for OpBuilders.

Looks much better. Thanks for cleaning it up!!

Fri, Jan 8, 1:47 PM · Restricted Project
antiagainst added reviewers for D94335: [mlir][linalg] Use attributes in named ops' indexing maps: hanchung, mravishankar, nicolasvasilache.
Fri, Jan 8, 12:48 PM · Restricted Project
antiagainst requested review of D94335: [mlir][linalg] Use attributes in named ops' indexing maps.
Fri, Jan 8, 12:47 PM · Restricted Project
antiagainst accepted D94288: [MLIR][SPIRV] Add `UsableInSpecConstantOp` trait..

Awesome!

Fri, Jan 8, 5:07 AM · Restricted Project

Thu, Jan 7

antiagainst updated the diff for D94240: [mlir][linalg] Support parsing attributes in named op spec.

Minor fixes

Thu, Jan 7, 1:25 PM · Restricted Project
antiagainst updated the diff for D94240: [mlir][linalg] Support parsing attributes in named op spec.

Minor fixes

Thu, Jan 7, 1:23 PM · Restricted Project
antiagainst updated the diff for D94240: [mlir][linalg] Support parsing attributes in named op spec.

Add support for vector attributes

Thu, Jan 7, 1:18 PM · Restricted Project
antiagainst accepted D94135: [mlir][PDL] Use ODS for defining PDL types.

Looks neat! :)

Thu, Jan 7, 12:06 PM · Restricted Project
antiagainst added a comment to D94240: [mlir][linalg] Support parsing attributes in named op spec.

Not specific to this revision, but is there a documentation for the .tc? (I don't see docs being updated here)

Thu, Jan 7, 11:56 AM · Restricted Project
antiagainst added reviewers for D94240: [mlir][linalg] Support parsing attributes in named op spec: hanchung, nicolasvasilache, mravishankar.
Thu, Jan 7, 9:06 AM · Restricted Project
antiagainst requested review of D94240: [mlir][linalg] Support parsing attributes in named op spec.
Thu, Jan 7, 9:04 AM · Restricted Project
antiagainst accepted D94220: [mlir] NFC: fix trivial typos.
Thu, Jan 7, 8:55 AM · Restricted Project
antiagainst accepted D94179: [mlir] replace LLVM dialect float types with built-ins.
Thu, Jan 7, 8:55 AM · Restricted Project

Wed, Jan 6

antiagainst requested changes to D94179: [mlir] replace LLVM dialect float types with built-ins.
Wed, Jan 6, 8:58 AM · Restricted Project
antiagainst accepted D94178: [mlir] replace LLVMIntegerType with built-in integer type.

Fantastic!!

Wed, Jan 6, 8:20 AM · Restricted Project
antiagainst committed rG25c78de6d2a5: [mlir][spirv] Update pass docs (authored by antiagainst).
[mlir][spirv] Update pass docs
Wed, Jan 6, 7:34 AM
antiagainst closed D94174: [mlir][spirv] Update pass docs.
Wed, Jan 6, 7:34 AM · Restricted Project
antiagainst updated the diff for D94174: [mlir][spirv] Update pass docs.

Add accidentially deleted commit

Wed, Jan 6, 7:27 AM · Restricted Project
antiagainst updated the diff for D94174: [mlir][spirv] Update pass docs.

Address comments

Wed, Jan 6, 7:25 AM · Restricted Project
antiagainst added reviewers for D94174: [mlir][spirv] Update pass docs: hanchung, ThomasRaoux.
Wed, Jan 6, 6:34 AM · Restricted Project
antiagainst requested review of D94174: [mlir][spirv] Update pass docs.
Wed, Jan 6, 6:34 AM · Restricted Project
antiagainst added inline comments to D94080: [mlir][spirv] Replace SPIRVOpLowering with OpConversionPattern.
Wed, Jan 6, 6:01 AM · Restricted Project
antiagainst updated the diff for D94080: [mlir][spirv] Replace SPIRVOpLowering with OpConversionPattern.

Address comments

Wed, Jan 6, 5:59 AM · Restricted Project
antiagainst accepted D94068: [MLIR][SPIRV] Add `UnsignedOp` trait..

Just two remaining nits. Feel free to land after fixing them.

Wed, Jan 6, 4:34 AM · Restricted Project

Tue, Jan 5

antiagainst requested changes to D93591: [MLIR][SPIRV] Add (de-)serialization support for SpecConstantOpeation..

Thanks for the contribution and sorry about the delay; I was out of office for quite some time. :)

Tue, Jan 5, 6:36 AM · Restricted Project, Restricted Project
antiagainst requested changes to D94068: [MLIR][SPIRV] Add `UnsignedOp` trait..

This looks awesome! Thanks so much! Just one request.

Tue, Jan 5, 5:07 AM · Restricted Project
antiagainst added reviewers for D94080: [mlir][spirv] Replace SPIRVOpLowering with OpConversionPattern: hanchung, ThomasRaoux, rriddle.
Tue, Jan 5, 5:00 AM · Restricted Project
antiagainst requested review of D94080: [mlir][spirv] Replace SPIRVOpLowering with OpConversionPattern.
Tue, Jan 5, 4:58 AM · Restricted Project

Wed, Dec 23

antiagainst committed rGfc41777702aa: [mlir][spirv] De-template serialization (authored by antiagainst).
[mlir][spirv] De-template serialization
Wed, Dec 23, 12:00 PM
antiagainst closed D93535: [mlir][spirv] De-template serialization.
Wed, Dec 23, 11:59 AM · Restricted Project
antiagainst committed rGae895ac4b9fa: [mlir][spirv] De-template deserialization (authored by antiagainst).
[mlir][spirv] De-template deserialization
Wed, Dec 23, 11:46 AM
antiagainst closed D93504: [mlir][spirv] De-template deserialization.
Wed, Dec 23, 11:45 AM · Restricted Project
antiagainst committed rG930c74f12d79: [mlir][spirv] NFC: rename SPIR-V conversion files for consistency (authored by antiagainst).
[mlir][spirv] NFC: rename SPIR-V conversion files for consistency
Wed, Dec 23, 11:37 AM
antiagainst closed D93489: [mlir][spirv] NFC: rename SPIR-V conversion files for consistency.
Wed, Dec 23, 11:37 AM · Restricted Project
antiagainst committed rGa16fbff17d32: [mlir][spirv] Create a pass for testing SCFToSPIRV patterns (authored by antiagainst).
[mlir][spirv] Create a pass for testing SCFToSPIRV patterns
Wed, Dec 23, 11:32 AM
antiagainst closed D93488: [mlir][spirv] Create a pass for testing SCFToSPIRV patterns.
Wed, Dec 23, 11:32 AM · Restricted Project
antiagainst added inline comments to D93488: [mlir][spirv] Create a pass for testing SCFToSPIRV patterns.
Wed, Dec 23, 11:17 AM · Restricted Project
antiagainst committed rG42980a789d22: [mlir][spirv] Convert functions returning one value (authored by antiagainst).
[mlir][spirv] Convert functions returning one value
Wed, Dec 23, 10:37 AM
antiagainst closed D93468: [mlir][spirv] Convert functions returning one value.
Wed, Dec 23, 10:37 AM · Restricted Project

Dec 18 2020

antiagainst requested review of D93535: [mlir][spirv] De-template serialization.
Dec 18 2020, 4:59 AM · Restricted Project
antiagainst added reviewers for D93504: [mlir][spirv] De-template deserialization: hanchung, ThomasRaoux.
Dec 18 2020, 4:58 AM · Restricted Project
antiagainst updated the diff for D93504: [mlir][spirv] De-template deserialization.

Fix comments

Dec 18 2020, 4:58 AM · Restricted Project