Page MenuHomePhabricator

antiagainst (Lei Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 24 2019, 5:47 AM (131 w, 6 d)

Recent Activity

Tue, Jun 28

antiagainst accepted D128662: [MLIR][Math] Improve docs for round op (NFC).

Thanks for making this clearer!

Tue, Jun 28, 11:02 AM · Restricted Project, Restricted Project
antiagainst added inline comments to D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
Tue, Jun 28, 10:50 AM · Restricted Project, Restricted Project
antiagainst updated the diff for D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.

Address comments

Tue, Jun 28, 10:47 AM · Restricted Project, Restricted Project
antiagainst committed rGe1e0ecb96e0a: [mlir][spirv] Support more comparisons on boolean values (authored by antiagainst).
[mlir][spirv] Support more comparisons on boolean values
Tue, Jun 28, 9:07 AM · Restricted Project, Restricted Project
antiagainst closed D128692: [mlir][spirv] Support more comparisons on boolean values.
Tue, Jun 28, 9:07 AM · Restricted Project, Restricted Project

Mon, Jun 27

antiagainst requested review of D128692: [mlir][spirv] Support more comparisons on boolean values.
Mon, Jun 27, 5:14 PM · Restricted Project, Restricted Project

Fri, Jun 24

antiagainst added inline comments to D127286: [MLIR][Math] Add round operation.
Fri, Jun 24, 2:07 PM · Restricted Project, Restricted Project

Thu, Jun 23

antiagainst committed rGb2671d8898e9: [mlir][spirv] Fix bitcast input order for UnifyAliasedResourcePass (authored by antiagainst).
[mlir][spirv] Fix bitcast input order for UnifyAliasedResourcePass
Thu, Jun 23, 7:24 PM · Restricted Project, Restricted Project
antiagainst closed D128473: [mlir][spirv] Fix bitcast input order for UnifyAliasedResourcePass.
Thu, Jun 23, 7:24 PM · Restricted Project, Restricted Project
antiagainst requested review of D128473: [mlir][spirv] Fix bitcast input order for UnifyAliasedResourcePass.
Thu, Jun 23, 3:33 PM · Restricted Project, Restricted Project

Wed, Jun 22

antiagainst committed rGefe603e70dec: [mlir][vulkan-runner] fix VK_ERROR_INCOMPATIBLE_DRIVER error (authored by jackalcooper).
[mlir][vulkan-runner] fix VK_ERROR_INCOMPATIBLE_DRIVER error
Wed, Jun 22, 4:41 PM · Restricted Project, Restricted Project
antiagainst closed D128173: [mlir][vulkan-runner] fix VK_ERROR_INCOMPATIBLE_DRIVER error.
Wed, Jun 22, 4:40 PM · Restricted Project, Restricted Project, Restricted Project
antiagainst added a comment to D128173: [mlir][vulkan-runner] fix VK_ERROR_INCOMPATIBLE_DRIVER error.

hi @antiagainst , I don't have commit access. Could you please commit the change?

Wed, Jun 22, 7:49 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

antiagainst accepted D128173: [mlir][vulkan-runner] fix VK_ERROR_INCOMPATIBLE_DRIVER error.
Tue, Jun 21, 9:27 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 16

antiagainst committed rG2320a4ae907f: [mlir][spirv] Workaround driver bug in math.ctlz conversion again (authored by antiagainst).
[mlir][spirv] Workaround driver bug in math.ctlz conversion again
Thu, Jun 16, 7:54 AM · Restricted Project, Restricted Project
antiagainst closed D127930: [mlir][spirv] Workaround driver bug in math.ctlz conversion again.
Thu, Jun 16, 7:54 AM · Restricted Project, Restricted Project
antiagainst updated the diff for D127930: [mlir][spirv] Workaround driver bug in math.ctlz conversion again.

Fix typos

Thu, Jun 16, 7:28 AM · Restricted Project, Restricted Project

Wed, Jun 15

antiagainst retitled D127930: [mlir][spirv] Workaround driver bug in math.ctlz conversion again from [mlir][spirv] Woraround driver bug in math.ctlz converion again to [mlir][spirv] Workaround driver bug in math.ctlz conversion again.
Wed, Jun 15, 7:22 PM · Restricted Project, Restricted Project
antiagainst requested review of D127930: [mlir][spirv] Workaround driver bug in math.ctlz conversion again.
Wed, Jun 15, 7:18 PM · Restricted Project, Restricted Project
antiagainst committed rGf3bc0fccd68a: [mlir][spirv] Define spv.ISubBorrowOp (authored by antiagainst).
[mlir][spirv] Define spv.ISubBorrowOp
Wed, Jun 15, 5:40 PM · Restricted Project, Restricted Project
antiagainst closed D127909: [mlir][spirv] Define spv.ISubBorrowOp.
Wed, Jun 15, 5:40 PM · Restricted Project, Restricted Project
antiagainst updated the diff for D127909: [mlir][spirv] Define spv.ISubBorrowOp.

Update example

Wed, Jun 15, 3:39 PM · Restricted Project, Restricted Project
antiagainst requested review of D127909: [mlir][spirv] Define spv.ISubBorrowOp.
Wed, Jun 15, 3:38 PM · Restricted Project, Restricted Project
antiagainst accepted D127879: [mlir][GPUToNVVM] Fix bug in mma elementwise lowering.
Wed, Jun 15, 10:21 AM · Restricted Project, Restricted Project

Tue, Jun 14

antiagainst committed rG06c6758a9816: [mlir][spirv] Handle corner cases for math.powf conversion (authored by antiagainst).
[mlir][spirv] Handle corner cases for math.powf conversion
Tue, Jun 14, 8:03 PM · Restricted Project, Restricted Project
antiagainst closed D127816: [mlir][spirv] Handle corner cases for math.powf conversion.
Tue, Jun 14, 8:03 PM · Restricted Project, Restricted Project
antiagainst requested review of D127816: [mlir][spirv] Handle corner cases for math.powf conversion.
Tue, Jun 14, 6:13 PM · Restricted Project, Restricted Project
antiagainst committed rGb4dff404f37a: [mlir][spirv] Fix math.ctlz for full zero bit cases (authored by antiagainst).
[mlir][spirv] Fix math.ctlz for full zero bit cases
Tue, Jun 14, 4:42 PM · Restricted Project, Restricted Project
antiagainst closed D127747: [mlir][spirv] Fix math.ctlz for full zero bit cases.
Tue, Jun 14, 4:41 PM · Restricted Project, Restricted Project
antiagainst abandoned D119454: [mlir][tensor] Keep size-1 dim for non-rank-reducing extract_slice.
Tue, Jun 14, 8:49 AM · Restricted Project, Restricted Project
antiagainst updated the diff for D127747: [mlir][spirv] Fix math.ctlz for full zero bit cases.

Rebase

Tue, Jun 14, 8:15 AM · Restricted Project, Restricted Project
antiagainst requested review of D127747: [mlir][spirv] Fix math.ctlz for full zero bit cases.
Tue, Jun 14, 8:03 AM · Restricted Project, Restricted Project

Mon, Jun 13

antiagainst committed rGb5192cbe506c: [mlir][spirv] Fix result type for arith.cmpi/cmpf conversion (authored by antiagainst).
[mlir][spirv] Fix result type for arith.cmpi/cmpf conversion
Mon, Jun 13, 10:16 AM · Restricted Project, Restricted Project
antiagainst closed D127574: [mlir][spirv] Fix result type for arith.cmpi/cmpf conversion.
Mon, Jun 13, 10:16 AM · Restricted Project, Restricted Project
antiagainst committed rG91de20c36d58: [mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV (authored by antiagainst).
[mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV
Mon, Jun 13, 10:14 AM · Restricted Project, Restricted Project
antiagainst closed D127573: [mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV.
Mon, Jun 13, 10:14 AM · Restricted Project, Restricted Project
antiagainst added inline comments to D127573: [mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV.
Mon, Jun 13, 10:08 AM · Restricted Project, Restricted Project
antiagainst committed rGcc020a2236af: [mlir][spirv] Convert math.ctlz to spv.GLSL.FindUMsb (authored by antiagainst).
[mlir][spirv] Convert math.ctlz to spv.GLSL.FindUMsb
Mon, Jun 13, 10:04 AM · Restricted Project, Restricted Project
antiagainst closed D127582: [mlir][spirv] Convert math.ctlz to spv.GLSL.FindUMsb.
Mon, Jun 13, 10:03 AM · Restricted Project, Restricted Project
antiagainst updated the diff for D127582: [mlir][spirv] Convert math.ctlz to spv.GLSL.FindUMsb.

Add some negative tests

Mon, Jun 13, 9:48 AM · Restricted Project, Restricted Project
antiagainst added a reviewer for D127582: [mlir][spirv] Convert math.ctlz to spv.GLSL.FindUMsb: rsuderman.
Mon, Jun 13, 9:36 AM · Restricted Project, Restricted Project
antiagainst added inline comments to D127573: [mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV.
Mon, Jun 13, 9:31 AM · Restricted Project, Restricted Project
antiagainst committed rGa10c09d1e38b: [mlir][spirv] Remove unused `traits` from `SPV_Attr` (authored by antiagainst).
[mlir][spirv] Remove unused `traits` from `SPV_Attr`
Mon, Jun 13, 9:23 AM · Restricted Project, Restricted Project
antiagainst committed rGa4360efb2c59: [mlir][spirv] Convert single element vector.splat/fma (authored by antiagainst).
[mlir][spirv] Convert single element vector.splat/fma
Mon, Jun 13, 9:19 AM · Restricted Project, Restricted Project
antiagainst closed D127572: [mlir][spirv] Convert single element vector.splat/fma.
Mon, Jun 13, 9:18 AM · Restricted Project, Restricted Project

Sat, Jun 11

antiagainst retitled D127572: [mlir][spirv] Convert single element vector.splat/fma from [mlir][spirv] Convert single element vector.splat to [mlir][spirv] Convert single element vector.splat/fma.
Sat, Jun 11, 5:54 PM · Restricted Project, Restricted Project
antiagainst updated the diff for D127572: [mlir][spirv] Convert single element vector.splat/fma.

Update

Sat, Jun 11, 5:54 PM · Restricted Project, Restricted Project
antiagainst requested review of D127582: [mlir][spirv] Convert math.ctlz to spv.GLSL.FindUMsb.
Sat, Jun 11, 5:52 PM · Restricted Project, Restricted Project
antiagainst added a reviewer for D127572: [mlir][spirv] Convert single element vector.splat/fma: mravishankar.
Sat, Jun 11, 9:04 AM · Restricted Project, Restricted Project
antiagainst added a reviewer for D127573: [mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV: mravishankar.
Sat, Jun 11, 8:51 AM · Restricted Project, Restricted Project
antiagainst added a reviewer for D127574: [mlir][spirv] Fix result type for arith.cmpi/cmpf conversion: mravishankar.
Sat, Jun 11, 8:51 AM · Restricted Project, Restricted Project
antiagainst requested review of D127574: [mlir][spirv] Fix result type for arith.cmpi/cmpf conversion.
Sat, Jun 11, 8:49 AM · Restricted Project, Restricted Project
antiagainst requested review of D127573: [mlir][spirv] Use UnrealizedConversionCast in ArithmeticToSPIRV.
Sat, Jun 11, 8:48 AM · Restricted Project, Restricted Project
antiagainst requested review of D127572: [mlir][spirv] Convert single element vector.splat/fma.
Sat, Jun 11, 8:43 AM · Restricted Project, Restricted Project

Fri, Jun 10

antiagainst committed rGe90b56e41186: [mlir][vulkan] Add missing '<>' in test IRs to fix test (authored by antiagainst).
[mlir][vulkan] Add missing '<>' in test IRs to fix test
Fri, Jun 10, 3:09 PM · Restricted Project, Restricted Project
antiagainst committed rG11cf2d5f62f9: [mlir][spirv] Unify aliases of different bitwidth scalar types (authored by antiagainst).
[mlir][spirv] Unify aliases of different bitwidth scalar types
Fri, Jun 10, 3:09 PM · Restricted Project, Restricted Project
antiagainst closed D127266: [mlir][spirv] Unify aliases of different bitwidth scalar types.
Fri, Jun 10, 3:09 PM · Restricted Project, Restricted Project

Thu, Jun 9

antiagainst accepted D127373: [mlir][spirv] Replace StructAttrs with AttrDefs.

Nice, thanks for migrating these!

Thu, Jun 9, 9:36 AM · Restricted Project, Restricted Project

Wed, Jun 8

antiagainst committed rG2dfefe02832a: [mlir][spirv] NFC: fix typo in UnifyAliasedResourcePass pass (authored by antiagainst).
[mlir][spirv] NFC: fix typo in UnifyAliasedResourcePass pass
Wed, Jun 8, 8:18 AM · Restricted Project, Restricted Project
antiagainst closed D127265: [mlir][spirv] NFC: fix typo in UnifyAliasedResourcePass pass.
Wed, Jun 8, 8:18 AM · Restricted Project, Restricted Project

Tue, Jun 7

antiagainst updated the diff for D127266: [mlir][spirv] Unify aliases of different bitwidth scalar types.

Fix order

Tue, Jun 7, 6:23 PM · Restricted Project, Restricted Project
antiagainst requested review of D127266: [mlir][spirv] Unify aliases of different bitwidth scalar types.
Tue, Jun 7, 6:06 PM · Restricted Project, Restricted Project
antiagainst requested review of D127265: [mlir][spirv] NFC: fix typo in UnifyAliasedResourcePass pass.
Tue, Jun 7, 6:05 PM · Restricted Project, Restricted Project

Mon, Jun 6

antiagainst accepted D127067: [mlir][spirv] Correctly deduce PhysicalStorageBuffer64 addressing model.
Mon, Jun 6, 11:26 AM · Restricted Project, Restricted Project

May 25 2022

antiagainst committed rGe0ea1fc6f8aa: [mlir][spirv] Fix capability check for 64-bit element types (authored by antiagainst).
[mlir][spirv] Fix capability check for 64-bit element types
May 25 2022, 7:58 AM · Restricted Project, Restricted Project
antiagainst closed D126256: [mlir][spirv] Fix capability check for 64-bit element types.
May 25 2022, 7:58 AM · Restricted Project, Restricted Project
antiagainst committed rG413fbb045d71: [mlir][scf] Retain existing attributes in scf.for transforms (authored by antiagainst).
[mlir][scf] Retain existing attributes in scf.for transforms
May 25 2022, 7:53 AM · Restricted Project, Restricted Project
antiagainst closed D126320: [mlir][scf] Retain existing attributes in scf.for transforms.
May 25 2022, 7:53 AM · Restricted Project, Restricted Project

May 24 2022

antiagainst added a reviewer for D126320: [mlir][scf] Retain existing attributes in scf.for transforms: mravishankar.
May 24 2022, 12:46 PM · Restricted Project, Restricted Project
antiagainst requested review of D126320: [mlir][scf] Retain existing attributes in scf.for transforms.
May 24 2022, 12:45 PM · Restricted Project, Restricted Project
antiagainst added a reviewer for D126256: [mlir][spirv] Fix capability check for 64-bit element types: mravishankar.
May 24 2022, 12:45 PM · Restricted Project, Restricted Project
antiagainst accepted D126292: [MLIR][NFC] Fix the Conversion/MemRefToSPIRV/alloc.mlir test..
May 24 2022, 8:12 AM · Restricted Project, Restricted Project

May 23 2022

antiagainst requested review of D126256: [mlir][spirv] Fix capability check for 64-bit element types.
May 23 2022, 4:21 PM · Restricted Project, Restricted Project
antiagainst updated the diff for D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.

Fix func.func

May 23 2022, 1:22 PM · Restricted Project, Restricted Project
antiagainst updated the summary of D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
May 23 2022, 12:16 PM · Restricted Project, Restricted Project
antiagainst added inline comments to D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
May 23 2022, 12:15 PM · Restricted Project, Restricted Project
antiagainst updated the diff for D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.

Remove vector.fma generation

May 23 2022, 12:15 PM · Restricted Project, Restricted Project
antiagainst accepted D126120: [mlir][vector] Add new lowering mode to vector.contractionOp.

Nice, thanks for this, Thomas!

May 23 2022, 12:00 PM · Restricted Project, Restricted Project
antiagainst abandoned D126004: [mlir][vector] Canonicalize contract to fma when possible.

Not needed anymore.

May 23 2022, 11:50 AM · Restricted Project, Restricted Project

May 19 2022

antiagainst updated the diff for D126004: [mlir][vector] Canonicalize contract to fma when possible.

Fix return value

May 19 2022, 12:14 PM · Restricted Project, Restricted Project
antiagainst requested review of D126004: [mlir][vector] Canonicalize contract to fma when possible.
May 19 2022, 12:07 PM · Restricted Project, Restricted Project

Apr 28 2022

antiagainst committed rGbbffece3835d: [mlir][spirv] Remove layout decoration on unneeded storage classes (authored by antiagainst).
[mlir][spirv] Remove layout decoration on unneeded storage classes
Apr 28 2022, 5:22 AM · Restricted Project, Restricted Project
antiagainst closed D124543: [mlir][spirv] Remove layout decoration on unneeded storage classes.
Apr 28 2022, 5:22 AM · Restricted Project, Restricted Project
antiagainst committed rG8854b736065c: [mlir][spirv] Convert memref.alloca to spv.Variable (authored by antiagainst).
[mlir][spirv] Convert memref.alloca to spv.Variable
Apr 28 2022, 5:18 AM · Restricted Project, Restricted Project
antiagainst closed D124542: [mlir][spirv] Convert memref.alloca to spirv.Variable.
Apr 28 2022, 5:17 AM · Restricted Project, Restricted Project

Apr 27 2022

antiagainst requested review of D124543: [mlir][spirv] Remove layout decoration on unneeded storage classes.
Apr 27 2022, 11:03 AM · Restricted Project, Restricted Project
antiagainst requested review of D124542: [mlir][spirv] Convert memref.alloca to spirv.Variable.
Apr 27 2022, 10:58 AM · Restricted Project, Restricted Project
antiagainst committed rGd137c05fc9a3: [mlir][spirv] Add conversion from vector.reduction (authored by antiagainst).
[mlir][spirv] Add conversion from vector.reduction
Apr 27 2022, 7:30 AM · Restricted Project, Restricted Project
antiagainst closed D124380: [mlir][spirv] Add conversion from vector.reduction.
Apr 27 2022, 7:30 AM · Restricted Project, Restricted Project
antiagainst added inline comments to D124380: [mlir][spirv] Add conversion from vector.reduction.
Apr 27 2022, 7:28 AM · Restricted Project, Restricted Project
antiagainst committed rG38e802a09de6: [mlir][spirv] Allow converting from index type in unsigned ops (authored by antiagainst).
[mlir][spirv] Allow converting from index type in unsigned ops
Apr 27 2022, 7:22 AM · Restricted Project, Restricted Project
antiagainst closed D124451: [mlir][spirv] Allow converting from index type in unsigned ops.
Apr 27 2022, 7:21 AM · Restricted Project, Restricted Project

Apr 26 2022

antiagainst requested review of D124451: [mlir][spirv] Allow converting from index type in unsigned ops.
Apr 26 2022, 6:39 AM · Restricted Project, Restricted Project

Apr 25 2022

antiagainst updated the summary of D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.
Apr 25 2022, 5:11 AM · Restricted Project, Restricted Project
antiagainst updated the diff for D123597: [mlir][vector] Fix CombineContractBroadcast for invalid cases.

Update to fix another invalid case

Apr 25 2022, 5:11 AM · Restricted Project, Restricted Project
antiagainst requested review of D124380: [mlir][spirv] Add conversion from vector.reduction.
Apr 25 2022, 5:03 AM · Restricted Project, Restricted Project

Apr 22 2022

antiagainst committed rG6f28fd0bf7f8: [mlir][vector] Fold 1-element reduction into extract or arith ops (authored by antiagainst).
[mlir][vector] Fold 1-element reduction into extract or arith ops
Apr 22 2022, 11:26 AM · Restricted Project, Restricted Project
antiagainst closed D124129: [mlir][vector] Fold one-element reduction into extract.
Apr 22 2022, 11:26 AM · Restricted Project, Restricted Project
antiagainst added a reviewer for D124207: [MLIR] introduce and use add_mlir_{tool,executable} variants: rriddle.
Apr 22 2022, 6:19 AM · Restricted Project, Restricted Project
antiagainst added inline comments to D124129: [mlir][vector] Fold one-element reduction into extract.
Apr 22 2022, 6:18 AM · Restricted Project, Restricted Project