Page MenuHomePhabricator

antiagainst (Lei Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 24 2019, 5:47 AM (76 w, 4 d)

Recent Activity

Wed, Jun 9

antiagainst committed rG56f60a1ce765: [mlir][spirv] Use SingleBlock + NoTerminator for spv.module (authored by antiagainst).
[mlir][spirv] Use SingleBlock + NoTerminator for spv.module
Wed, Jun 9, 11:04 AM
antiagainst closed D103265: [mlir][spirv] Use SingleBlock + NoTerminator for spv.module.
Wed, Jun 9, 11:04 AM · Restricted Project

Fri, Jun 4

antiagainst accepted D103594: [MLIR][SPIRV] Use getAsmResultName(...) hook for AddressOfOp..
Fri, Jun 4, 8:03 AM · Restricted Project

Thu, Jun 3

antiagainst accepted D103635: [mlir][SPIRV] Add lowering for math.log1p operation to SPIR-V dialect..
Thu, Jun 3, 12:04 PM · Restricted Project

Fri, May 28

antiagainst committed rG4694097dab72: [mlir] Don't elide the last op if there is no terminator (authored by antiagainst).
[mlir] Don't elide the last op if there is no terminator
Fri, May 28, 4:26 AM
antiagainst closed D103264: [mlir] Don't elide the last op if there is no terminator.
Fri, May 28, 4:26 AM · Restricted Project

Thu, May 27

antiagainst accepted D103152: [MLIR][SPIRV] Use getAsmResultName(...) hook for ConstantOp..

Thanks!

Thu, May 27, 11:21 AM · Restricted Project
antiagainst added a comment to D103264: [mlir] Don't elide the last op if there is no terminator.

Do you have a test for that?

Thu, May 27, 10:58 AM · Restricted Project
antiagainst updated the diff for D103264: [mlir] Don't elide the last op if there is no terminator.

Add test

Thu, May 27, 10:57 AM · Restricted Project
antiagainst updated the diff for D103264: [mlir] Don't elide the last op if there is no terminator.

Fix another place

Thu, May 27, 10:22 AM · Restricted Project
antiagainst added reviewers for D103265: [mlir][spirv] Use SingleBlock + NoTerminator for spv.module: hanchung, ThomasRaoux.
Thu, May 27, 9:43 AM · Restricted Project
antiagainst requested review of D103265: [mlir][spirv] Use SingleBlock + NoTerminator for spv.module.
Thu, May 27, 9:38 AM · Restricted Project
antiagainst requested review of D103264: [mlir] Don't elide the last op if there is no terminator.
Thu, May 27, 9:38 AM · Restricted Project
antiagainst requested changes to D103152: [MLIR][SPIRV] Use getAsmResultName(...) hook for ConstantOp..
Thu, May 27, 6:08 AM · Restricted Project
antiagainst added a comment to D103244: [mlir][affine] Fold affine.min with constant zero expressions.

Ah, I think you are right. I just checked the definition for index type; indeed it's just spec'ed as "signless integer whose size is equal to the natural machine word of the target". I was under the wrong impression due to its close relationship with indices/sizes. Thanks for pointing out!! :)

Thu, May 27, 5:50 AM · Restricted Project
antiagainst requested review of D103244: [mlir][affine] Fold affine.min with constant zero expressions.
Thu, May 27, 5:19 AM · Restricted Project
antiagainst requested review of D103243: [mlir][linalg] Support tiling and fusing linalg.pad_tensor.
Thu, May 27, 5:17 AM · Restricted Project

May 12 2021

antiagainst accepted D102029: [mlir][spirv] Define spv.ImageQuerySize operation.

Cool; overall LGTM. Just a few nits. Please fix them and then land.

May 12 2021, 6:06 AM · Restricted Project

May 10 2021

antiagainst committed rG7e71823f1deb: [mlir][linalg] Restrict distribution to parallel dims (authored by antiagainst).
[mlir][linalg] Restrict distribution to parallel dims
May 10 2021, 12:23 PM
antiagainst closed D102079: [mlir][linalg] Restrict distribution to parallel dims.
May 10 2021, 12:23 PM · Restricted Project

May 7 2021

antiagainst requested review of D102079: [mlir][linalg] Restrict distribution to parallel dims.
May 7 2021, 9:30 AM · Restricted Project

May 6 2021

antiagainst committed rG41bc54cc56fd: [mlir][spirv] NFC: Replace OwningSPIRVModuleRef with OwningOpRef (authored by antiagainst).
[mlir][spirv] NFC: Replace OwningSPIRVModuleRef with OwningOpRef
May 6 2021, 2:20 PM
antiagainst closed D102009: [spirv] NFC: Replace OwningSPIRVModuleRef with OwningOpRef.
May 6 2021, 2:20 PM · Restricted Project
antiagainst updated the diff for D102009: [spirv] NFC: Replace OwningSPIRVModuleRef with OwningOpRef.

Address comments

May 6 2021, 2:16 PM · Restricted Project
antiagainst accepted D101949: [mlir][Linalg] Allow folding to rank-zero tensor when using rank-reducing subtensors..
May 6 2021, 10:50 AM · Restricted Project
antiagainst accepted D101602: [MLIR][SPIRV] Properly (de-)serialize BranchConditionalOp..

Awesome, thanks for fixing this non-trivial part! :D

May 6 2021, 10:44 AM · Restricted Project
antiagainst added a reviewer for D102009: [spirv] NFC: Replace OwningSPIRVModuleRef with OwningOpRef: jpienaar.
May 6 2021, 10:24 AM · Restricted Project
antiagainst requested review of D102009: [spirv] NFC: Replace OwningSPIRVModuleRef with OwningOpRef.
May 6 2021, 10:24 AM · Restricted Project

May 3 2021

antiagainst accepted D101495: [mlir][Linalg] Use rank-reduced versions of subtensor and subtensor insert when possible..

Cool! Thanks for rewriting the std op chain into affine apply chain!

May 3 2021, 11:27 AM · Restricted Project
antiagainst accepted D101738: [mlir][linalg] Fix vectorization bug in vector transfer indexing map calculation.

LGTM. Thanks for fixing this, Thomas!

May 3 2021, 11:15 AM · Restricted Project
antiagainst accepted D101511: [mlir][spirv] Add support to convert std.splat op .
May 3 2021, 10:52 AM · Restricted Project

Apr 28 2021

antiagainst accepted D101456: [MLIR][Shape] Fix `shape.broadcast` to standard lowering.
Apr 28 2021, 7:19 AM · Restricted Project

Apr 26 2021

antiagainst added a reverting change for rGb5403117814a: [ADT] Remove StatisticBase and make NoopStatistic empty: rG254e289d4533: Revert "[ADT] Remove StatisticBase and make NoopStatistic empty".
Apr 26 2021, 3:31 PM
antiagainst committed rG254e289d4533: Revert "[ADT] Remove StatisticBase and make NoopStatistic empty" (authored by antiagainst).
Revert "[ADT] Remove StatisticBase and make NoopStatistic empty"
Apr 26 2021, 3:31 PM
antiagainst added a reverting change for D101211: [ADT] Remove StatisticBase and make NoopStatistic empty: rG254e289d4533: Revert "[ADT] Remove StatisticBase and make NoopStatistic empty".
Apr 26 2021, 3:31 PM · Restricted Project
antiagainst added a comment to D101211: [ADT] Remove StatisticBase and make NoopStatistic empty.

FYI: this breaks MLIR build. I'll revert it for now.

Apr 26 2021, 3:27 PM · Restricted Project

Apr 20 2021

antiagainst accepted D100814: [mlir][spirv] Support conversion of extract op from vector<1xT> type.
Apr 20 2021, 9:10 AM · Restricted Project
antiagainst requested changes to D100814: [mlir][spirv] Support conversion of extract op from vector<1xT> type.
Apr 20 2021, 5:33 AM · Restricted Project
antiagainst accepted D100817: [mlir][StandardToSPIRV] Add support for lowering std.xor on bool to SPIR-V.
Apr 20 2021, 5:27 AM · Restricted Project

Apr 14 2021

antiagainst accepted D100452: [mlir][StandardToSPIRV] Add support for lowering memref<?xi1> to SPIR-V.
Apr 14 2021, 7:09 AM · Restricted Project

Apr 13 2021

antiagainst committed rG5b15fe9334b8: [mlir][spirv] Only attach struct offset for required storage classes (authored by antiagainst).
[mlir][spirv] Only attach struct offset for required storage classes
Apr 13 2021, 12:30 PM
antiagainst closed D100386: [mlir][spirv] Only attach struct offset for required storage classes.
Apr 13 2021, 12:30 PM · Restricted Project
antiagainst accepted D100403: [mlir][StandardToSPIRV] Add support for lowering math.powf to SPIR-V..
Apr 13 2021, 12:01 PM · Restricted Project
antiagainst added a comment to D100403: [mlir][StandardToSPIRV] Add support for lowering math.powf to SPIR-V..

I think we should have a cleanup someday... many ops are no longer Standard ops...

Apr 13 2021, 12:01 PM · Restricted Project
antiagainst abandoned D98507: [mlir][spirv] Avoid struct wrapping in non-interface storage class.
Apr 13 2021, 7:24 AM · Restricted Project
antiagainst added a comment to D98507: [mlir][spirv] Avoid struct wrapping in non-interface storage class.

Good points Mahesh!

Apr 13 2021, 7:23 AM · Restricted Project
antiagainst requested review of D100386: [mlir][spirv] Only attach struct offset for required storage classes.
Apr 13 2021, 7:22 AM · Restricted Project

Apr 12 2021

antiagainst committed rG23b8264b5255: [mlir][spirv] Fix runtime array stride when emulating bitwidth (authored by antiagainst).
[mlir][spirv] Fix runtime array stride when emulating bitwidth
Apr 12 2021, 2:14 PM
antiagainst closed D100337: [mlir][spirv] Fix runtime array stride when emulating bitwidth.
Apr 12 2021, 2:13 PM · Restricted Project
antiagainst committed rG2eb98d89ac86: [mlir][spirv] Allow bitwidth emulation on runtime arrays (authored by antiagainst).
[mlir][spirv] Allow bitwidth emulation on runtime arrays
Apr 12 2021, 2:04 PM
antiagainst closed D100335: [mlir][spirv] Allow bitwidth emulation on runtime arrays.
Apr 12 2021, 2:04 PM · Restricted Project
antiagainst committed rG0deeaaca399b: [mlir] Move memref.subview patterns to MemRef/Transforms/ (authored by antiagainst).
[mlir] Move memref.subview patterns to MemRef/Transforms/
Apr 12 2021, 1:43 PM
antiagainst closed D100326: [mlir] Move memref.subview patterns to Memref/Transforms/.
Apr 12 2021, 1:43 PM · Restricted Project
antiagainst requested review of D100337: [mlir][spirv] Fix runtime array stride when emulating bitwidth.
Apr 12 2021, 12:43 PM · Restricted Project
antiagainst committed rGfd91f81c857a: [mlir][spirv] Put debug-only variable in LLVM_DEBUG (authored by antiagainst).
[mlir][spirv] Put debug-only variable in LLVM_DEBUG
Apr 12 2021, 12:15 PM
antiagainst closed D100325: [mlir][spirv] Put debug-only variable in LLVM_DEBUG.
Apr 12 2021, 12:14 PM · Restricted Project
antiagainst requested review of D100335: [mlir][spirv] Allow bitwidth emulation on runtime arrays.
Apr 12 2021, 12:09 PM · Restricted Project
antiagainst requested review of D100326: [mlir] Move memref.subview patterns to Memref/Transforms/.
Apr 12 2021, 10:30 AM · Restricted Project
antiagainst requested review of D100325: [mlir][spirv] Put debug-only variable in LLVM_DEBUG.
Apr 12 2021, 10:29 AM · Restricted Project

Apr 8 2021

antiagainst added a comment to D100128: [mlir][spirv] Define spv.ImageDrefGather operation.

Cool, just two minor issue.

BTW, do you still need me to land the patches from now on? I assume you have commit access now given https://github.com/llvm/llvm-project/commit/63e676ffff6fd57e731412f7d905ef9044d716bf?

Thank you for reviewing. Also thanks for helping me land patches all the time. I will fix the two issues and land the patch by myself. :)

Apr 8 2021, 2:37 PM · Restricted Project
antiagainst accepted D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

Cool, just one final comment.

Apr 8 2021, 11:01 AM · Restricted Project
antiagainst accepted D100128: [mlir][spirv] Define spv.ImageDrefGather operation.

Cool, just two minor issue.

Apr 8 2021, 10:56 AM · Restricted Project
antiagainst committed rG151752ab2082: [mlir][linalg] Fix loop upper bounds in conv fusion test (authored by antiagainst).
[mlir][linalg] Fix loop upper bounds in conv fusion test
Apr 8 2021, 10:42 AM
antiagainst closed D100112: [mlir][linalg] Fix loop upper bounds in conv fusion test.
Apr 8 2021, 10:42 AM · Restricted Project
antiagainst requested changes to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

Mostly okay to me. Major request to have an option for control.

Apr 8 2021, 9:02 AM · Restricted Project
antiagainst requested review of D100112: [mlir][linalg] Fix loop upper bounds in conv fusion test.
Apr 8 2021, 7:59 AM · Restricted Project
antiagainst committed rG5299843c3146: [mlir][spirv] Add control for non-32-bit scalar type emulation (authored by antiagainst).
[mlir][spirv] Add control for non-32-bit scalar type emulation
Apr 8 2021, 5:20 AM
antiagainst committed rG004f29c0bb3c: [mlir][spirv] Timely fail type conversion (authored by antiagainst).
[mlir][spirv] Timely fail type conversion
Apr 8 2021, 5:20 AM
antiagainst closed D100059: [mlir][spirv] Add control for non-32-bit scalar type emulation.
Apr 8 2021, 5:20 AM · Restricted Project
antiagainst closed D100058: [mlir][spirv] Timely fail type conversion.
Apr 8 2021, 5:19 AM · Restricted Project

Apr 7 2021

antiagainst updated the diff for D100059: [mlir][spirv] Add control for non-32-bit scalar type emulation.

Add missing &

Apr 7 2021, 11:52 AM · Restricted Project
antiagainst added a comment to D99724: [mlir][StandardToSPIRV] Handle i1 case for lowering memref.load/store op.

I've created D100058 and D100059 to introduce controls over emulation. You can rebase after they are landed. With D100059 I think we can introduce another option there to control the # of bits for boolean types. So the getTypeNumBytes (which should probably be changed to getTypeNumBits) and all those convert*Type functions can properly handle i1.

Apr 7 2021, 11:45 AM · Restricted Project
antiagainst added reviewers for D100059: [mlir][spirv] Add control for non-32-bit scalar type emulation: hanchung, ThomasRaoux.
Apr 7 2021, 11:41 AM · Restricted Project
antiagainst requested review of D100059: [mlir][spirv] Add control for non-32-bit scalar type emulation.
Apr 7 2021, 11:41 AM · Restricted Project
antiagainst added reviewers for D100058: [mlir][spirv] Timely fail type conversion: hanchung, ThomasRaoux.
Apr 7 2021, 11:41 AM · Restricted Project
antiagainst requested review of D100058: [mlir][spirv] Timely fail type conversion.
Apr 7 2021, 11:40 AM · Restricted Project

Apr 5 2021

antiagainst accepted D99793: [mlir] Hoist out getRequestedOpDefinitions helper.

LGTM. Just a nit about documentation.

Apr 5 2021, 4:40 AM · Restricted Project

Apr 2 2021

antiagainst committed rG6dd07fa513cd: [mlir][spirv] Add utilities for push constant value (authored by antiagainst).
[mlir][spirv] Add utilities for push constant value
Apr 2 2021, 4:55 AM
antiagainst closed D99725: [mlir][spirv] Add utilities for push constant value.
Apr 2 2021, 4:55 AM · Restricted Project

Apr 1 2021

antiagainst updated the summary of D99725: [mlir][spirv] Add utilities for push constant value.
Apr 1 2021, 6:57 AM · Restricted Project
antiagainst added a comment to D99725: [mlir][spirv] Add utilities for push constant value.

These utility functions has been used in IREE for a while. Upstream them now.

Apr 1 2021, 6:50 AM · Restricted Project
antiagainst added reviewers for D99725: [mlir][spirv] Add utilities for push constant value: ThomasRaoux, hanchung.
Apr 1 2021, 6:49 AM · Restricted Project
antiagainst requested review of D99725: [mlir][spirv] Add utilities for push constant value.
Apr 1 2021, 6:48 AM · Restricted Project

Mar 24 2021

antiagainst committed rG19435d3863e5: [mlir][linalg] Fold fill -> tensor_reshape chain (authored by antiagainst).
[mlir][linalg] Fold fill -> tensor_reshape chain
Mar 24 2021, 3:20 PM
antiagainst committed rGc241e1c2f553: [mlir][linalg] Support dropping unit dimensions for init tensors (authored by antiagainst).
[mlir][linalg] Support dropping unit dimensions for init tensors
Mar 24 2021, 3:20 PM
antiagainst committed rG7f28d27cb614: [mlir][linalg] Allow controlling folding unit dim reshapes (authored by antiagainst).
[mlir][linalg] Allow controlling folding unit dim reshapes
Mar 24 2021, 3:20 PM
antiagainst committed rGf66120a3575a: [mlir][affine] Add canonicalization to merge affine min/max ops (authored by antiagainst).
[mlir][affine] Add canonicalization to merge affine min/max ops
Mar 24 2021, 3:20 PM
antiagainst closed D99116: [mlir][linalg] Fold init_tensor -> fill -> tensor_reshape chain.
Mar 24 2021, 3:19 PM · Restricted Project
antiagainst committed rGe58597ee1c7d: [mlir][linalg] Fuse producers with non-permutation indexing maps (authored by antiagainst).
[mlir][linalg] Fuse producers with non-permutation indexing maps
Mar 24 2021, 3:19 PM
antiagainst committed rG23fd26608ca8: [mlir][affine] Deduplicate affine min/max op expressions (authored by antiagainst).
[mlir][affine] Deduplicate affine min/max op expressions
Mar 24 2021, 3:19 PM
antiagainst closed D99115: [mlir][linalg] Support dropping unit dimensions for init tensors.
Mar 24 2021, 3:19 PM · Restricted Project
antiagainst closed D99114: [mlir][linalg] Allow controlling folding unit dim reshapes.
Mar 24 2021, 3:19 PM · Restricted Project
antiagainst committed rGddf93abf49f7: [mlir][linalg] NFC: Move makeTiledShapes into Utils.{h|cpp} (authored by antiagainst).
[mlir][linalg] NFC: Move makeTiledShapes into Utils.{h|cpp}
Mar 24 2021, 3:19 PM
antiagainst closed D99016: [mlir][affine] Add canonicalization to merge affine min/max ops.
Mar 24 2021, 3:19 PM · Restricted Project
antiagainst closed D99015: [mlir][affine] Deduplicate affine min/max op expressions.
Mar 24 2021, 3:19 PM · Restricted Project
antiagainst closed D99014: [mlir][linalg] Fuse producers with non-permutation indexing maps.
Mar 24 2021, 3:19 PM · Restricted Project
antiagainst closed D99013: [linalg] NFC: Move makeTiledShapes into Utils.{h|cpp}.
Mar 24 2021, 3:19 PM · Restricted Project
antiagainst added inline comments to D99116: [mlir][linalg] Fold init_tensor -> fill -> tensor_reshape chain.
Mar 24 2021, 2:52 PM · Restricted Project
antiagainst updated the diff for D99116: [mlir][linalg] Fold init_tensor -> fill -> tensor_reshape chain.

Address comments

Mar 24 2021, 2:52 PM · Restricted Project
antiagainst updated the diff for D99115: [mlir][linalg] Support dropping unit dimensions for init tensors.

Add TODO

Mar 24 2021, 2:52 PM · Restricted Project