Page MenuHomePhabricator

yaxunl (Yaxun Liu)
User

Projects

User does not belong to any projects.

User Details

User Since
May 13 2015, 10:16 AM (255 w, 6 d)

Recent Activity

Today

yaxunl accepted D77670: [CUDA] Add partial support for recent CUDA versions..

LGTM. Thanks!

Tue, Apr 7, 2:43 PM · Restricted Project
yaxunl accepted D77665: [CUDA] Simplify GPU variant handling. NFC..

LGTM. Thanks!

Tue, Apr 7, 2:43 PM · Restricted Project
yaxunl added inline comments to D77665: [CUDA] Simplify GPU variant handling. NFC..
Tue, Apr 7, 11:55 AM · Restricted Project

Yesterday

yaxunl accepted D77583: [hip] Remove `hip_pinned_shadow`..

LGTM. Thanks!

Mon, Apr 6, 8:44 PM · Restricted Project
yaxunl added a comment to D77583: [hip] Remove `hip_pinned_shadow`..

Is the runtime and HIP directed test change in place?

Mon, Apr 6, 5:29 PM · Restricted Project
yaxunl committed rG77e24936022a: [NFC] Minor fix for deferred diagnostics emitter (authored by yaxunl).
[NFC] Minor fix for deferred diagnostics emitter
Mon, Apr 6, 11:26 AM
yaxunl added inline comments to D77028: Speed up deferred diagnostic emitter.
Mon, Apr 6, 11:25 AM · Restricted Project
yaxunl committed rG2c31aa2de13a: Speed up deferred diagnostic emitter (authored by yaxunl).
Speed up deferred diagnostic emitter
Mon, Apr 6, 10:20 AM
yaxunl closed D77028: Speed up deferred diagnostic emitter.
Mon, Apr 6, 10:20 AM · Restricted Project
yaxunl added inline comments to D77028: Speed up deferred diagnostic emitter.
Mon, Apr 6, 9:44 AM · Restricted Project
yaxunl updated the diff for D77028: Speed up deferred diagnostic emitter.

Revised by John's comments. Skip visited functions and check error limit.

Mon, Apr 6, 7:00 AM · Restricted Project

Sun, Apr 5

yaxunl added inline comments to D77028: Speed up deferred diagnostic emitter.
Sun, Apr 5, 8:49 PM · Restricted Project
yaxunl abandoned D42711: AMDGPU: Support target triple OS component cuda.

no longer needed

Sun, Apr 5, 9:36 AM
yaxunl added inline comments to D77028: Speed up deferred diagnostic emitter.
Sun, Apr 5, 9:36 AM · Restricted Project

Fri, Apr 3

yaxunl added inline comments to D77028: Speed up deferred diagnostic emitter.
Fri, Apr 3, 12:58 PM · Restricted Project
yaxunl closed D77390: Fix __builtin_amdgcn_workgroup_size_x/y/z return type.

b72fce1ffd0a0de5b46b486c7030d54cc5d8c225

Fri, Apr 3, 12:57 PM
yaxunl updated the diff for D77028: Speed up deferred diagnostic emitter.

revised by John's comments

Fri, Apr 3, 9:40 AM · Restricted Project
yaxunl added inline comments to D77028: Speed up deferred diagnostic emitter.
Fri, Apr 3, 9:40 AM · Restricted Project
yaxunl added a comment to D77398: [cuda][hip] Fix `RegisterVar` function prototype..

LGTM. Thanks!

Fri, Apr 3, 8:02 AM · Restricted Project
yaxunl committed rGb72fce1ffd0a: Fix __builtin_amdgcn_workgroup_size_x/y/z return type (authored by yaxunl).
Fix __builtin_amdgcn_workgroup_size_x/y/z return type
Fri, Apr 3, 6:59 AM
yaxunl created D77390: Fix __builtin_amdgcn_workgroup_size_x/y/z return type.
Fri, Apr 3, 6:56 AM
yaxunl committed rGa46e7d7a5f60: [AMDGPU] Allow AGPR in inline asm (authored by yaxunl).
[AMDGPU] Allow AGPR in inline asm
Fri, Apr 3, 6:25 AM
yaxunl closed D77329: [AMDGPU] Allow AGPR in inline asm.
Fri, Apr 3, 6:25 AM · Restricted Project

Thu, Apr 2

yaxunl updated the diff for D77329: [AMDGPU] Allow AGPR in inline asm.

fix test

Thu, Apr 2, 6:27 PM · Restricted Project
yaxunl updated the diff for D77329: [AMDGPU] Allow AGPR in inline asm.

added agprs to GCCRegNames and fixed types in test

Thu, Apr 2, 2:38 PM · Restricted Project
yaxunl created D77329: [AMDGPU] Allow AGPR in inline asm.
Thu, Apr 2, 12:28 PM · Restricted Project
yaxunl updated the diff for D77028: Speed up deferred diagnostic emitter.

added comments

Thu, Apr 2, 9:12 AM · Restricted Project
yaxunl added inline comments to D77028: Speed up deferred diagnostic emitter.
Thu, Apr 2, 9:12 AM · Restricted Project

Wed, Apr 1

yaxunl updated the diff for D77028: Speed up deferred diagnostic emitter.

rebase

Wed, Apr 1, 8:43 PM · Restricted Project
yaxunl committed rG5767085c8de9: Fix infinite recursion in deferred diag emitter (authored by yaxunl).
Fix infinite recursion in deferred diag emitter
Wed, Apr 1, 7:38 PM
yaxunl closed D76937: Fix infinite recursion in deferred diagnostic emitter.
Wed, Apr 1, 7:37 PM · Restricted Project
yaxunl accepted D77234: clang/AMDGPU: Stop setting old denormal subtarget features.

LGTM. Thanks!

Wed, Apr 1, 4:20 PM
yaxunl added inline comments to D59321: AMDGPU: Teach toolchain to link rocm device libs.
Wed, Apr 1, 2:45 PM
yaxunl updated the diff for D76937: Fix infinite recursion in deferred diagnostic emitter.

fix assert message

Wed, Apr 1, 11:49 AM · Restricted Project
yaxunl updated the diff for D76937: Fix infinite recursion in deferred diagnostic emitter.

Revised by John's comments. Also only check file scope variables.

Wed, Apr 1, 11:49 AM · Restricted Project

Tue, Mar 31

yaxunl added inline comments to D59321: AMDGPU: Teach toolchain to link rocm device libs.
Tue, Mar 31, 8:23 PM
yaxunl accepted D76950: HIP: Link correct denormal mode library.

LGTM. Thanks!

Tue, Mar 31, 3:59 PM
yaxunl accepted D76862: HIP: Ensure new denormal mode attributes are set.

LGTM. Thanks!

Tue, Mar 31, 1:07 PM
yaxunl added a comment to D76862: HIP: Ensure new denormal mode attributes are set.

Are there any other clang options affecting flushing denormals? If so, are they working properly after this change? Do we need to have tests for them? Thanks.

Tue, Mar 31, 11:58 AM

Mon, Mar 30

yaxunl committed rG764f54bb857b: Rename options --cuda-gpu-arch and --no-cuda-gpu-arch (authored by yaxunl).
Rename options --cuda-gpu-arch and --no-cuda-gpu-arch
Mon, Mar 30, 6:03 PM
yaxunl closed D76987: Rename options --cuda-gpu-arch and --no-cuda-gpu-arch.
Mon, Mar 30, 6:03 PM · Restricted Project
yaxunl added a comment to D76987: Rename options --cuda-gpu-arch and --no-cuda-gpu-arch.

This was discussed on llvm-dev three years ago. Here is the thread.

http://lists.llvm.org/pipermail/llvm-dev/2017-February/109930.html

The last name discussed was "-- offload-arch". I don't believe we need a list option anymore. So ignore the very old request for --offload-archs.

I am ok with the patch the way it is. In the future, we should consider renaming the CudaArch class to OffloadArch class . Also the GpuArchList is currently only initialized in CudaActionBuilder. Eventually this is will have to be done for HIPActionBuilder and OpenMPActionBuilder. Could you consider creating a function to InitializeGpuArchList ?

Mon, Mar 30, 6:02 PM · Restricted Project
yaxunl added a comment to D76937: Fix infinite recursion in deferred diagnostic emitter.

Can you explain what exactly the emission/semantic model is for variables? Normal code-generation absolutely triggers the emission of many variables lazily (e.g. internal-linkage globals, C++ inline variables); and any variable that's *not* being emitted lazily actually needs to be treated as a potential root into the delayed-diagnostic graph.

Mon, Mar 30, 1:37 PM · Restricted Project
yaxunl accepted D76887: AMDGPU: Make HIPToolChain a subclass of ROCMToolChain.

LGTM. Thanks!

Mon, Mar 30, 10:16 AM
yaxunl abandoned D76072: Make amdgpu- options ZeroOrMore.
Mon, Mar 30, 9:10 AM · Restricted Project
yaxunl abandoned D75285: Mark restrict pointer or reference to const as invariant.
Mon, Mar 30, 9:10 AM
yaxunl planned changes to D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee.

This patch is put on hold due to some concerns.

Mon, Mar 30, 9:10 AM

Sun, Mar 29

yaxunl created D77028: Speed up deferred diagnostic emitter.
Sun, Mar 29, 8:20 PM · Restricted Project
yaxunl created D77013: [AMDGPU] Add options -mamdgpu-ieee -mno-amdgpu-ieee.
Sun, Mar 29, 7:59 AM

Sat, Mar 28

yaxunl created D76987: Rename options --cuda-gpu-arch and --no-cuda-gpu-arch.
Sat, Mar 28, 6:27 AM · Restricted Project
yaxunl updated the summary of D76987: Rename options --cuda-gpu-arch and --no-cuda-gpu-arch.
Sat, Mar 28, 6:27 AM · Restricted Project

Fri, Mar 27

yaxunl committed rG369e26ca9e0d: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z (authored by yaxunl).
[AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z
Fri, Mar 27, 10:33 PM
yaxunl closed D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z.
Fri, Mar 27, 10:32 PM · Restricted Project
yaxunl added inline comments to D76887: AMDGPU: Make HIPToolChain a subclass of ROCMToolChain.
Fri, Mar 27, 8:23 PM
yaxunl added a reviewer for D76795: [HIP] Change default --gpu-max-threads-per-block value to 1024: arsenm.
Fri, Mar 27, 8:23 PM
yaxunl created D76937: Fix infinite recursion in deferred diagnostic emitter.
Fri, Mar 27, 9:50 AM · Restricted Project

Thu, Mar 26

yaxunl added inline comments to D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z.
Thu, Mar 26, 10:50 AM · Restricted Project

Wed, Mar 25

yaxunl added reviewers for D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z: rjmccall, Anastasia.
Wed, Mar 25, 5:21 PM · Restricted Project
yaxunl updated the diff for D76795: [HIP] Change default --gpu-max-threads-per-block value to 1024.

change variable names

Wed, Mar 25, 2:05 PM
yaxunl added inline comments to D76795: [HIP] Change default --gpu-max-threads-per-block value to 1024.
Wed, Mar 25, 2:05 PM
yaxunl created D76795: [HIP] Change default --gpu-max-threads-per-block value to 1024.
Wed, Mar 25, 11:55 AM
yaxunl added inline comments to D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z.
Wed, Mar 25, 10:47 AM · Restricted Project
yaxunl updated the diff for D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z.

Revised by Matt's comments

Wed, Mar 25, 10:47 AM · Restricted Project
yaxunl created D76772: [AMDGPU] Add __builtin_amdgcn_workgroup_size_x/y/z.
Wed, Mar 25, 6:59 AM · Restricted Project

Tue, Mar 24

yaxunl committed rG2ae25647d1a3: [CUDA][HIP] Add -Xarch_device and -Xarch_host options (authored by yaxunl).
[CUDA][HIP] Add -Xarch_device and -Xarch_host options
Tue, Mar 24, 7:30 AM
yaxunl closed D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options.
Tue, Mar 24, 7:30 AM · Restricted Project

Mon, Mar 23

yaxunl added a comment to D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path.

I am curious why opt and llc is not affected

In one case (opt, llc, clang-offload-bundler) it finds those programs in the "program paths", ie. the build folder: https://github.com/llvm/llvm-project/blob/master/clang/lib/Driver/Driver.cpp#L4733

Whereas in another cases (lld) when it doesn't find the program in the "program paths", it will go search the env.var. %PATH% and fall back to a platform-specific search, which includes searching using {program_name}.exe: https://github.com/llvm/llvm-project/blob/master/llvm/lib/Support/Windows/Program.inc#L65

This is the output I was getting:

D:\llvm-project\buildninjaRel\tools\clang\test\Driver>"d:\llvm-project\buildninjarel\bin\clang.exe" "-c" "--cuda-device-only" "-###" "-target" "x86_64-linux-gnu" "-o" "a.s" "-x" "hip" "--cuda-gpu-arch=gfx900" "--hip-device-lib=lib1.bc" "--hip-device-lib-path=D:\llvm-project\clang\test\Driver/Inputs/hip_multiple_inputs/lib1" "D:\llvm-project\clang\test\Driver/Inputs/hip_multiple_inputs/a.cu"
clang version 11.0.0 (https://github.com/llvm/llvm-project.git c1f8595fe5b856222418e2de547f0e346d84ac84)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: d:\llvm-project\buildninjarel\bin
 "d:\\llvm-project\\buildninjarel\\bin\\clang.exe" "-cc1" "-triple" "amdgcn-amd-amdhsa" "-aux-triple" "x86_64-unknown-linux-gnu" "-emit-llvm-bc" "-emit-llvm-uselists" "-disable-free" "-disable-llvm-verifier" "-discard-value-names" "-main-file-name" "a.cu" "-mrelocation-model" "pic" "-pic-level" "1" "-mthread-model" "posix" "-mframe-pointer=all" "-fno-rounding-math" "-mconstructor-aliases" "-aux-target-cpu" "x86-64" "-target-cpu" "gfx900" "-fcuda-is-device" "-fcuda-allow-variadic-functions" "-fvisibility" "hidden" "-fapply-global-visibility-to-externs" "-mlink-builtin-bitcode" "D:\\llvm-project\\clang\\test\\Driver/Inputs/hip_multiple_inputs/lib1\\lib1.bc" "-dwarf-column-info" "-fno-split-dwarf-inlining" "-debugger-tuning=gdb" "-resource-dir" "d:\\llvm-project\\buildninjarel\\lib\\clang\\11.0.0" "-internal-isystem" "/usr/local/include" "-internal-isystem" "d:\\llvm-project\\buildninjarel\\lib\\clang\\11.0.0\\include" "-internal-externc-isystem" "/include" "-internal-externc-isystem" "/usr/include" "-internal-isystem" "/usr/local/include" "-internal-isystem" "d:\\llvm-project\\buildninjarel\\lib\\clang\\11.0.0\\include" "-internal-externc-isystem" "/include" "-internal-externc-isystem" "/usr/include" "-fdeprecated-macro" "-fno-autolink" "-fdebug-compilation-dir" "D:\\llvm-project\\buildninjaRel\\tools\\clang\\test\\Driver" "-ferror-limit" "19" "-fmessage-length" "138" "-fgnuc-version=4.2.1" "-fobjc-runtime=gcc" "-fcxx-exceptions" "-fexceptions" "-fdiagnostics-show-option" "-fcolor-diagnostics" "-fcuda-allow-variadic-functions" "-faddrsig" "-o" "C:\\Users\\aganea\\AppData\\Local\\Temp\\a-152940.bc" "-x" "hip" "D:\\llvm-project\\clang\\test\\Driver/Inputs/hip_multiple_inputs/a.cu"
 "d:\\llvm-project\\buildninjarel\\bin\\llvm-link" "C:\\Users\\aganea\\AppData\\Local\\Temp\\a-152940.bc" "-o" "C:\\Users\\aganea\\AppData\\Local\\Temp\\a-152940-gfx900-linked-fa625c.bc"
 "d:\\llvm-project\\buildninjarel\\bin\\opt" "C:\\Users\\aganea\\AppData\\Local\\Temp\\a-152940-gfx900-linked-fa625c.bc" "-mtriple=amdgcn-amd-amdhsa" "-mcpu=gfx900" "-o" "C:\\Users\\aganea\\AppData\\Local\\Temp\\a-152940-gfx900-optimized-227a21.bc"
 "d:\\llvm-project\\buildninjarel\\bin\\llc" "C:\\Users\\aganea\\AppData\\Local\\Temp\\a-152940-gfx900-optimized-227a21.bc" "-mtriple=amdgcn-amd-amdhsa" "-mcpu=gfx900" "-filetype=obj" "-o" "C:\\Users\\aganea\\AppData\\Local\\Temp\\a-152940-gfx900-03076f.o"
 "C:\\Program Files\\LLVM\\bin\\lld.exe" "-flavor" "gnu" "-shared" "-o" "C:\\Users\\aganea\\AppData\\Local\\Temp\\a-630562.out" "C:\\Users\\aganea\\AppData\\Local\\Temp\\a-152940-gfx900-03076f.o"
 "d:\\llvm-project\\buildninjarel\\bin\\clang-offload-bundler" "-type=o" "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa-gfx900" "-inputs=nul,C:\\Users\\aganea\\AppData\\Local\\Temp\\a-630562.out" "-outputs=a.s"

If LLD is built at the same time as Clang, this error doesn't happen.

Mon, Mar 23, 2:11 PM · Restricted Project
yaxunl accepted D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path.

LGTM. Thanks.

Mon, Mar 23, 12:33 PM · Restricted Project
yaxunl updated the diff for D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options.

add TODO for fixing space separated arguments

Mon, Mar 23, 12:00 PM · Restricted Project
yaxunl added a comment to D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path.

I am curious why opt and llc is not affected

Mon, Mar 23, 11:28 AM · Restricted Project
yaxunl added a comment to D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options.
In D76520#1937217, @tra wrote:

-Xarch_ works with driver options having value, e.g. -fcf-protection=branch. I added a test for that.

-mframe-pointer=none is a cc1 option. That's why it cannot be passed by -Xarch_. If it is made a driver option it can be passed.

In other words, if we need to pass a cc1 option to a specific sub-compilation, we'll need an arch-specific -Xclang variant. Does -Xarch_foo -Xclang -Xarch_foo <foo-specific cc1 option> work with this patch? Considering that sub-compilations *are* cc1 invocations, passing cc1 options is something that would be very useful as not all cc1 options can be directly controlled from the driver level, but most driver options not directly related to the pipeline construction can be overridden by cc1 options.

Mon, Mar 23, 10:21 AM · Restricted Project
yaxunl committed rGb670ab7b6b3d: recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post… (authored by yaxunl).
recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post…
Mon, Mar 23, 9:16 AM
yaxunl updated the diff for D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options.

Add a test for passing options with value

Mon, Mar 23, 7:36 AM · Restricted Project
yaxunl added a comment to D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options.
In D76520#1934341, @tra wrote:

Does it handle options with values? E.g. if I want to pass -mframe-pointer=none ? I vaguely recall the current -Xarch_* implementation had some limitations.
It may be worth adding a test for that.

Mon, Mar 23, 7:36 AM · Restricted Project

Sun, Mar 22

yaxunl committed rG314deab9af94: Add Triple::isAMDGPU (authored by yaxunl).
Add Triple::isAMDGPU
Sun, Mar 22, 11:46 AM
yaxunl committed rG78957bab5515: [NFC] Refactor handling of Xarch option (authored by yaxunl).
[NFC] Refactor handling of Xarch option
Sun, Mar 22, 11:46 AM
yaxunl closed D57707: Add Triple::isAMDGPU.
Sun, Mar 22, 11:45 AM · Restricted Project
yaxunl closed D76455: [NFC] Refactor handling of Xarch option.
Sun, Mar 22, 11:45 AM · Restricted Project

Fri, Mar 20

yaxunl created D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options.
Fri, Mar 20, 12:28 PM · Restricted Project

Thu, Mar 19

yaxunl added a comment to D76455: [NFC] Refactor handling of Xarch option.
In D76455#1932232, @tra wrote:

+1 for refactoring, but what's the long term plan.
Long time ago echristo@ and I had a vague idea to change clang's option parsing to allow something like -Xarch_host <host-only args> -Xarch_device <args for all GPU compilations...> -Xarch=<target> <options for <target> only...>

Thu, Mar 19, 3:54 PM · Restricted Project
yaxunl created D76455: [NFC] Refactor handling of Xarch option.
Thu, Mar 19, 2:15 PM · Restricted Project

Wed, Mar 18

yaxunl committed rGe778db6d7217: recommit b58f6bb1207521cdf6a856004525d7bffa5f2153 (authored by yaxunl).
recommit b58f6bb1207521cdf6a856004525d7bffa5f2153
Wed, Mar 18, 9:42 PM
yaxunl committed rGf528df8e269d: Revert "Add a test for UsedDeclVisitor" (authored by yaxunl).
Revert "Add a test for UsedDeclVisitor"
Wed, Mar 18, 9:42 PM
yaxunl added a reverting change for rGb58f6bb12075: Add a test for UsedDeclVisitor: rGf528df8e269d: Revert "Add a test for UsedDeclVisitor".
Wed, Mar 18, 9:42 PM
yaxunl committed rGb58f6bb12075: Add a test for UsedDeclVisitor (authored by yaxunl).
Add a test for UsedDeclVisitor
Wed, Mar 18, 9:10 PM
yaxunl added a comment to D76262: [NFC] Add UsedDeclVisitor.

Could you add a clang-side test for the check-mlir fix? Having to run mlir tests to verify clang changes seems suboptimal, so we should try to improve coverage of clang's tests.

Wed, Mar 18, 9:09 PM · Restricted Project
yaxunl added a comment to D76262: [NFC] Add UsedDeclVisitor.

Could you add a clang-side test for the check-mlir fix? Having to run mlir tests to verify clang changes seems suboptimal, so we should try to improve coverage of clang's tests.

Wed, Mar 18, 8:04 PM · Restricted Project
yaxunl committed rG62201763c541: Fix crash in check-mlir due to 08ab8c9af4dd27cb306b449edc9a9c50ed11194a (authored by yaxunl).
Fix crash in check-mlir due to 08ab8c9af4dd27cb306b449edc9a9c50ed11194a
Wed, Mar 18, 7:32 PM
yaxunl added a comment to D76262: [NFC] Add UsedDeclVisitor.

This does not appear to be NFC:

git checkout 704cd4d5d0754904361823588f203369c309deca ; ninja check-mlir passes
git checkout 08ab8c9af4dd27cb306b449edc9a9c50ed11194a ; ninja check-mlir fails with:
0.      Program arguments: Compiles/build_clang/bin/clang++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/mlir/lib/Transforms -Illvm-project/mlir/lib/Transforms -Iinclude -Illvm-project/llvm/include -Illvm-project/mlir/include -Itools/mlir/include -fPIC -fvisibility-inl
ines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/mlir/lib/Transforms/CMakeFiles/MLIRTransforms.dir/AffineDataCopyGeneration.cpp.o -MF tools/mlir/lib/Transforms/CMakeFiles/MLIRTransforms.dir/AffineDataCopyGeneration.cpp.o.d -o tools/mlir/lib/Transforms/CMakeFiles/MLIRTransforms.dir/AffineDataCopyGeneration.cpp.o -c llvm-project/mlir/lib/Transforms/AffineDataCopyGeneration.cpp
1.      <eof> parser at end of file
2.      Per-file LLVM IR generation
3.      /usr/lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/unique_ptr.h:848:5: Generating code for declaration 'std::make_unique'
build_clang/bin/clang++(_ZN4llvm3sys15PrintStackTraceERNS_11raw_ostreamE+0x1a)[0x55796bf8436a]
build_clang/bin/clang++(_ZN4llvm3sys17RunSignalHandlersEv+0x34)[0x55796bf82204]
build_clang/bin/clang++(_ZN4llvm3sys15CleanupOnSignalEm+0xf8)[0x55796bf82708]
build_clang/bin/clang++(+0x1a58a08)[0x55796bf07a08]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x13520)[0x7f1b727f7520]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x121)[0x7f1b722bd535]
/lib/x86_64-linux-gnu/libc.so.6(+0x2540f)[0x7f1b722bd40f]
/lib/x86_64-linux-gnu/libc.so.6(+0x32b92)[0x7f1b722cab92]
build_clang/bin/clang++(_ZN5clang7CodeGen15CodeGenFunction17EmitDeclRefLValueEPKNS_11DeclRefExprE+0x358)[0x55796c4cb138]
build_clang/bin/clang++(_ZN5clang7CodeGen15CodeGenFunction10EmitLValueEPKNS_4ExprE+0x2f9)[0x55796c4ca6d9]
build_clang/bin/clang++(_ZN5clang7CodeGen15CodeGenFunction14EmitCastLValueEPKNS_8CastExprE+0x103)[0x55796c4d4033]
Wed, Mar 18, 7:32 PM · Restricted Project
yaxunl added inline comments to D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese.
Wed, Mar 18, 3:46 PM · Restricted Project
yaxunl updated the diff for D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese.

revised by John's comments

Wed, Mar 18, 2:07 PM · Restricted Project
yaxunl added inline comments to D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese.
Wed, Mar 18, 2:07 PM · Restricted Project
yaxunl committed rG6f79f80e6e47: [HIP] Fix duplicate clang -cc1 options on MSVC toolchain (authored by yaxunl).
[HIP] Fix duplicate clang -cc1 options on MSVC toolchain
Wed, Mar 18, 11:58 AM
yaxunl closed D76032: [HIP] Fix duplicate clang -cc1 options on MSVC toolchain.
Wed, Mar 18, 11:58 AM · Restricted Project
yaxunl added a comment to D76032: [HIP] Fix duplicate clang -cc1 options on MSVC toolchain.

ping

Wed, Mar 18, 4:18 AM · Restricted Project
yaxunl accepted D76344: [hip] Revise `GlobalDecl` constructors. NFC..

LGTM. Thanks!

Wed, Mar 18, 4:18 AM · Restricted Project

Tue, Mar 17

yaxunl updated the diff for D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese.

revised by John's comments.

Tue, Mar 17, 6:56 PM · Restricted Project
yaxunl added inline comments to D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese.
Tue, Mar 17, 6:56 PM · Restricted Project
yaxunl committed rG08ab8c9af4dd: [NFC] Add UsedDeclVisitor (authored by yaxunl).
[NFC] Add UsedDeclVisitor
Tue, Mar 17, 9:39 AM
yaxunl closed D76262: [NFC] Add UsedDeclVisitor.
Tue, Mar 17, 9:38 AM · Restricted Project