- User Since
- Jan 7 2020, 7:38 AM (74 w, 4 d)
Wed, Jun 9
Nice cleanup and fixes. Thanks!
Looks good modulo disabling multithreading. I assume that is a left-over from debugging?
Fri, May 21
Fix comments and re-enable cast handling
Wed, May 19
Hey @dfki-jugr. I debugged this a bit today and here is how far I got. We can either land this as a cleanup or you can fold it into some changes you want to do anyway.
Sent the wrong state of the change
I think this should become a pass instead, so that it can also consider aliases and
remove more clones. Block local aliases would suffice to catch situations like
Tue, May 18
Fix Cmake files.
Mon, May 17
There is a typo in the description. Otherwise lgtm.
Fri, May 14
Thank you for cleaning this up!
May 12 2021
I am +1 on the direction here.
Thanks for the replies.
May 11 2021
May 10 2021
May 7 2021
May 6 2021
On what op is this used as there is no test here?
May 3 2021
Apr 29 2021
I am not convinced that DependencyAnalysis is the better name here. For dependencies, I think of read-after-write, etc.. This only computes the flow of buffers through control flow.
Apr 16 2021
Thanks. I can see this to be useful as we use -1 for unknown quite often.
Nice. Some comments to further generalize.
Apr 6 2021
Mar 25 2021
Mar 24 2021
LGTM for the direction this takes. Please address nits.
Thanks for cleaning this up.
Mar 23 2021
This moves us a little further in the direction of having more precise types in the shape dialect in the non-error bearing case. I think this is the right direction to go but also want to give Jacques a chance to comment.
Mar 19 2021
Generally looks good. Just one question. Thanks for adding support for this!
Mar 17 2021
I think we should land this as it is strictly an improvement over the current documentation. We can improve further but having it documented avoids more confusion than it creates.
Thanks for cleaning this up! Looks good in general but I also cannot test this. It would be nice if we had a builder for this. @whchung do you have a setup that could test this continuously or at least periodically to make sure it does not break?
Mar 16 2021
Mar 12 2021
Fantastic! Thank you for cleaning this up.
Mar 11 2021
Please address the clang tidy warnings. Otherwise this looks good to go to me.
Mar 10 2021
After off-line discussion that this will be morphed into the final state in multiple changes, this looks like a good first step. Please fix the comment, though.
Mar 9 2021
Wow, what a patch :)
Mar 8 2021
Mar 5 2021
Mar 4 2021
So we get to use the context stack after all. Looks very clean now.
Mar 2 2021
Just nits for comments. Looks good, thanks!
Mar 1 2021
Feb 25 2021
Feb 24 2021
lgtm for a first step in making the pass pipeline more configurable.
Feb 16 2021
Thanks. Phabricator keeps hiding these from me (might be my fault) and I have to find them in my email.
This looks good. Is there a corresponding diff that adds the expm1 operation to math?
Feb 15 2021
+1 to landing and then cleaning up tests.
Feb 12 2021
Implement inlining interface
Feb 11 2021
Feb 10 2021
Thanks for the review!
Added missing tests