- User Since
- Oct 29 2020, 11:18 AM (124 w, 6 d)
Apr 29 2022
This relates to https://github.com/google/iree/issues/8855 .
Feb 20 2022
On a first pass, this looks ok to me. TOSA itself expresses quantization in-op rather than in-tensor and I don't think we've used these ops other than as a cleanup task (e.g. quant.stats, which I had written an identical removal pattern for internally).
Nov 10 2021
Nov 5 2021
This change keeps the new pad_const field an optional construct and adds a builder to handle it.
Oct 26 2021
Oct 25 2021
Oct 15 2021
Jul 12 2021
Jul 8 2021
Looks good to me! Sorry for the delay, as I was on vacation yesterday.
Jun 30 2021
Undoes the temporary change in https://reviews.llvm.org/rG05cadc6f71555319882ccabf631d2e6410e3fea4 and moves to 3D tensors now that consuming legalizations have been updated.
Jun 25 2021
Jun 21 2021
Jun 9 2021
Thanks for the explanation!
Jun 8 2021
Temporarily support 2D and 3D tensor types as valid.
Legalizations and tests across multiple repositories must be updated to emit 3D type.
Change to supporting just Tosa_Tensor3D once everything is updated.
Jun 7 2021
May 24 2021
I have this same thing locally and was planning to push this out, so I'm not going to stop you here :-)
May 23 2021
Ok now it seems to look a lot better ? If this is alright, please land it on my behalf - it doesn't seem I can do so myself.
Trying using arc diff --update from commandline.
May 21 2021
May 19 2021
Thank you once again for these changes!
Thank you for adding this!
May 12 2021
May 6 2021
May 5 2021
Apr 22 2021
This seems to look fine functionally, modulo the inline aesthetic comments.
Mar 31 2021
Mar 30 2021
Mar 25 2021
Thanks for the review! I'm not sure how to land this myself, or if I can at all.
Jan 11 2021
Dec 14 2020
At this point the best option appear to be to defer this change. Let's revisit this when the SCF dialect has corresponding tests for this interface. Right now, we aren't able to effectively exercise it, and lack access to precedent material on this interface that we can effectively utilize to construct tests, and don't have familiarity with this domain of MLIR. Thank you for your feedback!
Bringing this up again. May I proceed with this ?
Dec 9 2020
I've attempted to reconstruct the tests with insights from the sccp tests. While doing so, I restricted this interface to cond_if() alone to simplify this effort. I've also changed the conditional of the op to just a boolean I1 rather than an unnecessary I1Tensor, allowing the check in getSuccessorRegions() to work without modification.
Dec 7 2020
Dec 3 2020
Incorporated rriddle's feedback and added tests .
Nov 24 2020
Nov 7 2020
Thank you for these cleanup additions!
To suit the flavor of the season, we need a recount here - there was more than 204 since some appear to have disappeared along with deleted files :-)
Removed TosaTraits and TosaTypes headers. Will add when implemented.
Nov 6 2020
Removed extra path in test/Dialect/Tosa .
Updates to feedback from rriddle
Fixed typo in inlining test. Reran check-mlir to confirm.
stellaraccident: Removed extraneous tests as suggested
mehdi_amini: added test decorators.
Incorporates feedback from stellaraccident, rriddle, mehdi_amini
- Cleanup nits and mechanicals
- Removed extraneous tests
- Quantization Builders in C++ now
- Aligned pass invocation with current approach
- 80-col alignment
Nov 5 2020
We'll work on these nits and upload a new patch soon. Since we're new to this, if the next patch looks ok, then please do land it on our behalf as an act of approval.
- Aesthetic cleanups, usage of better MLIR constructs
- Unit tests
- WIP rationale document
Oct 30 2020
Missed one file update in prior commit
Updated to incorporate comments from mehdi_amini and stellaraccident.
Oct 29 2020
In the context of this patch, I just randomly sampled some functions involved here and couldn't find an obvious caller? For example buildQTypeAttrFromMinMax or all the computeMultiplierAndShift*
Updates to incorporate feedback from bondhugula and mehdi_amini .
- Comment formatting
- camelCase vars
- Removed extraneous computeMultiplierAndShift* functions