Page MenuHomePhabricator

yota9 (Vladislav Khmelevsky)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2020, 10:59 AM (52 w, 1 h)

Recent Activity

Apr 1 2021

yota9 updated the diff for D82745: [ThinLto] Fix Ifunc symbol usage.
Apr 1 2021, 2:07 PM · Restricted Project
yota9 added a comment to D82745: [ThinLto] Fix Ifunc symbol usage.

@tejohnson Thank you for you comments and sorry for so long answer! Looking forward to your review!
@guy-david Thank you, fixed!

Apr 1 2021, 12:45 PM · Restricted Project
yota9 updated the diff for D82745: [ThinLto] Fix Ifunc symbol usage.
Apr 1 2021, 12:43 PM · Restricted Project

Oct 27 2020

yota9 added a comment to D82745: [ThinLto] Fix Ifunc symbol usage.

Gentle ping.
Dear @tejohnson if there are some issues that I accidentally missed or not fully understood please let me know about them :)
Thank you for your understanding!

Oct 27 2020, 11:24 AM · Restricted Project

Oct 14 2020

yota9 added a comment to D82745: [ThinLto] Fix Ifunc symbol usage.

Dear @tejohnson!
Sorry for the late answer, the task is not prioritized and I don't have much time to finish it :)
Still I've added GlobalIndirectSummary class as you've requested and decided not to import ifuncs for now, since it should be handled another way then aliases (still AFAIU there is not so much sense in it, maybe only if the resolver unconditionally returns only one function, but in other way unlike aliases ifunc is a relocation that should be processed at runtime).
It seems to be ifunc_import test is not needed, but still added it, maybe it will be useful if somebody will import ifuncs in the future..
Thank you so much for your patch review!

Oct 14 2020, 6:41 AM · Restricted Project
yota9 updated the diff for D82745: [ThinLto] Fix Ifunc symbol usage.

Create GlobalIndirectValueSummary class
Add ifunc_import test
Skip ifuncs import

Oct 14 2020, 6:34 AM · Restricted Project

Aug 9 2020

yota9 added a comment to D82745: [ThinLto] Fix Ifunc symbol usage.

gentle ping :)
Dear @tejohnson maybe you can help/suggest something about this patch? Yes, theoretically it is not a big deal to combine both ifunc & alias cases, but I'm not sure if this won't give any problems in the future.. Thank you!

Aug 9 2020, 5:12 AM · Restricted Project

Jul 22 2020

yota9 updated the summary of D82745: [ThinLto] Fix Ifunc symbol usage.
Jul 22 2020, 4:55 AM · Restricted Project
yota9 added a comment to D82745: [ThinLto] Fix Ifunc symbol usage.

Dear tejohnson !
Thank you for you comments!
I've also added the same conditions for the LTO.cpp, but I'm not sure about symbol linkage resolution in LTO.cpp, since I'm not extremely familiar with LLVM internal linkage types, hope you can help me to investigate this.
Thank you!
Vladislav
Advanced Software Technology Lab, Huawei

Jul 22 2020, 4:52 AM · Restricted Project
yota9 updated the diff for D82745: [ThinLto] Fix Ifunc symbol usage.

Fixed rev 1 comments

Jul 22 2020, 4:41 AM · Restricted Project

Jun 29 2020

yota9 created D82745: [ThinLto] Fix Ifunc symbol usage.
Jun 29 2020, 2:39 AM · Restricted Project