Page MenuHomePhabricator

kbarton (Kit Barton)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 13 2015, 12:58 PM (301 w, 5 d)

Recent Activity

Sep 10 2020

kbarton committed rG009cd4e49103: [PPC][GlobalISel] Add initial GlobalIsel infrastructure (authored by kbarton).
[PPC][GlobalISel] Add initial GlobalIsel infrastructure
Sep 10 2020, 9:58 AM
kbarton closed D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.
Sep 10 2020, 9:58 AM · Restricted Project

Aug 17 2020

kbarton updated the diff for D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.
  • Add const to all parameters of createPPCInstructionSelector.
  • Address review comments - minor clean in PPC::lowerFormalArguments and update comments.
  • Put all new GlobalISel related files into new GISel subdirectory.
  • Fix warnings from clang-tidy and clang-format.
  • Remove unnecessary whitespace.
Aug 17 2020, 1:35 PM · Restricted Project

Aug 7 2020

kbarton updated the diff for D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.

Fix warnings from clang-tidy and clang-format and rebase to latest version of master.

Aug 7 2020, 1:49 PM · Restricted Project

Jul 29 2020

kbarton accepted D84785: [PowerPC] Don't remove swap if there is only a single one between the load and store.

LGTM

Jul 29 2020, 8:33 AM · Restricted Project

Jul 7 2020

kbarton added a comment to D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.

Pardon my cmake, but don't you need a CMakeLists.txt in the GISel sub-directory?

Jul 7 2020, 9:01 AM · Restricted Project

Jul 6 2020

kbarton updated the diff for D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.
  • Put all new GlobalISel related files into new GISel subdirectory.
Jul 6 2020, 1:39 PM · Restricted Project
kbarton added a comment to D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.

AArch64 has a sub-directory for GlobalISel related things:
https://reviews.llvm.org/D81116

Jul 6 2020, 1:04 PM · Restricted Project
kbarton updated the diff for D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.
  • Address review comments - minor clean in PPC::lowerFormalArguments and update comments.
Jul 6 2020, 1:04 PM · Restricted Project

Jul 3 2020

kbarton added a comment to D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.

I had some problems refreshing the patch using arcanist. I *think* I have fixed everything now, but if things look odd please let me know.

Jul 3 2020, 9:38 AM · Restricted Project
kbarton updated the diff for D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.

Refreshing diff

Jul 3 2020, 9:38 AM · Restricted Project
kbarton updated the diff for D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.

Refreshing diff.

Jul 3 2020, 9:38 AM · Restricted Project
kbarton updated the diff for D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.

Add const to all parameters of createPPCInstructionSelector.

Jul 3 2020, 9:06 AM · Restricted Project

Jul 2 2020

kbarton added reviewers for D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure: dsanders, bogner.
Jul 2 2020, 3:41 PM · Restricted Project
kbarton added reviewers for D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure: echristo, Restricted Project.
Jul 2 2020, 3:41 PM · Restricted Project
kbarton created D83100: [PPC][GlobalISel] Add initial GlobalIsel infrastructure.
Jul 2 2020, 3:41 PM · Restricted Project

Jun 30 2020

kbarton committed rG4c2c6c7cc166: [PPC][NFC] Replace TM with Subtarget->getTargetMachine() in preparation for… (authored by kbarton).
[PPC][NFC] Replace TM with Subtarget->getTargetMachine() in preparation for…
Jun 30 2020, 3:46 PM

Jun 26 2020

kbarton committed rG5ca75130f5cd: [PPC][NFC] Add Subtarget and replace all uses of PPCSubTarget with Subtarget. (authored by kbarton).
[PPC][NFC] Add Subtarget and replace all uses of PPCSubTarget with Subtarget.
Jun 26 2020, 9:50 AM
kbarton closed D81623: [PPC][NFC] Add Subtarget and replace all uses of PPCSubTarget with Subtarget..
Jun 26 2020, 9:50 AM · Restricted Project

Jun 19 2020

kbarton updated the diff for D81623: [PPC][NFC] Add Subtarget and replace all uses of PPCSubTarget with Subtarget..

Rebase based on latest version of master.

Jun 19 2020, 1:36 PM · Restricted Project

Jun 11 2020

kbarton retitled D81623: [PPC][NFC] Add Subtarget and replace all uses of PPCSubTarget with Subtarget. from [PPC] Add Subtarget and replace all uses of PPCSubTarget with Subtarget. to [PPC][NFC] Add Subtarget and replace all uses of PPCSubTarget with Subtarget..
Jun 11 2020, 2:22 PM · Restricted Project

Jun 10 2020

kbarton added reviewers for D81623: [PPC][NFC] Add Subtarget and replace all uses of PPCSubTarget with Subtarget.: hfinkel, nemanjai, jhibbits, Restricted Project.
Jun 10 2020, 5:48 PM · Restricted Project
kbarton created D81623: [PPC][NFC] Add Subtarget and replace all uses of PPCSubTarget with Subtarget..
Jun 10 2020, 5:47 PM · Restricted Project

May 27 2020

kbarton added a comment to D64193: [PowerPC] Add exception constraint to FP rounding operations.

I looked through this and it seems fine to me.
I'm not clear about the extraneous frin in vector-constrained-fp-intrinsics.ll, but if it is extraneous I agree we can proceed with this and deal with it in a subsequent patch.

May 27 2020, 12:29 PM · Restricted Project

May 6 2020

kbarton added a comment to D69088: [Lex] #pragma clang transform.

@Meinersbur I missed the RFC and discussion on the cfe-dev mailing list. Could you post a link here so that it's included in the history?

May 6 2020, 10:46 AM · Restricted Project
kbarton accepted D78679: [LoopFusion] Fix LI after fusion of guarded loops.

One minor comment that I just noticed - can you please change the names of the test cases to use _ instead of - (to be consistent with the other tests in the directory)?
Aside from that, LGTM.

May 6 2020, 10:46 AM · Restricted Project

May 1 2020

kbarton added inline comments to D68233: [FPEnv] [WIP] Verify strictfp attribute correctness.
May 1 2020, 5:10 PM · Restricted Project
kbarton requested changes to D78679: [LoopFusion] Fix LI after fusion of guarded loops.

Hi Diego,
Thank you for submitting this patch!
I think this fix makes sense. If you could go ahead and add the check rules for the test cases that would be great!

May 1 2020, 5:08 PM · Restricted Project

Mar 11 2020

kbarton added a comment to D73129: [LoopUnrollAndJam] Correctly update LoopInfo when unroll and jam more than 2-levels loop nests..

Option 1: Use LoopFusion infrastructure to jam innerloops recursively.
Option 2: Prove safety beforehand, and unroll and jamming without creating new loops.

IMHO option 2 is preferable and more robust.

Mar 11 2020, 9:37 AM · Restricted Project

Mar 3 2020

kbarton added a comment to D74644: TTI: Add addrspace parameters to memcpy lowering functions.

To me the grouping that you have here makes the most sense, but I don't have a strong opinion either way.

Mar 3 2020, 5:52 PM · Restricted Project
kbarton added a comment to D75013: [LoopTerminology] Rotated Loops.

I went through the recordings you cited, and as you expected these are mistakes.
First, the comment I made about loop latch having a single predecessor was a typo introduced when converting slides. That should have been successor, to match with the slides I presented at EuroLLVM.
The comment about single successor I got from the original patch for loop rotation (https://reviews.llvm.org/D22630). However, as @Meinersbur pointed out earlier, this comment doesn't make sense because the latch has to have two successors: the loop header and the loop exit block.

Mar 3 2020, 5:52 PM · Restricted Project

Mar 2 2020

kbarton added a comment to D75013: [LoopTerminology] Rotated Loops.

Hi @baziotis. First, thank you very much for working on this - I agree that more description of loop rotation is very important (and badly needed).
Regarding the specific questions you ask, I don't recall off hand, but I will echo @Meinersbur comment that it's possible we made mistakes in those presentations also. I'll try to review/remember what we were thinking in those presentations and reply here tomorrow.

Mar 2 2020, 2:56 PM · Restricted Project
kbarton added a comment to D67694: [Power9] Fix the missing pseudo instruction scheduling information for power9.

I think this is a good change. My only question is with the test case. If we can get the necessary information out of MIR, then I think it's better to write an MIR test case instead of relying on the debug output from the machine scheduler.

Mar 2 2020, 2:56 PM · Restricted Project
kbarton accepted D70651: [Power8] Add the MacroFusion support for Power8 .

LGTM.
I apologize for the delay in getting to this.

Mar 2 2020, 2:09 PM · Restricted Project

Dec 18 2019

kbarton added a comment to D70651: [Power8] Add the MacroFusion support for Power8 .

Could you please rebase this patch?
It no longer applies cleanly, since you committed https://reviews.llvm.org/D70768.

Dec 18 2019, 12:43 PM · Restricted Project
kbarton committed rG3db1cf7a1e67: [LoopFusion] Use the LoopInfo::isRotatedForm method (NFC). (authored by kbarton).
[LoopFusion] Use the LoopInfo::isRotatedForm method (NFC).
Dec 18 2019, 12:05 PM

Dec 17 2019

kbarton accepted D71165: [LoopFusion] Move instructions from FC0.Latch to FC1.Latch..

LGTM.

Dec 17 2019, 1:25 PM · Restricted Project

Dec 16 2019

kbarton created D71569: [LoopFusion] Ensure that both loops are guarded or neither are guarded..
Dec 16 2019, 2:07 PM · Restricted Project
kbarton committed rGff07fc66d9ee: [LoopFusion] Restrict loop fusion to rotated loops. (authored by kbarton).
[LoopFusion] Restrict loop fusion to rotated loops.
Dec 16 2019, 12:18 PM
kbarton closed D71025: [LoopFusion] Restrict loop fusion to rotated loops..
Dec 16 2019, 12:17 PM · Restricted Project
kbarton added inline comments to D71025: [LoopFusion] Restrict loop fusion to rotated loops..
Dec 16 2019, 10:44 AM · Restricted Project
kbarton added inline comments to D71025: [LoopFusion] Restrict loop fusion to rotated loops..
Dec 16 2019, 9:57 AM · Restricted Project
kbarton added a comment to D71025: [LoopFusion] Restrict loop fusion to rotated loops..

Addressed all the review comments.
I'm ready to land this, unless @Whitney has concerns about the test case.

Dec 16 2019, 9:02 AM · Restricted Project

Dec 12 2019

kbarton committed rG61368c8e98c5: Rename LoopInfo::isRotated() to LoopInfo::isRotatedForm(). (authored by kbarton).
Rename LoopInfo::isRotated() to LoopInfo::isRotatedForm().
Dec 12 2019, 3:55 PM

Dec 11 2019

kbarton committed rG942c9946cc2f: [Loop] Add isRotated method to Loop class. (authored by kbarton).
[Loop] Add isRotated method to Loop class.
Dec 11 2019, 6:46 AM
kbarton closed D65958: [Loop] Add isRotated method to Loop class..
Dec 11 2019, 6:45 AM · Restricted Project

Dec 4 2019

kbarton created D71025: [LoopFusion] Restrict loop fusion to rotated loops..
Dec 4 2019, 9:32 AM · Restricted Project

Dec 3 2019

kbarton committed rG06911aee7f86: Add discussion of git-format-patch to Phabricator.html (authored by kbarton).
Add discussion of git-format-patch to Phabricator.html
Dec 3 2019, 4:00 PM
kbarton closed D69323: Add discussion of git-format-patch to Phabricator.html.
Dec 3 2019, 4:00 PM · Restricted Project
kbarton added a comment to D69323: Add discussion of git-format-patch to Phabricator.html.

The problem I had with a new subsection was getting "out" of the new subsection for the rest of the instructions under "How to Submit a Patch" (hopefully that makes sense).

I'm not sure what you mean here.

Dec 3 2019, 11:29 AM · Restricted Project
kbarton updated the diff for D65958: [Loop] Add isRotated method to Loop class..
  • Return false if no latch block exists, instead of assert (based on suggestion from Meinersbur)
  • Add negative test case for loop that is not rotated.
Dec 3 2019, 11:29 AM · Restricted Project
kbarton added inline comments to D65958: [Loop] Add isRotated method to Loop class..
Dec 3 2019, 11:29 AM · Restricted Project

Nov 29 2019

kbarton added a comment to D69323: Add discussion of git-format-patch to Phabricator.html.

Thanks for the review @delcypher!

Nov 29 2019, 9:17 AM · Restricted Project
kbarton updated the diff for D69323: Add discussion of git-format-patch to Phabricator.html.
  • Move description of clang-format to Contributing.rst and add a link to Phabricator.rst to reference it.
Nov 29 2019, 9:10 AM · Restricted Project

Nov 27 2019

kbarton requested changes to D70651: [Power8] Add the MacroFusion support for Power8 .
Nov 27 2019, 8:54 AM · Restricted Project
kbarton accepted D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

LGTM.

Nov 27 2019, 7:49 AM · Restricted Project
kbarton accepted D70619: [NFC][LoopFusion] Use isControlFlowEquivalent() from CodeMoverUtils..

LGTM.

Nov 27 2019, 7:31 AM · Restricted Project

Nov 25 2019

kbarton committed rG85e4f5bcf6aa: [PowerPC] Rename DarwinDirective to CPUDirective (NFC) (authored by kbarton).
[PowerPC] Rename DarwinDirective to CPUDirective (NFC)
Nov 25 2019, 12:28 PM
kbarton closed D70352: [PowerPC] Rename DarwinDirective to CPUDirective (NFC).
Nov 25 2019, 12:28 PM · Restricted Project

Nov 22 2019

kbarton added inline comments to D70352: [PowerPC] Rename DarwinDirective to CPUDirective (NFC).
Nov 22 2019, 4:07 AM · Restricted Project

Nov 16 2019

kbarton added a reviewer for D70352: [PowerPC] Rename DarwinDirective to CPUDirective (NFC): jhibbits.
Nov 16 2019, 8:38 AM · Restricted Project

Nov 15 2019

kbarton created D70352: [PowerPC] Rename DarwinDirective to CPUDirective (NFC).
Nov 15 2019, 6:19 PM · Restricted Project

Nov 13 2019

kbarton abandoned D65811: Minor change to readme file..
Nov 13 2019, 10:34 AM · Restricted Project

Oct 22 2019

kbarton committed rGefd7caaa4ecc: Fix broken sphinx link in CMake.rst. (authored by kbarton).
Fix broken sphinx link in CMake.rst.
Oct 22 2019, 2:50 PM
kbarton closed D69325: Fix broken sphinx link in CMake.rst..
Oct 22 2019, 2:50 PM · Restricted Project
kbarton created D69325: Fix broken sphinx link in CMake.rst..
Oct 22 2019, 2:50 PM · Restricted Project
kbarton created D69323: Add discussion of git-format-patch to Phabricator.html.
Oct 22 2019, 2:40 PM · Restricted Project
kbarton created D69319: Testing arcanist in preparation for "Contributing to LLVM" Tutorial. Please ignore..
Oct 22 2019, 12:39 PM · Restricted Project
kbarton abandoned D69319: Testing arcanist in preparation for "Contributing to LLVM" Tutorial. Please ignore..

Cancelling. Will post another version during the tutorial.

Oct 22 2019, 12:39 PM · Restricted Project
kbarton committed rG8be5827f8561: Test commit - add clarification to README regarding Darwin. (authored by kbarton).
Test commit - add clarification to README regarding Darwin.
Oct 22 2019, 11:44 AM

Sep 26 2019

kbarton committed rG50bc61046084: [LoopFusion] Add ability to fuse guarded loops (authored by kbarton).
[LoopFusion] Add ability to fuse guarded loops
Sep 26 2019, 2:43 PM
kbarton committed rL373018: [LoopFusion] Add ability to fuse guarded loops.
[LoopFusion] Add ability to fuse guarded loops
Sep 26 2019, 2:43 PM
kbarton closed D65464: [LoopFusion] Add ability to fuse guarded loops.
Sep 26 2019, 2:43 PM · Restricted Project
kbarton accepted D66529: [LOOPGUARD] Disable loop with multiple loop exiting blocks..

LGTM.
Thanks for adding the comment.

Sep 26 2019, 12:00 PM · Restricted Project

Sep 23 2019

kbarton added a comment to D66529: [LOOPGUARD] Disable loop with multiple loop exiting blocks..

I don't remember why exactly this was necessary.
Looking at the current definition in LoopInfo.h, it's not immediately obvious to me either.
Could you either update the definition of getLoopGuardBranch in LoopInfo.h to state this case is not handled (and why). Or, if it's something obvious that I'm not seeing, expand the description here to make it clear?

Sep 23 2019, 1:15 PM · Restricted Project

Aug 30 2019

kbarton added inline comments to D65464: [LoopFusion] Add ability to fuse guarded loops.
Aug 30 2019, 10:19 AM · Restricted Project

Aug 29 2019

kbarton added a comment to D65464: [LoopFusion] Add ability to fuse guarded loops.

Are there any other comments on this?
If not, I'd like to get this committed and start working on the next patch.

Aug 29 2019, 2:41 PM · Restricted Project

Aug 27 2019

kbarton added inline comments to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.
Aug 27 2019, 11:40 AM · Restricted Project
kbarton added a comment to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.

Sorry, I clicked submit before adding general comments.
Thanks for working on this. I think this looks OK, just needs some minor cleaning wrt coding guidelines and the test cases.
I'd like other people weigh in though, as it's been a while since I looked at SD Chains.

Aug 27 2019, 9:26 AM · Restricted Project
kbarton added reviewers for D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls: jsji, wuzish.
Aug 27 2019, 9:21 AM · Restricted Project
kbarton requested changes to D64662: [FPEnv] [PowerPC] Lower ppc_fp128 StrictFP Nodes to libcalls.
Aug 27 2019, 9:21 AM · Restricted Project

Aug 13 2019

kbarton added inline comments to D65464: [LoopFusion] Add ability to fuse guarded loops.
Aug 13 2019, 9:50 AM · Restricted Project
kbarton updated the diff for D65464: [LoopFusion] Add ability to fuse guarded loops.
  • Assert guard branch is conditional in getNonLoopBlock.
Aug 13 2019, 9:47 AM · Restricted Project

Aug 8 2019

kbarton added a comment to D65464: [LoopFusion] Add ability to fuse guarded loops.

Is there a long-term plan to avoid the code duplication? E.g. refactoring/keeping only the fuseGuardedLoops variant when loop guards become a normal form? One could also add some preprocessing that makes the two loop guards guard both loops, then use the standard fuse code.

Aug 8 2019, 12:01 PM · Restricted Project
kbarton updated the diff for D65464: [LoopFusion] Add ability to fuse guarded loops.
  • Address review comments.
  • Improve haveIdenticalGuards method by ensuring the guards gave the same flow into/around the loop in addition to identical compare instructions.
  • Remove (redundant) increments of FuseCounter statistic.
  • Addressed review comments.
  • Remove old, out of date comments in fuseGuardedLoops method.
Aug 8 2019, 11:56 AM · Restricted Project
kbarton added inline comments to D65464: [LoopFusion] Add ability to fuse guarded loops.
Aug 8 2019, 11:37 AM · Restricted Project
kbarton created D65958: [Loop] Add isRotated method to Loop class..
Aug 8 2019, 9:54 AM · Restricted Project

Aug 6 2019

kbarton updated the diff for D65464: [LoopFusion] Add ability to fuse guarded loops.
  • Addressed review comments.
Aug 6 2019, 3:14 PM · Restricted Project
kbarton updated the diff for D65464: [LoopFusion] Add ability to fuse guarded loops.
  • Remove (redundant) increments of FuseCounter statistic.
Aug 6 2019, 8:57 AM · Restricted Project
kbarton created D65811: Minor change to readme file..
Aug 6 2019, 8:47 AM · Restricted Project

Jul 30 2019

kbarton updated the diff for D65464: [LoopFusion] Add ability to fuse guarded loops.
  • Improve haveIdenticalGuards method by ensuring the guards gave the same flow into/around the loop in addition to identical compare instructions.
Jul 30 2019, 3:08 PM · Restricted Project
kbarton added inline comments to D65464: [LoopFusion] Add ability to fuse guarded loops.
Jul 30 2019, 2:17 PM · Restricted Project
kbarton updated the diff for D65464: [LoopFusion] Add ability to fuse guarded loops.
  • Address review comments.
Jul 30 2019, 12:30 PM · Restricted Project
kbarton added inline comments to D65464: [LoopFusion] Add ability to fuse guarded loops.
Jul 30 2019, 12:30 PM · Restricted Project
kbarton updated subscribers of D65464: [LoopFusion] Add ability to fuse guarded loops.
Jul 30 2019, 11:44 AM · Restricted Project
kbarton created D65464: [LoopFusion] Add ability to fuse guarded loops.
Jul 30 2019, 11:37 AM · Restricted Project
kbarton committed rGde0b6339991d: [LoopFusion] Extend use of OptimizationRemarkEmitter (authored by kbarton).
[LoopFusion] Extend use of OptimizationRemarkEmitter
Jul 30 2019, 9:01 AM
kbarton committed rL367327: [LoopFusion] Extend use of OptimizationRemarkEmitter.
[LoopFusion] Extend use of OptimizationRemarkEmitter
Jul 30 2019, 9:01 AM
kbarton closed D63844: [LoopFusion] Extend use of OptimizationRemarkEmitter.
Jul 30 2019, 9:00 AM · Restricted Project

Jul 29 2019

kbarton added a comment to D63844: [LoopFusion] Extend use of OptimizationRemarkEmitter.

@etiotto Any additional comments?

Jul 29 2019, 1:18 PM · Restricted Project