Page MenuHomePhabricator

bondhugula (Uday Bondhugula)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2019, 8:54 PM (40 w, 21 h)

Recent Activity

Yesterday

bondhugula added inline comments to D87958: Add Operation to python bindings..
Sat, Sep 19, 3:15 AM · Restricted Project

Fri, Sep 18

bondhugula added inline comments to D87781: Reorder linalg.conv indexing_maps loop order.
Fri, Sep 18, 1:03 PM · Restricted Project
bondhugula added a comment to D87781: Reorder linalg.conv indexing_maps loop order.

It's a bit odd to see the loop ordering of a *lowering conversion* change because the output improves performance with a specific backend/compiler and for specific reasons. Moreover, that way, this would keep changing/evolving and be sensitive to common downstream paths and sensitive to LLVM's opt pipeline. In the absence of any target / scheduling info, the order to choose is typically expected to be just the most intuitive / canonical and shouldn't keep changing. You need an optimization mechanism if you need a better one.

Fri, Sep 18, 1:02 PM · Restricted Project
bondhugula accepted D87746: [mlir] Fix of updating function signature in normalizing memrefs.

Thanks!

Fri, Sep 18, 2:59 AM · Restricted Project, Restricted Project

Thu, Sep 17

bondhugula committed rG0602e8f77f86: [MLIR][Affine] Add parametric tile size support for affine.for tiling (authored by navdeepkk).
[MLIR][Affine] Add parametric tile size support for affine.for tiling
Thu, Sep 17, 11:13 AM
bondhugula closed D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.
Thu, Sep 17, 11:13 AM · Restricted Project
bondhugula accepted D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.
Thu, Sep 17, 11:06 AM · Restricted Project
bondhugula committed rG296e97ae8f71: [MLIR] Support for return values in Affine.For yield (authored by avarmapml).
[MLIR] Support for return values in Affine.For yield
Thu, Sep 17, 11:06 AM
bondhugula closed D87437: [MLIR] Support for return values in Affine.For yield.
Thu, Sep 17, 11:05 AM · Restricted Project
bondhugula accepted D87068: Introduce subtraction for FlatAffineConstraints.

@ftynse comments from the previous round sound good to me too. Looks good to commit from my side once those are addressed.

Thu, Sep 17, 10:19 AM · Restricted Project
bondhugula accepted D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.

Looks good!

Thu, Sep 17, 7:30 AM · Restricted Project
bondhugula added inline comments to D87617: [mlir] expose affine map to C API.
Thu, Sep 17, 2:15 AM · Restricted Project
bondhugula requested changes to D87746: [mlir] Fix of updating function signature in normalizing memrefs.
Thu, Sep 17, 2:10 AM · Restricted Project, Restricted Project
bondhugula accepted D87766: [MLIR] Turns swapId into a FlatAffineConstraints member func.
Thu, Sep 17, 2:07 AM · Restricted Project
bondhugula accepted D87437: [MLIR] Support for return values in Affine.For yield.
Thu, Sep 17, 2:05 AM · Restricted Project
bondhugula accepted D87437: [MLIR] Support for return values in Affine.For yield.

Looks good, thanks!

Thu, Sep 17, 1:46 AM · Restricted Project
bondhugula added inline comments to D87437: [MLIR] Support for return values in Affine.For yield.
Thu, Sep 17, 1:46 AM · Restricted Project
bondhugula requested changes to D87068: Introduce subtraction for FlatAffineConstraints.
Thu, Sep 17, 1:31 AM · Restricted Project

Wed, Sep 16

bondhugula added inline comments to D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.
Wed, Sep 16, 11:51 PM · Restricted Project
bondhugula accepted D87746: [mlir] Fix of updating function signature in normalizing memrefs.
Wed, Sep 16, 11:33 PM · Restricted Project, Restricted Project
bondhugula added inline comments to D87746: [mlir] Fix of updating function signature in normalizing memrefs.
Wed, Sep 16, 2:13 AM · Restricted Project, Restricted Project
bondhugula requested changes to D87746: [mlir] Fix of updating function signature in normalizing memrefs.

Please add a test case that exercises this. Thanks. It's not fully clear one could just ignore all uses that aren't CallOps. Please also add a comment.

Wed, Sep 16, 2:09 AM · Restricted Project, Restricted Project
bondhugula added reviewers for D87746: [mlir] Fix of updating function signature in normalizing memrefs: avarmapml, AlexEichenberger.
Wed, Sep 16, 2:02 AM · Restricted Project, Restricted Project

Tue, Sep 15

bondhugula committed rG9c40495a35a2: [MLIR][NFC] Value print update for block arguments (authored by bondhugula).
[MLIR][NFC] Value print update for block arguments
Tue, Sep 15, 10:18 PM
bondhugula closed D87670: [MLIR][NFC] Value print update for block arguments.
Tue, Sep 15, 10:18 PM · Restricted Project
bondhugula requested changes to D87437: [MLIR] Support for return values in Affine.For yield.
Tue, Sep 15, 9:22 PM · Restricted Project
bondhugula added inline comments to D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.
Tue, Sep 15, 9:21 PM · Restricted Project
bondhugula requested changes to D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.

constructTiledSetHyper... appears to have been moved but not mentioned in the commit summary as an NFC move. Has it been updated in some way?

Tue, Sep 15, 9:15 PM · Restricted Project
bondhugula updated the diff for D87670: [MLIR][NFC] Value print update for block arguments.

Rebase.

Tue, Sep 15, 9:13 PM · Restricted Project
bondhugula added inline comments to D87068: Introduce subtraction for FlatAffineConstraints.
Tue, Sep 15, 3:45 PM · Restricted Project
bondhugula updated the diff for D87670: [MLIR][NFC] Value print update for block arguments.

Trigger harbormaster build check.

Tue, Sep 15, 8:11 AM · Restricted Project
bondhugula added a comment to D87670: [MLIR][NFC] Value print update for block arguments.

These build failures appear unrelated.

Tue, Sep 15, 8:11 AM · Restricted Project
bondhugula added inline comments to D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.
Tue, Sep 15, 4:20 AM · Restricted Project

Mon, Sep 14

bondhugula added a comment to D86071: [MLIR][OpenMP] Add omp.do operation.
Mon, Sep 14, 11:54 PM · Restricted Project, Restricted Project
bondhugula added inline comments to D87437: [MLIR] Support for return values in Affine.For yield.
Mon, Sep 14, 11:33 PM · Restricted Project
bondhugula requested changes to D87437: [MLIR] Support for return values in Affine.For yield.

Thanks for fixing the issues.

Mon, Sep 14, 11:28 PM · Restricted Project
bondhugula added inline comments to D87437: [MLIR] Support for return values in Affine.For yield.
Mon, Sep 14, 11:25 PM · Restricted Project
bondhugula updated the summary of D87670: [MLIR][NFC] Value print update for block arguments.
Mon, Sep 14, 10:36 PM · Restricted Project
bondhugula added a comment to D87670: [MLIR][NFC] Value print update for block arguments.

Suggestions for tweaking the information printed welcome. This change does provide more information than just "<block argument>" but still not enough (as we aren't identifying its Block in any way).

Mon, Sep 14, 10:31 PM · Restricted Project
bondhugula requested review of D87670: [MLIR][NFC] Value print update for block arguments.
Mon, Sep 14, 10:29 PM · Restricted Project
bondhugula added inline comments to D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.
Mon, Sep 14, 10:00 PM · Restricted Project
bondhugula requested changes to D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.
Mon, Sep 14, 9:58 PM · Restricted Project
bondhugula added inline comments to D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.
Mon, Sep 14, 9:54 PM · Restricted Project
bondhugula requested changes to D87437: [MLIR] Support for return values in Affine.For yield.

I think we definitely need a test for the builder API here to make sure it's working as intended. Please see the other builder API tests for reference in test/EDSC/builder-api-test.cpp.

Mon, Sep 14, 4:10 AM · Restricted Project

Sun, Sep 13

bondhugula added a comment to D86071: [MLIR][OpenMP] Add omp.do operation.

I guess for the general workshare loop design issues we can have an RFC in discourse. But this patch can go ahead.

I haven't seen answers to the questions about lowering to LLVM IR + OpenMP runtime, and it sounds suboptimal to push the patch before discussing and agreeing on the actual design.

In particular, it is not clear to me how this construct will connect to loops and what the lowering flow is. Does it expect an scf.for/scf.parallel as the only nested op? Is there a plan for a separate omp.for? How long do loops persist when we go to LLVM, given that OpenMPIRBuilder does not handle loop constructs and we really want to avoid converting loops to CFG during MLIR->LLVM IR translation.

Sun, Sep 13, 11:30 PM · Restricted Project, Restricted Project
bondhugula requested changes to D86071: [MLIR][OpenMP] Add omp.do operation.

Great to see this. Some minor comments.

Sun, Sep 13, 11:17 PM · Restricted Project, Restricted Project
bondhugula added inline comments to D87525: [mlir][Standard] Add canonicalizer for dynamic_tensor_from_elements.
Sun, Sep 13, 11:12 PM · Restricted Project
bondhugula requested changes to D87583: [mlir][scf] Fix a bug in scf::ForOp loop unroll with an epilogue.
Sun, Sep 13, 11:09 PM · Restricted Project
bondhugula added inline comments to D87068: Introduce subtraction for FlatAffineConstraints.
Sun, Sep 13, 10:59 PM · Restricted Project

Thu, Sep 10

bondhugula added inline comments to D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.
Thu, Sep 10, 10:51 PM · Restricted Project
bondhugula accepted D87313: [NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor - CR issues addressed..
Thu, Sep 10, 10:45 PM · Restricted Project
bondhugula added inline comments to D87410: Add support for casting elements in vectors for certain Std dialect type conversion operations..
Thu, Sep 10, 5:35 PM · Restricted Project
bondhugula requested changes to D87410: Add support for casting elements in vectors for certain Std dialect type conversion operations..

I find the commit summary and the title a bit confusing. Isn't this extending standard dialect cast ops to work with vectors of those types? It's not that vector types are being cast to int/fp.

Thu, Sep 10, 5:33 PM · Restricted Project
bondhugula requested changes to D87437: [MLIR] Support for return values in Affine.For yield.
Thu, Sep 10, 9:02 AM · Restricted Project
bondhugula added reviewers for D87437: [MLIR] Support for return values in Affine.For yield: flaub, jbruestle, dcaballe.
Thu, Sep 10, 8:58 AM · Restricted Project

Wed, Sep 9

bondhugula requested changes to D87313: [NFC] Follow up on D87111 - Add an option for unrolling loops up to a factor - CR issues addressed..

Please mark the commit 'NFC' (in the title). Please also include the previous commit title in the commit summary and a part of it in the current title.

Wed, Sep 9, 10:28 PM · Restricted Project
bondhugula added a comment to D87292: Introduce linalg.vecmat.

I chatted with Nicolas about this earlier today, and he was okay with this idea.

Wed, Sep 9, 10:15 PM · Restricted Project
bondhugula requested changes to D87410: Add support for casting elements in vectors for certain Std dialect type conversion operations..
Wed, Sep 9, 10:13 PM · Restricted Project
bondhugula requested changes to D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.
Wed, Sep 9, 7:45 PM · Restricted Project
bondhugula added inline comments to D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.
Wed, Sep 9, 4:17 AM · Restricted Project
bondhugula added inline comments to D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.
Wed, Sep 9, 4:14 AM · Restricted Project
bondhugula requested changes to D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling.

Thanks for contributing this! Please state at the end of the commit summary as to which methods were just moved as a result of this revision (since there appear to be methods that were purely moved to allow reuse with constant tile size API).

Wed, Sep 9, 4:11 AM · Restricted Project
bondhugula added reviewers for D87353: [MLIR][Affine] Add parametric tile size support for affine.for tiling: jbruestle, andydavis1.
Wed, Sep 9, 4:05 AM · Restricted Project

Tue, Sep 8

bondhugula requested changes to D87068: Introduce subtraction for FlatAffineConstraints.
Tue, Sep 8, 11:28 PM · Restricted Project
bondhugula added inline comments to D87068: Introduce subtraction for FlatAffineConstraints.
Tue, Sep 8, 11:20 PM · Restricted Project
bondhugula added a comment to D87111: Add an option for unrolling loops up to a factor..

Thanks for adding this option.

Tue, Sep 8, 8:57 AM · Restricted Project
bondhugula added inline comments to D87111: Add an option for unrolling loops up to a factor..
Tue, Sep 8, 8:56 AM · Restricted Project
bondhugula accepted D87111: Add an option for unrolling loops up to a factor..
Tue, Sep 8, 8:54 AM · Restricted Project

Sat, Sep 5

bondhugula resigned from D87128: [mlir] Fix bug in copy removal.

@dfki-ehna Thanks for fixing the posted bug. Please do rely on @herhut or @pifon2a's review - they are I assume more familiar with prior code.

Sat, Sep 5, 2:25 PM · Restricted Project
bondhugula committed rG430b47a17d22: [MLIR] Remove unused arg from affine tiling validity check (authored by bondhugula).
[MLIR] Remove unused arg from affine tiling validity check
Sat, Sep 5, 5:38 AM

Fri, Sep 4

bondhugula requested changes to D87128: [mlir] Fix bug in copy removal.

Nit: commit summary: to -> due to / during the

Fri, Sep 4, 1:21 AM · Restricted Project

Thu, Sep 3

bondhugula added inline comments to D87068: Introduce subtraction for FlatAffineConstraints.
Thu, Sep 3, 7:40 PM · Restricted Project
bondhugula added inline comments to D87068: Introduce subtraction for FlatAffineConstraints.
Thu, Sep 3, 7:39 PM · Restricted Project
bondhugula requested changes to D87068: Introduce subtraction for FlatAffineConstraints.

Thanks very much for introducing this. Some initial superficial comments.

Thu, Sep 3, 7:38 PM · Restricted Project
bondhugula added inline comments to rG8782c7276559: Strength-reduce SmallVectors to arrays. NFCI..
Thu, Sep 3, 10:06 AM
bondhugula added inline comments to D86929: [mlir] Add Acos, Asin, Atan, Sinh, Cosh, Pow to SPIRVGLSLOps.
Thu, Sep 3, 7:05 AM · Restricted Project

Wed, Sep 2

bondhugula added inline comments to D86985: [MLIR] Change Operation::create() methods to use Value/Type/Block ranges..
Wed, Sep 2, 3:13 PM · Restricted Project
bondhugula added a comment to D85513: [mlir] Added support for loops in BufferPlacement transformation..

Great to see the region branch op interface being used for this. Some minor comments.

Wed, Sep 2, 10:52 AM · Restricted Project
bondhugula accepted D86982: [mlir][Affine] Fix AffineLoopInvariantCodeMotion.

Thanks!

Wed, Sep 2, 10:31 AM · Restricted Project

Tue, Sep 1

bondhugula added inline comments to D86982: [mlir][Affine] Fix AffineLoopInvariantCodeMotion.
Tue, Sep 1, 7:36 PM · Restricted Project
bondhugula added a comment to D86986: [mlir][Affine] Support affine vector loads/stores in LICM.

I'd reword the commit summary a bit to replace "Introduce" - instead, something like "Make use of ..."

Tue, Sep 1, 7:29 PM · Restricted Project
bondhugula accepted D86986: [mlir][Affine] Support affine vector loads/stores in LICM.

Looks good.

Tue, Sep 1, 7:28 PM · Restricted Project

Sun, Aug 30

bondhugula added inline comments to D86785: [mlir] Add Complex Type, Vector Type and Tuple Type subclasses to python bindings.
Sun, Aug 30, 8:33 PM · Restricted Project
bondhugula added inline comments to D85133: [mlir] Extend BufferAssignmentTypeConverter with result conversion callbacks.
Sun, Aug 30, 12:06 PM · Restricted Project
bondhugula added inline comments to rG8782c7276559: Strength-reduce SmallVectors to arrays. NFCI..
Sun, Aug 30, 9:42 AM

Sat, Aug 29

bondhugula accepted D86848: [MLIR] Improving the Comment .

Please fix the 80 column spillovers. Although this "Returns if ..." construction is used pervasively and isn't actually incorrect, it can be a bit confusing. "if this ..." was being used as a noun for the bool value.

Sat, Aug 29, 11:35 PM · Restricted Project

Thu, Aug 27

bondhugula committed rG28a7dfa33d97: [MLIR] Fixed missing constraint append when adding an AffineIfOp domain (authored by kumasento).
[MLIR] Fixed missing constraint append when adding an AffineIfOp domain
Thu, Aug 27, 12:05 PM
bondhugula closed D86421: [MLIR] Fixed missing append when adding an domain.
Thu, Aug 27, 12:05 PM · Restricted Project
bondhugula added a comment to D86421: [MLIR] Fixed missing append when adding an domain.

I've committed this after taking care of the typo, a whitespace error, and typos in the commit title/summary.

Thu, Aug 27, 12:04 PM · Restricted Project
bondhugula added inline comments to D86421: [MLIR] Fixed missing append when adding an domain.
Thu, Aug 27, 11:56 AM · Restricted Project
bondhugula accepted D86421: [MLIR] Fixed missing append when adding an domain.
Thu, Aug 27, 11:52 AM · Restricted Project
bondhugula committed rGa14a2805b04d: [MLIR] MemRef Normalization for Dialects (authored by AlexEichenberger).
[MLIR] MemRef Normalization for Dialects
Thu, Aug 27, 7:59 AM
bondhugula closed D86236: MemRef Normalization for Dialects.
Thu, Aug 27, 7:59 AM · Restricted Project

Wed, Aug 26

bondhugula added a comment to D86236: MemRef Normalization for Dialects.

@bondhugula I don't believe I have commit privilege yet. Please commit for me, if you don't mind.

Wed, Aug 26, 10:22 PM · Restricted Project
bondhugula added inline comments to D85885: [MLIR] Introduce memref vector cast op.
Wed, Aug 26, 9:23 AM · Restricted Project

Tue, Aug 25

bondhugula added a comment to D86236: MemRef Normalization for Dialects.

@AlexEichenberger Let me know if you are able to commit or if you'd like me to commit this for you.

Tue, Aug 25, 8:36 PM · Restricted Project
bondhugula accepted D86236: MemRef Normalization for Dialects.

Thanks!

Tue, Aug 25, 8:33 PM · Restricted Project
bondhugula added inline comments to D86236: MemRef Normalization for Dialects.
Tue, Aug 25, 9:01 AM · Restricted Project
bondhugula accepted D86236: MemRef Normalization for Dialects.

Some more minor comments - mostly on documentation and comments. Can you please fix?

Tue, Aug 25, 7:56 AM · Restricted Project

Mon, Aug 24

bondhugula added a comment to D86392: Implement a new kind of Pass: dynamic pass pipeline.

You may also want to add an [MLIR] tag to the title to not confuse LLVM proper folks.

I think this is noise in my git log and emails: it is likely better solved with tooling.

Mon, Aug 24, 5:00 AM · Restricted Project