Page MenuHomePhabricator

bondhugula (Uday Bondhugula)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2019, 8:54 PM (79 w, 5 d)

Recent Activity

Yesterday

bondhugula added inline comments to D104249: [mlir] Enable cleanup of single iteration reduction loops being sibling-fused maximally .
Thu, Jun 24, 5:59 AM · Restricted Project

Wed, Jun 23

bondhugula added inline comments to D104249: [mlir] Enable cleanup of single iteration reduction loops being sibling-fused maximally .
Wed, Jun 23, 11:02 PM · Restricted Project
bondhugula added a comment to D104249: [mlir] Enable cleanup of single iteration reduction loops being sibling-fused maximally .

@sumesh13 Could you also please mention whether some of the methods were just moved without any change? That's useful in the commit summary.

Wed, Jun 23, 10:54 PM · Restricted Project
bondhugula added inline comments to D104249: [mlir] Enable cleanup of single iteration reduction loops being sibling-fused maximally .
Wed, Jun 23, 10:51 PM · Restricted Project
bondhugula committed rGa873b6d466f5: [MLIR] Generalize detecting mods during slice computing (authored by vinayaka-polymage).
[MLIR] Generalize detecting mods during slice computing
Wed, Jun 23, 12:01 AM
bondhugula closed D104614: [MLIR] Generalize detecting mods during slice computing.
Wed, Jun 23, 12:01 AM · Restricted Project

Tue, Jun 22

bondhugula committed rG0e55112242f6: [NFC][PDL] Fix documentation typo, redundant test (authored by vinayaka-polymage).
[NFC][PDL] Fix documentation typo, redundant test
Tue, Jun 22, 11:57 PM
bondhugula closed D104688: [NFC][PDL] Fix documentation typo, redundant test.
Tue, Jun 22, 11:57 PM · Restricted Project
bondhugula accepted D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..
Tue, Jun 22, 3:01 AM · Restricted Project

Mon, Jun 21

bondhugula added inline comments to D104249: [mlir] Enable cleanup of single iteration reduction loops being sibling-fused maximally .
Mon, Jun 21, 11:15 PM · Restricted Project
bondhugula added a reviewer for D104688: [NFC][PDL] Fix documentation typo, redundant test: rriddle.
Mon, Jun 21, 11:01 PM · Restricted Project
bondhugula accepted D104688: [NFC][PDL] Fix documentation typo, redundant test.
Mon, Jun 21, 11:01 PM · Restricted Project
bondhugula added a comment to D104289: Implement an scf.for range folding optimization pass..

Can you fix the foor -> for typo in the revision title? Also "scf for" in the title will be useful.

Mon, Jun 21, 6:53 PM · Restricted Project
bondhugula accepted D104614: [MLIR] Generalize detecting mods during slice computing.

LGTM - nice improvement and covers a useful case.

Mon, Jun 21, 6:31 PM · Restricted Project
bondhugula requested changes to D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations.
Mon, Jun 21, 6:27 PM · Restricted Project
bondhugula accepted D104260: [mlir] Fix invalid handling of AllocOp symbolOperands by SimplifyAllocConst..

Thanks for fixing this. Some minor comments.

Mon, Jun 21, 5:42 PM · Restricted Project
bondhugula added inline comments to D104534: [mlir] Add TypeIDAllocator class.
Mon, Jun 21, 7:15 AM · Restricted Project

Sat, Jun 19

bondhugula added inline comments to D72223: [MLIR] Introduce affine.execute_region op.
Sat, Jun 19, 2:35 AM · Restricted Project, Restricted Project
bondhugula updated the diff for D72223: [MLIR] Introduce affine.execute_region op.

Minor update to test cases.

Sat, Jun 19, 2:29 AM · Restricted Project, Restricted Project
bondhugula updated the diff for D72223: [MLIR] Introduce affine.execute_region op.

Rebase on upstream tip. Bring code to date.

Sat, Jun 19, 1:49 AM · Restricted Project, Restricted Project

Fri, Jun 18

bondhugula updated the summary of D72223: [MLIR] Introduce affine.execute_region op.
Fri, Jun 18, 7:29 PM · Restricted Project, Restricted Project
Herald added a project to D72223: [MLIR] Introduce affine.execute_region op: Restricted Project.
Fri, Jun 18, 7:29 PM · Restricted Project, Restricted Project
bondhugula added inline comments to D104516: [mlir] Add a ThreadPool to MLIRContext and refactor MLIR threading usage.
Fri, Jun 18, 4:00 AM · Restricted Project, Restricted Project
bondhugula added inline comments to D104516: [mlir] Add a ThreadPool to MLIRContext and refactor MLIR threading usage.
Fri, Jun 18, 3:46 AM · Restricted Project, Restricted Project
bondhugula added inline comments to rGce77039596a9: [Verifier] Parallelize verification and dom checking. NFC..
Fri, Jun 18, 3:44 AM
bondhugula committed rG18c8c934d858: [MLIR] Introduce scf.execute_region op (authored by bondhugula).
[MLIR] Introduce scf.execute_region op
Fri, Jun 18, 3:10 AM
bondhugula closed D75837: [MLIR] Introduce scf.execute_region op.
Fri, Jun 18, 3:10 AM · Restricted Project, Restricted Project
bondhugula updated the diff for D75837: [MLIR] Introduce scf.execute_region op.

Update commit summary - fix revision number.

Fri, Jun 18, 2:55 AM · Restricted Project, Restricted Project

Thu, Jun 17

bondhugula retitled D75837: [MLIR] Introduce scf.execute_region op from [MLIR] Introduce std.execute_region op to [MLIR] Introduce scf.execute_region op.
Thu, Jun 17, 11:57 PM · Restricted Project, Restricted Project
bondhugula updated the diff for D75837: [MLIR] Introduce scf.execute_region op.

Update revision summary

Thu, Jun 17, 11:57 PM · Restricted Project, Restricted Project
bondhugula updated the diff for D75837: [MLIR] Introduce scf.execute_region op.

Drop duplicate attr dict parsing. Fix stale comment.

Thu, Jun 17, 11:55 PM · Restricted Project, Restricted Project
bondhugula abandoned D104508: [MLIR] Introduce scf.execute_region op.

Unintended duplicate

Thu, Jun 17, 11:55 PM · Restricted Project
bondhugula requested review of D104508: [MLIR] Introduce scf.execute_region op.
Thu, Jun 17, 11:54 PM · Restricted Project
bondhugula updated the diff for D75837: [MLIR] Introduce scf.execute_region op.

Rebase on upstream tip. Move op to SCF dialect.

Thu, Jun 17, 11:52 PM · Restricted Project, Restricted Project
bondhugula removed a reviewer for D75837: [MLIR] Introduce scf.execute_region op: bollu.
Thu, Jun 17, 10:17 PM · Restricted Project, Restricted Project
bondhugula updated the summary of D75837: [MLIR] Introduce scf.execute_region op.
Thu, Jun 17, 10:14 PM · Restricted Project, Restricted Project
bondhugula added a comment to D104449: [mlir][linalg] Purge linalg.indexed_generic..

@pifon2a Could I request adding a commit summary (even if one line) on what caused the change? (for eg., "Op dropped because of ...".) Changes like these shouldn't leave the commit summary empty I think - You could even just paste a link to a discourse thread if it was discussed there.

Thu, Jun 17, 6:27 AM · Restricted Project

Wed, Jun 16

bondhugula added inline comments to rGce77039596a9: [Verifier] Parallelize verification and dom checking. NFC..
Wed, Jun 16, 1:38 PM
bondhugula added inline comments to rGce77039596a9: [Verifier] Parallelize verification and dom checking. NFC..
Wed, Jun 16, 1:36 PM
bondhugula committed rG54384d172397: [MLIR] Make store to load fwd condition less conservative (authored by bondhugula).
[MLIR] Make store to load fwd condition less conservative
Wed, Jun 16, 12:58 PM
bondhugula closed D104174: [MLIR] Make store to load fwd condition less conservative.
Wed, Jun 16, 12:57 PM · Restricted Project
bondhugula committed rG51d43bbc4662: [MLIR] Fix affine parallelize pass. (authored by pashu123).
[MLIR] Fix affine parallelize pass.
Wed, Jun 16, 12:56 PM
bondhugula closed D104361: [MLIR] Fix affine parallelize pass..
Wed, Jun 16, 12:56 PM · Restricted Project
bondhugula accepted D104361: [MLIR] Fix affine parallelize pass..
Wed, Jun 16, 12:44 PM · Restricted Project
bondhugula added a comment to D104411: Fix verifier crashing on some invalid IR.

Interesting!

Wed, Jun 16, 12:41 PM · Restricted Project
bondhugula requested changes to D104249: [mlir] Enable cleanup of single iteration reduction loops being sibling-fused maximally .
Wed, Jun 16, 11:56 AM · Restricted Project
bondhugula added inline comments to D104361: [MLIR] Fix affine parallelize pass..
Wed, Jun 16, 11:37 AM · Restricted Project
bondhugula requested changes to D104361: [MLIR] Fix affine parallelize pass..
Wed, Jun 16, 11:36 AM · Restricted Project
bondhugula added a comment to D104361: [MLIR] Fix affine parallelize pass..

The commit summary is outdated/does not match the fix. Furthermore, a deque is not needed here any more.

Wed, Jun 16, 11:35 AM · Restricted Project
bondhugula added a comment to D104174: [MLIR] Make store to load fwd condition less conservative.

Thank you for the reviews!

Wed, Jun 16, 11:22 AM · Restricted Project
bondhugula updated the diff for D104174: [MLIR] Make store to load fwd condition less conservative.

Address reviewer comments. Rebase on tip.

Wed, Jun 16, 11:21 AM · Restricted Project

Tue, Jun 15

bondhugula added reviewers for D104249: [mlir] Enable cleanup of single iteration reduction loops being sibling-fused maximally : vinayaka-polymage, dcaballe.
Tue, Jun 15, 10:24 AM · Restricted Project
bondhugula resigned from D103782: fix DRR's optional operand support.

I just had superficial comments. Please do go with @jpienaar or one of the other reviewers' comments.

Tue, Jun 15, 10:22 AM · Restricted Project

Mon, Jun 14

bondhugula added inline comments to D104207: [Verifier] Parallelize verification and dom checking. NFC..
Mon, Jun 14, 10:00 AM · Restricted Project
bondhugula accepted D104227: Add AutomaticAllocationScope to memref.alloca_scope.
Mon, Jun 14, 7:04 AM · Restricted Project
bondhugula added a reviewer for D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations: ayzhuang.
Mon, Jun 14, 7:03 AM · Restricted Project
bondhugula added a reviewer for D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations: vinayaka-polymage.
Mon, Jun 14, 7:03 AM · Restricted Project
bondhugula added a comment to D104053: [MLIR] Correct memrefdataflow behavior in the presence of cast and other operations.

@wsmoses MemRefDataFlow has just been moved and been renamed. Could you rebase right away? (so that the rebase becomes easy with no further intervening commits)

Mon, Jun 14, 7:02 AM · Restricted Project
bondhugula accepted D104223: [flang] Fix compilation problem with rename of "MemRefDataFlow".

Thanks for fixing this - sorry I had missed updating flang.

Mon, Jun 14, 6:59 AM · Restricted Project, Restricted Project
bondhugula committed rG88e4aae57d4d: [MLIR][NFC] Rename MemRefDataFlow -> AffineScalarReplacement (authored by bondhugula).
[MLIR][NFC] Rename MemRefDataFlow -> AffineScalarReplacement
Mon, Jun 14, 5:27 AM
bondhugula closed D104190: [MLIR][NFC] Rename MemRefDataFlow -> AffineScalarReplacement.
Mon, Jun 14, 5:27 AM · Restricted Project
bondhugula accepted D104208: [mlir] Mark gpu dialect illegal in gpu-to-llvm conversion.
Mon, Jun 14, 12:20 AM · Restricted Project

Sat, Jun 12

bondhugula updated the diff for D104190: [MLIR][NFC] Rename MemRefDataFlow -> AffineScalarReplacement.

Update commit title/summary on phab.

Sat, Jun 12, 4:59 PM · Restricted Project
bondhugula updated the diff for D104190: [MLIR][NFC] Rename MemRefDataFlow -> AffineScalarReplacement.

Mark the change NFC.

Sat, Jun 12, 4:46 PM · Restricted Project
bondhugula requested review of D104190: [MLIR][NFC] Rename MemRefDataFlow -> AffineScalarReplacement.
Sat, Jun 12, 4:46 PM · Restricted Project
bondhugula committed rG466e5aba6495: [MLIR] Simplify affine.if ops with trivial conditions (authored by shashij-polymagelabs).
[MLIR] Simplify affine.if ops with trivial conditions
Sat, Jun 12, 7:03 AM
bondhugula closed D104015: [MLIR] Simplify affine.if ops with trivial conditions.
Sat, Jun 12, 7:02 AM · Restricted Project
bondhugula updated the diff for D104174: [MLIR] Make store to load fwd condition less conservative.

Make the test case simpler/direct.

Sat, Jun 12, 4:57 AM · Restricted Project
bondhugula updated the diff for D104174: [MLIR] Make store to load fwd condition less conservative.

Fix comments.

Sat, Jun 12, 12:07 AM · Restricted Project

Fri, Jun 11

bondhugula added reviewers for D104174: [MLIR] Make store to load fwd condition less conservative: ayzhuang, dcaballe, vinayaka-polymage.
Fri, Jun 11, 10:21 PM · Restricted Project
bondhugula updated the diff for D104174: [MLIR] Make store to load fwd condition less conservative.

Fix stale comments.

Fri, Jun 11, 10:21 PM · Restricted Project
bondhugula requested review of D104174: [MLIR] Make store to load fwd condition less conservative.
Fri, Jun 11, 10:15 PM · Restricted Project
bondhugula committed rGc8b8e8e02223: [MLIR] Execution engine python binding support for shared libraries (authored by bondhugula).
[MLIR] Execution engine python binding support for shared libraries
Fri, Jun 11, 5:17 PM
bondhugula closed D104009: [MLIR] Execution engine python binding support for shared libraries.
Fri, Jun 11, 5:17 PM · Restricted Project
bondhugula added inline comments to D104133: [mlir][VectorToGPU] Add conversion for splat constant to MMA const matrix.
Fri, Jun 11, 4:58 PM · Restricted Project
bondhugula added a reviewer for D103782: fix DRR's optional operand support: rriddle.
Fri, Jun 11, 4:54 PM · Restricted Project
bondhugula requested changes to D103782: fix DRR's optional operand support.
  1. Please add a test case.
Fri, Jun 11, 4:54 PM · Restricted Project
bondhugula abandoned D71961: [MLIR] Free ReturnOp from being restricted to a FuncOp.

This is now moot given std.execute_region suits the scf dialect and the yield op there could terminate it.

Fri, Jun 11, 4:28 PM · Restricted Project, Restricted Project
bondhugula updated the diff for D104009: [MLIR] Execution engine python binding support for shared libraries.

Drop unnecessary include STLExtras.h

Fri, Jun 11, 4:09 PM · Restricted Project
bondhugula accepted D104015: [MLIR] Simplify affine.if ops with trivial conditions.

Looks good - thanks!

Fri, Jun 11, 4:07 PM · Restricted Project
bondhugula added inline comments to D97768: Introduce alloca_scope op.
Fri, Jun 11, 4:47 AM · Restricted Project
bondhugula added a comment to D104009: [MLIR] Execution engine python binding support for shared libraries.

Switched to list of strings on Python API and <count, MlirStringRef array> on the CAPI.

Fri, Jun 11, 1:30 AM · Restricted Project
bondhugula updated the diff for D104009: [MLIR] Execution engine python binding support for shared libraries.

Switch to list of strings on Python API.

Fri, Jun 11, 1:28 AM · Restricted Project

Thu, Jun 10

bondhugula added a comment to D104009: [MLIR] Execution engine python binding support for shared libraries.

I would have wrote: ..., int numPaths, const MlirStringRef *libPaths).

This is the kind of API that I expect the user to map to an ArrayRef on the other side: the C API is unsafe (by nature somehow...) but the chance for error should be almost none because this is only a "binding" API and safe constructs can be used to wrap around this.

Thu, Jun 10, 11:08 PM · Restricted Project
bondhugula added a comment to D104009: [MLIR] Execution engine python binding support for shared libraries.

+1 to Stella's comment :)

(Btw, what did you mean by "string views" for a C API?)

https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir-c/Support.h#L52-L67

Thu, Jun 10, 10:46 PM · Restricted Project
bondhugula added a comment to D104015: [MLIR] Simplify affine.if ops with trivial conditions.
Thu, Jun 10, 2:47 AM · Restricted Project
bondhugula added inline comments to D104015: [MLIR] Simplify affine.if ops with trivial conditions.
Thu, Jun 10, 2:44 AM · Restricted Project
bondhugula requested changes to D104015: [MLIR] Simplify affine.if ops with trivial conditions.
Thu, Jun 10, 2:44 AM · Restricted Project
bondhugula added a comment to D104009: [MLIR] Execution engine python binding support for shared libraries.

All else being equal, it is better to not be in the business of textually manipulating file paths with ad hoc separators. While a bit more typing, would you be open to changing the c API to take a size and pointer to an array of string views? Then on the python side, accept a list of strings.

I know it's annoying but I've been bitten by this kind of path munging on multiple occasions.

Thu, Jun 10, 2:40 AM · Restricted Project
bondhugula added a reviewer for D104015: [MLIR] Simplify affine.if ops with trivial conditions: dcaballe.
Thu, Jun 10, 2:32 AM · Restricted Project

Wed, Jun 9

bondhugula updated the diff for D104009: [MLIR] Execution engine python binding support for shared libraries.

Drop unnecessary import.

Wed, Jun 9, 10:45 PM · Restricted Project
bondhugula requested review of D104009: [MLIR] Execution engine python binding support for shared libraries.
Wed, Jun 9, 10:44 PM · Restricted Project

Wed, Jun 2

bondhugula accepted D103294: [mlir] Remove redundant loads.

Thanks for addressing everything - LGTM!

Wed, Jun 2, 5:23 AM · Restricted Project
bondhugula added inline comments to D103294: [mlir] Remove redundant loads.
Wed, Jun 2, 5:20 AM · Restricted Project
bondhugula accepted D103266: [MLIR] Enable TensorCore integrations tests on Tesla buildbots.
Wed, Jun 2, 5:16 AM

Mon, May 31

bondhugula added a comment to D103384: [Dominators] Rewrite the dominator implementation for efficiency. NFC..

I'll be able to review this tomorrow, but a few really minor things I noticed.

Mon, May 31, 11:07 AM · Restricted Project
bondhugula committed rG18c2106e281b: [MLIR] Fix warnings in AffineOps.cpp (authored by bondhugula).
[MLIR] Fix warnings in AffineOps.cpp
Mon, May 31, 5:30 AM
bondhugula closed D103374: [MLIR] Fix warnings in AffineOps.cpp.
Mon, May 31, 5:30 AM · Restricted Project
bondhugula added inline comments to D102962: [mlir][VectorToGPU] First step to convert vector ops to GPU MMA ops.
Mon, May 31, 5:26 AM · Restricted Project

Sun, May 30

bondhugula requested changes to D103294: [mlir] Remove redundant loads.

Thanks for extending this pass. Comments below.

Sun, May 30, 3:08 AM · Restricted Project