Page MenuHomePhabricator
People bondhugula

bondhugula (Uday Bondhugula)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 14 2019, 8:54 PM (170 w, 3 d)

Recent Activity
View All

Today

bondhugula committed rGd25e022cd19b: [MLIR][Affine] Fix assumption on int type in memref elt size method (authored by bondhugula).
[MLIR][Affine] Fix assumption on int type in memref elt size method
Wed, Mar 22, 3:58 AM · Restricted Project, Restricted Project
bondhugula closed D146495: [MLIR][Affine] Fix assumption on int type in memref elt size method.
Wed, Mar 22, 3:58 AM · Restricted Project, Restricted Project
bondhugula updated the diff for D146495: [MLIR][Affine] Fix assumption on int type in memref elt size method.

Rebase and add a comment.

Wed, Mar 22, 3:54 AM · Restricted Project, Restricted Project
bondhugula added inline comments to D146611: [mlir][AffineMap] NFC - Refactor getProjectedMap and split into projectDims and projectSymbols.
Wed, Mar 22, 2:52 AM · Restricted Project, Restricted Project
bondhugula added inline comments to D146495: [MLIR][Affine] Fix assumption on int type in memref elt size method.
Wed, Mar 22, 2:45 AM · Restricted Project, Restricted Project

Yesterday

bondhugula added inline comments to D146495: [MLIR][Affine] Fix assumption on int type in memref elt size method.
Tue, Mar 21, 9:09 PM · Restricted Project, Restricted Project
bondhugula updated the diff for D146495: [MLIR][Affine] Fix assumption on int type in memref elt size method.

Incorporate review suggestion.

Tue, Mar 21, 7:12 PM · Restricted Project, Restricted Project
bondhugula accepted D146515: [mlir][memref] Use folded composed affine apply ops in FoldMemRefAliasOps.

LGTM

Tue, Mar 21, 6:45 PM · Restricted Project, Restricted Project
bondhugula updated the diff for D146495: [MLIR][Affine] Fix assumption on int type in memref elt size method.

Rebase.

Tue, Mar 21, 5:27 AM · Restricted Project, Restricted Project
bondhugula committed rG8f072bbd7402: [MLIR] Fix warnings in AttrTypeSubElements.h (authored by bondhugula).
[MLIR] Fix warnings in AttrTypeSubElements.h
Tue, Mar 21, 5:26 AM · Restricted Project, Restricted Project
bondhugula closed D146107: [MLIR] Fix warnings in AttrTypeSubElements.h.
Tue, Mar 21, 5:26 AM · Restricted Project, Restricted Project

Mon, Mar 20

bondhugula added inline comments to D146495: [MLIR][Affine] Fix assumption on int type in memref elt size method.
Mon, Mar 20, 10:01 PM · Restricted Project, Restricted Project
bondhugula committed rG71d97df6afc4: [MLIR][Affine] Fix addInductionVarOrTerminalSymbol (authored by bondhugula).
[MLIR][Affine] Fix addInductionVarOrTerminalSymbol
Mon, Mar 20, 9:58 PM · Restricted Project, Restricted Project
bondhugula closed D146493: [MLIR][Affine] Fix addInductionVarOrTerminalSymbol.
Mon, Mar 20, 9:58 PM · Restricted Project, Restricted Project
bondhugula added inline comments to D146495: [MLIR][Affine] Fix assumption on int type in memref elt size method.
Mon, Mar 20, 8:08 PM · Restricted Project, Restricted Project
bondhugula requested review of D146495: [MLIR][Affine] Fix assumption on int type in memref elt size method.
Mon, Mar 20, 8:07 PM · Restricted Project, Restricted Project
bondhugula updated the diff for D146493: [MLIR][Affine] Fix addInductionVarOrTerminalSymbol.

Add CHECK-LABEL line.

Mon, Mar 20, 7:38 PM · Restricted Project, Restricted Project
bondhugula requested review of D146493: [MLIR][Affine] Fix addInductionVarOrTerminalSymbol.
Mon, Mar 20, 7:37 PM · Restricted Project, Restricted Project

Sun, Mar 19

bondhugula removed a reviewer for D146130: [mlir][Transform] Add support for mapping to GPU warps and to linear ids: bondhugula.

Dismissing change request that has now been addressed. This is now purely a GPU transform ops related revision. Any of the other reviewers familiar/interested in transforms ops may be able to review it.

Sun, Mar 19, 9:28 PM · Restricted Project, Restricted Project
bondhugula updated the summary of D146107: [MLIR] Fix warnings in AttrTypeSubElements.h.
Sun, Mar 19, 7:44 PM · Restricted Project, Restricted Project
bondhugula added inline comments to D146107: [MLIR] Fix warnings in AttrTypeSubElements.h.
Sun, Mar 19, 7:44 PM · Restricted Project, Restricted Project
bondhugula updated the diff for D146107: [MLIR] Fix warnings in AttrTypeSubElements.h.

Update commit summary.

Sun, Mar 19, 7:43 PM · Restricted Project, Restricted Project

Thu, Mar 16

bondhugula requested changes to D146130: [mlir][Transform] Add support for mapping to GPU warps and to linear ids.

Please split out the IR/ changes out from the TransformOps/ changes if appropriate; add test cases for linear_id/lane_id op and its lowering - it doesn't seem to itself appear in test cases. It looks odd that the only code manipulating a GPU IR dialect op appears in TransformOps/. Commit summary appears incomplete - doesn't seems to capture all the changes.

Thu, Mar 16, 8:08 PM · Restricted Project, Restricted Project

Tue, Mar 14

bondhugula updated the diff for D146107: [MLIR] Fix warnings in AttrTypeSubElements.h.

Drop extra braces + else nearly.

Tue, Mar 14, 6:42 PM · Restricted Project, Restricted Project
bondhugula requested review of D146107: [MLIR] Fix warnings in AttrTypeSubElements.h.
Tue, Mar 14, 6:39 PM · Restricted Project, Restricted Project
bondhugula committed rG3e497a114730: [MLIR] Update/fix memref region computation for affine.parallel ops (authored by bondhugula).
[MLIR] Update/fix memref region computation for affine.parallel ops
Tue, Mar 14, 6:19 PM · Restricted Project, Restricted Project
bondhugula closed D145669: [MLIR] Update/fix memref region computation for affine.parallel ops.
Tue, Mar 14, 6:19 PM · Restricted Project, Restricted Project
bondhugula added a comment to D145669: [MLIR] Update/fix memref region computation for affine.parallel ops.

Thanks for the review.

Tue, Mar 14, 6:18 PM · Restricted Project, Restricted Project
bondhugula updated the diff for D145669: [MLIR] Update/fix memref region computation for affine.parallel ops.

Address review comments.

Tue, Mar 14, 6:18 PM · Restricted Project, Restricted Project

Fri, Mar 10

bondhugula accepted D145796: [mlir][affine][analysis] Fix `getClosedUB` handling in `getSliceBounds`.
Fri, Mar 10, 4:21 PM · Restricted Project, Restricted Project

Thu, Mar 9

bondhugula updated the diff for D145669: [MLIR] Update/fix memref region computation for affine.parallel ops.

Update commit summary.

Thu, Mar 9, 1:22 AM · Restricted Project, Restricted Project
bondhugula requested review of D145669: [MLIR] Update/fix memref region computation for affine.parallel ops.
Thu, Mar 9, 12:31 AM · Restricted Project, Restricted Project

Tue, Mar 7

bondhugula committed rG622702d08948: [MLIR] Fix affine analysis check for ops with no common block (authored by bondhugula).
[MLIR] Fix affine analysis check for ops with no common block
Tue, Mar 7, 9:47 AM · Restricted Project, Restricted Project
bondhugula closed D145460: [MLIR] Fix affine analysis check for ops with no common block.
Tue, Mar 7, 9:47 AM · Restricted Project, Restricted Project
bondhugula accepted D144712: [mlir][affine] add memory effect traits for dmaOp.

LGTM - thanks!

Tue, Mar 7, 8:55 AM · Restricted Project, Restricted Project

Mon, Mar 6

bondhugula updated the diff for D145460: [MLIR] Fix affine analysis check for ops with no common block.

Add test case comment.

Mon, Mar 6, 7:12 PM · Restricted Project, Restricted Project
bondhugula added a reviewer for D145460: [MLIR] Fix affine analysis check for ops with no common block: Colloportus0.
Mon, Mar 6, 7:08 PM · Restricted Project, Restricted Project
bondhugula requested review of D145460: [MLIR] Fix affine analysis check for ops with no common block.
Mon, Mar 6, 7:07 PM · Restricted Project, Restricted Project

Mon, Feb 27

bondhugula committed rGa2802dd24f62: [MLIR] Fix bug in addAffineParallelOpDomain upper bound constraint (authored by bondhugula).
[MLIR] Fix bug in addAffineParallelOpDomain upper bound constraint
Mon, Feb 27, 9:06 PM · Restricted Project, Restricted Project
bondhugula closed D144836: Fix bug in addAffineParallelOpDomain upper bound constraint.
Mon, Feb 27, 9:06 PM · Restricted Project, Restricted Project

Sun, Feb 26

bondhugula updated the diff for D144836: Fix bug in addAffineParallelOpDomain upper bound constraint.

Update test case.

Sun, Feb 26, 8:54 PM · Restricted Project, Restricted Project
bondhugula updated the diff for D144836: Fix bug in addAffineParallelOpDomain upper bound constraint.

Adjust test case CHECK.

Sun, Feb 26, 8:52 PM · Restricted Project, Restricted Project
bondhugula requested review of D144836: Fix bug in addAffineParallelOpDomain upper bound constraint.
Sun, Feb 26, 6:04 PM · Restricted Project, Restricted Project

Mon, Feb 20

bondhugula committed rG332b8cf1f689: [MLIR][Affine] Fix affine.parallel op domain add (authored by bondhugula).
[MLIR][Affine] Fix affine.parallel op domain add
Mon, Feb 20, 8:47 PM · Restricted Project, Restricted Project
bondhugula closed D144349: [MLIR][Affine] Fix affine.parallel op domain add.
Mon, Feb 20, 8:46 PM · Restricted Project, Restricted Project
bondhugula committed rG8a583dd22012: [MLIR] Add replaceUsesWithIf on Operation (authored by bondhugula).
[MLIR] Add replaceUsesWithIf on Operation
Mon, Feb 20, 8:45 PM · Restricted Project, Restricted Project
bondhugula closed D144348: [MLIR] Add replaceUsesWithIf on Operation.
Mon, Feb 20, 8:45 PM · Restricted Project, Restricted Project

Feb 19 2023

bondhugula requested review of D144349: [MLIR][Affine] Fix affine.parallel op domain add.
Feb 19 2023, 5:41 AM · Restricted Project, Restricted Project
bondhugula added a reviewer for D144348: [MLIR] Add replaceUsesWithIf on Operation: lattner.
Feb 19 2023, 5:30 AM · Restricted Project, Restricted Project
bondhugula updated the diff for D144348: [MLIR] Add replaceUsesWithIf on Operation.

Fix spacing.

Feb 19 2023, 5:30 AM · Restricted Project, Restricted Project
bondhugula requested review of D144348: [MLIR] Add replaceUsesWithIf on Operation.
Feb 19 2023, 5:27 AM · Restricted Project, Restricted Project

Feb 13 2023

bondhugula accepted D142082: [mlir][affine] Normalize constant valued bound loop.

LGTM - thanks.

Feb 13 2023, 3:00 AM · Restricted Project, Restricted Project
bondhugula accepted D143728: [MLIR][Presburger] Matrix: hide expensive consistency check behind EXPENSIVE_CHECKS macro.

LGTM - thanks

Feb 13 2023, 2:56 AM · Restricted Project, Restricted Project

Feb 12 2023

bondhugula added a comment to D142082: [mlir][affine] Normalize constant valued bound loop.

Can you please update the commit summary? It's no longer reflective of the change.

Feb 12 2023, 4:52 AM · Restricted Project, Restricted Project

Feb 10 2023

bondhugula added inline comments to D143728: [MLIR][Presburger] Matrix: hide expensive consistency check behind EXPENSIVE_CHECKS macro.
Feb 10 2023, 1:40 PM · Restricted Project, Restricted Project
bondhugula added inline comments to D143728: [MLIR][Presburger] Matrix: hide expensive consistency check behind EXPENSIVE_CHECKS macro.
Feb 10 2023, 1:39 PM · Restricted Project, Restricted Project
bondhugula added inline comments to D142082: [mlir][affine] Normalize constant valued bound loop.
Feb 10 2023, 1:36 PM · Restricted Project, Restricted Project
bondhugula committed rG687f78210d07: [MLIR] Fold away divs and mods in affine ops with operand info (authored by bondhugula).
[MLIR] Fold away divs and mods in affine ops with operand info
Feb 10 2023, 12:12 AM · Restricted Project, Restricted Project
bondhugula closed D143456: [MLIR] Fold away divs and mods in affine ops with operand info.
Feb 10 2023, 12:11 AM · Restricted Project, Restricted Project
bondhugula updated the diff for D143456: [MLIR] Fold away divs and mods in affine ops with operand info.

Address review comments.

Feb 10 2023, 12:10 AM · Restricted Project, Restricted Project
bondhugula added a comment to D143456: [MLIR] Fold away divs and mods in affine ops with operand info.

Thanks for the review!

Feb 10 2023, 12:04 AM · Restricted Project, Restricted Project

Feb 9 2023

bondhugula committed rGe6edc1bd69c8: [MLIR] Fix non-deterministic generation from buffer-deallocation pass (authored by bondhugula).
[MLIR] Fix non-deterministic generation from buffer-deallocation pass
Feb 9 2023, 3:23 PM · Restricted Project, Restricted Project
bondhugula closed D143622: [MLIR] Fix non-deterministic generation from buffer-deallocation pass.
Feb 9 2023, 3:22 PM · Restricted Project, Restricted Project

Feb 8 2023

bondhugula added reviewers for D143622: [MLIR] Fix non-deterministic generation from buffer-deallocation pass: mehdi_amini, rriddle.
Feb 8 2023, 6:54 PM · Restricted Project, Restricted Project
bondhugula requested review of D143622: [MLIR] Fix non-deterministic generation from buffer-deallocation pass.
Feb 8 2023, 6:53 PM · Restricted Project, Restricted Project

Feb 6 2023

bondhugula requested review of D143456: [MLIR] Fold away divs and mods in affine ops with operand info.
Feb 6 2023, 7:24 PM · Restricted Project, Restricted Project

Feb 1 2023

bondhugula committed rG978c744b3774: [mlir][NFC] Clean and Fix broken Affine documentation (authored by sotoshigoto).
[mlir][NFC] Clean and Fix broken Affine documentation
Feb 1 2023, 3:33 AM · Restricted Project, Restricted Project
bondhugula closed D142858: [mlir][NFC] Clean and Fix broken Affine documentation.
Feb 1 2023, 3:32 AM · Restricted Project, Restricted Project
bondhugula accepted D142858: [mlir][NFC] Clean and Fix broken Affine documentation.
Feb 1 2023, 3:28 AM · Restricted Project, Restricted Project

Jan 30 2023

bondhugula added a comment to D142858: [mlir][NFC] Clean and Fix broken Affine documentation.

The patch has two whitespace errors. Can you please fix these? I can land it otherwise.

git diff --check HEAD~
mlir/include/mlir/Dialect/Affine/IR/AffineOps.td:510: trailing whitespace.
+    
mlir/include/mlir/Dialect/Affine/IR/AffineOps.td:877: trailing whitespace.
+
Jan 30 2023, 10:52 PM · Restricted Project, Restricted Project
bondhugula added inline comments to D142082: [mlir][affine] Normalize constant valued bound loop.
Jan 30 2023, 5:40 PM · Restricted Project, Restricted Project
bondhugula committed rG3ab88e795c71: [MLIR] Remove unnecessary Block argument on MemRefDependenceGraph::init (authored by bondhugula).
[MLIR] Remove unnecessary Block argument on MemRefDependenceGraph::init
Jan 30 2023, 5:31 PM · Restricted Project, Restricted Project
bondhugula closed D142597: [MLIR] Remove unnecessary Block argument on MemRefDependenceGraph::init.
Jan 30 2023, 5:30 PM · Restricted Project, Restricted Project

Jan 29 2023

bondhugula added a reviewer for D142868: [mlir][NFC] Cleanup Passes documentation: bondhugula.
Jan 29 2023, 10:56 PM · Restricted Project, Restricted Project
bondhugula accepted D142858: [mlir][NFC] Clean and Fix broken Affine documentation.

LGTM - thanks very much.

Jan 29 2023, 10:51 PM · Restricted Project, Restricted Project
bondhugula added inline comments to D142082: [mlir][affine] Normalize constant valued bound loop.
Jan 29 2023, 4:19 AM · Restricted Project, Restricted Project

Jan 26 2023

bondhugula updated the diff for D142597: [MLIR] Remove unnecessary Block argument on MemRefDependenceGraph::init.

Adjust/improve debug messsages.

Jan 26 2023, 1:46 AM · Restricted Project, Restricted Project

Jan 25 2023

bondhugula updated the diff for D142597: [MLIR] Remove unnecessary Block argument on MemRefDependenceGraph::init.

Remove stale comment.

Jan 25 2023, 10:47 PM · Restricted Project, Restricted Project
bondhugula requested review of D142597: [MLIR] Remove unnecessary Block argument on MemRefDependenceGraph::init.
Jan 25 2023, 6:34 PM · Restricted Project, Restricted Project
bondhugula added a comment to D142082: [mlir][affine] Normalize constant valued bound loop.

Comments on test cases.

Jan 25 2023, 5:29 PM · Restricted Project, Restricted Project

Jan 23 2023

bondhugula added inline comments to D142082: [mlir][affine] Normalize constant valued bound loop.
Jan 23 2023, 7:31 PM · Restricted Project, Restricted Project
bondhugula requested changes to D142082: [mlir][affine] Normalize constant valued bound loop.

Thank you for reporting and attempting to fix https://github.com/llvm/llvm-project/issues/59994. Some comments.

Jan 23 2023, 7:31 PM · Restricted Project, Restricted Project

Jan 20 2023

bondhugula added inline comments to D142204: [mlir] fix outdated assert in affine symbol verification.
Jan 20 2023, 8:27 AM · Restricted Project, Restricted Project
bondhugula accepted D142204: [mlir] fix outdated assert in affine symbol verification.

LGTM.

Jan 20 2023, 8:27 AM · Restricted Project, Restricted Project

Jan 19 2023

bondhugula committed rG6b2e29c5080e: NFC. Refactor affine fusion code for readability (authored by bondhugula).
NFC. Refactor affine fusion code for readability
Jan 19 2023, 11:50 PM · Restricted Project, Restricted Project
bondhugula closed D142076: NFC. Refactor affine fusion code for readability.
Jan 19 2023, 11:50 PM · Restricted Project, Restricted Project

Jan 18 2023

bondhugula updated the diff for D142076: NFC. Refactor affine fusion code for readability.

Some more NFC for the code touched.

Jan 18 2023, 7:48 PM · Restricted Project, Restricted Project
bondhugula requested review of D142076: NFC. Refactor affine fusion code for readability.
Jan 18 2023, 7:18 PM · Restricted Project, Restricted Project

Jan 11 2023

bondhugula committed rG1fb096e0e3f7: [MLIR][Affine] Fix affine scalrep - add missing check (authored by bondhugula).
[MLIR][Affine] Fix affine scalrep - add missing check
Jan 11 2023, 10:20 PM · Restricted Project, Restricted Project
bondhugula closed D141255: [MLIR][Affine] Fix affine scalrep - add missing check.
Jan 11 2023, 10:19 PM · Restricted Project, Restricted Project
bondhugula updated the diff for D141255: [MLIR][Affine] Fix affine scalrep - add missing check.

Remove extra new line.

Jan 11 2023, 10:19 PM · Restricted Project, Restricted Project
bondhugula committed rG23bcd6b86271: [MLIR] Fix affine analysis methods for affine.parallel (authored by bondhugula).
[MLIR] Fix affine analysis methods for affine.parallel
Jan 11 2023, 10:17 PM · Restricted Project, Restricted Project
bondhugula closed D141254: [MLIR] Fix affine analysis methods for affine.parallel.
Jan 11 2023, 10:17 PM · Restricted Project, Restricted Project
bondhugula added inline comments to D141254: [MLIR] Fix affine analysis methods for affine.parallel.
Jan 11 2023, 10:16 PM · Restricted Project, Restricted Project
bondhugula updated the diff for D141254: [MLIR] Fix affine analysis methods for affine.parallel.

Update test case func name.

Jan 11 2023, 10:16 PM · Restricted Project, Restricted Project
bondhugula committed rG978ca8cae26e: Canonicalize affine set + operands while adding affine.if op domain (authored by bondhugula).
Canonicalize affine set + operands while adding affine.if op domain
Jan 11 2023, 10:14 PM · Restricted Project, Restricted Project
bondhugula closed D141250: Canonicalize affine set + operands while adding affine.if op domain.
Jan 11 2023, 10:14 PM · Restricted Project, Restricted Project

Jan 10 2023

bondhugula added inline comments to D141250: Canonicalize affine set + operands while adding affine.if op domain.
Jan 10 2023, 7:27 AM · Restricted Project, Restricted Project

Jan 9 2023

bondhugula accepted D141106: [mlir][affine] fix affine LICM pass for has effected memory's user.

LGTM - thanks for fixing this.

Jan 9 2023, 8:12 AM · Restricted Project, Restricted Project

Jan 8 2023

bondhugula updated the diff for D141250: Canonicalize affine set + operands while adding affine.if op domain.

NFC - remove dead stuff from AffineStructures.h

Jan 8 2023, 10:29 PM · Restricted Project, Restricted Project