User Details
- User Since
- Dec 14 2019, 8:54 PM (170 w, 3 d)
Today
Rebase and add a comment.
Yesterday
Incorporate review suggestion.
LGTM
Rebase.
Mon, Mar 20
Add CHECK-LABEL line.
Sun, Mar 19
Dismissing change request that has now been addressed. This is now purely a GPU transform ops related revision. Any of the other reviewers familiar/interested in transforms ops may be able to review it.
Update commit summary.
Thu, Mar 16
Please split out the IR/ changes out from the TransformOps/ changes if appropriate; add test cases for linear_id/lane_id op and its lowering - it doesn't seem to itself appear in test cases. It looks odd that the only code manipulating a GPU IR dialect op appears in TransformOps/. Commit summary appears incomplete - doesn't seems to capture all the changes.
Tue, Mar 14
Drop extra braces + else nearly.
Thanks for the review.
Address review comments.
Fri, Mar 10
Thu, Mar 9
Update commit summary.
Tue, Mar 7
LGTM - thanks!
Mon, Mar 6
Add test case comment.
Mon, Feb 27
Sun, Feb 26
Update test case.
Adjust test case CHECK.
Mon, Feb 20
Feb 19 2023
Fix spacing.
Feb 13 2023
LGTM - thanks.
LGTM - thanks
Feb 12 2023
Can you please update the commit summary? It's no longer reflective of the change.
Feb 10 2023
Address review comments.
Thanks for the review!
Feb 9 2023
Feb 8 2023
Feb 6 2023
Feb 1 2023
Jan 30 2023
The patch has two whitespace errors. Can you please fix these? I can land it otherwise.
git diff --check HEAD~ mlir/include/mlir/Dialect/Affine/IR/AffineOps.td:510: trailing whitespace. + mlir/include/mlir/Dialect/Affine/IR/AffineOps.td:877: trailing whitespace. +
Jan 29 2023
LGTM - thanks very much.
Jan 26 2023
Adjust/improve debug messsages.
Jan 25 2023
Remove stale comment.
Comments on test cases.
Jan 23 2023
Thank you for reporting and attempting to fix https://github.com/llvm/llvm-project/issues/59994. Some comments.
Jan 20 2023
LGTM.
Jan 19 2023
Jan 18 2023
Some more NFC for the code touched.
Jan 11 2023
Remove extra new line.
Update test case func name.
Jan 10 2023
Jan 9 2023
LGTM - thanks for fixing this.
Jan 8 2023
NFC - remove dead stuff from AffineStructures.h