- User Since
- Aug 25 2020, 4:03 PM (161 w, 3 d)
Mon, Sep 18
Isn't phabricator deprecated now, and all new reviews should be done on github?
Thu, Sep 7
@dblaikie ping. :) Do you want to continue review here or in github?
Wed, Sep 6
OK trying new workflow:
Fri, Sep 1
Also might be easier to explain to an "average" user "Just run llvm-dwarfdump --main-binary=<path_to_main_binary> --debug-info <path_to_dwo>" Vs Dump this DWO, look up DWOID (explain where it is in DWARF4 vs 5), then run llvm-dwarfdump again now with main binary with these flags.
update from upstream branch
Will add tests if the approach is acceptable.
@dblaikie @bulbazord @JDevlieghere WDYT of this approach?
@clayborg One suggestion, maybe move EnableMultiThreading optional paramenter to the end of argument list? That way constructors in other projects don't need to be modified? Right now this will break LLD and BOLT builds.
Thu, Aug 31
Aug 28 2023
Tried locally to confirm and build of a module succeeds.
Thank you for fixing it.
@huangjd Do you think you will have time to change implementation to unordered_map as discussed by EOD, otherwise I am reverting the diff to unblock out validation testing.
Aug 25 2023
@huangjd can you follow up and change to unordered_map, so whole diff doesn't have to be reverted?
@davidxl While discussion continues can the patch be reverted, or at least changed to unordered_map for now (preferably the former). It has been impacting our internal testing of trunk for a week now.
Aug 24 2023
I think https://reviews.llvm.org/D147740 should be reverted and concerns addressed in that patch next re-land.
This does seem to fix memory corruption.
That being said I think I am with @wenlei on this. The implementation seems fragile as DenseMap, apparently, doesn't offer reference stability. Which leads to these kind of workarounds, and more then likely more issues down the road.
Aug 23 2023
Aug 22 2023
MSAN output. Does this ring any bells?
Aug 21 2023
This diff is causing clang to crash on one of our builds, when clang is linked with jemalloc.
-DCMAKE_EXE_LINKER_FLAGS="-L /usr/lib64 -Wl,-rpath,/usr/lib64 -ljemalloc" \
Aug 17 2023
I am somewhat confused about how this is a performance regression. Doesn't sound like it currently working in multi threaded environment anyway. If it is implemented as is, I don't believe most tools that process debug information are multi threaded, and even if they are majority of time is spent actually parsing debug information.
Aug 14 2023
cleaned up dwarf5-loclist.s
Aug 11 2023
Fixed dwarf version in commands
Aug 10 2023
Aug 9 2023
Does this need a test?
Aug 8 2023
Aug 7 2023
Aug 3 2023
Restored formating in rest of the file
Aug 2 2023
Jul 31 2023
added how gc assembly files were generated
Added test, addressed comments.
Jul 30 2023
updated warning check
Jul 28 2023
addressed some of the comments
Jul 26 2023
Jul 20 2023
I don't remember anything about this code. :)
Can you add a test, and I guess this was submitted through web UI, can you do it with -999 so surrounding code can be viewed?