User Details
- User Since
- Aug 25 2020, 4:03 PM (32 w, 5 d)
Wed, Apr 7
nit changes
nit
nit
Added a test using APIs, moved getHeaderSize from protected to public. Aligns with other get APIs that are already public.
Tue, Apr 6
Mon, Apr 5
Wed, Mar 31
Mon, Mar 15
Thank You!
Oh right. Windows...
@dblaikie if you are busy I can put up a diff.
Doing should work I think.
- CHECK: 0x11
- CHECK-NEXT: f2()
- CHECK-NEXT: splitdwarf-single-issue.cpp:7:3
- CHECK-NEXT: main
- CHECK-NEXT: splitdwarf-single-issue.cpp:13:3
Thanks for committing, and refactoring test. Didn't know about --defsym.
That would be great. I don't have commit access yet.
Renamed .s to same name as test.
@dblaikie You were right, it's possible. Just need to use non-relocated address and remove some sections. If all good, will commit.
Changed to use assembly.
Trying through ARC, removed modified file that snuck in.
Trying through arc.
Mar 12 2021
Mar 11 2021
Mar 8 2021
Per discussion with @dblaikie going to go with this approach. Need to add test + see if we can avoid redundant checks.
Feb 18 2021
Feb 16 2021
Thanks!
Feb 11 2021
Gotcha, thanks. Yeah I abandoned it on my end.
@MaskRay saw you marking this as "Needs revision", is that just a general way of not accepting diff?
Feb 8 2021
From what I remember the discussion went back and forth with no real conclusion. I might be miss remembering, so please correct me if I am wrong.
This patch can be a short/medium term bridge to a more comprehensive solution. If I am understanding it correctly it also deals with a problem of sections like .debug_loc.
Jan 13 2021
Jan 11 2021
Jan 8 2021
rebased on latest.
Jan 6 2021
Well print-map does have size and address information scattered throughout what is potentially quite a large output. I think it will be useful to have a summary that can be quickly referenced with all the information in one place.
Maybe split the difference and add it as part of -print-map as a summary that gets printed before?
Jan 5 2021
Jan 4 2021
Dec 23 2020
Dec 22 2020
Dec 21 2020
To reproduce this config should do the trick:
This diff seems to be causing issue building llvm with clang-tools-extra;openmp projects enabled. Basically in self hoisting mode.
Dec 18 2020
Dec 17 2020
@tejohnson I was wondering where does this @anon.{{.*}} gets set, or in general where can I find more information about it.
@ggeorgakoudis In our local build environment I am now observing error below:
Dec 16 2020
Dec 14 2020
Dec 7 2020
From: David Blaikie via Phabricator <reviews@reviews.llvm.org>
Sent: Monday, December 7, 2020 11:08 AM
To: Alexander Yermolovich <ayermolo@fb.com>; llvm-commits@lists.llvm.org <llvm-commits@lists.llvm.org>
Cc: Hongtao Yu <hoy@fb.com>; jan_svoboda@apple.com <jan_svoboda@apple.com>; stevenwu@apple.com <stevenwu@apple.com>; dany.grumberg@gmail.com <dany.grumberg@gmail.com>; Wenlei He <wenlei@fb.com>; dexonsmith@apple.com <dexonsmith@apple.com>; cfe-commits@lists.llvm.org <cfe-commits@lists.llvm.org>; maskray@google.com <maskray@google.com>; ikudrin@accesssoftek.com <ikudrin@accesssoftek.com>; bhuvanendra.kumarn@amd.com <bhuvanendra.kumarn@amd.com>; mlekena@skidmore.edu <mlekena@skidmore.edu>; blitzrakete@gmail.com <blitzrakete@gmail.com>; shenhan@google.com <shenhan@google.com>; orlando.hyams@sony.com <orlando.hyams@sony.com>
Subject: [PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64
Nov 20 2020
Nov 19 2020
Nov 18 2020
Nov 17 2020
Nov 16 2020
Nov 12 2020
@jansvoboda11 Can you take a look? The failing test is unrelated it seems. Fails locally even without my change.
Nov 9 2020
The failure seems unrelated to my changes. Trying locally it fails with latest upstream even without my changes.
Nov 6 2020
Nov 5 2020
@ikudrin Can you elaborate on LLD changes. I recently started to look in to it. Reason I am interested in this, internally we are a looking in to using DWARF64, so I have bandwidth, and incentive, to help with it implementation and adoption.
Nov 4 2020
@ikudrin What else is left on clang side? I added a diff for passing a flag from clang to be, need to see what's up with failures, anything else that needs to be done?
Testing it locally I was able to generate binary with DWARF64, that llvm-dwarf is able to parse it. Looks like gdb and lldb support varies.
Nov 2 2020
Oct 30 2020
Oct 28 2020
Awesome, thanks.
I was trying to pass in -dwarf64 through our build system, but was still seeing 32 bit relocations. Will dig further on my end.
Thanks for working on this.
Oct 27 2020
@ikudrin To clarify this will emit R_X86_64_64 bit relocations for .debug_info on 64 bit platform, correct?
Sep 30 2020
Sep 23 2020
Sep 22 2020
Sep 15 2020
Thank you @craig.topper @wenlei
@craig.topper Any more questions/concerns? Can you approve?
@avl Would it be possible to rebase this on latest, or is this diff abandoned?
Sep 8 2020
We are linking against Intel Composer XE in to which svml libraries were added. I do believe they are from icc.
Sep 4 2020
Sep 3 2020
@wenlei Thanks!
Sep 2 2020
Hi, can someone take a look at this please?