Page MenuHomePhabricator

avogelsgesang (Adrian Vogelsgesang)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 13 2021, 10:17 AM (21 w, 1 d)

Recent Activity

Today

avogelsgesang added a comment to D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`.

What name and email address would you like me to use for patch attribution?

Wed, Dec 8, 10:13 AM · Restricted Project

Wed, Dec 1

avogelsgesang added a comment to D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`.

@aaron.ballman can you please commit this on my behalf? I don't have commit access

Wed, Dec 1, 1:14 PM · Restricted Project
avogelsgesang updated the diff for D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`.

Add missing dot to comment

Wed, Dec 1, 1:13 PM · Restricted Project
avogelsgesang retitled D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value` from [clang-tidy] Improve fix-its for `modernize-pass-by-value` check to [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`.
Wed, Dec 1, 11:17 AM · Restricted Project
avogelsgesang added a comment to D112646: [clang-tidy] Add `readability-container-contains` check.

Thanks for the instructions on how to build the documentation!
I fixed a build issue in the docs (incorrect length of the table footer) and updated the wording slightly

Wed, Dec 1, 10:38 AM · Restricted Project
avogelsgesang updated the diff for D112646: [clang-tidy] Add `readability-container-contains` check.

Fix build error in documentation and update wording

Wed, Dec 1, 10:32 AM · Restricted Project
avogelsgesang added inline comments to D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`.
Wed, Dec 1, 9:23 AM · Restricted Project
avogelsgesang updated the diff for D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`.

Address review comments

Wed, Dec 1, 9:22 AM · Restricted Project

Fri, Nov 26

avogelsgesang added inline comments to D112646: [clang-tidy] Add `readability-container-contains` check.
Fri, Nov 26, 9:25 AM · Restricted Project
avogelsgesang updated the diff for D112646: [clang-tidy] Add `readability-container-contains` check.

Address review comments

Fri, Nov 26, 9:25 AM · Restricted Project

Wed, Nov 17

avogelsgesang updated the diff for D112646: [clang-tidy] Add `readability-container-contains` check.

Fix test case

Wed, Nov 17, 6:27 AM · Restricted Project

Tue, Nov 16

avogelsgesang added inline comments to D112646: [clang-tidy] Add `readability-container-contains` check.
Tue, Nov 16, 10:46 AM · Restricted Project
avogelsgesang updated the diff for D112646: [clang-tidy] Add `readability-container-contains` check.

Address review comments by @whisperity:

Tue, Nov 16, 10:42 AM · Restricted Project

Mon, Nov 15

avogelsgesang updated subscribers of D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`.

@ymandel, @whisperity, @aaron.ballman could one of you review this/point me in the direction of a good reviewer for this change?
(Sorry for the spam - I am new to the LLVM project, and I guess I still have to learn how to navigate Phabricator/find the correct reviewers for my changes)

Mon, Nov 15, 10:35 AM · Restricted Project
avogelsgesang added a comment to D112646: [clang-tidy] Add `readability-container-contains` check.

@xazax.hun / @whisperity could you review this change for me, please :)
Or, alternatively: can you direct me to somebody who could review?

Mon, Nov 15, 10:25 AM · Restricted Project
avogelsgesang updated the diff for D112646: [clang-tidy] Add `readability-container-contains` check.

Update docs to also mention container.find() != container.end()

Mon, Nov 15, 10:20 AM · Restricted Project

Thu, Nov 11

avogelsgesang added a comment to D112647: [clang-apply-replacements] Correctly handle relative paths.

Thanks for the reviews, @ymandel and @hokein!

Thu, Nov 11, 9:59 AM · Restricted Project
avogelsgesang updated the diff for D112647: [clang-apply-replacements] Correctly handle relative paths.

Don't update WorkingDir through local reference; as requested @ymandel and @hokein

Thu, Nov 11, 5:42 AM · Restricted Project

Tue, Nov 9

avogelsgesang added a comment to D112647: [clang-apply-replacements] Correctly handle relative paths.

@alexfh, @ymandel: Do you know who could review this change?

Tue, Nov 9, 5:59 AM · Restricted Project
avogelsgesang added a comment to D112646: [clang-tidy] Add `readability-container-contains` check.

gentle ping

Tue, Nov 9, 5:50 AM · Restricted Project

Nov 2 2021

avogelsgesang updated the diff for D112647: [clang-apply-replacements] Correctly handle relative paths.

Use llvm::Optional instead of pointer as suggested by @ymandel

Nov 2 2021, 2:36 PM · Restricted Project
avogelsgesang added a comment to D112646: [clang-tidy] Add `readability-container-contains` check.

[...] If we want to follow container-size-empty's convention, we should include the replaced method in the name [...]

Nov 2 2021, 2:11 PM · Restricted Project
avogelsgesang updated subscribers of D112647: [clang-apply-replacements] Correctly handle relative paths.

Those relative paths are meant to be resolved relative to the corresponding build directory.

Is this behavior documented somewhere?

Nov 2 2021, 7:32 AM · Restricted Project

Oct 28 2021

avogelsgesang added inline comments to D112646: [clang-tidy] Add `readability-container-contains` check.
Oct 28 2021, 4:14 AM · Restricted Project
avogelsgesang updated the diff for D112646: [clang-tidy] Add `readability-container-contains` check.

Fix formatting; remove unrelated changes

Oct 28 2021, 4:11 AM · Restricted Project
avogelsgesang added inline comments to D112646: [clang-tidy] Add `readability-container-contains` check.
Oct 28 2021, 3:48 AM · Restricted Project
avogelsgesang added a comment to D112646: [clang-tidy] Add `readability-container-contains` check.

Why readability-, if the intent is to make users move to a newer API?

Oct 28 2021, 3:44 AM · Restricted Project

Oct 27 2021

avogelsgesang added a reviewer for D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`: alexfh.

not sure whom to add as a reviewer. According to git log this check wasn't changed for a while...
Adding @alexfh based on CODE_OWNERS.TXT

Oct 27 2021, 12:28 PM · Restricted Project
avogelsgesang added reviewers for D112647: [clang-apply-replacements] Correctly handle relative paths: ymandel, njames93.

Adding reviewers based on git log

Oct 27 2021, 12:20 PM · Restricted Project
avogelsgesang requested review of D112648: [clang-tidy] Don't offer partial fix-its for `modernize-pass-by-value`.
Oct 27 2021, 11:58 AM · Restricted Project
avogelsgesang updated the diff for D112647: [clang-apply-replacements] Correctly handle relative paths.

Remove unrelated changes

Oct 27 2021, 11:52 AM · Restricted Project
avogelsgesang requested review of D112647: [clang-apply-replacements] Correctly handle relative paths.
Oct 27 2021, 11:50 AM · Restricted Project
avogelsgesang requested review of D112646: [clang-tidy] Add `readability-container-contains` check.
Oct 27 2021, 11:49 AM · Restricted Project
avogelsgesang abandoned D106143: [CMake][TSAN] Add build dependency against libcxx.
Oct 27 2021, 11:16 AM · Restricted Project

Oct 18 2021

avogelsgesang added a comment to D108696: [Coroutines] [Frontend] Lookup in std namespace first.

sorry for what might be naive questions, but just to make sure I understand the context of this patch correctly:

Oct 18 2021, 3:39 AM · Restricted Project, Restricted Project, Restricted Project

Sep 2 2021

avogelsgesang added inline comments to D108696: [Coroutines] [Frontend] Lookup in std namespace first.
Sep 2 2021, 2:19 AM · Restricted Project, Restricted Project, Restricted Project

Aug 31 2021

avogelsgesang added a comment to D87171: Implement P0919R3.

makes perfect sense

Aug 31 2021, 7:30 AM · Restricted Project
avogelsgesang added a comment to D87171: Implement P0919R3.

is this really P0919R3?
Looks to me more like P0919R0

Aug 31 2021, 6:05 AM · Restricted Project

Jul 16 2021

avogelsgesang added inline comments to D106143: [CMake][TSAN] Add build dependency against libcxx.
Jul 16 2021, 3:02 PM · Restricted Project
avogelsgesang added a comment to D106143: [CMake][TSAN] Add build dependency against libcxx.

Oh, and I should probably add: I observed those build issues on the 12.0.1 release. I didn't try to build HEAD, yet.
So it might be that in the meantime this race condition was fixed in some other, probably better way than my proposed patch - not sure.
You probably have a better overview over LLVM than I do, and maybe something comes to your mind which might have fixed this already...

Jul 16 2021, 2:33 PM · Restricted Project
avogelsgesang added a comment to D106143: [CMake][TSAN] Add build dependency against libcxx.

That error shows issue when compiling ASan, not TSan, so I'm still not sure why this change is needed?

Jul 16 2021, 2:28 PM · Restricted Project
avogelsgesang added a comment to D106143: [CMake][TSAN] Add build dependency against libcxx.

Some more context:

Jul 16 2021, 7:01 AM · Restricted Project
avogelsgesang added a reviewer for D106143: [CMake][TSAN] Add build dependency against libcxx: phosek.

Adding phosek based on his commit 6db314e86b26741c2e29ce51d88a6a5dca35336c

Jul 16 2021, 6:52 AM · Restricted Project
avogelsgesang added reviewers for D106143: [CMake][TSAN] Add build dependency against libcxx: chandlerc, kcc.

Adding reviewers based on CODE_OWNERS.TXT

Jul 16 2021, 6:47 AM · Restricted Project
avogelsgesang updated subscribers of D106143: [CMake][TSAN] Add build dependency against libcxx.
Jul 16 2021, 6:44 AM · Restricted Project
avogelsgesang requested review of D106143: [CMake][TSAN] Add build dependency against libcxx.
Jul 16 2021, 5:29 AM · Restricted Project