- User Since
- Jul 13 2021, 10:17 AM (21 w, 1 d)
What name and email address would you like me to use for patch attribution?
Wed, Dec 1
@aaron.ballman can you please commit this on my behalf? I don't have commit access
Add missing dot to comment
Thanks for the instructions on how to build the documentation!
I fixed a build issue in the docs (incorrect length of the table footer) and updated the wording slightly
Fix build error in documentation and update wording
Address review comments
Fri, Nov 26
Address review comments
Wed, Nov 17
Fix test case
Tue, Nov 16
Address review comments by @whisperity:
Mon, Nov 15
@ymandel, @whisperity, @aaron.ballman could one of you review this/point me in the direction of a good reviewer for this change?
(Sorry for the spam - I am new to the LLVM project, and I guess I still have to learn how to navigate Phabricator/find the correct reviewers for my changes)
Update docs to also mention container.find() != container.end()
Thu, Nov 11
Tue, Nov 9
Nov 2 2021
Use llvm::Optional instead of pointer as suggested by @ymandel
[...] If we want to follow container-size-empty's convention, we should include the replaced method in the name [...]
Those relative paths are meant to be resolved relative to the corresponding build directory.
Is this behavior documented somewhere?
Oct 28 2021
Fix formatting; remove unrelated changes
Why readability-, if the intent is to make users move to a newer API?
Oct 27 2021
not sure whom to add as a reviewer. According to git log this check wasn't changed for a while...
Adding @alexfh based on CODE_OWNERS.TXT
Adding reviewers based on git log
Remove unrelated changes
Oct 18 2021
sorry for what might be naive questions, but just to make sure I understand the context of this patch correctly:
Sep 2 2021
Aug 31 2021
makes perfect sense
Jul 16 2021
Oh, and I should probably add: I observed those build issues on the 12.0.1 release. I didn't try to build HEAD, yet.
So it might be that in the meantime this race condition was fixed in some other, probably better way than my proposed patch - not sure.
You probably have a better overview over LLVM than I do, and maybe something comes to your mind which might have fixed this already...
That error shows issue when compiling ASan, not TSan, so I'm still not sure why this change is needed?
Some more context:
Adding phosek based on his commit 6db314e86b26741c2e29ce51d88a6a5dca35336c
Adding reviewers based on CODE_OWNERS.TXT