Page MenuHomePhabricator

clementval (Valentin Clement)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2019, 1:05 PM (40 w, 2 d)

Recent Activity

Fri, Sep 18

clementval updated subscribers of D87846: [OpenMP][flang]Lower NUM_THREADS clause for parallel construct.
Fri, Sep 18, 12:25 PM · Restricted Project, Restricted Project
clementval added a comment to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..

Pleas add test like the following one where we check the error:

Fri, Sep 18, 10:59 AM · Restricted Project
clementval committed rG88a1d402d6c6: [mlir][openacc] Add missing operands for acc.data operation (authored by clementval).
[mlir][openacc] Add missing operands for acc.data operation
Fri, Sep 18, 8:52 AM
clementval closed D87874: [mlir][openacc] Add missing operands for acc.data operation.
Fri, Sep 18, 8:52 AM · Restricted Project
clementval updated the diff for D87874: [mlir][openacc] Add missing operands for acc.data operation.

Rebase + review comment

Fri, Sep 18, 8:51 AM · Restricted Project
clementval added inline comments to D87874: [mlir][openacc] Add missing operands for acc.data operation.
Fri, Sep 18, 8:51 AM · Restricted Project
clementval committed rG22dde1f92f68: [mlir][openacc] Support Index and AnyInteger in loop op (authored by clementval).
[mlir][openacc] Support Index and AnyInteger in loop op
Fri, Sep 18, 8:38 AM
clementval closed D87848: [mlir][openacc] Support Index and AnyInteger in loop op.
Fri, Sep 18, 8:37 AM · Restricted Project
clementval updated the diff for D87848: [mlir][openacc] Support Index and AnyInteger in loop op.

Update comment to reflect operation syntax.

Fri, Sep 18, 8:37 AM · Restricted Project
clementval updated the diff for D87848: [mlir][openacc] Support Index and AnyInteger in loop op.

Address review comment

Fri, Sep 18, 8:07 AM · Restricted Project
clementval requested changes to D87906: [Flang][OpenACC] Fix for branching out issue in OpenACC parallel construct..
Fri, Sep 18, 7:53 AM · Restricted Project
clementval added inline comments to D87848: [mlir][openacc] Support Index and AnyInteger in loop op.
Fri, Sep 18, 7:33 AM · Restricted Project

Thu, Sep 17

clementval added inline comments to D87846: [OpenMP][flang]Lower NUM_THREADS clause for parallel construct.
Thu, Sep 17, 5:07 PM · Restricted Project, Restricted Project
clementval requested review of D87874: [mlir][openacc] Add missing operands for acc.data operation.
Thu, Sep 17, 5:02 PM · Restricted Project
clementval requested review of D87848: [mlir][openacc] Support Index and AnyInteger in loop op.
Thu, Sep 17, 12:12 PM · Restricted Project
clementval committed rGf0e028f4b323: [flang][openacc] Lower clauses on loop construct to OpenACC dialect (authored by clementval).
[flang][openacc] Lower clauses on loop construct to OpenACC dialect
Thu, Sep 17, 8:35 AM
clementval closed D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect.
Thu, Sep 17, 8:34 AM · Restricted Project, Restricted Project
clementval committed rG6d3cabd90eed: [mlir][openacc] Change operand type from index to AnyInteger in parallel op (authored by clementval).
[mlir][openacc] Change operand type from index to AnyInteger in parallel op
Thu, Sep 17, 8:34 AM
clementval closed D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op.
Thu, Sep 17, 8:34 AM · Restricted Project, Restricted Project
clementval updated the diff for D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op.

Rebase

Thu, Sep 17, 8:32 AM · Restricted Project, Restricted Project
clementval added inline comments to D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op.
Thu, Sep 17, 7:26 AM · Restricted Project, Restricted Project
clementval updated the diff for D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op.

Address review comments

Thu, Sep 17, 7:26 AM · Restricted Project, Restricted Project

Wed, Sep 16

clementval updated the diff for D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op.

Remove unrelated commits

Wed, Sep 16, 6:51 PM · Restricted Project, Restricted Project
clementval added inline comments to D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op.
Wed, Sep 16, 6:46 PM · Restricted Project, Restricted Project
clementval updated the diff for D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op.

Address review comments

Wed, Sep 16, 6:35 PM · Restricted Project, Restricted Project
clementval added inline comments to D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op.
Wed, Sep 16, 6:35 PM · Restricted Project, Restricted Project
clementval committed rGd9953d155493: [mlir][openacc] Add missing operands for acc.parallel operation (authored by clementval).
[mlir][openacc] Add missing operands for acc.parallel operation
Wed, Sep 16, 7:49 AM
clementval closed D87733: [mlir][openacc] Add missing operands for acc.parallel operation.
Wed, Sep 16, 7:49 AM · Restricted Project
clementval updated the diff for D87733: [mlir][openacc] Add missing operands for acc.parallel operation.

Relax checks to be less restritive

Wed, Sep 16, 7:16 AM · Restricted Project
clementval added inline comments to D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op.
Wed, Sep 16, 7:01 AM · Restricted Project, Restricted Project
clementval added inline comments to D87733: [mlir][openacc] Add missing operands for acc.parallel operation.
Wed, Sep 16, 7:00 AM · Restricted Project

Tue, Sep 15

clementval requested review of D87733: [mlir][openacc] Add missing operands for acc.parallel operation.
Tue, Sep 15, 5:56 PM · Restricted Project
clementval requested review of D87712: [mlir][openacc] Change operand type from index to AnyInteger in parallel op.
Tue, Sep 15, 11:41 AM · Restricted Project, Restricted Project
clementval committed rG01f5fcd82903: [mlir][openacc] Add loop op verifier (authored by clementval).
[mlir][openacc] Add loop op verifier
Tue, Sep 15, 8:42 AM
clementval closed D87546: [mlir][openacc] Add loop op verifier.
Tue, Sep 15, 8:42 AM · Restricted Project
clementval updated the diff for D87546: [mlir][openacc] Add loop op verifier.

Rebase + address review comments

Tue, Sep 15, 8:22 AM · Restricted Project
clementval added inline comments to D87546: [mlir][openacc] Add loop op verifier.
Tue, Sep 15, 8:22 AM · Restricted Project
clementval committed rG2d8f0c05dbe7: [mlir][openacc] Add missing print of vector_length in parallel op (authored by clementval).
[mlir][openacc] Add missing print of vector_length in parallel op
Tue, Sep 15, 6:49 AM
clementval closed D87630: [mlir][openacc] Add missing print of vector_length in parallel op.
Tue, Sep 15, 6:49 AM · Restricted Project
clementval updated the diff for D87630: [mlir][openacc] Add missing print of vector_length in parallel op.

Address review comments

Tue, Sep 15, 6:46 AM · Restricted Project
clementval added inline comments to D87630: [mlir][openacc] Add missing print of vector_length in parallel op.
Tue, Sep 15, 6:46 AM · Restricted Project

Mon, Sep 14

clementval added inline comments to D87546: [mlir][openacc] Add loop op verifier.
Mon, Sep 14, 5:35 PM · Restricted Project
clementval updated the diff for D87546: [mlir][openacc] Add loop op verifier.

Address review comments

Mon, Sep 14, 5:35 PM · Restricted Project
clementval requested review of D87630: [mlir][openacc] Add missing print of vector_length in parallel op.
Mon, Sep 14, 1:18 PM · Restricted Project
clementval added inline comments to D87546: [mlir][openacc] Add loop op verifier.
Mon, Sep 14, 9:35 AM · Restricted Project

Fri, Sep 11

clementval requested review of D87546: [mlir][openacc] Add loop op verifier.
Fri, Sep 11, 12:56 PM · Restricted Project

Thu, Sep 10

clementval accepted D86071: [MLIR][OpenMP] Add omp.do operation.
Thu, Sep 10, 8:36 AM · Restricted Project, Restricted Project
clementval added a comment to D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect.

Yes those are duplicate in a sense, but they are still tests(since nothing else is there) and can self validate well-formedness of the operation(which is one of the major pre-requisite for proceeding further with Lowering).
+ They will ensure matches with community criteria. up-streaming in testable chunks.

Thu, Sep 10, 6:11 AM · Restricted Project, Restricted Project

Wed, Sep 9

clementval updated the diff for D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect.

Address clang-tiday warning

Wed, Sep 9, 12:25 PM · Restricted Project, Restricted Project
clementval added a comment to D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect.

Since bbc based test can't be added here, would you mind adding a unit-test here ?

Wed, Sep 9, 10:53 AM · Restricted Project, Restricted Project
clementval updated the diff for D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect.

Remove unrelated changes

Wed, Sep 9, 10:51 AM · Restricted Project, Restricted Project
clementval added inline comments to D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect.
Wed, Sep 9, 10:48 AM · Restricted Project, Restricted Project
clementval abandoned D86423: [flang][openacc] Lower loop with collapse clause.

This patch is now part of D87389

Wed, Sep 9, 9:00 AM · Restricted Project
clementval requested review of D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect.
Wed, Sep 9, 9:00 AM · Restricted Project, Restricted Project

Tue, Sep 8

clementval accepted D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

LGTM (just a small comment about an include)

Tue, Sep 8, 8:54 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 1

clementval added a comment to D86423: [flang][openacc] Lower loop with collapse clause.

Is it possible to add lit tests based on the generated mlir?

Tue, Sep 1, 6:37 AM · Restricted Project

Mon, Aug 31

clementval committed rG2bbbcae782ad: [mlir][openacc] Add missing attributes and operands for acc.loop (authored by clementval).
[mlir][openacc] Add missing attributes and operands for acc.loop
Mon, Aug 31, 4:50 PM
clementval closed D86753: [mlir][openacc] Add missing attributes and operands for acc.loop.
Mon, Aug 31, 4:50 PM · Restricted Project
clementval updated the diff for D86753: [mlir][openacc] Add missing attributes and operands for acc.loop.

Address review comments

Mon, Aug 31, 4:49 PM · Restricted Project
clementval added a comment to D86753: [mlir][openacc] Add missing attributes and operands for acc.loop.

@rriddle Are you fine with the changes?

Mon, Aug 31, 6:56 AM · Restricted Project

Fri, Aug 28

clementval added a comment to D86753: [mlir][openacc] Add missing attributes and operands for acc.loop.

@rriddle and @kiranchandramohan Thanks for the reviews. I just updated the patche to address the comments.

Fri, Aug 28, 5:14 PM · Restricted Project
clementval updated the diff for D86753: [mlir][openacc] Add missing attributes and operands for acc.loop.

Address review comments

Fri, Aug 28, 5:13 PM · Restricted Project
clementval updated the diff for D86753: [mlir][openacc] Add missing attributes and operands for acc.loop.

Change I1Attr to UnitAttr

Fri, Aug 28, 12:27 PM · Restricted Project
clementval added inline comments to D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.
Fri, Aug 28, 8:35 AM · Restricted Project, Restricted Project, Restricted Project
clementval updated the summary of D86753: [mlir][openacc] Add missing attributes and operands for acc.loop.
Fri, Aug 28, 7:45 AM · Restricted Project

Thu, Aug 27

clementval committed rG832c8a72988a: [flang][openacc] Fix gang-argument parsing and add validity tests for !$acc loop (authored by clementval).
[flang][openacc] Fix gang-argument parsing and add validity tests for !$acc loop
Thu, Aug 27, 7:33 PM
clementval closed D86584: [flang][openacc] Fix gang-argument parsing and add validity tests for !$acc loop.
Thu, Aug 27, 7:33 PM · Restricted Project
clementval updated the diff for D86584: [flang][openacc] Fix gang-argument parsing and add validity tests for !$acc loop.

Rebase + address minor comments

Thu, Aug 27, 7:24 PM · Restricted Project
clementval committed rG4df2a5f782db: [flang][openacc] Add check for tile clause restriction (authored by clementval).
[flang][openacc] Add check for tile clause restriction
Thu, Aug 27, 7:14 PM
clementval closed D86655: [flang][openacc] Add check for tile clause restriction.
Thu, Aug 27, 7:13 PM · Restricted Project
clementval added inline comments to D86655: [flang][openacc] Add check for tile clause restriction.
Thu, Aug 27, 7:08 PM · Restricted Project
clementval updated the diff for D86655: [flang][openacc] Add check for tile clause restriction.

Rebase + address minor comments

Thu, Aug 27, 7:06 PM · Restricted Project
clementval requested review of D86753: [mlir][openacc] Add missing attributes and operands for acc.loop.
Thu, Aug 27, 6:25 PM · Restricted Project

Wed, Aug 26

clementval requested review of D86655: [flang][openacc] Add check for tile clause restriction.
Wed, Aug 26, 1:01 PM · Restricted Project

Tue, Aug 25

clementval requested review of D86584: [flang][openacc] Fix gang-argument parsing and add validity tests for !$acc loop.
Tue, Aug 25, 5:44 PM · Restricted Project
clementval committed rG4d69bcb12fa7: [mlir][openacc][NFC] Fix comment about OpenACCExecMapping (authored by clementval).
[mlir][openacc][NFC] Fix comment about OpenACCExecMapping
Tue, Aug 25, 12:12 PM
clementval updated the diff for D86423: [flang][openacc] Lower loop with collapse clause.

Update to reflect change in PR

Tue, Aug 25, 8:17 AM · Restricted Project

Mon, Aug 24

clementval committed rGd5557c6e056f: [flang][openacc] Fix reduction operator parsing/unparsing (authored by clementval).
[flang][openacc] Fix reduction operator parsing/unparsing
Mon, Aug 24, 11:23 AM
clementval closed D86296: [flang][openacc] Fix reduction operator parsing/unparsing.
Mon, Aug 24, 11:23 AM · Restricted Project
clementval updated the diff for D86296: [flang][openacc] Fix reduction operator parsing/unparsing.

Rebase

Mon, Aug 24, 11:17 AM · Restricted Project

Sun, Aug 23

clementval requested review of D86423: [flang][openacc] Lower loop with collapse clause.
Sun, Aug 23, 5:25 PM · Restricted Project
clementval committed rG86bbf8e6fc2b: [flang][openacc] Fix wait-argument for wait clause + add tests (authored by clementval).
[flang][openacc] Fix wait-argument for wait clause + add tests
Sun, Aug 23, 5:01 PM
clementval closed D86325: [flang][openacc] Fix wait-argument for wait clause + add tests.
Sun, Aug 23, 5:01 PM · Restricted Project, Restricted Project

Fri, Aug 21

clementval added a comment to D86296: [flang][openacc] Fix reduction operator parsing/unparsing.

Would you have issues matching the operation in Fortran and the reduction operation in the OpenACC directive since you are using your own custom enums?

I'm not sure I get what you want to say here.

What I meant to say here is that previously the OpenACCReductionOperator was defined in terms of struct DefinedOperator which in turn is defined in terms of DefinedOpName or IntrinsicOperator. If these are also used for the Fortran expressions in the parse tree then it is easy to match the OpenACC Reduction Operation and the operation in Fortran source where reduction is implied. If you use your own custom definitions for operations then there is some code that you have to write to do the matching.

Fri, Aug 21, 8:16 AM · Restricted Project
clementval added a comment to D86296: [flang][openacc] Fix reduction operator parsing/unparsing.

Would you have issues matching the operation in Fortran and the reduction operation in the OpenACC directive since you are using your own custom enums?

Fri, Aug 21, 7:42 AM · Restricted Project

Aug 20 2020

clementval retitled D86325: [flang][openacc] Fix wait-argument for wait clause + add tests from [flang][openacc] Fix wait-arguement for wait clause + add tests to [flang][openacc] Fix wait-argument for wait clause + add tests.
Aug 20 2020, 6:37 PM · Restricted Project, Restricted Project
clementval requested review of D86325: [flang][openacc] Fix wait-argument for wait clause + add tests.
Aug 20 2020, 6:35 PM · Restricted Project, Restricted Project
clementval added a comment to D86296: [flang][openacc] Fix reduction operator parsing/unparsing.

Sorry, I have not gone into detail here. But could you provide some motivation/explanation for this change? Is this because OpenACC accepts fewer or different reduction operators. Or is a similar change required in OpenMP too.

Aug 20 2020, 9:49 AM · Restricted Project
clementval requested review of D86296: [flang][openacc] Fix reduction operator parsing/unparsing.
Aug 20 2020, 8:27 AM · Restricted Project

Aug 18 2020

clementval added inline comments to D86071: [MLIR][OpenMP] Add omp.do operation.
Aug 18 2020, 11:34 AM · Restricted Project, Restricted Project

Aug 17 2020

clementval committed rG3060894bbb34: [flang][directives] Use TableGen to generate clause unparsing (authored by clementval).
[flang][directives] Use TableGen to generate clause unparsing
Aug 17 2020, 11:22 AM
clementval closed D85851: [flang][directives] Use TableGen to generate clause unparsing.
Aug 17 2020, 11:22 AM · Restricted Project, Restricted Project
clementval updated the diff for D85851: [flang][directives] Use TableGen to generate clause unparsing.

Rebase

Aug 17 2020, 11:20 AM · Restricted Project, Restricted Project

Aug 13 2020

clementval added a comment to D85851: [flang][directives] Use TableGen to generate clause unparsing.

@kiranchandramohan Thanks for the review. I have added test and corrected other stuffs. One clang-today warning will remain for the function name. It is not consistent with the rest of TableGen so I ignored it from the beginning.

Aug 13 2020, 7:33 PM · Restricted Project, Restricted Project
clementval updated the diff for D85851: [flang][directives] Use TableGen to generate clause unparsing.

Address review comment

Aug 13 2020, 7:31 PM · Restricted Project, Restricted Project
clementval committed rG05169af5cea2: [flang][openacc] Handle optional end directive in combined construct (authored by clementval).
[flang][openacc] Handle optional end directive in combined construct
Aug 13 2020, 11:05 AM
clementval closed D84481: [flang][openacc] Handle optional end directive in combined construct.
Aug 13 2020, 11:05 AM · Restricted Project, Restricted Project
clementval committed rG4225e7fa34fe: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations (authored by clementval).
[mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations
Aug 13 2020, 7:01 AM
clementval closed D84268: [mlir][openacc] Introduce OpenACC dialect with parallel, data, loop operations.
Aug 13 2020, 7:01 AM · Restricted Project

Aug 12 2020

clementval added a comment to D85851: [flang][directives] Use TableGen to generate clause unparsing.

@kiranchandramohan Just updated the patch.

Aug 12 2020, 7:35 PM · Restricted Project, Restricted Project