Page MenuHomePhabricator

clementval (Valentin Clement)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2019, 1:05 PM (128 w, 1 d)

Recent Activity

Apr 27 2022

clementval added a comment to D124225: [flang] Add lowering stubs for OpenMP/OpenACC declarative constructs.

Looks ok for me for now.

Apr 27 2022, 7:01 AM · Restricted Project, Restricted Project
clementval accepted D124520: [Flang] Lower the FailImage Statement.

LGTM

Apr 27 2022, 4:49 AM · Restricted Project, Restricted Project

Apr 26 2022

clementval added a comment to D124226: [flang][OpenMP] Support lowering parse-tree to MLIR for threadprivate directive.

There are tests in mlir/test/Target/LLVMIR/openmp-llvm.mlir. I guess if it is to test FIR/OpenMP integration then of course it makes sense to have where FIR is.

Apr 26 2022, 11:26 PM · Restricted Project, Restricted Project, Restricted Project
clementval accepted D124476: [NFC] Synchronize more code to reduce deltas for upstreaming..

LGTM

Apr 26 2022, 2:03 PM · Restricted Project, Restricted Project
clementval added a comment to D124277: [Flang] Initial lowering of the Fortran Do loop.

@clementval @schweitz Plan is to upstream the loop as a sequence of patches (if possible without code changes). Since the first patch (this one) only brings in a simple loop, the tests in fir-dev were not directly applicable and I decided to write a new one. Since it is a new test file, its name and contents do not matter much.
Once the loop is completely upstreamed, I will upstream all the remaining loop tests if they did not make it along with the code patches.

Apr 26 2022, 11:05 AM · Restricted Project, Restricted Project
clementval accepted D124467: [flang] Fix crash from PDT component init in module file.

LGTM

Apr 26 2022, 10:21 AM · Restricted Project, Restricted Project
clementval added a comment to D124277: [Flang] Initial lowering of the Fortran Do loop.

I have changed the name to do_loop.f90 and will write tests in separate files.

I'm not against making test clearer to read but this is again changes that will make the end of upstreaming harder.

I don't quite see how. This was is not present in fir-dev anyway. Also, since we are near the end, perhaps it's OK to be a bit more relaxed?

These tests were present in fir-dev in their initial form. Near the end is exactly where it becomes harder to be sure everything is upstreamed if there is lots of noise in the diffs.

Apr 26 2022, 8:24 AM · Restricted Project, Restricted Project
clementval added a comment to D124226: [flang][OpenMP] Support lowering parse-tree to MLIR for threadprivate directive.

@awarzynski Thanks for the explanations. Good to hear someone has the strong reason to make the test cases standard. It is also more reasonable for me to give one descriptive file name.

Apr 26 2022, 7:40 AM · Restricted Project, Restricted Project, Restricted Project
clementval added a comment to D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR..

Looks okay to me, please wait for Kiran/Valentin's comments. Also, will you be adding an assembly format/verifier for this later?

Yes

The summary says the map clause is not supported but there are map operands in the patch. Can we get these two in sync - we should either update the summary or remove map-related operands.

Also, please rebase before further reviews.

Will do

Apr 26 2022, 6:51 AM · Restricted Project, Restricted Project, Restricted Project
clementval added a comment to D124226: [flang][OpenMP] Support lowering parse-tree to MLIR for threadprivate directive.
Apr 26 2022, 6:39 AM · Restricted Project, Restricted Project, Restricted Project
clementval added a comment to D124277: [Flang] Initial lowering of the Fortran Do loop.

I think that 2 nested loops should be enough, unless we know that things change when moving from 2 to 3 nested loops. Also:

I was a bit conflicted about this. While 2-nested is easier to read, 3-nested seem to be in general a better test. Since it is not a strong opinion, I have changed to a 2-nested one.

I think 3 nested loops was a better test.

Apr 26 2022, 6:35 AM · Restricted Project, Restricted Project

Apr 25 2022

clementval accepted D124410: [NFC] More code cleanup for upstreaming..

LGTM

Apr 25 2022, 12:22 PM · Restricted Project, Restricted Project
clementval accepted D124303: [flang][runtime] Fix total MAXLOC/MINLOC for non-integer data.

LGTM

Apr 25 2022, 11:52 AM · Restricted Project, Restricted Project
clementval accepted D124296: [flang] Add semantic checks for intrinsic function REDUCE().

LGTM

Apr 25 2022, 11:51 AM · Restricted Project, Restricted Project

Apr 24 2022

clementval committed rG6243b90ead7a: [flang] Do not create arith.extui with same from/to type (authored by clementval).
[flang] Do not create arith.extui with same from/to type
Apr 24 2022, 11:38 AM · Restricted Project, Restricted Project
clementval closed D124107: [flang] Do not create arith.extui with same from/to type.
Apr 24 2022, 11:37 AM · Restricted Project, Restricted Project

Apr 23 2022

clementval accepted D124310: [NFC] Sync code for upstreaming.

LGTM

Apr 23 2022, 2:56 AM · Restricted Project, Restricted Project

Apr 22 2022

clementval accepted D124272: [NFC] Reduce noise in the diff for upstreaming.

LGTM

Apr 22 2022, 9:52 AM · Restricted Project, Restricted Project
clementval accepted D124243: [flang] fix LBOUND lowering with KIND and no DIM arguments.

LGTM

Apr 22 2022, 3:17 AM · Restricted Project, Restricted Project

Apr 21 2022

clementval added inline comments to D123492: [mlir][CSE] Add ability to remove commutative operations.
Apr 21 2022, 9:29 AM · Restricted Project, Restricted Project
clementval accepted D124167: [flang] Fold transformational bessels when host runtime has bessels.

LGTM

Apr 21 2022, 7:00 AM · Restricted Project, Restricted Project
clementval added a comment to D124160: [Flang} Fix issues in lowering loop variable of io implied do loop.

Can you check why the windows buildbot is failing?

Apr 21 2022, 5:45 AM · Restricted Project, Restricted Project
clementval added inline comments to D123492: [mlir][CSE] Add ability to remove commutative operations.
Apr 21 2022, 12:47 AM · Restricted Project, Restricted Project

Apr 20 2022

clementval updated the summary of D124107: [flang] Do not create arith.extui with same from/to type.
Apr 20 2022, 10:01 AM · Restricted Project, Restricted Project
clementval requested review of D124107: [flang] Do not create arith.extui with same from/to type.
Apr 20 2022, 10:00 AM · Restricted Project, Restricted Project
clementval added a comment to D122725: [flang][OpenMP] Added lowering support for atomic read and write constructs.

LGTM. Please wait for approval from @clementval/@schweitz for the location of attaching the OpenMP interface and any outstanding comments from the other reviewers.

Apr 20 2022, 9:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 19 2022

clementval accepted D123990: [flang] Do not pass derived type by descriptor when not needed.

LGTM

Apr 19 2022, 1:59 AM · Restricted Project, Restricted Project

Apr 18 2022

clementval added a comment to D122008: [flang][driver] Add support for generating executables.

Do you plan to discuss this again during the next call? Note that today is a holiday in various country in Europe (maybe elsewhere too) so the one on 4/27 is probably better.

Apr 18 2022, 5:24 AM · Restricted Project, Restricted Project, Restricted Project

Apr 16 2022

clementval committed rGbd514967aa22: [mlir][CSE] Add ability to remove commutative operations (authored by clementval).
[mlir][CSE] Add ability to remove commutative operations
Apr 16 2022, 12:10 PM · Restricted Project, Restricted Project
clementval closed D123492: [mlir][CSE] Add ability to remove commutative operations.
Apr 16 2022, 12:10 PM · Restricted Project, Restricted Project
clementval accepted D123899: [flang] Add & use a better visit() (take 2).

LGTM

Apr 16 2022, 11:55 AM · Restricted Project, Restricted Project

Apr 15 2022

clementval added inline comments to D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint..
Apr 15 2022, 1:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 14 2022

clementval added a comment to D123492: [mlir][CSE] Add ability to remove commutative operations.

@rriddle ping

Apr 14 2022, 9:31 AM · Restricted Project, Restricted Project

Apr 13 2022

clementval accepted D123731: [flang] Upgrade short actual character arguments to errors.

LGTM

Apr 13 2022, 1:26 PM · Restricted Project, Restricted Project
clementval accepted D123732: [flang] Allow POINTER attribute statement on procedure interfaces.

LGTM

Apr 13 2022, 1:26 PM · Restricted Project, Restricted Project
clementval accepted D123730: [flang][runtime] Fix ENDFILE for formatted stream output.

LGTM

Apr 13 2022, 1:25 PM · Restricted Project, Restricted Project
clementval accepted D123728: [flang] Handle parameter-dependent types in PDT initializers.

LGTM

Apr 13 2022, 1:25 PM · Restricted Project, Restricted Project
clementval accepted D123716: [flang][runtime] Preserve effect of positioning in record in non-advancing output.

LGTM

Apr 13 2022, 1:07 PM · Restricted Project, Restricted Project
clementval accepted D123715: [flang] Make F0.1 output editing of zero edge case consistent.

LGTM

Apr 13 2022, 1:06 PM · Restricted Project, Restricted Project
clementval accepted D123706: [flang] Emit a portability warning for padding in COMMON.

LGTM

Apr 13 2022, 12:37 PM · Restricted Project, Restricted Project

Apr 12 2022

clementval accepted D123624: [flang] Use full result range for clock_gettime implementation of SYSTEM_CLOCK.

LGTM

Apr 12 2022, 11:48 AM · Restricted Project, Restricted Project
clementval updated the diff for D123492: [mlir][CSE] Add ability to remove commutative operations.

Address review comments

Apr 12 2022, 12:57 AM · Restricted Project, Restricted Project

Apr 11 2022

clementval updated the diff for D123492: [mlir][CSE] Add ability to remove commutative operations.
  • Rebase
  • Fix check line
  • Add logic for isEquivalentTo
Apr 11 2022, 6:24 AM · Restricted Project, Restricted Project
clementval added a comment to D112711: [fir] Add FIR CSE specific pass.

Adding CSE for commutative ops - https://reviews.llvm.org/D123492

Apr 11 2022, 5:32 AM · Restricted Project, Restricted Project, Restricted Project
clementval requested review of D123492: [mlir][CSE] Add ability to remove commutative operations.
Apr 11 2022, 3:28 AM · Restricted Project, Restricted Project
clementval abandoned D92064: [flang][openacc] Remove duplicated code for clause lowering.

This patch is obsolete now.

Apr 11 2022, 12:52 AM · Restricted Project, Restricted Project, Restricted Project

Apr 8 2022

clementval committed rGab8e1e6e5ace: [flang] Do not fold fir.box_addr when it has a slice (authored by clementval).
[flang] Do not fold fir.box_addr when it has a slice
Apr 8 2022, 12:17 PM · Restricted Project, Restricted Project
clementval closed D123392: [flang] Do not fold fir.box_addr when it has a slice.
Apr 8 2022, 12:17 PM · Restricted Project, Restricted Project
clementval requested review of D123392: [flang] Do not fold fir.box_addr when it has a slice.
Apr 8 2022, 8:17 AM · Restricted Project, Restricted Project
clementval accepted D123388: [flang] Lower optionals in GET_COMMAND_ARGUMENT and GET_ENVIRONMENT_VARIABLE.

LGTM

Apr 8 2022, 7:06 AM · Restricted Project, Restricted Project
clementval accepted D123380: [flang] Handle dynamically optional argument in EXIT.

LGTM

Apr 8 2022, 5:07 AM · Restricted Project, Restricted Project
clementval accepted D123378: [flang][NFC] rename isAbsent to isStaticallyAbsent in IntrinsicCall.cpp.

LGTM

Apr 8 2022, 4:00 AM · Restricted Project, Restricted Project

Apr 7 2022

clementval committed rG02da9643506d: [mlir][CSE] Remove duplicated operations with MemRead side-effect (authored by clementval).
[mlir][CSE] Remove duplicated operations with MemRead side-effect
Apr 7 2022, 1:09 AM · Restricted Project, Restricted Project, Restricted Project
clementval closed D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.
Apr 7 2022, 1:09 AM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2022

clementval updated the diff for D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.
  • Use try_emplace
  • Trim test with multiple load
Apr 6 2022, 1:08 PM · Restricted Project, Restricted Project, Restricted Project
clementval added inline comments to D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.
Apr 6 2022, 12:23 PM · Restricted Project, Restricted Project, Restricted Project
clementval added inline comments to D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.
Apr 6 2022, 12:20 PM · Restricted Project, Restricted Project, Restricted Project
clementval added inline comments to D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.
Apr 6 2022, 12:09 PM · Restricted Project, Restricted Project, Restricted Project
clementval added a comment to D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.

Thanks for the review @mehdi_amini @rriddle

Apr 6 2022, 11:55 AM · Restricted Project, Restricted Project, Restricted Project
clementval added inline comments to D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.
Apr 6 2022, 11:29 AM · Restricted Project, Restricted Project, Restricted Project
clementval updated the diff for D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.

Address review comments

Apr 6 2022, 11:29 AM · Restricted Project, Restricted Project, Restricted Project
clementval added inline comments to D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.
Apr 6 2022, 9:13 AM · Restricted Project, Restricted Project, Restricted Project
clementval updated the diff for D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.

Address review comments

Apr 6 2022, 5:16 AM · Restricted Project, Restricted Project, Restricted Project

Apr 5 2022

clementval updated the diff for D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.

Add caching

Apr 5 2022, 12:09 PM · Restricted Project, Restricted Project, Restricted Project
clementval requested changes to D122725: [flang][OpenMP] Added lowering support for atomic read and write constructs.

Remove dependency between dialects.

Apr 5 2022, 9:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clementval accepted D123130: [flang] Fix fir.embox codegen with constant interior shape.

LGTM

Apr 5 2022, 7:21 AM · Restricted Project, Restricted Project
clementval added inline comments to D122725: [flang][OpenMP] Added lowering support for atomic read and write constructs.
Apr 5 2022, 6:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clementval added a reviewer for D122725: [flang][OpenMP] Added lowering support for atomic read and write constructs: schweitz.
Apr 5 2022, 6:54 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clementval added inline comments to D122725: [flang][OpenMP] Added lowering support for atomic read and write constructs.
Apr 5 2022, 6:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clementval accepted D123123: [flang] Set lower bounds of array section fir.embox to one.

LGTM

Apr 5 2022, 5:53 AM · Restricted Project, Restricted Project

Apr 4 2022

clementval added a comment to D122008: [flang][driver] Add support for generating executables.

I'm personally in favor of number 3.

Apr 4 2022, 12:11 PM · Restricted Project, Restricted Project, Restricted Project
clementval added reviewers for D122008: [flang][driver] Add support for generating executables: schweitz, vdonaldson, PeteSteinfeld, klausler.
Apr 4 2022, 12:11 PM · Restricted Project, Restricted Project, Restricted Project
clementval updated the diff for D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.

Update toy tests

Apr 4 2022, 8:01 AM · Restricted Project, Restricted Project, Restricted Project
clementval added a comment to D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline.

Do we still want to add a flag to optionally disable this pass?

Depends on our end goal here. @schweitz mentioned Windows interoperability. I guess that the mangling will be different on other platforms too? We could add the flag to disable ExternalNameConversionPass and then use it in tests so that:

Apr 4 2022, 4:48 AM · Restricted Project, Restricted Project, Restricted Project
clementval added a comment to D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline.

Also, do we want to move the pass from flang/Optimizer/Transforms/Passes.td to flang/Optimizer/Codegen/CGPasses.td, to clarify that it's a codegen pass?

Apr 4 2022, 4:46 AM · Restricted Project, Restricted Project, Restricted Project
clementval committed rGd333b382701e: [flang][NFC] Add tests for array-value-copy pass with array with pointers (authored by clementval).
[flang][NFC] Add tests for array-value-copy pass with array with pointers
Apr 4 2022, 1:46 AM · Restricted Project, Restricted Project
clementval closed D122878: [flang][NFC] Add tests for array-value-copy pass with array with pointers.
Apr 4 2022, 1:46 AM · Restricted Project, Restricted Project
clementval added inline comments to D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.
Apr 4 2022, 1:43 AM · Restricted Project, Restricted Project, Restricted Project
clementval updated the diff for D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.

Address some comments

Apr 4 2022, 1:42 AM · Restricted Project, Restricted Project, Restricted Project
clementval updated the summary of D122801: [mlir][CSE] Remove duplicated operations with MemRead side-effect.
Apr 4 2022, 12:47 AM · Restricted Project, Restricted Project, Restricted Project
clementval updated the diff for D122878: [flang][NFC] Add tests for array-value-copy pass with array with pointers.

Split iinput file + add some check lines

Apr 4 2022, 12:42 AM · Restricted Project, Restricted Project
clementval committed rG7dc492ed3443: [flang][NFC] Add tests for fir.address_of (authored by clementval).
[flang][NFC] Add tests for fir.address_of
Apr 4 2022, 12:29 AM · Restricted Project, Restricted Project
clementval closed D122889: [flang][NFC] Add tests for fir.address_of.
Apr 4 2022, 12:28 AM · Restricted Project, Restricted Project
clementval updated the diff for D122889: [flang][NFC] Add tests for fir.address_of.

Remove extra fir-opt

Apr 4 2022, 12:23 AM · Restricted Project, Restricted Project

Apr 3 2022

clementval committed rG3bcc928b1ba8: [flang][NFC] Add tests for fir.array_modify in array-value-copy pass (authored by clementval).
[flang][NFC] Add tests for fir.array_modify in array-value-copy pass
Apr 3 2022, 6:26 AM · Restricted Project, Restricted Project
clementval closed D122809: [flang][NFC] Add tests for fir.array_modify in array-value-copy pass.
Apr 3 2022, 6:26 AM · Restricted Project, Restricted Project
clementval committed rG0371f3e2329f: [flang][NFC] Add more test cases for the array-value-copy pass (authored by clementval).
[flang][NFC] Add more test cases for the array-value-copy pass
Apr 3 2022, 6:25 AM · Restricted Project, Restricted Project
clementval closed D122807: [flang][NFC] Add more test cases for the array-value-copy pass.
Apr 3 2022, 6:25 AM · Restricted Project, Restricted Project
clementval committed rG602dd6bd32ab: [flang][NFC] Add tests for fir.is_present (authored by clementval).
[flang][NFC] Add tests for fir.is_present
Apr 3 2022, 6:23 AM · Restricted Project, Restricted Project
clementval closed D122813: [flang][NFC] Add tests for fir.is_present.
Apr 3 2022, 6:22 AM · Restricted Project, Restricted Project
clementval committed rGe0c782bdc0e9: [flang] Add global and global box initialization tests (authored by clementval).
[flang] Add global and global box initialization tests
Apr 3 2022, 6:21 AM · Restricted Project, Restricted Project
clementval closed D122881: [flang] Add global and global box initialization tests.
Apr 3 2022, 6:21 AM · Restricted Project, Restricted Project
clementval committed rG2fb57d628c6f: [flang][NFC] Add tests for select constructs (authored by clementval).
[flang][NFC] Add tests for select constructs
Apr 3 2022, 6:19 AM · Restricted Project, Restricted Project
clementval closed D122888: [flang][NFC] Add tests for select constructs.
Apr 3 2022, 6:19 AM · Restricted Project, Restricted Project

Apr 1 2022

clementval updated the summary of D122888: [flang][NFC] Add tests for select constructs.
Apr 1 2022, 3:23 AM · Restricted Project, Restricted Project
clementval updated the diff for D122888: [flang][NFC] Add tests for select constructs.

Remove select-type test

Apr 1 2022, 3:23 AM · Restricted Project, Restricted Project
clementval requested review of D122889: [flang][NFC] Add tests for fir.address_of.
Apr 1 2022, 3:16 AM · Restricted Project, Restricted Project
clementval requested review of D122888: [flang][NFC] Add tests for select constructs.
Apr 1 2022, 3:11 AM · Restricted Project, Restricted Project
clementval requested review of D122881: [flang] Add global and global box initialization tests.
Apr 1 2022, 1:42 AM · Restricted Project, Restricted Project
clementval requested review of D122878: [flang][NFC] Add tests for array-value-copy pass with array with pointers.
Apr 1 2022, 12:57 AM · Restricted Project, Restricted Project