Page MenuHomePhabricator

clementval (Valentin Clement)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2019, 1:05 PM (58 w, 2 d)

Recent Activity

Fri, Jan 22

clementval added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Fri, Jan 22, 7:45 AM · Restricted Project, Restricted Project
clementval accepted D95233: [flang] Fix typo in error message.
Fri, Jan 22, 7:20 AM · Restricted Project, Restricted Project

Thu, Jan 21

clementval requested changes to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Thu, Jan 21, 7:34 AM · Restricted Project, Restricted Project

Wed, Jan 20

clementval added a project to D95108: [flang][directive] Enforce basic semantic check for all clauses: Restricted Project.
Wed, Jan 20, 5:58 PM · Restricted Project, Restricted Project
clementval requested review of D95108: [flang][directive] Enforce basic semantic check for all clauses.
Wed, Jan 20, 5:57 PM · Restricted Project, Restricted Project
clementval added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Wed, Jan 20, 12:06 PM · Restricted Project, Restricted Project
clementval added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Wed, Jan 20, 10:44 AM · Restricted Project, Restricted Project
clementval added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Wed, Jan 20, 7:30 AM · Restricted Project, Restricted Project

Tue, Jan 19

clementval added inline comments to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..
Tue, Jan 19, 11:26 AM · Restricted Project, Restricted Project
clementval committed rG6bd0a4451ccd: [flang][directive] Get rid of flangClassValue in TableGen (authored by clementval).
[flang][directive] Get rid of flangClassValue in TableGen
Tue, Jan 19, 7:29 AM
clementval closed D94821: [flang][directive] Get rid of flangClassValue in TableGen.
Tue, Jan 19, 7:29 AM · Restricted Project, Restricted Project
clementval added a comment to D94821: [flang][directive] Get rid of flangClassValue in TableGen.

Ok a clang version 8.0.1 based build passes.
It's seems compiler version related issue.
BTW, is there a way to mitigate or conform such compiler version/build related issues?
LGTM.

Tue, Jan 19, 5:59 AM · Restricted Project, Restricted Project

Mon, Jan 18

clementval added inline comments to D94821: [flang][directive] Get rid of flangClassValue in TableGen.
Mon, Jan 18, 5:31 PM · Restricted Project, Restricted Project
clementval added inline comments to D94821: [flang][directive] Get rid of flangClassValue in TableGen.
Mon, Jan 18, 11:55 AM · Restricted Project, Restricted Project

Fri, Jan 15

clementval added a project to D94821: [flang][directive] Get rid of flangClassValue in TableGen: Restricted Project.
Fri, Jan 15, 1:02 PM · Restricted Project, Restricted Project
clementval requested review of D94821: [flang][directive] Get rid of flangClassValue in TableGen.
Fri, Jan 15, 1:01 PM · Restricted Project, Restricted Project
clementval added a comment to D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc.

Ping

Fri, Jan 15, 8:12 AM · Restricted Project
clementval committed rGcf0173de69a7: [mlir] Add better support for f80 and f128 (authored by clementval).
[mlir] Add better support for f80 and f128
Fri, Jan 15, 7:30 AM
clementval closed D94737: [mlir] Add better support for f80 and f128.
Fri, Jan 15, 7:30 AM · Restricted Project
clementval updated the diff for D94737: [mlir] Add better support for f80 and f128.

Add f80 and f128 to LLVM.md

Fri, Jan 15, 5:45 AM · Restricted Project

Thu, Jan 14

clementval added inline comments to D94737: [mlir] Add better support for f80 and f128.
Thu, Jan 14, 7:02 PM · Restricted Project
clementval updated the diff for D94737: [mlir] Add better support for f80 and f128.

Remove useless checks now that types have been replaced

Thu, Jan 14, 7:02 PM · Restricted Project
clementval added inline comments to D94737: [mlir] Add better support for f80 and f128.
Thu, Jan 14, 6:35 PM · Restricted Project
clementval updated the diff for D94737: [mlir] Add better support for f80 and f128.

Add usage in IR/parser.mlir

Thu, Jan 14, 6:35 PM · Restricted Project
clementval requested review of D94737: [mlir] Add better support for f80 and f128.
Thu, Jan 14, 6:11 PM · Restricted Project
clementval committed rGca98baa04253: [openacc] Rename generated file from ACC.cpp.inc to ACC.inc to match D92955 (authored by clementval).
[openacc] Rename generated file from ACC.cpp.inc to ACC.inc to match D92955
Thu, Jan 14, 11:20 AM
clementval closed D93485: [openacc] Rename generated file from ACC.cpp.inc to ACC.inc to match D92955.
Thu, Jan 14, 11:20 AM · Restricted Project, Restricted Project
clementval added a comment to D93485: [openacc] Rename generated file from ACC.cpp.inc to ACC.inc to match D92955.

I couldn't understand still the rational for *.cpp.inc to *.inc for both OMP and OACC, could you please point why was that needed?

Well, when we started with the TableGen code generation we separated definition and declaration but this was not really the way to go and that's why now all code block are generated in a single file. Since this file is included in both headers and .cpp file, .inc is more appropriate.

Thu, Jan 14, 8:34 AM · Restricted Project, Restricted Project

Tue, Jan 12

clementval added inline comments to D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..
Tue, Jan 12, 11:20 AM · Restricted Project, Restricted Project
clementval added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Tue, Jan 12, 7:18 AM · Restricted Project, Restricted Project
clementval committed rG0bd9a1369112: [mlir][openacc] Use TableGen information for default enum (authored by clementval).
[mlir][openacc] Use TableGen information for default enum
Tue, Jan 12, 6:43 AM
clementval closed D93710: [mlir][openacc] Use TableGen information for default enum.
Tue, Jan 12, 6:42 AM · Restricted Project, Restricted Project

Mon, Jan 11

clementval updated the diff for D93710: [mlir][openacc] Use TableGen information for default enum.

Address review comment

Mon, Jan 11, 6:06 PM · Restricted Project, Restricted Project
clementval added a comment to D93710: [mlir][openacc] Use TableGen information for default enum.

Thanks for the patience.

LGTM. One comment regarding doc generation before I approve.

Mehdi added a patch to OpenMP dialectCMake for building the Doc generation for the OpenMP dialect otherwise a bot will fail. I guess it is needed in the OpenACC CMake as well.
https://reviews.llvm.org/rG7b18716361a533023d7f5366add759038c8a7825

Mon, Jan 11, 6:06 PM · Restricted Project, Restricted Project
clementval committed rG47567ca5faca: [flang][openxx][NFC] Remove duplicated function to check required clauses (authored by clementval).
[flang][openxx][NFC] Remove duplicated function to check required clauses
Mon, Jan 11, 11:09 AM
clementval closed D93575: [flang][openxx][NFC] Remove duplicated function to check required clauses.
Mon, Jan 11, 11:09 AM · Restricted Project, Restricted Project

Thu, Jan 7

clementval committed rG48baa7f5b11c: [clang] Add powerpc64le-none-linux-gnu to gnu toolchain for PPC64 (authored by clementval).
[clang] Add powerpc64le-none-linux-gnu to gnu toolchain for PPC64
Thu, Jan 7, 5:08 PM
clementval closed D94261: [clang] Add powerpc64le-none-linux-gnu to gnu toolchain for PPC64.
Thu, Jan 7, 5:08 PM · Restricted Project
clementval requested review of D94261: [clang] Add powerpc64le-none-linux-gnu to gnu toolchain for PPC64.
Thu, Jan 7, 1:30 PM · Restricted Project
clementval added inline comments to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Thu, Jan 7, 6:50 AM · Restricted Project, Restricted Project
clementval resigned from D83636: omp: Make OMP tablegen more like all other tablegens..

Patch D92955 and D93576 were going in this sense and landed. Patch D93560 is moving all to .inc file.

Thu, Jan 7, 6:45 AM · Restricted Project
clementval committed rGb73736a40481: [flang][openacc] Enforce delcare directive restriction (authored by clementval).
[flang][openacc] Enforce delcare directive restriction
Thu, Jan 7, 6:29 AM
clementval closed D92741: [flang][openacc] Enforce delcare directive restriction.
Thu, Jan 7, 6:29 AM · Restricted Project, Restricted Project

Wed, Jan 6

clementval added a comment to D92741: [flang][openacc] Enforce delcare directive restriction.

Thanks for the review. Did not see it before for some reason. I made some update to the patch.

Wed, Jan 6, 12:01 PM · Restricted Project, Restricted Project
clementval updated the diff for D92741: [flang][openacc] Enforce delcare directive restriction.

Rebase + address review comment

Wed, Jan 6, 12:00 PM · Restricted Project, Restricted Project
clementval committed rG322e98bc2799: [flang][openacc] Add more parsing/sema tests for init and shutdown directives (authored by clementval).
[flang][openacc] Add more parsing/sema tests for init and shutdown directives
Wed, Jan 6, 11:15 AM
clementval closed D90786: [flang][openacc] Add more parsing/sema tests for init and shutdown directives.
Wed, Jan 6, 11:15 AM · Restricted Project
clementval updated the diff for D90786: [flang][openacc] Add more parsing/sema tests for init and shutdown directives.

Rebase

Wed, Jan 6, 7:59 AM · Restricted Project

Tue, Jan 5

clementval added inline comments to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..
Tue, Jan 5, 12:44 PM · Restricted Project, Restricted Project
clementval added a comment to D90786: [flang][openacc] Add more parsing/sema tests for init and shutdown directives.

Ping

Tue, Jan 5, 12:15 PM · Restricted Project
clementval accepted D93301: [flang][driver] Add support for `-c` and `-emit-obj`.

LGTM

Tue, Jan 5, 8:47 AM · Restricted Project, Restricted Project

Mon, Jan 4

clementval added a comment to D92065: [flang][openacc] Lower parallel loop combined construct.

We're waiting on the ability to have tests for these I believe.

Mon, Jan 4, 5:23 PM · Restricted Project, Restricted Project
clementval committed rG4d0aad96e431: [flang][openmp] Make Reduction clause part of OmpClause (authored by clementval).
[flang][openmp] Make Reduction clause part of OmpClause
Mon, Jan 4, 12:19 PM
clementval closed D93482: [flang][openmp] Make Reduction clause part of OmpClause.
Mon, Jan 4, 12:19 PM · Restricted Project, Restricted Project
clementval updated the diff for D93482: [flang][openmp] Make Reduction clause part of OmpClause.

Rebase

Mon, Jan 4, 12:15 PM · Restricted Project, Restricted Project

Wed, Dec 30

clementval added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

@kiranchandramohan @sameeranjoshi Will the patch https://reviews.llvm.org/D93105 be committed to the master again?
If so , the function void GetSymbolsInDesignatorList(const std::list<parser::Designator> &, SymbolSourceMap &); would not be required.

Wed, Dec 30, 11:47 AM · Restricted Project, Restricted Project, Restricted Project

Dec 22 2020

clementval reopened D93105: [Flang][openmp][5.0] Add task_reduction clause..

Reopen the revision since it was reverted and other patches depend on it.

Dec 22 2020, 12:23 PM · Restricted Project, Restricted Project
clementval resigned from rG9a7895dc2085: [Flang][openmp][5.0] Add task_reduction clause..

Not sure what I'm supposed to do as an auditor. I guess you tried to fix the author stuff?

Dec 22 2020, 11:28 AM
clementval added a comment to D93105: [Flang][openmp][5.0] Add task_reduction clause..

The co-authorship must be in the commit message. Updating phab doesn't change what was landed. Look at https://github.com/llvm/llvm-project/commit/8a58f21f5b6c228137a9b87906fe5b720c4d1dfb, the co-authorship is correctly displayed on GitHub. This is not the case with the commit you landed for this revision.

Dec 22 2020, 9:56 AM · Restricted Project, Restricted Project
clementval updated the summary of D93710: [mlir][openacc] Use TableGen information for default enum.
Dec 22 2020, 8:41 AM · Restricted Project, Restricted Project
clementval added inline comments to D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..
Dec 22 2020, 8:34 AM · Restricted Project, Restricted Project
clementval requested review of D93710: [mlir][openacc] Use TableGen information for default enum.
Dec 22 2020, 7:55 AM · Restricted Project, Restricted Project
clementval committed rG28b00ba73116: [openacc][openmp][NFC] Fix typo in comments (authored by clementval).
[openacc][openmp][NFC] Fix typo in comments
Dec 22 2020, 7:00 AM
clementval added inline comments to D93576: [openacc] Use TableGen enum for default clause value.
Dec 22 2020, 6:55 AM · Restricted Project, Restricted Project

Dec 21 2020

clementval committed rG8f933a4e931d: [openacc] Use TableGen enum for default clause value (authored by clementval).
[openacc] Use TableGen enum for default clause value
Dec 21 2020, 12:07 PM
clementval closed D93576: [openacc] Use TableGen enum for default clause value.
Dec 21 2020, 12:07 PM · Restricted Project, Restricted Project
clementval updated the summary of D93576: [openacc] Use TableGen enum for default clause value.
Dec 21 2020, 12:06 PM · Restricted Project, Restricted Project
clementval accepted D93644: [Flang][openmp][5/5] Make dist_schedule clause part of OmpClause.

LGTM

Dec 21 2020, 9:41 AM · Restricted Project, Restricted Project
clementval accepted D93643: [Flang][openmp][4/5] Make nowait clause part of OmpClause.

LGTM

Dec 21 2020, 9:40 AM · Restricted Project
clementval accepted D93642: [Flang][openmp][3/5] Make ProcBind clause part of OmpClause.

LGTM

Dec 21 2020, 9:37 AM · Restricted Project
clementval accepted D93641: [Flang][openmp][2/5] Make Default clause part of OmpClause.

LGTM

Dec 21 2020, 9:36 AM · Restricted Project
clementval accepted D93640: [Flang][openmp][1/5] Make Allocate clause part of OmpClause.

Thanks for working on this. LGTM

Dec 21 2020, 9:34 AM · Restricted Project

Dec 19 2020

clementval added inline comments to D93482: [flang][openmp] Make Reduction clause part of OmpClause.
Dec 19 2020, 4:30 AM · Restricted Project, Restricted Project

Dec 18 2020

clementval added a comment to D83636: omp: Make OMP tablegen more like all other tablegens..

Patch D92955 and D93576 are going in this sense.

Dec 18 2020, 7:46 PM · Restricted Project
clementval added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Dec 18 2020, 7:42 PM · Restricted Project, Restricted Project, Restricted Project
clementval added a project to D93575: [flang][openxx][NFC] Remove duplicated function to check required clauses: Restricted Project.
Dec 18 2020, 7:27 PM · Restricted Project, Restricted Project
clementval added a project to D93576: [openacc] Use TableGen enum for default clause value: Restricted Project.
Dec 18 2020, 7:27 PM · Restricted Project, Restricted Project
clementval requested review of D93576: [openacc] Use TableGen enum for default clause value.
Dec 18 2020, 7:24 PM · Restricted Project, Restricted Project
clementval requested review of D93575: [flang][openxx][NFC] Remove duplicated function to check required clauses.
Dec 18 2020, 7:20 PM · Restricted Project, Restricted Project
clementval requested review of D93560: [openacc][openmp] Reduce number of generated file and prefer inclusion of .inc.
Dec 18 2020, 12:27 PM · Restricted Project
clementval added inline comments to D93051: [Flang][openmp] Add semantic checks for OpenMP critical construct..
Dec 18 2020, 11:23 AM · Restricted Project
clementval added inline comments to D93482: [flang][openmp] Make Reduction clause part of OmpClause.
Dec 18 2020, 11:15 AM · Restricted Project, Restricted Project
clementval added inline comments to D93482: [flang][openmp] Make Reduction clause part of OmpClause.
Dec 18 2020, 8:57 AM · Restricted Project, Restricted Project
clementval added inline comments to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 18 2020, 7:25 AM · Restricted Project, Restricted Project
clementval added a project to D93485: [openacc] Rename generated file from ACC.cpp.inc to ACC.inc to match D92955: Restricted Project.
Dec 18 2020, 7:21 AM · Restricted Project, Restricted Project

Dec 17 2020

clementval requested review of D93485: [openacc] Rename generated file from ACC.cpp.inc to ACC.inc to match D92955.
Dec 17 2020, 12:38 PM · Restricted Project, Restricted Project
clementval added a project to D93482: [flang][openmp] Make Reduction clause part of OmpClause: Restricted Project.
Dec 17 2020, 12:36 PM · Restricted Project, Restricted Project
clementval added inline comments to D93105: [Flang][openmp][5.0] Add task_reduction clause..
Dec 17 2020, 12:13 PM · Restricted Project, Restricted Project
clementval requested review of D93482: [flang][openmp] Make Reduction clause part of OmpClause.
Dec 17 2020, 12:12 PM · Restricted Project, Restricted Project
clementval accepted D93105: [Flang][openmp][5.0] Add task_reduction clause..

I guess it looks like what we have discussed now.

Dec 17 2020, 11:51 AM · Restricted Project, Restricted Project
clementval added inline comments to D93105: [Flang][openmp][5.0] Add task_reduction clause..
Dec 17 2020, 11:41 AM · Restricted Project, Restricted Project
clementval updated the diff for D93105: [Flang][openmp][5.0] Add task_reduction clause..

Remove indirection and use OmpReductionClause directly.

Dec 17 2020, 11:37 AM · Restricted Project, Restricted Project
clementval committed rGf4c8b8031800: [openmp] Remove clause from OMPKinds.def and use OMP.td info (authored by clementval).
[openmp] Remove clause from OMPKinds.def and use OMP.td info
Dec 17 2020, 11:08 AM
clementval closed D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info.
Dec 17 2020, 11:08 AM · Restricted Project, Restricted Project
clementval committed rG71699a998d4f: [flang][openacc] Enforce restriction on routine directive and clauses (authored by clementval).
[flang][openacc] Enforce restriction on routine directive and clauses
Dec 17 2020, 8:34 AM
clementval closed D92672: [flang][openacc] Enforce restriction on routine directive and clauses.
Dec 17 2020, 8:33 AM · Restricted Project, Restricted Project
clementval added inline comments to D92672: [flang][openacc] Enforce restriction on routine directive and clauses.
Dec 17 2020, 8:32 AM · Restricted Project, Restricted Project
clementval updated the diff for D92672: [flang][openacc] Enforce restriction on routine directive and clauses.

Rebase + nit comment

Dec 17 2020, 8:31 AM · Restricted Project, Restricted Project
clementval committed rG36bf2de8d866: [flang][openacc] Update serial construct clauses for OpenACC 3.1 (authored by clementval).
[flang][openacc] Update serial construct clauses for OpenACC 3.1
Dec 17 2020, 7:51 AM
clementval closed D92123: [flang][openacc] Update serial construct clauses for OpenACC 3.1.
Dec 17 2020, 7:50 AM · Restricted Project, Restricted Project