Page MenuHomePhabricator
People clementval

clementval (Valentin Clement)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2019, 1:05 PM (171 w, 5 d)

Recent Activity
View All

Thu, Mar 23

clementval added a comment to D146594: [flang] Lower fir.dispatch in the fir-polymorphic-op pass.

Thanks Renaud for this simplification in code gen!

Thu, Mar 23, 9:52 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 21

clementval committed rGfaa1043144b3: [flang] Carry over dynamic type information when creating an unlimited… (authored by clementval).
[flang] Carry over dynamic type information when creating an unlimited…
Tue, Mar 21, 8:08 AM · Restricted Project, Restricted Project
clementval closed D146525: [flang] Carry over dynamic type information when creating an unlimited polymorphic temp.
Tue, Mar 21, 8:08 AM · Restricted Project, Restricted Project
clementval requested review of D146525: [flang] Carry over dynamic type information when creating an unlimited polymorphic temp.
Tue, Mar 21, 6:55 AM · Restricted Project, Restricted Project
clementval added a comment to D144876: [Flang][PowerPC] Implement PPC mtfsf/mtfsfi intrinsics.

Looks ok for me. Just small nits.

Tue, Mar 21, 2:18 AM · Restricted Project, Restricted Project
clementval committed rG658595d031f7: [flang] Handle polymorphic entities with rank > 0 in entry statement (authored by clementval).
[flang] Handle polymorphic entities with rank > 0 in entry statement
Tue, Mar 21, 1:51 AM · Restricted Project, Restricted Project
clementval closed D146447: [flang] Handle polymorphic entities with rank > 0 in entry statement.
Tue, Mar 21, 1:51 AM · Restricted Project, Restricted Project

Mon, Mar 20

clementval requested review of D146447: [flang] Handle polymorphic entities with rank > 0 in entry statement.
Mon, Mar 20, 11:24 AM · Restricted Project, Restricted Project
clementval abandoned D84064: [flang][openacc] OpenACC module signature.
Mon, Mar 20, 9:44 AM · Restricted Project, Restricted Project, Restricted Project
clementval resigned from D144788: [Flang] Allocate character with source returns stat = 0 when already allocated.
Mon, Mar 20, 9:43 AM · Restricted Project, Restricted Project
clementval committed rG029313cc979a: [flang] Update allocate lowering to use AllocatableInit.*ForAllocate functions (authored by clementval).
[flang] Update allocate lowering to use AllocatableInit.*ForAllocate functions
Mon, Mar 20, 2:02 AM · Restricted Project, Restricted Project
clementval closed D146291: [flang] Update allocate lowering to use AllocatableInit.*ForAllocate functions.
Mon, Mar 20, 2:02 AM · Restricted Project, Restricted Project
clementval committed rG52e239794f35: [flang] Add AllocatableInit functions for use in allocate lowering (authored by clementval).
[flang] Add AllocatableInit functions for use in allocate lowering
Mon, Mar 20, 2:01 AM · Restricted Project, Restricted Project
clementval closed D146290: [flang] Add AllocatableInit functions for use in allocate lowering.
Mon, Mar 20, 2:00 AM · Restricted Project, Restricted Project

Fri, Mar 17

clementval added a reverting change for rGbde91fd03f72: [flang] Feature list plugin: rG9be446588e3b: Revert "[flang] Feature list plugin".
Fri, Mar 17, 10:00 AM · Restricted Project, Restricted Project
clementval committed rG9be446588e3b: Revert "[flang] Feature list plugin" (authored by clementval).
Revert "[flang] Feature list plugin"
Fri, Mar 17, 10:00 AM · Restricted Project, Restricted Project
clementval committed rG49d718db86aa: [flang] Pass box address for bind(c) assumed type dummy argument (authored by clementval).
[flang] Pass box address for bind(c) assumed type dummy argument
Fri, Mar 17, 9:59 AM · Restricted Project, Restricted Project
clementval closed D146300: [flang] Pass box address for bind(c) assumed type dummy argument.
Fri, Mar 17, 9:59 AM · Restricted Project, Restricted Project
clementval committed rG3132c78aea5e: [flang][NFC] Fix subroutine name (authored by clementval).
[flang][NFC] Fix subroutine name
Fri, Mar 17, 9:39 AM · Restricted Project, Restricted Project
clementval requested changes to D142796: Flang semantic check support for tile and unroll OpenMP Directive..
Fri, Mar 17, 9:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clementval added inline comments to D142796: Flang semantic check support for tile and unroll OpenMP Directive..
Fri, Mar 17, 9:15 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clementval added inline comments to D142796: Flang semantic check support for tile and unroll OpenMP Directive..
Fri, Mar 17, 9:09 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
clementval added a comment to D146204: [flang] Fix build error caused by missing llvm-readelf.

I still see error in the pre commit CI -> https://buildkite.com/llvm-project/premerge-checks/builds/141680#0186ef93-ff26-4149-bb7d-10163ef64ec5

Fri, Mar 17, 8:24 AM · Restricted Project, Restricted Project
clementval requested review of D146300: [flang] Pass box address for bind(c) assumed type dummy argument.
Fri, Mar 17, 8:10 AM · Restricted Project, Restricted Project
clementval retitled D146291: [flang] Update allocate lowering to use AllocatableInit.*ForAllocate functions from [flang] Use AllocatableInit[.*]ForAllocate functions to [flang] Update allocate lowering to use AllocatableInit.*ForAllocate functions.
Fri, Mar 17, 5:38 AM · Restricted Project, Restricted Project
clementval requested review of D146291: [flang] Update allocate lowering to use AllocatableInit.*ForAllocate functions.
Fri, Mar 17, 5:37 AM · Restricted Project, Restricted Project
clementval requested review of D146290: [flang] Add AllocatableInit functions for use in allocate lowering.
Fri, Mar 17, 5:36 AM · Restricted Project, Restricted Project

Thu, Mar 16

clementval committed rG1d837cf2cf17: [flang] Do not try to rebox for assumed type (authored by clementval).
[flang] Do not try to rebox for assumed type
Thu, Mar 16, 9:17 AM · Restricted Project, Restricted Project
clementval closed D146209: [flang] Do not try to rebox for assumed type.
Thu, Mar 16, 9:17 AM · Restricted Project, Restricted Project
clementval committed rGb52e97415f96: [flang] Embox argument for assumed type dummy argument to !fir.box<none> (authored by clementval).
[flang] Embox argument for assumed type dummy argument to !fir.box<none>
Thu, Mar 16, 9:11 AM · Restricted Project, Restricted Project
clementval closed D146207: [flang] Embox argument for assumed type dummy argument to !fir.box<none>.
Thu, Mar 16, 9:11 AM · Restricted Project, Restricted Project
clementval updated the diff for D146209: [flang] Do not try to rebox for assumed type.

clang-format

Thu, Mar 16, 8:26 AM · Restricted Project, Restricted Project
clementval abandoned D146224: [flang] Let double allocation error be catched by AllocatableAllocate.
Thu, Mar 16, 8:25 AM · Restricted Project, Restricted Project
clementval added inline comments to D146224: [flang] Let double allocation error be catched by AllocatableAllocate.
Thu, Mar 16, 8:24 AM · Restricted Project, Restricted Project
clementval added inline comments to D146224: [flang] Let double allocation error be catched by AllocatableAllocate.
Thu, Mar 16, 8:19 AM · Restricted Project, Restricted Project
clementval retitled D146207: [flang] Embox argument for assumed type dummy argument to !fir.box<none> from [flang] Embox argument for asusmed type dummy to !fir.box<none> to [flang] Embox argument for assumed type dummy argument to !fir.box<none>.
Thu, Mar 16, 7:50 AM · Restricted Project, Restricted Project
clementval requested review of D146224: [flang] Let double allocation error be catched by AllocatableAllocate.
Thu, Mar 16, 6:35 AM · Restricted Project, Restricted Project
clementval updated the diff for D146209: [flang] Do not try to rebox for assumed type.

Add missing test

Thu, Mar 16, 6:12 AM · Restricted Project, Restricted Project
clementval updated the diff for D146207: [flang] Embox argument for assumed type dummy argument to !fir.box<none>.

Remove unused interface

Thu, Mar 16, 6:11 AM · Restricted Project, Restricted Project
clementval updated the diff for D146207: [flang] Embox argument for assumed type dummy argument to !fir.box<none>.

Add missing test

Thu, Mar 16, 6:08 AM · Restricted Project, Restricted Project
clementval requested review of D146209: [flang] Do not try to rebox for assumed type.
Thu, Mar 16, 3:15 AM · Restricted Project, Restricted Project
clementval requested review of D146207: [flang] Embox argument for assumed type dummy argument to !fir.box<none>.
Thu, Mar 16, 2:54 AM · Restricted Project, Restricted Project
clementval added a comment to D146186: [flang] Replace !fir.ref<BoxType> -> BoxType conversion with a load prior to calling fir.dispatch.

There is a failure on the pre commit CI but I doesn't look related to your change at all.

Thu, Mar 16, 1:13 AM · Restricted Project, Restricted Project, Restricted Project
clementval accepted D146186: [flang] Replace !fir.ref<BoxType> -> BoxType conversion with a load prior to calling fir.dispatch.

As you pointed out this is ok to do the conversion but I think it is looks better to do the load. Thanks for the patch Renaud! LGTM

Thu, Mar 16, 1:00 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 15

clementval committed rG94d9b7ce604f: [flang] Detect fir.class nested in fir.box as invalid element type (authored by clementval).
[flang] Detect fir.class nested in fir.box as invalid element type
Wed, Mar 15, 9:36 AM · Restricted Project, Restricted Project
clementval closed D146078: [flang] Detect fir.class nested in fir.box as invalid element type.
Wed, Mar 15, 9:36 AM · Restricted Project, Restricted Project
clementval committed rG426c495e88d7: [flang] Avoid to wrap box/class type with box/class (authored by clementval).
[flang] Avoid to wrap box/class type with box/class
Wed, Mar 15, 9:28 AM · Restricted Project, Restricted Project
clementval closed D146120: [flang] Avoid to wrap box/class type with box/class.
Wed, Mar 15, 9:28 AM · Restricted Project, Restricted Project
clementval committed rG942bc18d203a: [flang] Rebox the polymorphic argument in merge intrinsic (authored by clementval).
[flang] Rebox the polymorphic argument in merge intrinsic
Wed, Mar 15, 8:33 AM · Restricted Project, Restricted Project
clementval closed D146133: [flang] Rebox the polymorphic argument in merge intrinsic.
Wed, Mar 15, 8:32 AM · Restricted Project, Restricted Project
clementval requested review of D146133: [flang] Rebox the polymorphic argument in merge intrinsic.
Wed, Mar 15, 6:08 AM · Restricted Project, Restricted Project
clementval updated the diff for D146078: [flang] Detect fir.class nested in fir.box as invalid element type.

Rebase on D146120

Wed, Mar 15, 2:57 AM · Restricted Project, Restricted Project
clementval requested review of D146120: [flang] Avoid to wrap box/class type with box/class.
Wed, Mar 15, 2:56 AM · Restricted Project, Restricted Project
clementval added a reverting change for rGfbca61c46612: [flang] Load fir.ref<fir.class<T>> instead of creating a wrong box: rGa95255f9662b: Revert "[flang] Load fir.ref<fir.class<T>> instead of creating a wrong box".
Wed, Mar 15, 2:39 AM · Restricted Project, Restricted Project
clementval committed rGa95255f9662b: Revert "[flang] Load fir.ref<fir.class<T>> instead of creating a wrong box" (authored by clementval).
Revert "[flang] Load fir.ref<fir.class<T>> instead of creating a wrong box"
Wed, Mar 15, 2:39 AM · Restricted Project, Restricted Project
clementval added a reverting change for D146079: [flang] Load fir.ref<fir.class<T>> instead of creating a wrong box: rGa95255f9662b: Revert "[flang] Load fir.ref<fir.class<T>> instead of creating a wrong box".
Wed, Mar 15, 2:38 AM · Restricted Project, Restricted Project
clementval added a comment to D146078: [flang] Detect fir.class nested in fir.box as invalid element type.

Something was probably messed up with the dependency. I rebased this patch now that the other has landed.

Wed, Mar 15, 1:59 AM · Restricted Project, Restricted Project
clementval updated the diff for D146078: [flang] Detect fir.class nested in fir.box as invalid element type.

Rebase

Wed, Mar 15, 1:59 AM · Restricted Project, Restricted Project

Tue, Mar 14

clementval committed rGfbca61c46612: [flang] Load fir.ref<fir.class<T>> instead of creating a wrong box (authored by clementval).
[flang] Load fir.ref<fir.class<T>> instead of creating a wrong box
Tue, Mar 14, 1:45 PM · Restricted Project, Restricted Project
clementval closed D146079: [flang] Load fir.ref<fir.class<T>> instead of creating a wrong box.
Tue, Mar 14, 1:45 PM · Restricted Project, Restricted Project
clementval added a comment to D146078: [flang] Detect fir.class nested in fir.box as invalid element type.
In D146078#4194285, @PeteSteinfeld wrote:

When I build and test this patch, I get errors:

Failed Tests (2):
  Flang :: Lower/HLFIR/allocatables-and-pointers.f90
  Flang :: Lower/Intrinsics/associated.f90

Let me know if you need more detail on the failures.

Tue, Mar 14, 1:34 PM · Restricted Project, Restricted Project
clementval updated the summary of D146079: [flang] Load fir.ref<fir.class<T>> instead of creating a wrong box.
Tue, Mar 14, 1:32 PM · Restricted Project, Restricted Project
clementval requested review of D146079: [flang] Load fir.ref<fir.class<T>> instead of creating a wrong box.
Tue, Mar 14, 12:29 PM · Restricted Project, Restricted Project
clementval requested review of D146078: [flang] Detect fir.class nested in fir.box as invalid element type.
Tue, Mar 14, 12:10 PM · Restricted Project, Restricted Project
clementval committed rG6472a2ee363f: [flang] Handle parent component on the LHS of intrinsic assignment (authored by clementval).
[flang] Handle parent component on the LHS of intrinsic assignment
Tue, Mar 14, 8:02 AM · Restricted Project, Restricted Project
clementval closed D146046: [flang] Handle parent component on the LHS of intrinsic assignment.
Tue, Mar 14, 8:02 AM · Restricted Project, Restricted Project
clementval requested review of D146046: [flang] Handle parent component on the LHS of intrinsic assignment.
Tue, Mar 14, 6:49 AM · Restricted Project, Restricted Project
clementval accepted D145959: [flang][hlfir] add matmul canonicalizer.

I think it makes sense to do this as a canonicalization pattern.

Tue, Mar 14, 2:56 AM · Restricted Project, Restricted Project
clementval added a comment to D146011: [flang][examples] remove unnecessary PASUE stamtment.

I think you can leave the example as is.

Tue, Mar 14, 12:07 AM · Restricted Project, Restricted Project

Mon, Mar 13

clementval committed rGc024fa4b5bd6: [flang] Use llvm.zext when converting from i1 -> iXX (authored by clementval).
[flang] Use llvm.zext when converting from i1 -> iXX
Mon, Mar 13, 10:32 PM · Restricted Project, Restricted Project
clementval closed D145984: [flang] Use llvm.zext when converting from i1 -> iXX.
Mon, Mar 13, 10:32 PM · Restricted Project, Restricted Project
clementval requested review of D145984: [flang] Use llvm.zext when converting from i1 -> iXX.
Mon, Mar 13, 1:17 PM · Restricted Project, Restricted Project
clementval committed rG67318df027ca: [flang] Handle parent component in user function argument for special cases (authored by clementval).
[flang] Handle parent component in user function argument for special cases
Mon, Mar 13, 12:49 PM · Restricted Project, Restricted Project
clementval closed D145931: [flang] Handle parent component in user function argument for special cases.
Mon, Mar 13, 12:49 PM · Restricted Project, Restricted Project
clementval committed rG33fbbf88afe5: [flang] Handle parent component in user function argument (authored by clementval).
[flang] Handle parent component in user function argument
Mon, Mar 13, 12:31 PM · Restricted Project, Restricted Project
clementval closed D145928: [flang] Handle parent component in user function argument.
Mon, Mar 13, 12:30 PM · Restricted Project, Restricted Project
clementval accepted D145968: [flang] Accept non-interoperable LOGICAL scalar dummy arguments.

LGTM

Mon, Mar 13, 12:04 PM · Restricted Project, Restricted Project
clementval added a comment to D145503: [flang][hlfir] clean up intrinsic arg extended values.
In D145503#4189646, @tblah wrote:
In D145503#4189416, @clementval wrote:

Can you add some tests?

Is https://reviews.llvm.org/D145504 enough?

Mon, Mar 13, 11:51 AM · Restricted Project, Restricted Project
clementval updated the diff for D145931: [flang] Handle parent component in user function argument for special cases.

Rebase

Mon, Mar 13, 9:34 AM · Restricted Project, Restricted Project
clementval updated the diff for D145928: [flang] Handle parent component in user function argument.

Clean up the mess

Mon, Mar 13, 9:28 AM · Restricted Project, Restricted Project
clementval updated the diff for D145928: [flang] Handle parent component in user function argument.

Remove conflict

Mon, Mar 13, 9:21 AM · Restricted Project, Restricted Project
clementval updated the diff for D145928: [flang] Handle parent component in user function argument.

Rebase

Mon, Mar 13, 9:19 AM · Restricted Project, Restricted Project
clementval resigned from D145883: [Flang][RISCV] Emit target features for RISC-V.
Mon, Mar 13, 9:09 AM · Restricted Project, Restricted Project, Restricted Project
clementval added a comment to D145503: [flang][hlfir] clean up intrinsic arg extended values.

Can you add some tests?

Mon, Mar 13, 8:15 AM · Restricted Project, Restricted Project
clementval committed rG71e2d7106fe5: [flang] Handle parent component in intrinsic function arguments (authored by clementval).
[flang] Handle parent component in intrinsic function arguments
Mon, Mar 13, 7:29 AM · Restricted Project, Restricted Project
clementval closed D145907: [flang] Handle parent component in intrinsic function arguments.
Mon, Mar 13, 7:28 AM · Restricted Project, Restricted Project
clementval added inline comments to D145907: [flang] Handle parent component in intrinsic function arguments.
Mon, Mar 13, 7:28 AM · Restricted Project, Restricted Project
clementval committed rG955eaaf1b52f: [flang] Only check for embox/rebox if defining op is present (authored by clementval).
[flang] Only check for embox/rebox if defining op is present
Mon, Mar 13, 7:26 AM · Restricted Project, Restricted Project
clementval closed D145910: [flang] Only check for embox/rebox if defining op is present.
Mon, Mar 13, 7:26 AM · Restricted Project, Restricted Project
clementval added a comment to D145931: [flang] Handle parent component in user function argument for special cases.
In D145931#4189125, @PeteSteinfeld wrote:

I get errors from check-flang:

******************** TEST 'Flang :: Lower/polymorphic.f90' FAILED ********************
Script:
--
: 'RUN: at line 1';   bbc -polymorphic-type -emit-fir /local/home/psteinfeld/main/931/flang/test/Lower/polymorphic.f90 -o - | /local/home/psteinfeld/main/931/build/bin/FileCheck /local/home/psteinfeld/main/931/flang/test/Lower/polymorphic.f90
--
Exit Code: 2

Command Output (stderr):
--
bbc: /local/home/psteinfeld/main/931/llvm/include/llvm/Support/Casting.h:663: decltype(auto) llvm::dyn_cast(From*) [with To = fir::EmboxOp; From = mlir::Operation]: Assertion `detail::isPresent(Val) && "dyn_cast on a non-existent value"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.      Program arguments: bbc -polymorphic-type -emit-fir /local/home/psteinfeld/main/931/flang/test/Lower/polymorphic.f90 -o -
 #0 0x00005651e153756b llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/local/home/psteinfeld/main/931/build/bin/bbc+0x1c7b56b)
 #1 0x00005651e1534de4 SignalHandler(int) Signals.cpp:0:0
 #2 0x000014887cdfdc20 __restore_rt sigaction.c:0:0
 #3 0x000014887b5ec37f raise (/lib64/libc.so.6+0x3737f)
 #4 0x000014887b5d6db5 abort (/lib64/libc.so.6+0x21db5)
 #5 0x000014887b5d6c89 _nl_load_domain.cold.0 loadmsgcat.c:0:0
 #6 0x000014887b5e4a76 .annobin___GI___assert_fail.end assert.c:0:0
 #7 0x00005651e07f0c36 Fortran::lower::updateBoxForParentComponent(Fortran::lower::AbstractConverter&, fir::ExtendedValue, Fortran::evaluate::Expr<Fortran::evaluate::SomeType> const&) (/local/home/psteinfeld/main/931/build/bin/bbc+0xf34c36)
 #8 0x00005651e08e01a2 (anonymous namespace)::ScalarExprLowering::genRawProcedureRef(Fortran::evaluate::ProcedureRef const&, std::optional<mlir::Type>) ConvertExpr.cpp:0:0
 #9 0x00005651e08e0803 (anonymous namespace)::ScalarExprLowering::genProcedureRef(Fortran::evaluate::ProcedureRef const&, std::optional<mlir::Type>) ConvertExpr.cpp:0:0
Mon, Mar 13, 7:16 AM · Restricted Project, Restricted Project
clementval added a comment to D145928: [flang] Handle parent component in user function argument.
In D145928#4189101, @PeteSteinfeld wrote:

I get errors from check-flang:

******************** TEST 'Flang :: Lower/polymorphic.f90' FAILED ********************
Script:
--
: 'RUN: at line 1';   bbc -polymorphic-type -emit-fir /local/home/psteinfeld/main/928/flang/test/Lower/polymorphic.f90 -o - | /local/home/psteinfeld/main/928/build/bin/FileCheck /local/home/psteinfeld/main/928/flang/test/Lower/polymorphic.f90
--
Exit Code: 2

Command Output (stderr):
--
bbc: /local/home/psteinfeld/main/928/llvm/include/llvm/Support/Casting.h:663: decltype(auto) llvm::dyn_cast(From*) [with To = fir::EmboxOp; From = mlir::Operation]: Assertion `detail::isPresent(Val) && "dyn_cast on a non-existent value"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.      Program arguments: bbc -polymorphic-type -emit-fir /local/home/psteinfeld/main/928/flang/test/Lower/polymorphic.f90 -o -
 #0 0x0000563e3b5b253b llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/local/home/psteinfeld/main/928/build/bin/bbc+0x1c7b53b)
 #1 0x0000563e3b5afdb4 SignalHandler(int) Signals.cpp:0:0
 #2 0x0000147555a4fc20 __restore_rt sigaction.c:0:0
 #3 0x000014755423e37f raise (/lib64/libc.so.6+0x3737f)
 #4 0x0000147554228db5 abort (/lib64/libc.so.6+0x21db5)
 #5 0x0000147554228c89 _nl_load_domain.cold.0 loadmsgcat.c:0:0
 #6 0x0000147554236a76 .annobin___GI___assert_fail.end assert.c:0:0
 #7 0x0000563e3a86bc36 Fortran::lower::updateBoxForParentComponent(Fortran::lower::AbstractConverter&, fir::ExtendedValue, Fortran::evaluate::Expr<Fortran::evaluate::SomeType> const&) (/local/home/psteinfeld/main/928/build/bin/bbc+0xf34c36)
 #8 0x0000563e3a95b16a (anonymous namespace)::ScalarExprLowering::genRawProcedureRef(Fortran::evaluate::ProcedureRef const&, std::optional<mlir::Type>) ConvertExpr.cpp:0:0
 #9 0x0000563e3a95b7d3 (anonymous namespace)::ScalarExprLowering::genProcedureRef(Fortran::evaluate::ProcedureRef const&, std::optional<mlir::Type>) ConvertExpr.cpp:0:0
Mon, Mar 13, 7:15 AM · Restricted Project, Restricted Project
clementval accepted D145653: [flang] Avoid ICE in case of subprogram name clash with runtime namespace..

Fine for me if this is the intended behavior.

Mon, Mar 13, 6:31 AM · Restricted Project, Restricted Project
clementval added inline comments to D145808: [Flang] Change fir.divc to perform library call rather than generate inline operations..
Mon, Mar 13, 6:31 AM · Restricted Project, Restricted Project
clementval requested review of D145931: [flang] Handle parent component in user function argument for special cases.
Mon, Mar 13, 6:11 AM · Restricted Project, Restricted Project
clementval requested review of D145928: [flang] Handle parent component in user function argument.
Mon, Mar 13, 5:39 AM · Restricted Project, Restricted Project
clementval requested review of D145910: [flang] Only check for embox/rebox if defining op is present.
Mon, Mar 13, 2:36 AM · Restricted Project, Restricted Project
clementval requested review of D145907: [flang] Handle parent component in intrinsic function arguments.
Mon, Mar 13, 2:15 AM · Restricted Project, Restricted Project

Sun, Mar 12

clementval committed rGfa77f579560e: [flang] Simpify parent component handling (authored by clementval).
[flang] Simpify parent component handling
Sun, Mar 12, 12:24 PM · Restricted Project, Restricted Project
clementval closed D145795: [flang] Simpify parent component handling.
Sun, Mar 12, 12:24 PM · Restricted Project, Restricted Project

Sat, Mar 11

clementval added a comment to D145845: [Flang] Allow compile *.f03, *.f08 file.
In D145845#4186607, @awarzynski wrote:

Thanks!

In D145845#4186590, @clementval wrote:

Thanks. Can you add tests in flang/test/Driver?

Hm, this is a clangDriver change rather than anything Flang specific 🤔 . Btw, how does https://github.com/llvm/llvm-project/issues/61260 manifest to you? I'm trying to figure out how to best test it (I couldn't find any other tests for this specifically).

Sat, Mar 11, 6:37 AM · Restricted Project, Restricted Project, Restricted Project