Page MenuHomePhabricator

clementval (Valentin Clement)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2019, 1:05 PM (79 w, 4 d)

Recent Activity

Tue, Jun 15

clementval added a project to D104301: [mlir][openacc] Initial translation for DataOp to LLVM IR: Unknown Object (Project).
Tue, Jun 15, 8:26 AM · Unknown Object (Project), Restricted Project
clementval requested review of D104301: [mlir][openacc] Initial translation for DataOp to LLVM IR.
Tue, Jun 15, 8:11 AM · Unknown Object (Project), Restricted Project

Wed, Jun 9

clementval committed rGcf8467057947: [mlir][openacc][NFC] move index in processDataOperands (authored by clementval).
[mlir][openacc][NFC] move index in processDataOperands
Wed, Jun 9, 7:28 AM
clementval closed D103924: [mlir][openacc][NFC] move index in processDataOperands.
Wed, Jun 9, 7:28 AM · Unknown Object (Project), Restricted Project

Tue, Jun 8

clementval added a project to D103924: [mlir][openacc][NFC] move index in processDataOperands: Unknown Object (Project).
Tue, Jun 8, 12:57 PM · Unknown Object (Project), Restricted Project
clementval requested review of D103924: [mlir][openacc][NFC] move index in processDataOperands.
Tue, Jun 8, 12:50 PM · Unknown Object (Project), Restricted Project

Mon, Jun 7

clementval requested changes to D103723: [MLIR][OpenMP]Add custom parser and pretty printer for target construct.
Mon, Jun 7, 12:16 PM · Restricted Project
clementval committed rGfb5b590b5e18: [mlir][openacc] Add conversion for if operand to scf.if for standalone data… (authored by clementval).
[mlir][openacc] Add conversion for if operand to scf.if for standalone data…
Mon, Jun 7, 9:10 AM
clementval closed D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.
Mon, Jun 7, 9:10 AM · Unknown Object (Project), Restricted Project
clementval added inline comments to D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.
Mon, Jun 7, 8:50 AM · Unknown Object (Project), Restricted Project
clementval committed rGaa4e6a609acd: [mlir][openacc] Add canonicalization for standalone data operations for if… (authored by clementval).
[mlir][openacc] Add canonicalization for standalone data operations for if…
Mon, Jun 7, 8:41 AM
clementval closed D103712: [mlir][openacc] Add canonicalization for standalone data operations for if condition.
Mon, Jun 7, 8:41 AM · Restricted Project
clementval added inline comments to D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.
Mon, Jun 7, 8:33 AM · Unknown Object (Project), Restricted Project
clementval updated the diff for D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.

Address review comments.

Mon, Jun 7, 8:33 AM · Unknown Object (Project), Restricted Project
clementval committed rGcfcdebaf3235: [mlir][openacc] Conversion of data operands in acc.parallel to LLVM IR dialect (authored by clementval).
[mlir][openacc] Conversion of data operands in acc.parallel to LLVM IR dialect
Mon, Jun 7, 8:22 AM
clementval closed D103337: [mlir][openacc] Conversion of data operands in acc.parallel to LLVM IR dialect.
Mon, Jun 7, 8:22 AM · Unknown Object (Project), Restricted Project
clementval updated the diff for D103337: [mlir][openacc] Conversion of data operands in acc.parallel to LLVM IR dialect.

Rebase

Mon, Jun 7, 8:18 AM · Unknown Object (Project), Restricted Project
clementval updated the diff for D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.

Address review comments

Mon, Jun 7, 8:07 AM · Unknown Object (Project), Restricted Project
clementval updated the diff for D103712: [mlir][openacc] Add canonicalization for standalone data operations for if condition.

Wrap ifCond removal in updateRootinPlace.

Mon, Jun 7, 7:51 AM · Restricted Project

Fri, Jun 4

clementval updated the diff for D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.

Remove changes that are not needed anymore.

Fri, Jun 4, 12:59 PM · Unknown Object (Project), Restricted Project
clementval added inline comments to D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.
Fri, Jun 4, 12:54 PM · Unknown Object (Project), Restricted Project
clementval updated the diff for D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.

Address review comments.

Fri, Jun 4, 12:54 PM · Unknown Object (Project), Restricted Project
clementval requested review of D103712: [mlir][openacc] Add canonicalization for standalone data operations for if condition.
Fri, Jun 4, 12:52 PM · Restricted Project
clementval committed rGfcb154722945: [mlir][openacc] Conversion of data operands in acc.data to LLVM IR dialect (authored by clementval).
[mlir][openacc] Conversion of data operands in acc.data to LLVM IR dialect
Fri, Jun 4, 7:26 AM
clementval closed D103332: [mlir][openacc] Conversion of data operands in acc.data to LLVM IR dialect.
Fri, Jun 4, 7:26 AM · Unknown Object (Project), Restricted Project

Wed, Jun 2

clementval added a comment to D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.
  1. Can this be a transformation pass?

@ftynse @rriddle Are there some best practices about conversion passes vs. transformation passes?

I think this is a good question to discuss in discourse. You can point to this review as well.

Wed, Jun 2, 11:45 AM · Unknown Object (Project), Restricted Project
clementval updated the diff for D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.

Fix header guard

Wed, Jun 2, 8:30 AM · Unknown Object (Project), Restricted Project

Tue, Jun 1

clementval added a comment to D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.
  1. Can this be a transformation pass?
Tue, Jun 1, 7:06 PM · Unknown Object (Project), Restricted Project
clementval committed rG6b8bf9494c46: [flang][openacc] Enforce restriction on attach and detach variables (authored by clementval).
[flang][openacc] Enforce restriction on attach and detach variables
Tue, Jun 1, 11:37 AM
clementval closed D103279: [flang][openacc] Enforce restriction on attach and detach variables.
Tue, Jun 1, 11:37 AM · Unknown Object (Project), Restricted Project, Restricted Project
clementval added inline comments to D103279: [flang][openacc] Enforce restriction on attach and detach variables.
Tue, Jun 1, 11:34 AM · Unknown Object (Project), Restricted Project, Restricted Project
clementval updated the diff for D103279: [flang][openacc] Enforce restriction on attach and detach variables.

Address review comments

Tue, Jun 1, 11:33 AM · Unknown Object (Project), Restricted Project, Restricted Project
clementval added a comment to D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.
  1. There is an SCF to OpenMP conversion, I can imagine an SCF to OpenACC conversion as well. This (OpenACC to SCF) would then create a cycle. Is that a problem?

You are right. I guess it depends how the final pipeline is set up. If the correct patterns are applied at the correct time it should work.

  1. Can this be a transformation pass?

Yeah that's probably better than conversion since it does not really convert the op to another op.

  1. For the OpenMP Parallel operation, the if clause is handled during translation. The CreateParallel function in the OpenMP IRBuilder accepts an if value and inserts an if-then-else. For consistency, should we do this during translation?

https://github.com/llvm/llvm-project/blob/2644399ce7721cba9a546a9af09fd2a942a4d0cd/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp#L531

I'm fine doing this in translation. The only point I see where it would be more beneficial to pass by SCF is for example if we want to translate to smth else than LLVM IR someday (e.g. SPIR-V). In that case going through scf would allow to use a single transformation to scf.if and reuse the available translation.

Tue, Jun 1, 7:07 AM · Unknown Object (Project), Restricted Project

Fri, May 28

clementval added a project to D103337: [mlir][openacc] Conversion of data operands in acc.parallel to LLVM IR dialect: Unknown Object (Project).
Fri, May 28, 12:25 PM · Unknown Object (Project), Restricted Project
clementval requested review of D103337: [mlir][openacc] Conversion of data operands in acc.parallel to LLVM IR dialect.
Fri, May 28, 12:24 PM · Unknown Object (Project), Restricted Project
clementval added a project to D103332: [mlir][openacc] Conversion of data operands in acc.data to LLVM IR dialect: Unknown Object (Project).
Fri, May 28, 12:12 PM · Unknown Object (Project), Restricted Project
clementval requested review of D103332: [mlir][openacc] Conversion of data operands in acc.data to LLVM IR dialect.
Fri, May 28, 11:42 AM · Unknown Object (Project), Restricted Project
clementval added a project to D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation: Unknown Object (Project).
Fri, May 28, 9:00 AM · Unknown Object (Project), Restricted Project
clementval requested review of D103325: [mlir][openacc] Add conversion for if operand to scf.if for standalone data operation.
Fri, May 28, 9:00 AM · Unknown Object (Project), Restricted Project

Thu, May 27

clementval added projects to D103279: [flang][openacc] Enforce restriction on attach and detach variables: Restricted Project, Unknown Object (Project).
Thu, May 27, 6:26 PM · Unknown Object (Project), Restricted Project, Restricted Project
clementval requested review of D103279: [flang][openacc] Enforce restriction on attach and detach variables.
Thu, May 27, 12:51 PM · Unknown Object (Project), Restricted Project, Restricted Project
clementval added inline comments to D102816: [MLIR][OpenMP]Basic OpenMP target operation.
Thu, May 27, 8:07 AM · Restricted Project, Restricted Project

Wed, May 26

clementval committed rG1005ef445dbf: [mlir][openacc] Translate UpdateOp to LLVM IR (authored by clementval).
[mlir][openacc] Translate UpdateOp to LLVM IR
Wed, May 26, 8:42 AM
clementval closed D102382: [mlir][openacc] Translate UpdateOp to LLVM IR.
Wed, May 26, 8:42 AM · Unknown Object (Project), Restricted Project
clementval updated the diff for D102382: [mlir][openacc] Translate UpdateOp to LLVM IR.

Rebase + address nit

Wed, May 26, 8:13 AM · Unknown Object (Project), Restricted Project

May 18 2021

clementval added a project to D102382: [mlir][openacc] Translate UpdateOp to LLVM IR: Unknown Object (Project).
May 18 2021, 5:11 PM · Unknown Object (Project), Restricted Project

May 17 2021

clementval committed rGab5ff154abe5: [mlir][openacc] Translate ExitDataop to LLVM IR (authored by clementval).
[mlir][openacc] Translate ExitDataop to LLVM IR
May 17 2021, 8:12 AM
clementval closed D102381: [mlir][openacc] Translate ExitDataop to LLVM IR.
May 17 2021, 8:12 AM · Restricted Project

May 13 2021

clementval committed rG8fdfead71aba: [mlir][openacc][NFC] add anonymous namespace around… (authored by clementval).
[mlir][openacc][NFC] add anonymous namespace around…
May 13 2021, 5:28 PM
clementval closed D102380: [mlir][openacc][NFC] add anonymous namespace around LegalizeDataOpForLLVMTranslation class.
May 13 2021, 5:28 PM · Restricted Project
clementval updated the diff for D102382: [mlir][openacc] Translate UpdateOp to LLVM IR.

Simplify test case and update after D102381 updates.

May 13 2021, 7:58 AM · Unknown Object (Project), Restricted Project
clementval updated the diff for D102381: [mlir][openacc] Translate ExitDataop to LLVM IR.

Simplify TypeSwitch

May 13 2021, 7:50 AM · Restricted Project
clementval updated the diff for D102381: [mlir][openacc] Translate ExitDataop to LLVM IR.

Address review comments

May 13 2021, 7:39 AM · Restricted Project
clementval added inline comments to D102381: [mlir][openacc] Translate ExitDataop to LLVM IR.
May 13 2021, 7:18 AM · Restricted Project

May 12 2021

clementval requested review of D102382: [mlir][openacc] Translate UpdateOp to LLVM IR.
May 12 2021, 5:30 PM · Unknown Object (Project), Restricted Project
clementval requested review of D102381: [mlir][openacc] Translate ExitDataop to LLVM IR.
May 12 2021, 5:19 PM · Restricted Project
clementval requested review of D102380: [mlir][openacc][NFC] add anonymous namespace around LegalizeDataOpForLLVMTranslation class.
May 12 2021, 5:16 PM · Restricted Project
clementval committed rG113b80701784: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin) (authored by clementval).
[mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin)
May 12 2021, 10:42 AM
clementval closed D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).
May 12 2021, 10:41 AM · Restricted Project
clementval added inline comments to D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).
May 12 2021, 8:40 AM · Restricted Project
clementval committed rG6110b667b053: [mlir][openacc] Conversion of data operand to LLVM IR dialect (authored by clementval).
[mlir][openacc] Conversion of data operand to LLVM IR dialect
May 12 2021, 8:34 AM
clementval closed D102170: [mlir][openacc] Conversion of data operand to LLVM IR dialect.
May 12 2021, 8:34 AM · Restricted Project
clementval updated the diff for D102170: [mlir][openacc] Conversion of data operand to LLVM IR dialect.

Rebase

May 12 2021, 8:29 AM · Restricted Project
clementval abandoned D92065: [flang][openacc] Lower parallel loop combined construct.

Will send a new version when the general lowering is available upstream.

May 12 2021, 7:27 AM · Restricted Project, Restricted Project

May 11 2021

clementval updated the diff for D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).

Address some more review comments

May 11 2021, 6:24 PM · Restricted Project
clementval added inline comments to D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).
May 11 2021, 12:08 PM · Restricted Project
clementval added inline comments to D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).
May 11 2021, 12:03 PM · Restricted Project
clementval updated the diff for D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).

Address review comment.

May 11 2021, 12:03 PM · Restricted Project
clementval updated the diff for D102170: [mlir][openacc] Conversion of data operand to LLVM IR dialect.

Make the conversion independent of std-to-llvm. Conversion can now be run before
std-to-llvm and cast op will be folded.

May 11 2021, 12:00 PM · Restricted Project
clementval added a comment to D102170: [mlir][openacc] Conversion of data operand to LLVM IR dialect.

@ftynse Thanks for the quick and very useful review. I made the conversion independent from "std-to-llvm".

May 11 2021, 11:59 AM · Restricted Project
clementval added inline comments to D102170: [mlir][openacc] Conversion of data operand to LLVM IR dialect.
May 11 2021, 7:32 AM · Restricted Project

May 10 2021

clementval added a comment to D102170: [mlir][openacc] Conversion of data operand to LLVM IR dialect.

Thanks! I think this goes into the right direction. I have a couple of small comments and two concerns:

  • the semantics of the OpenACC data descriptor is not documented, so it's hard to tell if the way it is obtained from a memref descriptor is correct or not; most likely it is not because it shouldn't be using the _allocated_ pointer twice;
  • the conversion pass shouldn't subsume std-to-llvm conversion, unless you can't make it work without it.
May 10 2021, 12:45 PM · Restricted Project
clementval updated the diff for D102170: [mlir][openacc] Conversion of data operand to LLVM IR dialect.

Address review comments

May 10 2021, 12:37 PM · Restricted Project
clementval updated the diff for D102170: [mlir][openacc] Conversion of data operand to LLVM IR dialect.

Fix header guard

May 10 2021, 8:15 AM · Restricted Project
clementval updated the diff for D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).

Update code to translate from converted types (D102170)

May 10 2021, 7:36 AM · Restricted Project
clementval requested review of D102170: [mlir][openacc] Conversion of data operand to LLVM IR dialect.
May 10 2021, 7:34 AM · Restricted Project

May 4 2021

clementval added a comment to D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).

I think the layering here is incorrect. It assumes translation has knowledge of higher-level types (memref), which defies the purpose of having LLVM dialect. Translation should only know about LLVM-level dialects.

May 4 2021, 5:25 PM · Restricted Project
clementval updated the diff for D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).

Address some review comments

May 4 2021, 5:23 PM · Restricted Project
clementval added inline comments to D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).
May 4 2021, 10:49 AM · Restricted Project
clementval updated the diff for D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).

Address some review comments

May 4 2021, 10:49 AM · Restricted Project
clementval updated the diff for D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).

Fix clang-tidy warnings

May 4 2021, 7:20 AM · Restricted Project

May 3 2021

clementval committed rG63f8226f259a: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions (authored by clementval).
[OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions
May 3 2021, 12:42 PM
clementval closed D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions.
May 3 2021, 12:42 PM · Restricted Project, Restricted Project
clementval updated the diff for D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions.

Rebase 2

May 3 2021, 12:41 PM · Restricted Project, Restricted Project
clementval updated the diff for D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions.

Rebase

May 3 2021, 12:24 PM · Restricted Project, Restricted Project

Apr 30 2021

clementval added a comment to D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions.

Macro testcase:

That is, something that calls createOffloadMaptypes/createOffloadMapnames independently of any front-end. Can be as simply as calling it and checking that the returned variable has the expected type and name.

Apr 30 2021, 9:10 AM · Restricted Project, Restricted Project
clementval updated the diff for D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions.

Address review comments

Apr 30 2021, 9:10 AM · Restricted Project, Restricted Project

Apr 29 2021

clementval retitled D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin) from [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create) to [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).
Apr 29 2021, 6:09 PM · Restricted Project
clementval updated the diff for D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).

Add copyin operand

Apr 29 2021, 6:08 PM · Restricted Project
clementval updated the diff for D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).

Adapt call to builder after change in D101503

Apr 29 2021, 11:53 AM · Restricted Project
clementval updated the diff for D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions.

Fix global variable names. Separator comes from OpenMP runtime information.

Apr 29 2021, 11:37 AM · Restricted Project, Restricted Project

Apr 28 2021

clementval abandoned D100678: [mlir][openacc] Add conversion pass OpenACC to LLVM with initial acc.enter_data conversion.

Patch D101504 is taking the new approach by doing a direct translation to LLVM IR with the use of the OpenMPIRBuilder.

Apr 28 2021, 6:11 PM · Restricted Project
clementval requested review of D101504: [mlir][openacc] Add OpenACC translation to LLVM IR (enter_data op create/copyin).
Apr 28 2021, 6:10 PM · Restricted Project
clementval requested review of D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions.
Apr 28 2021, 6:06 PM · Restricted Project, Restricted Project

Apr 22 2021

clementval added a comment to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

I do not, however both @awarzynski and @kiranchandramohan have offered to merge this patch (which should be ready now).

Apr 22 2021, 8:41 AM · Restricted Project, Restricted Project
clementval added a comment to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Addressed nit comments.

Apr 22 2021, 8:37 AM · Restricted Project, Restricted Project

Apr 20 2021

clementval added inline comments to D100678: [mlir][openacc] Add conversion pass OpenACC to LLVM with initial acc.enter_data conversion.
Apr 20 2021, 11:28 AM · Restricted Project

Apr 19 2021

clementval committed rGc46a88625d09: [mlir][llvm] Add UnnamedAddr attribute to GlobalOp (authored by clementval).
[mlir][llvm] Add UnnamedAddr attribute to GlobalOp
Apr 19 2021, 6:45 PM
clementval closed D100677: [mlir][llvm] Add UnnamedAddr attribute to GlobalOp.
Apr 19 2021, 6:45 PM · Restricted Project
clementval accepted D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

LGTM.

@clementval do you have more comments?

Apr 19 2021, 6:38 PM · Restricted Project, Restricted Project