Page MenuHomePhabricator

dcaballe (Diego Caballero)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 16 2016, 11:47 AM (340 w, 1 d)

Recent Activity

Fri, Mar 24

dcaballe requested review of D146857: [mlir][Vector] Add mapIterationSpaceDimToAllOperandDims to Linalg interface.
Fri, Mar 24, 5:53 PM · Restricted Project, Restricted Project
dcaballe requested review of D146856: [mlir][Vector] Enable masked vectorization of linalg.fill.
Fri, Mar 24, 5:40 PM · Restricted Project, Restricted Project
dcaballe accepted D146763: [MLIR][Affine] Fix/improve affine sibling fusion.

it makes sense. I think sibling fusion fell behind when I generalized producer-consumer fusion as I didn't look too much into it at that time.

Fri, Mar 24, 9:29 AM · Restricted Project, Restricted Project

Thu, Mar 23

dcaballe accepted D146741: [mlir][arith] Extend `floordivsi` expansion.

LGTM! Just a minor comment that you can fix before landing.

Thu, Mar 23, 7:19 PM · Restricted Project, Restricted Project
dcaballe added a comment to D146700: [mlir][Vector] Retire brittle canonicalizations of insert/extract slice with vector.transfer.

In the commit message would be even better :)

Thu, Mar 23, 7:03 PM · Restricted Project, Restricted Project
dcaballe accepted D146700: [mlir][Vector] Retire brittle canonicalizations of insert/extract slice with vector.transfer.

Could you please elaborate on what is going on? Why this is no longer necessary? What is the replacement?

Thu, Mar 23, 7:03 PM · Restricted Project, Restricted Project
dcaballe added a reviewer for D146741: [mlir][arith] Extend `floordivsi` expansion: Mogball.
Thu, Mar 23, 11:07 AM · Restricted Project, Restricted Project
dcaballe added inline comments to D146741: [mlir][arith] Extend `floordivsi` expansion.
Thu, Mar 23, 11:07 AM · Restricted Project, Restricted Project

Wed, Mar 22

dcaballe added a comment to D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.

LGTM. All my comments have been resolved. Please, wait for Mehdi to provide feedback on the remaining open questions/secondary PRs.

Wed, Mar 22, 10:52 AM · Restricted Project, Restricted Project
dcaballe accepted D146201: [mlir][Analysis][NFC] Split FlatAffineValueConstraints into multiple classes.
Wed, Mar 22, 10:39 AM · Restricted Project, Restricted Project
dcaballe accepted D146210: [mlir][Analysis][NFC] Make BoundType a top-level enum.
Wed, Mar 22, 10:29 AM · Restricted Project, Restricted Project
dcaballe accepted D146601: [mlir][affine] Prevent vectorizer test from crash without any map.
Wed, Mar 22, 9:33 AM · Restricted Project, Restricted Project

Mon, Mar 20

dcaballe accepted D146493: [MLIR][Affine] Fix addInductionVarOrTerminalSymbol.
Mon, Mar 20, 8:23 PM · Restricted Project, Restricted Project

Thu, Mar 16

dcaballe committed rG6d68ef4e38fb: [mlir][Vector] Canonicalize create_mask(transpose) (authored by dcaballe).
[mlir][Vector] Canonicalize create_mask(transpose)
Thu, Mar 16, 7:38 AM · Restricted Project, Restricted Project
dcaballe closed D146193: [mlir][Vector] Canonicalize create_mask(transpose).
Thu, Mar 16, 7:37 AM · Restricted Project, Restricted Project
dcaballe accepted D146210: [mlir][Analysis][NFC] Make BoundType a top-level enum.
Thu, Mar 16, 7:14 AM · Restricted Project, Restricted Project
dcaballe added inline comments to D145942: [mlir][vector] Add gather lowering patterns.
Thu, Mar 16, 6:42 AM · Restricted Project, Restricted Project
dcaballe accepted D146144: [mlir][vector] Add mask fold test for gather lowering.

Thanks!

Thu, Mar 16, 6:41 AM · Restricted Project, Restricted Project

Wed, Mar 15

dcaballe requested review of D146193: [mlir][Vector] Canonicalize create_mask(transpose).
Wed, Mar 15, 9:16 PM · Restricted Project, Restricted Project

Tue, Mar 14

dcaballe added a comment to D145942: [mlir][vector] Add gather lowering patterns.

LGTM! A couple of comments.

Tue, Mar 14, 8:33 PM · Restricted Project, Restricted Project

Mon, Mar 13

dcaballe accepted D145829: [mlir][llvm] Add fastmathFlags to SelectOp.
Mon, Mar 13, 9:14 AM · Restricted Project, Restricted Project

Sun, Mar 12

dcaballe added inline comments to D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.
Sun, Mar 12, 11:32 PM · Restricted Project, Restricted Project

Sat, Mar 11

dcaballe added a comment to D145681: [mlir][Interfaces] Add ValueBoundsOpInterface and tensor dialect op impl.

I took a first look and this looks really promising! Thank you so much for working on this so quickly.
Before we move forward with deeper reviews and comments, do you plan to send and RFC? I think this interface may benefit from one as it will impact multiple dialects. It would recommend so even if it's just an informative one.

Sat, Mar 11, 10:20 PM · Restricted Project, Restricted Project

Fri, Mar 10

dcaballe accepted D145824: [mlir][vector] Clarify OOB semantics for `gather` and `scatter`.

Thanks for addressing this! Good discussion!

Fri, Mar 10, 3:14 PM · Restricted Project, Restricted Project

Thu, Mar 9

dcaballe accepted D145731: [mlir][vector] remove unnecessary VectorTransformOps include.

Thanks!

Thu, Mar 9, 2:55 PM · Restricted Project, Restricted Project

Wed, Mar 8

dcaballe added inline comments to D145638: [mlir][vector][nvgpu] Move MMA contraction preparation to VectorUtils.
Wed, Mar 8, 7:14 PM · Restricted Project, Restricted Project

Mon, Mar 6

dcaballe accepted D145385: [mlir][linalg] Refine how contiguous loads are identified.

LGTM, thanks! I'd love to see this also working for 2D vectors :)

Mon, Mar 6, 10:49 PM · Restricted Project, Restricted Project

Fri, Mar 3

dcaballe added a comment to D145267: [mlir][linalg] Fix formatting of file Vectorization.cpp.

Clang-format is not passing. Assuming the llvm configuration is used, I wonder if the problem is that your clang-format is outdated. Perhaps, the formatting issues that you see in https://reviews.llvm.org/D145160 are related only to your code and this diff wouldn't be necessary?

Fri, Mar 3, 5:51 PM · Restricted Project, Restricted Project
dcaballe added a comment to D145162: [mlir][linalg] Downscale 2D convolution with unit dimensions to 1D convolution.

Sorry, I meant the diff context. If you look at the code below, it says "Context not available". You have to use git diff -U999999 if you are uploading a patch manually (take a look at the link I provided in my previous message). If you use Arcanist (see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line), it should take care of this automatically.

Fri, Mar 3, 1:39 PM · Restricted Project, Restricted Project
dcaballe requested changes to D145267: [mlir][linalg] Fix formatting of file Vectorization.cpp.
Fri, Mar 3, 1:34 PM · Restricted Project, Restricted Project
dcaballe accepted D145267: [mlir][linalg] Fix formatting of file Vectorization.cpp.
Fri, Mar 3, 12:39 PM · Restricted Project, Restricted Project
dcaballe added a comment to D145162: [mlir][linalg] Downscale 2D convolution with unit dimensions to 1D convolution.

Thanks for the contributions! Could you please submit a patch with full context? https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch

Fri, Mar 3, 12:31 PM · Restricted Project, Restricted Project
dcaballe added a comment to D145160: [mlir][linalg] Add vectorization support for conv_1d.

Build fails due to "mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp" not formatted (clang-format) properly in the current upstream branch. Not sure if the formatting change should go with this MR.

Fri, Mar 3, 12:24 PM · Restricted Project, Restricted Project
dcaballe accepted D145160: [mlir][linalg] Add vectorization support for conv_1d.

Thanks for the contribution! Just a couple of nits! LGTM

Fri, Mar 3, 11:47 AM · Restricted Project, Restricted Project

Feb 21 2023

dcaballe committed rG3a3ab2147d7a: [mlir][Vector] Add support for high-order masked contractions (authored by dcaballe).
[mlir][Vector] Add support for high-order masked contractions
Feb 21 2023, 11:00 PM · Restricted Project, Restricted Project
dcaballe closed D144427: [mlir][Vector] Add support for high-order masked contractions.
Feb 21 2023, 11:00 PM · Restricted Project, Restricted Project
dcaballe committed rG51f235c44457: [mlir][Vector] Add folding for masked reductions and vector.mask (authored by dcaballe).
[mlir][Vector] Add folding for masked reductions and vector.mask
Feb 21 2023, 10:52 PM · Restricted Project, Restricted Project
dcaballe closed D144414: [mlir][Vector] Add folding for masked reductions and vector.mask.
Feb 21 2023, 10:51 PM · Restricted Project, Restricted Project
dcaballe accepted D141998: [mlir][linalg] Vectorize tensor.extract using contiguous loads.
Feb 21 2023, 10:13 PM · Restricted Project, Restricted Project
dcaballe updated the diff for D144427: [mlir][Vector] Add support for high-order masked contractions.

Addressed feedback

Feb 21 2023, 7:12 PM · Restricted Project, Restricted Project
dcaballe added inline comments to D144414: [mlir][Vector] Add folding for masked reductions and vector.mask.
Feb 21 2023, 6:39 PM · Restricted Project, Restricted Project
dcaballe updated the diff for D144414: [mlir][Vector] Add folding for masked reductions and vector.mask.

Addressed feedback

Feb 21 2023, 6:39 PM · Restricted Project, Restricted Project
dcaballe committed rGc339f9e1c327: [mlir][Vector] Support masking for more contraction flavors (authored by dcaballe).
[mlir][Vector] Support masking for more contraction flavors
Feb 21 2023, 5:53 PM · Restricted Project, Restricted Project
dcaballe closed D144239: [mlir][Vector] Support masking for more contraction flavors.
Feb 21 2023, 5:52 PM · Restricted Project, Restricted Project
dcaballe added a comment to D144330: [MLIR][RISCV] Emit target-abi info for RISC-V.

I'm missing context here but do we want to restrict the ABIs to only those two? We are using ilp32, for example, and there are others (e.g., ilp32f, lp64, lp64f etc.).

Feb 21 2023, 3:45 PM · Restricted Project, Restricted Project

Feb 20 2023

dcaballe requested review of D144430: [mlir][Vector] Remove lhs and rhs masks from vector.contract.
Feb 20 2023, 1:28 PM · Restricted Project, Restricted Project
dcaballe requested review of D144427: [mlir][Vector] Add support for high-order masked contractions.
Feb 20 2023, 12:47 PM · Restricted Project, Restricted Project
dcaballe requested review of D144414: [mlir][Vector] Add folding for masked reductions and vector.mask.
Feb 20 2023, 10:32 AM · Restricted Project, Restricted Project

Feb 16 2023

dcaballe requested review of D144239: [mlir][Vector] Support masking for more contraction flavors.
Feb 16 2023, 6:44 PM · Restricted Project, Restricted Project

Feb 14 2023

dcaballe committed rG1427277eed80: [mlir][Vector] Enable masking for static shapes (authored by dcaballe).
[mlir][Vector] Enable masking for static shapes
Feb 14 2023, 10:16 PM · Restricted Project, Restricted Project
dcaballe committed rG1ac874c9aa18: [mlir][Vector] Add support for masked vector gather ops (authored by dcaballe).
[mlir][Vector] Add support for masked vector gather ops
Feb 14 2023, 10:16 PM · Restricted Project, Restricted Project
dcaballe committed rG9452356ddcf4: [mlir][Vector] Add support for masked vector.contract (authored by dcaballe).
[mlir][Vector] Add support for masked vector.contract
Feb 14 2023, 10:15 PM · Restricted Project, Restricted Project
dcaballe committed rGe9b82a5c4fb6: [mlir][Vector] Add LLVM lowering for masked reductions (authored by dcaballe).
[mlir][Vector] Add LLVM lowering for masked reductions
Feb 14 2023, 10:15 PM · Restricted Project, Restricted Project
dcaballe closed D143937: [mlir][Vector] Enable masking for static shapes.
Feb 14 2023, 10:15 PM · Restricted Project, Restricted Project
dcaballe closed D143939: [mlir][Vector] Add support for masked vector gather ops.
Feb 14 2023, 10:15 PM · Restricted Project, Restricted Project
dcaballe closed D143965: [mlir][Vector] Add support for masked vector.contract.
Feb 14 2023, 10:15 PM · Restricted Project, Restricted Project
dcaballe closed D142177: [mlir][Vector] Add LLVM lowering for masked reductions.
Feb 14 2023, 10:15 PM · Restricted Project, Restricted Project
dcaballe added inline comments to D143939: [mlir][Vector] Add support for masked vector gather ops.
Feb 14 2023, 9:49 PM · Restricted Project, Restricted Project
dcaballe added inline comments to D143939: [mlir][Vector] Add support for masked vector gather ops.
Feb 14 2023, 11:50 AM · Restricted Project, Restricted Project
dcaballe added a reviewer for D143965: [mlir][Vector] Add support for masked vector.contract: ThomasRaoux.
Feb 14 2023, 11:20 AM · Restricted Project, Restricted Project
dcaballe added a comment to D143993: [mlir] fix LLVM IR translation of vector<... x index>.

Awesome! I didn't know there was a fallback mechanism!

Feb 14 2023, 10:35 AM · Restricted Project, Restricted Project

Feb 13 2023

dcaballe abandoned D139077: [WIP] Sketch for tensor extract optimizations.
Feb 13 2023, 4:52 PM · Restricted Project, Restricted Project
dcaballe requested review of D143965: [mlir][Vector] Add support for masked vector.contract.
Feb 13 2023, 4:49 PM · Restricted Project, Restricted Project
dcaballe updated subscribers of D143939: [mlir][Vector] Add support for masked vector gather ops.
Feb 13 2023, 12:22 PM · Restricted Project, Restricted Project
dcaballe added a reviewer for D142634: [mlir] Add vectorize_nd_extract attribute to masked_vectorize: ThomasRaoux.
Feb 13 2023, 12:18 PM · Restricted Project, Restricted Project
dcaballe requested review of D143939: [mlir][Vector] Add support for masked vector gather ops.
Feb 13 2023, 12:15 PM · Restricted Project, Restricted Project
dcaballe requested review of D143937: [mlir][Vector] Enable masking for static shapes.
Feb 13 2023, 12:03 PM · Restricted Project, Restricted Project

Feb 8 2023

dcaballe accepted D143429: [mlir][linalg] Make Linalg vectorizer lower affine.apply (take 2).

LGTM! Just a comment about the tests

Feb 8 2023, 3:56 PM · Restricted Project, Restricted Project

Feb 7 2023

dcaballe accepted D143242: [mlir][vector] Support 0-D vector when eliding single element reduction.

Thanks!

Feb 7 2023, 6:15 PM · Restricted Project, Restricted Project
dcaballe committed rGd0613c1d7d0b: [mlir][LLVMIR] Add lowering support for vp.muladd intrinsic (authored by dcaballe).
[mlir][LLVMIR] Add lowering support for vp.muladd intrinsic
Feb 7 2023, 12:17 PM · Restricted Project, Restricted Project
dcaballe closed D143449: [mlir][LLVMIR] Add lowering support for vp.muladd intrinsic.
Feb 7 2023, 12:17 PM · Restricted Project, Restricted Project
dcaballe committed rGb1d82057ed7b: [mlir][Vector] Add lowering support for 1-D masked multi-reductions (authored by dcaballe).
[mlir][Vector] Add lowering support for 1-D masked multi-reductions
Feb 7 2023, 12:05 PM · Restricted Project, Restricted Project
dcaballe closed D143453: [mlir][Vector] Add lowering support for 1-D masked multi-reductions.
Feb 7 2023, 12:05 PM · Restricted Project, Restricted Project

Feb 6 2023

dcaballe requested review of D143453: [mlir][Vector] Add lowering support for 1-D masked multi-reductions.
Feb 6 2023, 6:18 PM · Restricted Project, Restricted Project
dcaballe requested review of D143449: [mlir][LLVMIR] Add lowering support for vp.muladd intrinsic.
Feb 6 2023, 5:21 PM · Restricted Project, Restricted Project
dcaballe added inline comments to D143243: [mlir][linalg] Fix crash in vectorizer when expanding affine apply.
Feb 6 2023, 12:12 PM · Restricted Project, Restricted Project

Feb 3 2023

dcaballe added a reverting change for rGc7b1176e9afb: [mlir][linalg] Make Linalg vectorizer lower affine.apply: rGf45358903912: Revert "[mlir][linalg] Make Linalg vectorizer lower affine.apply".
Feb 3 2023, 9:36 PM · Restricted Project, Restricted Project
dcaballe committed rGf45358903912: Revert "[mlir][linalg] Make Linalg vectorizer lower affine.apply" (authored by dcaballe).
Revert "[mlir][linalg] Make Linalg vectorizer lower affine.apply"
Feb 3 2023, 9:36 PM · Restricted Project, Restricted Project
dcaballe added a reverting change for rG62570b722fa3: [mlir][linalg] Fix crash in vectorizer when expanding affine apply: rGefae6c9f3786: Revert "[mlir][linalg] Fix crash in vectorizer when expanding affine apply".
Feb 3 2023, 9:36 PM · Restricted Project, Restricted Project
dcaballe added a reverting change for D142371: [WIP] Make Linalg vectorizer lower affine.apply: rGf45358903912: Revert "[mlir][linalg] Make Linalg vectorizer lower affine.apply".
Feb 3 2023, 9:36 PM · Restricted Project, Restricted Project
dcaballe committed rGefae6c9f3786: Revert "[mlir][linalg] Fix crash in vectorizer when expanding affine apply" (authored by dcaballe).
Revert "[mlir][linalg] Fix crash in vectorizer when expanding affine apply"
Feb 3 2023, 9:36 PM · Restricted Project, Restricted Project
dcaballe added a reverting change for D143243: [mlir][linalg] Fix crash in vectorizer when expanding affine apply: rGefae6c9f3786: Revert "[mlir][linalg] Fix crash in vectorizer when expanding affine apply".
Feb 3 2023, 9:36 PM · Restricted Project, Restricted Project
dcaballe added a comment to D142371: [WIP] Make Linalg vectorizer lower affine.apply.

We are seeing some correctness issues when integrating this commit. We attempted to fix it here https://reviews.llvm.org/D143243 but it looks like something else is still not working.
For the following affine.apply:

Feb 3 2023, 9:11 PM · Restricted Project, Restricted Project
dcaballe accepted D143244: Fix bazel dependency.
Feb 3 2023, 12:15 AM · Restricted Project, Restricted Project
dcaballe accepted D143243: [mlir][linalg] Fix crash in vectorizer when expanding affine apply.
Feb 3 2023, 12:09 AM · Restricted Project, Restricted Project
dcaballe added a reviewer for D143243: [mlir][linalg] Fix crash in vectorizer when expanding affine apply: awarzynski.
Feb 3 2023, 12:08 AM · Restricted Project, Restricted Project

Jan 30 2023

dcaballe accepted D141686: [mlir][vector][bufferize] Bufferize vector.mask and vector.yield.

Thanks!

Jan 30 2023, 5:16 PM · Restricted Project, Restricted Project
dcaballe accepted D142915: [mlir][vector] Clarify vector.contract promotion behavior.
Jan 30 2023, 4:05 PM · Restricted Project, Restricted Project
dcaballe added inline comments to D142915: [mlir][vector] Clarify vector.contract promotion behavior.
Jan 30 2023, 10:49 AM · Restricted Project, Restricted Project

Jan 29 2023

dcaballe accepted D142858: [mlir][NFC] Clean and Fix broken Affine documentation.

Thanks a lot for the contribution!

Jan 29 2023, 11:01 PM · Restricted Project, Restricted Project

Jan 26 2023

dcaballe accepted D142371: [WIP] Make Linalg vectorizer lower affine.apply.

Awesome!

Jan 26 2023, 10:29 AM · Restricted Project, Restricted Project
dcaballe added a reviewer for D142634: [mlir] Add vectorize_nd_extract attribute to masked_vectorize: ftynse.
Jan 26 2023, 10:09 AM · Restricted Project, Restricted Project
dcaballe accepted D142597: [MLIR] Remove unnecessary Block argument on MemRefDependenceGraph::init.
Jan 26 2023, 10:00 AM · Restricted Project, Restricted Project
dcaballe accepted D142628: [memref][Transform][NFC] Improve the doc for masked_vectorize.

Thanks for the fix!

Jan 26 2023, 9:41 AM · Restricted Project, Restricted Project

Jan 25 2023

dcaballe added a comment to D142496: [asan] fix two memory leaks in integration tests.

Ouch... Thanks, Aart!

Jan 25 2023, 10:40 AM · Restricted Project, Restricted Project
dcaballe added a reviewer for D142483: [mlir][vector] Allow transposing multi_reduction when the parallel dim is in the middle: vmurali.
Jan 25 2023, 10:36 AM · Restricted Project, Restricted Project

Jan 24 2023

dcaballe added a comment to D142371: [WIP] Make Linalg vectorizer lower affine.apply.

Thanks for adding support for this! It looks great! A few comments

Jan 24 2023, 5:51 PM · Restricted Project, Restricted Project

Jan 23 2023

dcaballe added inline comments to D141686: [mlir][vector][bufferize] Bufferize vector.mask and vector.yield.
Jan 23 2023, 11:34 PM · Restricted Project, Restricted Project

Jan 20 2023

dcaballe added a comment to D142177: [mlir][Vector] Add LLVM lowering for masked reductions.

Thanks for the review!

Jan 20 2023, 11:09 AM · Restricted Project, Restricted Project

Jan 19 2023

dcaballe added reviewers for D142177: [mlir][Vector] Add LLVM lowering for masked reductions: springerm, nicolasvasilache.
Jan 19 2023, 10:18 PM · Restricted Project, Restricted Project