This is an archive of the discontinued LLVM Phabricator instance.

[iwyu] Handle regressions in libLLVM header include
ClosedPublic

Authored by serge-sans-paille on May 3 2022, 5:23 AM.

Details

Summary

Running iwyu-diff on LLVM codebase since fa5a4e1b95c8f37796 detected a few
regressions, fixing them.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2022, 5:23 AM
serge-sans-paille requested review of this revision.May 3 2022, 5:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2022, 5:23 AM
RKSimon accepted this revision.May 3 2022, 6:15 AM

LGTM - slightly scary we've accumulated so much in so little time ....

This revision is now accepted and ready to land.May 3 2022, 6:15 AM
MaskRay accepted this revision.May 3 2022, 11:12 AM
arsenm added a comment.May 3 2022, 3:00 PM

LGTM - slightly scary we've accumulated so much in so little time ....

I think most of these are loss of uses. For example my recent MachineModuleInfo changes dropped a lot of dependencies

This revision was landed with ongoing or failed builds.May 3 2022, 11:33 PM
This revision was automatically updated to reflect the committed changes.