Page MenuHomePhabricator

hsmhsm (Mahesha S)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 14 2020, 12:20 AM (123 w, 3 d)

Recent Activity

Mon, May 2

hsmhsm committed rG589b9df4e151: [AMDGPU] Fix scalar_to_vector for v8i16/v8f16 (authored by hsmhsm).
[AMDGPU] Fix scalar_to_vector for v8i16/v8f16
Mon, May 2, 7:31 PM · Restricted Project, Restricted Project
hsmhsm committed rG3175323ce109: [AMDGPU][NFC] Make lowerINSERT_VECTOR_ELT() more readable (authored by hsmhsm).
[AMDGPU][NFC] Make lowerINSERT_VECTOR_ELT() more readable
Mon, May 2, 7:31 PM · Restricted Project, Restricted Project
hsmhsm closed D124734: [AMDGPU] Fix scalar_to_vector for v8i16/v8f16.
Mon, May 2, 7:31 PM · Restricted Project, Restricted Project
hsmhsm closed D124733: [AMDGPU][NFC] Make lowerINSERT_VECTOR_ELT() more readable.
Mon, May 2, 7:31 PM · Restricted Project, Restricted Project
hsmhsm updated the diff for D124734: [AMDGPU] Fix scalar_to_vector for v8i16/v8f16.

Fix further review comments by Stas.

Mon, May 2, 1:25 PM · Restricted Project, Restricted Project
hsmhsm added inline comments to D124734: [AMDGPU] Fix scalar_to_vector for v8i16/v8f16.
Mon, May 2, 1:17 PM · Restricted Project, Restricted Project
hsmhsm updated the diff for D124734: [AMDGPU] Fix scalar_to_vector for v8i16/v8f16.

Fix review comments by Stas and Matt.

Mon, May 2, 1:13 PM · Restricted Project, Restricted Project
hsmhsm updated the diff for D124734: [AMDGPU] Fix scalar_to_vector for v8i16/v8f16.

Fix review comments (by Matt), by materializing custom lowering of
scalar_to_vector via build_vector since build_vector already specially
handles v8i16/v8f16 types.

Mon, May 2, 11:56 AM · Restricted Project, Restricted Project
hsmhsm added inline comments to D124734: [AMDGPU] Fix scalar_to_vector for v8i16/v8f16.
Mon, May 2, 11:27 AM · Restricted Project, Restricted Project

Sun, May 1

hsmhsm updated the diff for D124733: [AMDGPU][NFC] Make lowerINSERT_VECTOR_ELT() more readable.

Fix review comments.

Sun, May 1, 9:01 PM · Restricted Project, Restricted Project
hsmhsm requested review of D124734: [AMDGPU] Fix scalar_to_vector for v8i16/v8f16.
Sun, May 1, 2:27 AM · Restricted Project, Restricted Project
hsmhsm requested review of D124733: [AMDGPU][NFC] Make lowerINSERT_VECTOR_ELT() more readable.
Sun, May 1, 12:26 AM · Restricted Project, Restricted Project

Fri, Apr 29

hsmhsm abandoned D124657: [AMDGPU][ISEL] Directly custom lower INSERT_SUBVECTOR instead of via INSERT_VECTOR_ELT.

This patch helped me to understand - what is going on with custom lowering of few vector operations, but, otherwise, the change within this patch itself for INSERT_SUBVECTOR does not any make sense. Hence abandoning it. We be coming up with update patch(es).

Fri, Apr 29, 3:55 AM · Restricted Project, Restricted Project
hsmhsm added inline comments to D124657: [AMDGPU][ISEL] Directly custom lower INSERT_SUBVECTOR instead of via INSERT_VECTOR_ELT.
Fri, Apr 29, 3:49 AM · Restricted Project, Restricted Project
hsmhsm added inline comments to D124657: [AMDGPU][ISEL] Directly custom lower INSERT_SUBVECTOR instead of via INSERT_VECTOR_ELT.
Fri, Apr 29, 3:30 AM · Restricted Project, Restricted Project
hsmhsm added inline comments to D124657: [AMDGPU][ISEL] Directly custom lower INSERT_SUBVECTOR instead of via INSERT_VECTOR_ELT.
Fri, Apr 29, 1:41 AM · Restricted Project, Restricted Project
hsmhsm updated the summary of D124657: [AMDGPU][ISEL] Directly custom lower INSERT_SUBVECTOR instead of via INSERT_VECTOR_ELT.
Fri, Apr 29, 1:08 AM · Restricted Project, Restricted Project

Thu, Apr 28

hsmhsm requested review of D124657: [AMDGPU][ISEL] Directly custom lower INSERT_SUBVECTOR instead of via INSERT_VECTOR_ELT.
Thu, Apr 28, 10:45 PM · Restricted Project, Restricted Project

Apr 21 2022

hsmhsm added inline comments to D124192: [AMDGPU] Callee must always spill writelane VGPRs.
Apr 21 2022, 9:50 PM · Restricted Project, Restricted Project

Apr 20 2022

hsmhsm committed rG5bd87350a5ae: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget. (authored by hsmhsm).
[AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget.
Apr 20 2022, 7:28 PM · Restricted Project, Restricted Project
hsmhsm closed D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..
Apr 20 2022, 7:28 PM · Restricted Project, Restricted Project
hsmhsm updated the diff for D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..

Fix minor comments by Matt and CD.

Apr 20 2022, 7:26 PM · Restricted Project, Restricted Project
hsmhsm committed rG7895c8736735: [AMDGPU] Split the lit test spill-vgpr-to-agpr.ll to different tests (authored by hsmhsm).
[AMDGPU] Split the lit test spill-vgpr-to-agpr.ll to different tests
Apr 20 2022, 6:47 PM · Restricted Project, Restricted Project
hsmhsm closed D123973: [AMDGPU] Split the lit test spill-vgpr-to-agpr.ll to different tests.
Apr 20 2022, 6:47 PM · Restricted Project, Restricted Project

Apr 19 2022

hsmhsm added a comment to D123973: [AMDGPU] Split the lit test spill-vgpr-to-agpr.ll to different tests.

It does not seem to move tests but rather dropping them.

Apr 19 2022, 7:41 PM · Restricted Project, Restricted Project
hsmhsm updated the diff for D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..

Rebase to D123973 and update lit tests accordingly.

Apr 19 2022, 12:20 AM · Restricted Project, Restricted Project
hsmhsm updated the summary of D123973: [AMDGPU] Split the lit test spill-vgpr-to-agpr.ll to different tests.
Apr 19 2022, 12:18 AM · Restricted Project, Restricted Project
hsmhsm updated the summary of D123973: [AMDGPU] Split the lit test spill-vgpr-to-agpr.ll to different tests.
Apr 19 2022, 12:16 AM · Restricted Project, Restricted Project

Apr 18 2022

hsmhsm updated the diff for D123973: [AMDGPU] Split the lit test spill-vgpr-to-agpr.ll to different tests.

Within spill-vgpr.ll, remove 2>&1 from RUN line for gfx900.

Apr 18 2022, 9:07 PM · Restricted Project, Restricted Project
hsmhsm updated the diff for D123973: [AMDGPU] Split the lit test spill-vgpr-to-agpr.ll to different tests.

Usage of AGPR in reject-agpr-usage-before-gfx908.ll should also fail for gfx906.

Apr 18 2022, 7:47 PM · Restricted Project, Restricted Project
hsmhsm requested review of D123973: [AMDGPU] Split the lit test spill-vgpr-to-agpr.ll to different tests.
Apr 18 2022, 7:21 PM · Restricted Project, Restricted Project
hsmhsm added inline comments to D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..
Apr 18 2022, 11:56 AM · Restricted Project, Restricted Project
hsmhsm added inline comments to D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..
Apr 18 2022, 11:43 AM · Restricted Project, Restricted Project

Apr 16 2022

hsmhsm added inline comments to D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..
Apr 16 2022, 11:02 PM · Restricted Project, Restricted Project
hsmhsm committed rG66c1fc19d62e: [AMDGPU] Pre-checkin updated lit tests for D123525. (authored by hsmhsm).
[AMDGPU] Pre-checkin updated lit tests for D123525.
Apr 16 2022, 10:16 PM · Restricted Project, Restricted Project
hsmhsm closed D123809: [AMDGPU] Pre-checkin updated lit tests for D123525..
Apr 16 2022, 10:16 PM · Restricted Project, Restricted Project

Apr 15 2022

hsmhsm updated the diff for D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..

Rebase to latest trunk and to D123809.

Apr 15 2022, 2:51 AM · Restricted Project, Restricted Project

Apr 14 2022

hsmhsm updated the summary of D123809: [AMDGPU] Pre-checkin updated lit tests for D123525..
Apr 14 2022, 8:50 PM · Restricted Project, Restricted Project
hsmhsm updated the diff for D123809: [AMDGPU] Pre-checkin updated lit tests for D123525..

Restore spill-vgpr-to-agpr.ll and spill-agpr.ll.

Apr 14 2022, 8:49 PM · Restricted Project, Restricted Project
hsmhsm updated the summary of D123809: [AMDGPU] Pre-checkin updated lit tests for D123525..
Apr 14 2022, 11:42 AM · Restricted Project, Restricted Project
hsmhsm updated the summary of D123809: [AMDGPU] Pre-checkin updated lit tests for D123525..
Apr 14 2022, 11:41 AM · Restricted Project, Restricted Project
hsmhsm requested review of D123809: [AMDGPU] Pre-checkin updated lit tests for D123525..
Apr 14 2022, 11:39 AM · Restricted Project, Restricted Project
hsmhsm added inline comments to D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..
Apr 14 2022, 9:55 AM · Restricted Project, Restricted Project
hsmhsm updated the summary of D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..
Apr 14 2022, 3:07 AM · Restricted Project, Restricted Project
hsmhsm updated the diff for D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..

Move code related to shifting of reserved VGPR to a lower range within FrameLowering.

Apr 14 2022, 3:01 AM · Restricted Project, Restricted Project
hsmhsm committed rGea47373af4bf: [AMDGPU][NFC] Organize code around reserving VGPR32 for AGPR copy. (authored by hsmhsm).
[AMDGPU][NFC] Organize code around reserving VGPR32 for AGPR copy.
Apr 14 2022, 12:22 AM · Restricted Project, Restricted Project
hsmhsm closed D123651: [AMDGPU][NFC] Organize code around reserving VGPR32 for AGPR copy..
Apr 14 2022, 12:22 AM · Restricted Project, Restricted Project

Apr 13 2022

hsmhsm updated the diff for D123651: [AMDGPU][NFC] Organize code around reserving VGPR32 for AGPR copy..

Fix assert message.

Apr 13 2022, 8:06 PM · Restricted Project, Restricted Project
hsmhsm added inline comments to D123651: [AMDGPU][NFC] Organize code around reserving VGPR32 for AGPR copy..
Apr 13 2022, 6:30 PM · Restricted Project, Restricted Project
hsmhsm updated the diff for D123651: [AMDGPU][NFC] Organize code around reserving VGPR32 for AGPR copy..

Minor update to member initialization.

Apr 13 2022, 3:08 AM · Restricted Project, Restricted Project
hsmhsm added inline comments to D123651: [AMDGPU][NFC] Organize code around reserving VGPR32 for AGPR copy..
Apr 13 2022, 1:40 AM · Restricted Project, Restricted Project
hsmhsm updated the diff for D123651: [AMDGPU][NFC] Organize code around reserving VGPR32 for AGPR copy..

Fix few review comments by CD.

Apr 13 2022, 1:34 AM · Restricted Project, Restricted Project

Apr 12 2022

hsmhsm requested review of D123651: [AMDGPU][NFC] Organize code around reserving VGPR32 for AGPR copy..
Apr 12 2022, 8:39 PM · Restricted Project, Restricted Project
hsmhsm added a comment to D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..

Let's begin with the question: what problem are you trying to solve?

Apr 12 2022, 10:31 AM · Restricted Project, Restricted Project
hsmhsm updated the diff for D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..

Here is the update where we always reserve highest avaialble VGPR irrespective of the
register constraint.

Apr 12 2022, 2:05 AM · Restricted Project, Restricted Project

Apr 11 2022

hsmhsm updated the diff for D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..

Refine the logic within indirectCopyToAGPR() while chosing lowest available
VGPR for AGPR copy. Basically, find out the total avaialble unused free
VGPRs (after RegAlloc), and call scavenger (only) that many times to find
the lowest available unused free VGPR.

Apr 11 2022, 11:58 PM · Restricted Project, Restricted Project
hsmhsm added inline comments to D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..
Apr 11 2022, 7:49 PM · Restricted Project, Restricted Project
hsmhsm added inline comments to D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..
Apr 11 2022, 7:09 PM · Restricted Project, Restricted Project
hsmhsm updated the summary of D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..
Apr 11 2022, 11:03 AM · Restricted Project, Restricted Project
hsmhsm requested review of D123525: [AMDGPU] On gfx908, reserve VGPR for AGPR copy based on register budget..
Apr 11 2022, 10:43 AM · Restricted Project, Restricted Project

Mar 25 2022

hsmhsm abandoned D122367: [AMDGPU] [NFC] Introduce subtargets check for MI hardware..
Mar 25 2022, 3:25 AM · Restricted Project, Restricted Project
hsmhsm added a comment to D122367: [AMDGPU] [NFC] Introduce subtargets check for MI hardware..

What's the reason behind this? You are not even using it.

Mar 25 2022, 3:23 AM · Restricted Project, Restricted Project

Mar 24 2022

hsmhsm updated the diff for D122367: [AMDGPU] [NFC] Introduce subtargets check for MI hardware..

Fix review comments by Stas.

Mar 24 2022, 5:13 PM · Restricted Project, Restricted Project
hsmhsm added a comment to D122091: [amdgpu] Elide module lds allocation in kernels with no callees.

If I understand this patch correctly, the main intention of this patch is to check if the entry point function makes any call(s) to device functions, and if so, create and allocate module lds. Otherwise don't.

Mar 24 2022, 4:40 AM · Restricted Project, Restricted Project

Mar 23 2022

hsmhsm requested review of D122367: [AMDGPU] [NFC] Introduce subtargets check for MI hardware..
Mar 23 2022, 7:49 PM · Restricted Project, Restricted Project
hsmhsm committed rGf5b6866d7ea9: [AMDGPU] Add missing testcase for SGPR to AGPR copy (authored by hsmhsm).
[AMDGPU] Add missing testcase for SGPR to AGPR copy
Mar 23 2022, 9:08 AM · Restricted Project
hsmhsm closed D122286: [AMDGPU] Add missing testcase for SGPR to AGPR copy.
Mar 23 2022, 9:08 AM · Restricted Project, Restricted Project
hsmhsm updated the diff for D122286: [AMDGPU] Add missing testcase for SGPR to AGPR copy.

Fix review comments by Jay.

Mar 23 2022, 3:31 AM · Restricted Project, Restricted Project
hsmhsm retitled D122286: [AMDGPU] Add missing testcase for SGPR to AGPR copy from [AMDGPU] VGPR need to be reserved for AGPR copy *only* on subtarget GFX908 to [AMDGPU] Add missing testcase for SGPR to AGPR copy.
Mar 23 2022, 2:50 AM · Restricted Project, Restricted Project
hsmhsm added a comment to D122286: [AMDGPU] Add missing testcase for SGPR to AGPR copy.

Can you simplify the patch? I think all it is doing is (a) adding a new test and (b) simplifying the "if" on line 609 because the condition is always true. All the other changes make it harder to see what the patch is really doing.

Mar 23 2022, 2:45 AM · Restricted Project, Restricted Project
hsmhsm updated the diff for D122286: [AMDGPU] Add missing testcase for SGPR to AGPR copy.

hasGFX90AInsts() is true for both GFX90A and GFX940 subtargets.

Mar 23 2022, 2:14 AM · Restricted Project, Restricted Project

Mar 22 2022

hsmhsm requested review of D122286: [AMDGPU] Add missing testcase for SGPR to AGPR copy.
Mar 22 2022, 10:12 PM · Restricted Project, Restricted Project
hsmhsm committed rGf014303e2ce4: [AMDGPU] [NFC]: Organize the code around reserving registers. (authored by hsmhsm).
[AMDGPU] [NFC]: Organize the code around reserving registers.
Mar 22 2022, 6:49 PM · Restricted Project
hsmhsm closed D122219: [AMDGPU] [NFC]: Organize the code around reserving registers..
Mar 22 2022, 6:48 PM · Restricted Project, Restricted Project
hsmhsm updated the diff for D122219: [AMDGPU] [NFC]: Organize the code around reserving registers..

Rebase and remove newly added confusing TODO comments.

Mar 22 2022, 6:36 PM · Restricted Project, Restricted Project
hsmhsm updated the diff for D122219: [AMDGPU] [NFC]: Organize the code around reserving registers..

Fix further review comments by Matt.

Mar 22 2022, 6:23 AM · Restricted Project, Restricted Project
hsmhsm updated the diff for D122219: [AMDGPU] [NFC]: Organize the code around reserving registers..

Fix review comments by Matt.

Mar 22 2022, 6:10 AM · Restricted Project, Restricted Project
hsmhsm requested review of D122219: [AMDGPU] [NFC]: Organize the code around reserving registers..
Mar 22 2022, 3:07 AM · Restricted Project, Restricted Project

Mar 21 2022

Herald added a project to D111764: [AMDGPU] Allow to use a whole register file on gfx90a for VGPRs: Restricted Project.
Mar 21 2022, 9:47 PM · Restricted Project, Restricted Project

Jan 4 2022

hsmhsm accepted D116641: [AMDGPU] Test commit. NFC..

LGTM.

Jan 4 2022, 8:13 PM · Restricted Project

Nov 16 2021

hsmhsm added a comment to D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas.

This is not something specific to AMDGPU backend, but AMDGPU backend at present requires this canonical form.

Undocumented and not checked by the IR verifier. Canonical form seems to be overstating it until at least one of those is addressed.

We already discussed that this canonical form is not something that IR verifier can verify, but it is good enough for better code transformation/optimization. Please refer llvm-dev email discussion w.r.t it.

If the new invariant is that all alloca must be adjacent to one another, that's a trivial thing for the verifier to check. So I guess it's something else? Please write down what this new invariant is intended to be, preferably in the documentation, perhaps of the alloca instruction.

Nov 16 2021, 12:57 AM · Restricted Project
hsmhsm added a comment to D109870: [AMDGPU] Enable the pass "amdgpu-replace-lds-use-with-pointer".

I personally think that you just want to avoid this patch from getting approved, though I do not know the real reason

I'm mistrusting of this patch because it has been landed repeatedly and broke amdgpu openmp every time. That's the 'real reason', every time you land this is breaks openmp and wastes a bunch of my time picking up the pieces.

Nov 16 2021, 12:53 AM · Restricted Project
hsmhsm added a comment to D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas.

This is not something specific to AMDGPU backend, but AMDGPU backend at present requires this canonical form.

Undocumented and not checked by the IR verifier. Canonical form seems to be overstating it until at least one of those is addressed.

Nov 16 2021, 12:27 AM · Restricted Project
hsmhsm abandoned D109870: [AMDGPU] Enable the pass "amdgpu-replace-lds-use-with-pointer".

I do not think this patch makes any progress. Enough is enough, I am abandoning it.

Nov 16 2021, 12:24 AM · Restricted Project
hsmhsm added a comment to D109870: [AMDGPU] Enable the pass "amdgpu-replace-lds-use-with-pointer".

Hi @JonChesterfield and @jdoerfert, you both had rejected this patch initially asking for the changes. Your review and acceptance of this patch is must, otherwise this patch will not land even if some other reviewer accept it. So, kind request to take a look at this patch.

I haven't seen someone remove reviewers from their patch when said reviewers marked it 'requested changes' before. Can you indicate why you did so? Reinstating my requested changes flag in the mean time.

Nov 16 2021, 12:23 AM · Restricted Project
hsmhsm added a comment to D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas.

Please change the commit message to say why this change is necessary / an improvement on what we have now.

My recollection is that the amdgpu backend crashes on some IR and this decreases the probability of that IR pattern occuring, which still sounds like fixing the wrong place to me. Was this the one where hoisting static size alloca into the entry block near the backend would the problem?

I think this patch is missing a documentation update adding the new constraint that allocas must be contiguous in IR. That would help to answer questions about which alloca must be contiguous and which can occur separated by instructions, as currently none of them need to be adjacent. Also, is this only intended to constrain the entry basic block?

Nov 16 2021, 12:11 AM · Restricted Project

Nov 15 2021

hsmhsm updated the summary of D109870: [AMDGPU] Enable the pass "amdgpu-replace-lds-use-with-pointer".
Nov 15 2021, 7:57 PM · Restricted Project
hsmhsm updated the diff for D109870: [AMDGPU] Enable the pass "amdgpu-replace-lds-use-with-pointer".

Rebase.

Nov 15 2021, 7:54 PM · Restricted Project
hsmhsm removed reviewers for D109870: [AMDGPU] Enable the pass "amdgpu-replace-lds-use-with-pointer": JonChesterfield, lebedev.ri, nhaehnle, jdoerfert.
Nov 15 2021, 7:52 PM · Restricted Project

Nov 9 2021

hsmhsm updated the diff for D109870: [AMDGPU] Enable the pass "amdgpu-replace-lds-use-with-pointer".

Minor changes to comment.

Nov 9 2021, 7:49 PM · Restricted Project
hsmhsm added a comment to D109870: [AMDGPU] Enable the pass "amdgpu-replace-lds-use-with-pointer".

Hi @arsenm, The pre-requisite front-end patch (https://reviews.llvm.org/D110257) has landed to llvm trunk. Now, this patch needs an action to be taken. Please have a look at this patch during your free time.

Nov 9 2021, 7:34 PM · Restricted Project
hsmhsm updated the diff for D109870: [AMDGPU] Enable the pass "amdgpu-replace-lds-use-with-pointer".

Rebase.

Nov 9 2021, 7:26 PM · Restricted Project
hsmhsm committed rG3b9a85d10ac7: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas (authored by hsmhsm).
[CFE][Codegen] Make sure to maintain the contiguity of all the static allocas
Nov 9 2021, 7:16 PM
hsmhsm closed D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas.
Nov 9 2021, 7:16 PM · Restricted Project
hsmhsm added a comment to D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas.

Thanks @rnk and @yaxunl .

Nov 9 2021, 7:11 PM · Restricted Project

Nov 7 2021

hsmhsm accepted D113379: [AMDGPU] Test Commit. NFC.

LGTM

Nov 7 2021, 10:57 PM · Restricted Project

Nov 3 2021

hsmhsm added a comment to D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas.

This patch is waiting for an action for a long time. I am expecting at-least anyone of the reviewers to either say "yes" or "no" or "further required improvements" on this patch so that I can take further action on this patch. If you say "no" to this patch with a strong valid reason, then I will abandon this patch and move-on instead of uncertainly waiting.

Nov 3 2021, 10:27 PM · Restricted Project
hsmhsm updated the diff for D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas.

Rebase.

Nov 3 2021, 10:20 PM · Restricted Project

Nov 1 2021

hsmhsm committed rGe9ea99249623: [IR] Replace *all* uses of a constant expression by corresponding instruction (authored by hsmhsm).
[IR] Replace *all* uses of a constant expression by corresponding instruction
Nov 1 2021, 9:34 PM
hsmhsm closed D112717: [IR] Replace *all* uses of a constant expression by corresponding instruction.
Nov 1 2021, 9:34 PM · Restricted Project, Restricted Project