This is an archive of the discontinued LLVM Phabricator instance.

Add DXContainer
ClosedPublic

Authored by beanz on Mar 18 2022, 8:53 PM.

Details

Summary

DXIL is wrapped in a container format defined by the DirectX 11
specification. Codebases differ in calling this format either DXBC or
DXILContainer.

Since eventually we want to add support for DXBC as a target
architecture and the format is used by DXBC and DXIL, I've termed it
DXContainer here.

Most of the changes in this patch are just adding cases to switch
statements to address warnings.

Diff Detail

Event Timeline

beanz created this revision.Mar 18 2022, 8:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2022, 8:53 PM
beanz requested review of this revision.Mar 18 2022, 8:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2022, 8:53 PM
Herald added a subscriber: aheejin. · View Herald Transcript
pete accepted this revision.Mar 19 2022, 6:25 PM

LGTM

llvm/include/llvm/ADT/Triple.h
264

Not sure if it matters, or if code anywhere cares, but these are in alphabetical order.

This revision is now accepted and ready to land.Mar 19 2022, 6:25 PM
This revision was landed with ongoing or failed builds.Mar 29 2022, 12:34 PM
Closed by commit rG9130e471fe82: Add DXContainer (authored by beanz). · Explain Why
This revision was automatically updated to reflect the committed changes.