Page MenuHomePhabricator

beanz (Chris Bieneman)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2014, 4:35 PM (405 w, 1 d)

Recent Activity

Yesterday

beanz accepted D126311: [DirectX] Update test for dxil-dis..

Changes like this that resolve test failures or fix simple bugs and are fairly obvious can be committed without review (same for patches reverting changes that break bots). The relevant line in the developer policy is under this section:

Thu, May 26, 10:53 AM · Restricted Project, Restricted Project

Tue, May 24

beanz committed rG11dd508bd43d: NFC. Clang-formatting. (authored by beanz).
NFC. Clang-formatting.
Tue, May 24, 9:51 AM · Restricted Project, Restricted Project
beanz added a comment to D124804: [Object][DX] Parse DXContainer Parts.

Updates uploaded.

Tue, May 24, 9:23 AM · Restricted Project, Restricted Project
beanz updated the diff for D124804: [Object][DX] Parse DXContainer Parts.

Updates based on feedback from @kuhar. Thank you!

Tue, May 24, 9:22 AM · Restricted Project, Restricted Project
beanz added inline comments to D124751: [HLSL] Support -E option for HLSL..
Tue, May 24, 7:03 AM · Restricted Project, Restricted Project

Thu, May 19

beanz added a comment to D124804: [Object][DX] Parse DXContainer Parts.

In total, I counted ~1500 uses of ArrayRef<uint8_t> in the monorepo, so I don't consider it an uncommon pattern.

Thu, May 19, 9:17 PM · Restricted Project, Restricted Project
beanz added a comment to D124804: [Object][DX] Parse DXContainer Parts.

libObject uses MemoryBufferRefs which play back and forth with StringRef, and while it has been pointed out over and over again that many of StringRef’s methods should probably be on MemoryBufferRef because they are more broadly useful, it is the way it is.

Thu, May 19, 6:34 PM · Restricted Project, Restricted Project
beanz accepted D125842: [DirectX backend] When cleanup module flags only remove unused flags..

LGTM.

Thu, May 19, 1:15 PM · Restricted Project, Restricted Project
beanz added inline comments to D125842: [DirectX backend] When cleanup module flags only remove unused flags..
Thu, May 19, 11:44 AM · Restricted Project, Restricted Project

Wed, May 18

beanz updated the diff for D124804: [Object][DX] Parse DXContainer Parts.

Fixing incorrect code coment.

Wed, May 18, 6:55 AM · Restricted Project, Restricted Project
beanz committed rG47258ffc5c7a: [NFC] correcting a code comment. (authored by beanz).
[NFC] correcting a code comment.
Wed, May 18, 6:53 AM · Restricted Project, Restricted Project
beanz added a reviewer for D124804: [Object][DX] Parse DXContainer Parts: kuhar.

Adding @kuhar.

Wed, May 18, 6:41 AM · Restricted Project, Restricted Project

Tue, May 17

beanz added inline comments to D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple..
Tue, May 17, 3:54 PM · Restricted Project, Restricted Project

Mon, May 16

beanz added inline comments to D125435: [TableGen][DirectX] Add tableGen backend to generate DXIL operation for DirectX backend..
Mon, May 16, 5:29 PM · Restricted Project, Restricted Project

Thu, May 12

beanz accepted D125507: [DirectX] Fix typo in CMakeLists.txt..
Thu, May 12, 5:17 PM · Restricted Project, Restricted Project

Tue, May 10

beanz accepted D124805: [DirectX backend] Add pass to lower llvm intrinsic into dxil op function..

Two small nitpicks, otherwise LGTM.

Tue, May 10, 6:08 PM · Restricted Project, Restricted Project
beanz added inline comments to D125334: [DirectX] Embed DXIL in LLVM Module.
Tue, May 10, 5:53 PM · Restricted Project, Restricted Project
beanz requested review of D125334: [DirectX] Embed DXIL in LLVM Module.
Tue, May 10, 12:59 PM · Restricted Project, Restricted Project
beanz added inline comments to D125158: [DirectX backend] Add pass to emit dxil metadata..
Tue, May 10, 10:24 AM · Restricted Project, Restricted Project
beanz accepted D125158: [DirectX backend] Add pass to emit dxil metadata..

LGTM.

Tue, May 10, 9:45 AM · Restricted Project, Restricted Project

Mon, May 9

beanz committed rGf5d054cdc12e: Modify DXILPrepare to emit no-op bitcasts (authored by beanz).
Modify DXILPrepare to emit no-op bitcasts
Mon, May 9, 11:41 AM · Restricted Project, Restricted Project
beanz closed D122269: Modify DXILPrepare to emit no-op bitcasts.
Mon, May 9, 11:41 AM · Restricted Project, Restricted Project
beanz updated the diff for D122269: Modify DXILPrepare to emit no-op bitcasts.

Updating based on PR feedback. Thank's @kuhar!

Mon, May 9, 10:27 AM · Restricted Project, Restricted Project
beanz added a comment to D125158: [DirectX backend] Add pass to emit dxil metadata..

Two super nitpick points off the top:
(1) Please be consistent that DXIL is all capitalized. I'd like LLVM to not have the annoyance issues that DXC's codebase has where DXIL is inconsistently capitalized.
(2) Can we instead name the pass "DXILTranslateMetadata"? The pass doesn't actually emit the metadata, it is translating it from one form in the module to another.

Mon, May 9, 7:51 AM · Restricted Project, Restricted Project
beanz added inline comments to D122270: Support converting pointers from opaque to typed.
Mon, May 9, 7:29 AM · Restricted Project, Restricted Project, Restricted Project

Sun, May 8

beanz added inline comments to D122270: Support converting pointers from opaque to typed.
Sun, May 8, 7:26 PM · Restricted Project, Restricted Project, Restricted Project

Thu, May 5

beanz added inline comments to D124983: [HLSL] add -fcgl option flag..
Thu, May 5, 7:55 AM · Restricted Project, Restricted Project

Wed, May 4

beanz requested review of D124945: [ObjectYAML][DX] Add dxcontainer2yaml support.
Wed, May 4, 10:19 AM · Restricted Project, Restricted Project
beanz requested review of D124944: [ObjectYAML][DX] Support yaml2dxcontainer.
Wed, May 4, 10:17 AM · Restricted Project, Restricted Project
beanz added inline comments to D124790: [HLSL] Enable half type for hlsl..
Wed, May 4, 8:42 AM · Restricted Project, Restricted Project

Tue, May 3

beanz committed rG15d20b976457: Fix DXBC magic parsing (authored by beanz).
Fix DXBC magic parsing
Tue, May 3, 2:47 PM · Restricted Project, Restricted Project

Mon, May 2

beanz accepted D122578: [cmake] fill `cmake_args` when crosscompiling external project with non-clang compiler.

LGTM. Thank you for a nice improvement!

Mon, May 2, 10:10 PM · Restricted Project, Restricted Project
beanz added a comment to D124643: [Object][DX] Initial DXContainer parsing support.

The other issue should be fixed in rGb26e44e623c75c084e865084b18541c6a1736df2.

Mon, May 2, 4:52 PM · Restricted Project, Restricted Project
beanz committed rG19fb52cbfec7: [NFC] Add missing switch cases (authored by beanz).
[NFC] Add missing switch cases
Mon, May 2, 4:13 PM · Restricted Project, Restricted Project
beanz committed rG966c40aea663: [Object][DX] Identify DXBC file magic (authored by beanz).
[Object][DX] Identify DXBC file magic
Mon, May 2, 2:48 PM · Restricted Project, Restricted Project
beanz requested review of D124804: [Object][DX] Parse DXContainer Parts.
Mon, May 2, 1:52 PM · Restricted Project, Restricted Project
beanz committed rGb26e44e623c7: [NFC] Fixing error on some versions of GCC (authored by beanz).
[NFC] Fixing error on some versions of GCC
Mon, May 2, 1:17 PM · Restricted Project, Restricted Project
beanz added a comment to D124643: [Object][DX] Initial DXContainer parsing support.

Bots should be fixed with rG55e13a6bc0d6a31afc258a012184253041b0eb8e.

Mon, May 2, 1:08 PM · Restricted Project, Restricted Project
beanz committed rG55e13a6bc0d6: [NFC] Fix warning reported on bots (authored by beanz).
[NFC] Fix warning reported on bots
Mon, May 2, 1:04 PM · Restricted Project, Restricted Project
beanz committed rG4070aa01561c: [Object][DX] Initial DXContainer parsing support (authored by beanz).
[Object][DX] Initial DXContainer parsing support
Mon, May 2, 11:57 AM · Restricted Project, Restricted Project
beanz closed D124643: [Object][DX] Initial DXContainer parsing support.
Mon, May 2, 11:57 AM · Restricted Project, Restricted Project

Fri, Apr 29

beanz accepted D123884: [HLSL][clang][Driver] Support validator version command line option..

LGTM.

Fri, Apr 29, 3:27 PM · Restricted Project, Restricted Project, Restricted Project
beanz updated the diff for D124643: [Object][DX] Initial DXContainer parsing support.

One more set of updates. Thanks @MaskRay!

Fri, Apr 29, 9:07 AM · Restricted Project, Restricted Project
beanz updated the diff for D124643: [Object][DX] Initial DXContainer parsing support.

Updates based on PR feedback

Fri, Apr 29, 9:06 AM · Restricted Project, Restricted Project

Thu, Apr 28

beanz requested review of D124643: [Object][DX] Initial DXContainer parsing support.
Thu, Apr 28, 4:06 PM · Restricted Project, Restricted Project
beanz committed rG0d6b574b8717: [HLSL] Adjust access specifier behavior (authored by beanz).
[HLSL] Adjust access specifier behavior
Thu, Apr 28, 8:38 AM · Restricted Project, Restricted Project
beanz closed D124487: [HLSL] Adjust access specifier behavior.
Thu, Apr 28, 8:38 AM · Restricted Project, Restricted Project, Restricted Project
beanz added inline comments to D124487: [HLSL] Adjust access specifier behavior.
Thu, Apr 28, 8:09 AM · Restricted Project, Restricted Project, Restricted Project
beanz retitled D123884: [HLSL][clang][Driver] Support validator version command line option. from [HLSL][clang][Driver] Support target profile command line option. to [HLSL][clang][Driver] Support validator version command line option..
Thu, Apr 28, 7:58 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Apr 27

beanz updated the diff for D124487: [HLSL] Adjust access specifier behavior.

Updates based on PR feedback.

Wed, Apr 27, 6:58 PM · Restricted Project, Restricted Project, Restricted Project
beanz added a comment to D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON.

I posted a PR to swift that migrates build-script to use LLVM_ENABLE_RUNTIMES: https://github.com/apple/swift/pull/58465

Wed, Apr 27, 1:51 PM · Restricted Project, Restricted Project

Apr 27 2022

beanz committed rG5e096ce6c84f: Update PGO and 3-stage cache files (authored by beanz).
Update PGO and 3-stage cache files
Apr 27 2022, 12:42 PM · Restricted Project, Restricted Project
beanz committed rG05b765ff6995: [DXIL] [NFC] Remove dead attribute code paths (authored by beanz).
[DXIL] [NFC] Remove dead attribute code paths
Apr 27 2022, 8:47 AM · Restricted Project, Restricted Project
beanz accepted D124521: Remove the Visual Studio/MSBuild integration.

LGTM! Thank you!

Apr 27 2022, 7:06 AM · Restricted Project, Restricted Project

Apr 26 2022

beanz added a comment to D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT.

Making it an ERROR and providing an option to downgrade it to a WARNING seems reasonable to me. Thoughts?

Apr 26 2022, 5:48 PM · Restricted Project, Restricted Project
beanz updated the diff for D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT.

Making the warning message more specific.

Apr 26 2022, 5:19 PM · Restricted Project, Restricted Project
beanz requested review of D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT.
Apr 26 2022, 5:03 PM · Restricted Project, Restricted Project
beanz added a comment to D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON.

Posted an RFC: https://discourse.llvm.org/t/rfc-deprecate-and-remove-llvm-build-external-compiler-rt/62058

Apr 26 2022, 4:59 PM · Restricted Project, Restricted Project
beanz requested review of D124487: [HLSL] Adjust access specifier behavior.
Apr 26 2022, 4:51 PM · Restricted Project, Restricted Project, Restricted Project
beanz added a comment to D123884: [HLSL][clang][Driver] Support validator version command line option..

I pointed out a few (not all) the places where you have unneeded brackets. Also all your new files don't have newlines at the end of them (the C standard specifies that as a requirement although pretty much all compilers just issue a warning).

Apr 26 2022, 3:09 PM · Restricted Project, Restricted Project, Restricted Project
beanz added reviewers for D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON: compnerd, ldionne, smeenai.

I don't want to roadblock or say "no we absolutely can't let this in", _but_... Apple Clang and Swift have long been the only reason we've kept this code alive. I didn't have the time to fix Apple Clang years ago, and nobody has made the effort since.

Apr 26 2022, 2:36 PM · Restricted Project, Restricted Project
beanz added a comment to D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON.

In this case I'm just trying to make it work with existing build configurations where it is being used (for example Swift). We should definitely be moving away from LLVM_BUILD_EXTERNAL_COMPILER_RT in favor of LLVM_ENABLE_RUNTIMES eventually though.

Apr 26 2022, 2:04 PM · Restricted Project, Restricted Project
beanz added a comment to D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON.

I question whether we should be extending this or killing it off... Is there a reason you're using LLVM_BUILD_EXTERNAL_COMPILER_RT instead of LLVM_ENABLE_RUNTIMES=compiler-rt?

Apr 26 2022, 1:05 PM · Restricted Project, Restricted Project
beanz added inline comments to D123884: [HLSL][clang][Driver] Support validator version command line option..
Apr 26 2022, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
beanz updated the diff for D122270: Support converting pointers from opaque to typed.

Rebasing and cleaning up code.

Apr 26 2022, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
beanz updated the diff for D122269: Modify DXILPrepare to emit no-op bitcasts.

Fixing a code comment.

Apr 26 2022, 10:54 AM · Restricted Project, Restricted Project
beanz updated the diff for D122269: Modify DXILPrepare to emit no-op bitcasts.

Updates based on PR feedback.

Apr 26 2022, 10:53 AM · Restricted Project, Restricted Project
beanz added inline comments to rGeab7d3639b3c: [SPIR-V](5/6) Add LegalizerInfo, InstructionSelector and utilities.
Apr 26 2022, 8:24 AM · Restricted Project, Restricted Project
beanz committed rG69c66bb21122: [SPIRV][NFC] Remove unused variable (authored by beanz).
[SPIRV][NFC] Remove unused variable
Apr 26 2022, 8:18 AM · Restricted Project, Restricted Project
beanz committed rG8631c115905e: [SPIRV][NFC] Fix warnings for switch cases (authored by beanz).
[SPIRV][NFC] Fix warnings for switch cases
Apr 26 2022, 7:57 AM · Restricted Project, Restricted Project
beanz committed rG500d677f1d13: [SPIRV][NFC] Fix warning on class/struct mismatch (authored by beanz).
[SPIRV][NFC] Fix warning on class/struct mismatch
Apr 26 2022, 7:52 AM · Restricted Project, Restricted Project

Apr 25 2022

beanz committed rG3143840f216c: NFC. Add missing DXILPointerTyID case (authored by beanz).
NFC. Add missing DXILPointerTyID case
Apr 25 2022, 6:09 PM · Restricted Project, Restricted Project
beanz committed rGe6f44a3cd273: Add PointerType analysis for DirectX backend (authored by beanz).
Add PointerType analysis for DirectX backend
Apr 25 2022, 3:56 PM · Restricted Project, Restricted Project
beanz closed D122268: Add PointerType analysis for DirectX backend.
Apr 25 2022, 3:55 PM · Restricted Project, Restricted Project
beanz added inline comments to D122268: Add PointerType analysis for DirectX backend.
Apr 25 2022, 3:15 PM · Restricted Project, Restricted Project
beanz updated the diff for D122268: Add PointerType analysis for DirectX backend.

This should fix the patch upload, also added in some more of @kuhar's suggestions :).

Apr 25 2022, 2:55 PM · Restricted Project, Restricted Project
beanz added a comment to D122268: Add PointerType analysis for DirectX backend.

Ugh... please hold off reviewing. I somehow messed up the commit update and got a lot of noisy diffs.

Apr 25 2022, 2:42 PM · Restricted Project, Restricted Project
beanz updated the diff for D122268: Add PointerType analysis for DirectX backend.

Updates based on review feedback. Thanks @kuhar!

Apr 25 2022, 2:41 PM · Restricted Project, Restricted Project
beanz added a comment to D122268: Add PointerType analysis for DirectX backend.

Comments below. Updated patch coming shortly.

Apr 25 2022, 2:34 PM · Restricted Project, Restricted Project
beanz added a comment to D123407: File Extension.

Overall this seems like a nice change. There is one unrelated change fixing a typo in here that should be removed and posted separately.

Apr 25 2022, 1:25 PM · Restricted Project, Restricted Project

Apr 23 2022

beanz accepted D124339: [NFC][Clang][Pragma] Remove unused variables.

LGTM

Apr 23 2022, 8:43 PM · Restricted Project, Restricted Project

Apr 20 2022

beanz accepted D123777: [CMake] Check for problematic MSVC + /arch:AVX configuration.

This looks good to me and seems like a good added check.

Apr 20 2022, 8:18 AM · Restricted Project, Restricted Project

Apr 16 2022

beanz added inline comments to D122082: Add DXIL Bitcode Writer and DXIL testing.
Apr 16 2022, 11:32 AM · Restricted Project, Restricted Project

Apr 15 2022

beanz added a comment to D123887: [HLSL][clang][Driver] Fix test error for use SmallString::data instead SmallString::c_str..

I already merged a fix to resolve the test errors.

Apr 15 2022, 7:08 PM · Restricted Project, Restricted Project
beanz added a comment to D122865: [HLSL][clang][Driver] Support target profile command line option..

@wolfgangp I can't reproduce the failure locally, but I have a guess what's going wrong. I _think_ the issue is that the SmallStrings aren't null terminated and the cleared allocations aren't zero'd. I pushed a speculative fix in rG329abac134a3. Hopefully that fixes it. If not feel free to revert the changes, @python3kgae you'll have to diagnose further issues as I'll be afk all of next week.

Apr 15 2022, 6:14 PM · Restricted Project, Restricted Project
beanz committed rG329abac134a3: Blind stab in the dark to fix a bot failure (authored by beanz).
Blind stab in the dark to fix a bot failure
Apr 15 2022, 6:13 PM · Restricted Project, Restricted Project
beanz committed rGf2526c1a5c6f: Add DXIL Bitcode Writer and DXIL testing (authored by beanz).
Add DXIL Bitcode Writer and DXIL testing
Apr 15 2022, 4:50 PM · Restricted Project, Restricted Project
beanz closed D122082: Add DXIL Bitcode Writer and DXIL testing.
Apr 15 2022, 4:50 PM · Restricted Project, Restricted Project
beanz committed rG721651be246e: [HLSL][clang][Driver] Support target profile command line option. (authored by python3kgae).
[HLSL][clang][Driver] Support target profile command line option.
Apr 15 2022, 12:18 PM · Restricted Project, Restricted Project
beanz closed D122865: [HLSL][clang][Driver] Support target profile command line option..
Apr 15 2022, 12:18 PM · Restricted Project, Restricted Project
beanz added inline comments to D122269: Modify DXILPrepare to emit no-op bitcasts.
Apr 15 2022, 7:52 AM · Restricted Project, Restricted Project
beanz added inline comments to D122269: Modify DXILPrepare to emit no-op bitcasts.
Apr 15 2022, 7:34 AM · Restricted Project, Restricted Project

Apr 14 2022

beanz added a comment to D122270: Support converting pointers from opaque to typed.

@nhaehnle sorry, I realized this patch hadn't been rebased since the request to just fork the full bitcode writer.

Apr 14 2022, 1:49 PM · Restricted Project, Restricted Project, Restricted Project
beanz updated the diff for D122270: Support converting pointers from opaque to typed.

Rebasing patches on the updated patch stack.

Apr 14 2022, 1:44 PM · Restricted Project, Restricted Project, Restricted Project
beanz updated the diff for D122269: Modify DXILPrepare to emit no-op bitcasts.

Rebasing on updated patches from earlier in the stack.

Apr 14 2022, 12:53 PM · Restricted Project, Restricted Project
beanz committed rG3efad612d234: [HLSL] Pointers are unsupported in HLSL (authored by beanz).
[HLSL] Pointers are unsupported in HLSL
Apr 14 2022, 11:33 AM · Restricted Project, Restricted Project
beanz closed D123167: [HLSL] Pointers are unsupported in HLSL.
Apr 14 2022, 11:33 AM · Restricted Project, Restricted Project
beanz committed rG1fdf952deeb9: [HLSL] Add Semantic syntax, and SV_GroupIndex (authored by beanz).
[HLSL] Add Semantic syntax, and SV_GroupIndex
Apr 14 2022, 8:22 AM · Restricted Project, Restricted Project
beanz closed D122699: [HLSL] Add Semantic syntax, and SV_GroupIndex.
Apr 14 2022, 8:22 AM · Restricted Project, Restricted Project
beanz updated the diff for D123167: [HLSL] Pointers are unsupported in HLSL.

Updates to test cases to increase coverage.

Apr 14 2022, 7:16 AM · Restricted Project, Restricted Project