beanz (Chris Bieneman)
User

Projects

User does not belong to any projects.
User Since
Aug 20 2014, 4:35 PM (135 w, 6 d)

Recent Activity

Yesterday

beanz accepted D31436: [yaml2obj] Enable and fix tests.

Thanks for catching this. I didn't even notice that I had written such bad tests!

Tue, Mar 28, 3:18 PM
beanz added a comment to D31363: [libc++] Remove cmake glob for source files.

LLVM has a CMake module "LLVMProcessSources.cmake" which verifies that all source files are referenced in the CMakeLists file. Since it is part of the LLVM distributed modules, you can re-use it in libcxx.

Tue, Mar 28, 11:06 AM
beanz added a comment to D30906: Revert r297545 - Revert r297516 - Respect CMAKE_INSTALL_MANDIR for sphinx generated manpages.

The one downside to this approach is that when you use an absolute path as the DESTINATION argument to install you can't change the install root without reconfiguring. When you use relative paths you can.

Tue, Mar 28, 10:57 AM

Mon, Mar 27

beanz updated the diff for D31357: Support Unit Testing debugserver.

Added a note to the unit test CMake file about why the tests are where they are. Generally we isolate debugserver from the rest of LLDB, and this comment explains the breach of isolation.

Mon, Mar 27, 3:55 PM
beanz added a comment to D31357: Support Unit Testing debugserver.

@jingham I put the unit tests at the top because they depend on LLDB's Host library (at least the current tests do). I'm attempting to write tests which cover the socket communication between LLDB and debugserver by sending data between the two using each side of the API.

Mon, Mar 27, 12:34 PM
beanz updated the diff for D31357: Support Unit Testing debugserver.

Fleshed out the unit test logic to be more meaningful.

Mon, Mar 27, 12:17 PM

Fri, Mar 24

beanz accepted D31356: [Support] Avoid concurrency hazard in signal handler registration.

LGTM.

Fri, Mar 24, 4:38 PM
beanz added a comment to D31357: Support Unit Testing debugserver.

Xcode is pretty magic to me. I don't know how to do much of anything in it other than build. I think the right solution would be to take most of the source files out of the debugserver target and generate a static archive from them, then have debugserver and the debugserverTest target link the static archive.

Fri, Mar 24, 4:23 PM
beanz created D31357: Support Unit Testing debugserver.
Fri, Mar 24, 3:00 PM

Wed, Mar 22

beanz accepted D30958: [CMake] Support building Fuchsia toolchain on Darwin.

Looks great!

Wed, Mar 22, 1:30 PM

Tue, Mar 21

beanz added inline comments to D30958: [CMake] Support building Fuchsia toolchain on Darwin.
Tue, Mar 21, 3:56 PM
beanz accepted D30957: [CMake] Support single target builtins build on Darwin.

LGTM!

Tue, Mar 21, 3:26 PM
beanz added a comment to D30957: [CMake] Support single target builtins build on Darwin.

One minor style comment, otherwise looks good to me.

Tue, Mar 21, 10:50 AM
beanz accepted D31098: [compiler-rt] respect CMAKE_EXE_LINKER_FLAGS in compiler and library tests.

Cool! Seems to me like this patch addresses everyones issues, and I think the patch looks good. Thanks for iterating on this!

Tue, Mar 21, 10:40 AM

Mon, Mar 20

beanz added reviewers for D30904: Allow suppressing host and target info in VersionPrinter: beanz, bogner.
Mon, Mar 20, 7:16 PM
beanz added a comment to D31098: [compiler-rt] respect CMAKE_EXE_LINKER_FLAGS in compiler and library tests.

@inglorion I believe the reason we had to set the policy to OLD is because the auto-passed variable masks the explicitly passed one in try_compile. If that is the case, we need the same change in the Darwin code path too.

Mon, Mar 20, 3:45 PM
beanz added inline comments to D31098: [compiler-rt] respect CMAKE_EXE_LINKER_FLAGS in compiler and library tests.
Mon, Mar 20, 3:25 PM
beanz added a comment to D31144: Respect cmake link flags when compiling test files.

This patch looks fine to me, however I'd like to see the resolution on D31098 before landing this. If we change the CMake policy CMP0056 to NEW, I think that will automatically address this issue resulting in us not needing this patch.

Mon, Mar 20, 2:10 PM
beanz added a comment to D31098: [compiler-rt] respect CMAKE_EXE_LINKER_FLAGS in compiler and library tests.

@davidxl, do you recall how the failure that caused you to make the policy change exhibited itself? It seems to me like we were working around the behavior of the old policy setting by passing the linker options through manually. I wonder if the reason for the error was CMake masking those liker flags under the new policy.

Mon, Mar 20, 2:06 PM
beanz accepted D31125: Fix evaluation of LLVM_DEFINITIONS.

This looks like a great cleanup. Thanks!

Mon, Mar 20, 1:30 PM

Fri, Mar 17

beanz accepted D31060: [CMake] Provide an option to disable runtimes build.

LGTM!

Fri, Mar 17, 3:55 PM
beanz accepted D30997: CMake: Add LLVM_DYLIB_SYMBOL_VERSIONING option.

@mgorny, we should only support this on shared libraries that we intend as vended libraries, not all libraries. For example we don't really want to support the CMake BUILD_SHARED_LIBS option's libraries as vended libraries on any platform.

Fri, Mar 17, 3:41 PM
beanz added inline comments to D30957: [CMake] Support single target builtins build on Darwin.
Fri, Mar 17, 3:41 PM
beanz accepted D30911: [CMake] fix CLANG_INCLUDE_DIRS CMake export.

LGTM!

Fri, Mar 17, 2:47 PM

Tue, Mar 14

beanz accepted D28533: [llvm-config] Add minimal sanity tests for path options.

This is great, thanks!

Tue, Mar 14, 3:32 PM
beanz accepted D29851: [clang-tools-extra] [test] Fix test dependencies when using installed tools.

Ugh... I really don't like how LLVM_UTILS_PROVIDED is implemented, but I guess it is fine. This patch is good.

Tue, Mar 14, 3:32 PM · Restricted Project

Mon, Mar 13

beanz updated the diff for D30918: [debugserver] This is a small cleanup patch to AVX support detection.

Forgot a semi-colon...

Mon, Mar 13, 4:28 PM
beanz updated the diff for D30918: [debugserver] This is a small cleanup patch to AVX support detection.

Updates based on feedback from Jason and Zachary.

Mon, Mar 13, 4:23 PM
beanz updated the diff for D30918: [debugserver] This is a small cleanup patch to AVX support detection.

Removing some extra changes that accidentally came along for the ride in my initial upload.

Mon, Mar 13, 3:52 PM
beanz created D30918: [debugserver] This is a small cleanup patch to AVX support detection.
Mon, Mar 13, 3:50 PM

Tue, Mar 7

beanz accepted D30656: CMake: Don't install llvm-tblgen twice.

LGTM.

Tue, Mar 7, 11:08 AM
beanz accepted D30470: [cmake] Include openmp with add_llvm_external_project.

This patch is fine, just be warned that eventually I really want to kill the projects subdirectory entirely.

Tue, Mar 7, 10:47 AM

Mon, Mar 6

beanz created D30666: [ObjectYAML] Add ability for DWARFYAML to calculate DIE lengths.
Mon, Mar 6, 2:23 PM
beanz accepted D30655: CMake: Add LLVM_UTILS_INSTALL_DIR option.

LGTM!

Mon, Mar 6, 10:14 AM

Fri, Mar 3

beanz updated the diff for D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.

Updating to address Paul's feedback about DWARF32/DWARF64.

Fri, Mar 3, 1:32 PM
beanz updated the diff for D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.

Updated based on feedback from Adrian.

Fri, Mar 3, 9:48 AM
beanz added inline comments to D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Fri, Mar 3, 8:47 AM

Thu, Mar 2

beanz added inline comments to D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Thu, Mar 2, 5:35 PM
beanz added inline comments to D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Thu, Mar 2, 4:37 PM
beanz added inline comments to D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Thu, Mar 2, 3:44 PM
beanz added inline comments to D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Thu, Mar 2, 2:18 PM
beanz updated the diff for D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.

Updates based on feedback from Adrian.

Thu, Mar 2, 1:25 PM
beanz added inline comments to D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Thu, Mar 2, 1:04 PM

Wed, Mar 1

beanz retitled D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code from [ObjectYAML] Add ability for DWARFYAML to calculate DIE lengths to [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Wed, Mar 1, 3:45 PM
beanz updated the diff for D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
  • Reducing the patch to just the NFC changes
Wed, Mar 1, 3:42 PM
beanz accepted D30092: CMake: Clean up VersionFromVCS.cmake.

LGTM!

Wed, Mar 1, 1:31 PM

Feb 24 2017

beanz created D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Feb 24 2017, 3:18 PM
beanz added a comment to D30346: [.gitignore] Update .gitignore to ignore a nested build directory.

This is for LLVM. Will land shortly.

Feb 24 2017, 11:26 AM
beanz created D30346: [.gitignore] Update .gitignore to ignore a nested build directory.
Feb 24 2017, 10:57 AM
beanz added a comment to D30266: Move Stream code from MSF -> Support.

This all looks pretty great to me.

Feb 24 2017, 10:07 AM

Feb 22 2017

beanz accepted D30275: Get the branch specifiers from a .json file rather than out of raw Python.

LGTM!

Feb 22 2017, 2:51 PM

Feb 17 2017

beanz added a comment to D30010: Improve the robustness of mmap.

Don't really have much to add here, but I really like what this is doing, and I think it will be a huge win for LLDB. Thanks @zturner!

Feb 17 2017, 3:36 PM
beanz added a comment to D30092: CMake: Clean up VersionFromVCS.cmake.

Mostly looks good, a few inline comments below.

Feb 17 2017, 3:19 PM
beanz accepted D30093: CMake: Add a build target for generating a source RPM.

LGTM. This is really cool, thanks for putting it together.

Feb 17 2017, 2:31 PM

Feb 15 2017

beanz added a comment to D26654: [CMake] Add Fuchsia toolchain CMake cache files.

Thanks for all your work on these!

Feb 15 2017, 3:06 PM
beanz added a comment to D28575: [CMake] Support externalizing debug info on non-Darwin platforms.

LGTM! Thanks!

Feb 15 2017, 3:05 PM
beanz accepted D29997: [libunwind][CMake] Use libc++ headers when available.

LGTM!

Feb 15 2017, 3:01 PM

Feb 14 2017

beanz accepted D29800: [libunwind][CMake] Use libc++ headers when available.

LGTM!

Feb 14 2017, 1:22 PM

Feb 8 2017

beanz accepted D29555: [CMake] Fix pthread handling for out-of-tree builds.

This looks reasonable to me.

Feb 8 2017, 3:18 PM
beanz accepted D28575: [CMake] Support externalizing debug info on non-Darwin platforms.

A few small comments below. Otherwise LGTM.

Feb 8 2017, 3:02 PM
beanz added a comment to D28234: Support for custom install dirs in CMake build.

A few comments inline. Since these variables are used by the LLVM CMake modules, they also need to be added to LLVMConfig.cmake.in. Otherwise they will break out-of-tree builds.

Feb 8 2017, 2:26 PM
beanz accepted D29573: [libunwind][CMake] Use libc++ headers when available.

LGTM! Thanks!

Feb 8 2017, 1:41 PM
beanz accepted D29575: [libcxx][CMake] Support in-tree libunwind when building as part of runtimes.

LGTM.

Feb 8 2017, 11:31 AM
beanz accepted D29574: [libcxxabi][CMake] Support in-tree libunwind when building as part of runtimes.

LGTM.

Feb 8 2017, 11:30 AM
beanz added inline comments to D29573: [libunwind][CMake] Use libc++ headers when available.
Feb 8 2017, 11:29 AM

Feb 7 2017

beanz added a comment to D29352: [CMake] Final dependency cleanup patch!.

Ok. I think this patch is fully ready to go now. I added the missing dependencies in the ObjectFileELF tests in rL294372.

Feb 7 2017, 3:48 PM
beanz updated the diff for D28869: [CMake] Fix `is_llvm_target_library` and support out-of-order components.

Adding Info and Utils handling.

Feb 7 2017, 11:20 AM

Feb 6 2017

beanz updated the diff for D29352: [CMake] Final dependency cleanup patch!.

Rebasing patch

Feb 6 2017, 10:50 AM

Feb 1 2017

beanz updated the diff for D29352: [CMake] Final dependency cleanup patch!.

Unit tests are updated in rL293821. This update makes one last change to the unit tests to build with the explicit dependencies.

Feb 1 2017, 2:30 PM
beanz added a comment to D29352: [CMake] Final dependency cleanup patch!.

Ah! I forgot to update the unittest directory. I'll get a patch in today that updates the unittests following the pattern from the libraries.

Feb 1 2017, 11:32 AM

Jan 31 2017

beanz updated the diff for D29352: [CMake] Final dependency cleanup patch!.

Fixing the issue labath reported in the review. Generally speaking we shouldn't be configuring or compiling plugins that can't be used.

Jan 31 2017, 3:33 PM
beanz created D29352: [CMake] Final dependency cleanup patch!.
Jan 31 2017, 3:18 PM
beanz created D29348: [CMake] Add explicit dependencies to plugins.
Jan 31 2017, 1:48 PM
beanz added a comment to D29333: [CMake] Add accurate dependency specifications.

@labath, we'll have to see if CMake's handling is good enough. What CMake actually does is repeat the full chain of the cycle, so it would be something like adding -lX -lY -lX -lY in your example. This doesn't work for certain pathological cases, but CMake actually has mechanisms to help deal with that too if we need them:

Jan 31 2017, 12:53 PM
beanz added a comment to D29333: [CMake] Add accurate dependency specifications.

I was thinking about that as well. I am not sure if it will work if we actually need multiple iterations of the loop to get all the dependencies converging, but it may be worth trying out.

Jan 31 2017, 11:28 AM
beanz added a comment to D29333: [CMake] Add accurate dependency specifications.

I expect this patch and the next one to be pretty safe because I'm not actually removing the existing dependency specifications, just adding new explicit ones.

Jan 31 2017, 11:18 AM
beanz added a comment to D29333: [CMake] Add accurate dependency specifications.

Thankfully CMake will not complain about circular dependencies in static archive targets. If it did, we'd really be in trouble because the LLDB dependencies graph has *lots* of circular dependencies. Actually, I think CMake even handles them properly on Linux, which should eliminate our need to add --start-group and --end-group to the linker command lines.

Jan 31 2017, 11:10 AM
beanz added a comment to D29333: [CMake] Add accurate dependency specifications.

@zturner That mechanism does work, however I generally find that it is cleaner to pass named parameters into CMake functions which provides a bit of a self-documenting API, as opposed to relying on known named variables. The named-parameter was introduced for LLD, and I think is the more-modern way of handling this. Eventually I think LLVM should be updated to do the same.

Jan 31 2017, 11:00 AM
beanz updated the diff for D29333: [CMake] Add accurate dependency specifications.

Updates based on post commit feedback from labath.

Jan 31 2017, 10:43 AM
beanz added reviewers for D29333: [CMake] Add accurate dependency specifications: labath, zturner.
Jan 31 2017, 9:51 AM
beanz created D29333: [CMake] Add accurate dependency specifications.
Jan 31 2017, 9:27 AM

Jan 26 2017

beanz updated the diff for D28869: [CMake] Fix `is_llvm_target_library` and support out-of-order components.

Updates based on review by bryant

Jan 26 2017, 1:17 PM

Jan 25 2017

beanz added inline comments to D28869: [CMake] Fix `is_llvm_target_library` and support out-of-order components.
Jan 25 2017, 4:07 PM

Jan 24 2017

beanz updated the diff for D28869: [CMake] Fix `is_llvm_target_library` and support out-of-order components.

Updating patch with a few new things.

Jan 24 2017, 10:27 AM

Jan 23 2017

beanz created D29043: [Lanai] Rename LanaiInstPrinter library to LanaiAsmPrinter.
Jan 23 2017, 11:32 AM

Jan 20 2017

beanz added inline comments to D28828: [DWARF] [ObjectYAML] Adding APIs for unittesting.
Jan 20 2017, 3:46 PM

Jan 18 2017

beanz updated the diff for D28828: [DWARF] [ObjectYAML] Adding APIs for unittesting.

Updates based on feedback from dblaikie.

Jan 18 2017, 3:22 PM
beanz added inline comments to D28828: [DWARF] [ObjectYAML] Adding APIs for unittesting.
Jan 18 2017, 2:11 PM
beanz added inline comments to D28828: [DWARF] [ObjectYAML] Adding APIs for unittesting.
Jan 18 2017, 1:48 PM
beanz created D28869: [CMake] Fix `is_llvm_target_library` and support out-of-order components.
Jan 18 2017, 12:32 PM

Jan 17 2017

beanz added a comment to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.

@joerg I completely disagree with you. Since libgcc provides those files for some platforms compiler-rt should as well.

Jan 17 2017, 3:15 PM
beanz added a comment to D28446: Fix llvm-config --link-shared --libs for mingw.

Ah... don't know if we have one with shared libs enabled, but adding a test is still good. You probably need a new available feature added to lit for checking the dylib. In case you're unsure how to do that I wrote it up real quick and put it in a paste (https://reviews.llvm.org/P7962).

Jan 17 2017, 2:46 PM
beanz created D28828: [DWARF] [ObjectYAML] Adding APIs for unittesting.
Jan 17 2017, 2:30 PM
beanz added inline comments to D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation.
Jan 17 2017, 2:23 PM
beanz added reviewers for D28791: [compiler-rt][crt] Simple crtbegin and crtend implementation: brad.king, steveire.

Looping in Brad King and Stephen Kelly for CMake advice.

Jan 17 2017, 2:17 PM
beanz added a comment to D28446: Fix llvm-config --link-shared --libs for mingw.

I'm pretty confident we have buildbots testing mingw. You should be able to add a test case under tests/tools/llvm-config and have REQUIRES: mingw32 in it.

Jan 17 2017, 2:00 PM
beanz added a comment to D28086: [CMake] Subsume LLVMBuild.txt. Disabled by default..

@bryant and I spoke over IRC in a PM, for posterity I'll recap here.

Jan 17 2017, 1:55 PM
beanz accepted D28821: [CMake] Separate LLVM_ENABLE_LTO and LLVM_ENABLE_LLD.

Many thanks for the quick cleanup! LGTM!

Jan 17 2017, 12:59 PM
beanz added inline comments to D26649: [CMake] Support lld with LTO bootstrap.
Jan 17 2017, 10:21 AM
beanz accepted D28730: [cmake] Update SOVERSION for the new versioning scheme.

LGTM.

Jan 17 2017, 10:09 AM