Page MenuHomePhabricator

beanz (Chris Bieneman)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2014, 4:35 PM (447 w, 5 d)

Recent Activity

Fri, Mar 10

beanz committed rGc3801568ef2b: [NFC] [CMake] Add misssing dependencies (authored by beanz).
[NFC] [CMake] Add misssing dependencies
Fri, Mar 10, 3:13 PM · Restricted Project, Restricted Project
beanz committed rG326c13531af3: [NFC] [CMake] Cleanup clang tool dependencies (authored by beanz).
[NFC] [CMake] Cleanup clang tool dependencies
Fri, Mar 10, 8:56 AM · Restricted Project, Restricted Project

Tue, Mar 7

beanz added inline comments to D145270: Add codegen for llvm exp/exp2 elementwise builtins.
Tue, Mar 7, 9:20 AM · Restricted Project, Restricted Project

Mon, Mar 6

beanz added inline comments to D144659: [DirectX backend] remove hlsl.* FnAttr after use..
Mon, Mar 6, 1:53 PM · Restricted Project, Restricted Project

Tue, Feb 21

beanz accepted D144526: [Test] Invoke GetErrcMessages from config-ix instead of llvm/CMakeLists.

LGTM

Tue, Feb 21, 3:57 PM · Restricted Project, Restricted Project

Mon, Feb 20

beanz accepted D144416: [STLExtras] Relax type requirements for `is_contained`.

LGTM. A very nice and useful improvement.

Mon, Feb 20, 11:31 AM · Restricted Project, Restricted Project

Feb 13 2023

beanz added a comment to D143468: [CMake] Remove custom ccache CMake logic.

I think getting rid of this option is good for us and our users in the long term.

Feb 13 2023, 10:32 AM · Restricted Project, Restricted Project, Restricted Project
beanz added inline comments to D143854: [DirectX backend] remove string function attribute and unused module flags.
Feb 13 2023, 8:29 AM · Restricted Project, Restricted Project

Feb 11 2023

beanz added a comment to D142279: [cmake] Use LLVM_ENABLE_ASSERTIONS to enable assertions in libstdc++.

LLVM’s C++ interfaces do not provide a stable ABI across all configuration flags (which is not uncommon for C++). As a result llvm-config and the LLVM CMake exports provide the options LLVM was built with for the user.

Feb 11 2023, 5:46 AM · Restricted Project, Restricted Project

Feb 7 2023

beanz added a comment to D143518: [DirectX backend] add pass to collect Resource information from dxil metadata..

I don't think this PR is correct. It seems like we should be able to ensure that the analysis result remains preserved after the metadata is generated allowing us to re-use the analysis result that was used to generate the metadata.

Feb 7 2023, 10:56 AM · Restricted Project, Restricted Project

Feb 6 2023

beanz added a comment to D142279: [cmake] Use LLVM_ENABLE_ASSERTIONS to enable assertions in libstdc++.

@beanz FYI - I think I heard you were a cmake expert!

Feb 6 2023, 10:05 AM · Restricted Project, Restricted Project

Feb 2 2023

beanz committed rGeba0bccf5af3: [DX] Speculative big endian fix (authored by beanz).
[DX] Speculative big endian fix
Feb 2 2023, 5:27 PM · Restricted Project, Restricted Project
beanz committed rG11d8f726d24d: [DX] Fix big-endian... again (authored by beanz).
[DX] Fix big-endian... again
Feb 2 2023, 4:22 PM · Restricted Project, Restricted Project
beanz committed rGdd3f7b02255a: [DX] Add support for PSV resource bindings (authored by beanz).
[DX] Add support for PSV resource bindings
Feb 2 2023, 2:51 PM · Restricted Project, Restricted Project
beanz closed D143130: [DX] Add support for PSV resource bindings.
Feb 2 2023, 2:50 PM · Restricted Project, Restricted Project
beanz accepted D143208: Repair sphinx doc generation.

LGTM

Feb 2 2023, 12:30 PM · Restricted Project, Restricted Project
beanz accepted D142404: [docs] Prefer setting LLVM_HOST_TRIPLE instead of LLVM_DEFAULT_TARGET_TRIPLE and LLVM_TARGET_ARCH.

LGTM

Feb 2 2023, 9:30 AM · Restricted Project, Restricted Project
beanz committed rGb505ef5e3eb9: [DX] Hopefully really fix the big endian bots (authored by beanz).
[DX] Hopefully really fix the big endian bots
Feb 2 2023, 6:14 AM · Restricted Project, Restricted Project

Feb 1 2023

beanz committed rGf8e783f16628: [DX] Speculative fix for big endian encoding (authored by beanz).
[DX] Speculative fix for big endian encoding
Feb 1 2023, 9:22 PM · Restricted Project, Restricted Project
beanz requested review of D143130: [DX] Add support for PSV resource bindings.
Feb 1 2023, 7:11 PM · Restricted Project, Restricted Project
beanz committed rGad93908e3b55: [DX] Begin adding support for pipeline state (authored by beanz).
[DX] Begin adding support for pipeline state
Feb 1 2023, 5:00 PM · Restricted Project, Restricted Project
beanz closed D141649: [DX] Begin adding support for pipeline state.
Feb 1 2023, 5:00 PM · Restricted Project, Restricted Project

Jan 31 2023

beanz accepted D140489: Add builtin_elementwise_log.

LGTM. This looks pretty straightforward and similar to other changes you've been making.

Jan 31 2023, 12:39 PM · Restricted Project, Restricted Project

Jan 27 2023

beanz added inline comments to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Jan 27 2023, 12:39 PM · Restricted Project, Restricted Project

Jan 26 2023

beanz accepted D142610: [CMake] Support undefined LLVM_NATIVE_ARCH in llvm_map_components_to_libnames()..

LGTM

Jan 26 2023, 8:06 AM · Restricted Project, Restricted Project
beanz added inline comments to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Jan 26 2023, 8:00 AM · Restricted Project, Restricted Project

Jan 25 2023

beanz updated subscribers of D142405: [CMake] Replace list(FIND) by if(IN_LIST) where index isn't used.

This doesn't affect us internally because we have cmake_minimum_required(VERSION 3.13.4), but should we add cmake_policy(SET CMP0057 NEW) to the exported files? Perhaps in a PUSH/POP?

Jan 25 2023, 5:16 PM · Restricted Project, Restricted Project

Jan 23 2023

beanz added inline comments to D142405: [CMake] Replace list(FIND) by if(IN_LIST) where index isn't used.
Jan 23 2023, 2:53 PM · Restricted Project, Restricted Project
beanz accepted D142405: [CMake] Replace list(FIND) by if(IN_LIST) where index isn't used.

LGTM. Thank you for the nice cleanup :D

Jan 23 2023, 2:44 PM · Restricted Project, Restricted Project
beanz added a comment to D96670: [CMake] Look up target subcomponents in LLVM_AVAILABLE_LIBS.

Yeah, I don't usually do this. But this has been sitting for a very long time with a couple of pings and no attention.

Jan 23 2023, 2:43 PM · Restricted Project, Restricted Project
beanz added a comment to D142404: [docs] Prefer setting LLVM_HOST_TRIPLE instead of LLVM_DEFAULT_TARGET_TRIPLE and LLVM_TARGET_ARCH.

No, here I disagree. LLVM_HOST_TRIPLE is documented as Host on which LLVM binaries will run, not as the host where I'm currently compiling it. We can easily infer the details of the OS where we're doing the build, but usually much less so for the cross target, where the cross compiled LLVM will run.

Jan 23 2023, 2:40 PM · Restricted Project, Restricted Project
beanz added a comment to D142404: [docs] Prefer setting LLVM_HOST_TRIPLE instead of LLVM_DEFAULT_TARGET_TRIPLE and LLVM_TARGET_ARCH.

Plus, since LLVM_TARGET_ARCH is the target to use for JIT generation, it essentially needs to be the same architecture as the host on which LLVM is going to run, so it can't really be set to a wildly different arch anyway?

Jan 23 2023, 2:32 PM · Restricted Project, Restricted Project
beanz added a comment to D142404: [docs] Prefer setting LLVM_HOST_TRIPLE instead of LLVM_DEFAULT_TARGET_TRIPLE and LLVM_TARGET_ARCH.

Neither the current doc, nor the proposed change are really always right, and they are doing different things.

Jan 23 2023, 2:22 PM · Restricted Project, Restricted Project
beanz accepted D142349: [docs] Add/update docs regarding LLVM_NATIVE_TOOL_DIR vs LLVM_TABLEGEN.

LGTM. Thank you for taking the time to update the docs!

Jan 23 2023, 1:36 PM · Restricted Project, Restricted Project
beanz accepted D142362: [cmake] Remove AddLLVMDefinitions.

LGTM.

Jan 23 2023, 1:32 PM · Restricted Project, Restricted Project
beanz accepted D140609: [bugpoint] Fix compilation of bugpoint-passes on Windows.

Yea, this makes sense for Windows. LGTM.

Jan 23 2023, 1:31 PM · Restricted Project, Restricted Project
beanz added inline comments to D142363: [cmake] Stop using add_definitions.
Jan 23 2023, 9:44 AM · Restricted Project, Restricted Project

Jan 22 2023

beanz added a comment to D96670: [CMake] Look up target subcomponents in LLVM_AVAILABLE_LIBS.

“I can’t find someone to review this so I’m just going to merge it” is not okay.

Jan 22 2023, 9:11 PM · Restricted Project, Restricted Project

Jan 20 2023

beanz updated the diff for D141649: [DX] Begin adding support for pipeline state.

A little bit of code cleanup. While working on the next patch in the series I refactored some of this code and thought I should just bring the refactoring back.

Jan 20 2023, 9:59 AM · Restricted Project, Restricted Project

Jan 18 2023

beanz added a comment to D136031: [DirectX backend] support ConstantBuffer to DXILResource.h.

@python3kgae, this change introduced a bunch of warning spew because it is using an API that was deprecated shortly before the change merged. Can you please address this?

Jan 18 2023, 9:49 AM · Restricted Project, Restricted Project, Restricted Project
beanz accepted D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR.

LGTM!

Jan 18 2023, 9:22 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 17 2023

beanz updated the diff for D141649: [DX] Begin adding support for pipeline state.

Adding Unused to VertexPSVInfo

Jan 17 2023, 9:53 AM · Restricted Project, Restricted Project
beanz added inline comments to D141649: [DX] Begin adding support for pipeline state.
Jan 17 2023, 9:53 AM · Restricted Project, Restricted Project
beanz added inline comments to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.
Jan 17 2023, 8:02 AM · Restricted Project, Restricted Project
beanz added a comment to D141705: [HLSL] [Dirver] add dxv as a Driver Action Job.

Re-using the VerifyDebug action really doesn't make sense. That's not what the DXIL validator does, and it will be a source of confusion forever.

Jan 17 2023, 7:59 AM · Restricted Project, Restricted Project

Jan 13 2023

beanz added a comment to D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR.

The convention that find_program uses is to cache the variables, which causes them to be defined at global scope. That also avoids needing to recompute filesystem lookups in incremental builds, which is desirable.

Jan 13 2023, 9:20 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
beanz added inline comments to D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR.
Jan 13 2023, 8:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
beanz added inline comments to D141417: [DirectX backend] emit metadata for DXIL version.
Jan 13 2023, 8:05 AM · Restricted Project, Restricted Project

Jan 12 2023

beanz added a comment to D141649: [DX] Begin adding support for pipeline state.

So no resource support in this PR?

Jan 12 2023, 9:26 PM · Restricted Project, Restricted Project
beanz requested review of D141649: [DX] Begin adding support for pipeline state.
Jan 12 2023, 7:04 PM · Restricted Project, Restricted Project
beanz added a comment to D141628: [DirectX backend] support empty program signature parts for compute shader.

All the other changes going into the DXContainer object and yaml support are aiming to be more full featured, and the object and yaml tooling changes are separate from the implementation change.

Jan 12 2023, 12:49 PM · Restricted Project, Restricted Project
beanz accepted D136031: [DirectX backend] support ConstantBuffer to DXILResource.h.

LGTM

Jan 12 2023, 6:40 AM · Restricted Project, Restricted Project, Restricted Project

Jan 9 2023

beanz accepted D141328: [DirectX backend] Remove unused bitcode block for dxil.

LGTM

Jan 9 2023, 3:06 PM · Restricted Project, Restricted Project
beanz accepted D141207: [DirectX backend] PartSize not include PartHeader.

LGTM

Jan 9 2023, 3:04 PM · Restricted Project, Restricted Project

Jan 3 2023

beanz added a comment to D136302: [DirectX backend] Support typed buffer load/store..

A few questions. Does this pass work with handles passed as parameters to functions? What about different functions that refer to the same global? Does that result in multiple createHandle calls?

Jan 3 2023, 1:53 PM · Restricted Project, Restricted Project
beanz added a comment to D136031: [DirectX backend] support ConstantBuffer to DXILResource.h.

It is probably worth adding some unit tests to test the CBufferDataLayout class.

Jan 3 2023, 12:07 PM · Restricted Project, Restricted Project, Restricted Project
beanz committed rG621ffbcbe4ab: [DX] Improve parse error messages (authored by beanz).
[DX] Improve parse error messages
Jan 3 2023, 10:50 AM · Restricted Project, Restricted Project
beanz closed D139681: [DX] Improve parse error messages.
Jan 3 2023, 10:50 AM · Restricted Project, Restricted Project
beanz committed rGa95717ef7197: [YAML] Support serializing MutableArrayRef (authored by beanz).
[YAML] Support serializing MutableArrayRef
Jan 3 2023, 10:29 AM · Restricted Project, Restricted Project
beanz closed D140427: [YAML] Support serializing MutableArrayRef.
Jan 3 2023, 10:29 AM · Restricted Project, Restricted Project

Dec 21 2022

beanz accepted D131807: [DIrectX backend] emit metadata for entry..

LGTM

Dec 21 2022, 11:36 AM · Restricted Project, Restricted Project

Dec 20 2022

beanz requested review of D140427: [YAML] Support serializing MutableArrayRef.
Dec 20 2022, 12:12 PM · Restricted Project, Restricted Project

Dec 15 2022

beanz added a comment to D131807: [DIrectX backend] emit metadata for entry..

You have some stub code in here to handle emitting shader flags, but the value is always set to 0 resulting in nothing being written and thus no tests.

Dec 15 2022, 9:17 AM · Restricted Project, Restricted Project

Dec 13 2022

beanz accepted D139765: [NFC] [DirectX backend] copy dxil-dis as exe file on windows.

LGTM

Dec 13 2022, 3:21 PM · Restricted Project, Restricted Project

Dec 9 2022

beanz added inline comments to D139765: [NFC] [DirectX backend] copy dxil-dis as exe file on windows.
Dec 9 2022, 8:50 PM · Restricted Project, Restricted Project
beanz added inline comments to rGcb088e8c3abf: Add more C99 DR test cases and update the status page.
Dec 9 2022, 11:27 AM · Restricted Project, Restricted Project
beanz committed rG2b405e7e049b: [NFC][DX] Update test case to use new opt flags (authored by beanz).
[NFC][DX] Update test case to use new opt flags
Dec 9 2022, 11:20 AM · Restricted Project, Restricted Project
beanz committed rG76fca14750e3: [NFC] Update DXContainer tests to use fake parts (authored by beanz).
[NFC] Update DXContainer tests to use fake parts
Dec 9 2022, 11:20 AM · Restricted Project, Restricted Project
beanz updated the diff for D139681: [DX] Improve parse error messages.

Updating based on PR feedback from bob80905. Thank you!

Dec 9 2022, 9:41 AM · Restricted Project, Restricted Project
beanz added inline comments to D139681: [DX] Improve parse error messages.
Dec 9 2022, 8:53 AM · Restricted Project, Restricted Project
beanz added a comment to D133379: [DL] Make vector ABI align bound by element align.

Sure -- but still the behavior on such cases should be clear, even if it is not relevant for DXIL. I just stumbled over the formulation

Dec 9 2022, 8:48 AM · Restricted Project, Restricted Project

Dec 8 2022

beanz requested review of D139681: [DX] Improve parse error messages.
Dec 8 2022, 4:26 PM · Restricted Project, Restricted Project
beanz added inline comments to rGcb088e8c3abf: Add more C99 DR test cases and update the status page.
Dec 8 2022, 3:29 PM · Restricted Project, Restricted Project

Dec 7 2022

beanz committed rGc861ea8736bd: Generate DXIL Shader hash (authored by beanz).
Generate DXIL Shader hash
Dec 7 2022, 1:26 PM · Restricted Project, Restricted Project
beanz closed D139357: Generate DXIL Shader hash.
Dec 7 2022, 1:26 PM · Restricted Project, Restricted Project

Dec 5 2022

beanz accepted D139137: add floor library function.

LGTM. @bob80905 if you haven't already, you should follow the steps here (https://www.llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access) to get commit access.

Dec 5 2022, 2:37 PM · Restricted Project, Restricted Project
beanz updated the diff for D139357: Generate DXIL Shader hash.

Need to byte-swap the hash structure on big endian hosts so that it is encoded as little-endian.

Dec 5 2022, 12:47 PM · Restricted Project, Restricted Project
beanz requested review of D139357: Generate DXIL Shader hash.
Dec 5 2022, 12:22 PM · Restricted Project, Restricted Project
beanz committed rGb4d711dc968c: Fix DirectX test build (authored by beanz).
Fix DirectX test build
Dec 5 2022, 11:13 AM · Restricted Project, Restricted Project
beanz added a comment to D133379: [DL] Make vector ABI align bound by element align.

How should this behave on overaligned element types? For example, with a i16:32 data layout (as in the old DXIL data layout),
the second element in <3 x i16> will not be 32-bit aligned, even if the vector is.

Dec 5 2022, 11:10 AM · Restricted Project, Restricted Project

Nov 21 2022

beanz added a comment to D138431: [DirectX] Fix shared libraries build.

I think I would broadly classify that there are two problems you're fixing here:
(1) Under-specified dependencies.
(2) A cyclic dependency on PointerTypeAnalysis

Nov 21 2022, 9:44 AM · Restricted Project, Restricted Project

Nov 14 2022

beanz accepted D137815: [DirectX backend] Fix build and test error caused by out of sync with upstream change..

LGTM

Nov 14 2022, 11:14 AM · Restricted Project, Restricted Project
beanz committed rG6111125d7344: [NFC] Fixing spelling in code comment (authored by beanz).
[NFC] Fixing spelling in code comment
Nov 14 2022, 8:29 AM · Restricted Project, Restricted Project

Nov 4 2022

beanz added inline comments to D135721: [HLSL] Added HLSL this as a reference.
Nov 4 2022, 11:52 AM · Restricted Project, Restricted Project

Nov 3 2022

beanz added inline comments to D135721: [HLSL] Added HLSL this as a reference.
Nov 3 2022, 12:58 PM · Restricted Project, Restricted Project

Oct 27 2022

beanz committed rG2556ba4a52ac: [ObjectYAML] Add support for DXContainer HASH (authored by beanz).
[ObjectYAML] Add support for DXContainer HASH
Oct 27 2022, 10:29 AM · Restricted Project, Restricted Project
beanz closed D136632: [ObjectYAML] Add support for DXContainer HASH.
Oct 27 2022, 10:28 AM · Restricted Project, Restricted Project

Oct 26 2022

beanz added a comment to D132413: [NFC] Make format() more amenable to format attributes.

Failing tests are from clangd and WebAssembly backend, which are not touched by this change.

Oct 26 2022, 12:26 PM · Restricted Project, Restricted Project

Oct 25 2022

beanz added inline comments to D136632: [ObjectYAML] Add support for DXContainer HASH.
Oct 25 2022, 2:35 PM · Restricted Project, Restricted Project
beanz added inline comments to D136632: [ObjectYAML] Add support for DXContainer HASH.
Oct 25 2022, 12:39 PM · Restricted Project, Restricted Project

Oct 24 2022

beanz requested review of D136632: [ObjectYAML] Add support for DXContainer HASH.
Oct 24 2022, 11:48 AM · Restricted Project, Restricted Project
beanz accepted D131545: [DirectX backend] set target triple to "dxil-ms-dx".

Please add a check line to the embed-dxil.ll test to verify that the triple is restored after embedding the DXIL global, otherwise LGTM.

Oct 24 2022, 9:06 AM · Restricted Project, Restricted Project

Oct 21 2022

beanz committed rG4c7218e77026: [HLSL] Remove unused frontend-generated ID (authored by beanz).
[HLSL] Remove unused frontend-generated ID
Oct 21 2022, 10:41 AM · Restricted Project, Restricted Project, Restricted Project
beanz closed D136271: [HLSL] Remove unused frontend-generated ID.
Oct 21 2022, 10:41 AM · Restricted Project, Restricted Project, Restricted Project

Oct 20 2022

beanz accepted D136134: [NFC] [DirectX backend] move ResourceClass into llvm..
Oct 20 2022, 11:18 AM · Restricted Project, Restricted Project, Restricted Project
beanz added inline comments to D136134: [NFC] [DirectX backend] move ResourceClass into llvm..
Oct 20 2022, 11:03 AM · Restricted Project, Restricted Project, Restricted Project
beanz added inline comments to D136134: [NFC] [DirectX backend] move ResourceClass into llvm..
Oct 20 2022, 9:31 AM · Restricted Project, Restricted Project, Restricted Project

Oct 19 2022

beanz committed rG262a3322b9e5: [NFC] Updating an incorrect code comment (authored by beanz).
[NFC] Updating an incorrect code comment
Oct 19 2022, 10:36 AM · Restricted Project, Restricted Project
beanz requested review of D136271: [HLSL] Remove unused frontend-generated ID.
Oct 19 2022, 10:34 AM · Restricted Project, Restricted Project, Restricted Project
beanz committed rG607be386e7ee: [DX] Fix missing preserved analysis (authored by beanz).
[DX] Fix missing preserved analysis
Oct 19 2022, 10:11 AM · Restricted Project, Restricted Project