- User Since
- Aug 20 2014, 4:35 PM (447 w, 5 d)
Fri, Mar 10
Tue, Mar 7
Mon, Mar 6
Tue, Feb 21
Mon, Feb 20
LGTM. A very nice and useful improvement.
Feb 13 2023
I think getting rid of this option is good for us and our users in the long term.
Feb 11 2023
LLVM’s C++ interfaces do not provide a stable ABI across all configuration flags (which is not uncommon for C++). As a result llvm-config and the LLVM CMake exports provide the options LLVM was built with for the user.
Feb 7 2023
I don't think this PR is correct. It seems like we should be able to ensure that the analysis result remains preserved after the metadata is generated allowing us to re-use the analysis result that was used to generate the metadata.
Feb 6 2023
Feb 2 2023
Feb 1 2023
Jan 31 2023
LGTM. This looks pretty straightforward and similar to other changes you've been making.
Jan 27 2023
Jan 26 2023
Jan 25 2023
Jan 23 2023
LGTM. Thank you for the nice cleanup :D
Neither the current doc, nor the proposed change are really always right, and they are doing different things.
LGTM. Thank you for taking the time to update the docs!
Yea, this makes sense for Windows. LGTM.
Jan 22 2023
“I can’t find someone to review this so I’m just going to merge it” is not okay.
Jan 20 2023
A little bit of code cleanup. While working on the next patch in the series I refactored some of this code and thought I should just bring the refactoring back.
Jan 18 2023
@python3kgae, this change introduced a bunch of warning spew because it is using an API that was deprecated shortly before the change merged. Can you please address this?
Jan 17 2023
Adding Unused to VertexPSVInfo
Re-using the VerifyDebug action really doesn't make sense. That's not what the DXIL validator does, and it will be a source of confusion forever.
Jan 13 2023
The convention that find_program uses is to cache the variables, which causes them to be defined at global scope. That also avoids needing to recompute filesystem lookups in incremental builds, which is desirable.
Jan 12 2023
All the other changes going into the DXContainer object and yaml support are aiming to be more full featured, and the object and yaml tooling changes are separate from the implementation change.
Jan 9 2023
Jan 3 2023
A few questions. Does this pass work with handles passed as parameters to functions? What about different functions that refer to the same global? Does that result in multiple createHandle calls?
It is probably worth adding some unit tests to test the CBufferDataLayout class.
Dec 21 2022
Dec 20 2022
Dec 15 2022
You have some stub code in here to handle emitting shader flags, but the value is always set to 0 resulting in nothing being written and thus no tests.
Dec 13 2022
Dec 9 2022
Updating based on PR feedback from bob80905. Thank you!
Dec 8 2022
Dec 7 2022
Dec 5 2022
LGTM. @bob80905 if you haven't already, you should follow the steps here (https://www.llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access) to get commit access.
Need to byte-swap the hash structure on big endian hosts so that it is encoded as little-endian.
Nov 21 2022
I think I would broadly classify that there are two problems you're fixing here:
(1) Under-specified dependencies.
(2) A cyclic dependency on PointerTypeAnalysis
Nov 14 2022
Nov 4 2022
Nov 3 2022
Oct 27 2022
Oct 26 2022
Oct 25 2022
Oct 24 2022
Please add a check line to the embed-dxil.ll test to verify that the triple is restored after embedding the DXIL global, otherwise LGTM.