beanz (Chris Bieneman)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2014, 4:35 PM (144 w, 1 d)

Recent Activity

Wed, May 10

beanz created D33048: [CMake] runtimes test targets need to depend on LLVM tools.
Wed, May 10, 9:09 AM

Mon, May 8

beanz accepted D32815: [clang-tidy][CMake] Make clang-tidy usable as distribution component.

Yep, this seems straight forward.

Mon, May 8, 7:51 PM · Restricted Project
beanz added a comment to D32734: [CMake][runtimes] Set default directory for runtime libraries.

What is the problem you're trying to solve here? This seems odd to me.

Mon, May 8, 1:24 PM
beanz added inline comments to D25886: [Test Suite] Properly respect --framework option.
Mon, May 8, 11:39 AM

Thu, Apr 27

beanz accepted D32603: Build the Apple-style stage2 with modules and full debug info.

SWEET! this is great to see! One small comment inline, otherwise LGTM.

Thu, Apr 27, 11:19 AM
beanz accepted D32600: Resurrect pselect MainLoop implementation.

This looks like a nice improvement. There are some formatting inconsistencies, can you run clang-format?

Thu, Apr 27, 11:02 AM

Apr 21 2017

beanz accepted D32357: Add more arguments to SocketAddress::GetAddressInfo.

This is awesome! Thanks!

Apr 21 2017, 2:06 PM

Apr 18 2017

beanz accepted D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM.

This looks good to me.

Apr 18 2017, 1:25 PM

Apr 17 2017

beanz added a comment to D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM.

Can you please move this check into HandleLLVMOptions.cmake? By putting it into a module that is vended as part of LLVM's packaging then LLVM subprojects can have consistent settings when building out-of-tree.

Apr 17 2017, 10:54 AM
beanz updated the diff for D31823: Update LLDB Host to support IPv6 over TCP.

Removing code I accidentally left in that was from debugging, and moving some duplicated code that @labath spotted out of the ifdef.

Apr 17 2017, 10:39 AM
beanz added inline comments to D32079: Ask Python where platform specific lib dir is..
Apr 17 2017, 10:31 AM
beanz updated the diff for D31823: Update LLDB Host to support IPv6 over TCP.

Updating patches to reflect feedback from zturner.

Apr 17 2017, 10:16 AM

Apr 14 2017

beanz updated the diff for D31823: Update LLDB Host to support IPv6 over TCP.

Updating to use MainLoop class, and refactor MainLoop class to operate on Windows.

Apr 14 2017, 3:39 PM

Apr 12 2017

beanz added a reviewer for D31823: Update LLDB Host to support IPv6 over TCP: clayborg.

Adding Greg to the reviewers list.

Apr 12 2017, 2:15 PM
beanz added a reviewer for D31824: Update DebugServer to support IPv6 over TCP: clayborg.

Adding Greg to the reviewers.

Apr 12 2017, 2:14 PM
beanz added inline comments to D31822: [NFC] Adding a new wrapper for getaddrinfo.
Apr 12 2017, 2:07 PM
beanz accepted D31985: Support: Add a VCSRevision.h header file..

LGTM.

Apr 12 2017, 1:43 PM
beanz accepted D31942: [CMake][runtimes] Use -nodefaultlibs for the runtimes build.

LGTM!

Apr 12 2017, 1:26 PM
beanz updated the diff for D31969: [CMake] Support generating Config.h.

Fixing up the include guard as per feedback from zturner, and fixing up an install logic error that I spoted.

Apr 12 2017, 1:24 PM
beanz added a comment to D31969: [CMake] Support generating Config.h.

My intention in this patch is not in any way to adversely impact the Xcode project, which is the supported and documented way to build LLDB on OS X (http://lldb.llvm.org/build.html#BuildingLldbOnMacOSX).

Apr 12 2017, 1:20 PM

Apr 11 2017

beanz updated the diff for D31969: [CMake] Support generating Config.h.

Updating the hard coded Config.h

Apr 11 2017, 6:47 PM
beanz updated the diff for D31969: [CMake] Support generating Config.h.

Actually uploading the updates this time...

Apr 11 2017, 6:36 PM
beanz updated the diff for D31969: [CMake] Support generating Config.h.
  • Fixing installation to make sure CMake always installs the generated Config.h
  • Removing LLDB_CONFIG_FCNTL_GETPATH_SUPPORTED becasue we really don't need it
Apr 11 2017, 6:35 PM
beanz created D31969: [CMake] Support generating Config.h.
Apr 11 2017, 6:19 PM
beanz added a comment to D31823: Update LLDB Host to support IPv6 over TCP.

@labath, I could adapt this into the MainLoop class, but I would actually want to change how that class hierarchy is implemented. Regardless of the event handling/polling model you use much of the code is identical between the classes. I'd rather get rid of MainLoopPosix and MainLoopBase and instead just implement a portable MainLoop class.

Apr 11 2017, 4:09 PM
beanz accepted D31858: Reland "[CMake][libunwind] Use -nodefaultlibs for CMake checks".

This looks good to me!

Apr 11 2017, 7:38 AM

Apr 7 2017

beanz updated the diff for D31824: Update DebugServer to support IPv6 over TCP.

Fixing a small bug parsing the command line arguments for IPv6 addresses.

Apr 7 2017, 12:23 PM
beanz created D31824: Update DebugServer to support IPv6 over TCP.
Apr 7 2017, 11:58 AM
beanz created D31823: Update LLDB Host to support IPv6 over TCP.
Apr 7 2017, 11:56 AM
beanz created D31822: [NFC] Adding a new wrapper for getaddrinfo.
Apr 7 2017, 11:55 AM
beanz added inline comments to D31696: Automatically add include-what-you-use for when building in tree.
Apr 7 2017, 11:54 AM
beanz accepted D31773: CMake: Move sphinx detection into AddSphinxTarget.cmake.

LGTM!

Apr 7 2017, 11:48 AM
beanz updated the diff for D31357: Support Unit Testing debugserver.

Fixing variable naming conventions

Apr 7 2017, 8:52 AM

Apr 6 2017

beanz added a comment to D31357: Support Unit Testing debugserver.

I will fix up the naming conventions. Switching back and forth between LLVM and LLDB conventions has done a number on my brain.

Apr 6 2017, 10:41 AM
beanz added a reviewer for D31357: Support Unit Testing debugserver: jingham.

Adding Jim as a reviewer.

Apr 6 2017, 8:24 AM
beanz updated the diff for D31357: Support Unit Testing debugserver.

Some cleanup to the test case:

Apr 6 2017, 8:22 AM

Apr 5 2017

beanz accepted D31639: [CMake][libcxxabi] Use -nodefaultlibs for CMake checks .

This looks reasonable to me.

Apr 5 2017, 2:01 PM
beanz accepted D31718: Disable the darwin_log tests as a category while we clean them up.

This seems like a reasonable workaround until we can figure out a better solution. Thanks Sean!

Apr 5 2017, 1:38 PM · Restricted Project
beanz added a comment to D31687: CMake: Fix sphinx build with standalone clang.

I think putting this into AddSphinxTarget.cmake would be a better way to handle it. Also I have one small inline comment.

Apr 5 2017, 1:13 PM

Apr 3 2017

beanz accepted D31447: [Driver] Add option to print the resource directory.

One minor nitpick on the test case, but otherwise this looks fine to me.

Apr 3 2017, 3:31 PM
beanz updated subscribers of D31367: Expression: add missing linkage to RuntimeDyld component.

@mgorny, because of differences in linker semantics between Darwin and ELF, I can't reproduce the failure you have locally. I think that the patch below works around it in a more-portable way.

Apr 3 2017, 3:27 PM · Restricted Project
beanz accepted D31617: [CMake][libcxx] Use builtins rather than gcc_s when compiler-rt is requested.

Looks reasonable to me.

Apr 3 2017, 3:11 PM
beanz accepted D30508: Align all scalar numbers to LLVM_YAML_IS_FLOW_SEQUENCE_VECTOR.

LGTM, sorry for the delay!

Apr 3 2017, 11:06 AM

Apr 2 2017

jdoerfert awarded D31570: Revert "Remove autoconf support" a Party Time token.
Apr 2 2017, 3:11 AM

Apr 1 2017

beanz created D31570: Revert "Remove autoconf support".
Apr 1 2017, 8:32 AM

Mar 30 2017

beanz added a comment to D31367: Expression: add missing linkage to RuntimeDyld component.

Please revert your patch. It is *not* the right solution and is masking underlying problems.

Mar 30 2017, 11:00 AM · Restricted Project
beanz added a comment to D31367: Expression: add missing linkage to RuntimeDyld component.

This is definitely not the right fix. Please revert.

Mar 30 2017, 10:06 AM · Restricted Project

Mar 29 2017

beanz accepted D30906: Revert r297545 - Revert r297516 - Respect CMAKE_INSTALL_MANDIR for sphinx generated manpages.

Looks reasonable to me. Thanks!

Mar 29 2017, 3:11 PM

Mar 28 2017

beanz accepted D31436: [yaml2obj] Enable and fix tests.

Thanks for catching this. I didn't even notice that I had written such bad tests!

Mar 28 2017, 3:18 PM
beanz added a comment to D31363: [libc++] Remove cmake glob for source files.

LLVM has a CMake module "LLVMProcessSources.cmake" which verifies that all source files are referenced in the CMakeLists file. Since it is part of the LLVM distributed modules, you can re-use it in libcxx.

Mar 28 2017, 11:06 AM
beanz added a comment to D30906: Revert r297545 - Revert r297516 - Respect CMAKE_INSTALL_MANDIR for sphinx generated manpages.

The one downside to this approach is that when you use an absolute path as the DESTINATION argument to install you can't change the install root without reconfiguring. When you use relative paths you can.

Mar 28 2017, 10:57 AM

Mar 27 2017

beanz updated the diff for D31357: Support Unit Testing debugserver.

Added a note to the unit test CMake file about why the tests are where they are. Generally we isolate debugserver from the rest of LLDB, and this comment explains the breach of isolation.

Mar 27 2017, 3:55 PM
beanz added a comment to D31357: Support Unit Testing debugserver.

@jingham I put the unit tests at the top because they depend on LLDB's Host library (at least the current tests do). I'm attempting to write tests which cover the socket communication between LLDB and debugserver by sending data between the two using each side of the API.

Mar 27 2017, 12:34 PM
beanz updated the diff for D31357: Support Unit Testing debugserver.

Fleshed out the unit test logic to be more meaningful.

Mar 27 2017, 12:17 PM

Mar 24 2017

beanz accepted D31356: [Support] Avoid concurrency hazard in signal handler registration.

LGTM.

Mar 24 2017, 4:38 PM
beanz added a comment to D31357: Support Unit Testing debugserver.

Xcode is pretty magic to me. I don't know how to do much of anything in it other than build. I think the right solution would be to take most of the source files out of the debugserver target and generate a static archive from them, then have debugserver and the debugserverTest target link the static archive.

Mar 24 2017, 4:23 PM
beanz created D31357: Support Unit Testing debugserver.
Mar 24 2017, 3:00 PM

Mar 22 2017

beanz accepted D30958: [CMake] Support building Fuchsia toolchain on Darwin.

Looks great!

Mar 22 2017, 1:30 PM

Mar 21 2017

beanz added inline comments to D30958: [CMake] Support building Fuchsia toolchain on Darwin.
Mar 21 2017, 3:56 PM
beanz accepted D30957: [CMake] Support single target builtins build on Darwin.

LGTM!

Mar 21 2017, 3:26 PM
beanz added a comment to D30957: [CMake] Support single target builtins build on Darwin.

One minor style comment, otherwise looks good to me.

Mar 21 2017, 10:50 AM
beanz accepted D31098: [compiler-rt] respect CMAKE_EXE_LINKER_FLAGS in compiler and library tests.

Cool! Seems to me like this patch addresses everyones issues, and I think the patch looks good. Thanks for iterating on this!

Mar 21 2017, 10:40 AM

Mar 20 2017

beanz added reviewers for D30904: Allow suppressing host and target info in VersionPrinter: beanz, bogner.
Mar 20 2017, 7:16 PM
beanz added a comment to D31098: [compiler-rt] respect CMAKE_EXE_LINKER_FLAGS in compiler and library tests.

@inglorion I believe the reason we had to set the policy to OLD is because the auto-passed variable masks the explicitly passed one in try_compile. If that is the case, we need the same change in the Darwin code path too.

Mar 20 2017, 3:45 PM
beanz added inline comments to D31098: [compiler-rt] respect CMAKE_EXE_LINKER_FLAGS in compiler and library tests.
Mar 20 2017, 3:25 PM
beanz added a comment to D31144: Respect cmake link flags when compiling test files.

This patch looks fine to me, however I'd like to see the resolution on D31098 before landing this. If we change the CMake policy CMP0056 to NEW, I think that will automatically address this issue resulting in us not needing this patch.

Mar 20 2017, 2:10 PM
beanz added a comment to D31098: [compiler-rt] respect CMAKE_EXE_LINKER_FLAGS in compiler and library tests.

@davidxl, do you recall how the failure that caused you to make the policy change exhibited itself? It seems to me like we were working around the behavior of the old policy setting by passing the linker options through manually. I wonder if the reason for the error was CMake masking those liker flags under the new policy.

Mar 20 2017, 2:06 PM
beanz accepted D31125: Fix evaluation of LLVM_DEFINITIONS.

This looks like a great cleanup. Thanks!

Mar 20 2017, 1:30 PM

Mar 17 2017

beanz accepted D31060: [CMake] Provide an option to disable runtimes build.

LGTM!

Mar 17 2017, 3:55 PM
beanz accepted D30997: CMake: Add LLVM_DYLIB_SYMBOL_VERSIONING option.

@mgorny, we should only support this on shared libraries that we intend as vended libraries, not all libraries. For example we don't really want to support the CMake BUILD_SHARED_LIBS option's libraries as vended libraries on any platform.

Mar 17 2017, 3:41 PM
beanz added inline comments to D30957: [CMake] Support single target builtins build on Darwin.
Mar 17 2017, 3:41 PM
beanz accepted D30911: [CMake] fix CLANG_INCLUDE_DIRS CMake export.

LGTM!

Mar 17 2017, 2:47 PM

Mar 14 2017

beanz accepted D28533: [llvm-config] Add minimal sanity tests for path options.

This is great, thanks!

Mar 14 2017, 3:32 PM
beanz accepted D29851: [clang-tools-extra] [test] Fix test dependencies when using installed tools.

Ugh... I really don't like how LLVM_UTILS_PROVIDED is implemented, but I guess it is fine. This patch is good.

Mar 14 2017, 3:32 PM · Restricted Project

Mar 13 2017

beanz updated the diff for D30918: [debugserver] This is a small cleanup patch to AVX support detection.

Forgot a semi-colon...

Mar 13 2017, 4:28 PM
beanz updated the diff for D30918: [debugserver] This is a small cleanup patch to AVX support detection.

Updates based on feedback from Jason and Zachary.

Mar 13 2017, 4:23 PM
beanz updated the diff for D30918: [debugserver] This is a small cleanup patch to AVX support detection.

Removing some extra changes that accidentally came along for the ride in my initial upload.

Mar 13 2017, 3:52 PM
beanz created D30918: [debugserver] This is a small cleanup patch to AVX support detection.
Mar 13 2017, 3:50 PM

Mar 7 2017

beanz accepted D30656: CMake: Don't install llvm-tblgen twice.

LGTM.

Mar 7 2017, 11:08 AM
beanz accepted D30470: [cmake] Include openmp with add_llvm_external_project.

This patch is fine, just be warned that eventually I really want to kill the projects subdirectory entirely.

Mar 7 2017, 10:47 AM

Mar 6 2017

beanz created D30666: [ObjectYAML] Add ability for DWARFYAML to calculate DIE lengths.
Mar 6 2017, 2:23 PM
beanz accepted D30655: CMake: Add LLVM_UTILS_INSTALL_DIR option.

LGTM!

Mar 6 2017, 10:14 AM

Mar 3 2017

beanz updated the diff for D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.

Updating to address Paul's feedback about DWARF32/DWARF64.

Mar 3 2017, 1:32 PM
beanz updated the diff for D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.

Updated based on feedback from Adrian.

Mar 3 2017, 9:48 AM
beanz added inline comments to D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Mar 3 2017, 8:47 AM

Mar 2 2017

beanz added inline comments to D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Mar 2 2017, 5:35 PM
beanz added inline comments to D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Mar 2 2017, 4:37 PM
beanz added inline comments to D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Mar 2 2017, 3:44 PM
beanz added inline comments to D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Mar 2 2017, 2:18 PM
beanz updated the diff for D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.

Updates based on feedback from Adrian.

Mar 2 2017, 1:25 PM
beanz added inline comments to D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Mar 2 2017, 1:04 PM

Mar 1 2017

beanz retitled D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code from [ObjectYAML] Add ability for DWARFYAML to calculate DIE lengths to [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Mar 1 2017, 3:45 PM
beanz updated the diff for D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
  • Reducing the patch to just the NFC changes
Mar 1 2017, 3:42 PM
beanz accepted D30092: CMake: Clean up VersionFromVCS.cmake.

LGTM!

Mar 1 2017, 1:31 PM

Feb 24 2017

beanz created D30357: [ObjectYAML] NFC. Refactor DWARFYAML CompileUnit dump code.
Feb 24 2017, 3:18 PM
beanz added a comment to D30346: [.gitignore] Update .gitignore to ignore a nested build directory.

This is for LLVM. Will land shortly.

Feb 24 2017, 11:26 AM
beanz created D30346: [.gitignore] Update .gitignore to ignore a nested build directory.
Feb 24 2017, 10:57 AM
beanz added a comment to D30266: Move Stream code from MSF -> Support.

This all looks pretty great to me.

Feb 24 2017, 10:07 AM

Feb 22 2017

beanz accepted D30275: Get the branch specifiers from a .json file rather than out of raw Python.

LGTM!

Feb 22 2017, 2:51 PM

Feb 17 2017

beanz added a comment to D30010: Improve the robustness of mmap.

Don't really have much to add here, but I really like what this is doing, and I think it will be a huge win for LLDB. Thanks @zturner!

Feb 17 2017, 3:36 PM